[webkit-reviews] review requested: [Bug 25884] WebKit needs a style linting tool : [Attachment 32444] Fix for lint errors v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 8 03:58:32 PDT 2009


Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32444: Fix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32444&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Ah, thanks for the comment! Yeah, of course, it is better to check this patch
in. I didn't flag '?' as I didn't confirm it could be compiled with Mac. Now I
confirmed it can be compiled and I fixed the style of cast. Could you land this
patch? I think it's good if you can check this in soon. Otherwise, you may see
a lot of conflicts as this patch changes many code.

By the way, the warning for C-style casts is another example of warnings I
disabled. It would be nice if we can discuss which rule is necessary for
WebKit. As I'm a newbie of WebKit, I know few undocumented customs.


More information about the webkit-reviews mailing list