[webkit-reviews] review requested: [Bug 27062] bugzilla-tool: post-commits should read bug id from commit log and actually work : [Attachment 32422] bugzilla-tool: post-commits should read bug id from commit log and actually work
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 7 19:25:36 PDT 2009
David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062
Attachment 32422: bugzilla-tool: post-commits should read bug id from
commit log and actually work
https://bugs.webkit.org/attachment.cgi?id=32422&action=review
------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).
* Scripts/bugzilla-tool:
(bug_id_from_commit_message): Added. Returns a bug id from the
commit log message, thus enforcing the need for a bug URL in the
message.
(PostCommitsAsPatchesToBug.__init__): Updated help description
to match new behavior of pulling bug ids from commit log
messages instead of from the command line.
(PostCommitsAsPatchesToBug.execute): Updated to use
bug_id_from_commit_message() to pull bug ids from commit log
messages. Also switched from SCM.create_patch() to use
SCM.create_patch_from_local_commit() to fix a bug where local
repository changes were posted as a patch instead of the
specific COMMITISH.
* Scripts/modules/bugzilla.py: Import datetime module.
(timestamp): Added. Returns a timestamp in the form of
"YYYYMMDDhhmmss".
(Bugzilla.add_patch_to_bug): Construct a more meaningful patch
file name using the bug_id and timestamp().
* Scripts/modules/scm.py:
(SCM.create_patch_from_local_commit): Added.
(Git.create_patch_from_local_commit): Added. Runs "git diff" to
return a patch for the given commit_id.
---
4 files changed, 70 insertions(+), 17 deletions(-)
More information about the webkit-reviews
mailing list