[webkit-reviews] review requested: [Bug 27051] Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled : [Attachment 32410] Code patch for Registerfile ccp and h

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 18:39:03 PDT 2009


Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27051: Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled
https://bugs.webkit.org/show_bug.cgi?id=27051

Attachment 32410: Code patch for Registerfile ccp and h
https://bugs.webkit.org/attachment.cgi?id=32410&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
RegisterFile constructor currently throws #error when both MMAP and
VIRTUALALLOC conditions fail.
On any platform that does not provide these features (for instance, Symbian),
the fallback should be regular malloc (or fastMalloc).
Memory allocation with fastMalloc functionally equivalent in this case, even
though it may have certain drawbacks such as lack of dynamic pre-allocation.

This should be the general, preferred way of fixing the issue, as opposed to
introducing conditional code block for platform Symbian.


More information about the webkit-reviews mailing list