[webkit-reviews] review denied: [Bug 27013] WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition for Windows : [Attachment 32399] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 16:28:13 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27013: WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle
definition for Windows
https://bugs.webkit.org/show_bug.cgi?id=27013

Attachment 32399: patch
https://bugs.webkit.org/attachment.cgi?id=32399&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
I'm concerned this may cause problems for the PLATFORM(QT) build.
I believe that in the PLATFORM(QT) builds on Windows, PLATFORM(WIN_OS)
will also be defined.

You may be able to avoid that problem by revising the #ifdefs to check
for PLATFORM(QT) before checking for PLATFORM(WIN_OS).

Also, the very last PLATFORM(WIN) in FileSystem.h might be best kept
as PLATFORM(WIN).  It looks like it is a declaration of additional
functions that perhaps only make sense in the PLATFORM(WIN) port
(i.e., Safari on Windows).


More information about the webkit-reviews mailing list