[webkit-reviews] review denied: [Bug 27007] Build fixes when ICONDATABASE is disabled : [Attachment 32396] Bug 27007: Build fixes when ICONDATABASE is disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 15:57:49 PDT 2009


Eric Seidel <eric at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32396:	  Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/attachment.cgi?id=32396&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems like the wrong patch.

re: this patch.  I like the ability to detect bug URLs in ChangeLogs, but I
don't think we should remove the ability to specify a bug?  Maybe we should...
I guess that forces folks to add the bug url to the ChangeLog?

Also the changelog greping code shoudl be in its own function.


More information about the webkit-reviews mailing list