[webkit-reviews] review granted: [Bug 27042] Incomplete painting of newly created floats : [Attachment 32393] Patch, including repaint tests

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 14:32:05 PDT 2009


Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 27042: Incomplete painting of newly created floats
https://bugs.webkit.org/show_bug.cgi?id=27042

Attachment 32393: Patch, including repaint tests
https://bugs.webkit.org/attachment.cgi?id=32393&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +	   for (size_t i = 0; i < floatCount; ++i) {
> +	       if (!floats[i].everHadLayout) {
> +		   RenderBox* f = floats[i].object;
> +		   if (!f->x() && !f->y() && f->checkForRepaintDuringLayout())

I have a preference for comparing with 0 for coordinates, but r=me


More information about the webkit-reviews mailing list