[webkit-reviews] review granted: [Bug 27035] [Chromium] Upstream DOMObjectsInclude.h : [Attachment 32387] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 13:18:49 PDT 2009


Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27035: [Chromium] Upstream DOMObjectsInclude.h
https://bugs.webkit.org/show_bug.cgi?id=27035

Attachment 32387: patch
https://bugs.webkit.org/attachment.cgi?id=32387&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/bindings/v8/DOMObjectsInclude.h

> + * this software without specific prior written permission.
> + * 

^^^ looks like there is an extra space at the end of that line.


> +#if ENABLE(DOM_STORAGE)
> +#include "Storage.h"
> +#include "StorageEvent.h"
> +#endif

^^^ should that have a "// STORAGE" comment like the others?


otherwise, R=me


More information about the webkit-reviews mailing list