[webkit-reviews] review requested: [Bug 26953] [V8] Do not do unnecessary handles casts and inline couple of methods : [Attachment 32384] Addressing Mads' comments

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 10:35:33 PDT 2009


anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32384: Addressing Mads' comments
https://bugs.webkit.org/attachment.cgi?id=32384&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Mads, thanks a lot for review!

I hope I addressed all your comments.  I don't know if we need this assert at
all, but I just don't want to touch it as my knowledge of bindings is currently
limited.  But if you all agree it should go away, I'd be more than happy to
remove it.

Sorry, original patch didn't compile cleanly in debug mode (some checks in
asserts), so I needed to through in some more changes, but of the similar
kind---don't downcast to v8::Value.

And I need a patch for webkit/glue part as well (sending it to you, guys).


More information about the webkit-reviews mailing list