[webkit-reviews] review requested: [Bug 27028] [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment 32376] Fix improper set of enum WebKitWebViewTargetInfo

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 06:54:36 PDT 2009


Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32376: Fix improper set of enum WebKitWebViewTargetInfo
https://bugs.webkit.org/attachment.cgi?id=32376&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
I use this Change:
> Index: WebCore/platform/gtk/PasteboardGtk.cpp
> ===================================================================
> --- WebCore/platform/gtk/PasteboardGtk.cpp	(revision 45546)
> +++ WebCore/platform/gtk/PasteboardGtk.cpp	(working copy)
> @@ -37,8 +38,8 @@ namespace WebCore {
>  /* FIXME: we must get rid of this and use the enum in webkitwebview.h
someway */
>  typedef enum
>  {
> -    WEBKIT_WEB_VIEW_TARGET_INFO_HTML = - 1,
> -    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT = - 2
> +    WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
> +    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT
>  } WebKitWebViewTargetInfo;
> 

it works.
it can use Ctrl-C to Copy rich text from WebkitGtk page now.


More information about the webkit-reviews mailing list