[webkit-reviews] review granted: [Bug 26791] [Gtk] Paste of rich text from firefox results garbled markup : [Attachment 32264] add a manual test in WebCore/manual-tests/gtk

[bugzilla-daemon at webkit.org]

Jan Alonzo <jmalonzo at gmail.com> has granted Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32264: add a manual test in WebCore/manual-tests/gtk
https://bugs.webkit.org/attachment.cgi?id=32264&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -	   String html = String::fromUTF8(reinterpret_cast<gchar*>(data->data),
data->length * data->format / 8);
> +	   String html;
> +	   RefPtr<TextResourceDecoder> decoder =
TextResourceDecoder::create("text/plain", "UTF-8", true);
> +	   html = decoder->decode(reinterpret_cast<char*>(data->data),
data->length);
> +	   html += decoder->flush();
>	   gtk_selection_data_free(data);

Declaration and the first assignment can be in the same line here. 

Looks fine and the patch works great! r=me.