[webkit-reviews] review denied: [Bug 26505] Value of file upload forms for non-multipart methods : [Attachment 32336] Proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jul 7 00:41:42 PDT 2009


Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32336: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32336&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your ChangeLog has boilerplate code in it.  Please read the boilerplate and act
on it.

This needs an automated test.  It's possible to test file drags and file
uploads using DumpRenderTree (at least on the mac).  Look at creating an http/
test which uses eventSender.beginDragWithFiles() you could also create a new
layoutTestController method which did fileObjectForPath() or similar if you
wanted to make test which didn't require drag and drop but still used File
objects.


More information about the webkit-reviews mailing list