[webkit-reviews] review denied: [Bug 26962] [V8] Move some simple utility functions in V8Proxy to V8Utilities : [Attachment 32294] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jul 7 00:17:36 PDT 2009
Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26962: [V8] Move some simple utility functions in V8Proxy to V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=26962
Attachment 32294: patch
https://bugs.webkit.org/attachment.cgi?id=32294&action=edit
------- Additional Comments from Eric Seidel <eric at webkit.org>
Your comment format is a bit strange. I would not have added all the crazy
//////.
It would make sense to me to describe each of these new classes some, more than
just putting their names there.
// Move to V8Constants, a class to hold all the constants used by V8?
// Move to V8EventListener, a subclass of EventListener with v8 specific
methods.
More information about the webkit-reviews
mailing list