[webkit-reviews] review granted: [Bug 27017] In the nitro-extreme branch, remove constants from the register file. : [Attachment 32353] The patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Jul 6 20:15:07 PDT 2009
Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27017: In the nitro-extreme branch, remove constants from the register
file.
https://bugs.webkit.org/show_bug.cgi?id=27017
Attachment 32353: The patch
https://bugs.webkit.org/attachment.cgi?id=32353&action=edit
------- Additional Comments from Sam Weinig <sam at webkit.org>
r=me
Can this be a static const instead of a #define. How about a comment
explaining the magic number?
> +#define FirstConstantRegisterIndex 0x40000000
More information about the webkit-reviews
mailing list