[webkit-reviews] review canceled: [Bug 26963] Reproducible crash at FontCache::getFontData() when a custom font is used in a pseudo-style : [Attachment 32328] Validate the pseudo-style cache on style recalc

[bugzilla-daemon at webkit.org]

mitz at webkit.org has canceled mitz at webkit.org's request for review:
Bug 26963: Reproducible crash at FontCache::getFontData() when a custom font is
used in a pseudo-style
https://bugs.webkit.org/show_bug.cgi?id=26963

Attachment 32328: Validate the pseudo-style cache on style recalc
https://bugs.webkit.org/attachment.cgi?id=32328&action=edit

------- Additional Comments from mitz at webkit.org
(In reply to comment #6)
> (From update of attachment 32328 [details])
> I'm concerned about the addition of the new firstLineStyle method to
> RenderObject.  It seems like that is going to be confusing next to the other
> first line style method.

I will try to come up with a more descriptive/discouraging name.

> Would it be cleaner to just build this pseudo style comparison into the diff
> method?

I’ll try that and see where I get stuck :-)

Thanks for the review!