[webkit-reviews] review denied: [Bug 27015] CSS properties such as color: and font-size: may be applied applied to the Media Controller text. : [Attachment 32335] patch v1.

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32335: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32335&action=edit

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
>     WebCore:
>     
>     2009-07-06  Pierre d'Herbemont  <pdherbemont at apple.com>
>     
>	      Reviewed by NOBODY (OOPS!).
>     
>	      Make sure the media controller style is not overrided.

This is too vague, and not actually correct. You need to take care that your
changelogs are very explicit about the changes being made, and that they make
sense to someone who is not familiar with the code.

>     
>	      This is only for QT mode. And this mostly affects text

What is QT mode (for someone not familiar)?

>	      properties.
>     
>	      There is a special case for text-decoration that can't
>	      be overrided from CSS. In this case we just
>	      force it from the code.

Where is the changelog file entry for this? In cases like this, it's good to
annotate the individual file changes one by one.

I'm going to be a hard-ass and r- this to give you some changelog-writing
practice.  :)