[webkit-reviews] review denied: [Bug 26829] add methods baselinePosition and lineHeight to InlineBox : [Attachment 32289] patch: removed unrelated code change from initial patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 16:30:53 PDT 2009


Eric Seidel <eric at webkit.org> has denied  review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32289: patch: removed unrelated code change from initial patch
https://bugs.webkit.org/attachment.cgi?id=32289&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/rendering/InlineBox.h
Hunk #1 succeeded at 205 (offset 4 lines).
Hunk #2 FAILED at 283.
1 out of 2 hunks FAILED -- saving rejects to file
WebCore/rendering/InlineBox.h.rej
patch -p0 "WebCore/rendering/InlineBox.h" returned 1.  Pass --force to ignore
patch failures.
Patch https://bugs.webkit.org/attachment.cgi?id=32289 failed to download and
apply.


More information about the webkit-reviews mailing list