[webkit-reviews] review requested: [Bug 26821] REGRESSION(r45285): focus rings are black on windows safari : [Attachment 32330] patch, without global initializers, compiles on mac and win

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 15:01:29 PDT 2009


Alice Liu <alice.liu at apple.com> has asked  for review:
Bug 26821: REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821

Attachment 32330: patch, without global initializers, compiles on mac and win
https://bugs.webkit.org/attachment.cgi?id=32330&action=edit

------- Additional Comments from Alice Liu <alice.liu at apple.com>
I did consider making platformFocusRingColor pure virtual, but doing it that
way would have required RenderThemeWin to provide an implementation, and i
wasn't convinced that providing an invalid or black color there would have
better than providing an invalid or black color in
RenderTheme::platformFocusRingColor along with the possible confusion about why
RenderThemeWin isn't appearing to provide an aqua-looking color.  In this patch
I did change to black as you suggested.


More information about the webkit-reviews mailing list