[webkit-reviews] review requested: [Bug 27001] Fix improper use of PassRefPtr<Node> to RefPtr<Node> : [Attachment 32318] Patch v1

[bugzilla-daemon at webkit.org]

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27001: Fix improper use of PassRefPtr<Node> to RefPtr<Node>
https://bugs.webkit.org/show_bug.cgi?id=27001

Attachment 32318: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32318&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Fix improper use of PassRefPtr<Node> to RefPtr<Node>

Reviewed by NOBODY (OOPS!).

PassRefPtr<> should only be used for arguments to functions that take ownership
of the object, or as return values from functions that relinquish ownership of
the object.

* editing/Editor.cpp:
(WebCore::Editor::increaseSelectionListLevelOrdered): Changed stack-allocated
PassRefPtr<Node> to RefPtr<Node> and call release() on returned object to
prevent ref count churn.
(WebCore::Editor::increaseSelectionListLevelUnordered): Ditto.