[webkit-reviews] review granted: [Bug 26998] Decommitted spans are added to the list of normal spans rather than the returned spans in TCMalloc_PageHeap::Delete() : [Attachment 32314] Prepend the span to the returned list if it is decommitted.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 13:53:13 PDT 2009


Darin Adler <darin at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 26998: Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete()
https://bugs.webkit.org/show_bug.cgi?id=26998

Attachment 32314: Prepend the span to the returned list if it is decommitted.
https://bugs.webkit.org/attachment.cgi?id=32314&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I noticed this comment in that function:

  // Note that the spans we merge into "span" may come out of
  // a "returned" list.  For simplicity, we move these into the
  // "normal" list of the appropriate size class.

Maybe you should change it?

r=me


More information about the webkit-reviews mailing list