[webkit-reviews] review granted: [Bug 25072] CSS21 attribute selectors not dynamic for xml : [Attachment 32241] New patch with more refactoring

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jul 6 13:38:25 PDT 2009


Dave Hyatt <hyatt at apple.com> has granted Kai Brüning <kai at granus.net>'s request
for review:
Bug 25072: CSS21 attribute selectors not dynamic for xml
https://bugs.webkit.org/show_bug.cgi?id=25072

Attachment 32241: New patch with more refactoring
https://bugs.webkit.org/attachment.cgi?id=32241&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This is fine... I dislike the name "otherUpdateAfterAttributeChanged."	I think
you could just drop "other" and call it "updateAfterAttributeChanged."

With that name change, r=me. If you don't have commit privs, you can attach a
new patch with the name change (or whoever lands it can make the change).


More information about the webkit-reviews mailing list