[webkit-reviews] review denied: [Bug 26848] [Qt] ResourceHandle::willLoadFromCache needs to be implmeneted QtWebKit. : [Attachment 32079] Implement willLoadFromCache for QtWebKit.

[bugzilla-daemon at webkit.org]

Holger Freyther <zecke at selfish.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 26848: [Qt] ResourceHandle::willLoadFromCache needs to be implmeneted
QtWebKit.
https://bugs.webkit.org/show_bug.cgi?id=26848

Attachment 32079: Implement willLoadFromCache for QtWebKit.
https://bugs.webkit.org/attachment.cgi?id=32079&action=edit

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> -bool ResourceHandle::willLoadFromCache(ResourceRequest& request)
> +bool ResourceHandle::willLoadFromCache(ResourceRequest& request, Frame*
frame)

this will break the mac build... remove the unused parameter


> +#if QT_VERSION >= 0x040400
> +    QNetworkAccessManager* manager =
QWebFramePrivate::kit(frame)->page()->networkAccessManager();
> +    QAbstractNetworkCache* cache = manager->cache();


this will not work on Qt4.4... the cache got added in Qt 4.5...

please revise the patch, it looks good otherwise!