[webkit-reviews] review granted: [Bug 20342] REGRESSION: fast/dom/cssTarget-crash.html fails : [Attachment 32285] patch 0.2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 5 21:55:18 PDT 2009


Darin Adler <darin at apple.com> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 20342: REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Attachment 32285: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=32285&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
http://trac.webkit.org/changeset/40475 moved the setCSSTarget call from
Node::removedFromDocument into ContainerNode::removedFromDocument. But that
wasn't when this bug was introduced.

It was introduced by a bad merge back in
http://trac.webkit.org/changeset/40499. The right fix is to add the code back,
but to add it back to ContainerNode::removedFromDocument, not
Node::removedFromDocument.

I'll take care of this.


More information about the webkit-reviews mailing list