[webkit-reviews] review granted: [Bug 26778] Inspector: Duplicate Computation in Autocompletion : [Attachment 31985] Removed Duplicate Computation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jul 5 04:26:47 PDT 2009


Maciej Stachowiak <mjs at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 26778: Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778

Attachment 31985: Removed Duplicate Computation
https://bugs.webkit.org/attachment.cgi?id=31985&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks good to me. I am surprised at the duplication but it certainly looks like
the passed in originalWordPrefixRange is computed in an identical way, and
can't have changed by the time _completionsReady is reached.


More information about the webkit-reviews mailing list