[webkit-reviews] review granted: [Bug 26957] RegExp::match to be optimized : [Attachment 32246] the patch

[bugzilla-daemon at webkit.org]

Maciej Stachowiak <mjs at apple.com> has granted George Staikos
<staikos at kde.org>'s request for review:
Bug 26957: RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957

Attachment 32246: the patch
https://bugs.webkit.org/attachment.cgi?id=32246&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Thanks for the patch! Looks like a good fix. On Mac OS X, this gives a 5%
speedup on string-unpack code and smaller speedups on the other string tests,
for an overall benefit of around 0.3% to SunSpider overall (some tests seem to
slow down a bit but this appears to be noise). This patch doesn't handle the
YARR case, I went ahead and filled that in and will post the revised patch in
addition to commiting it. Also this patch was missing a ChangeLog.