[webkit-reviews] review canceled: [Bug 25072] CSS21 attribute selectors not dynamic for xml : [Attachment 30768] Updated patch and test case

[bugzilla-daemon at webkit.org]

Kai Brüning <kai at granus.net> has canceled Kai Brüning <kai at granus.net>'s
request for review:
Bug 25072: CSS21 attribute selectors not dynamic for xml
https://bugs.webkit.org/show_bug.cgi?id=25072

Attachment 30768: Updated patch and test case
https://bugs.webkit.org/attachment.cgi?id=30768&action=edit

------- Additional Comments from Kai Brüning <kai at granus.net>
I reworked the patch with a little refactoring of
StyledElement::attributeChanged() and Element::attributeChanged(). Now there
are no longer additional virtual function calls beyond the necessary.

Notes:
- The new function Element::recalcStyleIfNeededAfterAttributeChanged() would be
a candidate for inlining, but it can’t be inlined in Element.h without adding
include files.

- Element::recalcStyleIfNeededAfterAttributeChanged() uses document() instead
of ownerdocument() as StyledElement::attributeChanged() used to do. As far as I
can see this is completely safe in this case and faster, too. Please double
check, though.