[webkit-reviews] review denied: [Bug 26262] Implement HTML5 draggable : [Attachment 32215] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jul 3 00:57:06 PDT 2009


Maciej Stachowiak <mjs at apple.com> has denied Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32215: Patch
https://bugs.webkit.org/attachment.cgi?id=32215&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Hyatt confirms that "draggable" should be implemented in code via
parseMappedAttribute rather than in the UA stylesheet, because in our CSS
implementation it's fairly inefficient to have an attribute selector that's not
scoped to particular tags. I believe HTMLElement::parseMappedAttribute would be
the right place.

r- to fix this, patch otherwise looks good to me.


More information about the webkit-reviews mailing list