[webkit-reviews] review granted: [Bug 26932] Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment 32218] Patch addressing Levin's comments

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32218: Patch addressing Levin's comments
https://bugs.webkit.org/attachment.cgi?id=32218&action=edit

------- Additional Comments from David Levin <levin at chromium.org>
This looks great.  This could be landed as is (if possible to address the nits
it would be great -- but it could be landed as is).


> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   * bindings/js/JSEventTarget.cpp:
> +	   (WebCore::toJS):
> +	   (WebCore::toEventTarget):
> +	   Added support for converting to/from AbstractWorkers.
> +	   * bindings/js/JSSharedWorkerConstructor.cpp: Added.
> +	  (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):

This one got out of place by one space.

> +	   (WebCore::CALLBACK_FUNC_DECL):
> +	   Custom constructor for SharedWorker.
> +	  * dom/EventTarget.cpp:

This one got out of place by one space.

> diff --git a/WebCore/bindings/js/JSEventTarget.cpp
b/WebCore/bindings/js/JSEventTarget.cpp

> +#if ENABLE(SHARED_WORKERS)
> +#include "JSAbstractWorker.h"
> +#include "AbstractWorker.h"

Nice to sort these.

> diff --git a/WebCore/workers/AbstractWorker.cpp
b/WebCore/workers/AbstractWorker.cpp
> +#endif  // ENABLE(SHARED_WORKERS)

Only one space before end of line comments.