[webkit-reviews] review granted: [Bug 26913] bugzilla-tool needs to handle login failure : [Attachment 32204] patch

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26913: bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913

Attachment 32204: patch
https://bugs.webkit.org/attachment.cgi?id=32204&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKitTools/Scripts/modules/bugzilla.py
b/WebKitTools/Scripts/modules/bugzilla.py
> +	   match = re.search("<title>(.+)</title>", response.read())

You could do a non-greedy match here like this "<title>(.+?)</title>" (which
would be more typical for grabbing the context of just one tag) but it isn't
necessary here.