[webkit-reviews] review denied: [Bug 26857] [Chromium] Upstream V8Binding : [Attachment 32198] patch4

[bugzilla-daemon at webkit.org]

David Levin <levin at chromium.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32198: patch4
https://bugs.webkit.org/attachment.cgi?id=32198&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few last things to address:

> Index: WebCore/bindings/v8/V8Binding.cpp
> +class WebCoreStringResource : public v8::String::ExternalStringResource {
> +public:
> +    explicit WebCoreStringResource(const String& string)
> +	   : m_impl(string.impl()) { }

The { } should go on separate lines (since you have initializers).


> +String v8StringToWebCoreString(v8::Handle<v8::String> v8String, bool
externalize)
> +{
...
> +
> +    int length = v8String->Length();
> +    if (length) {

if (!length)



> +String v8ValueToWebCoreString(v8::Handle<v8::Value> object)
> +{
...
> +	   return webCoreString;
> +    } else {

This else should go away since there is a "return" finishing the previous
block.