[webkit-reviews] review granted: [Bug 26935] [Chromium] Linux: fix complex text rendering with line break characters : [Attachment 32200] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jul 2 14:53:51 PDT 2009


Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 26935: [Chromium] Linux: fix complex text rendering with line break
characters
https://bugs.webkit.org/show_bug.cgi?id=26935

Attachment 32200: patch
https://bugs.webkit.org/attachment.cgi?id=32200&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yay for nice ChangeLogs! :)

I believe the { goes on the same line as the enum:
+enum
+{

Nice use of self-documenting constants, btw. :)

Looks fine. I'll ask you in person to make sure we're doing this in a similar
manner to the other complex text paths (which I know have similar code).


More information about the webkit-reviews mailing list