[webkit-reviews] review denied: [Bug 26620] Haiku WebKit port : [Attachment 32054] Patch to add Haiku-specific files for WebCore/platform/text/.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jul 2 14:40:13 PDT 2009
Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620
Attachment 32054: Patch to add Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/attachment.cgi?id=32054&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems you might want a notImplemnted() at:
+const char* currentTextBreakLocaleID()
Again, don't need:
+ WARNING: NO TEST CASES ADDED OR CHANGED
Since someone would have to manually fix your ChangeLogs, gonna r- this.
More information about the webkit-reviews
mailing list