[webkit-reviews] review granted: [Bug 26457] Build DumpRenderTree under Cairo : [Attachment 32190] Revised per Adam's comments (better).

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32190: Revised per Adam's comments (better).
https://bugs.webkit.org/attachment.cgi?id=32190&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
There's a newer version of the license header in
WebCore/html/PreloadScanner.cpp. Please use that template for new files.

> +	   * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
> +	     common pringPNG function.

Typo: pringPNG

> +    printPNG (dataLength, data);

Please remove the space after "printPNG".

> +typedef struct _cairo* CairoContextRef;

I thought there was a cairo_t typedef. Maybe there's some reason we can't use
that name here.

> +    BitmapContext(PlatformBitmapBuffer buffer, CairoContextRef context)
> +	   : m_buffer(buffer)
> +	   , m_context(context)
> +    {
> +    }
> +
> +    PlatformBitmapBuffer m_buffer;
> +    CairoContextRef m_context;

Do we need to retain/release m_context (using the appropriate Cairo functions)?


r=me