[webkit-reviews] review requested: [Bug 26490] Add isFinite method to floating point types. : [Attachment 32185] Add 'isFinite' operator to floating point types

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 26490: Add isFinite method to floating point types.
https://bugs.webkit.org/show_bug.cgi?id=26490

Attachment 32185: Add 'isFinite' operator to floating point types
https://bugs.webkit.org/attachment.cgi?id=32185&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
I put this patch together and realized the only place it's really useful (so
far) is in the ImageCairo.cpp file.  Is this change really worth it?

I didn't bother writing changelog, etc., since it seems like the patch is sort
of useless unless several routines are changed from using sets of bare
float/double values to the corresponding WebKit types.

Examples:
(1)  html/CanvasRenderingContext2D.cpp is passed the individual ordinates as
separate values (rather than as a single WebKit type) that are then tested for
finite-ness.
(2) page/DOMWindow.cpp tests for 'isfinite' in separate ASSERTs, but I don't
think the code is helped by using a WebKit type check here, as it would lose
the ability to see which ASSERT is failing.