[webkit-reviews] review denied: [Bug 26054] Need a new abstraction layer between the DB classes and the file system : [Attachment 32148] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jul 1 15:35:19 PDT 2009


Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32148: patch
https://bugs.webkit.org/attachment.cgi?id=32148&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Just one more thing! I promise!

> +	    SQLiteFileSystem::deleteDatabaseFile(trackerDatabasePath());
> +	   
SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_databaseDirectoryPath);

4 spaces?


More information about the webkit-reviews mailing list