[webkit-reviews] review granted: [Bug 26692] prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or REAL_NAME : [Attachment 32144] Now with more sanity checking

[bugzilla-daemon at webkit.org]

Adam Roben (aroben) <aroben at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 26692: prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or
REAL_NAME
https://bugs.webkit.org/show_bug.cgi?id=26692

Attachment 32144: Now with more sanity checking
https://bugs.webkit.org/attachment.cgi?id=32144&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> @@ -94,6 +96,8 @@ sub normalizePath($);
>  # Project time zone for Cupertino, CA, US
>  my $changeLogTimeZone = "PST8PDT";
>  
> +my $name;
> +my $email_address;
>  my $gitCommit = 0;
>  my $gitIndex = "";

You've been infected (cleansed?) by Python. Please use interCaps for variable
names.

r=me