[webkit-reviews] review granted: [Bug 26906] [Qt] Prevent Javascript object from being initialized when JavascriptEnabled is false : [Attachment 32147] Updated to be page-specific

[bugzilla-daemon at webkit.org]

Adam Treat <treat at kde.org> has granted robert <robert at roberthogan.net>'s
request for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32147: Updated to be page-specific
https://bugs.webkit.org/attachment.cgi?id=32147&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +    If QWebSettings::JavascriptEnabled is false, this function does nothing.


How about, "If JavaScript is not enabled for this page, then this function does
nothing."

> +2009-06-30  Robert Hogan <robert at roberthogan.net>
> +
> +	   Reviewed by NOBODY.
> +	   
> +	   Fix Qt segfault when javascript disabled.

Please put the URL in the ChangeLog.

With those changes r=me.