[webkit-reviews] review denied: [Bug 26054] Need a new abstraction layer between the DB classes and the file system : [Attachment 32139] final version

[bugzilla-daemon at webkit.org]

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied 's request for
review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32139: final version
https://bugs.webkit.org/attachment.cgi?id=32139&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>

> +String SQLiteFileSystem::getFileNameForNewDatabase(const String& dbDir,
const String& dbName,
> +						      const String&
originIdentifier, SQLiteDatabase* db)
> +{

> +    // dbName and originIdentifier not used in the default WebKit
implementation
> +    // touch them so gcc doesn't complain about that when building on Mac
> +    String unused = dbName;
> +    unused = originIdentifier;

Oops, this is wrong. Let's not create more work. You can just do:

String SQLiteFileSystem::getFileNameForNewDatabase(const String& dbDir, const
String&, const String&, SQLiteDatabase* db)