From bugzilla-daemon at webkit.org  Wed Jul  1 00:00:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 00:00:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26088] large negative
	letter-spacing crashes the chromium port : [Attachment 32025]
	revised patch w/ brett's improvements
Message-ID: <20090701070058.B81B03150A9C@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 26088: large negative letter-spacing crashes the chromium port
https://bugs.webkit.org/show_bug.cgi?id=26088

Attachment 32025: revised patch w/ brett's improvements
https://bugs.webkit.org/attachment.cgi?id=32025&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   Fix bug #26088 - TransparencyWin doesn't handle errors well at all;
> +	   revise it to fail silently (drawing nothing).

nit: please include an URL to this bug report in the ChangeLog.  (that is what
is normally done since it makes it easy to visit the bug from the trac log.)

It looks like this patch is trying to handle out-of-memory errors for small
fixed-size allocations.  That is something we normally do not do since if we
cannot allocate a few bytes, then we are happy to crash.

Handling out-of-memory cases that result from web content, where web content
has control over the allocation size, is another story.


> Index: WebCore/platform/graphics/chromium/FontChromiumWin.cpp
> ===================================================================
> --- WebCore/platform/graphics/chromium/FontChromiumWin.cpp	(revision
45284)
> +++ WebCore/platform/graphics/chromium/FontChromiumWin.cpp	(working copy)
> @@ -149,14 +149,16 @@ void TransparencyAwareFontPainter::initi
>      m_transparency.init(m_graphicsContext, layerMode,
TransparencyWin::KeepTransform, layerRect);
>  
>      // Set up the DC, using the one from the transparency helper.
> +    if (m_transparency.platformContext()) {

This looks like it is checking out-of-memory.  Why do we need to recover from
this condition?  Was this case being hit by those webkit tests?


> +	       
> +	       // webkit bug 26088 - very large positive or negative runs can
fail
> +	       // to render so we clamp the size here. In the specs, negative 
> +	       // letter-spacing is implementation-defined, so this should be 
> +	       // fine, and it matches Safari's implementation. The call
actually
> +	       // seems to crash if kMaxNegativeRun is set to somewhere around 

> +	       // -32830, so we give ourselves a little breathing room.
> +	       const int kMaxNegativeRun = -32768;
> +	       const int kMaxPositiveRun =  32768;

webkit style is to not have the "k" prefix.  you should just use regular
variable naming style for constants.


> +	       if ((curWidth + advances[i] < kMaxNegativeRun)
> +		|| (curWidth + advances[i] > kMaxPositiveRun)) 

nit: indentation is 4 white spaces.  i know this means that the two
lines will not line-up as you desire, but that's what webkit style
calls for.  (normally, people would not wrap this line.)


> Index: WebCore/platform/graphics/chromium/TransparencyWin.h
...
> +    PlatformGraphicsContext* platformContext() const { return m_drawContext
? m_drawContext->platformContext() : 0; }

Is this really worth null checking?


> Index:
LayoutTests/fast/text/text-large-negative-letter-spacing-with-opacity.html
...
> +<p>Test case for 
> +<a href="https://bugs.webkit.org/show_bug.cgi?id=26088" 
> +   >https://bugs.webkit.org/show_bug.cgi?id=26088</a>, 
> +which would crash the chromium port. If the browser does not crash, you
should
> +see an partially-transparent "world" on the next line.</p>
> +<p style="opacity: 0.5"><span style="letter-spacing: -1000em" 
> +  >Hello</span>world</p>

layout tests that verify crash fixes should use dumpAsText since there is no
need for pixel comparisons.


> Index: LayoutTests/fast/text/text-letter-spacing.html
...
> +which are explicitly implementation-dependent. Different browsers will
> +render these differently, but Chromium and Safari are attempting to be
> +the same.</p>

It seems a bit presumptuous to state what Safari is trying to do.  It is
probably better to just say WebKit here instead of calling out particular
WebKit-based apps especially since the claim is that those apps behave
the same way.

From bugzilla-daemon at webkit.org  Wed Jul  1 00:27:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 00:27:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26838] Multithread support
	for JSC on UNIX : [Attachment 32117]
	WebKit-r45374-Collector-multithread-support-for-UNIX.diff
Message-ID: <20090701072758.E6FA83151401@gamma.macosforge.org>

Martin Zoubek <martin.zoubek at acision.com> has asked  for review:
Bug 26838: Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838

Attachment 32117: WebKit-r45374-Collector-multithread-support-for-UNIX.diff
https://bugs.webkit.org/attachment.cgi?id=32117&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 06:16:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 06:16:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26699] [Win] HTML5 Drag and
	drop,
	dragend is not fired when pressing Esc :  [Attachment 32104] Patch
Message-ID: <20090701131626.E962F315A903@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 26699: [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

Attachment 32104: Patch
https://bugs.webkit.org/attachment.cgi?id=32104&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45412)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,13 @@
> +2009-06-30  Erik Arvidsson  <arv at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fixes issue where escape did not cancel the drag and drop operation
on windows.

You should add the URL and title of this bug to your ChangeLogs.

> Property changes on: WebCore/manual-tests/drag-escape.html
> ___________________________________________________________________
> Added: svn:executable
>    + *

Please remove the executable bit. It would also be good to set svn:eol-style to
native.

> 
> Index: WebCore/page/EventHandler.cpp
> ===================================================================
> --- WebCore/page/EventHandler.cpp	(revision 45393)
> +++ WebCore/page/EventHandler.cpp	(working copy)
> @@ -2102,6 +2102,7 @@ void EventHandler::dragSourceEndedAt(con
>      }
>      freeClipboard();
>      dragState().m_dragSrc = 0;
> +    m_mouseDownMayStartDrag = false;
>  }

It's probably worth adding a comment here about why this is needed (i.e., to
handle situations where the drag is cancelled while the mouse button is still
down).

>  STDMETHODIMP WebDropSource::QueryContinueDrag(BOOL fEscapePressed, DWORD
grfKeyState)
>  {
> -    if(fEscapePressed)
> -	   return DRAGDROP_S_CANCEL;
> -
> -    if(!(grfKeyState & (MK_LBUTTON|MK_RBUTTON))) {
> -	   m_dropped = true;
> +    if(fEscapePressed || !(grfKeyState & (MK_LBUTTON|MK_RBUTTON))) {

Please add a space after "if" while you're modifying this line.

> +	   m_dropped = !fEscapePressed;
>	   if (Page* page = m_webView->page())
>	       if (Frame* frame = page->mainFrame()) 
>		   //FIXME: We need to figure out how to find out what actually
happened in the drag <rdar://problem/5015961>
>		  
frame->eventHandler()->dragSourceEndedAt(generateMouseEvent(m_webView.get(),
false), DragOperationCopy);

It doesn't seem right to pass DragOperationCopy if Escape was pressed.

> -	   return DRAGDROP_S_DROP;
> +		return fEscapePressed? DRAGDROP_S_CANCEL : DRAGDROP_S_DROP;

Tabs! Please use 4-space indents.

Thanks for looking at this!

From bugzilla-daemon at webkit.org  Wed Jul  1 08:24:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 08:24:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26884] [WML] WMLTestCase.js
	is cluttered & depends on several hacks : [Attachment 32123]
	Initial patch
Message-ID: <20090701152453.84480315E13A@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 26884: [WML] WMLTestCase.js is cluttered & depends on several hacks
https://bugs.webkit.org/show_bug.cgi?id=26884

Attachment 32123: Initial patch
https://bugs.webkit.org/attachment.cgi?id=32123&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 08:34:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 08:34:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26885] [WML] WMLPageState
	doesn't reset history length correctly : [Attachment 32124]
	Initial patch
Message-ID: <20090701153437.E2956315E6A4@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 26885: [WML] WMLPageState doesn't reset history length correctly
https://bugs.webkit.org/show_bug.cgi?id=26885

Attachment 32124: Initial patch
https://bugs.webkit.org/attachment.cgi?id=32124&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 08:58:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 08:58:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25711] HTML5 Database
	becomes locked if a transaction is in progress when the page
	is refreshed. : [Attachment 32125] New patch.
Message-ID: <20090701155800.6AB20315F1C6@gamma.macosforge.org>

Ben Murdoch <benm at google.com> has asked  for review:
Bug 25711: HTML5 Database becomes locked if a transaction is in progress when
the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=25711

Attachment 32125: New patch.
https://bugs.webkit.org/attachment.cgi?id=32125&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 09:16:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 09:16:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26884] [WML] WMLTestCase.js
	is cluttered & depends on several hacks : [Attachment 32123]
	Initial patch
Message-ID: <20090701161609.B5DF4315F93E@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 26884: [WML] WMLTestCase.js is cluttered & depends on several hacks
https://bugs.webkit.org/show_bug.cgi?id=26884

Attachment 32123: Initial patch
https://bugs.webkit.org/attachment.cgi?id=32123&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 09:18:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 09:18:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26885] [WML] WMLPageState
	doesn't reset history length correctly : [Attachment 32124]
	Initial patch
Message-ID: <20090701161812.4CFAB315FA3F@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 26885: [WML] WMLPageState doesn't reset history length correctly
https://bugs.webkit.org/show_bug.cgi?id=26885

Attachment 32124: Initial patch
https://bugs.webkit.org/attachment.cgi?id=32124&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 09:49:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 09:49:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26655] ResourceHandle
	infrastructure is needed to support loading out of an
	appcache : [Attachment 32128] Interceptor (rev2)
Message-ID: <20090701164940.BECF831606E5@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 26655: ResourceHandle infrastructure is needed to support loading out of an
appcache
https://bugs.webkit.org/show_bug.cgi?id=26655

Attachment 32128: Interceptor (rev2)
https://bugs.webkit.org/attachment.cgi?id=32128&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Here's an updated patch that working for me on Safari/mac.

From bugzilla-daemon at webkit.org  Wed Jul  1 09:49:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 09:49:40 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26655] ResourceHandle
	infrastructure is needed to support loading out of an
	appcache : [Attachment 31813] Interceptor (rev2)
Message-ID: <20090701164940.B2F9E31606E3@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has cancelled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 26655: ResourceHandle infrastructure is needed to support loading out of an
appcache
https://bugs.webkit.org/show_bug.cgi?id=26655

Attachment 31813: Interceptor (rev2)
https://bugs.webkit.org/attachment.cgi?id=31813&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
Here's an updated patch that working for me on Safari/mac.

From bugzilla-daemon at webkit.org  Wed Jul  1 10:03:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 10:03:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26888] Converted op_mod to
	put { tag, payload } in { regT1, regT0 } :  [Attachment 32129] patch
Message-ID: <20090701170309.1FDB83160CC0@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 26888: Converted op_mod to put { tag, payload } in { regT1, regT0 }
https://bugs.webkit.org/show_bug.cgi?id=26888

Attachment 32129: patch
https://bugs.webkit.org/attachment.cgi?id=32129&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 10:08:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 10:08:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26888] Converted op_mod to
	put { tag, payload } in { regT1, regT0 } :  [Attachment 32129] patch
Message-ID: <20090701170811.BB6FB3160ED6@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted 's request for review:
Bug 26888: Converted op_mod to put { tag, payload } in { regT1, regT0 }
https://bugs.webkit.org/show_bug.cgi?id=26888

Attachment 32129: patch
https://bugs.webkit.org/attachment.cgi?id=32129&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 10:46:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 10:46:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24300] Add
	CSSKeepVisitedLinksPrivate option to WebCore : [Attachment
	32098] Updated patch
Message-ID: <20090701174639.2E3E83161F55@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 24300: Add CSSKeepVisitedLinksPrivate option to WebCore
https://bugs.webkit.org/show_bug.cgi?id=24300

Attachment 32098: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32098&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 11:12:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 11:12:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32130] patch2
Message-ID: <20090701181210.322BD31629DC@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32130: patch2
https://bugs.webkit.org/attachment.cgi?id=32130&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 11:38:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 11:38:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26891] Remove unused code
	in SVGTransformList and SVGTransformDistance : [Attachment
	32131] patch
Message-ID: <20090701183830.D6C303163611@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 26891: Remove unused code in SVGTransformList and SVGTransformDistance
https://bugs.webkit.org/show_bug.cgi?id=26891

Attachment 32131: patch
https://bugs.webkit.org/attachment.cgi?id=32131&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 12:48:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 12:48:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26699] [Win] HTML5 Drag and
	drop,
	dragend is not fired when pressing Esc : [Attachment 32133] Fixed
	Adam's comments
Message-ID: <20090701194847.CA579316564D@gamma.macosforge.org>

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 26699: [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

Attachment 32133: Fixed Adam's comments
https://bugs.webkit.org/attachment.cgi?id=32133&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 12:56:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 12:56:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26854] [GTK] Needs API to
	allow more control over outgoing requests : [Attachment
	32134] Map the willSendRequest delegate to the
	'outgoing-request' signal
Message-ID: <20090701195658.E31E63165A17@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 26854: [GTK] Needs API to allow more control over outgoing requests
https://bugs.webkit.org/show_bug.cgi?id=26854

Attachment 32134: Map the willSendRequest delegate to the 'outgoing-request'
signal
https://bugs.webkit.org/attachment.cgi?id=32134&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
After Jan pointed out that Mac used willSendRequest in its DRT implementation I
went and investigated. I now believe we need to look at this problem with a
wider perspective, and with the DataSource API in mind.

Delegates such as willSendRequest,  didFinishLoading, and other (I believe all
that get a DocumentLoader and an identifier, in FrameLoaderClient) are used
together for tracking the loading of the resources.

Mac provides as part of its API objects representing the resources, and maps
the identifier to said objects in these delegates. We may want to adopt a
similar approach.

From bugzilla-daemon at webkit.org  Wed Jul  1 13:01:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:01:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop
	support : [Attachment 32135] Second patch
Message-ID: <20090701200137.503B03165C31@gamma.macosforge.org>

Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 32135: Second patch
https://bugs.webkit.org/attachment.cgi?id=32135&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This is the second patch dissected from the WebKit/WebCore updates patch.

This one finally uses DragClipboard as the proper data holder.

One more patch is on its way, mostly taking care of things in WebKit part
(WebCoreSupport updates and proper support for dnd actions in WebKitWebView).
The patch should be prepared tomorrow, so the reviewer can also wait for that
one and then land these patches in the same day.

From bugzilla-daemon at webkit.org  Wed Jul  1 13:02:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:02:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32136] new patch with a bug fix + xcode changes
Message-ID: <20090701200242.581AF3165CAA@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32136: new patch with a bug fix + xcode changes
https://bugs.webkit.org/attachment.cgi?id=32136&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 13:15:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:15:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26896] [QT] make layout tests
	in fast/css/getComputedStyle/ to pass : [Attachment 32137] patch
Message-ID: <20090701201555.DAFBD31662C2@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has granted 's request for
review:
Bug 26896: [QT] make layout tests in fast/css/getComputedStyle/ to pass
https://bugs.webkit.org/show_bug.cgi?id=26896

Attachment 32137: patch
https://bugs.webkit.org/attachment.cgi?id=32137&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
patch for the bug. It was reviewed by Adam Treat on IRC:
<manyoso> r=me
<manyoso> on condition of one change!
<manyoso> you have to add the bug report URL to the ChangeLog and check-in
<manyoso> thanks!

From bugzilla-daemon at webkit.org  Wed Jul  1 13:33:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:33:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26807] Crashes on 3 layout
	tests when XSS auditor is enabled : [Attachment 32138] Patch
Message-ID: <20090701203355.97C853166BDD@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 26807: Crashes on 3 layout tests when XSS auditor is enabled
https://bugs.webkit.org/show_bug.cgi?id=26807

Attachment 32138: Patch
https://bugs.webkit.org/attachment.cgi?id=32138&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Fixes the issue by checking whether frame->document()->decoder() is null.

From bugzilla-daemon at webkit.org  Wed Jul  1 13:35:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:35:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26807] Crashes on 3 layout
	tests when XSS auditor is enabled : [Attachment 32138] Patch
Message-ID: <20090701203542.189673166CB2@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26807: Crashes on 3 layout tests when XSS auditor is enabled
https://bugs.webkit.org/show_bug.cgi?id=26807

Attachment 32138: Patch
https://bugs.webkit.org/attachment.cgi?id=32138&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks!

From bugzilla-daemon at webkit.org  Wed Jul  1 13:36:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:36:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26891] Remove unused code in
	SVGTransformList and SVGTransformDistance : [Attachment 32131] patch
Message-ID: <20090701203612.4A0663166CF5@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 26891: Remove unused code in SVGTransformList and SVGTransformDistance
https://bugs.webkit.org/show_bug.cgi?id=26891

Attachment 32131: patch
https://bugs.webkit.org/attachment.cgi?id=32131&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why not fix the default constructor?  I support removing the dead code though.

Wow, this code is old.	This was from yet-another attempt at animation by yours
truly... forever ago.  I think you shoudl fix the default constructor to zero
everything instead of changing the callsites.

From bugzilla-daemon at webkit.org  Wed Jul  1 13:38:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 13:38:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26699] [Win] HTML5 Drag and
	drop,
	dragend is not fired when pressing Esc : [Attachment 32133] Fixed
	Adam's comments
Message-ID: <20090701203847.9717C3166E3F@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 26699: [Win] HTML5 Drag and drop, dragend is not fired when pressing Esc
https://bugs.webkit.org/show_bug.cgi?id=26699

Attachment 32133: Fixed Adam's comments
https://bugs.webkit.org/attachment.cgi?id=32133&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul  1 14:15:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:15:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32139] final version
Message-ID: <20090701211558.9FFDA3167F20@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32139: final version
https://bugs.webkit.org/attachment.cgi?id=32139&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
forgot to add project.pbxproj to the ChangeLog.

From bugzilla-daemon at webkit.org  Wed Jul  1 14:15:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:15:58 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32136] new patch with a bug fix + xcode changes
Message-ID: <20090701211558.91AD03167F1E@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has cancelled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32136: new patch with a bug fix + xcode changes
https://bugs.webkit.org/attachment.cgi?id=32136&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
forgot to add project.pbxproj to the ChangeLog.

From bugzilla-daemon at webkit.org  Wed Jul  1 14:25:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:25:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26692] prepare-ChangeLog
	should bail out when missing EMAIL_ADDRESS or REAL_NAME :
	[Attachment 32141] First attempt
Message-ID: <20090701212529.3025B316834F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26692: prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or
REAL_NAME
https://bugs.webkit.org/show_bug.cgi?id=26692

Attachment 32141: First attempt
https://bugs.webkit.org/attachment.cgi?id=32141&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 14:39:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:39:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26900] AX: Manual spell
	check with Command-;
	does not bring up suggestions :  [Attachment 32142] patch
Message-ID: <20090701213950.7D2CF316899F@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900

Attachment 32142: patch
https://bugs.webkit.org/attachment.cgi?id=32142&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 14:45:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:45:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26900] AX: Manual spell check
	with Command-;
	does not bring up suggestions :  [Attachment 32142] patch
Message-ID: <20090701214547.78FB23168C9D@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 26900: AX: Manual spell check with Command-; does not bring up suggestions
https://bugs.webkit.org/show_bug.cgi?id=26900

Attachment 32142: patch
https://bugs.webkit.org/attachment.cgi?id=32142&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
> +IntPoint AccessibilityRenderObject::clickPoint() const
> +{
> +    // if we're asked to perform a show menu on an editable web area,
> +    // the click point should be where the selection is
> +    if (isWebArea() && !isReadOnly()) {
> +	   VisibleSelection visSelection = selection();
> +	   VisiblePositionRange range =
VisiblePositionRange(visSelection.visibleStart(), visSelection.visibleEnd());
> +	   IntRect bounds = boundsForVisiblePositionRange(range);
> +#if PLATFORM(MAC)
> +	  
bounds.setLocation(m_renderer->document()->view()->screenToContents(bounds.loca
tion()));
> +#endif	 
> +	   return IntPoint(bounds.x() + (bounds.width() / 2), bounds.y() -
(bounds.height() / 2));
> +    }
> +
> +    return AccessibilityObject::clickPoint();
> +}

This is just a style nit-pick, but how about you do the generic case as an
early return like:

if (!isWebArea() || isReadOnly())
    return AccessibilityObject::clickPoint();

VisibleSelection visSelection = selection();
?




r=me!

From bugzilla-daemon at webkit.org  Wed Jul  1 14:49:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:49:30 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26692] prepare-ChangeLog
	should bail out when missing EMAIL_ADDRESS or REAL_NAME :
	[Attachment 32141] First attempt
Message-ID: <20090701214930.DE6563168E59@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has cancelled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26692: prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or
REAL_NAME
https://bugs.webkit.org/show_bug.cgi?id=26692

Attachment 32141: First attempt
https://bugs.webkit.org/attachment.cgi?id=32141&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 14:49:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:49:30 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26692] prepare-ChangeLog
	should bail out when missing EMAIL_ADDRESS or REAL_NAME :
	[Attachment 32141] First attempt
Message-ID: <20090701214930.F0C3A3168E5D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has cancelled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26692: prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or
REAL_NAME
https://bugs.webkit.org/show_bug.cgi?id=26692

Attachment 32141: First attempt
https://bugs.webkit.org/attachment.cgi?id=32141&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 14:49:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:49:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26692] prepare-ChangeLog
	should bail out when missing EMAIL_ADDRESS or REAL_NAME :
	[Attachment 32144] Now with more sanity checking
Message-ID: <20090701214933.173423168E7C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26692: prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or
REAL_NAME
https://bugs.webkit.org/show_bug.cgi?id=26692

Attachment 32144: Now with more sanity checking
https://bugs.webkit.org/attachment.cgi?id=32144&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 14:50:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 14:50:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26054] Need a new abstraction
	layer between the DB classes and the file system :
	[Attachment 32139] final version
Message-ID: <20090701215000.BD4243168ED8@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32139: final version
https://bugs.webkit.org/attachment.cgi?id=32139&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:02:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:02:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26054] Need a new abstraction
	layer between the DB classes and the file system :
	[Attachment 32139] final version
Message-ID: <20090701220218.BA0283169438@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied 's request for
review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32139: final version
https://bugs.webkit.org/attachment.cgi?id=32139&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>

> +String SQLiteFileSystem::getFileNameForNewDatabase(const String& dbDir,
const String& dbName,
> +						      const String&
originIdentifier, SQLiteDatabase* db)
> +{

> +    // dbName and originIdentifier not used in the default WebKit
implementation
> +    // touch them so gcc doesn't complain about that when building on Mac
> +    String unused = dbName;
> +    unused = originIdentifier;

Oops, this is wrong. Let's not create more work. You can just do:

String SQLiteFileSystem::getFileNameForNewDatabase(const String& dbDir, const
String&, const String&, SQLiteDatabase* db)

From bugzilla-daemon at webkit.org  Wed Jul  1 15:02:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:02:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26906] Prevent Javascript
	object from being initialized when JavascriptEnabled is false
	: [Attachment 32145] Patch
Message-ID: <20090701220241.DAE1E316946A@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26906: Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32145: Patch
https://bugs.webkit.org/attachment.cgi?id=32145&action=review

------- Additional Comments from robert <robert at roberthogan.net>
This fixes the assert. But I don't see a ready way of adding a unit test for
the root cause.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:14:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:14:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26905] Don't use
	PlatformMessagePortChannel in any files : [Attachment 32146]
	Proposed patch
Message-ID: <20090701221427.F13A23169980@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 26905: Don't use PlatformMessagePortChannel in any files
https://bugs.webkit.org/show_bug.cgi?id=26905

Attachment 32146: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32146&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:18:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:18:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26906] [Qt] Prevent
	Javascript object from being initialized when
	JavascriptEnabled is false : [Attachment 32147] Updated to be
	page-specific
Message-ID: <20090701221837.377D33169B25@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32147: Updated to be page-specific
https://bugs.webkit.org/attachment.cgi?id=32147&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Patch updated to be page specific, also updated inline documentation.

Tested with arora. Launching with jscript both enabled and disabled. Also
tested opening different pages between toggling jscript on and off.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:18:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:18:37 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26906] [Qt] Prevent
	Javascript object from being initialized when
	JavascriptEnabled is false : [Attachment 32145] Patch
Message-ID: <20090701221837.2F19E3169B23@gamma.macosforge.org>

robert <robert at roberthogan.net> has cancelled robert <robert at roberthogan.net>'s
request for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32145: Patch
https://bugs.webkit.org/attachment.cgi?id=32145&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Patch updated to be page specific, also updated inline documentation.

Tested with arora. Launching with jscript both enabled and disabled. Also
tested opening different pages between toggling jscript on and off.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:21:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:21:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32148] patch
Message-ID: <20090701222102.4E1713169C1B@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32148: patch
https://bugs.webkit.org/attachment.cgi?id=32148&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
addressing all dimitri's comments.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:24:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:24:52 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24986] ARM JIT port :
	[Attachment 32046] Constant pool for AssemblerBuffer (v2)
Message-ID: <20090701222452.C51FF3169DAB@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has denied Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32046: Constant pool for AssemblerBuffer (v2)
https://bugs.webkit.org/attachment.cgi?id=32046&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
> Constant pool for AssemblerBuffer (v2)

This basically looks fine as is, r- for a handful of small fixes, but no big
issues at all.

The comment on the class states that the constant pool can store 4 or 8 bytes
values, however the code currently appears to be very 32-bit specific, only
handling entries of size (sizeof(uint32_t)) - so unless I'm missing something
the comment is currently a little misleading.  It may be good to fix this to
say that the pool can hold 32-bit values, and that we intend to extend the
class to be able to hold 64-bit values in the pool too, at some point in the
future.

When you align the pool, I'd suggest you may want to consider replacing the
magic number '0x0badf00d' with a value that will be interpreted as a
breakpoint, or illegal instruction on ARM (just as an extra guard against an
erroneously linked branch jumping into the padding.  To make this effective you
would also have to reverse the order in which it checks & plants the alignment
(byte, then short, then int) in order that the int value is 32-bit aligned.  On
x86 we use HLTs to pad (we use these since they're illegal in user space, cause
a trap, and as such clearly indicate an error case), and we'd probably want to
do the same in the constant pool too.  At minimum I'd suggest you should move
these values into the Assembler (AssemblerType::padForAlign8, 16, 32) so that
these values can be provided in a platform-specific fashion (we also try to
avoid "magic numbers" inline in the code, and prefer defining constant values
or declaring static const variables ??making this change would fix this problem
too).  I think it could be even nicer if you just called
AssemblerType::align(int) to do the alignment ... except I imagine that could
be problematic (since you would end up recursing, at Assembler::align tried to
plant a byte, caused a recursive flush, called Assembler::align, tried to plant
a byte ... etc.).  You could of course add a new specific method to Assembler
to alignConstantPool(int), and then provide methods to put the pad values
directly to the assembler buffer.  But then you have a danger that these
methods could be misused.  I'd probably ignore this last suggestion myself. 
I'd probably just add a set of constants to Assembler
(AssemblerType::padForAlign8, 16, 32).

> if (10 * m_numConsts > 6 * maxPoolSize / sizeof(uint32_t))
I think this check is prone to overflow.  It is probably not a practical
concern right now, since m_pool is allocated with a single malloc, so a huge
value for maxPoolSize would not be sensible anyway.  However in order to
support large constant pools on x86[_64], the obvious thing to do will probably
be to replace these arrays with some form of vector, and when we do so this
test would become potentially unsafe.  'maxPoolSize' is defined as a signed
int, so if (maxPoolSize > 0x15555555) then (6 * maxPoolSize) will overflow to a
negative walue, and the test will always pass.	Due to the first multiply (*
10) there are also boundary condition problems that could cause the left had
side of this compare to overflow, too.	If you enforce that maxPoolSize is no
larger than 0x15555555 then the limit (6 * maxPoolSize) could be 0x7FFFFFFE,
however as m_numConsts rolls over from 0x0CCCCCCC -> 0x0CCCCCCD (m_numConsts *
10) goes from 0x7FFFFFF8 -> 0x80000002, which, again interpreted as signed
values are both less than 0x7FFFFFFE, so the limit being exceeded will not be
detected.  I'd suggest adding an "ASSERT(maxPoolSize < 0x10000000);" above this
line to make sure we stay well away from any potential overflow issues here
would be a good idea.

Finally, a quick find & replace code style issue ??it is not WebKit coding
style to use abbreviations, we use full words.	AssemblerBufferWithCP is
certainly against style, placeConstPoolBarrier etc really should probably be
placeConstantPoolBarrier - but I leave it at your discretion as to exactly how
you change these names to bring these names in line with coding style.

But other than these little style issues, the mechanism looks great, and yes,
looks like it should be fairly straightforward to take this and roll it out to
the other platforms when we hit a point that we need to add constant-pool
support, which is really good news.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:24:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:24:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26906] [Qt] Prevent
	Javascript object from being initialized when
	JavascriptEnabled is false : [Attachment 32147] Updated to be
	page-specific
Message-ID: <20090701222456.95C853169DE7@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted robert <robert at roberthogan.net>'s
request for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32147: Updated to be page-specific
https://bugs.webkit.org/attachment.cgi?id=32147&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +    If QWebSettings::JavascriptEnabled is false, this function does nothing.


How about, "If JavaScript is not enabled for this page, then this function does
nothing."

> +2009-06-30  Robert Hogan <robert at roberthogan.net>
> +
> +	   Reviewed by NOBODY.
> +	   
> +	   Fix Qt segfault when javascript disabled.

Please put the URL in the ChangeLog.

With those changes r=me.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:25:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:25:32 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26906] [Qt] Prevent Javascript
	object from being initialized when JavascriptEnabled is false
	: [Attachment 32147] Updated to be page-specific
Message-ID: <20090701222532.753943169E22@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied 's request for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32147: Updated to be page-specific
https://bugs.webkit.org/attachment.cgi?id=32147&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:33:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:33:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26692] prepare-ChangeLog
	should bail out when missing EMAIL_ADDRESS or REAL_NAME :
	[Attachment 32144] Now with more sanity checking
Message-ID: <20090701223316.1E1D2316A188@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 26692: prepare-ChangeLog should bail out when missing EMAIL_ADDRESS or
REAL_NAME
https://bugs.webkit.org/show_bug.cgi?id=26692

Attachment 32144: Now with more sanity checking
https://bugs.webkit.org/attachment.cgi?id=32144&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> @@ -94,6 +96,8 @@ sub normalizePath($);
>  # Project time zone for Cupertino, CA, US
>  my $changeLogTimeZone = "PST8PDT";
>  
> +my $name;
> +my $email_address;
>  my $gitCommit = 0;
>  my $gitIndex = "";

You've been infected (cleansed?) by Python. Please use interCaps for variable
names.

r=me

From bugzilla-daemon at webkit.org  Wed Jul  1 15:33:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:33:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26906] [Qt] Prevent
	Javascript object from being initialized when
	JavascriptEnabled is false : [Attachment 32149] updated patch
Message-ID: <20090701223324.AFB66316A1B0@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32149: updated patch
https://bugs.webkit.org/attachment.cgi?id=32149&action=review

------- Additional Comments from robert <robert at roberthogan.net>
updated changelog and inline doc

From bugzilla-daemon at webkit.org  Wed Jul  1 15:35:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:35:19 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26054] Need a new abstraction
	layer between the DB classes and the file system :
	[Attachment 32148] patch
Message-ID: <20090701223519.2F9FC316A2A5@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32148: patch
https://bugs.webkit.org/attachment.cgi?id=32148&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Just one more thing! I promise!

> +	    SQLiteFileSystem::deleteDatabaseFile(trackerDatabasePath());
> +	   
SQLiteFileSystem::deleteEmptyDatabaseDirectory(m_databaseDirectoryPath);

4 spaces?

From bugzilla-daemon at webkit.org  Wed Jul  1 15:38:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:38:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26906] [Qt] Prevent
	Javascript object from being initialized when
	JavascriptEnabled is false : [Attachment 32149] updated patch
Message-ID: <20090701223802.2D6A9316A3D3@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted robert <robert at roberthogan.net>'s
request for review:
Bug 26906: [Qt] Prevent Javascript object from being initialized when
JavascriptEnabled is false
https://bugs.webkit.org/show_bug.cgi?id=26906

Attachment 32149: updated patch
https://bugs.webkit.org/attachment.cgi?id=32149&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:41:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:41:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26907] [Chromium] Upstream
	V8SVGPODTypeWrapper : [Attachment 32150] patch
Message-ID: <20090701224129.BF6F7316A538@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26907: [Chromium] Upstream V8SVGPODTypeWrapper
https://bugs.webkit.org/show_bug.cgi?id=26907

Attachment 32150: patch
https://bugs.webkit.org/attachment.cgi?id=32150&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:42:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:42:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32151] patch
Message-ID: <20090701224255.D0DB3316A5CA@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32151: patch
https://bugs.webkit.org/attachment.cgi?id=32151&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:46:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:46:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26903] Need to enable
	CHANNEL_MESSAGING by default : [Attachment 32152] Proposed patch
Message-ID: <20090701224605.0AD25316A70A@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32152: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32152&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
This patch is actually much smaller than it appears - I've re-enabled a bunch
of the previously disabled tests (I didn't modify them, I just renamed them)
which makes it look large.

From bugzilla-daemon at webkit.org  Wed Jul  1 15:50:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:50:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26088] large negative
	letter-spacing crashes the chromium port : [Attachment 32153]
	revised patch w/ fishd's comments
Message-ID: <20090701225013.2215C316A8CD@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 26088: large negative letter-spacing crashes the chromium port
https://bugs.webkit.org/show_bug.cgi?id=26088

Attachment 32153: revised patch w/ fishd's comments
https://bugs.webkit.org/attachment.cgi?id=32153&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:55:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:55:25 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32151] patch
Message-ID: <20090701225525.2F5E7316AB0A@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has cancelled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32151: patch
https://bugs.webkit.org/attachment.cgi?id=32151&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:55:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:55:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26054] Need a new
	abstraction layer between the DB classes and the file system
	: [Attachment 32154] patch
Message-ID: <20090701225525.3880B316AB0C@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32154: patch
https://bugs.webkit.org/attachment.cgi?id=32154&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 15:58:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 15:58:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26907] [Chromium] Upstream
	V8SVGPODTypeWrapper : [Attachment 32150] patch
Message-ID: <20090701225801.DD1F9316AC28@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 26907: [Chromium] Upstream V8SVGPODTypeWrapper
https://bugs.webkit.org/show_bug.cgi?id=26907

Attachment 32150: patch
https://bugs.webkit.org/attachment.cgi?id=32150&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to take care of.


> Index: WebCore/bindings/v8/V8SVGPODTypeWrapper.h
> +/*
> + * Copyright (C) 2006, 2008 Nikolas Zimmermann <zimmermann at kde.org>
> + * Copyright (C) 2008 Apple Inc. All rights reserved.
> + * Copyright (C) 2008 The Chromium Authors. All rights reserved.

I think this should be "Google" instead of "The Chromium Authors".  Also I'm
sure you did enough changes to add 2009.


> +#ifndef V8SVGPODTypeWrapper_h
> +#define V8SVGPODTypeWrapper_h
> +
> +#if ENABLE(SVG)
> +
> +#include "config.h"

I don't think header files are suppose to include config.h.



> +public:
> +    V8SVGStaticPODTypeWrapper(PODType type)
> +	   : m_podType(type)
> +    { }

Once you've put the { } on a new line, just put each on its own line.


> +private:
> +    // Update callbacks

Is this comment useful?



> +    explicit PODTypeWrapperCacheInfo(WTF::HashTableDeletedValueType)
> +	   : creator(reinterpret_cast<PODTypeCreator*>(-1))
> +	   , getter(0)
> +	   , setter(0)
> +    {
> +    }
> +    bool isHashTableDeletedValue() const

Add a blank line before this method.



> +template<typename PODType, typename PODTypeCreator>
> +struct PODTypeWrapperCacheInfoHash {
> +    static unsigned hash(const PODTypeWrapperCacheInfo<PODType,
PODTypeCreator>& info)
> +    {
> +	   unsigned creator = reinterpret_cast<unsigned>(info.creator);
> +	   unsigned getter = reinterpret_cast<unsigned>(*(void**)&info.getter);

> +	   unsigned setter = reinterpret_cast<unsigned>(*(void**)&info.setter);


Can reinterpret_cast be used for the void**?



> +template<typename PODType, typename PODTypeCreator>
> +struct PODTypeWrapperCacheInfoTraits :
WTF::GenericHashTraits<PODTypeWrapperCacheInfo<PODType, PODTypeCreator> > {
> +    typedef PODTypeWrapperCacheInfo<PODType, PODTypeCreator> CacheInfo;
> +
> +    static const bool emptyValueIsZero = true;
> +    static const bool needsDestruction = false;
> +
> +    static const CacheInfo& emptyValue()
> +    {
> +	   static CacheInfo key;

Consider using DEFINE_STATIC_LOCAL.



> +    static DynamicWrapperHashMap& dynamicWrapperHashMap()
> +    {
> +	   static DynamicWrapperHashMap _dynamicWrapperHashMap;

Consider using DEFINE_STATIC_LOCAL (and getting rid of the preceding "_").



> +template <class P>
> +P V8SVGPODTypeUtil::toSVGPODType(V8ClassIndex::V8WrapperType type,
v8::Handle<v8::Value> object, bool& ok) {

Brace style

From bugzilla-daemon at webkit.org  Wed Jul  1 16:04:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:04:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26054] Need a new abstraction
	layer between the DB classes and the file system :
	[Attachment 32154] patch
Message-ID: <20090701230403.2F88E316AE68@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26054: Need a new abstraction layer between the DB classes and the file
system
https://bugs.webkit.org/show_bug.cgi?id=26054

Attachment 32154: patch
https://bugs.webkit.org/attachment.cgi?id=32154&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me for realz. Landing now.

From bugzilla-daemon at webkit.org  Wed Jul  1 16:28:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:28:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26909] aria-label needs to
	be supported : [Attachment 32155] patch
Message-ID: <20090701232828.E631C316B7B7@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909

Attachment 32155: patch
https://bugs.webkit.org/attachment.cgi?id=32155&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 16:30:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:30:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26909] aria-label needs to be
	supported : [Attachment 32155] patch
Message-ID: <20090701233009.D8452316B871@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 26909: aria-label needs to be supported
https://bugs.webkit.org/show_bug.cgi?id=26909

Attachment 32155: patch
https://bugs.webkit.org/attachment.cgi?id=32155&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 16:43:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:43:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26907] [Chromium] Upstream
	V8SVGPODTypeWrapper : [Attachment 32158] patch2
Message-ID: <20090701234306.6813A316BE1E@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26907: [Chromium] Upstream V8SVGPODTypeWrapper
https://bugs.webkit.org/show_bug.cgi?id=26907

Attachment 32158: patch2
https://bugs.webkit.org/attachment.cgi?id=32158&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 16:44:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:44:47 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32130] patch2
Message-ID: <20090701234447.E1C94316BF61@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has cancelled Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32130: patch2
https://bugs.webkit.org/attachment.cgi?id=32130&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Forgot to edit CodeGeneratorV8.pm upstream in previous patches.

From bugzilla-daemon at webkit.org  Wed Jul  1 16:44:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:44:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32159] patch3
Message-ID: <20090701234447.ED3F8316BF63@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32159: patch3
https://bugs.webkit.org/attachment.cgi?id=32159&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Forgot to edit CodeGeneratorV8.pm upstream in previous patches.

From bugzilla-daemon at webkit.org  Wed Jul  1 16:53:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 16:53:16 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26905] Don't use
	PlatformMessagePortChannel in any files : [Attachment 32146]
	Proposed patch
Message-ID: <20090701235316.352BF316C30A@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 26905: Don't use PlatformMessagePortChannel in any files
https://bugs.webkit.org/show_bug.cgi?id=26905

Attachment 32146: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32146&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Small refactoring of MessagePortChannel so that a port's
PlatformMessagePortChannel doesn't
> +	   have to reside in the WebKit repository.

I think it would be more accurate to say "so that PlatformMessagePortChannel
may
be defined at the WebKit layer"

Otherwise, R=me

From bugzilla-daemon at webkit.org  Wed Jul  1 17:06:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:06:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24986] ARM JIT port :
	[Attachment 32047] Add YARR support for generic ARM platforms (v2)
Message-ID: <20090702000604.26279316C844@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has denied Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32047: Add YARR support for generic ARM platforms (v2)
https://bugs.webkit.org/attachment.cgi?id=32047&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
This all looks really great, couple of small comments.

In the MacroAssembler, we normally try to only use UNUSED_PARAM if a parameter
is only not use on some (ifdef'ed) code paths, so we'd normally write:

void mulDouble(Address src, FPRegisterID dest)
{
    UNUSED_PARAM(src);
    UNUSED_PARAM(dest);
    ASSERT_NOT_REACHED();
}

as:

void mulDouble(Address, FPRegisterID)
{
    ASSERT_NOT_REACHED();
}

But if you prefer to leave this unchanged, this would be okay.

In Platform.h:

 546 #elif PLATFORM(ARM)
 547	 /* Under development, temporarily disabled. */
 548	 #define ENABLE_JIT 0
 549	 #define ENABLE_JIT_OPTIMIZE_NATIVE_CALL 0

This should really be added as a part of the JIT patch, let's revert this for
now (it really doesn't make a lot of sense without the rest of the JIT changes
:o) ).	Also...

 596  || (!defined(ENABLE_YARR_JIT) && PLATFORM(ARM) && 0) \

We will only want to enable YARR & the ARM JIT on operating systems it has been
tested on.  What OS are you testing on?  Linux?  GTK or KDE?  Or other?  Also,
if Linux, this may also be the wrong place to be enabling them.  On Linux I
believe the platform specific settings are configured in configure.ac (GTK?)
and JavaScriptCore/JavaScriptCore.pri (KDE?) ??and I believe this is where YARR
is enabled on x86-Linux.  (Personally, I find the fact that we configure these
things in different places on different OSes a little odd, but given that we
do, it certainly seems that it would be more correct to keep the way we do
things on ARM-Linux in line with the way we work on x86-Linux - again, assuming
that it is Linux you're targeting).

The rest of the patch all looks great.	r-ing while the Platform.h questions
are answered, but otherwise this all looks good to land.

From bugzilla-daemon at webkit.org  Wed Jul  1 17:08:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:08:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22700] ApplicationCache
	should have size limit : [Attachment 32162] New proposal to
	limit the maximum size of the application cache (take 7)
Message-ID: <20090702000850.6B667316C9BC@gamma.macosforge.org>

Andrei Popescu <andreip at google.com> has asked  for review:
Bug 22700: ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Attachment 32162: New proposal to limit the maximum size of the application
cache (take 7)
https://bugs.webkit.org/attachment.cgi?id=32162&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 17:12:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:12:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26383] prepare-ChangeLog
	should have a --bug= argument and use it for url autofill :
	[Attachment 32163] First attempt
Message-ID: <20090702001228.52477316CB1C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26383: prepare-ChangeLog should have a --bug= argument and use it for url
autofill
https://bugs.webkit.org/show_bug.cgi?id=26383

Attachment 32163: First attempt
https://bugs.webkit.org/attachment.cgi?id=32163&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 17:25:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:25:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26910] [Chromium]
	Middle-click should set scrollbar position for Linux :
	[Attachment 32164] patch to resolve issue
Message-ID: <20090702002501.EC0A2316D0A9@gamma.macosforge.org>

Daniel Erat <derat at google.com> has asked  for review:
Bug 26910: [Chromium] Middle-click should set scrollbar position for Linux
https://bugs.webkit.org/show_bug.cgi?id=26910

Attachment 32164: patch to resolve issue
https://bugs.webkit.org/attachment.cgi?id=32164&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 17:35:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:35:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26899] XSSAuditor shouldn't
	strip control characters : [Attachment 32165] Patch with test
Message-ID: <20090702003509.39B8C316D4B1@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 26899: XSSAuditor shouldn't strip control characters
https://bugs.webkit.org/show_bug.cgi?id=26899

Attachment 32165: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32165&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Upon further investigation, we need to remove null characters, since the
HTMLTokenizer does in processing scripts (i.e. the contents of
<script>al\0ert(1)</script> becomes alert(1) by the time it is passed to
XSSAuditor). Let me know if this change is better addressed in a separate bug.

From bugzilla-daemon at webkit.org  Wed Jul  1 17:37:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:37:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26907] [Chromium] Upstream
	V8SVGPODTypeWrapper : [Attachment 32158] patch2
Message-ID: <20090702003745.D1E04316D5BD@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 26907: [Chromium] Upstream V8SVGPODTypeWrapper
https://bugs.webkit.org/show_bug.cgi?id=26907

Attachment 32158: patch2
https://bugs.webkit.org/attachment.cgi?id=32158&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 17:42:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:42:58 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26910] [Chromium]
	Middle-click should set scrollbar position for Linux :
	[Attachment 32164] patch to resolve issue
Message-ID: <20090702004258.CFF23316D78D@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Daniel Erat <derat at google.com>'s
request for review:
Bug 26910: [Chromium] Middle-click should set scrollbar position for Linux
https://bugs.webkit.org/show_bug.cgi?id=26910

Attachment 32164: patch to resolve issue
https://bugs.webkit.org/attachment.cgi?id=32164&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Style looks fine and your fellow platform developer thought it looked good, so
r+.

From bugzilla-daemon at webkit.org  Wed Jul  1 17:56:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 17:56:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26905] Don't use
	PlatformMessagePortChannel in any files : [Attachment 32166]
	updated changelog
Message-ID: <20090702005615.1FC34316DCF0@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 26905: Don't use PlatformMessagePortChannel in any files
https://bugs.webkit.org/show_bug.cgi?id=26905

Attachment 32166: updated changelog
https://bugs.webkit.org/attachment.cgi?id=32166&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 18:26:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 18:26:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26899] XSSAuditor shouldn't
	strip control characters : [Attachment 32165] Patch with test
Message-ID: <20090702012633.7124D316E849@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26899: XSSAuditor shouldn't strip control characters
https://bugs.webkit.org/show_bug.cgi?id=26899

Attachment 32165: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32165&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Great patch.  Thanks.

From bugzilla-daemon at webkit.org  Wed Jul  1 19:06:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 19:06:28 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26896] [QT] make layout
	tests in fast/css/getComputedStyle/ to pass : [Attachment
	32137] patch
Message-ID: <20090702020628.779CF316F680@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has cancelled 's request for review:
Bug 26896: [QT] make layout tests in fast/css/getComputedStyle/ to pass
https://bugs.webkit.org/show_bug.cgi?id=26896

Attachment 32137: patch
https://bugs.webkit.org/attachment.cgi?id=32137&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please don't mark it as reviewed unless you're a reviewer. :(  Makes the
scripts unhappy.

If Adam Marks this himself someone else can easily commit it.  Otherwise he'll
need to come take care of commiting for you..

From bugzilla-daemon at webkit.org  Wed Jul  1 19:17:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 19:17:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26914] bugzilla-tool fails
	for SVN users : [Attachment 32168] patch
Message-ID: <20090702021707.EA961316FA2A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26914: bugzilla-tool fails for SVN users
https://bugs.webkit.org/show_bug.cgi?id=26914

Attachment 32168: patch
https://bugs.webkit.org/attachment.cgi?id=32168&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 21:41:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 21:41:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26914] bugzilla-tool fails
	for SVN users : [Attachment 32168] patch
Message-ID: <20090702044119.A3E023172F4C@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26914: bugzilla-tool fails for SVN users
https://bugs.webkit.org/show_bug.cgi?id=26914

Attachment 32168: patch
https://bugs.webkit.org/attachment.cgi?id=32168&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm no python expert, but this looks reasonable to me.

From bugzilla-daemon at webkit.org  Wed Jul  1 22:02:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 22:02:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26383] prepare-ChangeLog
	should have a --bug= argument and use it for url autofill :
	[Attachment 32163] First attempt
Message-ID: <20090702050232.574DB3173761@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26383: prepare-ChangeLog should have a --bug= argument and use it for url
autofill
https://bugs.webkit.org/show_bug.cgi?id=26383

Attachment 32163: First attempt
https://bugs.webkit.org/attachment.cgi?id=32163&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 22:19:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 22:19:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26905] Don't use
	PlatformMessagePortChannel in any files : [Attachment 32166]
	updated changelog
Message-ID: <20090702051951.614303173D81@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted John
Abd-El-Malek <jam at chromium.org>'s request for review:
Bug 26905: Don't use PlatformMessagePortChannel in any files
https://bugs.webkit.org/show_bug.cgi?id=26905

Attachment 32166: updated changelog
https://bugs.webkit.org/attachment.cgi?id=32166&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 22:29:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 22:29:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26917] Increase delay in
	worker-terminate layout test to make it more reliable. :
	[Attachment 32169] Proposed patch
Message-ID: <20090702052939.30CB1317411D@gamma.macosforge.org>

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 26917: Increase delay in worker-terminate layout test to make it more
reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917

Attachment 32169: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32169&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 22:46:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 22:46:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32159] patch3
Message-ID: <20090702054640.7AB01317472B@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32159: patch3
https://bugs.webkit.org/attachment.cgi?id=32159&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few things to address.


> Index: WebCore/bindings/v8/V8Binding.cpp
> +class WebCoreStringResource: public v8::String::ExternalStringResource {

Add a space after WebCoreStringResource.

> +public:
> +    explicit WebCoreStringResource(const String& string)
> +	   : m_impl(string.impl()) { }

The { } should go on separate lines at this point.

> +
> +    virtual ~WebCoreStringResource() {}

Add space in {}


> +String v8StringToWebCoreString(v8::Handle<v8::String> v8String, bool
externalize)
> +{
> +    WebCoreStringResource* stringResource =
static_cast<WebCoreStringResource*>(v8String->GetExternalStringResource());
> +    if (stringResource)
> +	   return stringResource->webcoreString();
> +
> +    int length = v8String->Length();
> +    if (length == 0) {

Comparison to 0.


> +String v8ValueToWebCoreString(v8::Handle<v8::Value> object)
> +{
> +    if (object->IsString()) {
> +	   v8::Handle<v8::String> v8String =
v8::Handle<v8::String>::Cast(object);
> +	   String webCoreString = v8StringToWebCoreString(v8String, true);
> +	   return webCoreString;

This seems overly verbose plus it may inhibit return value optimization.

I'd suggest just doing:
	return v8StringToWebCoreString(v8String, true);



> +    } else if (object->IsInt32()) {
> +	   int value = object->Int32Value();
> +	   // Most numbers used are <= 100. Even if they aren't used there's
very little in using the space.
> +	   const int kLowNumbers = 100;
> +	   static AtomicString lowNumbers[kLowNumbers + 1];

Consider using DEFINE_STATIC_LOCAL



> Property changes on: WebCore/bindings/v8/V8Binding.cpp
> ___________________________________________________________________
> Added: svn:executable
>    + *

This should be fixed.



> Index: WebCore/bindings/v8/V8Binding.h
> +#include "config.h"

Don't include config.h in header files.

From bugzilla-daemon at webkit.org  Wed Jul  1 23:24:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 23:24:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26919] Root compositing
	layer is not correctly updated : [Attachment 32170] Patch
Message-ID: <20090702062434.4A25931755F5@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 26919: Root compositing layer is not correctly updated
https://bugs.webkit.org/show_bug.cgi?id=26919

Attachment 32170: Patch
https://bugs.webkit.org/attachment.cgi?id=32170&action=review

From bugzilla-daemon at webkit.org  Wed Jul  1 23:26:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  1 Jul 2009 23:26:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26919] Root compositing layer
	is not correctly updated : [Attachment 32170] Patch
Message-ID: <20090702062653.94FB031756DE@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 26919: Root compositing layer is not correctly updated
https://bugs.webkit.org/show_bug.cgi?id=26919

Attachment 32170: Patch
https://bugs.webkit.org/attachment.cgi?id=32170&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 00:46:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 00:46:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26815] [Gtk]
	text-selection-changed events are not issued for the correct
	object when the selection spans multiple objects :
	[Attachment 32171] textselection.patch
Message-ID: <20090702074618.5C95D317763B@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 26815: [Gtk] text-selection-changed events are not issued for the correct
object when the selection spans multiple objects
https://bugs.webkit.org/show_bug.cgi?id=26815

Attachment 32171: textselection.patch
https://bugs.webkit.org/attachment.cgi?id=32171&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Get the focused node from the selection end.

From bugzilla-daemon at webkit.org  Thu Jul  2 00:48:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 00:48:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26814] [Gtk] Caret-moved
	events are not issued for the correct offset when text is
	selected forward : [Attachment 32172] textcaretmoved.patch
Message-ID: <20090702074840.46098317770C@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 26814: [Gtk] Caret-moved events are not issued for the correct offset when
text is selected forward
https://bugs.webkit.org/show_bug.cgi?id=26814

Attachment 32172: textcaretmoved.patch
https://bugs.webkit.org/attachment.cgi?id=32172&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Report the offset from the end of the selection.

From bugzilla-daemon at webkit.org  Thu Jul  2 03:04:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 03:04:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
	[Attachment 32175] Constant pool for AssemblerBuffer (v3)
Message-ID: <20090702100448.A82D9317AB04@gamma.macosforge.org>

Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32175: Constant pool for AssemblerBuffer (v3)
https://bugs.webkit.org/attachment.cgi?id=32175&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
Reformatted as suggested in comment #62.

From bugzilla-daemon at webkit.org  Thu Jul  2 03:08:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 03:08:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
	[Attachment 32176] Add YARR support for generic ARM platforms (v3)
Message-ID: <20090702100855.0F19D317ACFE@gamma.macosforge.org>

Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32176: Add YARR support for generic ARM platforms (v3)
https://bugs.webkit.org/attachment.cgi?id=32176&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
Reformatted as suggested in comment #63.

From bugzilla-daemon at webkit.org  Thu Jul  2 05:28:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 05:28:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
	[Attachment 32181] Add generic ARM-JIT support using ARMAssembler
Message-ID: <20090702122809.2C8B6317E5E6@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32181: Add generic ARM-JIT support using ARMAssembler
https://bugs.webkit.org/attachment.cgi?id=32181&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 05:51:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 05:51:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
	[Attachment 32182] Floating point support for ARM. Looks like
	we double the number of patches each day :)
Message-ID: <20090702125151.A034A317EF3E@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32182: Floating point support for ARM. Looks like we double the
number of patches each day :)
https://bugs.webkit.org/attachment.cgi?id=32182&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 06:39:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 06:39:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26855] [Qt] New methods for
	QWebFrame to check and set focus. : [Attachment 32086]
	Proposed patch, adds QWebFrame methods for setting/checking focus
Message-ID: <20090702133918.3B3F83180286@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Joseph Ligman
<joseph.ligman at nokia.com>'s request for review:
Bug 26855: [Qt] New methods for QWebFrame to check and set focus.
https://bugs.webkit.org/show_bug.cgi?id=26855

Attachment 32086: Proposed patch, adds QWebFrame methods for setting/checking
focus
https://bugs.webkit.org/attachment.cgi?id=32086&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Looks good to me :)

From bugzilla-daemon at webkit.org  Thu Jul  2 07:15:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 07:15:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26896] [QT] make layout tests
	in fast/css/getComputedStyle/ to pass : [Attachment 32137] patch
Message-ID: <20090702141514.B19FC31811C9@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted 's request for review:
Bug 26896: [QT] make layout tests in fast/css/getComputedStyle/ to pass
https://bugs.webkit.org/show_bug.cgi?id=26896

Attachment 32137: patch
https://bugs.webkit.org/attachment.cgi?id=32137&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Looks good, tried, works. And this time touches only Qt files :)

From bugzilla-daemon at webkit.org  Thu Jul  2 09:07:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:07:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26882] Speed up creation of V8
	wrappers for DOM nodes : [Attachment 32180] Next iteration
Message-ID: <20090702160710.E3F1A31840B8@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied 's request for
review:
Bug 26882: Speed up creation of V8 wrappers for DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=26882

Attachment 32180: Next iteration
https://bugs.webkit.org/attachment.cgi?id=32180&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: ChangeLog
...
> +2009-07-01  anton muhin  <antonm at chromium.org>

nit: your name should be Mixed Case


> +	   Reviewed by NOBODY (OOPS!).
> +
> +				Speed up creation of V8 wrappers for DOM nodes.

> +
> +				https://bugs.webkit.org/show_bug.cgi?id=26882

nit: please do not put tabs in the ChangeLog


> +
> +	   This patch doesn't require new tests as it a set of refactorings
> +				to speed up wrapper creation.
> +
> +	   * ../../../bindings/v8/V8Proxy.cpp:
> +	   * ../../../bindings/v8/V8Proxy.h:
> +

nit: these paths should be relative to the WebCore directory.


> Index: bindings/v8/V8Proxy.h
...
> +	   static v8::Local<v8::Object>
instantiateV8Object(V8ClassIndex::V8WrapperType descType,
V8ClassIndex::V8WrapperType cptrType, void* impl)
> +	   {
> +	     return instantiateV8Object(NULL, descType, cptrType, impl);

nit: indent by 4 spaces

From bugzilla-daemon at webkit.org  Thu Jul  2 09:11:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:11:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26917] Increase delay in
	worker-terminate layout test to make it more reliable. :
	[Attachment 32169] Proposed patch
Message-ID: <20090702161101.BEAD43184277@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 26917: Increase delay in worker-terminate layout test to make it more
reliable.
https://bugs.webkit.org/show_bug.cgi?id=26917

Attachment 32169: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32169&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
R=me, but it sure would be nice if there were a way to construct a
test that wasn't timing sensitive.  Adding delays to the layout
tests just slows down running all of the layout tests, and if 500ms
wasn't enough, then sometimes (maybe only rarely) 1000ms will also
not be enough.

From bugzilla-daemon at webkit.org  Thu Jul  2 09:18:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:18:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26088] large negative
	letter-spacing crashes the chromium port : [Attachment 32153]
	revised patch w/ fishd's comments
Message-ID: <20090702161855.63DED31845AD@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 26088: large negative letter-spacing crashes the chromium port
https://bugs.webkit.org/show_bug.cgi?id=26088

Attachment 32153: revised patch w/ fishd's comments
https://bugs.webkit.org/attachment.cgi?id=32153&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/platform/graphics/chromium/FontChromiumWin.cpp
...
> +    // bug #26088 - init() might fail if layerRect is invalid. Given this,
...
> +	       // webkit bug 26088 - very large positive or negative runs can
fail

nit: would be nice to use a consistent way to refer to bug numbers.  no need
to say webkit since that can be assumed given that this code is part of webkit.


R=me

From bugzilla-daemon at webkit.org  Thu Jul  2 09:21:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:21:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25711] HTML5 Database becomes
	locked if a transaction is in progress when the page is
	refreshed. : [Attachment 32125] New patch.
Message-ID: <20090702162142.7B74331846E0@gamma.macosforge.org>

Antti Koivisto <koivisto at iki.fi> has granted Ben Murdoch <benm at google.com>'s
request for review:
Bug 25711: HTML5 Database becomes locked if a transaction is in progress when
the page is refreshed.
https://bugs.webkit.org/show_bug.cgi?id=25711

Attachment 32125: New patch.
https://bugs.webkit.org/attachment.cgi?id=32125&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
Is it really always true that recordDatabaseOpen/recordDatabaseClose can't get
called in the database thread? If so then obviously you won't need mutexes, but
please make sure.

> +    // Close the databases that we ran transactions on. This ensures that if
any transactions are still open, they are rolled back and we don't leave the
database in an
> +    // inconsistent or locked state.
> +    if (m_openDatabaseSet.size() > 0) {
> +	   // As the call to close will modify the original set, we must take a
copy to iterate over.
> +	   DatabaseSet openSetCopy = m_openDatabaseSet;
> +	   DatabaseSet::iterator end = openSetCopy.end();
> +	   for (DatabaseSet::iterator it = openSetCopy.begin(); it != end;
++it)
> +	      (*it)->close();

You should use HashSet::swap() instead of making a copy before iterating.

r=me with swap()

From bugzilla-daemon at webkit.org  Thu Jul  2 09:34:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:34:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32088] Xcode change for Mac build.
Message-ID: <20090702163416.14F3C3184C8C@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32088: Xcode change for Mac build.
https://bugs.webkit.org/attachment.cgi?id=32088&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul  2 09:47:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:47:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32087] Revised per Eric's comments.
Message-ID: <20090702164721.9C0833185255@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32087: Revised per Eric's comments.
https://bugs.webkit.org/attachment.cgi?id=32087&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +2009-06-30  U-bfulgham-PC\bfulgham  <bfulgham at webkit.org>

Looks like you need to set REAL_NAME on this computer.

> +	   * DumpRenderTree/PixelDumpSupport.cpp: Added.
> +	   (dumpWebViewAsPixelsAndCompareWithExpected):
> +	   (printPNG):
> +	   * DumpRenderTree/PixelDumpSupport.h:
> +	   * DumpRenderTree/cairo: Added.
> +	   * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp: Added.
> +	   (writeFunction):
> +	   (printPNG):
> +	   (computeMD5HashStringForBitmapContext):
> +	   (dumpBitmap):
> +	   * DumpRenderTree/cairo/PixelDumpSupportCairo.h: Added.
> +	   (BitmapContext::createByAdoptingBitmapAndContext):
> +	   (BitmapContext::~BitmapContext):
> +	   (BitmapContext::cairoContext):
> +	   (BitmapContext::BitmapContext):
> +	   * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
> +	   (printPNG):
> +	   (computeMD5HashStringForBitmapContext):
> +	   (dumpBitmap):
> +	   * DumpRenderTree/cg/PixelDumpSupportCG.h:
> +	   * DumpRenderTree/win/DumpRenderTree.cpp:
> +	   (main):
> +	   * DumpRenderTree/win/DumpRenderTree.vcproj:
> +	   * DumpRenderTree/win/PixelDumpSupportWin.cpp:
> +	   (createBitmapContextFromWebView):

It would be good to add more detailed comments about what you changed next to
each function/file.

> +#include "config.h"
> +#include "PixelDumpSupport.h"
> +#if PLATFORM(CG)
> +#include <CoreGraphics/CGBitmapContext.h>
> +#include "PixelDumpSupportCG.h"
> +#else
> +#include <cairo-win32.h>
> +#include "PixelDumpSupportCairo.h"
> +#endif
> +
> +#include "DumpRenderTree.h"
> +#include "LayoutTestController.h"
> +#include <wtf/Assertions.h>
> +#include <wtf/RefPtr.h>
> +#include <wtf/RetainPtr.h>

I'm not sure I understand why we need to include any port-specific headers
here. Can the declarations of the required functions move to
PixelDumpSupport.h?

> +#if PLATFORM(WIN)
> +static const CFStringRef kUTTypePNG = CFSTR("public.png");
> +#endif

I don't think this is needed in PixelDumpSupportCairo.

> +    const size_t dataLength = pixeldata.size ();
> +    const unsigned char* data = &pixeldata[0];
> +
> +    printPNG (dataLength, data);

Please remove the spaces after the function names.

pixeldata.data() would be better than &pixeldata[0]. pixeldata should probably
be renamed to pixelData.

> +void computeMD5HashStringForBitmapContext(RefPtr<BitmapContext> context,
char hashString[33])

context's type should be BitmapContext*.

> +    // We need to swap the bytes to ensure consistent hashes independently
of endianness

Your code doesn't seem to take endianness into account. Should this turn into a
FIXME? Be removed entirely?

> +void dumpBitmap(RefPtr<BitmapContext> context)

context's type should be BitmapContext*.

> +{
> +    cairo_surface_t* surface = cairo_get_target(context->cairoContext());
> +    printPNG(surface);
> +}
> \ No newline at end of file

Please add a newline.

> +    RetainPtr<CairoContextRef> m_context;

It seems unlikely that RetainPtr is the right smart pointer for holding a
CairoContextRef. Is it really right to use CFRetain/CFRelease with a
CairoContextRef?

> +#endif // PixelDumpSupportCairo_h
> \ No newline at end of file

Please add a newline.

From bugzilla-daemon at webkit.org  Thu Jul  2 09:47:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:47:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26490] Add isFinite method
	to floating point types. : [Attachment 32185] Add 'isFinite'
	operator to floating point types
Message-ID: <20090702164749.A4D2E3185289@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 26490: Add isFinite method to floating point types.
https://bugs.webkit.org/show_bug.cgi?id=26490

Attachment 32185: Add 'isFinite' operator to floating point types
https://bugs.webkit.org/attachment.cgi?id=32185&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
I put this patch together and realized the only place it's really useful (so
far) is in the ImageCairo.cpp file.  Is this change really worth it?

I didn't bother writing changelog, etc., since it seems like the patch is sort
of useless unless several routines are changed from using sets of bare
float/double values to the corresponding WebKit types.

Examples:
(1)  html/CanvasRenderingContext2D.cpp is passed the individual ordinates as
separate values (rather than as a single WebKit type) that are then tested for
finite-ness.
(2) page/DOMWindow.cpp tests for 'isfinite' in separate ASSERTs, but I don't
think the code is helped by using a WebKit type check here, as it would lose
the ability to see which ASSERT is failing.

From bugzilla-daemon at webkit.org  Thu Jul  2 09:54:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:54:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26923]
	<rdar://problem/6933052> SPOD playing video in a div with a
	box shadow : [Attachment 32186] Patch
Message-ID: <20090702165429.E576B31855C2@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 26923: <rdar://problem/6933052> SPOD playing video in a div with a box
shadow
https://bugs.webkit.org/show_bug.cgi?id=26923

Attachment 32186: Patch
https://bugs.webkit.org/attachment.cgi?id=32186&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 09:57:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 09:57:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22119] [Transforms] clicks
	in scrollbars of transformed element don't work (e.g. listbox
	or overflow) : [Attachment 32161] Almost done patch;
	needs ScrollbarClient cleanup
Message-ID: <20090702165739.0458B3185722@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 22119: [Transforms] clicks in scrollbars of transformed element don't work
(e.g. listbox or overflow)
https://bugs.webkit.org/show_bug.cgi?id=22119

Attachment 32161: Almost done patch; needs ScrollbarClient cleanup
https://bugs.webkit.org/attachment.cgi?id=32161&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 10:02:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 10:02:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 22119] [Transforms] clicks in
	scrollbars of transformed element don't work (e.g. listbox or
	overflow) : [Attachment 32161] Almost done patch;
	needs ScrollbarClient cleanup
Message-ID: <20090702170227.E30EB3185933@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 22119: [Transforms] clicks in scrollbars of transformed element don't work
(e.g. listbox or overflow)
https://bugs.webkit.org/show_bug.cgi?id=22119

Attachment 32161: Almost done patch; needs ScrollbarClient cleanup
https://bugs.webkit.org/attachment.cgi?id=32161&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 10:08:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 10:08:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26923]
	<rdar://problem/6933052> SPOD playing video in a div with a
	box shadow : [Attachment 32186] Patch
Message-ID: <20090702170847.197F63185BD9@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 26923: <rdar://problem/6933052> SPOD playing video in a div with a box
shadow
https://bugs.webkit.org/show_bug.cgi?id=26923

Attachment 32186: Patch
https://bugs.webkit.org/attachment.cgi?id=32186&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me, typo in changelog ("purely")

From bugzilla-daemon at webkit.org  Thu Jul  2 10:33:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 10:33:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26924] [Chromium] Linux:
	fix assertion when rendering google.com.kh. : [Attachment
	32187] patch
Message-ID: <20090702173332.53F11318668D@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26924: [Chromium] Linux: fix assertion when rendering google.com.kh.
https://bugs.webkit.org/show_bug.cgi?id=26924

Attachment 32187: patch
https://bugs.webkit.org/attachment.cgi?id=32187&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 11:09:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 11:09:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26926]
	StringsNotToBeLocalized.txt is out-of-date : [Attachment
	32188] patch v1 + ChangeLog
Message-ID: <20090702180917.17FD531874F6@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 26926: StringsNotToBeLocalized.txt is out-of-date
https://bugs.webkit.org/show_bug.cgi?id=26926

Attachment 32188: patch v1 + ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32188&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 11:12:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 11:12:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26926]
	StringsNotToBeLocalized.txt is out-of-date : [Attachment
	32188] patch v1 + ChangeLog
Message-ID: <20090702181245.C5E24318769A@gamma.macosforge.org>

John Sullivan <sullivan at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 26926: StringsNotToBeLocalized.txt is out-of-date
https://bugs.webkit.org/show_bug.cgi?id=26926

Attachment 32188: patch v1 + ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32188&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
Thanks for clearing the cobwebs.

From bugzilla-daemon at webkit.org  Thu Jul  2 11:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 11:17:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32189] Revised per Adam's comments.
Message-ID: <20090702181759.292A831878EC@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32189: Revised per Adam's comments.
https://bugs.webkit.org/attachment.cgi?id=32189&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 11:18:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 11:18:52 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26924] [Chromium] Linux: fix
	assertion when rendering google.com.kh. : [Attachment 32187] patch
Message-ID: <20090702181852.D69643187947@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 26924: [Chromium] Linux: fix assertion when rendering google.com.kh.
https://bugs.webkit.org/show_bug.cgi?id=26924

Attachment 32187: patch
https://bugs.webkit.org/attachment.cgi?id=32187&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Needs a layout test, or explanation as to why one is impossible.

I assume one is impossible because this requires special fonts to be installed?

From bugzilla-daemon at webkit.org  Thu Jul  2 11:25:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 11:25:21 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32189] Revised per Adam's comments.
Message-ID: <20090702182521.65D443187BE4@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has cancelled Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32189: Revised per Adam's comments.
https://bugs.webkit.org/attachment.cgi?id=32189&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 11:25:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 11:25:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32190] Revised per Adam's comments
	(better).
Message-ID: <20090702182521.6E6EA3187BE6@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32190: Revised per Adam's comments (better).
https://bugs.webkit.org/attachment.cgi?id=32190&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 12:20:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 12:20:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26620] Haiku WebKit port :
	[Attachment 32049] Patch to add Haiku-specific files for
	JavaScriptCore.
Message-ID: <20090702192010.32F10318934B@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32049: Patch to add Haiku-specific files for JavaScriptCore.
https://bugs.webkit.org/attachment.cgi?id=32049&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 12:21:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 12:21:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26620] Haiku WebKit port :
	[Attachment 32053] Patch to add Haiku-specific files for
	WebCore/platform/image-decoders/.
Message-ID: <20090702192133.39BBC3189410@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32053: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32053&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK, but the ChangeLog doesn't need:

WARNING: NO TEST CASES ADDED OR CHANGED

From bugzilla-daemon at webkit.org  Thu Jul  2 12:52:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 12:52:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26929]
	convertFromScrollbarToContainingView and friends should be in
	ScrollView : [Attachment 32191] patch
Message-ID: <20090702195259.ABE2F318A19F@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 26929: convertFromScrollbarToContainingView and friends should be in
ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

Attachment 32191: patch
https://bugs.webkit.org/attachment.cgi?id=32191&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 12:59:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 12:59:37 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26929]
	convertFromScrollbarToContainingView and friends should be in
	ScrollView : [Attachment 32191] patch
Message-ID: <20090702195937.E5B2A318A46E@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 26929: convertFromScrollbarToContainingView and friends should be in
ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

Attachment 32191: patch
https://bugs.webkit.org/attachment.cgi?id=32191&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Remove the FIXME: Test on Windows.  I forgot to do that. Oops.

You can devirtualize the methods once you move them to ScrollView.

From bugzilla-daemon at webkit.org  Thu Jul  2 13:00:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:00:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26872] Crash indenting a
	table cell : [Attachment 32167] Fixes crash.
Message-ID: <20090702200020.8F263318A4B3@gamma.macosforge.org>

Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 26872: Crash indenting a table cell
https://bugs.webkit.org/show_bug.cgi?id=26872

Attachment 32167: Fixes crash.
https://bugs.webkit.org/attachment.cgi?id=32167&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 13:13:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:13:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26929]
	convertFromScrollbarToContainingView and friends should be in
	ScrollView : [Attachment 32194] Remove unused functions
Message-ID: <20090702201322.74893318A9E9@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 26929: convertFromScrollbarToContainingView and friends should be in
ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

Attachment 32194: Remove unused functions
https://bugs.webkit.org/attachment.cgi?id=32194&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 13:16:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:16:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26929]
	convertFromScrollbarToContainingView and friends should be in
	ScrollView : [Attachment 32194] Remove unused functions
Message-ID: <20090702201658.337AC318AB39@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 26929: convertFromScrollbarToContainingView and friends should be in
ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

Attachment 32194: Remove unused functions
https://bugs.webkit.org/attachment.cgi?id=32194&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
The previous patch is right.

From bugzilla-daemon at webkit.org  Thu Jul  2 13:17:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:17:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26929]
	convertFromScrollbarToContainingView and friends should be in
	ScrollView : [Attachment 32191] patch
Message-ID: <20090702201710.32D8B318AB56@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted 's request for review:
Bug 26929: convertFromScrollbarToContainingView and friends should be in
ScrollView
https://bugs.webkit.org/show_bug.cgi?id=26929

Attachment 32191: patch
https://bugs.webkit.org/attachment.cgi?id=32191&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
This is the right one!

From bugzilla-daemon at webkit.org  Thu Jul  2 13:45:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:45:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26933] Replaced elements
	should simply always clip to border-radius : [Attachment
	32195] Patch
Message-ID: <20090702204529.BA137318B70F@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 26933: Replaced elements should simply always clip to border-radius
https://bugs.webkit.org/show_bug.cgi?id=26933

Attachment 32195: Patch
https://bugs.webkit.org/attachment.cgi?id=32195&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 13:47:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:47:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26933] Replaced elements
	should simply always clip to border-radius : [Attachment
	32195] Patch
Message-ID: <20090702204717.B5F69318B7D5@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 26933: Replaced elements should simply always clip to border-radius
https://bugs.webkit.org/show_bug.cgi?id=26933

Attachment 32195: Patch
https://bugs.webkit.org/attachment.cgi?id=32195&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 13:51:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 13:51:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
	ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs :
	[Attachment 32196] proposed patch
Message-ID: <20090702205132.4FEA0318B9AC@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32196: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32196&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 14:16:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:16:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26934] [Qt] It would be
	useful to have methods for scrolling QWebElement :
	[Attachment 32197] Proposed patch,
	for adding scrolling to QWebElement
Message-ID: <20090702211658.17891318C4C1@gamma.macosforge.org>

Joseph Ligman <joseph.ligman at nokia.com> has asked  for review:
Bug 26934: [Qt] It would be useful to have methods for scrolling QWebElement
https://bugs.webkit.org/show_bug.cgi?id=26934

Attachment 32197: Proposed patch, for adding scrolling to QWebElement
https://bugs.webkit.org/attachment.cgi?id=32197&action=review

------- Additional Comments from Joseph Ligman <joseph.ligman at nokia.com>
I'm not sure what is the correct API, but something like this would be useful
for me anyway.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:23:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:23:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32190] Revised per Adam's comments
	(better).
Message-ID: <20090702212329.2F66A318C7E7@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32190: Revised per Adam's comments (better).
https://bugs.webkit.org/attachment.cgi?id=32190&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
There's a newer version of the license header in
WebCore/html/PreloadScanner.cpp. Please use that template for new files.

> +	   * DumpRenderTree/PixelDumpSupport.h: Add declaration for new
> +	     common pringPNG function.

Typo: pringPNG

> +    printPNG (dataLength, data);

Please remove the space after "printPNG".

> +typedef struct _cairo* CairoContextRef;

I thought there was a cairo_t typedef. Maybe there's some reason we can't use
that name here.

> +    BitmapContext(PlatformBitmapBuffer buffer, CairoContextRef context)
> +	   : m_buffer(buffer)
> +	   , m_context(context)
> +    {
> +    }
> +
> +    PlatformBitmapBuffer m_buffer;
> +    CairoContextRef m_context;

Do we need to retain/release m_context (using the appropriate Cairo functions)?


r=me

From bugzilla-daemon at webkit.org  Thu Jul  2 14:26:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:26:59 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 17052] Scrolling with arrow
	keys does not update cursor : [Attachment 31822] Addressed comments
Message-ID: <20090702212659.F0BF0318C950@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 17052: Scrolling with arrow keys does not update cursor
https://bugs.webkit.org/show_bug.cgi?id=17052

Attachment 31822: Addressed comments
https://bugs.webkit.org/attachment.cgi?id=31822&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok.  What I need from you to r+ this patch, is I need explanation as to why
this is the correct fix.  The fix itself looks fine, but why is this the right
way to fix this?  Why does Mac not need this code for example?	Try the example
on a Mac with a scroll wheel mouse and you'll see cursor updates work as
expected.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:27:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:27:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32198] patch4
Message-ID: <20090702212718.6D71B318C986@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32198: patch4
https://bugs.webkit.org/attachment.cgi?id=32198&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 14:34:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:34:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
	ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs :
	[Attachment 32199] proposed patch
Message-ID: <20090702213405.70493318CC8B@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32199: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32199&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Removed unnecessary braces from V8SharedWorkerCustom

From bugzilla-daemon at webkit.org  Thu Jul  2 14:34:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:34:05 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26932] Add
	ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs :
	[Attachment 32196] proposed patch
Message-ID: <20090702213405.65A76318CC89@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has cancelled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32196: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32196&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Removed unnecessary braces from V8SharedWorkerCustom

From bugzilla-daemon at webkit.org  Thu Jul  2 14:34:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:34:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26872] Crash indenting a
	table cell : [Attachment 32167] Fixes crash.
Message-ID: <20090702213407.5064D318CCA1@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 26872: Crash indenting a table cell
https://bugs.webkit.org/show_bug.cgi?id=26872

Attachment 32167: Fixes crash.
https://bugs.webkit.org/attachment.cgi?id=32167&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
The fix looks fine to me.  I'm not sure if it's at the right layer or not. 
Justin would know that better.

I assume <td> and root contentEditable nodes are the only non-splitable nodes?

Justin has historically been very slow to respond to Bugzilla bugs, so I'm
going to go ahead and r+ this and we can roll it out or fix it differently if
Justin later comments and feels it should be done at a different level.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:40:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:40:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32054] Patch to add Haiku-specific files for
	WebCore/platform/text/.
Message-ID: <20090702214013.A37F8318CF43@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32054: Patch to add Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/attachment.cgi?id=32054&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems you might want a notImplemnted() at:
+const char* currentTextBreakLocaleID()

Again, don't need:
+	 WARNING: NO TEST CASES ADDED OR CHANGED

Since someone would have to manually fix your ChangeLogs, gonna r- this.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:40:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:40:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32058] Patch to add Haiku-specific files for
	WebCore/platform/.
Message-ID: <20090702214035.4B810318CF77@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32058: Patch to add Haiku-specific files for WebCore/platform/.
https://bugs.webkit.org/attachment.cgi?id=32058&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Too large to review.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:41:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:41:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32060] Patch to add WebCore support.
Message-ID: <20090702214104.E33BA318CFBF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32060: Patch to add WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32060&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Too large to review.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:41:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:41:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32069] Patch to add Haiku-specific files for
	WebCore/bindings/js/.
Message-ID: <20090702214139.6EF18318D025@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32069: Patch to add Haiku-specific files for WebCore/bindings/js/.
https://bugs.webkit.org/attachment.cgi?id=32069&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 8	   WARNING: NO TEST CASES ADDED OR CHANGED

is not needed.	Otherwise this looks great.  r- because someone would have to
manually edit your ChangeLogs when landing.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:42:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:42:45 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32071] Patch to add Haiku-specific files for
	WebCore/editing/.
Message-ID: <20090702214245.B2F29318D0BF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32071: Patch to add Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/attachment.cgi?id=32071&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.  Where is the implementation of ClipboardHaiku?

R- for someone having to edit your ChangeLogs when landing:
+	 WARNING: NO TEST CASES ADDED OR CHANGED

(If you were a committer I would just r+ all these, but as is, it's best if you
fix them first so they can be landed automatically by our scripts.)

From bugzilla-daemon at webkit.org  Thu Jul  2 14:44:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:44:31 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32073] Patch to add Haiku-specific files for
	WebCore/page/.
Message-ID: <20090702214431.7B104318D1A8@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32073: Patch to add Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/attachment.cgi?id=32073&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please don't include commented out code:
 //#include "Frame.h"
 32 //#include "FrameView.h"
 33 //#include "Page.h"
 
 108	 //notImplemented();


Looks OK otherwise.  Please remove extra comments and update changeLog and
re-post.  I would have r+'d this if you were a committer.

 8	   WARNING: NO TEST CASES ADDED OR CHANGED

From bugzilla-daemon at webkit.org  Thu Jul  2 14:47:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:47:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26935] [Chromium] Linux:
	fix complex text rendering with line break characters :
	[Attachment 32200] patch
Message-ID: <20090702214758.092CB318D326@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26935: [Chromium] Linux: fix complex text rendering with line break
characters
https://bugs.webkit.org/show_bug.cgi?id=26935

Attachment 32200: patch
https://bugs.webkit.org/attachment.cgi?id=32200&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 14:49:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:49:50 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32076] Patch to add Haiku-specific files for
	WebCore/platform/graphics/.
Message-ID: <20090702214950.6AF48318D422@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32076: Patch to add Haiku-specific files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32076&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
What is a styleable port?
 45	// FIXME: subtract 1 from height and width? This was not done in
Syllable port

I don't think you meant to leaven this in:
 52	printf("FontCache::getFontDataForCharacters\n");    

WebKit generally uses 0 for NULL in C++ code:
 72	pcDefaultFont->GetFamilyAndStyle(&family, NULL);

Please use c++ style casts:
 76	//return new FontPlatformData(fontDescription, (BFont*)pcDefaultFont);

We don't commit commented out code:
 76	//return new FontPlatformData(fontDescription, (BFont*)pcDefaultFont);

Style:
83     if (!pcData->font())
 84	{

You should consider using an OwnPtr here:
 82	FontPlatformData* pcData = new FontPlatformData(fontDescription,
family);

Style:
 51 int char_unicode_to_utf8(unsigned short glyph, char* out) {

Tabs will cause the commit to fail:
54	if (glyph < 0x0080)
 55		out[i++] = (char)glyph;

Indent:
{
 74	notImplemented();
 75	return true;
 76 }

Why?
 43 int char_unicode_to_utf8(unsigned short glyph, char* out); // implemented
in FontDataHaiku.cpp

Please use C++ style casts:
 57	BView* view = (BView*)graphicsContext->platformContext();

Double converting to float:
 float Font::floatWidthForComplexText(const TextRun& run, HashSet<const
SimpleFontData*>* fallbackFonts) const
 83 {
 84	notImplemented();
 85	return 3.0;

Style:
59     if (f.m_font)
 60	{
 61	    m_font = new BFont(f.m_font);
 62	}

Extra spaces and bad variable name:
 71	font_family	fam;

STyle:
 74	for(int i = 0; i < count_font_families(); i++) {


Please break this up into smaller patches.

Please do fewer patches per-bug.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:50:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:50:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
	[Attachment 32053] Patch to add Haiku-specific files for
	WebCore/platform/image-decoders/.
Message-ID: <20090702215035.653E3318D4A1@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32053: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32053&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Since you're not a committer this can't be landed by you. Please upload a new
one with 
 8	   WARNING: NO TEST CASES ADDED OR CHANGED

removed.  otherwise it looked fine.

From bugzilla-daemon at webkit.org  Thu Jul  2 14:53:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 14:53:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26935] [Chromium] Linux: fix
	complex text rendering with line break characters :
	[Attachment 32200] patch
Message-ID: <20090702215351.1E76E318D60C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 26935: [Chromium] Linux: fix complex text rendering with line break
characters
https://bugs.webkit.org/show_bug.cgi?id=26935

Attachment 32200: patch
https://bugs.webkit.org/attachment.cgi?id=32200&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yay for nice ChangeLogs! :)

I believe the { goes on the same line as the enum:
+enum
+{

Nice use of self-documenting constants, btw. :)

Looks fine. I'll ask you in person to make sure we're doing this in a similar
manner to the other complex text paths (which I know have similar code).

From bugzilla-daemon at webkit.org  Thu Jul  2 15:11:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 15:11:05 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26935] [Chromium] Linux: fix
	complex text rendering with line break characters :
	[Attachment 32200] patch
Message-ID: <20090702221105.09AFE318DCE3@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied 's request for review:
Bug 26935: [Chromium] Linux: fix complex text rendering with line break
characters
https://bugs.webkit.org/show_bug.cgi?id=26935

Attachment 32200: patch
https://bugs.webkit.org/attachment.cgi?id=32200&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Adam and I discussed this in person and he decided this would require further
revision.

From bugzilla-daemon at webkit.org  Thu Jul  2 15:16:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 15:16:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32198] patch4
Message-ID: <20090702221625.6DE05318DF24@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32198: patch4
https://bugs.webkit.org/attachment.cgi?id=32198&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few last things to address:

> Index: WebCore/bindings/v8/V8Binding.cpp
> +class WebCoreStringResource : public v8::String::ExternalStringResource {
> +public:
> +    explicit WebCoreStringResource(const String& string)
> +	   : m_impl(string.impl()) { }

The { } should go on separate lines (since you have initializers).


> +String v8StringToWebCoreString(v8::Handle<v8::String> v8String, bool
externalize)
> +{
...
> +
> +    int length = v8String->Length();
> +    if (length) {

if (!length)



> +String v8ValueToWebCoreString(v8::Handle<v8::Value> object)
> +{
...
> +	   return webCoreString;
> +    } else {

This else should go away since there is a "return" finishing the previous
block.

From bugzilla-daemon at webkit.org  Thu Jul  2 15:24:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 15:24:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26935] [Chromium] Linux:
	fix complex text rendering with line break characters :
	[Attachment 32201] patch
Message-ID: <20090702222423.26414318E245@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26935: [Chromium] Linux: fix complex text rendering with line break
characters
https://bugs.webkit.org/show_bug.cgi?id=26935

Attachment 32201: patch
https://bugs.webkit.org/attachment.cgi?id=32201&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
After testing with some of the other values that I believed should be
substituted for spaces, it seems that treatAsSpace is correct. None of the
other values are causing issues. Either they are handled somewhere else, or the
font's cmap is handling them.

From bugzilla-daemon at webkit.org  Thu Jul  2 15:25:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 15:25:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26935] [Chromium] Linux: fix
	complex text rendering with line break characters :
	[Attachment 32201] patch
Message-ID: <20090702222534.7C0A2318E2CC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 26935: [Chromium] Linux: fix complex text rendering with line break
characters
https://bugs.webkit.org/show_bug.cgi?id=26935

Attachment 32201: patch
https://bugs.webkit.org/attachment.cgi?id=32201&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul  2 15:47:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 15:47:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26924] [Chromium] Linux:
	fix assertion when rendering google.com.kh. : [Attachment
	32202] patch
Message-ID: <20090702224703.5A407318EB77@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked  for review:
Bug 26924: [Chromium] Linux: fix assertion when rendering google.com.kh.
https://bugs.webkit.org/show_bug.cgi?id=26924

Attachment 32202: patch
https://bugs.webkit.org/attachment.cgi?id=32202&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 15:47:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 15:47:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26924] [Chromium] Linux:
	fix assertion when rendering google.com.kh. : [Attachment
	32202] patch
Message-ID: <20090702224713.6AEBD318EB98@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26924: [Chromium] Linux: fix assertion when rendering google.com.kh.
https://bugs.webkit.org/show_bug.cgi?id=26924

Attachment 32202: patch
https://bugs.webkit.org/attachment.cgi?id=32202&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 16:14:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:14:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26939]
	http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html :
	[Attachment 32203] patch v1.
Message-ID: <20090702231449.251EF318F741@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26939: http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html
https://bugs.webkit.org/show_bug.cgi?id=26939

Attachment 32203: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32203&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 16:24:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:24:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26913] bugzilla-tool needs
	to handle login failure : [Attachment 32204] patch
Message-ID: <20090702232436.97DF0318FADD@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26913: bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913

Attachment 32204: patch
https://bugs.webkit.org/attachment.cgi?id=32204&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 16:29:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:29:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] Add a SQLite VFS for
	Chromium : [Attachment 32205] win patch
Message-ID: <20090702232916.14D0E318FCEF@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32205: win patch
https://bugs.webkit.org/attachment.cgi?id=32205&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
SQLite VFS: only the code that deals directly with files was slightly modified.

FileSystem: openDatabase() uses "chromium_vfs" to open files, all other
functions are either very simple or delegate to ChromiumBridge.

From bugzilla-daemon at webkit.org  Thu Jul  2 16:31:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:31:58 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26940] Add a SQLite VFS for
	Chromium : [Attachment 32205] win patch
Message-ID: <20090702233158.D940A318FDC0@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has cancelled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32205: win patch
https://bugs.webkit.org/attachment.cgi?id=32205&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Attached the wrong patch...

From bugzilla-daemon at webkit.org  Thu Jul  2 16:31:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:31:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] Add a SQLite VFS for
	Chromium : [Attachment 32206] win patch
Message-ID: <20090702233158.E1941318FDC2@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32206: win patch
https://bugs.webkit.org/attachment.cgi?id=32206&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Attached the wrong patch...

From bugzilla-daemon at webkit.org  Thu Jul  2 16:39:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:39:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26942] Dump As Text doing
	the wrong thing when overflow is set on replaced elements :
	[Attachment 32207] Patch
Message-ID: <20090702233950.A42563190084@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 26942: Dump As Text doing the wrong thing when overflow is set on replaced
elements
https://bugs.webkit.org/show_bug.cgi?id=26942

Attachment 32207: Patch
https://bugs.webkit.org/attachment.cgi?id=32207&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 16:41:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:41:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26942] Dump As Text doing the
	wrong thing when overflow is set on replaced elements :
	[Attachment 32207] Patch
Message-ID: <20090702234137.219A03190141@gamma.macosforge.org>

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 26942: Dump As Text doing the wrong thing when overflow is set on replaced
elements
https://bugs.webkit.org/show_bug.cgi?id=26942

Attachment 32207: Patch
https://bugs.webkit.org/attachment.cgi?id=32207&action=review

------- Additional Comments from mitz at webkit.org
r=me assuming the find-on-page tests that were added with Darin?s change still
pass

From bugzilla-daemon at webkit.org  Thu Jul  2 16:42:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:42:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26913] bugzilla-tool needs to
	handle login failure : [Attachment 32204] patch
Message-ID: <20090702234235.976D931901B3@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26913: bugzilla-tool needs to handle login failure
https://bugs.webkit.org/show_bug.cgi?id=26913

Attachment 32204: patch
https://bugs.webkit.org/attachment.cgi?id=32204&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKitTools/Scripts/modules/bugzilla.py
b/WebKitTools/Scripts/modules/bugzilla.py
> +	   match = re.search("<title>(.+)</title>", response.read())

You could do a non-greedy match here like this "<title>(.+?)</title>" (which
would be more typical for grabbing the context of just one tag) but it isn't
necessary here.

From bugzilla-daemon at webkit.org  Thu Jul  2 16:47:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:47:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26943] Transitions restart
	sometimes when they shouldn't : [Attachment 32210] Patch with test
Message-ID: <20090702234704.637AE3190358@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 26943: Transitions restart sometimes when they shouldn't
https://bugs.webkit.org/show_bug.cgi?id=26943

Attachment 32210: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32210&action=review

------- Additional Comments from Chris Marrin <cmarrin at apple.com>
NOTE: Please don't review this patch until we have done some tests with more
complex content.

From bugzilla-daemon at webkit.org  Thu Jul  2 16:51:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:51:13 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26670] [Win] REGRESSION
	(r37793): Hitting back button on Google often gives
	non-interactive Google page : [Attachment 31766] patch
	authored by oliver
Message-ID: <20090702235113.BFF0531904E3@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has cancelled Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 26670: [Win] REGRESSION (r37793): Hitting back button on Google often gives
non-interactive Google page
https://bugs.webkit.org/show_bug.cgi?id=26670

Attachment 31766: patch authored by oliver
https://bugs.webkit.org/attachment.cgi?id=31766&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 16:51:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:51:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26670] [Win] REGRESSION
	(r37793): Hitting back button on Google often gives
	non-interactive Google page : [Attachment 32211] fix with changelog
Message-ID: <20090702235113.CBFAD31904E5@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 26670: [Win] REGRESSION (r37793): Hitting back button on Google often gives
non-interactive Google page
https://bugs.webkit.org/show_bug.cgi?id=26670

Attachment 32211: fix with changelog
https://bugs.webkit.org/attachment.cgi?id=32211&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 16:51:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:51:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26670] [Win] REGRESSION
	(r37793): Hitting back button on Google often gives
	non-interactive Google page : [Attachment 32211] fix with changelog
Message-ID: <20090702235159.1AEA7319052D@gamma.macosforge.org>

Anders Carlsson <andersca at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 26670: [Win] REGRESSION (r37793): Hitting back button on Google often gives
non-interactive Google page
https://bugs.webkit.org/show_bug.cgi?id=26670

Attachment 32211: fix with changelog
https://bugs.webkit.org/attachment.cgi?id=32211&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul  2 16:56:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 16:56:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26939] MediaUI look is badly
	rendered on
	http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html :
	[Attachment 32203] patch v1.
Message-ID: <20090702235610.054CA3190733@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26939: MediaUI look is badly rendered on
http://www.mozilla.com/en-US/firefox/video/firefox-3.5.html
https://bugs.webkit.org/show_bug.cgi?id=26939

Attachment 32203: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32203&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 17:00:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 17:00:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32212] patch5
Message-ID: <20090703000056.7513331908E2@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32212: patch5
https://bugs.webkit.org/attachment.cgi?id=32212&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 17:06:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 17:06:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26857] [Chromium] Upstream
	V8Binding : [Attachment 32212] patch5
Message-ID: <20090703000646.CBC593190AD4@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 26857: [Chromium] Upstream V8Binding
https://bugs.webkit.org/show_bug.cgi?id=26857

Attachment 32212: patch5
https://bugs.webkit.org/attachment.cgi?id=32212&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 17:39:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 17:39:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26944] Media controls
	doesn't scale properly : [Attachment 32213] patch v1.
Message-ID: <20090703003934.CA9E53191812@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26944: Media controls doesn't scale properly
https://bugs.webkit.org/show_bug.cgi?id=26944

Attachment 32213: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32213&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 17:45:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 17:45:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26944] Media controls doesn't
	scale properly : [Attachment 32213] patch v1.
Message-ID: <20090703004501.E81673191A30@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26944: Media controls doesn't scale properly
https://bugs.webkit.org/show_bug.cgi?id=26944

Attachment 32213: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32213&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 17:49:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 17:49:50 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32088] Xcode change for Mac build.
Message-ID: <20090703004950.AB1183191BD7@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has cancelled 's request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32088: Xcode change for Mac build.
https://bugs.webkit.org/attachment.cgi?id=32088&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 17:49:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 17:49:51 -0700 (PDT)
Subject: [webkit-reviews] review cancelled: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32190] Revised per Adam's comments
	(better).
Message-ID: <20090703004951.DBCAC3191BE2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has cancelled 's request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32190: Revised per Adam's comments (better).
https://bugs.webkit.org/attachment.cgi?id=32190&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 18:02:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 18:02:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26790] ParserArenaDeletable
	should override delete : [Attachment 32038] Overeride
	ParserArenaDeletable delete
Message-ID: <20090703010228.AC66431920EA@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32038: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32038&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 18:12:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 18:12:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26457] Build DumpRenderTree
	under Cairo : [Attachment 32214] Workaround for build.
Message-ID: <20090703011221.2BE5131924E9@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32214: Workaround for build.
https://bugs.webkit.org/attachment.cgi?id=32214&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 18:45:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 18:45:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26262] Implement HTML5
	draggable : [Attachment 32215] Patch
Message-ID: <20090703014505.5AE17319309A@gamma.macosforge.org>

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32215: Patch
https://bugs.webkit.org/attachment.cgi?id=32215&action=review

From bugzilla-daemon at webkit.org  Thu Jul  2 21:18:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 21:18:54 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32199] proposed patch
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090703041854.97B52319CE6A@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32199: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32199&action=edit

------- Additional Comments from David Levin <levin at chromium.org>
This looks good in general.  There are a few things to address at the moment,
but it is looking good.


> diff --git a/LayoutTests/fast/workers/shared-worker-constructor.html-disabled
b/LayoutTests/fast/workers/shared-worker-constructor.html-disabled
> +try {
> +    new SharedWorker({toString:function(){throw "exception"}}, "name")
> +    log("FAIL: toString exception not propagated.");

According to
http://www.whatwg.org/specs/web-workers/current-work/#runtime-script-errors,

"Whenever a runtime script error occurs in one of the worker's scripts, if the
error did not occur while handling a previous script error, the user agent must
report the error using the WorkerGlobalScope object's onerror attribute.

For shared workers, if the error is still not handled afterwards, or if the
error occurred while handling a previous script error, the error should be
reported to the user."

So it sounds this the exception should not be propogated.


> +try {
> +    var foo = {toString:function(){new Worker(foo)}}
> +    new SharedWorker(foo, name);
> +    log("FAIL: no exception when trying to create workers recursively");

Same comment as above.


> diff --git a/WebCore/DerivedSources.make b/WebCore/DerivedSources.make
> +webcore_built_sources += \
> +	WebCore/bindings/js/JSAbstractWorkerCustom.cpp \
> +	WebCore/bindings/js/JSSharedWorkerConstructor.cpp \
> +	WebCore/bindings/js/JSSharedWorkerCustom.cpp \
> +	WebCore/workers/AbstractWorker.cpp \
> +	WebCore/workers/AbstractWorker.h \
> +	WebCore/workers/SharedWorker.cpp \
> +	WebCore/workers/SharedWorker.h

You're missing JSSharedWorkerConstructor.h in the above list.

> diff --git a/WebCore/WebCore.pro b/WebCore/WebCore.pro

This seems to be missing a line like this one:
    !contains(DEFINES, ENABLE_WORKERS=.): DEFINES += ENABLE_WORKERS=1

> +    SOURCES += \
> +	   bindings/js/JSAbstractWorkerCustom.cpp \
> +	   bindings/js/JSSharedWorkerConstructor.cpp \
> +	   bindings/js/JSSharedWorkerCustom.cpp \
> +	   workers/AbstractWorker.cpp \
> +	   workers/AbstractWorker.h \
> +	   workers/SharedWorker.cpp \
> +	   workers/SharedWorker.h

As you noted (well) before I did, the *.h need to be removed for this file.

> +
> +

It looks like there are typically not blank lines at this point in other
sections like this.
> +}


> diff --git a/WebCore/WebCore.xcodeproj/project.pbxproj
b/WebCore/WebCore.xcodeproj/project.pbxproj
>			isa = PBXGroup;
>			children = (
> +				2E4346350F546A8200B0F1BA /* Worker.idl */,

"Worker.idl" is already in this list, so this addition seems like a mistake.

>				2E4346330F546A8200B0F1BA /* Worker.cpp */,
>				2E4346340F546A8200B0F1BA /* Worker.h */,
>				2E4346350F546A8200B0F1BA /* Worker.idl */,


> diff --git a/WebCore/bindings/js/JSAbstractWorkerCustom.cpp
b/WebCore/bindings/js/JSAbstractWorkerCustom.cpp
> +#include "JSDOMGlobalObject.h"
> +#include "JSEventListener.h"
> +#include "AbstractWorker.h"

Sort these alphabetically.

Of course this file looks exceedingly similar to
bindings/js/JSWorkerCustom.cpp, but it sounds like that is on your roadmap to
clean that up.

Why not file a bug now about this so it is tracked?


> diff --git a/WebCore/bindings/js/JSEventTarget.cpp
b/WebCore/bindings/js/JSEventTarget.cpp

> +#if ENABLE(SHARED_WORKERS)
> +    if (AbstractWorker* abstractWorker = target->toAbstractWorker())
> +	   return toJS(exec, abstractWorker);
> +#endif
...
> +#if ENABLE(SHARED_WORKERS)
> +    CONVERT_TO_EVENT_TARGET(AbstractWorker)
> +#endif

Why aren't these SharedWorker instead of AbstractWorker?


> diff --git a/WebCore/bindings/js/JSSharedWorkerConstructor.cpp
b/WebCore/bindings/js/JSSharedWorkerConstructor.cpp
> +#include "JSDOMWindowCustom.h"
> +#include "JSSharedWorker.h"
> +#include "SharedWorker.h"

Sort these headers.

> +JSSharedWorkerConstructor::JSSharedWorkerConstructor(ExecState* exec,
JSDOMGlobalObject* globalObject)
> +    :
DOMObject(JSSharedWorkerConstructor::createStructure(exec->lexicalGlobalObject(
)->objectPrototype()))
> +{
> +    putDirect(exec->propertyNames().prototype,
JSSharedWorkerPrototype::self(exec, globalObject), None);

This file looks ok, but I'm weak on JSC bindings, so it would be great to get
this file glanced at by someone who knows it better (for example ap, olliej,
weinig, ...).

That being said the JSWorkerConstructor has the following line which you
omitted:

    putDirect(exec->propertyNames().length, jsNumber(exec, 1),
ReadOnly|DontDelete|DontEnum);

Why?  (To be honest I don't know why this line is necessary in that other file)



> diff --git a/WebCore/dom/EventTarget.h b/WebCore/dom/EventTarget.h
> +    class SharedWorker;

Sorting is done case sensitive so SharedWorker comes after
ScriptExecutionContext. (ScriptExecutionContext comes after SVGElementInstance
because ascii('c') > ascii('V')).

>      class SVGElementInstance;
>      class ScriptExecutionContext;


> diff --git a/WebCore/workers/AbstractWorker.cpp
b/WebCore/workers/AbstractWorker.cpp
> +void AbstractWorker::dispatchScriptErrorEvent(const String&, const String&,
int)
> +{
> +    //FIXME(atwilson): Generate an ErrorEvent instead of a simple event

FIXME's in WebKit don't have names in them.  If people want to know who added
it, they can use the revision history.


> diff --git a/WebCore/workers/SharedWorker.h b/WebCore/workers/SharedWorker.h
> +	   SharedWorker(const String&, const String&, ScriptExecutionContext*,
ExceptionCode&);

I would keep the parameter names for the two strings here.

From bugzilla-daemon at webkit.org  Thu Jul  2 21:34:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 21:34:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26947] Media controls miss
 click events when zoomed or non zoomed. : [Attachment 32217] patch v1.
In-Reply-To: <bug-26947-0@https.bugs.webkit.org/>
References: <bug-26947-0@https.bugs.webkit.org/>
Message-ID: <20090703043445.3DEF8319D410@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26947: Media controls miss click events when zoomed or non zoomed.
https://bugs.webkit.org/show_bug.cgi?id=26947

Attachment 32217: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32217&action=edit

From bugzilla-daemon at webkit.org  Thu Jul  2 21:37:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 21:37:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26457] Build DumpRenderTree
 under Cairo : [Attachment 32214] Workaround for build.
In-Reply-To: <bug-26457-0@https.bugs.webkit.org/>
References: <bug-26457-0@https.bugs.webkit.org/>
Message-ID: <20090703043720.37BD4319D521@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has canceled Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26457: Build DumpRenderTree under Cairo
https://bugs.webkit.org/show_bug.cgi?id=26457

Attachment 32214: Workaround for build.
https://bugs.webkit.org/attachment.cgi?id=32214&action=edit

From bugzilla-daemon at webkit.org  Thu Jul  2 21:46:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 21:46:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26490] Add isFinite method
 to floating point types. : [Attachment 32185] Add 'isFinite' operator to
 floating point types
In-Reply-To: <bug-26490-0@https.bugs.webkit.org/>
References: <bug-26490-0@https.bugs.webkit.org/>
Message-ID: <20090703044652.A605D319D8D4@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has canceled Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26490: Add isFinite method to floating point types.
https://bugs.webkit.org/show_bug.cgi?id=26490

Attachment 32185: Add 'isFinite' operator to floating point types
https://bugs.webkit.org/attachment.cgi?id=32185&action=edit

From bugzilla-daemon at webkit.org  Thu Jul  2 22:00:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 22:00:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26947] Media controls miss
 click events when zoomed or non zoomed. : [Attachment 32217] patch v1.
In-Reply-To: <bug-26947-0@https.bugs.webkit.org/>
References: <bug-26947-0@https.bugs.webkit.org/>
Message-ID: <20090703050055.D1DCB319DEAF@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26947: Media controls miss click events when zoomed or non zoomed.
https://bugs.webkit.org/show_bug.cgi?id=26947

Attachment 32217: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32217&action=edit

From bugzilla-daemon at webkit.org  Thu Jul  2 22:41:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 22:41:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32218] Patch addressing Levin's comments
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090703054150.E1B2C319ED9C@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32218: Patch addressing Levin's comments
https://bugs.webkit.org/attachment.cgi?id=32218&action=edit

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Also added the "length" property to the constructor with appropriate comments,
per maciej's email on the webkit-dev mailing-list.

From bugzilla-daemon at webkit.org  Thu Jul  2 23:22:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  2 Jul 2009 23:22:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32218] Patch addressing Levin's comments
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090703062200.52093319FB40@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32218: Patch addressing Levin's comments
https://bugs.webkit.org/attachment.cgi?id=32218&action=edit

------- Additional Comments from David Levin <levin at chromium.org>
This looks great.  This could be landed as is (if possible to address the nits
it would be great -- but it could be landed as is).


> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   * bindings/js/JSEventTarget.cpp:
> +	   (WebCore::toJS):
> +	   (WebCore::toEventTarget):
> +	   Added support for converting to/from AbstractWorkers.
> +	   * bindings/js/JSSharedWorkerConstructor.cpp: Added.
> +	  (WebCore::JSSharedWorkerConstructor::JSSharedWorkerConstructor):

This one got out of place by one space.

> +	   (WebCore::CALLBACK_FUNC_DECL):
> +	   Custom constructor for SharedWorker.
> +	  * dom/EventTarget.cpp:

This one got out of place by one space.

> diff --git a/WebCore/bindings/js/JSEventTarget.cpp
b/WebCore/bindings/js/JSEventTarget.cpp

> +#if ENABLE(SHARED_WORKERS)
> +#include "JSAbstractWorker.h"
> +#include "AbstractWorker.h"

Nice to sort these.

> diff --git a/WebCore/workers/AbstractWorker.cpp
b/WebCore/workers/AbstractWorker.cpp
> +#endif  // ENABLE(SHARED_WORKERS)

Only one space before end of line comments.

From bugzilla-daemon at webkit.org  Fri Jul  3 00:03:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 00:03:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32219] Patch to add Haiku-specific files
 for WebCore/platform/image-decoders/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703070335.2D2DE31A090F@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32219: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32219&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 00:04:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 00:04:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32220] Patch to add Haiku-specific files
 for WebCore/platform/text/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703070435.59DF631A0979@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32220: Patch to add Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/attachment.cgi?id=32220&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 00:13:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 00:13:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32221] Patch to add Haiku-specific files
 for WebCore/bindings/js/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703071336.CDA4F31A0CDF@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32221: Patch to add Haiku-specific files for WebCore/bindings/js/.
https://bugs.webkit.org/attachment.cgi?id=32221&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 00:21:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 00:21:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32222] Patch to add Haiku-specific files
 for WebCore/editing/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703072128.5EE0031A0F51@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32222: Patch to add Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/attachment.cgi?id=32222&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 00:35:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 00:35:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32223] Patch to add Haiku-specific files
 for WebCore/page/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703073516.6FC1E31A1465@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32223: Patch to add Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/attachment.cgi?id=32223&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 00:57:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 00:57:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26262] Implement HTML5
 draggable : [Attachment 32215] Patch
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090703075706.7ED5931A1C1F@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32215: Patch
https://bugs.webkit.org/attachment.cgi?id=32215&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Hyatt confirms that "draggable" should be implemented in code via
parseMappedAttribute rather than in the UA stylesheet, because in our CSS
implementation it's fairly inefficient to have an attribute selector that's not
scoped to particular tags. I believe HTMLElement::parseMappedAttribute would be
the right place.

r- to fix this, patch otherwise looks good to me.

From bugzilla-daemon at webkit.org  Fri Jul  3 01:01:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 01:01:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26950] Make the summary and
 alias fields support click-to-edit : [Attachment 32224] patch
In-Reply-To: <bug-26950-0@https.bugs.webkit.org/>
References: <bug-26950-0@https.bugs.webkit.org/>
Message-ID: <20090703080122.5033231A1DDA@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has asked  for review:
Bug 26950: Make the summary and alias fields support click-to-edit
https://bugs.webkit.org/show_bug.cgi?id=26950

Attachment 32224: patch
https://bugs.webkit.org/attachment.cgi?id=32224&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 01:19:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 01:19:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26950] Make the summary and
 alias fields support click-to-edit : [Attachment 32224] patch
In-Reply-To: <bug-26950-0@https.bugs.webkit.org/>
References: <bug-26950-0@https.bugs.webkit.org/>
Message-ID: <20090703081929.83C4331A240D@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has canceled Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 26950: Make the summary and alias fields support click-to-edit
https://bugs.webkit.org/show_bug.cgi?id=26950

Attachment 32224: patch
https://bugs.webkit.org/attachment.cgi?id=32224&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 01:19:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 01:19:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26950] Make the summary and
 alias fields support click-to-edit : [Attachment 32225] patch
In-Reply-To: <bug-26950-0@https.bugs.webkit.org/>
References: <bug-26950-0@https.bugs.webkit.org/>
Message-ID: <20090703081935.5E4E931A2423@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has asked  for review:
Bug 26950: Make the summary and alias fields support click-to-edit
https://bugs.webkit.org/show_bug.cgi?id=26950

Attachment 32225: patch
https://bugs.webkit.org/attachment.cgi?id=32225&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 01:24:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 01:24:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26951] bugzilla-tool forgot
 how to obsolete patches : [Attachment 32226] patch
In-Reply-To: <bug-26951-0@https.bugs.webkit.org/>
References: <bug-26951-0@https.bugs.webkit.org/>
Message-ID: <20090703082428.303BB31A260B@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has asked  for review:
Bug 26951: bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951

Attachment 32226: patch
https://bugs.webkit.org/attachment.cgi?id=32226&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 01:27:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 01:27:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26951] bugzilla-tool forgot
 how to obsolete patches : [Attachment 32226] patch
In-Reply-To: <bug-26951-0@https.bugs.webkit.org/>
References: <bug-26951-0@https.bugs.webkit.org/>
Message-ID: <20090703082745.E2EEE31A275C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maciej Stachowiak <mjs at apple.com>'s
request for review:
Bug 26951: bugzilla-tool forgot how to obsolete patches
https://bugs.webkit.org/show_bug.cgi?id=26951

Attachment 32226: patch
https://bugs.webkit.org/attachment.cgi?id=32226&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
The check-for-global-initializers change seems unrelated and should be removed,
no?  Otherwise looks fine.

From bugzilla-daemon at webkit.org  Fri Jul  3 01:54:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 01:54:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32227] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703085422.395FE31A31CF@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32227: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32227&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 02:22:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 02:22:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32228] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090703092231.1935831A3C1F@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32228: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32228&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 02:54:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 02:54:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32229] Patch to add ChromeClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090703095415.3B96031A489D@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32229: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32229&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 03:07:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 03:07:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32230] Patch to add ContextMenuClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090703100751.A2D3631A4E1A@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32230: Patch to add ContextMenuClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32230&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 03:16:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 03:16:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32231] Patch to add DragClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090703101612.3D6BC31A50C9@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32231: Patch to add DragClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32231&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 03:28:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 03:28:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32232] Patch to add EditorClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090703102853.862D331A5550@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32232: Patch to add EditorClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32232&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 03:38:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 03:38:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32233] Patch to add FrameLoaderClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090703103803.A8F6231A584F@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32233: Patch to add FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32233&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 03:43:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 03:43:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32234] Patch to add InspectorClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090703104327.B3D3B31A5A58@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32234: Patch to add InspectorClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32234&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 05:30:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 05:30:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25939] [GTK] Text
 attachments in bugzilla are downloaded instead of being opened :
 [Attachment 32236] remove workaround and rely on libsoup to do the sniffing
In-Reply-To: <bug-25939-0@https.bugs.webkit.org/>
References: <bug-25939-0@https.bugs.webkit.org/>
Message-ID: <20090703123049.AB6CA31A8694@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 25939: [GTK] Text attachments in bugzilla are downloaded instead of being
opened
https://bugs.webkit.org/show_bug.cgi?id=25939

Attachment 32236: remove workaround and rely on libsoup to do the sniffing
https://bugs.webkit.org/attachment.cgi?id=32236&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 05:42:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 05:42:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26815] [Gtk]
 text-selection-changed events are not issued for the correct object when
 the selection spans multiple objects : [Attachment 32171]
 textselection.patch
In-Reply-To: <bug-26815-0@https.bugs.webkit.org/>
References: <bug-26815-0@https.bugs.webkit.org/>
Message-ID: <20090703124245.CF45231A8B67@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 26815: [Gtk] text-selection-changed events are not issued for the correct
object when the selection spans multiple objects
https://bugs.webkit.org/show_bug.cgi?id=26815

Attachment 32171: textselection.patch
https://bugs.webkit.org/attachment.cgi?id=32171&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me.

From bugzilla-daemon at webkit.org  Fri Jul  3 05:45:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 05:45:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26814] [Gtk] Caret-moved
 events are not issued for the correct offset when text is selected forward
 : [Attachment 32172] textcaretmoved.patch
In-Reply-To: <bug-26814-0@https.bugs.webkit.org/>
References: <bug-26814-0@https.bugs.webkit.org/>
Message-ID: <20090703124529.188C131A8CA2@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 26814: [Gtk] Caret-moved events are not issued for the correct offset when
text is selected forward
https://bugs.webkit.org/show_bug.cgi?id=26814

Attachment 32172: textcaretmoved.patch
https://bugs.webkit.org/attachment.cgi?id=32172&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me.

From bugzilla-daemon at webkit.org  Fri Jul  3 07:09:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 07:09:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 10930] WebKit could benefit
 from a JavaScript live object profiler : [Attachment 32237] adds live
 object profiling capabilities
In-Reply-To: <bug-10930-0@https.bugs.webkit.org/>
References: <bug-10930-0@https.bugs.webkit.org/>
Message-ID: <20090703140941.0170631AAD08@gamma.macosforge.org>

Horia Olaru <olaru at adobe.com> has asked  for review:
Bug 10930: WebKit could benefit from a JavaScript live object profiler
https://bugs.webkit.org/show_bug.cgi?id=10930

Attachment 32237: adds live object profiling capabilities
https://bugs.webkit.org/attachment.cgi?id=32237&action=edit

------- Additional Comments from Horia Olaru <olaru at adobe.com>
(In reply to comment #15)
> (From update of attachment 31800 [review])

> > +	 SparseArrayValueMap* map = m_storage->m_sparseValueMap;
> > +	 if (map) {
> > +	     computedSize += sizeof(*map) + map->capacity() *
sizeof(SparseArrayValueMap::ValueType);
> > +	 }
> 
> We don't put curly brackets around a single line of code.

Corrected.

> > +
> > +	 //  FIXME: Measure size of the JSObject propertyMap
> > +	 //  JSArray will store objects with non-numeric identifiers, and some
other types
> > +	 //  (see the comments at the beginning of JSArray.cpp) in its property
map
> > +	 //  (eg: arr["object"]), so it is important to measure this.
> > +	 //  This should probably be done in JSObject and a 'super' method
should be
> > +	 //  called.
> 
> Again if this is important we should do this.  And seeing how the only tests
we
> don't have
> are for object size, this is a natural place for bugs to hide.

I've added an inheritance based mechanism to measure the cell size and the
object property map size, which includes this case as well.
Please see the modified implementation of JSCell::instanceSize and
JSObject::instanceSize.

> > --- JavaScriptCore/runtime/JSString.cpp	(revision 45079)
> > +++ JavaScriptCore/runtime/JSString.cpp	(working copy)
> > @@ -112,6 +112,16 @@ bool JSString::getOwnPropertySlot(ExecSt
> >	 return JSString::getOwnPropertySlot(exec, Identifier::from(exec,
propertyName), slot);
> >  }
> >  
> > +size_t JSString::instanceSize() const
> > +{
> > +	 size_t computedSize = sizeof(*this);
> > +
> > +	 computedSize += value().size() * sizeof(UChar) + value().cost();
> > +//  FIXME: Add structure size
> 
> See comment above.

Fixed. See above.

> > --- JavaScriptCore/runtime/NumberObject.cpp (revision 45079)
> > +++ JavaScriptCore/runtime/NumberObject.cpp (working copy)
> > @@ -41,6 +41,13 @@ JSValue NumberObject::getJSNumber()
> >	 return internalValue();
> >  }
> >  
> > +size_t NumberObject::instanceSize() const
> > +{
> > +//  FIXME: Aside from this, we should probably measure the size of the
> > +//  structure/property map of an object - should probably be done higer up

> 
> Ditto.

I've decided to rely on JSWrapperObject for the size calculation and removed
this implementation. NumberObject adds nothing more to size.

> > --- JavaScriptCore/runtime/StringObject.cpp (revision 45079)
> > +++ JavaScriptCore/runtime/StringObject.cpp (working copy)
> > @@ -98,4 +98,18 @@ JSString* StringObject::toThisJSString(E
> >	 return internalValue();
> >  }
> >  
> > +size_t StringObject::instanceSize() const
> > +{
> > +	 size_t computedSize = sizeof(*this);
> > +
> > +//  Add size of the contained JSString object
> 
> Ditto
> 
> > +	 CollectorCell* cell =
reinterpret_cast<CollectorCell*>(asCell(JSWrapperObject::internalValue()));
> > +	 if (cell->u.freeCell.zeroIfFree)
> > +	     computedSize += internalValue()->instanceSize();
> > +
> > +//  FIXME: Add structure size (if this object has a Structure member)
> 
> Ditto

Removed. Relying on JSWrapperObject.

> > --- WebCore/html/HTMLImageElement.cpp	(revision 45079)
> > +++ WebCore/html/HTMLImageElement.cpp	(working copy)
> > @@ -40,6 +40,17 @@ namespace WebCore {
> >  
> >  using namespace HTMLNames;
> >  
> > +size_t HTMLImageElement::elementSize() const
> > +{
> > +	 size_t computedSize = sizeof(*this);
> > +
> > +	 //should we compute and add the render area size?
> 
> You should try to find an answer to this question, but my suspicion is the
> answer is no.  Geoff or Sam would know better than I.

Removed comment. Render area size is not a relevant mesurement.

> > --- WebCore/inspector/JavaScriptObjectIdentifier.cpp	(revision 0)
> > +++ WebCore/inspector/JavaScriptObjectIdentifier.cpp	(revision 0)
> > +JSValue toJS(ExecState* exec, ObjectIdentifier* objectInfo)
> > +{
> > +	 if (!objectInfo)
> > +	     return jsNull();
> > +	     
> > +	 JSObject* objectInfoWrapper = objectIdentifierCache().get(objectInfo);

> > +	 if (objectInfoWrapper)
> > +	     return objectInfoWrapper;
> > +
> > +	 objectInfo->ref();
> > +
> > +	 //FIXME: may need to cache the transformed JS objects.
> 
> Same comment.

Was already done, but forgot to remove comment.

> > --- WebCore/inspector/JavaScriptProfile.cpp (revision 45079)
> > +++ WebCore/inspector/JavaScriptProfile.cpp (working copy)
> > @@ -131,6 +136,53 @@ static JSValueRef restoreAll(JSContextRe
> >	 return JSValueMakeUndefined(ctx);
> >  }
> >  
> > +static JSValueRef getLiveObjects(JSContextRef ctx, JSObjectRef thisObject,
JSStringRef, JSValueRef* exception)
> > +{
> > +	 Profile* profile =
static_cast<Profile*>(JSObjectGetPrivate(thisObject));
> > +	 if (!profile)
> > +	     return JSValueMakeUndefined(ctx);
> > +
> > +	 LiveObjects::ObjectVector objects =
profile->liveObjects()->cachedObjects();
> > +
> > +	 JSObjectRef global = JSContextGetGlobalObject(ctx);
> > +
> > +
> 
> Extra whitespace.  You could actually probably move several of these lines of

> code together.

I've changed the implementation of this function, as per the comment below.

> > +	 JSRetainPtr<JSStringRef> arrayString(Adopt,
JSStringCreateWithUTF8CString("Array"));
> > +
> > +	 JSValueRef arrayProperty = JSObjectGetProperty(ctx, global,
arrayString.get(), exception);
> > +	 if (exception && *exception)
> > +	     return JSValueMakeUndefined(ctx);
> > +
> > +	 JSObjectRef arrayConstructor = JSValueToObject(ctx, arrayProperty,
exception);
> > +	 if (exception && *exception)
> > +	     return JSValueMakeUndefined(ctx);
> > +
> > +	 JSObjectRef result = JSObjectCallAsConstructor(ctx, arrayConstructor,
0, 0, exception);
> > +	 if (exception && *exception)
> > +	     return JSValueMakeUndefined(ctx);
> > +
> > +	 JSRetainPtr<JSStringRef> pushString(Adopt,
JSStringCreateWithUTF8CString("push"));
> > +
> > +	 JSValueRef pushProperty = JSObjectGetProperty(ctx, result,
pushString.get(), exception);
> > +	 if (exception && *exception)
> > +	     return JSValueMakeUndefined(ctx);
> > +
> > +	 JSObjectRef pushFunction = JSValueToObject(ctx, pushProperty,
exception);
> > +	 if (exception && *exception)
> > +	     return JSValueMakeUndefined(ctx);
> > +
> > +	 for (size_t i = 0; i < objects.size(); ++i) {
> > +	     ExecState* exec = toJS(ctx);
> > +	     JSValueRef obj = toRef(exec, toJS(exec, objects[i].get()));
> > +
> > +	     JSObjectCallAsFunction(ctx, pushFunction, result, 1, &obj,
exception);
> > +	     if (exception && *exception)
> > +		 return JSValueMakeUndefined(ctx);
> > +	 }
> 
> I think someone added a function to do this somewhere.  All you have to do is

> pass in your objects and it will return the array with the objects in the
> array.
> Again ask Sam he may know where this function is.

Thanks for pointing that out.
I've looked around and I think you're referring to
JSObjectRef::JSObjectMakeArray. It would do the job better, but the data
parameter is a JSValueRef array. I would have to iterate over the vector data
to create a new array to pass in. This is inefficient as JSObjectMakeArray does
this again inside (twice).
In light of the above, I've taken the JSObjectMakeArray code and replaced what
I did before.

> >  static void finalize(JSObjectRef object)
> >  {
> >	 Profile* profile = static_cast<Profile*>(JSObjectGetPrivate(object));
> > Index: WebCore/page/Console.cpp
> > ===================================================================
> > --- WebCore/page/Console.cpp	(revision 45079)
> > +++ WebCore/page/Console.cpp	(working copy)
> > @@ -313,6 +313,19 @@ void Console::profileEnd(const JSC::UStr
> >	 }
> >  }
> >  
> > +void Console::setMemoryProfilingEnabled(bool isEnabled)
> 
> We should definitely discuss this as a team. Is this the API we want to
expose
> for this feature?
> Is this the right name for exposing this functionality?

I've added this API as a temporary solution until the functionality is hooked
into the UI. The current console API does not allow enabling and disabling
profiling from the console. An API only for enabling memory profiling would be
out of place. A function to do this should be added to the layoutTestController
object though.

> What if we always profiled objects when profiling at all?

Oliver Hunt points out in a comment above that:

> most frequently people wish to profile execution
> time rather than object overhead, yet this is likely to add significant time
> and memory pressure that will skew those results in that case.

Is there some statistic on this?

This is the reason I've made a switch to enable or disable memory profiling.
However, the memory profiler at this stage relies on performance profiling for
collecting object allocation traces.

> I would like to see some more discussion on this before we make a decision
that
> affect so many developers.
> 
> 
> Overall I think you are almost there with this patch.  As you can see I'm
very
> resistant to checking in new features where I think
> core functionality is substituted with FIXMEs.  You should try to answer all
> the open questions you have before landing this.
> 
> It's good that we have some tests now since there is no UI yet, and so these
> tests are the only way we have to investigate if this
> is working correctly, and helps keep other developers from breaking a new
> feature.
> 
> Once this lands you should coordinate with Tim for a way to get some UI for
> this into the Profile's panel.
> 

Additional changes:
- the m_liveObjects member of Profile dies along with the Profile, so I've made
it into an OwnPtr. The LiveObject class no longer needs to extend RefCounted.
- removed the typedefs for iterator and const_iterator and the functions
mapping the HashMap begin and end to LiveObject begin and end. They weren't
really necessary.
- renamed flushLiveObjects to finalizeCollectedData

From bugzilla-daemon at webkit.org  Fri Jul  3 08:33:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 08:33:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26791] [Gtk] Paste of rich
 text from firefox results garbled markup : [Attachment 32238] use
 TextResourceDecoder instead of simple detectTextEncoding
In-Reply-To: <bug-26791-0@https.bugs.webkit.org/>
References: <bug-26791-0@https.bugs.webkit.org/>
Message-ID: <20090703153333.5225731ACE7E@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32238: use TextResourceDecoder instead of simple detectTextEncoding
https://bugs.webkit.org/attachment.cgi?id=32238&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
change to this code:

>	  String html;
>	  RefPtr<TextResourceDecoder> decoder =
TextResourceDecoder::create("text/html", "UTF-8", true);
>	  html = decoder->decode(reinterpret_cast<char*>(data->data),
data->length);

it works.


GtkSelectionData (html) from GTK clipboard can be some forms:

 1. From other WebkitGtk page
    "text/html", 8bits, utf-8, no BOMs

 2. From FireFox page
    "text/html", 8bits (wrong for firefox), utf-16, BOMs

 3. From Pidgin messageview
    "text/html", 16bits, BOMs

 4. From other Gtk App who use "text/html" when copy-paste
    "text/html", 8bits, utf-8, no BOMs

 ...


it use TextResourceDecoder to auto detect encoding.

From bugzilla-daemon at webkit.org  Fri Jul  3 09:59:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 09:59:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26791] [Gtk] Paste of rich
 text from firefox results garbled markup : [Attachment 32238] use
 TextResourceDecoder instead of simple detectTextEncoding
In-Reply-To: <bug-26791-0@https.bugs.webkit.org/>
References: <bug-26791-0@https.bugs.webkit.org/>
Message-ID: <20090703165946.74A2B31AEF35@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has canceled Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32238: use TextResourceDecoder instead of simple detectTextEncoding
https://bugs.webkit.org/attachment.cgi?id=32238&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
Use "text/plain" mimeType instead of "text/html" in TextResourceDecoder,
it will decrease the checking cost.

From bugzilla-daemon at webkit.org  Fri Jul  3 09:59:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 09:59:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26791] [Gtk] Paste of rich
 text from firefox results garbled markup : [Attachment 32239] change
 mimeType to decrease the cost
In-Reply-To: <bug-26791-0@https.bugs.webkit.org/>
References: <bug-26791-0@https.bugs.webkit.org/>
Message-ID: <20090703165946.86C6831AEF39@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32239: change mimeType to decrease the cost
https://bugs.webkit.org/attachment.cgi?id=32239&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
Use "text/plain" mimeType instead of "text/html" in TextResourceDecoder,
it will decrease the checking cost.

From bugzilla-daemon at webkit.org  Fri Jul  3 10:20:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 10:20:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26950] Make the summary and
 alias fields support click-to-edit : [Attachment 32225] patch
In-Reply-To: <bug-26950-0@https.bugs.webkit.org/>
References: <bug-26950-0@https.bugs.webkit.org/>
Message-ID: <20090703172043.4A6A031AF718@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 26950: Make the summary and alias fields support click-to-edit
https://bugs.webkit.org/show_bug.cgi?id=26950

Attachment 32225: patch
https://bugs.webkit.org/attachment.cgi?id=32225&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>-function hideEditableField( container, input, action, field_id,
original_value ) {
>+function hideEditableField( container, input, action, field1_text,
field2_text, field_id, original_value ) {
>     YAHOO.util.Dom.setStyle(container, 'display', 'inline');
>     YAHOO.util.Dom.setStyle(input, 'display', 'none');
>-    YAHOO.util.Event.addListener(action, 'click', showEditableField,
>+    YAHOO.util.Event.addListener(action, 'click', showEditableFieldFocusLast,

>+				   new Array(container, input));
>+    YAHOO.util.Event.addListener(field2_text, 'click',
showEditableFieldFocusLast,
>+				   new Array(container, input));
>+    YAHOO.util.Event.addListener(field1_text, 'click', showEditableField,
>				   new Array(container, input));

Since field2_text is field_id with "_nonedit_display" appended and field1_text
is "alias_nonedit_display", I don't think you need to add two parameters here.

Also, adding a new function, showEditableFieldFocusLast(), instead of adding
arguments to the array object goes against the design of the JavaScript used
elsewhere in the file.

>-function showEditableField (e, ContainerInputArray) {
>+function showEditableField (e, ContainerInputArray, focusLast) {

The "focusLast" argument should be passed in with the ContainerInputArray
argument.

>     }
>+
>+
>     YAHOO.util.Event.preventDefault(e);
> }

Gratuitous whitespace change.

>+function showEditableFieldFocusLast (e, ContainerInputArray) {
>+    showEditableField(e, ContainerInputArray, true);
>+}

This function won't be needed if you add the "focusLast" argument to the
ContainerInputArray.

>     hideEditableField( 'summary_alias_container','summary_alias_input',
>-			 'editme_action','short_desc', short_desc_value);  
>+			 'editme_action', 'alias_nonedit_display',
'short_desc_nonedit_display', 'short_desc', short_desc_value);	

Again, I think we only need to add one argument to hideEditableField().

r- for the above issues.  (Patches to Bugzilla should try to match the existing
design to make them easier to merge upstream.)

FWIW, this patch did work using a local copy of the original page (saved as
HTML) with a <base> tag added and the URL to the field.js adjusted to use a
local copy.

I have an updated patch that I'll post next.

From bugzilla-daemon at webkit.org  Fri Jul  3 10:23:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 10:23:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26950] Make the summary and
 alias fields support click-to-edit : [Attachment 32240] Patch v3
In-Reply-To: <bug-26950-0@https.bugs.webkit.org/>
References: <bug-26950-0@https.bugs.webkit.org/>
Message-ID: <20090703172301.7B19A31AF81B@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 26950: Make the summary and alias fields support click-to-edit
https://bugs.webkit.org/show_bug.cgi?id=26950

Attachment 32240: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32240&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Patch with issues in Comment #4 addressed.

From bugzilla-daemon at webkit.org  Fri Jul  3 10:25:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 10:25:12 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25072] CSS21 attribute
 selectors not dynamic for xml : [Attachment 30768] Updated patch and test
 case
In-Reply-To: <bug-25072-0@https.bugs.webkit.org/>
References: <bug-25072-0@https.bugs.webkit.org/>
Message-ID: <20090703172512.1325831AF8F7@gamma.macosforge.org>

Kai Br?ning <kai at granus.net> has canceled Kai Br?ning <kai at granus.net>'s
request for review:
Bug 25072: CSS21 attribute selectors not dynamic for xml
https://bugs.webkit.org/show_bug.cgi?id=25072

Attachment 30768: Updated patch and test case
https://bugs.webkit.org/attachment.cgi?id=30768&action=edit

------- Additional Comments from Kai Br?ning <kai at granus.net>
I reworked the patch with a little refactoring of
StyledElement::attributeChanged() and Element::attributeChanged(). Now there
are no longer additional virtual function calls beyond the necessary.

Notes:
- The new function Element::recalcStyleIfNeededAfterAttributeChanged() would be
a candidate for inlining, but it can?t be inlined in Element.h without adding
include files.

- Element::recalcStyleIfNeededAfterAttributeChanged() uses document() instead
of ownerdocument() as StyledElement::attributeChanged() used to do. As far as I
can see this is completely safe in this case and faster, too. Please double
check, though.

From bugzilla-daemon at webkit.org  Fri Jul  3 10:25:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 10:25:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25072] CSS21 attribute
 selectors not dynamic for xml : [Attachment 32241] New patch with more
 refactoring
In-Reply-To: <bug-25072-0@https.bugs.webkit.org/>
References: <bug-25072-0@https.bugs.webkit.org/>
Message-ID: <20090703172512.25B9231AF8FB@gamma.macosforge.org>

Kai Br?ning <kai at granus.net> has asked	for review:
Bug 25072: CSS21 attribute selectors not dynamic for xml
https://bugs.webkit.org/show_bug.cgi?id=25072

Attachment 32241: New patch with more refactoring
https://bugs.webkit.org/attachment.cgi?id=32241&action=edit

------- Additional Comments from Kai Br?ning <kai at granus.net>
I reworked the patch with a little refactoring of
StyledElement::attributeChanged() and Element::attributeChanged(). Now there
are no longer additional virtual function calls beyond the necessary.

Notes:
- The new function Element::recalcStyleIfNeededAfterAttributeChanged() would be
a candidate for inlining, but it can?t be inlined in Element.h without adding
include files.

- Element::recalcStyleIfNeededAfterAttributeChanged() uses document() instead
of ownerdocument() as StyledElement::attributeChanged() used to do. As far as I
can see this is completely safe in this case and faster, too. Please double
check, though.

From bugzilla-daemon at webkit.org  Fri Jul  3 12:02:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 12:02:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26954] Adam and Collin's
 affiliation is incorrect : [Attachment 32243] patch
In-Reply-To: <bug-26954-0@https.bugs.webkit.org/>
References: <bug-26954-0@https.bugs.webkit.org/>
Message-ID: <20090703190250.704BC31B1ECF@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26954: Adam and Collin's affiliation is incorrect
https://bugs.webkit.org/show_bug.cgi?id=26954

Attachment 32243: patch
https://bugs.webkit.org/attachment.cgi?id=32243&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 12:10:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 12:10:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26953] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32244]
 The patch
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090703191033.7455F31B2129@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: Do not do unnecessary handles casts and inline couple of methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32244: The patch
https://bugs.webkit.org/attachment.cgi?id=32244&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 12:22:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 12:22:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26955] Use RGBColor::create
 in V8 bindings codegenerator : [Attachment 32245] Use RGBColor::create in
 V8 bindings codegen
In-Reply-To: <bug-26955-0@https.bugs.webkit.org/>
References: <bug-26955-0@https.bugs.webkit.org/>
Message-ID: <20090703192248.A8BE831B2549@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 26955: Use RGBColor::create in V8 bindings codegenerator
https://bugs.webkit.org/show_bug.cgi?id=26955

Attachment 32245: Use RGBColor::create in V8 bindings codegen
https://bugs.webkit.org/attachment.cgi?id=32245&action=edit

------- Additional Comments from Mads Ager <ager at chromium.org>
Patch to the V8 bindings codegenerator to correctly use RGBColor::create to
create RGBColor objects.  This avoid memory leaks because of errors in
refcounting.

From bugzilla-daemon at webkit.org  Fri Jul  3 12:28:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 12:28:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26954] Adam and Collin's
 affiliation is incorrect : [Attachment 32243] patch
In-Reply-To: <bug-26954-0@https.bugs.webkit.org/>
References: <bug-26954-0@https.bugs.webkit.org/>
Message-ID: <20090703192810.395BD31B2706@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26954: Adam and Collin's affiliation is incorrect
https://bugs.webkit.org/show_bug.cgi?id=26954

Attachment 32243: patch
https://bugs.webkit.org/attachment.cgi?id=32243&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
My bad!  r=me.

From bugzilla-daemon at webkit.org  Fri Jul  3 13:40:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 13:40:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26957] RegExp::match to be
 optimized : [Attachment 32246] the patch
In-Reply-To: <bug-26957-0@https.bugs.webkit.org/>
References: <bug-26957-0@https.bugs.webkit.org/>
Message-ID: <20090703204039.E40CC31B4364@gamma.macosforge.org>

George Staikos <staikos at kde.org> has asked  for review:
Bug 26957: RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957

Attachment 32246: the patch
https://bugs.webkit.org/attachment.cgi?id=32246&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 13:52:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 13:52:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26956] Background audio
 stops playing when JS GC runs : [Attachment 32247] Patch
In-Reply-To: <bug-26956-0@https.bugs.webkit.org/>
References: <bug-26956-0@https.bugs.webkit.org/>
Message-ID: <20090703205204.A95DB31B47CF@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 26956: Background audio stops playing when JS GC runs
https://bugs.webkit.org/show_bug.cgi?id=26956

Attachment 32247: Patch
https://bugs.webkit.org/attachment.cgi?id=32247&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 13:52:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 13:52:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26956] Background audio stops
 playing when JS GC runs : [Attachment 32247] Patch
In-Reply-To: <bug-26956-0@https.bugs.webkit.org/>
References: <bug-26956-0@https.bugs.webkit.org/>
Message-ID: <20090703205251.5A47F31B4813@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 26956: Background audio stops playing when JS GC runs
https://bugs.webkit.org/show_bug.cgi?id=26956

Attachment 32247: Patch
https://bugs.webkit.org/attachment.cgi?id=32247&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 14:02:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 14:02:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26950] Make the summary and
 alias fields support click-to-edit : [Attachment 32240] Patch v3
In-Reply-To: <bug-26950-0@https.bugs.webkit.org/>
References: <bug-26950-0@https.bugs.webkit.org/>
Message-ID: <20090703210256.2104C31B4BD5@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 26950: Make the summary and alias fields support click-to-edit
https://bugs.webkit.org/show_bug.cgi?id=26950

Attachment 32240: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32240&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me on your changes. Not sure which one of us should land the patch now. :-)

From bugzilla-daemon at webkit.org  Fri Jul  3 14:13:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 14:13:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26943] Transitions restart
 sometimes when they shouldn't : [Attachment 32210] Patch with test
In-Reply-To: <bug-26943-0@https.bugs.webkit.org/>
References: <bug-26943-0@https.bugs.webkit.org/>
Message-ID: <20090703211324.6A67A31B4FAE@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 26943: Transitions restart sometimes when they shouldn't
https://bugs.webkit.org/show_bug.cgi?id=26943

Attachment 32210: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32210&action=edit

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
This breaks a testcase that I will attach.

From bugzilla-daemon at webkit.org  Fri Jul  3 16:52:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 16:52:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26838] Multithread support for
 JSC on UNIX : [Attachment 32117]
 WebKit-r45374-Collector-multithread-support-for-UNIX.diff
In-Reply-To: <bug-26838-0@https.bugs.webkit.org/>
References: <bug-26838-0@https.bugs.webkit.org/>
Message-ID: <20090703235243.807B731B8690@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied Martin Zoubek
<martin.zoubek at acision.com>'s request for review:
Bug 26838: Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838

Attachment 32117: WebKit-r45374-Collector-multithread-support-for-UNIX.diff
https://bugs.webkit.org/attachment.cgi?id=32117&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Some style issues:

>#define SIG_THREAD_SUSPEND_RESUME SIGUSR2

I'd consider making this a static const int, rather than a #define. We prefer
to avoid preprocessor macros.


> static void pth_sig_suspend_resume(int signo)

This function should use WebKit naming style, for example
sendSuspendResumeSignal()


> -  markConservatively(static_cast<void*>(&regs),
static_cast<void*>(reinterpret_cast<char*>(&regs) + regSize));
> +  if (regSize > 0)
> +		 markConservatively(static_cast<void*>(&regs),
static_cast<void*>(reinterpret_cast<char*>(&regs) + regSize));

This change seems unrelated to the rest of the patch. Please submit as a
separate patch or document the purpose of this change in the ChangeLog.


Also, since changes to this area can be performance-sensitive, please provide
before and after SunSpider results (as determined by the run-sunspider script
on the command line).

This patch looks great! r- for now to attend to the above issues, and please
resubmit with the requested revisions.

From bugzilla-daemon at webkit.org  Fri Jul  3 18:17:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 18:17:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26957] RegExp::match to be
 optimized : [Attachment 32246] the patch
In-Reply-To: <bug-26957-0@https.bugs.webkit.org/>
References: <bug-26957-0@https.bugs.webkit.org/>
Message-ID: <20090704011745.0770F31BA28A@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted George Staikos
<staikos at kde.org>'s request for review:
Bug 26957: RegExp::match to be optimized
https://bugs.webkit.org/show_bug.cgi?id=26957

Attachment 32246: the patch
https://bugs.webkit.org/attachment.cgi?id=32246&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Thanks for the patch! Looks like a good fix. On Mac OS X, this gives a 5%
speedup on string-unpack code and smaller speedups on the other string tests,
for an overall benefit of around 0.3% to SunSpider overall (some tests seem to
slow down a bit but this appears to be noise). This patch doesn't handle the
YARR case, I went ahead and filled that in and will post the revised patch in
addition to commiting it. Also this patch was missing a ChangeLog.

From bugzilla-daemon at webkit.org  Fri Jul  3 18:46:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 18:46:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26958] Change edit link to
 review link in request messages : [Attachment 32249] Patch
In-Reply-To: <bug-26958-0@https.bugs.webkit.org/>
References: <bug-26958-0@https.bugs.webkit.org/>
Message-ID: <20090704014622.53DAA31BAB6E@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 26958: Change edit link to review link in request messages
https://bugs.webkit.org/show_bug.cgi?id=26958

Attachment 32249: Patch
https://bugs.webkit.org/attachment.cgi?id=32249&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Mitz says that request messages should have a "review" link instead of and
"edit" link.

I'll add the bug number to the ChangeLog before committing.

From bugzilla-daemon at webkit.org  Fri Jul  3 18:49:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 18:49:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26958] Change edit link to
 review link in request messages : [Attachment 32249] Patch
In-Reply-To: <bug-26958-0@https.bugs.webkit.org/>
References: <bug-26958-0@https.bugs.webkit.org/>
Message-ID: <20090704014940.1CA1B31BAC9D@gamma.macosforge.org>

mitz at webkit.org has granted David Kilzer (ddkilzer) <ddkilzer at webkit.org>'s
request for review:
Bug 26958: Change edit link to review link in request messages
https://bugs.webkit.org/show_bug.cgi?id=26958

Attachment 32249: Patch
https://bugs.webkit.org/attachment.cgi?id=32249&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 20:54:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 20:54:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26959] REGRESSION
 (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
 : [Attachment 32250] patch
In-Reply-To: <bug-26959-0@https.bugs.webkit.org/>
References: <bug-26959-0@https.bugs.webkit.org/>
Message-ID: <20090704035415.9BBCD31BD3A4@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 26959: REGRESSION (r44670-r44680): Typing is suprisingly slow in password
field on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=26959

Attachment 32250: patch
https://bugs.webkit.org/attachment.cgi?id=32250&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 20:56:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 20:56:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26959] REGRESSION
 (r44670-r44680): Typing is suprisingly slow in password field on reddit.com
 : [Attachment 32250] patch
In-Reply-To: <bug-26959-0@https.bugs.webkit.org/>
References: <bug-26959-0@https.bugs.webkit.org/>
Message-ID: <20090704035649.7965131BD47A@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 26959: REGRESSION (r44670-r44680): Typing is suprisingly slow in password
field on reddit.com
https://bugs.webkit.org/show_bug.cgi?id=26959

Attachment 32250: patch
https://bugs.webkit.org/attachment.cgi?id=32250&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 22:09:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 22:09:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26962] [V8] Move some
 simple utility functions in V8Proxy to V8Utilities : [Attachment 32252]
 patch
In-Reply-To: <bug-26962-0@https.bugs.webkit.org/>
References: <bug-26962-0@https.bugs.webkit.org/>
Message-ID: <20090704050920.B7E1831BECD8@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26962: [V8] Move some simple utility functions in V8Proxy to V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=26962

Attachment 32252: patch
https://bugs.webkit.org/attachment.cgi?id=32252&action=edit

From bugzilla-daemon at webkit.org  Fri Jul  3 22:11:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri,  3 Jul 2009 22:11:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26962] [V8] Move some simple
 utility functions in V8Proxy to V8Utilities : [Attachment 32252] patch
In-Reply-To: <bug-26962-0@https.bugs.webkit.org/>
References: <bug-26962-0@https.bugs.webkit.org/>
Message-ID: <20090704051141.F23FC31BED99@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26962: [V8] Move some simple utility functions in V8Proxy to V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=26962

Attachment 32252: patch
https://bugs.webkit.org/attachment.cgi?id=32252&action=edit

------- Additional Comments from Adam Barth <abarth at webkit.org>
Nevermind.  That doesn't compile.  :(

From bugzilla-daemon at webkit.org  Sat Jul  4 00:09:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 00:09:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26262] Implement HTML5
 draggable : [Attachment 32253] Uses parseMappedAttribute instead of the
 user style sheet
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090704070942.BA17E31C105B@gamma.macosforge.org>

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32253: Uses parseMappedAttribute instead of the user style sheet
https://bugs.webkit.org/attachment.cgi?id=32253&action=edit

------- Additional Comments from Erik Arvidsson <arv at chromium.org>
I also did some testing with Firefox 3.5 and it ignores the case of true and
false so I made all the checks ignore the case. Also, added code to correctly
handle when the attribute is set to something other than true or false and
updated the test to reflect that.

From bugzilla-daemon at webkit.org  Sat Jul  4 07:06:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 07:06:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26875] Large buffer
 allocation on the stack : [Attachment 32109] Proposed patch
In-Reply-To: <bug-26875-0@https.bugs.webkit.org/>
References: <bug-26875-0@https.bugs.webkit.org/>
Message-ID: <20090704140640.AB7F331C9C9C@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has canceled TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 26875: Large buffer allocation on the stack
https://bugs.webkit.org/show_bug.cgi?id=26875

Attachment 32109: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32109&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Clearing review flag and marking obsolete, since the patch is withdrawn.

From bugzilla-daemon at webkit.org  Sat Jul  4 09:03:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 09:03:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26960] [Gtk] caret offset
 not updated when selecting text : [Attachment 32255] caretoffset.patch
In-Reply-To: <bug-26960-0@https.bugs.webkit.org/>
References: <bug-26960-0@https.bugs.webkit.org/>
Message-ID: <20090704160351.036B431CC41F@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 26960: [Gtk] caret offset not updated when selecting text
https://bugs.webkit.org/show_bug.cgi?id=26960

Attachment 32255: caretoffset.patch
https://bugs.webkit.org/attachment.cgi?id=32255&action=edit

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Well, it was basically the same bug than the other cases, but in a different
place.

From bugzilla-daemon at webkit.org  Sat Jul  4 10:00:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 10:00:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26955] Use RGBColor::create
 in V8 bindings codegenerator : [Attachment 32245] Use RGBColor::create in
 V8 bindings codegen
In-Reply-To: <bug-26955-0@https.bugs.webkit.org/>
References: <bug-26955-0@https.bugs.webkit.org/>
Message-ID: <20090704170046.25DDB31CD618@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Mads Ager
<ager at chromium.org>'s request for review:
Bug 26955: Use RGBColor::create in V8 bindings codegenerator
https://bugs.webkit.org/show_bug.cgi?id=26955

Attachment 32245: Use RGBColor::create in V8 bindings codegen
https://bugs.webkit.org/attachment.cgi?id=32245&action=edit

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
The change looks fine. I would really love to see the RGBColor upstreamed,
though :)

From bugzilla-daemon at webkit.org  Sat Jul  4 11:08:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 11:08:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26439] QtWebKit fails in
 loading www.nytimes.com in Windows/Linux : [Attachment 32256] Fixes issue
 associated with rejecting response of HTTP 401 error
In-Reply-To: <bug-26439-0@https.bugs.webkit.org/>
References: <bug-26439-0@https.bugs.webkit.org/>
Message-ID: <20090704180805.B7D4531CEC9A@gamma.macosforge.org>

Sriram <sriram.yadavalli at nokia.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 26439: QtWebKit fails in loading www.nytimes.com in Windows/Linux
https://bugs.webkit.org/show_bug.cgi?id=26439

Attachment 32256: Fixes issue associated with rejecting response of HTTP 401
error
https://bugs.webkit.org/attachment.cgi?id=32256&action=edit

From bugzilla-daemon at webkit.org  Sat Jul  4 11:23:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 11:23:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26262] Implement HTML5
 draggable : [Attachment 32253] Uses parseMappedAttribute instead of the
 user style sheet
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090704182312.BBDD131CF1BB@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32253: Uses parseMappedAttribute instead of the user style sheet
https://bugs.webkit.org/attachment.cgi?id=32253&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> +    if (equalIgnoringCase(getAttribute(draggableAttr), "true"))
> +	   return true;
> +    if (equalIgnoringCase(getAttribute(draggableAttr), "false"))
> +	   return false;

It would be more efficient to call getAttribute only once. A local variable of
type const AtomicString& can be used to hold the attribute value.

> +void HTMLElement::setDraggable(MappedAttribute* attr)

I think it would be best to give this a different name, rather than using
overloading. Perhaps it could be called parseDraggableAttribute.

> +void HTMLElement::setDraggable(const bool& value)

This should just be bool, not const bool&.

> +    void setDraggable(MappedAttribute*);

This newly-added member function should be private.

This looks good, but I'm going to say review- since I'd really like to see the
name and visibility of the setDraggable function that takes an attribute
changed.

From bugzilla-daemon at webkit.org  Sat Jul  4 12:08:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 12:08:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26968] Add API to reload
 without using cache : [Attachment 32258] Implementation
In-Reply-To: <bug-26968-0@https.bugs.webkit.org/>
References: <bug-26968-0@https.bugs.webkit.org/>
Message-ID: <20090704190806.7296931D01E6@gamma.macosforge.org>

Benjamin Meyer <ben at meyerhome.net> has asked  for review:
Bug 26968: Add API to reload without using cache
https://bugs.webkit.org/show_bug.cgi?id=26968

Attachment 32258: Implementation
https://bugs.webkit.org/attachment.cgi?id=32258&action=edit

------- Additional Comments from Benjamin Meyer <ben at meyerhome.net>
Webkit's reload function takes an argument to reload with and without cache. 
This is used to populate the QNetworkRequest cacheloadcontrol enum
(http://doc.trolltech.com/4.5/qnetworkrequest.html#CacheLoadControl-enum) when
creating a QNetworkRequest.  Currently the Qt api has an action for reload, but
no action for reload without cache.  This patch adds that action to QtWebkit.

This functionality is often seen in browsers/viewers as holding down shift
while clicking on the reload button.

From bugzilla-daemon at webkit.org  Sat Jul  4 12:35:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 12:35:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32260] proposed
 patch
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090704193544.4952131D0B2A@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32260: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32260&action=edit

From bugzilla-daemon at webkit.org  Sat Jul  4 12:54:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 12:54:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26897] Dynamic SVG images
 do not display correctly : [Attachment 32261] First attempt
In-Reply-To: <bug-26897-0@https.bugs.webkit.org/>
References: <bug-26897-0@https.bugs.webkit.org/>
Message-ID: <20090704195401.0506331D116E@gamma.macosforge.org>

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 26897: Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897

Attachment 32261: First attempt
https://bugs.webkit.org/attachment.cgi?id=32261&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
Using repaint works for both normal svg and svg embedded in xhtml. Since it
ends up calling clipped clippedOverflowRectForRepaint just like
absoluteClippedOverflowRect does the computed update rects should be equal.
Cheers,

Rob.

From bugzilla-daemon at webkit.org  Sat Jul  4 14:20:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 14:20:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26960] [Gtk] caret offset not
 updated when selecting text : [Attachment 32255] caretoffset.patch
In-Reply-To: <bug-26960-0@https.bugs.webkit.org/>
References: <bug-26960-0@https.bugs.webkit.org/>
Message-ID: <20090704212035.1660831D2F7E@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 26960: [Gtk] caret offset not updated when selecting text
https://bugs.webkit.org/show_bug.cgi?id=26960

Attachment 32255: caretoffset.patch
https://bugs.webkit.org/attachment.cgi?id=32255&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
This looks fine. r=me.

We need to think of a way to test these changes in the future while we don't
have an AXController in DRT yet. Maybe more unit tests.

From bugzilla-daemon at webkit.org  Sat Jul  4 15:40:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 15:40:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32260] proposed
 patch
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090704224001.CD1F531D48CF@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted robert <robert at roberthogan.net>'s
request for review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32260: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32260&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

I would advise making the comment a bit shorter if possible. I don't think
mentioning the bug number in the code is necessary, as long as it's in the
ChangeLog.

From bugzilla-daemon at webkit.org  Sat Jul  4 15:55:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 15:55:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32263] patch
 updated with shorter inline comment
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090704225514.CFBAF31D4DEB@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32263: patch updated with shorter inline comment
https://bugs.webkit.org/attachment.cgi?id=32263&action=edit

From bugzilla-daemon at webkit.org  Sat Jul  4 15:57:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 15:57:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32263] patch
 updated with shorter inline comment
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090704225745.471D731D4EE4@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted robert <robert at roberthogan.net>'s
request for review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32263: patch updated with shorter inline comment
https://bugs.webkit.org/attachment.cgi?id=32263&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Sat Jul  4 15:58:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 15:58:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32260] proposed
 patch
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090704225802.9953531D4F05@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has canceled	review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32260: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32260&action=edit

From bugzilla-daemon at webkit.org  Sat Jul  4 16:03:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 16:03:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25939] [GTK] Text attachments
 in bugzilla are downloaded instead of being opened : [Attachment 32236]
 remove workaround and rely on libsoup to do the sniffing
In-Reply-To: <bug-25939-0@https.bugs.webkit.org/>
References: <bug-25939-0@https.bugs.webkit.org/>
Message-ID: <20090704230347.B066631D510C@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has denied Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 25939: [GTK] Text attachments in bugzilla are downloaded instead of being
opened
https://bugs.webkit.org/show_bug.cgi?id=25939

Attachment 32236: remove workaround and rely on libsoup to do the sniffing
https://bugs.webkit.org/attachment.cgi?id=32236&action=edit

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   Remove workarounds for content type sniffing and rely on libsoup's
> +	   content sniffer (now that it has one).

This is not enough. We need to actually add the sniffer feature to the session,
and use the new signal. I have a now-outdated webkitgtk+ patch at
http://bugzilla.gnome.org/show_bug.cgi?id=572589 which I was planning to update
and propose for reviewing. I'll do it tomorrow, but if you'd like to beat me to
it, go ahead =D.

From bugzilla-daemon at webkit.org  Sat Jul  4 16:20:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 16:20:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26791] [Gtk] Paste of rich
 text from firefox results garbled markup : [Attachment 32239] change
 mimeType to decrease the cost
In-Reply-To: <bug-26791-0@https.bugs.webkit.org/>
References: <bug-26791-0@https.bugs.webkit.org/>
Message-ID: <20090704232041.BB8FE31D56CD@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has canceled Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32239: change mimeType to decrease the cost
https://bugs.webkit.org/attachment.cgi?id=32239&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
(In reply to comment #22)
> Hi Jiahua. Are you able to add manual-test for this? That seems to be a
missing
> piece in your patch.
> 
> Thanks!

Hi Jan,
WebCore/manual-tests/gtk/paste-richtext-from-firefox.html has been added.

From bugzilla-daemon at webkit.org  Sat Jul  4 16:20:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 16:20:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26791] [Gtk] Paste of rich
 text from firefox results garbled markup : [Attachment 32264] add a manual
 test in WebCore/manual-tests/gtk
In-Reply-To: <bug-26791-0@https.bugs.webkit.org/>
References: <bug-26791-0@https.bugs.webkit.org/>
Message-ID: <20090704232041.CFE9131D56D2@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32264: add a manual test in WebCore/manual-tests/gtk
https://bugs.webkit.org/attachment.cgi?id=32264&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
(In reply to comment #22)
> Hi Jiahua. Are you able to add manual-test for this? That seems to be a
missing
> piece in your patch.
> 
> Thanks!

Hi Jan,
WebCore/manual-tests/gtk/paste-richtext-from-firefox.html has been added.

From bugzilla-daemon at webkit.org  Sat Jul  4 16:27:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 16:27:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26971] [Qt] Fix build break
 in QtWebkit : [Attachment 32265] Fix build break introduced due to new
 functionality in the media support
In-Reply-To: <bug-26971-0@https.bugs.webkit.org/>
References: <bug-26971-0@https.bugs.webkit.org/>
Message-ID: <20090704232717.CC7E831D5906@gamma.macosforge.org>

Sriram <sriram.yadavalli at nokia.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 26971: [Qt] Fix build break in QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=26971

Attachment 32265: Fix build break introduced due to new functionality in the
media support
https://bugs.webkit.org/attachment.cgi?id=32265&action=edit

------- Additional Comments from Sriram <sriram.yadavalli at nokia.com>
Added strings for localizing "Loading" and "Live Broadcast"

From bugzilla-daemon at webkit.org  Sat Jul  4 20:56:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat,  4 Jul 2009 20:56:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26262] Implement HTML5
 draggable : [Attachment 32266] Fixed Darin's comments.
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090705035643.DBAA131DAC54@gamma.macosforge.org>

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32266: Fixed Darin's comments.
https://bugs.webkit.org/attachment.cgi?id=32266&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 04:09:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:09:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26976] WebInspector:
 suggest global properties based on async evaluation. : [Attachment 32271]
 Patch with the fix
In-Reply-To: <bug-26976-0@https.bugs.webkit.org/>
References: <bug-26976-0@https.bugs.webkit.org/>
Message-ID: <20090705110917.EEC9B31E2343@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 26976: WebInspector: suggest global properties based on async evaluation.
https://bugs.webkit.org/show_bug.cgi?id=26976

Attachment 32271: Patch with the fix
https://bugs.webkit.org/attachment.cgi?id=32271&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 04:22:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:22:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26262] Implement HTML5
 draggable : [Attachment 32266] Fixed Darin's comments.
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090705112230.AFDC931E27BF@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Erik Arvidsson
<arv at chromium.org>'s request for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32266: Fixed Darin's comments.
https://bugs.webkit.org/attachment.cgi?id=32266&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks to me like the comments are all addressed, and I do not see any new
issues. Thanks for the contribution and the several revised versions! r=me

From bugzilla-daemon at webkit.org  Sun Jul  5 04:26:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:26:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26778] Inspector: Duplicate
 Computation in Autocompletion : [Attachment 31985] Removed Duplicate
 Computation
In-Reply-To: <bug-26778-0@https.bugs.webkit.org/>
References: <bug-26778-0@https.bugs.webkit.org/>
Message-ID: <20090705112647.2A54131E291F@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 26778: Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778

Attachment 31985: Removed Duplicate Computation
https://bugs.webkit.org/attachment.cgi?id=31985&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks good to me. I am surprised at the duplication but it certainly looks like
the passed in originalWordPrefixRange is computed in an identical way, and
can't have changed by the time _completionsReady is reached.

From bugzilla-daemon at webkit.org  Sun Jul  5 04:28:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:28:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26897] Dynamic SVG images do
 not display correctly : [Attachment 32261] First attempt
In-Reply-To: <bug-26897-0@https.bugs.webkit.org/>
References: <bug-26897-0@https.bugs.webkit.org/>
Message-ID: <20090705112848.89A0831E29DF@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 26897: Dynamic SVG images do not display correctly
https://bugs.webkit.org/show_bug.cgi?id=26897

Attachment 32261: First attempt
https://bugs.webkit.org/attachment.cgi?id=32261&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Sun Jul  5 04:30:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:30:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25061] Unconfirmed
 input-method typing should affect the value of <textarea> : [Attachment
 31911] Ojan's fix with an automated test.
In-Reply-To: <bug-25061-0@https.bugs.webkit.org/>
References: <bug-25061-0@https.bugs.webkit.org/>
Message-ID: <20090705113036.8DCB931E2A8A@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Hironori Bono
<hbono at chromium.org>'s request for review:
Bug 25061: Unconfirmed input-method typing should affect the value of
<textarea>
https://bugs.webkit.org/show_bug.cgi?id=25061

Attachment 31911: Ojan's fix with an automated test.
https://bugs.webkit.org/attachment.cgi?id=31911&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Looks good. r=me

From bugzilla-daemon at webkit.org  Sun Jul  5 04:33:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:33:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26843] Fix run-time crashes
 in JavaScriptCore on Symbian with Metrowerks compiler : [Attachment 32066]
 Patch to fix run-time crashes with winscw
In-Reply-To: <bug-26843-0@https.bugs.webkit.org/>
References: <bug-26843-0@https.bugs.webkit.org/>
Message-ID: <20090705113324.AB5CA31E2BA7@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 26843: Fix run-time crashes in JavaScriptCore on Symbian with Metrowerks
compiler
https://bugs.webkit.org/show_bug.cgi?id=26843

Attachment 32066: Patch to fix run-time crashes with winscw
https://bugs.webkit.org/attachment.cgi?id=32066&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

I would suggest maybe making the comment above JSC_CONST_HASHTABLE a bit
shorter, just stating that it's a workaround for a compiler bug should do.

From bugzilla-daemon at webkit.org  Sun Jul  5 04:59:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 04:59:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26976] WebInspector: suggest
 global properties based on async evaluation. : [Attachment 32271] Patch
 with the fix
In-Reply-To: <bug-26976-0@https.bugs.webkit.org/>
References: <bug-26976-0@https.bugs.webkit.org/>
Message-ID: <20090705115913.59A3631E35F0@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 26976: WebInspector: suggest global properties based on async evaluation.
https://bugs.webkit.org/show_bug.cgi?id=26976

Attachment 32271: Patch with the fix
https://bugs.webkit.org/attachment.cgi?id=32271&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 05:43:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 05:43:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26976] WebInspector:
 suggest global properties based on async evaluation. : [Attachment 32272]
 Patch with the fix
In-Reply-To: <bug-26976-0@https.bugs.webkit.org/>
References: <bug-26976-0@https.bugs.webkit.org/>
Message-ID: <20090705124343.0723431E4332@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 26976: WebInspector: suggest global properties based on async evaluation.
https://bugs.webkit.org/show_bug.cgi?id=26976

Attachment 32272: Patch with the fix
https://bugs.webkit.org/attachment.cgi?id=32272&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 05:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 05:46:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26976] WebInspector: suggest
 global properties based on async evaluation. : [Attachment 32272] Patch
 with the fix
In-Reply-To: <bug-26976-0@https.bugs.webkit.org/>
References: <bug-26976-0@https.bugs.webkit.org/>
Message-ID: <20090705124607.76F2131E4425@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 26976: WebInspector: suggest global properties based on async evaluation.
https://bugs.webkit.org/show_bug.cgi?id=26976

Attachment 32272: Patch with the fix
https://bugs.webkit.org/attachment.cgi?id=32272&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 05:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 05:46:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26976] WebInspector:
 suggest global properties based on async evaluation. : [Attachment 32273]
 Patch with the fix
In-Reply-To: <bug-26976-0@https.bugs.webkit.org/>
References: <bug-26976-0@https.bugs.webkit.org/>
Message-ID: <20090705124607.89A7231E442A@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 26976: WebInspector: suggest global properties based on async evaluation.
https://bugs.webkit.org/show_bug.cgi?id=26976

Attachment 32273: Patch with the fix
https://bugs.webkit.org/attachment.cgi?id=32273&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 05:47:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 05:47:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26976] WebInspector: suggest
 global properties based on async evaluation. : [Attachment 32273] Patch
 with the fix
In-Reply-To: <bug-26976-0@https.bugs.webkit.org/>
References: <bug-26976-0@https.bugs.webkit.org/>
Message-ID: <20090705124732.45CA331E44B2@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 26976: WebInspector: suggest global properties based on async evaluation.
https://bugs.webkit.org/show_bug.cgi?id=26976

Attachment 32273: Patch with the fix
https://bugs.webkit.org/attachment.cgi?id=32273&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 12:30:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 12:30:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25401] <use> of text not
 displayed unless declared after : [Attachment 32278] First attempt
In-Reply-To: <bug-25401-0@https.bugs.webkit.org/>
References: <bug-25401-0@https.bugs.webkit.org/>
Message-ID: <20090705193030.CF93231EC55D@gamma.macosforge.org>

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 25401: <use> of text not displayed unless declared after
https://bugs.webkit.org/show_bug.cgi?id=25401

Attachment 32278: First attempt
https://bugs.webkit.org/attachment.cgi?id=32278&action=edit

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
The default SVGElement:insertedIntoDocument is not enough in this case, since
the text content may not have been appended to the <text> element yet,
therefore do
something extra in childrenChanged.
Cheers,

Rob.

From bugzilla-daemon at webkit.org  Sun Jul  5 13:16:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 13:16:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26983] tst_qwebpage
 segfaults : [Attachment 32281] patch
In-Reply-To: <bug-26983-0@https.bugs.webkit.org/>
References: <bug-26983-0@https.bugs.webkit.org/>
Message-ID: <20090705201657.969DF31ED4E6@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32281: patch
https://bugs.webkit.org/attachment.cgi?id=32281&action=edit

------- Additional Comments from robert <robert at roberthogan.net>
Decided against removing the comment and return statement from
http://trac.webkit.org/changeset/29878. 

The assert makes the return redundant but maybe the rdar issue is still open.

From bugzilla-daemon at webkit.org  Sun Jul  5 19:48:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 19:48:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26918] XSSAuditor should
 prevent injection of HTML Base tag : [Attachment 32284] Patch with tests
In-Reply-To: <bug-26918-0@https.bugs.webkit.org/>
References: <bug-26918-0@https.bugs.webkit.org/>
Message-ID: <20090706024830.980AC31F5241@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 26918: XSSAuditor should prevent injection of HTML Base tag
https://bugs.webkit.org/show_bug.cgi?id=26918

Attachment 32284: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32284&action=edit

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Implements support for preventing injection of HTML Base tag.

From bugzilla-daemon at webkit.org  Sun Jul  5 20:59:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 20:59:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20342] REGRESSION:
 fast/dom/cssTarget-crash.html fails : [Attachment 32285] patch 0.2
In-Reply-To: <bug-20342-0@https.bugs.webkit.org/>
References: <bug-20342-0@https.bugs.webkit.org/>
Message-ID: <20090706035920.2865D31F6950@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 20342: REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Attachment 32285: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=32285&action=edit

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
Re-added original fix the cssTarget-crash.

it fixes running this test in QtWebKit for both release and debug modes. Should
fix mac (and make it possible to unskip it).

From bugzilla-daemon at webkit.org  Sun Jul  5 21:55:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 21:55:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 20342] REGRESSION:
 fast/dom/cssTarget-crash.html fails : [Attachment 32285] patch 0.2
In-Reply-To: <bug-20342-0@https.bugs.webkit.org/>
References: <bug-20342-0@https.bugs.webkit.org/>
Message-ID: <20090706045518.0B5B331F7A77@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 20342: REGRESSION: fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Attachment 32285: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=32285&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
http://trac.webkit.org/changeset/40475 moved the setCSSTarget call from
Node::removedFromDocument into ContainerNode::removedFromDocument. But that
wasn't when this bug was introduced.

It was introduced by a bad merge back in
http://trac.webkit.org/changeset/40499. The right fix is to add the code back,
but to add it back to ContainerNode::removedFromDocument, not
Node::removedFromDocument.

I'll take care of this.

From bugzilla-daemon at webkit.org  Sun Jul  5 22:23:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 22:23:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 20342] REGRESSION (r40499):
 fast/dom/cssTarget-crash.html fails : [Attachment 32285] patch 0.2
In-Reply-To: <bug-20342-0@https.bugs.webkit.org/>
References: <bug-20342-0@https.bugs.webkit.org/>
Message-ID: <20090706052313.26AD631F837D@gamma.macosforge.org>

Darin Adler <darin at apple.com> has canceled  review:
Bug 20342: REGRESSION (r40499): fast/dom/cssTarget-crash.html fails
https://bugs.webkit.org/show_bug.cgi?id=20342

Attachment 32285: patch 0.2
https://bugs.webkit.org/attachment.cgi?id=32285&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Clearing the review flag since I landed the fix as
http://trac.webkit.org/changeset/45557 but not closing the bug, because the
test still fails. The crash is gone, but now the test doesn't terminate. That's
presumably because of loader changes that happened while it was disabled.

From bugzilla-daemon at webkit.org  Sun Jul  5 23:19:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 23:19:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26918] XSSAuditor should
 prevent injection of HTML Base tag : [Attachment 32284] Patch with tests
In-Reply-To: <bug-26918-0@https.bugs.webkit.org/>
References: <bug-26918-0@https.bugs.webkit.org/>
Message-ID: <20090706061913.2898031F964F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26918: XSSAuditor should prevent injection of HTML Base tag
https://bugs.webkit.org/show_bug.cgi?id=26918

Attachment 32284: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32284&action=edit

From bugzilla-daemon at webkit.org  Sun Jul  5 23:34:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun,  5 Jul 2009 23:34:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26985] Implement parsing of
 <rp> & <rt> elements as per HTML5 spec : [Attachment 32286] patch:
 implement parsing of <rt>/<rp>, add accessibility role
In-Reply-To: <bug-26985-0@https.bugs.webkit.org/>
References: <bug-26985-0@https.bugs.webkit.org/>
Message-ID: <20090706063445.5E16131F9BD4@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 26985: Implement parsing of <rp> & <rt> elements as per HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=26985

Attachment 32286: patch: implement parsing of <rt>/<rp>, add accessibility role
https://bugs.webkit.org/attachment.cgi?id=32286&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
This patch implements the parsing of <rp> and <rt> tags as per the HTML5 spec. 


It also sets a (new) accessibility role "Annotation" for <rp> and <rt>.

Affected code parts are not enclosed in #IF ENABLE(RUBY), since the parsing is
not affected by whether ruby is rendered properly or not (in fact, it may be
more profound without ruby layouting, since the contents of <rp> are not
hidden).

The patch includes no layout tests, as layouting will change once the patch for
proper ruby rendering is landed.

From bugzilla-daemon at webkit.org  Mon Jul  6 00:23:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 00:23:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26832] Generalize special
 height handling in InlineBox : [Attachment 32110] patch: renamed to
 'virtualHeight'
In-Reply-To: <bug-26832-0@https.bugs.webkit.org/>
References: <bug-26832-0@https.bugs.webkit.org/>
Message-ID: <20090706072314.71BD331FAD09@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26832: Generalize special height handling in InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26832

Attachment 32110: patch: renamed to 'virtualHeight'
https://bugs.webkit.org/attachment.cgi?id=32110&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 00:27:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 00:27:16 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26985] Implement parsing of
 <rp> & <rt> elements as per HTML5 spec : [Attachment 32286] patch:
 implement parsing of <rt>/<rp>, add accessibility role
In-Reply-To: <bug-26985-0@https.bugs.webkit.org/>
References: <bug-26985-0@https.bugs.webkit.org/>
Message-ID: <20090706072716.85DB231FAE85@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26985: Implement parsing of <rp> & <rt> elements as per HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=26985

Attachment 32286: patch: implement parsing of <rt>/<rp>, add accessibility role
https://bugs.webkit.org/attachment.cgi?id=32286&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
The code change looks good. However, I am going to say review- due to lack of
tests for the newly introduced parsing behavior.

From bugzilla-daemon at webkit.org  Mon Jul  6 00:29:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 00:29:23 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32033] patch:
 add methods lineHeight and baselinePosition to InlineBox
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090706072923.8F39D31FAF61@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32033: patch: add methods lineHeight and baselinePosition to
InlineBox
https://bugs.webkit.org/attachment.cgi?id=32033&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
There is a chunk in here that's unrelated to the refactoring mentioned in the
ChangeLog. I discussed with Roland, and he is going to submit a new patch.

From bugzilla-daemon at webkit.org  Mon Jul  6 00:45:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 00:45:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23849] Keyboard shortcuts
 needed in Web Inspector : [Attachment 32287] Change 'Continue' shortcut
 from F5 to F8
In-Reply-To: <bug-23849-0@https.bugs.webkit.org/>
References: <bug-23849-0@https.bugs.webkit.org/>
Message-ID: <20090706074534.04C3931FB446@gamma.macosforge.org>

Yury Semikhatsky <yurys at chromium.org> has asked Timothy Hatcher
<timothy at hatcher.name> for review:
Bug 23849: Keyboard shortcuts needed in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=23849

Attachment 32287: Change 'Continue' shortcut from F5 to F8
https://bugs.webkit.org/attachment.cgi?id=32287&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 01:27:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 01:27:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32289] patch:
 removed unrelated code change from initial patch
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090706082742.B02FF31FC249@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32289: patch: removed unrelated code change from initial patch
https://bugs.webkit.org/attachment.cgi?id=32289&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 01:33:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 01:33:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26784] Enable XSSAuditor by
 default : [Attachment 31993] patch
In-Reply-To: <bug-26784-0@https.bugs.webkit.org/>
References: <bug-26784-0@https.bugs.webkit.org/>
Message-ID: <20090706083328.0022B31FC3F2@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26784: Enable XSSAuditor by default
https://bugs.webkit.org/show_bug.cgi?id=26784

Attachment 31993: patch
https://bugs.webkit.org/attachment.cgi?id=31993&action=edit

------- Additional Comments from Adam Barth <abarth at webkit.org>
Marking for review again now that this is actionable again.

From bugzilla-daemon at webkit.org  Mon Jul  6 01:37:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 01:37:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32289] patch:
 removed unrelated code change from initial patch
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090706083759.D199C31FC562@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32289: patch: removed unrelated code change from initial patch
https://bugs.webkit.org/attachment.cgi?id=32289&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 01:56:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 01:56:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26915] HTML5: DOM binding
 of <datalist> element : [Attachment 32290] Proposed patch
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090706085621.F340F31FCC77@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32290: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32290&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 02:55:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 02:55:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26962] [V8] Move some
 simple utility functions in V8Proxy to V8Utilities : [Attachment 32294]
 patch
In-Reply-To: <bug-26962-0@https.bugs.webkit.org/>
References: <bug-26962-0@https.bugs.webkit.org/>
Message-ID: <20090706095517.D304B31FE320@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26962: [V8] Move some simple utility functions in V8Proxy to V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=26962

Attachment 32294: patch
https://bugs.webkit.org/attachment.cgi?id=32294&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 03:20:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 03:20:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26985] Implement parsing of
 <rp> & <rt> elements as per HTML5 spec : [Attachment 32296] patch: update
 with layout test
In-Reply-To: <bug-26985-0@https.bugs.webkit.org/>
References: <bug-26985-0@https.bugs.webkit.org/>
Message-ID: <20090706102034.D9FBB31FEBFE@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 26985: Implement parsing of <rp> & <rt> elements as per HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=26985

Attachment 32296: patch: update with layout test
https://bugs.webkit.org/attachment.cgi?id=32296&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Adding a layout test was a good thing because it turns out that for proper
parsing I also needed to add code for the outer <ruby> tag. Without this,
<rp>/<rt> wouldn't be automatically closed if no end tag is present before
</ruby>.

From bugzilla-daemon at webkit.org  Mon Jul  6 04:02:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 04:02:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26982] Use soup's content
 sniffing : [Attachment 32279] Use soup's content sniffing
In-Reply-To: <bug-26982-0@https.bugs.webkit.org/>
References: <bug-26982-0@https.bugs.webkit.org/>
Message-ID: <20090706110249.A412A31FFAD8@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 26982: Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Attachment 32279: Use soup's content sniffing
https://bugs.webkit.org/attachment.cgi?id=32279&action=edit

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
TODO: depend on 2.27.3 libsoup, when it is released =P.

From bugzilla-daemon at webkit.org  Mon Jul  6 04:28:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 04:28:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 23849] Keyboard shortcuts
 needed in Web Inspector : [Attachment 32287] Change 'Continue' shortcut
 from F5 to F8
In-Reply-To: <bug-23849-0@https.bugs.webkit.org/>
References: <bug-23849-0@https.bugs.webkit.org/>
Message-ID: <20090706112831.3825232003A8@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 23849: Keyboard shortcuts needed in Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=23849

Attachment 32287: Change 'Continue' shortcut from F5 to F8
https://bugs.webkit.org/attachment.cgi?id=32287&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 04:47:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 04:47:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26982] Use soup's content
 sniffing : [Attachment 32279] Use soup's content sniffing
In-Reply-To: <bug-26982-0@https.bugs.webkit.org/>
References: <bug-26982-0@https.bugs.webkit.org/>
Message-ID: <20090706114733.5E3E63200A8D@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 26982: Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Attachment 32279: Use soup's content sniffing
https://bugs.webkit.org/attachment.cgi?id=32279&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -	       , m_reportedHeaders(false)

Please don't forget to remove m_reportedHeaders decl too.

> +static void contentSniffedCallback(SoupMessage* msg, const char*
sniffedType, GHashTable *params, gpointer data)
> +{
> +    if (sniffedType) {
> +	   const char* officialType =
soup_message_headers_get_one(msg->response_headers, "Content-Type");
> +
> +	   if (!officialType || strcmp(officialType, sniffedType))
> +	       soup_message_headers_set_content_type(msg->response_headers,
sniffedType, params);
> +    }

Ok. r=me.

From bugzilla-daemon at webkit.org  Mon Jul  6 06:08:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 06:08:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26987] Add fast case for
 Math.floor(a / b) expressions : [Attachment 32297] getType() method added
 for all leaf Nodes
In-Reply-To: <bug-26987-0@https.bugs.webkit.org/>
References: <bug-26987-0@https.bugs.webkit.org/>
Message-ID: <20090706130845.BCB343202B12@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 26987: Add fast case for Math.floor(a / b) expressions
https://bugs.webkit.org/show_bug.cgi?id=26987

Attachment 32297: getType() method added for all leaf Nodes
https://bugs.webkit.org/attachment.cgi?id=32297&action=edit

------- Additional Comments from Zoltan Herczeg <zherczeg at inf.u-szeged.hu>
I split the patch into two parts for easier review.

Since my mthod detects Math.floor(a/b) expressions in AST level, I need some
kind of node type. I decided to use virtual methods for this task, because
emitByteCode has already virtual, so virtual method table has already generated
for all nodes.

Perhaps some virtual functions can be eliminated in ExpressionNode using these
types.

From bugzilla-daemon at webkit.org  Mon Jul  6 06:16:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 06:16:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26987] Add fast case for
 Math.floor(a / b) expressions : [Attachment 32298] Enable math.floor(a/b)
 optimization on interpreter
In-Reply-To: <bug-26987-0@https.bugs.webkit.org/>
References: <bug-26987-0@https.bugs.webkit.org/>
Message-ID: <20090706131604.CC4353202E4D@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 26987: Add fast case for Math.floor(a / b) expressions
https://bugs.webkit.org/show_bug.cgi?id=26987

Attachment 32298: Enable math.floor(a/b) optimization on interpreter
https://bugs.webkit.org/attachment.cgi?id=32298&action=edit

------- Additional Comments from Zoltan Herczeg <zherczeg at inf.u-szeged.hu>
This is the main part of the patch. Well, actually it is just a draft, since I
feel you will have several ideas to further improve the code. Furthermore, only
interpreter is supported right now. I would like to hear your opinion before I
continue the work on JIT.

The following code is executed in 0m1.992s without this patch:

var a = 3
for (var i = 0; i < 10000000; ++i)
    Math.floor(a / -2)

The patch improved the runtime to 0m0.790s, which is 2.5 times faster.

From bugzilla-daemon at webkit.org  Mon Jul  6 06:19:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 06:19:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32300] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706131949.792C63202FEE@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32300: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32300&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 06:26:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 06:26:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32301] Patch to add a second bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706132611.8C37F32032B3@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32301: Patch to add a second bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32301&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 06:34:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 06:34:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32302] Patch to add a third bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706133404.24F5832035F9@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32302: Patch to add a third bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32302&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 06:45:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 06:45:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32303] Patch to add a fourth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706134538.8F3653203A43@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32303: Patch to add a fourth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32303&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 07:12:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 07:12:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32304] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706141203.6829232044FB@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32304: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32304&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 07:33:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 07:33:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26848] [Qt]
 ResourceHandle::willLoadFromCache needs to be implmeneted QtWebKit. :
 [Attachment 32079] Implement willLoadFromCache for QtWebKit.
In-Reply-To: <bug-26848-0@https.bugs.webkit.org/>
References: <bug-26848-0@https.bugs.webkit.org/>
Message-ID: <20090706143320.E46033204D3A@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has denied Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 26848: [Qt] ResourceHandle::willLoadFromCache needs to be implmeneted
QtWebKit.
https://bugs.webkit.org/show_bug.cgi?id=26848

Attachment 32079: Implement willLoadFromCache for QtWebKit.
https://bugs.webkit.org/attachment.cgi?id=32079&action=edit

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> -bool ResourceHandle::willLoadFromCache(ResourceRequest& request)
> +bool ResourceHandle::willLoadFromCache(ResourceRequest& request, Frame*
frame)

this will break the mac build... remove the unused parameter


> +#if QT_VERSION >= 0x040400
> +    QNetworkAccessManager* manager =
QWebFramePrivate::kit(frame)->page()->networkAccessManager();
> +    QAbstractNetworkCache* cache = manager->cache();


this will not work on Qt4.4... the cache got added in Qt 4.5...

please revise the patch, it looks good otherwise!

From bugzilla-daemon at webkit.org  Mon Jul  6 08:11:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 08:11:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26990] [QT] [ARM] Add
 pkg-config entry for FontConfig on DRT.pro : [Attachment 32306] adds fc
 pkg-config entry into DRT.pro
In-Reply-To: <bug-26990-0@https.bugs.webkit.org/>
References: <bug-26990-0@https.bugs.webkit.org/>
Message-ID: <20090706151140.8EB993205D65@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 26990: [QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro
https://bugs.webkit.org/show_bug.cgi?id=26990

Attachment 32306: adds fc pkg-config entry into DRT.pro
https://bugs.webkit.org/attachment.cgi?id=32306&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 08:21:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 08:21:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32307] Patch to add a fifth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706152141.377BB32061BA@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32307: Patch to add a fifth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32307&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 08:35:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 08:35:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32308] Patch to add a sixth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090706153555.DA82A32066F6@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32308: Patch to add a sixth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32308&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 11:21:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 11:21:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 32309] patch 0.1 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090706182129.24A6A320A921@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 32309: patch 0.1 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=32309&action=edit

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
ps: I have not figure out a good way to add tests to this. any input welcome.

From bugzilla-daemon at webkit.org  Mon Jul  6 11:29:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 11:29:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 15135] REGRESSION
 (r19843-r19850): Changing a flexbox's contents makes its container scroll
 to the top : [Attachment 31834] Patch v6
In-Reply-To: <bug-15135-0@https.bugs.webkit.org/>
References: <bug-15135-0@https.bugs.webkit.org/>
Message-ID: <20090706182909.82646320AC82@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 15135: REGRESSION (r19843-r19850): Changing a flexbox's contents makes its
container scroll to the top
https://bugs.webkit.org/show_bug.cgi?id=15135

Attachment 31834: Patch v6
https://bugs.webkit.org/attachment.cgi?id=31834&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 11:32:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 11:32:31 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26717] box-orient is not
 inherited : [Attachment 31905] Patch v1
In-Reply-To: <bug-26717-0@https.bugs.webkit.org/>
References: <bug-26717-0@https.bugs.webkit.org/>
Message-ID: <20090706183231.672EF320ADD9@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 26717: box-orient is not inherited
https://bugs.webkit.org/show_bug.cgi?id=26717

Attachment 31905: Patch v1
https://bugs.webkit.org/attachment.cgi?id=31905&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Clearing review flag for now while I try to determine why this changed.

From bugzilla-daemon at webkit.org  Mon Jul  6 12:41:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 12:41:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26940] [Chromium] Add a SQLite
 VFS for Chromium : [Attachment 32206] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090706194125.70051320C7E2@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32206: win patch
https://bugs.webkit.org/attachment.cgi?id=32206&action=edit

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> Index: WebCore/platform/sql/chromium/SQLiteFileSystemChromium.cpp

If this is a Windows-specific file, it should be
SQLiteFileSystemChromiumWin.cpp

> +	   if (desiredFlags & SQLITE_OPEN_READWRITE) {
> +	       int newFlags = (desiredFlags | SQLITE_OPEN_READONLY) &
~SQLITE_OPEN_READWRITE;
> +	       return chromiumOpen(0, fileName, id, newFlags, usedFlags);
> +	   } else {
> +	       return SQLITE_CANTOPEN;
> +	}

Fix indentation, no need for brackets for one-liners.

> +#ifndef SQLITE_OMIT_LOAD_EXTENSION
> +// Returns NULL, thus disallowing loading libraries in the renderer process.

> +//
> +// vfs - pointer to the sqlite3_vfs object.
> +// fileName - the name of the shared library file.
> +void* chromiumDlOpen(sqlite3_vfs* vfs, const char* fileName)
> +{
> +    return NULL;

return 0;

> +    static sqlite3_vfs chromium_vfs = {
> +	 1,
> +	 win32_vfs->szOsFile,
> +	 win32_vfs->mxPathname,
> +	 0,
> +	 "chromium_vfs",
> +	 0,
> +	 chromiumOpen,
> +	 chromiumDelete,
> +	 chromiumAccess,
> +	 chromiumFullPathname,
> +	 chromiumDlOpen,
> +	 win32_vfs->xDlError,
> +	 win32_vfs->xDlSym,
> +	 win32_vfs->xDlClose,
> +	 win32_vfs->xRandomness,
> +	 win32_vfs->xSleep,
> +	 win32_vfs->xCurrentTime,
> +	 win32_vfs->xGetLastError

4 space indent.

> +
> +bool SQLiteFileSystem::ensureDatabaseDirectoryExists(const String& path)
> +{

Should probably eliminate unused param for consistency.

> +bool SQLiteFileSystem::ensureDatabaseFileExists(const String& fileName, bool
checkPathOnly)
> +{

Ditto.

> +bool SQLiteFileSystem::deleteEmptyDatabaseDirectory(const String& path)
> +{

Ditto.

From bugzilla-daemon at webkit.org  Mon Jul  6 12:51:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 12:51:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 32309] patch 0.1 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090706195141.535DF320CBD0@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 32309: patch 0.1 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=32309&action=edit

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
updated to ToT

From bugzilla-daemon at webkit.org  Mon Jul  6 12:51:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 12:51:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 32310] patch 0.2 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090706195141.62171320CBD3@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 32310: patch 0.2 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=32310&action=edit

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
updated to ToT

From bugzilla-daemon at webkit.org  Mon Jul  6 13:10:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:10:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26618] [Chromium] Gradient
 and pattern text failing on Chromium/Linux : [Attachment 31662]
 Patterns/Gradients refactoring for Skia impl.
In-Reply-To: <bug-26618-0@https.bugs.webkit.org/>
References: <bug-26618-0@https.bugs.webkit.org/>
Message-ID: <20090706201018.7014D320D345@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has canceled Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 26618: [Chromium] Gradient and pattern text failing on Chromium/Linux
https://bugs.webkit.org/show_bug.cgi?id=26618

Attachment 31662: Patterns/Gradients refactoring for Skia impl.
https://bugs.webkit.org/attachment.cgi?id=31662&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 13:11:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:11:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26618] [Chromium] Gradient
 and pattern text failing on Chromium/Linux : [Attachment 32311] 2nd rev of
 above -- outlined rect fix, setXXXColor() also reset shaders
In-Reply-To: <bug-26618-0@https.bugs.webkit.org/>
References: <bug-26618-0@https.bugs.webkit.org/>
Message-ID: <20090706201109.2DB58320D3AD@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has asked  for review:
Bug 26618: [Chromium] Gradient and pattern text failing on Chromium/Linux
https://bugs.webkit.org/show_bug.cgi?id=26618

Attachment 32311: 2nd rev of above -- outlined rect fix, setXXXColor() also
reset shaders
https://bugs.webkit.org/attachment.cgi?id=32311&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 13:22:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:22:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26982] Use soup's content
 sniffing : [Attachment 32279] Use soup's content sniffing
In-Reply-To: <bug-26982-0@https.bugs.webkit.org/>
References: <bug-26982-0@https.bugs.webkit.org/>
Message-ID: <20090706202208.B1F17320D7F1@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 26982: Use soup's content sniffing
https://bugs.webkit.org/show_bug.cgi?id=26982

Attachment 32279: Use soup's content sniffing
https://bugs.webkit.org/attachment.cgi?id=32279&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This was landed, clearing flag.

From bugzilla-daemon at webkit.org  Mon Jul  6 13:26:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:26:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26821] REGRESSION(r45285):
 focus rings are black on windows safari : [Attachment 32312] patch
In-Reply-To: <bug-26821-0@https.bugs.webkit.org/>
References: <bug-26821-0@https.bugs.webkit.org/>
Message-ID: <20090706202645.1E354320DA0D@gamma.macosforge.org>

Alice Liu <alice.liu at apple.com> has asked  for review:
Bug 26821: REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821

Attachment 32312: patch
https://bugs.webkit.org/attachment.cgi?id=32312&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 13:31:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:31:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26997] [Chromium] Remove
 buggy usage of DEFINE_STATIC_LOCAL in V8Binding.cpp : [Attachment 32313]
 patch
In-Reply-To: <bug-26997-0@https.bugs.webkit.org/>
References: <bug-26997-0@https.bugs.webkit.org/>
Message-ID: <20090706203144.7EF34320DC1A@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 26997: [Chromium] Remove buggy usage of DEFINE_STATIC_LOCAL in
V8Binding.cpp
https://bugs.webkit.org/show_bug.cgi?id=26997

Attachment 32313: patch
https://bugs.webkit.org/attachment.cgi?id=32313&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 13:38:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:38:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25072] CSS21 attribute
 selectors not dynamic for xml : [Attachment 32241] New patch with more
 refactoring
In-Reply-To: <bug-25072-0@https.bugs.webkit.org/>
References: <bug-25072-0@https.bugs.webkit.org/>
Message-ID: <20090706203825.D93D0320DEC9@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Kai Br?ning <kai at granus.net>'s request
for review:
Bug 25072: CSS21 attribute selectors not dynamic for xml
https://bugs.webkit.org/show_bug.cgi?id=25072

Attachment 32241: New patch with more refactoring
https://bugs.webkit.org/attachment.cgi?id=32241&action=edit

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
This is fine... I dislike the name "otherUpdateAfterAttributeChanged."	I think
you could just drop "other" and call it "updateAfterAttributeChanged."

With that name change, r=me. If you don't have commit privs, you can attach a
new patch with the name change (or whoever lands it can make the change).

From bugzilla-daemon at webkit.org  Mon Jul  6 13:39:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:39:37 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26821] REGRESSION(r45285):
 focus rings are black on windows safari : [Attachment 32312] patch
In-Reply-To: <bug-26821-0@https.bugs.webkit.org/>
References: <bug-26821-0@https.bugs.webkit.org/>
Message-ID: <20090706203937.22094320DF94@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 26821: REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821

Attachment 32312: patch
https://bugs.webkit.org/attachment.cgi?id=32312&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Looks good.

> +static Color customFocusRingColor;

This would fail on Mac (scripts would catch it around link time) because it
creates a constructor that runs at framework load time and a destructor that
runs at exit time. For an example of the correct idiom for this type of thing,
you could look at a function like keepAliveSet() in Frame.cpp that shows how to
use DEFINE_STATIC_LOCAL to avoid the exit-time destructor and a function to
avoid a load-time constructor.

> +void RenderTheme::setCustomFocusRingColor(Color c)

We'd typically use "const Color&" as the type for the argument to avoid copying
the color.

> +    virtual Color platformFocusRingColor() const { return Color(); }

I think platformFocusRingColor should probably be pure virtual instead of
returning a transparent color. Or it could return opaque black?

review- because of the load-time and exit-time issue

From bugzilla-daemon at webkit.org  Mon Jul  6 13:43:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:43:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26998] Decommitted spans
 are added to the list of normal spans rather than the returned spans in
 TCMalloc_PageHeap::Delete() : [Attachment 32314] Prepend the span to the
 returned list if it is decommitted.
In-Reply-To: <bug-26998-0@https.bugs.webkit.org/>
References: <bug-26998-0@https.bugs.webkit.org/>
Message-ID: <20090706204342.3C6A8320E19E@gamma.macosforge.org>

Ada Chan <adachan at apple.com> has asked	for review:
Bug 26998: Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete()
https://bugs.webkit.org/show_bug.cgi?id=26998

Attachment 32314: Prepend the span to the returned list if it is decommitted.
https://bugs.webkit.org/attachment.cgi?id=32314&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 13:46:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:46:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26997] [Chromium] Remove
 buggy usage of DEFINE_STATIC_LOCAL in V8Binding.cpp : [Attachment 32313]
 patch
In-Reply-To: <bug-26997-0@https.bugs.webkit.org/>
References: <bug-26997-0@https.bugs.webkit.org/>
Message-ID: <20090706204656.7ADAA320E2F4@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 26997: [Chromium] Remove buggy usage of DEFINE_STATIC_LOCAL in
V8Binding.cpp
https://bugs.webkit.org/show_bug.cgi?id=26997

Attachment 32313: patch
https://bugs.webkit.org/attachment.cgi?id=32313&action=edit

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Mon Jul  6 13:47:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:47:03 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26790] ParserArenaDeletable
 should override delete : [Attachment 32038] Overeride ParserArenaDeletable
 delete
In-Reply-To: <bug-26790-0@https.bugs.webkit.org/>
References: <bug-26790-0@https.bugs.webkit.org/>
Message-ID: <20090706204703.1324D320E30C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32038: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32038&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Build fails:

In file included from JavaScriptCore/parser/Grammar.y:32,
		 from
/Users/eseidel/Projects/WebKit/JavaScriptCore/AllInOneFile.cpp:59:
/Users/eseidel/Projects/WebKit/JavaScriptCore/parser/NodeConstructors.h:42:
error: ?operator delete? must return type ?void?

From bugzilla-daemon at webkit.org  Mon Jul  6 13:53:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 13:53:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26998] Decommitted spans are
 added to the list of normal spans rather than the returned spans in
 TCMalloc_PageHeap::Delete() : [Attachment 32314] Prepend the span to the
 returned list if it is decommitted.
In-Reply-To: <bug-26998-0@https.bugs.webkit.org/>
References: <bug-26998-0@https.bugs.webkit.org/>
Message-ID: <20090706205313.491CD320E5DC@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 26998: Decommitted spans are added to the list of normal spans rather than
the returned spans in TCMalloc_PageHeap::Delete()
https://bugs.webkit.org/show_bug.cgi?id=26998

Attachment 32314: Prepend the span to the returned list if it is decommitted.
https://bugs.webkit.org/attachment.cgi?id=32314&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
I noticed this comment in that function:

  // Note that the spans we merge into "span" may come out of
  // a "returned" list.  For simplicity, we move these into the
  // "normal" list of the appropriate size class.

Maybe you should change it?

r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 14:06:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:06:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26778] Inspector: Duplicate
 Computation in Autocompletion : [Attachment 32316] Removed Duplicate
 Computation (patch from root)
In-Reply-To: <bug-26778-0@https.bugs.webkit.org/>
References: <bug-26778-0@https.bugs.webkit.org/>
Message-ID: <20090706210628.0A8F8320EBE4@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 26778: Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778

Attachment 32316: Removed Duplicate Computation (patch from root)
https://bugs.webkit.org/attachment.cgi?id=32316&action=edit

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Removed Duplicate Computation - svn-create-patch made from the root directory.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:11:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:11:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27000] Minor clean up to
 runtime_root.{cpp|h} : [Attachment 32317] Patch v1
In-Reply-To: <bug-27000-0@https.bugs.webkit.org/>
References: <bug-27000-0@https.bugs.webkit.org/>
Message-ID: <20090706211123.4E933320EE18@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27000: Minor clean up to runtime_root.{cpp|h}
https://bugs.webkit.org/show_bug.cgi?id=27000

Attachment 32317: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32317&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Minor clean up to runtime_root.{cpp|h}

Reviewed by NOBODY (OOPS!).

* bridge/runtime_root.cpp: Added blank line between license and the first
#include statement.
* bridge/runtime_root.h: Added comment to #endif.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:12:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:12:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27000] Minor clean up to
 runtime_root.{cpp|h} : [Attachment 32317] Patch v1
In-Reply-To: <bug-27000-0@https.bugs.webkit.org/>
References: <bug-27000-0@https.bugs.webkit.org/>
Message-ID: <20090706211204.330C1320EE65@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27000: Minor clean up to runtime_root.{cpp|h}
https://bugs.webkit.org/show_bug.cgi?id=27000

Attachment 32317: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32317&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:13:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:13:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27001] Fix improper use of
 PassRefPtr<Node> to RefPtr<Node> : [Attachment 32318] Patch v1
In-Reply-To: <bug-27001-0@https.bugs.webkit.org/>
References: <bug-27001-0@https.bugs.webkit.org/>
Message-ID: <20090706211341.8CAE3320EF1A@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27001: Fix improper use of PassRefPtr<Node> to RefPtr<Node>
https://bugs.webkit.org/show_bug.cgi?id=27001

Attachment 32318: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32318&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Fix improper use of PassRefPtr<Node> to RefPtr<Node>

Reviewed by NOBODY (OOPS!).

PassRefPtr<> should only be used for arguments to functions that take ownership
of the object, or as return values from functions that relinquish ownership of
the object.

* editing/Editor.cpp:
(WebCore::Editor::increaseSelectionListLevelOrdered): Changed stack-allocated
PassRefPtr<Node> to RefPtr<Node> and call release() on returned object to
prevent ref count churn.
(WebCore::Editor::increaseSelectionListLevelUnordered): Ditto.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:16:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:16:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27001] Fix improper use of
 PassRefPtr<Node> to RefPtr<Node> : [Attachment 32318] Patch v1
In-Reply-To: <bug-27001-0@https.bugs.webkit.org/>
References: <bug-27001-0@https.bugs.webkit.org/>
Message-ID: <20090706211611.3C52C320F056@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27001: Fix improper use of PassRefPtr<Node> to RefPtr<Node>
https://bugs.webkit.org/show_bug.cgi?id=27001

Attachment 32318: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32318&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
>	  (WebCore::Editor::increaseSelectionListLevelOrdered): Changed
>	  stack-allocated PassRefPtr<Node> to RefPtr<Node> and call
>	  release() on returned object to prevent ref count churn.

Technically, I don't think there would be refcount churn, since the default
behavior of PassRefPtr is to give up its reference upon assignment:

	template <typename U> PassRefPtr(const PassRefPtr<U>& o) :
m_ptr(o.releaseRef()) { }

However, this is still a good change for the style reasons you cited.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:16:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:16:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27002] Build fix when
 DASHBOARD_SUPPORT is disabled with -Wunused-parameter : [Attachment 32319]
 Patch v1
In-Reply-To: <bug-27002-0@https.bugs.webkit.org/>
References: <bug-27002-0@https.bugs.webkit.org/>
Message-ID: <20090706211631.0EFA0320F085@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27002: Build fix when DASHBOARD_SUPPORT is disabled with -Wunused-parameter
https://bugs.webkit.org/show_bug.cgi?id=27002

Attachment 32319: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32319&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Build fix when DASHBOARD_SUPPORT is disabled with -Wunused-parameter

Reviewed by NOBODY (OOPS!).

* html/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::prepareGradientForDashboard): Mark gradient
as an unused parameter when DASHBOARD_SUPPORT is disabled.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:17:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:17:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27003] Build fix when
 USE(PLUGIN_HOST_PROCESS) is disabled : [Attachment 32320] Patch v1
In-Reply-To: <bug-27003-0@https.bugs.webkit.org/>
References: <bug-27003-0@https.bugs.webkit.org/>
Message-ID: <20090706211732.B6CBF320F0E7@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27003: Build fix when USE(PLUGIN_HOST_PROCESS) is disabled
https://bugs.webkit.org/show_bug.cgi?id=27003

Attachment 32320: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32320&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Build fix when USE(PLUGIN_HOST_PROCESS) is disabled

Reviewed by NOBODY (OOPS!).

* Plugins/WebNetscapeContainerCheckContextInfo.h: Added #if
USE(PLUGIN_HOST_PROCESS)/#endif guards.
* Plugins/WebNetscapeContainerCheckContextInfo.mm: Ditto.
* Plugins/WebNetscapeContainerCheckPrivate.mm: Ditto.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:17:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27002] Build fix when
 DASHBOARD_SUPPORT is disabled with -Wunused-parameter : [Attachment 32319]
 Patch v1
In-Reply-To: <bug-27002-0@https.bugs.webkit.org/>
References: <bug-27002-0@https.bugs.webkit.org/>
Message-ID: <20090706211759.B6D99320F12C@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27002: Build fix when DASHBOARD_SUPPORT is disabled with -Wunused-parameter
https://bugs.webkit.org/show_bug.cgi?id=27002

Attachment 32319: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32319&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:18:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:18:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27003] Build fix when
 USE(PLUGIN_HOST_PROCESS) is disabled : [Attachment 32320] Patch v1
In-Reply-To: <bug-27003-0@https.bugs.webkit.org/>
References: <bug-27003-0@https.bugs.webkit.org/>
Message-ID: <20090706211827.8118C320F16B@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27003: Build fix when USE(PLUGIN_HOST_PROCESS) is disabled
https://bugs.webkit.org/show_bug.cgi?id=27003

Attachment 32320: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32320&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:20:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:20:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27004] Build fix for
 ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618 : [Attachment 32321] Patch v1
In-Reply-To: <bug-27004-0@https.bugs.webkit.org/>
References: <bug-27004-0@https.bugs.webkit.org/>
Message-ID: <20090706212019.CEC62320F236@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27004: Build fix for ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618
https://bugs.webkit.org/show_bug.cgi?id=27004

Attachment 32321: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32321&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Build fix for ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618

Reviewed by NOBODY (OOPS!).

* Plugins/WebPluginController.mm:
(mediaProxyClient): Use core() method to convert from DOMElement to
WebCore::Element.

 <http://trac.webkit.org/changeset/42618>

From bugzilla-daemon at webkit.org  Mon Jul  6 14:21:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:21:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27005] Build fixes when
 NETSCAPE_PLUGIN_API is disabled : [Attachment 32322] Patch v1
In-Reply-To: <bug-27005-0@https.bugs.webkit.org/>
References: <bug-27005-0@https.bugs.webkit.org/>
Message-ID: <20090706212138.4A204320F2D4@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27005: Build fixes when NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=27005

Attachment 32322: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32322&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Build fixes when NETSCAPE_PLUGIN_API is disabled

Reviewed by NOBODY (OOPS!).

* Plugins/WebPluginController.mm:
(-[WebPluginController destroyPlugin:]): Wrap call to
ScriptController::cleanupScriptObjectsForPlugin() in #if
ENABLE(NETSCAPE_PLUGIN_API)/#endif macro.
(-[WebPluginController destroyAllPlugins]): Ditto.
* Plugins/WebPluginDatabase.mm:
(-[WebPluginDatabase removePluginInstanceViewsFor:]): Wrap
WebBaseNetscapePluginView class checks in #if
ENABLE(NETSCAPE_PLUGIN_API)/#endif macro.
(-[WebPluginDatabase destroyAllPluginInstanceViews]): Ditto.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:22:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:22:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27006] Build fix when
 MAC_JAVA_BRIDGE is disabled : [Attachment 32323] Patch v1
In-Reply-To: <bug-27006-0@https.bugs.webkit.org/>
References: <bug-27006-0@https.bugs.webkit.org/>
Message-ID: <20090706212230.88768320F332@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27006: Build fix when MAC_JAVA_BRIDGE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27006

Attachment 32323: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32323&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Build fix when MAC_JAVA_BRIDGE is disabled

Reviewed by NOBODY (OOPS!).

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createJavaAppletWidget): Wrap contents of the method in
#if ENABLE(MAC_JAVA_BRIDGE)/#endif and return 0 when this feature is disabled.

From bugzilla-daemon at webkit.org  Mon Jul  6 14:23:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:23:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32324] Patch v1
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090706212353.4E68B320F3BA@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32324: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32324&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Build fixes when ICONDATABASE is disabled

Reviewed by NOBODY (OOPS!).

WebCore:

	* Configurations/WebCore.xcconfig: Exclude IconDatabase.cpp
	from being compiled when ICONDATABASE is disabled, and exclude
	IconDatabaseNone.cpp when ICONDATABASE is enabled.  Reworked
	definition of EXCLUDED_SOURCE_FILE_NAMES.
	* WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp
	to the project.
	* loader/icon/IconDatabase.h: Removed three public methods from
	#if ENABLE(ICONDATABASE)/#endif macro so that they may be
	stubbed out in IconDatabaseNone.cpp.
	* loader/icon/IconDatabaseNone.cpp:
	(WebCore::IconDatabase::importIconURLForPageURL): Added.
	(WebCore::IconDatabase::importIconDataForIconURL): Added.
	(WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

	* Misc/WebIconDatabase.mm:
	(defaultClient): Return 0 if ICONDATABASE is disabled.
	* WebCoreSupport/WebFrameLoaderClient.mm:
	(WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out
	the body of the method if ICONDATABASE is disabled.
	(WebFrameLoaderClient::registerForIconNotification): Ditto.
	* WebCoreSupport/WebIconDatabaseClient.mm: Added #if
	ENABLE(ICONDATABASE)/#endif guard to source.
	* WebView/WebView.mm:
	(-[WebView setFrameLoadDelegate:]): Wrapped code that starts the
	icon database machinery in #if ENABLE(ICONDATABASE)/#endif.
	(-[WebView _registerForIconNotification:]): Wrapped method in
	#if ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
	* WebView/WebViewInternal.h: Wrapped methods in #if
	ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _registerForIconNotification:]):
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]):

From bugzilla-daemon at webkit.org  Mon Jul  6 14:28:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:28:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32325] updated
 changelog
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090706212808.9EF56320F55D@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32325: updated changelog
https://bugs.webkit.org/attachment.cgi?id=32325&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:29:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:29:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26618] [Chromium] Gradient
 and pattern text failing on Chromium/Linux : [Attachment 32311] 2nd rev of
 above -- outlined rect fix, setXXXColor() also reset shaders
In-Reply-To: <bug-26618-0@https.bugs.webkit.org/>
References: <bug-26618-0@https.bugs.webkit.org/>
Message-ID: <20090706212905.969A7320F5F7@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has canceled Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 26618: [Chromium] Gradient and pattern text failing on Chromium/Linux
https://bugs.webkit.org/show_bug.cgi?id=26618

Attachment 32311: 2nd rev of above -- outlined rect fix, setXXXColor() also
reset shaders
https://bugs.webkit.org/attachment.cgi?id=32311&action=edit

------- Additional Comments from Stephen White <senorblanco at chromium.org>
Also removed names from some unused parameters, to silence warnings (treated as
errors in Mac Webkit build).

From bugzilla-daemon at webkit.org  Mon Jul  6 14:29:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:29:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26618] [Chromium] Gradient
 and pattern text failing on Chromium/Linux : [Attachment 32326] 3rd rev -
 setFillColor() unconditionally in rect border code,
 so shader is always reset
In-Reply-To: <bug-26618-0@https.bugs.webkit.org/>
References: <bug-26618-0@https.bugs.webkit.org/>
Message-ID: <20090706212905.A2CFF320F5F9@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has asked  for review:
Bug 26618: [Chromium] Gradient and pattern text failing on Chromium/Linux
https://bugs.webkit.org/show_bug.cgi?id=26618

Attachment 32326: 3rd rev - setFillColor() unconditionally in rect border code,
so shader is always reset
https://bugs.webkit.org/attachment.cgi?id=32326&action=edit

------- Additional Comments from Stephen White <senorblanco at chromium.org>
Also removed names from some unused parameters, to silence warnings (treated as
errors in Mac Webkit build).

From bugzilla-daemon at webkit.org  Mon Jul  6 14:32:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:32:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26262] Implement HTML5
 draggable : [Attachment 32327] Style nits fixed
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090706213227.83B59320F733@gamma.macosforge.org>

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32327: Style nits fixed
https://bugs.webkit.org/attachment.cgi?id=32327&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:36:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:36:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27006] Build fix when
 MAC_JAVA_BRIDGE is disabled : [Attachment 32323] Patch v1
In-Reply-To: <bug-27006-0@https.bugs.webkit.org/>
References: <bug-27006-0@https.bugs.webkit.org/>
Message-ID: <20090706213632.5228A320F8F5@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27006: Build fix when MAC_JAVA_BRIDGE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27006

Attachment 32323: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32323&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:37:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:37:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26262] Implement HTML5
 draggable : [Attachment 32327] Style nits fixed
In-Reply-To: <bug-26262-0@https.bugs.webkit.org/>
References: <bug-26262-0@https.bugs.webkit.org/>
Message-ID: <20090706213751.EBF9D320F96F@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 26262: Implement HTML5 draggable
https://bugs.webkit.org/show_bug.cgi?id=26262

Attachment 32327: Style nits fixed
https://bugs.webkit.org/attachment.cgi?id=32327&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:40:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:40:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32324] Patch v1
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090706214053.EA051320FAAD@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32324: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32324&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:41:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:41:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27005] Build fixes when
 NETSCAPE_PLUGIN_API is disabled : [Attachment 32322] Patch v1
In-Reply-To: <bug-27005-0@https.bugs.webkit.org/>
References: <bug-27005-0@https.bugs.webkit.org/>
Message-ID: <20090706214121.9DBE4320FAE4@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27005: Build fixes when NETSCAPE_PLUGIN_API is disabled
https://bugs.webkit.org/show_bug.cgi?id=27005

Attachment 32322: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32322&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:41:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:41:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27004] Build fix for
 ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618 : [Attachment 32321] Patch v1
In-Reply-To: <bug-27004-0@https.bugs.webkit.org/>
References: <bug-27004-0@https.bugs.webkit.org/>
Message-ID: <20090706214153.6DE56320FB21@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27004: Build fix for ENABLE(PLUGIN_PROXY_FOR_VIDEO) after r42618
https://bugs.webkit.org/show_bug.cgi?id=27004

Attachment 32321: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32321&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 14:44:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 14:44:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26963] Reproducible crash
 at FontCache::getFontData() when a custom font is used in a pseudo-style :
 [Attachment 32328] Validate the pseudo-style cache on style recalc
In-Reply-To: <bug-26963-0@https.bugs.webkit.org/>
References: <bug-26963-0@https.bugs.webkit.org/>
Message-ID: <20090706214436.CEC39320FBEF@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 26963: Reproducible crash at FontCache::getFontData() when a custom font is
used in a pseudo-style
https://bugs.webkit.org/show_bug.cgi?id=26963

Attachment 32328: Validate the pseudo-style cache on style recalc
https://bugs.webkit.org/attachment.cgi?id=32328&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 15:01:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 15:01:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26821] REGRESSION(r45285):
 focus rings are black on windows safari : [Attachment 32330] patch,
 without global initializers, compiles on mac and win
In-Reply-To: <bug-26821-0@https.bugs.webkit.org/>
References: <bug-26821-0@https.bugs.webkit.org/>
Message-ID: <20090706220129.78AE13210194@gamma.macosforge.org>

Alice Liu <alice.liu at apple.com> has asked  for review:
Bug 26821: REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821

Attachment 32330: patch, without global initializers, compiles on mac and win
https://bugs.webkit.org/attachment.cgi?id=32330&action=edit

------- Additional Comments from Alice Liu <alice.liu at apple.com>
I did consider making platformFocusRingColor pure virtual, but doing it that
way would have required RenderThemeWin to provide an implementation, and i
wasn't convinced that providing an invalid or black color there would have
better than providing an invalid or black color in
RenderTheme::platformFocusRingColor along with the possible confusion about why
RenderThemeWin isn't appearing to provide an aqua-looking color.  In this patch
I did change to black as you suggested.

From bugzilla-daemon at webkit.org  Mon Jul  6 15:02:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 15:02:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26821] REGRESSION(r45285):
 focus rings are black on windows safari : [Attachment 32330] patch,
 without global initializers, compiles on mac and win
In-Reply-To: <bug-26821-0@https.bugs.webkit.org/>
References: <bug-26821-0@https.bugs.webkit.org/>
Message-ID: <20090706220253.48465321022D@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Alice Liu <alice.liu at apple.com>'s
request for review:
Bug 26821: REGRESSION(r45285): focus rings are black on windows safari
https://bugs.webkit.org/show_bug.cgi?id=26821

Attachment 32330: patch, without global initializers, compiles on mac and win
https://bugs.webkit.org/attachment.cgi?id=32330&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> +    Color& color = customFocusRingColor();
> +    color = c;

Could just be done like this:

    customFocusRingColor() = c;

r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 15:55:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 15:55:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27012] result chaining :
 [Attachment 32331] patch
In-Reply-To: <bug-27012-0@https.bugs.webkit.org/>
References: <bug-27012-0@https.bugs.webkit.org/>
Message-ID: <20090706225545.766F732113FF@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 27012: result chaining
https://bugs.webkit.org/show_bug.cgi?id=27012

Attachment 32331: patch
https://bugs.webkit.org/attachment.cgi?id=32331&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Patch coming.

From bugzilla-daemon at webkit.org  Mon Jul  6 15:58:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 15:58:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27012] result chaining :
 [Attachment 32331] patch
In-Reply-To: <bug-27012-0@https.bugs.webkit.org/>
References: <bug-27012-0@https.bugs.webkit.org/>
Message-ID: <20090706225849.7C474321151E@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 27012: result chaining
https://bugs.webkit.org/show_bug.cgi?id=27012

Attachment 32331: patch
https://bugs.webkit.org/attachment.cgi?id=32331&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
Looks great. r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 16:30:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 16:30:53 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32289] patch:
 removed unrelated code change from initial patch
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090706233053.649B032120CA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32289: patch: removed unrelated code change from initial patch
https://bugs.webkit.org/attachment.cgi?id=32289&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/rendering/InlineBox.h
Hunk #1 succeeded at 205 (offset 4 lines).
Hunk #2 FAILED at 283.
1 out of 2 hunks FAILED -- saving rejects to file
WebCore/rendering/InlineBox.h.rej
patch -p0 "WebCore/rendering/InlineBox.h" returned 1.  Pass --force to ignore
patch failures.
Patch https://bugs.webkit.org/attachment.cgi?id=32289 failed to download and
apply.

From bugzilla-daemon at webkit.org  Mon Jul  6 16:52:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 16:52:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27014] Include
 op_convert_this in result caching. : [Attachment 32333] patch
In-Reply-To: <bug-27014-0@https.bugs.webkit.org/>
References: <bug-27014-0@https.bugs.webkit.org/>
Message-ID: <20090706235238.35F8B32127BE@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 27014: Include op_convert_this in result caching.
https://bugs.webkit.org/show_bug.cgi?id=27014

Attachment 32333: patch
https://bugs.webkit.org/attachment.cgi?id=32333&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Patch coming.

From bugzilla-daemon at webkit.org  Mon Jul  6 16:53:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 16:53:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26995] AX: Some webpages do
 not send AXLoadComplete : [Attachment 32332] Proposed patch
In-Reply-To: <bug-26995-0@https.bugs.webkit.org/>
References: <bug-26995-0@https.bugs.webkit.org/>
Message-ID: <20090706235336.72E473212845@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 26995: AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995

Attachment 32332: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32332&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 16:53:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 16:53:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27014] Include
 op_convert_this in result caching. : [Attachment 32333] patch
In-Reply-To: <bug-27014-0@https.bugs.webkit.org/>
References: <bug-27014-0@https.bugs.webkit.org/>
Message-ID: <20090706235340.DE10A3212851@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 27014: Include op_convert_this in result caching.
https://bugs.webkit.org/show_bug.cgi?id=27014

Attachment 32333: patch
https://bugs.webkit.org/attachment.cgi?id=32333&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 17:18:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 17:18:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27010] Need to remove
 UsesManualToJSImplementation() in favor of CustomToJS : [Attachment 32334]
 Proposed patch
In-Reply-To: <bug-27010-0@https.bugs.webkit.org/>
References: <bug-27010-0@https.bugs.webkit.org/>
Message-ID: <20090707001858.034A53213137@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27010: Need to remove UsesManualToJSImplementation() in favor of CustomToJS
https://bugs.webkit.org/show_bug.cgi?id=27010

Attachment 32334: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32334&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 17:26:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 17:26:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27010] Need to remove
 UsesManualToJSImplementation() in favor of CustomToJS : [Attachment 32334]
 Proposed patch
In-Reply-To: <bug-27010-0@https.bugs.webkit.org/>
References: <bug-27010-0@https.bugs.webkit.org/>
Message-ID: <20090707002602.101C932133BE@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Andrew Wilson <atwilson at google.com>'s
request for review:
Bug 27010: Need to remove UsesManualToJSImplementation() in favor of CustomToJS
https://bugs.webkit.org/show_bug.cgi?id=27010

Attachment 32334: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32334&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
r=me assuming it build and tests pass

From bugzilla-daemon at webkit.org  Mon Jul  6 17:35:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 17:35:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27015] CSS properties such
 as color: and font-size: may be applied applied to the Media Controller
 text. : [Attachment 32335] patch v1.
In-Reply-To: <bug-27015-0@https.bugs.webkit.org/>
References: <bug-27015-0@https.bugs.webkit.org/>
Message-ID: <20090707003549.2984432136D5@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32335: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32335&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 17:47:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 17:47:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27015] CSS properties such as
 color: and font-size: may be applied applied to the Media Controller text.
 : [Attachment 32335] patch v1.
In-Reply-To: <bug-27015-0@https.bugs.webkit.org/>
References: <bug-27015-0@https.bugs.webkit.org/>
Message-ID: <20090707004713.3DD8B3213A50@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32335: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32335&action=edit

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
>     WebCore:
>     
>     2009-07-06  Pierre d'Herbemont  <pdherbemont at apple.com>
>     
>	      Reviewed by NOBODY (OOPS!).
>     
>	      Make sure the media controller style is not overrided.

This is too vague, and not actually correct. You need to take care that your
changelogs are very explicit about the changes being made, and that they make
sense to someone who is not familiar with the code.

>     
>	      This is only for QT mode. And this mostly affects text

What is QT mode (for someone not familiar)?

>	      properties.
>     
>	      There is a special case for text-decoration that can't
>	      be overrided from CSS. In this case we just
>	      force it from the code.

Where is the changelog file entry for this? In cases like this, it's good to
annotate the individual file changes one by one.

I'm going to be a hard-ass and r- this to give you some changelog-writing
practice.  :)

From bugzilla-daemon at webkit.org  Mon Jul  6 17:58:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 17:58:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32336] Proposed patch
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090707005832.69CCC3213E18@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32336: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32336&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:00:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:00:42 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26995] AX: Some webpages do
 not send AXLoadComplete : [Attachment 32332] Proposed patch
In-Reply-To: <bug-26995-0@https.bugs.webkit.org/>
References: <bug-26995-0@https.bugs.webkit.org/>
Message-ID: <20090707010042.3E5653213ED1@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 26995: AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995

Attachment 32332: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32332&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Code change looks fine. Needs comment explaining why it's calling getOrCreate
and discarding the result. Needs a ChangeLog.

review- because of those issues

From bugzilla-daemon at webkit.org  Mon Jul  6 18:02:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:02:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32338] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090707010234.5B9913213F7A@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32338: win patch
https://bugs.webkit.org/attachment.cgi?id=32338&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:06:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:06:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27008] bugzilla-tool fails
 with bugzilla 3.0 : [Attachment 32339] patch
In-Reply-To: <bug-27008-0@https.bugs.webkit.org/>
References: <bug-27008-0@https.bugs.webkit.org/>
Message-ID: <20090707010616.E3C7A32140CC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27008: bugzilla-tool fails with bugzilla 3.0
https://bugs.webkit.org/show_bug.cgi?id=27008

Attachment 32339: patch
https://bugs.webkit.org/attachment.cgi?id=32339&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:07:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:07:45 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32324] Patch v1
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090707010745.AE8123214181@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32324: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32324&action=edit

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Mark Rowe prefers #if macros around the IconDatabase.cpp and
IconDatabaseNone.cpp source rather than futzing with the
EXCLUDED_SOURCE_FILE_NAMES Xcode setting, so I will update the patch to do
that.

From bugzilla-daemon at webkit.org  Mon Jul  6 18:19:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:19:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25463] Desktop
 Notifications API : [Attachment 32341] Notifications API,
 Tests and DumpRenderTree hooks
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090707011959.05FA13214685@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has asked  for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 32341: Notifications API, Tests and DumpRenderTree hooks
https://bugs.webkit.org/attachment.cgi?id=32341&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:20:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:20:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25463] Desktop
 Notifications API : [Attachment 32342] Notifications API, V8 Bindings
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090707012008.2920132146AE@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has asked  for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 32342: Notifications API, V8 Bindings
https://bugs.webkit.org/attachment.cgi?id=32342&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:20:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:20:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25463] Desktop
 Notifications API : [Attachment 32344] Notifications API,
 Core & JSC Bindings
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090707012017.36A8932146D4@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has asked  for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 32344: Notifications API, Core & JSC Bindings
https://bugs.webkit.org/attachment.cgi?id=32344&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:22:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:22:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27015] CSS properties such
 as color: and font-size: may be applied applied to the Media Controller
 text. : [Attachment 32345] patch v2.
In-Reply-To: <bug-27015-0@https.bugs.webkit.org/>
References: <bug-27015-0@https.bugs.webkit.org/>
Message-ID: <20090707012253.B125732147E4@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32345: patch v2.
https://bugs.webkit.org/attachment.cgi?id=32345&action=edit

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
hum. ChangeLog more descriptive this time :-)

From bugzilla-daemon at webkit.org  Mon Jul  6 18:25:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:25:22 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26963] Reproducible crash at
 FontCache::getFontData() when a custom font is used in a pseudo-style :
 [Attachment 32328] Validate the pseudo-style cache on style recalc
In-Reply-To: <bug-26963-0@https.bugs.webkit.org/>
References: <bug-26963-0@https.bugs.webkit.org/>
Message-ID: <20090707012522.E986432148CE@gamma.macosforge.org>

mitz at webkit.org has canceled mitz at webkit.org's request for review:
Bug 26963: Reproducible crash at FontCache::getFontData() when a custom font is
used in a pseudo-style
https://bugs.webkit.org/show_bug.cgi?id=26963

Attachment 32328: Validate the pseudo-style cache on style recalc
https://bugs.webkit.org/attachment.cgi?id=32328&action=edit

------- Additional Comments from mitz at webkit.org
(In reply to comment #6)
> (From update of attachment 32328 [details])
> I'm concerned about the addition of the new firstLineStyle method to
> RenderObject.  It seems like that is going to be confusing next to the other
> first line style method.

I will try to come up with a more descriptive/discouraging name.

> Would it be cleaner to just build this pseudo style comparison into the diff
> method?

I?ll try that and see where I get stuck :-)

Thanks for the review!

From bugzilla-daemon at webkit.org  Mon Jul  6 18:30:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:30:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27015] CSS properties such
 as color: and font-size: may be applied applied to the Media Controller
 text. : [Attachment 32345] patch v2.
In-Reply-To: <bug-27015-0@https.bugs.webkit.org/>
References: <bug-27015-0@https.bugs.webkit.org/>
Message-ID: <20090707013002.1E5653214A48@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32345: patch v2.
https://bugs.webkit.org/attachment.cgi?id=32345&action=edit

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
git changelog was still the old one for some reason.

From bugzilla-daemon at webkit.org  Mon Jul  6 18:30:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:30:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27015] CSS properties such
 as color: and font-size: may be applied applied to the Media Controller
 text. : [Attachment 32346] patch v3.
In-Reply-To: <bug-27015-0@https.bugs.webkit.org/>
References: <bug-27015-0@https.bugs.webkit.org/>
Message-ID: <20090707013002.3162B3214A4C@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32346: patch v3.
https://bugs.webkit.org/attachment.cgi?id=32346&action=edit

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
git changelog was still the old one for some reason.

From bugzilla-daemon at webkit.org  Mon Jul  6 18:35:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:35:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27008] bugzilla-tool fails
 with bugzilla 3.0 : [Attachment 32339] patch
In-Reply-To: <bug-27008-0@https.bugs.webkit.org/>
References: <bug-27008-0@https.bugs.webkit.org/>
Message-ID: <20090707013506.5D4F63214BC0@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27008: bugzilla-tool fails with bugzilla 3.0
https://bugs.webkit.org/show_bug.cgi?id=27008

Attachment 32339: patch
https://bugs.webkit.org/attachment.cgi?id=32339&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 18:40:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:40:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26816] Selection changed by
 indent : [Attachment 32347] Refactors indentRegion further,
 and fixes the bug 26816 and 25317
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090707014012.C8ED13214D51@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32347: Refactors indentRegion further, and fixes the bug 26816 and
25317
https://bugs.webkit.org/attachment.cgi?id=32347&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 18:40:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:40:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26918] XSSAuditor should
 prevent injection of HTML Base tag : [Attachment 32348] Patch with tests
In-Reply-To: <bug-26918-0@https.bugs.webkit.org/>
References: <bug-26918-0@https.bugs.webkit.org/>
Message-ID: <20090707014016.6F1583214D67@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 26918: XSSAuditor should prevent injection of HTML Base tag
https://bugs.webkit.org/show_bug.cgi?id=26918

Attachment 32348: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32348&action=edit

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Cleaned up patch.

Removed test base-href-scheme-relative2.html. Added test
base-href-with-null-char.html.

From bugzilla-daemon at webkit.org  Mon Jul  6 18:48:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 18:48:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26790] ParserArenaDeletable
 should override delete : [Attachment 32349] Overeride ParserArenaDeletable
 delete
In-Reply-To: <bug-26790-0@https.bugs.webkit.org/>
References: <bug-26790-0@https.bugs.webkit.org/>
Message-ID: <20090707014820.676913214FF9@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32349: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32349&action=edit

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
Oops. Fixed a typo.

From bugzilla-daemon at webkit.org  Mon Jul  6 19:33:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 19:33:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26963] Reproducible crash
 at FontCache::getFontData() when a custom font is used in a pseudo-style :
 [Attachment 32328] Validate the pseudo-style cache on style recalc
In-Reply-To: <bug-26963-0@https.bugs.webkit.org/>
References: <bug-26963-0@https.bugs.webkit.org/>
Message-ID: <20090707023337.3E3B73215F09@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 26963: Reproducible crash at FontCache::getFontData() when a custom font is
used in a pseudo-style
https://bugs.webkit.org/show_bug.cgi?id=26963

Attachment 32328: Validate the pseudo-style cache on style recalc
https://bugs.webkit.org/attachment.cgi?id=32328&action=edit

------- Additional Comments from mitz at webkit.org
Node::diff() is now a static function (because of a callsite in
updateBeforeAfterContent(). I could make it take a renderer, but it seems
unnatural to supply a renderer at that stage, because the renderer depends on
style.

I can rename firstLineStyle() to uncachedFirstLineStyle() to discourage use and
add a comment.

r? again.

From bugzilla-daemon at webkit.org  Mon Jul  6 19:34:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 19:34:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32352] patch:
 update to remove conflicts
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090707023433.31FFA3215F6E@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32352: patch: update to remove conflicts
https://bugs.webkit.org/attachment.cgi?id=32352&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Same as previous patch, updated to remove patching conflicts

From bugzilla-daemon at webkit.org  Mon Jul  6 19:44:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 19:44:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27017] In the nitro-extreme
 branch,
 remove constants from the register file. : [Attachment 32353] The patch
In-Reply-To: <bug-27017-0@https.bugs.webkit.org/>
References: <bug-27017-0@https.bugs.webkit.org/>
Message-ID: <20090707024433.762F332163AB@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 27017: In the nitro-extreme branch, remove constants from the register
file.
https://bugs.webkit.org/show_bug.cgi?id=27017

Attachment 32353: The patch
https://bugs.webkit.org/attachment.cgi?id=32353&action=edit

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
~0.75% progression

From bugzilla-daemon at webkit.org  Mon Jul  6 20:03:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:03:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27018] Fix compile
 RenderThemeChromiumMac.mm due to API changes from r45572 : [Attachment
 32355] Compilation fix.
In-Reply-To: <bug-27018-0@https.bugs.webkit.org/>
References: <bug-27018-0@https.bugs.webkit.org/>
Message-ID: <20090707030325.EF9133216AEA@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27018: Fix compile RenderThemeChromiumMac.mm due to API changes from r45572
https://bugs.webkit.org/show_bug.cgi?id=27018

Attachment 32355: Compilation fix.
https://bugs.webkit.org/attachment.cgi?id=32355&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 20:03:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:03:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26963] Reproducible crash at
 FontCache::getFontData() when a custom font is used in a pseudo-style :
 [Attachment 32328] Validate the pseudo-style cache on style recalc
In-Reply-To: <bug-26963-0@https.bugs.webkit.org/>
References: <bug-26963-0@https.bugs.webkit.org/>
Message-ID: <20090707030333.B314B3216B00@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 26963: Reproducible crash at FontCache::getFontData() when a custom font is
used in a pseudo-style
https://bugs.webkit.org/show_bug.cgi?id=26963

Attachment 32328: Validate the pseudo-style cache on style recalc
https://bugs.webkit.org/attachment.cgi?id=32328&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> +bool Element::validatePseudoStyleCache(const RenderStyle* currentStyle,
RenderStyle* newStyle)

I don't understand why this function is named "validate" yet returns a boolean.
Typically if functions return a value they are named after the value. I think
the value means "needs to dump the style cache" or something like that, so
validate seems an unhelpful name.

> +    Vector<RenderStyle*, 10> pseudoStyleCache;

I'd prefer a typedef so the magic number 10 isn't repeated here.

> +	   if (*newPseudoStyle.get() != *pseudoStyleCache[i]) {

Do you really need the call to get() here? If so, I'm surprised you do.

Otherwise, based on Hyatt's review and my reading of the code, r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 20:15:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:15:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27017] In the nitro-extreme
 branch,
 remove constants from the register file. : [Attachment 32353] The patch
In-Reply-To: <bug-27017-0@https.bugs.webkit.org/>
References: <bug-27017-0@https.bugs.webkit.org/>
Message-ID: <20090707031507.A89E73216EDD@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27017: In the nitro-extreme branch, remove constants from the register
file.
https://bugs.webkit.org/show_bug.cgi?id=27017

Attachment 32353: The patch
https://bugs.webkit.org/attachment.cgi?id=32353&action=edit

------- Additional Comments from Sam Weinig <sam at webkit.org>
r=me

Can this be a static const instead of a #define.  How about a comment
explaining the magic number?

> +#define FirstConstantRegisterIndex 0x40000000

From bugzilla-daemon at webkit.org  Mon Jul  6 20:21:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:21:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32352] patch:
 update to remove conflicts
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090707032159.EADB832170FB@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has canceled Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32352: patch: update to remove conflicts
https://bugs.webkit.org/attachment.cgi?id=32352&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
@_@ How did that happen? Updated patch to remove tabs.

From bugzilla-daemon at webkit.org  Mon Jul  6 20:22:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:22:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32356] patch:
 remove tabs
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090707032200.03D1D32170FD@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32356: patch: remove tabs
https://bugs.webkit.org/attachment.cgi?id=32356&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
@_@ How did that happen? Updated patch to remove tabs.

From bugzilla-daemon at webkit.org  Mon Jul  6 20:26:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:26:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27018] Fix compile
 RenderThemeChromiumMac.mm due to API changes from r45572 : [Attachment
 32355] Compilation fix.
In-Reply-To: <bug-27018-0@https.bugs.webkit.org/>
References: <bug-27018-0@https.bugs.webkit.org/>
Message-ID: <20090707032636.CD7933217284@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27018: Fix compile RenderThemeChromiumMac.mm due to API changes from r45572
https://bugs.webkit.org/show_bug.cgi?id=27018

Attachment 32355: Compilation fix.
https://bugs.webkit.org/attachment.cgi?id=32355&action=edit

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Mon Jul  6 20:29:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:29:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32357] patch:
 remove tabs AND spurious file references
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090707032939.A8B3132173B0@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32357: patch: remove tabs AND spurious file references
https://bugs.webkit.org/attachment.cgi?id=32357&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Today seems to be not my day.  >_< Removed spurious file references at the end
of the patch file...

Sorry for the attachment spam.

From bugzilla-daemon at webkit.org  Mon Jul  6 20:29:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:29:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32356] patch:
 remove tabs
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090707032939.9C29E32173AE@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has canceled Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32356: patch: remove tabs
https://bugs.webkit.org/attachment.cgi?id=32356&action=edit

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Today seems to be not my day.  >_< Removed spurious file references at the end
of the patch file...

Sorry for the attachment spam.

From bugzilla-daemon at webkit.org  Mon Jul  6 20:32:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:32:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26829] add methods
 baselinePosition and lineHeight to InlineBox : [Attachment 32357] patch:
 remove tabs AND spurious file references
In-Reply-To: <bug-26829-0@https.bugs.webkit.org/>
References: <bug-26829-0@https.bugs.webkit.org/>
Message-ID: <20090707033208.3B6F43217492@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26829: add methods baselinePosition and lineHeight to InlineBox
https://bugs.webkit.org/show_bug.cgi?id=26829

Attachment 32357: patch: remove tabs AND spurious file references
https://bugs.webkit.org/attachment.cgi?id=32357&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

From bugzilla-daemon at webkit.org  Mon Jul  6 20:58:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 20:58:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27020]
 msToGregorianDateTime ignores outputIsUTC param when filling in utcOffset :
 [Attachment 32358] patch to DateMath.cpp
In-Reply-To: <bug-27020-0@https.bugs.webkit.org/>
References: <bug-27020-0@https.bugs.webkit.org/>
Message-ID: <20090707035838.BA6E93217CFE@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27020: msToGregorianDateTime ignores outputIsUTC param when filling in
utcOffset
https://bugs.webkit.org/show_bug.cgi?id=27020

Attachment 32358: patch to DateMath.cpp
https://bugs.webkit.org/attachment.cgi?id=32358&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 21:13:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 21:13:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27015] CSS properties such as
 color: and font-size: may be applied applied to the Media Controller text.
 : [Attachment 32346] patch v3.
In-Reply-To: <bug-27015-0@https.bugs.webkit.org/>
References: <bug-27015-0@https.bugs.webkit.org/>
Message-ID: <20090707041359.353D632181A6@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27015: CSS properties such as color: and font-size: may be applied applied
to the Media Controller text.
https://bugs.webkit.org/show_bug.cgi?id=27015

Attachment 32346: patch v3.
https://bugs.webkit.org/attachment.cgi?id=32346&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 22:16:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 22:16:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27017] In the nitro-extreme
 branch,
 remove constants from the register file. : [Attachment 32359] With layout
 test tweakage.
In-Reply-To: <bug-27017-0@https.bugs.webkit.org/>
References: <bug-27017-0@https.bugs.webkit.org/>
Message-ID: <20090707051609.CDFFE32194CE@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 27017: In the nitro-extreme branch, remove constants from the register
file.
https://bugs.webkit.org/show_bug.cgi?id=27017

Attachment 32359: With layout test tweakage.
https://bugs.webkit.org/attachment.cgi?id=32359&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 22:20:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 22:20:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27017] In the nitro-extreme
 branch,
 remove constants from the register file. : [Attachment 32359] With layout
 test tweakage.
In-Reply-To: <bug-27017-0@https.bugs.webkit.org/>
References: <bug-27017-0@https.bugs.webkit.org/>
Message-ID: <20090707052039.B3DA03219652@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27017: In the nitro-extreme branch, remove constants from the register
file.
https://bugs.webkit.org/show_bug.cgi?id=27017

Attachment 32359: With layout test tweakage.
https://bugs.webkit.org/attachment.cgi?id=32359&action=edit

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me on the layout test change

From bugzilla-daemon at webkit.org  Mon Jul  6 23:05:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 23:05:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27016] Interpreter crashes
 due to invalid array indexes : [Attachment 32361] fixeration!
In-Reply-To: <bug-27016-0@https.bugs.webkit.org/>
References: <bug-27016-0@https.bugs.webkit.org/>
Message-ID: <20090707060532.CA828321A575@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27016: Interpreter crashes due to invalid array indexes
https://bugs.webkit.org/show_bug.cgi?id=27016

Attachment 32361: fixeration!
https://bugs.webkit.org/attachment.cgi?id=32361&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 23:30:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 23:30:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27021] Make use of geometry
 information to decide which layers become composited : [Attachment 32362]
 Patch, changelog
In-Reply-To: <bug-27021-0@https.bugs.webkit.org/>
References: <bug-27021-0@https.bugs.webkit.org/>
Message-ID: <20090707063017.D71CE321ADA4@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27021: Make use of geometry information to decide which layers become
composited
https://bugs.webkit.org/show_bug.cgi?id=27021

Attachment 32362: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32362&action=edit

From bugzilla-daemon at webkit.org  Mon Jul  6 23:50:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon,  6 Jul 2009 23:50:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27016] Interpreter crashes
 due to invalid array indexes : [Attachment 32361] fixeration!
In-Reply-To: <bug-27016-0@https.bugs.webkit.org/>
References: <bug-27016-0@https.bugs.webkit.org/>
Message-ID: <20090707065045.8E4C3321B414@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27016: Interpreter crashes due to invalid array indexes
https://bugs.webkit.org/show_bug.cgi?id=27016

Attachment 32361: fixeration!
https://bugs.webkit.org/attachment.cgi?id=32361&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
Test case?

Why int32_t instead of just int?

r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 00:10:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:10:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26995] AX: Some webpages do
 not send AXLoadComplete : [Attachment 32351] Updated patch 3
In-Reply-To: <bug-26995-0@https.bugs.webkit.org/>
References: <bug-26995-0@https.bugs.webkit.org/>
Message-ID: <20090707071054.0C261321BAE0@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 26995: AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995

Attachment 32351: Updated patch 3
https://bugs.webkit.org/attachment.cgi?id=32351&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 00:12:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:12:46 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26971] [Qt] Fix build break in
 QtWebkit : [Attachment 32265] Fix build break introduced due to new
 functionality in the media support
In-Reply-To: <bug-26971-0@https.bugs.webkit.org/>
References: <bug-26971-0@https.bugs.webkit.org/>
Message-ID: <20090707071246.BBA0C321BBAB@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Sriram <sriram.yadavalli at nokia.com>'s
request for review:
Bug 26971: [Qt] Fix build break in QtWebkit
https://bugs.webkit.org/show_bug.cgi?id=26971

Attachment 32265: Fix build break introduced due to new functionality in the
media support
https://bugs.webkit.org/attachment.cgi?id=32265&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your patch is in a strange format with ../../ leading. That will break our
landing tools.	Also, You don't need to fill in the reviewer name, our scripts
will do that for you.  r- (unless Simon wants to r+ this and fix it when he
lands it for you).

From bugzilla-daemon at webkit.org  Tue Jul  7 00:14:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:14:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26969] Fix ASSERT in
 WebCore::DocumentThreadableLoader::didFail : [Attachment 32325] updated
 changelog
In-Reply-To: <bug-26969-0@https.bugs.webkit.org/>
References: <bug-26969-0@https.bugs.webkit.org/>
Message-ID: <20090707071446.3C9AD321BC79@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted robert <robert at roberthogan.net>'s
request for review:
Bug 26969: Fix ASSERT in WebCore::DocumentThreadableLoader::didFail
https://bugs.webkit.org/show_bug.cgi?id=26969

Attachment 32325: updated changelog
https://bugs.webkit.org/attachment.cgi?id=32325&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
We normally use full english words, like "Constructor" instead of ctor.

This looks fine.  I assume this fails on the Qt or Gtk builds?	In which case
it would have made sense to make a layout test for them.  I will OK it as is
though.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:17:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:17:36 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26962] [V8] Move some simple
 utility functions in V8Proxy to V8Utilities : [Attachment 32294] patch
In-Reply-To: <bug-26962-0@https.bugs.webkit.org/>
References: <bug-26962-0@https.bugs.webkit.org/>
Message-ID: <20090707071736.A2CDA321BD94@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26962: [V8] Move some simple utility functions in V8Proxy to V8Utilities
https://bugs.webkit.org/show_bug.cgi?id=26962

Attachment 32294: patch
https://bugs.webkit.org/attachment.cgi?id=32294&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your comment format is a bit strange.  I would not have added all the crazy
//////.

It would make sense to me to describe each of these new classes some, more than
just putting their names there.

// Move to V8Constants, a class to hold all the constants used by V8?

// Move to V8EventListener, a subclass of EventListener with v8 specific
methods.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:21:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:21:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32231] Patch to add DragClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090707072105.7C1B1321BEF9@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32231: Patch to add DragClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32231&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems like you probably wanted DragDestinationActionNone, but OK.

Looks OK.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:21:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:21:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32234] Patch to add InspectorClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090707072153.1FA58321BF5F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32234: Patch to add InspectorClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32234&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK.  We've often used TemporaryLinkStubs for such things, but this is
also fine.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:23:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:23:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32222] Patch to add Haiku-specific files
 for WebCore/editing/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707072303.595B0321BFB5@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32222: Patch to add Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/attachment.cgi?id=32222&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:23:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:23:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32221] Patch to add Haiku-specific files
 for WebCore/bindings/js/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707072347.7710E321C039@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32221: Patch to add Haiku-specific files for WebCore/bindings/js/.
https://bugs.webkit.org/attachment.cgi?id=32221&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  Seems kinda silly that this code can't be shared between more ports?

From bugzilla-daemon at webkit.org  Tue Jul  7 00:25:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:25:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32223] Patch to add Haiku-specific files
 for WebCore/page/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707072508.42675321C0C3@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32223: Patch to add Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/attachment.cgi?id=32223&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sad that more of this code can't be shared between ports.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:26:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:26:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32220] Patch to add Haiku-specific files
 for WebCore/platform/text/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707072630.5EB40321C149@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32220: Patch to add Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/attachment.cgi?id=32220&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Does this copy the data?
string.SetTo(utf8().data());

If it doesn't then your WebKit will crash all the time as StringImpls get
released before the corresponding BStrings do...

r+ assuming this won't crash. :)

From bugzilla-daemon at webkit.org  Tue Jul  7 00:27:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:27:56 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32219] Patch to add Haiku-specific files
 for WebCore/platform/image-decoders/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707072756.6BA57321C1DC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32219: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32219&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
This cast seems unecessary:
+    const void* bytes = (const void*)m_bytes.data();

STyle:
+int RGBA32Buffer::width() const {
+    return m_size.width();
+}
+
+int RGBA32Buffer::height() const {
+    return m_size.height();
+}

From bugzilla-daemon at webkit.org  Tue Jul  7 00:33:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:33:22 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32227] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707073322.6B068321C3BB@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32227: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32227&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why the prefix "pc"?
65     const BFont* pcDefaultFont = be_plain_font;

Are you sure you meant to levae this in?
 72	printf("FontCache::getLastResortFallbackFont -> %s\n", family);

Spacing:
 74	BView* view = static_cast<BView*> (graphicsContext->platformContext());


Style:
 50	    FontPlatformData(const FontPlatformData& f);
 48	    FontPlatformData(const FontDescription&, BFont* font);

count_font_families() sounds expensive. :)
 71	for(int i = 0; i < count_font_families(); i++) {

style:
 73	    if(!BString(familyName.string()).Compare(family)){

MOre style:
 90		if ( get_font_style(family, i, &style, &flags) == B_OK) {
 91		    if((bItalic && bBold) &&  (!strcmp( style, "BoldItalic")
 92			    || !strcmp(style, "Bold Oblique"))) {


You could also convert "style" to be a String and then style == "Bold Oblique"
would read a bit better.

Style:
53	   } else {
 54		character = characterBuffer[i];
 55	    }

Doesn't ICU, and other parts of WebCore already have code for dealign with
this:
	 if(isUtf16) {
 50		UChar lead = characterBuffer[i * 2];
 51		UChar trail = characterBuffer[i * 2 + 1];
 52		character = U16_GET_SUPPLEMENTARY(lead, trail);
 53	    } else {
 54		character = characterBuffer[i];
 55	    } 

Style:
 46	BFont *font = m_platformData.font();

From bugzilla-daemon at webkit.org  Tue Jul  7 00:41:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:41:42 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32336] Proposed patch
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090707074142.B2206321C6EA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32336: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32336&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your ChangeLog has boilerplate code in it.  Please read the boilerplate and act
on it.

This needs an automated test.  It's possible to test file drags and file
uploads using DumpRenderTree (at least on the mac).  Look at creating an http/
test which uses eventSender.beginDragWithFiles() you could also create a new
layoutTestController method which did fileObjectForPath() or similar if you
wanted to make test which didn't require drag and drop but still used File
objects.

From bugzilla-daemon at webkit.org  Tue Jul  7 00:44:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:44:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25401] <use> of text not
 displayed unless declared after : [Attachment 32278] First attempt
In-Reply-To: <bug-25401-0@https.bugs.webkit.org/>
References: <bug-25401-0@https.bugs.webkit.org/>
Message-ID: <20090707074401.CD832321C7B3@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Rob Buis <rwlbuis at gmail.com>'s request
for review:
Bug 25401: <use> of text not displayed unless declared after
https://bugs.webkit.org/show_bug.cgi?id=25401

Attachment 32278: First attempt
https://bugs.webkit.org/attachment.cgi?id=32278&action=edit

------- Additional Comments from Eric Seidel <eric at webkit.org>
Isn't:
8     // Invalidate all SVGElementInstances associated with us
 139	 SVGElementInstance::invalidateAllInstancesOfElement(this);
needed in the root SVGElement childrenChanged method?  How do we handle
updating <use> elements when other subtrees change?

From bugzilla-daemon at webkit.org  Tue Jul  7 00:54:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 00:54:15 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26995] AX: Some webpages do
 not send AXLoadComplete : [Attachment 32351] Updated patch 3
In-Reply-To: <bug-26995-0@https.bugs.webkit.org/>
References: <bug-26995-0@https.bugs.webkit.org/>
Message-ID: <20090707075415.9389B321CB1B@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 26995: AX: Some webpages do not send AXLoadComplete
https://bugs.webkit.org/show_bug.cgi?id=26995

Attachment 32351: Updated patch 3
https://bugs.webkit.org/attachment.cgi?id=32351&action=edit

------- Additional Comments from Darin Adler <darin at apple.com>
> +    RenderObject* render = renderer();

An idiom we use for this is

    RenderObject* renderer = this->renderer();

The downside of naming the variable "render" is that's a verb with a different
meaning.

Is there any way to make a regression test for this?

r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 01:19:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 01:19:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26915] HTML5: DOM binding of
 <datalist> element : [Attachment 32290] Proposed patch
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090707081929.B7E3B321D2F4@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has canceled TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32290: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32290&action=edit

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Reverted the whitespace changes in HTMLCollection.cpp

From bugzilla-daemon at webkit.org  Tue Jul  7 01:19:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 01:19:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26915] HTML5: DOM binding
 of <datalist> element : [Attachment 32363] Proposed patch (rev.2)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090707081929.C4815321D2F6@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32363: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=32363&action=edit

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Reverted the whitespace changes in HTMLCollection.cpp

From bugzilla-daemon at webkit.org  Tue Jul  7 01:34:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 01:34:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32364] Patch to add Haiku-specific files
 for WebCore/platform/image-decoders/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707083459.8D41E321D815@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32364: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32364&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 01:51:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 01:51:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26816] Selection changed by
 indent : [Attachment 32367] Refactors indentRegion and fixes the bugs 26816
 and 25317 (a minor change on the prototype of indentListItem)
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090707085151.C308F321DE2F@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32367: Refactors indentRegion and fixes the bugs 26816 and 25317 (a
minor change on the prototype of indentListItem)
https://bugs.webkit.org/attachment.cgi?id=32367&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 01:51:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 01:51:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26816] Selection changed by
 indent : [Attachment 32347] Refactors indentRegion further,
 and fixes the bug 26816 and 25317
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090707085151.AC62A321DE2B@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32347: Refactors indentRegion further, and fixes the bug 26816 and
25317
https://bugs.webkit.org/attachment.cgi?id=32347&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 01:59:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 01:59:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32368] Proposed patch (rev.2)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090707085946.9A5BC321E0A5@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32368: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=32368&action=edit

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Eric,
Thank you for the advice.  I have updated the ChangeLog, made an automated
test, and removed the manual test.

From bugzilla-daemon at webkit.org  Tue Jul  7 02:05:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 02:05:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32369] Proposed patch (rev.3)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090707090505.D3FB8321E24D@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32369: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=32369&action=edit

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Oops, removed unnecessary JavaScript code.

From bugzilla-daemon at webkit.org  Tue Jul  7 02:05:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 02:05:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32368] Proposed patch (rev.2)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090707090505.C7523321E24B@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has canceled TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32368: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=32368&action=edit

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Oops, removed unnecessary JavaScript code.

From bugzilla-daemon at webkit.org  Tue Jul  7 02:31:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 02:31:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25205] XMLHttpRequest
 instance is not an instanceof XMLHttpRequest : [Attachment 32370] Fix for
 "instanceof XMLHttpRequest"
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090707093158.2B59F321EC21@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32370: Fix for "instanceof XMLHttpRequest"
https://bugs.webkit.org/attachment.cgi?id=32370&action=edit

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Hi,

Can you review the attached patch?
It attempts to fix this bug by setting JSC::ImplementsHasInstance flag for
JSXMLHttpRequestConstructor.

Yuzo

From bugzilla-daemon at webkit.org  Tue Jul  7 03:17:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 03:17:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32371] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090707101718.71347321FDE4@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32371: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32371&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 04:58:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 04:58:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27025] Crashes and
 regression test failures related to regexps in 64-bit : [Attachment 32372]
 Patch!
In-Reply-To: <bug-27025-0@https.bugs.webkit.org/>
References: <bug-27025-0@https.bugs.webkit.org/>
Message-ID: <20090707115804.EB3F532227AA@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has asked  for review:
Bug 27025: Crashes and regression test failures related to regexps in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=27025

Attachment 32372: Patch!
https://bugs.webkit.org/attachment.cgi?id=32372&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 05:17:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 05:17:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26791] [Gtk] Paste of rich
 text from firefox results garbled markup : [Attachment 32264] add a manual
 test in WebCore/manual-tests/gtk
In-Reply-To: <bug-26791-0@https.bugs.webkit.org/>
References: <bug-26791-0@https.bugs.webkit.org/>
Message-ID: <20090707121710.34D573222ED9@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 26791: [Gtk] Paste of rich text from firefox results garbled markup
https://bugs.webkit.org/show_bug.cgi?id=26791

Attachment 32264: add a manual test in WebCore/manual-tests/gtk
https://bugs.webkit.org/attachment.cgi?id=32264&action=edit

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -	   String html = String::fromUTF8(reinterpret_cast<gchar*>(data->data),
data->length * data->format / 8);
> +	   String html;
> +	   RefPtr<TextResourceDecoder> decoder =
TextResourceDecoder::create("text/plain", "UTF-8", true);
> +	   html = decoder->decode(reinterpret_cast<char*>(data->data),
data->length);
> +	   html += decoder->flush();
>	   gtk_selection_data_free(data);

Declaration and the first assignment can be in the same line here. 

Looks fine and the patch works great! r=me.

From bugzilla-daemon at webkit.org  Tue Jul  7 05:38:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 05:38:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26882] Speed up creation of
 V8 wrappers for DOM nodes : [Attachment 32373] Uploaded updated version
In-Reply-To: <bug-26882-0@https.bugs.webkit.org/>
References: <bug-26882-0@https.bugs.webkit.org/>
Message-ID: <20090707123839.A433F322368B@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 26882: Speed up creation of V8 wrappers for DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=26882

Attachment 32373: Uploaded updated version
https://bugs.webkit.org/attachment.cgi?id=32373&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 05:43:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 05:43:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27026] Guard singal.h
 dependency with HAVE(SIGNAL_H) : [Attachment 32374] Proposed fix.
In-Reply-To: <bug-27026-0@https.bugs.webkit.org/>
References: <bug-27026-0@https.bugs.webkit.org/>
Message-ID: <20090707124348.F00E83223856@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27026: Guard singal.h dependency with HAVE(SIGNAL_H)
https://bugs.webkit.org/show_bug.cgi?id=27026

Attachment 32374: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32374&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 06:28:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 06:28:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop
 support : [Attachment 32375] Third patch
In-Reply-To: <bug-23642-0@https.bugs.webkit.org/>
References: <bug-23642-0@https.bugs.webkit.org/>
Message-ID: <20090707132852.AA2F93224A35@gamma.macosforge.org>

Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 32375: Third patch
https://bugs.webkit.org/attachment.cgi?id=32375&action=edit

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
Re-upload of the third patch, now with a proper review flag.

From bugzilla-daemon at webkit.org  Tue Jul  7 06:54:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 06:54:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32376] Fix improper set of enum WebKitWebViewTargetInfo
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090707135436.2516E322544C@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32376: Fix improper set of enum WebKitWebViewTargetInfo
https://bugs.webkit.org/attachment.cgi?id=32376&action=edit

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
I use this Change:
> Index: WebCore/platform/gtk/PasteboardGtk.cpp
> ===================================================================
> --- WebCore/platform/gtk/PasteboardGtk.cpp	(revision 45546)
> +++ WebCore/platform/gtk/PasteboardGtk.cpp	(working copy)
> @@ -37,8 +38,8 @@ namespace WebCore {
>  /* FIXME: we must get rid of this and use the enum in webkitwebview.h
someway */
>  typedef enum
>  {
> -    WEBKIT_WEB_VIEW_TARGET_INFO_HTML = - 1,
> -    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT = - 2
> +    WEBKIT_WEB_VIEW_TARGET_INFO_HTML,
> +    WEBKIT_WEB_VIEW_TARGET_INFO_TEXT
>  } WebKitWebViewTargetInfo;
> 

it works.
it can use Ctrl-C to Copy rich text from WebkitGtk page now.

From bugzilla-daemon at webkit.org  Tue Jul  7 06:55:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 06:55:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27027] Add missing include
 + fix typo in RenderThemeChromiumMac.mm : [Attachment 32377] 2-line patch
 to fix the chromium compile.
In-Reply-To: <bug-27027-0@https.bugs.webkit.org/>
References: <bug-27027-0@https.bugs.webkit.org/>
Message-ID: <20090707135510.1E6C1322549C@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27027: Add missing include + fix typo in RenderThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=27027

Attachment 32377: 2-line patch to fix the chromium compile.
https://bugs.webkit.org/attachment.cgi?id=32377&action=edit

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
This should have been part of the patch for
https://bugs.webkit.org/show_bug.cgi?id=27018, but I uploaded an old diff. :(

From bugzilla-daemon at webkit.org  Tue Jul  7 08:18:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:18:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18984] [GTK] textarea
 height property works only if other property are defined : [Attachment
 32378] patch
In-Reply-To: <bug-18984-0@https.bugs.webkit.org/>
References: <bug-18984-0@https.bugs.webkit.org/>
Message-ID: <20090707151822.6EC9C3227487@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 18984: [GTK] textarea height property works only if other property are
defined
https://bugs.webkit.org/show_bug.cgi?id=18984

Attachment 32378: patch
https://bugs.webkit.org/attachment.cgi?id=32378&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 08:28:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:28:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27025] Crashes and regression
 test failures related to regexps in 64-bit : [Attachment 32372] Patch!
In-Reply-To: <bug-27025-0@https.bugs.webkit.org/>
References: <bug-27025-0@https.bugs.webkit.org/>
Message-ID: <20090707152820.E900832278F7@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Mark Rowe (bdash) <mrowe at apple.com>'s
request for review:
Bug 27025: Crashes and regression test failures related to regexps in 64-bit
https://bugs.webkit.org/show_bug.cgi?id=27025

Attachment 32372: Patch!
https://bugs.webkit.org/attachment.cgi?id=32372&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 08:29:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:29:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27026] Guard signal.h
 dependency with HAVE(SIGNAL_H) : [Attachment 32374] Proposed fix.
In-Reply-To: <bug-27026-0@https.bugs.webkit.org/>
References: <bug-27026-0@https.bugs.webkit.org/>
Message-ID: <20090707152922.D4782322798D@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27026: Guard signal.h dependency with HAVE(SIGNAL_H)
https://bugs.webkit.org/show_bug.cgi?id=27026

Attachment 32374: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32374&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 08:32:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:32:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27030] [WINCE] random
 number generator is too slow : [Attachment 32379] patch adding mt19937ar.c
 for WinCE
In-Reply-To: <bug-27030-0@https.bugs.webkit.org/>
References: <bug-27030-0@https.bugs.webkit.org/>
Message-ID: <20090707153239.0341E3227AF6@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27030: [WINCE] random number generator is too slow
https://bugs.webkit.org/show_bug.cgi?id=27030

Attachment 32379: patch adding mt19937ar.c for WinCE
https://bugs.webkit.org/attachment.cgi?id=32379&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 08:35:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:35:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 18984] [GTK] textarea height
 property works only if other property are defined : [Attachment 32378]
 patch
In-Reply-To: <bug-18984-0@https.bugs.webkit.org/>
References: <bug-18984-0@https.bugs.webkit.org/>
Message-ID: <20090707153512.40B063227BED@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has denied Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 18984: [GTK] textarea height property works only if other property are
defined
https://bugs.webkit.org/show_bug.cgi?id=18984

Attachment 32378: patch
https://bugs.webkit.org/attachment.cgi?id=32378&action=edit

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Thanks for looking into this! It makes me sad =). I believe leaving this for
webcore to do is not really what we want; we probably want to do the same as
adjustTextFieldStyle, except for setting the height to auto. I'll say r- on
that basis.

From bugzilla-daemon at webkit.org  Tue Jul  7 08:39:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:39:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27031] [WINCE] needs
 OwnPtr<HDC> : [Attachment 32380] patch implemented deleteOwnedPtr(HDC) for
 Windows
In-Reply-To: <bug-27031-0@https.bugs.webkit.org/>
References: <bug-27031-0@https.bugs.webkit.org/>
Message-ID: <20090707153911.2BF383227DA7@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27031: [WINCE] needs OwnPtr<HDC>
https://bugs.webkit.org/show_bug.cgi?id=27031

Attachment 32380: patch implemented deleteOwnedPtr(HDC) for Windows
https://bugs.webkit.org/attachment.cgi?id=32380&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 08:44:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 08:44:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 18984] [GTK] textarea height
 property works only if other property are defined : [Attachment 32378]
 patch
In-Reply-To: <bug-18984-0@https.bugs.webkit.org/>
References: <bug-18984-0@https.bugs.webkit.org/>
Message-ID: <20090707154416.AFF233227FAB@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted  review:
Bug 18984: [GTK] textarea height property works only if other property are
defined
https://bugs.webkit.org/show_bug.cgi?id=18984

Attachment 32378: patch
https://bugs.webkit.org/attachment.cgi?id=32378&action=edit

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
After clarifying a few concerns with Jan regarding the effect this had in
things such as dark themes, I now believe this is correct, so I'll say r=me.

From bugzilla-daemon at webkit.org  Tue Jul  7 09:15:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 09:15:15 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26882] Speed up creation of
 V8 wrappers for DOM nodes : [Attachment 32373] Uploaded updated version
In-Reply-To: <bug-26882-0@https.bugs.webkit.org/>
References: <bug-26882-0@https.bugs.webkit.org/>
Message-ID: <20090707161515.9DA593228C0A@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 26882: Speed up creation of V8 wrappers for DOM nodes
https://bugs.webkit.org/show_bug.cgi?id=26882

Attachment 32373: Uploaded updated version
https://bugs.webkit.org/attachment.cgi?id=32373&action=edit

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
>Index: bindings/v8/V8Proxy.cpp

>+static const V8ClassIndex::V8WrapperType mapping[] = {
>+    V8ClassIndex::INVALID_CLASS_INDEX,    // NONE
>+    V8ClassIndex::INVALID_CLASS_INDEX,    // ELEMENT_NODE needs special
treatment
>+    V8ClassIndex::ATTR,		    // ATTRIBUTE_NODE
>+    V8ClassIndex::TEXT,		    // TEXT_NODE
>+    V8ClassIndex::CDATASECTION,	    // CDATA_SECTION_NODE
>+    V8ClassIndex::ENTITYREFERENCE,	    // ENTITY_REFERENCE_NODE
>+    V8ClassIndex::ENTITY,		    // ENTITY_NODE
>+    V8ClassIndex::PROCESSINGINSTRUCTION,  // PROCESSING_INSTRUCTION_NODE
>+    V8ClassIndex::COMMENT,		    // COMMENT_NODE
>+    V8ClassIndex::INVALID_CLASS_INDEX,    // DOCUMENT_NODE needs special
treatment
>+    V8ClassIndex::DOCUMENTTYPE,	    // DOCUMENT_TYPE_NODE
>+    V8ClassIndex::DOCUMENTFRAGMENT,	    // DOCUMENT_FRAGMENT_NODE
>+    V8ClassIndex::NOTATION,		    // NOTATION_NODE
>+    V8ClassIndex::NODE,		    // XPATH_NAMESPACE_NODE
>+};

This is a little bit fragile.  If someone changes the NodeType
enum, then we'll be in trouble.  I don't have a good suggestion
to avoid this though :(

R=me

From bugzilla-daemon at webkit.org  Tue Jul  7 09:20:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 09:20:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27031] [WINCE] needs
 OwnPtr<HDC> : [Attachment 32380] patch implemented deleteOwnedPtr(HDC) for
 Windows
In-Reply-To: <bug-27031-0@https.bugs.webkit.org/>
References: <bug-27031-0@https.bugs.webkit.org/>
Message-ID: <20090707162030.F002C3228E2C@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27031: [WINCE] needs OwnPtr<HDC>
https://bugs.webkit.org/show_bug.cgi?id=27031

Attachment 32380: patch implemented deleteOwnedPtr(HDC) for Windows
https://bugs.webkit.org/attachment.cgi?id=32380&action=edit

From bugzilla-daemon at webkit.org  Tue Jul  7 09:20:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 09:20:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27030] [WINCE] random number
 generator is too slow : [Attachment 32379] patch adding mt19937ar.c for
 WinCE
In-Reply-To: <bug-27030-0@https.bugs.webkit.org/>
References: <bug-27030-0@https.bugs.webkit.org/>
Message-ID: <20090707162040.E2F753228E50@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27030: [WINCE] random number generator is too slow
https://bugs.webkit.org/show_bug.cgi?id=27030

Attachment 32379: patch adding mt19937ar.c for WinCE
https://bugs.webkit.org/attachment.cgi?id=32379&action=edit

------- Additional Comments from George Staikos <staikos at kde.org>
The initialization code should be brought inline with the current system where
a function is called.

From bugzilla-daemon at webkit.org  Tue Jul  7 10:10:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 10:10:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27021] Make use of geometry
 information to decide which layers become composited : [Attachment 32362]
 Patch, changelog
In-Reply-To: <bug-27021-0@https.bugs.webkit.org/>
References: <bug-27021-0@https.bugs.webkit.org/>
Message-ID: <20090707171056.4141C322A53E@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 27021: Make use of geometry information to decide which layers become
composited
https://bugs.webkit.org/show_bug.cgi?id=27021

Attachment 32362: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32362&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 10:35:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 10:35:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32384]
 Addressing Mads' comments
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090707173533.85E52322B03C@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32384: Addressing Mads' comments
https://bugs.webkit.org/attachment.cgi?id=32384&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Mads, thanks a lot for review!

I hope I addressed all your comments.  I don't know if we need this assert at
all, but I just don't want to touch it as my knowledge of bindings is currently
limited.  But if you all agree it should go away, I'd be more than happy to
remove it.

Sorry, original patch didn't compile cleanly in debug mode (some checks in
asserts), so I needed to through in some more changes, but of the similar
kind---don't downcast to v8::Value.

And I need a patch for webkit/glue part as well (sending it to you, guys).

From bugzilla-daemon at webkit.org  Tue Jul  7 10:37:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 10:37:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32244]
 The patch
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090707173704.0F7C2322B0ED@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has canceled anton muhin
<antonm at chromium.org>'s request for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32244: The patch
https://bugs.webkit.org/attachment.cgi?id=32244&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 10:37:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 10:37:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32384]
 Addressing Mads' comments
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090707173704.2633D322B0F1@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has canceled anton muhin
<antonm at chromium.org>'s request for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32384: Addressing Mads' comments
https://bugs.webkit.org/attachment.cgi?id=32384&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 10:37:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 10:37:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32385]
 Removing forgotten line from ChangeLog
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090707173731.99971322B137@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32385: Removing forgotten line from ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32385&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 10:40:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 10:40:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27030] [WINCE] random
 number generator is too slow : [Attachment 32386] updated patch
In-Reply-To: <bug-27030-0@https.bugs.webkit.org/>
References: <bug-27030-0@https.bugs.webkit.org/>
Message-ID: <20090707174010.04A54322B256@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27030: [WINCE] random number generator is too slow
https://bugs.webkit.org/show_bug.cgi?id=27030

Attachment 32386: updated patch
https://bugs.webkit.org/attachment.cgi?id=32386&action=review

------- Additional Comments from Joe Mason <joe.mason at torchmobile.com>
Done.  Also added an srand call so that the default RNG used to fill the
initialization array for MT is itself initialized - I believe in the first
patch it was always using the same seed.

From bugzilla-daemon at webkit.org  Tue Jul  7 11:09:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 11:09:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27035] [Chromium] Upstream
 DOMObjectsInclude.h : [Attachment 32387] patch
In-Reply-To: <bug-27035-0@https.bugs.webkit.org/>
References: <bug-27035-0@https.bugs.webkit.org/>
Message-ID: <20090707180925.A8264322BF34@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27035: [Chromium] Upstream DOMObjectsInclude.h
https://bugs.webkit.org/show_bug.cgi?id=27035

Attachment 32387: patch
https://bugs.webkit.org/attachment.cgi?id=32387&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 12:42:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 12:42:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27037] Fix baselines for
 inline tables. : [Attachment 32388] patch
In-Reply-To: <bug-27037-0@https.bugs.webkit.org/>
References: <bug-27037-0@https.bugs.webkit.org/>
Message-ID: <20090707194223.9E25B322E88E@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked  for review:
Bug 27037: Fix baselines for inline tables.
https://bugs.webkit.org/show_bug.cgi?id=27037

Attachment 32388: patch
https://bugs.webkit.org/attachment.cgi?id=32388&action=review

------- Additional Comments from Adam Langley <agl at chromium.org>
I'm not sure that the patch fixes this in the right way. The layout test
included certainly demonstrates the issue and the patch fixes that, but it
seems to cause some layout test failures which I'm still looking at.

From bugzilla-daemon at webkit.org  Tue Jul  7 13:10:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 13:10:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26918] XSSAuditor should
 prevent injection of HTML Base tag : [Attachment 32348] Patch with tests
In-Reply-To: <bug-26918-0@https.bugs.webkit.org/>
References: <bug-26918-0@https.bugs.webkit.org/>
Message-ID: <20090707201001.B3C03322F3C7@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26918: XSSAuditor should prevent injection of HTML Base tag
https://bugs.webkit.org/show_bug.cgi?id=26918

Attachment 32348: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32348&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks pretty good.  Only one detail to change. 

> +	   m_hrefAttrValue =
StringImpl::createStrippingNullCharacters(attr->value().characters(),
attr->value().length());

It doesn't seem right to do the null stripping here.  m_hrefAttrValue should
hold the value of the href attr, nulls and all.

> +bool XSSAuditor::canSetBaseElementURL(const String& url) const

We can either do the null stripping here or find a way to tell findInRequest
not to strip nulls.

Do we have this same null issue with <script src="..."> or canLoadObject?  If
so, we should fix that in a separate bug.

From bugzilla-daemon at webkit.org  Tue Jul  7 13:18:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 13:18:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27035] [Chromium] Upstream
 DOMObjectsInclude.h : [Attachment 32387] patch
In-Reply-To: <bug-27035-0@https.bugs.webkit.org/>
References: <bug-27035-0@https.bugs.webkit.org/>
Message-ID: <20090707201849.E7C57322F76F@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27035: [Chromium] Upstream DOMObjectsInclude.h
https://bugs.webkit.org/show_bug.cgi?id=27035

Attachment 32387: patch
https://bugs.webkit.org/attachment.cgi?id=32387&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/bindings/v8/DOMObjectsInclude.h

> + * this software without specific prior written permission.
> + * 

^^^ looks like there is an extra space at the end of that line.


> +#if ENABLE(DOM_STORAGE)
> +#include "Storage.h"
> +#include "StorageEvent.h"
> +#endif

^^^ should that have a "// STORAGE" comment like the others?


otherwise, R=me

From bugzilla-daemon at webkit.org  Tue Jul  7 13:42:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 13:42:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32389]
 fixes the bug
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707204219.6CF8132300FB@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32389: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32389&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at google.com>
This patch supplies utility functions to resolve the bug 26816.

From bugzilla-daemon at webkit.org  Tue Jul  7 13:46:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 13:46:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32389] fixes the
 bug
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707204640.9AA8A3230332@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32389: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32389&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 13:50:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 13:50:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32391]
 removed tab from the patch
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707205054.58535323051A@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32391: removed tab from the patch
https://bugs.webkit.org/attachment.cgi?id=32391&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 14:21:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 14:21:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27042] Incomplete painting
 of newly created floats : [Attachment 32393] Patch, including repaint tests
In-Reply-To: <bug-27042-0@https.bugs.webkit.org/>
References: <bug-27042-0@https.bugs.webkit.org/>
Message-ID: <20090707212112.632B93231408@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27042: Incomplete painting of newly created floats
https://bugs.webkit.org/show_bug.cgi?id=27042

Attachment 32393: Patch, including repaint tests
https://bugs.webkit.org/attachment.cgi?id=32393&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 14:32:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 14:32:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27042] Incomplete painting of
 newly created floats : [Attachment 32393] Patch, including repaint tests
In-Reply-To: <bug-27042-0@https.bugs.webkit.org/>
References: <bug-27042-0@https.bugs.webkit.org/>
Message-ID: <20090707213205.7CCEC32318DF@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 27042: Incomplete painting of newly created floats
https://bugs.webkit.org/show_bug.cgi?id=27042

Attachment 32393: Patch, including repaint tests
https://bugs.webkit.org/attachment.cgi?id=32393&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +	   for (size_t i = 0; i < floatCount; ++i) {
> +	       if (!floats[i].everHadLayout) {
> +		   RenderBox* f = floats[i].object;
> +		   if (!f->x() && !f->y() && f->checkForRepaintDuringLayout())

I have a preference for comparing with 0 for coordinates, but r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 15:01:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:01:44 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32391] removed
 tab from the patch
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707220144.61736323259B@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32391: removed tab from the patch
https://bugs.webkit.org/attachment.cgi?id=32391&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at google.com>
I removed getVisibleRangeOfNode and added visiblePositionBeforeNode and
visiblePositionAfterNode.  This would clean up the rest of my patch a little
bit.

From bugzilla-daemon at webkit.org  Tue Jul  7 15:01:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:01:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32394]
 fixed the style violations
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707220144.802A6323259F@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32394: fixed the style violations
https://bugs.webkit.org/attachment.cgi?id=32394&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at google.com>
I removed getVisibleRangeOfNode and added visiblePositionBeforeNode and
visiblePositionAfterNode.  This would clean up the rest of my patch a little
bit.

From bugzilla-daemon at webkit.org  Tue Jul  7 15:09:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:09:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32394] fixed the
 style violations
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707220910.D53EF3232918@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32394: fixed the style violations
https://bugs.webkit.org/attachment.cgi?id=32394&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 15:09:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:09:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32395]
 updated ChangeLog
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707220910.ED2EA323291D@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32395: updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32395&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 15:21:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:21:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32396] Bug 27007: Build fixes when
 ICONDATABASE is disabled
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090707222131.ADE903232E73@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32396:	  Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/attachment.cgi?id=32396&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	<https://bugs.webkit.org/show_bug.cgi?id=27007>

	Reviewed by NOBODY (OOPS!).

WebCore:

	* WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp
	to the project.
	* loader/icon/IconDatabase.cpp: Added
	#if ENABLE(ICONDATABASE)/#endif macro guard.
	* loader/icon/IconDatabase.h: Removed three public methods from
	#if ENABLE(ICONDATABASE)/#endif macro so that they may be
	stubbed out in IconDatabaseNone.cpp.
	* loader/icon/IconDatabaseNone.cpp: Added
	#if !ENABLE(ICONDATABASE)/#endif macro guard.
	(WebCore::IconDatabase::importIconURLForPageURL): Added.
	(WebCore::IconDatabase::importIconDataForIconURL): Added.
	(WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

	* Misc/WebIconDatabase.mm:
	(defaultClient): Return 0 if ICONDATABASE is disabled.
	* WebCoreSupport/WebFrameLoaderClient.mm:
	(WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out
	the body of the method if ICONDATABASE is disabled.
	(WebFrameLoaderClient::registerForIconNotification): Ditto.
	* WebCoreSupport/WebIconDatabaseClient.mm: Added #if
	ENABLE(ICONDATABASE)/#endif guard to source.
	* WebView/WebView.mm:
	(-[WebView setFrameLoadDelegate:]): Wrapped code that starts the
	icon database machinery in #if ENABLE(ICONDATABASE)/#endif.
	(-[WebView _registerForIconNotification:]): Wrapped method in
	#if ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
	* WebView/WebViewInternal.h: Wrapped methods in #if
	ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _registerForIconNotification:]):
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]):---
 11 files changed, 97 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul  7 15:28:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:28:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26088] large negative
 letter-spacing crashes the chromium port : [Attachment 32397] add pixel
 tests for LayoutTests/fast/text/text-letter-spacing.html,
 move generic test for text-large-negative-spaccing
In-Reply-To: <bug-26088-0@https.bugs.webkit.org/>
References: <bug-26088-0@https.bugs.webkit.org/>
Message-ID: <20090707222824.4C59C323312C@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 26088: large negative letter-spacing crashes the chromium port
https://bugs.webkit.org/show_bug.cgi?id=26088

Attachment 32397: add pixel tests for
LayoutTests/fast/text/text-letter-spacing.html, move generic test for
text-large-negative-spaccing
https://bugs.webkit.org/attachment.cgi?id=32397&action=review

------- Additional Comments from Dirk Pranke <dpranke at chromium.org>
adding the missing pixel tests, moving the generic crash output (dumpAsText)
alongside the input file

From bugzilla-daemon at webkit.org  Tue Jul  7 15:41:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:41:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27022] Repaint issue after
 layer drops out of composited mode. : [Attachment 32398] Patch, testcase,
 changelogs
In-Reply-To: <bug-27022-0@https.bugs.webkit.org/>
References: <bug-27022-0@https.bugs.webkit.org/>
Message-ID: <20090707224142.701AF323368C@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27022: Repaint issue after layer drops out of composited mode.
https://bugs.webkit.org/show_bug.cgi?id=27022

Attachment 32398: Patch, testcase, changelogs
https://bugs.webkit.org/attachment.cgi?id=32398&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 15:44:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:44:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32395] updated
 ChangeLog
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707224437.80B1F32337A1@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32395: updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32395&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 15:45:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:45:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26816] Selection changed by
 indent : [Attachment 32367] Refactors indentRegion and fixes the bugs 26816
 and 25317 (a minor change on the prototype of indentListItem)
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090707224507.54B4232337DF@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32367: Refactors indentRegion and fixes the bugs 26816 and 25317 (a
minor change on the prototype of indentListItem)
https://bugs.webkit.org/attachment.cgi?id=32367&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 15:54:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:54:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27027] Add missing include +
 fix typo in RenderThemeChromiumMac.mm : [Attachment 32377] 2-line patch to
 fix the chromium compile.
In-Reply-To: <bug-27027-0@https.bugs.webkit.org/>
References: <bug-27027-0@https.bugs.webkit.org/>
Message-ID: <20090707225451.7377C3233BB4@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27027: Add missing include + fix typo in RenderThemeChromiumMac.mm
https://bugs.webkit.org/show_bug.cgi?id=27027

Attachment 32377: 2-line patch to fix the chromium compile.
https://bugs.webkit.org/attachment.cgi?id=32377&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It would appear this was already landed.

From bugzilla-daemon at webkit.org  Tue Jul  7 15:57:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 15:57:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32396] Bug 27007: Build fixes when
 ICONDATABASE is disabled
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090707225749.934D03233CFB@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32396:	  Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/attachment.cgi?id=32396&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems like the wrong patch.

re: this patch.  I like the ability to detect bug URLs in ChangeLogs, but I
don't think we should remove the ability to specify a bug?  Maybe we should...
I guess that forces folks to add the bug url to the ChangeLog?

Also the changelog greping code shoudl be in its own function.

From bugzilla-daemon at webkit.org  Tue Jul  7 16:00:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 16:00:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27013]
 WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition
 for Windows : [Attachment 32399] patch
In-Reply-To: <bug-27013-0@https.bugs.webkit.org/>
References: <bug-27013-0@https.bugs.webkit.org/>
Message-ID: <20090707230003.1C94F3233DC0@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 27013: WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle
definition for Windows
https://bugs.webkit.org/show_bug.cgi?id=27013

Attachment 32399: patch
https://bugs.webkit.org/attachment.cgi?id=32399&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 16:01:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 16:01:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32400]
 added more comments to each function
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090707230119.45AC23233E5C@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32400: added more comments to each function
https://bugs.webkit.org/attachment.cgi?id=32400&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 16:06:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 16:06:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27022] Repaint issue after
 layer drops out of composited mode. : [Attachment 32398] Patch, testcase,
 changelogs
In-Reply-To: <bug-27022-0@https.bugs.webkit.org/>
References: <bug-27022-0@https.bugs.webkit.org/>
Message-ID: <20090707230613.3BBE73234051@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 27022: Repaint issue after layer drops out of composited mode.
https://bugs.webkit.org/show_bug.cgi?id=27022

Attachment 32398: Patch, testcase, changelogs
https://bugs.webkit.org/attachment.cgi?id=32398&action=review

------- Additional Comments from mitz at webkit.org
r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 16:28:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 16:28:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27013]
 WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition
 for Windows : [Attachment 32399] patch
In-Reply-To: <bug-27013-0@https.bugs.webkit.org/>
References: <bug-27013-0@https.bugs.webkit.org/>
Message-ID: <20090707232813.084F3323490E@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27013: WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle
definition for Windows
https://bugs.webkit.org/show_bug.cgi?id=27013

Attachment 32399: patch
https://bugs.webkit.org/attachment.cgi?id=32399&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
I'm concerned this may cause problems for the PLATFORM(QT) build.
I believe that in the PLATFORM(QT) builds on Windows, PLATFORM(WIN_OS)
will also be defined.

You may be able to avoid that problem by revising the #ifdefs to check
for PLATFORM(QT) before checking for PLATFORM(WIN_OS).

Also, the very last PLATFORM(WIN) in FileSystem.h might be best kept
as PLATFORM(WIN).  It looks like it is a declaration of additional
functions that perhaps only make sense in the PLATFORM(WIN) port
(i.e., Safari on Windows).

From bugzilla-daemon at webkit.org  Tue Jul  7 16:35:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 16:35:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26088] large negative
 letter-spacing crashes the chromium port : [Attachment 32397] add pixel
 tests for LayoutTests/fast/text/text-letter-spacing.html,
 move generic test for text-large-negative-spaccing
In-Reply-To: <bug-26088-0@https.bugs.webkit.org/>
References: <bug-26088-0@https.bugs.webkit.org/>
Message-ID: <20090707233554.79D773234C7B@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 26088: large negative letter-spacing crashes the chromium port
https://bugs.webkit.org/show_bug.cgi?id=26088

Attachment 32397: add pixel tests for
LayoutTests/fast/text/text-letter-spacing.html, move generic test for
text-large-negative-spaccing
https://bugs.webkit.org/attachment.cgi?id=32397&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 16:37:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 16:37:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27013]
 WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition
 for Windows : [Attachment 32401] patch
In-Reply-To: <bug-27013-0@https.bugs.webkit.org/>
References: <bug-27013-0@https.bugs.webkit.org/>
Message-ID: <20090707233730.459743234D3E@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 27013: WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle
definition for Windows
https://bugs.webkit.org/show_bug.cgi?id=27013

Attachment 32401: patch
https://bugs.webkit.org/attachment.cgi?id=32401&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
done.

From bugzilla-daemon at webkit.org  Tue Jul  7 17:01:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:01:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32402] undo
 the change to CompositeEditCommand.cpp
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090708000116.AFC993235634@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32402: undo the change to CompositeEditCommand.cpp
https://bugs.webkit.org/attachment.cgi?id=32402&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 17:01:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:01:16 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32400] added more
 comments to each function
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090708000116.96E1B3235630@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32400: added more comments to each function
https://bugs.webkit.org/attachment.cgi?id=32400&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 17:07:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:07:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27013]
 WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle definition
 for Windows : [Attachment 32401] patch
In-Reply-To: <bug-27013-0@https.bugs.webkit.org/>
References: <bug-27013-0@https.bugs.webkit.org/>
Message-ID: <20090708000738.5A64A32358C9@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27013: WebCore/platform/FileSystem.h doesn't have a PlatformFileHandle
definition for Windows
https://bugs.webkit.org/show_bug.cgi?id=27013

Attachment 32401: patch
https://bugs.webkit.org/attachment.cgi?id=32401&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
This looks like it will work.  R=me

From bugzilla-daemon at webkit.org  Tue Jul  7 17:16:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:16:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32403] proposed patch with a fix to AbstractWorker::toJS()
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090708001654.BDF083235C8A@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32403: proposed patch with a fix to AbstractWorker::toJS()
https://bugs.webkit.org/attachment.cgi?id=32403&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
While working on a patch based on this patch, I found a bug in how
AbstractWorker::toJS() worked, so I added a custom toJS() function in
AbstractWorker.

Also fixed JSSharedWorkerConstructor.cpp to use the proper global object when
constructing the prototype chain.

From bugzilla-daemon at webkit.org  Tue Jul  7 17:17:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:17:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32404] Bug 27007: Build fixes when
 ICONDATABASE is disabled
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090708001702.606103235CB2@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32404:	  Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/attachment.cgi?id=32404&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	<https://bugs.webkit.org/show_bug.cgi?id=27007>

	Reviewed by NOBODY (OOPS!).

WebCore:

	* WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp
	to the project.
	* loader/icon/IconDatabase.cpp: Added
	#if ENABLE(ICONDATABASE)/#endif macro guard.
	* loader/icon/IconDatabase.h: Removed three public methods from
	#if ENABLE(ICONDATABASE)/#endif macro so that they may be
	stubbed out in IconDatabaseNone.cpp.
	* loader/icon/IconDatabaseNone.cpp: Added
	#if !ENABLE(ICONDATABASE)/#endif macro guard.
	(WebCore::IconDatabase::importIconURLForPageURL): Added.
	(WebCore::IconDatabase::importIconDataForIconURL): Added.
	(WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

	* Misc/WebIconDatabase.mm:
	(defaultClient): Return 0 if ICONDATABASE is disabled.
	* WebCoreSupport/WebFrameLoaderClient.mm:
	(WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out
	the body of the method if ICONDATABASE is disabled.
	(WebFrameLoaderClient::registerForIconNotification): Ditto.
	* WebCoreSupport/WebIconDatabaseClient.mm: Added #if
	ENABLE(ICONDATABASE)/#endif guard to source.
	* WebView/WebView.mm:
	(-[WebView setFrameLoadDelegate:]): Wrapped code that starts the
	icon database machinery in #if ENABLE(ICONDATABASE)/#endif.
	(-[WebView _registerForIconNotification:]): Wrapped method in
	#if ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
	* WebView/WebViewInternal.h: Wrapped methods in #if
	ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _registerForIconNotification:]):
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]):
---
 11 files changed, 97 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul  7 17:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:17:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32404] Bug 27007: Build fixes when
 ICONDATABASE is disabled
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090708001759.46FBA3235D33@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32404:	  Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/attachment.cgi?id=32404&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
bugzilla-tool FAIL again, probably one of my local modifications.

From bugzilla-daemon at webkit.org  Tue Jul  7 17:24:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 17:24:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32405] Bug 27007: Build fixes when
 ICONDATABASE is disabled
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090708002419.51EB8323601E@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32405:	  Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/attachment.cgi?id=32405&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	<https://bugs.webkit.org/show_bug.cgi?id=27007>

	Reviewed by NOBODY (OOPS!).

WebCore:

	* WebCore.xcodeproj/project.pbxproj: Added IconDatabaseNone.cpp
	to the project.
	* loader/icon/IconDatabase.cpp: Added
	#if ENABLE(ICONDATABASE)/#endif macro guard.
	* loader/icon/IconDatabase.h: Removed three public methods from
	#if ENABLE(ICONDATABASE)/#endif macro so that they may be
	stubbed out in IconDatabaseNone.cpp.
	* loader/icon/IconDatabaseNone.cpp: Added
	#if !ENABLE(ICONDATABASE)/#endif macro guard.
	(WebCore::IconDatabase::importIconURLForPageURL): Added.
	(WebCore::IconDatabase::importIconDataForIconURL): Added.
	(WebCore::IconDatabase::shouldStopThreadActivity): Added.

WebKit/mac:

	* Misc/WebIconDatabase.mm:
	(defaultClient): Return 0 if ICONDATABASE is disabled.
	* WebCoreSupport/WebFrameLoaderClient.mm:
	(WebFrameLoaderClient::dispatchDidReceiveIcon): Commented out
	the body of the method if ICONDATABASE is disabled.
	(WebFrameLoaderClient::registerForIconNotification): Ditto.
	* WebCoreSupport/WebIconDatabaseClient.mm: Added #if
	ENABLE(ICONDATABASE)/#endif guard to source.
	* WebView/WebView.mm:
	(-[WebView setFrameLoadDelegate:]): Wrapped code that starts the
	icon database machinery in #if ENABLE(ICONDATABASE)/#endif.
	(-[WebView _registerForIconNotification:]): Wrapped method in
	#if ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]): Ditto.
	* WebView/WebViewInternal.h: Wrapped methods in #if
	ENABLE(ICONDATABASE)/#endif guard.
	(-[WebView _registerForIconNotification:]):
	(-[WebView _dispatchDidReceiveIconFromWebFrame:]):
---
 11 files changed, 97 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul  7 18:02:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:02:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27047] Sometimes the media
 controller remaining time disappear. : [Attachment 32407] patch v1.
In-Reply-To: <bug-27047-0@https.bugs.webkit.org/>
References: <bug-27047-0@https.bugs.webkit.org/>
Message-ID: <20090708010234.7F2483236DCE@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27047: Sometimes the media controller remaining time disappear.
https://bugs.webkit.org/show_bug.cgi?id=27047

Attachment 32407: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32407&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 18:03:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:03:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17052] Scrolling with arrow
 keys does not update cursor : [Attachment 32408] Add CHROMIUM to the target
 platform.
In-Reply-To: <bug-17052-0@https.bugs.webkit.org/>
References: <bug-17052-0@https.bugs.webkit.org/>
Message-ID: <20090708010337.CB2163236E46@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 17052: Scrolling with arrow keys does not update cursor
https://bugs.webkit.org/show_bug.cgi?id=17052

Attachment 32408: Add CHROMIUM to the target platform.
https://bugs.webkit.org/attachment.cgi?id=32408&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Mark,

Thank you for your comment.
I've added PLATFORM(CHROMIUM) to the #if.

Yuzo

From bugzilla-daemon at webkit.org  Tue Jul  7 18:13:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:13:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27047] Sometimes the media
 controller remaining time disappear. : [Attachment 32407] patch v1.
In-Reply-To: <bug-27047-0@https.bugs.webkit.org/>
References: <bug-27047-0@https.bugs.webkit.org/>
Message-ID: <20090708011335.1B0F43237234@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27047: Sometimes the media controller remaining time disappear.
https://bugs.webkit.org/show_bug.cgi?id=27047

Attachment 32407: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32407&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +2009-07-07  Pierre d'Herbemont  <pdherbemont at apple.com>
> +
> +	   (WebCore::MediaControlElement::styleForElement): Shortcut.

Utility method, or "code factoring" would be a better description.

> diff --git a/WebCore/rendering/MediaControlElements.cpp
b/WebCore/rendering/MediaControlElements.cpp

> +	   return NULL;

WebCore code uses 0 instead of NULL.

From bugzilla-daemon at webkit.org  Tue Jul  7 18:26:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:26:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24540] Fix for missing mmap
 features in Symbian : [Attachment 32409] Update 2 of patch file for bug
 24540
In-Reply-To: <bug-24540-0@https.bugs.webkit.org/>
References: <bug-24540-0@https.bugs.webkit.org/>
Message-ID: <20090708012624.0AE783237759@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 24540: Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540

Attachment 32409: Update 2 of patch file for bug 24540
https://bugs.webkit.org/attachment.cgi?id=32409&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Attached patch contains cleaned-up code for collector.cpp, according to
suggestions from Mark Rowe in comment #4.
For simplicity, I separated the change requests for RegisterFile and
ExecutableAllocator from this bug and will submit those independently.

From bugzilla-daemon at webkit.org  Tue Jul  7 18:39:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:39:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27051] Use fastMalloc when
 neither MMAP nor VIRTUALALLOC are enabled : [Attachment 32410] Code patch
 for Registerfile ccp and h
In-Reply-To: <bug-27051-0@https.bugs.webkit.org/>
References: <bug-27051-0@https.bugs.webkit.org/>
Message-ID: <20090708013903.3AE063237BEE@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27051: Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled
https://bugs.webkit.org/show_bug.cgi?id=27051

Attachment 32410: Code patch for Registerfile ccp and h
https://bugs.webkit.org/attachment.cgi?id=32410&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
RegisterFile constructor currently throws #error when both MMAP and
VIRTUALALLOC conditions fail.
On any platform that does not provide these features (for instance, Symbian),
the fallback should be regular malloc (or fastMalloc).
Memory allocation with fastMalloc functionally equivalent in this case, even
though it may have certain drawbacks such as lack of dynamic pre-allocation.

This should be the general, preferred way of fixing the issue, as opposed to
introducing conditional code block for platform Symbian.

From bugzilla-daemon at webkit.org  Tue Jul  7 18:39:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:39:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27049] In
 dumpBackForwardList() mode,
 DRT should normalize file urls to be the same no matter the config of the
 machine you're on. : [Attachment 32411] Mac and Windows DRT fix,
 and updated test results for the test I added that fails until this is
 fixed!
In-Reply-To: <bug-27049-0@https.bugs.webkit.org/>
References: <bug-27049-0@https.bugs.webkit.org/>
Message-ID: <20090708013909.BB7583237C04@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27049: In dumpBackForwardList() mode, DRT should normalize file urls to be
the same no matter the config of the machine you're on.
https://bugs.webkit.org/show_bug.cgi?id=27049

Attachment 32411: Mac and Windows DRT fix, and updated test results for the
test I added that fails until this is fixed!
https://bugs.webkit.org/attachment.cgi?id=32411&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 18:40:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:40:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27049] In
 dumpBackForwardList() mode,
 DRT should normalize file urls to be the same no matter the config of the
 machine you're on. : [Attachment 32411] Mac and Windows DRT fix,
 and updated test results for the test I added that fails until this is
 fixed!
In-Reply-To: <bug-27049-0@https.bugs.webkit.org/>
References: <bug-27049-0@https.bugs.webkit.org/>
Message-ID: <20090708014059.915903237CC0@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 27049: In dumpBackForwardList() mode, DRT should normalize file urls to be
the same no matter the config of the machine you're on.
https://bugs.webkit.org/show_bug.cgi?id=27049

Attachment 32411: Mac and Windows DRT fix, and updated test results for the
test I added that fails until this is fixed!
https://bugs.webkit.org/attachment.cgi?id=32411&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 18:47:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:47:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27052] Undef ASSERT,
 to avoid excessive warnings : [Attachment 32412] Code patch for
 Assertion.h
In-Reply-To: <bug-27052-0@https.bugs.webkit.org/>
References: <bug-27052-0@https.bugs.webkit.org/>
Message-ID: <20090708014722.E31E83237F0D@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27052: Undef ASSERT, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052

Attachment 32412: Code patch for Assertion.h
https://bugs.webkit.org/attachment.cgi?id=32412&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
2nd attempt to add attachment - failed first time

From bugzilla-daemon at webkit.org  Tue Jul  7 18:52:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:52:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27053] Ambiguity in
 LabelScope initialization : [Attachment 32413] Code patch for
 BytecodeGenerator.cpp
In-Reply-To: <bug-27053-0@https.bugs.webkit.org/>
References: <bug-27053-0@https.bugs.webkit.org/>
Message-ID: <20090708015226.2A5BA3238113@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27053: Ambiguity in LabelScope initialization
https://bugs.webkit.org/show_bug.cgi?id=27053

Attachment 32413: Code patch for BytecodeGenerator.cpp
https://bugs.webkit.org/attachment.cgi?id=32413&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Codewarrior compiler (WINSCW) latest b482 on Symbian cannot resolve type of "0"
unambiguously. Set expression explicitly to PassRefPtr<Label>::PassRefPtr().

Rather than implementing conditional block for COMPILER(WINSCW) it appears to
be save and appropriate to modify the main-line code accordingly.

From bugzilla-daemon at webkit.org  Tue Jul  7 18:57:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 18:57:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27054] Renamed Translator
 to HashTranslator : [Attachment 32414] Code patch for HashSet.h
In-Reply-To: <bug-27054-0@https.bugs.webkit.org/>
References: <bug-27054-0@https.bugs.webkit.org/>
Message-ID: <20090708015752.C308D323838D@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27054: Renamed Translator to HashTranslator
https://bugs.webkit.org/show_bug.cgi?id=27054

Attachment 32414: Code patch for HashSet.h
https://bugs.webkit.org/attachment.cgi?id=32414&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Codewarrior compiler (WINSCW) with latest build b482 cannot resolve typename
mismatch between template declaration and definition (HashTranslator /
Translator).

Patch is submitted as a general code cleanup, without compiler conditional
clause.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:03:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:03:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27055] Qualify include path
 with wtf : [Attachment 32415] Code patch for Interpreter.h
In-Reply-To: <bug-27055-0@https.bugs.webkit.org/>
References: <bug-27055-0@https.bugs.webkit.org/>
Message-ID: <20090708020321.0E02C32385EE@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27055: Qualify include path with wtf
https://bugs.webkit.org/show_bug.cgi?id=27055

Attachment 32415: Code patch for Interpreter.h
https://bugs.webkit.org/attachment.cgi?id=32415&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
On Symbian platforms we encounter include ambiguities of HashMap.h file, which
is already present in default location.

Since that header filename is very generic, it appears to be appropriate and
saver to add a pathname qualifier "wtf/HashMap.h" to the include statement.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:09:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:09:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27053] Ambiguity in
 LabelScope initialization : [Attachment 32413] Code patch for
 BytecodeGenerator.cpp
In-Reply-To: <bug-27053-0@https.bugs.webkit.org/>
References: <bug-27053-0@https.bugs.webkit.org/>
Message-ID: <20090708020916.70CD93238885@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27053: Ambiguity in LabelScope initialization
https://bugs.webkit.org/show_bug.cgi?id=27053

Attachment 32413: Code patch for BytecodeGenerator.cpp
https://bugs.webkit.org/attachment.cgi?id=32413&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

I think you can just write "PassRefPtr<Label>()" instead of
"PassRefPtr<Label>::PassRefPtr()".

From bugzilla-daemon at webkit.org  Tue Jul  7 19:10:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:10:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27056] Alternate bool
 operator for codewarrior compiler (WINSCW) : [Attachment 32416] Code patch
 for OwnArrayPtr.h
In-Reply-To: <bug-27056-0@https.bugs.webkit.org/>
References: <bug-27056-0@https.bugs.webkit.org/>
Message-ID: <20090708021016.7DF2432388EB@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27056: Alternate bool operator for codewarrior compiler (WINSCW)
https://bugs.webkit.org/show_bug.cgi?id=27056

Attachment 32416: Code patch for OwnArrayPtr.h
https://bugs.webkit.org/attachment.cgi?id=32416&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Compiler (latest build b482) reports error for UnspecifiedBoolType construct:
"illegal explicit conversion from 'WTF::OwnArrayPtr<JSC::Register>' to 'bool'"

Similar conditional (COMPILER(WINSCW)) code fixes have already been applied to
PassRefPtr.h and RefPtr.h

From bugzilla-daemon at webkit.org  Tue Jul  7 19:14:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:14:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27058] Removed superfluous
 parenthesis around single expression : [Attachment 32417] Code patch for
 Platform.h
In-Reply-To: <bug-27058-0@https.bugs.webkit.org/>
References: <bug-27058-0@https.bugs.webkit.org/>
Message-ID: <20090708021428.85B7F3238AB6@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27058: Removed superfluous parenthesis around single expression
https://bugs.webkit.org/show_bug.cgi?id=27058

Attachment 32417: Code patch for Platform.h
https://bugs.webkit.org/attachment.cgi?id=32417&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Compilers on Symbian platform fail to parse and compile a statement such as:
defined( ENABLE_##WTF_FEATURE ) && ENABLE_##WTF_FEATURE

The proposed patch removes the unnecessary parenthesis, which is save on any
platform.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:18:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:18:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27059] Exclude Symbian
 platform from define of MIDDLE_ENDIAN : [Attachment 32418] Code patch for
 Platform.h
In-Reply-To: <bug-27059-0@https.bugs.webkit.org/>
References: <bug-27059-0@https.bugs.webkit.org/>
Message-ID: <20090708021812.25A573238C31@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27059: Exclude Symbian platform from define of MIDDLE_ENDIAN
https://bugs.webkit.org/show_bug.cgi?id=27059

Attachment 32418: Code patch for Platform.h
https://bugs.webkit.org/attachment.cgi?id=32418&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
The proposed patch adds !PLATFORM(SYMBIAN) tpo prevent it from entering the
conditional code block that defines WTF_PLATFORM_MIDDLE_ENDIAN=1.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:22:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:22:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27060] Type cast for first
 argument in make_pair() : [Attachment 32420] Code patch for Structure.cpp
In-Reply-To: <bug-27060-0@https.bugs.webkit.org/>
References: <bug-27060-0@https.bugs.webkit.org/>
Message-ID: <20090708022241.27C133238E2F@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27060: Type cast for first argument in make_pair()
https://bugs.webkit.org/show_bug.cgi?id=27060

Attachment 32420: Code patch for Structure.cpp
https://bugs.webkit.org/attachment.cgi?id=32420&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Codewarrior compiler (WINSCW) latest build b482 fails with "illegal operand"
when first arg of make_pair() method has unqualified type.

Proposed patch casts the arguments accordingly.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:24:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:24:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27061] Define explicit
 include path for UnicodeQt4.h : [Attachment 32421] Code patch for Unicode.h
In-Reply-To: <bug-27061-0@https.bugs.webkit.org/>
References: <bug-27061-0@https.bugs.webkit.org/>
Message-ID: <20090708022459.0FDB73238EEE@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27061: Define explicit include path for UnicodeQt4.h
https://bugs.webkit.org/show_bug.cgi?id=27061

Attachment 32421: Code patch for Unicode.h
https://bugs.webkit.org/attachment.cgi?id=32421&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Define explicit include path wtf/unicode/qt4/UnicodeQt4.h,
conditionally for codewarrior compiler (WINSCW) latest build b482.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:25:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:25:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27062] bugzilla-tool:
 post-commits should read bug id from commit log and actually work :
 [Attachment 32422] bugzilla-tool: post-commits should read bug id from
 commit log and actually work
In-Reply-To: <bug-27062-0@https.bugs.webkit.org/>
References: <bug-27062-0@https.bugs.webkit.org/>
Message-ID: <20090708022536.07E083238F40@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062

Attachment 32422:	  bugzilla-tool: post-commits should read bug id from
commit log and actually work
https://bugs.webkit.org/attachment.cgi?id=32422&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	Reviewed by NOBODY (OOPS!).

	* Scripts/bugzilla-tool:
	(bug_id_from_commit_message): Added.  Returns a bug id from the
	commit log message, thus enforcing the need for a bug URL in the
	message.
	(PostCommitsAsPatchesToBug.__init__): Updated help description
	to match new behavior of pulling bug ids from commit log
	messages instead of from the command line.
	(PostCommitsAsPatchesToBug.execute): Updated to use
	bug_id_from_commit_message() to pull bug ids from commit log
	messages.  Also switched from SCM.create_patch() to use
	SCM.create_patch_from_local_commit() to fix a bug where local
	repository changes were posted as a patch instead of the
	specific COMMITISH.

	* Scripts/modules/bugzilla.py: Import datetime module.
	(timestamp): Added.  Returns a timestamp in the form of
	"YYYYMMDDhhmmss".
	(Bugzilla.add_patch_to_bug): Construct a more meaningful patch
	file name using the bug_id and timestamp().

	* Scripts/modules/scm.py:
	(SCM.create_patch_from_local_commit): Added.
	(Git.create_patch_from_local_commit): Added.  Runs "git diff" to
	return a patch for the given commit_id.
---
 4 files changed, 70 insertions(+), 17 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul  7 19:25:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:25:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27057] Missing call to
 FocusController::setFocused(true) when handling WM_SETFOCUS in WebView :
 [Attachment 32419] Call FocusController::setFocused(true) in the case when
 we have no focused frame.
In-Reply-To: <bug-27057-0@https.bugs.webkit.org/>
References: <bug-27057-0@https.bugs.webkit.org/>
Message-ID: <20090708022536.37AB03238F44@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted  review:
Bug 27057: Missing call to FocusController::setFocused(true) when handling
WM_SETFOCUS in WebView
https://bugs.webkit.org/show_bug.cgi?id=27057

Attachment 32419: Call FocusController::setFocused(true) in the case when we
have no focused frame.
https://bugs.webkit.org/attachment.cgi?id=32419&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me

From bugzilla-daemon at webkit.org  Tue Jul  7 19:27:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:27:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27063] Exclude
 DumpRenderTree.pro from symbian build : [Attachment 32423] Code patch for
 WebKit.pro
In-Reply-To: <bug-27063-0@https.bugs.webkit.org/>
References: <bug-27063-0@https.bugs.webkit.org/>
Message-ID: <20090708022751.7E2B5323902D@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27063: Exclude DumpRenderTree.pro from symbian build
https://bugs.webkit.org/show_bug.cgi?id=27063

Attachment 32423: Code patch for WebKit.pro
https://bugs.webkit.org/attachment.cgi?id=32423&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Exclude DumpRenderTree.pro, conditionally, for symbian build.

That code cannot be built for target platform.

From bugzilla-daemon at webkit.org  Tue Jul  7 19:39:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 19:39:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27053] Ambiguity in
 LabelScope initialization : [Attachment 32424] Updated patch for bug# 27053
In-Reply-To: <bug-27053-0@https.bugs.webkit.org/>
References: <bug-27053-0@https.bugs.webkit.org/>
Message-ID: <20090708023924.104E532394C3@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27053: Ambiguity in LabelScope initialization
https://bugs.webkit.org/show_bug.cgi?id=27053

Attachment 32424: Updated patch for bug# 27053
https://bugs.webkit.org/attachment.cgi?id=32424&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
I just verified Geoffrey's suggestion about simplifying the statement, and he's
right.

The updated patch contains the respective modification.

From bugzilla-daemon at webkit.org  Tue Jul  7 20:31:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 20:31:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27064] Turn off
 non-portable date manipulations for SYMBIAN (as well) : [Attachment 32425]
 Proposed fix.
In-Reply-To: <bug-27064-0@https.bugs.webkit.org/>
References: <bug-27064-0@https.bugs.webkit.org/>
Message-ID: <20090708033125.86380323A7AB@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27064: Turn off non-portable date manipulations for SYMBIAN (as well)
https://bugs.webkit.org/show_bug.cgi?id=27064

Attachment 32425: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32425&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 20:34:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 20:34:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 19562] ValidityState object
 stub : [Attachment 31508] ValidityState stuff, basic support
In-Reply-To: <bug-19562-0@https.bugs.webkit.org/>
References: <bug-19562-0@https.bugs.webkit.org/>
Message-ID: <20090708033431.305BB323A8F8@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 19562: ValidityState object stub
https://bugs.webkit.org/show_bug.cgi?id=19562

Attachment 31508: ValidityState stuff, basic support
https://bugs.webkit.org/attachment.cgi?id=31508&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
looks good!

From bugzilla-daemon at webkit.org  Tue Jul  7 22:09:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 22:09:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27068] Reduce complexity of
 lifetime management in DynamicNodeList caches : [Attachment 32426] tidying
In-Reply-To: <bug-27068-0@https.bugs.webkit.org/>
References: <bug-27068-0@https.bugs.webkit.org/>
Message-ID: <20090708050911.BF0A4323CE16@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27068: Reduce complexity of lifetime management in DynamicNodeList caches
https://bugs.webkit.org/show_bug.cgi?id=27068

Attachment 32426: tidying
https://bugs.webkit.org/attachment.cgi?id=32426&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 22:13:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 22:13:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27068] Reduce complexity of
 lifetime management in DynamicNodeList caches : [Attachment 32426] tidying
In-Reply-To: <bug-27068-0@https.bugs.webkit.org/>
References: <bug-27068-0@https.bugs.webkit.org/>
Message-ID: <20090708051317.3A7DF323CF9E@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27068: Reduce complexity of lifetime management in DynamicNodeList caches
https://bugs.webkit.org/show_bug.cgi?id=27068

Attachment 32426: tidying
https://bugs.webkit.org/attachment.cgi?id=32426&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 22:14:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 22:14:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27066] -webkit-perspective
 should be a Length : [Attachment 32427] Patch, testcase, changelog
In-Reply-To: <bug-27066-0@https.bugs.webkit.org/>
References: <bug-27066-0@https.bugs.webkit.org/>
Message-ID: <20090708051439.A609B323D02A@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27066: -webkit-perspective should be a Length
https://bugs.webkit.org/show_bug.cgi?id=27066

Attachment 32427: Patch, testcase, changelog
https://bugs.webkit.org/attachment.cgi?id=32427&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 22:19:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 22:19:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27066] -webkit-perspective
 should be a Length : [Attachment 32427] Patch, testcase, changelog
In-Reply-To: <bug-27066-0@https.bugs.webkit.org/>
References: <bug-27066-0@https.bugs.webkit.org/>
Message-ID: <20090708051933.40F92323D1C7@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 27066: -webkit-perspective should be a Length
https://bugs.webkit.org/show_bug.cgi?id=27066

Attachment 32427: Patch, testcase, changelog
https://bugs.webkit.org/attachment.cgi?id=32427&action=review

------- Additional Comments from mitz at webkit.org
+	 as pixels for backwards compatibility.

+	     // For backward compatibility, treat valueless numbers as px.

backwards?

Presumably this quirk should only apply to the vendor-prefixed version of the
property. Perhaps a comment in the parser will help to ensure that it is
cleaned up when the prefix is dropped.

From bugzilla-daemon at webkit.org  Tue Jul  7 22:32:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 22:32:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27062] bugzilla-tool:
 post-commits should read bug id from commit log and actually work :
 [Attachment 32422] bugzilla-tool: post-commits should read bug id from
 commit log and actually work
In-Reply-To: <bug-27062-0@https.bugs.webkit.org/>
References: <bug-27062-0@https.bugs.webkit.org/>
Message-ID: <20090708053210.741C2323D6B7@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062

Attachment 32422:	  bugzilla-tool: post-commits should read bug id from
commit log and actually work
https://bugs.webkit.org/attachment.cgi?id=32422&action=review

From bugzilla-daemon at webkit.org  Tue Jul  7 22:32:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue,  7 Jul 2009 22:32:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27062] bugzilla-tool:
 post-commits should read bug id from commit log and actually work :
 [Attachment 32428] Bug 27062: bugzilla-tool: post-commits should read bug
 id from commit log and actually work
In-Reply-To: <bug-27062-0@https.bugs.webkit.org/>
References: <bug-27062-0@https.bugs.webkit.org/>
Message-ID: <20090708053212.D26A6323D6CC@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062

Attachment 32428:	  Bug 27062: bugzilla-tool: post-commits should read
bug id from commit log and actually work
https://bugs.webkit.org/attachment.cgi?id=32428&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 00:27:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 00:27:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27071] [XSSAuditor] HTTP
 parameters with null/control characters bypass XSSAuditor : [Attachment
 32433] Patch with tests
In-Reply-To: <bug-27071-0@https.bugs.webkit.org/>
References: <bug-27071-0@https.bugs.webkit.org/>
Message-ID: <20090708072736.1738F3240062@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27071: [XSSAuditor] HTTP parameters with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27071

Attachment 32433: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32433&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 00:29:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 00:29:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25205] XMLHttpRequest
 instance is not an instanceof XMLHttpRequest : [Attachment 32370] Fix for
 "instanceof XMLHttpRequest"
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090708072908.1E05E32400DF@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has canceled Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32370: Fix for "instanceof XMLHttpRequest"
https://bugs.webkit.org/attachment.cgi?id=32370&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Can anyone review this, please?

I've updated the patch to fix for XSLTProcessor, Audio, etc.

Yuzo

From bugzilla-daemon at webkit.org  Wed Jul  8 00:29:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 00:29:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25205] XMLHttpRequest
 instance is not an instanceof XMLHttpRequest : [Attachment 32434] This also
 fixes for XSTLProcessor, Audio, etc.
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090708072908.3532732400E3@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32434: This also fixes for XSTLProcessor, Audio, etc.
https://bugs.webkit.org/attachment.cgi?id=32434&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Can anyone review this, please?

I've updated the patch to fix for XSLTProcessor, Audio, etc.

Yuzo

From bugzilla-daemon at webkit.org  Wed Jul  8 00:52:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 00:52:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27072] Split
 StorageNamespace and StorageArea into an interface and implementation :
 [Attachment 32435] v1
In-Reply-To: <bug-27072-0@https.bugs.webkit.org/>
References: <bug-27072-0@https.bugs.webkit.org/>
Message-ID: <20090708075224.9BB5B32408DB@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32435: v1
https://bugs.webkit.org/attachment.cgi?id=32435&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
I need to split StorageNamespace and StorageArea into an interface and
implementation.  In a later patch, I'll implement a proxy interface that'll run
inside the Chromium renderer process.

This is a continuation of other refactoring work:
https://bugs.webkit.org/show_bug.cgi?id=25376

From bugzilla-daemon at webkit.org  Wed Jul  8 00:55:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 00:55:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26816] Selection changed by
 indent : [Attachment 32436] fixes the bug
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090708075539.458953240A02@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32436: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32436&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at google.com>
This patch may be committed only after the patch for
https://bugs.webkit.org/show_bug.cgi?id=27038 is committed.

From bugzilla-daemon at webkit.org  Wed Jul  8 02:36:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 02:36:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32439] Add cpplint
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090708093640.262543242D67@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32439: Add cpplint
https://bugs.webkit.org/attachment.cgi?id=32439&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
---
 3 files changed, 6109 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul  8 03:58:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 03:58:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32444] Fix for lint errors v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090708105832.C8ABE3244CB6@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32444: Fix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32444&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Ah, thanks for the comment! Yeah, of course, it is better to check this patch
in. I didn't flag '?' as I didn't confirm it could be compiled with Mac. Now I
confirmed it can be compiled and I fixed the style of cast. Could you land this
patch? I think it's good if you can check this in soon. Otherwise, you may see
a lot of conflicts as this patch changes many code.

By the way, the warning for C-style casts is another example of warnings I
disabled. It would be nice if we can discuss which rule is necessary for
WebKit. As I'm a newbie of WebKit, I know few undocumented customs.

From bugzilla-daemon at webkit.org  Wed Jul  8 04:23:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 04:23:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27076] [WINCE] Move date
 related symbols to DateExtras.h : [Attachment 32446] DateExtras
In-Reply-To: <bug-27076-0@https.bugs.webkit.org/>
References: <bug-27076-0@https.bugs.webkit.org/>
Message-ID: <20090708112340.71D893245600@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32446: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32446&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
DateExtras

From bugzilla-daemon at webkit.org  Wed Jul  8 04:35:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 04:35:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27076] [WINCE] Move date
 related symbols to DateExtras.h : [Attachment 32448] DateExtras
In-Reply-To: <bug-27076-0@https.bugs.webkit.org/>
References: <bug-27076-0@https.bugs.webkit.org/>
Message-ID: <20090708113526.924B832459FB@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32448: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32448&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
coding convention.

From bugzilla-daemon at webkit.org  Wed Jul  8 04:36:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 04:36:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27076] [WINCE] Move date
 related symbols to DateExtras.h : [Attachment 32446] DateExtras
In-Reply-To: <bug-27076-0@https.bugs.webkit.org/>
References: <bug-27076-0@https.bugs.webkit.org/>
Message-ID: <20090708113627.973183245A51@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has canceled Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32446: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32446&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 06:41:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 06:41:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32444] Fix for lint errors v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090708134131.518EE3248B4A@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32444: Fix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32444&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me!  Yes, I can land this as well.

From bugzilla-daemon at webkit.org  Wed Jul  8 06:58:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 06:58:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32444] Fix for lint errors v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090708135820.ACD7B3249296@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32444: Fix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32444&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Clearing my r+ flag now that this patch has landed.

From bugzilla-daemon at webkit.org  Wed Jul  8 07:21:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 07:21:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 32451]
 lineboundary.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090708142111.9FE273249BF6@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 32451: lineboundary.patch
https://bugs.webkit.org/attachment.cgi?id=32451&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK, this patch seems to at least get the basics right from my testing.
Unfortunately it copies a bit of code from FontGtk.cpp, we need to share it.

From bugzilla-daemon at webkit.org  Wed Jul  8 07:36:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 07:36:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27062] bugzilla-tool:
 post-commits should read bug id from commit log and actually work :
 [Attachment 32428] Bug 27062: bugzilla-tool: post-commits should read bug
 id from commit log and actually work
In-Reply-To: <bug-27062-0@https.bugs.webkit.org/>
References: <bug-27062-0@https.bugs.webkit.org/>
Message-ID: <20090708143655.24C0B324A28C@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062

Attachment 32428:	  Bug 27062: bugzilla-tool: post-commits should read
bug id from commit log and actually work
https://bugs.webkit.org/attachment.cgi?id=32428&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 07:36:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 07:36:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27062] bugzilla-tool:
 post-commits should read bug id from commit log and actually work :
 [Attachment 32452] Bug 27062: bugzilla-tool: post-commits should read bug
 id from commit log and actually work
In-Reply-To: <bug-27062-0@https.bugs.webkit.org/>
References: <bug-27062-0@https.bugs.webkit.org/>
Message-ID: <20090708143658.33C9B324A2A6@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062

Attachment 32452:	  Bug 27062: bugzilla-tool: post-commits should read
bug id from commit log and actually work
https://bugs.webkit.org/attachment.cgi?id=32452&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 07:38:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 07:38:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27080]
 fast/loader/submit-form-while-parsing-2.html fails and passes randomly :
 [Attachment 32453] patch to fix timing issue
In-Reply-To: <bug-27080-0@https.bugs.webkit.org/>
References: <bug-27080-0@https.bugs.webkit.org/>
Message-ID: <20090708143828.1858D324A366@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27080: fast/loader/submit-form-while-parsing-2.html fails and passes
randomly
https://bugs.webkit.org/show_bug.cgi?id=27080

Attachment 32453: patch to fix timing issue
https://bugs.webkit.org/attachment.cgi?id=32453&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 07:40:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 07:40:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27080]
 fast/loader/submit-form-while-parsing-2.html fails and passes randomly :
 [Attachment 32453] patch to fix timing issue
In-Reply-To: <bug-27080-0@https.bugs.webkit.org/>
References: <bug-27080-0@https.bugs.webkit.org/>
Message-ID: <20090708144033.5F888324A438@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27080: fast/loader/submit-form-while-parsing-2.html fails and passes
randomly
https://bugs.webkit.org/show_bug.cgi?id=27080

Attachment 32453: patch to fix timing issue
https://bugs.webkit.org/attachment.cgi?id=32453&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 09:12:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 09:12:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27081] Wrap
 RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER) : [Attachment
 32455] Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)
In-Reply-To: <bug-27081-0@https.bugs.webkit.org/>
References: <bug-27081-0@https.bugs.webkit.org/>
Message-ID: <20090708161241.EDB6D324CBA6@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27081: Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)
https://bugs.webkit.org/show_bug.cgi?id=27081

Attachment 32455:	  Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) &&
HAVE(RUNLOOP_TIMER)
https://bugs.webkit.org/attachment.cgi?id=32455&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	Reviewed by NOBODY (OOPS!).

	* platform/cf/RunLoopTimerCF.cpp: This code is only used on
	Mac OS X when HAVE(RUNLOOP_TIMER) is enabled, so wrap the code
	in that macro as well.
---
 2 files changed, 12 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul  8 09:34:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 09:34:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27081] Wrap
 RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER) : [Attachment
 32455] Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)
In-Reply-To: <bug-27081-0@https.bugs.webkit.org/>
References: <bug-27081-0@https.bugs.webkit.org/>
Message-ID: <20090708163451.0E5F2324D4D2@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27081: Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) && HAVE(RUNLOOP_TIMER)
https://bugs.webkit.org/show_bug.cgi?id=27081

Attachment 32455:	  Wrap RunLoopTimerCF.cpp in PLATFORM(MAC) &&
HAVE(RUNLOOP_TIMER)
https://bugs.webkit.org/attachment.cgi?id=32455&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 09:54:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 09:54:11 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25205] XMLHttpRequest instance
 is not an instanceof XMLHttpRequest : [Attachment 32434] This also fixes
 for XSTLProcessor, Audio, etc.
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090708165411.06519324DC4B@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32434: This also fixes for XSTLProcessor, Audio, etc.
https://bugs.webkit.org/attachment.cgi?id=32434&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems OK, but not great. The design here is supposed to be that derived
classes override createStructure if the base class version doesn't work right.
Leaving behind a createStructure function that does the wrong thing and relying
on the callers to call the correct one seems unnecessarily fragile to me. To
share code, we could create a new base class, derived from DOMObject, and have
all the constructor classes derive from this, and it would override
createStructure to work properly.

Would you be willing to try that approach?

review- for now, but I'm open to landing this version if you don't like my
suggestion and can convince me.

From bugzilla-daemon at webkit.org  Wed Jul  8 10:09:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:09:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26790] ParserArenaDeletable
 should override delete : [Attachment 32349] Overeride ParserArenaDeletable
 delete
In-Reply-To: <bug-26790-0@https.bugs.webkit.org/>
References: <bug-26790-0@https.bugs.webkit.org/>
Message-ID: <20090708170953.0EB79324E2A1@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked Eric Seidel <eric at webkit.org>
for review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32349: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32349&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 10:18:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:18:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26790] ParserArenaDeletable
 should override delete : [Attachment 32349] Overeride ParserArenaDeletable
 delete
In-Reply-To: <bug-26790-0@https.bugs.webkit.org/>
References: <bug-26790-0@https.bugs.webkit.org/>
Message-ID: <20090708171813.DD377324E659@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32349: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32349&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   return fastFree(p);

There's no need for the return here, and it would be slightly nicer without it.


r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 10:21:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:21:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27072] Split StorageNamespace
 and StorageArea into an interface and implementation : [Attachment 32435]
 v1
In-Reply-To: <bug-27072-0@https.bugs.webkit.org/>
References: <bug-27072-0@https.bugs.webkit.org/>
Message-ID: <20090708172100.B5D8C324E79D@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32435: v1
https://bugs.webkit.org/attachment.cgi?id=32435&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/storage/StorageArea.cpp

> +#if PLATFORM(CHROMIUM)
> +#else
> +    return StorageAreaImpl::create(storageType, origin, syncManager);
>  #endif

I think this should be #if !PLATFORM(CHROMIUM) to avoid the #else, or
perhaps you should add a similar FIXME comment there as you do below:


> Index: WebCore/storage/StorageNamespace.cpp

> +#if PLATFORM(CHROMIUM)
> +    // FIXME: Implement.
> +#else
> +    return StorageNamespaceImpl::localStorageNamespace(path);
> +#endif

Otherwise, looks good to me.  R=me

From bugzilla-daemon at webkit.org  Wed Jul  8 10:26:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:26:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27011] [Gtk] Implement
 support for get_index_in_parent : [Attachment 32456] getindexinparent.patch
In-Reply-To: <bug-27011-0@https.bugs.webkit.org/>
References: <bug-27011-0@https.bugs.webkit.org/>
Message-ID: <20090708172643.B7DD3324E9E5@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 27011: [Gtk] Implement support for get_index_in_parent
https://bugs.webkit.org/show_bug.cgi?id=27011

Attachment 32456: getindexinparent.patch
https://bugs.webkit.org/attachment.cgi?id=32456&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
This implements the function, but the particular testcase you mention does not
work because the object hierarchy is not quite right in Google's case (the Map
object has a dummy 'label' parent).

From bugzilla-daemon at webkit.org  Wed Jul  8 10:28:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:28:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26790] ParserArenaDeletable
 should override delete : [Attachment 32457] Overeride ParserArenaDeletable
 delete
In-Reply-To: <bug-26790-0@https.bugs.webkit.org/>
References: <bug-26790-0@https.bugs.webkit.org/>
Message-ID: <20090708172825.00EA6324EAA6@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked Darin Adler <darin at apple.com>
for review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32457: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32457&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
final.

From bugzilla-daemon at webkit.org  Wed Jul  8 10:29:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:29:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26790] ParserArenaDeletable
 should override delete : [Attachment 32457] Overeride ParserArenaDeletable
 delete
In-Reply-To: <bug-26790-0@https.bugs.webkit.org/>
References: <bug-26790-0@https.bugs.webkit.org/>
Message-ID: <20090708172949.A8473324EB75@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 26790: ParserArenaDeletable should override delete
https://bugs.webkit.org/show_bug.cgi?id=26790

Attachment 32457: Overeride ParserArenaDeletable delete
https://bugs.webkit.org/attachment.cgi?id=32457&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 10:34:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:34:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 32458] bugzilla-tool: Add
 --no-close switch to land-patches
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090708173407.50AFD324ED54@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 32458:	  bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/attachment.cgi?id=32458&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	Reviewed by NOBODY (OOPS!).

	* Scripts/bugzilla-tool:
	(LandPatchesFromBugs.__init__): Added --no-close switch.
	(LandPatchesFromBugs.land_patches): Don't close the bug if the
	--no-close switch was used.
---
 2 files changed, 15 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul  8 10:36:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:36:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 32458] bugzilla-tool: Add
 --no-close switch to land-patches
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090708173645.28008324EE74@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 32458:	  bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/attachment.cgi?id=32458&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
rs=me -- I'm not a total expert on this, but it looks fine

From bugzilla-daemon at webkit.org  Wed Jul  8 10:39:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:39:52 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27071] [XSSAuditor] HTTP
 parameters with null/control characters bypass XSSAuditor : [Attachment
 32433] Patch with tests
In-Reply-To: <bug-27071-0@https.bugs.webkit.org/>
References: <bug-27071-0@https.bugs.webkit.org/>
Message-ID: <20090708173952.16A43324EFBA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27071: [XSSAuditor] HTTP parameters with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27071

Attachment 32433: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32433&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
What is execGetURL.swf ?  I don't think we can put flash movies in layout
tests.	This probably isn't needed because the auditor blocks the load anyway. 
Also, where is script-tag-post-control-char.html ?

From bugzilla-daemon at webkit.org  Wed Jul  8 10:46:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:46:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27083] bugzilla.py: Clean
 up bug_server use : [Attachment 32459] bugzilla.py: Clean up bug_server use
In-Reply-To: <bug-27083-0@https.bugs.webkit.org/>
References: <bug-27083-0@https.bugs.webkit.org/>
Message-ID: <20090708174654.B09C5324F292@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27083: bugzilla.py: Clean up bug_server use
https://bugs.webkit.org/show_bug.cgi?id=27083

Attachment 32459:	  bugzilla.py: Clean up bug_server use
https://bugs.webkit.org/attachment.cgi?id=32459&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

	Reviewed by NOBODY (OOPS!).

	* Scripts/modules/bugzilla.py:
	(Bugzilla.fetch_bug_ids_from_commit_queue): Use bug_server
	instead of hard-coding the URL.
	(Bugzilla.authenticate): Remove extra '/' before URL path.
	(Bugzilla.add_patch_to_bug): Ditto.
---
 2 files changed, 15 insertions(+), 3 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul  8 10:47:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 10:47:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27083] bugzilla.py: Clean up
 bug_server use : [Attachment 32459] bugzilla.py: Clean up bug_server use
In-Reply-To: <bug-27083-0@https.bugs.webkit.org/>
References: <bug-27083-0@https.bugs.webkit.org/>
Message-ID: <20090708174732.6BCE7324F2E3@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27083: bugzilla.py: Clean up bug_server use
https://bugs.webkit.org/show_bug.cgi?id=27083

Attachment 32459:	  bugzilla.py: Clean up bug_server use
https://bugs.webkit.org/attachment.cgi?id=32459&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 11:05:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 11:05:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27084] Add -[WebView
 _userGestureHint] : [Attachment 32460] patch to implement bug fix
In-Reply-To: <bug-27084-0@https.bugs.webkit.org/>
References: <bug-27084-0@https.bugs.webkit.org/>
Message-ID: <20090708180550.D7A28324FB3B@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27084: Add -[WebView _userGestureHint]
https://bugs.webkit.org/show_bug.cgi?id=27084

Attachment 32460: patch to implement bug fix
https://bugs.webkit.org/attachment.cgi?id=32460&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 11:08:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 11:08:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26903] Need to enable
 CHANNEL_MESSAGING by default : [Attachment 32152] Proposed patch
In-Reply-To: <bug-26903-0@https.bugs.webkit.org/>
References: <bug-26903-0@https.bugs.webkit.org/>
Message-ID: <20090708180858.E6B42324FC9F@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32152: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32152&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Good catch on the visual studio stuff - I've done a search to make sure I
haven't missed any other places, and also updated the ChangeLogs to have a less
terse change description.

From bugzilla-daemon at webkit.org  Wed Jul  8 11:08:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 11:08:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26903] Need to enable
 CHANNEL_MESSAGING by default : [Attachment 32461] Patch addressing ap's
 comments
In-Reply-To: <bug-26903-0@https.bugs.webkit.org/>
References: <bug-26903-0@https.bugs.webkit.org/>
Message-ID: <20090708180859.0DB7B324FCA3@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32461: Patch addressing ap's comments
https://bugs.webkit.org/attachment.cgi?id=32461&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Good catch on the visual studio stuff - I've done a search to make sure I
haven't missed any other places, and also updated the ChangeLogs to have a less
terse change description.

From bugzilla-daemon at webkit.org  Wed Jul  8 11:18:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 11:18:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27071] [XSSAuditor] HTTP
 parameters with null/control characters bypass XSSAuditor : [Attachment
 32462] Patch with tests
In-Reply-To: <bug-27071-0@https.bugs.webkit.org/>
References: <bug-27071-0@https.bugs.webkit.org/>
Message-ID: <20090708181827.A42FE3250104@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27071: [XSSAuditor] HTTP parameters with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27071

Attachment 32462: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32462&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Removed file execGetURL.swf. Added test case script-tag-post-control-char.html

From bugzilla-daemon at webkit.org  Wed Jul  8 11:29:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 11:29:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26903] Need to enable
 CHANNEL_MESSAGING by default : [Attachment 32461] Patch addressing ap's
 comments
In-Reply-To: <bug-26903-0@https.bugs.webkit.org/>
References: <bug-26903-0@https.bugs.webkit.org/>
Message-ID: <20090708182959.A00E732505DB@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32461: Patch addressing ap's comments
https://bugs.webkit.org/attachment.cgi?id=32461&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +<<<<<<< HEAD:LayoutTests/ChangeLog

> +=======

Please fix conflict markers before landing.

Does the Visual Studio project actually build? I'm not sure if it has all the
necessary source files in it.

Oh, and please also enable
LayoutTests/http/tests/security/MessagePort/event-listener-context.html-disable
d.

I'm going to say r=me now, but please address these comments.

From bugzilla-daemon at webkit.org  Wed Jul  8 12:02:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 12:02:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27071] [XSSAuditor] HTTP
 parameters with null/control characters bypass XSSAuditor : [Attachment
 32462] Patch with tests
In-Reply-To: <bug-27071-0@https.bugs.webkit.org/>
References: <bug-27071-0@https.bugs.webkit.org/>
Message-ID: <20090708190230.BFD6B3251484@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27071: [XSSAuditor] HTTP parameters with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27071

Attachment 32462: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32462&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great.  Thanks Dan.	The ChangeLog still lists the SWF, but that's
not a big deal.  I'll try to remember to remove it when I land the patch.

From bugzilla-daemon at webkit.org  Wed Jul  8 12:21:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 12:21:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27087] Add New
 Configuration Flag for Redistributable Windows Build : [Attachment 32465]
 Add WIN_REDISTRIBUTABLE flag for builds
In-Reply-To: <bug-27087-0@https.bugs.webkit.org/>
References: <bug-27087-0@https.bugs.webkit.org/>
Message-ID: <20090708192138.67ABB3251CE6@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 27087: Add New Configuration Flag for Redistributable Windows Build
https://bugs.webkit.org/show_bug.cgi?id=27087

Attachment 32465: Add WIN_REDISTRIBUTABLE flag for builds
https://bugs.webkit.org/attachment.cgi?id=32465&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 12:46:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 12:46:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27089] Fix V8 idl codegen
 to use unique constant names : [Attachment 32466] Fix to use a
 DerivedSource.cpp-like cpp merger for v8 bindings
In-Reply-To: <bug-27089-0@https.bugs.webkit.org/>
References: <bug-27089-0@https.bugs.webkit.org/>
Message-ID: <20090708194639.91BF832527BA@gamma.macosforge.org>

Marc-Antoine Ruel <maruel at chromium.org> has asked  for review:
Bug 27089: Fix V8 idl codegen to use unique constant names
https://bugs.webkit.org/show_bug.cgi?id=27089

Attachment 32466: Fix to use a DerivedSource.cpp-like cpp merger for v8
bindings
https://bugs.webkit.org/attachment.cgi?id=32466&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 12:47:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 12:47:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27090] Remove
 lockBackForwardList argument from HTMLFormElement::submit() : [Attachment
 32467] proposed patch
In-Reply-To: <bug-27090-0@https.bugs.webkit.org/>
References: <bug-27090-0@https.bugs.webkit.org/>
Message-ID: <20090708194720.2EEFE3252810@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 27090: Remove lockBackForwardList argument from HTMLFormElement::submit()
https://bugs.webkit.org/show_bug.cgi?id=27090

Attachment 32467: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32467&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 12:48:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 12:48:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27089] Fix V8 idl codegen
 to use unique constant names : [Attachment 32466] Fix to use a
 DerivedSource.cpp-like cpp merger for v8 bindings
In-Reply-To: <bug-27089-0@https.bugs.webkit.org/>
References: <bug-27089-0@https.bugs.webkit.org/>
Message-ID: <20090708194824.6D41432528AC@gamma.macosforge.org>

Marc-Antoine Ruel <maruel at chromium.org> has asked David Levin
<levin at chromium.org> for review:
Bug 27089: Fix V8 idl codegen to use unique constant names
https://bugs.webkit.org/show_bug.cgi?id=27089

Attachment 32466: Fix to use a DerivedSource.cpp-like cpp merger for v8
bindings
https://bugs.webkit.org/attachment.cgi?id=32466&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 12:51:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 12:51:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27090] Remove
 lockBackForwardList argument from HTMLFormElement::submit() : [Attachment
 32467] proposed patch
In-Reply-To: <bug-27090-0@https.bugs.webkit.org/>
References: <bug-27090-0@https.bugs.webkit.org/>
Message-ID: <20090708195133.AD03F3252A2B@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 27090: Remove lockBackForwardList argument from HTMLFormElement::submit()
https://bugs.webkit.org/show_bug.cgi?id=27090

Attachment 32467: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32467&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 13:18:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:18:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27084] Add -[WebView
 _userGestureHint] : [Attachment 32468] updated to address Darin's comments
In-Reply-To: <bug-27084-0@https.bugs.webkit.org/>
References: <bug-27084-0@https.bugs.webkit.org/>
Message-ID: <20090708201858.2781032537E1@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27084: Add -[WebView _userGestureHint]
https://bugs.webkit.org/show_bug.cgi?id=27084

Attachment 32468: updated to address Darin's comments
https://bugs.webkit.org/attachment.cgi?id=32468&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 13:18:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:18:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27084] Add -[WebView
 _userGestureHint] : [Attachment 32460] patch to implement bug fix
In-Reply-To: <bug-27084-0@https.bugs.webkit.org/>
References: <bug-27084-0@https.bugs.webkit.org/>
Message-ID: <20090708201858.1251132537DE@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has canceled Greg Bolsinga
<bolsinga at apple.com>'s request for review:
Bug 27084: Add -[WebView _userGestureHint]
https://bugs.webkit.org/show_bug.cgi?id=27084

Attachment 32460: patch to implement bug fix
https://bugs.webkit.org/attachment.cgi?id=32460&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 13:20:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:20:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27086] Movie controller
 pops back up after mousing out of the video,
 while movie is loading : [Attachment 32469] patch v1.
In-Reply-To: <bug-27086-0@https.bugs.webkit.org/>
References: <bug-27086-0@https.bugs.webkit.org/>
Message-ID: <20090708202008.78BD43253874@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27086: Movie controller pops back up after mousing out of the video, while
movie is loading
https://bugs.webkit.org/show_bug.cgi?id=27086

Attachment 32469: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32469&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 13:25:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:25:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27072] Split
 StorageNamespace and StorageArea into an interface and implementation :
 [Attachment 32470] v2
In-Reply-To: <bug-27072-0@https.bugs.webkit.org/>
References: <bug-27072-0@https.bugs.webkit.org/>
Message-ID: <20090708202549.288923253AF7@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32470: v2
https://bugs.webkit.org/attachment.cgi?id=32470&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
The main difference is that I took out the Chromium ifdef's and replaced them
with an #error for Chromium.

From bugzilla-daemon at webkit.org  Wed Jul  8 13:27:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:27:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27084] Add -[WebView _
 isProcessingUserGesture] : [Attachment 32468] updated to address Darin's
 comments
In-Reply-To: <bug-27084-0@https.bugs.webkit.org/>
References: <bug-27084-0@https.bugs.webkit.org/>
Message-ID: <20090708202714.7EB843253BC0@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 27084: Add -[WebView _ isProcessingUserGesture]
https://bugs.webkit.org/show_bug.cgi?id=27084

Attachment 32468: updated to address Darin's comments
https://bugs.webkit.org/attachment.cgi?id=32468&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 13:28:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:28:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27089] Fix V8 idl codegen to
 use unique constant names : [Attachment 32466] Fix to use a
 DerivedSource.cpp-like cpp merger for v8 bindings
In-Reply-To: <bug-27089-0@https.bugs.webkit.org/>
References: <bug-27089-0@https.bugs.webkit.org/>
Message-ID: <20090708202818.4BC313253C46@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Marc-Antoine Ruel
<maruel at chromium.org>'s request for review:
Bug 27089: Fix V8 idl codegen to use unique constant names
https://bugs.webkit.org/show_bug.cgi?id=27089

Attachment 32466: Fix to use a DerivedSource.cpp-like cpp merger for v8
bindings
https://bugs.webkit.org/attachment.cgi?id=32466&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
LGTM

From bugzilla-daemon at webkit.org  Wed Jul  8 13:56:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 13:56:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27086] Movie controller pops
 back up after mousing out of the video,
 while movie is loading : [Attachment 32469] patch v1.
In-Reply-To: <bug-27086-0@https.bugs.webkit.org/>
References: <bug-27086-0@https.bugs.webkit.org/>
Message-ID: <20090708205615.0E1B8325473E@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27086: Movie controller pops back up after mousing out of the video, while
movie is loading
https://bugs.webkit.org/show_bug.cgi?id=27086

Attachment 32469: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32469&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +    // do fading manually, css animations don't work well with shadow trees

Since you're moving this comment, might as well fix the capitalization, and
remove "well" (they just don't work).

r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 14:09:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:09:27 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32402] removed
 the change to CompositeEditCommand.cpp
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090708210927.6B50E3254CB9@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32402: removed the change to CompositeEditCommand.cpp
https://bugs.webkit.org/attachment.cgi?id=32402&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Style:
 63	short comparePoint(Node* refNode, int offset, ExceptionCode& ec) const;


I would have used early return:
 215	 Element* enclosingCell = static_cast<Element*>(enclosingNodeOfType(p,
&isTableCell, true));
 216	 // Since enclosingNodeOfType won't search beyond the highest root
editable node,
 217	 // this code works even if the closest table cell was outside of the
root editable node.
 218	 return enclosingCell ? enclosingCell : editableRootForPosition(p);

This could assert ASSERT(node->parentNode()):
 592 VisiblePosition visiblePositionBeforeNode(const Node* node)

Please add a FIXME: to the other createRange:
 612 PassRefPtr<Range> createRange(PassRefPtr<Document> document, const
VisiblePosition& start, const VisiblePosition& end, ExceptionCode& ec)

PassRefPtr seems the wrong type for these args:
 627 PassRefPtr<Range> extendRangeToWrappingNodes(PassRefPtr<Range>
rangeToExtend, PassRefPtr<Range> maximumRange, Node* rootNode)

Explicit visiblePosition construction is not needed here:
 1076	  return visiblePositionBeforeNode(node) ==
VisiblePosition(selectedRange.startPosition())
(but it also doesn't hurt)

Style:
 65 Element* unsplittableElementForPosition(const Position& p);
 78 PassRefPtr<Range> createRange(PassRefPtr<Document> document, const
VisiblePosition& start, const VisiblePosition& end, ExceptionCode& ec);
 145 bool isNodeVisiblyContainedWithin(Node* node, const Range& selectedRange);


Looks fine.  Normally we don't add unused code, but I can see how this will
help make your future patches smaller.

Please re-submit a fixed version, and then we might wait to land this until the
other patch which depends on these changes is approved to.

From bugzilla-daemon at webkit.org  Wed Jul  8 14:10:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:10:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 32458] bugzilla-tool: Add
 --no-close switch to land-patches
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090708211051.D07DC3254D71@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 32458:	  bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/attachment.cgi?id=32458&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #2)
> (From update of attachment 32458 [details])
> Looks fine.  It should obsolete the one patch it landed instead of closing
> though.

The current practice is to clear the review flag, not obsolete the patch.  
I'll make it do that instead.

From bugzilla-daemon at webkit.org  Wed Jul  8 14:14:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:14:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27093] Add a 'AllInOne.cpp'
 file to help with windows compilation with v8 : [Attachment 32472] new file
In-Reply-To: <bug-27093-0@https.bugs.webkit.org/>
References: <bug-27093-0@https.bugs.webkit.org/>
Message-ID: <20090708211425.A9F713254EF8@gamma.macosforge.org>

Marc-Antoine Ruel <maruel at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27093: Add a 'AllInOne.cpp' file to help with windows compilation with v8
https://bugs.webkit.org/show_bug.cgi?id=27093

Attachment 32472: new file
https://bugs.webkit.org/attachment.cgi?id=32472&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 14:16:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:16:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27093] Add a 'AllInOne.cpp'
 file to help with windows compilation with v8 : [Attachment 32472] new file
In-Reply-To: <bug-27093-0@https.bugs.webkit.org/>
References: <bug-27093-0@https.bugs.webkit.org/>
Message-ID: <20090708211619.2B9DB3254FD4@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Marc-Antoine Ruel
<maruel at chromium.org>'s request for review:
Bug 27093: Add a 'AllInOne.cpp' file to help with windows compilation with v8
https://bugs.webkit.org/show_bug.cgi?id=27093

Attachment 32472: new file
https://bugs.webkit.org/attachment.cgi?id=32472&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 14:25:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:25:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27094] [Chromium] Upstream
 V8 npruntime bindings : [Attachment 32473] patch
In-Reply-To: <bug-27094-0@https.bugs.webkit.org/>
References: <bug-27094-0@https.bugs.webkit.org/>
Message-ID: <20090708212528.1745B325541E@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27094: [Chromium] Upstream V8 npruntime bindings
https://bugs.webkit.org/show_bug.cgi?id=27094

Attachment 32473: patch
https://bugs.webkit.org/attachment.cgi?id=32473&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 14:33:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:33:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27094] [Chromium] Upstream
 V8 npruntime bindings : [Attachment 32474] patch2
In-Reply-To: <bug-27094-0@https.bugs.webkit.org/>
References: <bug-27094-0@https.bugs.webkit.org/>
Message-ID: <20090708213304.EBB4E32557DE@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27094: [Chromium] Upstream V8 npruntime bindings
https://bugs.webkit.org/show_bug.cgi?id=27094

Attachment 32474: patch2
https://bugs.webkit.org/attachment.cgi?id=32474&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 14:33:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:33:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27094] [Chromium] Upstream
 V8 npruntime bindings : [Attachment 32473] patch
In-Reply-To: <bug-27094-0@https.bugs.webkit.org/>
References: <bug-27094-0@https.bugs.webkit.org/>
Message-ID: <20090708213304.DF6FE32557DC@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has canceled Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27094: [Chromium] Upstream V8 npruntime bindings
https://bugs.webkit.org/show_bug.cgi?id=27094

Attachment 32473: patch
https://bugs.webkit.org/attachment.cgi?id=32473&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 14:42:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:42:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27094] [Chromium] Upstream V8
 npruntime bindings : [Attachment 32474] patch2
In-Reply-To: <bug-27094-0@https.bugs.webkit.org/>
References: <bug-27094-0@https.bugs.webkit.org/>
Message-ID: <20090708214205.AA9BA3255BD1@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27094: [Chromium] Upstream V8 npruntime bindings
https://bugs.webkit.org/show_bug.cgi?id=27094

Attachment 32474: patch2
https://bugs.webkit.org/attachment.cgi?id=32474&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me, with nits:

> +// Commenting out the locks to avoid dependencies on chrome for now.
> +// Need a platform abstraction which we can use.
> +// static Lock StringIdentifierMapLock;
> +

Remove commented code.

> +// FIXME: Consider removing locks if we're singlethreaded already.
> +// static Lock IntIdentifierMapLock;

Ditto.

> +	   // AutoLock safeLock(StringIdentifierMapLock);

Ditto.

> +    // AutoLock safeLock(IntIdentifierMapLock);

Ditto.

From bugzilla-daemon at webkit.org  Wed Jul  8 14:59:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:59:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26918] XSSAuditor should
 prevent injection of HTML Base tag : [Attachment 32475] Patch with tests
In-Reply-To: <bug-26918-0@https.bugs.webkit.org/>
References: <bug-26918-0@https.bugs.webkit.org/>
Message-ID: <20090708215905.59AA732562F0@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 26918: XSSAuditor should prevent injection of HTML Base tag
https://bugs.webkit.org/show_bug.cgi?id=26918

Attachment 32475: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32475&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Cleaned up patch.

From bugzilla-daemon at webkit.org  Wed Jul  8 14:59:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:59:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32476] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090708215925.4DBFC3256314@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32476: win patch
https://bugs.webkit.org/attachment.cgi?id=32476&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 14:59:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 14:59:25 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32338] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090708215925.41C143256312@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32338: win patch
https://bugs.webkit.org/attachment.cgi?id=32338&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 15:04:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:04:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26967] [V8] Move garbage
 collector related functions from V8Proxy to V8GCController : [Attachment
 32477] patch
In-Reply-To: <bug-26967-0@https.bugs.webkit.org/>
References: <bug-26967-0@https.bugs.webkit.org/>
Message-ID: <20090708220450.2EFBC32565AD@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 26967: [V8] Move garbage collector related functions from V8Proxy to
V8GCController
https://bugs.webkit.org/show_bug.cgi?id=26967

Attachment 32477: patch
https://bugs.webkit.org/attachment.cgi?id=32477&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 15:05:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:05:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26940] [Chromium] Add a SQLite
 VFS for Chromium : [Attachment 32476] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090708220557.2264A3256631@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32476: win patch
https://bugs.webkit.org/attachment.cgi?id=32476&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looking much prettier -- two minor issues below:

> +String SQLiteFileSystem::appendDatabaseFileNameToPath(const String& path,
const String& fileName)
> +{
> +    if (path.isEmpty())
> +	   return fileName;
> +    else
> +	   return path + "\\" + fileName;
> +}

Whoops. This is a Windows-ism. Can we use FileSystem.h magic here?

> +int chromiumDelete(sqlite3_vfs* vfs, const char* fileName, int syncDir)

unused param syncDir?

From bugzilla-daemon at webkit.org  Wed Jul  8 15:08:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:08:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26918] XSSAuditor should
 prevent injection of HTML Base tag : [Attachment 32475] Patch with tests
In-Reply-To: <bug-26918-0@https.bugs.webkit.org/>
References: <bug-26918-0@https.bugs.webkit.org/>
Message-ID: <20090708220802.EDBB13256709@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26918: XSSAuditor should prevent injection of HTML Base tag
https://bugs.webkit.org/show_bug.cgi?id=26918

Attachment 32475: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32475&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Great.	This got much cleaner now that you've done the null / control char
thing for the other APIs.

From bugzilla-daemon at webkit.org  Wed Jul  8 15:21:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:21:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27072] Split StorageNamespace
 and StorageArea into an interface and implementation : [Attachment 32470]
 v2
In-Reply-To: <bug-27072-0@https.bugs.webkit.org/>
References: <bug-27072-0@https.bugs.webkit.org/>
Message-ID: <20090708222145.E4FAE3256C82@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32470: v2
https://bugs.webkit.org/attachment.cgi?id=32470&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 15:31:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:31:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26967] [V8] Move garbage
 collector related functions from V8Proxy to V8GCController : [Attachment
 32477] patch
In-Reply-To: <bug-26967-0@https.bugs.webkit.org/>
References: <bug-26967-0@https.bugs.webkit.org/>
Message-ID: <20090708223148.1E01E3257116@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26967: [V8] Move garbage collector related functions from V8Proxy to
V8GCController
https://bugs.webkit.org/show_bug.cgi?id=26967

Attachment 32477: patch
https://bugs.webkit.org/attachment.cgi?id=32477&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Wed Jul  8 15:54:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:54:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27098] Make
 prepare-ChangeLog less shouty : [Attachment 32480] patch
In-Reply-To: <bug-27098-0@https.bugs.webkit.org/>
References: <bug-27098-0@https.bugs.webkit.org/>
Message-ID: <20090708225434.33B6432579EB@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has asked  for review:
Bug 27098: Make prepare-ChangeLog less shouty
https://bugs.webkit.org/show_bug.cgi?id=27098

Attachment 32480: patch
https://bugs.webkit.org/attachment.cgi?id=32480&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 15:57:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 15:57:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27098] Make prepare-ChangeLog
 less shouty : [Attachment 32480] patch
In-Reply-To: <bug-27098-0@https.bugs.webkit.org/>
References: <bug-27098-0@https.bugs.webkit.org/>
Message-ID: <20090708225719.505E83257ACD@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Maciej Stachowiak
<mjs at apple.com>'s request for review:
Bug 27098: Make prepare-ChangeLog less shouty
https://bugs.webkit.org/show_bug.cgi?id=27098

Attachment 32480: patch
https://bugs.webkit.org/attachment.cgi?id=32480&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 16:00:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:00:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32482] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090708230014.03F603257C06@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32482: win patch
https://bugs.webkit.org/attachment.cgi?id=32482&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 16:07:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:07:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27100] Media controls
 shouldn't display a "loading" state when there is no src. : [Attachment
 32483] patch v1.
In-Reply-To: <bug-27100-0@https.bugs.webkit.org/>
References: <bug-27100-0@https.bugs.webkit.org/>
Message-ID: <20090708230716.6659D3257ECF@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27100: Media controls shouldn't display a "loading" state when there is no
src.
https://bugs.webkit.org/show_bug.cgi?id=27100

Attachment 32483: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32483&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 16:10:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:10:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27062] bugzilla-tool:
 post-commits should read bug id from commit log and actually work :
 [Attachment 32452] Patch v3
In-Reply-To: <bug-27062-0@https.bugs.webkit.org/>
References: <bug-27062-0@https.bugs.webkit.org/>
Message-ID: <20090708231016.97EEF3258002@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27062: bugzilla-tool: post-commits should read bug id from commit log and
actually work
https://bugs.webkit.org/show_bug.cgi?id=27062

Attachment 32452: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32452&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Changes to WebKitTools/Scripts/modules/bugzilla.py are fantastic, and good to
commit as is.

Reviewing WebKitTools/Scripts/bugzilla-tool:
+	 commit_ids = tool.scm().commit_ids_from_range_arguments(args,
cherry_pick=True)

cherry_pick?  Seems like that part of your patch was dropped.

Looks good.

From bugzilla-daemon at webkit.org  Wed Jul  8 16:11:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:11:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32484]
 resubmission
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090708231105.BC49C325805E@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32484: resubmission
https://bugs.webkit.org/attachment.cgi?id=32484&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 16:13:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:13:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27101] Possible crashes
 when mouse clicks not dispatched because range input destroyed while thumb
 is being dragged (e.g. scrub to end of movie) : [Attachment 32485] Proposed
 patch
In-Reply-To: <bug-27101-0@https.bugs.webkit.org/>
References: <bug-27101-0@https.bugs.webkit.org/>
Message-ID: <20090708231353.9A2313258191@gamma.macosforge.org>

Eric Carlson <eric.carlson at apple.com> has asked  for review:
Bug 27101: Possible crashes when mouse clicks not dispatched because range
input destroyed while thumb is being dragged (e.g. scrub to end of movie)
https://bugs.webkit.org/show_bug.cgi?id=27101

Attachment 32485: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32485&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 16:27:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:27:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27072] Split
 StorageNamespace and StorageArea into an interface and implementation :
 [Attachment 32486] Fix build in release mode
In-Reply-To: <bug-27072-0@https.bugs.webkit.org/>
References: <bug-27072-0@https.bugs.webkit.org/>
Message-ID: <20090708232759.4C2A4325870F@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32486: Fix build in release mode
https://bugs.webkit.org/attachment.cgi?id=32486&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
I'm not sure why this showed up in release mode and not debug (probably
optimizations?), but there was a build error in the last patch.  To fix it, I
defined 2 virtual functions in StorageArea and made StorageAreaSync use a
StorageArea* rather than a StroageAreaImpl* which removed some complex
dependencies.

From bugzilla-daemon at webkit.org  Wed Jul  8 16:41:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:41:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26816] Selection changed by
 indent : [Attachment 32487] change due to the resubmission for 27038
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090708234135.A25263258CC7@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32487: change due to the resubmission for 27038
https://bugs.webkit.org/attachment.cgi?id=32487&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 16:41:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:41:35 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26816] Selection changed by
 indent : [Attachment 32436] fixes the bug
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090708234135.8958F3258CC3@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32436: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32436&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 16:49:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 16:49:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27072] Split StorageNamespace
 and StorageArea into an interface and implementation : [Attachment 32486]
 Fix build in release mode
In-Reply-To: <bug-27072-0@https.bugs.webkit.org/>
References: <bug-27072-0@https.bugs.webkit.org/>
Message-ID: <20090708234923.94F1F3258F7B@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27072: Split StorageNamespace and StorageArea into an interface and
implementation
https://bugs.webkit.org/show_bug.cgi?id=27072

Attachment 32486: Fix build in release mode
https://bugs.webkit.org/attachment.cgi?id=32486&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 17:03:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 17:03:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27103] Upstream
 V8NPObject.h and V8NPObject.cpp : [Attachment 32488] Patch with
 V8NPObject.h, V8NPObject.cpp,
 plus fixes to other files that reference the old filename/function names.
In-Reply-To: <bug-27103-0@https.bugs.webkit.org/>
References: <bug-27103-0@https.bugs.webkit.org/>
Message-ID: <20090709000354.2C884325959E@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103

Attachment 32488: Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other
files that reference the old filename/function names.
https://bugs.webkit.org/attachment.cgi?id=32488&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 17:07:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 17:07:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27102] [V8] Move
 V8GCController functions to their own file : [Attachment 32489] patch
In-Reply-To: <bug-27102-0@https.bugs.webkit.org/>
References: <bug-27102-0@https.bugs.webkit.org/>
Message-ID: <20090709000713.722A732596F9@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27102: [V8] Move V8GCController functions to their own file
https://bugs.webkit.org/show_bug.cgi?id=27102

Attachment 32489: patch
https://bugs.webkit.org/attachment.cgi?id=32489&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 17:09:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 17:09:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27102] [V8] Move
 V8GCController functions to their own file : [Attachment 32489] patch
In-Reply-To: <bug-27102-0@https.bugs.webkit.org/>
References: <bug-27102-0@https.bugs.webkit.org/>
Message-ID: <20090709000906.E9E4232597F0@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27102: [V8] Move V8GCController functions to their own file
https://bugs.webkit.org/show_bug.cgi?id=27102

Attachment 32489: patch
https://bugs.webkit.org/attachment.cgi?id=32489&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I did not review this for content.  The move looks sane enough.  rs=me

From bugzilla-daemon at webkit.org  Wed Jul  8 17:23:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 17:23:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27104] [V8]
 evaluateInNewContext should send the didCreateScriptContext notification :
 [Attachment 32490] simple patch
In-Reply-To: <bug-27104-0@https.bugs.webkit.org/>
References: <bug-27104-0@https.bugs.webkit.org/>
Message-ID: <20090709002356.2D7303259D79@gamma.macosforge.org>

Matt Perry <mpComplete at gmail.com> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27104: [V8] evaluateInNewContext should send the didCreateScriptContext
notification
https://bugs.webkit.org/show_bug.cgi?id=27104

Attachment 32490: simple patch
https://bugs.webkit.org/attachment.cgi?id=32490&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 17:29:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 17:29:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26999]
 bugzilla-tool/svn-apply can't handle patches made from a non-root directory
 : [Attachment 32491] This would make it so svn-create-patch provides full
 paths from the WebKit root directory.
In-Reply-To: <bug-26999-0@https.bugs.webkit.org/>
References: <bug-26999-0@https.bugs.webkit.org/>
Message-ID: <20090709002958.A7B8B3259FAD@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 26999: bugzilla-tool/svn-apply can't handle patches made from a non-root
directory
https://bugs.webkit.org/show_bug.cgi?id=26999

Attachment 32491: This would make it so svn-create-patch provides full paths
from the WebKit root directory.
https://bugs.webkit.org/attachment.cgi?id=32491&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This should keep the current svn-create-patch behavior, but just make it so
that the paths for the files are from the WebKit root directory.  This would be
on the create patch side, not on the apply patch side.	I don't know how common
it is to get patches in a form other then one produced by svn-create-patch.  If
its better to handle the apply side then I'm perfectly fine with this getting
r-.  I tested this a number of different ways on OS X, I haven't tried Windows.

From bugzilla-daemon at webkit.org  Wed Jul  8 17:42:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 17:42:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25151] workers with syntax
 errors not firing error event : [Attachment 32493] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090709004209.5E86D325A490@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 25151: workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32493: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32493&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 18:02:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 18:02:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26229] Can't click outside
 the slider thumb and start dragging : [Attachment 32494] patch v3.
In-Reply-To: <bug-26229-0@https.bugs.webkit.org/>
References: <bug-26229-0@https.bugs.webkit.org/>
Message-ID: <20090709010204.07BA1325AB79@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26229: Can't click outside the slider thumb and start dragging
https://bugs.webkit.org/show_bug.cgi?id=26229

Attachment 32494: patch v3.
https://bugs.webkit.org/attachment.cgi?id=32494&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 18:12:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 18:12:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 32495] Bug 27082:
 bugzilla-tool: Add --no-close switch to land-patches
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090709011206.848A5325AEF9@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 32495:	  Bug 27082: bugzilla-tool: Add --no-close switch to
land-patches
https://bugs.webkit.org/attachment.cgi?id=32495&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 18:15:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 18:15:53 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26229] Can't click outside the
 slider thumb and start dragging : [Attachment 32494] patch v3.
In-Reply-To: <bug-26229-0@https.bugs.webkit.org/>
References: <bug-26229-0@https.bugs.webkit.org/>
Message-ID: <20090709011553.E0E33325B036@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26229: Can't click outside the slider thumb and start dragging
https://bugs.webkit.org/show_bug.cgi?id=26229

Attachment 32494: patch v3.
https://bugs.webkit.org/attachment.cgi?id=32494&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> diff --git a/WebCore/rendering/RenderSlider.cpp
b/WebCore/rendering/RenderSlider.cpp
> index 610a060..9e00d68 100644
> --- a/WebCore/rendering/RenderSlider.cpp
> +++ b/WebCore/rendering/RenderSlider.cpp
> @@ -127,41 +127,52 @@ private:
>      virtual Node* shadowParentNode() { return m_shadowParent; }
>  
>      Node* m_shadowParent;
> -    FloatPoint m_initialClickPoint;	     // initial click point in
RenderSlider-local coordinates
> -    int m_initialPosition;
>      bool m_inDragMode;
> +    FloatPoint m_mouseDragVectorToThumb;

Please move this above the bool to optimize packing. I'm not sure
'mouseDragVector' is really tbe best way to describe this. Is it
"offsetFromThumb"? Maybe it should be a FloatSize? 

> +    , m_mouseDragVectorToThumb(0, 0)

No need to init a FloatPoint.

> +		   }
> +		   else {

Should be } else { on one line.

> +		       // We are outside the thumb, move the thumb to the point
were
> +		       // we clicked. We'll be exactly at the center of the
thumb.
> +		       m_mouseDragVectorToThumb.setX(0);
> +		       m_mouseDragVectorToThumb.setY(0);

Is it possible for the click to be off the end of the slider, so we'd end up
with a negative thumb position? i.e. does this code need to handle end
conditions?

> +FloatPoint RenderSlider::mouseEventVectorToThumb(MouseEvent* evt)
> +{
> +    ASSERT (m_thumb && m_thumb->renderer());
> +    FloatPoint localPoint =
m_thumb->renderBox()->absoluteToLocal(evt->absoluteLocation(), false, true);
> +    IntRect thumbBounds = m_thumb->renderBox()->borderBoxRect();
> +    FloatPoint distance;
> +    distance.setX(thumbBounds.x() + thumbBounds.height() / 2 -
localPoint.x());
> +    distance.setY(thumbBounds.y() + thumbBounds.width() / 2 -
localPoint.y());

I think you have height and width switched.

> +    return distance;

You call this distance, but the method says vector.

r- because I think this needs another revision, but it's certainly in the right
direction.

From bugzilla-daemon at webkit.org  Wed Jul  8 18:17:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 18:17:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27100] Media controls
 shouldn't display a "loading" state when there is no src. : [Attachment
 32483] patch v1.
In-Reply-To: <bug-27100-0@https.bugs.webkit.org/>
References: <bug-27100-0@https.bugs.webkit.org/>
Message-ID: <20090709011720.BCC73325B0CD@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27100: Media controls shouldn't display a "loading" state when there is no
src.
https://bugs.webkit.org/show_bug.cgi?id=27100

Attachment 32483: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32483&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 18:59:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 18:59:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27106] [Chromium] Linux:
 render disabled checkboxes and radio controls as disabled : [Attachment
 32498] patch
In-Reply-To: <bug-27106-0@https.bugs.webkit.org/>
References: <bug-27106-0@https.bugs.webkit.org/>
Message-ID: <20090709015927.EEDCC325BFF8@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27106: [Chromium] Linux: render disabled checkboxes and radio controls as
disabled
https://bugs.webkit.org/show_bug.cgi?id=27106

Attachment 32498: patch
https://bugs.webkit.org/attachment.cgi?id=32498&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 19:01:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 19:01:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27043] Mouse-dragged events
 are not generated for right & middle buttons : [Attachment 32497] Fixes
 middlemouse and rightmouse drag events.
In-Reply-To: <bug-27043-0@https.bugs.webkit.org/>
References: <bug-27043-0@https.bugs.webkit.org/>
Message-ID: <20090709020122.4790D325C0B3@gamma.macosforge.org>

John Newlin <jnewlin at google.com> has asked  for review:
Bug 27043: Mouse-dragged events are not generated for right & middle buttons
https://bugs.webkit.org/show_bug.cgi?id=27043

Attachment 32497: Fixes middlemouse and rightmouse drag events.
https://bugs.webkit.org/attachment.cgi?id=32497&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 19:12:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 19:12:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32482] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090709021256.CA357325C54A@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32482: win patch
https://bugs.webkit.org/attachment.cgi?id=32482&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 19:29:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 19:29:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25205] XMLHttpRequest
 instance is not an instanceof XMLHttpRequest : [Attachment 32499]
 DOMConstructorObject approach.
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090709022954.46803325CB68@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32499: DOMConstructorObject approach.
https://bugs.webkit.org/attachment.cgi?id=32499&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Thank you for your review.

I agree.

I've revised the patch such that all the classes in question derive from
DOMConstructorObject, which in turn derives from DOMObject.

Can you take another look?

Yuzo

From bugzilla-daemon at webkit.org  Wed Jul  8 20:56:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 20:56:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26229] Can't click outside
 the slider thumb and start dragging : [Attachment 32500] patch v4.
In-Reply-To: <bug-26229-0@https.bugs.webkit.org/>
References: <bug-26229-0@https.bugs.webkit.org/>
Message-ID: <20090709035605.AA9EB325EBC0@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26229: Can't click outside the slider thumb and start dragging
https://bugs.webkit.org/show_bug.cgi?id=26229

Attachment 32500: patch v4.
https://bugs.webkit.org/attachment.cgi?id=32500&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 21:01:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 21:01:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24000] Side bar linking to
 "DOM Interfaces" returns 404 : [Attachment 32501] Remove "DOM Interfaces"
 Link
In-Reply-To: <bug-24000-0@https.bugs.webkit.org/>
References: <bug-24000-0@https.bugs.webkit.org/>
Message-ID: <20090709040108.16404325ED98@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 24000: Side bar linking to "DOM Interfaces" returns 404
https://bugs.webkit.org/show_bug.cgi?id=24000

Attachment 32501: Remove "DOM Interfaces" Link
https://bugs.webkit.org/attachment.cgi?id=32501&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This patch just removes the link from the navigation sidebar.  I search the
wiki [1] and didn't find a really suitable replacement link.
http://trac.webkit.org/wiki

Maybe open a new bug for some "doc" pages in the future?

From bugzilla-daemon at webkit.org  Wed Jul  8 21:06:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 21:06:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26229] Can't click outside
 the slider thumb and start dragging : [Attachment 32500] patch v4.
In-Reply-To: <bug-26229-0@https.bugs.webkit.org/>
References: <bug-26229-0@https.bugs.webkit.org/>
Message-ID: <20090709040605.B0575325EF79@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26229: Can't click outside the slider thumb and start dragging
https://bugs.webkit.org/show_bug.cgi?id=26229

Attachment 32500: patch v4.
https://bugs.webkit.org/attachment.cgi?id=32500&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 21:11:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 21:11:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27101] Possible crashes when
 mouse clicks not dispatched because range input destroyed while thumb is
 being dragged (e.g. scrub to end of movie) : [Attachment 32485] Proposed
 patch
In-Reply-To: <bug-27101-0@https.bugs.webkit.org/>
References: <bug-27101-0@https.bugs.webkit.org/>
Message-ID: <20090709041147.B43C8325F169@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 27101: Possible crashes when mouse clicks not dispatched because range
input destroyed while thumb is being dragged (e.g. scrub to end of movie)
https://bugs.webkit.org/show_bug.cgi?id=27101

Attachment 32485: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32485&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
looks good!

From bugzilla-daemon at webkit.org  Wed Jul  8 21:42:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 21:42:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26784] Enable XSSAuditor by
 default : [Attachment 31993] patch
In-Reply-To: <bug-26784-0@https.bugs.webkit.org/>
References: <bug-26784-0@https.bugs.webkit.org/>
Message-ID: <20090709044242.81305325FCFC@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 26784: Enable XSSAuditor by default
https://bugs.webkit.org/show_bug.cgi?id=26784

Attachment 31993: patch
https://bugs.webkit.org/attachment.cgi?id=31993&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
By the power of Grayskull!  r=me

From bugzilla-daemon at webkit.org  Wed Jul  8 21:58:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 21:58:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26784] Enable XSSAuditor by
 default : [Attachment 31993] patch
In-Reply-To: <bug-26784-0@https.bugs.webkit.org/>
References: <bug-26784-0@https.bugs.webkit.org/>
Message-ID: <20090709045826.4D9113260329@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26784: Enable XSSAuditor by default
https://bugs.webkit.org/show_bug.cgi?id=26784

Attachment 31993: patch
https://bugs.webkit.org/attachment.cgi?id=31993&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Clearing the review flag.  We're going to hold off landing this for a few days.

From bugzilla-daemon at webkit.org  Wed Jul  8 22:50:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 22:50:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20625] ConsoleMessage
 should have a "type" attribute : [Attachment 32502] Patch to add
 MessageType to ConsoleMessage
In-Reply-To: <bug-20625-0@https.bugs.webkit.org/>
References: <bug-20625-0@https.bugs.webkit.org/>
Message-ID: <20090709055023.7B3913261667@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 20625: ConsoleMessage should have a "type" attribute
https://bugs.webkit.org/show_bug.cgi?id=20625

Attachment 32502: Patch to add MessageType to ConsoleMessage
https://bugs.webkit.org/attachment.cgi?id=32502&action=review

From bugzilla-daemon at webkit.org  Wed Jul  8 23:12:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 23:12:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27107] [V8] Move DOM
 wrapper functions in V8Proxy to V8DOMWrapper : [Attachment 32503] patch
 (renaming only)
In-Reply-To: <bug-27107-0@https.bugs.webkit.org/>
References: <bug-27107-0@https.bugs.webkit.org/>
Message-ID: <20090709061215.43A753261E09@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27107: [V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=27107

Attachment 32503: patch (renaming only)
https://bugs.webkit.org/attachment.cgi?id=32503&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Sorry.	The patch is huge.  It's just renaming functions.

From bugzilla-daemon at webkit.org  Wed Jul  8 23:22:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed,  8 Jul 2009 23:22:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27107] [V8] Move DOM wrapper
 functions in V8Proxy to V8DOMWrapper : [Attachment 32503] patch (renaming
 only)
In-Reply-To: <bug-27107-0@https.bugs.webkit.org/>
References: <bug-27107-0@https.bugs.webkit.org/>
Message-ID: <20090709062247.E20F1326213F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27107: [V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
https://bugs.webkit.org/show_bug.cgi?id=27107

Attachment 32503: patch (renaming only)
https://bugs.webkit.org/attachment.cgi?id=32503&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
rs=me

From bugzilla-daemon at webkit.org  Thu Jul  9 00:18:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 00:18:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20625] ConsoleMessage
 should have a "type" attribute : [Attachment 32504] forgot to write WebKit
 ChangeLog
In-Reply-To: <bug-20625-0@https.bugs.webkit.org/>
References: <bug-20625-0@https.bugs.webkit.org/>
Message-ID: <20090709071821.F28A332634FF@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 20625: ConsoleMessage should have a "type" attribute
https://bugs.webkit.org/show_bug.cgi?id=20625

Attachment 32504: forgot to write WebKit ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32504&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 00:18:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 00:18:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 20625] ConsoleMessage should
 have a "type" attribute : [Attachment 32502] Patch to add MessageType to
 ConsoleMessage
In-Reply-To: <bug-20625-0@https.bugs.webkit.org/>
References: <bug-20625-0@https.bugs.webkit.org/>
Message-ID: <20090709071821.D884632634FB@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 20625: ConsoleMessage should have a "type" attribute
https://bugs.webkit.org/show_bug.cgi?id=20625

Attachment 32502: Patch to add MessageType to ConsoleMessage
https://bugs.webkit.org/attachment.cgi?id=32502&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 00:53:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 00:53:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27108] Crash with
 fast/loader/frame-creation-removal.html : [Attachment 32505] 2009-07-08
 Adam Barth <abarth@webkit.org>
In-Reply-To: <bug-27108-0@https.bugs.webkit.org/>
References: <bug-27108-0@https.bugs.webkit.org/>
Message-ID: <20090709075309.5A535326429E@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27108: Crash with fast/loader/frame-creation-removal.html
https://bugs.webkit.org/show_bug.cgi?id=27108

Attachment 32505: 2009-07-08  Adam Barth  <abarth at webkit.org>
https://bugs.webkit.org/attachment.cgi?id=32505&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

	Rubber stamped by Eric Seidel.

	[V8] Move DOM wrapper functions in V8Proxy to V8DOMWrapper
	https://bugs.webkit.org/show_bug.cgi?id=27107

	This patch is just renaming.  Code motion will occur next.

	* bindings/scripts/CodeGeneratorV8.pm:
	* bindings/v8/ScriptController.cpp:
	(WebCore::ScriptController::processingUserGesture):
	(WebCore::createScriptObject):
	(WebCore::ScriptController::createScriptObjectForPluginElement):
	* bindings/v8/ScriptObject.cpp:
	(WebCore::ScriptGlobalObject::set):
	* bindings/v8/ScriptObjectQuarantine.cpp:
	(WebCore::getQuarantinedScriptObject):
	* bindings/v8/V8AbstractEventListener.cpp:
	(WebCore::V8AbstractEventListener::handleEvent):
	(WebCore::V8AbstractEventListener::getReceiverObject):
	* bindings/v8/V8Collection.cpp:
	(WebCore::toOptionsCollectionSetter):
	* bindings/v8/V8Collection.h:
	(WebCore::getV8Object):
	(WebCore::getNamedPropertyOfCollection):
	(WebCore::nodeCollectionNamedPropertyGetter):
	(WebCore::getIndexedPropertyOfCollection):
	(WebCore::nodeCollectionIndexedPropertyGetter):
	(WebCore::nodeCollectionIndexedPropertyEnumerator):
	(WebCore::collectionIndexedPropertyEnumerator):
	(WebCore::collectionStringOrNullIndexedPropertyGetter):
	* bindings/v8/V8DOMMap.cpp:
	(WebCore::DOMData::handleWeakObject):
	(WebCore::DOMData::removeObjectsFromWrapperMap):
	* bindings/v8/V8GCController.cpp:
	(WebCore::enumerateDOMObjectMap):
	(WebCore::DOMObjectVisitor::visitDOMWrapper):
	(WebCore::GCPrologueVisitor::visitDOMWrapper):
	(WebCore::GCEpilogueVisitor::visitDOMWrapper):
	* bindings/v8/V8Helpers.cpp:
	(WebCore::wrapNPObject):
	* bindings/v8/V8NodeFilterCondition.cpp:
	(WebCore::V8NodeFilterCondition::acceptNode):
	* bindings/v8/V8Proxy.cpp:
	(WebCore::V8DOMWrapper::convertSVGElementInstanceToV8Object):
	(WebCore::V8DOMWrapper::convertSVGObjectWithContextToV8Object):
	(WebCore::V8DOMWrapper::domObjectHasJSWrapper):
	(WebCore::V8DOMWrapper::setJSWrapperForDOMObject):
	(WebCore::V8DOMWrapper::setJSWrapperForActiveDOMObject):
	(WebCore::V8DOMWrapper::setJSWrapperForDOMNode):
	(WebCore::V8Proxy::evaluateInNewContext):
	(WebCore::V8Proxy::getConstructor):
	(WebCore::V8DOMWrapper::getTemplate):
	(WebCore::V8Proxy::retrieveWindow):
	(WebCore::V8Proxy::updateDocumentWrapperCache):
	(WebCore::V8Proxy::clearForNavigation):
	(WebCore::V8Proxy::installDOMWindow):
	(WebCore::setDOMExceptionHelper):
	(WebCore::V8DOMWrapper::convertToV8Object):
	(WebCore::V8DOMWrapper::setHiddenWindowReference):
	(WebCore::V8DOMWrapper::domWrapperType):
	(WebCore::V8DOMWrapper::convertToNativeObjectImpl):
	(WebCore::V8DOMWrapper::convertToSVGPODTypeImpl):
	(WebCore::V8DOMWrapper::lookupDOMWrapper):
	(WebCore::V8DOMWrapper::convertDOMWrapperToNodeHelper):
	(WebCore::V8DOMWrapper::wrapNativeNodeFilter):
	(WebCore::V8DOMWrapper::instantiateV8Object):
	(WebCore::V8DOMWrapper::setDOMWrapper):
	(WebCore::V8DOMWrapper::maybeDOMWrapper):
	(WebCore::V8DOMWrapper::isDOMEventWrapper):
	(WebCore::V8DOMWrapper::isWrapperOfType):
	(WebCore::V8DOMWrapper::htmlElementType):
	(WebCore::V8DOMWrapper::svgElementType):
	(WebCore::V8DOMWrapper::convertEventToV8Object):
	(WebCore::V8DOMWrapper::convertNodeToV8Object):
	(WebCore::V8DOMWrapper::convertEventTargetToV8Object):
	(WebCore::V8DOMWrapper::convertEventListenerToV8Object):
	(WebCore::V8DOMWrapper::convertDOMImplementationToV8Object):
	(WebCore::V8DOMWrapper::convertStyleSheetToV8Object):
	(WebCore::V8DOMWrapper::convertCSSValueToV8Object):
	(WebCore::V8DOMWrapper::convertCSSRuleToV8Object):
	(WebCore::V8DOMWrapper::convertWindowToV8Object):
	(WebCore::V8Proxy::bindJsObjectToWindow):
	* bindings/v8/V8Proxy.h:
	(WebCore::V8DOMWrapper::convertDOMWrapperToNative):
	(WebCore::V8DOMWrapper::wrapCPointer):
	(WebCore::V8DOMWrapper::extractCPointer):
	(WebCore::V8DOMWrapper::convertDOMWrapperToNode):
	(WebCore::V8DOMWrapper::convertToV8Object):
	(WebCore::V8DOMWrapper::convertToNativeObject):
	(WebCore::V8DOMWrapper::convertToNativeEvent):
	(WebCore::V8DOMWrapper::extractCPointerImpl):
	(WebCore::V8DOMWrapper::instantiateV8Object):
	(WebCore::V8Proxy::constructDOMObject):
	(WebCore::toV8):
	* bindings/v8/V8SVGPODTypeWrapper.h:
	(WebCore::V8SVGPODTypeUtil::toSVGPODType):
	* bindings/v8/WorkerContextExecutionProxy.cpp:
	(WebCore::WorkerContextExecutionProxy::retrieve):
	(WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
	(WebCore::WorkerContextExecutionProxy::GetConstructor):
	(WebCore::WorkerContextExecutionProxy::ToV8Object):
	(WebCore::WorkerContextExecutionProxy::EventToV8Object):
	(WebCore::WorkerContextExecutionProxy::toV8):
	* bindings/v8/custom/V8AttrCustom.cpp:
	(WebCore::ACCESSOR_SETTER):
	* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::NAMED_PROPERTY_SETTER):
	* bindings/v8/custom/V8CanvasPixelArrayCustom.cpp:
	(WebCore::INDEXED_PROPERTY_GETTER):
	(WebCore::INDEXED_PROPERTY_SETTER):
	* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
	(WebCore::toV8):
	(WebCore::toCanvasStyle):
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8ClientRectListCustom.cpp:
	(WebCore::INDEXED_PROPERTY_GETTER):
	* bindings/v8/custom/V8ClipboardCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8CustomBinding.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::INDEXED_ACCESS_CHECK):
	(WebCore::NAMED_ACCESS_CHECK):
	(WebCore::V8Custom::GetTargetFrame):
	* bindings/v8/custom/V8CustomSQLStatementCallback.cpp:
	(WebCore::V8CustomSQLStatementCallback::handleEvent):
	* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
	(WebCore::V8CustomSQLStatementErrorCallback::handleEvent):
	* bindings/v8/custom/V8CustomSQLTransactionCallback.cpp:
	(WebCore::V8CustomSQLTransactionCallback::handleEvent):
	* bindings/v8/custom/V8CustomSQLTransactionErrorCallback.cpp:
	(WebCore::V8CustomSQLTransactionErrorCallback::handleEvent):
	* bindings/v8/custom/V8DOMWindowCustom.cpp:
	(WebCore::V8Custom::WindowSetTimeoutImpl):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::ACCESSOR_GETTER):
	(WebCore::INDEXED_PROPERTY_GETTER):
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::V8Custom::ClearTimeoutImpl):
	(WebCore::NAMED_ACCESS_CHECK):
	(WebCore::INDEXED_ACCESS_CHECK):
	* bindings/v8/custom/V8DatabaseCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8DocumentCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8DocumentLocationCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	* bindings/v8/custom/V8ElementCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::ACCESSOR_GETTER):
	* bindings/v8/custom/V8EventCustom.cpp:
	(WebCore::ACCESSOR_SETTER):
	(WebCore::ACCESSOR_GETTER):
	* bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLCollectionCustom.cpp:
	(WebCore::getNamedItems):
	(WebCore::getItem):
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::ACCESSOR_GETTER):
	* bindings/v8/custom/V8HTMLFormElementCustom.cpp:
	(WebCore::INDEXED_PROPERTY_GETTER):
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLFrameElementCustom.cpp:
	(WebCore::ACCESSOR_SETTER):
	* bindings/v8/custom/V8HTMLFrameSetElementCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	* bindings/v8/custom/V8HTMLIFrameElementCustom.cpp:
	(WebCore::ACCESSOR_SETTER):
	* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::INDEXED_PROPERTY_GETTER):
	(WebCore::INDEXED_PROPERTY_SETTER):
	* bindings/v8/custom/V8HTMLPlugInElementCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::NAMED_PROPERTY_SETTER):
	(WebCore::INDEXED_PROPERTY_GETTER):
	(WebCore::INDEXED_PROPERTY_SETTER):
	* bindings/v8/custom/V8HTMLSelectElementCollectionCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	(WebCore::INDEXED_PROPERTY_SETTER):
	* bindings/v8/custom/V8HTMLSelectElementCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::removeElement):
	* bindings/v8/custom/V8InspectorControllerCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8LocationCustom.cpp:
	(WebCore::ACCESSOR_SETTER):
	(WebCore::ACCESSOR_GETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::INDEXED_ACCESS_CHECK):
	(WebCore::NAMED_ACCESS_CHECK):
	* bindings/v8/custom/V8MessageChannelConstructor.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8MessagePortCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8NamedNodeMapCustom.cpp:
	(WebCore::INDEXED_PROPERTY_GETTER):
	(WebCore::NAMED_PROPERTY_GETTER):
	* bindings/v8/custom/V8NavigatorCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	* bindings/v8/custom/V8NodeCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8NodeIteratorCustom.cpp:
	(WebCore::toV8):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8NodeListCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8SQLTransactionCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8SVGLengthCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8SVGMatrixCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8StorageCustom.cpp:
	(WebCore::V8Custom::v8StorageNamedPropertyEnumerator):
	(WebCore::storageGetter):
	(WebCore::storageSetter):
	(WebCore::storageDeleter):
	* bindings/v8/custom/V8StyleSheetListCustom.cpp:
	(WebCore::NAMED_PROPERTY_GETTER):
	* bindings/v8/custom/V8TreeWalkerCustom.cpp:
	(WebCore::toV8):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8WorkerContextCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::SetTimeoutOrInterval):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8WorkerCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	* bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:
	(WebCore::ACCESSOR_GETTER):
	(WebCore::ACCESSOR_SETTER):
	(WebCore::CALLBACK_FUNC_DECL):
	* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
	(WebCore::CALLBACK_FUNC_DECL):



git-svn-id: http://svn.webkit.org/repository/webkit/trunk at 45659
268f45cc-cd09-0410-ab3c-d52691b4dbfc
---
 72 files changed, 903 insertions(+), 613 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 00:53:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 00:53:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27108] Crash with
 fast/loader/frame-creation-removal.html : [Attachment 32505] 2009-07-08
 Adam Barth <abarth@webkit.org>
In-Reply-To: <bug-27108-0@https.bugs.webkit.org/>
References: <bug-27108-0@https.bugs.webkit.org/>
Message-ID: <20090709075353.E416A32642DD@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27108: Crash with fast/loader/frame-creation-removal.html
https://bugs.webkit.org/show_bug.cgi?id=27108

Attachment 32505: 2009-07-08  Adam Barth  <abarth at webkit.org>
https://bugs.webkit.org/attachment.cgi?id=32505&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Oops, bugzilla-tool caught the wrong commitish :)

From bugzilla-daemon at webkit.org  Thu Jul  9 00:54:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 00:54:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27108] Crash with
 fast/loader/frame-creation-removal.html : [Attachment 32506] WebKit/qt:
In-Reply-To: <bug-27108-0@https.bugs.webkit.org/>
References: <bug-27108-0@https.bugs.webkit.org/>
Message-ID: <20090709075430.3AE183264324@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27108: Crash with fast/loader/frame-creation-removal.html
https://bugs.webkit.org/show_bug.cgi?id=27108

Attachment 32506: WebKit/qt:
https://bugs.webkit.org/attachment.cgi?id=32506&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27108

	Fix crash when in frame tree of a new frame before the new frame
	has been installed in the frame tree, similar to r35088.

	After calling Frame::init() the frame it may have been removed from the
	frame tree again through JavaScript. Detect this by checking the page()
	afterwards.

	* WebCoreSupport/FrameLoaderClientQt.cpp:
	(WebCore::FrameLoaderClientQt::createFrame):

LayoutTests:

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27108

	Remove fast/loader/frame-creation-removal.html from the skip list, it
	passes now.

	* platform/qt/Skipped:
---
 4 files changed, 33 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 00:55:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 00:55:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27109] Some tests in the Qt
 DRT pass and fail randomly,
 depending on whether previous tests used @font-face : [Attachment 32507]
 WebKitTools:
In-Reply-To: <bug-27109-0@https.bugs.webkit.org/>
References: <bug-27109-0@https.bugs.webkit.org/>
Message-ID: <20090709075527.A8D503264380@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27109: Some tests in the Qt DRT pass and fail randomly, depending on
whether previous tests used @font-face
https://bugs.webkit.org/show_bug.cgi?id=27109

Attachment 32507: WebKitTools:
https://bugs.webkit.org/attachment.cgi?id=32507&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27109

	Fix side-effects in the Qt DRT with tests using application fonts.

	Detect if a test used application fonts and re-initialize the
fontconfig
	application fontset accordingly.

	* DumpRenderTree/qt/DumpRenderTree.cpp:
	(WebCore::DumpRenderTree::open): call initializeFonts and remove all
application fonts
	after running a testcase.
	(WebCore::DumpRenderTree::initializeFonts): Moved fontconfig
initialization code
	here from main.
	* DumpRenderTree/qt/DumpRenderTree.h: Declare initializeFonts.
	* DumpRenderTree/qt/main.cpp:
	(main): Moved fontconfig initialization code to DRT::initializeFonts.

LayoutTests:

2009-07-08  Simon Hausmann  <hausmann at webkit.org>

	Reviewed by NOBODY (OOPS!).

	https://bugs.webkit.org/show_bug.cgi?id=27109

	Remove various tests from the Qt skip list that previously failed
	due to DRT side-effects.

	* platform/qt/Skipped:
---
 6 files changed, 85 insertions(+), 34 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 03:08:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 03:08:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32509] Add cpplint w/ some autofix
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090709100859.A028432677CF@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32509: Add cpplint w/ some autofix
https://bugs.webkit.org/attachment.cgi?id=32509&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
As most common kinds of lint errors seem to be trivial ones, I implemented
autofix feature for most common 10 kinds of warnings. I applied the tool for
some components in WebCore (css, dom, editing, rendering, history, storage,
html, svg, wml, inspector, workers, xml, and page) and it seems to be working
good. It found 298 lint errors and fixed 247 of them automatically. There were
no false-positives in the 247 error (if my investigation on the git-diff was
correct).

From bugzilla-daemon at webkit.org  Thu Jul  9 03:08:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 03:08:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32439] Add cpplint
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090709100859.83EAB32677CA@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32439: Add cpplint
https://bugs.webkit.org/attachment.cgi?id=32439&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
As most common kinds of lint errors seem to be trivial ones, I implemented
autofix feature for most common 10 kinds of warnings. I applied the tool for
some components in WebCore (css, dom, editing, rendering, history, storage,
html, svg, wml, inspector, workers, xml, and page) and it seems to be working
good. It found 298 lint errors and fixed 247 of them automatically. There were
no false-positives in the 247 error (if my investigation on the git-diff was
correct).

From bugzilla-daemon at webkit.org  Thu Jul  9 03:16:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 03:16:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32510] Autofix for lint errors
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090709101618.1DED63267AC5@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32510: Autofix for lint errors
https://bugs.webkit.org/attachment.cgi?id=32510&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 04:05:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 04:05:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 12195] XMLHttpRequest
 should raise SYNTAX_ERR when a parameter doesn't match HTTP syntax :
 [Attachment 32511] Fix for open()
In-Reply-To: <bug-12195-0@https.bugs.webkit.org/>
References: <bug-12195-0@https.bugs.webkit.org/>
Message-ID: <20090709110549.BFDB53268F34@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 12195: XMLHttpRequest should raise SYNTAX_ERR when a parameter doesn't
match HTTP syntax
https://bugs.webkit.org/show_bug.cgi?id=12195

Attachment 32511: Fix for open()
https://bugs.webkit.org/attachment.cgi?id=32511&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Hi, I've attached a patch to partially fix (i.e., only for open() ) this issue.


Can you take a look?

Yuzo

From bugzilla-daemon at webkit.org  Thu Jul  9 04:58:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 04:58:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27112] Crash in
 v8::internal::Context::global_context() : [Attachment 32512] Enter the
 frame's context before creating new objects.
In-Reply-To: <bug-27112-0@https.bugs.webkit.org/>
References: <bug-27112-0@https.bugs.webkit.org/>
Message-ID: <20090709115838.2EE5E326A689@gamma.macosforge.org>

Yury Semikhatsky <yurys at chromium.org> has asked Mads Ager <ager at chromium.org>
for review:
Bug 27112: Crash in v8::internal::Context::global_context()
https://bugs.webkit.org/show_bug.cgi?id=27112

Attachment 32512: Enter the frame's context before creating new objects.
https://bugs.webkit.org/attachment.cgi?id=32512&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 05:46:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 05:46:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27114] bugzilla-tool: Parse
 short bug URL from commit log messages : [Attachment 32513] Patch v1
In-Reply-To: <bug-27114-0@https.bugs.webkit.org/>
References: <bug-27114-0@https.bugs.webkit.org/>
Message-ID: <20090709124608.F3D8B326B95B@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27114: bugzilla-tool: Parse short bug URL from commit log messages
https://bugs.webkit.org/show_bug.cgi?id=27114

Attachment 32513: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32513&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

* Scripts/bugzilla-tool:
(bug_id_from_commit_message): Check for the short bug URL before
checking for the longer bugs.webkit.org URL.
---
 2 files changed, 16 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 05:50:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 05:50:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27115] bugzilla-tool:
 extract duplicate logging methods into a module : [Attachment 32514] Patch
 v1
In-Reply-To: <bug-27115-0@https.bugs.webkit.org/>
References: <bug-27115-0@https.bugs.webkit.org/>
Message-ID: <20090709125057.891C5326BB27@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27115: bugzilla-tool: extract duplicate logging methods into a module
https://bugs.webkit.org/show_bug.cgi?id=27115

Attachment 32514: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32514&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

* Scripts/bugzilla-tool: Removed error() and log() methods and
added import of new logging module.
* Scripts/modules/bugzilla.py: Ditto.  Removed "import sys".
* Scripts/modules/scm.py: Ditto.

* Scripts/modules/logging.py: Added.
(log): Added.
(error): Added.  Prefix error messages with "ERROR: ".
---
 5 files changed, 60 insertions(+), 22 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 07:03:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 07:03:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 12195] XMLHttpRequest should
 raise SYNTAX_ERR when a parameter doesn't match HTTP syntax : [Attachment
 32511] Fix for open()
In-Reply-To: <bug-12195-0@https.bugs.webkit.org/>
References: <bug-12195-0@https.bugs.webkit.org/>
Message-ID: <20090709140313.8E09E326D906@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has denied Yuzo Fujishima
<yuzo at google.com>'s request for review:
Bug 12195: XMLHttpRequest should raise SYNTAX_ERR when a parameter doesn't
match HTTP syntax
https://bugs.webkit.org/show_bug.cgi?id=12195

Attachment 32511: Fix for open()
https://bugs.webkit.org/attachment.cgi?id=32511&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This patch doesn't fix anything that was mentioned in the bug description -
please open a new bug to discuss your proposed change. Besides, I don't see
where the spec requires open() to raise an exception if the URL is invalid -
see <http://dev.w3.org/2006/webapi/XMLHttpRequest-2/#the-open-method>.

fast/js is not a good place for the test - this directory is for JavaScriptCore
tests. Please use fast/xmlhttprequest or http/tests/xmlhttprequest.

From bugzilla-daemon at webkit.org  Thu Jul  9 07:35:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 07:35:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27117] bugzilla-tool: use
 Mac OS X keychain for authentication : [Attachment 32517] Patch v1
In-Reply-To: <bug-27117-0@https.bugs.webkit.org/>
References: <bug-27117-0@https.bugs.webkit.org/>
Message-ID: <20090709143556.0FBE3326E7FB@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27117: bugzilla-tool: use Mac OS X keychain for authentication
https://bugs.webkit.org/show_bug.cgi?id=27117

Attachment 32517: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32517&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

Try reading credentials from git config first, then keychain if
running on Mac OS X, else prompt at the command-line.

* Scripts/modules/bugzilla.py: Added "import platform".
(credentials_from_git): Added.
(credentials_from_keychain): Added.
(is_mac_os_x): Added.
(read_credentials): Added.
(Bugzilla.__init__): Moved instance attribute bug_server to a
static attribute named bug-server_url.
(Bugzilla.bug_server_host): Added.  Extracted host name from
bug_server_url.
(Bugzilla.bug_server_regex): Updated to be created using
bug_server_host.
(Bugzilla.bug_server_url): Renamed from bug_server.
(Bugzilla.bug_url_for_bug_id): Updated for renaming of
bug_server to bug_server_url.
(Bugzilla.attachment_url_for_id): Ditto.
(Bugzilla.fetch_bug_ids_from_commit_queue): Ditto.
(Bugzilla.authenticate): Ditto.  Updated to use
read_credentials().
(Bugzilla.add_patch_to_bug): Ditto.
---
 2 files changed, 88 insertions(+), 19 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 07:54:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 07:54:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 32518] Patch v1
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090709145429.B913C326EFB5@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 32518: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32518&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

Initial pass at a "create-bug" command for bugzilla-tool.  This
version only works with local git commits since that was the
immediate need.

* Scripts/bugzilla-tool: Added CreateBugWithPatch class.
(CreateBugWithPatch.__init__): Added.
(CreateBugWithPatch.execute): Added.
(BugzillaTool.__init__): Added create-bug command.
* Scripts/modules/bugzilla.py:
(Bugzilla.prompt_for_component): Added.
(Bugzilla.create_bug_with_patch): Added.
---
 3 files changed, 101 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 08:18:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 08:18:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25205] XMLHttpRequest instance
 is not an instanceof XMLHttpRequest : [Attachment 32499]
 DOMConstructorObject approach.
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090709151821.3CF36326F97C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32499: DOMConstructorObject approach.
https://bugs.webkit.org/attachment.cgi?id=32499&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#ifndef NDEBUG
> +	   virtual ~DOMConstructorObject();
> +#endif

What's the idea here? I don't see any definition of this destructor, so it
seems like the change won't link. Have you tested yet?

Otherwise, everything looks great!

From bugzilla-daemon at webkit.org  Thu Jul  9 08:34:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 08:34:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32510] Autofix for lint errors
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090709153408.CE8E8326FFFE@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32510: Autofix for lint errors
https://bugs.webkit.org/attachment.cgi?id=32510&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the review! For now, I've modified the issues by hand. I'll fix the
linter so that it won't produce this kinds of false positves.

From bugzilla-daemon at webkit.org  Thu Jul  9 08:34:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 08:34:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32519] Autofix for lint errors v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090709153409.274073270002@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32519: Autofix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32519&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Thanks for the review! For now, I've modified the issues by hand. I'll fix the
linter so that it won't produce this kinds of false positves.

From bugzilla-daemon at webkit.org  Thu Jul  9 08:44:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 08:44:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27112] Crash in
 v8::internal::Context::global_context() : [Attachment 32512] Enter the
 frame's context before creating new objects.
In-Reply-To: <bug-27112-0@https.bugs.webkit.org/>
References: <bug-27112-0@https.bugs.webkit.org/>
Message-ID: <20090709154428.633A9327043E@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Yury Semikhatsky
<yurys at chromium.org>'s request for review:
Bug 27112: Crash in v8::internal::Context::global_context()
https://bugs.webkit.org/show_bug.cgi?id=27112

Attachment 32512: Enter the frame's context before creating new objects.
https://bugs.webkit.org/attachment.cgi?id=32512&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me.

From bugzilla-daemon at webkit.org  Thu Jul  9 09:02:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 09:02:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27114] bugzilla-tool: Parse
 short bug URL from commit log messages : [Attachment 32513] Patch v1
In-Reply-To: <bug-27114-0@https.bugs.webkit.org/>
References: <bug-27114-0@https.bugs.webkit.org/>
Message-ID: <20090709160253.8D5D33270C68@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27114: bugzilla-tool: Parse short bug URL from commit log messages
https://bugs.webkit.org/show_bug.cgi?id=27114

Attachment 32513: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32513&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I didn't even know we had these short URLs!

r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 09:20:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 09:20:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27087] Add New Configuration
 Flag for Redistributable Windows Build : [Attachment 32465] Add
 WIN_REDISTRIBUTABLE flag for builds
In-Reply-To: <bug-27087-0@https.bugs.webkit.org/>
References: <bug-27087-0@https.bugs.webkit.org/>
Message-ID: <20090709162004.8C11E3271314@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 27087: Add New Configuration Flag for Redistributable Windows Build
https://bugs.webkit.org/show_bug.cgi?id=27087

Attachment 32465: Add WIN_REDISTRIBUTABLE flag for builds
https://bugs.webkit.org/attachment.cgi?id=32465&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   * WebCore.vcproj/WebCore.vcproj: Define WIN_REDISTRIBUTABLE for
> +	     the Release_Cairo and Debug_Cairo targets.

I think it would be better to make a WebCoreRedistributable.vsprops file and
put the definition in there. We want to keep as much stuff out of the .vcproj
as possible!

The other code changes look fine. I'm not so sure about the WIN_REDISTRIBUTABLE
name, though. It seems a bit too vague (not that the existing "WIN" name is any
better!). Maybe we need a more "marketing-ish" name for this port?

From bugzilla-daemon at webkit.org  Thu Jul  9 09:32:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 09:32:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27115] bugzilla-tool: extract
 duplicate logging methods into a module : [Attachment 32514] Patch v1
In-Reply-To: <bug-27115-0@https.bugs.webkit.org/>
References: <bug-27115-0@https.bugs.webkit.org/>
Message-ID: <20090709163259.937A03271809@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27115: bugzilla-tool: extract duplicate logging methods into a module
https://bugs.webkit.org/show_bug.cgi?id=27115

Attachment 32514: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32514&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I'm no Python expert, but this seems reasonable, and I'm sure you followed the
example of the existing code.

r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 09:52:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 09:52:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25406]
 -webkit-box-orient:horizontal doesn't work on <button> tag : [Attachment
 32520] Patch v2
In-Reply-To: <bug-25406-0@https.bugs.webkit.org/>
References: <bug-25406-0@https.bugs.webkit.org/>
Message-ID: <20090709165213.3229C327207C@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25406: -webkit-box-orient:horizontal doesn't work on <button> tag
https://bugs.webkit.org/show_bug.cgi?id=25406

Attachment 32520: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32520&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
As it turned out that box-orient should not be inherited, I modified the first
patch so that the flexible button passes its box-orient to its anonymous child.

From bugzilla-daemon at webkit.org  Thu Jul  9 10:01:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 10:01:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27121] [V8] Move
 V8DOMWrapper to its own file : [Attachment 32521] patch (code motion only)
In-Reply-To: <bug-27121-0@https.bugs.webkit.org/>
References: <bug-27121-0@https.bugs.webkit.org/>
Message-ID: <20090709170115.06BB6327245E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27121: [V8] Move V8DOMWrapper to its own file
https://bugs.webkit.org/show_bug.cgi?id=27121

Attachment 32521: patch (code motion only)
https://bugs.webkit.org/attachment.cgi?id=32521&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 10:08:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 10:08:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27121] [V8] Move V8DOMWrapper
 to its own file : [Attachment 32521] patch (code motion only)
In-Reply-To: <bug-27121-0@https.bugs.webkit.org/>
References: <bug-27121-0@https.bugs.webkit.org/>
Message-ID: <20090709170855.765343272738@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27121: [V8] Move V8DOMWrapper to its own file
https://bugs.webkit.org/show_bug.cgi?id=27121

Attachment 32521: patch (code motion only)
https://bugs.webkit.org/attachment.cgi?id=32521&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 10:27:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 10:27:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27122] prepare-ChangeLog
 should decode HTML entities in short description : [Attachment 32522] Patch
 v1
In-Reply-To: <bug-27122-0@https.bugs.webkit.org/>
References: <bug-27122-0@https.bugs.webkit.org/>
Message-ID: <20090709172704.ACBDD3272EF8@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27122: prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Attachment 32522: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32522&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 10:43:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 10:43:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26903] Need to enable
 CHANNEL_MESSAGING by default : [Attachment 32523] Patch with enabled
 security test and removing merge conflict.
In-Reply-To: <bug-26903-0@https.bugs.webkit.org/>
References: <bug-26903-0@https.bugs.webkit.org/>
Message-ID: <20090709174332.0725632735EC@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32523: Patch with enabled security test and removing merge conflict.
https://bugs.webkit.org/attachment.cgi?id=32523&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Sigh, fixed merge errors - tragically git didn't notice that I'd committed a
file with a merge conflict.

I enabled that test - as I mentioned on IRC, you can no longer use a
MessageChannel constructor from a closed frame, so now I simplified the test to
just check for a thrown exception.

I was able to build on Windows just fine - what files were you concerned were
missing from the vcproj file?

From bugzilla-daemon at webkit.org  Thu Jul  9 11:20:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 11:20:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27123] Full page zoom
 breaks remaining and elapsed time display in the <video> controller. :
 [Attachment 32524] patch v1.
In-Reply-To: <bug-27123-0@https.bugs.webkit.org/>
References: <bug-27123-0@https.bugs.webkit.org/>
Message-ID: <20090709182001.A92D53274606@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27123: Full page zoom breaks remaining and elapsed time display in the
<video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

Attachment 32524: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32524&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 12:16:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:16:03 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32385]
 Removing forgotten line from ChangeLog
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090709191603.8E6853275C7B@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has canceled anton muhin
<antonm at chromium.org>'s request for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32385: Removing forgotten line from ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32385&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Mads, thanks a lot for another round!

I'd easily remove ASSERT---I do agree it fishy---I just wanted to keep it
closer to the original version.  So if you repeat it again, next patch would be
w/o ASSERT :)  For now I'm just putting boolean generation under proper
condition.

From bugzilla-daemon at webkit.org  Thu Jul  9 12:16:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:16:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32525]
 Do not generate long boolen expression unless ASSERTs enabled
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090709191603.9B6743275C7D@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32525: Do not generate long boolen expression unless ASSERTs enabled
https://bugs.webkit.org/attachment.cgi?id=32525&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Mads, thanks a lot for another round!

I'd easily remove ASSERT---I do agree it fishy---I just wanted to keep it
closer to the original version.  So if you repeat it again, next patch would be
w/o ASSERT :)  For now I'm just putting boolean generation under proper
condition.

From bugzilla-daemon at webkit.org  Thu Jul  9 12:34:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:34:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27123] Full page zoom breaks
 remaining and elapsed time display in the <video> controller. : [Attachment
 32524] patch v1.
In-Reply-To: <bug-27123-0@https.bugs.webkit.org/>
References: <bug-27123-0@https.bugs.webkit.org/>
Message-ID: <20090709193439.5D6FD3276469@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27123: Full page zoom breaks remaining and elapsed time display in the
<video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

Attachment 32524: patch v1.
https://bugs.webkit.org/attachment.cgi?id=32524&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

>	      Full page zoom breaks remaining and elapsed time display in the
&lt;video&gt; controller.

No need to escape the <>


> +    PassRefPtr<RenderStyle> style = styleForElement();
>      if (!style)
>	   return;

This should be a RefPtr.

>  
> @@ -258,7 +258,7 @@ void MediaControlInputElement::update()
>      updateStyle();
>  }
>  
> -RenderStyle* MediaControlInputElement::styleForElement()
> +PassRefPtr<RenderStyle> MediaControlInputElement::styleForElement()
>  {
>      return
m_mediaElement->renderer()->getCachedPseudoStyle(m_pseudoStyleId);
>  }

No need to change return type>

> @@ -270,17 +270,17 @@ bool
MediaControlInputElement::rendererIsNeeded(RenderStyle* style)
>  
>  void MediaControlInputElement::attach()
>  {
> -    RenderStyle* style = styleForElement();
> +    PassRefPtr<RenderStyle> style = styleForElement();

This should be a RefPtr

>  void MediaControlTimeDisplayElement::setVisible(bool visible)
>  {
> +    // This function is used during the RenderMedia::layout()
> +    // call, where we cannot change the renderer at this time.

> +    if (visible == m_isVisible)
> +	   return;
> +    m_isVisible = visible;
> +    RefPtr<RenderStyle> style = styleForElement();
> +    renderer()->setStyle(style.get());

But you are changing style here, which is not really a good thing to do.

From bugzilla-daemon at webkit.org  Thu Jul  9 12:44:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:44:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27127] Upstream fixes to
 NPV8Object.cpp that make ~30 layout tests pass. : [Attachment 32526] Fixes
 for NPV8Object.cpp
In-Reply-To: <bug-27127-0@https.bugs.webkit.org/>
References: <bug-27127-0@https.bugs.webkit.org/>
Message-ID: <20090709194400.2DF19327688B@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27127: Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
https://bugs.webkit.org/show_bug.cgi?id=27127

Attachment 32526: Fixes for NPV8Object.cpp
https://bugs.webkit.org/attachment.cgi?id=32526&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 12:47:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:47:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27122] prepare-ChangeLog
 should decode HTML entities in short description : [Attachment 32522] Patch
 v1
In-Reply-To: <bug-27122-0@https.bugs.webkit.org/>
References: <bug-27122-0@https.bugs.webkit.org/>
Message-ID: <20090709194743.606BC32769F7@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27122: prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Attachment 32522: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32522&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 12:47:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:47:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27122] prepare-ChangeLog
 should decode HTML entities in short description : [Attachment 32527] Patch
 v2
In-Reply-To: <bug-27122-0@https.bugs.webkit.org/>
References: <bug-27122-0@https.bugs.webkit.org/>
Message-ID: <20090709194743.7882432769FB@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27122: prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Attachment 32527: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32527&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 12:48:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:48:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27127] Upstream fixes to
 NPV8Object.cpp that make ~30 layout tests pass. : [Attachment 32526] Fixes
 for NPV8Object.cpp
In-Reply-To: <bug-27127-0@https.bugs.webkit.org/>
References: <bug-27127-0@https.bugs.webkit.org/>
Message-ID: <20090709194848.DD0A63276A75@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27127: Upstream fixes to NPV8Object.cpp that make ~30 layout tests pass.
https://bugs.webkit.org/show_bug.cgi?id=27127

Attachment 32526: Fixes for NPV8Object.cpp
https://bugs.webkit.org/attachment.cgi?id=32526&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 12:54:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 12:54:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27103] Upstream V8NPObject.h
 and V8NPObject.cpp : [Attachment 32488] Patch with V8NPObject.h,
 V8NPObject.cpp,
 plus fixes to other files that reference the old filename/function names.
In-Reply-To: <bug-27103-0@https.bugs.webkit.org/>
References: <bug-27103-0@https.bugs.webkit.org/>
Message-ID: <20090709195435.D45C03276D19@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103

Attachment 32488: Patch with V8NPObject.h, V8NPObject.cpp, plus fixes to other
files that reference the old filename/function names.
https://bugs.webkit.org/attachment.cgi?id=32488&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Thanks for doing this! Just two minor style nits:

> +enum InvokeFunctionType {
> +    INVOKE_METHOD = 1,
> +    INVOKE_CONSTRUCT = 2,
> +    INVOKE_DEFAULT = 3
> +};

InvokeError, etc.

> +    return v8::Local<v8::Value>(); // Do not intercept the call.

return notHandledByInterceptor();

From bugzilla-daemon at webkit.org  Thu Jul  9 13:03:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:03:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27122] prepare-ChangeLog
 should decode HTML entities in short description : [Attachment 32528] Patch
 v3
In-Reply-To: <bug-27122-0@https.bugs.webkit.org/>
References: <bug-27122-0@https.bugs.webkit.org/>
Message-ID: <20090709200327.45C0B3277124@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27122: prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Attachment 32528: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32528&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Oops sorry. I forgot to add function declaration for decodeEntities.

From bugzilla-daemon at webkit.org  Thu Jul  9 13:03:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:03:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27122] prepare-ChangeLog
 should decode HTML entities in short description : [Attachment 32527] Patch
 v2
In-Reply-To: <bug-27122-0@https.bugs.webkit.org/>
References: <bug-27122-0@https.bugs.webkit.org/>
Message-ID: <20090709200327.2DE4B3277120@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27122: prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Attachment 32527: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32527&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Oops sorry. I forgot to add function declaration for decodeEntities.

From bugzilla-daemon at webkit.org  Thu Jul  9 13:08:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:08:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32519] Autofix for lint errors v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090709200842.0AE0A3277399@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32519: Autofix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32519&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me  Thanks!

From bugzilla-daemon at webkit.org  Thu Jul  9 13:10:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:10:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27106] [Chromium] Linux:
 render disabled checkboxes and radio controls as disabled : [Attachment
 32498] patch
In-Reply-To: <bug-27106-0@https.bugs.webkit.org/>
References: <bug-27106-0@https.bugs.webkit.org/>
Message-ID: <20090709201024.B594A327745D@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Langley
<agl at chromium.org>'s request for review:
Bug 27106: [Chromium] Linux: render disabled checkboxes and radio controls as
disabled
https://bugs.webkit.org/show_bug.cgi?id=27106

Attachment 32498: patch
https://bugs.webkit.org/attachment.cgi?id=32498&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 13:37:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:37:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27128] Make Widget
 Ref-Counted. : [Attachment 32530] Patch
In-Reply-To: <bug-27128-0@https.bugs.webkit.org/>
References: <bug-27128-0@https.bugs.webkit.org/>
Message-ID: <20090709203730.B1CA332780AA@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 27128: Make Widget Ref-Counted.
https://bugs.webkit.org/show_bug.cgi?id=27128

Attachment 32530: Patch
https://bugs.webkit.org/attachment.cgi?id=32530&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 13:41:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:41:50 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 20625] ConsoleMessage should
 have a "type" attribute : [Attachment 32504] forgot to write WebKit
 ChangeLog
In-Reply-To: <bug-20625-0@https.bugs.webkit.org/>
References: <bug-20625-0@https.bugs.webkit.org/>
Message-ID: <20090709204150.2A31F3278291@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 20625: ConsoleMessage should have a "type" attribute
https://bugs.webkit.org/show_bug.cgi?id=20625

Attachment 32504: forgot to write WebKit ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32504&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> -	       case WebInspector.ConsoleMessage.MessageLevel.StartGroup:
> -		   element.addStyleClass("console-group-title-level");
> +	   }
> +	   
> +	   if (this.type ===
WebInspector.ConsoleMessage.MessageType.StartGroup) {
> +	       element.addStyleClass("console-group-title");

Why can't this be in the switch liek before?

> diff --git a/WebCore/workers/GenericWorkerTask.h
b/WebCore/workers/GenericWorkerTask.h
> index 3611fea..d6a9994 100644
> --- a/WebCore/workers/GenericWorkerTask.h
> +++ b/WebCore/workers/GenericWorkerTask.h
> @@ -328,6 +328,56 @@ namespace WebCore {
>	   P6 m_parameter6;
>	   P7 m_parameter7;
>      };
> +    
> +    template<typename P1, typename MP1, typename P2, typename MP2, typename
P3, typename MP3, typename P4, typename MP4, typename P5, typename MP5,
typename P6, typename MP6, typename P7, typename MP7, typename P8, typename
MP8>
> +    class GenericWorkerTask8 : public ScriptExecutionContext::Task {
> +    public:
> +	   typedef void (*Method)(ScriptExecutionContext*, MP1, MP2, MP3, MP4,
MP5, MP6, MP7, MP8);
> +	   typedef GenericWorkerTask8<P1, MP1, P2, MP2, P3, MP3, P4, MP4, P5,
MP5, P6, MP6, P7, MP7, P8, MP8> GenericWorkerTask;
> +	   typedef typename GenericWorkerTaskTraits<P1>::ParamType Param1;
> +	   typedef typename GenericWorkerTaskTraits<P2>::ParamType Param2;
> +	   typedef typename GenericWorkerTaskTraits<P3>::ParamType Param3;
> +	   typedef typename GenericWorkerTaskTraits<P4>::ParamType Param4;
> +	   typedef typename GenericWorkerTaskTraits<P5>::ParamType Param5;
> +	   typedef typename GenericWorkerTaskTraits<P6>::ParamType Param6;
> +	   typedef typename GenericWorkerTaskTraits<P7>::ParamType Param7;
> +	   typedef typename GenericWorkerTaskTraits<P8>::ParamType Param8;
> +	   
> +	   static PassRefPtr<GenericWorkerTask> create(Method method, Param1
parameter1, Param2 parameter2, Param3 parameter3, Param4 parameter4, Param5
parameter5, Param6 parameter6, Param7 parameter7, Param8 parameter8)
> +	   {
> +	       return adoptRef(new GenericWorkerTask(method, parameter1,
parameter2, parameter3, parameter4, parameter5, parameter6, parameter7,
parameter8));
> +	   }
> +	   
> +    private:
> +	   GenericWorkerTask8(Method method, Param1 parameter1, Param2
parameter2, Param3 parameter3, Param4 parameter4, Param5 parameter5, Param6
parameter6, Param7 parameter7, Param8 parameter8)
> +	   : m_method(method)
> +	   , m_parameter1(parameter1)
> +	   , m_parameter2(parameter2)
> +	   , m_parameter3(parameter3)
> +	   , m_parameter4(parameter4)
> +	   , m_parameter5(parameter5)
> +	   , m_parameter6(parameter6)
> +	   , m_parameter7(parameter7)
> +	   , m_parameter8(parameter8)
> +	   {
> +	   }
> +	   
> +	   virtual void performTask(ScriptExecutionContext* context)
> +	   {
> +	       (*m_method)(context, m_parameter1, m_parameter2, m_parameter3,
m_parameter4, m_parameter5, m_parameter6, m_parameter7, m_parameter8);
> +	   }
> +	   
> +    private:
> +	   Method m_method;
> +	   P1 m_parameter1;
> +	   P2 m_parameter2;
> +	   P3 m_parameter3;
> +	   P4 m_parameter4;
> +	   P5 m_parameter5;
> +	   P6 m_parameter6;
> +	   P7 m_parameter7;
> +	   P8 m_parameter8;
> +    };
>  
>      template<typename P1, typename MP1>
>      PassRefPtr<ScriptExecutionContext::Task> createCallbackTask(
> @@ -413,6 +463,21 @@ namespace WebCore {
>		   CrossThreadCopier<P7>::copy(parameter7));
>      }
>  
> +    template<typename P1, typename MP1, typename P2, typename MP2, typename
P3, typename MP3, typename P4, typename MP4, typename P5, typename MP5,
typename P6, typename MP6, typename P7, typename MP7, typename P8, typename
MP8>
> +    PassRefPtr<ScriptExecutionContext::Task> createCallbackTask(
> +								   void
(*method)(ScriptExecutionContext*, MP1, MP2, MP3, MP4, MP5, MP6, MP7, MP8),
> +								   const P1&
parameter1, const P2& parameter2, const P3& parameter3, const P4& parameter4,
const P5& parameter5, const P6& parameter6, const P7& parameter7, const P8&
parameter8)
> +    {
> +	   return GenericWorkerTask8<typename CrossThreadCopier<P1>::Type, MP1,
typename CrossThreadCopier<P2>::Type, MP2, typename
CrossThreadCopier<P3>::Type, MP3,
> +	   typename CrossThreadCopier<P4>::Type, MP4, typename
CrossThreadCopier<P5>::Type, MP5, typename CrossThreadCopier<P6>::Type, MP6,
> +	   typename CrossThreadCopier<P7>::Type, MP7, typename
CrossThreadCopier<P8>::Type, MP8>::create(
> +							      method,
> +							     
CrossThreadCopier<P1>::copy(parameter1),
CrossThreadCopier<P2>::copy(parameter2),
> +							     
CrossThreadCopier<P3>::copy(parameter3),
CrossThreadCopier<P4>::copy(parameter4),
> +							     
CrossThreadCopier<P5>::copy(parameter5),
CrossThreadCopier<P6>::copy(parameter6),
> +							     
CrossThreadCopier<P7>::copy(parameter7),
CrossThreadCopier<P8>::copy(parameter8));
> +    }
> +
>  } // namespace WebCore
>  
>  #endif // ENABLE(WORKERS)

What is up with the change to WebCore/workers/GenericWorkerTask.h? I don't
think that is relivant to this change.

From bugzilla-daemon at webkit.org  Thu Jul  9 13:47:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 13:47:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27128] Make Widget
 Ref-Counted. : [Attachment 32530] Patch
In-Reply-To: <bug-27128-0@https.bugs.webkit.org/>
References: <bug-27128-0@https.bugs.webkit.org/>
Message-ID: <20090709204755.E86AE3278553@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has denied Beth Dakin <bdakin at apple.com>'s request
for review:
Bug 27128: Make Widget Ref-Counted.
https://bugs.webkit.org/show_bug.cgi?id=27128

Attachment 32530: Patch
https://bugs.webkit.org/attachment.cgi?id=32530&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>

> -    const HashSet<Widget*>* viewChildren = children();
> -    HashSet<Widget*>::const_iterator end = viewChildren->end();
> -    for (HashSet<Widget*>::const_iterator current = viewChildren->begin();
current != end; ++current)
> -	   if ((*current)->isFrameView())
> -	       static_cast<FrameView*>(*current)->layoutIfNeededRecursive();
> +    const HashSet<RefPtr<Widget> >* viewChildren = children();
> +    HashSet<RefPtr<Widget> >::const_iterator end = viewChildren->end();
> +    for (HashSet<RefPtr<Widget> >::const_iterator current =
viewChildren->begin(); current != end; ++current) {
> +	   RefPtr<Widget> widget = (*current);
> +	   if (widget->isFrameView())
> +	      
static_cast<FrameView*>(widget.get())->layoutIfNeededRecursive();
> +    }
>  

I don't think the change to use a temporary variable here is helpful, since
you've created refcounting churn.  I think you should put it back the way it
was and just use |current|.


> Index: WebCore/rendering/RenderApplet.cpp
> ===================================================================
> --- WebCore/rendering/RenderApplet.cpp	(revision 45662)
> +++ WebCore/rendering/RenderApplet.cpp	(working copy)
> @@ -26,6 +26,7 @@
>  #include "HTMLAppletElement.h"
>  #include "HTMLNames.h"
>  #include "HTMLParamElement.h"
> +#include "Widget.h"
>  
>  namespace WebCore {
>  
> @@ -71,7 +72,8 @@ void RenderApplet::createWidgetIfNecessa
>  
>      Frame* frame = document()->frame();
>      ASSERT(frame);
> -    setWidget(frame->loader()->createJavaAppletWidget(IntSize(contentWidth,
contentHeight), element, m_args));
> +    RefPtr<Widget> widget =
frame->loader()->createJavaAppletWidget(IntSize(contentWidth, contentHeight),
element, m_args);
> +    setWidget(widget.get());
>  }
>  

I don't see any reason to use a temporary variable here?  You're at the end of
the function, so can't you just say:

setWidget(frame->loader()->createJavaAppletWidget(...));

?

Other comments:

Shouldn't setWidget take a PassRefPtr now, since RenderWidgets will be taking
ownership of the widget?

It seems like addChild should arguably take a PassRefPtr too, since the parent
will also be taking ownership of the added child.

I take back my objections to this patch.   The fact that Scrollbars and
FrameViews were already refcounted anyway makes this a really great cleanup.

Let me see one more round.  Thanks.

From bugzilla-daemon at webkit.org  Thu Jul  9 14:20:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:20:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26903] Need to enable
 CHANNEL_MESSAGING by default : [Attachment 32523] Patch with enabled
 security test and removing merge conflict.
In-Reply-To: <bug-26903-0@https.bugs.webkit.org/>
References: <bug-26903-0@https.bugs.webkit.org/>
Message-ID: <20090709212009.A813A32794D9@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26903: Need to enable CHANNEL_MESSAGING by default
https://bugs.webkit.org/show_bug.cgi?id=26903

Attachment 32523: Patch with enabled security test and removing merge conflict.
https://bugs.webkit.org/attachment.cgi?id=32523&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 14:27:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:27:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27123] Full page zoom
 breaks remaining and elapsed time display in the <video> controller. :
 [Attachment 32531] patch v2.
In-Reply-To: <bug-27123-0@https.bugs.webkit.org/>
References: <bug-27123-0@https.bugs.webkit.org/>
Message-ID: <20090709212714.F41443279827@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27123: Full page zoom breaks remaining and elapsed time display in the
<video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

Attachment 32531: patch v2.
https://bugs.webkit.org/attachment.cgi?id=32531&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 14:38:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:38:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27129] AX: possible
 assertion for a non-native image in accessibility : [Attachment 32532]
 patch
In-Reply-To: <bug-27129-0@https.bugs.webkit.org/>
References: <bug-27129-0@https.bugs.webkit.org/>
Message-ID: <20090709213838.A6BD43279C76@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 27129: AX: possible assertion for a non-native image in accessibility
https://bugs.webkit.org/show_bug.cgi?id=27129

Attachment 32532: patch
https://bugs.webkit.org/attachment.cgi?id=32532&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 14:45:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:45:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27123] Full page zoom breaks
 remaining and elapsed time display in the <video> controller. : [Attachment
 32531] patch v2.
In-Reply-To: <bug-27123-0@https.bugs.webkit.org/>
References: <bug-27123-0@https.bugs.webkit.org/>
Message-ID: <20090709214513.9DB823279F81@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27123: Full page zoom breaks remaining and elapsed time display in the
<video> controller.
https://bugs.webkit.org/show_bug.cgi?id=27123

Attachment 32531: patch v2.
https://bugs.webkit.org/attachment.cgi?id=32531&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>


> +	   We are changing the size of the time remaining and time ellapsed
field, to

Typo: "ellapsed"

> +	   The following patch fixes that problem by using a cloned style on
which we

"This change", not "The following patch", since the changelog needs to read
well after you commit :)


> +    RefPtr<RenderStyle> style = styleForElement();
> +    renderer()->setStyle(style.get());

To reduce ref churn, you could just do

 renderer()->setStyle(styleForElement());

From bugzilla-daemon at webkit.org  Thu Jul  9 14:46:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:46:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27117] bugzilla-tool: use Mac
 OS X keychain for authentication : [Attachment 32517] Patch v1
In-Reply-To: <bug-27117-0@https.bugs.webkit.org/>
References: <bug-27117-0@https.bugs.webkit.org/>
Message-ID: <20090709214636.AC353327A034@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27117: bugzilla-tool: use Mac OS X keychain for authentication
https://bugs.webkit.org/show_bug.cgi?id=27117

Attachment 32517: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32517&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks good!

From bugzilla-daemon at webkit.org  Thu Jul  9 14:51:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:51:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27128] Make Widget
 Ref-Counted. : [Attachment 32533] New Patch
In-Reply-To: <bug-27128-0@https.bugs.webkit.org/>
References: <bug-27128-0@https.bugs.webkit.org/>
Message-ID: <20090709215121.3CE61327A22E@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 27128: Make Widget Ref-Counted.
https://bugs.webkit.org/show_bug.cgi?id=27128

Attachment 32533: New Patch
https://bugs.webkit.org/attachment.cgi?id=32533&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
Here's a new patch that takes all of these comments into account.

From bugzilla-daemon at webkit.org  Thu Jul  9 14:59:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 14:59:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27128] Make Widget
 Ref-Counted. : [Attachment 32533] New Patch
In-Reply-To: <bug-27128-0@https.bugs.webkit.org/>
References: <bug-27128-0@https.bugs.webkit.org/>
Message-ID: <20090709215939.4133C327A632@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 27128: Make Widget Ref-Counted.
https://bugs.webkit.org/show_bug.cgi?id=27128

Attachment 32533: New Patch
https://bugs.webkit.org/attachment.cgi?id=32533&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Typo in ChangeLog:

"setWidget() now takes a PassRefPtr. Also eemoved the manual ref of "

"eemoved" should be "removed".

ScrollView::platformAddChild never takes ownership of the Widget, so I don't
think you needed to change any of those implementations. Those should just be
platformAddChild(Widget*) still.  You can undo that change and avoid having to
touch a bunch of ScrollView port files.

With those changes, r=me!

From bugzilla-daemon at webkit.org  Thu Jul  9 15:05:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:05:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27129] AX: possible assertion
 for a non-native image in accessibility : [Attachment 32532] patch
In-Reply-To: <bug-27129-0@https.bugs.webkit.org/>
References: <bug-27129-0@https.bugs.webkit.org/>
Message-ID: <20090709220548.EFA69327A8C6@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27129: AX: possible assertion for a non-native image in accessibility
https://bugs.webkit.org/show_bug.cgi?id=27129

Attachment 32532: patch
https://bugs.webkit.org/attachment.cgi?id=32532&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 15:12:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:12:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 20625] ConsoleMessage should
 have a "type" attribute : [Attachment 32504] forgot to write WebKit
 ChangeLog
In-Reply-To: <bug-20625-0@https.bugs.webkit.org/>
References: <bug-20625-0@https.bugs.webkit.org/>
Message-ID: <20090709221223.1A6C6327ABB3@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted  review:
Bug 20625: ConsoleMessage should have a "type" attribute
https://bugs.webkit.org/show_bug.cgi?id=20625

Attachment 32504: forgot to write WebKit ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32504&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 15:30:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:30:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27011] [Gtk] Implement
 support for get_index_in_parent : [Attachment 32456] getindexinparent.patch
In-Reply-To: <bug-27011-0@https.bugs.webkit.org/>
References: <bug-27011-0@https.bugs.webkit.org/>
Message-ID: <20090709223004.AE201327B413@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 27011: [Gtk] Implement support for get_index_in_parent
https://bugs.webkit.org/show_bug.cgi?id=27011

Attachment 32456: getindexinparent.patch
https://bugs.webkit.org/attachment.cgi?id=32456&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -    // FIXME: This needs to be implemented.
> -    notImplemented();
> +    AccessibilityObject* coreObject = core(object);
> +    AccessibilityObject* parent = coreObject->parentObject();
> +
> +    g_return_val_if_fail (parent, 0);

Just a nit: this needs to be in "if" since we're dealing with WebCore objects.

I'll clear the review flag for now until we sort out Joanmarie's findings.

From bugzilla-daemon at webkit.org  Thu Jul  9 15:30:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:30:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27132] Upstream
 UndetectableHTMLCollection.idl as HTMLAllCollection.idl : [Attachment
 32534] patch
In-Reply-To: <bug-27132-0@https.bugs.webkit.org/>
References: <bug-27132-0@https.bugs.webkit.org/>
Message-ID: <20090709223023.79C84327B446@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27132: Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl
https://bugs.webkit.org/show_bug.cgi?id=27132

Attachment 32534: patch
https://bugs.webkit.org/attachment.cgi?id=32534&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 15:37:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:37:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27132] Upstream
 UndetectableHTMLCollection.idl as HTMLAllCollection.idl : [Attachment
 32535] patch2
In-Reply-To: <bug-27132-0@https.bugs.webkit.org/>
References: <bug-27132-0@https.bugs.webkit.org/>
Message-ID: <20090709223723.DF92D327B78E@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27132: Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl
https://bugs.webkit.org/show_bug.cgi?id=27132

Attachment 32535: patch2
https://bugs.webkit.org/attachment.cgi?id=32535&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 15:37:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:37:23 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27132] Upstream
 UndetectableHTMLCollection.idl as HTMLAllCollection.idl : [Attachment
 32534] patch
In-Reply-To: <bug-27132-0@https.bugs.webkit.org/>
References: <bug-27132-0@https.bugs.webkit.org/>
Message-ID: <20090709223723.D32D3327B78C@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has canceled Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27132: Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl
https://bugs.webkit.org/show_bug.cgi?id=27132

Attachment 32534: patch
https://bugs.webkit.org/attachment.cgi?id=32534&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 15:47:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 15:47:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27132] Upstream
 UndetectableHTMLCollection.idl as HTMLAllCollection.idl : [Attachment
 32535] patch2
In-Reply-To: <bug-27132-0@https.bugs.webkit.org/>
References: <bug-27132-0@https.bugs.webkit.org/>
Message-ID: <20090709224742.DD399327BBBA@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27132: Upstream UndetectableHTMLCollection.idl as HTMLAllCollection.idl
https://bugs.webkit.org/show_bug.cgi?id=27132

Attachment 32535: patch2
https://bugs.webkit.org/attachment.cgi?id=32535&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Thu Jul  9 16:17:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 16:17:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27135] [Chromium] Upstream
 Chromium port project files. : [Attachment 32536] Upstream Chromium port
 project files, v1.
In-Reply-To: <bug-27135-0@https.bugs.webkit.org/>
References: <bug-27135-0@https.bugs.webkit.org/>
Message-ID: <20090709231712.E89A8327C9CE@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 27135: [Chromium] Upstream Chromium port project files.
https://bugs.webkit.org/show_bug.cgi?id=27135

Attachment 32536: Upstream Chromium port project files, v1.
https://bugs.webkit.org/attachment.cgi?id=32536&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 JavaScriptCore/ChangeLog	    |	 9 +
 JavaScriptCore/JavaScriptCore.gypi |  452 +++++
 WebCore/ChangeLog		    |	 9 +
 WebCore/WebCore.gypi		    | 3324 ++++++++++++++++++++++++++++++++++++
 4 files changed, 3794 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul  9 16:19:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 16:19:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27135] [Chromium] Upstream
 Chromium port project files. : [Attachment 32536] Upstream Chromium port
 project files, v1.
In-Reply-To: <bug-27135-0@https.bugs.webkit.org/>
References: <bug-27135-0@https.bugs.webkit.org/>
Message-ID: <20090709231927.CD87E327CAE1@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 27135: [Chromium] Upstream Chromium port project files.
https://bugs.webkit.org/show_bug.cgi?id=27135

Attachment 32536: Upstream Chromium port project files, v1.
https://bugs.webkit.org/attachment.cgi?id=32536&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 16:19:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 16:19:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27134] [V8] Make DOMWrapper
 interface more like JSC : [Attachment 32537] Patch (renaming only)
In-Reply-To: <bug-27134-0@https.bugs.webkit.org/>
References: <bug-27134-0@https.bugs.webkit.org/>
Message-ID: <20090709231953.8617D327CB1C@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27134: [V8] Make DOMWrapper interface more like JSC
https://bugs.webkit.org/show_bug.cgi?id=27134

Attachment 32537: Patch (renaming only)
https://bugs.webkit.org/attachment.cgi?id=32537&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 16:23:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 16:23:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27133] [Chromium] Upstream
 RGBColor : [Attachment 32538] patch
In-Reply-To: <bug-27133-0@https.bugs.webkit.org/>
References: <bug-27133-0@https.bugs.webkit.org/>
Message-ID: <20090709232339.39BA3327CCAC@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27133: [Chromium] Upstream RGBColor
https://bugs.webkit.org/show_bug.cgi?id=27133

Attachment 32538: patch
https://bugs.webkit.org/attachment.cgi?id=32538&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 16:45:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 16:45:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27136] [Qt] Webkit hangs
 when executing an infinite JavaScript loop : [Attachment 32539] Add UI
 asking the user if to stop running the script
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090709234517.2BC2A327D61E@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32539: Add UI asking the user if to stop running the script
https://bugs.webkit.org/attachment.cgi?id=32539&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Following the model of ChromeClientQt::runJavaScriptConfirm(), added a callback
to QWebPage, to display a query to the user.

From bugzilla-daemon at webkit.org  Thu Jul  9 16:45:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 16:45:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25316] Outdenting a line
 inside a blockquote tag does nothing : [Attachment 32540] fixes the bug
In-Reply-To: <bug-25316-0@https.bugs.webkit.org/>
References: <bug-25316-0@https.bugs.webkit.org/>
Message-ID: <20090709234538.4B62F327D656@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32540: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32540&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:21:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:21:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27138]
 LayoutTests/fast/dom/anchor-toString.html is unnecessarily
 platform-specific : [Attachment 32541] patch to make test case less
 platform-specific
In-Reply-To: <bug-27138-0@https.bugs.webkit.org/>
References: <bug-27138-0@https.bugs.webkit.org/>
Message-ID: <20090710002140.3BD6D327E559@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 27138: LayoutTests/fast/dom/anchor-toString.html is unnecessarily
platform-specific
https://bugs.webkit.org/show_bug.cgi?id=27138

Attachment 32541: patch to make test case less platform-specific
https://bugs.webkit.org/attachment.cgi?id=32541&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:22:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:22:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27130] Need to implement
 ARIA role="toolbar" : [Attachment 32542] patch
In-Reply-To: <bug-27130-0@https.bugs.webkit.org/>
References: <bug-27130-0@https.bugs.webkit.org/>
Message-ID: <20090710002232.E84E9327E5B7@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 27130: Need to implement ARIA role="toolbar"
https://bugs.webkit.org/show_bug.cgi?id=27130

Attachment 32542: patch
https://bugs.webkit.org/attachment.cgi?id=32542&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:24:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:24:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27130] Need to implement ARIA
 role="toolbar" : [Attachment 32542] patch
In-Reply-To: <bug-27130-0@https.bugs.webkit.org/>
References: <bug-27130-0@https.bugs.webkit.org/>
Message-ID: <20090710002430.3F565327E6A1@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27130: Need to implement ARIA role="toolbar"
https://bugs.webkit.org/show_bug.cgi?id=27130

Attachment 32542: patch
https://bugs.webkit.org/attachment.cgi?id=32542&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:34:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:34:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27138]
 LayoutTests/fast/dom/anchor-toString.html is unnecessarily
 platform-specific : [Attachment 32541] patch to make test case less
 platform-specific
In-Reply-To: <bug-27138-0@https.bugs.webkit.org/>
References: <bug-27138-0@https.bugs.webkit.org/>
Message-ID: <20090710003422.23473327EAD5@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27138: LayoutTests/fast/dom/anchor-toString.html is unnecessarily
platform-specific
https://bugs.webkit.org/show_bug.cgi?id=27138

Attachment 32541: patch to make test case less platform-specific
https://bugs.webkit.org/attachment.cgi?id=32541&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:38:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:38:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27134] [V8] Make DOMWrapper
 interface more like JSC : [Attachment 32537] Patch (renaming only)
In-Reply-To: <bug-27134-0@https.bugs.webkit.org/>
References: <bug-27134-0@https.bugs.webkit.org/>
Message-ID: <20090710003808.74C61327EC69@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27134: [V8] Make DOMWrapper interface more like JSC
https://bugs.webkit.org/show_bug.cgi?id=27134

Attachment 32537: Patch (renaming only)
https://bugs.webkit.org/attachment.cgi?id=32537&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:42:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:42:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27138]
 LayoutTests/fast/dom/anchor-toString.html is unnecessarily
 platform-specific : [Attachment 32541] patch to make test case less
 platform-specific
In-Reply-To: <bug-27138-0@https.bugs.webkit.org/>
References: <bug-27138-0@https.bugs.webkit.org/>
Message-ID: <20090710004230.824C0327EE2F@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 27138: LayoutTests/fast/dom/anchor-toString.html is unnecessarily
platform-specific
https://bugs.webkit.org/show_bug.cgi?id=27138

Attachment 32541: patch to make test case less platform-specific
https://bugs.webkit.org/attachment.cgi?id=32541&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +		   * fast/dom/anchor-toString-expected.txt:
> +	   * fast/dom/anchor-toString.html:

Strange indentation here.

r=me

Sorry, I missed the comment explaining what "platform-dependent" meant. I think
the comment would have been a lot clearer if it just specifically called out
Windows drive letters in URLs as the issue.

From bugzilla-daemon at webkit.org  Thu Jul  9 17:43:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:43:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27139] Fix chromium
 platform build bustage : [Attachment 32543] Fix compile errors
In-Reply-To: <bug-27139-0@https.bugs.webkit.org/>
References: <bug-27139-0@https.bugs.webkit.org/>
Message-ID: <20090710004344.B4DF7327EEB4@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 27139: Fix chromium platform build bustage
https://bugs.webkit.org/show_bug.cgi?id=27139

Attachment 32543: Fix compile errors
https://bugs.webkit.org/attachment.cgi?id=32543&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:44:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:44:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27139] Fix chromium platform
 build bustage : [Attachment 32543] Fix compile errors
In-Reply-To: <bug-27139-0@https.bugs.webkit.org/>
References: <bug-27139-0@https.bugs.webkit.org/>
Message-ID: <20090710004400.5C393327EED6@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27139: Fix chromium platform build bustage
https://bugs.webkit.org/show_bug.cgi?id=27139

Attachment 32543: Fix compile errors
https://bugs.webkit.org/attachment.cgi?id=32543&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 17:54:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 17:54:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14271] Add preferences key
 to make the inspector dock by default : [Attachment 32544] Windows Patch
In-Reply-To: <bug-14271-0@https.bugs.webkit.org/>
References: <bug-14271-0@https.bugs.webkit.org/>
Message-ID: <20090710005455.72080327F32C@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 14271: Add preferences key to make the inspector dock by default
https://bugs.webkit.org/show_bug.cgi?id=14271

Attachment 32544: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32544&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 18:06:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 18:06:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27140] Add a preference key
 to make Web Inspector detach/attach by default : [Attachment 32545] Windows
 Patch
In-Reply-To: <bug-27140-0@https.bugs.webkit.org/>
References: <bug-27140-0@https.bugs.webkit.org/>
Message-ID: <20090710010636.A95E1327F75F@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 27140: Add a preference key to make Web Inspector detach/attach by default
https://bugs.webkit.org/show_bug.cgi?id=27140

Attachment 32545: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32545&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 18:30:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 18:30:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32546] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090710013034.B0C3E327FF94@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32546: win patch
https://bugs.webkit.org/attachment.cgi?id=32546&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
minor bug fix in appendDatabaseFileNameToPath() in
SQLiteFileSystemChromium.cpp.

From bugzilla-daemon at webkit.org  Thu Jul  9 18:33:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 18:33:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27140] Add a preference key
 to make Web Inspector detach/attach by default : [Attachment 32545] Windows
 Patch
In-Reply-To: <bug-27140-0@https.bugs.webkit.org/>
References: <bug-27140-0@https.bugs.webkit.org/>
Message-ID: <20090710013321.7A4663280091@gamma.macosforge.org>

Alice Liu <alice.liu at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 27140: Add a preference key to make Web Inspector detach/attach by default
https://bugs.webkit.org/show_bug.cgi?id=27140

Attachment 32545: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32545&action=review

------- Additional Comments from Alice Liu <alice.liu at apple.com>
> @@ -322,6 +324,9 @@ void WebInspectorClient::showWindowWitho
>      ASSERT(m_webView);
>      ASSERT(m_inspectedWebViewHwnd);
>  
> +    InspectorController::Setting shouldAttach =
m_inspectedWebView->page()->inspectorController()->setting(inspectorStartsAttac
hedName);
> +    m_shouldAttachWhenShown = (shouldAttach.type() ==
InspectorController::Setting::BooleanType) ? shouldAttach.booleanValue() :
false;
> +
>      if (!m_shouldAttachWhenShown) {
>	   // Put the Inspector's WebView inside our window and show it.
>	   m_webView->setHostWindow(reinterpret_cast<OLE_HANDLE>(m_hwnd));

bdash wants you to remove the extraneous parents around the condition before
the question mark

r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 18:33:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 18:33:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25205] XMLHttpRequest
 instance is not an instanceof XMLHttpRequest : [Attachment 32547] Removed
 virtual destructor declaration of DOMConstructorObject.
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090710013338.DEE0432800B7@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32547: Removed virtual destructor declaration of
DOMConstructorObject.
https://bugs.webkit.org/attachment.cgi?id=32547&action=review

------- Additional Comments from Yuzo Fujishima <yuzo at google.com>
Hi,

Thank you for reviewing this.

I've removed the virtual destructor declaration of DOMConstructorObject
and confirmed that the layout test succeeds for both Debug and Release.

Yuzo

From bugzilla-daemon at webkit.org  Thu Jul  9 18:52:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 18:52:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27140] Add a preference key
 to make Web Inspector detach/attach by default : [Attachment 32545] Windows
 Patch
In-Reply-To: <bug-27140-0@https.bugs.webkit.org/>
References: <bug-27140-0@https.bugs.webkit.org/>
Message-ID: <20090710015219.1B63A3280731@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has canceled  review:
Bug 27140: Add a preference key to make Web Inspector detach/attach by default
https://bugs.webkit.org/show_bug.cgi?id=27140

Attachment 32545: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32545&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 20:07:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:07:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27122] prepare-ChangeLog
 should decode HTML entities in short description : [Attachment 32528] Patch
 v3
In-Reply-To: <bug-27122-0@https.bugs.webkit.org/>
References: <bug-27122-0@https.bugs.webkit.org/>
Message-ID: <20090710030728.947753282232@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27122: prepare-ChangeLog should decode HTML entities in short description
https://bugs.webkit.org/show_bug.cgi?id=27122

Attachment 32528: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32528&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 20:13:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:13:09 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27051] Use fastMalloc when
 neither MMAP nor VIRTUALALLOC are enabled : [Attachment 32410] Code patch
 for Registerfile ccp and h
In-Reply-To: <bug-27051-0@https.bugs.webkit.org/>
References: <bug-27051-0@https.bugs.webkit.org/>
Message-ID: <20090710031309.93E873282432@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has canceled Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27051: Use fastMalloc when neither MMAP nor VIRTUALALLOC are enabled
https://bugs.webkit.org/show_bug.cgi?id=27051

Attachment 32410: Code patch for Registerfile ccp and h
https://bugs.webkit.org/attachment.cgi?id=32410&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
I'll have to check into whether this works - I don't remember whether there are
special alignment or lazy commit requirements.

But I also noticed that PLATFORM(SYMBIAN) uses fastMalloc in place of VM
allocation inside Collector.cpp. That's definitely bugus - the GC counts on the
guaranteed alignment provided by vm_map, VirtualAlloc and posix_memalign.
Failing to meet the alignment requirements will lead to random crashes. If
Symbian has no way to get aligned memory chunks, it needs to do a trick to fix
up the alignment, like the mmap() code path.

From bugzilla-daemon at webkit.org  Thu Jul  9 20:15:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:15:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26985] Implement parsing of
 <rp> & <rt> elements as per HTML5 spec : [Attachment 32296] patch: update
 with layout test
In-Reply-To: <bug-26985-0@https.bugs.webkit.org/>
References: <bug-26985-0@https.bugs.webkit.org/>
Message-ID: <20090710031535.8EE133282539@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26985: Implement parsing of <rp> & <rt> elements as per HTML5 spec
https://bugs.webkit.org/show_bug.cgi?id=26985

Attachment 32296: patch: update with layout test
https://bugs.webkit.org/attachment.cgi?id=32296&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul  9 20:17:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:17:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26827] Improve
 InlineBox::first/lastLeafChild methods : [Attachment 32103] updated patch
In-Reply-To: <bug-26827-0@https.bugs.webkit.org/>
References: <bug-26827-0@https.bugs.webkit.org/>
Message-ID: <20090710031746.7BA3032825ED@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 26827: Improve InlineBox::first/lastLeafChild methods
https://bugs.webkit.org/show_bug.cgi?id=26827

Attachment 32103: updated patch
https://bugs.webkit.org/attachment.cgi?id=32103&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
All right, the code looks correct, and since it doesn't fail any tests, I'm
going to assume the assumptions about looking at parents (that it's
accidentally there and no longer needed) are right. If not, we'll find out soon
enough.

From bugzilla-daemon at webkit.org  Thu Jul  9 20:28:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:28:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26987] Add fast case for
 Math.floor(a / b) expressions : [Attachment 32298] Enable math.floor(a/b)
 optimization on interpreter
In-Reply-To: <bug-26987-0@https.bugs.webkit.org/>
References: <bug-26987-0@https.bugs.webkit.org/>
Message-ID: <20090710032857.5B12A32829CD@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 26987: Add fast case for Math.floor(a / b) expressions
https://bugs.webkit.org/show_bug.cgi?id=26987

Attachment 32298: Enable math.floor(a/b) optimization on interpreter
https://bugs.webkit.org/attachment.cgi?id=32298&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I think the complexity of this patch isn't balanced performance gain.  I
recognise that we need to come up with a solution for the problem of the simple
builtin function, but i don't believe lexical specialisation is the solution. 
It works for call/apply but they have a *huge* overhead on many levels and
aren't cached in js, whereas things like the builtin Math functions (and also a
number of other builtin functions) are cached in ways that defeat lexical
caching, especially in the fast case, and the quantity of calls is likely to be
much larger than that of call and apply.

Just to make it clear, i do believe we want to improve performance of builtins,
i just don't believe lexical caching is the solution.

From bugzilla-daemon at webkit.org  Thu Jul  9 20:29:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:29:16 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26987] Add fast case for
 Math.floor(a / b) expressions : [Attachment 32297] getType() method added
 for all leaf Nodes
In-Reply-To: <bug-26987-0@https.bugs.webkit.org/>
References: <bug-26987-0@https.bugs.webkit.org/>
Message-ID: <20090710032916.6132C3282A2A@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 26987: Add fast case for Math.floor(a / b) expressions
https://bugs.webkit.org/show_bug.cgi?id=26987

Attachment 32297: getType() method added for all leaf Nodes
https://bugs.webkit.org/attachment.cgi?id=32297&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 20:39:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:39:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27043] Mouse-dragged events
 are not generated for right & middle buttons : [Attachment 32497] Fixes
 middlemouse and rightmouse drag events.
In-Reply-To: <bug-27043-0@https.bugs.webkit.org/>
References: <bug-27043-0@https.bugs.webkit.org/>
Message-ID: <20090710033940.878333282D86@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied John Newlin <jnewlin at google.com>'s
request for review:
Bug 27043: Mouse-dragged events are not generated for right & middle buttons
https://bugs.webkit.org/show_bug.cgi?id=27043

Attachment 32497: Fixes middlemouse and rightmouse drag events.
https://bugs.webkit.org/attachment.cgi?id=32497&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Basically looks good, but you probably also want to add
-[WebBaseNetscapePluginView otherMouseDragged:NSEvent*] and you also need to
add tests cases for it

From bugzilla-daemon at webkit.org  Thu Jul  9 20:44:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:44:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27133] [Chromium] Upstream
 RGBColor : [Attachment 32538] patch
In-Reply-To: <bug-27133-0@https.bugs.webkit.org/>
References: <bug-27133-0@https.bugs.webkit.org/>
Message-ID: <20090710034444.D224B3282F35@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27133: [Chromium] Upstream RGBColor
https://bugs.webkit.org/show_bug.cgi?id=27133

Attachment 32538: patch
https://bugs.webkit.org/attachment.cgi?id=32538&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/bindings/v8/RGBColor.cpp
...
> +    unsigned int value = (m_rgbColor >> 16) & 0xFF;
> +    return CSSPrimitiveValue::create(value, CSSPrimitiveValue::CSS_NUMBER);

nit: i think the prevailing style in webkit is to just use "unsigned" instead
of
"unsigned int"

otherwise, R=me

From bugzilla-daemon at webkit.org  Thu Jul  9 20:59:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 20:59:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27141] Web Inspector should
 use Web Inspector preferences to remember attached/detached setting :
 [Attachment 32548] Use Web Inspector Preferences
In-Reply-To: <bug-27141-0@https.bugs.webkit.org/>
References: <bug-27141-0@https.bugs.webkit.org/>
Message-ID: <20090710035904.5EE163283485@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 27141: Web Inspector should use Web Inspector preferences to remember
attached/detached setting
https://bugs.webkit.org/show_bug.cgi?id=27141

Attachment 32548: Use Web Inspector Preferences
https://bugs.webkit.org/attachment.cgi?id=32548&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 21:16:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 21:16:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27133] [Chromium] Upstream
 RGBColor : [Attachment 32538] patch
In-Reply-To: <bug-27133-0@https.bugs.webkit.org/>
References: <bug-27133-0@https.bugs.webkit.org/>
Message-ID: <20090710041638.10DD73283B30@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied  review:
Bug 27133: [Chromium] Upstream RGBColor
https://bugs.webkit.org/show_bug.cgi?id=27133

Attachment 32538: patch
https://bugs.webkit.org/attachment.cgi?id=32538&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>

From bugzilla-daemon at webkit.org  Thu Jul  9 21:20:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 21:20:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 32518] Patch v1
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090710042021.28ED63283CA5@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 32518: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32518&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
I think you should make this work with svn before it goes in as this is the
primary tool used by this project.  Adding git support as well is okay, but it
should not be the only way to do anything.

From bugzilla-daemon at webkit.org  Thu Jul  9 21:47:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 21:47:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27007] Build fixes when
 ICONDATABASE is disabled : [Attachment 32405] Patch v4
In-Reply-To: <bug-27007-0@https.bugs.webkit.org/>
References: <bug-27007-0@https.bugs.webkit.org/>
Message-ID: <20090710044751.0CF7C32846CA@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27007: Build fixes when ICONDATABASE is disabled
https://bugs.webkit.org/show_bug.cgi?id=27007

Attachment 32405: Patch v4
https://bugs.webkit.org/attachment.cgi?id=32405&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 21:56:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 21:56:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27142] canPlayType() should
 return empty string for unsupported content : [Attachment 32549] Update
 canPlayType behaviour
In-Reply-To: <bug-27142-0@https.bugs.webkit.org/>
References: <bug-27142-0@https.bugs.webkit.org/>
Message-ID: <20090710045601.D2F3A32849F8@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27142: canPlayType() should return empty string for unsupported content
https://bugs.webkit.org/show_bug.cgi?id=27142

Attachment 32549: Update canPlayType behaviour
https://bugs.webkit.org/attachment.cgi?id=32549&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 21:58:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 21:58:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27142] canPlayType() should
 return empty string for unsupported content : [Attachment 32549] Update
 canPlayType behaviour
In-Reply-To: <bug-27142-0@https.bugs.webkit.org/>
References: <bug-27142-0@https.bugs.webkit.org/>
Message-ID: <20090710045835.9E8DD3284B0A@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27142: canPlayType() should return empty string for unsupported content
https://bugs.webkit.org/show_bug.cgi?id=27142

Attachment 32549: Update canPlayType behaviour
https://bugs.webkit.org/attachment.cgi?id=32549&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=maciej

From bugzilla-daemon at webkit.org  Thu Jul  9 22:45:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 22:45:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20578] [CAIRO] pattern of a
 canvas-element changes after modifications on canvas-element : [Attachment
 32550] Patch v4
In-Reply-To: <bug-20578-0@https.bugs.webkit.org/>
References: <bug-20578-0@https.bugs.webkit.org/>
Message-ID: <20090710054514.068EE3285B62@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 20578: [CAIRO] pattern of a canvas-element changes after modifications on
canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578

Attachment 32550: Patch v4
https://bugs.webkit.org/attachment.cgi?id=32550&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Fixing a style error for copySurface. Though Eric kindly said that he'll fix
this, I fixed it to save Eric's time a bit.

From bugzilla-daemon at webkit.org  Thu Jul  9 22:45:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 22:45:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 20578] [CAIRO] pattern of a
 canvas-element changes after modifications on canvas-element : [Attachment
 31926] Patch v3
In-Reply-To: <bug-20578-0@https.bugs.webkit.org/>
References: <bug-20578-0@https.bugs.webkit.org/>
Message-ID: <20090710054514.0148A3285B5F@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 20578: [CAIRO] pattern of a canvas-element changes after modifications on
canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578

Attachment 31926: Patch v3
https://bugs.webkit.org/attachment.cgi?id=31926&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Fixing a style error for copySurface. Though Eric kindly said that he'll fix
this, I fixed it to save Eric's time a bit.

From bugzilla-daemon at webkit.org  Thu Jul  9 23:04:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 23:04:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27137] REGRESSION (r44311):
 Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor()
 -> FrameView::layout() : [Attachment 32551] Make lock-scroll-to-anchor a
 function of FrameView, and perform it as a post-layout task
In-Reply-To: <bug-27137-0@https.bugs.webkit.org/>
References: <bug-27137-0@https.bugs.webkit.org/>
Message-ID: <20090710060403.ED118328619D@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27137: REGRESSION (r44311): Reproducible crash due to infinite recursion
into FrameLoader::gotoAnchor() -> FrameView::layout()
https://bugs.webkit.org/show_bug.cgi?id=27137

Attachment 32551: Make lock-scroll-to-anchor a function of FrameView, and
perform it as a post-layout task
https://bugs.webkit.org/attachment.cgi?id=32551&action=review

From bugzilla-daemon at webkit.org  Thu Jul  9 23:25:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu,  9 Jul 2009 23:25:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24000] Side bar linking to
 "DOM Interfaces" returns 404 : [Attachment 32501] Remove "DOM Interfaces"
 Link
In-Reply-To: <bug-24000-0@https.bugs.webkit.org/>
References: <bug-24000-0@https.bugs.webkit.org/>
Message-ID: <20090710062547.9BCB2328695A@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Joseph Pecoraro <joepeck02 at gmail.com>'s
request for review:
Bug 24000: Side bar linking to "DOM Interfaces" returns 404
https://bugs.webkit.org/show_bug.cgi?id=24000

Attachment 32501: Remove "DOM Interfaces" Link
https://bugs.webkit.org/attachment.cgi?id=32501&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 02:08:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 02:08:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27146] JSDebugger crashes
 after reloading from a breakpoint : [Attachment 32552] harden the debugger
In-Reply-To: <bug-27146-0@https.bugs.webkit.org/>
References: <bug-27146-0@https.bugs.webkit.org/>
Message-ID: <20090710090803.BEC0F328A0BD@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27146: JSDebugger crashes after reloading from a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=27146

Attachment 32552: harden the debugger
https://bugs.webkit.org/attachment.cgi?id=32552&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 02:36:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 02:36:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27146] JSDebugger crashes
 after reloading from a breakpoint : [Attachment 32552] harden the debugger
In-Reply-To: <bug-27146-0@https.bugs.webkit.org/>
References: <bug-27146-0@https.bugs.webkit.org/>
Message-ID: <20090710093626.BC248328AA1E@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has canceled Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27146: JSDebugger crashes after reloading from a breakpoint
https://bugs.webkit.org/show_bug.cgi?id=27146

Attachment 32552: harden the debugger
https://bugs.webkit.org/attachment.cgi?id=32552&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
despite fixing the crash weirdness happens in the debugger afterwards

From bugzilla-daemon at webkit.org  Fri Jul 10 04:02:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 04:02:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27147] JS Syntax Highlight
 is incorrect for keyword followed by string or regexp : [Attachment 32554]
 Patch
In-Reply-To: <bug-27147-0@https.bugs.webkit.org/>
References: <bug-27147-0@https.bugs.webkit.org/>
Message-ID: <20090710110204.BC369328C8C7@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27147: JS Syntax Highlight is incorrect for keyword followed by string or
regexp
https://bugs.webkit.org/show_bug.cgi?id=27147

Attachment 32554: Patch
https://bugs.webkit.org/attachment.cgi?id=32554&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
all-minified.js at slashdot.org looks much better with this patch.

From bugzilla-daemon at webkit.org  Fri Jul 10 04:10:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 04:10:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27063] Exclude
 DumpRenderTree.pro from symbian build : [Attachment 32423] Code patch for
 WebKit.pro
In-Reply-To: <bug-27063-0@https.bugs.webkit.org/>
References: <bug-27063-0@https.bugs.webkit.org/>
Message-ID: <20090710111029.8D4E4328CB83@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27063: Exclude DumpRenderTree.pro from symbian build
https://bugs.webkit.org/show_bug.cgi?id=27063

Attachment 32423: Code patch for WebKit.pro
https://bugs.webkit.org/attachment.cgi?id=32423&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 04:32:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 04:32:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26990] [QT] [ARM] Add
 pkg-config entry for FontConfig on DRT.pro : [Attachment 32306] adds fc
 pkg-config entry into DRT.pro
In-Reply-To: <bug-26990-0@https.bugs.webkit.org/>
References: <bug-26990-0@https.bugs.webkit.org/>
Message-ID: <20090710113244.82D82328D28C@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 26990: [QT] [ARM] Add pkg-config entry for FontConfig on DRT.pro
https://bugs.webkit.org/show_bug.cgi?id=26990

Attachment 32306: adds fc pkg-config entry into DRT.pro
https://bugs.webkit.org/attachment.cgi?id=32306&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 05:17:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 05:17:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27141] Web Inspector should
 use Web Inspector preferences to remember attached/detached setting :
 [Attachment 32548] Use Web Inspector Preferences
In-Reply-To: <bug-27141-0@https.bugs.webkit.org/>
References: <bug-27141-0@https.bugs.webkit.org/>
Message-ID: <20090710121729.3D983328E1A1@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 27141: Web Inspector should use Web Inspector preferences to remember
attached/detached setting
https://bugs.webkit.org/show_bug.cgi?id=27141

Attachment 32548: Use Web Inspector Preferences
https://bugs.webkit.org/attachment.cgi?id=32548&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Does this default to being attached the first time?

From bugzilla-daemon at webkit.org  Fri Jul 10 05:37:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 05:37:22 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27108] [Qt] Crash with
 fast/loader/frame-creation-removal.html : [Attachment 32506] [Qt] Frame
 initialization crash
In-Reply-To: <bug-27108-0@https.bugs.webkit.org/>
References: <bug-27108-0@https.bugs.webkit.org/>
Message-ID: <20090710123722.B5B41328E819@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27108: [Qt] Crash with fast/loader/frame-creation-removal.html
https://bugs.webkit.org/show_bug.cgi?id=27108

Attachment 32506: [Qt] Frame initialization crash
https://bugs.webkit.org/attachment.cgi?id=32506&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing review, there may be a double-deletion in this patch as
frameLoaderClientDestroyed() should _also_ delete the QWebFrame

From bugzilla-daemon at webkit.org  Fri Jul 10 05:43:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 05:43:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27109] [Qt] Some tests in the
 Qt DRT pass and fail randomly,
 depending on whether previous tests used @font-face : [Attachment 32507]
 [Qt] Fix Qt DRT Fontconfig side-effects
In-Reply-To: <bug-27109-0@https.bugs.webkit.org/>
References: <bug-27109-0@https.bugs.webkit.org/>
Message-ID: <20090710124331.43E37328EA48@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27109: [Qt] Some tests in the Qt DRT pass and fail randomly, depending on
whether previous tests used @font-face
https://bugs.webkit.org/show_bug.cgi?id=27109

Attachment 32507: [Qt] Fix Qt DRT Fontconfig side-effects
https://bugs.webkit.org/attachment.cgi?id=32507&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 06:28:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 06:28:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26439] [Qt] QtWebKit fails in
 loading www.nytimes.com in Windows/Linux : [Attachment 32256] Fixes issue
 associated with rejecting response of HTTP 401 error
In-Reply-To: <bug-26439-0@https.bugs.webkit.org/>
References: <bug-26439-0@https.bugs.webkit.org/>
Message-ID: <20090710132818.F25F5328F9EE@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Sriram
<sriram.yadavalli at nokia.com>'s request for review:
Bug 26439: [Qt] QtWebKit fails in loading www.nytimes.com in Windows/Linux
https://bugs.webkit.org/show_bug.cgi?id=26439

Attachment 32256: Fixes issue associated with rejecting response of HTTP 401
error
https://bugs.webkit.org/attachment.cgi?id=32256&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. thanks, good catch!

Two minor points though:

1) Your patch doesn't apply as-is because the diff has relative paths in it
(../..)

2) Please don't put in my name as reviewer before it has been reviewed.

From bugzilla-daemon at webkit.org  Fri Jul 10 06:35:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 06:35:16 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27147] JS Syntax Highlight
 is incorrect for keyword followed by string or regexp : [Attachment 32554]
 Patch
In-Reply-To: <bug-27147-0@https.bugs.webkit.org/>
References: <bug-27147-0@https.bugs.webkit.org/>
Message-ID: <20090710133516.232A6328FC5A@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27147: JS Syntax Highlight is incorrect for keyword followed by string or
regexp
https://bugs.webkit.org/show_bug.cgi?id=27147

Attachment 32554: Patch
https://bugs.webkit.org/attachment.cgi?id=32554&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 06:59:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 06:59:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 19562] ValidityState object
 stub : [Attachment 32557] ValidityState full patch
In-Reply-To: <bug-19562-0@https.bugs.webkit.org/>
References: <bug-19562-0@https.bugs.webkit.org/>
Message-ID: <20090710135935.13FFD32904F0@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked Adele Peterson
<adele at apple.com> for review:
Bug 19562: ValidityState object stub
https://bugs.webkit.org/show_bug.cgi?id=19562

Attachment 32557: ValidityState full patch
https://bugs.webkit.org/attachment.cgi?id=32557&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
This patch includes previous code plus build fixes for various platform. It
includes tweaks to add ValidityState into the recently added gyp build system.

From bugzilla-daemon at webkit.org  Fri Jul 10 07:33:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 07:33:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32558] grabbing the WEBKIT_WEB_VIEW_TARGET_INFO_HTML via m_helper
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090710143346.7D2F9329124A@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32558: grabbing the WEBKIT_WEB_VIEW_TARGET_INFO_HTML via m_helper
https://bugs.webkit.org/attachment.cgi?id=32558&action=review

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
(In reply to comment #6)
> I think a proper fix for this is to add a function in
> WebKit/gtk/WebCoreSuppoer/PasteboardHelperGtk.cpp that will return the value
of
> WEBKIT_WEB_VIEW_TARGET_INFO_HTML, and use that in clipboard_get_contents_cb.

Done,
it works =)

From bugzilla-daemon at webkit.org  Fri Jul 10 07:33:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 07:33:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32376] Fix improper set of enum WebKitWebViewTargetInfo
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090710143346.61AD23291246@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has canceled Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32376: Fix improper set of enum WebKitWebViewTargetInfo
https://bugs.webkit.org/attachment.cgi?id=32376&action=review

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
(In reply to comment #6)
> I think a proper fix for this is to add a function in
> WebKit/gtk/WebCoreSuppoer/PasteboardHelperGtk.cpp that will return the value
of
> WEBKIT_WEB_VIEW_TARGET_INFO_HTML, and use that in clipboard_get_contents_cb.

Done,
it works =)

From bugzilla-daemon at webkit.org  Fri Jul 10 07:35:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 07:35:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27136] [Qt] Webkit hangs when
 executing an infinite JavaScript loop : [Attachment 32539] Add UI asking
 the user if to stop running the script
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710143506.A14F232912EF@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32539: Add UI asking the user if to stop running the script
https://bugs.webkit.org/attachment.cgi?id=32539&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Yael, we may not add new virtual methods as this will change the vtable and
break ABI to previous versions. One common way is to create a new method with
return value and use QMetaObject::invokeMethod. I assume Qt Software has an
internal document describing what to do now. Besides that the patch looks fine.

From bugzilla-daemon at webkit.org  Fri Jul 10 07:51:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 07:51:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32559] update patch to svn r45707
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090710145133.C349632918C6@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32559: update patch to svn r45707
https://bugs.webkit.org/attachment.cgi?id=32559&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 07:51:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 07:51:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32558] grabbing the WEBKIT_WEB_VIEW_TARGET_INFO_HTML via m_helper
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090710145133.AC05C32918C3@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has canceled Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32558: grabbing the WEBKIT_WEB_VIEW_TARGET_INFO_HTML via m_helper
https://bugs.webkit.org/attachment.cgi?id=32558&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 08:04:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 08:04:06 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32559] update patch to svn r45707
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090710150406.96B3C3291D90@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has canceled Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32559: update patch to svn r45707
https://bugs.webkit.org/attachment.cgi?id=32559&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 08:04:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 08:04:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32560] cleanup. update patch to svn r45707
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090710150406.B22C43291D94@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32560: cleanup.  update patch to svn r45707
https://bugs.webkit.org/attachment.cgi?id=32560&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 08:13:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 08:13:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27137] REGRESSION (r44311):
 Reproducible crash due to infinite recursion into FrameLoader::gotoAnchor()
 -> FrameView::layout() : [Attachment 32551] Make lock-scroll-to-anchor a
 function of FrameView, and perform it as a post-layout task
In-Reply-To: <bug-27137-0@https.bugs.webkit.org/>
References: <bug-27137-0@https.bugs.webkit.org/>
Message-ID: <20090710151316.549B532920D9@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 27137: REGRESSION (r44311): Reproducible crash due to infinite recursion
into FrameLoader::gotoAnchor() -> FrameView::layout()
https://bugs.webkit.org/show_bug.cgi?id=27137

Attachment 32551: Make lock-scroll-to-anchor a function of FrameView, and
perform it as a post-layout task
https://bugs.webkit.org/attachment.cgi?id=32551&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>


> +void FrameView::keepScrolledToAnchorNode(Node* anchorNode)

I'm not a big fan of this method name; maybe something like
maintainScrollPositionToAnchorNode?

> +    if (anchorNode != m_frame->document())
> +	   rect = anchorNode->getRect();

getRect(true) will make this transform-friendly!

r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 09:38:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 09:38:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22700] ApplicationCache should
 have size limit : [Attachment 32162] New proposal to limit the maximum size
 of the application cache (take 7)
In-Reply-To: <bug-22700-0@https.bugs.webkit.org/>
References: <bug-22700-0@https.bugs.webkit.org/>
Message-ID: <20090710163812.F3FB63293FFE@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has denied Andrei Popescu
<andreip at google.com>'s request for review:
Bug 22700: ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Attachment 32162: New proposal to limit the maximum size of the application
cache (take 7)
https://bugs.webkit.org/attachment.cgi?id=32162&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
> +	   * loader/appcache/ApplicationCache.cpp:
> +	   * loader/appcache/ApplicationCache.h:
> +	   Adds the ability to calculate the approximate size of an
ApplicationCache object.

I think that the data member and accessor naming should make it clear how the
data relates to reality (size() is not a great name for approximate/estimated
size).

> +    , m_calledChromeClient(false)

This is a super confusing name. What method was called? Why was it called? Was
it at any point in the past, or in some time range we care about?

> +   
m_frame->page()->chrome()->client()->reachedMaxAppCacheSize(cacheStorage().spac
eNeeded(m_cacheBeingUpdated->size()));
> +    m_calledChromeClient = true;
> +    checkIfLoadIsComplete();

The synchronous call to client matches how it is done for database quotas, but
in the grand scheme of things, I'm not sure if WebCore should be blocked while
waiting for the UI here.

> +	       // the maximum size. In such a case, m_manifestResource may be
NULL, as

We do not use NULL in code, so using it in comments isn't appropriate either. I
suggest lower case "null" or 0.

> +class ChromeClientCallbackTimer: public TimerBase {
...
> +    ApplicationCacheGroup* m_cacheGroup;

A comment explaining why m_cacheGroup won't be deleted before the timer fires
would help.

> +void ApplicationCacheGroup::scheduleReachedMaxAppCacheSize()

Looks like a noun is missing in this name ("callback"?).

> +class ChromeClientCallbackTimer;

I don't think you need a forward declaration here - a friend declaration should
be sufficient.

> +#include <sqlite3.h>

ApplicationCacheStorage shouldn't be talking to SQLite directly.
>	   unsigned newestCacheID =
static_cast<unsigned>(statement.getColumnInt64(2));
>	   RefPtr<ApplicationCache> cache = loadCache(newestCacheID);
> +	   if (!cache)
> +	       continue;

When can this fail? Wouldn't it mean that we left the disk database in
inconsistent state?

> +	   // Callback invoked when the application cache gets hits the maximum
size.

s/gets//. But also, is this comment 100% correct? I'd expect it to be called
when something doesn't fit.

> +	   // spaceNeeded denotes the amount of space that would need to be
freed
> +	   // in order for the operation that caused the out-of-space condition
to
> +	   // succeed.

That part seems obvious from argument name, I'd just drop it.

This looks pretty close to being ready to me. It would be great if Anders took
a look, too - especially at ApplicationCacheStorage.cpp changes, which I didn't
study very closely.

From bugzilla-daemon at webkit.org  Fri Jul 10 10:00:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 10:00:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27136] [Qt] Webkit hangs
 when executing an infinite JavaScript loop : [Attachment 32561] Replace
 virtual method with signal/slot
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710170058.C6AE8329494A@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32561: Replace virtual method with signal/slot
https://bugs.webkit.org/attachment.cgi?id=32561&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
I followed the instructions from
http://techbase.kde.org/Policies/Binary_Compatibility_Examples#Add_new_virtuals
_to_a_non-leaf_class.

I hope I got it right this time :-)

From bugzilla-daemon at webkit.org  Fri Jul 10 10:17:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 10:17:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27133] [Chromium] Upstream
 RGBColor : [Attachment 32562] patch2 - moved to WebCore/css/
In-Reply-To: <bug-27133-0@https.bugs.webkit.org/>
References: <bug-27133-0@https.bugs.webkit.org/>
Message-ID: <20090710171723.AFF803294F9D@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27133: [Chromium] Upstream RGBColor
https://bugs.webkit.org/show_bug.cgi?id=27133

Attachment 32562: patch2 - moved to WebCore/css/
https://bugs.webkit.org/attachment.cgi?id=32562&action=review

------- Additional Comments from Nate Chapin <japhet at chromium.org>
Moved to css/ and renamed "unsigned int" to "unsigned".

That was all that was required, right?

From bugzilla-daemon at webkit.org  Fri Jul 10 10:59:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 10:59:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27141] Web Inspector should
 use Web Inspector preferences to remember attached/detached setting :
 [Attachment 32548] Use Web Inspector Preferences
In-Reply-To: <bug-27141-0@https.bugs.webkit.org/>
References: <bug-27141-0@https.bugs.webkit.org/>
Message-ID: <20090710175951.84C823296066@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has canceled  review:
Bug 27141: Web Inspector should use Web Inspector preferences to remember
attached/detached setting
https://bugs.webkit.org/show_bug.cgi?id=27141

Attachment 32548: Use Web Inspector Preferences
https://bugs.webkit.org/attachment.cgi?id=32548&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 11:13:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:13:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27079]
 sort-Xcode-project-file should sort case-insensitively,
 to match Xcode's files list : [Attachment 32563] Use case-insensitive
 comparisons when sorting Xcode project files
In-Reply-To: <bug-27079-0@https.bugs.webkit.org/>
References: <bug-27079-0@https.bugs.webkit.org/>
Message-ID: <20090710181310.C712432965E1@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 27079: sort-Xcode-project-file should sort case-insensitively, to match
Xcode's files list
https://bugs.webkit.org/show_bug.cgi?id=27079

Attachment 32563:	  Use case-insensitive comparisons when sorting Xcode
project files
https://bugs.webkit.org/attachment.cgi?id=32563&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>

	This matches the sorting used in Xcode's files list.

	Fixes Bug 27079: sort-Xcode-project-file should sort
	case-insensitively, to match Xcode's files list
	<https://bugs.webkit.org/show_bug.cgi?id=27079>

	Reviewed by NOBODY (OOPS!).

	* Scripts/sort-Xcode-project-file:
	(sortChildrenByFileName):
	(sortFilesByFileName):
	Lowercase the strings before comparing them so that the comparison
	will be case-insensitive.
---
 2 files changed, 20 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 10 11:18:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:18:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27150] REGRESSION (r45647):
 prepare-ChangeLog -d puts non-diff lines into the diff : [Attachment 32564]
 Print prepare-ChangeLog's reminders to the STDERR so they don't end up in
 the diff output
In-Reply-To: <bug-27150-0@https.bugs.webkit.org/>
References: <bug-27150-0@https.bugs.webkit.org/>
Message-ID: <20090710181811.4CF9D32967CE@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has asked  for review:
Bug 27150: REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines into
the diff
https://bugs.webkit.org/show_bug.cgi?id=27150

Attachment 32564:	  Print prepare-ChangeLog's reminders to the STDERR so
they don't end up in the diff output
https://bugs.webkit.org/attachment.cgi?id=32564&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 11:18:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:18:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27079]
 sort-Xcode-project-file should sort case-insensitively,
 to match Xcode's files list : [Attachment 32563] Use case-insensitive
 comparisons when sorting Xcode project files
In-Reply-To: <bug-27079-0@https.bugs.webkit.org/>
References: <bug-27079-0@https.bugs.webkit.org/>
Message-ID: <20090710181823.13C2032967EF@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 27079: sort-Xcode-project-file should sort case-insensitively, to match
Xcode's files list
https://bugs.webkit.org/show_bug.cgi?id=27079

Attachment 32563:	  Use case-insensitive comparisons when sorting Xcode
project files
https://bugs.webkit.org/attachment.cgi?id=32563&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me!

Please run the script and commit the results after you're done (with no
additional changes to the Xcode projects, please :).

From bugzilla-daemon at webkit.org  Fri Jul 10 11:20:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:20:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27151] [XSSAuditor]
 JavaScript URLs with null/control characters bypass XSSAuditor :
 [Attachment 32565] Patch with tests
In-Reply-To: <bug-27151-0@https.bugs.webkit.org/>
References: <bug-27151-0@https.bugs.webkit.org/>
Message-ID: <20090710182023.F22A932968C5@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27151: [XSSAuditor] JavaScript URLs with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27151

Attachment 32565: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32565&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 11:21:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:21:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27152] Crash when changing
 the zoom level in http://iphone.akamai.com/ : [Attachment 32566] Patch
In-Reply-To: <bug-27152-0@https.bugs.webkit.org/>
References: <bug-27152-0@https.bugs.webkit.org/>
Message-ID: <20090710182110.B09E0329692A@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27152: Crash when changing the zoom level in http://iphone.akamai.com/
https://bugs.webkit.org/show_bug.cgi?id=27152

Attachment 32566: Patch
https://bugs.webkit.org/attachment.cgi?id=32566&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 11:43:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:43:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32567]
 Addressing Mads' comments and merging with new head
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090710184329.086BE32971CD@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32567: Addressing Mads' comments and merging with new head
https://bugs.webkit.org/attachment.cgi?id=32567&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 11:43:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:43:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32525]
 Do not generate long boolen expression unless ASSERTs enabled
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090710184329.06B2B32971CB@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has canceled anton muhin
<antonm at chromium.org>'s request for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32525: Do not generate long boolen expression unless ASSERTs enabled
https://bugs.webkit.org/attachment.cgi?id=32525&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 11:46:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:46:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27152] Crash when changing
 the zoom level in http://iphone.akamai.com/ : [Attachment 32566] Patch
In-Reply-To: <bug-27152-0@https.bugs.webkit.org/>
References: <bug-27152-0@https.bugs.webkit.org/>
Message-ID: <20090710184636.52F373297343@gamma.macosforge.org>

John Sullivan <sullivan at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 27152: Crash when changing the zoom level in http://iphone.akamai.com/
https://bugs.webkit.org/show_bug.cgi?id=27152

Attachment 32566: Patch
https://bugs.webkit.org/attachment.cgi?id=32566&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
ChangeLog comments could be improved by explaining that
updateLayerListsIfNeeded was split into two functions, and the existing title
was kept for the one that does less work.

From bugzilla-daemon at webkit.org  Fri Jul 10 11:48:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:48:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27150] REGRESSION (r45647):
 prepare-ChangeLog -d puts non-diff lines into the diff : [Attachment 32564]
 Print prepare-ChangeLog's reminders to the STDERR so they don't end up in
 the diff output
In-Reply-To: <bug-27150-0@https.bugs.webkit.org/>
References: <bug-27150-0@https.bugs.webkit.org/>
Message-ID: <20090710184833.F3D3B329742E@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Adam Roben (aroben)
<aroben at apple.com>'s request for review:
Bug 27150: REGRESSION (r45647): prepare-ChangeLog -d puts non-diff lines into
the diff
https://bugs.webkit.org/show_bug.cgi?id=27150

Attachment 32564:	  Print prepare-ChangeLog's reminders to the STDERR so
they don't end up in the diff output
https://bugs.webkit.org/attachment.cgi?id=32564&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 11:59:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:59:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27136] [Qt] Webkit hangs
 when executing an infinite JavaScript loop : [Attachment 32568] Replace the
 signal with QMetaObject::invokeMethod
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710185949.69DBA3297931@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32568: Replace the signal with QMetaObject::invokeMethod
https://bugs.webkit.org/attachment.cgi?id=32568&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Third time is a charm :-)

From bugzilla-daemon at webkit.org  Fri Jul 10 11:59:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 11:59:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27136] [Qt] Webkit hangs
 when executing an infinite JavaScript loop : [Attachment 32561] Replace
 virtual method with signal/slot
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710185949.5CD33329792F@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has canceled Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32561: Replace virtual method with signal/slot
https://bugs.webkit.org/attachment.cgi?id=32561&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Third time is a charm :-)

From bugzilla-daemon at webkit.org  Fri Jul 10 12:04:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:04:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27153] Add delegate methods
 about focus and blur and state change : [Attachment 32569] This patch
 implements the needed changes
In-Reply-To: <bug-27153-0@https.bugs.webkit.org/>
References: <bug-27153-0@https.bugs.webkit.org/>
Message-ID: <20090710190419.825673297AD5@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27153: Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Attachment 32569: This patch implements the needed changes
https://bugs.webkit.org/attachment.cgi?id=32569&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 12:08:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:08:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27153] Add delegate methods
 about focus and blur and state change : [Attachment 32569] This patch
 implements the needed changes
In-Reply-To: <bug-27153-0@https.bugs.webkit.org/>
References: <bug-27153-0@https.bugs.webkit.org/>
Message-ID: <20090710190839.7FC853297CE1@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has canceled Greg Bolsinga
<bolsinga at apple.com>'s request for review:
Bug 27153: Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Attachment 32569: This patch implements the needed changes
https://bugs.webkit.org/attachment.cgi?id=32569&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 12:08:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:08:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27153] Add delegate methods
 about focus and blur and state change : [Attachment 32570] Remove the
 FrameView diff; it wasn't supposed to be there.
In-Reply-To: <bug-27153-0@https.bugs.webkit.org/>
References: <bug-27153-0@https.bugs.webkit.org/>
Message-ID: <20090710190839.8E15D3297CE3@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27153: Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Attachment 32570: Remove the FrameView diff; it wasn't supposed to be there.
https://bugs.webkit.org/attachment.cgi?id=32570&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 12:08:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:08:50 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27136] [Qt] Webkit hangs when
 executing an infinite JavaScript loop : [Attachment 32568] Replace the
 signal with QMetaObject::invokeMethod
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710190850.412EF3297D0B@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32568: Replace the signal with QMetaObject::invokeMethod
https://bugs.webkit.org/attachment.cgi?id=32568&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
> Index: WebKit/qt/WebCoreSupport/ChromeClientQt.cpp
> ===================================================================
> --- WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	(revision 45709)
> +++ WebKit/qt/WebCoreSupport/ChromeClientQt.cpp	(working copy)
> @@ -288,8 +288,7 @@
>  
>  bool ChromeClientQt::shouldInterruptJavaScript()
>  {
> -    notImplemented();
> -    return false;
> +    return QMetaObject::invokeMethod(m_webPage, "shouldInterruptJavaScript",
Qt::DirectConnection);

I don't think this is correct, invokeMethod returns a boolean indicating
whether the function could be called or not, but the return value itself is
placed in the fourth argument of invokeMethod.

Also a unit test would be good for this :)

An alternate solution would be to use QWebPage::supportsExtension and
QWebPage::extension. Holger, do you have any preference?





I

From bugzilla-daemon at webkit.org  Fri Jul 10 12:23:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:23:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27103] Upstream
 V8NPObject.h and V8NPObject.cpp : [Attachment 32571] Address Dimitiri's
 comments. Also update with latest changes downstream due to V8Proxy
 refactor
In-Reply-To: <bug-27103-0@https.bugs.webkit.org/>
References: <bug-27103-0@https.bugs.webkit.org/>
Message-ID: <20090710192353.BC6D732983AF@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103

Attachment 32571: Address Dimitiri's comments.	Also update with latest changes
downstream due to V8Proxy refactor
https://bugs.webkit.org/attachment.cgi?id=32571&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 12:39:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:39:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27103] Upstream V8NPObject.h
 and V8NPObject.cpp : [Attachment 32571] Address Dimitiri's comments. Also
 update with latest changes downstream due to V8Proxy refactor
In-Reply-To: <bug-27103-0@https.bugs.webkit.org/>
References: <bug-27103-0@https.bugs.webkit.org/>
Message-ID: <20090710193959.924833298AA5@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has canceled Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103

Attachment 32571: Address Dimitiri's comments.	Also update with latest changes
downstream due to V8Proxy refactor
https://bugs.webkit.org/attachment.cgi?id=32571&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 12:44:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 12:44:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs
 a way to override settings on a per-test basis : [Attachment 32572] Fixed
 and cleaned patch.
In-Reply-To: <bug-20534-0@https.bugs.webkit.org/>
References: <bug-20534-0@https.bugs.webkit.org/>
Message-ID: <20090710194441.89E2D3298CC0@gamma.macosforge.org>

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 32572: Fixed and cleaned patch.
https://bugs.webkit.org/attachment.cgi?id=32572&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I'd like to help move it forward.
I've merged the patch and changed the method naming per Maciej's suggestion. It
runs all the tests fine (on Mac).

From bugzilla-daemon at webkit.org  Fri Jul 10 13:10:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:10:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 19562] ValidityState object
 stub : [Attachment 32557] ValidityState full patch
In-Reply-To: <bug-19562-0@https.bugs.webkit.org/>
References: <bug-19562-0@https.bugs.webkit.org/>
Message-ID: <20090710201001.121BE32998FF@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 19562: ValidityState object stub
https://bugs.webkit.org/show_bug.cgi?id=19562

Attachment 32557: ValidityState full patch
https://bugs.webkit.org/attachment.cgi?id=32557&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 13:12:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:12:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27153] Add delegate methods
 about focus and blur and state change : [Attachment 32570] Remove the
 FrameView diff; it wasn't supposed to be there.
In-Reply-To: <bug-27153-0@https.bugs.webkit.org/>
References: <bug-27153-0@https.bugs.webkit.org/>
Message-ID: <20090710201217.1D33732999F3@gamma.macosforge.org>

Antti Koivisto <koivisto at iki.fi> has granted Greg Bolsinga
<bolsinga at apple.com>'s request for review:
Bug 27153: Add delegate methods about focus and blur and state change
https://bugs.webkit.org/show_bug.cgi?id=27153

Attachment 32570: Remove the FrameView diff; it wasn't supposed to be there.
https://bugs.webkit.org/attachment.cgi?id=32570&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 13:13:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:13:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27103] Upstream
 V8NPObject.h and V8NPObject.cpp : [Attachment 32571] Address Dimitiri's
 comments. Also update with latest changes downstream due to V8Proxy
 refactor
In-Reply-To: <bug-27103-0@https.bugs.webkit.org/>
References: <bug-27103-0@https.bugs.webkit.org/>
Message-ID: <20090710201344.6BB5F3299AC1@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103

Attachment 32571: Address Dimitiri's comments.	Also update with latest changes
downstream due to V8Proxy refactor
https://bugs.webkit.org/attachment.cgi?id=32571&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 13:16:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:16:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27151] [XSSAuditor] JavaScript
 URLs with null/control characters bypass XSSAuditor : [Attachment 32565]
 Patch with tests
In-Reply-To: <bug-27151-0@https.bugs.webkit.org/>
References: <bug-27151-0@https.bugs.webkit.org/>
Message-ID: <20090710201657.95D3E3299C3E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27151: [XSSAuditor] JavaScript URLs with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27151

Attachment 32565: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=32565&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good, but can you make the same change to the V8 bindings in
WebCore/bindings/v8?

From bugzilla-daemon at webkit.org  Fri Jul 10 13:29:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:29:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27103] Upstream V8NPObject.h
 and V8NPObject.cpp : [Attachment 32571] Address Dimitiri's comments. Also
 update with latest changes downstream due to V8Proxy refactor
In-Reply-To: <bug-27103-0@https.bugs.webkit.org/>
References: <bug-27103-0@https.bugs.webkit.org/>
Message-ID: <20090710202938.6CD49329A27F@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27103: Upstream V8NPObject.h and V8NPObject.cpp
https://bugs.webkit.org/show_bug.cgi?id=27103

Attachment 32571: Address Dimitiri's comments.	Also update with latest changes
downstream due to V8Proxy refactor
https://bugs.webkit.org/attachment.cgi?id=32571&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 13:35:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:35:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27151] [XSSAuditor]
 JavaScript URLs with null/control characters bypass XSSAuditor :
 [Attachment 32573] Updated patch with tests.
In-Reply-To: <bug-27151-0@https.bugs.webkit.org/>
References: <bug-27151-0@https.bugs.webkit.org/>
Message-ID: <20090710203524.0BAAA329A57F@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27151: [XSSAuditor] JavaScript URLs with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27151

Attachment 32573: Updated patch with tests.
https://bugs.webkit.org/attachment.cgi?id=32573&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
I made the changes in the V8 bindings, but how do I test it?

Also, moved line "const String* savedSourceURL = m_sourceURL;" to its original
place in file WebCore/bindings/js/ScriptController.cpp.

From bugzilla-daemon at webkit.org  Fri Jul 10 13:38:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:38:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27088] WebKit constructors
 use wrong global object/prototype chain : [Attachment 32574] patch
In-Reply-To: <bug-27088-0@https.bugs.webkit.org/>
References: <bug-27088-0@https.bugs.webkit.org/>
Message-ID: <20090710203814.D4926329A6FC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27088: WebKit constructors use wrong global object/prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27088

Attachment 32574: patch
https://bugs.webkit.org/attachment.cgi?id=32574&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 13:39:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:39:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27151] [XSSAuditor]
 JavaScript URLs with null/control characters bypass XSSAuditor :
 [Attachment 32573] Updated patch with tests.
In-Reply-To: <bug-27151-0@https.bugs.webkit.org/>
References: <bug-27151-0@https.bugs.webkit.org/>
Message-ID: <20090710203927.D8686329A787@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27151: [XSSAuditor] JavaScript URLs with null/control characters bypass
XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27151

Attachment 32573: Updated patch with tests.
https://bugs.webkit.org/attachment.cgi?id=32573&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good.  To test the V8 bindings, you need a Chromium build.  I'll
watch the chromium build bot to make sure it works fine.

From bugzilla-daemon at webkit.org  Fri Jul 10 13:39:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:39:47 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27088] WebKit constructors
 use wrong global object/prototype chain : [Attachment 32574] patch
In-Reply-To: <bug-27088-0@https.bugs.webkit.org/>
References: <bug-27088-0@https.bugs.webkit.org/>
Message-ID: <20090710203947.D38B5329A7C8@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27088: WebKit constructors use wrong global object/prototype chain
https://bugs.webkit.org/show_bug.cgi?id=27088

Attachment 32574: patch
https://bugs.webkit.org/attachment.cgi?id=32574&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sorry, wrong bug.

From bugzilla-daemon at webkit.org  Fri Jul 10 13:39:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:39:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27157] rename
 getDOMStructure calls w/o JSGlobalObject* to deprecatedGetDOMStructure :
 [Attachment 32575] patch
In-Reply-To: <bug-27157-0@https.bugs.webkit.org/>
References: <bug-27157-0@https.bugs.webkit.org/>
Message-ID: <20090710203959.4753A329A7EF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27157: rename getDOMStructure calls w/o JSGlobalObject* to
deprecatedGetDOMStructure
https://bugs.webkit.org/show_bug.cgi?id=27157

Attachment 32575: patch
https://bugs.webkit.org/attachment.cgi?id=32575&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 13:40:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:40:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27157] rename getDOMStructure
 calls w/o JSGlobalObject* to deprecatedGetDOMStructure : [Attachment 32575]
 patch
In-Reply-To: <bug-27157-0@https.bugs.webkit.org/>
References: <bug-27157-0@https.bugs.webkit.org/>
Message-ID: <20090710204051.015A9329A87E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27157: rename getDOMStructure calls w/o JSGlobalObject* to
deprecatedGetDOMStructure
https://bugs.webkit.org/show_bug.cgi?id=27157

Attachment 32575: patch
https://bugs.webkit.org/attachment.cgi?id=32575&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 13:47:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:47:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27136] [Qt] Webkit hangs
 when executing an infinite JavaScript loop : [Attachment 32576] Added test
 case
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710204731.16ACB329AB97@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32576: Added test case
https://bugs.webkit.org/attachment.cgi?id=32576&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
I am thinking that using the extension is probably an overkill for this
feature. It is very similar to JavaScript alert implementation. However, if
there is a strong opinion otherwise, I will modify it again.

From bugzilla-daemon at webkit.org  Fri Jul 10 13:49:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:49:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22784] Home and End buttons
 do not do anything in drop down lists : [Attachment 32577] Fixes bug 22784
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090710204938.4F8EB329AC89@gamma.macosforge.org>

Jens Alfke <snej at google.com> has asked	for review:
Bug 22784: Home and End buttons do not do anything in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 32577: Fixes bug 22784
https://bugs.webkit.org/attachment.cgi?id=32577&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 13:52:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:52:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32567]
 Addressing Mads' comments and merging with new head
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090710205206.26CC0329ADA3@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32567: Addressing Mads' comments and merging with new head
https://bugs.webkit.org/attachment.cgi?id=32567&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Definitely #ifndef NDEBUG. Looks fine otherwise.

From bugzilla-daemon at webkit.org  Fri Jul 10 13:52:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 13:52:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32567]
 Addressing Mads' comments and merging with new head
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090710205236.A02AA329ADDB@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has canceled  review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32567: Addressing Mads' comments and merging with new head
https://bugs.webkit.org/attachment.cgi?id=32567&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I'll clear review flag until you have a newer patch.

From bugzilla-daemon at webkit.org  Fri Jul 10 14:11:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:11:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home and End
 buttons do not do anything in drop down lists : [Attachment 32577] Fixes
 bug 22784
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090710211135.727AB329B617@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Jens Alfke <snej at google.com>'s
request for review:
Bug 22784: [Chromium] Home and End buttons do not do anything in drop down
lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 32577: Fixes bug 22784
https://bugs.webkit.org/attachment.cgi?id=32577&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> -#if PLATFORM(MAC)
> +// On Mac (Safari or Chrome), pop up the menu if the user presses the arrow
keys
> +// while a Select element has focus. On other platforms, just change the
selection.
> +#if PLATFORM(DARWIN) && !PLATFORM(IPHONE)
>  #define ARROW_KEYS_POP_MENU 1
>  #else
>  #define ARROW_KEYS_POP_MENU 0

Another minor comment: Mac WebKit is more than just Safari, so it doesn't makes
too much sense to mention Safari here.

> +#if !ARROW_KEYS_POP_MENU
> +// Returns the index of the next valid list item in direction |dir| past
|listIndex|.
> +static int nextValidIndex(int listIndex, int dir, const Vector<Element*>&
listItems) {
> +    ASSERT(dir!=0);
> +    int size = listItems.size();
> +    for (listIndex += dir; listIndex >= 0 && listIndex < size; listIndex +=
dir) {
> +	   if (!listItems[listIndex]->disabled() &&
isOptionElement(listItems[listIndex]))
> +	       return listIndex;
> +    }
> +    return -1;
> +}
> +#endif

There are some minor style issues here (brace on same line as function
definition, lack of whitespace around operators).  We also prefer not to
unnecessarily abbreviate variable names such as "dir".	It may be clearer to
use an enum rather than magic values such as -1 and 1 to represent up and down
as the directions.

From bugzilla-daemon at webkit.org  Fri Jul 10 14:46:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:46:03 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home and End
 buttons do not do anything in drop down lists : [Attachment 32580] 2nd
 patch
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090710214603.B537C329C3B0@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Jens Alfke <snej at google.com>'s
request for review:
Bug 22784: [Chromium] Home and End buttons do not do anything in drop down
lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 32580: 2nd patch
https://bugs.webkit.org/attachment.cgi?id=32580&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/dom/SelectElement.cpp
> ===================================================================
> --- WebCore/dom/SelectElement.cpp	(revision 45713)
> +++ WebCore/dom/SelectElement.cpp	(working copy)
> @@ -47,7 +47,10 @@
>  #include "WMLSelectElement.h"
>  #endif
>  
> -#if PLATFORM(MAC)
> +// On Mac OS, pop up the menu if the user presses the arrow keys while a
Select element has focus.
> +// On other platforms, just change the selection.
> +// (Cannot just test PLATFORM(MAC), because that is false in Chromium due to
its AppKit assumptions.)
> +#if PLATFORM(DARWIN) && !PLATFORM(GTK) && !PLATFORM(WX)
>  #define ARROW_KEYS_POP_MENU 1
>  #else
>  #define ARROW_KEYS_POP_MENU 0

At the very least this is not correct because it omits Qt.  Thinking about this
a little more, I suspect what you really want is PLATFORM(MAC) ||
(PLATFORM(CHROMIUM) && PLATFORM(DARWIN))

Marking as r- due to this and the other unaddressed comments.

From bugzilla-daemon at webkit.org  Fri Jul 10 14:47:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:47:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25463] Desktop Notifications
 API : [Attachment 32342] Notifications API, V8 Bindings
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090710214736.524CC329C463@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has canceled John Gregg <johnnyg at google.com>'s
request for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 32342: Notifications API, V8 Bindings
https://bugs.webkit.org/attachment.cgi?id=32342&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 14:48:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:48:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27136] [Qt] Webkit hangs when
 executing an infinite JavaScript loop : [Attachment 32576] Added test case
In-Reply-To: <bug-27136-0@https.bugs.webkit.org/>
References: <bug-27136-0@https.bugs.webkit.org/>
Message-ID: <20090710214822.3E40D329C4C5@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27136: [Qt] Webkit hangs when executing an infinite JavaScript loop
https://bugs.webkit.org/show_bug.cgi?id=27136

Attachment 32576: Added test case
https://bugs.webkit.org/attachment.cgi?id=32576&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Yael wants to fix it before landing. So r=+ for me. We might have to discuss on
monday if extensions are better...

From bugzilla-daemon at webkit.org  Fri Jul 10 14:50:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:50:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27133] [Chromium] Upstream
 RGBColor : [Attachment 32562] patch2 - moved to WebCore/css/
In-Reply-To: <bug-27133-0@https.bugs.webkit.org/>
References: <bug-27133-0@https.bugs.webkit.org/>
Message-ID: <20090710215028.1063E329C5B4@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Nate Chapin <japhet at chromium.org>'s
request for review:
Bug 27133: [Chromium] Upstream RGBColor
https://bugs.webkit.org/show_bug.cgi?id=27133

Attachment 32562: patch2 - moved to WebCore/css/
https://bugs.webkit.org/attachment.cgi?id=32562&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> +
> +    class RGBColor : public RefCounted<RGBColor> {
> +    public:
> +	   // TODO(ager): Make constructor private once codegenerator changes
> +	   // have landed upstream.

We prefer FIXME, instead of TODO(name).

From bugzilla-daemon at webkit.org  Fri Jul 10 14:53:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:53:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27054] Renamed Translator to
 HashTranslator : [Attachment 32414] Code patch for HashSet.h
In-Reply-To: <bug-27054-0@https.bugs.webkit.org/>
References: <bug-27054-0@https.bugs.webkit.org/>
Message-ID: <20090710215311.39779329C713@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27054: Renamed Translator to HashTranslator
https://bugs.webkit.org/show_bug.cgi?id=27054

Attachment 32414: Code patch for HashSet.h
https://bugs.webkit.org/attachment.cgi?id=32414&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 14:58:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 14:58:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32581] Patch that
 fixes XHR's confusing the max-connections-per-host count.
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090710215856.DA3C3329C955@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32581: Patch that fixes XHR's confusing the max-connections-per-host
count.
https://bugs.webkit.org/attachment.cgi?id=32581&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Patch that fixes XHR's confusing the max-connections-per-host count.

I think we should land this very localized fix while we hash out a reworking of
the Loader::Host mechanism that tracks connections-per-host at the
ResourceHandle level.

(a test case is coming)

From bugzilla-daemon at webkit.org  Fri Jul 10 15:10:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:10:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27058] Removed superfluous
 parenthesis around single expression : [Attachment 32417] Code patch for
 Platform.h
In-Reply-To: <bug-27058-0@https.bugs.webkit.org/>
References: <bug-27058-0@https.bugs.webkit.org/>
Message-ID: <20090710221026.B13BA329CE1A@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27058: Removed superfluous parenthesis around single expression
https://bugs.webkit.org/show_bug.cgi?id=27058

Attachment 32417: Code patch for Platform.h
https://bugs.webkit.org/attachment.cgi?id=32417&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 15:19:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:19:36 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32581] Patch that
 fixes XHR's confusing the max-connections-per-host count.
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090710221936.1B796329D1CD@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has denied Brady Eidson <beidson at apple.com>'s
request for review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32581: Patch that fixes XHR's confusing the max-connections-per-host
count.
https://bugs.webkit.org/attachment.cgi?id=32581&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Sent out wrong version, fixing soon.

From bugzilla-daemon at webkit.org  Fri Jul 10 15:26:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:26:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 32583] Initial Patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090710222655.B2C6F329D491@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32583: Initial Patch
https://bugs.webkit.org/attachment.cgi?id=32583&action=review

------- Additional Comments from robert <robert at roberthogan.net>
The approach is to treat WebCore/Configurations/Version.xcconfig as the
definitive place for version information. If parsing that file fails, Qt will
default to a version number hardcode in WebKit.pri, and failing that a version
hardcoded in qwebkitversion.cpp.

Things I'm not sure about yet:

- Choice of hard-coded version number if parsing Version.xcconfig fails -
currently 531.3.
- Have only tested the following qmake macro on Linux. It should work on all
other platforms, but not 100% certain.

+MAJOR_VERSION = $$system(perl WebKitTools/Scripts/get-webkit-version --major \

+			  WebCore/Configurations/Version.xcconfig)

From bugzilla-daemon at webkit.org  Fri Jul 10 15:43:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:43:37 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home and End
 buttons do not do anything in drop down lists : [Attachment 32582] updated
 patch
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090710224337.87733329DB39@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Jens Alfke <snej at google.com>'s
request for review:
Bug 22784: [Chromium] Home and End buttons do not do anything in drop down
lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 32582: updated patch
https://bugs.webkit.org/attachment.cgi?id=32582&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45720)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,24 @@
> +2009-07-10  Jens Alfke  <snej at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Bug 22784: Home/End and PageUp/PageDn buttons do not do anything in
drop down lists,
> +		on non-Mac platforms (nor in the Mac build of Chromium.)
> +		https://bugs.webkit.org/show_bug.cgi?id=22784
> +		http://code.google.com/p/chromium/issues/detail?id=4576
> +
> +
> +	   No new tests; affects only user input handling, not layout or
rendering.
> +
> +	   * dom/SelectElement.cpp:
> +		Changed definition of ARROW_KEYS_POP_MENU to make it true in
Mac Chromium,
> +		so it will behave compatibly with Mac HI guidelines on pop-up
menus.
> +		It's not possible to have PLATFORM(MAC) be true in the Mac
build of Chromium.
> +	   (WebCore::nextValidIndex): 
> +		New utility fn for traversing items of a select's list.
> +	   (WebCore::SelectElement::menuListDefaultEventHandler):
> +		Added code to handle Home/End and PageUp/PageDn when
ARROW_KEYS_POP_MENU is false.

There are lots of tabs in this ChangeLog entry.  Our SVN pre-commit hook will
be unhappy with these, so it would be best to remove them.

> +#if !ARROW_KEYS_POP_MENU
> +// Returns the index of the next valid list item before or after
|listIndex|.
> +static int nextValidIndex(int listIndex, bool forward, const
Vector<Element*>& listItems)
> +{
> +    int skip = forward ? 1 : -1;

Is there a reason that you switched to a boolean argument rather than the enum
that I suggested?  At the call site you don't have the context of the argument
name to indicate what the true or false represent. An enum value is
understandable at a glance, even at the call site.

The rest of the patch looks good.  It should be landable when these two minor
issues are addressed.

From bugzilla-daemon at webkit.org  Fri Jul 10 15:51:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:51:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32585] Updated
 (removed overzealous decrement in internalAbort())
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090710225112.37A70329DE52@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32585: Updated (removed overzealous decrement in internalAbort())
https://bugs.webkit.org/attachment.cgi?id=32585&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Still fixing up a layout test but this is the patch to go with!

From bugzilla-daemon at webkit.org  Fri Jul 10 15:52:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:52:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32586] Take away space out of
 ARROW_KEYS_POP_MENU and into SPACE_POP_MENU for platforms that display the
 popup when spacebar is pressed
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090710225239.87DEF329DEF6@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32586: Take away space out of ARROW_KEYS_POP_MENU and into
SPACE_POP_MENU for platforms that display the popup when spacebar is pressed
https://bugs.webkit.org/attachment.cgi?id=32586&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
The patch takes away space (' ') out of ARROW_KEYS_POP_MENU and into
SPACE_POP_MENU for platforms that want to display a popup menu when spacebar is
pressed.

No change in behaviour except for Gtk.

From bugzilla-daemon at webkit.org  Fri Jul 10 15:54:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:54:23 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32585] Updated
 (removed overzealous decrement in internalAbort())
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090710225423.DC6E3329DFD5@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has canceled Brady Eidson
<beidson at apple.com>'s request for review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32585: Updated (removed overzealous decrement in internalAbort())
https://bugs.webkit.org/attachment.cgi?id=32585&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 15:54:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:54:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32587] Now as a
 patch
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090710225424.0371B329DFD9@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32587: Now as a patch
https://bugs.webkit.org/attachment.cgi?id=32587&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 15:57:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:57:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32546] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090710225753.78636329E13F@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32546: win patch
https://bugs.webkit.org/attachment.cgi?id=32546&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
same patch + WebCore/WebCore.gypi changes.

From bugzilla-daemon at webkit.org  Fri Jul 10 15:57:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:57:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32588] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090710225753.8A0EC329E141@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32588: win patch
https://bugs.webkit.org/attachment.cgi?id=32588&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
same patch + WebCore/WebCore.gypi changes.

From bugzilla-daemon at webkit.org  Fri Jul 10 15:59:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 15:59:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32587] Now as a
 patch
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090710225947.C42D3329E20C@gamma.macosforge.org>

Antti Koivisto <koivisto at iki.fi> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32587: Now as a patch
https://bugs.webkit.org/attachment.cgi?id=32587&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
> +    if (m_didTellLoaderAboutRequest) {
> +	       cache()->loader()->nonCacheRequestComplete(m_url);
> +	       m_didTellLoaderAboutRequest = false;
> +    }

Double indentation here.

r=me

From bugzilla-daemon at webkit.org  Fri Jul 10 16:05:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:05:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27155] bug in V8Custom
 invokeCallback which will crash on void callbacks : [Attachment 32589] Fix
 the logic for computing the return value
In-Reply-To: <bug-27155-0@https.bugs.webkit.org/>
References: <bug-27155-0@https.bugs.webkit.org/>
Message-ID: <20090710230533.CF5AC329E43B@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has asked  for review:
Bug 27155: bug in V8Custom invokeCallback which will crash on void callbacks
https://bugs.webkit.org/show_bug.cgi?id=27155

Attachment 32589: Fix the logic for computing the return value
https://bugs.webkit.org/attachment.cgi?id=32589&action=review

------- Additional Comments from John Gregg <johnnyg at google.com>
One-character fix to the logic for computing the return value.

From bugzilla-daemon at webkit.org  Fri Jul 10 16:25:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:25:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27155] bug in V8Custom
 invokeCallback which will crash on void callbacks : [Attachment 32589] Fix
 the logic for computing the return value
In-Reply-To: <bug-27155-0@https.bugs.webkit.org/>
References: <bug-27155-0@https.bugs.webkit.org/>
Message-ID: <20090710232532.398E2329EC8D@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted John Gregg <johnnyg at google.com>'s
request for review:
Bug 27155: bug in V8Custom invokeCallback which will crash on void callbacks
https://bugs.webkit.org/show_bug.cgi?id=27155

Attachment 32589: Fix the logic for computing the return value
https://bugs.webkit.org/attachment.cgi?id=32589&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 16:34:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:34:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27163] Fix memory leak in
 V8 bindings : [Attachment 32591] patch to avoid leaking contexts
In-Reply-To: <bug-27163-0@https.bugs.webkit.org/>
References: <bug-27163-0@https.bugs.webkit.org/>
Message-ID: <20090710233416.0732B329F03E@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27163: Fix memory leak in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27163

Attachment 32591: patch to avoid leaking contexts
https://bugs.webkit.org/attachment.cgi?id=32591&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 16:42:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:42:09 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32403] proposed patch with a fix to AbstractWorker::toJS()
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090710234209.31438329F31C@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32403: proposed patch with a fix to AbstractWorker::toJS()
https://bugs.webkit.org/attachment.cgi?id=32403&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Code base keeps changing underneath me - updated patch to reflect latest
revision.

From bugzilla-daemon at webkit.org  Fri Jul 10 16:42:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:42:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32592] Patch including changes to newly-upstreamed gypi files,
 and a couple of layout test "expected.txt" files I missed.
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090710234209.4A765329F320@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked David Levin <levin at chromium.org>
for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32592: Patch including changes to newly-upstreamed gypi files, and a
couple of layout test "expected.txt" files I missed.
https://bugs.webkit.org/attachment.cgi?id=32592&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Code base keeps changing underneath me - updated patch to reflect latest
revision.

From bugzilla-daemon at webkit.org  Fri Jul 10 16:44:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:44:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25205] XMLHttpRequest
 instance is not an instanceof XMLHttpRequest : [Attachment 32547] Removed
 virtual destructor declaration of DOMConstructorObject.
In-Reply-To: <bug-25205-0@https.bugs.webkit.org/>
References: <bug-25205-0@https.bugs.webkit.org/>
Message-ID: <20090710234449.DE4C5329F44C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 25205: XMLHttpRequest instance is not an instanceof XMLHttpRequest
https://bugs.webkit.org/show_bug.cgi?id=25205

Attachment 32547: Removed virtual destructor declaration of
DOMConstructorObject.
https://bugs.webkit.org/attachment.cgi?id=32547&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 16:53:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:53:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32592] Patch including changes to newly-upstreamed gypi files,
 and a couple of layout test "expected.txt" files I missed.
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090710235326.A0373329F7EB@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32592: Patch including changes to newly-upstreamed gypi files, and a
couple of layout test "expected.txt" files I missed.
https://bugs.webkit.org/attachment.cgi?id=32592&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 16:53:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 16:53:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32593] More style fixups per levin's review.
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090710235326.B92EA329F7EF@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked David Levin <levin at chromium.org>
for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32593: More style fixups per levin's review.
https://bugs.webkit.org/attachment.cgi?id=32593&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 17:04:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 17:04:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 32560] cleanup. update patch to svn r45707
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090711000447.7E78D329FC55@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 32560: cleanup.  update patch to svn r45707
https://bugs.webkit.org/attachment.cgi?id=32560&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> Index: WebCore/platform/Pasteboard.h
> ===================================================================
> --- WebCore/platform/Pasteboard.h	(revision 45707)
> +++ WebCore/platform/Pasteboard.h	(working copy)
> @@ -102,6 +102,7 @@ public:
>  
>  #if PLATFORM(GTK)
>      void setHelper(PasteboardHelper*);
> +    PasteboardHelper* m_helper;
>  #endif

Is there any reason for this change?

> -    if ((gint)info == WEBKIT_WEB_VIEW_TARGET_INFO_HTML) {
> +    if ((gint)info ==
Pasteboard::generalPasteboard()->m_helper->getWebViewTargetInfoHtml()) {

I think calling generalPasteboard() is unnecessary here.

> +    virtual gint getWebViewTargetInfoHtml() const = 0;

What's this for?

Looks fine otherwise. r- for now as the patch needs to be revised.

From bugzilla-daemon at webkit.org  Fri Jul 10 17:51:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 17:51:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27167]
 <http://webkit.org/bugs/BUGID> bugzilla-tool: hide help for unsupported
 commands : [Attachment 32596] Patch v1
In-Reply-To: <bug-27167-0@https.bugs.webkit.org/>
References: <bug-27167-0@https.bugs.webkit.org/>
Message-ID: <20090711005140.173B432A0E6F@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27167: <http://webkit.org/bugs/BUGID> bugzilla-tool: hide help for
unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32596: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32596&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

When bugzilla-tool -h|--help is invoked in an svn working
directory, don't print help for commands that are only supported
on git working directories.

* Scripts/bugzilla-tool:
(Command.requires_local_commits): Added.  Must be implemented by
all subclasses.
(BugsInCommitQueue.requires_local_commits): Added.
(PatchesInCommitQueue.requires_local_commits): Added.
(ReviewedPatchesOnBug.requires_local_commits): Added.
(ApplyPatchesFromBug.requires_local_commits): Added.
(LandAndUpdateBug.requires_local_commits): Added.
(LandPatchesFromBugs.requires_local_commits): Added.
(CommitMessageForCurrentDiff.requires_local_commits): Added.
(ObsoleteAttachmentsOnBug.requires_local_commits): Added.
(PostDiffAsPatchToBug.requires_local_commits): Added.
(PostCommitsAsPatchesToBug.execute): Removed
SCM.supports_local_commits() check since this is now handled by
BugzillaTool.main().
(PostCommitsAsPatchesToBug.requires_local_commits): Added.
(BugzillaTool.commands_usage): Don't print help for commands if
they require local commits and the current SCM doesn't support
them.
(BugzillaTool.main): If command_object requires local commits
and the current SCM doesn't, exit with an error message.
---
 2 files changed, 82 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 10 17:54:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 17:54:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25316] Outdenting a line
 inside a blockquote tag does nothing : [Attachment 32540] fixes the bug
In-Reply-To: <bug-25316-0@https.bugs.webkit.org/>
References: <bug-25316-0@https.bugs.webkit.org/>
Message-ID: <20090711005404.5CCB732A0FAC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32540: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32540&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think we should remove this function:
6060 static bool isIndentBlockquote(const Node* node)

and just use tag-based detection of blockquotes like was the case pre-r17143

Why is:
LayoutTests/platform/mac/editing/execCommand/outdent-selection-expected.txt
changing?  Please explain in your ChagneLog.

Please remove boilerplate from your ChangeLogs:
	 DETAILED DESCRIPTION OF THE CHANGES GOES HERE. (OOPS!) SEE:
 9	   http://webkit.org/coding/contributing.html FOR MORE INFORMATION

You soudl explain all your added tests and changes to tests in your ChangeLogs.


Please explain this change:
     if (enclosingBlockFlow != enclosingNode)
275	     splitBlockquoteNode =
splitTreeToNode(enclosingBlockFlowElement(visibleStartOfParagraph),
enclosingNode, true);
 271	     splitBlockquoteNode = splitTreeToNode(enclosingBlockFlow,
enclosingNode, true);
 272	 else {
 273	     splitElement(static_cast<Element*>(enclosingBlockFlow),
visibleStartOfParagraph.deepEquivalent().node());
 274	     splitBlockquoteNode = enclosingBlockFlow;
 275	 }
in your ChangeLog.

From bugzilla-daemon at webkit.org  Fri Jul 10 17:54:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 17:54:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27104] [V8]
 evaluateInNewContext should send the didCreateScriptContext notification :
 [Attachment 32490] simple patch
In-Reply-To: <bug-27104-0@https.bugs.webkit.org/>
References: <bug-27104-0@https.bugs.webkit.org/>
Message-ID: <20090711005432.D56CD32A1007@gamma.macosforge.org>

Matt Perry <mpComplete at gmail.com> has canceled Matt Perry
<mpComplete at gmail.com>'s request for review:
Bug 27104: [V8] evaluateInNewContext should send the didCreateScriptContext
notification
https://bugs.webkit.org/show_bug.cgi?id=27104

Attachment 32490: simple patch
https://bugs.webkit.org/attachment.cgi?id=32490&action=review

------- Additional Comments from Matt Perry <mpComplete at gmail.com>
OK, instead of having didDestroyScriptContext only sometimes getting called, I
renamed the create/destroy notifications for frames, and added a new one for
evaluateInNewContext.  Hopefully this will make it clearer to callers what to
expect.

From bugzilla-daemon at webkit.org  Fri Jul 10 17:54:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 17:54:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27104] [V8]
 evaluateInNewContext should send the didCreateScriptContext notification :
 [Attachment 32598] new notification
In-Reply-To: <bug-27104-0@https.bugs.webkit.org/>
References: <bug-27104-0@https.bugs.webkit.org/>
Message-ID: <20090711005432.E9C4F32A1009@gamma.macosforge.org>

Matt Perry <mpComplete at gmail.com> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27104: [V8] evaluateInNewContext should send the didCreateScriptContext
notification
https://bugs.webkit.org/show_bug.cgi?id=27104

Attachment 32598: new notification
https://bugs.webkit.org/attachment.cgi?id=32598&action=review

------- Additional Comments from Matt Perry <mpComplete at gmail.com>
OK, instead of having didDestroyScriptContext only sometimes getting called, I
renamed the create/destroy notifications for frames, and added a new one for
evaluateInNewContext.  Hopefully this will make it clearer to callers what to
expect.

From bugzilla-daemon at webkit.org  Fri Jul 10 17:59:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 17:59:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27167] bugzilla-tool: hide
 help for unsupported commands : [Attachment 32596] Patch v1
In-Reply-To: <bug-27167-0@https.bugs.webkit.org/>
References: <bug-27167-0@https.bugs.webkit.org/>
Message-ID: <20090711005926.DBE6832A122F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27167: bugzilla-tool: hide help for unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32596: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32596&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I think this is great, except I would have defaulted "requires_local_commits"
to False, and made it a parameter to the Command constructor (__init__), then
you only need to change about 4 lines of code, instead of all the ones you did
here.

I guess I should r- this since I wouldn't recommend committing as-is, but in
general I think this feature is great!	I would have just used a slightly
different python approach.

basically now:

Command.__init__(self, ..., requires_local_commits=False)

and the few commands which do, call:

	Command.__init__(self, 'r+\'d patches on a bug', 'BUGID',
requires_local_commits=True)

From bugzilla-daemon at webkit.org  Fri Jul 10 18:01:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 18:01:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26924] [Chromium] Linux: fix
 assertion when rendering google.com.kh. : [Attachment 32202] patch
In-Reply-To: <bug-26924-0@https.bugs.webkit.org/>
References: <bug-26924-0@https.bugs.webkit.org/>
Message-ID: <20090711010132.9B3B032A130F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 26924: [Chromium] Linux: fix assertion when rendering google.com.kh.
https://bugs.webkit.org/show_bug.cgi?id=26924

Attachment 32202: patch
https://bugs.webkit.org/attachment.cgi?id=32202&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Fantastic.

From bugzilla-daemon at webkit.org  Fri Jul 10 18:18:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 18:18:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14271] Add preferences key to
 make the inspector dock by default : [Attachment 32544] Windows Patch
In-Reply-To: <bug-14271-0@https.bugs.webkit.org/>
References: <bug-14271-0@https.bugs.webkit.org/>
Message-ID: <20090711011836.B27E632A1979@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14271: Add preferences key to make the inspector dock by default
https://bugs.webkit.org/show_bug.cgi?id=14271

Attachment 32544: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32544&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

In the future please try to avoid attaching patches to closed bugs. File a new
bug instead.

From bugzilla-daemon at webkit.org  Fri Jul 10 18:33:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 18:33:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27167] bugzilla-tool: hide
 help for unsupported commands : [Attachment 32596] Patch v1
In-Reply-To: <bug-27167-0@https.bugs.webkit.org/>
References: <bug-27167-0@https.bugs.webkit.org/>
Message-ID: <20090711013339.DEA3E32A1E83@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27167: bugzilla-tool: hide help for unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32596: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32596&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 18:33:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 18:33:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27167] bugzilla-tool: hide
 help for unsupported commands : [Attachment 32599]
 <http://webkit.org/b/27167> bugzilla-tool: hide help for unsupported
 commands
In-Reply-To: <bug-27167-0@https.bugs.webkit.org/>
References: <bug-27167-0@https.bugs.webkit.org/>
Message-ID: <20090711013342.7A88332A1E9B@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27167: bugzilla-tool: hide help for unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32599:	  <http://webkit.org/b/27167> bugzilla-tool: hide help
for unsupported commands
https://bugs.webkit.org/attachment.cgi?id=32599&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 18:39:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 18:39:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 32518] Patch v1
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090711013920.91BC932A20A3@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 32518: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32518&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 19:06:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 19:06:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25316] Outdenting a line
 inside a blockquote tag does nothing : [Attachment 32601] removes
 isIndentBlockquote as requested
In-Reply-To: <bug-25316-0@https.bugs.webkit.org/>
References: <bug-25316-0@https.bugs.webkit.org/>
Message-ID: <20090711020630.E713832A2A43@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32601: removes isIndentBlockquote as requested
https://bugs.webkit.org/attachment.cgi?id=32601&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 19:14:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 19:14:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26921] [XSSAuditor] HTML
 entities can bypass xssAuditor : [Attachment 32602] Working patch with
 tests
In-Reply-To: <bug-26921-0@https.bugs.webkit.org/>
References: <bug-26921-0@https.bugs.webkit.org/>
Message-ID: <20090711021417.6F62732A2CEB@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 26921: [XSSAuditor] HTML entities can bypass xssAuditor
https://bugs.webkit.org/show_bug.cgi?id=26921

Attachment 32602: Working patch with tests
https://bugs.webkit.org/attachment.cgi?id=32602&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Modified initial patch XSSAuditor::decodeHTMLEntities to more closely match the
functionality in HTMLTokenizer for handling illegal entities by not decoding
them (for example: HTMLTokenizer does not substitute '\0' for &#00, &#x00, but
the PreloadScanner, used by XSSAuditor::decodeHTMLEntities, does). To get
similar behavior, I make a copy of SegmentedString |source| called sourceShadow
before calling the PreloadScanner. If the PreloadScanner returns and invalid
entity e == 0xFFFD, then I swap |source| and |sourceShadow|. Maybe there is a
more efficient way to achieve the same result?

The list of parameters to findInRequest, decodeURL are becoming unwieldy. The
code should be cleaned up, but this may be better to do in a separate bug.

From bugzilla-daemon at webkit.org  Fri Jul 10 19:34:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 19:34:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27170] drawImage method of
 HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment
 32603] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090711023413.05FDF32A3361@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27170: drawImage method of HTMLCanvasElement to accept HTMLVideoElement as
argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32603: patch
https://bugs.webkit.org/attachment.cgi?id=32603&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 19:45:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 19:45:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 14271] Add preferences key
 to make the inspector dock by default : [Attachment 32544] Windows Patch
In-Reply-To: <bug-14271-0@https.bugs.webkit.org/>
References: <bug-14271-0@https.bugs.webkit.org/>
Message-ID: <20090711024519.94ABF32A36E0@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has canceled  review:
Bug 14271: Add preferences key to make the inspector dock by default
https://bugs.webkit.org/show_bug.cgi?id=14271

Attachment 32544: Windows Patch
https://bugs.webkit.org/attachment.cgi?id=32544&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 19:45:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 19:45:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 14271] Add preferences key
 to make the inspector dock by default : [Attachment 22773] Proposed patch
In-Reply-To: <bug-14271-0@https.bugs.webkit.org/>
References: <bug-14271-0@https.bugs.webkit.org/>
Message-ID: <20090711024528.8B26032A36F6@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has canceled  review:
Bug 14271: Add preferences key to make the inspector dock by default
https://bugs.webkit.org/show_bug.cgi?id=14271

Attachment 22773: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=22773&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 20:02:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 20:02:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27172] bugzilla-tool:
 create CommitMessage class : [Attachment 32604] Patch v1
In-Reply-To: <bug-27172-0@https.bugs.webkit.org/>
References: <bug-27172-0@https.bugs.webkit.org/>
Message-ID: <20090711030257.B78E032A3D54@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27172: bugzilla-tool: create CommitMessage class
https://bugs.webkit.org/show_bug.cgi?id=27172

Attachment 32604: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32604&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

Reviewed by NOBODY (OOPS!).

Create a CommitMessage class to encapsulate related code.

* Scripts/bugzilla-tool:
(bug_id_from_commit_message): Moved to
CommitMessage.parse_bug_id().
(commit_message_for_this_commit): Return a CommitMessage.
(ApplyPatchesFromBug.apply_patches): Use CommitMessage.message().
(LandPatchesFromBugs.build_and_commit): Ditto.
(CommitMessageForCurrentDiff.execute): Ditto.
(PostCommitsAsPatchesToBug.execute): Switched from
Git.commit_message_for_commit() to
Git.commit_message_for_local_commit().	Switched from
bug_id_from_commit_message() to CommitMessage.parse_bug_id().

* Scripts/modules/scm.py:
(first_non_empty_line_after_index): Added.
(CommitMessage.__init__): Added.
(CommitMessage.body): Added.
(CommitMessage.description): Added.
(CommitMessage.message): Added.
(CommitMessage.parse_bug_id): Added.  Moved from
bug_id_from_commit_message() in bugzilla-tool.
(Git.commit_message_for_local_commit): Renamed from
commit_message_for_commit().  Return a CommitMessage.
---
 3 files changed, 87 insertions(+), 21 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 10 20:04:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 20:04:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27171] [Gtk] REGRESSION
 (r45440): fails at fast/events/frame-programmatic-focus.html : [Attachment
 32605] implement grab-focus
In-Reply-To: <bug-27171-0@https.bugs.webkit.org/>
References: <bug-27171-0@https.bugs.webkit.org/>
Message-ID: <20090711030439.8030132A3DF9@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27171: [Gtk] REGRESSION (r45440): fails at
fast/events/frame-programmatic-focus.html
https://bugs.webkit.org/show_bug.cgi?id=27171

Attachment 32605: implement grab-focus
https://bugs.webkit.org/attachment.cgi?id=32605&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 20:24:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 20:24:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27167] bugzilla-tool: hide
 help for unsupported commands : [Attachment 32599] Patch v2
In-Reply-To: <bug-27167-0@https.bugs.webkit.org/>
References: <bug-27167-0@https.bugs.webkit.org/>
Message-ID: <20090711032422.71A7432A4511@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27167: bugzilla-tool: hide help for unsupported commands
https://bugs.webkit.org/show_bug.cgi?id=27167

Attachment 32599: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32599&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks great.

I would make:
if command_object.requires_local_commits and not
self.scm().supports_local_commits():
 591		 error(command_name + " requires local commits.")

more verbose.  You could spit out the SCM.display_name() as well as possibly
the root directory we detected for the SCM.

Thanks!

From bugzilla-daemon at webkit.org  Fri Jul 10 20:30:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 20:30:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32606]
 Height Patch
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090711033047.381B832A4721@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32606: Height Patch
https://bugs.webkit.org/attachment.cgi?id=32606&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 21:33:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 21:33:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20166] CSS Perspective
 Transform works on iPhone but not in Safari : [Attachment 32607] Patch
In-Reply-To: <bug-20166-0@https.bugs.webkit.org/>
References: <bug-20166-0@https.bugs.webkit.org/>
Message-ID: <20090711043314.A338D32A5B50@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 20166: CSS Perspective Transform works on iPhone but not in Safari
https://bugs.webkit.org/show_bug.cgi?id=20166

Attachment 32607: Patch
https://bugs.webkit.org/attachment.cgi?id=32607&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
There will be some new Leopard-specific pixel results that go along with this.

From bugzilla-daemon at webkit.org  Fri Jul 10 21:44:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 21:44:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27173] svn-apply: Fix typo
 in git command used to find deleted files : [Attachment 32608] Patch v1
In-Reply-To: <bug-27173-0@https.bugs.webkit.org/>
References: <bug-27173-0@https.bugs.webkit.org/>
Message-ID: <20090711044438.8916E32A5F5F@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27173: svn-apply: Fix typo in git command used to find deleted files
https://bugs.webkit.org/show_bug.cgi?id=27173

Attachment 32608: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32608&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Found a typo in svn-apply when writing a "land-commits" command for
bugzilla-tool.

This also tests "create-bug" for svn.

From bugzilla-daemon at webkit.org  Fri Jul 10 21:45:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 21:45:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 20166] CSS Perspective
 Transform works on iPhone but not in Safari : [Attachment 32607] Patch
In-Reply-To: <bug-20166-0@https.bugs.webkit.org/>
References: <bug-20166-0@https.bugs.webkit.org/>
Message-ID: <20090711044526.5D90F32A5FBB@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 20166: CSS Perspective Transform works on iPhone but not in Safari
https://bugs.webkit.org/show_bug.cgi?id=20166

Attachment 32607: Patch
https://bugs.webkit.org/attachment.cgi?id=32607&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me, are there no leopard tests that need their results updated?

From bugzilla-daemon at webkit.org  Fri Jul 10 21:54:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 21:54:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27170] drawImage method of
 HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment
 32603] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090711045424.4EFDF32A62B1@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27170: drawImage method of HTMLCanvasElement to accept HTMLVideoElement as
argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32603: patch
https://bugs.webkit.org/attachment.cgi?id=32603&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
> +	       if (ec != 0) {
> +		   V8Proxy::setDOMException(ec);
> +		   return notHandledByInterceptor();
> +	       }

This probably should be

if (ec)
   return throwError(ec);

> +	       if (ec != 0) {
> +		   V8Proxy::setDOMException(ec);
> +		   return notHandledByInterceptor();
> +	       }

Ditto.

> +	       break;
> +	   default:
> +	       V8Proxy::throwError(V8Proxy::SyntaxError, "drawImage: Invalid
number of arguments");
> +	       return v8::Undefined();

return throwError(V8Proxy::SyntaxError, "drawImage: Invalid number of
arguments");

> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 45742)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,12 @@
> +2009-07-07  Alpha Lam  <hclam at chromium.org>
> +
> +	   Reviewed by NOBODY(OOPS!).
> +
> +	   Changed CanvasRenderingContext2DDrawImage to accept HTMLVideoElement

> +	   as a parameter of drawImage of HTMLCanvasElement.
> +


Wrong ChangeLog? Should be WebCore/ChangeLog.

From bugzilla-daemon at webkit.org  Fri Jul 10 22:04:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 22:04:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 32609] <http://webkit.org/b/27119>
 bugzilla-tool: Add create-bug command
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090711050433.E590B32A662D@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 32609:	  <http://webkit.org/b/27119> bugzilla-tool: Add
create-bug command
https://bugs.webkit.org/attachment.cgi?id=32609&action=review

From bugzilla-daemon at webkit.org  Fri Jul 10 22:39:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 22:39:11 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 32609] Patch v3
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090711053911.2BFE232A723C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 32609: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32609&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 489	     bug_id = tool.bugs.create_bug_with_patch(bug_title, comment_text,
options.component, diff_file, "Patch v1", cc=options.cc,
mark_for_review=options.review)

Is "Patch v1" intended there?

You don't have to forward declare in python AFAIK:
bug_title = ""
 476	     comment_text = ""

It seems this wants to be its own function:
80	       commit_message = tool.scm().commit_message_for_commit(commit_id)

 481		 commit_lines = [re.sub('^ {0,8}', '', line, 1) for line in
commit_message.splitlines()]
 482		 bug_title = commit_lines[0]
 483		 comment_text = "\n".join(commit_lines[1:]) + "\n"
 484		 comment_text += "---\n"
 485		 comment_text +=
tool.scm().files_changed_summary_for_commit(commit_id)


There seems to be come copy/paste from the previous section:
 503		 commit_message = commit_message_for_this_commit(tool.scm())
 504		 commit_lines = [re.sub('^ {0,8}', '', line, 1) for line in
commit_message.splitlines()]
 505		 bug_title = commit_lines[0]
 506		 comment_text = "\n".join(commit_lines[1:]) + "\n"

AGain, no need for forward-declare:
498	    bug_title = ""
 499	     comment_text = ""

We shoudl just fix all these functions to detect a string and turn it into a
file for Mechanize:
	 diff = tool.scm().create_patch()
 509	     diff_file = StringIO.StringIO(diff) # create_bug_with_patch
expects a file-like object
 510	     bug_id = tool.bugs.create_bug_with_patch(bug_title, comment_text,
options.component, diff_file, "Patch v1", cc=options.cc,
mark_for_review=options.review)

You can invert the order of the clauses with:
if len(args) == 0
and use
if len(args) instead.  Doesn't really matter.

r- for the copy/paste code.  Otherwise this seems fine in general.

From bugzilla-daemon at webkit.org  Fri Jul 10 22:39:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 22:39:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27173] svn-apply: Fix typo in
 git command used to find deleted files : [Attachment 32608] Patch v1
In-Reply-To: <bug-27173-0@https.bugs.webkit.org/>
References: <bug-27173-0@https.bugs.webkit.org/>
Message-ID: <20090711053948.4636132A728F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27173: svn-apply: Fix typo in git command used to find deleted files
https://bugs.webkit.org/show_bug.cgi?id=27173

Attachment 32608: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32608&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Yeah, I wonder why "head" works for me but no one else. :)

From bugzilla-daemon at webkit.org  Fri Jul 10 22:44:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 22:44:38 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32519] Autofix for lint errors v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090711054438.B153D32A7483@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32519: Autofix for lint errors v2
https://bugs.webkit.org/attachment.cgi?id=32519&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Clearing my r+ flag on this since it's been landed.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:04:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:04:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27172] bugzilla-tool: create
 CommitMessage class : [Attachment 32604] Patch v1
In-Reply-To: <bug-27172-0@https.bugs.webkit.org/>
References: <bug-27172-0@https.bugs.webkit.org/>
Message-ID: <20090711060413.24B1632A7B58@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27172: bugzilla-tool: create CommitMessage class
https://bugs.webkit.org/show_bug.cgi?id=27172

Attachment 32604: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32604&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's difficult for me to tell where the divide between a CommitMessage class
and ChangeLog* classes should be.

 114	 return CommitMessage(''.join(changelog_messages).splitlines())
Seems a little odd to take an array of lines, but OK.

Maybe CommitMessage should take an array of ChangeLog paths instead?
(eventually probably an array of ChangeLog entries?)

Should we name this bug_id and have it lazily call parse_bug_id?
 426		 bug_id = options.bug_id or commit_message.parse_bug_id()

I don't understand this code:
 72	    if strip_url:
 73		line = re.sub("^(\s*)<.+> ", "\1", line)

Seems it at least needs a comment.  I assume this is some new prepare-ChangeLog
thing which I'm not used to yet?

Some of this code really seems to belong in a ChangeLogEntry class.

Seems odd that these lines don't match:
 81		match = re.search("http\://webkit\.org/b/(?P<bug_id>\d+)",
line)
 84		match = re.search(Bugzilla.bug_server_regex +
"show_bug\.cgi\?id=(?P<bug_id>\d+)", line)

I don't think this is needed:
 87	    return None

I think this is OK.  But you might want to try some of the comments above.  I
think much of this will end up in a ChangeLogEntry class instead of in
CommitMessage.	CommitMessage seems useful for doing all the commit-log-editor
stuff dealing with ChangeLogEntry (or similar) classes.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:08:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:08:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32586] Take away space out of
 ARROW_KEYS_POP_MENU and into SPACE_POP_MENU for platforms that display the
 popup when spacebar is pressed
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090711060801.BAC6132A7D22@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32586: Take away space out of ARROW_KEYS_POP_MENU and into
SPACE_POP_MENU for platforms that display the popup when spacebar is pressed
https://bugs.webkit.org/attachment.cgi?id=32586&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks like it will break mac.  You seem to want #if and #endif then
another #if, not #elif

This also needs a manual test.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:10:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:10:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 32495] Patch v2
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090711061015.88C3C32A7E12@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 32495: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32495&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #9)
> (From update of attachment 32495 [details])
> So I'm confused by why we obsolete patches one at a time when landing them
when
> there is more than one to land. But we don't obsolete them when landing with
> the --no-close option.
> 
> I guess I would prefer we always obsoleted the patch after landing.  But I
> think you and I have different personal preferences here. :)
> 
> Either way, we should make them consistent, no?

My view of the world:

Obsolete patch:  A patch that has never and will never land.
Patch with cleared review flag:  A patch that has landed on a bug with more
than one patch up for review (which must necessarily stay open until all
patches have landed).

What's your view?

I'll make the change to be consistent in behavior and post another patch. 
Thanks!

From bugzilla-daemon at webkit.org  Fri Jul 10 23:14:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:14:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27053] Ambiguity in
 LabelScope initialization : [Attachment 32424] Updated patch for bug# 27053
In-Reply-To: <bug-27053-0@https.bugs.webkit.org/>
References: <bug-27053-0@https.bugs.webkit.org/>
Message-ID: <20090711061420.8FBA832A7F95@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27053: Ambiguity in LabelScope initialization
https://bugs.webkit.org/show_bug.cgi?id=27053

Attachment 32424: Updated patch for bug# 27053
https://bugs.webkit.org/attachment.cgi?id=32424&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.  Your ChangeLog seems to have an extra return in it though.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:17:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:17:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27059] Exclude Symbian
 platform from define of MIDDLE_ENDIAN : [Attachment 32418] Code patch for
 Platform.h
In-Reply-To: <bug-27059-0@https.bugs.webkit.org/>
References: <bug-27059-0@https.bugs.webkit.org/>
Message-ID: <20090711061706.6C81032A80A4@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27059: Exclude Symbian platform from define of MIDDLE_ENDIAN
https://bugs.webkit.org/show_bug.cgi?id=27059

Attachment 32418: Code patch for Platform.h
https://bugs.webkit.org/attachment.cgi?id=32418&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why?  PLATFORM(SYMBIAN) seems the wrong level of define to be using here.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:18:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:18:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27060] Type cast for first
 argument in make_pair() : [Attachment 32420] Code patch for Structure.cpp
In-Reply-To: <bug-27060-0@https.bugs.webkit.org/>
References: <bug-27060-0@https.bugs.webkit.org/>
Message-ID: <20090711061801.DAD0C32A8108@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27060: Type cast for first argument in make_pair()
https://bugs.webkit.org/show_bug.cgi?id=27060

Attachment 32420: Code patch for Structure.cpp
https://bugs.webkit.org/attachment.cgi?id=32420&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why?  Also, we use c++ style casts.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:19:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:19:00 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27061] Define explicit include
 path for UnicodeQt4.h : [Attachment 32421] Code patch for Unicode.h
In-Reply-To: <bug-27061-0@https.bugs.webkit.org/>
References: <bug-27061-0@https.bugs.webkit.org/>
Message-ID: <20090711061900.E5FE232A8163@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27061: Define explicit include path for UnicodeQt4.h
https://bugs.webkit.org/show_bug.cgi?id=27061

Attachment 32421: Code patch for Unicode.h
https://bugs.webkit.org/attachment.cgi?id=32421&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why?  Why don't other platforms need this.

"Why?" seems to be a common theme for your patches.  Please include more
information in your ChangeLogs

From bugzilla-daemon at webkit.org  Fri Jul 10 23:21:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:21:05 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27076] [WINCE] Move date
 related symbols to DateExtras.h : [Attachment 32448] DateExtras
In-Reply-To: <bug-27076-0@https.bugs.webkit.org/>
References: <bug-27076-0@https.bugs.webkit.org/>
Message-ID: <20090711062105.C669732A822D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32448: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32448&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Is JavaScriptCore/wtf/DateExtras.cpp all code you wrote?  Where can we validate
the license if not?

There are lots of style errors.

Try using the new cpplint in WebKitTools/Scripts/

From bugzilla-daemon at webkit.org  Fri Jul 10 23:30:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:30:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27163] Fix memory leak in V8
 bindings : [Attachment 32591] patch to avoid leaking contexts
In-Reply-To: <bug-27163-0@https.bugs.webkit.org/>
References: <bug-27163-0@https.bugs.webkit.org/>
Message-ID: <20090711063041.39DE832A8620@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Mads Ager <ager at chromium.org>'s
request for review:
Bug 27163: Fix memory leak in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27163

Attachment 32591: patch to avoid leaking contexts
https://bugs.webkit.org/attachment.cgi?id=32591&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
These seem like two independent changes, but that's ok.  I don't understand why
calling initContextIfNeeded() in clearForNavigation() leads to a leak, but it
makes sense that this isn't needed because all the other entry points are super
excited about making sure the context is initialized before they use it.

I'm r+ing this, but it would be helpful for Dimitri to give his opinion as
well.

From bugzilla-daemon at webkit.org  Fri Jul 10 23:42:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 10 Jul 2009 23:42:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26921] [XSSAuditor] HTML
 entities can bypass xssAuditor : [Attachment 32602] Working patch with
 tests
In-Reply-To: <bug-26921-0@https.bugs.webkit.org/>
References: <bug-26921-0@https.bugs.webkit.org/>
Message-ID: <20090711064207.8CB3C32A8AA3@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 26921: [XSSAuditor] HTML entities can bypass xssAuditor
https://bugs.webkit.org/show_bug.cgi?id=26921

Attachment 32602: Working patch with tests
https://bugs.webkit.org/attachment.cgi?id=32602&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is fine for now.  Now that we've worked through all the known issues, it's
time to do a clean up patch for the auditor.  There are some nits that I'd
change with this patch, but we can deal with them in the cleanup patch.

Thanks for the thorough test cases.  That work is about to pay off.

From bugzilla-daemon at webkit.org  Sat Jul 11 04:34:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 04:34:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 32612] Updated patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090711113428.B219332AF271@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32612: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32612&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Updated re comments.

From bugzilla-daemon at webkit.org  Sat Jul 11 04:34:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 04:34:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 32583] Initial Patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090711113428.A1CC632AF26E@gamma.macosforge.org>

robert <robert at roberthogan.net> has canceled robert <robert at roberthogan.net>'s
request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32583: Initial Patch
https://bugs.webkit.org/attachment.cgi?id=32583&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Updated re comments.

From bugzilla-daemon at webkit.org  Sat Jul 11 10:36:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 10:36:44 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32593] More style fixups per levin's review.
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090711173644.C9B7C32B7EED@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32593: More style fixups per levin's review.
https://bugs.webkit.org/attachment.cgi?id=32593&action=review

From bugzilla-daemon at webkit.org  Sat Jul 11 10:36:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 10:36:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32614] Removed test expectations that were incorrectly generated with
 non-default flags.
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090711173644.F0D6B32B7EF1@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked David Levin <levin at chromium.org>
for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32614: Removed test expectations that were incorrectly generated
with non-default flags.
https://bugs.webkit.org/attachment.cgi?id=32614&action=review

From bugzilla-daemon at webkit.org  Sat Jul 11 11:09:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 11:09:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32616] proposed patch
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090711180924.E441B32B8B9A@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked David Levin <levin at chromium.org>
for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32616: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32616&action=review

From bugzilla-daemon at webkit.org  Sat Jul 11 13:47:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 13:47:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32617] patch 1
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090711204708.8CE4932BCA34@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32617: patch 1
https://bugs.webkit.org/attachment.cgi?id=32617&action=review

From bugzilla-daemon at webkit.org  Sat Jul 11 15:11:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 15:11:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32617] patch 1
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090711221142.5FDC532BEC55@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32617: patch 1
https://bugs.webkit.org/attachment.cgi?id=32617&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Having the reference counter be a friend class and a private destructor does
seem slightly tighter than our usual reference counting idiom, which is good.

If it was me I wouldn't call these "really bad dependencies" or say "such a
tangled mess" -- I would intend say something factual about how many extra
includes there are and let the reader decide how bad it was.

From bugzilla-daemon at webkit.org  Sat Jul 11 19:01:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 19:01:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27186]
 HTMLMediaElement.canPlayType "maybe" and "probably" reversed : [Attachment
 32622] proposed patch
In-Reply-To: <bug-27186-0@https.bugs.webkit.org/>
References: <bug-27186-0@https.bugs.webkit.org/>
Message-ID: <20090712020125.1680532C4369@gamma.macosforge.org>

Eric Carlson <eric.carlson at apple.com> has asked  for review:
Bug 27186: HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

Attachment 32622: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32622&action=review

From bugzilla-daemon at webkit.org  Sat Jul 11 19:12:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 19:12:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27186]
 HTMLMediaElement.canPlayType "maybe" and "probably" reversed : [Attachment
 32622] proposed patch
In-Reply-To: <bug-27186-0@https.bugs.webkit.org/>
References: <bug-27186-0@https.bugs.webkit.org/>
Message-ID: <20090712021207.B2F7632C4765@gamma.macosforge.org>

Antti Koivisto <koivisto at iki.fi> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 27186: HTMLMediaElement.canPlayType "maybe" and "probably" reversed
https://bugs.webkit.org/show_bug.cgi?id=27186

Attachment 32622: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32622&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
r=me

From bugzilla-daemon at webkit.org  Sat Jul 11 21:38:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 21:38:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27187] Match Gecko
 behaviour for canvas path mutation APIs on an empty path : [Attachment
 32623] fixeration!
In-Reply-To: <bug-27187-0@https.bugs.webkit.org/>
References: <bug-27187-0@https.bugs.webkit.org/>
Message-ID: <20090712043810.3DE0F32C7EF5@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27187: Match Gecko behaviour for canvas path mutation APIs on an empty path
https://bugs.webkit.org/show_bug.cgi?id=27187

Attachment 32623: fixeration!
https://bugs.webkit.org/attachment.cgi?id=32623&action=review

From bugzilla-daemon at webkit.org  Sat Jul 11 22:15:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 11 Jul 2009 22:15:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27187] Match Gecko behaviour
 for canvas path mutation APIs on an empty path : [Attachment 32623]
 fixeration!
In-Reply-To: <bug-27187-0@https.bugs.webkit.org/>
References: <bug-27187-0@https.bugs.webkit.org/>
Message-ID: <20090712051505.CDBDC32C8D9C@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 27187: Match Gecko behaviour for canvas path mutation APIs on an empty path
https://bugs.webkit.org/show_bug.cgi?id=27187

Attachment 32623: fixeration!
https://bugs.webkit.org/attachment.cgi?id=32623&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> +	   Simple API change, check for the mpty path and add appropriate point
if necessary.

Typo here. r=me

From bugzilla-daemon at webkit.org  Sun Jul 12 04:40:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 04:40:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27171] [Gtk] REGRESSION
 (r45440): fails at fast/events/frame-programmatic-focus.html : [Attachment
 32605] implement grab-focus
In-Reply-To: <bug-27171-0@https.bugs.webkit.org/>
References: <bug-27171-0@https.bugs.webkit.org/>
Message-ID: <20090712114057.85B2832D2956@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27171: [Gtk] REGRESSION (r45440): fails at
fast/events/frame-programmatic-focus.html
https://bugs.webkit.org/show_bug.cgi?id=27171

Attachment 32605: implement grab-focus
https://bugs.webkit.org/attachment.cgi?id=32605&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -	   core(webView)->focusController()->setActive(frame);
> -	   core(webView)->focusController()->setFocused(true);
> +	   focusController->setActive(true);
> +	   focusController->setFocused(true);

The only change that makes me a bit nervous is going from frame to true here. I
believe there might have been a reason to not set it unconditionally? r=me, but
please either revert this specific change, or add a comment here on the bug so
that we have a way of tracking this down.

From bugzilla-daemon at webkit.org  Sun Jul 12 07:22:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 07:22:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32625] rev 2
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090712142229.4B43932D7089@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32625: rev 2
https://bugs.webkit.org/attachment.cgi?id=32625&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Cleaned up the ChangeLog wording.

Ready to be landed, I think.

From bugzilla-daemon at webkit.org  Sun Jul 12 09:30:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 09:30:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug
 27184]=?UTF-8?Q?=20Text=20searching=20with=20ICU=20should=20take=20the=20user=E2=80=99s=20default=20locale=20into=20account=20?=:
 [Attachment 32628] patch
In-Reply-To: <bug-27184-0@https.bugs.webkit.org/>
References: <bug-27184-0@https.bugs.webkit.org/>
Message-ID: <20090712163011.023DF32DA232@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27184: Text searching with ICU should take the user?s default locale into
account
https://bugs.webkit.org/show_bug.cgi?id=27184

Attachment 32628: patch
https://bugs.webkit.org/attachment.cgi?id=32628&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 10:08:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 10:08:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug
 27184]=?UTF-8?Q?=20Text=20searching=20with=20ICU=20should=20take=20the=20user=E2=80=99s=20default=20locale=20into=20account=20?=:
 [Attachment 32628] patch
In-Reply-To: <bug-27184-0@https.bugs.webkit.org/>
References: <bug-27184-0@https.bugs.webkit.org/>
Message-ID: <20090712170810.69FB532DB0FA@gamma.macosforge.org>

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 27184: Text searching with ICU should take the user?s default locale into
account
https://bugs.webkit.org/show_bug.cgi?id=27184

Attachment 32628: patch
https://bugs.webkit.org/attachment.cgi?id=32628&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 10:10:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 10:10:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 32451]
 lineboundary.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090712171032.EC9BB32DB213@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 32451: lineboundary.patch
https://bugs.webkit.org/attachment.cgi?id=32451&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +static void utf16_to_utf8(const UChar* aText, gint aLength, char* &text,
gint &length)
> +{
> +    gboolean need_copy = FALSE;

I believe we want UTF16ToUTF8, and needCopy, here, though the first one looks
blergh. Maybe Utf16ToUtf8? Though the style doesn't like that for acronyms...

> +	   if (!aText[i] || IS_LOW_SURROGATE(aText[i])) {
> +	       need_copy = TRUE;
> +	       break;
> +	   }
> +	   else if (IS_HIGH_SURROGATE(aText[i])) {

The else if line should be after the if's } here.

> +    gint new_length = 0;

newLength

It would be good to have a comment on top of convertUniCharToUTF8 explaining
that it is not really general, as the name seems to imply, and that it is
concerned with how the layouting is done. I know there's a comment that may
lead people to notice this in the middle of the function, but then again, it
would be best to make this obvious.

The rest looks fine to me, so r=me with the style changes. It's a pitty you had
to do all that messing with the text to get it right, but I figure it would be
much harder to change the way webcore works.

From bugzilla-daemon at webkit.org  Sun Jul 12 10:32:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 10:32:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32616] proposed patch
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090712173256.1681932DBAC1@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32616: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32616&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Removing "review ?" for now, as it looks like there's a bug in the V8 GC
behavior which I saw while working on another refactoring. I'll either upload a
new patch or restore this to '?' once I finish my investigation.

From bugzilla-daemon at webkit.org  Sun Jul 12 11:35:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 11:35:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27191] [Qt] Cleanup -
 Remove prf install target : [Attachment 32630] Proposed patch.
In-Reply-To: <bug-27191-0@https.bugs.webkit.org/>
References: <bug-27191-0@https.bugs.webkit.org/>
Message-ID: <20090712183545.5E4BC32DD246@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27191: [Qt] Cleanup - Remove prf install target
https://bugs.webkit.org/show_bug.cgi?id=27191

Attachment 32630: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=32630&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 12:09:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 12:09:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26718] [Gtk] Add support for
 javascript windows for DRT : [Attachment 32102] updated to fix the popup
 blocking flag
In-Reply-To: <bug-26718-0@https.bugs.webkit.org/>
References: <bug-26718-0@https.bugs.webkit.org/>
Message-ID: <20090712190948.3362032DDECC@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 26718: [Gtk] Add support for javascript windows for DRT
https://bugs.webkit.org/show_bug.cgi?id=26718

Attachment 32102: updated to fix the popup blocking flag
https://bugs.webkit.org/attachment.cgi?id=32102&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
So, since Xan commented. r=me with the name change, the removal of one of the
class method placeholders, and please reposition the signal in the enum.

From bugzilla-daemon at webkit.org  Sun Jul 12 12:36:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 12:36:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27189] r45752+ nightly:
 @import css generates wrong path : [Attachment 32631] Patch with test
In-Reply-To: <bug-27189-0@https.bugs.webkit.org/>
References: <bug-27189-0@https.bugs.webkit.org/>
Message-ID: <20090712193610.F125032DE973@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27189: r45752+ nightly: @import css generates wrong path
https://bugs.webkit.org/show_bug.cgi?id=27189

Attachment 32631: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32631&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 13:21:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 13:21:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27189] r45752+ nightly:
 @import css generates wrong path : [Attachment 32631] Patch with test
In-Reply-To: <bug-27189-0@https.bugs.webkit.org/>
References: <bug-27189-0@https.bugs.webkit.org/>
Message-ID: <20090712202101.C5A0032DFCA0@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27189: r45752+ nightly: @import css generates wrong path
https://bugs.webkit.org/show_bug.cgi?id=27189

Attachment 32631: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32631&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 14:28:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 14:28:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 16401] [GTK] GObject/C DOM
 binding : [Attachment 32633] brings glib/gobject bindings up to svn r44473.
In-Reply-To: <bug-16401-0@https.bugs.webkit.org/>
References: <bug-16401-0@https.bugs.webkit.org/>
Message-ID: <20090712212805.5E71732E18DA@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 16401: [GTK] GObject/C DOM binding
https://bugs.webkit.org/show_bug.cgi?id=16401

Attachment 32633: brings glib/gobject bindings up to svn r44473.
https://bugs.webkit.org/attachment.cgi?id=32633&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
okaay, this is the "2 steps backwards, 1 step forwards" patch which, as
explained, cannot take into consideration adam's fantastic work because it was
impossible for me to follow it.  even _one_ feature removed (and the first that
adam picked was event handling) meant that the test framework (pyjamas 
desktop) was totally cut off at the knees.

dave agrees - https://bugs.webkit.org/show_bug.cgi?id=16401#c214 - that the way
forward is to take this "as-is" and then to move forward from there.  over what
is likely to be a period of several months, retro-fix issues that have been
raised and recorded will - should - be created.  it would have been nice if
people had listened to my advice on this months ago, but, not believing me, you
had to find out for yourselves [by taking up adam's time as well as mine].  at
least we're moving forward, now, rather than playing silly buggers.

i'll be _more_ than happy to help review individual small dedicated controlled
manageable single-purpose patches that anyone cares to contribute: perhaps by
comparing the differences between what adam has done and what this patch
provides it may make individuals' lives easier when it comes to updating this
strategically critical area of functionality.

there is a _lot_ still left to be done - but, butbutbut, what is here is
_provably_ working.  it would be very nice if it stayed that way, and that
pyjamas-desktop, the only current project which utilised these bindings with
near 100% code coverage, carried on working.

still on the critical TODO list, after this patch is accepted (let alone any
bug-fixes / coding-standards / review update work!) is: Enums, SVG 2D Canvas,
and Exception handling.

this latter is proving tiresome to not have, in pywebkitgtk (and
pyjamas-desktop): several bugs could not be found in pyjamas-desktop until
python-xpcom / XULRunner was added as an alternative back-end peer [to
pywebkitgtk].  up until then, due to the lack of error reporting from runtime
exceptions, style attributes and a few others just... silently vanished
(fortunately with no useability impact, but that was down to luck).

as requested, i've made review comments to
https://bugs.webkit.org/show_bug.cgi?id=16401#c191 and
https://bugs.webkit.org/show_bug.cgi?id=16401#c194  - the coding-standards
issues i immediately fixed (as they're dead-easy) however there were issues
raised that should have been raised eight months ago, when i had a complete map
of the code and a handle on the 600+ auto-generated files in my head.  i've
answered them as best i can: now it's time to move on.

one thing that can be seen from this patch: it includes LANGUAGE_GOBJECT as a
#define.  this is in for two separate reasons:

1) until someone can show me how to get a TextDocument object, in order to pass
it to XMLHttpRequest.open(), for that reason and for that sole reason alone,
LANGUAGE_GOBJECT is _absolutely_ required, in order to reactivate
open(DOMString).  otherwise, it's simply not possible to get XMLHttpRequest to
work, and XMLHttpRequest working is a critical requirement of pyjamas-desktop
[what's the point of having python bindings that are identical and a peer with
the javascript ones if AJAX is bloody well missing???! :) ]

2) removal of LANGUAGE_GOBJECT was requested several months ago because it
introduced features which are present in the de-facto Javascript standard (i.e.
anyone coming from javascript would not be in for some unpleasant surprises)
and it was stated that these features are not present in the W3C standard. 
after some extensive research, it was demonstrated that this wasn't quite true:
the W3C standard makes specific mention that certain browser engines _do_
support the features.  in fact, the research showed that by not having these
features (i.e. by conforming strictly to the W3C standards), webkit would in
fact be the _only_ major web engine that would not be on a par with its peers! 
even MSHTML has better support, because thanks to DCOM which has LP_VARIANT
(which can take int, string, or in fact anything) and thus, unlike any of the
other DOM implementations, the MS implementation of the DOM functions can
support _both_ the W3C standard _and_ the de-facto javascript-led standard.

regarding 2), i have put considerable thought to the matter and have some
insights to share.  from the perspective of the objective-c bindiings, strict
W3C DOM standards compliance may make perfect sense.  objective-c is a
_compiler_.  the auto-generated webkit objective-c header files are utilised at
_compile_ time by the compiler to perform type-checking that can result in
developers catching errors immediately.  and, in objective-c, developers can
take advantage of c++ classes that will be compiled, again at _compile_ time,
into type-converters that will take strings as input, and convert to integers,
and much much more.

however - the glib/gobject bindings will - and are - be utilised by INTERPRETED
languages.  there is a WHOPPING great world of difference.  there are two such
(auto-generated) language bindings already (vala and python), and there will be
more.

vala - https://bugs.webkit.org/attachment.cgi?id=27558

python - http://code.google.com/p/pywebkitgtk/issues/detail?id=13

in the python case, the (currently sole and exclusive) project which is using
pywebkitgtk with the DOM bindings is pyjamas - a python-to-javascript compiler.


in other words, the only test case - the only really big significant (free
software) test platform for the webkit glib bindings has a javascript-only
cousin.

that means that any applications written for pyjamas-desktop (which uses either
pywebkitgtk or XULrunner python-xpcom) can also run as javascript, in all major
web browsers.

_that_ means that application developers may be developing exclusively in
javascript, using the pyjamas python-to-javascript compiler.  then, they
encounter a requirement to have the application run as a stand-alone desktop
app.  then they download pywebkitgtk....

... and they get a nasty big shock because the bloody underlying API is subtly
different.  without LANGUAGE_GOBJECT, all toString() functions would be
missing; there would be no way to get the range of selected text out of input
nodes; embed nodes would suddenly lose their width and height settings;
XMLHttpRequest would be completely broken, and a few other nasty surprises.

not one of these things is acceptable.	the workarounds aren't particularly
nice, either, and - again, the workarounds would be _great_ if these were
COMPILED languages, with virtual base class function pointers etc. - but
they're not: they're INTERPRETED languages, just like javascript.

which reminds me of the other reason why many of the JS-isms should be enabled
(such as getBoxObjectFor).  again: in COMPILED languages, which are damn fast,
calling functions like getBoxObjectFor via two or three levels of indirection
makes absolutely no sense: just grab the attributes (width, height, top, left)
individually and directly and write your own version of getBoxObjectFor which
will, thanks to being a compiled language, be far far quicker.

NOT so, in interpreted languages such as python.  why?	well, have you ever
looked at python's Objects/abstractobject.c source code?  it makes for
interesting reading.  and that's where all object access starts out.  every
single add, multiply, etc. goes through potential coercion checking.  a single
optimisation is made to check whether the two types are "int", and this is the
_only_ case which is made faster: everything else goes through the "approx one
hundred lines of c-code" route.  just to do an add, or a multiply.

so the very reasons for which the javascript-isms were created are just as
equally valid for other dynamic languages as they are for javascript.

overall then, for many many reasons, there is an overall compelling case to be
made for sticking to the de-facto javascript standards over the W3C standards,
for the glib/gobject bindings, and as equally a compelling case to be made for
sticking to the W3C standards for the objective-C bindings.

the two should not be confused, and developers using interpreted languages
should not be put to incredible inconvenience (as well as the developers of the
intermediate bindings) just for the sake of it.

l.

From bugzilla-daemon at webkit.org  Sun Jul 12 16:46:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 16:46:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25316] Outdenting a line
 inside a blockquote tag does nothing : [Attachment 32601] removes
 isIndentBlockquote as requested
In-Reply-To: <bug-25316-0@https.bugs.webkit.org/>
References: <bug-25316-0@https.bugs.webkit.org/>
Message-ID: <20090712234652.7825A32E4E86@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has canceled Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32601: removes isIndentBlockquote as requested
https://bugs.webkit.org/attachment.cgi?id=32601&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 16:46:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 16:46:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25316] Outdenting a line
 inside a blockquote tag does nothing : [Attachment 32635] fixes the bug
In-Reply-To: <bug-25316-0@https.bugs.webkit.org/>
References: <bug-25316-0@https.bugs.webkit.org/>
Message-ID: <20090712234652.8F6B432E4E8A@gamma.macosforge.org>

Ryosuke Niwa <rniwa at google.com> has asked  for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32635: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32635&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 17:37:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 17:37:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25316] Outdenting a line
 inside a blockquote tag does nothing : [Attachment 32635] fixes the bug
In-Reply-To: <bug-25316-0@https.bugs.webkit.org/>
References: <bug-25316-0@https.bugs.webkit.org/>
Message-ID: <20090713003759.58DFB32E609C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at google.com>'s
request for review:
Bug 25316: Outdenting a line inside a blockquote tag does nothing
https://bugs.webkit.org/show_bug.cgi?id=25316

Attachment 32635: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=32635&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough to me.

From bugzilla-daemon at webkit.org  Sun Jul 12 17:40:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 17:40:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27196] Rename bidi.cpp to
 RenderBlockLineLayout.cpp and remove bidi.h : [Attachment 32637] Rename
 bidi.cpp to RenderBlockLineLayout.cpp, remove bidi.h,
 update project files and script
In-Reply-To: <bug-27196-0@https.bugs.webkit.org/>
References: <bug-27196-0@https.bugs.webkit.org/>
Message-ID: <20090713004047.2731732E61C0@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27196: Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h
https://bugs.webkit.org/show_bug.cgi?id=27196

Attachment 32637: Rename bidi.cpp to RenderBlockLineLayout.cpp, remove bidi.h,
update project files and script
https://bugs.webkit.org/attachment.cgi?id=32637&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 17:52:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 17:52:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27196] Rename bidi.cpp to
 RenderBlockLineLayout.cpp and remove bidi.h : [Attachment 32637] Rename
 bidi.cpp to RenderBlockLineLayout.cpp, remove bidi.h,
 update project files and script
In-Reply-To: <bug-27196-0@https.bugs.webkit.org/>
References: <bug-27196-0@https.bugs.webkit.org/>
Message-ID: <20090713005241.81AA932E6635@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted mitz at webkit.org's request for
review:
Bug 27196: Rename bidi.cpp to RenderBlockLineLayout.cpp and remove bidi.h
https://bugs.webkit.org/show_bug.cgi?id=27196

Attachment 32637: Rename bidi.cpp to RenderBlockLineLayout.cpp, remove bidi.h,
update project files and script
https://bugs.webkit.org/attachment.cgi?id=32637&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Sun Jul 12 18:34:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 18:34:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27197] Add a media layout
 test for data: urls : [Attachment 32639] proposed patch
In-Reply-To: <bug-27197-0@https.bugs.webkit.org/>
References: <bug-27197-0@https.bugs.webkit.org/>
Message-ID: <20090713013430.8075232E773C@gamma.macosforge.org>

Eric Carlson <eric.carlson at apple.com> has asked  for review:
Bug 27197: Add a media layout test for data: urls
https://bugs.webkit.org/show_bug.cgi?id=27197

Attachment 32639: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32639&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 18:37:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 18:37:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27197] Add a media layout
 test for data: urls : [Attachment 32639] proposed patch
In-Reply-To: <bug-27197-0@https.bugs.webkit.org/>
References: <bug-27197-0@https.bugs.webkit.org/>
Message-ID: <20090713013719.7A82932E788C@gamma.macosforge.org>

mitz at webkit.org has granted Eric Carlson <eric.carlson at apple.com>'s request for
review:
Bug 27197: Add a media layout test for data: urls
https://bugs.webkit.org/show_bug.cgi?id=27197

Attachment 32639: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32639&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 20:04:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 20:04:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27179] Facebook Chat is
 broken due to XSS auditor : [Attachment 32642] patch
In-Reply-To: <bug-27179-0@https.bugs.webkit.org/>
References: <bug-27179-0@https.bugs.webkit.org/>
Message-ID: <20090713030449.2874732E97DD@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27179: Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179

Attachment 32642: patch
https://bugs.webkit.org/attachment.cgi?id=32642&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 21:04:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 21:04:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27202] Inspector: Cookies
 in Storage Panel : [Attachment 32643] Add Cookies to Database Panel
In-Reply-To: <bug-27202-0@https.bugs.webkit.org/>
References: <bug-27202-0@https.bugs.webkit.org/>
Message-ID: <20090713040408.0699632EACE7@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27202: Inspector: Cookies in Storage Panel
https://bugs.webkit.org/show_bug.cgi?id=27202

Attachment 32643: Add Cookies to Database Panel
https://bugs.webkit.org/attachment.cgi?id=32643&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
The first take!  Here are some comments:

- I have little to no image skills.  If anyone could help make a better image
or point me to someone who can that would be awesome!  I just made a new image
to get the proper CSS rules out of the way.
- The Cookie TreeElement disappears if the user has the Inspector open and
navigates to another page or reloads the current page.	I don't know which
functions the Inspector is calling.  It doesn't seem to call the Panel's show()
or populateInterface() methods on page loads, only when the currentPanel is
changed to the Databases panel or the WebInspector is opened after being
closed.
- This is an all js version. I hope to work up to switching over to C++ to
access more of the cookie data and to do some processing without having to
resort to evaluating code in the inspected window.
- A page has only 1 set of cookies but can have >1 DOMStorage and >1 Databases.
 This is why WebInspector.DatabasesPanel._cookies is one object that is
constantly updated, and why nothing is passed into the CookieView.  Whenever
the view needs the list of cookies it must resort to checking the inspected
page's document.cookie string.	A C++ version would probably make this cleaner.

- The Datagrid has the ability to delete cookies and will automatically update
the display once a cookie has been deleted.  Again this jumps into the
inspected window to run a command.
- I tried to keep in line with the coding standards from DOMStorage and
Databases as much as possible.
- I used the Apple Copyright with the year 2009.  However, I'm not actually
affiliated with Apple.	I just noticed writing this bug report that it says
"please also add your copyright (name and year) to the relevant files".  Is the
Apple Copyright fine to keep or should I replace it with my own?

If you want to test it out you can easily add/remove cookies, and at the same
time get a quick reminder on how to work with them via javascript at this site.
 I've been using it for testing and its helped me squash some bugs:
http://www.quirksmode.org/js/cookies.html

Thanks for taking the time to look this over.  Cheers!

From bugzilla-daemon at webkit.org  Sun Jul 12 21:40:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 21:40:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27203] Inspector: Remove
 Unintended Global Variables : [Attachment 32644] Remove Unintended Globals
In-Reply-To: <bug-27203-0@https.bugs.webkit.org/>
References: <bug-27203-0@https.bugs.webkit.org/>
Message-ID: <20090713044020.52A2732EBA20@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27203: Inspector: Remove Unintended Global Variables
https://bugs.webkit.org/show_bug.cgi?id=27203

Attachment 32644: Remove Unintended Globals
https://bugs.webkit.org/attachment.cgi?id=32644&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This removes the unintended globals that I found.

Most are harmless and are only global variables inside the Web Inspector
window.

Note that in the case of Console.js, there is code that gets evaluated in the
inspected window.  Thus the "k" variable could get overwritten when running
either the keys() or values() functions created by the Web Inspector.  For
example, running some sample code in the Inspector:

> k
ReferenceError: Can't find variable: k
> var obj = { a:1 }
undefined
> keys(obj)
["a"]
> k /* Now defined as a side effect of running keys() */
a

Although its probably bad programming if a developer used window.k, and even
more unusual if they then called these functions, this side effect should still
be removed. =)

Cheers.

From bugzilla-daemon at webkit.org  Sun Jul 12 21:57:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 21:57:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27203] Inspector: Remove
 Unintended Global Variables : [Attachment 32644] Remove Unintended Globals
In-Reply-To: <bug-27203-0@https.bugs.webkit.org/>
References: <bug-27203-0@https.bugs.webkit.org/>
Message-ID: <20090713045748.3B86F32EC09A@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Joseph Pecoraro <joepeck02 at gmail.com>'s
request for review:
Bug 27203: Inspector: Remove Unintended Global Variables
https://bugs.webkit.org/show_bug.cgi?id=27203

Attachment 32644: Remove Unintended Globals
https://bugs.webkit.org/attachment.cgi?id=32644&action=review

From bugzilla-daemon at webkit.org  Sun Jul 12 22:00:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 22:00:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26915] HTML5: DOM binding of
 <datalist> element : [Attachment 32363] Proposed patch (rev.2)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090713050048.66DA232EC19B@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has canceled TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32363: Proposed patch (rev.2)
https://bugs.webkit.org/attachment.cgi?id=32363&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Updates more build files including .gypi

From bugzilla-daemon at webkit.org  Sun Jul 12 22:00:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 22:00:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26915] HTML5: DOM binding
 of <datalist> element : [Attachment 32645] Proposed patch (rev.3)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090713050048.7453132EC19D@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32645: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=32645&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Updates more build files including .gypi

From bugzilla-daemon at webkit.org  Sun Jul 12 22:24:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 22:24:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27179] Facebook Chat is
 broken due to XSS auditor : [Attachment 32642] patch
In-Reply-To: <bug-27179-0@https.bugs.webkit.org/>
References: <bug-27179-0@https.bugs.webkit.org/>
Message-ID: <20090713052446.0CD4732ECA66@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27179: Facebook Chat is broken due to XSS auditor
https://bugs.webkit.org/show_bug.cgi?id=27179

Attachment 32642: patch
https://bugs.webkit.org/attachment.cgi?id=32642&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

From bugzilla-daemon at webkit.org  Sun Jul 12 23:41:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 12 Jul 2009 23:41:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27205] [Qt] Buildfix for
 QtWebKit on Win : [Attachment 32647] Proposed patch.
In-Reply-To: <bug-27205-0@https.bugs.webkit.org/>
References: <bug-27205-0@https.bugs.webkit.org/>
Message-ID: <20090713064157.C451D32EE869@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27205: [Qt] Buildfix for QtWebKit on Win
https://bugs.webkit.org/show_bug.cgi?id=27205

Attachment 32647: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=32647&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Tested on win32-msvc2005.

From bugzilla-daemon at webkit.org  Mon Jul 13 00:20:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 00:20:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22706] Don't respect number
 of columns : [Attachment 32648] Add --websocket flag in build-webkit and
 ENABLE_WEBSOCKET define.
In-Reply-To: <bug-22706-0@https.bugs.webkit.org/>
References: <bug-22706-0@https.bugs.webkit.org/>
Message-ID: <20090713072041.62E6232EF720@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 22706: Don't respect number of columns
https://bugs.webkit.org/show_bug.cgi?id=22706

Attachment 32648: Add --websocket flag in build-webkit and ENABLE_WEBSOCKET
define.
https://bugs.webkit.org/attachment.cgi?id=32648&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 7 files changed, 85 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 00:24:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 00:24:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32649] Add --websocket flag in
 build-webkit and ENABLE_WEBSOCKET define.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090713072411.3815732EF874@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32649: Add --websocket flag in build-webkit and ENABLE_WEBSOCKET
define.
https://bugs.webkit.org/attachment.cgi?id=32649&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 7 files changed, 85 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 00:33:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 00:33:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26932] Add
 ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs : [Attachment
 32614] Removed test expectations that were incorrectly generated with
 non-default flags.
In-Reply-To: <bug-26932-0@https.bugs.webkit.org/>
References: <bug-26932-0@https.bugs.webkit.org/>
Message-ID: <20090713073323.8D8B732EFC14@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26932: Add ENABLE(SHARED_WORKERS) flag and define SharedWorker APIs
https://bugs.webkit.org/show_bug.cgi?id=26932

Attachment 32614: Removed test expectations that were incorrectly generated
with non-default flags.
https://bugs.webkit.org/attachment.cgi?id=32614&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> While working on a patch based on this patch, I found a bug in how
> AbstractWorker::toJS() worked, so I added a custom toJS() function in
> AbstractWorker.

It would have been nice to fix this issue while adding a layout tests that
caught the issue, but it sounds like your later patch will have a layout test
which catches this.

This looks fine.  I have a few very minor nits which I'll address while
landing.


> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +	   (WebCore::AbstractWorker::AbstractWorker):
> +	   Common baseclass for SharedWorker and (soon) Worker. The functions
below were copied from Worker.cpp.

s/baseclass/base class/


> diff --git a/WebCore/workers/AbstractWorker.cpp
b/WebCore/workers/AbstractWorker.cpp
> +#include "AbstractWorker.h"

Typically a blank line is after the header for the cpp file.



> diff --git a/WebCore/workers/AbstractWorker.h
b/WebCore/workers/AbstractWorker.h

> +
> +#if ENABLE(SHARED_WORKERS)
> +
> +#include "AtomicStringHash.h"
> +#include "ActiveDOMObject.h"

Out of order.

From bugzilla-daemon at webkit.org  Mon Jul 13 00:44:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 00:44:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 22706] Don't respect number
 of columns : [Attachment 32648] Add --websocket flag in build-webkit and
 ENABLE_WEBSOCKET define.
In-Reply-To: <bug-22706-0@https.bugs.webkit.org/>
References: <bug-22706-0@https.bugs.webkit.org/>
Message-ID: <20090713074455.98BFC32F008C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 22706: Don't respect number of columns
https://bugs.webkit.org/show_bug.cgi?id=22706

Attachment 32648: Add --websocket flag in build-webkit and ENABLE_WEBSOCKET
define.
https://bugs.webkit.org/attachment.cgi?id=32648&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
wrong bug.

From bugzilla-daemon at webkit.org  Mon Jul 13 00:45:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 00:45:54 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27055] Qualify include path
 with wtf : [Attachment 32415] Code patch for Interpreter.h
In-Reply-To: <bug-27055-0@https.bugs.webkit.org/>
References: <bug-27055-0@https.bugs.webkit.org/>
Message-ID: <20090713074554.45AA632F00F2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27055: Qualify include path with wtf
https://bugs.webkit.org/show_bug.cgi?id=27055

Attachment 32415: Code patch for Interpreter.h
https://bugs.webkit.org/attachment.cgi?id=32415&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
r- per Darin's comment.

From bugzilla-daemon at webkit.org  Mon Jul 13 00:54:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 00:54:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27208] Add open as event
 name,
 which is used in WebSocket : [Attachment 32650] add open in event names
In-Reply-To: <bug-27208-0@https.bugs.webkit.org/>
References: <bug-27208-0@https.bugs.webkit.org/>
Message-ID: <20090713075449.E3C1332F04D9@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27208: Add open as event name, which is used in WebSocket
https://bugs.webkit.org/show_bug.cgi?id=27208

Attachment 32650: add open in event names
https://bugs.webkit.org/attachment.cgi?id=32650&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 2 files changed, 10 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 01:00:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 01:00:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32651] patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090713080046.EB69F32F070F@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32651: patch
https://bugs.webkit.org/attachment.cgi?id=32651&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 01:10:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 01:10:42 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32509] Add cpplint w/ some autofix
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090713081042.6CDC332F0AED@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32509: Add cpplint w/ some autofix
https://bugs.webkit.org/attachment.cgi?id=32509&action=review

------- Additional Comments from David Levin <levin at chromium.org>
General comments:

Thanks for tackling this!

First, I know it was suggested that this tool be able to automatically fix
errors but this patch is huge without that support.  It would be nice to do the
review without that added support and then add it.  I have two reasons for
this:
   1. It is less to review in this initial pass.
   2. I would like to be able to review that code in more detail since it is
pretty new and untested (unlike the rest of the code which mostly has been in
use already).

Secondly, WebKit python code is following the python coding style
(http://www.python.org/dev/peps/pep-0008/, which is different from Google's). 
The main differences are 
   1. indent code by 4 space not 2. Fortunately, you can use
http://svn.python.org/projects/python/trunk/Tools/scripts/reindent.py to
automatically do this for you.
   2. Function/Method names should be lower_case_with_underscores as opposed to
CamelCase

I didn't do an in depth review at this point, but I left a few comments on
things I noticed during a quick look.

> +++ b/WebKitTools/Scripts/cpplint.py
> @@ -0,0 +1,3362 @@
> +#!/usr/bin/python2.4

"#!/usr/bin/python"


> +# Here are some issues that I've had people identify in my code during
reviews,
> +# that I think are possible to flag automatically in a lint tool.  If these
were
> +# caught by lint, it would save time both for myself and that of my
reviewers.
> +# Most likely, some of these are beyond the scope of the current lint
framework,
> +# but I think it is valuable to retain these wish-list items even if they
cannot
> +# be immediately implemented.
> +#
> +#  Suggestions
> +#  -----------
> +#  - Check for no 'explicit' for multi-arg ctor
> +#  - Check for boolean assign RHS in parens
> +#  - Check for ctor initializer-list colon position and spacing
> +#  - Check that if there's a ctor, there should be a dtor
> +#  - Check accessors that return non-pointer member variables are
> +#	declared const
> +#  - Check accessors that return non-const pointer member vars are
> +#	*not* declared const
> +#  - Check for using public includes for testing
> +#  - Check for spaces between brackets in one-line inline method
> +#  - Check for no assert()
> +#  - Check for spaces surrounding operators
> +#  - Check for 0 in pointer context (should be NULL)
> +#  - Check for 0 in char context (should be '\0')
> +#  - Check for camel-case method name conventions for methods
> +#	that are not simple inline getters and setters
> +#  - Check that base classes have virtual destructors
> +#	put "  // namespace" after } that closes a namespace, with
> +#	namespace's name after 'namespace' if it is named.
> +#  - Do not indent namespace contents
> +#  - Avoid inlining non-trivial constructors in header files
> +#  - Check for old-school (void) cast for call-sites of functions
> +#	ignored return value
> +#  - Check for class declaration order (typedefs, consts, enums,
> +#	ctor(s?), dtor, friend declarations, methods, member vars)

Several of these are either not relevant to WebKit or just plain not correct,
so I think this whole comment should just be deleted.




> +# Matches invalid increment: *count++, which moves pointer insead of

s/insead/instead/

> +
> +def CheckInvalidIncrement(filename, clean_lines, linenum, error):
> +  """Checks for invalud increment *count++.

s/invalud/invalid/

From bugzilla-daemon at webkit.org  Mon Jul 13 01:28:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 01:28:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32586] Take away space out of
 ARROW_KEYS_POP_MENU and into SPACE_POP_MENU for platforms that display the
 popup when spacebar is pressed
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090713082821.4AFCE32F1311@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled  review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32586: Take away space out of ARROW_KEYS_POP_MENU and into
SPACE_POP_MENU for platforms that display the popup when spacebar is pressed
https://bugs.webkit.org/attachment.cgi?id=32586&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 01:28:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 01:28:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32652] addressed eric's
 feedback and added a manual test
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090713082827.2E91B32F132D@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32652: addressed eric's feedback and added a manual test
https://bugs.webkit.org/attachment.cgi?id=32652&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 01:31:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 01:31:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27191] [Qt] Cleanup - Remove
 prf install target : [Attachment 32630] Proposed patch.
In-Reply-To: <bug-27191-0@https.bugs.webkit.org/>
References: <bug-27191-0@https.bugs.webkit.org/>
Message-ID: <20090713083153.81DC332F14DB@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27191: [Qt] Cleanup - Remove prf install target
https://bugs.webkit.org/show_bug.cgi?id=27191

Attachment 32630: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=32630&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Mon Jul 13 02:13:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 02:13:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27209] Add WebSocket.idl :
 [Attachment 32653] Add WebSocket.idl
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090713091346.A396D32F262A@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 32653: Add WebSocket.idl
https://bugs.webkit.org/attachment.cgi?id=32653&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 2 files changed, 63 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 02:52:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 02:52:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 3749] XHTML 1.1 Ruby
 Annotation : [Attachment 32654] patch: implementation of minimal HTML5 ruby
 support
In-Reply-To: <bug-3749-0@https.bugs.webkit.org/>
References: <bug-3749-0@https.bugs.webkit.org/>
Message-ID: <20090713095248.19F4F32F37D4@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked Dave Hyatt
<hyatt at apple.com> for review:
Bug 3749: XHTML 1.1 Ruby  Annotation
https://bugs.webkit.org/show_bug.cgi?id=3749

Attachment 32654: patch: implementation of minimal HTML5 ruby support
https://bugs.webkit.org/attachment.cgi?id=32654&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Reduced-size patch for HTML5 ruby support. The patch contains no layout tests,
which will be contained in a separate patch file, to make things more
manageable.

From bugzilla-daemon at webkit.org  Mon Jul 13 03:02:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 03:02:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 3749] XHTML 1.1 Ruby
 Annotation : [Attachment 32655] patch: layout tests for ruby implementation
In-Reply-To: <bug-3749-0@https.bugs.webkit.org/>
References: <bug-3749-0@https.bugs.webkit.org/>
Message-ID: <20090713100250.A775432F3C74@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked Dave Hyatt
<hyatt at apple.com> for review:
Bug 3749: XHTML 1.1 Ruby  Annotation
https://bugs.webkit.org/show_bug.cgi?id=3749

Attachment 32655: patch: layout tests for ruby implementation
https://bugs.webkit.org/attachment.cgi?id=32655&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
The layout tests for the ruby implementation - see previous patch attachment.

From bugzilla-daemon at webkit.org  Mon Jul 13 03:37:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 03:37:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27210] [Qt] Add an API to
 get a list of installed plugins : [Attachment 32656] patch
In-Reply-To: <bug-27210-0@https.bugs.webkit.org/>
References: <bug-27210-0@https.bugs.webkit.org/>
Message-ID: <20090713103720.677DA32F4B4E@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27210: [Qt] Add an API to get a list of installed plugins
https://bugs.webkit.org/show_bug.cgi?id=27210

Attachment 32656: patch
https://bugs.webkit.org/attachment.cgi?id=32656&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
The attached patch adds a new function: QWebPluginFactory::installedPlugins()
that returns a list of plugins currently installed and recognized by WebKit,
with an autotest.

From bugzilla-daemon at webkit.org  Mon Jul 13 05:04:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 05:04:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27211] fastMalloc and
 fastFree mismatch correction : [Attachment 32657] proposed patch
In-Reply-To: <bug-27211-0@https.bugs.webkit.org/>
References: <bug-27211-0@https.bugs.webkit.org/>
Message-ID: <20090713120412.52DE232F71D3@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27211: fastMalloc and fastFree mismatch correction
https://bugs.webkit.org/show_bug.cgi?id=27211

Attachment 32657: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32657&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 07:05:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 07:05:30 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32509] Add cpplint w/ some autofix
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090713140530.BF0E132FA705@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32509: Add cpplint w/ some autofix
https://bugs.webkit.org/attachment.cgi?id=32509&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 07:05:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 07:05:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32660] first cpplint
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090713140543.91AC332FA74E@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32660: first cpplint
https://bugs.webkit.org/attachment.cgi?id=32660&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 5799 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 07:47:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 07:47:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27205] [Qt] Buildfix for
 QtWebKit on Win : [Attachment 32647] Proposed patch.
In-Reply-To: <bug-27205-0@https.bugs.webkit.org/>
References: <bug-27205-0@https.bugs.webkit.org/>
Message-ID: <20090713144759.3C23432FB8F6@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27205: [Qt] Buildfix for QtWebKit on Win
https://bugs.webkit.org/show_bug.cgi?id=27205

Attachment 32647: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=32647&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Looks good, thanks!

From bugzilla-daemon at webkit.org  Mon Jul 13 07:59:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 07:59:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32606]
 Height Patch
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090713145925.5DD1332FBDE8@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32606: Height Patch
https://bugs.webkit.org/attachment.cgi?id=32606&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
It's really great to see this getting fixed!

I have a few comments about the general approach to this fix:

I think it's not good to be duplicating more code from WebKit/mac in
WebKit/win. A much better way to fix this would be to move most of the
WebKit/mac code down into WebCore, where it can be shared by WebKit/win. The
idea would be to have all the logic down in WebCore, and only call up to WebKit
when absolutely necessary. A rough division of responsibility would be:

WebCore:
 * Calculates new window sizes
 * Saves/restores window size preference

WebKit:
 * Actually resizes the windows to the dimensions specified by WebCore

So I think you should redo this in at least two parts:

1) Move most WebKit/mac logic related to the window size down to WebCore
2) Add in the WebKit/win bits

Please feel free to ask more questions here in the bug!

From bugzilla-daemon at webkit.org  Mon Jul 13 09:21:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 09:21:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26953] [V8] Do not do
 unnecessary handles casts and inline couple of methods : [Attachment 32659]
 Switching to NDEBUG
In-Reply-To: <bug-26953-0@https.bugs.webkit.org/>
References: <bug-26953-0@https.bugs.webkit.org/>
Message-ID: <20090713162133.A4A9C32FDE27@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted  review:
Bug 26953: [V8] Do not do unnecessary handles casts and inline couple of
methods
https://bugs.webkit.org/show_bug.cgi?id=26953

Attachment 32659: Switching to NDEBUG
https://bugs.webkit.org/attachment.cgi?id=32659&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me.

From bugzilla-daemon at webkit.org  Mon Jul 13 09:28:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 09:28:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27218] [V8] Add missing
 check for constructor call in WebKitCSSMatrixConstructor : [Attachment
 32662] Add missing cosntructor call check, v1.
In-Reply-To: <bug-27218-0@https.bugs.webkit.org/>
References: <bug-27218-0@https.bugs.webkit.org/>
Message-ID: <20090713162829.E37F232FE0EF@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 27218: [V8] Add missing check for constructor call in
WebKitCSSMatrixConstructor
https://bugs.webkit.org/show_bug.cgi?id=27218

Attachment 32662: Add missing cosntructor call check, v1.
https://bugs.webkit.org/attachment.cgi?id=32662&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 LayoutTests/ChangeLog				    |	10 +++++++
 .../fast/css/matrix-as-function-crash-expected.txt |	 3 ++
 LayoutTests/fast/css/matrix-as-function-crash.html |	27 ++++++++++++++++++++
 WebCore/ChangeLog				    |	11 ++++++++
 .../v8/custom/V8WebKitCSSMatrixConstructor.cpp     |	 4 +++
 5 files changed, 55 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 09:30:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 09:30:15 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27218] [V8] Add missing check
 for constructor call in WebKitCSSMatrixConstructor : [Attachment 32662] Add
 missing cosntructor call check, v1.
In-Reply-To: <bug-27218-0@https.bugs.webkit.org/>
References: <bug-27218-0@https.bugs.webkit.org/>
Message-ID: <20090713163015.16F5732FE194@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Dimitri Glazkov
(Google) <dglazkov at chromium.org>'s request for review:
Bug 27218: [V8] Add missing check for constructor call in
WebKitCSSMatrixConstructor
https://bugs.webkit.org/show_bug.cgi?id=27218

Attachment 32662: Add missing cosntructor call check, v1.
https://bugs.webkit.org/attachment.cgi?id=32662&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,14 @@
> +2009-07-13  Dimitri Glazkov	<dglazkov at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [V8] Add a missing check for constructor call in
WebKitCSSMatrixConstructor.
> +
> +	   Test: fast/css/matrix-as-function-crash.html
> +
> +	   * bindings/v8/custom/V8WebKitCSSMatrixConstructor.cpp:
> +	   (WebCore::CALLBACK_FUNC_DECL): Added a check for constructor call.

^^^ needs a bug link

r=me

From bugzilla-daemon at webkit.org  Mon Jul 13 09:57:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 09:57:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27217] Straight quotes
 should match fancy quotes in in-page search : [Attachment 32663] patch
In-Reply-To: <bug-27217-0@https.bugs.webkit.org/>
References: <bug-27217-0@https.bugs.webkit.org/>
Message-ID: <20090713165752.85C2432FEC54@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27217: Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217

Attachment 32663: patch
https://bugs.webkit.org/attachment.cgi?id=32663&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 09:59:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 09:59:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27087] Add New
 Configuration Flag for Redistributable Windows Build : [Attachment 32664]
 Revise to use vsprops instead of project modifications. Use WIN_CAIRO label
 instead of WIN_REDISTRIBUTABLE.
In-Reply-To: <bug-27087-0@https.bugs.webkit.org/>
References: <bug-27087-0@https.bugs.webkit.org/>
Message-ID: <20090713165922.289A932FECEF@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 27087: Add New Configuration Flag for Redistributable Windows Build
https://bugs.webkit.org/show_bug.cgi?id=27087

Attachment 32664: Revise to use vsprops instead of project modifications.  Use
WIN_CAIRO label instead of WIN_REDISTRIBUTABLE.
https://bugs.webkit.org/attachment.cgi?id=32664&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 10:32:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 10:32:02 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27211] fastMalloc and fastFree
 mismatch correction : [Attachment 32657] proposed patch
In-Reply-To: <bug-27211-0@https.bugs.webkit.org/>
References: <bug-27211-0@https.bugs.webkit.org/>
Message-ID: <20090713173202.CB48E32FFAEF@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27211: fastMalloc and fastFree mismatch correction
https://bugs.webkit.org/show_bug.cgi?id=27211

Attachment 32657: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32657&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 10:45:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 10:45:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27166] Find for strings
 composed entirely of spaces doesn't work : [Attachment 32665] patch
In-Reply-To: <bug-27166-0@https.bugs.webkit.org/>
References: <bug-27166-0@https.bugs.webkit.org/>
Message-ID: <20090713174555.88CEC33000FD@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27166: Find for strings composed entirely of spaces doesn't work
https://bugs.webkit.org/show_bug.cgi?id=27166

Attachment 32665: patch
https://bugs.webkit.org/attachment.cgi?id=32665&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 11:01:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 11:01:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27166] Find for strings
 composed entirely of spaces doesn't work : [Attachment 32665] patch
In-Reply-To: <bug-27166-0@https.bugs.webkit.org/>
References: <bug-27166-0@https.bugs.webkit.org/>
Message-ID: <20090713180102.D120C3300776@gamma.macosforge.org>

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 27166: Find for strings composed entirely of spaces doesn't work
https://bugs.webkit.org/show_bug.cgi?id=27166

Attachment 32665: patch
https://bugs.webkit.org/attachment.cgi?id=32665&action=review

------- Additional Comments from mitz at webkit.org
> -    // whitespace, so we won't even try. This also takes care of the empty
string case.

What takes care of the empty string case now? Is there a test for it? r=me if
the empty string case is covered.

From bugzilla-daemon at webkit.org  Mon Jul 13 11:03:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 11:03:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27223] Add
 HTMLAllCollection.idl to WebCore.gypi : [Attachment 32666] patch
In-Reply-To: <bug-27223-0@https.bugs.webkit.org/>
References: <bug-27223-0@https.bugs.webkit.org/>
Message-ID: <20090713180310.045EF3300855@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27223: Add HTMLAllCollection.idl to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=27223

Attachment 32666: patch
https://bugs.webkit.org/attachment.cgi?id=32666&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 11:03:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 11:03:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27087] Add New Configuration
 Flag for Redistributable Windows Build : [Attachment 32664] Revise to use
 vsprops instead of project modifications. Use WIN_CAIRO label instead of
 WIN_REDISTRIBUTABLE.
In-Reply-To: <bug-27087-0@https.bugs.webkit.org/>
References: <bug-27087-0@https.bugs.webkit.org/>
Message-ID: <20090713180322.108523300880@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 27087: Add New Configuration Flag for Redistributable Windows Build
https://bugs.webkit.org/show_bug.cgi?id=27087

Attachment 32664: Revise to use vsprops instead of project modifications.  Use
WIN_CAIRO label instead of WIN_REDISTRIBUTABLE.
https://bugs.webkit.org/attachment.cgi?id=32664&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebCore/WebCore.vcproj/WebCore.vcproj	(working copy)
> @@ -183,8 +183,9 @@
>		</Configuration>
>		<Configuration
>			Name="Debug_Cairo|Win32"
> +			IntermediateDirectory="$(ConfigurationName)"

I don't think you meant to add this.

> +++ WebKit/win/ChangeLog	(working copy)
> @@ -1,3 +1,23 @@
> +2009-07-13  Brent Fulgham  <bfulgham at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add new configuration flag for redistributable Windows build.
> +	   https://bugs.webkit.org/show_bug.cgi=27087
> +
> +	   * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to
> +	     Debug_Cairo and Release_Cairo targets.
> +
> +2009-07-13  Brent Fulgham  <bfulgham at webkit.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Add new configuration flag for redistributable Windows build.
> +	   https://bugs.webkit.org/show_bug.cgi=27087
> +
> +	   * WebKit.vcproj/WebKit.vcproj: Add new WinCairo.vsprops to the
> +	     Release_Cairo and Debug_Cairo targets.

Double double!

r=me

From bugzilla-daemon at webkit.org  Mon Jul 13 11:04:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 11:04:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27223] Add
 HTMLAllCollection.idl to WebCore.gypi : [Attachment 32666] patch
In-Reply-To: <bug-27223-0@https.bugs.webkit.org/>
References: <bug-27223-0@https.bugs.webkit.org/>
Message-ID: <20090713180413.969AF33008E1@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27223: Add HTMLAllCollection.idl to WebCore.gypi
https://bugs.webkit.org/show_bug.cgi?id=27223

Attachment 32666: patch
https://bugs.webkit.org/attachment.cgi?id=32666&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me. For these kinds of things, you could probably just use lisppaste.

From bugzilla-daemon at webkit.org  Mon Jul 13 11:09:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 11:09:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27224] WebInspector: handle
 debugger shortcuts when focus is on source frame or on script file
 selector. : [Attachment 32667] patch
In-Reply-To: <bug-27224-0@https.bugs.webkit.org/>
References: <bug-27224-0@https.bugs.webkit.org/>
Message-ID: <20090713180920.C975D3300B46@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27224: WebInspector: handle debugger shortcuts when focus is on source
frame or on script file selector.
https://bugs.webkit.org/show_bug.cgi?id=27224

Attachment 32667: patch
https://bugs.webkit.org/attachment.cgi?id=32667&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Currently shortcuts are not handled when SourceFrame or fileSelector elements
have focus.

From bugzilla-daemon at webkit.org  Mon Jul 13 11:44:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 11:44:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27225] Change all
 Noncopyable inheriting to publicly inheriting : [Attachment 32668] proposed
 patch
In-Reply-To: <bug-27225-0@https.bugs.webkit.org/>
References: <bug-27225-0@https.bugs.webkit.org/>
Message-ID: <20090713184418.667CA3301B0D@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27225: Change all Noncopyable inheriting to publicly inheriting
https://bugs.webkit.org/show_bug.cgi?id=27225

Attachment 32668: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32668&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 12:17:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 12:17:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27228] Add
 NoncopyableCustomAllocated to Noncopyable.h : [Attachment 32670] proposed
 patch
In-Reply-To: <bug-27228-0@https.bugs.webkit.org/>
References: <bug-27228-0@https.bugs.webkit.org/>
Message-ID: <20090713191717.AB66E3302AF2@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27228: Add NoncopyableCustomAllocated to Noncopyable.h
https://bugs.webkit.org/show_bug.cgi?id=27228

Attachment 32670: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32670&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 12:37:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 12:37:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27228] Add
 NoncopyableCustomAllocated to Noncopyable.h : [Attachment 32670] proposed
 patch
In-Reply-To: <bug-27228-0@https.bugs.webkit.org/>
References: <bug-27228-0@https.bugs.webkit.org/>
Message-ID: <20090713193701.7B4203303339@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27228: Add NoncopyableCustomAllocated to Noncopyable.h
https://bugs.webkit.org/show_bug.cgi?id=27228

Attachment 32670: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32670&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 12:40:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 12:40:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27232] Add
 RefCountedCustomAllocated to RefCounted.h : [Attachment 32671] proposed
 patch
In-Reply-To: <bug-27232-0@https.bugs.webkit.org/>
References: <bug-27232-0@https.bugs.webkit.org/>
Message-ID: <20090713194055.A6CB333034F8@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27232: Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232

Attachment 32671: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32671&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 12:49:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 12:49:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27232] Add
 RefCountedCustomAllocated to RefCounted.h : [Attachment 32671] proposed
 patch
In-Reply-To: <bug-27232-0@https.bugs.webkit.org/>
References: <bug-27232-0@https.bugs.webkit.org/>
Message-ID: <20090713194940.578A433038A9@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27232: Add RefCountedCustomAllocated to RefCounted.h
https://bugs.webkit.org/show_bug.cgi?id=27232

Attachment 32671: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32671&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 13:07:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 13:07:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27170] drawImage method of
 HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment
 32672] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090713200708.3F01B3303FC8@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27170: drawImage method of HTMLCanvasElement to accept HTMLVideoElement as
argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32672: patch
https://bugs.webkit.org/attachment.cgi?id=32672&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 13:09:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 13:09:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27131] Disable continuous
 spell checking in the inspector : [Attachment 32673] Use the spellcheck
 attribute to disable continuous spell checking in the inspector
In-Reply-To: <bug-27131-0@https.bugs.webkit.org/>
References: <bug-27131-0@https.bugs.webkit.org/>
Message-ID: <20090713200914.147D033040C0@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27131: Disable continuous spell checking in the inspector
https://bugs.webkit.org/show_bug.cgi?id=27131

Attachment 32673: Use the spellcheck attribute to disable continuous spell
checking in the inspector
https://bugs.webkit.org/attachment.cgi?id=32673&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 13:10:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 13:10:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27131] Disable continuous
 spell checking in the inspector : [Attachment 32673] Use the spellcheck
 attribute to disable continuous spell checking in the inspector
In-Reply-To: <bug-27131-0@https.bugs.webkit.org/>
References: <bug-27131-0@https.bugs.webkit.org/>
Message-ID: <20090713201033.283DD3304184@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 27131: Disable continuous spell checking in the inspector
https://bugs.webkit.org/show_bug.cgi?id=27131

Attachment 32673: Use the spellcheck attribute to disable continuous spell
checking in the inspector
https://bugs.webkit.org/attachment.cgi?id=32673&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 13:51:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 13:51:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27224] WebInspector: handle
 debugger shortcuts when focus is on source frame or on script file
 selector. : [Attachment 32667] patch
In-Reply-To: <bug-27224-0@https.bugs.webkit.org/>
References: <bug-27224-0@https.bugs.webkit.org/>
Message-ID: <20090713205119.C55EC3305342@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27224: WebInspector: handle debugger shortcuts when focus is on source
frame or on script file selector.
https://bugs.webkit.org/show_bug.cgi?id=27224

Attachment 32667: patch
https://bugs.webkit.org/attachment.cgi?id=32667&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 13:57:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 13:57:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27236] Memory is not
 released back to the system from TCMalloc on Windows : [Attachment 32677]
 This patch implements TCMalloc_SystemRelease() on windows and adds a new
 mechanism to release memory back to the system via a background thread.
In-Reply-To: <bug-27236-0@https.bugs.webkit.org/>
References: <bug-27236-0@https.bugs.webkit.org/>
Message-ID: <20090713205734.3C18D3305607@gamma.macosforge.org>

Ada Chan <adachan at apple.com> has asked	for review:
Bug 27236: Memory is not released back to the system from TCMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=27236

Attachment 32677: This patch implements TCMalloc_SystemRelease() on windows and
adds a new mechanism to release memory back to the system via a background
thread.
https://bugs.webkit.org/attachment.cgi?id=32677&action=review

------- Additional Comments from Ada Chan <adachan at apple.com>
This patch implements TCMalloc_SystemRelease() on windows and adds a new
mechanism to release memory back to the system via a background thread.  That
new mechanism is turned on by default.	

Every 5 seconds, the background thread wakes up and does the following:
- Check if the number of pages allocated in the last 5 seconds is greater than
1/3 of the free committed pages.  If so, skip this scavenge because it's a sign
that there is a lot of activity going on right now and thrashing may happen if
we release memory back to the system now.
- Otherwise, go through the list of free spans (from largest to smallest) and
release up to 1/3 of the free committed pages back to the system.  We can
release more if there's absolutely no activity going on in the last 5 seconds.
- If the number of free committed pages reaches kMinimumFreeCommittedPageCount,
we can stop the scavenging and block the scavenging thread until the number of
free committed pages goes above kMinimumFreeCommittedPageCount.

From bugzilla-daemon at webkit.org  Mon Jul 13 14:11:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 14:11:03 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27170] [V8] drawImage method
 of HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment
 32672] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090713211103.3F0623305B52@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27170: [V8] drawImage method of HTMLCanvasElement to accept
HTMLVideoElement as argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32672: patch
https://bugs.webkit.org/attachment.cgi?id=32672&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 14:52:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 14:52:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27237] Make V8DOMMap.h
 compiling with gcc option -Werror=non-virtual-dtor : [Attachment 32680]
 patch
In-Reply-To: <bug-27237-0@https.bugs.webkit.org/>
References: <bug-27237-0@https.bugs.webkit.org/>
Message-ID: <20090713215235.BF1AB3306720@gamma.macosforge.org>

Feng Qian <feng at chromium.org> has asked  for review:
Bug 27237: Make V8DOMMap.h compiling with gcc option -Werror=non-virtual-dtor
https://bugs.webkit.org/show_bug.cgi?id=27237

Attachment 32680: patch
https://bugs.webkit.org/attachment.cgi?id=32680&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 14:53:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 14:53:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27170] [V8] drawImage
 method of HTMLCanvasElement to accept HTMLVideoElement as argument :
 [Attachment 32679] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090713215314.A2EC0330677F@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27170: [V8] drawImage method of HTMLCanvasElement to accept
HTMLVideoElement as argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32679: patch
https://bugs.webkit.org/attachment.cgi?id=32679&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 14:59:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 14:59:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27237] Make V8DOMMap.h
 compiling with gcc option -Werror=non-virtual-dtor : [Attachment 32680]
 patch
In-Reply-To: <bug-27237-0@https.bugs.webkit.org/>
References: <bug-27237-0@https.bugs.webkit.org/>
Message-ID: <20090713215951.CA6ED3306A4D@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Feng Qian
<feng at chromium.org>'s request for review:
Bug 27237: Make V8DOMMap.h compiling with gcc option -Werror=non-virtual-dtor
https://bugs.webkit.org/show_bug.cgi?id=27237

Attachment 32680: patch
https://bugs.webkit.org/attachment.cgi?id=32680&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Mon Jul 13 15:28:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 15:28:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20348] Background color
 formatting lost on enter : [Attachment 32684] fixes the bug by making more
 CSS properties inheritable.
In-Reply-To: <bug-20348-0@https.bugs.webkit.org/>
References: <bug-20348-0@https.bugs.webkit.org/>
Message-ID: <20090713222825.6EFF633076BD@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 20348: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Attachment 32684: fixes the bug by making more CSS properties inheritable.
https://bugs.webkit.org/attachment.cgi?id=32684&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 15:46:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 15:46:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27240] Refactor
 WebFrame::spoolPages to share with Windows Cairo : [Attachment 32685]
 Refactor page spooling
In-Reply-To: <bug-27240-0@https.bugs.webkit.org/>
References: <bug-27240-0@https.bugs.webkit.org/>
Message-ID: <20090713224628.CDBD03307DF8@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 27240: Refactor WebFrame::spoolPages to share with Windows Cairo
https://bugs.webkit.org/show_bug.cgi?id=27240

Attachment 32685: Refactor page spooling
https://bugs.webkit.org/attachment.cgi?id=32685&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
Refactor page spooling code to share with Cairo port.

From bugzilla-daemon at webkit.org  Mon Jul 13 15:51:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 15:51:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27239] Do not do HTTP
 Refresh to javascript: or other dangerous URI schemes : [Attachment 32686]
 Fix that limits which schemes we will Refresh to
In-Reply-To: <bug-27239-0@https.bugs.webkit.org/>
References: <bug-27239-0@https.bugs.webkit.org/>
Message-ID: <20090713225139.E7FA8330808A@gamma.macosforge.org>

Chris Evans <scarybeasts at gmail.com> has asked Sam Weinig <sam at webkit.org> for
review:
Bug 27239: Do not do HTTP Refresh to javascript: or other dangerous URI schemes
https://bugs.webkit.org/show_bug.cgi?id=27239

Attachment 32686: Fix that limits which schemes we will Refresh to
https://bugs.webkit.org/attachment.cgi?id=32686&action=review

------- Additional Comments from Chris Evans <scarybeasts at gmail.com>
Sam / Adam, something like this?

From bugzilla-daemon at webkit.org  Mon Jul 13 16:00:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 16:00:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27240] Refactor
 WebFrame::spoolPages to share with Windows Cairo : [Attachment 32685]
 Refactor page spooling
In-Reply-To: <bug-27240-0@https.bugs.webkit.org/>
References: <bug-27240-0@https.bugs.webkit.org/>
Message-ID: <20090713230059.94ED2330847A@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 27240: Refactor WebFrame::spoolPages to share with Windows Cairo
https://bugs.webkit.org/show_bug.cgi?id=27240

Attachment 32685: Refactor page spooling
https://bugs.webkit.org/attachment.cgi?id=32685&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +#if PLATFORM(CG)
>  #include <CoreGraphics/CoreGraphics.h>
>  
>  // CG SPI used for printing
> @@ -105,6 +106,9 @@ extern "C" {
>      CGAffineTransform CGContextGetBaseCTM(CGContextRef c); 
>      void CGContextSetBaseCTM(CGContextRef c, CGAffineTransform m); 
>  }
> +#elif PLATFORM(CAIRO)
> +#include <cairo-win32.h>
> +#endif

It's probably best to keep all #includes above all declarations, even though
that will require two #if PLATFORM(CG) blocks.

> +void WebFrame::printHeader(void* ctx, COMPtr<IWebUIDelegate> ui, const
IntRect& pageRect, float headerHeight)

Why can't ctx be a PlatformGraphicsContext*?

ui should just be an IWebUIDelegate*, to avoid ref-count churn.

The same comments apply to all your new functions.

> +    PlatformGraphicsContext* pctx = (PlatformGraphicsContext*)ctx;

static_cast would be better here (if you don't change the type of ctx to
PlatformGraphicsContext).

> +    int x = pageRect.x();
> +    int y = 0;
> +    RECT headerRect = {x, y, x+pageRect.width(), y+(int)headerHeight};
> +    ui->drawHeaderInRect(d->webView, &headerRect, (OLE_HANDLE)(LONG64)pctx);


reinterpret_cast would be better here (I won't comment on other existing uses
of C-style casts).

> +#if PLATFORM(CG)
> +void WebFrame::spoolPage (void* ctx, GraphicsContext* spoolCtx, HDC printDC,
COMPtr<IWebUIDelegate> ui, float headerHeight, float footerHeight, UINT page,
UINT pageCount)

Please remove the space before the opening parenthesis (here and elsewhere in
the patch).

Why not have separate WebFrameCG and WebFrameCairo files for the two
implementations of spoolPage?

> +    float scale = (float)mediaBox.size().width()/ (float)pageRect.width();
> +    cairo_scale(pctx, -scale, -scale);
> +    cairo_translate(pctx, -pageRect.x(), -pageRect.y()+headerHeight);
> +    cairo_scale(pctx, scale, scale);
> +    cairo_translate(pctx, -pageRect.x(), -pageRect.y()+headerHeight);   //
reserves space for header

Seems like we could share all this coordinate space code if we used
GraphicsContext a little more. Maybe add a FIXME?

> +    void spoolPage (void* ctx, WebCore::GraphicsContext* spoolCtx, HDC
printDC, COMPtr<IWebUIDelegate> ui, float headerHeight, float footerHeight,
UINT page, UINT pageCount);
> +    void printHeader(void* ctx, COMPtr<IWebUIDelegate> ui, const
WebCore::IntRect& pageRect, float headerHeight);
> +    void printFooter(void* ctx, COMPtr<IWebUIDelegate> ui, const
WebCore::IntRect& pageRect, UINT page, UINT pageCount, float headerHeight,
float footerHeight);

Please remove the "ui" parameter names from these declarations.

I think drawHeader/drawFooter would be better names, since these functions on
their own don't do any printing.

r=me, but please make these changes first (except for maybe the
WebFrameCG/WebFrameCairo stuff).

From bugzilla-daemon at webkit.org  Mon Jul 13 16:26:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 16:26:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26925] URL Fragment Breaks
 Application Cache Loads : [Attachment 32687] proposed fix
In-Reply-To: <bug-26925-0@https.bugs.webkit.org/>
References: <bug-26925-0@https.bugs.webkit.org/>
Message-ID: <20090713232614.084563308F06@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 26925: URL Fragment Breaks Application Cache Loads
https://bugs.webkit.org/show_bug.cgi?id=26925

Attachment 32687: proposed fix
https://bugs.webkit.org/attachment.cgi?id=32687&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 16:50:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 16:50:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24187] RTL: tooltip does not
 get its directionality from its element's directionality : [Attachment
 31953] patch w/o layout test (version 2)
In-Reply-To: <bug-24187-0@https.bugs.webkit.org/>
References: <bug-24187-0@https.bugs.webkit.org/>
Message-ID: <20090713235025.1FBC8330983B@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 31953: patch w/o layout test (version 2)
https://bugs.webkit.org/attachment.cgi?id=31953&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    RenderObject* renderer = m_innerNonSharedNode->renderer();
> +    if (renderer)
> +	   dir = renderer->style()->direction();

Could have defined the variable inside the if statement.

> +		   RenderObject* renderer = titleNode->renderer();
> +		   if (renderer)
> +		       dir = renderer->style()->direction();

Ditto.

> +    }
> +    else if (isEqual(WebElementTitleKey, key)) {

In WebKit coding style, the else goes on the same line as the brace.

> +void WebChromeClient::setToolTip(const String& toolTip, TextDirection /* dir
*/)

We normally omit the name entirely rather than having it included but commented
out.

r=me

From bugzilla-daemon at webkit.org  Mon Jul 13 16:55:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 16:55:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26925] URL fragment breaks
 application cache loads : [Attachment 32687] proposed fix
In-Reply-To: <bug-26925-0@https.bugs.webkit.org/>
References: <bug-26925-0@https.bugs.webkit.org/>
Message-ID: <20090713235519.29D973309A77@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 26925: URL fragment breaks application cache loads
https://bugs.webkit.org/show_bug.cgi?id=26925

Attachment 32687: proposed fix
https://bugs.webkit.org/attachment.cgi?id=32687&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Should we use KURL more and String less?

From bugzilla-daemon at webkit.org  Mon Jul 13 16:59:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 16:59:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32688]
 Cross Platform Fix + Refactoring
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090713235930.85E5D3309C39@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32688: Cross Platform Fix + Refactoring
https://bugs.webkit.org/attachment.cgi?id=32688&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
Updated patch taking Adam's feedback into account, moving more logic into
InspectorController and away from the clients.

From bugzilla-daemon at webkit.org  Mon Jul 13 18:48:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 18:48:17 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32649] Add --websocket flag in
 build-webkit and ENABLE_WEBSOCKET define.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090714014817.BF2CE330C076@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32649: Add --websocket flag in build-webkit and ENABLE_WEBSOCKET
define.
https://bugs.webkit.org/attachment.cgi?id=32649&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> diff --git a/WebCore/Configurations/FeatureDefines.xcconfig
b/WebCore/Configurations/FeatureDefines.xcconfig
> index 1f196ea..3dade71 100644
> --- a/WebCore/Configurations/FeatureDefines.xcconfig
> +++ b/WebCore/Configurations/FeatureDefines.xcconfig
> @@ -52,5 +52,6 @@ ENABLE_WML = ;
>  ENABLE_WORKERS = ENABLE_WORKERS;
>  ENABLE_XPATH = ENABLE_XPATH;
>  ENABLE_XSLT = ENABLE_XSLT;
> +ENABLE_WEBSOCKET = ;
>  
> -FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DOM_STORAGE) $(ENABLE_FILTERS)
$(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER)
$(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION)
$(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS)
$(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WML)
$(ENABLE_WORKERS) $(ENABLE_XPATH) $(ENABLE_XSLT);
> +FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DOM_STORAGE) $(ENABLE_FILTERS)
$(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER)
$(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION)
$(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS)
$(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WML)
$(ENABLE_WORKERS) $(ENABLE_XPATH) $(ENABLE_XSLT) $(ENABLE_WEBSOCKET);

You need to make the same change to FeatureDefines.xcconfig in the other
locations that it exists (JavaScriptCore and WebKit/mac).  You should also
continue the tradition of keeping this list of variables sorted in alphabetical
order.

> diff --git a/WebKitTools/Scripts/build-webkit
b/WebKitTools/Scripts/build-webkit
> index 9e2f41c..83013dd 100755
> --- a/WebKitTools/Scripts/build-webkit
> +++ b/WebKitTools/Scripts/build-webkit
> @@ -48,7 +48,7 @@ my ($threeDRenderingSupport, $channelMessagingSupport,
$databaseSupport, $domSto
>      $filtersSupport, $geolocationSupport, $gnomeKeyringSupport,
$iconDatabaseSupport,
>      $javaScriptDebuggerSupport, $offlineWebApplicationSupport, $svgSupport,
$svgAnimationSupport,
>      $svgAsImageSupport, $svgDOMObjCBindingsSupport, $svgFontsSupport,
$svgForeignObjectSupport,
> -    $svgUseSupport, $videoSupport, $wmlSupport, $workersSupport,
$xpathSupport, $xsltSupport,
> +    $svgUseSupport, $videoSupport, $wmlSupport, $workersSupport,
$xpathSupport, $xsltSupport, $websocketSupport,
>      $coverageSupport);
>  
>  my @features = (
> @@ -120,6 +120,8 @@ my @features = (
>  
>      { option => "xslt", desc => "Toggle XSLT support",
>	 define => "ENABLE_XSLT", default => 1, value => \$xsltSupport },
> +    { option => "websocket", desc => "Toggle WebSocket support",
> +	 define => "ENABLE_WEBSOCKET", default => 0, value=> \$websocketSupport
},
>  );

Is it "Web Socket", "WebSocket" or "web socket"?  You use different names here
than in configure.ac.  If it's "Web Socket" I would expect the related flag
names to use "web-socket".  If it's the latter, I'd expect "websocket".  I
couldn't find the spec to check this myself, but either way we should be
consistent.

You appear to have missed the related .vcproj changes to apply this to Windows
as well.

r- to address these issues.

From bugzilla-daemon at webkit.org  Mon Jul 13 18:54:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 18:54:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27154] useless null-check
 statement in visible_units.cpp@logicalStartOfLine : [Attachment 32693]
 simple fix: statement removed
In-Reply-To: <bug-27154-0@https.bugs.webkit.org/>
References: <bug-27154-0@https.bugs.webkit.org/>
Message-ID: <20090714015422.99B48330C24D@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27154: useless null-check statement in visible_units.cpp at logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=27154

Attachment 32693: simple fix: statement removed
https://bugs.webkit.org/attachment.cgi?id=32693&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 20:12:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 20:12:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27217] Straight quotes should
 match fancy quotes in in-page search : [Attachment 32663] patch
In-Reply-To: <bug-27217-0@https.bugs.webkit.org/>
References: <bug-27217-0@https.bugs.webkit.org/>
Message-ID: <20090714031214.398A7330D74C@gamma.macosforge.org>

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 27217: Straight quotes should match fancy quotes in in-page search
https://bugs.webkit.org/show_bug.cgi?id=27217

Attachment 32663: patch
https://bugs.webkit.org/attachment.cgi?id=32663&action=review

------- Additional Comments from mitz at webkit.org
r=me if you add a mapping from hebrewPunctuationGershayim to " and from
hebrewPunctuationGeresh (U+05F3, still not in CharacterNames.h) to '

From bugzilla-daemon at webkit.org  Mon Jul 13 22:31:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 22:31:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32660] first cpplint
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714053124.3175B330FC36@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32660: first cpplint
https://bugs.webkit.org/attachment.cgi?id=32660&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Ok, here's my detailed review.	After you address these issues, I think we can
land this.  Thanks for your patience.


Throughout change TODO to FIXME (and get rid of any assignment after the TODO).


i.e. "TODO(levin):" becomes "FIXME:"



> diff --git a/WebKitTools/Scripts/cpplint.py b/WebKitTools/Scripts/cpplint.py
> +_ERROR_CATEGORIES = '''\
> +  build/class

These are still indented by 2 spaces.  Although it is in quotes, might as well
make it 4 to match.


> +# We used to check for high-bit characters, but after much discussion we
> +# decided those were OK, as long as they were in UTF-8 and didn't represent
> +# hard-coded international strings, which belong in a seperate i18n file.

Another Google specific comment that doesn't apply to WebKit.


> +for op, replacement in [('==', 'EQ'), ('!=', 'NE'),
> +			   ('>=', 'GE'), ('>', 'GT'),
> +			   ('<=', 'LE'), ('<', 'LT')]:
> +  _CHECK_REPLACEMENT['DCHECK'][op] = 'DCHECK_%s' % replacement
> +  _CHECK_REPLACEMENT['CHECK'][op] = 'CHECK_%s' % replacement
> +  _CHECK_REPLACEMENT['EXPECT_TRUE'][op] = 'EXPECT_%s' % replacement
> +  _CHECK_REPLACEMENT['ASSERT_TRUE'][op] = 'ASSERT_%s' % replacement
> +  _CHECK_REPLACEMENT['EXPECT_TRUE_M'][op] = 'EXPECT_%s_M' % replacement
> +  _CHECK_REPLACEMENT['ASSERT_TRUE_M'][op] = 'ASSERT_%s_M' % replacement

Two space indent.

> +
> +for op, inv_replacement in [('==', 'NE'), ('!=', 'EQ'),
> +			       ('>=', 'LT'), ('>', 'LE'),
> +			       ('<=', 'GT'), ('<', 'GE')]:
> +  _CHECK_REPLACEMENT['EXPECT_FALSE'][op] = 'EXPECT_%s' % inv_replacement
> +  _CHECK_REPLACEMENT['ASSERT_FALSE'][op] = 'ASSERT_%s' % inv_replacement
> +  _CHECK_REPLACEMENT['EXPECT_FALSE_M'][op] = 'EXPECT_%s_M' % inv_replacement

> +  _CHECK_REPLACEMENT['ASSERT_FALSE_M'][op] = 'ASSERT_%s_M' % inv_replacement


Two space indent.


> +def _output_format():
> +    """Gets the module's output format."""
> +    return _cpplint_state.output_format
> +
> +

A single line to separate the functions is sufficient (though two lines before
a class of course).


> +def find_next_multi_line_comment_start(lines, lineix):
> +    """Find the beginning marker for a multiline comment."""
> +    while lineix < len(lines):

s/lineix/line_index/

> +
> +
> +def close_expression(clean_lines, linenum, pos):

s/lineum/line_number/


> +    line = clean_lines.elided[linenum]
> +    startchar = line[pos]

s/startchar/start_character/

> +    if startchar not in '({[':
> +	   return (line, clean_lines.num_lines(), -1)
> +    if startchar == '(': endchar = ')'

s/endchar/end_character/

> +    if startchar == '[': endchar = ']'
> +    if startchar == '{': endchar = '}'

Put the statements on separate lines
    if startchar == '(':
	endchar = ')'
etc.

> +def check_for_copyright(filename, lines, error):
> +    """Logs an error if no Copyright message appears at the top of the
file."""
> +
> +    # We'll say it should occur by line 10. Don't forget there's a
> +    # dummy line at the front.
> +    for line in xrange(1, min(len(lines), 11)):
> +	   if re.search(r'Copyright', lines[line], re.I): break

Put the statements on separate lines

if re.search(r'Copyright', lines[line], re.I): 
    break

> +    cppvar = get_header_guard_cpp_variable(filename)
> +
> +    ifndef = None
> +    ifndef_linenum = 0

s/ifndef_linenum/ifndef_line_number/

> +    define = None
> +    endif = None
> +    endif_linenum = 0

s/endif_linenum/endif_line_number/

> +    for linenum, line in enumerate(lines):

s/linenum/line_number/ -- throughout this file.

> +	   linesplit = line.split()

s/linesplit/line_split/

> +threading_list = (

THREADING_LIST = (

Since it is a constant.

> +    for single_thread_function, multithread_safe_function in threading_list:

> +	   ix = line.find(single_thread_function)

s/ix/index/

> +    if
search(r'(\w+|[+-]?\d+(\.\d*)?)\s*(<|>)\?=?\s*(\w+|[+-]?\d+)(\.\d*)?',
> +		 line):

I would unwrap this line.

> +    if (args and
> +	   args.group(1) != 'void' and
> +	   not match(r'(const\s+)?%s\s*&' % re.escape(base_classname),
> +		     args.group(1).strip())):

"and" placement. -- Let's follow standard WebKit style and put the "and/or" at
the beginning of the continuation line as opposed to the end of the line.

For example,
    if (args
       and args.group(1) != 'void'
       and not match(r'(const\s+)?%s\s*&' % re.escape(base_classname),
		     args.group(1).strip())):

> +	   if ((classinfo.virtual_method_linenumber is not None) and
> +	       (not classinfo.has_virtual_destructor) and
> +	       (not classinfo.is_derived)):  # Only warn for base classes

"and" placement.

> +    if (  # Ignore control structures.
> +	   not search(r'\b(if|for|while|switch|return|new|delete)\b', fncall)
and
> +	   # Ignore pointers/references to functions.
> +	   not search(r' \([^)]+\)\([^)]*(\)|,$)', fncall) and
> +	   # Ignore pointers/references to arrays.
> +	   not search(r' \([^)]+\)\[[^\]]+\]', fncall)):

"and" placement.

> +	   if function_name == 'TEST' or function_name == 'TEST_F' or (
> +	       not match(r'[A-Z_]+$', function_name)):

I would just unwrap this line. (WebKit doesn't stop code at 80 columns.)


> +    # Next, we complain if there's a comment too near the text
> +    commentpos = line.find('//')

s/commentpos/comment_position/


> +    if commentpos != -1:
> +	   # Check if the // may be in quotes.	If so, ignore it
> +	   # Comparisons made explicit for clarity -- pylint: disable-msg=C6403

> +	   if (line.count('"', 0, commentpos) -
> +	       line.count('\\"', 0, commentpos)) % 2 == 0:   # not in quotes

I would unwrap this.

> +	       # Allow one space for new scopes, two spaces otherwise:
> +	       if (not match(r'^\s*{ //', line) and
> +		   ((commentpos >= 1 and
> +		     line[commentpos-1] not in string.whitespace) or
> +		    (commentpos >= 2 and
> +		     line[commentpos-2] not in string.whitespace))):

"and/or" placment

> +		   matched = (search(r'[=/-]{4,}\s*$', line[commentend:]) or
> +			    search(r'^/+ ', line[commentend:]))

"or" placement

> +    matched = search(r'\b(if|for|while|switch)\s*'
> +		      r'\(([ ]*)(.).*[^ ]+([ ]*)\)\s*{\s*$',
> +		      line)

These two lines should be indented slightly.


> +    if matched:
> +	   if len(matched.group(2)) != len(matched.group(4)):
> +	       if not (matched.group(3) == ';' and
> +		       len(matched.group(2)) == 1 + len(matched.group(4)) or
> +		       not matched.group(2) and search(r'\bfor\s*\(.*; \)',
line)):

"and/or" placement.

> +    elif (search(r'\s+;\s*$', line) and
> +	     not search(r'\bfor\b', line)):

"and" placement.

> +    elif (search(r'\b(for|while)\s*\(.*\)\s*;\s*$', line) and
> +	     line.count('(') == line.count(')') and
> +	     # Allow do {} while();
> +	     not search(r'}\s*while', line)):

"and" placement.

> +    prevlinenum = linenum - 1

s/prevlinenum/previous_line_number/

> +	   prevline = get_previous_non_blank_line(clean_lines, linenum)[0]
> +	   if (not search(r'[;:}{)=]\s*$|\)\s*const\s*$', prevline) and
> +	       prevline.find('#') < 0):

"and" placement.

> +    if (search(r'{.*}\s*;', line) and
> +	   line.count('{') == line.count('}') and
> +	   not search(r'struct|class|enum|\s*=\s*{', line)):

"and" placement.

> +def get_line_width(line):
> +    if isinstance(line, unicode):
> +	   width = 0
> +	   for c in unicodedata.normalize('NFC', line):
> +	       if unicodedata.east_asian_width(c) in ('W', 'F'):
> +		   width += 2
> +	       elif not unicodedata.combining(c):
> +		   width += 1
> +	   return width
> +    else:
> +	   return len(line)

Since the "if" ends with a "return" then is no need for the else (following
standard WebKit code style).


> +def check_style(filename, clean_lines, linenum, file_extension, error):
> +    """Checks rules from the 'C++ style rules' section of cppguide.html.
> +
> +    Most of these rules are hard to test (naming, comment style), but we
> +    do what we can.	In particular we check for 2-space indents, line
lengths,

s/2-space indents/4-space indents/

> +    # One or three blank spaces at the beginning of the line is weird; it's
> +    # hard to reconcile that with 2-space indents.
s/2-space indents/4-space indents/

> +    # Labels should always be indented at least one space.
> +    elif not initial_spaces and line[:2] != '//' and search(r'[^:]:\s*$',
> +							       line):

I would unwrap the "line):" which looks like it was done to meet the 80 column
limit (which WebKit doesn't have).

> +
> +    # Check if the line is a header guard.
> +    is_header_guard = False
> +    if file_extension == 'h':
> +	   cppvar = get_header_guard_cpp_variable(filename)
> +	   if (line.startswith('#ifndef %s' % cppvar) or
> +	       line.startswith('#define %s' % cppvar) or
> +	       line.startswith('#endif	// %s' % cppvar)):
> +	       is_header_guard = True

is_header_guard is unused now so you can remove this bit of code.

> +
> +    if (cleansed_line.count(';') > 1 and
> +	   # for loops are allowed two ;'s (and may run over two lines).
> +	   cleansed_line.find('for') == -1 and
> +	   (get_previous_non_blank_line(clean_lines, linenum)[0].find('for') ==
-1 or
> +	    get_previous_non_blank_line(clean_lines, linenum)[0].find(';') !=
-1) and
> +	   # It's ok to have many commands in a switch case that fits in 1 line

> +	   not ((cleansed_line.find('case ') != -1 or
> +		 cleansed_line.find('default:') != -1) and
> +		cleansed_line.find('break;') != -1)):

"and/or" placement.


> +    for suffix in ('test.cc', 'regtest.cc', 'unittest.cc',
> +		      'inl.h', 'impl.h', 'internal.h'):
> +	   if (filename.endswith(suffix) and len(filename) > len(suffix) and
> +	       filename[-len(suffix) - 1] in ('-', '_')):
> +	       return filename[:-len(suffix) - 1]

"and" placement.

> +    if (filename.endswith('_test.cc') or
> +	   filename.endswith('_unittest.cc') or
> +	   filename.endswith('_regtest.cc')):

"or" placement.

> +	   return True
> +    else:
> +	   return False

Remove "else" since the if has a return.

> +    if is_system:
> +	   if is_cpp_h:
> +	       return _CPP_SYS_HEADER
> +	   else:
> +	       return _C_SYS_HEADER

Remove "else" since the if has a return.

> +
> +    if target_base == include_base and (
> +	   include_dir == target_dir or
> +	   include_dir == os.path.normpath(target_dir + '/../public')):

"and/or" placement.

> +    if (target_first_component and include_first_component and
> +	   target_first_component.group(0) ==
> +	   include_first_component.group(0)):

"and" placement.

Also, having to do
"a ==
 b"
is just ugly so I'd unwrap this part of it.

> +    if linenum + 1 < clean_lines.num_lines():
> +	   extended_line = line + clean_lines.elided[linenum + 1]
> +    else:
> +	   extended_line = line

extended_line is unused.

> +    # Make Windows paths like Unix.
> +    fullname = os.path.abspath(filename).replace('\\', '/')

fullname is unused.


> +def use_webkit_styles():
> +    global _DEFAULT_FILTERS
> +    _DEFAULT_FILTERS = [
> +	   '-whitespace/end_of_line',
> +	   '-whitespace/comments',

I don't think the whitespace/comments is correct for WebKit right now.	WebKit
style uses 1 space before end of line comments (unliks Google style which does
2 spaces), so I'd just remove this one until we fix it.



> +def main():
> +    use_webkit_styles()

As I've looked through this code, I really want it to get landed but I'm
concerned there are issues with respect to WebKit style that will have to be
fixed after it is landed when multiple people can contribute and we can do
incremental changes to improve it.  Given that it is a tool and not part of
this shipping code, I think that it is ok to handle in this fashion.

However, it would be nice to let people know about the potential alpha state of
the warnings (due to the adaption to WebKit style).

In short for now, it would be nice to print a warning banner here that this
tool is still under development and may flag things incorrectly.  After it is
landed and people have an opportunity to try it out we can remove the warning
banner.

Something like this:

WARNING WARNING WARNING
This tool is in the process of development and may give inaccurate results at
present.
Please files bugs (and/or patches) for things that you notice that it flags
incorrectly.
WARNING WARNING WARNING

From bugzilla-daemon at webkit.org  Mon Jul 13 22:52:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 22:52:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32649] Add --websocket flag in
 build-webkit and ENABLE_WEBSOCKET define.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090714055241.C43FE33102B1@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has canceled  review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32649: Add --websocket flag in build-webkit and ENABLE_WEBSOCKET
define.
https://bugs.webkit.org/attachment.cgi?id=32649&action=review

From bugzilla-daemon at webkit.org  Mon Jul 13 22:52:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 22:52:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32695] Add "Web Sockets" feature
 configuration.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090714055245.A8AE933102C0@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32695: Add "Web Sockets" feature configuration.
https://bugs.webkit.org/attachment.cgi?id=32695&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 15 files changed, 121 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 13 23:50:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 13 Jul 2009 23:50:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27246] Add
 HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL()
 functions : [Attachment 32697] Patch to add in
 HTMLMediaElement::supportsSave() and HitTestResult::absoluteMediaURL()
In-Reply-To: <bug-27246-0@https.bugs.webkit.org/>
References: <bug-27246-0@https.bugs.webkit.org/>
Message-ID: <20090714065047.C184F331149B@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27246: Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Attachment 32697: Patch to add in HTMLMediaElement::supportsSave() and
HitTestResult::absoluteMediaURL()
https://bugs.webkit.org/attachment.cgi?id=32697&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
See description.

From bugzilla-daemon at webkit.org  Tue Jul 14 00:08:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 00:08:22 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32695] Add "Web Sockets" feature
 configuration.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090714070822.5D69B3311A3B@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has canceled Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32695: Add "Web Sockets" feature configuration.
https://bugs.webkit.org/attachment.cgi?id=32695&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 00:08:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 00:08:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32698] Add "Web Sockets" feature
 configuration.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090714070826.2CF0D3311A49@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32698: Add "Web Sockets" feature configuration.
https://bugs.webkit.org/attachment.cgi?id=32698&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 15 files changed, 121 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 00:17:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 00:17:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27246] Add
 HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL()
 functions : [Attachment 32697] Patch to add in
 HTMLMediaElement::supportsSave() and HitTestResult::absoluteMediaURL()
In-Reply-To: <bug-27246-0@https.bugs.webkit.org/>
References: <bug-27246-0@https.bugs.webkit.org/>
Message-ID: <20090714071751.43B3F3311D70@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has canceled Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27246: Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Attachment 32697: Patch to add in HTMLMediaElement::supportsSave() and
HitTestResult::absoluteMediaURL()
https://bugs.webkit.org/attachment.cgi?id=32697&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 00:18:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 00:18:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27246] Add
 HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL()
 functions : [Attachment 32699] Patch to add in
 HTMLMediaElement::supportsSave() and HitTestResult::absoluteMediaURL()
In-Reply-To: <bug-27246-0@https.bugs.webkit.org/>
References: <bug-27246-0@https.bugs.webkit.org/>
Message-ID: <20090714071853.CE5FB3311DD1@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27246: Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Attachment 32699: Patch to add in HTMLMediaElement::supportsSave() and
HitTestResult::absoluteMediaURL()
https://bugs.webkit.org/attachment.cgi?id=32699&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
removed some useless includes + forward declares from the last patch.

From bugzilla-daemon at webkit.org  Tue Jul 14 01:51:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 01:51:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22249] CSS Multicolumn text
 is split awkwardly : [Attachment 32700] Patch v5
In-Reply-To: <bug-22249-0@https.bugs.webkit.org/>
References: <bug-22249-0@https.bugs.webkit.org/>
Message-ID: <20090714085113.72B4C33139A7@gamma.macosforge.org>

Yuta Kitamura <yutak at chromium.org> has asked  for review:
Bug 22249: CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

Attachment 32700: Patch v5
https://bugs.webkit.org/attachment.cgi?id=32700&action=review

------- Additional Comments from Yuta Kitamura <yutak at chromium.org>
I take over this bug from Shinichiro. Please review this patch.

This patch adds code that checks if a multi-column element has the enough
height that can hold the text inside.

From bugzilla-daemon at webkit.org  Tue Jul 14 02:30:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 02:30:47 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32660] first cpplint
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714093047.78EB63314711@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32660: first cpplint
https://bugs.webkit.org/attachment.cgi?id=32660&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 02:30:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 02:30:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32701] first cpplint v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714093053.CCEA93314730@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32701: first cpplint v2
https://bugs.webkit.org/attachment.cgi?id=32701&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 5799 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 02:35:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 02:35:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27248] Change JSCell
 superclass to NoncopyableCustomAllocated : [Attachment 32702] proposed
 patch
In-Reply-To: <bug-27248-0@https.bugs.webkit.org/>
References: <bug-27248-0@https.bugs.webkit.org/>
Message-ID: <20090714093526.4AF4E33148B7@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27248: Change JSCell superclass to NoncopyableCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27248

Attachment 32702: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32702&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 02:41:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 02:41:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32701] first cpplint v2
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714094155.F40213314B2A@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32701: first cpplint v2
https://bugs.webkit.org/attachment.cgi?id=32701&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 02:42:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 02:42:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32703] first cpplint v3
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714094202.A5A993314B52@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32703: first cpplint v3
https://bugs.webkit.org/attachment.cgi?id=32703&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 5788 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 02:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 02:46:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27249] Change
 ParserArenaRefCounted's superclass to RefCountedCustomAllocated :
 [Attachment 32704] proposed patch
In-Reply-To: <bug-27249-0@https.bugs.webkit.org/>
References: <bug-27249-0@https.bugs.webkit.org/>
Message-ID: <20090714094607.4859B3314C86@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27249: Change ParserArenaRefCounted's superclass to
RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249

Attachment 32704: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32704&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 03:16:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 03:16:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27209] Add WebSocket.idl :
 [Attachment 32653] Add WebSocket.idl
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090714101649.111CB33154FC@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has canceled Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 32653: Add WebSocket.idl
https://bugs.webkit.org/attachment.cgi?id=32653&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 03:16:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 03:16:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27209] Add WebSocket.idl :
 [Attachment 32705] add WebSocket.idl and its implementation and bindings
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090714101652.BE82D331550D@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 32705: add WebSocket.idl and its implementation and bindings
https://bugs.webkit.org/attachment.cgi?id=32705&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 7 files changed, 603 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 04:29:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 04:29:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27253] Allow custom memory
 allocation control for JavaScriptCore's Profiler class : [Attachment 32707]
 proposed patch
In-Reply-To: <bug-27253-0@https.bugs.webkit.org/>
References: <bug-27253-0@https.bugs.webkit.org/>
Message-ID: <20090714112901.40E1A33169C9@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27253: Allow custom memory allocation control for JavaScriptCore's Profiler
class
https://bugs.webkit.org/show_bug.cgi?id=27253

Attachment 32707: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32707&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 04:41:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 04:41:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27244] [Gtk] en_GB
 translation : [Attachment 32691] en_GB
In-Reply-To: <bug-27244-0@https.bugs.webkit.org/>
References: <bug-27244-0@https.bugs.webkit.org/>
Message-ID: <20090714114134.21F913316D53@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted  review:
Bug 27244: [Gtk] en_GB translation
https://bugs.webkit.org/show_bug.cgi?id=27244

Attachment 32691: en_GB
https://bugs.webkit.org/attachment.cgi?id=32691&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
rs=me.

From bugzilla-daemon at webkit.org  Tue Jul 14 05:28:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 05:28:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26968] [QT] Add API to reload
 without using cache : [Attachment 32258] Implementation
In-Reply-To: <bug-26968-0@https.bugs.webkit.org/>
References: <bug-26968-0@https.bugs.webkit.org/>
Message-ID: <20090714122807.5D1263317E79@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Benjamin Meyer <ben at meyerhome.net>'s
request for review:
Bug 26968: [QT] Add API to reload without using cache
https://bugs.webkit.org/show_bug.cgi?id=26968

Attachment 32258: Implementation
https://bugs.webkit.org/attachment.cgi?id=32258&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
The patch looks good.  It would be nice to have a auto test for this, but I'll
leave that to you. r=me.

From bugzilla-daemon at webkit.org  Tue Jul 14 05:33:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 05:33:29 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26934] [Qt] It would be useful
 to have methods for scrolling QWebElement : [Attachment 32197] Proposed
 patch, for adding scrolling to QWebElement
In-Reply-To: <bug-26934-0@https.bugs.webkit.org/>
References: <bug-26934-0@https.bugs.webkit.org/>
Message-ID: <20090714123329.35D2C3318082@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Joseph Ligman <joseph.ligman at nokia.com>'s
request for review:
Bug 26934: [Qt] It would be useful to have methods for scrolling QWebElement
https://bugs.webkit.org/show_bug.cgi?id=26934

Attachment 32197: Proposed patch, for adding scrolling to QWebElement
https://bugs.webkit.org/attachment.cgi?id=32197&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
And how would a client use this exactly?  I'm not convinced that it is
necessary.  At Torch we have a client that uses QtWebKit that has automatic
panning on a touch screen.  We didn't need this API to accomplish it.

More than happy to have this if a real use-case can be demonstrated.  r- to get
it out of review queue until such use case is understood and because of the
concerns with scrollByPixel API from other comments.

From bugzilla-daemon at webkit.org  Tue Jul 14 05:49:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 05:49:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27257] [Qt] DumpRenderTree
 no longer builds with Qt4.4 : [Attachment 32708] Proposed fix.
In-Reply-To: <bug-27257-0@https.bugs.webkit.org/>
References: <bug-27257-0@https.bugs.webkit.org/>
Message-ID: <20090714124901.B749133185CD@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27257: [Qt] DumpRenderTree no longer builds with Qt4.4
https://bugs.webkit.org/show_bug.cgi?id=27257

Attachment 32708: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32708&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 05:52:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 05:52:29 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26778] Inspector: Duplicate
 Computation in Autocompletion : [Attachment 32316] Removed Duplicate
 Computation (patch from root)
In-Reply-To: <bug-26778-0@https.bugs.webkit.org/>
References: <bug-26778-0@https.bugs.webkit.org/>
Message-ID: <20090714125229.ACDBC3318721@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 26778: Inspector: Duplicate Computation in Autocompletion
https://bugs.webkit.org/show_bug.cgi?id=26778

Attachment 32316: Removed Duplicate Computation (patch from root)
https://bugs.webkit.org/attachment.cgi?id=32316&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 06:03:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 06:03:43 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27257] [Qt] DumpRenderTree no
 longer builds with Qt4.4 : [Attachment 32708] Proposed fix.
In-Reply-To: <bug-27257-0@https.bugs.webkit.org/>
References: <bug-27257-0@https.bugs.webkit.org/>
Message-ID: <20090714130343.D6A5B3318ADA@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27257: [Qt] DumpRenderTree no longer builds with Qt4.4
https://bugs.webkit.org/show_bug.cgi?id=27257

Attachment 32708: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32708&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. thanks :)

From bugzilla-daemon at webkit.org  Tue Jul 14 06:41:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 06:41:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22700] ApplicationCache
 should have size limit : [Attachment 32709] New proposal to limit the
 maximum size of the application cache (take 8)
In-Reply-To: <bug-22700-0@https.bugs.webkit.org/>
References: <bug-22700-0@https.bugs.webkit.org/>
Message-ID: <20090714134118.E42883319AA3@gamma.macosforge.org>

Andrei Popescu <andreip at google.com> has asked  for review:
Bug 22700: ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Attachment 32709: New proposal to limit the maximum size of the application
cache (take 8)
https://bugs.webkit.org/attachment.cgi?id=32709&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 06:44:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 06:44:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27260] Allow custom memory
 allocation control for JavaScriptCore's IdentifierTable class : [Attachment
 32710] proposed patch
In-Reply-To: <bug-27260-0@https.bugs.webkit.org/>
References: <bug-27260-0@https.bugs.webkit.org/>
Message-ID: <20090714134445.2B6F53319C2D@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27260: Allow custom memory allocation control for JavaScriptCore's
IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260

Attachment 32710: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32710&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 07:06:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 07:06:46 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27158] Add WebKit version API
 to Qt. : [Attachment 32612] Updated patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090714140646.3456E331A676@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied robert
<robert at roberthogan.net>'s request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32612: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32612&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r- on the patch for now, I think with little effort this can be even better and
simpler, without the need to modify the build system :)

On the Qt side please prefix the functions with 'q', i.e. qWebKitVersion().

From bugzilla-daemon at webkit.org  Tue Jul 14 07:15:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 07:15:45 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27210] [Qt] Add an API to get
 a list of installed plugins : [Attachment 32656] patch
In-Reply-To: <bug-27210-0@https.bugs.webkit.org/>
References: <bug-27210-0@https.bugs.webkit.org/>
Message-ID: <20090714141545.732A5331AA79@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 27210: [Qt] Add an API to get a list of installed plugins
https://bugs.webkit.org/show_bug.cgi?id=27210

Attachment 32656: patch
https://bugs.webkit.org/attachment.cgi?id=32656&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
We talked this over in #qtwebkit and believe this is a great addition to the
API.  However, there might be confusion with two different functions that
appear to do the same thing: plugins() and installedPlugins().	With this in
mind, how about a method such as 'QList<QWebPluginFactory::Plugin>
QWebPage::plugins(enum);' where the enum would differentiate between system
plugins that are picked up by scanning netscape plugin directories and those
plugins that are installed via QWebPluginFactory.

With this change, perhaps QWebPluginFactory::Plugin should have it's own class
such as QWebPlugin.  I'm not sure.

Eventually, it'd be nice to add API to set/get the preferred plugin for a
particular mimetype and also to query/set the directories searched for system
plugins.  Some ideas for how to do that are here:

http://code.staikos.net/cgi-bin/gitweb.cgi?p=webkit;a=shortlog;h=adam/netscape-
plugin-manager

Cheers,
Adam

From bugzilla-daemon at webkit.org  Tue Jul 14 07:16:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 07:16:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 32310] patch 0.2 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090714141655.334C9331AAEE@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 32310: patch 0.2 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=32310&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing from the review queue as per comment from IRC:
<tonikitoo> manyoso, tronical i am finishing originalURl patch ... adding a
better test (as suggested by fawek) and better docs, as per simon's suggestion
...

From bugzilla-daemon at webkit.org  Tue Jul 14 07:51:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 07:51:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27030] [WINCE] random number
 generator is too slow : [Attachment 32386] updated patch
In-Reply-To: <bug-27030-0@https.bugs.webkit.org/>
References: <bug-27030-0@https.bugs.webkit.org/>
Message-ID: <20090714145139.A34A1331B9F7@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Joe Mason <joe.mason at torchmobile.com>'s
request for review:
Bug 27030: [WINCE] random number generator is too slow
https://bugs.webkit.org/show_bug.cgi?id=27030

Attachment 32386: updated patch
https://bugs.webkit.org/attachment.cgi?id=32386&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
License from given urls is BSD.  The copy that goes in should have updated url
and contact info.  Otherwise looks good.

From bugzilla-daemon at webkit.org  Tue Jul 14 07:53:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 07:53:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32703] first cpplint v3
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714145303.188DA331BABC@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32703: first cpplint v3
https://bugs.webkit.org/attachment.cgi?id=32703&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Here's a few last changes.  I'm willing to do them while landing the patch, but
if you put up a new one that fixes them, that would also be nice.


> diff --git a/WebKitTools/Scripts/cpplint.py b/WebKitTools/Scripts/cpplint.py
> +# ********************* WARNING WARNING WARNING *********************
> +#
> +# This tool is in the process of development and may give inaccurate
> +# results at resent.  Please files bugs (and/or patches) for things
> +# that you notice that it flags incorrectly.

I actually meant this as something that the tool printed out to warn anyone who
tried it out.

> +#
> +# Also, please note that the style of this Python script may be
> +# inconsistent with other Python scripts in WebKit.
> +#

I don't think this is necessary.  I've tried to be very careful with the style
in this patch and you've done a lot of changes to make it conform.

> +	   self.filters = _DEFAULT_FILTERS[:]
> +	   for filt in filters.split(','):

s/filt/filter/

> +	       clean_filt = filt.strip()

s/clean_filt/clean_filter/

> +	   trigger = base_trigger * 2**_verbose_level()

Add spaces around **


> +_RE_PATTERN_IVALID_INCREMENT = re.compile(

s/IVLIAD/INVALID/

> +    fncall = line	# if there's no control flow construct, look at whole
line

s/fncall/function_call/

> +	       if search(r'(;|})', start_line):  # Declarations and trivial
functions
> +		   body_found = True
> +		   break			      # ... ignore
> +	       elif search(r'{', start_line):

This should be an "if"	(This is in the same spirit as when the previous if
ends with a return.)

> +	   prevbrace = previous_line.rfind('{')

s/prevbrace/previous_brace/

> +def update_include_state(filename, include_state, io=codecs):
...
> +    headerfile = None

header_file

From bugzilla-daemon at webkit.org  Tue Jul 14 08:01:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:01:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32688]
 Cross Platform Fix + Refactoring
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090714150109.A33FD331BE78@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32688: Cross Platform Fix + Refactoring
https://bugs.webkit.org/attachment.cgi?id=32688&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   * inspector/InspectorController.cpp: Moved resizing logic from
InspectorClient to here

That should be "WebInspectorClient.mm", not "InspectorClient".

> +    virtual long getInspectedWebViewHeight() = 0;

We normally only prefix function names with "get" if they return their result
through an out-parameter. Since that is not the case here, I'd just call this
"inspectedWebViewHeight()". Since WebCore doesn't really know what a "WebView"
is, I'd also rename it to "inspectedPageHeight()". But this function doesn't
return the height of the inspected page. It returns the height the page would
be if the Inspector weren't docked. We should either rename the function to
indicate that, or make it truly return the inspected page's height and make
InspectorController responsible for adding in the docked Inspector's height.
The latter option seems conceptually simpler to me.

> @@ -188,6 +191,12 @@ InspectorController::InspectorController
>      ASSERT_ARG(page, page);
>      ASSERT_ARG(client, client);
>      ++s_inspectorControllerCount;
> +
> +    // Set the initial attached height to the users preferred attached
height
> +    // It might not start out attached, but this variable needs to be
populated before
> +    // it could be attached

Typo: "users" should be "user's". You should also end your sentences with
periods.

> +    long attachedHeight = round(max(static_cast<float>(250.0), 
> +	   static_cast<float>(min(static_cast<float>(height), 
> +	   static_cast<float>(m_client->getInspectedWebViewHeight() * .75)))));


You should put the constants into named variables. I think that would reduce
the need for casting, too:

static const minimumAttachedHeight = 250;
static const maximumAttachedHeightRatio = 0.75;

setAttachedWindowHeight(height)
{
    long attachedHeight = round(max(minimumAttachedHeight,
min(static_cast<float>(height), maximumAttachedHeightRatio *
inspectedPageHeight())));
}

Why is defaultAttachedHeight unsigned when we're using long elsewhere?

> +    // Save a preference for the users preferred attached height
> +    Setting heightSetting;
> +    heightSetting.set(attachedHeight);
> +    setSetting(inspectorAttachedHeightName, heightSetting);

It would probably be better to add an explicit Setting constructor that takes a
long.

> +++ WebKit/gtk/WebCoreSupport/InspectorClientGtk.cpp	(working copy)
> @@ -112,6 +112,17 @@ String InspectorClient::hiddenPanels()
>      notImplemented();
>      return String();
>  }
> +    
> +long getInspectedWebViewHeight()
> +{
> +    notImplemented();
> +    return 0;
> +}
> +    
> +void setInitialAttachedHeight(long height)
> +{
> +    notImplemented();
> +}

These function names need to be prefixed with "InspectorClient::". (Ditto for
the other platforms, though the prefix will be different for each.)

> @@ -69,6 +72,7 @@ public:
>  private:
>      void updateWindowTitle() const;
>  
> +    long m_initialAttachedHeight;

It looks like this member doesn't get initialized by the constructor.

> +- (long)getInspectedWebViewHeight
> +{
> +    ASSERT(_attachedToInspectedWebView);
> +    
> +    // For calculations, we want the height of the frame view and the height
of the attached inspector
> +    // to calculate the correct bounds

This comment doesn't really make sense to me as written. But if we either
rename the function or change its behavior as described above, you probably
won't need a comment at all.

> @@ -332,7 +363,7 @@ void WebInspectorClient::updateWindowTit
>  
>	   _attachedToInspectedWebView = YES;
>  
> -	   [self setAttachedWindowHeight:[[NSUserDefaults standardUserDefaults]
integerForKey:WebKitInspectorAttachedViewHeightKey]];
> +	   [self setAttachedWindowHeight:_attachedHeight];

I think you can get rid of the definition of
WebKitInspectorAttachedViewHeightKey now.

Should we migrate the old NSUserDefaults-style preference to the new
InspectorController::Setting-style preference?

> @@ -381,23 +412,21 @@ void WebInspectorClient::updateWindowTit
>  
>  - (void)setAttachedWindowHeight:(unsigned)height
>  {
> -    [[NSUserDefaults standardUserDefaults] setInteger:height
forKey:WebKitInspectorAttachedViewHeightKey];
> -
>      if (!_attachedToInspectedWebView)
>	   return;
> -
> -    WebFrameView *frameView = [[_inspectedWebView mainFrame] frameView];
> -    NSRect frameViewRect = [frameView frame];
> -
> -    CGFloat attachedHeight = round(MAX(250.0, MIN(height,
(NSHeight([_inspectedWebView frame]) * 0.75))));
> -
> +    
> +    _attachedHeight = height;

Why do we need to store this value? Can't we just calculate it by querying the
bounds of the Inspector window?

> @@ -76,6 +74,7 @@ WebInspectorClient::WebInspectorClient(W
>      , m_webViewHwnd(0)
>      , m_shouldAttachWhenShown(false)
>      , m_attached(false)
> +    , m_attachedHeight(0)

You're leaving m_attachedParentHeight uninitialized here.

>  void WebInspectorClient::setAttachedWindowHeight(unsigned height)
>  {
> -    // FIXME: implement this.
> +    RECT inspectedRect;
> +    GetClientRect(m_inspectedWebViewHwnd, &inspectedRect);
> +
> +    int webViewX = inspectedRect.left;
> +    int webViewY = m_attachedParentHeight - height;
> +    int webViewWidth = inspectedRect.right - inspectedRect.left;
> +    int webViewHeight = height;
> +
> +    m_attachedHeight = height;

Why do we need to store this value? Can't we just calculate it by querying the
client rect of the Inspector window?

> +    SendMessage(m_inspectedWebViewHwnd, WM_SETREDRAW, FALSE, NULL);
> +    SendMessage(m_webViewHwnd, WM_SETREDRAW, FALSE, NULL);

We use 0 instead of NULL in C++ files. (This comment applies elsewhere in this
patch.)

Should we be doing this WM_SETREDRAW stuff in onWebViewWindowPosChanging, too?

> +    ::SetWindowPos(m_inspectedWebViewHwnd, 0, webViewX, inspectedRect.top,
webViewWidth, m_attachedParentHeight, SWP_NOZORDER);
> +    ::SetWindowPos(m_webViewHwnd, 0, webViewX, webViewY, webViewWidth,
webViewHeight, SWP_NOZORDER);

You should remove the "::" prefixes here, or add them to the other Win32 API
calls in this function (whatever is consistent with the rest of the file). In
general, in new code you should leave them off.

> @@ -410,12 +440,16 @@ void WebInspectorClient::onWebViewWindow
>      WINDOWPOS* windowPos = reinterpret_cast<WINDOWPOS*>(lParam);
>      ASSERT_ARG(lParam, windowPos);
>  
> +    // Cache this value because GetClientRect doesn't give the correct
parent height
> +    // And whenever the height updates and an inspector is attached, this
function will be called first.
> +    m_attachedParentHeight = windowPos->cy;

Why do we need to store this value? Can't we calculate it by getting the client
rects of the inspected WebView and the Inspector, and adding their heights?

From bugzilla-daemon at webkit.org  Tue Jul 14 08:04:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:04:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32703] first cpplint v3
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714150454.04017331C009@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32703: first cpplint v3
https://bugs.webkit.org/attachment.cgi?id=32703&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 08:05:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:05:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32711] first cpplint v4
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714150500.D92C5331C02E@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32711: first cpplint v4
https://bugs.webkit.org/attachment.cgi?id=32711&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 5788 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 08:09:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:09:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27076] [WINCE] Move date
 related symbols to DateExtras.h : [Attachment 32712] DateExtras
In-Reply-To: <bug-27076-0@https.bugs.webkit.org/>
References: <bug-27076-0@https.bugs.webkit.org/>
Message-ID: <20090714150945.E0A0F331C24E@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked Eric Seidel <eric at webkit.org>
for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32712: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32712&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
Okay. I removed the code from the public without license. Instead, I copied the
implementation of WinCE time functions from wxWidgets-2.8.10 and modified them
accordingly. wxWidgets is licensed under wxWindows Licence which is essentially
LGPL, so I think there is no license problem here now.

http://www.wxwidgets.org/about/newlicen.htm


I also run the new lint tool and fixed some style errors. I am still not
accustomed to the WebKit coding convention, there might be more errors.

cpplint.py DateExtras.*
Done processing DateExtras.cpp
Done processing DateExtras.h
Total errors found: 0

From bugzilla-daemon at webkit.org  Tue Jul 14 08:14:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:14:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27262] Chromium: HTML
 exported isn't marked as being UTF-8 : [Attachment 32713] Patch to mark
 clipboard HTML as UTF-8
In-Reply-To: <bug-27262-0@https.bugs.webkit.org/>
References: <bug-27262-0@https.bugs.webkit.org/>
Message-ID: <20090714151452.C7510331C4C1@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked  for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32713: Patch to mark clipboard HTML as UTF-8
https://bugs.webkit.org/attachment.cgi?id=32713&action=review

------- Additional Comments from Avi Drissman <avi at drissman.com>
This is corresponding to http://codereview.chromium.org/149414

From bugzilla-daemon at webkit.org  Tue Jul 14 08:17:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:17:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25884] WebKit needs a style
 linting tool : [Attachment 32711] first cpplint v4
In-Reply-To: <bug-25884-0@https.bugs.webkit.org/>
References: <bug-25884-0@https.bugs.webkit.org/>
Message-ID: <20090714151726.378C3331C5DB@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 25884: WebKit needs a style linting tool
https://bugs.webkit.org/show_bug.cgi?id=25884

Attachment 32711: first cpplint v4
https://bugs.webkit.org/attachment.cgi?id=32711&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 08:52:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:52:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32715] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090714155235.DE0B8331D4BE@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32715: patch
https://bugs.webkit.org/attachment.cgi?id=32715&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 08:59:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:59:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26983] tst_qwebpage segfaults
 : [Attachment 32281] patch
In-Reply-To: <bug-26983-0@https.bugs.webkit.org/>
References: <bug-26983-0@https.bugs.webkit.org/>
Message-ID: <20090714155914.F3869331D7E8@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied robert <robert at roberthogan.net>'s request
for review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32281: patch
https://bugs.webkit.org/attachment.cgi?id=32281&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Larger issues at work.

From bugzilla-daemon at webkit.org  Tue Jul 14 08:59:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 08:59:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27264] [v8] Speed up access
 to NodeList length : [Attachment 32716] Initial version
In-Reply-To: <bug-27264-0@https.bugs.webkit.org/>
References: <bug-27264-0@https.bugs.webkit.org/>
Message-ID: <20090714155936.564FB331D821@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27264: [v8] Speed up access to NodeList length
https://bugs.webkit.org/show_bug.cgi?id=27264

Attachment 32716: Initial version
https://bugs.webkit.org/attachment.cgi?id=32716&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:01:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:01:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32715] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090714160147.9E89C331D934@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32715: patch
https://bugs.webkit.org/attachment.cgi?id=32715&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	     if (lastActivePanelSetting.type() == Setting::StringType) {
> +		 m_showAfterVisible =
specialPanelForJSName(lastActivePanelSetting.string());
> +	     }

No need for the curly braces.

From bugzilla-daemon at webkit.org  Tue Jul 14 09:07:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:07:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26999] bugzilla-tool/svn-apply
 can't handle patches made from a non-root directory : [Attachment 32491]
 This would make it so svn-create-patch provides full paths from the WebKit
 root directory.
In-Reply-To: <bug-26999-0@https.bugs.webkit.org/>
References: <bug-26999-0@https.bugs.webkit.org/>
Message-ID: <20090714160759.08FC7331DBE0@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 26999: bugzilla-tool/svn-apply can't handle patches made from a non-root
directory
https://bugs.webkit.org/show_bug.cgi?id=26999

Attachment 32491: This would make it so svn-create-patch provides full paths
from the WebKit root directory.
https://bugs.webkit.org/attachment.cgi?id=32491&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +use webkitdirs;

It's unfortunate that we need to use the webkitdirs module since this script
could be used on any SVN working directory previously.	(Darin Adler may have
more input on this.)

> +sub chdirWebKitAndGetPrefix;

This needs empty parenthesis after the declaration (an empty prototype) to
match the style of the rest of the source.

> +    my $file = $prefix . $fileData->{path};

This should use File::Spec->catdir($prefix, $fileData->{path}) instead.  Then
you don't have to worry about the trailing '/' in chdirWebKitAndGetPrefix().

> +# Change to WebKit dir and get the difference from the current dir

This comment isn't really needed; the method name explains what it does
already.

> +sub chdirWebKitAndGetPrefix

Needs parenthesis after the method to match the style of the rest of the
source.

> +{
> +    my $before = File::Spec->rel2abs( File::Spec->curdir() );
> +    chdirWebKit();
> +    my $after = File::Spec->rel2abs( File::Spec->curdir() );
> +    $before =~ s/^$after\/?//;

I think it would be clearer to use File::Spec::abs2rel() instead of rolling
your own regex here:

my $relativePath = File::Spec->abs2rel($after, $before);

> +    return $before if $before eq '';    # Already at WebKit dir
> +    $before .= '/' if $before !~ /\/$/; # Prefix needs a trailing '/'
> +    return $before;
> +}

With the change to use File::Spec::catdir() above, and because
File::Spec::abs2rel() will either return a relative path or an empty string,
this logic goes away:

    return $relativePath;

In fact, you should just remove the $relativePath variable and return the
result directly:

    return File::Spec->abs2rel($after, $before);

r- to fix everything except the 'use webkitdirs' issue.

IMO, it would be great to have a replacement subroutine for chdirwebkit() that
got the svn URL from the "svn info" command in the current directory, then did
a "chdir .." until the current svn URL no longer matched the previous svn URL
(minus one directory), then you could chdir back into the last directory.  This
would then put you at the root of the svn working directory regardless of
whether you're working on WebKit or not.

From bugzilla-daemon at webkit.org  Tue Jul 14 09:14:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:14:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26983] tst_qwebpage
 segfaults : [Attachment 32717] Fix the QSize/IntSize mismatch
In-Reply-To: <bug-26983-0@https.bugs.webkit.org/>
References: <bug-26983-0@https.bugs.webkit.org/>
Message-ID: <20090714161447.12BAF331DE98@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32717: Fix the QSize/IntSize mismatch
https://bugs.webkit.org/attachment.cgi?id=32717&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:21:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:21:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27064] Turn off non-portable
 date manipulations for SYMBIAN (as well) : [Attachment 32425] Proposed fix.
In-Reply-To: <bug-27064-0@https.bugs.webkit.org/>
References: <bug-27064-0@https.bugs.webkit.org/>
Message-ID: <20090714162156.91C1C331E1AB@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27064: Turn off non-portable date manipulations for SYMBIAN (as well)
https://bugs.webkit.org/show_bug.cgi?id=27064

Attachment 32425: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32425&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Nice.  r=me

From bugzilla-daemon at webkit.org  Tue Jul 14 09:22:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:22:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27264] [v8] Speed up access
 to NodeList length : [Attachment 32716] Initial version
In-Reply-To: <bug-27264-0@https.bugs.webkit.org/>
References: <bug-27264-0@https.bugs.webkit.org/>
Message-ID: <20090714162218.C5F55331E204@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 27264: [v8] Speed up access to NodeList length
https://bugs.webkit.org/show_bug.cgi?id=27264

Attachment 32716: Initial version
https://bugs.webkit.org/attachment.cgi?id=32716&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:25:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:25:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32625] rev 2
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090714162531.7C0F8331E3FC@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32625: rev 2
https://bugs.webkit.org/attachment.cgi?id=32625&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Yes, this may be landed.  Technically, the lander should use Darin Adler's r+,
not mine.   I'm just confirming the ChangeLog update. :)

From bugzilla-daemon at webkit.org  Tue Jul 14 09:30:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:30:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27248] Change JSCell's
 superclass to NoncopyableCustomAllocated : [Attachment 32702] proposed
 patch
In-Reply-To: <bug-27248-0@https.bugs.webkit.org/>
References: <bug-27248-0@https.bugs.webkit.org/>
Message-ID: <20090714163054.3891E331E6CC@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27248: Change JSCell's superclass to NoncopyableCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27248

Attachment 32702: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32702&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:31:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:31:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27249] Change
 ParserArenaRefCounted's superclass to RefCountedCustomAllocated :
 [Attachment 32704] proposed patch
In-Reply-To: <bug-27249-0@https.bugs.webkit.org/>
References: <bug-27249-0@https.bugs.webkit.org/>
Message-ID: <20090714163120.BF2CB331E715@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27249: Change ParserArenaRefCounted's superclass to
RefCountedCustomAllocated
https://bugs.webkit.org/show_bug.cgi?id=27249

Attachment 32704: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32704&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:32:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:32:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27253] Allow custom memory
 allocation control for JavaScriptCore's Profiler class : [Attachment 32707]
 proposed patch
In-Reply-To: <bug-27253-0@https.bugs.webkit.org/>
References: <bug-27253-0@https.bugs.webkit.org/>
Message-ID: <20090714163213.A9297331E78C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27253: Allow custom memory allocation control for JavaScriptCore's Profiler
class
https://bugs.webkit.org/show_bug.cgi?id=27253

Attachment 32707: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32707&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:33:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:33:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27260] Allow custom memory
 allocation control for JavaScriptCore's IdentifierTable class : [Attachment
 32710] proposed patch
In-Reply-To: <bug-27260-0@https.bugs.webkit.org/>
References: <bug-27260-0@https.bugs.webkit.org/>
Message-ID: <20090714163355.1CCB4331E85A@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27260: Allow custom memory allocation control for JavaScriptCore's
IdentifierTable class
https://bugs.webkit.org/show_bug.cgi?id=27260

Attachment 32710: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32710&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:38:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:38:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27262] Chromium: HTML
 exported isn't marked as being UTF-8 : [Attachment 32713] Patch to mark
 clipboard HTML as UTF-8
In-Reply-To: <bug-27262-0@https.bugs.webkit.org/>
References: <bug-27262-0@https.bugs.webkit.org/>
Message-ID: <20090714163826.462BA331EACE@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Avi Drissman
<avi at drissman.com>'s request for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32713: Patch to mark clipboard HTML as UTF-8
https://bugs.webkit.org/attachment.cgi?id=32713&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +2009-07-14  Avi Drissman  <avi at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Explicitly mark the HTML generated for the Mac as being UTF-8
encoded.
> +	   The Windows clipboard format is explicitly documented as being
UTF-8,
> +	   and all Linux apps assume UTF-8. On the Mac, though, unless
otherwise
> +	   indicated, ISO/IEC 8859-1 is assumed, which is wrong.

nit: Your ChangeLog should include a link to this bug.

Otherwise, R=me

From bugzilla-daemon at webkit.org  Tue Jul 14 09:39:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:39:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32625] rev 2
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090714163905.1C4D0331EB4D@gamma.macosforge.org>

Darin Adler <darin at apple.com> has canceled  review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32625: rev 2
https://bugs.webkit.org/attachment.cgi?id=32625&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
I'll set the review flag again just for clarity.

From bugzilla-daemon at webkit.org  Tue Jul 14 09:39:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:39:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32625] rev 2
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090714163912.7DB80331EB7B@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted  review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32625: rev 2
https://bugs.webkit.org/attachment.cgi?id=32625&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 09:39:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:39:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26983] tst_qwebpage segfaults
 : [Attachment 32717] Fix the QSize/IntSize mismatch
In-Reply-To: <bug-26983-0@https.bugs.webkit.org/>
References: <bug-26983-0@https.bugs.webkit.org/>
Message-ID: <20090714163945.CA7F4331EBDF@gamma.macosforge.org>

Zack Rusin <zack at kde.org> has granted Adam Treat <treat at kde.org>'s request for
review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32717: Fix the QSize/IntSize mismatch
https://bugs.webkit.org/attachment.cgi?id=32717&action=review

------- Additional Comments from Zack Rusin <zack at kde.org>
Personally I'd prefer this in IntSizeQt.cpp but the issue is that it's
impossible to detect whether it's QSize() or QSize(-1, -1). We'd like to
convert the first one to QSize(0, 0) but not the latter (because it will mess
up conversions after doing any kind of subtraction of IntSizes). So I think
this will do for now.

From bugzilla-daemon at webkit.org  Tue Jul 14 09:41:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 09:41:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27262] Chromium: HTML
 exported isn't marked as being UTF-8 : [Attachment 32718] Links to the bug
 now; no other changes
In-Reply-To: <bug-27262-0@https.bugs.webkit.org/>
References: <bug-27262-0@https.bugs.webkit.org/>
Message-ID: <20090714164128.B8B0C331ECBA@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32718: Links to the bug now; no other changes
https://bugs.webkit.org/attachment.cgi?id=32718&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 10:20:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 10:20:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25998] Build failure:
 conflicting declaration 'typedef XID Cursor' : [Attachment 32719] Revised
 patch with ChangeLog
In-Reply-To: <bug-25998-0@https.bugs.webkit.org/>
References: <bug-25998-0@https.bugs.webkit.org/>
Message-ID: <20090714172046.3F120331FEB2@gamma.macosforge.org>

David Evans <devans at macports.org> has asked  for review:
Bug 25998: Build failure: conflicting declaration 'typedef XID Cursor'
https://bugs.webkit.org/show_bug.cgi?id=25998

Attachment 32719: Revised patch with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32719&action=review

------- Additional Comments from David Evans <devans at macports.org>
Dave here, actually.  I'm one of the MacPorts maintainers for port webkit-gtk.

Attached is a revised patch with ChangeLog as requested.

From bugzilla-daemon at webkit.org  Tue Jul 14 10:30:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 10:30:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27177] After
 double-clicking a word,
 using Shift-arrow to select behaves unpredictably : [Attachment 32720] patch
In-Reply-To: <bug-27177-0@https.bugs.webkit.org/>
References: <bug-27177-0@https.bugs.webkit.org/>
Message-ID: <20090714173032.9DF193320294@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27177: After double-clicking a word, using Shift-arrow to select behaves
unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177

Attachment 32720: patch
https://bugs.webkit.org/attachment.cgi?id=32720&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 10:41:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 10:41:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26983] tst_qwebpage
 segfaults : [Attachment 32721] Fixes the more general problem
In-Reply-To: <bug-26983-0@https.bugs.webkit.org/>
References: <bug-26983-0@https.bugs.webkit.org/>
Message-ID: <20090714174122.A7B43332066F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32721: Fixes the more general problem
https://bugs.webkit.org/attachment.cgi?id=32721&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I made a check in the new FrameView::visibleContentsResized method to ensure
the view is attached before layouting.	I think this is a better place for it
so we can still keep the ASSERT in layout() which proved to be valuable.

From bugzilla-daemon at webkit.org  Tue Jul 14 10:47:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 10:47:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26983] tst_qwebpage segfaults
 : [Attachment 32721] Fixes the more general problem
In-Reply-To: <bug-26983-0@https.bugs.webkit.org/>
References: <bug-26983-0@https.bugs.webkit.org/>
Message-ID: <20090714174710.D3C25332087B@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 26983: tst_qwebpage segfaults
https://bugs.webkit.org/show_bug.cgi?id=26983

Attachment 32721: Fixes the more general problem
https://bugs.webkit.org/attachment.cgi?id=32721&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Just make it a null check instead rather than checking for inequality with
this.

r=me with that change.

From bugzilla-daemon at webkit.org  Tue Jul 14 10:48:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 10:48:44 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27262] Chromium: HTML exported
 isn't marked as being UTF-8 : [Attachment 32718] Links to the bug now;
 no other changes
In-Reply-To: <bug-27262-0@https.bugs.webkit.org/>
References: <bug-27262-0@https.bugs.webkit.org/>
Message-ID: <20090714174844.B28413320955@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Avi Drissman
<avi at drissman.com>'s request for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32718: Links to the bug now; no other changes
https://bugs.webkit.org/attachment.cgi?id=32718&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
r- for revised changelog per feedback from jshin.  i'll commit the next patch.
-darin

From bugzilla-daemon at webkit.org  Tue Jul 14 10:50:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 10:50:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27104] [V8]
 evaluateInNewContext should send a notification that a context was created
 : [Attachment 32598] new notification
In-Reply-To: <bug-27104-0@https.bugs.webkit.org/>
References: <bug-27104-0@https.bugs.webkit.org/>
Message-ID: <20090714175024.C7FA533209FA@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Matt Perry
<mpComplete at gmail.com>'s request for review:
Bug 27104: [V8] evaluateInNewContext should send a notification that a context
was created
https://bugs.webkit.org/show_bug.cgi?id=27104

Attachment 32598: new notification
https://bugs.webkit.org/attachment.cgi?id=32598&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:19:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:19:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25425] DOM attribute
 getter/setter functions should use const AtomicString& type : [Attachment
 32722] patch that does this for eight classes
In-Reply-To: <bug-25425-0@https.bugs.webkit.org/>
References: <bug-25425-0@https.bugs.webkit.org/>
Message-ID: <20090714181937.EACF7332135E@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 25425: DOM attribute getter/setter functions should use const AtomicString&
type
https://bugs.webkit.org/show_bug.cgi?id=25425

Attachment 32722: patch that does this for eight classes
https://bugs.webkit.org/attachment.cgi?id=32722&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:27:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:27:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27268] [V8] Fix isolated
 world crash on getting window.location : [Attachment 32723] patch
In-Reply-To: <bug-27268-0@https.bugs.webkit.org/>
References: <bug-27268-0@https.bugs.webkit.org/>
Message-ID: <20090714182714.97A683321623@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27268: [V8] Fix isolated world crash on getting window.location
https://bugs.webkit.org/show_bug.cgi?id=27268

Attachment 32723: patch
https://bugs.webkit.org/attachment.cgi?id=32723&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:33:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:33:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27262] Chromium: HTML
 exported isn't marked as being UTF-8 : [Attachment 32724] New version;
 addresses jshin's comments
In-Reply-To: <bug-27262-0@https.bugs.webkit.org/>
References: <bug-27262-0@https.bugs.webkit.org/>
Message-ID: <20090714183352.6C7253321810@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32724: New version; addresses jshin's comments
https://bugs.webkit.org/attachment.cgi?id=32724&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:41:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:41:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27266] Add
 hasCurrentPoint() to WebCore::Path : [Attachment 32725] Proposed patch
In-Reply-To: <bug-27266-0@https.bugs.webkit.org/>
References: <bug-27266-0@https.bugs.webkit.org/>
Message-ID: <20090714184144.F3B173321AA4@gamma.macosforge.org>

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 27266: Add hasCurrentPoint() to WebCore::Path
https://bugs.webkit.org/show_bug.cgi?id=27266

Attachment 32725: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32725&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:51:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:51:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27266] Add hasCurrentPoint()
 to WebCore::Path : [Attachment 32725] Proposed patch
In-Reply-To: <bug-27266-0@https.bugs.webkit.org/>
References: <bug-27266-0@https.bugs.webkit.org/>
Message-ID: <20090714185132.16E613321DF0@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Dmitry Titov <dimich at chromium.org>'s
request for review:
Bug 27266: Add hasCurrentPoint() to WebCore::Path
https://bugs.webkit.org/show_bug.cgi?id=27266

Attachment 32725: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32725&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:52:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:52:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27246] Add
 HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL()
 functions : [Attachment 32699] Patch to add in
 HTMLMediaElement::supportsSave() and HitTestResult::absoluteMediaURL()
In-Reply-To: <bug-27246-0@https.bugs.webkit.org/>
References: <bug-27246-0@https.bugs.webkit.org/>
Message-ID: <20090714185255.0F9413321ECC@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27246: Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Attachment 32699: Patch to add in HTMLMediaElement::supportsSave() and
HitTestResult::absoluteMediaURL()
https://bugs.webkit.org/attachment.cgi?id=32699&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:53:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:53:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27154] useless null-check
 statement in visible_units.cpp@logicalStartOfLine : [Attachment 32693]
 simple fix: statement removed
In-Reply-To: <bug-27154-0@https.bugs.webkit.org/>
References: <bug-27154-0@https.bugs.webkit.org/>
Message-ID: <20090714185328.75B313321F23@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27154: useless null-check statement in visible_units.cpp at logicalStartOfLine
https://bugs.webkit.org/show_bug.cgi?id=27154

Attachment 32693: simple fix: statement removed
https://bugs.webkit.org/attachment.cgi?id=32693&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:54:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:54:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27170] [V8] drawImage method
 of HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment
 32679] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090714185432.AF8553321FAC@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has canceled Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27170: [V8] drawImage method of HTMLCanvasElement to accept
HTMLVideoElement as argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32679: patch
https://bugs.webkit.org/attachment.cgi?id=32679&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 11:55:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 11:55:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27170] [V8] drawImage
 method of HTMLCanvasElement to accept HTMLVideoElement as argument :
 [Attachment 32726] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090714185504.0BA433321FFD@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27170: [V8] drawImage method of HTMLCanvasElement to accept
HTMLVideoElement as argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32726: patch
https://bugs.webkit.org/attachment.cgi?id=32726&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 12:06:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:06:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27236] Memory is not released
 back to the system from TCMalloc on Windows : [Attachment 32677] This patch
 implements TCMalloc_SystemRelease() on windows and adds a new mechanism to
 release memory back to the system via a background thread.
In-Reply-To: <bug-27236-0@https.bugs.webkit.org/>
References: <bug-27236-0@https.bugs.webkit.org/>
Message-ID: <20090714190654.08E6A33223F9@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 27236: Memory is not released back to the system from TCMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=27236

Attachment 32677: This patch implements TCMalloc_SystemRelease() on windows and
adds a new mechanism to release memory back to the system via a background
thread.
https://bugs.webkit.org/attachment.cgi?id=32677&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This patch has a lot of uses of reinterpret_cast in cases where static_cast can
be used. To convert from void* to a specific type, static_cast works and is
preferred.

> +#if PLATFORM(WIN)
> +  static void* runScavengerThread(void*);
> +
> +  void scavengerThread();
> +#else
> +  static NO_RETURN void* runScavengerThread(void*);
> +
> +  NO_RETURN void scavengerThread();
> +#endif

Can we just use the return 0 all the time and avoid the conditional code here
and in the definition of the function? Or does GCC give us a warning about
NO_RETURN if we don't specify it?

> +#if TCMALLOC_TRACK_DECOMMITED_SPANS
> +  inline bool shouldContinueScavenging() const { return
free_committed_pages_ > kMinimumFreeCommittedPageCount; }
> +#else
> +  inline bool shouldContinueScavenging() const { return true; }
> +#endif

I'd prefer to have the function declaration be outside an ifdef, and have the
implementation be ifdef'd.

Also, the "inline" here is not needed. If you define a function inside a class
definition then it's automatically treated as if "inline" was specified.

> +void TCMalloc_PageHeap::scavenge() {

Since this is new code, you could follow the normal WebKit style of putting the
brace on a new line.

> +#if PLATFORM(WIN)
> +	 ::Sleep(kScavengeTimerDelayInSeconds * 1000);
> +#else
> +	 sleep(kScavengeTimerDelayInSeconds);
> +#endif

Can we make a helper function for this so we don't have to have the #if right
in the middle of the code's logic? Maybe even define a sleep function for
Windows, or if not, just define a function that has the call to either sleep or
Sleep in it.

> +    void* end = (char*)start + length;

This should be static_cast, not a C-style cast.

> +	   size_t resultSize = VirtualQuery(ptr, &info, sizeof(info));
> +	   UNUSED_PARAM(resultSize);
> +	   ASSERT(resultSize == sizeof(info));

You should use ASSERT_UNUSED here, not UNUSED_PARAM. For one thing, this is not
a parameter!

> +	   BOOL success = VirtualFree(ptr, length < info.RegionSize ? length :
info.RegionSize, MEM_DECOMMIT);
> +	   UNUSED_PARAM(success);
> +	   ASSERT(success);

Ditto.

> +    void* end = (char*)start + length;

Ditto.

> +	   size_t resultSize = VirtualQuery(ptr, &info, sizeof(info));
> +	   UNUSED_PARAM(resultSize);
> +	   ASSERT(resultSize == sizeof(info));

Ditto.

> +	   UNUSED_PARAM(newAddress);
> +	   ASSERT(newAddress == ptr);

Ditto.

r=me

From bugzilla-daemon at webkit.org  Tue Jul 14 12:33:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:33:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24187] RTL: tooltip does not
 get its directionality from its element's directionality : [Attachment
 32727] updated patch for landing
In-Reply-To: <bug-24187-0@https.bugs.webkit.org/>
References: <bug-24187-0@https.bugs.webkit.org/>
Message-ID: <20090714193323.8D3EC3322D63@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted  review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 32727: updated patch for landing
https://bugs.webkit.org/attachment.cgi?id=32727&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 12:34:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:34:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27271] [V8] Fix isolated
 world wrappers for Nodes : [Attachment 32728] patch
In-Reply-To: <bug-27271-0@https.bugs.webkit.org/>
References: <bug-27271-0@https.bugs.webkit.org/>
Message-ID: <20090714193415.AB3FC3322DC1@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27271: [V8] Fix isolated world wrappers for Nodes
https://bugs.webkit.org/show_bug.cgi?id=27271

Attachment 32728: patch
https://bugs.webkit.org/attachment.cgi?id=32728&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
By the way, you can see the test suite I'm working from here:

http://codereview.chromium.org/149193

Once I get these tests in reasonable shape, I can turn on the feature and land
the tests.

From bugzilla-daemon at webkit.org  Tue Jul 14 12:37:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:37:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27271] [V8] Fix isolated
 world wrappers for Nodes : [Attachment 32728] patch
In-Reply-To: <bug-27271-0@https.bugs.webkit.org/>
References: <bug-27271-0@https.bugs.webkit.org/>
Message-ID: <20090714193710.E352B3322EAF@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27271: [V8] Fix isolated world wrappers for Nodes
https://bugs.webkit.org/show_bug.cgi?id=27271

Attachment 32728: patch
https://bugs.webkit.org/attachment.cgi?id=32728&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Fix _and_ prettify. I like it.

From bugzilla-daemon at webkit.org  Tue Jul 14 12:40:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:40:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27170] [V8] drawImage method
 of HTMLCanvasElement to accept HTMLVideoElement as argument : [Attachment
 32726] patch
In-Reply-To: <bug-27170-0@https.bugs.webkit.org/>
References: <bug-27170-0@https.bugs.webkit.org/>
Message-ID: <20090714194051.19B843323075@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27170: [V8] drawImage method of HTMLCanvasElement to accept
HTMLVideoElement as argument
https://bugs.webkit.org/show_bug.cgi?id=27170

Attachment 32726: patch
https://bugs.webkit.org/attachment.cgi?id=32726&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Good to go.

From bugzilla-daemon at webkit.org  Tue Jul 14 12:40:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:40:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27076] [WINCE] Move date
 related symbols to DateExtras.h : [Attachment 32712] DateExtras
In-Reply-To: <bug-27076-0@https.bugs.webkit.org/>
References: <bug-27076-0@https.bugs.webkit.org/>
Message-ID: <20090714194057.6681A332308B@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 27076: [WINCE] Move date related symbols to DateExtras.h
https://bugs.webkit.org/show_bug.cgi?id=27076

Attachment 32712: DateExtras
https://bugs.webkit.org/attachment.cgi?id=32712&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
This patch directly conflicts with the WinCE port that is in the process of
being merged right now.  I don't think we need two conflicting ports - it's
counterproductive.  If you would like to merge patches from our existing port
you can find them online at http://code.staikos.net/.  Otherwise I'd ask you to
be patient and allow that work to continue instead of creating conflicts.

From bugzilla-daemon at webkit.org  Tue Jul 14 12:44:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 12:44:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26599] CSSHelper.h's
 parseURL is a function that no one should ever call : [Attachment 32729]
 patch for part 1
In-Reply-To: <bug-26599-0@https.bugs.webkit.org/>
References: <bug-26599-0@https.bugs.webkit.org/>
Message-ID: <20090714194412.A0D8233231C2@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 26599: CSSHelper.h's parseURL is a function that no one should ever call
https://bugs.webkit.org/show_bug.cgi?id=26599

Attachment 32729: patch for part 1
https://bugs.webkit.org/attachment.cgi?id=32729&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 13:22:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 13:22:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27270] The WebFormDelegate
 -(BOOL)textField:shouldHandleEvent:inFrame is never called : [Attachment
 32731] removes the unused delegate method
In-Reply-To: <bug-27270-0@https.bugs.webkit.org/>
References: <bug-27270-0@https.bugs.webkit.org/>
Message-ID: <20090714202224.8FBD23323E4D@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27270: The WebFormDelegate -(BOOL)textField:shouldHandleEvent:inFrame is
never called
https://bugs.webkit.org/show_bug.cgi?id=27270

Attachment 32731: removes the unused delegate method
https://bugs.webkit.org/attachment.cgi?id=32731&action=review

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
This delegate is implemented in Safari, but not called anywhere.

From bugzilla-daemon at webkit.org  Tue Jul 14 13:40:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 13:40:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32625] rev 2
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090714204058.8370733243FD@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has denied	review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32625: rev 2
https://bugs.webkit.org/attachment.cgi?id=32625&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 13:47:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 13:47:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32733] For Qt,
 suppress NP Plugin stderr output that is out of our control
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090714204700.238D53324673@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32733: For Qt, suppress NP Plugin stderr output that is out of our
control
https://bugs.webkit.org/attachment.cgi?id=32733&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 14:17:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:17:48 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 23642] [GTK] Drag and drop
 support : [Attachment 32375] Third patch
In-Reply-To: <bug-23642-0@https.bugs.webkit.org/>
References: <bug-23642-0@https.bugs.webkit.org/>
Message-ID: <20090714211748.7D59A3325170@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has denied Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 32375: Third patch
https://bugs.webkit.org/attachment.cgi?id=32375&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +//	 gtk_target_list_unref(targetList);
>  }

I don't like adding commented code. It seems to me like we need to keep track
of both targetList and context, to make sure they go away when the drag
operation ends. Should they be added to the private struct?

> +namespace WebCore {
> +    class IntPoint;
> +}

Maybe make this class WebCore::IntPoint; to avoid using more lines than
necessary? =)

>  namespace WebKit {
> +

I think there are some unecesary empty line additions in the patch. Some, like
the one bellow are OK, but I think the others should be removed:

>      public:
> +	   DragClient(WebKitWebView*);
> +

> +	   private:
> +	       WebKitWebView* m_webView;
> +
> +	       WebCore::IntPoint m_startPos;

Like this one.

> +static void webkit_web_view_drag_end(GtkWidget* widget, GdkDragContext*
context)
> +{
> +    DragClipboard::clipboard()->resetClipboard();
> +}

This is where we want to free context and targetList, I believe.

> +    fprintf(stderr, "webkit_web_view_drag_data_get %d\n", info);

Debugging that should go away?

The rest looks fine. I think if you modify the code to not leak targetList and
context we should be good to go with this one =). r- for now.

From bugzilla-daemon at webkit.org  Tue Jul 14 14:20:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:20:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27270] The WebFormDelegate
 -(BOOL)textField:shouldHandleEvent:inFrame is never called : [Attachment
 32731] removes the unused delegate method
In-Reply-To: <bug-27270-0@https.bugs.webkit.org/>
References: <bug-27270-0@https.bugs.webkit.org/>
Message-ID: <20090714212010.DD3CA3325267@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has canceled Greg Bolsinga
<bolsinga at apple.com>'s request for review:
Bug 27270: The WebFormDelegate -(BOOL)textField:shouldHandleEvent:inFrame is
never called
https://bugs.webkit.org/show_bug.cgi?id=27270

Attachment 32731: removes the unused delegate method
https://bugs.webkit.org/attachment.cgi?id=32731&action=review

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
I do not see it called at all via grep for shouldHandleEvent in all of WebKit
(after this new patch! ;)

From bugzilla-daemon at webkit.org  Tue Jul 14 14:20:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:20:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27270] The WebFormDelegate
 -(BOOL)textField:shouldHandleEvent:inFrame is never called : [Attachment
 32734] Remove the uncalled declaration for windows as well.
In-Reply-To: <bug-27270-0@https.bugs.webkit.org/>
References: <bug-27270-0@https.bugs.webkit.org/>
Message-ID: <20090714212010.EB0673325269@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27270: The WebFormDelegate -(BOOL)textField:shouldHandleEvent:inFrame is
never called
https://bugs.webkit.org/show_bug.cgi?id=27270

Attachment 32734: Remove the uncalled declaration for windows as well.
https://bugs.webkit.org/attachment.cgi?id=32734&action=review

------- Additional Comments from Greg Bolsinga <bolsinga at apple.com>
I do not see it called at all via grep for shouldHandleEvent in all of WebKit
(after this new patch! ;)

From bugzilla-daemon at webkit.org  Tue Jul 14 14:20:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:20:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 23642] [GTK] Drag and drop
 support : [Attachment 32135] Second patch
In-Reply-To: <bug-23642-0@https.bugs.webkit.org/>
References: <bug-23642-0@https.bugs.webkit.org/>
Message-ID: <20090714212038.CDC8D33252B1@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 32135: Second patch
https://bugs.webkit.org/attachment.cgi?id=32135&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
This one seems to be fine, but I'd like to commit both at the same time,
indeed.

From bugzilla-daemon at webkit.org  Tue Jul 14 14:26:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:26:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32733] For Qt,
 suppress NP Plugin stderr output that is out of our control
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090714212648.09DB933254FE@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has canceled
Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>'s request for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32733: For Qt, suppress NP Plugin stderr output that is out of our
control
https://bugs.webkit.org/attachment.cgi?id=32733&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 14:26:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:26:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32735] For Linux,
 suppress NP Plugin stderr output that is out of our control
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090714212648.17ED73325500@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32735: For Linux, suppress NP Plugin stderr output that is out of
our control
https://bugs.webkit.org/attachment.cgi?id=32735&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 14:31:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:31:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27268] [V8] Fix isolated
 world crash on getting window.location : [Attachment 32723] patch
In-Reply-To: <bug-27268-0@https.bugs.webkit.org/>
References: <bug-27268-0@https.bugs.webkit.org/>
Message-ID: <20090714213134.271803325682@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27268: [V8] Fix isolated world crash on getting window.location
https://bugs.webkit.org/show_bug.cgi?id=27268

Attachment 32723: patch
https://bugs.webkit.org/attachment.cgi?id=32723&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Tue Jul 14 14:34:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:34:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32652] addressed eric's
 feedback and added a manual test
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090714213428.CB3EB332577A@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32652: addressed eric's feedback and added a manual test
https://bugs.webkit.org/attachment.cgi?id=32652&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Looks good to me, after the changes. While you're at it, you could also have
enter also open the combo box, to match what GTK+ does. Should be a matter of
adding || keyCode == 'r' to the if inside SPACE_POP_MENU. Make it
SPACE_AND_RETURN_POP_MENU =P.

From bugzilla-daemon at webkit.org  Tue Jul 14 14:43:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:43:44 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32651] patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090714214344.BD0793325A8C@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has denied Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32651: patch
https://bugs.webkit.org/attachment.cgi?id=32651&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +    const gchar* uri = webkit_web_history_item_get_uri(item);
> +    if (g_strcmp0(g_uri_parse_scheme(uri), "file") == 0) {

You are leaking the return of g_uri_parse_scheme here.

> +	   static gchar* layoutTestString = g_strdup("/LayoutTests/");
> +	   static gchar* fileTestString = g_strdup("(file test):");

These are also leaked. There should be no need to g_strdup here. Just use the
static strings instead?

> +	   result = g_string_append(result, pos + strlen(layoutTestString));

I'd suggest using sizeof("/LayoutTests/") instead of strlen.

From bugzilla-daemon at webkit.org  Tue Jul 14 14:46:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:46:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27273] [V8] Implement
 Reflect and ReflectURL attribute support : [Attachment 32736] Implement
 Reflect attribute support, v1.
In-Reply-To: <bug-27273-0@https.bugs.webkit.org/>
References: <bug-27273-0@https.bugs.webkit.org/>
Message-ID: <20090714214600.7CC4D3325B41@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 27273: [V8] Implement Reflect and ReflectURL attribute support
https://bugs.webkit.org/show_bug.cgi?id=27273

Attachment 32736: Implement Reflect attribute support, v1.
https://bugs.webkit.org/attachment.cgi?id=32736&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 WebCore/ChangeLog			     |	  9 ++++
 WebCore/bindings/scripts/CodeGeneratorV8.pm |	 62 +++++++++++++++++----------
 2 files changed, 48 insertions(+), 23 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 14:53:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:53:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 32737] More Portable Patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090714215325.0F0523325E30@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked  for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32737: More Portable Patch
https://bugs.webkit.org/attachment.cgi?id=32737&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Is this more like it?

From bugzilla-daemon at webkit.org  Tue Jul 14 14:55:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:55:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 32737] More Portable Patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090714215504.4053F3325EC4@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked Simon Hausmann <hausmann at webkit.org>
for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32737: More Portable Patch
https://bugs.webkit.org/attachment.cgi?id=32737&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 14:58:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 14:58:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27273] [V8] Implement Reflect
 and ReflectURL attribute support : [Attachment 32736] Implement Reflect
 attribute support, v1.
In-Reply-To: <bug-27273-0@https.bugs.webkit.org/>
References: <bug-27273-0@https.bugs.webkit.org/>
Message-ID: <20090714215807.CD8473325FAA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 27273: [V8] Implement Reflect and ReflectURL attribute support
https://bugs.webkit.org/show_bug.cgi?id=27273

Attachment 32736: Implement Reflect attribute support, v1.
https://bugs.webkit.org/attachment.cgi?id=32736&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Will help from Dimitri, I now understand this patch.  I for one welcome our new
getAttribute overlords.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:03:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:03:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32484]
 resubmission
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090714220323.3D21F3326179@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32484: resubmission
https://bugs.webkit.org/attachment.cgi?id=32484&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

I think the intent of the old comments (that something needs fixing) is lost:
    // FIXME: This should ASSERT(node->parentNode())
 582	 ASSERT(node);
 583	 // FIXME: adding ASSERT(node->parentNode()); results in
editing/deleting/delete-ligature-001.html crashing
569584

No need to be const:
 595 VisiblePosition visiblePositionBeforeNode(const Node* node)

Generally we don't make RefCounted objects const, ever.  Because well...
they're refcounted. :)	You can't ref them w/ them being const.

I probably would have named the argument "range" and the returned value
"extendRange" but this is fine too:
 632 PassRefPtr<Range> extendRangeToWrappingNodes(PassRefPtr<Range>
rangeToExtend, const Range* maximumRange, const Node* rootNode)

Thanks.!

From bugzilla-daemon at webkit.org  Tue Jul 14 15:09:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:09:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26816] Selection changed by
 indent : [Attachment 32487] change due to the resubmission for 27038
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090714220924.E9BA23326322@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 32487: change due to the resubmission for 27038
https://bugs.webkit.org/attachment.cgi?id=32487&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Should have a bug:
+    // FIXME: we need to deal with the case where there is no li (malformed
HTML)
+    if (!selectedListItem->hasTagName(liTag))
+	 return false;


024 \ No newline at end of file

Needs an arg name for the Node*:
 59	void indentIntoBlockquote(const VisiblePosition&, const
VisiblePosition&, RefPtr<Element>&, Node*);

Looks fine otherwise.  Thanks!

From bugzilla-daemon at webkit.org  Tue Jul 14 15:09:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:09:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25425] DOM attribute
 getter/setter functions should use const AtomicString& type : [Attachment
 32722] patch that does this for eight classes
In-Reply-To: <bug-25425-0@https.bugs.webkit.org/>
References: <bug-25425-0@https.bugs.webkit.org/>
Message-ID: <20090714220925.3A9ED3326327@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Darin Adler
<darin at apple.com>'s request for review:
Bug 25425: DOM attribute getter/setter functions should use const AtomicString&
type
https://bugs.webkit.org/show_bug.cgi?id=25425

Attachment 32722: patch that does this for eight classes
https://bugs.webkit.org/attachment.cgi?id=32722&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
LGTM :)

From bugzilla-daemon at webkit.org  Tue Jul 14 15:14:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:14:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27275] Chromium popup menus
 can crash when the selected index is -1 : [Attachment 32738] Fix for
 crashing with invalid index.
In-Reply-To: <bug-27275-0@https.bugs.webkit.org/>
References: <bug-27275-0@https.bugs.webkit.org/>
Message-ID: <20090714221415.66D6433264C8@gamma.macosforge.org>

Paul Godavari <paul at chromium.org> has asked  for review:
Bug 27275: Chromium popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 32738: Fix for crashing with invalid index.
https://bugs.webkit.org/attachment.cgi?id=32738&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 15:26:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:26:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27276] Some constructor
 objects exposed on Window have the wrong prototype chain : [Attachment
 32739] patch
In-Reply-To: <bug-27276-0@https.bugs.webkit.org/>
References: <bug-27276-0@https.bugs.webkit.org/>
Message-ID: <20090714222646.D9987332689E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27276: Some constructor objects exposed on Window have the wrong prototype
chain
https://bugs.webkit.org/show_bug.cgi?id=27276

Attachment 32739: patch
https://bugs.webkit.org/attachment.cgi?id=32739&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 15:34:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:34:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27225] Change all Noncopyable
 inheriting to publicly inheriting : [Attachment 32668] proposed patch
In-Reply-To: <bug-27225-0@https.bugs.webkit.org/>
References: <bug-27225-0@https.bugs.webkit.org/>
Message-ID: <20090714223420.10D973326B37@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27225: Change all Noncopyable inheriting to publicly inheriting
https://bugs.webkit.org/show_bug.cgi?id=27225

Attachment 32668: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32668&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -struct OpaqueJSClassContextData : Noncopyable {
> +struct OpaqueJSClassContextData : public Noncopyable {

struct inheritance is already public, so this change is not needed. There are
tons of other cases like this. Please don't make those changes since they
aren't needed. Otherwise this seems fine. review- because I'd like to see the
patch without the unneeded changes.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:45:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:45:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25151] workers with syntax
 errors not firing error event : [Attachment 32493] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090714224509.4C5D93326E8E@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 25151: workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32493: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32493&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to address/clarify.  Thanks.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2009-07-08  Jian Li	<jianli at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Bug 25151 - workers with syntax errors not firing error event.
> +	   https://bugs.webkit.org/show_bug.cgi?id=25151
> +
> +	   This fixes the problem that an error event is not fired when failed

Consider this wording:

  This fixes the problem that an error event is not fired when the worker
script
  fails to load.  Some reasons this may occur are an invalid URL for the worker

  script, a cross-origin redirect, or a syntax error in the script.


Another problem is this changelog doesn't say much about why things were done. 
When I
first looked at the patch I thought another issue was being fixed but some
items were moved
around.  Function level comments in the changelog would be helpful here.

> diff --git a/WebCore/bindings/js/JSWorkerConstructor.cpp
b/WebCore/bindings/js/JSWorkerConstructor.cpp
> -    ExceptionCode ec = 0;
> -    RefPtr<Worker> worker = Worker::create(scriptURL, window->document(),
ec);
> -    setDOMException(exec, ec);
> +    RefPtr<Worker> worker = Worker::create(scriptURL, window->document());

Why is it ok to stop setting the dom exception?


> diff --git a/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
b/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
> -    ExceptionCode ec = 0;
> -    RefPtr<Worker> obj = Worker::create(toWebCoreString(scriptUrl), context,
ec);
> -
> -    if (ec)
> -	   return throwError(ec);
> +    RefPtr<Worker> obj = Worker::create(toWebCoreString(scriptUrl),
context);

Same question as above (but here it is throwError).

> diff --git a/WebCore/workers/WorkerMessagingProxy.cpp
b/WebCore/workers/WorkerMessagingProxy.cpp

>      virtual void performTask(ScriptExecutionContext* context)
>      {
> -	   if (!m_messagingProxy->askedToTerminate())
> -	       context->reportException(m_errorMessage, m_lineNumber,
m_sourceURL);
> +	   Worker* workerObject = m_messagingProxy->workerObject();
> +	   if (!workerObject || m_messagingProxy->askedToTerminate())
> +	       return;
> +
> +	   context->reportException(m_errorMessage, m_lineNumber, m_sourceURL);

> +	   workerObject->dispatchErrorEvent();

This changes the behavior for more than just the case that you're fixing.  Any
code that calls ScriptExecutionContext->reportException will get this behavior.
 Why is that the correct thing to do?

Also, is there a chromium change corresponding to this?

> diff --git a/WebCore/workers/WorkerMessagingProxy.h
b/WebCore/workers/WorkerMessagingProxy.h
> namespace WebCore {
...
> +	   friend class WorkerExceptionTask;

Why is this being added here?

> diff --git a/WebCore/workers/WorkerScriptLoader.cpp
b/WebCore/workers/WorkerScriptLoader.cpp
> +void WorkerScriptLoader::loadSynchronously(ScriptExecutionContext*
scriptExecutionContext, const String& url, URLCompletionPolicy
urlCompletionPolicy, CrossOriginLoadPolicy crossOriginLoadPolicy)
...
> +    CrossOriginRedirectPolicy crossOriginRedirectPolicy =
(crossOriginLoadPolicy == DenyCrossOriginLoad) ? DenyCrossOriginRedirect :
AllowCrossOriginRedirect;
    
> +void WorkerScriptLoader::loadAsynchronously(ScriptExecutionContext*
scriptExecutionContext, const String& url, URLCompletionPolicy
urlCompletionPolicy, CrossOriginLoadPolicy crossOriginLoadPolicy,
WorkerScriptLoaderClient* client)
...
> +    CrossOriginRedirectPolicy crossOriginRedirectPolicy =
(crossOriginLoadPolicy == DenyCrossOriginLoad) ? DenyCrossOriginRedirect :
AllowCrossOriginRedirect;

It would be nice to only have one place that does the conversion of
CrossOriginLoadPolicy to CrossOriginRedirectPolicy.  Right now there are two in
this file.

> +ResourceRequest*
WorkerScriptLoader::createResourceRequest(ScriptExecutionContext*
scriptExecutionContext, const String& url, URLCompletionPolicy
urlCompletionPolicy, CrossOriginLoadPolicy crossOriginLoadPolicy)

This should return a PassOwnPtr<ResourceRequest>

From bugzilla-daemon at webkit.org  Tue Jul 14 15:45:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:45:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27262] Chromium: HTML
 exported isn't marked as being UTF-8 : [Attachment 32724] New version;
 addresses jshin's comments
In-Reply-To: <bug-27262-0@https.bugs.webkit.org/>
References: <bug-27262-0@https.bugs.webkit.org/>
Message-ID: <20090714224516.8E4443326EB7@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Avi Drissman
<avi at drissman.com>'s request for review:
Bug 27262: Chromium: HTML exported isn't marked as being UTF-8
https://bugs.webkit.org/show_bug.cgi?id=27262

Attachment 32724: New version; addresses jshin's comments
https://bugs.webkit.org/attachment.cgi?id=32724&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 15:48:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:48:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27277] [V8] Fix isolated
 world wrappers for Node prototypes : [Attachment 32740] patch
In-Reply-To: <bug-27277-0@https.bugs.webkit.org/>
References: <bug-27277-0@https.bugs.webkit.org/>
Message-ID: <20090714224859.9EBA13326FB9@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27277: [V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277

Attachment 32740: patch
https://bugs.webkit.org/attachment.cgi?id=32740&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Sorry for the goofy diff format.  I'm working out of an improvised git repo in
my Chromium tree.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:54:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:54:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27277] [V8] Fix isolated
 world wrappers for Node prototypes : [Attachment 32741] patch
In-Reply-To: <bug-27277-0@https.bugs.webkit.org/>
References: <bug-27277-0@https.bugs.webkit.org/>
Message-ID: <20090714225402.D30FA33271A1@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27277: [V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277

Attachment 32741: patch
https://bugs.webkit.org/attachment.cgi?id=32741&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Oops.  The previous version was slightly old.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:54:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:54:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27277] [V8] Fix isolated
 world wrappers for Node prototypes : [Attachment 32740] patch
In-Reply-To: <bug-27277-0@https.bugs.webkit.org/>
References: <bug-27277-0@https.bugs.webkit.org/>
Message-ID: <20090714225402.B78F8332719D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27277: [V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277

Attachment 32740: patch
https://bugs.webkit.org/attachment.cgi?id=32740&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Oops.  The previous version was slightly old.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:55:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:55:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26999]
 bugzilla-tool/svn-apply can't handle patches made from a non-root directory
 : [Attachment 32742] svn-create-patch provides full paths Subversion
 Repository's Root Directory
In-Reply-To: <bug-26999-0@https.bugs.webkit.org/>
References: <bug-26999-0@https.bugs.webkit.org/>
Message-ID: <20090714225527.8AD28332723C@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 26999: bugzilla-tool/svn-apply can't handle patches made from a non-root
directory
https://bugs.webkit.org/show_bug.cgi?id=26999

Attachment 32742: svn-create-patch provides full paths Subversion Repository's
Root Directory
https://bugs.webkit.org/attachment.cgi?id=32742&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Much cleaner!  This addresses the points in David's review.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:55:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:55:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26999]
 bugzilla-tool/svn-apply can't handle patches made from a non-root directory
 : [Attachment 32743] svn-create-patch provides full paths Subversion
 Repository's Root Directory
In-Reply-To: <bug-26999-0@https.bugs.webkit.org/>
References: <bug-26999-0@https.bugs.webkit.org/>
Message-ID: <20090714225528.4EB56332723F@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 26999: bugzilla-tool/svn-apply can't handle patches made from a non-root
directory
https://bugs.webkit.org/show_bug.cgi?id=26999

Attachment 32743: svn-create-patch provides full paths Subversion Repository's
Root Directory
https://bugs.webkit.org/attachment.cgi?id=32743&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Much cleaner!  This addresses the points in David's review.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:56:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:56:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27277] [V8] Fix isolated
 world wrappers for Node prototypes : [Attachment 32741] patch
In-Reply-To: <bug-27277-0@https.bugs.webkit.org/>
References: <bug-27277-0@https.bugs.webkit.org/>
Message-ID: <20090714225626.3C9E633272CB@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27277: [V8] Fix isolated world wrappers for Node prototypes
https://bugs.webkit.org/show_bug.cgi?id=27277

Attachment 32741: patch
https://bugs.webkit.org/attachment.cgi?id=32741&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
sounds good.

From bugzilla-daemon at webkit.org  Tue Jul 14 15:58:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 15:58:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26999]
 bugzilla-tool/svn-apply can't handle patches made from a non-root directory
 : [Attachment 32742] svn-create-patch provides full paths Subversion
 Repository's Root Directory
In-Reply-To: <bug-26999-0@https.bugs.webkit.org/>
References: <bug-26999-0@https.bugs.webkit.org/>
Message-ID: <20090714225839.6EC8733273D4@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 26999: bugzilla-tool/svn-apply can't handle patches made from a non-root
directory
https://bugs.webkit.org/show_bug.cgi?id=26999

Attachment 32742: svn-create-patch provides full paths Subversion Repository's
Root Directory
https://bugs.webkit.org/attachment.cgi?id=32742&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 16:07:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 16:07:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 19562] ValidityState object
 stub : [Attachment 32744] ValidityState and related build stuff
In-Reply-To: <bug-19562-0@https.bugs.webkit.org/>
References: <bug-19562-0@https.bugs.webkit.org/>
Message-ID: <20090714230703.35D5B332775D@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked Adele Peterson
<adele at apple.com> for review:
Bug 19562: ValidityState object stub
https://bugs.webkit.org/show_bug.cgi?id=19562

Attachment 32744: ValidityState and related build stuff
https://bugs.webkit.org/attachment.cgi?id=32744&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 16:08:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 16:08:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27225] Change all
 Noncopyable inheriting to publicly inheriting : [Attachment 32745] updated
 proposed patch
In-Reply-To: <bug-27225-0@https.bugs.webkit.org/>
References: <bug-27225-0@https.bugs.webkit.org/>
Message-ID: <20090714230846.992383327812@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27225: Change all Noncopyable inheriting to publicly inheriting
https://bugs.webkit.org/show_bug.cgi?id=27225

Attachment 32745: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=32745&action=review

------- Additional Comments from Zoltan Horvath <hzoltan at inf.u-szeged.hu>
I've updated the patch and removed the unnecessary struct changes.

From bugzilla-daemon at webkit.org  Tue Jul 14 16:09:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 16:09:59 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32617] patch 1
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090714230959.2E9DD332788A@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has denied	review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32617: patch 1
https://bugs.webkit.org/attachment.cgi?id=32617&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 16:29:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 16:29:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 19562] ValidityState object
 stub : [Attachment 32744] ValidityState and related build stuff
In-Reply-To: <bug-19562-0@https.bugs.webkit.org/>
References: <bug-19562-0@https.bugs.webkit.org/>
Message-ID: <20090714232907.277483327EA3@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 19562: ValidityState object stub
https://bugs.webkit.org/show_bug.cgi?id=19562

Attachment 32744: ValidityState and related build stuff
https://bugs.webkit.org/attachment.cgi?id=32744&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Removing specific reviewer request.

The only thing that needs review here is that adding DOMValidityState.{h,mm}
(which we needed to compile) but not adding to Copy-Generated Headers or adding
DOMValidityStateInternal* is kosher.  Everything else is the same as the patch
on Friday other than a layout test fix.

From bugzilla-daemon at webkit.org  Tue Jul 14 16:45:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 16:45:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27225] Change all Noncopyable
 inheriting to publicly inheriting : [Attachment 32745] updated proposed
 patch
In-Reply-To: <bug-27225-0@https.bugs.webkit.org/>
References: <bug-27225-0@https.bugs.webkit.org/>
Message-ID: <20090714234540.9C5D63328392@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27225: Change all Noncopyable inheriting to publicly inheriting
https://bugs.webkit.org/show_bug.cgi?id=27225

Attachment 32745: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=32745&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 17:06:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:06:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25151] workers with syntax
 errors not firing error event : [Attachment 32747] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090715000620.93F023328A9C@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 25151: workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32747: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32747&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 17:07:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:07:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27281] Fails to save
 document state when navigating away from a page with a reference fragment :
 [Attachment 32748] v1 patch
In-Reply-To: <bug-27281-0@https.bugs.webkit.org/>
References: <bug-27281-0@https.bugs.webkit.org/>
Message-ID: <20090715000709.BA0403328ADC@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has asked  for review:
Bug 27281: Fails to save document state when navigating away from a page with a
reference fragment
https://bugs.webkit.org/show_bug.cgi?id=27281

Attachment 32748: v1 patch
https://bugs.webkit.org/attachment.cgi?id=32748&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Simple patch.  Use equalIgnoringRef to compare the HistoryItem's URL the URL of
a document.

From bugzilla-daemon at webkit.org  Tue Jul 14 17:07:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:07:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25151] workers with syntax
 errors not firing error event : [Attachment 32747] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090715000710.F3A923328AF0@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has canceled Jian Li <jianli at chromium.org>'s
request for review:
Bug 25151: workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32747: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32747&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 17:07:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:07:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25151] workers with syntax
 errors not firing error event : [Attachment 32749] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090715000711.192953328AF4@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 25151: workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32749: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32749&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 17:09:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:09:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27281] Fails to save document
 state when navigating away from a page with a reference fragment :
 [Attachment 32748] v1 patch
In-Reply-To: <bug-27281-0@https.bugs.webkit.org/>
References: <bug-27281-0@https.bugs.webkit.org/>
Message-ID: <20090715000938.D204E3328B8C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Darin Fisher (:fishd, Google)
<fishd at chromium.org>'s request for review:
Bug 27281: Fails to save document state when navigating away from a page with a
reference fragment
https://bugs.webkit.org/show_bug.cgi?id=27281

Attachment 32748: v1 patch
https://bugs.webkit.org/attachment.cgi?id=32748&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> -    return urlString() == doc->url();
> +    return equalIgnoringRef(KURL(urlString()), doc->url());

I would write url() instead of KURL(urlString()).

r=me

From bugzilla-daemon at webkit.org  Tue Jul 14 17:37:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:37:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27282] [V8] Implement the
 corresponding V8 changes to deal with the problem that workers with syntax
 errors not firing error event : [Attachment 32752] Proposed Patch
In-Reply-To: <bug-27282-0@https.bugs.webkit.org/>
References: <bug-27282-0@https.bugs.webkit.org/>
Message-ID: <20090715003742.8DED733293B1@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27282: [V8] Implement the corresponding V8 changes to deal with the problem
that workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=27282

Attachment 32752: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32752&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 17:40:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 17:40:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27283] Implement the 'rem'
 unit type from CSS3 : [Attachment 32755] Patch
In-Reply-To: <bug-27283-0@https.bugs.webkit.org/>
References: <bug-27283-0@https.bugs.webkit.org/>
Message-ID: <20090715004031.7EA7C33294B3@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27283: Implement the 'rem' unit type from CSS3
https://bugs.webkit.org/show_bug.cgi?id=27283

Attachment 32755: Patch
https://bugs.webkit.org/attachment.cgi?id=32755&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 18:03:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 18:03:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27283] Implement the 'rem'
 unit type from CSS3 : [Attachment 32755] Patch
In-Reply-To: <bug-27283-0@https.bugs.webkit.org/>
References: <bug-27283-0@https.bugs.webkit.org/>
Message-ID: <20090715010353.04A1C3329BFB@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 27283: Implement the 'rem' unit type from CSS3
https://bugs.webkit.org/show_bug.cgi?id=27283

Attachment 32755: Patch
https://bugs.webkit.org/attachment.cgi?id=32755&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 18:20:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 18:20:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 19562] ValidityState object
 stub : [Attachment 32744] ValidityState and related build stuff
In-Reply-To: <bug-19562-0@https.bugs.webkit.org/>
References: <bug-19562-0@https.bugs.webkit.org/>
Message-ID: <20090715012002.8865D332A108@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 19562: ValidityState object stub
https://bugs.webkit.org/show_bug.cgi?id=19562

Attachment 32744: ValidityState and related build stuff
https://bugs.webkit.org/attachment.cgi?id=32744&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 18:25:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 18:25:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27055] Qualify include path
 with wtf : [Attachment 32756] Second try.
In-Reply-To: <bug-27055-0@https.bugs.webkit.org/>
References: <bug-27055-0@https.bugs.webkit.org/>
Message-ID: <20090715012531.EA674332A301@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27055: Qualify include path with wtf
https://bugs.webkit.org/show_bug.cgi?id=27055

Attachment 32756: Second try.
https://bugs.webkit.org/attachment.cgi?id=32756&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Updated the patch based on Darin's feedback (filling in for Norbert.)
Note that since this patch reverses a subset of r44418 (presumably a build fix
for WIN_CAIRO), the proposed fix might break WIN_CAIRO port (I CCd Brent on the
bug).

From bugzilla-daemon at webkit.org  Tue Jul 14 18:30:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 18:30:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26999]
 bugzilla-tool/svn-apply can't handle patches made from a non-root directory
 : [Attachment 32743] svn-create-patch provides full paths Subversion
 Repository's Root Directory
In-Reply-To: <bug-26999-0@https.bugs.webkit.org/>
References: <bug-26999-0@https.bugs.webkit.org/>
Message-ID: <20090715013006.DB391332A49D@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 26999: bugzilla-tool/svn-apply can't handle patches made from a non-root
directory
https://bugs.webkit.org/show_bug.cgi?id=26999

Attachment 32743: svn-create-patch provides full paths Subversion Repository's
Root Directory
https://bugs.webkit.org/attachment.cgi?id=32743&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
(In reply to comment #11)
> (In reply to comment #5)
> > IMO, it would be great to have a replacement subroutine for chdirwebkit()
that
> > got the svn URL from the "svn info" command in the current directory, then
did
> > a "chdir .." until the current svn URL no longer matched the previous svn
URL
> > (minus one directory), then you could chdir back into the last directory. 
This
> > would then put you at the root of the svn working directory regardless of
> > whether you're working on WebKit or not.
> 
> The way I went about it was using "svn info [PATH]".	And building up that
path
> as a trail of "../".	I also use system() to check the error code of svn
info. 
> Let me know if there is a problem with this approach (cross platform?) or if
> you think of a better way and I'll see what I can do.

I thought of doing that after my last comment as well!	The only situation
where this won't work is if a user has a "mixed" svn working directory where
they have one svn working directory at "dir" and a second svn working directory
(from a different repository) under "dir", and the user ran svn-create-patch in
the second working directory.  I don't know how prevalent this use case is, and
I doubt it's common with WebKit, so let's not worry about that for now.

>+sub chdirAndGetDifference($);

Nit: Instead of "GetDifference", I think something like "ReturnRelativePath"
might be more descriptive.  I can change this when I land the patch.

r=me!

From bugzilla-daemon at webkit.org  Tue Jul 14 18:32:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 18:32:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27285] [Qt] New window
 created by clicking a link is not visible : [Attachment 32757] Force the
 new window to be visible
In-Reply-To: <bug-27285-0@https.bugs.webkit.org/>
References: <bug-27285-0@https.bugs.webkit.org/>
Message-ID: <20090715013243.1BA92332A56D@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27285: [Qt] New window created by clicking a link is not visible
https://bugs.webkit.org/show_bug.cgi?id=27285

Attachment 32757: Force the new window to be visible
https://bugs.webkit.org/attachment.cgi?id=32757&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
This is similar to calling ChromeClientQt::show(), when opening a new window
from JavaScript.

From bugzilla-daemon at webkit.org  Tue Jul 14 18:48:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 18:48:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27286] Inspector: Keyboard
 Shortcuts to Switch Panels : [Attachment 32758] Keyboard Shortcuts for
 Switching Panels
In-Reply-To: <bug-27286-0@https.bugs.webkit.org/>
References: <bug-27286-0@https.bugs.webkit.org/>
Message-ID: <20090715014801.6D517332AA07@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27286: Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286

Attachment 32758: Keyboard Shortcuts for Switching Panels
https://bugs.webkit.org/attachment.cgi?id=32758&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Some of the more obvious keyboard shortcuts are taken by Safari.  Like ?1, ?2,
etc. are hot links to bookmarks and Safari grabs them.	It also seems to grab
??[ and ??] probably because it thinks an undocked Inspector is a window.

So I resorted to ?] and ?[ for Macs.
I don't actually have a Windows Safari setup but I did ^[ and ^].

Let me know if you can think of other keyboard shortcuts for any features or
better ones for panel manipulation.

From bugzilla-daemon at webkit.org  Tue Jul 14 19:34:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 19:34:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32759] rev 3
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090715023410.027B8332B75C@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32759: rev 3
https://bugs.webkit.org/attachment.cgi?id=32759&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Removed the fancy private destructor stuff.  It's not that important.

From bugzilla-daemon at webkit.org  Tue Jul 14 19:45:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 19:45:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27246] Add
 HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL()
 functions : [Attachment 32760] Undo the added delegation of
 HTMLMediaElement::supportsFullscreen().
In-Reply-To: <bug-27246-0@https.bugs.webkit.org/>
References: <bug-27246-0@https.bugs.webkit.org/>
Message-ID: <20090715024555.59CAC332BAD2@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27246: Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Attachment 32760: Undo the added delegation of
HTMLMediaElement::supportsFullscreen().
https://bugs.webkit.org/attachment.cgi?id=32760&action=review

------- Additional Comments from Albert J. Wong <ajwong at chromium.org>
Per Eric's comment, undoing this part of my earlier patch.

I've verified that the media tests pass this time.

Sorry for the bustage in the last patch.  I thought that the version of the
layout tests in the chromium build were equivalent in coverage.  Learned that I
was completely wrong. :(

From bugzilla-daemon at webkit.org  Tue Jul 14 19:55:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 19:55:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32761]
 Take 3
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090715025516.383F1332BDA8@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32761: Take 3
https://bugs.webkit.org/attachment.cgi?id=32761&action=review

------- Additional Comments from Brian Weinstein <bweinstein at apple.com>
Fixes comments made by aroben about previous patch.

From bugzilla-daemon at webkit.org  Tue Jul 14 19:58:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 19:58:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27287] [V8] Fix isolated
 world constructors : [Attachment 32762] patch
In-Reply-To: <bug-27287-0@https.bugs.webkit.org/>
References: <bug-27287-0@https.bugs.webkit.org/>
Message-ID: <20090715025836.60876332BEC8@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27287: [V8] Fix isolated world constructors
https://bugs.webkit.org/show_bug.cgi?id=27287

Attachment 32762: patch
https://bugs.webkit.org/attachment.cgi?id=32762&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 20:06:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 20:06:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27288] Inspector: Missing
 UIString and other localizedString.js fixes : [Attachment 32763] Localized
 String Fixes
In-Reply-To: <bug-27288-0@https.bugs.webkit.org/>
References: <bug-27288-0@https.bugs.webkit.org/>
Message-ID: <20090715030622.72CA3332C101@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27288: Inspector: Missing UIString and other localizedString.js fixes
https://bugs.webkit.org/show_bug.cgi?id=27288

Attachment 32763: Localized String Fixes
https://bugs.webkit.org/attachment.cgi?id=32763&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Added the missing string and correctly sorted two other keys ("COOKIES" and
"Time").

From bugzilla-daemon at webkit.org  Tue Jul 14 20:30:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 20:30:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27284]
 HTMLMediaElement::supportsFullscreen() should return false : [Attachment
 32764] 2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com>
In-Reply-To: <bug-27284-0@https.bugs.webkit.org/>
References: <bug-27284-0@https.bugs.webkit.org/>
Message-ID: <20090715033020.6060D332C736@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27284: HTMLMediaElement::supportsFullscreen() should return false
https://bugs.webkit.org/show_bug.cgi?id=27284

Attachment 32764: 2009-07-14  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=32764&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>

	Reviewed by NOBODY (OOPS!).

	HTMLMediaElement::supportsFullscreen() should return false
	https://bugs.webkit.org/show_bug.cgi?id=27284

	(Reverting a part of 45875)

	HTMLVideoElement::supportsFullscreen() will properly do the
	job to check if the backend supports fullscreen.

	HTMLVideoElement is the only subclass to support fullscreen
	(conditionnaly). HTMLAudioElement fullscreen is not supported
	and is a different kind of fullscreen, if it comes to be wanted.

	No test can be done currently given that none of the backend
	supports fullscreen.

	* html/HTMLMediaElement.cpp:
	* html/HTMLMediaElement.h:
	(WebCore::HTMLMediaElement::supportsFullscreen):
---
 3 files changed, 26 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 14 21:58:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 21:58:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27055] Qualify include path
 with wtf : [Attachment 32756] Second try.
In-Reply-To: <bug-27055-0@https.bugs.webkit.org/>
References: <bug-27055-0@https.bugs.webkit.org/>
Message-ID: <20090715045801.1542F332E02D@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27055: Qualify include path with wtf
https://bugs.webkit.org/show_bug.cgi?id=27055

Attachment 32756: Second try.
https://bugs.webkit.org/attachment.cgi?id=32756&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 22:22:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:22:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27284]
 HTMLMediaElement::supportsFullscreen() should return false : [Attachment
 32764] 2009-07-14 Pierre d'Herbemont <pdherbemont@apple.com>
In-Reply-To: <bug-27284-0@https.bugs.webkit.org/>
References: <bug-27284-0@https.bugs.webkit.org/>
Message-ID: <20090715052216.EE2A4332E712@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27284: HTMLMediaElement::supportsFullscreen() should return false
https://bugs.webkit.org/show_bug.cgi?id=27284

Attachment 32764: 2009-07-14  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=32764&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

From bugzilla-daemon at webkit.org  Tue Jul 14 22:29:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:29:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26599] CSSHelper.h's parseURL
 is a function that no one should ever call : [Attachment 32729] patch for
 part 1
In-Reply-To: <bug-26599-0@https.bugs.webkit.org/>
References: <bug-26599-0@https.bugs.webkit.org/>
Message-ID: <20090715052926.32EA7332E95C@gamma.macosforge.org>

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 26599: CSSHelper.h's parseURL is a function that no one should ever call
https://bugs.webkit.org/show_bug.cgi?id=26599

Attachment 32729: patch for part 1
https://bugs.webkit.org/attachment.cgi?id=32729&action=review

------- Additional Comments from mitz at webkit.org
> +	       // FIXME: The completeURL call should be done when using the
CSSImageValue,
> +	       // not when creating it.
> +	       parsedValue =
CSSFontFaceSrcValue::create(m_styleSheet->completeURL(val->string));

The comment should say CSSFontFaceSrcValue.

From bugzilla-daemon at webkit.org  Tue Jul 14 22:47:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:47:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32766] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090715054729.10961332EE6A@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32766: patch
https://bugs.webkit.org/attachment.cgi?id=32766&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 22:53:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:53:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32767] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090715055332.1BA89332F021@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32767: patch
https://bugs.webkit.org/attachment.cgi?id=32767&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 22:53:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:53:31 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32766] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090715055332.00BB2332F01B@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32766: patch
https://bugs.webkit.org/attachment.cgi?id=32766&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 22:54:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:54:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32768] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090715055407.5744C332F054@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32768: patch
https://bugs.webkit.org/attachment.cgi?id=32768&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 22:54:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 22:54:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32767] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090715055407.38BB2332F050@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32767: patch
https://bugs.webkit.org/attachment.cgi?id=32767&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 23:04:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 23:04:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32768] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090715060404.D757C332F3A6@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32768: patch
https://bugs.webkit.org/attachment.cgi?id=32768&action=review

From bugzilla-daemon at webkit.org  Tue Jul 14 23:32:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 14 Jul 2009 23:32:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 32769] Fixes
 bug 27289 by updating m_lastScrollbarUnderMouse on mouse down.
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090715063200.B6712332FBB2@gamma.macosforge.org>

Viet-Trung Luu <viettrungluu at gmail.com> has asked  for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 32769: Fixes bug 27289 by updating m_lastScrollbarUnderMouse on
mouse down.
https://bugs.webkit.org/attachment.cgi?id=32769&action=review

------- Additional Comments from Viet-Trung Luu <viettrungluu at gmail.com>
EventHandler::m_lastScrollbarUnderMouse is currently only updated on mouse move
and not on mouse down, which makes it fail (or at least behave oddly) when a
mouse down on a scrollbar occurs without a mouse move onto the scrollbar; this
patch fixes this.

From bugzilla-daemon at webkit.org  Wed Jul 15 01:14:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 01:14:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27290] Fix the
 DumpRenderTree GTK+ build : [Attachment 32770] proposed patch
In-Reply-To: <bug-27290-0@https.bugs.webkit.org/>
References: <bug-27290-0@https.bugs.webkit.org/>
Message-ID: <20090715081456.DDCD3333188D@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27290: Fix the DumpRenderTree GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=27290

Attachment 32770: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32770&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 01:25:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 01:25:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27290] Fix the DumpRenderTree
 GTK+ build : [Attachment 32770] proposed patch
In-Reply-To: <bug-27290-0@https.bugs.webkit.org/>
References: <bug-27290-0@https.bugs.webkit.org/>
Message-ID: <20090715082519.19EE83331BB9@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27290: Fix the DumpRenderTree GTK+ build
https://bugs.webkit.org/show_bug.cgi?id=27290

Attachment 32770: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32770&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>  dumprendertree_cppflags := \
> +	-DUSE_SYSTEM_MALLOC \

Ok. r=me.

From bugzilla-daemon at webkit.org  Wed Jul 15 01:53:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 01:53:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27291] Support lint for
 patches : [Attachment 32771] Patch v1
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090715085308.E0B133332473@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 32771: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32771&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 414 insertions(+), 3 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 15 02:47:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 02:47:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27292] Improve handling of
 <canvas> path operations on an empty path. : [Attachment 32772] Patch
In-Reply-To: <bug-27292-0@https.bugs.webkit.org/>
References: <bug-27292-0@https.bugs.webkit.org/>
Message-ID: <20090715094750.E763B3333449@gamma.macosforge.org>

Dean McNamee <deanm at chromium.org> has asked  for review:
Bug 27292: Improve handling of <canvas> path operations on an empty path.
https://bugs.webkit.org/show_bug.cgi?id=27292

Attachment 32772: Patch
https://bugs.webkit.org/attachment.cgi?id=32772&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 02:48:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 02:48:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27292] Improve handling of
 <canvas> path operations on an empty path. : [Attachment 32772] Patch
In-Reply-To: <bug-27292-0@https.bugs.webkit.org/>
References: <bug-27292-0@https.bugs.webkit.org/>
Message-ID: <20090715094857.2B30033334A4@gamma.macosforge.org>

Dean McNamee <deanm at chromium.org> has asked Oliver Hunt <oliver at apple.com> for
review:
Bug 27292: Improve handling of <canvas> path operations on an empty path.
https://bugs.webkit.org/show_bug.cgi?id=27292

Attachment 32772: Patch
https://bugs.webkit.org/attachment.cgi?id=32772&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 02:50:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 02:50:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27259] REGRESSION(43559):
 fast/js/kde/arguments-scope.html fails with interpreter : [Attachment
 32773] Patch o doom
In-Reply-To: <bug-27259-0@https.bugs.webkit.org/>
References: <bug-27259-0@https.bugs.webkit.org/>
Message-ID: <20090715095021.4DB4D3333514@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27259: REGRESSION(43559): fast/js/kde/arguments-scope.html fails with
interpreter
https://bugs.webkit.org/show_bug.cgi?id=27259

Attachment 32773: Patch o doom
https://bugs.webkit.org/attachment.cgi?id=32773&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 02:51:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 02:51:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27292] Improve handling of
 <canvas> path operations on an empty path. : [Attachment 32772] Patch
In-Reply-To: <bug-27292-0@https.bugs.webkit.org/>
References: <bug-27292-0@https.bugs.webkit.org/>
Message-ID: <20090715095153.90E6A3333593@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Dean McNamee <deanm at chromium.org>'s
request for review:
Bug 27292: Improve handling of <canvas> path operations on an empty path.
https://bugs.webkit.org/show_bug.cgi?id=27292

Attachment 32772: Patch
https://bugs.webkit.org/attachment.cgi?id=32772&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
In general this seems okay to me -- how does the output compare to firefox?

From bugzilla-daemon at webkit.org  Wed Jul 15 02:56:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 02:56:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27259] REGRESSION(43559):
 fast/js/kde/arguments-scope.html fails with interpreter : [Attachment
 32773] Patch o doom
In-Reply-To: <bug-27259-0@https.bugs.webkit.org/>
References: <bug-27259-0@https.bugs.webkit.org/>
Message-ID: <20090715095638.697533333709@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 27259: REGRESSION(43559): fast/js/kde/arguments-scope.html fails with
interpreter
https://bugs.webkit.org/show_bug.cgi?id=27259

Attachment 32773: Patch o doom
https://bugs.webkit.org/attachment.cgi?id=32773&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me . thanks for quick fix :)

From bugzilla-daemon at webkit.org  Wed Jul 15 03:44:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 03:44:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27293] Chromium's canvas
 forgets its context after fillText again : [Attachment 32774] Patch v1
In-Reply-To: <bug-27293-0@https.bugs.webkit.org/>
References: <bug-27293-0@https.bugs.webkit.org/>
Message-ID: <20090715104408.B59AA33344F7@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27293: Chromium's canvas forgets its context after fillText again
https://bugs.webkit.org/show_bug.cgi?id=27293

Attachment 32774: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32774&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 2 files changed, 14 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 15 04:24:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 04:24:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27294] REGRESSION:
 fast/js/postfix-syntax.html fails with interpreter : [Attachment 32776]
 fixeration!
In-Reply-To: <bug-27294-0@https.bugs.webkit.org/>
References: <bug-27294-0@https.bugs.webkit.org/>
Message-ID: <20090715112402.0FEEB3335184@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27294: REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294

Attachment 32776: fixeration!
https://bugs.webkit.org/attachment.cgi?id=32776&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 04:28:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 04:28:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27265] [Qt] font cache
 reworking : [Attachment 32777] proposed patch
In-Reply-To: <bug-27265-0@https.bugs.webkit.org/>
References: <bug-27265-0@https.bugs.webkit.org/>
Message-ID: <20090715112806.7619D333528A@gamma.macosforge.org>

Kelemen Bal?zs <Kelemen.Balazs.3 at stud.u-szeged.hu> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27265: [Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Attachment 32777: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32777&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 04:30:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 04:30:19 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27285] [Qt] New window created
 by clicking a link is not visible : [Attachment 32757] Force the new window
 to be visible
In-Reply-To: <bug-27285-0@https.bugs.webkit.org/>
References: <bug-27285-0@https.bugs.webkit.org/>
Message-ID: <20090715113019.1FAF03335355@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Yael <yael.aharon at nokia.com>'s request
for review:
Bug 27285: [Qt] New window created by clicking a link is not visible
https://bugs.webkit.org/show_bug.cgi?id=27285

Attachment 32757: Force the new window to be visible
https://bugs.webkit.org/attachment.cgi?id=32757&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I believe this is incorrect.

Arora, which is based on QtWebKit has no problem showing windows when a link is
clicked.  In fact, there is a setting in Arora to control the behavior so that
opening the "new window" is done in a tab instead.  The
QWebPage|QWebFrame::createWindow(...) function is virtual and allows the client
application to create the "new window" in the manner that it prefers.  The
default implementation does nothing, thus this will have no effect on the
default implementation.  It seems that if the client is responsible for
constructing the "new window" in the manner that it deems fit, then it can be
responsible for showing it too.

From bugzilla-daemon at webkit.org  Wed Jul 15 04:42:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 04:42:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27158] Add WebKit version API
 to Qt. : [Attachment 32737] More Portable Patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090715114218.E52433335781@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied robert
<robert at roberthogan.net>'s request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32737: More Portable Patch
https://bugs.webkit.org/attachment.cgi?id=32737&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

Nice! This looks a lot simpler :)

I have a few small comments below. Otherwise I have only one suggestion:
Instead of generating the entire header file from within the .pro file simply
include the contents of the generated header file in your patch itself. For
example running your script could simply produce WebCore/WebCoreVersion.h that
defines WEBCORE_MAJOR/MINOR_VERSION. Then your patch (here) includes your
script as well as the generated header file.

Afterwards all we need is

1) The other ports including the header file and using it (very simple patch)

and

2) Whenever WebCore/Configurations/Version.xcconfig is touched someone needs to
re-run your perl script to update the header file (simple).


r- because of the above, but otherwise a great step towards cleaning this up!

[...]
>      // webkit/qt version
> -    ua.append(QLatin1String("AppleWebKit/" WEBKIT_VERSION " (KHTML, like
Gecko, Safari/419.3) "));
> +    ua.append(QString(QLatin1String("AppleWebKit/%1 (KHTML, like Gecko) "))
> +			 .arg(QString(qWebKitVersion())));
>  
>      // Application name/version
>      QString appName = QCoreApplication::applicationName();
>      if (!appName.isEmpty()) {
> -	   ua.append(QLatin1Char(' ') + appName);
> +	   ua.append(appName);
>  #if QT_VERSION >= 0x040400
>	   QString appVer = QCoreApplication::applicationVersion();
>	   if (!appVer.isEmpty())
> @@ -2699,6 +2701,10 @@ QString QWebPage::userAgentForUrl(const QUrl& url)
const
>	   ua.append(QLatin1String("Qt/"));
>	   ua.append(QLatin1String(qVersion()));
>      }
> +
> +    ua.append(QString(QLatin1String(" Safari/%1"))
> +			 .arg(qWebKitVersion()));
> +
>      return ua;
>  }

Out of curiousity, why did you decide to append the Safari bit at the end
instead of just keeping the existing
initual ua.append() line and use arg() twice?

Doesn't this patch also change the parentheses of the user agent?

I think if we change the structure of the user agent string, then we have to
adjust the API documentation of the method, too.

> +void tst_QWebView::getWebKitVersion()
> +{
> +    QVERIFY(qWebKitVersion().toDouble());
> +}
> +

I'm not sure if this test is very useful :)

Given the simplicity of the function I think it's okay to skip this "test"
alltogether if you want.

From bugzilla-daemon at webkit.org  Wed Jul 15 04:53:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 04:53:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27294] REGRESSION:
 fast/js/postfix-syntax.html fails with interpreter : [Attachment 32778]
 attach patch instead of the changelog
In-Reply-To: <bug-27294-0@https.bugs.webkit.org/>
References: <bug-27294-0@https.bugs.webkit.org/>
Message-ID: <20090715115347.10DF33335B47@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27294: REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294

Attachment 32778: attach patch instead of the changelog
https://bugs.webkit.org/attachment.cgi?id=32778&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 04:53:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 04:53:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27294] REGRESSION:
 fast/js/postfix-syntax.html fails with interpreter : [Attachment 32776]
 fixeration!
In-Reply-To: <bug-27294-0@https.bugs.webkit.org/>
References: <bug-27294-0@https.bugs.webkit.org/>
Message-ID: <20090715115347.030303335B45@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has canceled Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27294: REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294

Attachment 32776: fixeration!
https://bugs.webkit.org/attachment.cgi?id=32776&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 05:13:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 05:13:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27294] REGRESSION:
 fast/js/postfix-syntax.html fails with interpreter : [Attachment 32778]
 attach patch instead of the changelog
In-Reply-To: <bug-27294-0@https.bugs.webkit.org/>
References: <bug-27294-0@https.bugs.webkit.org/>
Message-ID: <20090715121334.B12D33336491@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 27294: REGRESSION: fast/js/postfix-syntax.html fails with interpreter
https://bugs.webkit.org/show_bug.cgi?id=27294

Attachment 32778: attach patch instead of the changelog
https://bugs.webkit.org/attachment.cgi?id=32778&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 15 05:28:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 05:28:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 32451]
 lineboundary.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090715122807.F1A743336959@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled  review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 32451: lineboundary.patch
https://bugs.webkit.org/attachment.cgi?id=32451&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Clearing review. Patch landed.

From bugzilla-daemon at webkit.org  Wed Jul 15 05:43:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 05:43:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27252] Simplified Chinese
 translation : [Attachment 32706] Simplified Chinese translation in
 WebKit/gtk/po/ (r45855)
In-Reply-To: <bug-27252-0@https.bugs.webkit.org/>
References: <bug-27252-0@https.bugs.webkit.org/>
Message-ID: <20090715124351.7B3623336E59@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted  review:
Bug 27252: Simplified Chinese translation
https://bugs.webkit.org/show_bug.cgi?id=27252

Attachment 32706: Simplified Chinese translation in WebKit/gtk/po/ (r45855)
https://bugs.webkit.org/attachment.cgi?id=32706&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
rs=me.

From bugzilla-daemon at webkit.org  Wed Jul 15 05:46:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 05:46:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27295] The Qt DRT pops up
 message boxes when javascript execution takes too long : [Attachment 32779]
 patch to re-implement shouldInterruptJavaScript() in Qt DRT
In-Reply-To: <bug-27295-0@https.bugs.webkit.org/>
References: <bug-27295-0@https.bugs.webkit.org/>
Message-ID: <20090715124656.01C0E3336F68@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27295: The Qt DRT pops up message boxes when javascript execution takes too
long
https://bugs.webkit.org/show_bug.cgi?id=27295

Attachment 32779: patch to re-implement shouldInterruptJavaScript() in Qt DRT
https://bugs.webkit.org/attachment.cgi?id=32779&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Tests like fast/js/try-catch-crash.html take a long time with debug builds and
the interpreter and may result in a message box popping up.

Qt DRT should re-implement QWebPage::shouldInterruptJavaScript() and return
false, to avoid the message boxes. The run-webkit-tests counterpart takes care
of the timeout handling.

From bugzilla-daemon at webkit.org  Wed Jul 15 05:50:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 05:50:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27295] The Qt DRT pops up
 message boxes when javascript execution takes too long : [Attachment 32779]
 patch to re-implement shouldInterruptJavaScript() in Qt DRT
In-Reply-To: <bug-27295-0@https.bugs.webkit.org/>
References: <bug-27295-0@https.bugs.webkit.org/>
Message-ID: <20090715125004.12CA433370AB@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Simon Hausmann <hausmann at webkit.org>'s
request for review:
Bug 27295: The Qt DRT pops up message boxes when javascript execution takes too
long
https://bugs.webkit.org/show_bug.cgi?id=27295

Attachment 32779: patch to re-implement shouldInterruptJavaScript() in Qt DRT
https://bugs.webkit.org/attachment.cgi?id=32779&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 06:05:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 06:05:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27052] Undef ASSERT,
 to avoid excessive warnings : [Attachment 32780] Second try.
In-Reply-To: <bug-27052-0@https.bugs.webkit.org/>
References: <bug-27052-0@https.bugs.webkit.org/>
Message-ID: <20090715130558.677923337613@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27052: Undef ASSERT, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052

Attachment 32780: Second try.
https://bugs.webkit.org/attachment.cgi?id=32780&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Changed the patch so that it only impacts the SYMBIAN platform and reflect the
intention of this change better. In addition fixed the ChangeLog (filling in
for Norbert.)

The reason for this patch is to kill the following compiler warning:

"\WebKit\JavaScriptCore\wtf\Assertions.h", line 146: Warning:  #47-D:
incompatible redefinition of macro "ASSERT" (declared at line 3029 of
"\epoc32\include\e32def.h")
  #define ASSERT(assertion) ((void)0)

From bugzilla-daemon at webkit.org  Wed Jul 15 06:13:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 06:13:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27177] After double-clicking
 a word,
 using Shift-arrow to select behaves unpredictably : [Attachment 32720] patch
In-Reply-To: <bug-27177-0@https.bugs.webkit.org/>
References: <bug-27177-0@https.bugs.webkit.org/>
Message-ID: <20090715131334.7AB6C333784D@gamma.macosforge.org>

John Sullivan <sullivan at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 27177: After double-clicking a word, using Shift-arrow to select behaves
unpredictably
https://bugs.webkit.org/show_bug.cgi?id=27177

Attachment 32720: patch
https://bugs.webkit.org/attachment.cgi?id=32720&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
> +	   Remvoe code that sets m_lastChangeWasHorizontalExtension; that is
now handled elsewhere. 

Typo, "Remvoe"

From bugzilla-daemon at webkit.org  Wed Jul 15 06:56:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 06:56:25 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27052] Undef ASSERT,
 to avoid excessive warnings : [Attachment 32412] Code patch for
 Assertion.h
In-Reply-To: <bug-27052-0@https.bugs.webkit.org/>
References: <bug-27052-0@https.bugs.webkit.org/>
Message-ID: <20090715135625.92AF1333864B@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has canceled Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27052: Undef ASSERT, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052

Attachment 32412: Code patch for Assertion.h
https://bugs.webkit.org/attachment.cgi?id=32412&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Obsolete according to lazlos.

From bugzilla-daemon at webkit.org  Wed Jul 15 07:03:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 07:03:50 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27052] Undef ASSERT,
 to avoid excessive warnings : [Attachment 32780] Second try.
In-Reply-To: <bug-27052-0@https.bugs.webkit.org/>
References: <bug-27052-0@https.bugs.webkit.org/>
Message-ID: <20090715140350.D1B6133388FD@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27052: Undef ASSERT, to avoid excessive warnings
https://bugs.webkit.org/show_bug.cgi?id=27052

Attachment 32780: Second try.
https://bugs.webkit.org/attachment.cgi?id=32780&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. I'll mention Symbian in the changelog when landing, to make it a bit
clearer.

From bugzilla-daemon at webkit.org  Wed Jul 15 07:07:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 07:07:11 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32651] patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090715140711.1183B3338A6E@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled  review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32651: patch
https://bugs.webkit.org/attachment.cgi?id=32651&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 07:07:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 07:07:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32782] updated patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090715140716.9E0753338A7A@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32782: updated patch
https://bugs.webkit.org/attachment.cgi?id=32782&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 07:08:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 07:08:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32782] updated patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090715140848.59CA43338B0D@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked Gustavo Noronha (kov) <gns at gnome.org>
for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32782: updated patch
https://bugs.webkit.org/attachment.cgi?id=32782&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 07:15:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 07:15:23 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27265] [Qt] font cache
 reworking : [Attachment 32777] proposed patch
In-Reply-To: <bug-27265-0@https.bugs.webkit.org/>
References: <bug-27265-0@https.bugs.webkit.org/>
Message-ID: <20090715141523.1A1973338D6E@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied Kelemen Bal?zs
<Kelemen.Balazs.3 at stud.u-szeged.hu>'s request for review:
Bug 27265: [Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Attachment 32777: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32777&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
In general this looks good, but after running the layout tests with your patch
applied I'm getting a bunch of crashes:

fast/css/font-face-multiple-families.html
fast/loader/font-face-empty.html
fast/loader/goto-anchor-infinite-layout.html
svg/custom/createImageElement2.xhtml
svg/custom/font-platformDestroy-crash.svg
svg/dom/altGlyph-dom.xhtml

r- because of that, sorry :)

From bugzilla-daemon at webkit.org  Wed Jul 15 07:56:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 07:56:07 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27291] Support lint for
 patches : [Attachment 32771] Patch v1
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090715145607.6DEA93339BE6@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 32771: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32771&action=review

------- Additional Comments from David Levin <levin at chromium.org>


> diff --git a/WebKitTools/Scripts/cpplint.py b/WebKitTools/Scripts/cpplint.py

> +# From
http://code.google.com/p/rietveld/source/browse/branches/chromium/codereview/en
gine.py
This code may not be used in WebKit because it has an incompatible license:
"Licensed under the Apache License"

By the way, this is the typical license for Google code. (cpplint.py was
relicense due to Albert Wong asking the author so that it could be used in
WebKit.)

So there are two options:
1. See if the code can be relicensed (or dual licensed) (which may not be easy
to do if people outside of Google contributed) OR
2. Write something equivalent from scratch.

> +# From
http://code.google.com/p/rietveld/source/browse/branches/chromium/codereview/pa
tching.py

Same license issue.



*** General comment ***
For the rest of this, it feels like the use case should be someone who has the
patch in their scm. The user would be to run the lint tool on the patch that
would be created.

With that in mind could this change would do the following: 
1. Getting the current diff from the scm (use "create_patch" in scm.py.  A
subsequent change can add support to call create_patch_from_local_commit for
git users.)
2. Run cpplint on the files in that diff.
3. Filter the output from cpplint to only include the lines that changed in
that diff.

Also, this logic could reside outside of cpplint.py, there could be a
run-webkit-lint that did most of this and then called cpplint to do the linting
of cpp/h files (with what lines to filter the results to).

I like this approach because you'll get less false lint warnings from running
it on the whole file and it feels like it fits the usage model.  (If I want to
lint someone else's patch, I could always patch it into my local system and
then run the lint tool on it.) 

As you do this work, don't feel like you need a fully completely functional
thing to submit a patch.  Just take logical chunks that are complete by
themselves but may not provide all the functionality and submit patches as you
go along so that the patches stay small which will make the review process
faster.

For example one patch, may be just to move cpplint.py (and its unit test) into
Scripts/modules since we'll probably call it from "run-webkit-lint" (which
would be the harness you'll write in these patches).

From bugzilla-daemon at webkit.org  Wed Jul 15 08:04:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:04:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27293] Chromium's canvas
 forgets its context after fillText again : [Attachment 32774] Patch v1
In-Reply-To: <bug-27293-0@https.bugs.webkit.org/>
References: <bug-27293-0@https.bugs.webkit.org/>
Message-ID: <20090715150430.AE64C3339EA4@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27293: Chromium's canvas forgets its context after fillText again
https://bugs.webkit.org/show_bug.cgi?id=27293

Attachment 32774: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32774&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 08:06:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:06:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32782] updated patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090715150651.E8CE23339F72@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32782: updated patch
https://bugs.webkit.org/attachment.cgi?id=32782&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +	   gchar* resultStr = g_string_free(result, FALSE);
> +	   printf("%s", resultStr);
> +	   g_free(resultStr);

I would prefer the following:

printf("%s", result->str);
g_string_free(result, TRUE);

But I am fine either way. If you feel like changing it, please do.

r=me

From bugzilla-daemon at webkit.org  Wed Jul 15 08:11:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:11:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27020] msToGregorianDateTime
 ignores outputIsUTC param when filling in utcOffset : [Attachment 32358]
 patch to DateMath.cpp
In-Reply-To: <bug-27020-0@https.bugs.webkit.org/>
References: <bug-27020-0@https.bugs.webkit.org/>
Message-ID: <20090715151136.52B94333A11A@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27020: msToGregorianDateTime ignores outputIsUTC param when filling in
utcOffset
https://bugs.webkit.org/show_bug.cgi?id=27020

Attachment 32358: patch to DateMath.cpp
https://bugs.webkit.org/attachment.cgi?id=32358&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
absence of comments otherwise and it looks both correct and reasonable to me,
so r+

From bugzilla-daemon at webkit.org  Wed Jul 15 08:16:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:16:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27056] Alternate bool
 operator for codewarrior compiler (WINSCW) : [Attachment 32416] Code patch
 for OwnArrayPtr.h
In-Reply-To: <bug-27056-0@https.bugs.webkit.org/>
References: <bug-27056-0@https.bugs.webkit.org/>
Message-ID: <20090715151605.E7EA7333A2E6@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27056: Alternate bool operator for codewarrior compiler (WINSCW)
https://bugs.webkit.org/show_bug.cgi?id=27056

Attachment 32416: Code patch for OwnArrayPtr.h
https://bugs.webkit.org/attachment.cgi?id=32416&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me, this is identical to the fix in r38391 / #38391

From bugzilla-daemon at webkit.org  Wed Jul 15 08:19:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:19:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27299] [Qt] Cleanup -
 Remove obsolete code from the make system : [Attachment 32785] Proposed
 Fix.
In-Reply-To: <bug-27299-0@https.bugs.webkit.org/>
References: <bug-27299-0@https.bugs.webkit.org/>
Message-ID: <20090715151939.12D16333A498@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27299: [Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299

Attachment 32785: Proposed Fix.
https://bugs.webkit.org/attachment.cgi?id=32785&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 08:21:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:21:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27246] Add
 HTMLMediaElement::supportSave() and a HitTestResult::absoluteMediaURL()
 functions : [Attachment 32760] Undo the added delegation of
 HTMLMediaElement::supportsFullscreen().
In-Reply-To: <bug-27246-0@https.bugs.webkit.org/>
References: <bug-27246-0@https.bugs.webkit.org/>
Message-ID: <20090715152149.9CE76333A56A@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27246: Add HTMLMediaElement::supportSave() and a
HitTestResult::absoluteMediaURL() functions
https://bugs.webkit.org/show_bug.cgi?id=27246

Attachment 32760: Undo the added delegation of
HTMLMediaElement::supportsFullscreen().
https://bugs.webkit.org/attachment.cgi?id=32760&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Sounds reasonable, I take that we don't want MediaControlElement to know about
audio/video.

From bugzilla-daemon at webkit.org  Wed Jul 15 08:22:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:22:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27285] [Qt] New window
 created by clicking a link is not visible : [Attachment 32786] Make the
 change only for QtLauncher
In-Reply-To: <bug-27285-0@https.bugs.webkit.org/>
References: <bug-27285-0@https.bugs.webkit.org/>
Message-ID: <20090715152213.746CA333A5B4@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27285: [Qt] New window created by clicking a link is not visible
https://bugs.webkit.org/show_bug.cgi?id=27285

Attachment 32786: Make the change only for QtLauncher
https://bugs.webkit.org/attachment.cgi?id=32786&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
As suggested in comment #2, each client is responsible for showing its own
window. Thus moving the change to QtLauncher.

From bugzilla-daemon at webkit.org  Wed Jul 15 08:25:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:25:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27206] Add --websocket flag
 and ENABLE_WEBSOCKET define : [Attachment 32698] Add "Web Sockets" feature
 configuration.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090715152540.10595333A717@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27206: Add --websocket flag and ENABLE_WEBSOCKET define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32698: Add "Web Sockets" feature configuration.
https://bugs.webkit.org/attachment.cgi?id=32698&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few last small details.

> diff --git a/ChangeLog b/ChangeLog
> +2009-07-12  Fumitoshi Ukai  <ukai at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27206
> +

The current changelog format has bug titles in addition to the bug link, so

  Add --websocket flag and ENABLE_WEBSOCKET define
  https://bugs.webkit.org/show_bug.cgi?id=27206

(for every ChangeLog in here).



> diff --git a/WebCore/GNUmakefile.am b/WebCore/GNUmakefile.am

> +# IDL_BINDINGS += WebCore/websockets/WebSocket.idl
...
> +#webcore_sources += \
> +#	WebCore/bindings/js/JSWebSocketConstructor.cpp \
> +#	WebCore/bindings/js/JSWebSocketConstructor.h \
> +#	WebCore/bindings/js/JSWebSocketCustom.cpp \
> +#	WebCore/websockets/WebSocket.cpp \
> +#	WebCore/websockets/WebSocket.h \
> +#	WebCore/websockets/WebSocketChannel.cpp \
> +#	WebCore/websockets/WebSocketChannel.h \
> +#	WebCore/websockets/WebSocketChannelClient.h \
> +#	WebCore/platform/network/WebSocketHandle.h \
> +#	WebCore/platform/network/WebSocketHandleClient.h \
> +#	WebCore/platform/network/WebSocketRequestBase.cpp \
> +#	WebCore/platform/network/WebSocketRequestBase.h \
> +#	WebCore/platform/network/WebSocketResponseBase.cpp \
> +#	WebCore/platform/network/WebSocketResponseBase.h
> +
> +# webcoregtk_sources += \
> +#	WebCore/platform/network/soup/WebSocketHandleSoup.cpp \
> +#	WebCore/platform/network/soup/WebSocketRequest.h \
> +#	WebCore/platform/network/soup/WebSocketResponse.h
> +
> +# if TARGET_WIN32
> +# webcore_sources += \
> +# endif

You're adding a lot of commented out "code".  I would just leave it out until
it is useful and add it as needed without commenting it out.


> diff --git a/WebKitTools/Scripts/build-webkit
b/WebKitTools/Scripts/build-webkit
> @@ -123,6 +123,8 @@ my @features = (
>  
>      { option => "xslt", desc => "Toggle XSLT support",
>	 define => "ENABLE_XSLT", default => 1, value => \$xsltSupport },
> +    { option => "web-sockets", desc => "Toggle Web Sockets support",
> +	 define => "ENABLE_WEB_SOCKETS", default => 1, value=>
\$webSocketsSupport },
>  );

This should be sorted as well.


> diff --git a/configure.ac b/configure.ac
>   WML support 					     : $enable_wml
>   Web Workers support 				     : $enable_workers
> + Web Sockets support 				     :
$enable_web_sockets

"Web Sockets support" should be just before "Web Workers support" instead of
after.

From bugzilla-daemon at webkit.org  Wed Jul 15 08:31:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:31:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27298] [WINCE] platform
 defines for WinCE : [Attachment 32784] patch to Platform.h
In-Reply-To: <bug-27298-0@https.bugs.webkit.org/>
References: <bug-27298-0@https.bugs.webkit.org/>
Message-ID: <20090715153126.8A46E333A938@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied  review:
Bug 27298: [WINCE] platform defines for WinCE
https://bugs.webkit.org/show_bug.cgi?id=27298

Attachment 32784: patch to Platform.h
https://bugs.webkit.org/attachment.cgi?id=32784&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Need to remove ENABLE_MDR.  That's specific to Torch Mobile at this point. 
Rest looks fine.

From bugzilla-daemon at webkit.org  Wed Jul 15 08:41:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:41:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27285] [Qt] New window
 created by clicking a link is not visible : [Attachment 32786] Make the
 change only for QtLauncher
In-Reply-To: <bug-27285-0@https.bugs.webkit.org/>
References: <bug-27285-0@https.bugs.webkit.org/>
Message-ID: <20090715154122.8B415333ACCD@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27285: [Qt] New window created by clicking a link is not visible
https://bugs.webkit.org/show_bug.cgi?id=27285

Attachment 32786: Make the change only for QtLauncher
https://bugs.webkit.org/attachment.cgi?id=32786&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me, thanks :)

From bugzilla-daemon at webkit.org  Wed Jul 15 08:49:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 08:49:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27299] [Qt] Cleanup - Remove
 obsolete code from the make system : [Attachment 32785] Proposed Fix.
In-Reply-To: <bug-27299-0@https.bugs.webkit.org/>
References: <bug-27299-0@https.bugs.webkit.org/>
Message-ID: <20090715154954.42117333B040@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27299: [Qt] Cleanup - Remove obsolete code from the make system
https://bugs.webkit.org/show_bug.cgi?id=27299

Attachment 32785: Proposed Fix.
https://bugs.webkit.org/attachment.cgi?id=32785&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. thanks for the cleanup!

From bugzilla-daemon at webkit.org  Wed Jul 15 09:05:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:05:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27302] Move cpplint.py to
 module directory : [Attachment 32788] Patch v1
In-Reply-To: <bug-27302-0@https.bugs.webkit.org/>
References: <bug-27302-0@https.bugs.webkit.org/>
Message-ID: <20090715160552.E5EA7333B5D8@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27302: Move cpplint.py to module directory
https://bugs.webkit.org/show_bug.cgi?id=27302

Attachment 32788: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32788&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 5 files changed, 5785 insertions(+), 5775 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 15 09:11:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:11:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27301] [WINCE]
 vprintf_stderr_common must use OutputDebugStringW : [Attachment 32789]
 patch to Assertions.cpp
In-Reply-To: <bug-27301-0@https.bugs.webkit.org/>
References: <bug-27301-0@https.bugs.webkit.org/>
Message-ID: <20090715161144.32F24333B7DF@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27301: [WINCE] vprintf_stderr_common must use OutputDebugStringW
https://bugs.webkit.org/show_bug.cgi?id=27301

Attachment 32789: patch to Assertions.cpp
https://bugs.webkit.org/attachment.cgi?id=32789&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 09:27:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:27:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27303] [WINCE] implement
 createThreadInternal : [Attachment 32790] patch to ThreadingWin.cpp
In-Reply-To: <bug-27303-0@https.bugs.webkit.org/>
References: <bug-27303-0@https.bugs.webkit.org/>
Message-ID: <20090715162719.A2FAD333BD9F@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32790: patch to ThreadingWin.cpp
https://bugs.webkit.org/attachment.cgi?id=32790&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 09:35:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:35:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27304] WebKit should
 provide usage and eligibility information about the page cache :
 [Attachment 32791] Patch
In-Reply-To: <bug-27304-0@https.bugs.webkit.org/>
References: <bug-27304-0@https.bugs.webkit.org/>
Message-ID: <20090715163505.6E04A333C06A@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27304: WebKit should provide usage and eligibility information about the
page cache
https://bugs.webkit.org/show_bug.cgi?id=27304

Attachment 32791: Patch
https://bugs.webkit.org/attachment.cgi?id=32791&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 09:35:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:35:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27301] [WINCE]
 vprintf_stderr_common must use OutputDebugStringW : [Attachment 32789]
 patch to Assertions.cpp
In-Reply-To: <bug-27301-0@https.bugs.webkit.org/>
References: <bug-27301-0@https.bugs.webkit.org/>
Message-ID: <20090715163538.394EB333C08A@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27301: [WINCE] vprintf_stderr_common must use OutputDebugStringW
https://bugs.webkit.org/show_bug.cgi?id=27301

Attachment 32789: patch to Assertions.cpp
https://bugs.webkit.org/attachment.cgi?id=32789&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 09:41:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:41:46 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27303] [WINCE] implement
 createThreadInternal : [Attachment 32790] patch to ThreadingWin.cpp
In-Reply-To: <bug-27303-0@https.bugs.webkit.org/>
References: <bug-27303-0@https.bugs.webkit.org/>
Message-ID: <20090715164146.9762A333C2FF@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Joe Mason <joe.mason at torchmobile.com>'s
request for review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32790: patch to ThreadingWin.cpp
https://bugs.webkit.org/attachment.cgi?id=32790&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +#if !PLATFORM(WINCE)
>  #include <process.h>
> +#endif

For?

> +#if HAVE(ERRNO_H)
> +#include <errno.h>
> +#else
> +#define NO_ERRNO
> +#endif

I'm not sure.  In a previous patch to RegisterFile we were using 'GetLastError'
instead of errno for WINCE.  Shouldn't we do the same here?  Moreover, we
should create a proper WTF abstraction for ERRNO it seems.

> +#if PLATFORM(WINCE)
> +    // This should be safe on WINCE.  On Windows desktop it is not.
> +    HANDLE threadHandle = CreateThread(0, 0,
(LPTHREAD_START_ROUTINE)wtfThreadEntryPoint, invocation, 0,
(LPDWORD)&threadIdentifier);

Why is it safe for WINCE, but not for desktop and what does it gain us?

From bugzilla-daemon at webkit.org  Wed Jul 15 09:45:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:45:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27305] [WINCE] add
 WinCE-specific unicode implementation : [Attachment 32792] patch adding
 unicode/wince subdir
In-Reply-To: <bug-27305-0@https.bugs.webkit.org/>
References: <bug-27305-0@https.bugs.webkit.org/>
Message-ID: <20090715164550.9E855333C46D@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27305: [WINCE] add WinCE-specific unicode implementation
https://bugs.webkit.org/show_bug.cgi?id=27305

Attachment 32792: patch adding unicode/wince subdir
https://bugs.webkit.org/attachment.cgi?id=32792&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 09:57:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 09:57:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27306] [WINCE]
 initializeMainThreadPlatform must use RegisterClass,
 not RegisterClassEx : [Attachment 32793] Patch to MainThreadWin.cpp
In-Reply-To: <bug-27306-0@https.bugs.webkit.org/>
References: <bug-27306-0@https.bugs.webkit.org/>
Message-ID: <20090715165758.D6990333C90A@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27306: [WINCE] initializeMainThreadPlatform must use RegisterClass, not
RegisterClassEx
https://bugs.webkit.org/show_bug.cgi?id=27306

Attachment 32793: Patch to MainThreadWin.cpp
https://bugs.webkit.org/attachment.cgi?id=32793&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 10:02:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:02:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27302] Move cpplint.py to
 module directory : [Attachment 32788] Patch v1
In-Reply-To: <bug-27302-0@https.bugs.webkit.org/>
References: <bug-27302-0@https.bugs.webkit.org/>
Message-ID: <20090715170202.B09E7333CA62@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27302: Move cpplint.py to module directory
https://bugs.webkit.org/show_bug.cgi?id=27302

Attachment 32788: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32788&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 10:08:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:08:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27304] WebKit should provide
 usage and eligibility information about the page cache : [Attachment 32791]
 Patch
In-Reply-To: <bug-27304-0@https.bugs.webkit.org/>
References: <bug-27304-0@https.bugs.webkit.org/>
Message-ID: <20090715170831.7FDF7333CD02@gamma.macosforge.org>

mitz at webkit.org has granted Brady Eidson <beidson at apple.com>'s request for
review:
Bug 27304: WebKit should provide usage and eligibility information about the
page cache
https://bugs.webkit.org/show_bug.cgi?id=27304

Attachment 32791: Patch
https://bugs.webkit.org/attachment.cgi?id=32791&action=review

------- Additional Comments from mitz at webkit.org
r=me if you address the above comments

From bugzilla-daemon at webkit.org  Wed Jul 15 10:19:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:19:02 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32761]
 Take 3
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090715171902.374C6333D09A@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32761: Take 3
https://bugs.webkit.org/attachment.cgi?id=32761&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
The improvements here look really good.

> +    virtual long inspectorPageHeight() = 0;

Do we really need the client to give us this information? I think
m_page->mainFrame()->view()->visibleHeight() would give us the same
information.

> +    virtual long inspectedPageHeight() = 0;

For the same reason, it seems like we don't need inspectedPageHeight(), either.
We can do the same thing as above, but use m_inspectedPage instead of m_page.

> +    static const float minimumAttachedHeight = 250.0;
> +    static const float maximumAttachedHeightRatio = 0.75;

I think you should move these up next to defaultAttachedHeight.

> +    long attachedHeight = round(max(minimumAttachedHeight, 
> +	   min(static_cast<float>(height), (m_client->inspectedPageHeight() +
m_client->inspectorPageHeight()) * maximumAttachedHeightRatio)));
> +
> +    // Save a preference for the user's preferred attached height and pass
it to the client
> +    setSetting(inspectorAttachedHeightName, Setting(attachedHeight));
> +    m_client->setInitialAttachedHeight(attachedHeight);
> +
> +    m_client->setAttachedWindowHeight(attachedHeight);

It seems bad that we have to call both of these functions one after the other.

I think that we can get rid of setInitialAttachedHeight completely. I think the
way this should work is:

1) Whenever the Inspector becomes attached (either because it is being shown
for the first time and is starting out attached, or because the user clicked
the button to attach it), the client should set the height of the Inspector to
the value stored in the settings (so the client would ask the
InspectorController for that height value)
2) Whenever the height of the attached Inspector changes, the
InspectorController saves the new height to settings and calls
InspectorClient::setAttachedWindowHeight, and the client obliges.

So there's no need for the whole "initial attached height" concept here. That
will let the clients get rid of their m_initialAttachedHeight members.

>  private:
>      void updateWindowTitle() const;
>  
> +    long m_initialAttachedHeight;

You still aren't initializing this in the constructor (in
WebInspectorClient.mm). But as I explained above, I think we can get rid of
this entirely.

>  void WebInspectorClient::setAttachedWindowHeight(unsigned height)
>  {
> -    // FIXME: implement this.
> +    if (!m_attached)
> +	   return;
> +
> +    RECT inspectedRect;
> +    GetClientRect(m_inspectedWebViewHwnd, &inspectedRect);
> +
> +    int webViewWidth = inspectedRect.right - inspectedRect.left;
> +    int totalHeight = inspectedPageHeight() + inspectorPageHeight();
> +
> +    SetWindowPos(m_webViewHwnd, 0, 0, totalHeight - height, webViewWidth,
height, SWP_NOZORDER);
> +    SetWindowPos(m_inspectedWebViewHwnd, 0, 0, 0, webViewWidth, totalHeight,
SWP_NOZORDER);
> +    
> +    RedrawWindow(m_webViewHwnd, 0, 0, RDW_INVALIDATE | RDW_ALLCHILDREN |
RDW_UPDATENOW); 
> +    RedrawWindow(m_inspectedWebViewHwnd, 0, 0, RDW_INVALIDATE |
RDW_ALLCHILDREN | RDW_UPDATENOW);
>  }

I guess you decided we don't need the WM_SETREDRAW stuff after all?

I think after making the changes I described above, we won't need any new
InspectorClient functions at all! That should make the patch a lot smaller and
simpler. Sorry my thinking on this wasn't clearer before.

From bugzilla-daemon at webkit.org  Wed Jul 15 10:20:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:20:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27287] [V8] Fix isolated
 world constructors : [Attachment 32762] patch
In-Reply-To: <bug-27287-0@https.bugs.webkit.org/>
References: <bug-27287-0@https.bugs.webkit.org/>
Message-ID: <20090715172026.A3D23333D135@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27287: [V8] Fix isolated world constructors
https://bugs.webkit.org/show_bug.cgi?id=27287

Attachment 32762: patch
https://bugs.webkit.org/attachment.cgi?id=32762&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Excellent!

From bugzilla-daemon at webkit.org  Wed Jul 15 10:31:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:31:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27306] [WINCE]
 initializeMainThreadPlatform must use RegisterClass,
 not RegisterClassEx : [Attachment 32793] Patch to MainThreadWin.cpp
In-Reply-To: <bug-27306-0@https.bugs.webkit.org/>
References: <bug-27306-0@https.bugs.webkit.org/>
Message-ID: <20090715173107.34459333D562@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Joe Mason <joe.mason at torchmobile.com>'s
request for review:
Bug 27306: [WINCE] initializeMainThreadPlatform must use RegisterClass, not
RegisterClassEx
https://bugs.webkit.org/show_bug.cgi?id=27306

Attachment 32793: Patch to MainThreadWin.cpp
https://bugs.webkit.org/attachment.cgi?id=32793&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 10:39:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:39:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27298] [WINCE] platform
 defines for WinCE : [Attachment 32794] updated patch (removed ENABLE_MDR)
In-Reply-To: <bug-27298-0@https.bugs.webkit.org/>
References: <bug-27298-0@https.bugs.webkit.org/>
Message-ID: <20090715173930.0D3B2333D81D@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27298: [WINCE] platform defines for WinCE
https://bugs.webkit.org/show_bug.cgi?id=27298

Attachment 32794: updated patch (removed ENABLE_MDR)
https://bugs.webkit.org/attachment.cgi?id=32794&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 10:49:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:49:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27303] [WINCE] implement
 createThreadInternal : [Attachment 32795] Updated patch
In-Reply-To: <bug-27303-0@https.bugs.webkit.org/>
References: <bug-27303-0@https.bugs.webkit.org/>
Message-ID: <20090715174924.3002A333DB7F@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32795: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32795&action=review

------- Additional Comments from Joe Mason <joe.mason at torchmobile.com>
Updated the patch to call ::GetLastError on WINCE (and also leave the NO_ERRNO
path in, just in case there's a different platform without errno).

Also added a more detailed comment on why CreateThread is safe.

From bugzilla-daemon at webkit.org  Wed Jul 15 10:52:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:52:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27298] [WINCE] platform
 defines for WinCE : [Attachment 32794] updated patch (removed ENABLE_MDR)
In-Reply-To: <bug-27298-0@https.bugs.webkit.org/>
References: <bug-27298-0@https.bugs.webkit.org/>
Message-ID: <20090715175242.870ED333DCB8@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27298: [WINCE] platform defines for WinCE
https://bugs.webkit.org/show_bug.cgi?id=27298

Attachment 32794: updated patch (removed ENABLE_MDR)
https://bugs.webkit.org/attachment.cgi?id=32794&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Hopefully the ENABLE_MDR will be addressed otherwise downstream.  Looks okay
now.

In the future we might want to deal with ENABLE_WML similarly.

From bugzilla-daemon at webkit.org  Wed Jul 15 10:54:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 10:54:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27303] [WINCE] implement
 createThreadInternal : [Attachment 32795] Updated patch
In-Reply-To: <bug-27303-0@https.bugs.webkit.org/>
References: <bug-27303-0@https.bugs.webkit.org/>
Message-ID: <20090715175430.812F0333DD5D@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32795: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32795&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
I'm not sure that NO_ERRNO is needed anymore but I don't see the harm either. 
It will help in porting to other platforms I think.

From bugzilla-daemon at webkit.org  Wed Jul 15 11:03:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:03:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32735] For Linux,
 suppress NP Plugin stderr output that is out of our control
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090715180326.B0A50333E05D@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has canceled
Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>'s request for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32735: For Linux, suppress NP Plugin stderr output that is out of
our control
https://bugs.webkit.org/attachment.cgi?id=32735&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 11:03:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:03:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32796] For Qt,
 overwrite the plugin directories for the DRT to only those defined in
 QTWEBKIT_PLUGIN_PATH
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090715180326.C2AD1333E05F@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32796: For Qt,overwrite the plugin directories for the DRT to only
those defined in QTWEBKIT_PLUGIN_PATH
https://bugs.webkit.org/attachment.cgi?id=32796&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 11:18:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:18:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27303] [WINCE] implement
 createThreadInternal : [Attachment 32795] Updated patch
In-Reply-To: <bug-27303-0@https.bugs.webkit.org/>
References: <bug-27303-0@https.bugs.webkit.org/>
Message-ID: <20090715181826.957DB333E5C5@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32795: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32795&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 11:18:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:18:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27303] [WINCE] implement
 createThreadInternal : [Attachment 32795] Updated patch
In-Reply-To: <bug-27303-0@https.bugs.webkit.org/>
References: <bug-27303-0@https.bugs.webkit.org/>
Message-ID: <20090715181847.52993333E5E9@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Adam Treat <treat at kde.org>'s request for
review:
Bug 27303: [WINCE] implement createThreadInternal
https://bugs.webkit.org/show_bug.cgi?id=27303

Attachment 32795: Updated patch
https://bugs.webkit.org/attachment.cgi?id=32795&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Looks good to me too.

From bugzilla-daemon at webkit.org  Wed Jul 15 11:39:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:39:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26940] [Chromium] Add a SQLite
 VFS for Chromium : [Attachment 32588] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090715183909.DB65F333EE29@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32588: win patch
https://bugs.webkit.org/attachment.cgi?id=32588&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Please add WebCore.gypi changes and we'll be good to land.

From bugzilla-daemon at webkit.org  Wed Jul 15 11:50:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:50:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32588] win patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090715185024.F26A8333F272@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted  review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32588: win patch
https://bugs.webkit.org/attachment.cgi?id=32588&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 11:52:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 11:52:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32228] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090715185255.1ABFC333F36D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32228: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32228&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Who owns the BView in the GraphicsContextPlatformPrivate?  I'm surprised that
GCPlatformPrivate doesnt' need to retain it?

style:
npoints should be numberOfPoints or pointsLength or similar.

Style:
8     if (rects.size() > 1)
 229	 {

spacing:
 235	     m_data->view->StrokeRect(region.Frame(),B_MIXED_COLORS);

Naming:
 257 FloatRect GraphicsContext::roundToDevicePixels(const FloatRect& frect)

Naming:
 287 void GraphicsContext::strokeRect(const FloatRect& r, float width)
 298 void GraphicsContext::setLineCap(LineCap lc)

No need to wrap lines like this:
void GraphicsContext::addInnerRoundedRectClip(const IntRect& rect,
 451						   int thickness)
 452 

I'm surprised your compiler can't convert from "return 0":
    return PassRefPtr<Icon>(0);

Why are you adding the empy ImageBufferData class?

I think you mean something like "if the image hasn't fully loaded":
 130	 if (!image) // If it's too early we won't have an image yet.

But I'm still confused as to why we'd be calling pattern drawing routines with
an image w/o a first frame.

I think there are functions to do this for you:
 140	 ctxt->clip(IntRect(dstRect.x(), dstRect.y(), dstRect.width(),
dstRect.height()));

IntRect(dstRect) probably does what you want.  Although you might want
enclosingIntRect() there.

c++ style casts please:
 57	const unsigned char* uContents = (const unsigned char*) data.data();


I'm surprised:
 50 ImageDecoder* createDecoder(const Vector<char>& data)

isn't shared between teh ports?

Spacing:
 45	return BRect(BPoint(x(), y()), BSize(width(),height()));

It's better to break patches down by size instead of directory.

r- for all the nits above.

From bugzilla-daemon at webkit.org  Wed Jul 15 12:03:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:03:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27309] Local variable in
 instantiateV8Object shadows function parameter : [Attachment 32797] Patch
 which removes the local variable
In-Reply-To: <bug-27309-0@https.bugs.webkit.org/>
References: <bug-27309-0@https.bugs.webkit.org/>
Message-ID: <20090715190344.456D4333F770@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has asked  for review:
Bug 27309: Local variable in instantiateV8Object shadows function parameter
https://bugs.webkit.org/show_bug.cgi?id=27309

Attachment 32797: Patch which removes the local variable
https://bugs.webkit.org/attachment.cgi?id=32797&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 12:07:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:07:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27309] Local variable in
 instantiateV8Object shadows function parameter : [Attachment 32797] Patch
 which removes the local variable
In-Reply-To: <bug-27309-0@https.bugs.webkit.org/>
References: <bug-27309-0@https.bugs.webkit.org/>
Message-ID: <20090715190700.9AD3A333F89A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted James Hawkins
<jhawkins at google.com>'s request for review:
Bug 27309: Local variable in instantiateV8Object shadows function parameter
https://bugs.webkit.org/show_bug.cgi?id=27309

Attachment 32797: Patch which removes the local variable
https://bugs.webkit.org/attachment.cgi?id=32797&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+	No test required as this change does not affect layout.

You should say that no test is required because this change does not change our
behavior.  The LayoutTests test much more than just layout.  :)

From bugzilla-daemon at webkit.org  Wed Jul 15 12:07:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:07:45 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32796] For Qt,
 overwrite the plugin directories for the DRT to only those defined in
 QTWEBKIT_PLUGIN_PATH
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090715190745.49F47333F8F0@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32796: For Qt,overwrite the plugin directories for the DRT to only
those defined in QTWEBKIT_PLUGIN_PATH
https://bugs.webkit.org/attachment.cgi?id=32796&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I like the approach of the patch and think this will work, but a few problems:

> -PluginDatabase* PluginDatabase::installedPlugins()
> +PluginDatabase* PluginDatabase::installedPlugins(bool populate)

This reason for this populate arg should be documented in code as it is not
obvious.

> +void PluginDatabase::clear()
> +{
> +    m_plugins.clear();
> +    m_pluginsByPath.clear();
> +    m_registeredMIMETypes.clear();
> +}

Sure, but no deletion needed?

> +	   void setPluginDirectories(const Vector<String>& directories)
> +	   {
> +	       clear();
> +	       m_pluginDirectories = directories;
> +	   }

Looks suspect as you're changing the behavior of this method.  Where is this
method currently called from?  Any obvious side effects?
  
> +	   bool m_pluginSetChanged;

Adding a member variable that is never used or initialized?

> +void QWEBKIT_EXPORT qt_drt_overwritePluginDirectories()
> +{
> +    PluginDatabase *db = PluginDatabase::installedPlugins(/* populate */
false);

The decorator is in wrong place according to webkit coding style guidelines.

With these things fixed I think it'll be in good shape.

Cheers,
Adam

From bugzilla-daemon at webkit.org  Wed Jul 15 12:10:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:10:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27310] Incorrect animation
 when trying to duplicate effect of transform-origin : [Attachment 32799]
 Patch with test
In-Reply-To: <bug-27310-0@https.bugs.webkit.org/>
References: <bug-27310-0@https.bugs.webkit.org/>
Message-ID: <20090715191022.2FA02333F9E2@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 27310: Incorrect animation when trying to duplicate effect of
transform-origin
https://bugs.webkit.org/show_bug.cgi?id=27310

Attachment 32799: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32799&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 12:12:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:12:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27309] Local variable in
 instantiateV8Object shadows function parameter : [Attachment 32800] Patch2:
 modified the changelog
In-Reply-To: <bug-27309-0@https.bugs.webkit.org/>
References: <bug-27309-0@https.bugs.webkit.org/>
Message-ID: <20090715191207.8E658333FA81@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has asked  for review:
Bug 27309: Local variable in instantiateV8Object shadows function parameter
https://bugs.webkit.org/show_bug.cgi?id=27309

Attachment 32800: Patch2: modified the changelog
https://bugs.webkit.org/attachment.cgi?id=32800&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 12:14:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:14:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27310] Incorrect animation
 when trying to duplicate effect of transform-origin : [Attachment 32799]
 Patch with test
In-Reply-To: <bug-27310-0@https.bugs.webkit.org/>
References: <bug-27310-0@https.bugs.webkit.org/>
Message-ID: <20090715191400.5D4D2333FB58@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 27310: Incorrect animation when trying to duplicate effect of
transform-origin
https://bugs.webkit.org/show_bug.cgi?id=27310

Attachment 32799: Patch with test
https://bugs.webkit.org/attachment.cgi?id=32799&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45934)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,19 @@
> +2009-07-15  Chris Marrin  <cmarrin at apple.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27310

There's a new format being used here now. See earlier entries.

> +	   This fixes the bug by always doing component animation
> +	   as long as the function lists match. This allows CA
> +	   to animate the components and then recompose the result
> +	   into the correct matrix.

It would be nice to describe the bug that is being fixed here too.

> Index: LayoutTests/animations/transform-origin-vs-functions.html
> ===================================================================

> +	 //document.addEventListener('webkitAnimationStart', start, false);

You should remove that if it's not necessary.
r=me with those fixes.

From bugzilla-daemon at webkit.org  Wed Jul 15 12:14:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:14:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27309] Local variable in
 instantiateV8Object shadows function parameter : [Attachment 32800] Patch2:
 modified the changelog
In-Reply-To: <bug-27309-0@https.bugs.webkit.org/>
References: <bug-27309-0@https.bugs.webkit.org/>
Message-ID: <20090715191414.5B90E333FB70@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted James Hawkins
<jhawkins at google.com>'s request for review:
Bug 27309: Local variable in instantiateV8Object shadows function parameter
https://bugs.webkit.org/show_bug.cgi?id=27309

Attachment 32800: Patch2: modified the changelog
https://bugs.webkit.org/attachment.cgi?id=32800&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks!

From bugzilla-daemon at webkit.org  Wed Jul 15 12:15:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:15:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27311] [V8] Layout test
 failures for drawImage in Canvas : [Attachment 32801] patch
In-Reply-To: <bug-27311-0@https.bugs.webkit.org/>
References: <bug-27311-0@https.bugs.webkit.org/>
Message-ID: <20090715191536.1F214333FC19@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked David Levin <levin at chromium.org> for
review:
Bug 27311: [V8] Layout test failures for drawImage in Canvas
https://bugs.webkit.org/show_bug.cgi?id=27311

Attachment 32801: patch
https://bugs.webkit.org/attachment.cgi?id=32801&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 12:16:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 12:16:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27311] [V8] Layout test
 failures for drawImage in Canvas : [Attachment 32801] patch
In-Reply-To: <bug-27311-0@https.bugs.webkit.org/>
References: <bug-27311-0@https.bugs.webkit.org/>
Message-ID: <20090715191653.21117333FC91@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27311: [V8] Layout test failures for drawImage in Canvas
https://bugs.webkit.org/show_bug.cgi?id=27311

Attachment 32801: patch
https://bugs.webkit.org/attachment.cgi?id=32801&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 13:33:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 13:33:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27193] run-ins that don't
 run in don't become blocks : [Attachment 32802] Patch
In-Reply-To: <bug-27193-0@https.bugs.webkit.org/>
References: <bug-27193-0@https.bugs.webkit.org/>
Message-ID: <20090715203334.651EA3341805@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27193: run-ins that don't run in don't become blocks
https://bugs.webkit.org/show_bug.cgi?id=27193

Attachment 32802: Patch
https://bugs.webkit.org/attachment.cgi?id=32802&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 13:40:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 13:40:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27193] run-ins that don't run
 in don't become blocks : [Attachment 32802] Patch
In-Reply-To: <bug-27193-0@https.bugs.webkit.org/>
References: <bug-27193-0@https.bugs.webkit.org/>
Message-ID: <20090715204028.524CF3341A71@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Dave Hyatt
<hyatt at apple.com>'s request for review:
Bug 27193: run-ins that don't run in don't become blocks
https://bugs.webkit.org/show_bug.cgi?id=27193

Attachment 32802: Patch
https://bugs.webkit.org/attachment.cgi?id=32802&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -    RenderBlock* blockRunIn = toRenderBlock(child);
>      // Get the next non-positioned/non-floating RenderBlock.
> +    RenderBlock* blockRunIn = toRenderBlock(child);

This change doesn't really seem necessary, but I also hardly care about it at
all.


> +++ LayoutTests/fast/runin/generated.html	(working copy)
> @@ -9,5 +9,5 @@
>      Generated content with display: run-in causes a crash</i>.
>  </p>
>  <div id="target">
> -    &lt; this should say &ldquo;PASS&rdquo;
> +   <div> &lt; this should say &ldquo;PASS&rdquo;</div>
>  </div>

Is this still testing the thing that caused the crash before?

r=me

From bugzilla-daemon at webkit.org  Wed Jul 15 13:43:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 13:43:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32803] Propopsed patch, rev. 2
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090715204340.DC7183341BEA@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32803: Propopsed patch, rev. 2
https://bugs.webkit.org/attachment.cgi?id=32803&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
This patch include support for the valueMissing flag as well as new tests for
the ValidityState object.
Waiting for comments.

From bugzilla-daemon at webkit.org  Wed Jul 15 13:45:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 13:45:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 32804] Updated patch for generating
 WebKitVersion.h manually
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090715204550.6EAF53341CED@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked Simon Hausmann <hausmann at webkit.org>
for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32804: Updated patch for generating WebKitVersion.h manually
https://bugs.webkit.org/attachment.cgi?id=32804&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Updated re Simon's comments. Haven't touched anything in other ports - don't
have their build set up. Can certainly do gtk as a separate job of work though.


Have placed WebKitVersion.h in WebCore/platform/ .. couldn't think of a better
place. Also note that I use the Version.xcconfig in WebKit/mac/Configurations
as per Mark's advice. It appears that the 'second' occurence of the webkit
version number in the UA string is maintained internally by Safari, so standard
approach is just to reuse the same webkit version number in both positions.

From bugzilla-daemon at webkit.org  Wed Jul 15 13:51:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 13:51:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32803] Propopsed patch, rev. 2
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090715205152.A1B673341F57@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has canceled Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32803: Propopsed patch, rev. 2
https://bugs.webkit.org/attachment.cgi?id=32803&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
This patch lacks the support for ":required" and ":optional" CSS pseudoclasses,
I'm working to include it.

From bugzilla-daemon at webkit.org  Wed Jul 15 13:58:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 13:58:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 16401] [GTK] GObject/C DOM
 binding : [Attachment 32807] answering comments in #194 by sam
In-Reply-To: <bug-16401-0@https.bugs.webkit.org/>
References: <bug-16401-0@https.bugs.webkit.org/>
Message-ID: <20090715205836.075A933421FC@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 16401: [GTK] GObject/C DOM binding
https://bugs.webkit.org/show_bug.cgi?id=16401

Attachment 32807: answering comments in #194 by sam
https://bugs.webkit.org/attachment.cgi?id=32807&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
ok - sam, this is answering the question about why CustomGetter, CustomSetter
and Custom are used.  if you don't then there are three (that i could find,
through compile-errors) properties that have to be skipped; i just skip
anything of type "Event"; anything of type "Object" and
JavaScriptCallFrame.type.

i'm not sure of the wisdom of skipping everything of type "Event", it may be
wiser to skip only "DOMWindow.event" but i wanted to solicit your approval for
this technique of removing the references to CustomGetter, CustomSetter and
Custom in favour of very specific statements like this:

+	 # skip JavaScriptCallFrame.type
+	 if (($prop_name eq "type") && ($interfaceName eq
"JavaScriptCallFrame")){
+	     next SKIPPROP;
+	 }

there aren't tooooo many of these, as you can see, but it can also be seen that
they are, right now, entirely necessary.  and the patch size is kept down as a
result.

l.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:06:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:06:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 16401] [GTK] GObject/C DOM
 binding : [Attachment 32807] answering comments in #194 by sam
In-Reply-To: <bug-16401-0@https.bugs.webkit.org/>
References: <bug-16401-0@https.bugs.webkit.org/>
Message-ID: <20090715210651.41D7833424E1@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked Sam Weinig
<sam at webkit.org> for review:
Bug 16401: [GTK] GObject/C DOM binding
https://bugs.webkit.org/show_bug.cgi?id=16401

Attachment 32807: answering comments in #194 by sam
https://bugs.webkit.org/attachment.cgi?id=32807&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 14:10:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:10:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27317] [Chromium] Need to
 update DOM Storage files in the GYPI file : [Attachment 32809] v1
In-Reply-To: <bug-27317-0@https.bugs.webkit.org/>
References: <bug-27317-0@https.bugs.webkit.org/>
Message-ID: <20090715211049.6566B3342684@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27317: [Chromium] Need to update DOM Storage files in the GYPI file
https://bugs.webkit.org/show_bug.cgi?id=27317

Attachment 32809: v1
https://bugs.webkit.org/attachment.cgi?id=32809&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Need to update DOM Storage files in the GYPI file.  They're pretty out of date
and we're on the path towards enabling them for everyone!

From bugzilla-daemon at webkit.org  Wed Jul 15 14:12:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:12:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27317] [Chromium] Need to
 update DOM Storage files in the GYPI file : [Attachment 32809] v1
In-Reply-To: <bug-27317-0@https.bugs.webkit.org/>
References: <bug-27317-0@https.bugs.webkit.org/>
Message-ID: <20090715211207.E06D433426D4@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27317: [Chromium] Need to update DOM Storage files in the GYPI file
https://bugs.webkit.org/show_bug.cgi?id=27317

Attachment 32809: v1
https://bugs.webkit.org/attachment.cgi?id=32809&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:33:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:33:42 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25151] workers that fail to
 load scripts not firing error event : [Attachment 32749] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090715213342.A5A8F3342E91@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has canceled Jian Li <jianli at chromium.org>'s
request for review:
Bug 25151: workers that fail to load scripts not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32749: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32749&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Uploaded a new pacth per discussion with levin. Removed the handling of syntax
error in the script from this patch.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:33:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:33:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25151] workers that fail to
 load scripts not firing error event : [Attachment 32814] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090715213342.BE6E03342E95@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 25151: workers that fail to load scripts not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32814: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32814&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Uploaded a new pacth per discussion with levin. Removed the handling of syntax
error in the script from this patch.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:45:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:45:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26599] CSSHelper.h's
 parseURL is a function that no one should ever call : [Attachment 32729]
 patch for part 1
In-Reply-To: <bug-26599-0@https.bugs.webkit.org/>
References: <bug-26599-0@https.bugs.webkit.org/>
Message-ID: <20090715214552.1F972334322C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has canceled  review:
Bug 26599: CSSHelper.h's parseURL is a function that no one should ever call
https://bugs.webkit.org/show_bug.cgi?id=26599

Attachment 32729: patch for part 1
https://bugs.webkit.org/attachment.cgi?id=32729&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Landed this as http://trac.webkit.org/changeset/45946 and now clearing flag so
we can finish the rest of this.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:46:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:46:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27274] Add upstreamed V8
 bindings files into WebCore.gypi so they can be seen downstream :
 [Attachment 32810] Change to webcore.gypi so that the upstreamed files are
 visible to gyp in the chromium build downstream.
In-Reply-To: <bug-27274-0@https.bugs.webkit.org/>
References: <bug-27274-0@https.bugs.webkit.org/>
Message-ID: <20090715214652.C84EE334328B@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27274: Add upstreamed V8 bindings files into WebCore.gypi so they can be
seen downstream
https://bugs.webkit.org/show_bug.cgi?id=27274

Attachment 32810: Change to webcore.gypi so that the upstreamed files are
visible to gyp in the chromium build downstream.
https://bugs.webkit.org/attachment.cgi?id=32810&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 14:49:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:49:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27274] Add upstreamed V8
 bindings files into WebCore.gypi so they can be seen downstream :
 [Attachment 32810] Change to webcore.gypi so that the upstreamed files are
 visible to gyp in the chromium build downstream.
In-Reply-To: <bug-27274-0@https.bugs.webkit.org/>
References: <bug-27274-0@https.bugs.webkit.org/>
Message-ID: <20090715214938.9001A33433A0@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27274: Add upstreamed V8 bindings files into WebCore.gypi so they can be
seen downstream
https://bugs.webkit.org/show_bug.cgi?id=27274

Attachment 32810: Change to webcore.gypi so that the upstreamed files are
visible to gyp in the chromium build downstream.
https://bugs.webkit.org/attachment.cgi?id=32810&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 14:55:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:55:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25151] workers that fail to
 load scripts not firing error event : [Attachment 32814] Proposed Patch
In-Reply-To: <bug-25151-0@https.bugs.webkit.org/>
References: <bug-25151-0@https.bugs.webkit.org/>
Message-ID: <20090715215530.5FE6F334357B@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 25151: workers that fail to load scripts not firing error event
https://bugs.webkit.org/show_bug.cgi?id=25151

Attachment 32814: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32814&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Looks good.

Please file a bug about the error not being fired on WorkerContext when there
is a syntax error in the script.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:55:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:55:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27318] Allow LocalStorage
 to be enabled without enabling SessionStorage : [Attachment 32815] v1
In-Reply-To: <bug-27318-0@https.bugs.webkit.org/>
References: <bug-27318-0@https.bugs.webkit.org/>
Message-ID: <20090715215542.ECFF3334359E@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32815: v1
https://bugs.webkit.org/attachment.cgi?id=32815&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Allow LocalStorage to be enabled without enabling SessionStorage at runtime. 
There is a settings class setting for localStorage, but not for sessionStorage.
 We want to be able to test one of these features without necessarily enabling
the other.

From bugzilla-daemon at webkit.org  Wed Jul 15 14:59:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 14:59:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27316] [Qt] more than 100
 tests in Qt's DRT Skipped list works for me : [Attachment 32816] Remove
 tests from Qt Skipped list that are actually working.
In-Reply-To: <bug-27316-0@https.bugs.webkit.org/>
References: <bug-27316-0@https.bugs.webkit.org/>
Message-ID: <20090715215914.C751A33436B1@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked Adam
Treat <treat at kde.org> for review:
Bug 27316: [Qt] more than 100 tests in Qt's DRT Skipped list works for me
https://bugs.webkit.org/show_bug.cgi?id=27316

Attachment 32816: Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/attachment.cgi?id=32816&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 15:00:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 15:00:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26618] [Chromium] Gradient
 and pattern text failing on Chromium/Linux : [Attachment 32326] 3rd rev -
 setFillColor() unconditionally in rect border code,
 so shader is always reset
In-Reply-To: <bug-26618-0@https.bugs.webkit.org/>
References: <bug-26618-0@https.bugs.webkit.org/>
Message-ID: <20090715220033.3F1563343725@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 26618: [Chromium] Gradient and pattern text failing on Chromium/Linux
https://bugs.webkit.org/show_bug.cgi?id=26618

Attachment 32326: 3rd rev - setFillColor() unconditionally in rect border code,
so shader is always reset
https://bugs.webkit.org/attachment.cgi?id=32326&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 15:25:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 15:25:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27180] Cleanup DOM Storage
 dependencies. : [Attachment 32759] rev 3
In-Reply-To: <bug-27180-0@https.bugs.webkit.org/>
References: <bug-27180-0@https.bugs.webkit.org/>
Message-ID: <20090715222502.CCC593343EFB@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27180: Cleanup DOM Storage dependencies.
https://bugs.webkit.org/show_bug.cgi?id=27180

Attachment 32759: rev 3
https://bugs.webkit.org/attachment.cgi?id=32759&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 15 15:43:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 15:43:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27320] [WINCE] need to
 define _countof for WINCE5 : [Attachment 32817] patch to Platform.h
In-Reply-To: <bug-27320-0@https.bugs.webkit.org/>
References: <bug-27320-0@https.bugs.webkit.org/>
Message-ID: <20090715224304.1EB543344546@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27320: [WINCE] need to define _countof for WINCE5
https://bugs.webkit.org/show_bug.cgi?id=27320

Attachment 32817: patch to Platform.h
https://bugs.webkit.org/attachment.cgi?id=32817&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 15:45:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 15:45:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27320] [WINCE] need to define
 _countof for WINCE5 : [Attachment 32817] patch to Platform.h
In-Reply-To: <bug-27320-0@https.bugs.webkit.org/>
References: <bug-27320-0@https.bugs.webkit.org/>
Message-ID: <20090715224510.A61B533445DC@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27320: [WINCE] need to define _countof for WINCE5
https://bugs.webkit.org/show_bug.cgi?id=27320

Attachment 32817: patch to Platform.h
https://bugs.webkit.org/attachment.cgi?id=32817&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 15:51:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 15:51:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 21374] text-shadow is not
 drawn for text with transparent colour : [Attachment 32818] Make shadows
 independent of fill opacity
In-Reply-To: <bug-21374-0@https.bugs.webkit.org/>
References: <bug-21374-0@https.bugs.webkit.org/>
Message-ID: <20090715225123.8FC6A334479F@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 21374: text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374

Attachment 32818: Make shadows independent of fill opacity
https://bugs.webkit.org/attachment.cgi?id=32818&action=review

------- Additional Comments from mitz at webkit.org
One issue with this change is that it makes it impossible to have only the
outline of text cast a shadow (which is currently possible by specifying
-webkit-text-stroke: 1px black; color: transparent;).

From bugzilla-daemon at webkit.org  Wed Jul 15 16:04:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:04:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 21374] text-shadow is not
 drawn for text with transparent colour : [Attachment 32818] Make shadows
 independent of fill opacity
In-Reply-To: <bug-21374-0@https.bugs.webkit.org/>
References: <bug-21374-0@https.bugs.webkit.org/>
Message-ID: <20090715230424.071B83344BD3@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 21374: text-shadow is not drawn for text with transparent colour
https://bugs.webkit.org/show_bug.cgi?id=21374

Attachment 32818: Make shadows independent of fill opacity
https://bugs.webkit.org/attachment.cgi?id=32818&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 15 16:06:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:06:52 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27270] The WebFormDelegate
 -(BOOL)textField:shouldHandleEvent:inFrame is never called : [Attachment
 32734] Remove the uncalled declaration for windows as well.
In-Reply-To: <bug-27270-0@https.bugs.webkit.org/>
References: <bug-27270-0@https.bugs.webkit.org/>
Message-ID: <20090715230652.770653344C8B@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 27270: The WebFormDelegate -(BOOL)textField:shouldHandleEvent:inFrame is
never called
https://bugs.webkit.org/show_bug.cgi?id=27270

Attachment 32734: Remove the uncalled declaration for windows as well.
https://bugs.webkit.org/attachment.cgi?id=32734&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Wed Jul 15 16:10:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:10:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27037] Fix baselines for
 inline tables. : [Attachment 32388] patch
In-Reply-To: <bug-27037-0@https.bugs.webkit.org/>
References: <bug-27037-0@https.bugs.webkit.org/>
Message-ID: <20090715231057.0D65B3344DEE@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27037: Fix baselines for inline tables.
https://bugs.webkit.org/show_bug.cgi?id=27037

Attachment 32388: patch
https://bugs.webkit.org/attachment.cgi?id=32388&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Haven't heard much from the table folks.  But this looks sane to me.

Please fix your style error:
+int RenderTable::baselinePosition(bool firstLine, bool isRootLineBox) const {
+    if (firstBody() && style()->display() == INLINE_TABLE)

Make sure you've run the layout tests when landing.

From bugzilla-daemon at webkit.org  Wed Jul 15 16:14:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:14:28 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26915] HTML5: DOM binding of
 <datalist> element : [Attachment 32645] Proposed patch (rev.3)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090715231428.BE1463344F54@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32645: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=32645&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your ChangeLog is doubled.

Why is this right?
bool HTMLDataListElement::checkDTD(const Node* newChild)
 48 {
 49	return newChild->hasTagName(HTMLNames::optionTag) ||
HTMLElement::checkDTD(newChild);
 50 }

You should add a test to test the checkDTD code.  If you're trying to prevent
adding non-option elements then we need to test that?

Otherwise this looks fine.  r- since you're not a committer and this needs a
small update (and ideally another test).

From bugzilla-daemon at webkit.org  Wed Jul 15 16:17:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:17:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32369] Proposed patch (rev.3)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090715231709.7B027334503B@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32369: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=32369&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This looks fine to me.	Ideally Sam would comment before you land.  But I think
this is good to go as-is.

From bugzilla-daemon at webkit.org  Wed Jul 15 16:20:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:20:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 20348] Background color
 formatting lost on enter : [Attachment 32684] fixes the bug by making more
 CSS properties inheritable.
In-Reply-To: <bug-20348-0@https.bugs.webkit.org/>
References: <bug-20348-0@https.bugs.webkit.org/>
Message-ID: <20090715232049.AC19033451AC@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has canceled Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 20348: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Attachment 32684: fixes the bug by making more CSS properties inheritable.
https://bugs.webkit.org/attachment.cgi?id=32684&action=review

------- Additional Comments from Ryosuke Niwa <ryosuke.niwa at gmail.com>
This is the patch for (2).

From bugzilla-daemon at webkit.org  Wed Jul 15 16:20:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:20:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20348] Background color
 formatting lost on enter : [Attachment 32820] fixes the bug and renames
 copyInheritableProperties to copyPropertiesForEditing and removes
 removeComputedInheritablePropertiesFrom
In-Reply-To: <bug-20348-0@https.bugs.webkit.org/>
References: <bug-20348-0@https.bugs.webkit.org/>
Message-ID: <20090715232049.B9DBB33451AE@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 20348: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Attachment 32820: fixes the bug and renames copyInheritableProperties to
copyPropertiesForEditing and removes removeComputedInheritablePropertiesFrom
https://bugs.webkit.org/attachment.cgi?id=32820&action=review

------- Additional Comments from Ryosuke Niwa <ryosuke.niwa at gmail.com>
This is the patch for (2).

From bugzilla-daemon at webkit.org  Wed Jul 15 16:21:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:21:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26254] Setting white-space
 and word-wrap via CSS in textarea doesn't override the wrap attribute :
 [Attachment 31900] Patch v2
In-Reply-To: <bug-26254-0@https.bugs.webkit.org/>
References: <bug-26254-0@https.bugs.webkit.org/>
Message-ID: <20090715232105.A21DD33451DF@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 26254: Setting white-space and word-wrap via CSS in textarea doesn't
override the wrap attribute
https://bugs.webkit.org/show_bug.cgi?id=26254

Attachment 31900: Patch v2
https://bugs.webkit.org/attachment.cgi?id=31900&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'm rubber stamping basically.	I'll land this and indicate that it was
reviewed by eric at webkit.org

The only difference between the current patch and the one he r+'ed is that this
one has the image:
LayoutTests/platform/mac/fast/forms/basic-textareas-expected.png

From bugzilla-daemon at webkit.org  Wed Jul 15 16:30:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:30:34 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27270] The WebFormDelegate
 -(BOOL)textField:shouldHandleEvent:inFrame is never called : [Attachment
 32734] Remove the uncalled declaration for windows as well.
In-Reply-To: <bug-27270-0@https.bugs.webkit.org/>
References: <bug-27270-0@https.bugs.webkit.org/>
Message-ID: <20090715233034.410703345532@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27270: The WebFormDelegate -(BOOL)textField:shouldHandleEvent:inFrame is
never called
https://bugs.webkit.org/show_bug.cgi?id=27270

Attachment 32734: Remove the uncalled declaration for windows as well.
https://bugs.webkit.org/attachment.cgi?id=32734&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
No, this patch should not be landed yet as there are still unanswered
questions.

I'm clearing the review flag until Greg returns from vacation.

From bugzilla-daemon at webkit.org  Wed Jul 15 16:59:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 16:59:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 20348] Background color
 formatting lost on enter : [Attachment 32820] fixes the bug and renames
 copyInheritableProperties to copyPropertiesForEditing and removes
 removeComputedInheritablePropertiesFrom
In-Reply-To: <bug-20348-0@https.bugs.webkit.org/>
References: <bug-20348-0@https.bugs.webkit.org/>
Message-ID: <20090715235955.C2A443345FF0@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 20348: Background color formatting lost on enter
https://bugs.webkit.org/show_bug.cgi?id=20348

Attachment 32820: fixes the bug and renames copyInheritableProperties to
copyPropertiesForEditing and removes removeComputedInheritablePropertiesFrom
https://bugs.webkit.org/attachment.cgi?id=32820&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This name is not sufficiently clear:
+static const int propertiesForEditing[] = {

What are these actually used for?

Do we have tests for both of these?
     // Properties for editing
 1472	  CSSPropertyTextDecoration,
 1473	  CSSPropertyBackgroundColor,
14701474 };

It seems this could break the optimization in:
handleStyleSpansBeforeInsertion
(which may already be broken)

Seems uses of this function are inconsistent in their needs.  I think this is
just a bad function which dates from before time:
(I stopped digging after http://trac.webkit.org/changeset/7314)

I think we should just deprecate this function and make a new (somewhat copied)
one which works for your uses.	All the callers of this need to change, but I'm
not gonna ask you to do that.

From bugzilla-daemon at webkit.org  Wed Jul 15 17:29:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 17:29:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27322] Inspector: Create
 New DOM Storage Items via DataGrid : [Attachment 32821] Make DOM Storage
 DataGrid More Interactive
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090716002904.93E92334688B@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 32821: Make DOM Storage DataGrid More Interactive
https://bugs.webkit.org/attachment.cgi?id=32821&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
- Added a "CreationDataGridNode" type that can delete its special data and
transform back into a normal DataGridNode.
- Added a reference in the DataGrid to a CreationDataNode if one exists: @see
addCreationNode()
- Clicking anywhere in the excess space will select the bottom row (an existing
blank row)
- DOM Storage specific logic forces it to select the leftmost td (to set a Key)


I see a potential problem with sorting the GridData table.  However, sorting
wasn't working for me to begin with (was it ever working).  However, the
special CreationDataNode, if it exists, has this.isCreationNode and thus can
easily be sorted last.

From bugzilla-daemon at webkit.org  Wed Jul 15 17:47:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 17:47:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27324] Add ENABLE_RUBY to
 list of build options : [Attachment 32822] patch: add ENABLE_RUBY build
 option
In-Reply-To: <bug-27324-0@https.bugs.webkit.org/>
References: <bug-27324-0@https.bugs.webkit.org/>
Message-ID: <20090716004702.677AA3346DF0@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Attachment 32822: patch: add ENABLE_RUBY build option
https://bugs.webkit.org/attachment.cgi?id=32822&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Further outtake from larger ruby patch submitted to bug #3749, in order to
reduce patch sizes.

This patch only adds the build options, but no actual functionality.

From bugzilla-daemon at webkit.org  Wed Jul 15 17:51:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 17:51:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 3749] XHTML 1.1 Ruby
 Annotation : [Attachment 32654] patch: implementation of minimal HTML5 ruby
 support
In-Reply-To: <bug-3749-0@https.bugs.webkit.org/>
References: <bug-3749-0@https.bugs.webkit.org/>
Message-ID: <20090716005133.506423346EF0@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has canceled Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 3749: XHTML 1.1 Ruby  Annotation
https://bugs.webkit.org/show_bug.cgi?id=3749

Attachment 32654: patch: implementation of minimal HTML5 ruby support
https://bugs.webkit.org/attachment.cgi?id=32654&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
In order to further reduce patch sizes, I split out the build option from the
actual functionality.

Note that the patch in bug #32822 that adds ENABLE_RUBY must be used/committed
before this patch can be applied!

(Also removed the mentioned linting issues.)

From bugzilla-daemon at webkit.org  Wed Jul 15 17:51:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 17:51:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 3749] XHTML 1.1 Ruby
 Annotation : [Attachment 32823] patch: HTML5 ruby functionality only -
 requires patch in bug #32822 for build option
In-Reply-To: <bug-3749-0@https.bugs.webkit.org/>
References: <bug-3749-0@https.bugs.webkit.org/>
Message-ID: <20090716005133.611F13346EF2@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked Dave Hyatt
<hyatt at apple.com> for review:
Bug 3749: XHTML 1.1 Ruby  Annotation
https://bugs.webkit.org/show_bug.cgi?id=3749

Attachment 32823: patch: HTML5 ruby functionality only - requires patch in bug
#32822 for build option
https://bugs.webkit.org/attachment.cgi?id=32823&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
In order to further reduce patch sizes, I split out the build option from the
actual functionality.

Note that the patch in bug #32822 that adds ENABLE_RUBY must be used/committed
before this patch can be applied!

(Also removed the mentioned linting issues.)

From bugzilla-daemon at webkit.org  Wed Jul 15 18:14:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 18:14:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27324] Add ENABLE_RUBY to
 list of build options : [Attachment 32822] patch: add ENABLE_RUBY build
 option
In-Reply-To: <bug-27324-0@https.bugs.webkit.org/>
References: <bug-27324-0@https.bugs.webkit.org/>
Message-ID: <20090716011404.E47823347549@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has canceled Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Attachment 32822: patch: add ENABLE_RUBY build option
https://bugs.webkit.org/attachment.cgi?id=32822&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Upload correct file. :p

From bugzilla-daemon at webkit.org  Wed Jul 15 18:14:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 18:14:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27324] Add ENABLE_RUBY to
 list of build options : [Attachment 32824] patch: add ENABLE_RUBY build
 option
In-Reply-To: <bug-27324-0@https.bugs.webkit.org/>
References: <bug-27324-0@https.bugs.webkit.org/>
Message-ID: <20090716011404.E8CB2334754B@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Attachment 32824: patch: add ENABLE_RUBY build option
https://bugs.webkit.org/attachment.cgi?id=32824&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Upload correct file. :p

From bugzilla-daemon at webkit.org  Wed Jul 15 18:26:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 18:26:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27325]
 copyInheritableProperties and removeComputedInheritablePropertiesFrom
 should be deprecated : [Attachment 32825] removes
 removeComputedInheritablePropertiesFrom and renames
 copyInheritableProperties
In-Reply-To: <bug-27325-0@https.bugs.webkit.org/>
References: <bug-27325-0@https.bugs.webkit.org/>
Message-ID: <20090716012636.7EC5933478D9@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 27325: copyInheritableProperties and
removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325

Attachment 32825: removes removeComputedInheritablePropertiesFrom and renames
copyInheritableProperties
https://bugs.webkit.org/attachment.cgi?id=32825&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 18:50:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 18:50:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27325]
 copyInheritableProperties and removeComputedInheritablePropertiesFrom
 should be deprecated : [Attachment 32826] Deprecates
 copyInheritableProperties and removes
 removeComputedInheritablePropertiesFrom
In-Reply-To: <bug-27325-0@https.bugs.webkit.org/>
References: <bug-27325-0@https.bugs.webkit.org/>
Message-ID: <20090716015059.5CD113347F50@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 27325: copyInheritableProperties and
removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325

Attachment 32826: Deprecates copyInheritableProperties and removes
removeComputedInheritablePropertiesFrom
https://bugs.webkit.org/attachment.cgi?id=32826&action=review

------- Additional Comments from Ryosuke Niwa <ryosuke.niwa at gmail.com>
Added more detailed comments

From bugzilla-daemon at webkit.org  Wed Jul 15 18:50:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 18:50:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27325]
 copyInheritableProperties and removeComputedInheritablePropertiesFrom
 should be deprecated : [Attachment 32825] removes
 removeComputedInheritablePropertiesFrom and renames
 copyInheritableProperties
In-Reply-To: <bug-27325-0@https.bugs.webkit.org/>
References: <bug-27325-0@https.bugs.webkit.org/>
Message-ID: <20090716015059.570FF3347F4E@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has canceled Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 27325: copyInheritableProperties and
removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325

Attachment 32825: removes removeComputedInheritablePropertiesFrom and renames
copyInheritableProperties
https://bugs.webkit.org/attachment.cgi?id=32825&action=review

------- Additional Comments from Ryosuke Niwa <ryosuke.niwa at gmail.com>
Added more detailed comments

From bugzilla-daemon at webkit.org  Wed Jul 15 21:17:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 21:17:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27181] StorageArea should
 only contain methods we intend to proxy : [Attachment 32828] v1
In-Reply-To: <bug-27181-0@https.bugs.webkit.org/>
References: <bug-27181-0@https.bugs.webkit.org/>
Message-ID: <20090716041757.76523334A67A@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27181: StorageArea should only contain methods we intend to proxy
https://bugs.webkit.org/show_bug.cgi?id=27181

Attachment 32828: v1
https://bugs.webkit.org/attachment.cgi?id=32828&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
StorageArea should only contain methods we intend to proxy.
https://bugs.webkit.org/show_bug.cgi?id=27181

Right now, StorageAreaSync takes in a StorageArea* and calls methods
like importItem.  Really, StorageAreaSync should be operating directly
on StorageAreaImpl* and those methods should be removed from StorageArea
since StorageAreaSync should never be attached to anything other than a
StorageAreaImpl.
This was pointed out in the review for
https://bugs.webkit.org/show_bug.cgi?id=27072

Also clean up StorageNamespaceImpl to operate directly on
StorageAreaImpl.  Also, get rid of the factory for StorageArea
since nothing should ever create a StorageArea directly.

From bugzilla-daemon at webkit.org  Wed Jul 15 21:28:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 21:28:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14997] Support for
 server-sent DOM events : [Attachment 31160] updated patch
In-Reply-To: <bug-14997-0@https.bugs.webkit.org/>
References: <bug-14997-0@https.bugs.webkit.org/>
Message-ID: <20090716042807.51419334A93F@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Adam Bergkvist
<adam.bergkvist at ericsson.com>'s request for review:
Bug 14997: Support for server-sent DOM events
https://bugs.webkit.org/show_bug.cgi?id=14997

Attachment 31160: updated patch
https://bugs.webkit.org/attachment.cgi?id=31160&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>

> +static JSObject* constructEventSource(ExecState* exec, JSObject*
constructor, const ArgList& args)
> +{
> +    if (args.size() == 0)
> +	   return throwError(exec, SyntaxError, "Not enough arguments");

Out approach is ussually to just all the the toString conversion go to work on
the undefined value instead of checking the number of args here. Is this called
out for specifically in the spec?

One thing we should definitely look into doing is writing a fuzzer for this new
parser.  Otherwise, this looks great, thanks for keeping it up to date and
hanging in there for this ridiculous long time. r=me.

From bugzilla-daemon at webkit.org  Wed Jul 15 21:39:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 21:39:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27329] Inspector:
 Properties Should be Sorted more Naturally : [Attachment 32829] Sort
 Properties with the Alphanum Sort
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090716043940.3C0E2334AD06@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32829: Sort Properties with the Alphanum Sort
https://bugs.webkit.org/attachment.cgi?id=32829&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This algorithm is my own making based on my understanding of how the sort
should behave.	No copyright needed.

From bugzilla-daemon at webkit.org  Wed Jul 15 21:41:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 21:41:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27327] [Chromium] Clean up
 v8 bindings a bit : [Attachment 32831] v1
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716044158.089F0334ADB0@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32831: v1
https://bugs.webkit.org/attachment.cgi?id=32831&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
The DOMWindow::*Storage functions currently return 0 in some cases.  Currently,

the v8 bindings will just wrap the NULL/0 with a Storage object.  Given that 0
is returned when *Storage is "unavailable" it makes more sense to return
Undefined.

Pavel: Can you please look at the ScriptObjectQuarantine part, please?

From bugzilla-daemon at webkit.org  Wed Jul 15 21:50:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 21:50:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27241] bugzilla-tool
 post-commits silently fails with bad args : [Attachment 32833] Patch v1
In-Reply-To: <bug-27241-0@https.bugs.webkit.org/>
References: <bug-27241-0@https.bugs.webkit.org/>
Message-ID: <20090716045056.3C3B5334B071@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27241: bugzilla-tool post-commits silently fails with bad args
https://bugs.webkit.org/show_bug.cgi?id=27241

Attachment 32833: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32833&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 21:59:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 21:59:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27241] bugzilla-tool
 post-commits silently fails with bad args : [Attachment 32833] Patch v1
In-Reply-To: <bug-27241-0@https.bugs.webkit.org/>
References: <bug-27241-0@https.bugs.webkit.org/>
Message-ID: <20090716045929.23C4E334B2E0@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27241: bugzilla-tool post-commits silently fails with bad args
https://bugs.webkit.org/show_bug.cgi?id=27241

Attachment 32833: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32833&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You could probably re-use the self.argnames string (or wahtever it's called). 
Instead of re-typing "COMMITTISH".  

I probably woudl have written "'%s' is not a COMMITISH" as "unable to parse
commit is from %s".

What you have is fine.	Or with one or more of the modifications suggested
above.

Thanks!

From bugzilla-daemon at webkit.org  Wed Jul 15 22:00:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 22:00:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27318] Allow LocalStorage to
 be enabled without enabling SessionStorage : [Attachment 32815] v1
In-Reply-To: <bug-27318-0@https.bugs.webkit.org/>
References: <bug-27318-0@https.bugs.webkit.org/>
Message-ID: <20090716050051.DFE5C334B34B@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32815: v1
https://bugs.webkit.org/attachment.cgi?id=32815&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/page/DOMWindow.cpp
> ===================================================================
> --- WebCore/page/DOMWindow.cpp	(revision 45916)
> +++ WebCore/page/DOMWindow.cpp	(working copy)
> @@ -552,6 +552,9 @@ Storage* DOMWindow::sessionStorage() con
>	   return 0;
>  
>      Document* document = m_frame->document();
> +    Settings* settings = document->settings();
> +    if (!settings || !settings->sessionStorageEnabled())

You should just use page->settings() here which cannot be null.

Otherwise, looks good to me.

From bugzilla-daemon at webkit.org  Wed Jul 15 22:32:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 22:32:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26915] HTML5: DOM binding
 of <datalist> element : [Attachment 32835] Proposed patch (rev.4)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090716053222.4AF36334BB1B@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32835: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=32835&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
- Updated ChangeLog
- Changed checkDTD()
- Added another test

From bugzilla-daemon at webkit.org  Wed Jul 15 23:07:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 23:07:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27331] Add tests for
 isolated worlds : [Attachment 32836] patch
In-Reply-To: <bug-27331-0@https.bugs.webkit.org/>
References: <bug-27331-0@https.bugs.webkit.org/>
Message-ID: <20090716060701.9862E334C688@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27331: Add tests for isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27331

Attachment 32836: patch
https://bugs.webkit.org/attachment.cgi?id=32836&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 23:11:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 23:11:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27331] Add tests for isolated
 worlds : [Attachment 32836] patch
In-Reply-To: <bug-27331-0@https.bugs.webkit.org/>
References: <bug-27331-0@https.bugs.webkit.org/>
Message-ID: <20090716061134.25814334C7DA@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27331: Add tests for isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27331

Attachment 32836: patch
https://bugs.webkit.org/attachment.cgi?id=32836&action=review

From bugzilla-daemon at webkit.org  Wed Jul 15 23:29:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 23:29:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27327] [Chromium] Clean up
 v8 bindings a bit : [Attachment 32831] v1
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716062953.24CA1334CDE2@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has canceled Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32831: v1
https://bugs.webkit.org/attachment.cgi?id=32831&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Made the change Mads pointed out.

From bugzilla-daemon at webkit.org  Wed Jul 15 23:29:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 23:29:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27327] [Chromium] Clean up
 v8 bindings a bit : [Attachment 32837] v2
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716062953.33359334CDE4@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32837: v2
https://bugs.webkit.org/attachment.cgi?id=32837&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Made the change Mads pointed out.

From bugzilla-daemon at webkit.org  Wed Jul 15 23:31:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 23:31:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27276] Some constructor
 objects exposed on Window have the wrong prototype chain : [Attachment
 32739] patch
In-Reply-To: <bug-27276-0@https.bugs.webkit.org/>
References: <bug-27276-0@https.bugs.webkit.org/>
Message-ID: <20090716063138.5D7F6334CE7A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27276: Some constructor objects exposed on Window have the wrong prototype
chain
https://bugs.webkit.org/show_bug.cgi?id=27276

Attachment 32739: patch
https://bugs.webkit.org/attachment.cgi?id=32739&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great!  A few nits below.

> +for (property in window) {
> +    windowProperites.push(property);
> +}

No braces here.

I'm surprised we don't see a lot of junk from the testing code.  Maybe it's
better to enumerate the subframe's properties?

> +for (var x = 0; x < windowProperites.length; x++) {

Preincrement.

>  JSAudioConstructor::JSAudioConstructor(ExecState* exec, JSDOMGlobalObject*
globalObject)
> -    :
DOMObject(JSAudioConstructor::createStructure(exec->lexicalGlobalObject()->obje
ctPrototype()))
> -    , m_globalObject(globalObject)
> +    :
DOMObject(JSAudioConstructor::createStructure(globalObject->objectPrototype()))

> +	  , m_globalObject(globalObject)

Extra space added here.

> -JSXSLTProcessorConstructor::JSXSLTProcessorConstructor(ExecState* exec)
> -    :
DOMObject(JSXSLTProcessorConstructor::createStructure(exec->lexicalGlobalObject
()->objectPrototype()))
> +JSXSLTProcessorConstructor::JSXSLTProcessorConstructor(ExecState* exec,
JSDOMGlobalObject* globalObject)
> +    :
DOMObject(JSXSLTProcessorConstructor::createStructure(globalObject->objectProto
type()))
>  {
> -    putDirect(exec->propertyNames().prototype,
JSXSLTProcessorPrototype::self(exec, exec->lexicalGlobalObject()), None);
> +    putDirect(exec->propertyNames().prototype,
JSXSLTProcessorPrototype::self(exec, globalObject), None);
> +    putDirect(exec->propertyNames().length, jsNumber(exec, 1),
ReadOnly|DontDelete|DontEnum);

Where did this length line come from?

From bugzilla-daemon at webkit.org  Wed Jul 15 23:51:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 15 Jul 2009 23:51:11 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26749] Update expected image
 for Bug 26426 : [Attachment 31904] Patch v1
In-Reply-To: <bug-26749-0@https.bugs.webkit.org/>
References: <bug-26749-0@https.bugs.webkit.org/>
Message-ID: <20090716065111.EA896334D40B@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 26749: Update expected image for Bug 26426
https://bugs.webkit.org/show_bug.cgi?id=26749

Attachment 31904: Patch v1
https://bugs.webkit.org/attachment.cgi?id=31904&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
I'm not sure what you're trying to fix here.  If this patch is correct you
should just be doing 1<<22, but like i said i'm not sure what you're actually
trying to do.

From bugzilla-daemon at webkit.org  Thu Jul 16 00:00:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:00:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27328]
 WebKitTools/Scripts/svn-create-patch is broken : [Attachment 32838] Fix for
 Unusual Perl Behavior
In-Reply-To: <bug-27328-0@https.bugs.webkit.org/>
References: <bug-27328-0@https.bugs.webkit.org/>
Message-ID: <20090716070026.6400B334D6D9@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27328: WebKitTools/Scripts/svn-create-patch is broken
https://bugs.webkit.org/show_bug.cgi?id=27328

Attachment 32838: Fix for Unusual Perl Behavior
https://bugs.webkit.org/attachment.cgi?id=32838&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Perl seems to have been acting differently on our machines.  This handles the
special case that was acting differently.  Its been tested on Jeremy Orlow's
system (thanks for taking the time!) and worked.

From bugzilla-daemon at webkit.org  Thu Jul 16 00:02:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:02:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 20578] [CAIRO] pattern of a
 canvas-element changes after modifications on canvas-element : [Attachment
 32550] Patch v4
In-Reply-To: <bug-20578-0@https.bugs.webkit.org/>
References: <bug-20578-0@https.bugs.webkit.org/>
Message-ID: <20090716070257.0E0A7334D7C0@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 20578: [CAIRO] pattern of a canvas-element changes after modifications on
canvas-element
https://bugs.webkit.org/show_bug.cgi?id=20578

Attachment 32550: Patch v4
https://bugs.webkit.org/attachment.cgi?id=32550&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 00:03:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:03:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27316] [Qt] more than 100
 tests in Qt's DRT Skipped list works for me : [Attachment 32816] Remove
 tests from Qt Skipped list that are actually working.
In-Reply-To: <bug-27316-0@https.bugs.webkit.org/>
References: <bug-27316-0@https.bugs.webkit.org/>
Message-ID: <20090716070337.9758F334D7FD@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27316: [Qt] more than 100 tests in Qt's DRT Skipped list works for me
https://bugs.webkit.org/show_bug.cgi?id=27316

Attachment 32816: Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/attachment.cgi?id=32816&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 00:06:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:06:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27333] cpplint should check
 for equality comparisons to 0/true/false : [Attachment 32839] Proposed fix.
In-Reply-To: <bug-27333-0@https.bugs.webkit.org/>
References: <bug-27333-0@https.bugs.webkit.org/>
Message-ID: <20090716070609.78337334D8C0@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27333: cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

Attachment 32839: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32839&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 00:08:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:08:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32232] Patch to add EditorClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090716070807.000BA334D958@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32232: Patch to add EditorClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32232&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 00:08:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:08:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32230] Patch to add ContextMenuClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090716070834.A2EB6334D98A@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32230: Patch to add ContextMenuClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32230&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 00:09:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:09:36 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26952] WebCore Support for the
 Haiku WebKit port : [Attachment 32229] Patch to add ChromeClient for Haiku
 WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090716070936.B9CE3334D9E0@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32229: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32229&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
addMessageToConsole and canRunBeforeUnloadConfirmPanel definitions are not
correctly indented

From bugzilla-daemon at webkit.org  Thu Jul 16 00:22:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:22:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27334] prepare-ChangeLog
 should display the --bug option in its help text. : [Attachment 32840]
 Proposed fix.
In-Reply-To: <bug-27334-0@https.bugs.webkit.org/>
References: <bug-27334-0@https.bugs.webkit.org/>
Message-ID: <20090716072236.8C988334DD76@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27334: prepare-ChangeLog should display the --bug option in its help text.
https://bugs.webkit.org/show_bug.cgi?id=27334

Attachment 32840: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32840&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 00:23:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:23:41 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32300] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716072341.B89E0334DDEB@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32300: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32300&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +// extensions beyond IE's API
> +HashSet<String> ClipboardHaiku::types() const 
> +{
> +    HashSet<String> result;
> +    BMessage *data;
> +
> +    if (be_clipboard->Lock()) {
> +	   if ((data = be_clipboard->Data())) {
> +	       char *name;
> +	       uint32 type;
> +	       int32 count;
> +
> +	       for (int32 i = 0;
> +		    data->GetInfo(B_ANY_TYPE, i, &name, &type, &count) == B_OK;

> +		    i++) {
> +		   result.add(name);
> +	       } 

This should be two lines:
	       for (int32 i = 0; data->GetInfo(B_ANY_TYPE, i, &name, &type,
&count) == B_OK; i++)
		   result.add(name);

> +bool ClipboardHaiku::hasData() 
> +{
> +    bool result = false;
> +    BMessage *data;
> +
> +    if (be_clipboard->Lock()) {
> +	   if ((data = be_clipboard->Data())) {
> +	       result = !data->IsEmpty();
> +	   }
This if-statement has a single line of code so should not have braces

Rest of the patch looks fine, but it's easier for us to do landing if we have a
set of correct patches to land

From bugzilla-daemon at webkit.org  Thu Jul 16 00:26:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:26:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32301] Patch to add a second bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716072602.75432334DE8A@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32301: Patch to add a second bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32301&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
looks fine

From bugzilla-daemon at webkit.org  Thu Jul 16 00:28:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:28:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32302] Patch to add a third bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716072826.5EE5E334DF3E@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32302: Patch to add a third bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32302&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
looks fine

From bugzilla-daemon at webkit.org  Thu Jul 16 00:36:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:36:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32303] Patch to add a fourth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716073651.22ACC334E1AC@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32303: Patch to add a fourth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32303&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +void Pasteboard::writeSelection(Range* selectedRange, bool
canSmartCopyOrDelete, Frame* frame)
> +{
> +    BMessage* data;
> +
> +    if (be_clipboard->Lock()) {
> +	   be_clipboard->Clear();
> +	   if ((data = be_clipboard->Data())) {
> +	       data->AddString("text/plain", BString(frame->selectedText()));
> +	       be_clipboard->Commit();
> +	   }
> +	   be_clipboard->Unlock();
> +    }
> +}

You'll want a bug to track supporting pasting of rich text.  Also i'm concerned
about where be_clipboard comes from?  If it's the global pasteboard in haiku
you don't want to use it here

> +String Pasteboard::plainText(Frame* frame)
> +{
> +    BString string;
> +    BMessage* data;
> +
> +    if (be_clipboard->Lock()) {
> +	   if ((data = be_clipboard->Data())) {
> +	       data->FindString("text/plain", &string);
> +	   }
No braces on a single line if statement

From bugzilla-daemon at webkit.org  Thu Jul 16 00:43:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:43:56 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32304] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716074356.3D55D334E3E4@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32304: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32304&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +
> +void ScrollViewCanvasHaiku::Draw(BRect updateRect)
> +{
> +    FrameView* fv = static_cast<FrameView*>(m_scrollView);
> +    if (!fv || !fv->frame() || !fv->frame()->contentRenderer())
> +	   return;
> +
> +    while (fv->needsLayout()) {
> +	   fv->layout();
> +    }
Single line code block should not have braces :D

> +void ScrollViewCanvasHaiku::KeyDown(const char* bytes, int32 numBytes)
> +{
> +    BMessage* message = Looper()->CurrentMessage();
> +    if (!message)
> +	   return;
> +
> +    WebCore::FrameView* fv = static_cast<WebCore::FrameView*>(m_scrollView);

> +    if (!fv || !fv->frame())
> +	return;
> +
> +   
if(!fv->frame()->eventHandler()->keyEvent(PlatformKeyboardEvent(message)))
> +	printf("-->KeyDown: not arrived\n");	
> +
> +    if((int)bytes[0] != (int)B_TAB)
> +	   BView::KeyDown(bytes, numBytes);

We use c++ casts for all casts in webkit -- eg. static_cast

> +}
> +
> +void ScrollViewCanvasHaiku::KeyUp(const char* bytes, int32 numBytes)
> +{
> +    BMessage* message = Looper()->CurrentMessage();
> +    if (!message)
> +	   return;
> +
> +    WebCore::FrameView* fv = static_cast<WebCore::FrameView*>(m_scrollView);

> +    if (!fv || !fv->frame())
> +	return;
> +
> +   
if(fv->frame()->eventHandler()->keyEvent(PlatformKeyboardEvent(message)))
> +	printf("-->KeyUp: not arrived\n"); 
> +
> +    if(bytes[0] != (int)B_TAB)
ditto

Basically looks fine except the aforementioned style issues

From bugzilla-daemon at webkit.org  Thu Jul 16 00:49:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:49:50 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32307] Patch to add a fifth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716074950.04918334E5EF@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32307: Patch to add a fifth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32307&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +// This might be useful, but it not used for now
> +/*
> +static BView* haikuWidgetForPage(const Page* page)
> +{
> +    Frame* frame = (page ? page->mainFrame() : 0);
> +    FrameView* frameView = (frame ? frame->view() : 0);
> +
> +    if (!frameView)
> +	   return 0;
> +
> +    return frameView->haikuWidget();
> +}*/

We don't include commented out code in the tree


> +int screenDepth(Widget*)
> +{
> +    BScreen screen;
> +    // FIXME: We assume this screen is valid
> +    color_space cs = screen.ColorSpace();
> +
> +    size_t pixelChunk, rowAlignment, pixelsPerChunk;
> +    if (get_pixel_size_for(cs, &pixelChunk, &rowAlignment, &pixelsPerChunk)
== B_OK) {
> +	   // FIXME: Not sure if this is right
> +	   return pixelChunk * 8;
> +    }
Single line block shouldn't have braces

> +void SharedTimerHaiku::setFireTime(double fireTime)
> +{
> +    m_fireTime = fireTime;
> +    if (m_fireTime > 0 && m_shouldRun) {
> +	   bigtime_t sleepyTime = (bigtime_t)((m_fireTime - WTF::currentTime())
* 1000000);
You should be using a c++ style cast

> +	   
> +	   if(sleepyTime < 0)
space between if and (

> +// WebCore functions
> +void setSharedTimerFiredFunction(void (*function)())
> +{
> +    SharedTimerHaiku* timer=getSharedTimerHaiku();
Need spaces around =

> +namespace WebCore {
> +    class SharedTimerHaiku : public BMessageFilter {
> +	   public:
> +	       SharedTimerHaiku();
> +	       ~SharedTimerHaiku();
> +
> +	       void setFireTime(double fireTime);
> +	       void setFireFunction(void (*function)());
> +	       void setShouldRun(bool shouldRun);
> +
> +	       //void  MessageReceived(BMessage* message);
> +	       virtual filter_result Filter(BMessage* message, BHandler**
_target);
> +
> +	   private:
> +	       //void wait();
> +	       //static int32 threadFunction(void *data);
> +
> +	       //thread_id m_thread;
> +	       //sem_id m_waitSem;
Don't included commented out members, you should file a bug on resurrecting
these

From bugzilla-daemon at webkit.org  Thu Jul 16 00:50:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:50:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27334] prepare-ChangeLog
 should display the --bug option in its help text. : [Attachment 32840]
 Proposed fix.
In-Reply-To: <bug-27334-0@https.bugs.webkit.org/>
References: <bug-27334-0@https.bugs.webkit.org/>
Message-ID: <20090716075031.C35D6334E62A@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 27334: prepare-ChangeLog should display the --bug option in its help text.
https://bugs.webkit.org/show_bug.cgi?id=27334

Attachment 32840: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32840&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 00:53:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:53:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32308] Patch to add a sixth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716075347.F332D334E76B@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32308: Patch to add a sixth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32308&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +double currentTime()
> +{
> +    struct timeval tv;
> +    struct timezone tz;
> +
> +    gettimeofday(&tv, &tz);
> +    return (double)tv.tv_sec + (double)(tv.tv_usec / 1000000.0);
Once again c++ style casts please :D

> +TranslatorDecoder::TranslatorDecoder()
> +{
> +    m_image = 0;
> +    setSize(-1,-1);
> +}
space after the ,

> +
> +bool TranslatorDecoder::isSizeAvailable() const
> +{
> +    return !(size() == IntSize(-1, -1));
> +}
Does != really not work here?

> +void TranslatorDecoder::setData(SharedBuffer* data, bool allDataReceived) 
> +{ 
> +    if(allDataReceived) {
> +	   BMemoryIO io(data->data(),data->size());
> +	   m_image = BTranslationUtils::GetBitmap(&io);
> +	   if (m_image) {
> +	       //set the image size decoded.
> +	       setSize(m_image->Bounds().Width() + 1,
m_image->Bounds().Height() + 1);
> +	   }   
Should not have braces around a single line if :D

> +void Widget::setFrameRect(const IntRect& rect)
> +{
> +    if (!platformWidget())
> +	   return;
> +
> +    if (frameRect() != rect){
Space before {

From bugzilla-daemon at webkit.org  Thu Jul 16 00:55:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 00:55:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32364] Patch to add Haiku-specific files
 for WebCore/platform/image-decoders/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716075511.59E12334E803@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32364: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32364&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 01:03:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:03:54 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32371] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716080354.ABCBE334EA75@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32371: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32371&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> +// Fix temp routine to check the conversion works, please move it ASAP      

> +int charUnicodeToUtf8(unsigned short glyph, char* out)
> +{
> +    int i = 0;
> +
> +    if (glyph < 0x0080)
> +	   out[i++] = (char)glyph;
C++ style casts please :D

> +    else if (glyph < 0x0800) { //two bytes
> +	   out[i++] = 0xc0 | (( glyph ) >> 6 );
> +	   out[i++] = 0x80 | (( glyph ) & 0x3F );
> +    } else if (glyph > 0x0800) { //3 bytes
> +	   out[i++] = 0xe0 | (( glyph ) >> 12 );
> +	   out[i++] = 0x80 | ( (( glyph ) >> 6 ) & 0x3F );
> +	   out[i++] = 0x80 | (( glyph ) & 0x3F);
> +    }
Should have excess braces, eg.
out[i++] = 0x80 | ( (( glyph ) >> 6 ) & 0x3F ); => out[i++] = 0x80 | ((glyph >>
6 ) & 0x3F );
Shouldn't have spaces around the content of parenthesis, eg.
out[i++] = 0x80 | ( (( glyph ) >> 6 ) & 0x3F ); => out[i++] = 0x80 | ((glyph >>
6) & 0x3F);


> +FontPlatformData::FontPlatformData(const FontDescription& fontDescription,
const AtomicString& familyName)
> +    : m_font(0)
> +{
> +    bool bFound = false;
> +    bool bItalic = fontDescription.italic();
> +    bool bBold = fontDescription.weight() == FontWeightBold;
> +    font_family family;
> +
> +    for (int i = 0; i < count_font_families(); i++) {
> +	   get_font_family(i, &family, 0);
> +	   if (!BString(familyName.string()).Compare(family)) {
> +	       m_font = new BFont();
> +	       m_font->SetFamilyAndStyle(family, 0);
> +	       m_font->SetSize(fontDescription.computedSize());
> +
> +	       bFound = true;
> +	       break;
> +	   }
> +    }
> +
> +    if (bFound) {
> +	   int32 numStyles = count_font_styles(family);
> +	   font_style fontStyle;
> +	   uint32 flags;
> +	   bFound = false;
> +
> +	   for (int i = 0; i < numStyles; i++) {
> +	       if (get_font_style(family, i, &fontStyle, &flags) == B_OK) {
> +		   String style(fontStyle);
> +		   if ((bItalic && bBold)
> +		       && (style == "BoldItalic" || style == "Bold Oblique")) {

There's no reason for this line break, we don't have an 80-cloumn limit in our
style guidelines :D

> +			bFound = true;
> +			break;
> +		    }
> +		   if ((bItalic && !bBold)
> +		       && (style == "Italic" || style == "Oblique")) {
ditto

...
> +		    }
> +		   if ((!bItalic && !bBold)
> +		       && (style == "Roma"
> +			   || style == "Book" || style == "Condensed"
> +			   || style == "Regular" || style == "Medium")) {
You may want multiple lines here for clarity, but 4 lines seems excessive

From bugzilla-daemon at webkit.org  Thu Jul 16 01:08:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:08:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27335] [V8]
 V8IsolatedWorld::evaluate needs to call didCreateIsolatedScriptContext :
 [Attachment 32841] patch
In-Reply-To: <bug-27335-0@https.bugs.webkit.org/>
References: <bug-27335-0@https.bugs.webkit.org/>
Message-ID: <20090716080832.E0F73334EC03@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27335: [V8] V8IsolatedWorld::evaluate needs to call
didCreateIsolatedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=27335

Attachment 32841: patch
https://bugs.webkit.org/attachment.cgi?id=32841&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 01:21:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:21:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27336] Allow custom memory
 allocation control in JavaScriptCore's CodeBlock.h : [Attachment 32842]
 proposed patch
In-Reply-To: <bug-27336-0@https.bugs.webkit.org/>
References: <bug-27336-0@https.bugs.webkit.org/>
Message-ID: <20090716082121.2F9F3334F06D@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27336: Allow custom memory allocation control in JavaScriptCore's
CodeBlock.h
https://bugs.webkit.org/show_bug.cgi?id=27336

Attachment 32842: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32842&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 01:26:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:26:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27329] Inspector: Properties
 Should be Sorted more Naturally : [Attachment 32829] Sort Properties with
 the Alphanum Sort
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090716082647.529C9334F2AC@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32829: Sort Properties with the Alphanum Sort
https://bugs.webkit.org/attachment.cgi?id=32829&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45964)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,13 @@
> +2009-07-15  Joseph Pecoraro	<joepeck02 at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Inspector: Properties Should be Sorted more Naturally
> +	   https://bugs.webkit.org/show_bug.cgi?id=27329
> +
> +	   * inspector/front-end/utilities.js:
> +	   (Object.sortedProperties): added alphaNumSort sorting function
> +
>  2009-07-15  Adam Langley  <agl at google.com>
>  
>	   No review: reverting previous change.
> Index: WebCore/inspector/front-end/utilities.js
> ===================================================================
> --- WebCore/inspector/front-end/utilities.js	(revision 45963)
> +++ WebCore/inspector/front-end/utilities.js	(working copy)
> @@ -1,5 +1,5 @@
>  /*
> - * Copyright (C) 2007 Apple Inc.  All rights reserved.
> + * Copyright (C) 2007, 2009 Apple Inc.  All rights reserved.
>   *
>   * Redistribution and use in source and binary forms, with or without
>   * modification, are permitted provided that the following conditions
> @@ -96,10 +96,43 @@ Object.describe = function(obj, abbrevia
>  
>  Object.sortedProperties = function(obj)
>  {
> +
> +    function alphaNumSort(a,b) {
> +	   a = a.toString();
> +	   b = b.toString();
In our usage alphaNumSort is always passed strings so these toString calls are
unnecessary, and are definitely not free, so you shouldn't have them

> +	   if (a===b)
should have spaces around ===

> +	       return 0;
> +
> +	   var diff = 0;
> +	   var chunk = /^\d+|^\D+/;
> +	   var chunka, chunkb, anum, bnum;
> +	   while (diff === 0) {
> +	       if (!a && b)
> +		   return -1;
> +	       if (!b && a)
> +		   return 1;
> +	       chunka = a.match(chunk)[0];
> +	       chunkb = b.match(chunk)[0];
> +	       anum = +chunka+1; // quick falsey check if its a number
> +	       bnum = +chunkb+1; // quick falsey check if its a number
This seems unnecessarily complex -- why "+1" ?	aside from that the second +
should have spaces on either side.

> +	       if (anum && !bnum)
> +		   return -1;
> +	       if (bnum && !anum)
> +		   return 1;
> +	       if (anum && bnum)
> +		   diff = chunka - chunkb;
> +	       else if (chunka !== chunkb)
> +		   return (chunka<chunkb) ? -1 : 1;
Should have spaces around <

> +	       a = a.substring(chunka.length);
> +	       b = b.substring(chunkb.length);
> +	   }
> +	   return diff;
> +    }
> +    

Otherwise this basically seems fine, just needs my comments addressed

From bugzilla-daemon at webkit.org  Thu Jul 16 01:28:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:28:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27333] cpplint should check
 for equality comparisons to 0/true/false : [Attachment 32839] Proposed fix.
In-Reply-To: <bug-27333-0@https.bugs.webkit.org/>
References: <bug-27333-0@https.bugs.webkit.org/>
Message-ID: <20090716082808.74117334F328@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27333: cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

Attachment 32839: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32839&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 01:28:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:28:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27337] Add a getter in
 MessagePortChannel for the PlatformMessagePortChannel : [Attachment 32843]
 Proposed patch
In-Reply-To: <bug-27337-0@https.bugs.webkit.org/>
References: <bug-27337-0@https.bugs.webkit.org/>
Message-ID: <20090716082827.8232D334F358@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27337: Add a getter in MessagePortChannel for the
PlatformMessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=27337

Attachment 32843: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32843&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 01:32:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:32:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27336] Allow custom memory
 allocation control in JavaScriptCore's CodeBlock.h : [Attachment 32842]
 proposed patch
In-Reply-To: <bug-27336-0@https.bugs.webkit.org/>
References: <bug-27336-0@https.bugs.webkit.org/>
Message-ID: <20090716083218.74652334F47D@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27336: Allow custom memory allocation control in JavaScriptCore's
CodeBlock.h
https://bugs.webkit.org/show_bug.cgi?id=27336

Attachment 32842: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32842&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 01:40:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:40:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27338] Allow custom memory
 allocation control in NewThreadContext struct : [Attachment 32844] proposed
 patch
In-Reply-To: <bug-27338-0@https.bugs.webkit.org/>
References: <bug-27338-0@https.bugs.webkit.org/>
Message-ID: <20090716084044.AAC3F334F722@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27338: Allow custom memory allocation control in NewThreadContext struct
https://bugs.webkit.org/show_bug.cgi?id=27338

Attachment 32844: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32844&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 01:46:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 01:46:52 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27337] Add a getter in
 MessagePortChannel for the PlatformMessagePortChannel : [Attachment 32843]
 Proposed patch
In-Reply-To: <bug-27337-0@https.bugs.webkit.org/>
References: <bug-27337-0@https.bugs.webkit.org/>
Message-ID: <20090716084652.68077334F8D3@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27337: Add a getter in MessagePortChannel for the
PlatformMessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=27337

Attachment 32843: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=32843&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It would be nice to mention in the bug why this is useful.

> Index: WebCore/dom/MessagePortChannel.h
> +	   // Getter for m_channel.

I'd remove this comment as it doesn't really seem to add any information.

> +	   PassRefPtr<PlatformMessagePortChannel> channel();

Since this method isn't really passing the ref count to the caller (it retains
the ref counted pointer), just return PlatformMessagePortChannel* (instead of a
PassRefPtr).

Also, why not just define this inline?
     return m_channel.get();

From bugzilla-daemon at webkit.org  Thu Jul 16 02:02:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 02:02:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27338] Allow custom memory
 allocation control in NewThreadContext struct : [Attachment 32845] updated
 proposed patch
In-Reply-To: <bug-27338-0@https.bugs.webkit.org/>
References: <bug-27338-0@https.bugs.webkit.org/>
Message-ID: <20090716090259.11875334FE42@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27338: Allow custom memory allocation control in NewThreadContext struct
https://bugs.webkit.org/show_bug.cgi?id=27338

Attachment 32845: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=32845&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 02:02:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 02:02:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27338] Allow custom memory
 allocation control in NewThreadContext struct : [Attachment 32844] proposed
 patch
In-Reply-To: <bug-27338-0@https.bugs.webkit.org/>
References: <bug-27338-0@https.bugs.webkit.org/>
Message-ID: <20090716090258.E80D1334FE3D@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has canceled Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27338: Allow custom memory allocation control in NewThreadContext struct
https://bugs.webkit.org/show_bug.cgi?id=27338

Attachment 32844: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32844&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 02:24:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 02:24:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32846] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716092447.D53A43350522@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32846: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32846&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 02:34:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 02:34:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32847] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090716093458.1FEDB335087F@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32847: patch
https://bugs.webkit.org/attachment.cgi?id=32847&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Special case ConsolePanel opening.

From bugzilla-daemon at webkit.org  Thu Jul 16 02:41:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 02:41:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27340] Allow custom memory
 allocation control in JavaScriptCore's JSClassRef.h : [Attachment 32848]
 proposed patch
In-Reply-To: <bug-27340-0@https.bugs.webkit.org/>
References: <bug-27340-0@https.bugs.webkit.org/>
Message-ID: <20090716094152.F2C423350B54@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27340: Allow custom memory allocation control in JavaScriptCore's
JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340

Attachment 32848: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32848&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 03:13:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 03:13:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27342] Allow custom memory
 allocation control for OpaqueJSPropertyNameArray struct : [Attachment
 32850] proposed patch
In-Reply-To: <bug-27342-0@https.bugs.webkit.org/>
References: <bug-27342-0@https.bugs.webkit.org/>
Message-ID: <20090716101315.67CAA3351458@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27342: Allow custom memory allocation control for OpaqueJSPropertyNameArray
struct
https://bugs.webkit.org/show_bug.cgi?id=27342

Attachment 32850: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32850&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 03:22:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 03:22:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27077] Workers + garbage
 collector: weird crashes : [Attachment 32851] Patch for op_method_check
 (unlinkCallers)
In-Reply-To: <bug-27077-0@https.bugs.webkit.org/>
References: <bug-27077-0@https.bugs.webkit.org/>
Message-ID: <20090716102206.77D1633516C6@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 27077: Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

Attachment 32851: Patch for op_method_check (unlinkCallers)
https://bugs.webkit.org/attachment.cgi?id=32851&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 03:39:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 03:39:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27343] Allow custom memory
 allocation control in JavaScriptCore's RegexPattern.h : [Attachment 32852]
 proposed patch
In-Reply-To: <bug-27343-0@https.bugs.webkit.org/>
References: <bug-27343-0@https.bugs.webkit.org/>
Message-ID: <20090716103905.2FD523351BE8@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27343: Allow custom memory allocation control in JavaScriptCore's
RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343

Attachment 32852: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32852&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 04:11:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:11:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27077] Workers + garbage
 collector: weird crashes : [Attachment 32851] Patch for op_method_check
 (unlinkCallers)
In-Reply-To: <bug-27077-0@https.bugs.webkit.org/>
References: <bug-27077-0@https.bugs.webkit.org/>
Message-ID: <20090716111110.1920B3352442@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27077: Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

Attachment 32851: Patch for op_method_check (unlinkCallers)
https://bugs.webkit.org/attachment.cgi?id=32851&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me, this seems to be the correct fix according to my logic.

From bugzilla-daemon at webkit.org  Thu Jul 16 04:17:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:17:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32856] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716111734.121E33352636@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32856: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32856&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 04:20:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:20:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27344] Allow custom memory
 allocation control for JavaScriptCore's MatchFrame struct : [Attachment
 32857] proposed patch
In-Reply-To: <bug-27344-0@https.bugs.webkit.org/>
References: <bug-27344-0@https.bugs.webkit.org/>
Message-ID: <20090716112056.643AD3352789@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27344: Allow custom memory allocation control for JavaScriptCore's
MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344

Attachment 32857: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32857&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 04:44:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:44:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32858] Patch to add ChromeClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090716114449.3C9F63352E31@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32858: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32858&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 04:47:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:47:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26749] Canvas: rotation of
 'no-repeat' pattern still has small error : [Attachment 32859] Patch v2
In-Reply-To: <bug-26749-0@https.bugs.webkit.org/>
References: <bug-26749-0@https.bugs.webkit.org/>
Message-ID: <20090716114713.C96A33352EE8@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 26749: Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749

Attachment 32859: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32859&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 04:58:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:58:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32860] Patch to add FrameLoaderClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090716115809.961E733534B5@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32860: Patch to add FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32860&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 04:58:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 04:58:09 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32233] Patch to add FrameLoaderClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090716115809.82D9133534B2@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32233: Patch to add FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32233&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 05:21:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 05:21:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32861] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716122148.210613353BA2@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32861: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32861&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 05:28:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 05:28:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27347]
 HitTestResult::boundingBox can ASSERT in SVGRenderBase::mapLocalToContainer
 : [Attachment 32862] Make using HitTestResult on SVG not run into
 assertions
In-Reply-To: <bug-27347-0@https.bugs.webkit.org/>
References: <bug-27347-0@https.bugs.webkit.org/>
Message-ID: <20090716122816.E7F0A3353D81@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27347: HitTestResult::boundingBox can ASSERT in
SVGRenderBase::mapLocalToContainer
https://bugs.webkit.org/show_bug.cgi?id=27347

Attachment 32862: Make using HitTestResult on SVG not run into assertions
https://bugs.webkit.org/attachment.cgi?id=32862&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
WebCore
2009-07-03  Holger Hans Peter Freyther	<zecke at selfish.org>

Reviewed by NOBODY (OOPS!).

Change HitTest to use transform for SVGRenderBase

Kill HitTestResult::boundingBox as it doesn't belong into a
HitTest as it is operating on points.

Change HitTestResult::imageRect to use RenderBox::absoluteContentQuad
to useTransform. This is required to not run into an assert
with SVG Images in SVGRenderBase.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::imageRect):
* rendering/HitTestResult.h:

WebKit/win
2009-07-03  Holger Hans Peter Freyther	<zecke at selfish.org>

Reviewed by NOBODY (OOPS!).

HitTestResult::boundingBox is gone, use the RenderObject
directly and be transformation aware to not run into asserts
in SVGRenderBase.

* WebElementPropertyBag.cpp:
(WebElementPropertyBag::Read):

WebKit/qt
2009-07-03  Holger Hans Peter Freyther	<zecke at selfish.org>

Reviewed by NOBODY (OOPS!).

HitTestResult::boundingBox is gone, use the RenderObject
directly and be transformation aware to not run into asserts
in SVGRenderBase.

* Api/qwebframe.cpp:
(QWebHitTestResultPrivate::QWebHitTestResultPrivate):
---
 7 files changed, 44 insertions(+), 15 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 05:35:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 05:35:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27346] [GTK] Change the
 focus-in/grab-focus code to set FocusController::setFocusedFrame :
 [Attachment 32863] [GTK+] Make TestNescpaePlugin loadable in mozilla
In-Reply-To: <bug-27346-0@https.bugs.webkit.org/>
References: <bug-27346-0@https.bugs.webkit.org/>
Message-ID: <20090716123546.BB4D13353F53@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27346: [GTK] Change the focus-in/grab-focus code to set
FocusController::setFocusedFrame
https://bugs.webkit.org/show_bug.cgi?id=27346

Attachment 32863: [GTK+] Make TestNescpaePlugin loadable in mozilla
https://bugs.webkit.org/attachment.cgi?id=32863&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.
---
 2 files changed, 13 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 05:36:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 05:36:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27345] [UNIX]
 TestNetscapePlugin for Unix (X11) can not be loaded in gecko : [Attachment
 32864] [GTK+] Update the focus handling code.
In-Reply-To: <bug-27345-0@https.bugs.webkit.org/>
References: <bug-27345-0@https.bugs.webkit.org/>
Message-ID: <20090716123633.D0D443353F9C@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27345: [UNIX] TestNetscapePlugin for Unix (X11) can not be loaded in gecko
https://bugs.webkit.org/show_bug.cgi?id=27345

Attachment 32864: [GTK+] Update the focus handling code.
https://bugs.webkit.org/attachment.cgi?id=32864&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Make sure to call FocusController::setFocusedFrame when
we didn't set a focused frame yet. We are doing this in
the grab-focus and focus-in routine.
---
 2 files changed, 30 insertions(+), 3 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 06:01:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:01:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27346] [GTK] Change the
 focus-in/grab-focus code to set FocusController::setFocusedFrame :
 [Attachment 32863] [GTK+] Make TestNescpaePlugin loadable in mozilla
In-Reply-To: <bug-27346-0@https.bugs.webkit.org/>
References: <bug-27346-0@https.bugs.webkit.org/>
Message-ID: <20090716130128.9782C335470B@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has canceled Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 27346: [GTK] Change the focus-in/grab-focus code to set
FocusController::setFocusedFrame
https://bugs.webkit.org/show_bug.cgi?id=27346

Attachment 32863: [GTK+] Make TestNescpaePlugin loadable in mozilla
https://bugs.webkit.org/attachment.cgi?id=32863&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 06:01:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:01:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27346] [GTK] Change the
 focus-in/grab-focus code to set FocusController::setFocusedFrame :
 [Attachment 32865] [GTK+] Update the focus handling code.
In-Reply-To: <bug-27346-0@https.bugs.webkit.org/>
References: <bug-27346-0@https.bugs.webkit.org/>
Message-ID: <20090716130132.90FE1335471B@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27346: [GTK] Change the focus-in/grab-focus code to set
FocusController::setFocusedFrame
https://bugs.webkit.org/show_bug.cgi?id=27346

Attachment 32865: [GTK+] Update the focus handling code.
https://bugs.webkit.org/attachment.cgi?id=32865&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Make sure to call FocusController::setFocusedFrame when
we didn't set a focused frame yet. We are doing this in
the grab-focus and focus-in routine.
---
 2 files changed, 30 insertions(+), 3 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 06:01:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:01:50 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27345] [UNIX]
 TestNetscapePlugin for Unix (X11) can not be loaded in gecko : [Attachment
 32864] [GTK+] Update the focus handling code.
In-Reply-To: <bug-27345-0@https.bugs.webkit.org/>
References: <bug-27345-0@https.bugs.webkit.org/>
Message-ID: <20090716130150.0567A3354733@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has canceled Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 27345: [UNIX] TestNetscapePlugin for Unix (X11) can not be loaded in gecko
https://bugs.webkit.org/show_bug.cgi?id=27345

Attachment 32864: [GTK+] Update the focus handling code.
https://bugs.webkit.org/attachment.cgi?id=32864&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 06:01:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:01:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27345] [UNIX]
 TestNetscapePlugin for Unix (X11) can not be loaded in gecko : [Attachment
 32866] [GTK+] Make TestNescpaePlugin loadable in mozilla
In-Reply-To: <bug-27345-0@https.bugs.webkit.org/>
References: <bug-27345-0@https.bugs.webkit.org/>
Message-ID: <20090716130154.082143354746@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27345: [UNIX] TestNetscapePlugin for Unix (X11) can not be loaded in gecko
https://bugs.webkit.org/show_bug.cgi?id=27345

Attachment 32866: [GTK+] Make TestNescpaePlugin loadable in mozilla
https://bugs.webkit.org/attachment.cgi?id=32866&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Currently the NPNetscapeFuncs of WebKit contains two more
entries than the gecko version. This means comparing the
aMozillaVTable->size with the size of NPNetscpaeFuncs will
fail and the plugin will not be loaded.

For testing it is nice to be able to load the plugin into
gecko and currently we are not using the two extra methods.
Remove the test to be able to use the plugin in gecko.
---
 2 files changed, 13 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 06:05:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:05:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27346] [GTK] Change the
 focus-in/grab-focus code to set FocusController::setFocusedFrame :
 [Attachment 32865] [GTK+] Update the focus handling code.
In-Reply-To: <bug-27346-0@https.bugs.webkit.org/>
References: <bug-27346-0@https.bugs.webkit.org/>
Message-ID: <20090716130536.4E1213354858@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 27346: [GTK] Change the focus-in/grab-focus code to set
FocusController::setFocusedFrame
https://bugs.webkit.org/show_bug.cgi?id=27346

Attachment 32865: [GTK+] Update the focus handling code.
https://bugs.webkit.org/attachment.cgi?id=32865&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me.

From bugzilla-daemon at webkit.org  Thu Jul 16 06:27:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:27:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32846] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716132714.A8DF53354F68@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32846: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32846&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 06:27:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:27:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32867] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716132714.B86F53354F6A@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32867: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32867&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 06:43:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:43:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32861] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716134333.0B0333355549@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32861: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32861&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Sorry, the previous patch lacks some files.

From bugzilla-daemon at webkit.org  Thu Jul 16 06:43:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:43:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32868] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716134333.2F99D335554B@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32868: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32868&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Sorry, the previous patch lacks some files.

From bugzilla-daemon at webkit.org  Thu Jul 16 06:53:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 06:53:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32869] Patch to add a fourth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716135344.9D1C23355951@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32869: Patch to add a fourth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32869&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 07:22:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 07:22:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32870] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716142255.63D713356327@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32870: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32870&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 07:53:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 07:53:02 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25195] using keyboard to
 extend selection after a selection using mouse extends character selection
 in reverse order as FF and IE : [Attachment 31969] patch w/ Layout test
In-Reply-To: <bug-25195-0@https.bugs.webkit.org/>
References: <bug-25195-0@https.bugs.webkit.org/>
Message-ID: <20090716145302.7A75C3356D9E@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Xiaomei Ji <xji at chromium.org>'s
request for review:
Bug 25195: using keyboard to extend selection after a selection using mouse
extends character selection in reverse order as FF and IE
https://bugs.webkit.org/show_bug.cgi?id=25195

Attachment 31969: patch w/ Layout test
https://bugs.webkit.org/attachment.cgi?id=31969&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Six thoughts:

    1) Please re-test this after http://trac.webkit.org/changeset/45945 -- this
might have been affected by that bug.

    2) #if !PLATFORM(WIN) is the way to do this, not an #if followed by an
#else.

    3) Does this really not affect the results of any other regression tests?

    4) We want the test to test behavior on all platforms, expecting one result
on Windows and another on other platforms.

    5) Is it really true that Windows is the exception? Maybe Mac is the
exception?

    6) In the test case, two of the comments have been merged into one giant
line. Search for "the mouse down" to see what I mean.

From bugzilla-daemon at webkit.org  Thu Jul 16 08:04:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:04:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27333] cpplint should check
 for equality comparisons to 0/true/false : [Attachment 32872] Proposed fix
 (that addresses previous comments and has an updated ChangeLog).
In-Reply-To: <bug-27333-0@https.bugs.webkit.org/>
References: <bug-27333-0@https.bugs.webkit.org/>
Message-ID: <20090716150430.78AB433570D0@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27333: cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

Attachment 32872: Proposed fix (that addresses previous comments and has an
updated ChangeLog).
https://bugs.webkit.org/attachment.cgi?id=32872&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 08:10:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:10:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 17052] Scrolling with arrow
 keys does not update cursor : [Attachment 32408] Add CHROMIUM to the target
 platform.
In-Reply-To: <bug-17052-0@https.bugs.webkit.org/>
References: <bug-17052-0@https.bugs.webkit.org/>
Message-ID: <20090716151010.D5A713357295@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Yuzo Fujishima <yuzo at google.com>'s
request for review:
Bug 17052: Scrolling with arrow keys does not update cursor
https://bugs.webkit.org/show_bug.cgi?id=17052

Attachment 32408: Add CHROMIUM to the target platform.
https://bugs.webkit.org/attachment.cgi?id=32408&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    const bool result = handleWheelEventInternal(e);

There are many local variables that could be marked const. Normally it is not
our style in the WebKit project to do this just because the variable is not
modified in the function. It seems an unnecessary stylistic difference in your
new code.

> +    // For Windows and GTK, we need to simulate a mousemove event after
scrolling by mouse wheel or up/down/space key.
> +    // For MAC, we don't need to, because the OS sends a mousemove event
after a mousewheel event, and hides the mouse cursor while scrolling by keys.
> +    // TODO: Examine other platforms.

The name of the platforms are Windows and Mac. Not Windows and MAC.

This comment seems incorrect to me. An almost identical issue exists on the
Mac. I think the issue is that the Mac has code in WebKit to handle this, and
the other platforms don't. I don't think the difference is in the OS. You
should patch the platforms to be the same instead of creating an unnecessary
platform difference.

Even if what you said was true about the wheel events, it's definitely not true
about keyboard events.

In fact, by leaving this code turned off for Mac you miss the opportunity to
fix a bug I've seen where scrolling with arrow keys on Mac doesn't result in
update of hover. Worse, by including PLATFORM(CHROMIUM), you'd fix the Mac
version of Chrome but leave this broken in the Mac version of Safari.

> +    // Simulating a mousemove event has a side effect that onmousemove
handler is invoked when the mouse doesn't actually move.

Tiny language nitpick. Referring to the "onmousemove" handler is unnecessarily
inaccurate. Setting an onmousemove attribute is only one of many ways to set up
a handler for a mousemove event, and not one that needs to be emphasized in
comments.

> +    bool keyEventInternal(const PlatformKeyboardEvent&);
> +    bool handleWheelEventInternal(PlatformWheelEvent&);

Why does one of these functions have "handle" in its name, but not the other? I
guess because they reflect the names of the original functions that you broke
into two pieces.

It's a little ugly to just add a level of function call so you can wrap the
function in new code. If people find other similar requirements and go on
repeating this pattern, then we will end up with Internal2, Internal3, versions
of these functions. The names do nothing to tell programmers what should be in
the outer and what should be in the inner version.

I don't think it's a good design pattern for the long term, although I think
it's OK here.

It's strange that we will record scroll positions and simulate mouse move
events even for keyboard events we choose not to handle. I think this patch
really isn't tackling this at the right level. It's true that this is the
easiest level to patch for someone who's not familiar with the code, but
scrolling can also be triggered by scripts rather than by events, and the
scripts could run based on a timer. It's not right to trigger the simulated
events based on the real events. Instead I think the simulated mouse move
events should be triggered more directly by the actual document scrolling.

A good test case would be a timer that scrolls. The cursor should be updated
each time the scroll happens even if there is not keyboard or mouse wheel
events.

> +    void updateMousePositions(const PlatformMouseEvent& mouseEvent);

We do not give names to arguments like mouseEvent in function declarations when
the type already makes the argument's purpose clear.

> +	   const IntPoint& globalPos() const { return m_globalPosition; }

I know this is just following the standard of the original code, but I think
globalPosition() would be a better name for this new function.

I think it's unnecessary to have the simulated event have so much incorrect
state, such as false for all the modifier keys. Instead we should make the
simulated event reflect the real state as much as possible.

I also think that the simulated event should not contain the same mouse
position as the last real event. The mapping from a global position to a local
one can be affected by things such as the window position, and that could have
changed since the last real mouse event, for example if a script moved the
window.

The idea of this code is great, but I think it needs more work and to be less
platform-specific.

From bugzilla-daemon at webkit.org  Thu Jul 16 08:21:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:21:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27328]
 WebKitTools/Scripts/svn-create-patch is broken : [Attachment 32838] Fix for
 Unusual Perl Behavior
In-Reply-To: <bug-27328-0@https.bugs.webkit.org/>
References: <bug-27328-0@https.bugs.webkit.org/>
Message-ID: <20090716152112.4DE0C335765E@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27328: WebKitTools/Scripts/svn-create-patch is broken
https://bugs.webkit.org/show_bug.cgi?id=27328

Attachment 32838: Fix for Unusual Perl Behavior
https://bugs.webkit.org/attachment.cgi?id=32838&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 08:26:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:26:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27343] Allow custom memory
 allocation control in JavaScriptCore's RegexPattern.h : [Attachment 32852]
 proposed patch
In-Reply-To: <bug-27343-0@https.bugs.webkit.org/>
References: <bug-27343-0@https.bugs.webkit.org/>
Message-ID: <20090716152631.86DBE33577E4@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27343: Allow custom memory allocation control in JavaScriptCore's
RegexPattern.h
https://bugs.webkit.org/show_bug.cgi?id=27343

Attachment 32852: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32852&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 08:27:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:27:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27344] Allow custom memory
 allocation control for JavaScriptCore's MatchFrame struct : [Attachment
 32857] proposed patch
In-Reply-To: <bug-27344-0@https.bugs.webkit.org/>
References: <bug-27344-0@https.bugs.webkit.org/>
Message-ID: <20090716152708.8D0183357817@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27344: Allow custom memory allocation control for JavaScriptCore's
MatchFrame struct
https://bugs.webkit.org/show_bug.cgi?id=27344

Attachment 32857: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32857&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 08:36:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:36:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27329] Inspector:
 Properties Should be Sorted more Naturally : [Attachment 32873]
 AlphaNumSort (Like Finder on leading zeros)
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090716153628.1D87D3357ADB@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32873: AlphaNumSort (Like Finder on leading zeros)
https://bugs.webkit.org/attachment.cgi?id=32873&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Keishi liked Finder's sort the best.  And indeed that is probably the best
performing because it didn't require using any more regular expressions
(although it treats 0 as a special case, which is disappointing but possible to
do without regular expressions in the algorithm).  Give this one a shot.

And if you feel as though "!+chunk" is clearer as "!Number(chunk)" then please
change it.  I actually prefer the former.

From bugzilla-daemon at webkit.org  Thu Jul 16 08:41:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:41:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27333] cpplint should check
 for equality comparisons to 0/true/false : [Attachment 32874] Updated
 patched.
In-Reply-To: <bug-27333-0@https.bugs.webkit.org/>
References: <bug-27333-0@https.bugs.webkit.org/>
Message-ID: <20090716154147.3EB213357C7E@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27333: cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

Attachment 32874: Updated patched.
https://bugs.webkit.org/attachment.cgi?id=32874&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Fixed the (ironic) incorrectly styled variable names in the test cases.

From bugzilla-daemon at webkit.org  Thu Jul 16 08:41:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 08:41:47 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27333] cpplint should check
 for equality comparisons to 0/true/false : [Attachment 32872] Proposed fix
 (that addresses previous comments and has an updated ChangeLog).
In-Reply-To: <bug-27333-0@https.bugs.webkit.org/>
References: <bug-27333-0@https.bugs.webkit.org/>
Message-ID: <20090716154147.2C8063357C7C@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled David Levin
<levin at chromium.org>'s request for review:
Bug 27333: cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

Attachment 32872: Proposed fix (that addresses previous comments and has an
updated ChangeLog).
https://bugs.webkit.org/attachment.cgi?id=32872&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Fixed the (ironic) incorrectly styled variable names in the test cases.

From bugzilla-daemon at webkit.org  Thu Jul 16 09:01:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:01:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32875] Patch to add a fifth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716160118.EC78533582BD@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32875: Patch to add a fifth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32875&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 09:05:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:05:44 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27329] Inspector: Properties
 Should be Sorted more Naturally : [Attachment 32873] AlphaNumSort (Like
 Finder on leading zeros)
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090716160544.2F01B33583F9@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32873: AlphaNumSort (Like Finder on leading zeros)
https://bugs.webkit.org/attachment.cgi?id=32873&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Apparently sorting happens in multiple places.

It works for:
obj={a:[0,1,2,3,4,5,6,7,8,9,10,11,12]}

But it doesn't even get run for:
obj = { '0':0, '00':0, '000':0, '01':0, '1':0, '2':0, '02':0, '001':0, '002':0
}

I should look into when sorts are applied.

From bugzilla-daemon at webkit.org  Thu Jul 16 09:15:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:15:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32876] Patch to add a sixth bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090716161518.84B4D3358710@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32876: Patch to add a sixth bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32876&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 09:33:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:33:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27335] [V8]
 V8IsolatedWorld::evaluate needs to call didCreateIsolatedScriptContext :
 [Attachment 32841] patch
In-Reply-To: <bug-27335-0@https.bugs.webkit.org/>
References: <bug-27335-0@https.bugs.webkit.org/>
Message-ID: <20090716163310.E75233358CC5@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27335: [V8] V8IsolatedWorld::evaluate needs to call
didCreateIsolatedScriptContext
https://bugs.webkit.org/show_bug.cgi?id=27335

Attachment 32841: patch
https://bugs.webkit.org/attachment.cgi?id=32841&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Apparently.

From bugzilla-daemon at webkit.org  Thu Jul 16 09:33:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:33:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27327] [Chromium] Clean up
 v8 bindings a bit : [Attachment 32878] v2 minus DOMWindow changes
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716163330.E9CF03358CF0@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32878: v2 minus DOMWindow changes
https://bugs.webkit.org/attachment.cgi?id=32878&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
This is the other possible option: Only change ScriptObjectQuarantine and leave
DOMWindow as is.  I'm leaning towards this patch, but both seem like fine
options.

From bugzilla-daemon at webkit.org  Thu Jul 16 09:34:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:34:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27327] [Chromium] Clean up v8
 bindings a bit : [Attachment 32878] v2 minus DOMWindow changes
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716163445.1D26B3358D7A@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32878: v2 minus DOMWindow changes
https://bugs.webkit.org/attachment.cgi?id=32878&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
I like this one better -- I was just going to suggest letting codegen do its
thing.

From bugzilla-daemon at webkit.org  Thu Jul 16 09:35:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:35:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27327] [Chromium] Clean up
 v8 bindings a bit : [Attachment 32837] v2
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716163505.BC2263358D9E@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has canceled Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32837: v2
https://bugs.webkit.org/attachment.cgi?id=32837&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 09:35:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:35:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27329] Inspector:
 Properties Should be Sorted more Naturally : [Attachment 32879] Sort is
 Applied Correctly, only When Displaying
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090716163532.B8EA73358DF0@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32879: Sort is Applied Correctly, only When Displaying
https://bugs.webkit.org/attachment.cgi?id=32879&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This only applies the sort when needed in the ObjectPropertiesSection. 
Typeahead/Autocompletion uses the default sort().
Both test cases pass:

> obj={a:[0,1,2,3,4,5,6,7,8,9,10,11,12]};
> obj
...

> obj = {'0':0,'00':0,'000':0,'01':0,'1':0,'2':0,'02':0,'001':0,'002':0};
> obj
...

From bugzilla-daemon at webkit.org  Thu Jul 16 09:36:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:36:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27348] [Qt] Enable GNU
 compiler extensions to the ARM compiler for all Qt ports using RVCT :
 [Attachment 32880] Proposed patch.
In-Reply-To: <bug-27348-0@https.bugs.webkit.org/>
References: <bug-27348-0@https.bugs.webkit.org/>
Message-ID: <20090716163609.25C813358E2E@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27348: [Qt] Enable GNU compiler extensions to the ARM compiler for all Qt
ports using RVCT
https://bugs.webkit.org/show_bug.cgi?id=27348

Attachment 32880: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=32880&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 09:41:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:41:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 32881] Fixes
 bug 27289 (same as previous version of patch) and adds test cases.
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090716164143.787D83359025@gamma.macosforge.org>

Viet-Trung Luu <viettrungluu at gmail.com> has asked  for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 32881: Fixes bug 27289 (same as previous version of patch) and adds
test cases.
https://bugs.webkit.org/attachment.cgi?id=32881&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 09:41:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:41:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 32769] Fixes
 bug 27289 by updating m_lastScrollbarUnderMouse on mouse down.
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090716164143.5C2093359021@gamma.macosforge.org>

Viet-Trung Luu <viettrungluu at gmail.com> has canceled Viet-Trung Luu
<viettrungluu at gmail.com>'s request for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 32769: Fixes bug 27289 by updating m_lastScrollbarUnderMouse on
mouse down.
https://bugs.webkit.org/attachment.cgi?id=32769&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 09:43:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:43:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27348] [Qt] Enable GNU
 compiler extensions to the ARM compiler for all Qt ports using RVCT :
 [Attachment 32880] Proposed patch.
In-Reply-To: <bug-27348-0@https.bugs.webkit.org/>
References: <bug-27348-0@https.bugs.webkit.org/>
Message-ID: <20090716164313.D7A25335909C@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27348: [Qt] Enable GNU compiler extensions to the ARM compiler for all Qt
ports using RVCT
https://bugs.webkit.org/show_bug.cgi?id=27348

Attachment 32880: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=32880&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. thanks :)

From bugzilla-daemon at webkit.org  Thu Jul 16 09:54:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:54:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 32882] Patch
 and test cases for bug 27289.
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090716165433.E6CFE3359435@gamma.macosforge.org>

Viet-Trung Luu <viettrungluu at gmail.com> has asked  for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 32882: Patch and test cases for bug 27289.
https://bugs.webkit.org/attachment.cgi?id=32882&action=review

------- Additional Comments from Viet-Trung Luu <viettrungluu at gmail.com>
Got rid of duplicate Changelog entry.

From bugzilla-daemon at webkit.org  Thu Jul 16 09:56:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 09:56:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 32881] Fixes
 bug 27289 (same as previous version of patch) and adds test cases.
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090716165604.8E5C933594D2@gamma.macosforge.org>

Viet-Trung Luu <viettrungluu at gmail.com> has canceled Viet-Trung Luu
<viettrungluu at gmail.com>'s request for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 32881: Fixes bug 27289 (same as previous version of patch) and adds
test cases.
https://bugs.webkit.org/attachment.cgi?id=32881&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 10:19:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 10:19:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 32884] Adds
 GraphicsContextWince.cpp
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090716171952.DE2863359C38@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 32884: Adds GraphicsContextWince.cpp
https://bugs.webkit.org/attachment.cgi?id=32884&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 10:53:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 10:53:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26655] ResourceHandle
 infrastructure is needed to support loading out of an appcache :
 [Attachment 32128] Interceptor (rev2)
In-Reply-To: <bug-26655-0@https.bugs.webkit.org/>
References: <bug-26655-0@https.bugs.webkit.org/>
Message-ID: <20090716175349.75846335A746@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 26655: ResourceHandle infrastructure is needed to support loading out of an
appcache
https://bugs.webkit.org/show_bug.cgi?id=26655

Attachment 32128: Interceptor (rev2)
https://bugs.webkit.org/attachment.cgi?id=32128&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r? to move this out of the review queue since Michael Nordman stated
"This is patch is really here more for proof-of-concept purposes, I'm not
looking to submit anything like this at this time."

From bugzilla-daemon at webkit.org  Thu Jul 16 10:53:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 10:53:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27282] [V8] Implement the
 corresponding V8 changes to deal with the problem that workers with syntax
 errors not firing error event : [Attachment 32752] Proposed Patch
In-Reply-To: <bug-27282-0@https.bugs.webkit.org/>
References: <bug-27282-0@https.bugs.webkit.org/>
Message-ID: <20090716175354.EA9C8335A76A@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has canceled Jian Li <jianli at chromium.org>'s
request for review:
Bug 27282: [V8] Implement the corresponding V8 changes to deal with the problem
that workers with syntax errors not firing error event
https://bugs.webkit.org/show_bug.cgi?id=27282

Attachment 32752: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32752&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 10:54:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 10:54:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26655] ResourceHandle
 infrastructure is needed to support loading out of an appcache :
 [Attachment 31738] Interceptor (rev1)
In-Reply-To: <bug-26655-0@https.bugs.webkit.org/>
References: <bug-26655-0@https.bugs.webkit.org/>
Message-ID: <20090716175418.D9CF6335A79A@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 26655: ResourceHandle infrastructure is needed to support loading out of an
appcache
https://bugs.webkit.org/show_bug.cgi?id=26655

Attachment 31738: Interceptor (rev1)
https://bugs.webkit.org/attachment.cgi?id=31738&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r? to move this out of the review queue since Michael Nordman stated
"This is patch is really here more for proof-of-concept purposes, I'm not
looking to submit anything like this at this time."

From bugzilla-daemon at webkit.org  Thu Jul 16 11:40:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 11:40:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27333] cpplint should check
 for equality comparisons to 0/true/false : [Attachment 32874] Updated
 patched.
In-Reply-To: <bug-27333-0@https.bugs.webkit.org/>
References: <bug-27333-0@https.bugs.webkit.org/>
Message-ID: <20090716184010.A2EB4335B632@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 27333: cpplint should check for equality comparisons to 0/true/false
https://bugs.webkit.org/show_bug.cgi?id=27333

Attachment 32874: Updated patched.
https://bugs.webkit.org/attachment.cgi?id=32874&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +def check_for_comparisons_to_zero(filename, clean_lines, line_number,
error):
> +    # Get the line without comments and strings.
> +    line = clean_lines.elided[line_number]
> +
> +    # Include NULL here so that users don't have to convert NULL to 0 first
and then get this error.
> +    if search(r'[=!]=\s*(NULL|0|true|false)\W', line) or
search(r'\W(NULL|0|true|false)\s*[=!]=', line):
> +	   error(filename, line_number, 'readability/comparison_to_zero', 5,
> +	      'Tests for true/false, zero/non-zero, etc. should be done without
equality comparisons.')

I think the error message should be more specific:

      'Tests for true/false, zero/non-zero, NULL/not-NULL should be done
without equality comparisons.')

> @@ -2907,8 +2904,29 @@ class WebKitStyleTest(CpplintTestBase):
>  
>	   # 3. Tests for true/false, null/non-null, and zero/non-zero should
>	   #	all be done without equality comparisons.
> -	   # FIXME: Implement this.
> -	   pass
> +	   self.assert_lint(
> +	       'if (count == 0)',
> +	       'Tests for true/false, zero/non-zero, etc. should be done
without equality comparisons.'
> +	       '  [readability/comparison_to_zero] [5]')
> +	   self.assert_lint(
> +	       'if (string == NULL)',
> +	       'Tests for true/false, zero/non-zero, etc. should be done
without equality comparisons.'
> +	       '  [readability/comparison_to_zero] [5]')
> +	   self.assert_lint(
> +	       'if (0 != aLongerVariableName)',
> +	       'Tests for true/false, zero/non-zero, etc. should be done
without equality comparisons.'
> +	       '  [readability/comparison_to_zero] [5]')
> +	   self.assert_lint(
> +	       'if (condition == true)',
> +	       'Tests for true/false, zero/non-zero, etc. should be done
without equality comparisons.'
> +	       '  [readability/comparison_to_zero] [5]')
> +	   self.assert_lint(
> +	       'if (myVariable == /* Why would anyone put a comment here? */
false)',
> +	       'Tests for true/false, zero/non-zero, etc. should be done
without equality comparisons.'
> +	       '  [readability/comparison_to_zero] [5]')
> +	   self.assert_lint(
> +	       'if (fontType == trueType)',
> +	       '')

The error messages here need to be updated to match the changed error message.

Ideally, all permutations of lhs, rhs and ==/!= should be tested here, but I
think this is sufficient.

r=me with the error message change.

From bugzilla-daemon at webkit.org  Thu Jul 16 11:53:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 11:53:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32867] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090716185306.74EDD335BB4B@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32867: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32867&action=review

------- Additional Comments from David Levin <levin at chromium.org>
You may want to consider using the (alpha version) lint tool for WebKit.

I downloaded this patch and ran on your files in this patch like this:
   python WebKitTools/Scripts/modules/cpplint.py
WebCore/platform/graphics/haiku/*.cpp

It found these errors:
WebCore/platform/graphics/haiku/FloatRectHaiku.cpp:44:	Missing space after , 
[whitespace/comma] [3]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:51:  This { should be
at the end of the previous line  [whitespace/braces] [4]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:229:  Tab found;
better to use spaces  [whitespace/tab] [1]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:495:  Place brace on
its own line for function definitions.	[whitespace/braces] [4]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:495:  Missing space
before {  [whitespace/braces] [5]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:511:  Tab found;
better to use spaces  [whitespace/tab] [1]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:516:  Tab found;
better to use spaces  [whitespace/tab] [1]
WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp:541:  Missing space
after ,  [whitespace/comma] [3]
WebCore/platform/graphics/haiku/ImageHaiku.cpp:109:  Tab found; better to use
spaces	[whitespace/tab] [1]
WebCore/platform/graphics/haiku/ImageHaiku.cpp:127:  Tab found; better to use
spaces	[whitespace/tab] [1]
WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp:78:  Tests for true/false,
zero/non-zero, etc. should be done without equality comparisons. 
[readability/comparison_to_zero] [5]
WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp:91:  Extra space before ) 
[whitespace/parens] [2]
WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp:124:  Missing space before
( in if(  [whitespace/parens] [5]
WebCore/platform/graphics/haiku/IntRectHaiku.cpp:45:  Missing space after , 
[whitespace/comma] [3]

When glancing through the code, I also noticed the following issues.

In WebCore/platform/graphics/haiku/GraphicsContextHaiku.cpp

> 56 BView* view;
"Prefix C++ data members with "m_"."So it should be m_view 

> 59 GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate(BView*
p_view)
p_view is not the correct format for a variable.

> 210	  // creatin the region.
typo: creatin

> 318 void GraphicsContext::setLineJoin(LineJoin lj)
Use full words, except in the rare case where an abbreviation would be more
canonical and easier to understand.
s/lj/lineJoin/


In WebCore/platform/graphics/haiku/ImageBufferData.h
#include "OwnPtr.h" should be #include <wtf/OwnPtr.h>


In WebCore/platform/graphics/haiku/ImageSourceHaiku.cpp
> 65	 if (uContents[0] == 0x89 &&
> 66	     uContents[1] == 0x50 &&
Boolean expressions at the same nesting level that span multiple lines should
have their operators on the left side of the line instead of the right side.

So it should look like this:
     if (uContents[0] == 0x89
	 && uContents[1] == 0x50

> 72	 // if (uContents[0] == 0xFF &&
Commented out code isn't checked in.  If you want to note the need to address
JPEG, you could put a 
  // FIXME: Implement JPEG support.
comment here.

From bugzilla-daemon at webkit.org  Thu Jul 16 12:04:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 12:04:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27321] v8 bindings missing
 from the build : [Attachment 32885] proposed patch that fixes the windows
 build when ENABLE_SHARED_WORKERS=true
In-Reply-To: <bug-27321-0@https.bugs.webkit.org/>
References: <bug-27321-0@https.bugs.webkit.org/>
Message-ID: <20090716190447.CA903335BF78@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked David Levin <levin at chromium.org>
for review:
Bug 27321: v8 bindings missing from the build
https://bugs.webkit.org/show_bug.cgi?id=27321

Attachment 32885: proposed patch that fixes the windows build when
ENABLE_SHARED_WORKERS=true
https://bugs.webkit.org/attachment.cgi?id=32885&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 12:10:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 12:10:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27337] Add a getter in
 MessagePortChannel for the PlatformMessagePortChannel : [Attachment 32886]
 new patch
In-Reply-To: <bug-27337-0@https.bugs.webkit.org/>
References: <bug-27337-0@https.bugs.webkit.org/>
Message-ID: <20090716191049.94E41335C1C3@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27337: Add a getter in MessagePortChannel for the
PlatformMessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=27337

Attachment 32886: new patch
https://bugs.webkit.org/attachment.cgi?id=32886&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 12:27:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 12:27:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27351] [Qt]
 navigator.platform returns an empty string in Symbian and in Linux
 platforms : [Attachment 32887] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090716192728.16330335C781@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32887: Patch
https://bugs.webkit.org/attachment.cgi?id=32887&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 12:43:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 12:43:11 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27351] [Qt] navigator.platform
 returns an empty string in Symbian and in Linux platforms : [Attachment
 32887] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090716194311.611BD335CD11@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32887: Patch
https://bugs.webkit.org/attachment.cgi?id=32887&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
No reason to believe that PLATFORM(LINUX) is "Linux i686"

From bugzilla-daemon at webkit.org  Thu Jul 16 12:55:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 12:55:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 32888] patch 0.2 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090716195558.ACA08335D16A@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 32888: patch 0.2 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=32888&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
Test added: it creates a proper FakeNetworkAccessManager
(:QNetworkAccessManager) and FakeReply (:QNetworkReply) in order to a redirect.

From bugzilla-daemon at webkit.org  Thu Jul 16 13:08:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 13:08:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27337] Add a getter in
 MessagePortChannel for the PlatformMessagePortChannel : [Attachment 32886]
 new patch
In-Reply-To: <bug-27337-0@https.bugs.webkit.org/>
References: <bug-27337-0@https.bugs.webkit.org/>
Message-ID: <20090716200831.55CD4335D556@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27337: Add a getter in MessagePortChannel for the
PlatformMessagePortChannel
https://bugs.webkit.org/show_bug.cgi?id=27337

Attachment 32886: new patch
https://bugs.webkit.org/attachment.cgi?id=32886&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I missed your earlier comment too.

> ah, I still get confused sometimes with all the RefPtr objects.  Thanks, I
only
> need a pointer.  I wasn't sure if it's ok to pass around raw pointers of ref
> counted objects.

Actually, I wasn't aware of this guideline until recently, but it is stated
well here: http://webkit.org/coding/RefPtr.html

"If a function?s result is an object, but ownership is not being transferred,
the result should be a raw pointer. This includes most getter functions."

From bugzilla-daemon at webkit.org  Thu Jul 16 13:17:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 13:17:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27321] v8 bindings missing
 from the build : [Attachment 32885] proposed patch that fixes the windows
 build when ENABLE_SHARED_WORKERS=true
In-Reply-To: <bug-27321-0@https.bugs.webkit.org/>
References: <bug-27321-0@https.bugs.webkit.org/>
Message-ID: <20090716201726.91369335D8D3@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27321: v8 bindings missing from the build
https://bugs.webkit.org/show_bug.cgi?id=27321

Attachment 32885: proposed patch that fixes the windows build when
ENABLE_SHARED_WORKERS=true
https://bugs.webkit.org/attachment.cgi?id=32885&action=review

------- Additional Comments from David Levin <levin at chromium.org>
The new modes being set on:
 WebCore/bindings/v8/custom/V8AbstractWorkerCustom.cpp
 WebCore/bindings/v8/custom/V8SharedWorkerCustom.cpp

Seem odd (to both of us).  I'll remove them from the patch when I land it.

From bugzilla-daemon at webkit.org  Thu Jul 16 13:24:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 13:24:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27327] [Chromium] Clean up v8
 bindings a bit : [Attachment 32878] v2 minus DOMWindow changes
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716202457.0BBB0335DBC1@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied  review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32878: v2 minus DOMWindow changes
https://bugs.webkit.org/attachment.cgi?id=32878&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Whoops. Mads is right. Actually, you should just be able to use Frame* that's
being passed.

From bugzilla-daemon at webkit.org  Thu Jul 16 13:45:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 13:45:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32889]
 Fixed Reattach Bug - No variable Caching
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090716204558.8AF87335E2B8@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32889: Fixed Reattach Bug - No variable Caching
https://bugs.webkit.org/attachment.cgi?id=32889&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 14:00:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:00:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32890] Fixes, part 1
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090716210001.D754F335E7B7@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked Adam Roben (aroben)
<aroben at apple.com> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32890: Fixes, part 1
https://bugs.webkit.org/attachment.cgi?id=32890&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Found a few more script issues with the scripts to prepare a change, so here's
a patch that fixes those and sets the eol-style for shell scripts.  This does
not update all the build steps to conditionally set the path; I figured
including that in this change would just make it hard to review.  That patch
will come next.

I created this patch using the modified copies of prepare-ChangeLog and
svn-create-patch here, so they at least work for me now :)

From bugzilla-daemon at webkit.org  Thu Jul 16 14:10:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:10:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22700] ApplicationCache
 should have size limit : [Attachment 32891] New proposal to limit the
 maximum size of the application cache (take 9)
In-Reply-To: <bug-22700-0@https.bugs.webkit.org/>
References: <bug-22700-0@https.bugs.webkit.org/>
Message-ID: <20090716211033.E3143335EBA3@gamma.macosforge.org>

Andrei Popescu <andreip at google.com> has asked  for review:
Bug 22700: ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Attachment 32891: New proposal to limit the maximum size of the application
cache (take 9)
https://bugs.webkit.org/attachment.cgi?id=32891&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 14:10:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:10:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 22700] ApplicationCache
 should have size limit : [Attachment 32709] New proposal to limit the
 maximum size of the application cache (take 8)
In-Reply-To: <bug-22700-0@https.bugs.webkit.org/>
References: <bug-22700-0@https.bugs.webkit.org/>
Message-ID: <20090716211033.D2855335EBA1@gamma.macosforge.org>

Andrei Popescu <andreip at google.com> has canceled Andrei Popescu
<andreip at google.com>'s request for review:
Bug 22700: ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Attachment 32709: New proposal to limit the maximum size of the application
cache (take 8)
https://bugs.webkit.org/attachment.cgi?id=32709&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 14:15:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:15:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32892] proposed patch
 (fixed problem with previous patch that prevent V8 bindings from compiling)
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090716211553.ECF03335EE2A@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked David Levin <levin at chromium.org>
for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32892: proposed patch (fixed problem with previous patch that
prevent V8 bindings from compiling)
https://bugs.webkit.org/attachment.cgi?id=32892&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
V8AbstractWorker underwent some bit rot (V8Proxy refactoring moved some of the
APIs it depended on, which was masked by the fact that SHARED_WORKERS is
disabled by default).

From bugzilla-daemon at webkit.org  Thu Jul 16 14:30:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:30:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32889]
 Fixed Reattach Bug - No variable Caching
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090716213026.6C41D335F401@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32889: Fixed Reattach Bug - No variable Caching
https://bugs.webkit.org/attachment.cgi?id=32889&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +long InspectorController::constrainedAttachedWindowHeight(long
preferredHeight, long totalWindowHeight)
> +{
> +    if (preferredHeight == 0) {

We normally write this as if (!preferredHeight).

> @@ -323,7 +320,8 @@ void WebInspectorClient::updateWindowTit
>  
>      if (_shouldAttach) {
>	   WebFrameView *frameView = [[_inspectedWebView mainFrame] frameView];

> -
> +	   NSRect frameViewRect = [frameView frame];

I don't think this local variable is really useful.

> @@ -331,8 +329,8 @@ void WebInspectorClient::updateWindowTit
>	   [frameView setAutoresizingMask:(NSViewWidthSizable |
NSViewHeightSizable | NSViewMinYMargin)];
>  
>	   _attachedToInspectedWebView = YES;
> -
> -	   [self setAttachedWindowHeight:[[NSUserDefaults standardUserDefaults]
integerForKey:WebKitInspectorAttachedViewHeightKey]];
> +	   
> +	   [self setAttachedWindowHeight:[_inspectedWebView
page]->inspectorController()->constrainedAttachedWindowHeight(0,
NSHeight(frameViewRect))];

Why do both InspectorClient implementations have to call
setAttachedWindowHeight themselves? Can't the InspectorController make this
call for us (passing in the height of the inspected page from before
InspectorClient::attachWindow was called)? If InspectorController did it for
us, we could get rid of the constrainedAttachedWindowHeight function.

> @@ -240,6 +238,16 @@ void WebInspectorClient::attachWindow()
>  
>      closeWindowWithoutNotifications();
>      showWindowWithoutNotifications();
> +
> +    HWND hostWindow;
> +    if (SUCCEEDED(m_inspectedWebView->hostWindow((OLE_HANDLE*)&hostWindow)))


Please use reinterpret_cast instead of a C-style cast.

> +	   SendMessage(hostWindow, WM_SIZE, 0, 0);     // Make sure we have the
correct size

What happens if you omit this SendMessage call?

> +    RECT hostWindowRect;
> +    GetClientRect(hostWindow, &hostWindowRect);
> +
> +    // This re-constrains our attached height, in case while the inspector
was detached, they resized the inspected window,
> +    // and drawing it at the size it used to be could lead to the inspector
taking up the whole window or more

Please put a period at the end of this comment.

>  void WebInspectorClient::setAttachedWindowHeight(unsigned height)
>  {
> -    // FIXME: implement this.
> +    if (!m_attached)
> +	   return;
> +
> +    HWND hostWindow;
> +    if
(!SUCCEEDED(m_inspectedWebView->hostWindow((OLE_HANDLE*)&hostWindow)))

You should use reinterpret_cast here, and FAILED() instead of !SUCCEEDED().

> +	   return;
> +
> +    RECT hostWindowRect;
> +    GetClientRect(hostWindow, &hostWindowRect);
> +
> +    RECT inspectedRect;
> +    GetClientRect(m_inspectedWebViewHwnd, &inspectedRect);
> +
> +    int totalHeight = hostWindowRect.bottom - hostWindowRect.top;
> +    int webViewWidth = inspectedRect.right - inspectedRect.left;
> +
> +    SetWindowPos(m_webViewHwnd, 0, 0, totalHeight - height, webViewWidth,
height, SWP_NOZORDER);
> +    SetWindowPos(m_inspectedWebViewHwnd, 0, 0, 0, webViewWidth, totalHeight,
SWP_NOZORDER);

This doesn't seem right. Shouldn't the height of m_inspectedWebViewHwnd be set
to totalHeight - height?

From bugzilla-daemon at webkit.org  Thu Jul 16 14:39:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:39:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27352] Video size sometimes
 jumps just after the video starts loading : [Attachment 32893] Patch,
 changelog
In-Reply-To: <bug-27352-0@https.bugs.webkit.org/>
References: <bug-27352-0@https.bugs.webkit.org/>
Message-ID: <20090716213952.B9DBA335F725@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27352: Video size sometimes jumps just after the video starts loading
https://bugs.webkit.org/show_bug.cgi?id=27352

Attachment 32893: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32893&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 14:41:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:41:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27352] Video size sometimes
 jumps just after the video starts loading : [Attachment 32893] Patch,
 changelog
In-Reply-To: <bug-27352-0@https.bugs.webkit.org/>
References: <bug-27352-0@https.bugs.webkit.org/>
Message-ID: <20090716214128.D2DB1335F7B9@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 27352: Video size sometimes jumps just after the video starts loading
https://bugs.webkit.org/show_bug.cgi?id=27352

Attachment 32893: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32893&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    bool readyForRendering() const;

I think it would be slightly better to call this isReadyForRendering for two
reasons.

    1) "ready" is verb as well as an adjective.
    2) Without the "is", the function seems like it might be the caller saying
we are ready, rather than asking.

r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 14:53:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:53:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32890] Fixes, part 1
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090716215337.3DB38335FB8D@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32890: Fixes, part 1
https://bugs.webkit.org/attachment.cgi?id=32890&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +++ WebKitTools/ChangeLog	(working copy)
> @@ -1,3 +1,14 @@
> +2009-07-16  Peter Kasting  <pkasting at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27323
> +	   Improve support for non-Cygwin SVNs on Windows, as well as WebKit
> +	   checkouts hosted inside other checkouts.
> +
> +	   * Scripts/prepare-ChangeLog: Fix a case of adding "\n" to the
ChangeLog without normalizing.	Normalize file paths early instead of late so
all stages of the script work.	Modify regexes so that trailing whitespace
(e.g. \r) isn't included in filenames.
> +	   * Scripts/svn-create-patch: Use a regex instead of chomp so we cut
off line endings even if they don't match Perl's.  Determine SVN root by
looking for Repository Root string and aborting when it's missing or different
than what we've already seen.

Please wrap these long lines.

> @@ -338,7 +338,7 @@ foreach my $prefix (sort keys %files) {
>      $bugDescription = "Need a short description and bug URL (OOPS!)" unless
$bugDescription;
>      print CHANGE_LOG normalizeLineEndings("	      $bugDescription\n",
$endl) if $bugDescription;
>      print CHANGE_LOG normalizeLineEndings("	      $bugURL\n", $endl) if
$bugURL;
> -    print CHANGE_LOG "\n";
> +    print CHANGE_LOG normalizeLineEndings("\n", $endl);

Seems like all of these lines could just use $endl instead of \n and then they
wouldn't have to call normalizeLineEndings at all.

> @@ -1289,7 +1289,7 @@ sub findOriginalFileFromSvn($)
>      my $baseUrl;
>      open INFO, "$SVN info . |" or die;
>      while (<INFO>) {
> -	   if (/^URL: (.+)/) {
> +	   if (/^URL: (.+\S+)\s*/) {
>	       $baseUrl = $1;
>	   }

Do we still need the .+ part of this regex? Seems like its only purpose at this
point is to allow leading spaces, which doesn't seem like something we want.

Should we use \r?\n$ at the end instead of \s* ? That seems a little clearer
about the intent. Ditto for the other similar changes you made to regexes.

> @@ -467,10 +471,26 @@ sub determineSvnRoot()
>      my $path = '.';
>      my $parent = '../';
>      my $devnull = File::Spec->devnull();
> -    my $exitCode;
> +    my $repositoryRoot;
>      while (1) {
> -	   $exitCode = system("svn info $path 2> $devnull > $devnull")/256;
> -	   last if $exitCode;
> +	   my $thisRoot;
> +	   open INFO, "svn info '$path' |" or die;
> +	   while (<INFO>) {
> +	       if (/^Repository Root: (.+)/) {
> +		   $thisRoot = $1;
> +	       }
> +	   }
> +	   close INFO;
> +
> +	   # It's possible (e.g. for developers of some ports) to have a WebKit

> +	   # checkout in a subdirectory of another checkout.  So abort if the
> +	   # repository root suddenly changes.
> +	   last if !$thisRoot;
> +	   if (!$repositoryRoot) {
> +	       $repositoryRoot = $thisRoot;
> +	   }
> +	   last if $thisRoot ne $repositoryRoot;
> +

This seems like a very separate fix from the rest of this patch. Could you
split it out into its own change?

r=me if you do the determineSvnRoot change separately. You should get Dave
Kilzer to review that part.

From bugzilla-daemon at webkit.org  Thu Jul 16 14:53:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:53:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27353] Images mispositioned
 on photo page : [Attachment 32894] Patch
In-Reply-To: <bug-27353-0@https.bugs.webkit.org/>
References: <bug-27353-0@https.bugs.webkit.org/>
Message-ID: <20090716215338.45B1A335FB97@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27353: Images mispositioned on photo page
https://bugs.webkit.org/show_bug.cgi?id=27353

Attachment 32894: Patch
https://bugs.webkit.org/attachment.cgi?id=32894&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 14:55:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:55:50 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27353] Images mispositioned
 on photo page : [Attachment 32894] Patch
In-Reply-To: <bug-27353-0@https.bugs.webkit.org/>
References: <bug-27353-0@https.bugs.webkit.org/>
Message-ID: <20090716215550.49EF8335FC8A@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 27353: Images mispositioned on photo page
https://bugs.webkit.org/show_bug.cgi?id=27353

Attachment 32894: Patch
https://bugs.webkit.org/attachment.cgi?id=32894&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 14:56:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 14:56:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27354] cpplint should check
 for one line control statements surrounded by braces : [Attachment 32895]
 Add the cpplint check
In-Reply-To: <bug-27354-0@https.bugs.webkit.org/>
References: <bug-27354-0@https.bugs.webkit.org/>
Message-ID: <20090716215612.99D31335FCB8@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27354: cpplint should check for one line control statements surrounded by
braces
https://bugs.webkit.org/show_bug.cgi?id=27354

Attachment 32895: Add the cpplint check
https://bugs.webkit.org/attachment.cgi?id=32895&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 15:26:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 15:26:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 24187] RTL: tooltip does not
 get its directionality from its element's directionality : [Attachment
 31953] patch w/o layout test (version 2)
In-Reply-To: <bug-24187-0@https.bugs.webkit.org/>
References: <bug-24187-0@https.bugs.webkit.org/>
Message-ID: <20090716222607.0D50E336076D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 31953: patch w/o layout test (version 2)
https://bugs.webkit.org/attachment.cgi?id=31953&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The real patch is the other one.

From bugzilla-daemon at webkit.org  Thu Jul 16 15:27:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 15:27:23 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27354] cpplint should check
 for one line control statements surrounded by braces : [Attachment 32895]
 Add the cpplint check
In-Reply-To: <bug-27354-0@https.bugs.webkit.org/>
References: <bug-27354-0@https.bugs.webkit.org/>
Message-ID: <20090716222723.D9C30336081C@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Adam Treat <treat at kde.org>'s
request for review:
Bug 27354: cpplint should check for one line control statements surrounded by
braces
https://bugs.webkit.org/show_bug.cgi?id=27354

Attachment 32895: Add the cpplint check
https://bugs.webkit.org/attachment.cgi?id=32895&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This is awesome!  This is another issue happens fairly frequently and would be
nice to tell people about ahead of their review.

I just have a few things to address/respond to, and then we'll be done.


> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> +	   previous_line = get_previous_non_blank_line(clean_lines,
line_number-1)[0]

I don't think using "get_previous_non_blank_line" is quite right because it
would flag this case
  if (condition) {
      // Some comment
      doIt();
  }
as needing to get right of the braces and the braces should remain in this
case.  I wonder if it should just do this instead:

clean_lines.elided[line_number - 2]


> +	   if (previous_line.find('{') > 0
> +	       and search (r'\b(if|for|while|switch)\b', previous_line)):

1. Remove space after search.
2. Remove "switch"
3. Add "else"


> +	       error(filename, line_number, 'whitespace/braces', 4,

At first this didn't seem like it fit the category of "whitespace" (which in my
mind is adding deleting spaces/blank lines).  I was going to suggest
"readability/"
However after further consideration, getting rid of braces decreases blank
lines so it actually does seem concerned with that after all.


> +		     'This } does not belong as one line control clauses should
not use braces')

It seems odd to say that the "}" doesn't belong.  How about just going with
something very close to style guide text: "Single-line control clauses should
not use braces." ?



> diff --git a/WebKitTools/Scripts/modules/cpplint_unittest.py
b/WebKitTools/Scripts/modules/cpplint_unittest.py
> +	   self.assert_multi_line_lint(
> +	       'if (true) {\n'
> +	       '    int foo;\n'
> +	       '}\n',
> +	       'This } does not belong as one line control clauses should not
use braces  [whitespace/braces] [4]')
> +

1. Add a test cases for: for,while,else
2. Add a test cases for:
a.  if (condition) {
	// Some comment
	doIt();
   }

b. if (condition) {
       myFunction(reallyLongParam1, reallyLongParam2,
		  reallyLongParam3);
   }

That verifies that these cases don't get flagged.

From bugzilla-daemon at webkit.org  Thu Jul 16 15:33:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 15:33:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27318] Allow LocalStorage
 to be enabled without enabling SessionStorage : [Attachment 32897] v2
In-Reply-To: <bug-27318-0@https.bugs.webkit.org/>
References: <bug-27318-0@https.bugs.webkit.org/>
Message-ID: <20090716223332.1E6123360A46@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32897: v2
https://bugs.webkit.org/attachment.cgi?id=32897&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Cleaned up the way we access the settings per Darin F.

From bugzilla-daemon at webkit.org  Thu Jul 16 15:37:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 15:37:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32898] Proposed patch, rev.3
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090716223741.309633360BDB@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32898: Proposed patch, rev.3
https://bugs.webkit.org/attachment.cgi?id=32898&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 15:57:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 15:57:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32890] Fixes, part 1
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090716225704.DB65E3361272@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32890: Fixes, part 1
https://bugs.webkit.org/attachment.cgi?id=32890&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Clearing flags since I landed a modified version of this in r44993.

From bugzilla-daemon at webkit.org  Thu Jul 16 16:05:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:05:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32899] Fixes, part 2
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090716230553.59C7233615F3@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked David Kilzer (ddkilzer)
<ddkilzer at webkit.org> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32899: Fixes, part 2
https://bugs.webkit.org/attachment.cgi?id=32899&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
ddkilzer: aroben suggested you were the right person to review this.

The motivation behind this is that it's possible for at least Chromium (perhaps
other ports) to have a layered checkout, with the top level being from the
Chromium repo and a subdirectory ("WebKit/") being from the WebKit repo.  This
makes it possible to test WK changes directly in a Chromium build and then
submit without having to copy things over to a separate checkout (error-prone).
 This works well except that svn-create-patch gets confused about the checkout
root, so here I modify the algorithm to halt when we see a different Repository
Root than we started with (or no root at all, if we're in a standalone WK
checkout).

From bugzilla-daemon at webkit.org  Thu Jul 16 16:09:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:09:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27037] Fix baselines for
 inline tables. : [Attachment 32388] patch
In-Reply-To: <bug-27037-0@https.bugs.webkit.org/>
References: <bug-27037-0@https.bugs.webkit.org/>
Message-ID: <20090716230920.617013361713@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27037: Fix baselines for inline tables.
https://bugs.webkit.org/show_bug.cgi?id=27037

Attachment 32388: patch
https://bugs.webkit.org/attachment.cgi?id=32388&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch fails the following tests:

editing/pasteboard/innerText-inline-table.html
editing/selection/iframe.html
editing/selection/inline-table.html
editing/selection/table-caret-3.html
fast/css-generated-content/inline-display-types.html
fast/encoding/utf-16-big-endian.html
fast/encoding/utf-16-little-endian.html
fast/inline-block/001.html
fast/invalid/residual-style.html
fast/repaint/float-overflow-right.html
fast/repaint/float-overflow.html
http/tests/misc/redirect-to-about-blank.html
tables/mozilla/bugs/bug2479-2.html

From bugzilla-daemon at webkit.org  Thu Jul 16 16:11:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:11:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32782] updated patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090716231143.0AF4833617E9@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32782: updated patch
https://bugs.webkit.org/attachment.cgi?id=32782&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please post an updated patch with the nits addressed.  Removing from commit
queue.

From bugzilla-daemon at webkit.org  Thu Jul 16 16:13:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:13:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 32888] patch 0.2 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090716231352.971FC3361895@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 32888: patch 0.2 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=32888&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
cleanring review flag ... improvements to come !

From bugzilla-daemon at webkit.org  Thu Jul 16 16:34:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:34:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26747] REGRESSION (r41238)
 Repainted portion of a scaled image does not line up with full image :
 [Attachment 32900] Patch
In-Reply-To: <bug-26747-0@https.bugs.webkit.org/>
References: <bug-26747-0@https.bugs.webkit.org/>
Message-ID: <20090716233447.7413F33620C7@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 26747: REGRESSION (r41238) Repainted portion of a scaled image does not
line up with full image
https://bugs.webkit.org/show_bug.cgi?id=26747

Attachment 32900: Patch
https://bugs.webkit.org/attachment.cgi?id=32900&action=review

------- Additional Comments from mitz at webkit.org
Updated the previous patch. Added clipping to the destination rect?drawPattern
already does that, so we already have subpixel gaps in that case.

From bugzilla-daemon at webkit.org  Thu Jul 16 16:34:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:34:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32899] Fixes, part 2
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090716233448.AE2F733620CF@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32899: Fixes, part 2
https://bugs.webkit.org/attachment.cgi?id=32899&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
>      my $path = '.';
>      my $parent = '../';
>      my $devnull = File::Spec->devnull();
> -    my $exitCode;
> +    my $repositoryRoot;
>      while (1) {
> -	   $exitCode = system("svn info $path 2> $devnull > $devnull")/256;
> -	   last if $exitCode;
> +	   my $thisRoot;
> +	   open INFO, "svn info '$path' |" or die;
> +	   while (<INFO>) {
> +	       if (/^Repository Root: (.+)/) {
> +		   $thisRoot = $1;
> +	       }
> +	   }
> +	   close INFO;
> +
> +	   # It's possible (e.g. for developers of some ports) to have a WebKit

> +	   # checkout in a subdirectory of another checkout.  So abort if the
> +	   # repository root suddenly changes.
> +	   last if !$thisRoot;
> +	   if (!$repositoryRoot) {
> +	       $repositoryRoot = $thisRoot;
> +	   }
> +	   last if $thisRoot ne $repositoryRoot;
> +
>	   $last = $path;
>	   $path = $parent . $path;
>      }

This change looks fine.  I notice another change that I missed in Bug 26999
that could be made to make the code a bit more Windows- (or non-UNIX-)
friendly:

-      my $parent = '../';
+      my $parent = '..';

-	   $path = $parent . $path;
+	   $path = File::Spec->catdir($parent, $path);

Feel free to make this change if you'd like, but it's not necessary.

r=me

From bugzilla-daemon at webkit.org  Thu Jul 16 16:41:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:41:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27327] [Chromium] Clean up
 v8 bindings a bit : [Attachment 32901] rev 3
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090716234102.CCBCB3362299@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32901: rev 3
https://bugs.webkit.org/attachment.cgi?id=32901&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Made the change Mads suggested.

Also a disclaimer that I should have made earlier: I know nothing about the
Inspector, nothing about this code, and only some about the bindings in
general.  This stuff is definitely over my head.  I'm only doing it because
hitting the NOTIMPLEMENTED was blocking me from enabling DOM_STORAGE.  The
inspector has seemingly worked even after the previously buggy implementations,
so please take a close look before you r+ it.  That said, we really need to get
this in before we can go much further in enabling DOM storage.

From bugzilla-daemon at webkit.org  Thu Jul 16 16:46:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 16:46:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32899] Fixes, part 2
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090716234613.454403362466@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32899: Fixes, part 2
https://bugs.webkit.org/attachment.cgi?id=32899&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r45998, clearing flags.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:02:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:02:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27318] Allow LocalStorage to
 be enabled without enabling SessionStorage : [Attachment 32897] v2
In-Reply-To: <bug-27318-0@https.bugs.webkit.org/>
References: <bug-27318-0@https.bugs.webkit.org/>
Message-ID: <20090717000238.15F0A3362A68@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32897: v2
https://bugs.webkit.org/attachment.cgi?id=32897&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks good, but two nits:

> -    Document* document = m_frame->document();
> +    Settings* settings = page->settings();
> +    if (!settings->sessionStorageEnabled())
> +	   return 0;

If settings isn't used by the rest of this function, then you don't need to
make a variable for it.

>      , m_localStorageEnabled(false)
> +    , m_sessionStorageEnabled(true)

Why do these have different defaults?

From bugzilla-daemon at webkit.org  Thu Jul 16 17:06:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:06:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27354] cpplint should check
 for one line control statements surrounded by braces : [Attachment 32902]
 Second version
In-Reply-To: <bug-27354-0@https.bugs.webkit.org/>
References: <bug-27354-0@https.bugs.webkit.org/>
Message-ID: <20090717000600.705883362B96@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27354: cpplint should check for one line control statements surrounded by
braces
https://bugs.webkit.org/show_bug.cgi?id=27354

Attachment 32902: Second version
https://bugs.webkit.org/attachment.cgi?id=32902&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 17:08:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:08:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32903]
 Resize Attached Inspector
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090717000832.394F13362C93@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked Adam Roben (aroben)
<aroben at apple.com> for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32903: Resize Attached Inspector
https://bugs.webkit.org/attachment.cgi?id=32903&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 17:15:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:15:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32904] Fixes, part 3
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717001520.12D7C3362EBF@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked Steve Falkenburg
<sfalken at apple.com> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32904: Fixes, part 3
https://bugs.webkit.org/attachment.cgi?id=32904&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
While this patch looks large, it's just a search-and-replace of:

set PATH=%SystemDrive%\cygwin\bin;%PATH%

...with:

%SystemDrive%\cygwin\bin\which.exe bash&#x0D;&#x0A;if errorlevel 1 set
PATH=%SystemDrive%\cygwin\bin;%PATH%

There is one place I didn't touch:
JavaScriptCore/JavaScriptCore.vcproj/JavaScriptCore.make.  I wasn't sure what
the right syntax in here was (I don't know makefiles) or even what this
makefile was used for.	Feel free to give direction.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:15:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:15:42 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26948] Need to refactor Worker
 to derive from AbstractWorker : [Attachment 32892] proposed patch (fixed
 problem with previous patch that prevent V8 bindings from compiling)
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090717001542.016C03362EFC@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32892: proposed patch (fixed problem with previous patch that
prevent V8 bindings from compiling)
https://bugs.webkit.org/attachment.cgi?id=32892&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few thing to address (one nit and one bug).

> diff --git a/WebCore/bindings/js/JSWorkerCustom.cpp
b/WebCore/bindings/js/JSWorkerCustom.cpp
> @@ -42,40 +40,7 @@ void JSWorker::mark()
>  {
>      DOMObject::mark();

I think this should be JSAbstractWorker::mark(); or even better just
"Base::mark();" (and then this would have not have needed to change).



> diff --git a/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
b/WebCore/bindings/v8/custom/V8WorkerCustom.cpp
> -    if (args.Length() == 0) {
> +    if (args.Length() == 0)
If you're going to fix the style here

       if (!args.Length())

is what you want.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:17:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:17:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27318] Allow LocalStorage
 to be enabled without enabling SessionStorage : [Attachment 32905] v3
In-Reply-To: <bug-27318-0@https.bugs.webkit.org/>
References: <bug-27318-0@https.bugs.webkit.org/>
Message-ID: <20090717001731.903FD3362FD8@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32905: v3
https://bugs.webkit.org/attachment.cgi?id=32905&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
We now do page->settings()-> rather than saving page->settings() to a local
variable.

I also updated the change log to explain why SessionStorage is on by default.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:18:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:18:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32369] Proposed patch (rev.3)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090717001821.8728A336304B@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32369: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=32369&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 17:20:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:20:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27318] Allow LocalStorage to
 be enabled without enabling SessionStorage : [Attachment 32905] v3
In-Reply-To: <bug-27318-0@https.bugs.webkit.org/>
References: <bug-27318-0@https.bugs.webkit.org/>
Message-ID: <20090717002010.549CC3363106@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27318: Allow LocalStorage to be enabled without enabling SessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27318

Attachment 32905: v3
https://bugs.webkit.org/attachment.cgi?id=32905&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Looks great.  Thanks for the explanation.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:21:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:21:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27354] cpplint should check
 for one line control statements surrounded by braces : [Attachment 32902]
 Second version
In-Reply-To: <bug-27354-0@https.bugs.webkit.org/>
References: <bug-27354-0@https.bugs.webkit.org/>
Message-ID: <20090717002101.9D3AE3363138@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27354: cpplint should check for one line control statements surrounded by
braces
https://bugs.webkit.org/show_bug.cgi?id=27354

Attachment 32902: Second version
https://bugs.webkit.org/attachment.cgi?id=32902&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> +    if (match(r'\s*}\s*$', line)
> +	   and line_number > 1):

You might as well put this on one line.  In general, feel free to make the
lines as long as you wish.  (Most of the code was developed using 80 characters
limits so sometimes it seems to do weird line wrappings to meet this
requirement.)


> +	   # We check if a closed brace has started a line to see if a
> +	   # one line control statement was previous

Nice to add a "." to the end of your sentence.

> +	   previous_line = clean_lines.elided[line_number - 2]
> +	   if (previous_line.find('{') > 0
> +	       and search(r'\b(if|for|while|else)\b', previous_line)):
> +	       error(filename, line_number, 'whitespace/braces', 4,
> +		     'One line control clauses should not use braces')

Nice to add a "." to the end of your sentence.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:33:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:33:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24187] RTL: tooltip does
 not get its directionality from its element's directionality : [Attachment
 32906] patch to fix compilation error in gtk and qt
In-Reply-To: <bug-24187-0@https.bugs.webkit.org/>
References: <bug-24187-0@https.bugs.webkit.org/>
Message-ID: <20090717003319.07C38336351B@gamma.macosforge.org>

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 32906: patch to fix compilation error in gtk and qt
https://bugs.webkit.org/attachment.cgi?id=32906&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 17:33:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:33:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26747] REGRESSION (r41238)
 Repainted portion of a scaled image does not line up with full image :
 [Attachment 32900] Patch
In-Reply-To: <bug-26747-0@https.bugs.webkit.org/>
References: <bug-26747-0@https.bugs.webkit.org/>
Message-ID: <20090717003342.EAF323363555@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 26747: REGRESSION (r41238) Repainted portion of a scaled image does not
line up with full image
https://bugs.webkit.org/show_bug.cgi?id=26747

Attachment 32900: Patch
https://bugs.webkit.org/attachment.cgi?id=32900&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 17:34:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:34:43 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24187] RTL: tooltip does not
 get its directionality from its element's directionality : [Attachment
 32906] patch to fix compilation error in gtk and qt
In-Reply-To: <bug-24187-0@https.bugs.webkit.org/>
References: <bug-24187-0@https.bugs.webkit.org/>
Message-ID: <20090717003443.D2A49336359E@gamma.macosforge.org>

mitz at webkit.org has granted Xiaomei Ji <xji at chromium.org>'s request for review:
Bug 24187: RTL: tooltip does not get its directionality from its element's
directionality
https://bugs.webkit.org/show_bug.cgi?id=24187

Attachment 32906: patch to fix compilation error in gtk and qt
https://bugs.webkit.org/attachment.cgi?id=32906&action=review

------- Additional Comments from mitz at webkit.org
Build fixes like this do not require a review (although it is okay to request a
review).

From bugzilla-daemon at webkit.org  Thu Jul 16 17:36:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:36:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27358] [Qt] Fix the include
 path for the Symbian port : [Attachment 32907] Proposed fix.
In-Reply-To: <bug-27358-0@https.bugs.webkit.org/>
References: <bug-27358-0@https.bugs.webkit.org/>
Message-ID: <20090717003629.17B92336366A@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27358: [Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

Attachment 32907: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32907&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Started as a build fix; ended up being a lot of cleanup.

This patch puts the system includes at the end of the include path, so that
when the include path is built up new (more specific) path elements are
prepended (and not appended) to the include path. For example the include path
for WebCore looks like this:
 - Qt port specific dirs
 - Port independent WebCore dirs
 - JavaScriptCore dirs
 - System includes.

In addition the patch includes the following cleanups:
 - Sorted the include lists
 - Fixed the Qt port specific include list (so that it only includes Qt port
specific dirs and it includes all of those)
 - Removed WebCore/ForwardingHeaders from WebCore include path (as
JavaScriptCore.pri is included). This should make the build a bit faster.

Tested on Linux/Windows/Symbian.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:55:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:55:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27275] Chromium popup menus
 can crash when the selected index is -1 : [Attachment 32738] Fix for
 crashing with invalid index.
In-Reply-To: <bug-27275-0@https.bugs.webkit.org/>
References: <bug-27275-0@https.bugs.webkit.org/>
Message-ID: <20090717005502.D0D223363CA9@gamma.macosforge.org>

Paul Godavari <paul at chromium.org> has canceled Paul Godavari
<paul at chromium.org>'s request for review:
Bug 27275: Chromium popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 32738: Fix for crashing with invalid index.
https://bugs.webkit.org/attachment.cgi?id=32738&action=review

------- Additional Comments from Paul Godavari <paul at chromium.org>
Update the patch to more thoroughly enforce correct vector index values through
out PopupListBox.

From bugzilla-daemon at webkit.org  Thu Jul 16 17:55:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 17:55:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27275] Chromium popup menus
 can crash when the selected index is -1 : [Attachment 32908] Updated fix
 for an invalid vector index crash
In-Reply-To: <bug-27275-0@https.bugs.webkit.org/>
References: <bug-27275-0@https.bugs.webkit.org/>
Message-ID: <20090717005502.EE99D3363CAD@gamma.macosforge.org>

Paul Godavari <paul at chromium.org> has asked  for review:
Bug 27275: Chromium popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 32908: Updated fix for an invalid vector index crash
https://bugs.webkit.org/attachment.cgi?id=32908&action=review

------- Additional Comments from Paul Godavari <paul at chromium.org>
Update the patch to more thoroughly enforce correct vector index values through
out PopupListBox.

From bugzilla-daemon at webkit.org  Thu Jul 16 18:14:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 18:14:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32909] Patch addressing
 Levin's comments
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090717011451.BE6EE33642A4@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32909: Patch addressing Levin's comments
https://bugs.webkit.org/attachment.cgi?id=32909&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 18:41:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 18:41:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32909] Patch addressing
 Levin's comments
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090717014133.888D43364A77@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32909: Patch addressing Levin's comments
https://bugs.webkit.org/attachment.cgi?id=32909&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 18:47:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 18:47:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27359] [V8] Centralize
 hidden property names : [Attachment 32910] patch
In-Reply-To: <bug-27359-0@https.bugs.webkit.org/>
References: <bug-27359-0@https.bugs.webkit.org/>
Message-ID: <20090717014756.183073364C2A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27359: [V8] Centralize hidden property names
https://bugs.webkit.org/show_bug.cgi?id=27359

Attachment 32910: patch
https://bugs.webkit.org/attachment.cgi?id=32910&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 19:07:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 19:07:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27359] [V8] Centralize hidden
 property names : [Attachment 32910] patch
In-Reply-To: <bug-27359-0@https.bugs.webkit.org/>
References: <bug-27359-0@https.bugs.webkit.org/>
Message-ID: <20090717020746.0566633651A7@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27359: [V8] Centralize hidden property names
https://bugs.webkit.org/show_bug.cgi?id=27359

Attachment 32910: patch
https://bugs.webkit.org/attachment.cgi?id=32910&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/bindings/v8/V8HiddenPropertyName.cpp
> +    static v8::Persistent<v8::String>* string = new
v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbo
l(key)));

It seems a shame to repeat "new
v8::Persistent<v8::String>(v8::Persistent<v8::String>::New(v8::String::NewSymbo
l(key)))" twice already in this file.

What about a function so this line of code would look something like this 
   static v8::Persistent<v8::String>* string = createV8PeristentString(key)
?

From bugzilla-daemon at webkit.org  Thu Jul 16 19:43:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 19:43:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27351] [Qt]
 navigator.platform returns an empty string in Symbian and in Linux
 platforms : [Attachment 32911] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090717024323.749E63365C4A@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32911: Patch
https://bugs.webkit.org/attachment.cgi?id=32911&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Add #define for Symbian platform.
Use uname to determine the OS name and CPU , but limit it to Linux platform
only.
(I am not able to test other platforms).

From bugzilla-daemon at webkit.org  Thu Jul 16 20:33:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 20:33:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27360] [Chromium] Fix build
 with DOM_STORAGE enabled. : [Attachment 32912] v1
In-Reply-To: <bug-27360-0@https.bugs.webkit.org/>
References: <bug-27360-0@https.bugs.webkit.org/>
Message-ID: <20090717033354.962C93366BD4@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27360: [Chromium] Fix build with DOM_STORAGE enabled.
https://bugs.webkit.org/show_bug.cgi?id=27360

Attachment 32912: v1
https://bugs.webkit.org/attachment.cgi?id=32912&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
* bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .ccp files.
* storage/StorageAreaImpl.cpp:	#include "DOMWindow.h"

I'm sorry this didn't get attached to my previous v8 patch, but I _think_ this
is the last change that needs to be made.

From bugzilla-daemon at webkit.org  Thu Jul 16 21:09:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 21:09:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27360] [Chromium] Fix build
 with DOM_STORAGE enabled. : [Attachment 32912] v1
In-Reply-To: <bug-27360-0@https.bugs.webkit.org/>
References: <bug-27360-0@https.bugs.webkit.org/>
Message-ID: <20090717040920.C38B733675E8@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27360: [Chromium] Fix build with DOM_STORAGE enabled.
https://bugs.webkit.org/show_bug.cgi?id=27360

Attachment 32912: v1
https://bugs.webkit.org/attachment.cgi?id=32912&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Two nits which I can fix up on landing.

> Index: WebCore/ChangeLog
> +	   * bindings/v8/DerivedSourcesAllInOne.cpp: Add the generated .ccp
files.
Typo: ccp

> Index: WebCore/storage/StorageAreaImpl.cpp

>  #include "EventNames.h"
>  #include "ExceptionCode.h"
> +#include "DOMWindow.h"
>  #include "Frame.h"

Out of alphabetical order.

From bugzilla-daemon at webkit.org  Thu Jul 16 21:25:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 21:25:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32914] Proposed patch (rev.4)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090717042531.0E0343367AE9@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32914: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=32914&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Disables the test for non-Mac.

From bugzilla-daemon at webkit.org  Thu Jul 16 21:30:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 21:30:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26505] Value of file upload
 forms for non-multipart methods : [Attachment 32914] Proposed patch (rev.4)
In-Reply-To: <bug-26505-0@https.bugs.webkit.org/>
References: <bug-26505-0@https.bugs.webkit.org/>
Message-ID: <20090717043054.0B6A43367CB7@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 26505: Value of file upload forms for non-multipart methods
https://bugs.webkit.org/show_bug.cgi?id=26505

Attachment 32914: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=32914&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks for updating the patch.

From bugzilla-daemon at webkit.org  Thu Jul 16 22:46:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:46:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32220] Patch to add Haiku-specific files
 for WebCore/platform/text/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717054627.188AD3369305@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32220: Patch to add Haiku-specific files for WebCore/platform/text/.
https://bugs.webkit.org/attachment.cgi?id=32220&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 22:46:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:46:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32221] Patch to add Haiku-specific files
 for WebCore/bindings/js/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717054643.394AA336931F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32221: Patch to add Haiku-specific files for WebCore/bindings/js/.
https://bugs.webkit.org/attachment.cgi?id=32221&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 22:46:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:46:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32222] Patch to add Haiku-specific files
 for WebCore/editing/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717054658.6C6E33369337@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32222: Patch to add Haiku-specific files for WebCore/editing/.
https://bugs.webkit.org/attachment.cgi?id=32222&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 22:47:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:47:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32223] Patch to add Haiku-specific files
 for WebCore/page/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717054714.0DA383369353@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32223: Patch to add Haiku-specific files for WebCore/page/.
https://bugs.webkit.org/attachment.cgi?id=32223&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 22:47:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:47:30 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32364] Patch to add Haiku-specific files
 for WebCore/platform/image-decoders/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717054730.14A88336936D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32364: Patch to add Haiku-specific files for
WebCore/platform/image-decoders/.
https://bugs.webkit.org/attachment.cgi?id=32364&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 22:50:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:50:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27206] Add --web-sockets
 flag and ENABLE_WEB_SOCKETS define : [Attachment 32698] Add "Web Sockets"
 feature configuration.
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090717055018.BA5AB3369456@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has canceled  review:
Bug 27206: Add --web-sockets flag and ENABLE_WEB_SOCKETS define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32698: Add "Web Sockets" feature configuration.
https://bugs.webkit.org/attachment.cgi?id=32698&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 22:50:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 22:50:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27206] Add --web-sockets
 flag and ENABLE_WEB_SOCKETS define : [Attachment 32915] Add --web-sockets
 flag and ENABLE_WEB_SOCKETS define
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090717055022.D94A43369465@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27206: Add --web-sockets flag and ENABLE_WEB_SOCKETS define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32915: Add --web-sockets flag and ENABLE_WEB_SOCKETS define
https://bugs.webkit.org/attachment.cgi?id=32915&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 15 files changed, 106 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 23:02:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:02:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32230] Patch to add ContextMenuClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090717060228.72634336986A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32230: Patch to add ContextMenuClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32230&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:02:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:02:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32231] Patch to add DragClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090717060243.C84BC336987F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32231: Patch to add DragClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32231&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:02:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:02:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32232] Patch to add EditorClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090717060259.322BA336989B@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32232: Patch to add EditorClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32232&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:03:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:03:00 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27209] Add WebSocket.idl :
 [Attachment 32705] add WebSocket.idl and its implementation and bindings
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090717060300.6278C33698A6@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has canceled Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 32705: add WebSocket.idl and its implementation and bindings
https://bugs.webkit.org/attachment.cgi?id=32705&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:03:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:03:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27209] Add WebSocket.idl :
 [Attachment 32916] add WebSocket.idl
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090717060304.4F9AB33698BC@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 32916: add WebSocket.idl
https://bugs.webkit.org/attachment.cgi?id=32916&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 7 files changed, 629 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 16 23:03:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:03:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32234] Patch to add InspectorClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090717060315.C6E1833698D6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32234: Patch to add InspectorClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32234&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:14:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:14:15 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27206] Add --web-sockets flag
 and ENABLE_WEB_SOCKETS define : [Attachment 32915] Add --web-sockets flag
 and ENABLE_WEB_SOCKETS define
In-Reply-To: <bug-27206-0@https.bugs.webkit.org/>
References: <bug-27206-0@https.bugs.webkit.org/>
Message-ID: <20090717061415.F0CFF3369C66@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27206: Add --web-sockets flag and ENABLE_WEB_SOCKETS define
https://bugs.webkit.org/show_bug.cgi?id=27206

Attachment 32915: Add --web-sockets flag and ENABLE_WEB_SOCKETS define
https://bugs.webkit.org/attachment.cgi?id=32915&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:29:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:29:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
 [Attachment 31858] Modifications on WebKit source code to allow Haiku port.
 (including ChangeLogs)
In-Reply-To: <bug-26620-0@https.bugs.webkit.org/>
References: <bug-26620-0@https.bugs.webkit.org/>
Message-ID: <20090717062921.CF912336A295@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 31858: Modifications on WebKit source code to allow Haiku port.
(including ChangeLogs)
https://bugs.webkit.org/attachment.cgi?id=31858&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I'm sorry, but this patch no longer applies to top-of-tree.  DateMath.cpp has
changed a bit and it's not obvious to me how to merge the patch.

From bugzilla-daemon at webkit.org  Thu Jul 16 23:41:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:41:45 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32301] Patch to add a second bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090717064145.6C4D6336A6B9@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32301: Patch to add a second bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32301&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:42:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:42:03 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32302] Patch to add a third bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090717064203.C8783336A6DA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32302: Patch to add a third bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32302&action=review

From bugzilla-daemon at webkit.org  Thu Jul 16 23:44:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 16 Jul 2009 23:44:38 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26620] Haiku WebKit port :
 [Attachment 32049] Patch to add Haiku-specific files for JavaScriptCore.
In-Reply-To: <bug-26620-0@https.bugs.webkit.org/>
References: <bug-26620-0@https.bugs.webkit.org/>
Message-ID: <20090717064438.2AC68336A805@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32049: Patch to add Haiku-specific files for JavaScriptCore.
https://bugs.webkit.org/attachment.cgi?id=32049&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I guess i need to clear this flag to remove this bug from the commit queue.

From bugzilla-daemon at webkit.org  Fri Jul 17 00:00:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 00:00:37 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27316] [Qt] more than 100
 tests in Qt's DRT Skipped list works for me : [Attachment 32816] Remove
 tests from Qt Skipped list that are actually working.
In-Reply-To: <bug-27316-0@https.bugs.webkit.org/>
References: <bug-27316-0@https.bugs.webkit.org/>
Message-ID: <20090717070037.F104E336AD96@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27316: [Qt] more than 100 tests in Qt's DRT Skipped list works for me
https://bugs.webkit.org/show_bug.cgi?id=27316

Attachment 32816: Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/attachment.cgi?id=32816&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I confirm that this patch does not apply to TOT, which makes this patch not
actionable.  Please upload a new version that applies cleanly.

From bugzilla-daemon at webkit.org  Fri Jul 17 00:05:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 00:05:16 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26948] Need to refactor Worker
 to derive from AbstractWorker : [Attachment 32909] Patch addressing Levin's
 comments
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090717070516.ED50C336AF4C@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied  review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32909: Patch addressing Levin's comments
https://bugs.webkit.org/attachment.cgi?id=32909&action=review

------- Additional Comments from David Levin <levin at chromium.org>
LayoutTests/fast/workers/worker-constructor.html fails to apply cleanly. 
Please update the patch and I'll review/land ot promptly.

From bugzilla-daemon at webkit.org  Fri Jul 17 00:14:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 00:14:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26620] Haiku WebKit port :
 [Attachment 32917] Modifications on WebKit source code to allow Haiku port.
In-Reply-To: <bug-26620-0@https.bugs.webkit.org/>
References: <bug-26620-0@https.bugs.webkit.org/>
Message-ID: <20090717071455.BA4AB336B2FD@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32917: Modifications on WebKit source code to allow Haiku port.
https://bugs.webkit.org/attachment.cgi?id=32917&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Concerning the issue with DateMath.cpp, as the issue had move to another place
there is no more modifications in this file.

From bugzilla-daemon at webkit.org  Fri Jul 17 00:19:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 00:19:06 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25526] [Gtk] Additional
 support is needed for caret browsing : [Attachment 30045]
 textselectionchanged.patch
In-Reply-To: <bug-25526-0@https.bugs.webkit.org/>
References: <bug-25526-0@https.bugs.webkit.org/>
Message-ID: <20090717071906.D8E8C336B47D@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has canceled  review:
Bug 25526: [Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Attachment 30045: textselectionchanged.patch
https://bugs.webkit.org/attachment.cgi?id=30045&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
This patch got landed, clear review to make it drop out of the review queue.

From bugzilla-daemon at webkit.org  Fri Jul 17 00:19:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 00:19:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25526] [Gtk] Additional
 support is needed for caret browsing : [Attachment 30044] textcaretv2.patch
In-Reply-To: <bug-25526-0@https.bugs.webkit.org/>
References: <bug-25526-0@https.bugs.webkit.org/>
Message-ID: <20090717071954.E5267336B4DF@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has canceled  review:
Bug 25526: [Gtk] Additional support is needed for caret browsing
https://bugs.webkit.org/show_bug.cgi?id=25526

Attachment 30044: textcaretv2.patch
https://bugs.webkit.org/attachment.cgi?id=30044&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 00:32:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 00:32:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27345] [UNIX]
 TestNetscapePlugin for Unix (X11) can not be loaded in gecko : [Attachment
 32866] [GTK+] Make TestNescpaePlugin loadable in mozilla
In-Reply-To: <bug-27345-0@https.bugs.webkit.org/>
References: <bug-27345-0@https.bugs.webkit.org/>
Message-ID: <20090717073217.83AAD336B912@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 27345: [UNIX] TestNetscapePlugin for Unix (X11) can not be loaded in gecko
https://bugs.webkit.org/show_bug.cgi?id=27345

Attachment 32866: [GTK+] Make TestNescpaePlugin loadable in mozilla
https://bugs.webkit.org/attachment.cgi?id=32866&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me, I guess the same applies to the check below?

From bugzilla-daemon at webkit.org  Fri Jul 17 02:13:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:13:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32919] Patch v2
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717091339.7FB7B336DB91@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32919: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32919&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 9 files changed, 137 insertions(+), 5 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 02:14:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:14:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32919] Patch v2
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717091441.A781D336DBE5@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32919: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32919&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 02:14:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:14:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32920] Patch v1
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717091446.21647336DBFB@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32920: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32920&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 312 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 02:19:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:19:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32920] Patch v1
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717091910.D7B8E336DD60@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32920: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32920&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 02:19:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:19:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32921] Patch v2
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717091915.9CE21336DD7A@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32921: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32921&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 1 files changed, 2 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 02:21:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:21:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32921] Patch v2
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717092129.0995C336DE4C@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32921: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32921&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 02:21:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 02:21:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32922] Patch v3
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717092133.C012A336DE63@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32922: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32922&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 313 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 03:12:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:12:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32923] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717101259.12D32336EE7D@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32923: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32923&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 03:23:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:23:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27363] Add a parser of patches
 for linter : [Attachment 32922] Patch v3
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717102351.168FC336F1B2@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32922: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32922&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Nice to see this patch.  Just a few things to address.


> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
...
> +	   Now, the parser doesn't have full information of patches.
> +	   It only knows the line number and line contents of each lines in
> +	   chunks of a patch.  In case the line is newly added or deleted, it
> +	   sets zero as the line number.

In isolation from the code, this comment is a bit confusing.  I think it is
sufficient to say something like this here:

Adds a simple parser for unified diff format.

> diff --git a/WebKitTools/Scripts/modules/diff_parser.py
b/WebKitTools/Scripts/modules/diff_parser.py
...
> +def match(pattern, string):
> +    """Matches the string with the pattern, caching the compiled regexp."""
> +    # The regexp compilation caching is inlined in both match and search for

> +    # performance reasons; factoring it out into a separate function turns
out
> +    # to be noticeably expensive.

I'd remove this comment as there is no search function.  (The comment is a
carry over from the cpplint.py file where there is.)

> +# FIXME: We may need more states if we want to check the integrity of input
patches.

I think it is fine to omit this fixme.	If someone wants to check integrity,
they can do the appropriate changes.

> +class DiffFile:
> +    """Hold information of a file in a patch.

Consider: Contains the information for one file in a patch.

> +    The field "lines" is a list which contains tuples which represent

Consider: The field "lines" is a list which contains tuples in this format:

> +    # FIXME: We only have information of lines in chunks. Need more info?

I think it is fine to omit this FIXME.	If someone wants more information, they
can enhance this code.

> +    def add_new_line(self, line_number, line):
> +	   """Adds a newly added line."""

I would just omit this doc string as it doesn't add any information.

> +    def add_old_line(self, line_number, line):

add_deleted_line seems like a better name.

> +	   """Adds a deleted line."""

Remove this doc string.

> +    def add_unchanged_line(self, old_line_number, new_line_number, line):
> +	   """Adds an unchanged line."""

Remove this doc string.

> +    def __init__(self, diff_input):
> +	   """Parses a diff.
> +
> +	   Args:
> +	     diff_input: An iteratable object.

An iterable object

> +		   elif line == '\\ No newline at end of file\n':
> +		       # Nothing to do.  We may still have some added lines.
> +		       # FIXME: Check if the following lines only contain added
lines?

I don't understand this FIXME. (I guess I really don't understand how there are
added lines after the "no newline at end of line" in the diff.)

> +	       # The following kinds of lines will be ignored silently:
> +	       #
> +	       # - Lines git-diff-tree produces before filename
> +	       #   declaration, which contains a hash of a patch.
> +	       # - '='*67 lines between filename declaration and file
> +	       #   revision declaration.
> +	       # - Lines for revision declaration.
> +	       #
> +	       # FIXME: Need these info?

I think it is fine to omit this FIXME and perhaps the whole note.  It seems
clear that this information isn't used.


> diff --git a/WebKitTools/Scripts/modules/diff_parser_unittest.py
b/WebKitTools/Scripts/modules/diff_parser_unittest.py
...
> +    def test_diff_parser(self):
...
> +	   # The first file looks OK, let's check the next, more complicated
file.

Add a period here:
	# The first file looks OK. Let's check the next, more complicated file.


> +	   # Look through the last chunk, which contains both add/delete.
Consider this wording:
	# Look through the last chunk, which contains both add's and delete's.

From bugzilla-daemon at webkit.org  Fri Jul 17 03:25:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:25:50 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32856] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717102550.7B0A9336F25E@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32856: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32856&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
I made some style cleanup (thanks to the cpplint.py tool).

From bugzilla-daemon at webkit.org  Fri Jul 17 03:25:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:25:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32924] Patch to add Haiku-specific font
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717102550.8DB7C336F260@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32924: Patch to add Haiku-specific font files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32924&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
I made some style cleanup (thanks to the cpplint.py tool).

From bugzilla-daemon at webkit.org  Fri Jul 17 03:33:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:33:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27365] Build fix on
 platforms don't have MMAP : [Attachment 32925] proposed patch
In-Reply-To: <bug-27365-0@https.bugs.webkit.org/>
References: <bug-27365-0@https.bugs.webkit.org/>
Message-ID: <20090717103337.2F604336F4C7@gamma.macosforge.org>

Csaba Osztrogon?c <oszi at inf.u-szeged.hu> has asked  for review:
Bug 27365: Build fix on platforms don't have MMAP
https://bugs.webkit.org/show_bug.cgi?id=27365

Attachment 32925: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32925&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 03:34:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:34:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27365] Build fix on platforms
 don't have MMAP : [Attachment 32925] proposed patch
In-Reply-To: <bug-27365-0@https.bugs.webkit.org/>
References: <bug-27365-0@https.bugs.webkit.org/>
Message-ID: <20090717103456.633FD336F541@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Csaba Osztrogon?c
<oszi at inf.u-szeged.hu>'s request for review:
Bug 27365: Build fix on platforms don't have MMAP
https://bugs.webkit.org/show_bug.cgi?id=27365

Attachment 32925: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32925&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 03:48:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 03:48:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27366] TextEncodingDetector
 that uses Universal Charset Detector : [Attachment 32926]
 TextEncodingDetectorUniversal
In-Reply-To: <bug-27366-0@https.bugs.webkit.org/>
References: <bug-27366-0@https.bugs.webkit.org/>
Message-ID: <20090717104807.83C05336F917@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 27366: TextEncodingDetector that uses Universal Charset Detector
https://bugs.webkit.org/show_bug.cgi?id=27366

Attachment 32926: TextEncodingDetectorUniversal
https://bugs.webkit.org/attachment.cgi?id=32926&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
No change to the build.

From bugzilla-daemon at webkit.org  Fri Jul 17 04:32:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 04:32:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32922] Patch v3
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717113228.61DAD3370775@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32922: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32922&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 04:32:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 04:32:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32927] Patch v4
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717113233.A7F1D3370795@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32927: Patch v4
https://bugs.webkit.org/attachment.cgi?id=32927&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 291 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 05:02:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:02:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27363] Add a parser of
 patches for linter : [Attachment 32927] Patch v4
In-Reply-To: <bug-27363-0@https.bugs.webkit.org/>
References: <bug-27363-0@https.bugs.webkit.org/>
Message-ID: <20090717120229.C20D933714BF@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27363: Add a parser of patches for linter
https://bugs.webkit.org/show_bug.cgi?id=27363

Attachment 32927: Patch v4
https://bugs.webkit.org/attachment.cgi?id=32927&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I still like add_deleted_line better than add_old_line, but add_old_line is ok.
:)

From bugzilla-daemon at webkit.org  Fri Jul 17 05:09:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:09:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32923] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717120959.4E55E33716E5@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32923: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32923&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Sorry, in the previous patch for the purpose of style cleanup I renamed a
variable, but it makes the compilation to fail.

From bugzilla-daemon at webkit.org  Fri Jul 17 05:09:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:09:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32931] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090717120959.64E4D33716E7@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32931: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32931&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Sorry, in the previous patch for the purpose of style cleanup I renamed a
variable, but it makes the compilation to fail.

From bugzilla-daemon at webkit.org  Fri Jul 17 05:23:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:23:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25523] [GTK] The text
 displayed by push buttons is not exposed to assistive technologies :
 [Attachment 32932] Patch proposal
In-Reply-To: <bug-25523-0@https.bugs.webkit.org/>
References: <bug-25523-0@https.bugs.webkit.org/>
Message-ID: <20090717122354.1F4233371B7C@gamma.macosforge.org>

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25523: [GTK] The text displayed by push buttons is not exposed to assistive
technologies
https://bugs.webkit.org/show_bug.cgi?id=25523

Attachment 32932: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=32932&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
New version of the patch attached. Please notice it touches
platform-independent code, even though it's motivated because of a WebKitGtk
a11y bug.

(In reply to comment #7)
> > This can be inlined in RenderButton.h. And also, RenderButton::text()
should
> > return const String instead of just String.
> 
> I did it this way as that's how I've seen it's done in other places, such as
> RenderMenuList.[h|cpp]. Anyway, I've no problem in implementing it as an
inline
> funcion in the .h file if that's ok.

At last, I did not add the method as inline because its implementation relies
on the private attribute 'RenderTextFragment* m_buttonText'
(m_buttonText->text() is used) and that class is not available at compilation
time when compiling the RenderButton.h file, so it fails to compile. Therefore,
I've leave it as it was right now (same way than in RenderMenuList.[h|cpp]),
just adding the 'const' modifier to the return value of the function.

From bugzilla-daemon at webkit.org  Fri Jul 17 05:34:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:34:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25524] [Gtk] Expose the
 title attribute to assistive technologies : [Attachment 32933] Patch
 proposal, with ChangeLog
In-Reply-To: <bug-25524-0@https.bugs.webkit.org/>
References: <bug-25524-0@https.bugs.webkit.org/>
Message-ID: <20090717123401.959853371EBB@gamma.macosforge.org>

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25524: [Gtk] Expose the title attribute to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=25524

Attachment 32933: Patch proposal, with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32933&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Attaching the patch again, this time with ChangeLog prepared and setting the
review:? flag. Sorry for the spam.

From bugzilla-daemon at webkit.org  Fri Jul 17 05:53:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:53:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27369] [v8] Restore proxy
 retrieval lost in -r45596 : [Attachment 32934] Initial version
In-Reply-To: <bug-27369-0@https.bugs.webkit.org/>
References: <bug-27369-0@https.bugs.webkit.org/>
Message-ID: <20090717125329.6CBD43372579@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27369: [v8] Restore proxy retrieval lost in -r45596
https://bugs.webkit.org/show_bug.cgi?id=27369

Attachment 32934: Initial version
https://bugs.webkit.org/attachment.cgi?id=32934&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 05:59:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 05:59:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27368] [Qt] On Symbian link
 against the system sqlite3 : [Attachment 32935] First try.
In-Reply-To: <bug-27368-0@https.bugs.webkit.org/>
References: <bug-27368-0@https.bugs.webkit.org/>
Message-ID: <20090717125902.E78F0337271D@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27368: [Qt] On Symbian link against the system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368

Attachment 32935: First try.
https://bugs.webkit.org/attachment.cgi?id=32935&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Add an option for all Qt builds to force linking against system sqlite3 by
adding system-sqlite to the CONFIG variable - up until now this was only an
option for QTDIR_build builds.

The symbian specific part of this patch is contributed by Norbert Leser.

From bugzilla-daemon at webkit.org  Fri Jul 17 06:12:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 06:12:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32936] For Qt,
 overwrite the plugin directories for the DRT to only those defined in
 QTWEBKIT_PLUGIN_PATH
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090717131213.C46E53372BB3@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32936: For Qt,overwrite the plugin directories for the DRT to only
those defined in QTWEBKIT_PLUGIN_PATH
https://bugs.webkit.org/attachment.cgi?id=32936&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 06:17:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 06:17:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32936] For Qt,
 overwrite the plugin directories for the DRT to only those defined in
 QTWEBKIT_PLUGIN_PATH
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090717131702.70BAA3372D35@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has canceled
Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>'s request for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32936: For Qt,overwrite the plugin directories for the DRT to only
those defined in QTWEBKIT_PLUGIN_PATH
https://bugs.webkit.org/attachment.cgi?id=32936&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Submitted patch with garbage by mistake. This one should be alright

From bugzilla-daemon at webkit.org  Fri Jul 17 06:17:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 06:17:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32937] For Qt,
 overwrite the plugin directories for the DRT to only those defined in
 QTWEBKIT_PLUGIN_PATH
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090717131702.821083372D37@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32937: For Qt,overwrite the plugin directories for the DRT to only
those defined in QTWEBKIT_PLUGIN_PATH
https://bugs.webkit.org/attachment.cgi?id=32937&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Submitted patch with garbage by mistake. This one should be alright

From bugzilla-daemon at webkit.org  Fri Jul 17 06:30:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 06:30:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27215] [QT] suppress
 (un)desired launcher output that can make layout test to fail with stderr :
 [Attachment 32937] For Qt,
 overwrite the plugin directories for the DRT to only those defined in
 QTWEBKIT_PLUGIN_PATH
In-Reply-To: <bug-27215-0@https.bugs.webkit.org/>
References: <bug-27215-0@https.bugs.webkit.org/>
Message-ID: <20090717133024.1F3F63373192@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27215: [QT] suppress (un)desired launcher output that can make layout test
to fail with stderr
https://bugs.webkit.org/show_bug.cgi?id=27215

Attachment 32937: For Qt,overwrite the plugin directories for the DRT to only
those defined in QTWEBKIT_PLUGIN_PATH
https://bugs.webkit.org/attachment.cgi?id=32937&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 06:55:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 06:55:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27351] [Qt]
 navigator.platform returns an empty string in Symbian and in Linux
 platforms : [Attachment 32911] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090717135527.697E33373AE2@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32911: Patch
https://bugs.webkit.org/attachment.cgi?id=32911&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Seems consistent with firefox and chromium on linux, too.

From bugzilla-daemon at webkit.org  Fri Jul 17 06:55:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 06:55:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27358] [Qt] Fix the include
 path for the Symbian port : [Attachment 32907] Proposed fix.
In-Reply-To: <bug-27358-0@https.bugs.webkit.org/>
References: <bug-27358-0@https.bugs.webkit.org/>
Message-ID: <20090717135551.8F1FF3373B08@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27358: [Qt] Fix the include path for the Symbian port
https://bugs.webkit.org/show_bug.cgi?id=27358

Attachment 32907: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32907&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Nice!

From bugzilla-daemon at webkit.org  Fri Jul 17 07:43:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 07:43:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27371] [WINCE] Add WinCE
 specific platform/text files to WebCore : [Attachment 32939] Adds
 platform/text/wince files to WebCore
In-Reply-To: <bug-27371-0@https.bugs.webkit.org/>
References: <bug-27371-0@https.bugs.webkit.org/>
Message-ID: <20090717144326.34F1F3374CE6@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27371: [WINCE] Add WinCE specific platform/text files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27371

Attachment 32939: Adds platform/text/wince files to WebCore
https://bugs.webkit.org/attachment.cgi?id=32939&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I've run them through cpplint and fixed them up by hand... fwiw.

From bugzilla-daemon at webkit.org  Fri Jul 17 07:43:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 07:43:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27316] [Qt] more than 100
 tests in Qt's DRT Skipped list works for me : [Attachment 32938] Remove
 tests from Qt Skipped list that are actually working.
In-Reply-To: <bug-27316-0@https.bugs.webkit.org/>
References: <bug-27316-0@https.bugs.webkit.org/>
Message-ID: <20090717144331.8741F3374CF5@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted  review:
Bug 27316: [Qt] more than 100 tests in Qt's DRT Skipped list works for me
https://bugs.webkit.org/show_bug.cgi?id=27316

Attachment 32938: Remove tests from Qt Skipped list that are actually working.
https://bugs.webkit.org/attachment.cgi?id=32938&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. thanks

From bugzilla-daemon at webkit.org  Fri Jul 17 07:47:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 07:47:15 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25524] [Gtk] Expose the title
 attribute to assistive technologies : [Attachment 32933] Patch proposal,
 with ChangeLog
In-Reply-To: <bug-25524-0@https.bugs.webkit.org/>
References: <bug-25524-0@https.bugs.webkit.org/>
Message-ID: <20090717144715.F013F3374E6B@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has denied Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25524: [Gtk] Expose the title attribute to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=25524

Attachment 32933: Patch proposal, with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32933&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> +2009-07-17  Mario Sanchez Prada  <msanchez at igalia.com>
> +
> +	Reviewed by NOBODY (OOPS!).
> +
> +	https://bugs.webkit.org/show_bug.cgi?id=25524
> +	[Gtk] Expose the title attribute to assistive technologies
> +
> +	Expose 'alt' attribute from images as accessible name.
> +	Expose the 'title' core HTML attribute as accessible description.
> +
> +	   * accessibility/AccessibilityRenderObject.cpp:
> +	   (WebCore::AccessibilityRenderObject::stringValue):
> +	   (WebCore::AccessibilityRenderObject::accessibilityDescription):
> +

The indentation here is completely off. You should align everything at 8 chars,
with no tabs at all.

> +	   if (node && node->isHTMLElement()) {
> +	       const AtomicString& alt =
static_cast<HTMLElement*>(node)->getAttribute(altAttr);
> +	       if (!alt.isEmpty())
> +		 return alt;

Bad indentation here (2 instead of 4 spaces). If you're using Emacs you may
want to do M-x set-variable <RET> c-basic-offset <RET> 4 <RET> =)

> +    } else {
> +	 Node* node = m_renderer->node();
> +	 if (node && node->isHTMLElement()) {
> +	   const AtomicString& title =
static_cast<HTMLElement*>(node)->getAttribute(titleAttr);
> +	   if (!title.isEmpty())
> +	     return title;
> +	 }

Bad indentation here too.

I could just fix this stuff myself, and commit, since the rest of the patch
looks good, but I'd like to have an updated patch submitted by you that I can
just apply and commit. Thanks for your work!

From bugzilla-daemon at webkit.org  Fri Jul 17 07:55:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 07:55:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32870] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090717145527.7C4E533751BB@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32870: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32870&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Many coding style issues corrected from the previous patch. ( Thanks to the
cpplint.py tool :)

From bugzilla-daemon at webkit.org  Fri Jul 17 07:55:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 07:55:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32940] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090717145527.8640033751BD@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32940: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32940&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Many coding style issues corrected from the previous patch. ( Thanks to the
cpplint.py tool :)

From bugzilla-daemon at webkit.org  Fri Jul 17 08:05:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 08:05:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27265] [Qt] font cache
 reworking : [Attachment 32941] proposed patch
In-Reply-To: <bug-27265-0@https.bugs.webkit.org/>
References: <bug-27265-0@https.bugs.webkit.org/>
Message-ID: <20090717150535.8B4AB3375531@gamma.macosforge.org>

Kelemen Bal?zs <Kelemen.Balazs.3 at stud.u-szeged.hu> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27265: [Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Attachment 32941: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32941&action=review

------- Additional Comments from Kelemen Bal?zs
<Kelemen.Balazs.3 at stud.u-szeged.hu>
Layouttest problems are fixed.

From bugzilla-daemon at webkit.org  Fri Jul 17 08:20:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 08:20:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27372] [v8] switch to
 faster methods to obtain and set implementation : [Attachment 32942]
 Initial version
In-Reply-To: <bug-27372-0@https.bugs.webkit.org/>
References: <bug-27372-0@https.bugs.webkit.org/>
Message-ID: <20090717152003.402623375AB7@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27372: [v8] switch to faster methods to obtain and set implementation
https://bugs.webkit.org/show_bug.cgi?id=27372

Attachment 32942: Initial version
https://bugs.webkit.org/attachment.cgi?id=32942&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 08:29:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 08:29:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32943] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090717152947.0129B3375EB4@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32943: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32943&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
I should build my code once before submitting patches.
I changed the name of an attribut, but I forgot two places in my source code.

From bugzilla-daemon at webkit.org  Fri Jul 17 08:29:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 08:29:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32940] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090717152946.DBB8C3375EB1@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32940: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32940&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
I should build my code once before submitting patches.
I changed the name of an attribut, but I forgot two places in my source code.

From bugzilla-daemon at webkit.org  Fri Jul 17 09:12:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:12:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25524] [Gtk] Expose the
 title attribute to assistive technologies : [Attachment 32944] Patch
 proposal, indentation fixed
In-Reply-To: <bug-25524-0@https.bugs.webkit.org/>
References: <bug-25524-0@https.bugs.webkit.org/>
Message-ID: <20090717161216.B794B3376D53@gamma.macosforge.org>

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25524: [Gtk] Expose the title attribute to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=25524

Attachment 32944: Patch proposal, indentation fixed
https://bugs.webkit.org/attachment.cgi?id=32944&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Fixed indentation problems

From bugzilla-daemon at webkit.org  Fri Jul 17 09:20:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:20:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32898] Proposed patch, rev.3
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717162051.53207337707B@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has canceled Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32898: Proposed patch, rev.3
https://bugs.webkit.org/attachment.cgi?id=32898&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
Modified according to observations:

+ virtual isOptionalFormControl
+ virtual isRequiredFormControl

From bugzilla-daemon at webkit.org  Fri Jul 17 09:20:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:20:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32945] Proposed patch, rev. 4
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717162051.635ED337707E@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32945: Proposed patch, rev. 4
https://bugs.webkit.org/attachment.cgi?id=32945&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
Modified according to observations:

+ virtual isOptionalFormControl
+ virtual isRequiredFormControl

From bugzilla-daemon at webkit.org  Fri Jul 17 09:22:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:22:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25523] [GTK] The text
 displayed by push buttons is not exposed to assistive technologies :
 [Attachment 32932] Patch proposal
In-Reply-To: <bug-25523-0@https.bugs.webkit.org/>
References: <bug-25523-0@https.bugs.webkit.org/>
Message-ID: <20090717162214.CB3CC3377119@gamma.macosforge.org>

Mario Sanchez Prada <msanchez at igalia.com> has canceled Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25523: [GTK] The text displayed by push buttons is not exposed to assistive
technologies
https://bugs.webkit.org/show_bug.cgi?id=25523

Attachment 32932: Patch proposal
https://bugs.webkit.org/attachment.cgi?id=32932&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Fixed indentation issue in previous patch

From bugzilla-daemon at webkit.org  Fri Jul 17 09:22:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:22:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25523] [GTK] The text
 displayed by push buttons is not exposed to assistive technologies :
 [Attachment 32946] Patch proposal, indentation fixed
In-Reply-To: <bug-25523-0@https.bugs.webkit.org/>
References: <bug-25523-0@https.bugs.webkit.org/>
Message-ID: <20090717162214.EBA76337711D@gamma.macosforge.org>

Mario Sanchez Prada <msanchez at igalia.com> has asked  for review:
Bug 25523: [GTK] The text displayed by push buttons is not exposed to assistive
technologies
https://bugs.webkit.org/show_bug.cgi?id=25523

Attachment 32946: Patch proposal, indentation fixed
https://bugs.webkit.org/attachment.cgi?id=32946&action=review

------- Additional Comments from Mario Sanchez Prada <msanchez at igalia.com>
Fixed indentation issue in previous patch

From bugzilla-daemon at webkit.org  Fri Jul 17 09:24:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:24:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25524] [Gtk] Expose the title
 attribute to assistive technologies : [Attachment 32944] Patch proposal,
 indentation fixed
In-Reply-To: <bug-25524-0@https.bugs.webkit.org/>
References: <bug-25524-0@https.bugs.webkit.org/>
Message-ID: <20090717162413.705F333771F1@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25524: [Gtk] Expose the title attribute to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=25524

Attachment 32944: Patch proposal, indentation fixed
https://bugs.webkit.org/attachment.cgi?id=32944&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 09:28:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:28:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27356] Some transitions
 don't work correctly on Leopard : [Attachment 32947] Patch
In-Reply-To: <bug-27356-0@https.bugs.webkit.org/>
References: <bug-27356-0@https.bugs.webkit.org/>
Message-ID: <20090717162828.AEC4833773B0@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 27356: Some transitions don't work correctly on Leopard
https://bugs.webkit.org/show_bug.cgi?id=27356

Attachment 32947: Patch
https://bugs.webkit.org/attachment.cgi?id=32947&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 09:38:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:38:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27356] Some transitions don't
 work correctly on Leopard : [Attachment 32947] Patch
In-Reply-To: <bug-27356-0@https.bugs.webkit.org/>
References: <bug-27356-0@https.bugs.webkit.org/>
Message-ID: <20090717163823.CF2853377737@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Chris Marrin <cmarrin at apple.com>'s
request for review:
Bug 27356: Some transitions don't work correctly on Leopard
https://bugs.webkit.org/show_bug.cgi?id=27356

Attachment 32947: Patch
https://bugs.webkit.org/attachment.cgi?id=32947&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 09:47:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:47:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27374] WebKit should have a
 bash completion script to aid with common commands. : [Attachment 32948] a
 few last fix ups.
In-Reply-To: <bug-27374-0@https.bugs.webkit.org/>
References: <bug-27374-0@https.bugs.webkit.org/>
Message-ID: <20090717164741.CE5A23377A79@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27374: WebKit should have a bash completion script to aid with common
commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

Attachment 32948: a few last fix ups.
https://bugs.webkit.org/attachment.cgi?id=32948&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 09:48:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:48:45 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27374] WebKit should have a
 bash completion script to aid with common commands. : [Attachment 32948] a
 few last fix ups.
In-Reply-To: <bug-27374-0@https.bugs.webkit.org/>
References: <bug-27374-0@https.bugs.webkit.org/>
Message-ID: <20090717164845.49BA63377ACE@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled David Levin
<levin at chromium.org>'s request for review:
Bug 27374: WebKit should have a bash completion script to aid with common
commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

Attachment 32948: a few last fix ups.
https://bugs.webkit.org/attachment.cgi?id=32948&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 09:48:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:48:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27374] WebKit should have a
 bash completion script to aid with common commands. : [Attachment 32949]
 Add script for WebKit command completions in bash.
In-Reply-To: <bug-27374-0@https.bugs.webkit.org/>
References: <bug-27374-0@https.bugs.webkit.org/>
Message-ID: <20090717164847.C87C53377ADC@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27374: WebKit should have a bash completion script to aid with common
commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

Attachment 32949: Add script for WebKit command completions in bash.
https://bugs.webkit.org/attachment.cgi?id=32949&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 09:52:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:52:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32950] Proposed patch, rev. 4b
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717165226.1D7023377C1E@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32950: Proposed patch, rev. 4b
https://bugs.webkit.org/attachment.cgi?id=32950&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
In Rev.4 there was an unecessary inclusion of ValidityState.h in
CSSStyleSelector.cpp, cleaned up.

From bugzilla-daemon at webkit.org  Fri Jul 17 09:52:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 09:52:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32945] Proposed patch, rev. 4
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717165226.0C3BC3377C1A@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has canceled Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32945: Proposed patch, rev. 4
https://bugs.webkit.org/attachment.cgi?id=32945&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
In Rev.4 there was an unecessary inclusion of ValidityState.h in
CSSStyleSelector.cpp, cleaned up.

From bugzilla-daemon at webkit.org  Fri Jul 17 10:03:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:03:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 32951] Add
 platform/network WinCE specific files
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090717170351.7A1FD33780BD@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 32951: Add platform/network WinCE specific files
https://bugs.webkit.org/attachment.cgi?id=32951&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 10:27:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:27:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27377] Assorted cpplint
 improvements : [Attachment 32953] Adds new cpplint check for webkit rule
 violation
In-Reply-To: <bug-27377-0@https.bugs.webkit.org/>
References: <bug-27377-0@https.bugs.webkit.org/>
Message-ID: <20090717172734.82F6C33788A0@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27377: Assorted cpplint improvements
https://bugs.webkit.org/show_bug.cgi?id=27377

Attachment 32953: Adds new cpplint check for webkit rule violation
https://bugs.webkit.org/attachment.cgi?id=32953&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 10:28:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:28:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27377] Assorted cpplint
 improvements : [Attachment 32954] Turn off erroneous filters preventing
 valid checks
In-Reply-To: <bug-27377-0@https.bugs.webkit.org/>
References: <bug-27377-0@https.bugs.webkit.org/>
Message-ID: <20090717172810.291AE33788D6@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27377: Assorted cpplint improvements
https://bugs.webkit.org/show_bug.cgi?id=27377

Attachment 32954: Turn off erroneous filters preventing valid checks
https://bugs.webkit.org/attachment.cgi?id=32954&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 10:28:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:28:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27377] Assorted cpplint
 improvements : [Attachment 32955] Move comment to where it belongs
In-Reply-To: <bug-27377-0@https.bugs.webkit.org/>
References: <bug-27377-0@https.bugs.webkit.org/>
Message-ID: <20090717172834.19C223378901@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27377: Assorted cpplint improvements
https://bugs.webkit.org/show_bug.cgi?id=27377

Attachment 32955: Move comment to where it belongs
https://bugs.webkit.org/attachment.cgi?id=32955&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 10:39:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:39:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27341] cpplint should flag
 usages of NULL. : [Attachment 32929] Proposed fix.
In-Reply-To: <bug-27341-0@https.bugs.webkit.org/>
References: <bug-27341-0@https.bugs.webkit.org/>
Message-ID: <20090717173943.D121F3378CF7@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27341: cpplint should flag usages of NULL.
https://bugs.webkit.org/show_bug.cgi?id=27341

Attachment 32929: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32929&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 10:43:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:43:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27375] [Chromium] Need a
 DOM_STORAGE guard in DerivedSourcesAllInOne.cpp : [Attachment 32957] v1
In-Reply-To: <bug-27375-0@https.bugs.webkit.org/>
References: <bug-27375-0@https.bugs.webkit.org/>
Message-ID: <20090717174353.A69E33378E7D@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27375: [Chromium] Need a DOM_STORAGE guard in DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375

Attachment 32957: v1
https://bugs.webkit.org/attachment.cgi?id=32957&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
In https://bugs.webkit.org/show_bug.cgi?id=27360 I added Storage.cpp and
StorageEvent.cpp.  Unfortunately, until later this afternoon, DOM_STORAGE is
not turned on by default in Chromium, and so these two files are never
generated.  This breaks the compile.

There are no other instances of guards in the file, which puzzles me..but I
think adding guards is the right way to go about this.

From bugzilla-daemon at webkit.org  Fri Jul 17 10:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:46:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27341] cpplint should flag
 usages of NULL. : [Attachment 32929] Proposed fix.
In-Reply-To: <bug-27341-0@https.bugs.webkit.org/>
References: <bug-27341-0@https.bugs.webkit.org/>
Message-ID: <20090717174607.A650E3378F5F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27341: cpplint should flag usages of NULL.
https://bugs.webkit.org/show_bug.cgi?id=27341

Attachment 32929: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32929&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Awesome! I was planning on writing this one later :)

From bugzilla-daemon at webkit.org  Fri Jul 17 10:47:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 10:47:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27375] [Chromium] Need a
 DOM_STORAGE guard in DerivedSourcesAllInOne.cpp : [Attachment 32957] v1
In-Reply-To: <bug-27375-0@https.bugs.webkit.org/>
References: <bug-27375-0@https.bugs.webkit.org/>
Message-ID: <20090717174744.715453378FF6@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27375: [Chromium] Need a DOM_STORAGE guard in DerivedSourcesAllInOne.cpp
https://bugs.webkit.org/show_bug.cgi?id=27375

Attachment 32957: v1
https://bugs.webkit.org/attachment.cgi?id=32957&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 11:08:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:08:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32959] Fixed up merge
 errors with worker-constructor layout test.
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090717180824.6321F33797FD@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32959: Fixed up merge errors with worker-constructor layout test.
https://bugs.webkit.org/attachment.cgi?id=32959&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 11:12:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:12:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27377] Assorted cpplint
 improvements : [Attachment 32955] Move comment to where it belongs
In-Reply-To: <bug-27377-0@https.bugs.webkit.org/>
References: <bug-27377-0@https.bugs.webkit.org/>
Message-ID: <20090717181222.3C3573379935@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27377: Assorted cpplint improvements
https://bugs.webkit.org/show_bug.cgi?id=27377

Attachment 32955: Move comment to where it belongs
https://bugs.webkit.org/attachment.cgi?id=32955&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 11:14:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:14:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26948] Need to refactor
 Worker to derive from AbstractWorker : [Attachment 32959] Fixed up merge
 errors with worker-constructor layout test.
In-Reply-To: <bug-26948-0@https.bugs.webkit.org/>
References: <bug-26948-0@https.bugs.webkit.org/>
Message-ID: <20090717181456.29C3A3379A47@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 26948: Need to refactor Worker to derive from AbstractWorker
https://bugs.webkit.org/show_bug.cgi?id=26948

Attachment 32959: Fixed up merge errors with worker-constructor layout test.
https://bugs.webkit.org/attachment.cgi?id=32959&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 11:18:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:18:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27369] [v8] Restore proxy
 retrieval lost in -r45596 : [Attachment 32934] Initial version
In-Reply-To: <bug-27369-0@https.bugs.webkit.org/>
References: <bug-27369-0@https.bugs.webkit.org/>
Message-ID: <20090717181827.6264A3379B8B@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 27369: [v8] Restore proxy retrieval lost in -r45596
https://bugs.webkit.org/show_bug.cgi?id=27369

Attachment 32934: Initial version
https://bugs.webkit.org/attachment.cgi?id=32934&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Fri Jul 17 11:25:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:25:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27381] WinLauncher Crash
 with File URLs : [Attachment 32960] Correct BSTR mishandling.
In-Reply-To: <bug-27381-0@https.bugs.webkit.org/>
References: <bug-27381-0@https.bugs.webkit.org/>
Message-ID: <20090717182527.E16953379E60@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 27381: WinLauncher Crash with File URLs
https://bugs.webkit.org/show_bug.cgi?id=27381

Attachment 32960: Correct BSTR mishandling.
https://bugs.webkit.org/attachment.cgi?id=32960&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 11:31:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:31:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27379]
 Absolutely-positioned elements with a scrollbar wrap prematurely :
 [Attachment 32961] Patch
In-Reply-To: <bug-27379-0@https.bugs.webkit.org/>
References: <bug-27379-0@https.bugs.webkit.org/>
Message-ID: <20090717183131.5984B337A09A@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27379: Absolutely-positioned elements with a scrollbar wrap prematurely
https://bugs.webkit.org/show_bug.cgi?id=27379

Attachment 32961: Patch
https://bugs.webkit.org/attachment.cgi?id=32961&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 11:34:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:34:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27381] WinLauncher Crash with
 File URLs : [Attachment 32960] Correct BSTR mishandling.
In-Reply-To: <bug-27381-0@https.bugs.webkit.org/>
References: <bug-27381-0@https.bugs.webkit.org/>
Message-ID: <20090717183410.DA17A337A189@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 27381: WinLauncher Crash with File URLs
https://bugs.webkit.org/show_bug.cgi?id=27381

Attachment 32960: Correct BSTR mishandling.
https://bugs.webkit.org/attachment.cgi?id=32960&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>	   if (SUCCEEDED(UrlCreateFromPath(urlBStr, fileURL, &fileURLLength,
0)))
> -	       urlBStr = fileURL;
> +	       SysReAllocString(&urlBStr, fileURL);

It doesn't seem so great to be modifying the urlBStr parameter like this. Maybe
it would be better to put the file: URL into a separate variable? Something
like:

BSTR fileURLBstr = 0;
if (...) {
    fileURLBstr = SysAllocString(...);
    urlBStr = fileURLBstr;
}

...actual loading calls here...

if (fileURLBstr)
    SysFreeString(fileURLBstr);

But it seems OK as-is.

From bugzilla-daemon at webkit.org  Fri Jul 17 11:34:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 11:34:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27379] Absolutely-positioned
 elements with a scrollbar wrap prematurely : [Attachment 32961] Patch
In-Reply-To: <bug-27379-0@https.bugs.webkit.org/>
References: <bug-27379-0@https.bugs.webkit.org/>
Message-ID: <20090717183431.92229337A1AA@gamma.macosforge.org>

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 27379: Absolutely-positioned elements with a scrollbar wrap prematurely
https://bugs.webkit.org/show_bug.cgi?id=27379

Attachment 32961: Patch
https://bugs.webkit.org/attachment.cgi?id=32961&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 12:05:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:05:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27382] Build break --
 including a corefoundation header : [Attachment 32962] Add a header
 inclusion guard
In-Reply-To: <bug-27382-0@https.bugs.webkit.org/>
References: <bug-27382-0@https.bugs.webkit.org/>
Message-ID: <20090717190505.BF6D1337AC4A@gamma.macosforge.org>

Eric Roman <eroman at chromium.org> has asked  for review:
Bug 27382: Build break -- including a corefoundation header
https://bugs.webkit.org/show_bug.cgi?id=27382

Attachment 32962: Add a header inclusion guard
https://bugs.webkit.org/attachment.cgi?id=32962&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 12:09:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:09:00 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32903]
 Resize Attached Inspector
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090717190900.B0F5F337ADD1@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32903: Resize Attached Inspector
https://bugs.webkit.org/attachment.cgi?id=32903&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +    int inspectedHeight =
m_inspectedPage->mainFrame()->view()->visibleHeight();

There seems to be a mix of "long", "int", and "unsigned" when talking about
attached window heights. It would be good to use a single type as much as
possible.

"inspectedHeight" is a confusing name. We aren't inspecting the height, we're
inspecting the page. "inspectedPageHeight" would be better.

>      m_client->attachWindow();
> +    
> +    Setting attachedHeight = setting(inspectorAttachedHeightName);
> +    int preferredHeight = attachedHeight.type() == Setting::IntegerType ?
attachedHeight.integerValue() : defaultAttachedHeight;
> +   
m_client->setAttachedWindowHeight(constrainedAttachedWindowHeight(preferredHeig
ht, inspectedHeight));

It would be good to add a comment here about how we have to reconstrain the
height based on the current height of the inspected page.

> +long InspectorController::constrainedAttachedWindowHeight(long
preferredHeight, long totalWindowHeight)

This can just be a static helper function. It doesn't need to be a member of
the InspectorController class.

> +    // Save a preference for the user's preferred attached height and pass
it to the client
> +    setSetting(inspectorAttachedHeightName, Setting(attachedHeight));

We aren't saving the preferred height, we're saving the constrained height. I
don't think this comment is needed at all, though.

>  void InspectorController::showWindow()
>  {
>      ASSERT(enabled());
> +    
> +    int inspectedHeight =
m_inspectedPage->mainFrame()->view()->visibleHeight();
> +    
>      m_client->showWindow();
> +    
> +    Setting attachedHeight = setting(inspectorAttachedHeightName);
> +    int preferredHeight = attachedHeight.type() == Setting::IntegerType ?
attachedHeight.integerValue() : defaultAttachedHeight;
> +   
m_client->setAttachedWindowHeight(constrainedAttachedWindowHeight(preferredHeig
ht, inspectedHeight));
>  }

We only need to do this if we're going to start out attached, right? Again, I
think a comment would be useful. It might also be worth adding a FIXME about
how it's strange that we have to do this both here and in attachWindow; we
should only have to do it once. It might be that we can fix this eventually by
moving more code down into WebCore, but we don't have to do that now.

> @@ -323,7 +320,7 @@ void WebInspectorClient::updateWindowTit
>  
>      if (_shouldAttach) {
>	   WebFrameView *frameView = [[_inspectedWebView mainFrame] frameView];

> -
> +	   

Please undo this whitespace change.

>  - (void)setAttachedWindowHeight:(unsigned)height
>  {
> -    [[NSUserDefaults standardUserDefaults] setInteger:height
forKey:WebKitInspectorAttachedViewHeightKey];
> -
>      if (!_attachedToInspectedWebView)
>	   return;
> -
> -    WebFrameView *frameView = [[_inspectedWebView mainFrame] frameView];
> -    NSRect frameViewRect = [frameView frame];
> -
> -    CGFloat attachedHeight = round(MAX(250.0, MIN(height,
(NSHeight([_inspectedWebView frame]) * 0.75))));
> -
> +    

Please remove the whitespace on this line.

>  void WebInspectorClient::setAttachedWindowHeight(unsigned height)
>  {
> -    // FIXME: implement this.
> +    if (!m_attached)
> +	   return;
> +
> +    HWND hostWindow;
> +    if
(!SUCCEEDED(m_inspectedWebView->hostWindow((OLE_HANDLE*)&hostWindow)))
> +	   return;
> +
> +    RECT hostWindowRect;
> +    GetClientRect(hostWindow, &hostWindowRect);
> +
> +    RECT inspectedRect;
> +    GetClientRect(m_inspectedWebViewHwnd, &inspectedRect);
> +
> +    int totalHeight = hostWindowRect.bottom - hostWindowRect.top;
> +    int webViewWidth = inspectedRect.right - inspectedRect.left;
> +
> +    SetWindowPos(m_webViewHwnd, 0, 0, totalHeight - height, webViewWidth,
height, SWP_NOZORDER);
> +    SetWindowPos(m_inspectedWebViewHwnd, 0, 0, 0, webViewWidth, totalHeight,
SWP_NOZORDER);

Please add a comment here explaining why totalHeight is the right height to set
m_inspectedWebViewHwnd to.

So close! I'm really happy with how this is shaping up.

From bugzilla-daemon at webkit.org  Fri Jul 17 12:09:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:09:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27382] Build break --
 including a corefoundation header : [Attachment 32962] Add a header
 inclusion guard
In-Reply-To: <bug-27382-0@https.bugs.webkit.org/>
References: <bug-27382-0@https.bugs.webkit.org/>
Message-ID: <20090717190921.E07CE337AE00@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Eric Roman <eroman at chromium.org>'s
request for review:
Bug 27382: Build break -- including a corefoundation header
https://bugs.webkit.org/show_bug.cgi?id=27382

Attachment 32962: Add a header inclusion guard
https://bugs.webkit.org/attachment.cgi?id=32962&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Conditionalized includes go in separate paragraphs in our coding style.

Typo "Build fox" instead of build fix. Would you be willing to do a new patch
with those fixed?

From bugzilla-daemon at webkit.org  Fri Jul 17 12:09:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:09:52 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27377] Assorted cpplint
 improvements : [Attachment 32954] Turn off erroneous filters preventing
 valid checks
In-Reply-To: <bug-27377-0@https.bugs.webkit.org/>
References: <bug-27377-0@https.bugs.webkit.org/>
Message-ID: <20090717190952.43A24337AE37@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27377: Assorted cpplint improvements
https://bugs.webkit.org/show_bug.cgi?id=27377

Attachment 32954: Turn off erroneous filters preventing valid checks
https://bugs.webkit.org/attachment.cgi?id=32954&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> index 7b66d46..80f3a75 100644
> --- a/WebKitTools/ChangeLog
> +++ b/WebKitTools/ChangeLog
> @@ -3,6 +3,29 @@
>	   Reviewed by NOBODY (OOPS!).
>  
>	   https://bugs.webkit.org/show_bug.cgi?id=27377
> +	   Don't filter whitespace at the end of the line.  This is not
> +	   explicitly a rule of webkit coding style, but there is no reason
> +	   not to warn of this common style problem.
> +
> +	   Don't filter whitespace newline.  This prevents cpplint of
complaining
> +	   about the following situation:

I was confused when I read this because it sounded like removing the filtering
prevented the complaining.

Here's an idea for an alternate wording:
	Don't filter whitespace newline.  Now, cpplint will complain
	about the following situation:


> +
> +	       if (true) {
> +		   doSomething();
> +		   doSomethingAgain();
> +	       }
> +	       else
> +		   doSomething();
> +
> +	   Which is a webkit coding style rule violation.
> +
> +	   * Scripts/modules/cpplint.py:
> +
> +2009-07-17  Adam Treat  <adam.treat at torchmobile.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27377
>	   This makes cpplint complain about this for instance:
>  
>	       if (true)
> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> index 2ef4e3a..cf22e3d 100644
> --- a/WebKitTools/Scripts/modules/cpplint.py
> +++ b/WebKitTools/Scripts/modules/cpplint.py
> @@ -2786,10 +2786,8 @@ def use_webkit_styles():
>      #	modify the implementation and enable them.
>      global _DEFAULT_FILTERS
>      _DEFAULT_FILTERS = [
> -	   '-whitespace/end_of_line',
>	   '-whitespace/comments',
>	   '-whitespace/blank_line',
> -	   '-whitespace/newline',  # '\r'
>	   '-runtime/explicit',  # explicit
>	   '-runtime/virtual',	# virtual dtor
>	   '-runtime/printf',

From bugzilla-daemon at webkit.org  Fri Jul 17 12:14:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:14:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32963] Fixes, part 4
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717191444.E0752337AFF6@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked David Kilzer (ddkilzer)
<ddkilzer at webkit.org> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32963: Fixes, part 4
https://bugs.webkit.org/attachment.cgi?id=32963&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This corrects the issues with svn-create-patch and adds the changes mentioned
above.

The issue with me getting bogus patches seems to be an svn bug that I may have
to work around by setting svn:eol-style on everything (ack).

From bugzilla-daemon at webkit.org  Fri Jul 17 12:18:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:18:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27382] Build break --
 including a corefoundation header : [Attachment 32964] Add a header
 inclusion guard (v2)
In-Reply-To: <bug-27382-0@https.bugs.webkit.org/>
References: <bug-27382-0@https.bugs.webkit.org/>
Message-ID: <20090717191807.26E13337B125@gamma.macosforge.org>

Eric Roman <eroman at chromium.org> has asked  for review:
Bug 27382: Build break -- including a corefoundation header
https://bugs.webkit.org/show_bug.cgi?id=27382

Attachment 32964: Add a header inclusion guard (v2)
https://bugs.webkit.org/attachment.cgi?id=32964&action=review

------- Additional Comments from Eric Roman <eroman at chromium.org>
New patch -- addressed darin at apple.com's feedback.

From bugzilla-daemon at webkit.org  Fri Jul 17 12:22:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:22:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27382] Build break --
 including a corefoundation header : [Attachment 32964] Add a header
 inclusion guard (v2)
In-Reply-To: <bug-27382-0@https.bugs.webkit.org/>
References: <bug-27382-0@https.bugs.webkit.org/>
Message-ID: <20090717192256.A2E59337B299@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Eric Roman <eroman at chromium.org>'s
request for review:
Bug 27382: Build break -- including a corefoundation header
https://bugs.webkit.org/show_bug.cgi?id=27382

Attachment 32964: Add a header inclusion guard (v2)
https://bugs.webkit.org/attachment.cgi?id=32964&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 12:30:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:30:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27377] Assorted cpplint
 improvements : [Attachment 32953] Adds new cpplint check for webkit rule
 violation
In-Reply-To: <bug-27377-0@https.bugs.webkit.org/>
References: <bug-27377-0@https.bugs.webkit.org/>
Message-ID: <20090717193038.88170337B50B@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27377: Assorted cpplint improvements
https://bugs.webkit.org/show_bug.cgi?id=27377

Attachment 32953: Adds new cpplint check for webkit rule violation
https://bugs.webkit.org/attachment.cgi?id=32953&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> +		or search(r'\b(if|for|while|switch)\b', previous_line))
Please add "else" and a test case using else.

From bugzilla-daemon at webkit.org  Fri Jul 17 12:32:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:32:42 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25551] Support for HTML5 Forms
 "required" attribute : [Attachment 32950] Proposed patch, rev. 4b
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717193242.66FA5337B596@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32950: Proposed patch, rev. 4b
https://bugs.webkit.org/attachment.cgi?id=32950&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       case CSSSelector::PseudoOptional: {
> +		   if (!e || !e->isFormControlElement())
> +		       return false;
> +
> +		   return e->isOptionalFormControl();
> +	       }

No braces needed here.

Since you put isOptionalFormControl into Element, you don't need so much code.
Just:

    case CSSSelector::PseudoOptional:
	return e && e->isOptionalFormControl();

Same for PseudoRequired.

> +    virtual bool isOptionalFormControl() const { return true; }

I prefer to make such virtual function overrides in the private: section of a
class. If anyone calls this on a button element it means they made a
programming mistake and I think it's best if the code fails to compile in such
cases that can easily be caught. Making the virtual function override private
accomplishes that.

> +bool HTMLInputElement::isRequiredFormControl() const
> +{
> +    if (!required())
> +	   return false;
> +
> +    switch (inputType()) {
> +	   case HTMLInputElement::HIDDEN:
> +	   case HTMLInputElement::RANGE:
> +	   case HTMLInputElement::SUBMIT:
> +	   case HTMLInputElement::IMAGE:
> +	   case HTMLInputElement::RESET:
> +	   case HTMLInputElement::BUTTON:
> +	       return false;
> +	   default:
> +	       return true;
> +    }
> +
> +    return false;
> +}

There is no need to have that "return false" statement there if there is no
exit from the switch statement, and in fact I believe this will fail to compile
with some compilers due to the unreachable code.

The enum values don't need to be qualified by the HTMLInputElement class name,
because this is already a member function. For maintenance I prefer to have all
the values of the enum listed. If you do that and omit the default from the
switch, then the gcc compiler will catch you if you add a new enum value
without modifying this function.

If you remove the default, then you will need the return after the switch,
though, although you can do an ASSERT_NOT_REACHED. The saveForMControlState
function uses the preferred style.

> +    virtual bool isOptionalFormControl() const { return
!isRequiredFormControl(); }
> +    virtual bool isRequiredFormControl() const;

Same thought about making these private.

> +    virtual bool isOptionalFormControl() const { return true; }

Ditto.

> +    virtual bool isOptionalFormControl() const { return
!isRequiredFormControl(); }
> +    virtual bool isRequiredFormControl() const { return required(); }

Ditto.

> +	   switch (i->inputType()) {
> +	       case HTMLInputElement::TEXT:
> +	       case HTMLInputElement::SEARCH:
> +	       case HTMLInputElement::URL:
> +	       case HTMLInputElement::TELEPHONE:
> +	       case HTMLInputElement::EMAIL:
> +	       case HTMLInputElement::PASSWORD:
> +	       case HTMLInputElement::NUMBER:
> +		   return i->value().isEmpty();
> +	       case HTMLInputElement::FILE:
> +		   return i->files()->isEmpty();
> +	       case HTMLInputElement::CHECKBOX:
> +		   return !i->checked();
> +	       case HTMLInputElement::RADIO:
> +		   return
!i->document()->checkedRadioButtons().checkedButtonForGroup(i->name());
> +	       default:
> +		   return false;

Same thought about omitting the default case from this.

Again, would this be done better with code in the various element classes and a
virtual function rather than all this code specific per-type here in the
ValidityState class?

I think those are enough comments that I'll say review- and give you a chance
to consider the comments. I think all the comments I made are optional, so
please do use your own best judgement.

From bugzilla-daemon at webkit.org  Fri Jul 17 12:35:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:35:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 10930] WebKit could benefit
 from a JavaScript live object profiler : [Attachment 32237] adds live
 object profiling capabilities
In-Reply-To: <bug-10930-0@https.bugs.webkit.org/>
References: <bug-10930-0@https.bugs.webkit.org/>
Message-ID: <20090717193513.035D4337B68C@gamma.macosforge.org>

Kevin McCullough <kmccullough at apple.com> has denied Horia Olaru
<olaru at adobe.com>'s request for review:
Bug 10930: WebKit could benefit from a JavaScript live object profiler
https://bugs.webkit.org/show_bug.cgi?id=10930

Attachment 32237: adds live object profiling capabilities
https://bugs.webkit.org/attachment.cgi?id=32237&action=review

------- Additional Comments from Kevin McCullough <kmccullough at apple.com>

> Index: JavaScriptCore/profiler/LiveObjects.cpp
> ===================================================================
> --- JavaScriptCore/profiler/LiveObjects.cpp	(revision 0)
> +++ JavaScriptCore/profiler/LiveObjects.cpp	(revision 0)
> +
> +void LiveObjects::removeNode(const JSCell* cell)
> +{
> +    ASSERT(cell);
> +    if (!m_storeCollectedObjects)
> +	   m_stackMap.remove(cell);
> +    else {
> +	   RefPtr<ProfileNode> node = m_stackMap.take(cell);
> +	   if (node && !isFree(cell))
> +	      
m_cachedObjects.append(ObjectIdentifier::create(m_cachedObjects.size(), cell,
node));

Why are we appending to m_cachedObjects only if cell was not freed?

> +    }
> +}
> +// This method is meant to be called from the stopProfiling method of
ProfileGenerator
> +// After profiling stops, live objects are likely to be collected, so we
store the
> +// information we have now.
> +void LiveObjects::finalizeCollectedData()
> +{
> +    toVector(m_cachedObjects);
> +

You can probably put toVector()'s code here since it's not called from anywhere
else

> +    // We no longer need the stack map after this
> +    m_stackMap.clear();
> +}

> Index: JavaScriptCore/profiler/ObjectIdentifier.h
> ===================================================================
> --- JavaScriptCore/profiler/ObjectIdentifier.h	(revision 0)
> +++ JavaScriptCore/profiler/ObjectIdentifier.h	(revision 0)
> +namespace JSC {
> +
> +    class ProfileNode;
> +
> +    class ObjectIdentifier : public RefCounted<ObjectIdentifier> {
> +    public:
> +	   unsigned uid() const { return m_uid; }
> +	   UString type() const { return m_type; }
> +	   unsigned size() const { return m_size; }
> +	   ProfileNode* creatingFunction() const { return
m_creatingFunction.get(); }
> +
> +	   static PassRefPtr<ObjectIdentifier> create(unsigned, const JSCell*,
PassRefPtr<ProfileNode>);

This is just my own nit pick but I think our style (although it may not be
documented) is to put the create function before the accessors.

> +
> +    private:
> +	   unsigned m_uid;
> +	   UString m_type;
> +	   unsigned m_size;
> +	   RefPtr<ProfileNode> m_creatingFunction;
> +
> +	   ObjectIdentifier(unsigned, const JSCell*, PassRefPtr<ProfileNode>);

Likewise the constructor before the members.

> +    };
> +
> Index: JavaScriptCore/profiler/Profiler.cpp
> ===================================================================
> --- JavaScriptCore/profiler/Profiler.cpp	(revision 45533)
> +++ JavaScriptCore/profiler/Profiler.cpp	(working copy)
> @@ -86,8 +98,12 @@ PassRefPtr<Profile> Profiler::stopProfil
>	       RefPtr<Profile> returnProfile = profileGenerator->profile();
>  
>	       m_currentProfiles.remove(i);
> -	       if (!m_currentProfiles.size())
> +	       if (!m_currentProfiles.size()) {
> +		   if (m_isMemoryProfilingEnabled)
> +		       JSCell::setDoCollectAllocationTraces(false);
> +

The current Profiler can be running multiple Profiles at the same time.  If we
start and stop JSCell from collecting allocation traces when a profile is
started and stopped then if two profiles are started and one stops the second
profile will no longer get collection or allocation information.  The was we
solve this problem currently is that the JS is re-compiled with the debugging
hooks only when the profiler is enabled and in dispatchFunctionToProfiles() the

list of profiles is empty so no messages are sent.  This still causes a
callIdentifier to be created which is wasteful and we could get some benefit
here from doing less work, but the point is that we need to preserve the 
functionality of allowing multiple profiles to run at once.

>		   s_sharedEnabledProfilerReference = 0;
> +	       }
>	       
>	       return returnProfile;
>	   }
> Index: JavaScriptCore/runtime/JSArray.cpp
> ===================================================================
> --- JavaScriptCore/runtime/JSArray.cpp	(revision 45533)
> +++ JavaScriptCore/runtime/JSArray.cpp	(working copy)
> @@ -1048,6 +1048,22 @@ void JSArray::checkConsistency(Consisten
>  
>  #endif
>  
> +size_t JSArray::instanceSize() const
> +{
> +    // The Base::instanceSize includes the size of the property storage map,

> +    // which counts for cases when the array stores data as properties
> +    size_t computedSize = Base::instanceSize();
> +
> +    // ArrayStorage - storageSize return value includes the storage vector 
> +    computedSize += storageSize(m_storage->m_vectorLength);

Please put a space before and after "->" (e.g. "m_storage -> m_vectorLength")

> +
> +    //  size of Sparse value map
> +    if (SparseArrayValueMap* map = m_storage->m_sparseValueMap)
> +	   computedSize += sizeof(*map) + map->capacity() *
sizeof(SparseArrayValueMap::ValueType);

Ditto

> +
> +    return computedSize;
> +}
> +
>  JSArray* constructEmptyArray(ExecState* exec)
>  {
>      return new (exec)
JSArray(exec->lexicalGlobalObject()->arrayStructure());

> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45533)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,61 @@
> +2009-07-03  Horia Olaru  <olaru at adobe.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Bug 10930: WebKit could benefit from a JavaScript live object
profiler
> +	   https://bugs.webkit.org/show_bug.cgi?id=10930
> +
> +	   Added two new headers to forward JavaScriptCore headers.
> +
> +	   Modified CodeGeneratorJS.pm to check for the "HasInstanceSize"
> +	   attribute and insert an instanceSize method in the generated
JSObjects.
> +	   This method calls the elementSize method from the DOM object
> +	   implementation.
> +
> +	   Added an elementSize method to HTMLImageElement and updated the idl
> +	   to reflect this for the generator script. This is not a complete
> +	   implementation of a size function, but is added to prove
functionality.

This concerns me.  What more work needs to be done?

> +
> +	   Added the JavaScriptObjectIdentifier to the inspector. This is a
class
> +	   containing the JS representation of a profiler live object. The new
> +	   liveObjects property added to the JavaScriptProfile class is an
Array
> +	   of such objects.
> +
> +	   Added the setMemoryProfilingEnabled(boolean) function to the console

> +	   object.
> Index: WebCore/html/HTMLImageElement.cpp
> ===================================================================
> --- WebCore/html/HTMLImageElement.cpp (revision 45533)
> +++ WebCore/html/HTMLImageElement.cpp (working copy)
> @@ -40,6 +40,16 @@ namespace WebCore {
>  
>  using namespace HTMLNames;
>  
> +size_t HTMLImageElement::elementSize() const
> +{
> +    size_t computedSize = sizeof(*this);
> +
> +    if(cachedImage() && cachedImage()->image()->data())
> +	   computedSize += cachedImage()->image()->data()->size();
> +
> +    return computedSize;
> +}

Is this the only HTMLElement that needs an elementSize()?

> Index: WebCore/page/Console.cpp
> ===================================================================
> --- WebCore/page/Console.cpp	(revision 45533)
> +++ WebCore/page/Console.cpp	(working copy)
> @@ -315,6 +315,19 @@ void Console::profileEnd(const JSC::UStr
>      controller->addProfile(profile, lastCaller.lineNumber(),
lastCaller.sourceURL());
>  }
>  
> +void Console::setMemoryProfilingEnabled(bool isEnabled)
> +{
> +    Page* page = this->page();
> +    if (!page)
> +	   return;
> +
> +    // FIXME: see the FIXME in Console::profile
> +    if (!page->inspectorController()->profilerEnabled())
> +	   return;
> +
> +    JSC::Profiler::profiler()->setIsMemoryProfiling(isEnabled);
> +}
> +

I think this patch may be best served by being broken up.  Maybe the JSC part
landed first then the WebCore part.  I'm not comfortable exposing a temporary
API just to make it work for now with plans to replace it later.  That is a
good way to end up with API to stay persistent much longer than intended.

For the purposes of the test cases I'd say just make memory profiling be
enabled whenever normal profiling is, or maybe someone else has a better
suggestion.

It looks like this is getting pretty good and almost ready to land.  I think it
might work well to break the patch up, and we'll need to get some UI as soon as
possible after this lands.

From bugzilla-daemon at webkit.org  Fri Jul 17 12:37:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:37:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27374] WebKit should have a
 bash completion script to aid with common commands. : [Attachment 32949]
 Add script for WebKit command completions in bash.
In-Reply-To: <bug-27374-0@https.bugs.webkit.org/>
References: <bug-27374-0@https.bugs.webkit.org/>
Message-ID: <20090717193740.A4663337B7D5@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27374: WebKit should have a bash completion script to aid with common
commands.
https://bugs.webkit.org/show_bug.cgi?id=27374

Attachment 32949: Add script for WebKit command completions in bash.
https://bugs.webkit.org/attachment.cgi?id=32949&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 12:58:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 12:58:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32963] Fixes, part 4
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717195827.4E8B5337BEA1@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32963: Fixes, part 4
https://bugs.webkit.org/attachment.cgi?id=32963&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +my $devnull = File::Spec->devnull();

I think $devNull would probably read a bit better since it's technically two
words.	(I would use $dev_null in Python.)

> -	   $mimeType =~ s/\r?\n$//g;
> +	   $mimeType =~ s/\r?\n?$//g;

This pattern seems a bit strange since it could end up replacing nothing.  I
think this pattern might work better:

	$mimeType =~ s/[\r\n]+$//g;

> -	   $line =~ s/\r?\n$//g;
> +	   $line =~ s/\r?\n?$//;

Ditto.

> -	   print `svn cat ${sourceFile} | diff -u /dev/null - | tail -n +3`;
> +	   print `svn cat ${sourceFile} | diff -u $devnull - | tail -n +3`;

$devNull

> +	   # Ignore error messages in case we've run past the root of the
checkout.
> +	   open INFO, "svn info '$path' 2> $devnull |" or die;

$devNull

>	   while (<INFO>) {
>	       if (/^Repository Root: (.+)/) {
>		   $thisRoot = $1;
> +		   { local $/ = undef; <INFO>; }  # Eat the rest of the input.
>	       }
>	   }

I think "Consume" would be better than "Eat" here, unless you're feeling
hungry.  :)

r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 13:02:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 13:02:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27383] [Chromium] Hook up
 V8 bindings for DataGrid elements : [Attachment 32965] Patch to hook up the
 V8 bindings
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090717200222.90986337C00B@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32965: Patch to hook up the V8 bindings
https://bugs.webkit.org/attachment.cgi?id=32965&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 13:17:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 13:17:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32963] Fixes, part 4
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717201741.2EBCD337C58B@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32963: Fixes, part 4
https://bugs.webkit.org/attachment.cgi?id=32963&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46054, clearing flags.

From bugzilla-daemon at webkit.org  Fri Jul 17 13:20:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 13:20:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27384] Random crashes in
 appcache/update-cache.html test : [Attachment 32966] proposed fix
In-Reply-To: <bug-27384-0@https.bugs.webkit.org/>
References: <bug-27384-0@https.bugs.webkit.org/>
Message-ID: <20090717202005.747F7337C671@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 27384: Random crashes in appcache/update-cache.html test
https://bugs.webkit.org/show_bug.cgi?id=27384

Attachment 32966: proposed fix
https://bugs.webkit.org/attachment.cgi?id=32966&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 13:38:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 13:38:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32967] win patch + mac/linux stubs
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090717203840.D0B34337CD4C@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32967: win patch + mac/linux stubs
https://bugs.webkit.org/attachment.cgi?id=32967&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Same patch + stubs for Mac/Linux.

From bugzilla-daemon at webkit.org  Fri Jul 17 13:42:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 13:42:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25524] [Gtk] Expose the title
 attribute to assistive technologies : [Attachment 32944] Patch proposal,
 indentation fixed
In-Reply-To: <bug-25524-0@https.bugs.webkit.org/>
References: <bug-25524-0@https.bugs.webkit.org/>
Message-ID: <20090717204204.356AA337CE6F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 25524: [Gtk] Expose the title attribute to assistive technologies
https://bugs.webkit.org/show_bug.cgi?id=25524

Attachment 32944: Patch proposal, indentation fixed
https://bugs.webkit.org/attachment.cgi?id=32944&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This caused regressions:
http://trac.webkit.org/changeset/46038

http://build.webkit.org/results/Leopard%20Intel%20Debug%20(Tests)/r46051%20(293
1)/results.html

About to roll this out.

From bugzilla-daemon at webkit.org  Fri Jul 17 13:48:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 13:48:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27384] Random crashes in
 appcache/update-cache.html test : [Attachment 32966] proposed fix
In-Reply-To: <bug-27384-0@https.bugs.webkit.org/>
References: <bug-27384-0@https.bugs.webkit.org/>
Message-ID: <20090717204824.9B393337D0AD@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 27384: Random crashes in appcache/update-cache.html test
https://bugs.webkit.org/show_bug.cgi?id=27384

Attachment 32966: proposed fix
https://bugs.webkit.org/attachment.cgi?id=32966&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I don't have in depth knowledge of the area, but the patch is pretty simple and
makes a lot of sense.

From bugzilla-daemon at webkit.org  Fri Jul 17 14:12:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:12:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32968]
 Resize Attach Height
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090717211239.5019D337D93C@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32968: Resize Attach Height
https://bugs.webkit.org/attachment.cgi?id=32968&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:19:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:19:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24986] ARM JIT port :
 [Attachment 32175] Constant pool for AssemblerBuffer (v3)
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090717211948.B555B337DB63@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has granted Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32175: Constant pool for AssemblerBuffer (v3)
https://bugs.webkit.org/attachment.cgi?id=32175&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Landed in r46057.

From bugzilla-daemon at webkit.org  Fri Jul 17 14:21:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:21:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27386] Add support for Qt's
 foreach to cpplint : [Attachment 32969] Support for foreach in cpplint
In-Reply-To: <bug-27386-0@https.bugs.webkit.org/>
References: <bug-27386-0@https.bugs.webkit.org/>
Message-ID: <20090717212105.90976337DC2F@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27386: Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

Attachment 32969: Support for foreach in cpplint
https://bugs.webkit.org/attachment.cgi?id=32969&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:25:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:25:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 32970] Fix for 1px CSS border issue
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090717212534.1F06E337DDA4@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 32970: Fix for 1px CSS border issue
https://bugs.webkit.org/attachment.cgi?id=32970&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:29:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:29:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27387] Implement ErrorEvent
 API. : [Attachment 32971] Proposed Patch
In-Reply-To: <bug-27387-0@https.bugs.webkit.org/>
References: <bug-27387-0@https.bugs.webkit.org/>
Message-ID: <20090717212933.7AAB1337DF38@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27387: Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

Attachment 32971: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32971&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:29:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:29:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27386] Add support for Qt's
 foreach to cpplint : [Attachment 32972] Support for foreach in cpplint
In-Reply-To: <bug-27386-0@https.bugs.webkit.org/>
References: <bug-27386-0@https.bugs.webkit.org/>
Message-ID: <20090717212937.10B86337DF51@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27386: Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

Attachment 32972: Support for foreach in cpplint
https://bugs.webkit.org/attachment.cgi?id=32972&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Now with ChangeLog that was missing in the last patch

From bugzilla-daemon at webkit.org  Fri Jul 17 14:29:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:29:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27386] Add support for Qt's
 foreach to cpplint : [Attachment 32969] Support for foreach in cpplint
In-Reply-To: <bug-27386-0@https.bugs.webkit.org/>
References: <bug-27386-0@https.bugs.webkit.org/>
Message-ID: <20090717212937.02177337DF4F@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has canceled
Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org>'s request for
review:
Bug 27386: Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

Attachment 32969: Support for foreach in cpplint
https://bugs.webkit.org/attachment.cgi?id=32969&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Now with ChangeLog that was missing in the last patch

From bugzilla-daemon at webkit.org  Fri Jul 17 14:30:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:30:30 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 32965] Patch to hook up the V8
 bindings
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090717213030.13270337DF94@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has denied Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32965: Patch to hook up the V8 bindings
https://bugs.webkit.org/attachment.cgi?id=32965&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Looks great except for needing to modify CodeGeneratorV8.pm to correctly handle
the [Conditional] attr.

From bugzilla-daemon at webkit.org  Fri Jul 17 14:30:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:30:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27386] Add support for Qt's
 foreach to cpplint : [Attachment 32972] Support for foreach in cpplint
In-Reply-To: <bug-27386-0@https.bugs.webkit.org/>
References: <bug-27386-0@https.bugs.webkit.org/>
Message-ID: <20090717213047.9EDAF337DFA8@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27386: Add support for Qt's foreach to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27386

Attachment 32972: Support for foreach in cpplint
https://bugs.webkit.org/attachment.cgi?id=32972&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:36:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:36:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32904] Fixes, part 3
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717213632.1D3D6337E1CF@gamma.macosforge.org>

Steve Falkenburg <sfalken at apple.com> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32904: Fixes, part 3
https://bugs.webkit.org/attachment.cgi?id=32904&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:37:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:37:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32967] win patch + mac/linux stubs
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090717213749.3BD05337E26E@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32967: win patch + mac/linux stubs
https://bugs.webkit.org/attachment.cgi?id=32967&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Fri Jul 17 14:41:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:41:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 22700] ApplicationCache
 should have size limit : [Attachment 32891] New proposal to limit the
 maximum size of the application cache (take 9)
In-Reply-To: <bug-22700-0@https.bugs.webkit.org/>
References: <bug-22700-0@https.bugs.webkit.org/>
Message-ID: <20090717214102.94A53337E3A8@gamma.macosforge.org>

Anders Carlsson <andersca at apple.com> has granted Andrei Popescu
<andreip at google.com>'s request for review:
Bug 22700: ApplicationCache should have size limit
https://bugs.webkit.org/show_bug.cgi?id=22700

Attachment 32891: New proposal to limit the maximum size of the application
cache (take 9)
https://bugs.webkit.org/attachment.cgi?id=32891&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
SQL/storage parts look fine by me!

From bugzilla-daemon at webkit.org  Fri Jul 17 14:56:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:56:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32973]
 re-resubmission
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090717215601.986B9337E8D9@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32973: re-resubmission
https://bugs.webkit.org/attachment.cgi?id=32973&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 14:58:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:58:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32973]
 re-resubmission
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090717215838.2B064337E990@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32973: re-resubmission
https://bugs.webkit.org/attachment.cgi?id=32973&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why is this needed?
 #include "HTMLNames.h"
+#include "CompositeEditCommand.h"

Seems wrong.

From bugzilla-daemon at webkit.org  Fri Jul 17 14:58:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 14:58:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24986] ARM JIT port :
 [Attachment 32176] Add YARR support for generic ARM platforms (v3)
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090717215840.415CB337E9A4@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has granted Gabor Loki
<loki at inf.u-szeged.hu>'s request for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32176: Add YARR support for generic ARM platforms (v3)
https://bugs.webkit.org/attachment.cgi?id=32176&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Landed in r46059.

Sorry for the delay in getting back to these, will start looking at the new
patches at the start of next week.

cheers,
G.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:03:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:03:23 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32904] Fixes, part 3
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717220323.BE4E1337EBA0@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32904: Fixes, part 3
https://bugs.webkit.org/attachment.cgi?id=32904&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46060, clearing flags.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:04:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:04:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26715] bugzilla-tool should
 automate rollouts : [Attachment 32974] Updated patch for rollout support
In-Reply-To: <bug-26715-0@https.bugs.webkit.org/>
References: <bug-26715-0@https.bugs.webkit.org/>
Message-ID: <20090717220440.BE229337EC10@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26715: bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

Attachment 32974: Updated patch for rollout support
https://bugs.webkit.org/attachment.cgi?id=32974&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 4 files changed, 189 insertions(+), 51 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 15:05:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:05:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32975] Proposed patch, rev.5
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717220549.04D72337EC64@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32975: Proposed patch, rev.5
https://bugs.webkit.org/attachment.cgi?id=32975&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
Modified according to comments from Darin and Peter.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:06:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:06:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26715] bugzilla-tool should
 automate rollouts : [Attachment 32974] Updated patch for rollout support
In-Reply-To: <bug-26715-0@https.bugs.webkit.org/>
References: <bug-26715-0@https.bugs.webkit.org/>
Message-ID: <20090717220621.E080F337ECA5@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26715: bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

Attachment 32974: Updated patch for rollout support
https://bugs.webkit.org/attachment.cgi?id=32974&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:06:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:06:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26715] bugzilla-tool should
 automate rollouts : [Attachment 32976] Begone ye tabs!
In-Reply-To: <bug-26715-0@https.bugs.webkit.org/>
References: <bug-26715-0@https.bugs.webkit.org/>
Message-ID: <20090717220624.3EDC9337ECB6@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 26715: bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

Attachment 32976: Begone ye tabs!
https://bugs.webkit.org/attachment.cgi?id=32976&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 4 files changed, 189 insertions(+), 51 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 15:09:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:09:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27038] htmlediting.cpp
 needs more utility functions to fix the bug 26816 : [Attachment 32977] 9th
 submission
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090717220953.0B3FC337EDD0@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32977: 9th submission
https://bugs.webkit.org/attachment.cgi?id=32977&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:11:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:11:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27390] CSS custom cursor
 hotspots should work in quirks mode : [Attachment 32978] Patch
In-Reply-To: <bug-27390-0@https.bugs.webkit.org/>
References: <bug-27390-0@https.bugs.webkit.org/>
Message-ID: <20090717221118.1AC84337EE64@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 27390: CSS custom cursor hotspots should work in quirks mode
https://bugs.webkit.org/show_bug.cgi?id=27390

Attachment 32978: Patch
https://bugs.webkit.org/attachment.cgi?id=32978&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
In Radar as <rdar://problem/6554340>

From bugzilla-daemon at webkit.org  Fri Jul 17 15:15:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:15:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32975] Proposed patch, rev.5
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717221521.03133337EF95@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32975: Proposed patch, rev.5
https://bugs.webkit.org/attachment.cgi?id=32975&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    switch (inputType()) {
> +	   case TEXT:
> +	   case SEARCH:
> +	   case URL:
> +	   case TELEPHONE:
> +	   case EMAIL:
> +	   case PASSWORD:
> +	   case NUMBER:
> +	   case FILE:
> +	       return value().isEmpty();
> +	   case CHECKBOX:
> +	       return !checked();
> +	   case RADIO:
> +	       return
!document()->checkedRadioButtons().checkedButtonForGroup(name());
> +	   case HIDDEN:
> +	   case RANGE:
> +	   case SUBMIT:
> +	   case IMAGE:
> +	   case RESET:
> +	   case BUTTON:
> +	   case ISINDEX:
> +	       ASSERT_NOT_REACHED();
> +    }
> +
> +    return false;

Could also use an assertion outside the switch statement, since that should not
be reached either. I suggest replacing the ASSERT_NOT_REACHED with a break and
moving the ASSERT_NOT_REACHED outside the switch.

r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 15:16:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:16:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27038] htmlediting.cpp needs
 more utility functions to fix the bug 26816 : [Attachment 32977] 9th
 submission
In-Reply-To: <bug-27038-0@https.bugs.webkit.org/>
References: <bug-27038-0@https.bugs.webkit.org/>
Message-ID: <20090717221620.00BE7337F007@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa
<ryosuke.niwa at gmail.com>'s request for review:
Bug 27038: htmlediting.cpp needs more utility functions to fix the bug 26816
https://bugs.webkit.org/show_bug.cgi?id=27038

Attachment 32977: 9th submission
https://bugs.webkit.org/attachment.cgi?id=32977&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Generally we sort headers in alphabetical order, but this is fine to land
as-is.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:17:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:17:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32979] Proposed patch, rev. 5b
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717221740.58F90337F07B@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32979: Proposed patch, rev. 5b
https://bugs.webkit.org/attachment.cgi?id=32979&action=review

------- Additional Comments from Michelangelo De Simone <micdesim at gmail.com>
Done.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:18:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:18:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27390] CSS custom cursor
 hotspots should work in quirks mode : [Attachment 32978] Patch
In-Reply-To: <bug-27390-0@https.bugs.webkit.org/>
References: <bug-27390-0@https.bugs.webkit.org/>
Message-ID: <20090717221808.452DA337F0B0@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 27390: CSS custom cursor hotspots should work in quirks mode
https://bugs.webkit.org/show_bug.cgi?id=27390

Attachment 32978: Patch
https://bugs.webkit.org/attachment.cgi?id=32978&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:18:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:18:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25551] Support for HTML5
 Forms "required" attribute : [Attachment 32979] Proposed patch, rev. 5b
In-Reply-To: <bug-25551-0@https.bugs.webkit.org/>
References: <bug-25551-0@https.bugs.webkit.org/>
Message-ID: <20090717221839.50E1B337F0D8@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25551: Support for HTML5 Forms "required" attribute
https://bugs.webkit.org/show_bug.cgi?id=25551

Attachment 32979: Proposed patch, rev. 5b
https://bugs.webkit.org/attachment.cgi?id=32979&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:24:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:24:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32980] win VFS + mac/linux stubs
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090717222432.F0F13337F2CF@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32980: win VFS + mac/linux stubs
https://bugs.webkit.org/attachment.cgi?id=32980&action=review

------- Additional Comments from Dumitru Daniliuc <dumi at chromium.org>
Last patch for this bug hopefully...

From bugzilla-daemon at webkit.org  Fri Jul 17 15:27:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:27:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32981] Fixes, part 5
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717222729.71329337F402@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked David Kilzer (ddkilzer)
<ddkilzer at webkit.org> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32981: Fixes, part 5
https://bugs.webkit.org/attachment.cgi?id=32981&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Fixes for a couple of the above issues

From bugzilla-daemon at webkit.org  Fri Jul 17 15:35:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:35:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27391] Get the branch
 working on windows. : [Attachment 32982] patch
In-Reply-To: <bug-27391-0@https.bugs.webkit.org/>
References: <bug-27391-0@https.bugs.webkit.org/>
Message-ID: <20090717223520.06329337F67F@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has asked  for review:
Bug 27391: Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391

Attachment 32982: patch
https://bugs.webkit.org/attachment.cgi?id=32982&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:42:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:42:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32983] same patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090717224220.68B28337F95D@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32983: same patch
https://bugs.webkit.org/attachment.cgi?id=32983&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:42:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:42:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32980] win VFS + mac/linux stubs
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090717224220.4DD65337F95B@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has canceled Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32980: win VFS + mac/linux stubs
https://bugs.webkit.org/attachment.cgi?id=32980&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:43:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:43:43 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26940] [Chromium] Add a
 SQLite VFS for Chromium : [Attachment 32983] same patch
In-Reply-To: <bug-26940-0@https.bugs.webkit.org/>
References: <bug-26940-0@https.bugs.webkit.org/>
Message-ID: <20090717224343.F0B15337F9F0@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 26940: [Chromium] Add a SQLite VFS for Chromium
https://bugs.webkit.org/show_bug.cgi?id=26940

Attachment 32983: same patch
https://bugs.webkit.org/attachment.cgi?id=32983&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
good deal. Let's land this puppy.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:50:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:50:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27391] Get the branch working
 on windows. : [Attachment 32982] patch
In-Reply-To: <bug-27391-0@https.bugs.webkit.org/>
References: <bug-27391-0@https.bugs.webkit.org/>
Message-ID: <20090717225049.C64F6337FC0B@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Geoffrey Garen <ggaren at apple.com>'s
request for review:
Bug 27391: Get the branch working on windows.
https://bugs.webkit.org/show_bug.cgi?id=27391

Attachment 32982: patch
https://bugs.webkit.org/attachment.cgi?id=32982&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:52:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:52:09 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32652] addressed eric's
 feedback and added a manual test
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090717225209.E579F337FC6E@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled  review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32652: addressed eric's feedback and added a manual test
https://bugs.webkit.org/attachment.cgi?id=32652&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:52:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:52:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32984] updated: return key
 should popup the menu list too for gtk
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090717225216.ACF6E337FC8D@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32984: updated: return key should popup the menu list too for gtk
https://bugs.webkit.org/attachment.cgi?id=32984&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:53:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:53:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27383] [Chromium] Hook up
 V8 bindings for DataGrid elements : [Attachment 32985] 2nd patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090717225328.EE523337FD18@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32985: 2nd patch
https://bugs.webkit.org/attachment.cgi?id=32985&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
Changes in this patch:
At Dimitri's request I took out the #ifdef I added to DOMWindow.idl, and
instead fixed the V8 code generator to add #ifs around conditionally-enabled
attributes (in GenerateBatchedAttributeData).
This Perl function had really messed up indentation that obscured the flow of
control, so I fixed it; but that introduces a bunch of spurious diffs that are
just whitespace changes. Sorry about that (but I felt this needed fixing, as it
confused me on first reading.)

From bugzilla-daemon at webkit.org  Fri Jul 17 15:55:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:55:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27394] V8: Selenium test
 failures : [Attachment 32986] Fix global access after navigation
In-Reply-To: <bug-27394-0@https.bugs.webkit.org/>
References: <bug-27394-0@https.bugs.webkit.org/>
Message-ID: <20090717225548.26BCC337FDDA@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27394: V8: Selenium test failures
https://bugs.webkit.org/show_bug.cgi?id=27394

Attachment 32986: Fix global access after navigation
https://bugs.webkit.org/attachment.cgi?id=32986&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 15:58:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:58:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 32985] 2nd patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090717225832.23449337FEE4@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32985: 2nd patch
https://bugs.webkit.org/attachment.cgi?id=32985&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
Great! Just one nit:

> Index: WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp
> ===================================================================
> --- WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp       
(revision 46037)
> +++ WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp       
(working copy)
> @@ -29,7 +29,9 @@
>   */
>  
>  #include "config.h"
> +#include "Document.h"
>  #include "HTMLDataGridElement.h"
> +#include "V8DataGridDataSource.h"
>  
>  #include "NotImplemented.h"

We don't need this one anymore, right?

From bugzilla-daemon at webkit.org  Fri Jul 17 15:59:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:59:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27327] [Chromium] Clean up v8
 bindings a bit : [Attachment 32901] rev 3
In-Reply-To: <bug-27327-0@https.bugs.webkit.org/>
References: <bug-27327-0@https.bugs.webkit.org/>
Message-ID: <20090717225919.65FE3337FF4D@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27327: [Chromium] Clean up v8 bindings a bit
https://bugs.webkit.org/show_bug.cgi?id=27327

Attachment 32901: rev 3
https://bugs.webkit.org/attachment.cgi?id=32901&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Fri Jul 17 15:59:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 15:59:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32981] Fixes, part 5
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717225921.21363337FF6B@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32981: Fixes, part 5
https://bugs.webkit.org/attachment.cgi?id=32981&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me

You might mention you "stole" normalizePath() from prepare-ChangeLog in the
entry for update-webkit.  :)

From bugzilla-daemon at webkit.org  Fri Jul 17 16:01:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:01:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27394] V8: Selenium test
 failures : [Attachment 32986] Fix global access after navigation
In-Reply-To: <bug-27394-0@https.bugs.webkit.org/>
References: <bug-27394-0@https.bugs.webkit.org/>
Message-ID: <20090717230142.1EDF13380077@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Mads Ager
<ager at chromium.org>'s request for review:
Bug 27394: V8: Selenium test failures
https://bugs.webkit.org/show_bug.cgi?id=27394

Attachment 32986: Fix global access after navigation
https://bugs.webkit.org/attachment.cgi?id=32986&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok

From bugzilla-daemon at webkit.org  Fri Jul 17 16:02:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:02:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32981] Fixes, part 5
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090717230202.3AA6533800A1@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32981: Fixes, part 5
https://bugs.webkit.org/attachment.cgi?id=32981&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46064, clearing flags

From bugzilla-daemon at webkit.org  Fri Jul 17 16:05:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:05:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27181] StorageArea should
 only contain methods we intend to proxy : [Attachment 32828] v1
In-Reply-To: <bug-27181-0@https.bugs.webkit.org/>
References: <bug-27181-0@https.bugs.webkit.org/>
Message-ID: <20090717230510.E7ED933801B2@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27181: StorageArea should only contain methods we intend to proxy
https://bugs.webkit.org/show_bug.cgi?id=27181

Attachment 32828: v1
https://bugs.webkit.org/attachment.cgi?id=32828&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 16:05:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:05:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27396] Moving cursor in
 Thai text sometimes jumps over two characters : [Attachment 32987] proposed
 fix
In-Reply-To: <bug-27396-0@https.bugs.webkit.org/>
References: <bug-27396-0@https.bugs.webkit.org/>
Message-ID: <20090717230527.87FD033801EB@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 27396: Moving cursor in Thai text sometimes jumps over two characters
https://bugs.webkit.org/show_bug.cgi?id=27396

Attachment 32987: proposed fix
https://bugs.webkit.org/attachment.cgi?id=32987&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 16:13:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:13:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32968]
 Resize Attach Height
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090717231340.B728C3380508@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32968: Resize Attach Height
https://bugs.webkit.org/attachment.cgi?id=32968&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
>  void InspectorController::showWindow()
>  {
>      ASSERT(enabled());
> +
> +    unsigned inspectedPageHeight =
m_inspectedPage->mainFrame()->view()->visibleHeight();
> +
>      m_client->showWindow();
> +
> +    Setting attachedHeight = setting(inspectorAttachedHeightName);
> +    unsigned preferredHeight = attachedHeight.type() == Setting::IntegerType
? attachedHeight.integerValue() : defaultAttachedHeight;
> +
> +    // This call might not go through (if the window starts out detached),
but if the window is initially created attached,
> +    // InspectorController::attachWindow is never called, so we need to make
sure to set the attachedWindowHeight.
> +   
m_client->setAttachedWindowHeight(constrainedAttachedWindowHeight(preferredHeig
ht, inspectedPageHeight));

I think it's worth adding a FIXME here about cleaning this up so we can share
this logic with attachWindow.

This turned out really nicely. Thanks for doing all those revisions and working
out the bugs!

r=me

From bugzilla-daemon at webkit.org  Fri Jul 17 16:16:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:16:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27396] Moving cursor in Thai
 text sometimes jumps over two characters : [Attachment 32987] proposed fix
In-Reply-To: <bug-27396-0@https.bugs.webkit.org/>
References: <bug-27396-0@https.bugs.webkit.org/>
Message-ID: <20090717231604.2532633805FC@gamma.macosforge.org>

mitz at webkit.org has granted Alexey Proskuryakov <ap at webkit.org>'s request for
review:
Bug 27396: Moving cursor in Thai text sometimes jumps over two characters
https://bugs.webkit.org/show_bug.cgi?id=27396

Attachment 32987: proposed fix
https://bugs.webkit.org/attachment.cgi?id=32987&action=review

------- Additional Comments from mitz at webkit.org
r=me if you add a description and the Radar link to the change log

From bugzilla-daemon at webkit.org  Fri Jul 17 16:26:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:26:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27383] [Chromium] Hook up
 V8 bindings for DataGrid elements : [Attachment 32988] 3rd patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090717232645.A54F43380933@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32988: 3rd patch
https://bugs.webkit.org/attachment.cgi?id=32988&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
OK, this patch simply gets rid of the #include "NotImplemented.h" that Dimitri
correctly pointed out is no longer needed.

From bugzilla-daemon at webkit.org  Fri Jul 17 16:29:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 16:29:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 32988] 3rd patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090717232927.76B483380A02@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32988: 3rd patch
https://bugs.webkit.org/attachment.cgi?id=32988&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 17:07:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:07:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27397] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32989] patch
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090718000719.19ECC3381438@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27397: V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32989: patch
https://bugs.webkit.org/attachment.cgi?id=32989&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 17:11:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:11:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 32990]
 Patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090718001105.0EEAB33815A7@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 32990: Patch
https://bugs.webkit.org/attachment.cgi?id=32990&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 17:11:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:11:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 14272] Cannot change the
 height of the Web Inspector when docked on Windows : [Attachment 32968]
 Resize Attach Height
In-Reply-To: <bug-14272-0@https.bugs.webkit.org/>
References: <bug-14272-0@https.bugs.webkit.org/>
Message-ID: <20090718001136.BDEEF33815D6@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has canceled  review:
Bug 14272: Cannot change the height of the Web Inspector when docked on Windows
https://bugs.webkit.org/show_bug.cgi?id=14272

Attachment 32968: Resize Attach Height
https://bugs.webkit.org/attachment.cgi?id=32968&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 17:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:17:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27397] V8IsolatedWorld keeps
 a handle to a disposed context : [Attachment 32989] patch
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090718001759.3BACF33817EF@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27397: V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32989: patch
https://bugs.webkit.org/attachment.cgi?id=32989&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 17:19:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:19:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27397] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32989] patch
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090718001902.C26CF338184E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27397: V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32989: patch
https://bugs.webkit.org/attachment.cgi?id=32989&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Silly bzt.  Not obsolete.

From bugzilla-daemon at webkit.org  Fri Jul 17 17:19:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:19:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27397] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32991] Fix weak handle
 issue
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090718001951.BFFD23381894@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27397: V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32991: Fix weak handle issue
https://bugs.webkit.org/attachment.cgi?id=32991&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 17:41:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:41:53 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 32990]
 Patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090718004153.0E58B3381EAF@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 32990: Patch
https://bugs.webkit.org/attachment.cgi?id=32990&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================

> +	   Second, I turn off all opacity animation.

Not always, I hope!

> Index: WebCore/platform/graphics/GraphicsLayer.h
> ===================================================================

>  private:
> +    void setOpacityOnLayer();

I think it should be called "update" if it takes no argument, or "set" if it
takes one.

> Index: WebCore/platform/graphics/mac/GraphicsLayerCA.mm
> ===================================================================

> +float GraphicsLayerCA::accumulatedOpacity() const
> +{
> +    if (!preserves3D())
> +	   return 1;
> +	   
> +    return m_opacity * (parent() ? parent()->accumulatedOpacity() : 1);
> +}
> +
> +void GraphicsLayerCA::distributeOpacity(float opacity)

Argument could be "accumulatedOpacity" for clarity.

> +{
> +    // If this is a transform layer we need to distribute our opacity to all
our children
> +    // and set the opacity on our m_layer. Otherwise we just set our own
opacity.
> +    
> +    // Incoming opacity is the contribution from our parent(s). We mutiply
this by our own
> +    // opacity to get the value that is either passed down to the children
or set on our
> +    // own layer.
> +    opacity *= m_opacity;
> +    
> +    if (preserves3D()) {
> +	   if (m_layer.get())
> +	       [m_layer.get() setOpacity: opacity];
> +
> +	   size_t numChildren = children().size();
> +	   for (size_t i = 0; i < numChildren; ++i)
> +	       children()[i]->distributeOpacity(opacity);
> +    } else
> +	   [primaryLayer() setOpacity: opacity];
> +}

I think put the platform-neutral logic into base class methods, and then add a
small virtual function 
to wrap the [layer setOpacity:] call. BTW, webcore style is no space after
colons.

From bugzilla-daemon at webkit.org  Fri Jul 17 17:59:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 17:59:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32992] Fixes, part 6
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090718005913.F36223382382@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked David Kilzer (ddkilzer)
<ddkilzer at webkit.org> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32992: Fixes, part 6
https://bugs.webkit.org/attachment.cgi?id=32992&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This makes resolve-ChangeLogs work significantly better for non-Cygwin SVNs.

One concern I have is my usage of --binary.  Without this, the ChangeLog files
were being converted from CRLF (how they were checked out) to LF by patch,
except for the new local changes, which were preserved as CRLF, leaving the
ChangeLogs in a mixed state.  I _think_ it should be safe on all platforms to
use --binary here to tell diff and patch to treat line endings as a black box
and not modify them, but I admit it's not what happens in svn-create-patch,
svn-apply, svn-unapply, etc., which (on my non-Cygwin SVN system) currently
strip CRs from everywhere (resulting in files whose line endings are completely
changed, which doesn't bother svn if the files have an svn:eol-style set).  I'm
concerned that if I add more usage of --binary to all these scripts that files
checked out with eol-style "native" and then modified will result in patches
which can't be cleanly applied on OSes different from the one which created
them.  By contrast, the changes here only affect the internal workings of
resolve-ChangeLogs, so they can't cause such problems, unless the local
ChangeLogs have mixed endings before running resolve-ChangeLogs.

What a mess.

From bugzilla-daemon at webkit.org  Fri Jul 17 18:00:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:00:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27351] [Qt] navigator.platform
 returns an empty string in Symbian and in Linux platforms : [Attachment
 32911] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090718010049.9A6293382407@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has denied	review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32911: Patch
https://bugs.webkit.org/attachment.cgi?id=32911&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

>  
>  String NavigatorBase::platform() const
>  {
> +#if PLATFORM(LINUX)
> +    struct utsname osname;
> +    int result = uname(&osname);
> +    String platformName;
> +    if (result >= 0) {
> +	   platformName = osname.sysname;
> +	   platformName += " ";
> +	   platformName += osname.machine;
> +    }
> +    return platformName;
> +#else
>      return WEBCORE_NAVIGATOR_PLATFORM;
> +#endif

Jan is right, we should call uname(&osname) exactly once. Yael could you post
an updated version of the patch?

From bugzilla-daemon at webkit.org  Fri Jul 17 18:02:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:02:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27400] Inspector:
 Automatically Refresh DOM Storage Grids on "storage" event : [Attachment
 32993] Live Update both DOM Storage Grids
In-Reply-To: <bug-27400-0@https.bugs.webkit.org/>
References: <bug-27400-0@https.bugs.webkit.org/>
Message-ID: <20090718010244.CE71C338248B@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27400: Inspector: Automatically Refresh DOM Storage Grids on "storage"
event
https://bugs.webkit.org/show_bug.cgi?id=27400

Attachment 32993: Live Update both DOM Storage Grids
https://bugs.webkit.org/attachment.cgi?id=32993&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
NOTES:

- Assumes only 2 storages exist (like the current code does with the
"isLocalStorage" property.
- Tested on localStorage and sessionStorage and it worked great.
- register/unregister functions would be great to use for a toolbar item in
case this moves into a setting.

From bugzilla-daemon at webkit.org  Fri Jul 17 18:08:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:08:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27368] [Qt] On Symbian link
 against the system sqlite3 : [Attachment 32935] First try.
In-Reply-To: <bug-27368-0@https.bugs.webkit.org/>
References: <bug-27368-0@https.bugs.webkit.org/>
Message-ID: <20090718010805.8463133825B2@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27368: [Qt] On Symbian link against the system sqlite3
https://bugs.webkit.org/show_bug.cgi?id=27368

Attachment 32935: First try.
https://bugs.webkit.org/attachment.cgi?id=32935&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>

> +	       INCLUDEPATH += $${SQLITE3SRCDIR}
> +	       symbian: LIBS += -lsqlite3.lib
> +	       else: LIBS += -lsqlite3



Looks good, it might look like the else is not properly indented... please
check that when landing.

From bugzilla-daemon at webkit.org  Fri Jul 17 18:11:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:11:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27399] DRT doesn't reliably
 snapshot composited layers : [Attachment 32994] Patch, changelog
In-Reply-To: <bug-27399-0@https.bugs.webkit.org/>
References: <bug-27399-0@https.bugs.webkit.org/>
Message-ID: <20090718011107.856963382693@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27399: DRT doesn't reliably snapshot composited layers
https://bugs.webkit.org/show_bug.cgi?id=27399

Attachment 32994: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32994&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:17:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:17:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32782] updated patch
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090718011753.CD15E3382881@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled  review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32782: updated patch
https://bugs.webkit.org/attachment.cgi?id=32782&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:17:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32995] Updated to use result->str instead of a temp var
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090718011759.2982B3382890@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32995: Updated to use result->str instead of a temp var
https://bugs.webkit.org/attachment.cgi?id=32995&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:22:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:22:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27399] DRT doesn't reliably
 snapshot composited layers : [Attachment 32994] Patch, changelog
In-Reply-To: <bug-27399-0@https.bugs.webkit.org/>
References: <bug-27399-0@https.bugs.webkit.org/>
Message-ID: <20090718012219.C34273382993@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 27399: DRT doesn't reliably snapshot composited layers
https://bugs.webkit.org/show_bug.cgi?id=27399

Attachment 32994: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=32994&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:23:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:23:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27351] [Qt]
 navigator.platform returns an empty string in Symbian and in Linux
 platforms : [Attachment 32996] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090718012332.D7BBF33829CC@gamma.macosforge.org>

Yael <yael.aharon at nokia.com> has asked	for review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32996: Patch
https://bugs.webkit.org/attachment.cgi?id=32996&action=review

------- Additional Comments from Yael <yael.aharon at nokia.com>
Use DEFINE_STATIC_LOCAL as requested in comment #8.

From bugzilla-daemon at webkit.org  Fri Jul 17 18:30:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:30:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27401]
 webkit-tools-completion.sh has two typos and sorting issues. : [Attachment
 32997] Proposed fix.
In-Reply-To: <bug-27401-0@https.bugs.webkit.org/>
References: <bug-27401-0@https.bugs.webkit.org/>
Message-ID: <20090718013054.DC1D93382B77@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27401: webkit-tools-completion.sh has two typos and sorting issues.
https://bugs.webkit.org/show_bug.cgi?id=27401

Attachment 32997: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32997&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:33:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:33:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27401]
 webkit-tools-completion.sh has two typos and sorting issues. : [Attachment
 32997] Proposed fix.
In-Reply-To: <bug-27401-0@https.bugs.webkit.org/>
References: <bug-27401-0@https.bugs.webkit.org/>
Message-ID: <20090718013306.4DB6A3382C5F@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 27401: webkit-tools-completion.sh has two typos and sorting issues.
https://bugs.webkit.org/show_bug.cgi?id=27401

Attachment 32997: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=32997&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:43:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:43:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27351] [Qt]
 navigator.platform returns an empty string in Symbian and in Linux
 platforms : [Attachment 32996] Patch
In-Reply-To: <bug-27351-0@https.bugs.webkit.org/>
References: <bug-27351-0@https.bugs.webkit.org/>
Message-ID: <20090718014334.B3AC53382F54@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yael <yael.aharon at nokia.com>'s
request for review:
Bug 27351: [Qt] navigator.platform returns an empty string in Symbian and in
Linux platforms
https://bugs.webkit.org/show_bug.cgi?id=27351

Attachment 32996: Patch
https://bugs.webkit.org/attachment.cgi?id=32996&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:50:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:50:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27403] Add test case for
 bug 27394 : [Attachment 32998] Layout test for window access after
 navigation.
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718015011.0D6A63383114@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 32998: Layout test for window access after navigation.
https://bugs.webkit.org/attachment.cgi?id=32998&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 18:56:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:56:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27403] Add test case for bug
 27394 : [Attachment 32998] Layout test for window access after navigation.
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718015637.34A9233832D2@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has canceled Mads Ager <ager at chromium.org>'s
request for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 32998: Layout test for window access after navigation.
https://bugs.webkit.org/attachment.cgi?id=32998&action=review

------- Additional Comments from Mads Ager <ager at chromium.org>
Test for 'blank.html' instead of just 'blank' to avoid matching 'about:blank'.

From bugzilla-daemon at webkit.org  Fri Jul 17 18:57:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 18:57:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27403] Add test case for
 bug 27394 : [Attachment 32999] Layout test for window access after
 navigation.
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718015718.373FD3383311@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 32999: Layout test for window access after navigation.
https://bugs.webkit.org/attachment.cgi?id=32999&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 19:02:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:02:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27403] Add test case for bug
 27394 : [Attachment 32999] Layout test for window access after navigation.
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718020232.58A3D3383441@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has canceled Mads Ager <ager at chromium.org>'s
request for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 32999: Layout test for window access after navigation.
https://bugs.webkit.org/attachment.cgi?id=32999&action=review

------- Additional Comments from Mads Ager <ager at chromium.org>
And fixing the ChangeLog with the right bug number.  Sorry about the spam.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:02:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:02:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27403] Add test case for
 bug 27394 : [Attachment 33000] Layout test for window access after
 navigation.
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718020232.754863383445@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 33000: Layout test for window access after navigation.
https://bugs.webkit.org/attachment.cgi?id=33000&action=review

------- Additional Comments from Mads Ager <ager at chromium.org>
And fixing the ChangeLog with the right bug number.  Sorry about the spam.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:15:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:15:52 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27403] Add test case for bug
 27394 : [Attachment 33000] Layout test for window access after navigation.
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718021552.BA76D33837A6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Mads Ager <ager at chromium.org>'s
request for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 33000: Layout test for window access after navigation.
https://bugs.webkit.org/attachment.cgi?id=33000&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Please don't use polling.  Use the frame's load event instead.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:22:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:22:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32992] Fixes, part 6
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090718022207.20A2E3383952@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32992: Fixes, part 6
https://bugs.webkit.org/attachment.cgi?id=32992&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me as long as this has been tested in a UNIX environment as well.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:25:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:25:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 32984] updated: return key
 should popup the menu list too for gtk
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090718022526.70FEE3383A4E@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 32984: updated: return key should popup the menu list too for gtk
https://bugs.webkit.org/attachment.cgi?id=32984&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 19:25:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:25:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 33001] Make it
 if-elif-else-endif as suggested by Holger
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090718022532.642CD3383A6C@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 33001: Make it if-elif-else-endif as suggested by Holger
https://bugs.webkit.org/attachment.cgi?id=33001&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 19:34:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:34:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27230] [Gtk]
 soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not
 declared in this scope : [Attachment 33002] Use g_mapped_file_unref for
 GLIB version 2.22 onwards.
In-Reply-To: <bug-27230-0@https.bugs.webkit.org/>
References: <bug-27230-0@https.bugs.webkit.org/>
Message-ID: <20090718023447.4AD1F3383D4B@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27230: [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free'
was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=27230

Attachment 33002: Use g_mapped_file_unref for GLIB version 2.22 onwards.
https://bugs.webkit.org/attachment.cgi?id=33002&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 19:41:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:41:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 18363] [GTK] Combo boxes
 cannot be opened pressing space : [Attachment 33001] Make it
 if-elif-else-endif as suggested by Holger
In-Reply-To: <bug-18363-0@https.bugs.webkit.org/>
References: <bug-18363-0@https.bugs.webkit.org/>
Message-ID: <20090718024155.CA5E53383EF1@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 18363: [GTK] Combo boxes cannot be opened pressing space
https://bugs.webkit.org/show_bug.cgi?id=18363

Attachment 33001: Make it if-elif-else-endif as suggested by Holger
https://bugs.webkit.org/attachment.cgi?id=33001&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
OKay, the next thing boils down to taste. To reduce code duplication one could
do

if (
#if SPACE_OR_..
keyCode == ' ' || keyCode == '\r'
#elif
keyCode == ' '
#endif
) {
  common Code
}

From bugzilla-daemon at webkit.org  Fri Jul 17 19:42:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:42:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26715] bugzilla-tool should
 automate rollouts : [Attachment 32976] Begone ye tabs!
In-Reply-To: <bug-26715-0@https.bugs.webkit.org/>
References: <bug-26715-0@https.bugs.webkit.org/>
Message-ID: <20090718024225.D20F03383F2E@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 26715: bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

Attachment 32976: Begone ye tabs!
https://bugs.webkit.org/attachment.cgi?id=32976&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to address.  I'm most concerned about the issue I mentioned
in update_changelog_for_revert.

Two general notes:
1. It was pointed out to me that python style is to have two blank lines
between top level functions: "Separate top-level function and class definitions
with two blank lines."
2. Many comments don't end with periods.  Please add them.

> diff --git a/WebKitTools/Scripts/bugzilla-tool
b/WebKitTools/Scripts/bugzilla-tool

> +def update_changelog_for_revert(changelog_path, revision):
> +    removing_boilerplate = False
> +    # inplace=1 creates a backup file and re-directs stdout to the file
> +    for line in fileinput.FileInput(changelog_path, inplace=1):
> +	   if re.search('Reviewed by', line):

I'm confused.  How does this stop after this boilerplate change log that was
just created?

It looks like it goes through the whole changelog removing all descriptions
along the way.


> +	       print line.replace("Reviewed by NOBODY (OOPS!)", "No review,
rolling out %s" % revision),

I like to prefix revisions with an r.
Consider: ..."No review, rolling out r%s"...


> +class RolloutCommit(Command):
...
> +    def create_changelogs_for_revert(scm, revision):
...
> +	   # This could move to prepare-ChangeLog by adding a --revert= option

That might be easier.  I think the current code has a bug as I noted above.


> diff --git a/WebKitTools/Scripts/modules/scm.py
b/WebKitTools/Scripts/modules/scm.py

> +    @classmethod
> +    def git_commit_from_svn_revision(cls, revision):
> +	   git_log_output = cls.run_command(['git', 'svn', 'log', '-r',
revision, '--oneline', '--show-commit'])
> +	   # Example: r45396 | b4954e7 | 2009-06-30  Antonio Gomes  
<antonio.gomes at openbossa.org>
> +	   matched_commit = re.search("^r(\d+) \| (\w+) \| .*$",
git_log_output, re.MULTILINE)

This is ok, but I always find code more readable when it uses named groups.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:44:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:44:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27403] Add test case for
 bug 27394 : [Attachment 33003] Use onload instead of polling
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718024434.52B723383FE7@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 33003: Use onload instead of polling
https://bugs.webkit.org/attachment.cgi?id=33003&action=review

------- Additional Comments from Mads Ager <ager at chromium.org>
Thanks, onload is better.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:48:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:48:15 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25523] The text displayed by
 push buttons is not exposed to assistive technologies : [Attachment 32946]
 Add new public method text() to RenderButton and use it from
In-Reply-To: <bug-25523-0@https.bugs.webkit.org/>
References: <bug-25523-0@https.bugs.webkit.org/>
Message-ID: <20090718024815.C0EDE33840A8@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Mario Sanchez Prada
<msanchez at igalia.com>'s request for review:
Bug 25523: The text displayed by push buttons is not exposed to assistive
technologies
https://bugs.webkit.org/show_bug.cgi?id=25523

Attachment 32946: Add new public method text() to RenderButton and use it from
AccessibilityRenderObject::stringValue().
https://bugs.webkit.org/attachment.cgi?id=32946&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> -    
> +    const String text() const;
> +

I stand corrected and it should return a String not const String. The reason is
because RenderText::text() doesn't return a const String (RenderMenuList return
a String for RenderMenuList::text() as well, not const String).

r=me with changing it back to just String.

From bugzilla-daemon at webkit.org  Fri Jul 17 19:59:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 19:59:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 32884] Adds
 GraphicsContextWince.cpp
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090718025926.49B843384362@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Adam Treat <treat at kde.org>'s
request for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 32884: Adds GraphicsContextWince.cpp
https://bugs.webkit.org/attachment.cgi?id=32884&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
There are many comments below that apply to many parts of the code. I've marked
these with "(applies elsewhere)" instead of repeating the comments in each
case.

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 3b18cab..a0708ac 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,115 @@
> +2009-07-16  Yong Li	<yong.li at torchmobile.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27349
> +	   Add GraphicsContext implementation for the WinCE port.
> +
> +	   Written by Yong Li <yong.li at torchmobile.com> and George Staikos
<george.staikos at torchmobile.com>
> +	   with trivial style fixes by Adam Treat <adam.treat at torchmobile.com>
> +
> +	   * platform/graphics/wince/GraphicsContextWince.cpp: Added.
> +	   (WebCore::isZero):
> +	   (WebCore::Round):
> +	   (WebCore::roundRect):
> +	   (WebCore::RotationTransform::RotationTransform):
> +	   (WebCore::RotationTransform::operator-):
> +	   (WebCore::RotationTransform::map):
> +	   (WebCore::mapPoint):
> +	   (WebCore::mapRect):
> +	  
(WebCore::GraphicsContextPlatformPrivateData::GraphicsContextPlatformPrivateDat
a):
> +	  
(WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
> +	  
(WebCore::GraphicsContextPlatformPrivate::~GraphicsContextPlatformPrivate):
> +	   (WebCore::GraphicsContextPlatformPrivate::origin):
> +	   (WebCore::GraphicsContextPlatformPrivate::translate):
> +	   (WebCore::GraphicsContextPlatformPrivate::scale):
> +	   (WebCore::GraphicsContextPlatformPrivate::rotate):
> +	   (WebCore::GraphicsContextPlatformPrivate::concatCTM):
> +	   (WebCore::GraphicsContextPlatformPrivate::mapRect):
> +	   (WebCore::GraphicsContextPlatformPrivate::mapPoint):
> +	   (WebCore::GraphicsContextPlatformPrivate::mapSize):
> +	   (WebCore::GraphicsContextPlatformPrivate::save):
> +	   (WebCore::GraphicsContextPlatformPrivate::restore):
> +	  
(WebCore::GraphicsContextPlatformPrivate::getTransparentLayerBitmap):
> +	  
(WebCore::GraphicsContextPlatformPrivate::paintBackTransparentLayerBitmap):
> +	   (WebCore::createPen):
> +	   (WebCore::createBrush):
> +	   (WebCore::rotateBitmap):
> +	   (WebCore::TransparentLayerDC::TransparentLayerDC):
> +	   (WebCore::TransparentLayerDC::~TransparentLayerDC):
> +	   (WebCore::TransparentLayerDC::hdc):
> +	   (WebCore::TransparentLayerDC::rect):
> +	   (WebCore::TransparentLayerDC::toShift):
> +	   (WebCore::ScopeDCProvider::ScopeDCProvider):
> +	   (WebCore::ScopeDCProvider::~ScopeDCProvider):
> +	   (WebCore::GraphicsContext::GraphicsContext):
> +	   (WebCore::GraphicsContext::~GraphicsContext):
> +	   (WebCore::GraphicsContext::setBitmap):
> +	   (WebCore::GraphicsContext::getWindowsContext):
> +	   (WebCore::GraphicsContext::releaseWindowsContext):
> +	   (WebCore::GraphicsContext::savePlatformState):
> +	   (WebCore::GraphicsContext::restorePlatformState):
> +	   (WebCore::GraphicsContext::drawRect):
> +	   (WebCore::GraphicsContext::drawLine):
> +	   (WebCore::GraphicsContext::drawEllipse):
> +	   (WebCore::getEllipsePointByAngle):
> +	   (WebCore::getEllipseY):
> +	   (WebCore::getEllipseX):
> +	   (WebCore::GraphicsContext::strokeArc):
> +	   (WebCore::GraphicsContext::drawConvexPolygon):
> +	   (WebCore::fillRectWithAlpha):
> +	   (WebCore::GraphicsContext::fillRect):
> +	   (WebCore::GraphicsContext::clip):
> +	   (WebCore::GraphicsContext::clipOut):
> +	   (WebCore::GraphicsContext::drawFocusRing):
> +	   (WebCore::GraphicsContext::drawLineForText):
> +	   (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
> +	   (WebCore::GraphicsContext::setPlatformFillColor):
> +	   (WebCore::GraphicsContext::setPlatformStrokeColor):
> +	   (WebCore::GraphicsContext::setPlatformStrokeThickness):
> +	   (WebCore::GraphicsContext::setURLForRect):
> +	   (WebCore::GraphicsContext::addInnerRoundedRectClip):
> +	   (WebCore::GraphicsContext::clearRect):
> +	   (WebCore::GraphicsContext::strokeRect):
> +	   (WebCore::GraphicsContext::beginTransparencyLayer):
> +	   (WebCore::GraphicsContext::endTransparencyLayer):
> +	   (WebCore::GraphicsContext::concatCTM):
> +	   (WebCore::GraphicsContext::affineTransform):
> +	   (WebCore::GraphicsContext::resetAffineTransform):
> +	   (WebCore::GraphicsContext::translate):
> +	   (WebCore::GraphicsContext::rotate):
> +	   (WebCore::GraphicsContext::origin):
> +	   (WebCore::GraphicsContext::scale):
> +	   (WebCore::GraphicsContext::mapRect):
> +	   (WebCore::GraphicsContext::mapPoint):
> +	   (WebCore::GraphicsContext::mapSize):
> +	   (WebCore::GraphicsContext::setLineCap):
> +	   (WebCore::GraphicsContext::setLineJoin):
> +	   (WebCore::GraphicsContext::setMiterLimit):
> +	   (WebCore::GraphicsContext::setAlpha):
> +	   (WebCore::GraphicsContext::setCompositeOperation):
> +	   (WebCore::GraphicsContext::beginPath):
> +	   (WebCore::GraphicsContext::addPath):
> +	   (WebCore::GraphicsContext::clipOutEllipseInRect):
> +	   (WebCore::GraphicsContext::fillRoundedRect):
> +	   (WebCore::GraphicsContext::roundToDevicePixels):
> +	   (WebCore::GraphicsContext::fillPath):
> +	   (WebCore::GraphicsContext::strokePath):
> +	   (WebCore::GraphicsContext::getCTM):
> +	   (WebCore::GraphicsContext::clipToImageBuffer):
> +	   (WebCore::GraphicsContext::setPlatformShadow):
> +	   (WebCore::GraphicsContext::clearPlatformShadow):
> +	   (WebCore::GraphicsContext::setImageInterpolationQuality):
> +	   (WebCore::GraphicsContext::drawText):
> +	   (WebCore::GraphicsContext::drawFrameControl):
> +	   (WebCore::GraphicsContext::drawFocusRect):
> +	   (WebCore::GraphicsContext::paintTextField):
> +	   (WebCore::GraphicsContext::drawBitmap):
> +	   (WebCore::GraphicsContext::drawBitmapPattern):
> +	   (WebCore::GraphicsContext::setPlatformShouldAntialias):
> +	   (WebCore::GraphicsContext::setLineDash):
> +	   (WebCore::GraphicsContext::clipPath):

It's probably better to omit the function list if you aren't adding comments
about each function.

> +#include "config.h"
> +#include "GraphicsContext.h"
> +#include "TransformationMatrix.h"
> +#include "NotImplemented.h"
> +#include "wince/MemoryManager.h"
> +#include "OwnPtr.h"
> +#include "SharedBitmap.h"
> +#include "Path.h"
> +#include "PlatformPathWince.h"
> +#include "Gradient.h"
> +#include "GraphicsContextPrivate.h"
> +#include "SimpleFontData.h"
> +#include "GlyphBuffer.h"
> +#include "CharacterNames.h"
> +#include <windows.h>

These should be sorted in ASCII order. You should add a blank line after
#include "GraphicsContext.h". "OwnPtr.h" should be <wtf/OwnPtr.h>.

> +#define PI	     3.14159265358979323846

wtf/MathExtras.h defines piFloat and piDouble. You should probably use those
instead.

> +#define RADIAN(a)	((a) * PI / 180.)
> +#define DEGREE(a)	((a) * 180. / PI)

wtf/MathExtras.h has deg2rad and rad2deg functions you can use instead.

> +static inline int Round(double d)

Function names start with a lowercase letter in WebKit. But you can probably
just use lround from wtf/MathExtras.h instead.

> +{
> +    if (d > 0)
> +	   return int(d + 0.5);

We normally use C++ cast operators instead of function-style casts. So
static_cast would be better here. (applies elsewhere)

> +    else {

We don't write "else" after "return". (applies elsewhere)

> +static inline IntRect roundRect(const FloatRect& r)
> +{
> +    return IntRect(Round(r.x()), Round(r.y()), Round(r.right()) -
Round(r.x()), Round(r.bottom()) - Round(r.y()));
> +}

Are you sure you don't want to use enclosingIntRect instead?

> +struct RotationTransform { // Origin (0, 0)
> +    double m_cosA;
> +    double m_sinA;
> +    int m_preShiftX;
> +    int m_preShiftY;
> +    int m_postShiftX;
> +    int m_postShiftY;

We often omit the "m_" prefix on struct data members. (applies elsewhere)

> +    void map(double x1, double y1, double* x2, double* y2) const
> +    {
> +	   x1 += m_preShiftX;
> +	   y1 += m_preShiftY;
> +	   *x2 = x1 * m_cosA + y1 * m_sinA + m_postShiftX;
> +	   *y2 = y1 * m_cosA - x1 * m_sinA + m_postShiftY;
> +    }

Maybe this would be better as: IntPoint map(const IntPoint&) const

> +    void map(int x1, int y1, int* x2, int* y2) const
> +    {
> +	   x1 += m_preShiftX;
> +	   y1 += m_preShiftY;
> +	   *x2 = Round(x1 * m_cosA + y1 * m_sinA) + m_postShiftX;
> +	   *y2 = Round(y1 * m_cosA - x1 * m_sinA) + m_postShiftY;
> +    }

Maybe this would be better as: FloatPoint map(const FloatPoint&) const

> +template<class T> static inline
> +IntPoint mapPoint(const IntPoint& p, const T& t)

I think we normally put the entire function declaration on a single line.
(applies elsewhere)

> +template<class Transform, class Rect, class Value> static inline
> +Rect mapRect(const Rect& rect, const Transform& transform)

If you switched the template parameter order to Value, Transform, Rect, then I
think you could normally call the function like this: mapRect<Value>(...). The
Transform and Rect parameters would be inferred from the parameter types.

> +{
> +    Value x[4], y[4];
> +    Value l, t, r, b;

It might be clearer to give these variables full-word names ("left", "top",
etc.).
We don't normally declare multiple variables on a single line. (applies
elsewhere)

> +    GraphicsContextPlatformPrivateData()
> +	   : m_transform()
> +	   , m_opacity(1.0)
> +    {}

Please put the braces on their own lines, or put the entire constructor on a
single line (including the initializer list).

> +    GraphicsContextPlatformPrivate(HDC dc)
> +	   : m_dc(dc)
> +    {
> +	   HDC hScreenDC = ::GetDC(0);
> +	   int rtn = ::GetDeviceCaps(hScreenDC, RASTERCAPS);
> +	   ::ReleaseDC(0, hScreenDC);
> +    }

What's the point of the three lines in the body of the constructor? They don't
seem to do anything. Does calling GetDeviceCaps have some side-effect?

> +    IntPoint origin()
> +    {
> +	   return IntPoint(Round(-m_transform.e()),
> +		   Round(-m_transform.f()));
> +    }

This could be a const member function.

> +    FloatSize mapSize(const FloatSize& size)
> +    {
> +	   double w, h;
> +	   m_transform.map(size.width(), size.height(), w, h);
> +	   return FloatSize(w, h);
> +    }

Earlier you used static_cast when passing doubles to the FloatSize constructor.
It would be good to be consistent one way or the other.

> +    void restore()
> +    {
> +	   if (m_backupData.isEmpty())
> +	       return;
> +
> +	   if (m_dc)
> +	       RestoreDC(m_dc, -1);
> +
> +	   GraphicsContextPlatformPrivateData::operator=(m_backupData.last());

Does *this = m_backupData.last() not work?

> +    PassRefPtr<SharedBitmap> getTransparentLayerBitmap(IntRect& origRect,
bool uses16bit, RECT& bmpRect, bool checkClipBox, bool force)

It seems strange to use a mix of IntRect and RECT in this declaration. (applies
elsewhere)

> +    {
> +	   if (m_opacity <= 0)
> +	       return 0;
> +	   else if (force || m_opacity < 1.)  {

You could negate this condition and use an early return.

> +#if !defined(NO_ALPHABLEND)
> +	   if (m_opacity < 1. || !use16bit) {
> +	       const BLENDFUNCTION blend = { AC_SRC_OVER, 0
> +		   , m_opacity >= 1. ? 255 : (BYTE)(m_opacity * 255)
> +		   , use16bit ? 0 : AC_SRC_ALPHA };
> +	       AlphaBlend
> +		   (m_dc
> +		   , origRect.x()
> +		   , origRect.y()
> +		   , origRect.width()
> +		   , origRect.height()
> +		   , hdc
> +		   , 0
> +		   , 0
> +		   , bmpRect.right
> +		   , bmpRect.bottom
> +		   , blend
> +		   );

I've never seen this one-parameter-per-line style anywhere else in WebKit. I'm
not sure it's a good idea to introduce it here. (applies elsewhere)

> +// Only for 16bit
> +void rotateBitmap(SharedBitmap* destBmp, const SharedBitmap* sourceBmp,
const RotationTransform& transform)

This should be marked "static" so it gets internal linkage. (applies elsewhere)


> +{
> +    ASSERT(destBmp->is16bit() && sourceBmp->is16bit());

It would be better to use ASSERT_ARG. It would be better to separate this into
two assertions.

> +    int destW = destBmp->width();
> +    int destH = destBmp->height();
> +    int sourceW = sourceBmp->width();
> +    int sourceH = sourceBmp->height();
> +    unsigned short* dest = (unsigned short*)destBmp->bytes();
> +    const unsigned short* source = (const unsigned
short*)sourceBmp->bytes();
> +    int padding = destW & 1;
> +    int paddedSourceW = sourceW + (sourceW & 1);
> +    if (isZero(transform.m_sinA)) {
> +	   int cosA = transform.m_cosA > 0 ? 1 : -1;
> +	   for (int y = 0; y < destH; ++y) {
> +	       for (int x = 0; x < destW; ++x) {
> +		   int x1 = x + transform.m_preShiftX;
> +		   int y1 = y + transform.m_preShiftY;
> +		   int srcX = x1 * cosA + transform.m_postShiftX;
> +		   int srcY = y1 * cosA - transform.m_postShiftY;
> +		   if (srcX >= 0 && srcX <= sourceW && srcY >= 0 && srcY <=
sourceH)
> +		       *dest++ = source[srcY * paddedSourceW + srcX] |
0xFF000000;
> +		   else
> +		       *dest++ |= 0xFF;
> +	       }
> +	       dest += padding;
> +	   }
> +    } else if (isZero(transform.m_cosA)) {
> +	   int sinA = transform.m_sinA > 0 ? 1 : -1;
> +	   for (int y = 0; y < destH; ++y) {
> +	       for (int x = 0; x < destW; ++x) {
> +		   int x1 = x + transform.m_preShiftX;
> +		   int y1 = y + transform.m_preShiftY;
> +		   int srcX = y1 * sinA + transform.m_postShiftX;
> +		   int srcY = -x1 * sinA + transform.m_postShiftY;
> +		   if (srcX >= 0 && srcX <= sourceW && srcY >= 0 && srcY <=
sourceH)
> +		       *dest++ = source[srcY * paddedSourceW + srcX] |
0xFF000000;
> +		   else
> +		       *dest++ |= 0xFF;
> +	       }
> +	       dest += padding;
> +	   }
> +    } else {
> +	   for (int y = 0; y < destH; ++y) {
> +	       for (int x = 0; x < destW; ++x) {
> +		   // FIXME: for best quality, we should get weighted sum of
four neighbours,
> +		   // but that will be too expensive
> +		   int srcX, srcY;
> +		   transform.map(x, y, &srcX, &srcY);
> +		   if (srcX >= 0 && srcX <= sourceW && srcY >= 0 && srcY <=
sourceH)
> +		       *dest++ = source[srcY * paddedSourceW + srcX] |
0xFF000000;
> +		   else
> +		       *dest++ |= 0xFF;
> +	       }
> +	       dest += padding;
> +	   }
> +    }
> +}

It would be nice to have a little less duplication in this function.

> +    explicit TransparentLayerDC(GraphicsContextPlatformPrivate* data,
> +				   IntRect& origRect,
> +				   const IntRect* rectBeforeTransform = 0,
> +				   int alpha = 255)

"explicit" doesn't really add anything here, since this constructor requires
more than one parameter.

> +	   : m_data(data)
> +	   , m_origRect(origRect)
> +	   , m_oldOpacity(data->m_opacity)

It seems error-prone to leave m_key1 and m_key2 uninitialized here.

> +#if 1
> +		   FloatPoint topLeft =
m_data->m_transform.mapPoint(FloatPoint(rectBeforeTransform->topLeft()));
> +		   FloatPoint topRight(rectBeforeTransform->right() - 1,
rectBeforeTransform->y());
> +		   topRight = m_data->m_transform.mapPoint(topRight);
> +		   FloatPoint bottomLeft(rectBeforeTransform->x(),
rectBeforeTransform->bottom() - 1);
> +		   bottomLeft = m_data->m_transform.mapPoint(bottomLeft);
> +		   FloatSize sideTop = topRight - topLeft;
> +		   FloatSize sideLeft = bottomLeft - topLeft;
> +		   float width = _hypot(sideTop.width() + 1, sideTop.height() +
1);
> +		   float height = _hypot(sideLeft.width() + 1,
sideLeft.height() + 1);
> +
> +		   origRect.inflateX(Round((width - origRect.width()) * 0.5));
> +		   origRect.inflateY(Round((height - origRect.height()) *
0.5));
> +#else
> +		   FloatRect rotatedBeforeTransform =
mapRect(FloatRect(*rectBeforeTransform), -m_rotation);
> +		   double shrinkRateX = (1. - rectBeforeTransform->width() /
(double)rotatedBeforeTransform.width()) * 0.5;
> +		   double shrinkRateY = (1. - rectBeforeTransform->height() /
(double)rotatedBeforeTransform.height()) * 0.5;
> +		   origRect.inflateX(-Round(shrinkRateX * origRect.width()));
> +		   origRect.inflateY(-Round(shrinkRateY * origRect.height()));
> +#endif

We don't like to check in commented-out code. (applies elsewhere)

> +	   if (m_bitmap)
> +	       m_memDc = m_bitmap->getDC(&m_key1, &m_key2);

m_memDC would match our variable naming conventions better.

> +HDC GraphicsContext::getWindowsContext(const IntRect& dstRect, bool
supportAlphaBlend, bool mayCreateBitmap)
> +{
> +    // FIXME: the implementation is buggy. Currently the function seems not
being used. Just make an assertion
> +    ASSERT(0);
> +    return 0;

ASSERT_NOT_REACHED() would be better here.

> +void GraphicsContext::drawRect(const IntRect& rect)
> +{
> +    if (!m_data->m_opacity || paintingDisabled() || rect.width() <= 0 ||
rect.height() <= 0)
> +	   return;

You can use rect.isEmpty() instead of the width() and height() checks.

> +    TransparentLayerDC transparentDc(m_data, trRect, &rect);

transparentDC would match our variable naming conventions better. (applies
elsewhere)

> +    if (fillColor().alpha()) {
> +	   brush = createBrush(fillColor());
> +	   oldBrush = SelectObject(dc, brush);
> +    } else {
> +	   SelectObject(dc, GetStockObject(NULL_BRUSH));
> +    }

We don't put braces around the bodies of single-line branches.

> +void GraphicsContext::drawEllipse(const IntRect& rect)
> +{
> +    if (!m_data->m_opacity || paintingDisabled() || (!fillColor().alpha() &&
strokeStyle() == NoStroke))
> +	   return;

Should you check that strokeColor().alpha() is non-zero, too?

> +    HGDIOBJ oldBrush = SelectObject(dc, GetStockObject(NULL_BRUSH));
> +    Ellipse(dc, trRect.x(), trRect.y(), trRect.right(), trRect.bottom());
> +    SelectObject(dc, oldBrush);
> +
> +    if (newClip)
> +	   SelectClipRgn(dc, 0);

Why don't we need to select the old clip region back in in this case?

> +void GraphicsContext::drawConvexPolygon(size_t npoints, const FloatPoint*
points, bool shouldAntialias)
> +{
> +    if (!m_data->m_opacity || paintingDisabled() || npoints <= 1 || !points)

> +	   return;
> +
> +    ScopeDCProvider dcProvider(m_data);
> +    if (!m_data->m_dc)
> +	   return;
> +
> +    Vector<POINT, 20> winPoints;
> +    winPoints.resize(npoints);

You can just pass npoints to the Vector constructor instead of calling resize.
(applies elsewhere)

> +void GraphicsContext::fillRect(const FloatRect& rect, const Color& color)
> +{
> +    if (paintingDisabled() || !m_data->m_opacity)
> +	   return;
> +
> +    if (int alpha = color.alpha()) {
> +	   OwnPtr<HBRUSH> hbrush(CreateSolidBrush(RGB(color.red(),
color.green(), color.blue())));
> +	   if (hbrush) {
> +	       ScopeDCProvider dcProvider(m_data);
> +	       if (m_data->m_dc) {
> +		   IntRect intRect = enclosingIntRect(rect);
> +		   TransparentLayerDC transparentDc(m_data,
m_data->mapRect(intRect), &intRect);
> +		   if (transparentDc.hdc())
> +		       if (alpha == 0xFF)
> +			   FillRect(transparentDc.hdc(), &transparentDc.rect(),
hbrush.get());
> +		       else
> +			   fillRectWithAlpha(transparentDc.hdc(),
&transparentDc.rect(), hbrush.get(), alpha);
> +	       }
> +	   }
> +    }
> +}

This function would benefit from reducing nesting by using early returns.

> +void GraphicsContext::drawFocusRing(const Color& color)
> +{
> +    if (!m_data->m_opacity || paintingDisabled())
> +	   return;
> +
> +    ScopeDCProvider dcProvider(m_data);
> +    if (!m_data->m_dc)
> +	   return;
> +
> +    int radius = (focusRingWidth() - 1) / 2;
> +    int offset = radius + focusRingOffset();
> +
> +    const Vector<IntRect>& rects = focusRingRects();
> +    unsigned rectCount = rects.size();
> +    IntRect finalFocusRect;
> +    for (unsigned i = 0; i < rectCount; i++) {
> +	   IntRect focusRect = rects[i];
> +	   focusRect.inflate(offset);
> +	   finalFocusRect.unite(focusRect);
> +    }
> +
> +    RECT rect = { finalFocusRect.x(), finalFocusRect.y(),
finalFocusRect.right(), finalFocusRect.bottom() };

There's an operator RECT() member of IntRect, so you shouldn't have to do this
explicitly.

> +void GraphicsContext::addInnerRoundedRectClip(const IntRect& rect, int
thickness)
> +{
> +    notImplemented();
> +    // FIX ME:
> +    clip(rect);

Our style is "FIXME:". It would be good to add a slightly more descriptive
comment.

> +void GraphicsContext::fillPath()
> +{
> +    if (!fillColor().alpha() || !m_data->m_opacity)
> +	   return;
> +    ScopeDCProvider dcProvider(m_data);
> +    if (!m_data->m_dc)
> +	   return;
> +
> +    if (m_data->m_opacity < 1.0f) {
> +	   HGDIOBJ brush = createBrush(fillColor());
> +	   for (Vector<Path>::const_iterator i = m_data->m_paths.begin(); i !=
m_data->m_paths.end(); ++i) {
> +	       IntRect trRect = roundRect(m_data->mapRect(i->boundingRect()));
> +	       TransparentLayerDC transparentDc(m_data, trRect);
> +	       HDC dc = transparentDc.hdc();
> +	       if (!dc)
> +		   continue;
> +
> +	       TransformationMatrix tr = m_data->m_transform;
> +	       tr.translate(transparentDc.toShift().width(),
transparentDc.toShift().height());
> +
> +	       SelectObject(dc, GetStockObject(NULL_PEN));
> +	       HGDIOBJ oldBrush = SelectObject(dc, brush);
> +	       i->platformPath()->fillPath(dc, &tr);
> +	       SelectObject(dc, oldBrush);

Don't you need to restore the old pen, too? (Ditto for the other branch in this
function.)

> +void GraphicsContext::strokePath()
> +{
> +    if (!m_data->m_opacity)
> +	   return;
> +
> +    ScopeDCProvider dcProvider(m_data);
> +    if (!m_data->m_dc)
> +	   return;
> +
> +    if (m_data->m_opacity < 1.0f) {
> +	   HGDIOBJ pen = createPen(strokeColor(), strokeThickness(),
strokeStyle());
> +	   for (Vector<Path>::const_iterator i = m_data->m_paths.begin(); i !=
m_data->m_paths.end(); ++i) {
> +	       IntRect trRect = roundRect(m_data->mapRect(i->boundingRect()));
> +	       TransparentLayerDC transparentDc(m_data, trRect);
> +	       HDC dc = transparentDc.hdc();
> +	       if (!dc)
> +		   continue;
> +
> +	       TransformationMatrix tr = m_data->m_transform;
> +	       tr.translate(transparentDc.toShift().width(),
transparentDc.toShift().height());
> +
> +	       SelectObject(dc, GetStockObject(NULL_BRUSH));
> +	       HGDIOBJ oldPen = SelectObject(dc, pen);
> +	       i->platformPath()->strokePath(dc, &m_data->m_transform);
> +	       SelectObject(dc, oldPen);

Don't you need to restore the old brush? (Ditto for the other branch of this
function.)

> +void GraphicsContext::fillRect(const FloatRect& r, const Gradient* gradient)

> +{
> +    if (!m_data->m_opacity)
> +	   return;
> +
> +    const Vector<Gradient::ColorStop>& stops = gradient->getStops();
> +    int numStops = stops.size();
> +    if (numStops == 0) {
> +    } else if (numStops == 1) {

I think this would be clearer as:

if (stops.isEmpty())
    return;
size_t numStops = stops.size();

> +#define isCharVisible(c) ((c) && (c) != zeroWidthSpace)

This would be better as an inline helper function.

> +void GraphicsContext::drawText(const Font& font, const TextRun& run, const
IntPoint& point, int from, int to)
> +{
> +    if (paintingDisabled() || fillColor().alpha() == 0 ||
!m_data->m_opacity)
> +	   return;

Please use !fillColor().alpha() instead of comparing to 0. (applies elsewhere)

> +    if (fillColor().alpha() == 0xFF && m_data->m_opacity >= 1.0)
> +	   font.drawText(this, run, point, from, to);
> +    else {

You should add an early return in the if case to reduce nesting.

> +	   float oldOpacity = m_data->m_opacity;
> +	   m_data->m_opacity *= fillColor().alpha() / 255.0;
> +
> +	   FloatRect textRect = font.selectionRectForText(run, point,
font.height(), from, to);
> +	   textRect.setY(textRect.y() - font.ascent());
> +	   IntRect trRect = enclosingIntRect(m_data->mapRect(textRect));
> +	   RECT bmpRect;
> +	   RefPtr<SharedBitmap> bmp = m_data->getTransparentLayerBitmap(trRect,
true, bmpRect, true, false);
> +	   if (bmp) {

You can declare the bmp variable inside the if condition:

if (RefPtr<SharedBitmap> bmp = ...) {

> +    // TransparentLayerDC ...

What does this comment mean?

> +    HFONT hFont = height > 1
> +	   ? fontData->platformData().getScaledFontHandle(height, scaleX ==
scaleY ? 0 : width)
> +	   : 0;
> +
> +    FloatPoint startPoint(point.x(), point.y() - fontData->ascent());
> +    FloatPoint trPoint = m_data->mapPoint(startPoint);
> +    int y = Round(trPoint.y());
> +
> +    Color color = fillColor();
> +    if (color.alpha() == 0) // hack
> +	   return;
> +
> +    COLORREF fontColor = RGB(color.red(), color.green(), color.blue());
> +
> +    if (hFont) {

If you put the !hFont case first, you can add an early return at the end of it,
and add early returns throughout the rest of the function to reduce nesting.
i.e.,:

if (!hFont) {
    ....the current else case goes here....
    return;
}

....the rest of the code goes here, hopefully with more early returns....

> +	   COLORREF shadowRgbColor;

shadowRGBColor would match our variable naming conventions better.

> +	   HGDIOBJ hOldFont = SelectObject(m_data->m_dc, hFont);
> +	   // transparent always...
> +	   int oldBkMode = GetBkMode(m_data->m_dc);

What does this comment mean?

> +    if ((rectWin.right - rectWin.left) < boxWidthBest) {
> +	   RefPtr<SharedBitmap> bmp1 = SharedBitmap::createInstance(true,
boxWidthBest, boxHeightBest, true);
> +	   SharedBitmap::DCHolder dc1(bmp1.get());

Is there a better way to name these variables than with a "1" suffix?

> +void GraphicsContext::setPlatformShouldAntialias(bool should)
> +{
> +    (void)should;
> +    notImplemented();
> +}

You can use the UNUSED_PARAM macro from wtf/UnusedParam.h here, or just omit
the parameter name entirely. (applies elsewhere)

I think there's enough style clean-up here that we should do another pass at
this. Hopefully we can make cpplint.py catch more of these style issues!

From bugzilla-daemon at webkit.org  Fri Jul 17 20:14:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 20:14:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27404] bugzilla-tool does
 not understand nested SVN repos : [Attachment 33004] patch
In-Reply-To: <bug-27404-0@https.bugs.webkit.org/>
References: <bug-27404-0@https.bugs.webkit.org/>
Message-ID: <20090718031457.DBFCD3384751@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27404: bugzilla-tool does not understand nested SVN repos
https://bugs.webkit.org/show_bug.cgi?id=27404

Attachment 33004: patch
https://bugs.webkit.org/attachment.cgi?id=33004&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 20:19:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 20:19:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27403] Add test case for bug
 27394 : [Attachment 33003] Use onload instead of polling
In-Reply-To: <bug-27403-0@https.bugs.webkit.org/>
References: <bug-27403-0@https.bugs.webkit.org/>
Message-ID: <20090718031942.10D723384895@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Mads Ager <ager at chromium.org>'s
request for review:
Bug 27403: Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403

Attachment 33003: Use onload instead of polling
https://bugs.webkit.org/attachment.cgi?id=33003&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks great!  Thanks for the patch.

From bugzilla-daemon at webkit.org  Fri Jul 17 20:22:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 20:22:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27404] bugzilla-tool does not
 understand nested SVN repos : [Attachment 33004] patch
In-Reply-To: <bug-27404-0@https.bugs.webkit.org/>
References: <bug-27404-0@https.bugs.webkit.org/>
Message-ID: <20090718032214.4BF773384960@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27404: bugzilla-tool does not understand nested SVN repos
https://bugs.webkit.org/show_bug.cgi?id=27404

Attachment 33004: patch
https://bugs.webkit.org/attachment.cgi?id=33004&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> +	   # Seach up the directory hierarchy until we find a different UUID.
typo:Seach

From bugzilla-daemon at webkit.org  Fri Jul 17 20:50:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 20:50:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27380] Media Controls: We
 are specifying the text height,
 where it is unneeded and the slider is 2px off. : [Attachment 33005] Adjust
 the margin of the slider and remove useless height specification to fix
 alignement of the media controls.
In-Reply-To: <bug-27380-0@https.bugs.webkit.org/>
References: <bug-27380-0@https.bugs.webkit.org/>
Message-ID: <20090718035012.235533384FFB@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27380: Media Controls: We are specifying the text height, where it is
unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Attachment 33005: Adjust the margin of the slider and remove useless height
specification to fix alignement of the media controls.
https://bugs.webkit.org/attachment.cgi?id=33005&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>

---
 8 files changed, 55 insertions(+), 32 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 17 22:02:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 22:02:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14409] Double click on a
 resource in the sidebar should open that resource in Safari : [Attachment
 33006] Double Click opens the Resource in a New Window
In-Reply-To: <bug-14409-0@https.bugs.webkit.org/>
References: <bug-14409-0@https.bugs.webkit.org/>
Message-ID: <20090718050227.AAA2B338600E@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 14409: Double click on a resource in the sidebar should open that resource
in Safari
https://bugs.webkit.org/show_bug.cgi?id=14409

Attachment 33006: Double Click opens the Resource in a New Window
https://bugs.webkit.org/attachment.cgi?id=33006&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Side effect of a really good design is that a feature like this requires a
couple lines of code.  This opens up a new window with the url of the resource.


NOTES:
- Should we white-list file extensions or mime-types?
- Is this behavior still desired? (I think its fine).

From bugzilla-daemon at webkit.org  Fri Jul 17 22:56:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 22:56:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27405] [XSSAuditor] URL
 encoded ampersand can be used to bypass XSSAuditor : [Attachment 33007]
 Patch with tests
In-Reply-To: <bug-27405-0@https.bugs.webkit.org/>
References: <bug-27405-0@https.bugs.webkit.org/>
Message-ID: <20090718055628.8A1A43386DF3@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27405: [XSSAuditor] URL encoded ampersand can be used to bypass XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27405

Attachment 33007: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=33007&action=review

From bugzilla-daemon at webkit.org  Fri Jul 17 23:10:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 23:10:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14410] Dragging a resource
 in the sidebar should drag it's URL : [Attachment 33008] Make Resource Have
 a Draggable URL
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090718061013.7E8FF33871F6@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33008: Make Resource Have a Draggable URL
https://bugs.webkit.org/attachment.cgi?id=33008&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This wraps the TreeElement's contents in a <a href="resource url"> so that you
can drag around the link as though it were a normal <a> tag.  Dragging the url
into a non-inspector window works fine.

NOTE:
- This changes the Right-Click menu for the Sidebar Elements (I will attach a
screenshot of the before/after behavior)
- This works fine with the double click to open patch (see patch on
https://bugs.webkit.org/show_bug.cgi?id=14409)

From bugzilla-daemon at webkit.org  Fri Jul 17 23:12:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 17 Jul 2009 23:12:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27405] [XSSAuditor] URL
 encoded ampersand can be used to bypass XSSAuditor : [Attachment 33007]
 Patch with tests
In-Reply-To: <bug-27405-0@https.bugs.webkit.org/>
References: <bug-27405-0@https.bugs.webkit.org/>
Message-ID: <20090718061218.3D84F3387278@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27405: [XSSAuditor] URL encoded ampersand can be used to bypass XSSAuditor
https://bugs.webkit.org/show_bug.cgi?id=27405

Attachment 33007: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=33007&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yes.

From bugzilla-daemon at webkit.org  Sat Jul 18 00:05:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 00:05:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27406] Minor
 FrameLoader.cpp cleanup : [Attachment 33011] patch
In-Reply-To: <bug-27406-0@https.bugs.webkit.org/>
References: <bug-27406-0@https.bugs.webkit.org/>
Message-ID: <20090718070543.0D9433388077@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27406: Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

Attachment 33011: patch
https://bugs.webkit.org/attachment.cgi?id=33011&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 00:31:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 00:31:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27407] [V8] Revert
 incomplete patch : [Attachment 33012] v1
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090718073120.2CB263388714@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33012: v1
https://bugs.webkit.org/attachment.cgi?id=33012&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Revert Jens' patch.

From bugzilla-daemon at webkit.org  Sat Jul 18 00:36:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 00:36:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27407] [V8] Revert
 incomplete patch : [Attachment 33012] v1
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090718073608.D992C3388860@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has canceled Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33012: v1
https://bugs.webkit.org/attachment.cgi?id=33012&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
add a change log

From bugzilla-daemon at webkit.org  Sat Jul 18 00:36:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 00:36:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27407] [V8] Revert
 incomplete patch : [Attachment 33013] now with changelog!
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090718073608.EC9F43388862@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33013: now with changelog!
https://bugs.webkit.org/attachment.cgi?id=33013&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
add a change log

From bugzilla-daemon at webkit.org  Sat Jul 18 00:38:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 00:38:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27407] [V8] Revert incomplete
 patch : [Attachment 33013] now with changelog!
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090718073826.1F2FE338890A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33013: now with changelog!
https://bugs.webkit.org/attachment.cgi?id=33013&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
jorlow certifies that this is a revert of a previous patch.  I apply the rubber
stamp.

From bugzilla-daemon at webkit.org  Sat Jul 18 01:02:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:02:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24758] [Gtk] Implement a
 WebDataSource for the gtk port : [Attachment 33014] updated patch
In-Reply-To: <bug-24758-0@https.bugs.webkit.org/>
References: <bug-24758-0@https.bugs.webkit.org/>
Message-ID: <20090718080226.211B73388EBB@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 33014: updated patch
https://bugs.webkit.org/attachment.cgi?id=33014&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 01:03:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:03:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24758] [Gtk] Implement a
 WebDataSource for the gtk port : [Attachment 33015] updated datasource
 patch
In-Reply-To: <bug-24758-0@https.bugs.webkit.org/>
References: <bug-24758-0@https.bugs.webkit.org/>
Message-ID: <20090718080334.B599A3388F22@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 33015: updated datasource patch
https://bugs.webkit.org/attachment.cgi?id=33015&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 01:04:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:04:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24758] [Gtk] Implement a
 WebDataSource for the gtk port : [Attachment 33016] Updated frame data
 source API patch
In-Reply-To: <bug-24758-0@https.bugs.webkit.org/>
References: <bug-24758-0@https.bugs.webkit.org/>
Message-ID: <20090718080435.AAEAF3388F79@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 33016: Updated frame data source API patch
https://bugs.webkit.org/attachment.cgi?id=33016&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 01:09:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:09:08 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 16401] [GTK] GObject/C DOM
 binding : [Attachment 32633] brings glib/gobject bindings up to svn r44473.
In-Reply-To: <bug-16401-0@https.bugs.webkit.org/>
References: <bug-16401-0@https.bugs.webkit.org/>
Message-ID: <20090718080908.82CC333890C5@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 16401: [GTK] GObject/C DOM binding
https://bugs.webkit.org/show_bug.cgi?id=16401

Attachment 32633: brings glib/gobject bindings up to svn r44473.
https://bugs.webkit.org/attachment.cgi?id=32633&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
This patch did not address the feedback made by other reviewers. Please make it
short and sweet so it can be reviewed thoroughly.

From bugzilla-daemon at webkit.org  Sat Jul 18 01:15:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:15:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 16401] [GTK] GObject/C DOM
 binding : [Attachment 32807] answering comments in #194 by sam
In-Reply-To: <bug-16401-0@https.bugs.webkit.org/>
References: <bug-16401-0@https.bugs.webkit.org/>
Message-ID: <20090718081504.2F3603389271@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 16401: [GTK] GObject/C DOM binding
https://bugs.webkit.org/show_bug.cgi?id=16401

Attachment 32807: answering comments in #194 by sam
https://bugs.webkit.org/attachment.cgi?id=32807&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
This patch is missing a ChangeLog and can't be r+d as it is, so r-. Please
submit a patch that actually builds and addresses the issues raised by other
reviewers. 

Thanks.

From bugzilla-daemon at webkit.org  Sat Jul 18 01:24:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:24:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27406] Minor FrameLoader.cpp
 cleanup : [Attachment 33011] patch
In-Reply-To: <bug-27406-0@https.bugs.webkit.org/>
References: <bug-27406-0@https.bugs.webkit.org/>
Message-ID: <20090718082404.36F3F33894E1@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27406: Minor FrameLoader.cpp cleanup
https://bugs.webkit.org/show_bug.cgi?id=27406

Attachment 33011: patch
https://bugs.webkit.org/attachment.cgi?id=33011&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me.

From bugzilla-daemon at webkit.org  Sat Jul 18 01:39:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:39:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27408] [V8] Move event
 listener methods from V8Proxy to V8EventListenerList : [Attachment 33017]
 patch
In-Reply-To: <bug-27408-0@https.bugs.webkit.org/>
References: <bug-27408-0@https.bugs.webkit.org/>
Message-ID: <20090718083954.3A17B33898ED@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27408: [V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Attachment 33017: patch
https://bugs.webkit.org/attachment.cgi?id=33017&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 01:45:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:45:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27408] [V8] Move event
 listener methods from V8Proxy to V8EventListenerList : [Attachment 33017]
 patch
In-Reply-To: <bug-27408-0@https.bugs.webkit.org/>
References: <bug-27408-0@https.bugs.webkit.org/>
Message-ID: <20090718084532.8C8083389A7D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27408: [V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Attachment 33017: patch
https://bugs.webkit.org/attachment.cgi?id=33017&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 01:45:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:45:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27408] [V8] Move event
 listener methods from V8Proxy to V8EventListenerList : [Attachment 33018]
 patch
In-Reply-To: <bug-27408-0@https.bugs.webkit.org/>
References: <bug-27408-0@https.bugs.webkit.org/>
Message-ID: <20090718084539.20C5E3389A98@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27408: [V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Attachment 33018: patch
https://bugs.webkit.org/attachment.cgi?id=33018&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 01:57:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 01:57:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25401] <use> of text not
 displayed unless declared after : [Attachment 33019] More efificent
In-Reply-To: <bug-25401-0@https.bugs.webkit.org/>
References: <bug-25401-0@https.bugs.webkit.org/>
Message-ID: <20090718085710.30BFD338A136@gamma.macosforge.org>

Rob Buis <rwlbuis at gmail.com> has asked	for review:
Bug 25401: <use> of text not displayed unless declared after
https://bugs.webkit.org/show_bug.cgi?id=25401

Attachment 33019: More efificent
https://bugs.webkit.org/attachment.cgi?id=33019&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
This version is slightly more efficient since it skips
SVGStyledElement::invalidateAllInstancesOfElement. I still think the patch is
correct so putting it up for review again.
Cheers,

Rob.

From bugzilla-daemon at webkit.org  Sat Jul 18 02:33:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 02:33:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27410] adding GObject
 Language bindings auto-generator : [Attachment 33020] adds codegenerator
 for gobject language bindings
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090718093300.7E171338B3FC@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27410: adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33020: adds codegenerator for gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33020&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
following david's advice, this patch adds just the gobject code generator. 
follow-up bug reports will make use of it.  the code-generator is the largest
piece of the puzzle: once this is committed, the remaining pieces should be a
breeze.

From bugzilla-daemon at webkit.org  Sat Jul 18 02:56:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 02:56:48 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27410] adding GObject Language
 bindings auto-generator : [Attachment 33020] adds codegenerator for gobject
 language bindings
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090718095648.EA08D338BA79@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27410: adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33020: adds codegenerator for gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33020&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
The patch is still is huge. If possible please trim it down to something that
can build the bindings for Node.idl only. The point here is to review the
generation process (and code) and not to make an outright usable GLib bindings.

From bugzilla-daemon at webkit.org  Sat Jul 18 07:30:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 07:30:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27408] [V8] Move event
 listener methods from V8Proxy to V8EventListenerList : [Attachment 33018]
 patch
In-Reply-To: <bug-27408-0@https.bugs.webkit.org/>
References: <bug-27408-0@https.bugs.webkit.org/>
Message-ID: <20090718143001.CBA2D3390330@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27408: [V8] Move event listener methods from V8Proxy to V8EventListenerList
https://bugs.webkit.org/show_bug.cgi?id=27408

Attachment 33018: patch
https://bugs.webkit.org/attachment.cgi?id=33018&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 08:20:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 08:20:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27414] Cairo-based Windows
 port does not handle cookies properly : [Attachment 33026] Replace
 CookieJarWin.cpp with CookieJarCurl.cpp
In-Reply-To: <bug-27414-0@https.bugs.webkit.org/>
References: <bug-27414-0@https.bugs.webkit.org/>
Message-ID: <20090718152053.3E3DB33911C4@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 27414: Cairo-based Windows port does not handle cookies properly
https://bugs.webkit.org/show_bug.cgi?id=27414

Attachment 33026: Replace CookieJarWin.cpp with CookieJarCurl.cpp
https://bugs.webkit.org/attachment.cgi?id=33026&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 08:46:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 08:46:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33020] adds codegenerator
 for gobject language bindings
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090718154628.3572D3391871@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33020: adds codegenerator for gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33020&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
re-enabling review.  awaiting decision.  a compromise _has_ to be reached,
here, so that its acceptance does not interfere with its maintenance.

From bugzilla-daemon at webkit.org  Sat Jul 18 10:25:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 10:25:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27415] [V8] Phase 2: Remove
 event listener methods from V8Proxy : [Attachment 33027] patch
In-Reply-To: <bug-27415-0@https.bugs.webkit.org/>
References: <bug-27415-0@https.bugs.webkit.org/>
Message-ID: <20090718172550.D545F3393246@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27415: [V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415

Attachment 33027: patch
https://bugs.webkit.org/attachment.cgi?id=33027&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 10:31:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 10:31:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27415] [V8] Phase 2: Remove
 event listener methods from V8Proxy : [Attachment 33027] patch
In-Reply-To: <bug-27415-0@https.bugs.webkit.org/>
References: <bug-27415-0@https.bugs.webkit.org/>
Message-ID: <20090718173115.C7C74339338A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27415: [V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415

Attachment 33027: patch
https://bugs.webkit.org/attachment.cgi?id=33027&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 10:31:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 10:31:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27415] [V8] Phase 2: Remove
 event listener methods from V8Proxy : [Attachment 33028] patch
In-Reply-To: <bug-27415-0@https.bugs.webkit.org/>
References: <bug-27415-0@https.bugs.webkit.org/>
Message-ID: <20090718173129.0D60633933AF@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27415: [V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415

Attachment 33028: patch
https://bugs.webkit.org/attachment.cgi?id=33028&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 11:13:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 11:13:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27416] Windows build break
 due to warning C4819 : [Attachment 33029] Disable C4819 to fix build for
 non-English Windows
In-Reply-To: <bug-27416-0@https.bugs.webkit.org/>
References: <bug-27416-0@https.bugs.webkit.org/>
Message-ID: <20090718181357.79131339406D@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 27416: Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Attachment 33029: Disable C4819 to fix build for non-English Windows
https://bugs.webkit.org/attachment.cgi?id=33029&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 11:50:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 11:50:38 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 32992] Fixes, part 6
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090718185038.81A433394A3D@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 32992: Fixes, part 6
https://bugs.webkit.org/attachment.cgi?id=32992&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46095, clearing flags.

From bugzilla-daemon at webkit.org  Sat Jul 18 11:56:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 11:56:48 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33020] adds codegenerator
 for gobject language bindings
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090718185648.657243394C8E@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33020: adds codegenerator for gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33020&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
This still needs to be broken up.

From bugzilla-daemon at webkit.org  Sat Jul 18 13:35:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 13:35:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33020] adds codegenerator
 for gobject language bindings
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090718203558.0C66633968F2@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33020: adds codegenerator for gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33020&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
sorry, sam - breaking it up isn't an option.
re-enabling review, to give people an opportunity
to come up with another idea.
options discussed and rejected so far:
 * doing Node.idl only [rejected several times]
 * breaking file up [method not described]
options suggested (only half-joking):
 * split into 10of 150-line patches

From bugzilla-daemon at webkit.org  Sat Jul 18 13:51:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 13:51:15 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33020] adds codegenerator
 for gobject language bindings
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090718205115.173483396D94@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33020: adds codegenerator for gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33020&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 15:28:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 15:28:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27417] Add spread radius
 support to -webkit-box-shadow : [Attachment 33030] Path
In-Reply-To: <bug-27417-0@https.bugs.webkit.org/>
References: <bug-27417-0@https.bugs.webkit.org/>
Message-ID: <20090718222842.96F8333987D2@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27417: Add spread radius support to -webkit-box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27417

Attachment 33030: Path
https://bugs.webkit.org/attachment.cgi?id=33030&action=review

------- Additional Comments from mitz at webkit.org
Treatment of corner radii is deliberately different from Firefox?s.
<http://www.w3.org/TR/2008/WD-css3-background-20080910/#the-box-shadow> says ?
The shadow should not change shape when a spread radius is applied: sharp
corners should remain sharp?, and this patch extrapolates this to not
increasing the radius. Firefox makes a special case for the 0 radius by
preserving it, while growing any positive radius by the spread radius, which
does not make sense to me.

From bugzilla-daemon at webkit.org  Sat Jul 18 15:36:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 15:36:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26319] es translation :
 [Attachment 31161] Spanish translation
In-Reply-To: <bug-26319-0@https.bugs.webkit.org/>
References: <bug-26319-0@https.bugs.webkit.org/>
Message-ID: <20090718223627.82FBA33989D6@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted  review:
Bug 26319: es translation
https://bugs.webkit.org/show_bug.cgi?id=26319

Attachment 31161: Spanish translation
https://bugs.webkit.org/attachment.cgi?id=31161&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
(In reply to comment #2)
> Any progress in this? It's long ago since I uploaded the translation.

Hi Jorge. This one slipped through - apologies. Next time please set the review
flag to "?" so can see the patch. Thanks.

rs=me.

From bugzilla-daemon at webkit.org  Sat Jul 18 15:40:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 15:40:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27145] [Gtk][REGRESSION]
 subframe-navigate-during-main-frame-load.html fails after r45615 :
 [Attachment 32995] Updated to use result->str instead of a temp var
In-Reply-To: <bug-27145-0@https.bugs.webkit.org/>
References: <bug-27145-0@https.bugs.webkit.org/>
Message-ID: <20090718224042.D1F213398AD7@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27145: [Gtk][REGRESSION] subframe-navigate-during-main-frame-load.html
fails after r45615
https://bugs.webkit.org/show_bug.cgi?id=27145

Attachment 32995: Updated to use result->str instead of a temp var
https://bugs.webkit.org/attachment.cgi?id=32995&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
r=me

From bugzilla-daemon at webkit.org  Sat Jul 18 15:53:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 15:53:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27417] Add spread radius
 support to -webkit-box-shadow : [Attachment 33030] Patch
In-Reply-To: <bug-27417-0@https.bugs.webkit.org/>
References: <bug-27417-0@https.bugs.webkit.org/>
Message-ID: <20090718225323.B6D3A3398DF5@gamma.macosforge.org>

Anders Carlsson <andersca at apple.com> has granted mitz at webkit.org's request for
review:
Bug 27417: Add spread radius support to -webkit-box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27417

Attachment 33030: Patch
https://bugs.webkit.org/attachment.cgi?id=33030&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
r=me!

From bugzilla-daemon at webkit.org  Sat Jul 18 16:12:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 16:12:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27230] [Gtk]
 soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free' was not
 declared in this scope : [Attachment 33002] Use g_mapped_file_unref for
 GLIB version 2.22 onwards.
In-Reply-To: <bug-27230-0@https.bugs.webkit.org/>
References: <bug-27230-0@https.bugs.webkit.org/>
Message-ID: <20090718231246.2AFA933992D2@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Jan Alonzo
<jmalonzo at gmail.com>'s request for review:
Bug 27230: [Gtk] soup/ResourceHandleSoup.cpp:533: error: 'g_mapped_file_free'
was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=27230

Attachment 33002: Use g_mapped_file_unref for GLIB version 2.22 onwards.
https://bugs.webkit.org/attachment.cgi?id=33002&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
yep! r=me

From bugzilla-daemon at webkit.org  Sat Jul 18 17:10:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:10:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33031] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090719001016.F05BD339A18B@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33031: patch
https://bugs.webkit.org/attachment.cgi?id=33031&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 17:14:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:14:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33031] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090719001449.4F811339A2B5@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33031: patch
https://bugs.webkit.org/attachment.cgi?id=33031&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 17:14:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:14:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33032] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090719001456.782E4339A2F8@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33032: patch
https://bugs.webkit.org/attachment.cgi?id=33032&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 17:17:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:17:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33032] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090719001720.228BA339A396@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33032: patch
https://bugs.webkit.org/attachment.cgi?id=33032&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 17:17:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:17:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33033] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090719001725.2DD61339A3C0@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33033: patch
https://bugs.webkit.org/attachment.cgi?id=33033&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 17:40:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:40:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26620] Haiku WebKit port :
 [Attachment 32917] Modifications on WebKit source code to allow Haiku port.
In-Reply-To: <bug-26620-0@https.bugs.webkit.org/>
References: <bug-26620-0@https.bugs.webkit.org/>
Message-ID: <20090719004058.31A53339A950@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 32917: Modifications on WebKit source code to allow Haiku port.
https://bugs.webkit.org/attachment.cgi?id=32917&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>

> -#if !PLATFORM(WIN_OS) && !PLATFORM(SOLARIS) && !PLATFORM(SYMBIAN) &&
!COMPILER(RVCT)
> +#if !PLATFORM(WIN_OS) && !PLATFORM(SOLARIS) && !PLATFORM(SYMBIAN) &&
!COMPILER(RVCT) && !(HAIKU)
Should be !PLATFORM(HAIKU)

> --- a/WebCore/config.h
> +++ b/WebCore/config.h
> @@ -187,3 +187,7 @@ typedef float CGFloat;
>  #if PLATFORM(WIN) && PLATFORM(CG)
>  #define WTF_USE_SAFARI_THEME 1
>  #endif
> +
> +#if PLATFORM(HAIKU)
> +#include <stdio.h>
> +#endif
stdio.h should not be included in config.h

From bugzilla-daemon at webkit.org  Sat Jul 18 17:44:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:44:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27340] Allow custom memory
 allocation control in JavaScriptCore's JSClassRef.h : [Attachment 32848]
 proposed patch
In-Reply-To: <bug-27340-0@https.bugs.webkit.org/>
References: <bug-27340-0@https.bugs.webkit.org/>
Message-ID: <20090719004412.6B7A2339AA44@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27340: Allow custom memory allocation control in JavaScriptCore's
JSClassRef.h
https://bugs.webkit.org/show_bug.cgi?id=27340

Attachment 32848: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32848&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 17:47:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 17:47:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27338] Allow custom memory
 allocation control in NewThreadContext struct : [Attachment 32845] updated
 proposed patch
In-Reply-To: <bug-27338-0@https.bugs.webkit.org/>
References: <bug-27338-0@https.bugs.webkit.org/>
Message-ID: <20090719004728.CD0A2339AAE6@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27338: Allow custom memory allocation control in NewThreadContext struct
https://bugs.webkit.org/show_bug.cgi?id=27338

Attachment 32845: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=32845&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 21:36:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 21:36:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33034] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090719043635.77F1F339E3C6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33034: patch
https://bugs.webkit.org/attachment.cgi?id=33034&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 21:41:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 21:41:01 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33034] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090719044101.0963B339E4F0@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33034: patch
https://bugs.webkit.org/attachment.cgi?id=33034&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 21:42:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 21:42:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33035] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090719044218.9D593339E551@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33035: patch
https://bugs.webkit.org/attachment.cgi?id=33035&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 23:13:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 23:13:16 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33035] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090719061316.CDF52339F9A0@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33035: patch
https://bugs.webkit.org/attachment.cgi?id=33035&action=review

From bugzilla-daemon at webkit.org  Sat Jul 18 23:13:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 18 Jul 2009 23:13:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33036] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090719061328.37EC7339F9CA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33036: patch
https://bugs.webkit.org/attachment.cgi?id=33036&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 00:16:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 00:16:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27415] [V8] Phase 2: Remove
 event listener methods from V8Proxy : [Attachment 33028] patch
In-Reply-To: <bug-27415-0@https.bugs.webkit.org/>
References: <bug-27415-0@https.bugs.webkit.org/>
Message-ID: <20090719071622.B46A933A075C@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27415: [V8] Phase 2: Remove event listener methods from V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27415

Attachment 33028: patch
https://bugs.webkit.org/attachment.cgi?id=33028&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Looks like a pretty mechanical change and the mechanics look correct.

From bugzilla-daemon at webkit.org  Sun Jul 19 00:29:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 00:29:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27324] Add ENABLE_RUBY to list
 of build options : [Attachment 32824] patch: add ENABLE_RUBY build option
In-Reply-To: <bug-27324-0@https.bugs.webkit.org/>
References: <bug-27324-0@https.bugs.webkit.org/>
Message-ID: <20090719072920.DB0EF33A0ACC@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Attachment 32824: patch: add ENABLE_RUBY build option
https://bugs.webkit.org/attachment.cgi?id=32824&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Address the following few issues and I think it will be ready to land.

Two issues:
1. You appear to be missing changes to trunk/WebCore/GNUmakefile.am and
trunk/WebCore/WebCore.vcproj/WebCoreCommon.vsprops (see
http://trac.webkit.org/changeset/46021 for example changes to these files).
2. The changelog should have the following:

  Date Name line

  Reviewed by NOBODY (OOPS!).

  >Bug Title<
  >Bug Link<

  Description of change.

a. Your change logs appears to be missing the items in ><
b. Your description line seems to need to be indented one more space.

From bugzilla-daemon at webkit.org  Sun Jul 19 01:21:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 01:21:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 32858] Patch to add ChromeClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090719082148.2848B33A16E2@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32858: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32858&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Indeed, it wasn't my intention to leave the printf's in the runJavaScript[...]
methods.

From bugzilla-daemon at webkit.org  Sun Jul 19 01:21:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 01:21:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 33037] Patch to add ChromeClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090719082148.3A9E033A16E4@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33037: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33037&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
Indeed, it wasn't my intention to leave the printf's in the runJavaScript[...]
methods.

From bugzilla-daemon at webkit.org  Sun Jul 19 02:52:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 02:52:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33038] absolute basic
 beginnings of CodeGeneratorGObject.pm.
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090719095211.35D4D33A2D2C@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33038: absolute basic beginnings of CodeGeneratorGObject.pm. 
https://bugs.webkit.org/attachment.cgi?id=33038&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
this patch contains two functions - the absolute basic beginnings of the code
generator.  it can be seen to have zero impact on the existing codebase.  it is
not compiled in.  it is not linked in.	it is perl.  it is not used anywhere. 
it is a start.

From bugzilla-daemon at webkit.org  Sun Jul 19 05:14:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 05:14:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 19874] Inspector should
 support inspect() in the command line : [Attachment 33039] Patch
In-Reply-To: <bug-19874-0@https.bugs.webkit.org/>
References: <bug-19874-0@https.bugs.webkit.org/>
Message-ID: <20090719121412.5587A33A5324@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 19874: Inspector should support inspect() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19874

Attachment 33039: Patch
https://bugs.webkit.org/attachment.cgi?id=33039&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
inspect(document.body) jumps to the Elements panel and selects the node in the
dom tree
inspect(db) jumps to the Databases panel and selects the database
inspect(window.localStorage) jumps to the Databases panel and selects the
domStorage

For other objects, like inspect("foo"), there is no appropriate panel so it
fallsback to console.log
Firebug shows "foo" in the DOM tab.

inspect() with no arguments is ignored.
Firebug shows window in the DOM tab.
Is that better?

From bugzilla-daemon at webkit.org  Sun Jul 19 05:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 05:17:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 19874] Inspector should
 support inspect() in the command line : [Attachment 33039] Patch
In-Reply-To: <bug-19874-0@https.bugs.webkit.org/>
References: <bug-19874-0@https.bugs.webkit.org/>
Message-ID: <20090719121759.5421D33A542D@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19874: Inspector should support inspect() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19874

Attachment 33039: Patch
https://bugs.webkit.org/attachment.cgi?id=33039&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 05:18:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 05:18:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 19874] Inspector should
 support inspect() in the command line : [Attachment 33040] Fixed misleading
 method name
In-Reply-To: <bug-19874-0@https.bugs.webkit.org/>
References: <bug-19874-0@https.bugs.webkit.org/>
Message-ID: <20090719121820.4A3B533A5451@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 19874: Inspector should support inspect() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19874

Attachment 33040: Fixed misleading method name
https://bugs.webkit.org/attachment.cgi?id=33040&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 05:39:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 05:39:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26620] Haiku WebKit port :
 [Attachment 33041] Modifications on WebKit source code to allow Haiku port.
In-Reply-To: <bug-26620-0@https.bugs.webkit.org/>
References: <bug-26620-0@https.bugs.webkit.org/>
Message-ID: <20090719123946.C169633A5966@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26620: Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26620

Attachment 33041: Modifications on WebKit source code to allow Haiku port.
https://bugs.webkit.org/attachment.cgi?id=33041&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 05:54:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 05:54:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 33042] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090719125451.D921033A5D55@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 33042: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=33042&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
The latest modifications on the patch "Modifications on WebKit source code to
allow Haiku port." ( https://bugs.webkit.org/show_bug.cgi?id=26620#c59 )
require that I add "#include <stdio.h>" in 2 files of
WebCore/platform/graphics/haiku/.

From bugzilla-daemon at webkit.org  Sun Jul 19 05:54:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 05:54:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26949] WebCore part of the
 Haiku WebKit port : [Attachment 32931] Patch to add Haiku-specific drawing
 files for WebCore/platform/graphics/.
In-Reply-To: <bug-26949-0@https.bugs.webkit.org/>
References: <bug-26949-0@https.bugs.webkit.org/>
Message-ID: <20090719125451.C792A33A5D53@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26949: WebCore part of the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26949

Attachment 32931: Patch to add Haiku-specific drawing files for
WebCore/platform/graphics/.
https://bugs.webkit.org/attachment.cgi?id=32931&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
The latest modifications on the patch "Modifications on WebKit source code to
allow Haiku port." ( https://bugs.webkit.org/show_bug.cgi?id=26620#c59 )
require that I add "#include <stdio.h>" in 2 files of
WebCore/platform/graphics/haiku/.

From bugzilla-daemon at webkit.org  Sun Jul 19 06:16:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 06:16:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 33043] use the enum in webkitwebview.h
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090719131654.B343733A62D6@gamma.macosforge.org>

Jiahua Huang <jhuangjiahua at gmail.com> has asked  for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 33043: use the enum in webkitwebview.h
https://bugs.webkit.org/attachment.cgi?id=33043&action=review

------- Additional Comments from Jiahua Huang <jhuangjiahua at gmail.com>
(In reply to comment #12)
> Looks fine otherwise. r- for now as the patch needs to be revised.

Remove the improper set of enum WebKitWebViewTargetInfo
in platform/gtk/PasteboardGtk.cpp,
and use the enum in webkitwebview.h

From bugzilla-daemon at webkit.org  Sun Jul 19 08:07:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 08:07:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17154] [GTK] Widget size
 negotiation : [Attachment 33045] Implement proper size request for the
 widget
In-Reply-To: <bug-17154-0@https.bugs.webkit.org/>
References: <bug-17154-0@https.bugs.webkit.org/>
Message-ID: <20090719150721.C179D33A7FC8@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 17154: [GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Attachment 33045: Implement proper size request for the widget
https://bugs.webkit.org/attachment.cgi?id=33045&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
The Anjal project needs this and is currently solving the problem with a
somewhat hackish API addition. I think we should provide a real solution. This
works well on my tests.

From bugzilla-daemon at webkit.org  Sun Jul 19 08:35:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 08:35:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27422] HTMLAudioElement:
 constructor should set "autobuffer" attribute : [Attachment 33046] proposed
 patch
In-Reply-To: <bug-27422-0@https.bugs.webkit.org/>
References: <bug-27422-0@https.bugs.webkit.org/>
Message-ID: <20090719153528.14A5F33A8750@gamma.macosforge.org>

Eric Carlson <eric.carlson at apple.com> has asked  for review:
Bug 27422: HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422

Attachment 33046: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33046&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 08:48:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 08:48:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 19874] Inspector should
 support inspect() in the command line : [Attachment 33040] Fixed misleading
 method name
In-Reply-To: <bug-19874-0@https.bugs.webkit.org/>
References: <bug-19874-0@https.bugs.webkit.org/>
Message-ID: <20090719154859.8230133A8A8D@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19874: Inspector should support inspect() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19874

Attachment 33040: Fixed misleading method name
https://bugs.webkit.org/attachment.cgi?id=33040&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
JoePeck advised me to use a workaround for DOMStorage

From bugzilla-daemon at webkit.org  Sun Jul 19 08:48:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 08:48:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 19874] Inspector should
 support inspect() in the command line : [Attachment 33047] used workaround
 for DOMStorage
In-Reply-To: <bug-19874-0@https.bugs.webkit.org/>
References: <bug-19874-0@https.bugs.webkit.org/>
Message-ID: <20090719154859.8FA8B33A8A90@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 19874: Inspector should support inspect() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19874

Attachment 33047: used workaround for DOMStorage
https://bugs.webkit.org/attachment.cgi?id=33047&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
JoePeck advised me to use a workaround for DOMStorage

From bugzilla-daemon at webkit.org  Sun Jul 19 09:05:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 09:05:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27422] HTMLAudioElement:
 constructor should set "autobuffer" attribute : [Attachment 33046] proposed
 patch
In-Reply-To: <bug-27422-0@https.bugs.webkit.org/>
References: <bug-27422-0@https.bugs.webkit.org/>
Message-ID: <20090719160516.4BAC433A8F61@gamma.macosforge.org>

mitz at webkit.org has granted Eric Carlson <eric.carlson at apple.com>'s request for
review:
Bug 27422: HTMLAudioElement: constructor should set "autobuffer" attribute
https://bugs.webkit.org/show_bug.cgi?id=27422

Attachment 33046: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33046&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 09:07:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 09:07:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27420] Refactor
 WorkerContext to move DedicatedWorker-specific APIs into
 DedicatedWorkerContext : [Attachment 33048] proposed patch
In-Reply-To: <bug-27420-0@https.bugs.webkit.org/>
References: <bug-27420-0@https.bugs.webkit.org/>
Message-ID: <20090719160737.4E83833A9026@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

Attachment 33048: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33048&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
I'd like someone with some experience with the JS bindings internals to take a
look at WebCore/bindings/js/WorkerScriptController::initScript where I'm
setting up the prototype for the global context. I'll try to find someone on
IRC on Monday.

From bugzilla-daemon at webkit.org  Sun Jul 19 12:43:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 12:43:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27423] Remove some outdated
 S60 platform specific code : [Attachment 33049] Proposed patch !
In-Reply-To: <bug-27423-0@https.bugs.webkit.org/>
References: <bug-27423-0@https.bugs.webkit.org/>
Message-ID: <20090719194326.81FCE33ACD1A@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27423: Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423

Attachment 33049: Proposed patch !
https://bugs.webkit.org/attachment.cgi?id=33049&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Also removed WTF_USE_SYMBIAN_UNICODE, it is no longer used.

From bugzilla-daemon at webkit.org  Sun Jul 19 13:00:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 13:00:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27028] [gtk]
 Pasteboard/GtkClipboard can't handle the "text/html" target. : [Attachment
 33043] use the enum in webkitwebview.h
In-Reply-To: <bug-27028-0@https.bugs.webkit.org/>
References: <bug-27028-0@https.bugs.webkit.org/>
Message-ID: <20090719200038.2E31133AD1D6@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Jiahua Huang
<jhuangjiahua at gmail.com>'s request for review:
Bug 27028: [gtk] Pasteboard/GtkClipboard can't handle the "text/html" target.
https://bugs.webkit.org/show_bug.cgi?id=27028

Attachment 33043: use the enum in webkitwebview.h
https://bugs.webkit.org/attachment.cgi?id=33043&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +webcore_cppflags += \
> +	-I$(srcdir)/WebKit/gtk/
> +

This is a layering violation. WebCore should not depend on WebKit. It should go
through the *Client interface, or in the case of Pasteboard, should go through
PasteboardHelper. The previous patch was already doing that. Why the change?

r- because of the layering violation.

From bugzilla-daemon at webkit.org  Sun Jul 19 13:13:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 13:13:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27424] adding
 GStringBinding.h : [Attachment 33050] adds GStringConvert.h
In-Reply-To: <bug-27424-0@https.bugs.webkit.org/>
References: <bug-27424-0@https.bugs.webkit.org/>
Message-ID: <20090719201307.584E933AD4FD@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27424: adding GStringBinding.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33050: adds GStringConvert.h
https://bugs.webkit.org/attachment.cgi?id=33050&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 13:28:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 13:28:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27425] adding
 GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 33052] adds
 gdomhtmlelementwrapperfactory.
In-Reply-To: <bug-27425-0@https.bugs.webkit.org/>
References: <bug-27425-0@https.bugs.webkit.org/>
Message-ID: <20090719202849.CCDA133AD91B@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27425: adding GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425

Attachment 33052: adds gdomhtmlelementwrapperfactory.
https://bugs.webkit.org/attachment.cgi?id=33052&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
these files have review comments on it (one key reason why they're submitted
under a separate bugreport).

from memory, the questions are:

* why is there "shouting" in it?

  answer: because the original files, JSHTMLElementWrapperFactory.[cpp,h] from
which they're copied, also have "shouting" in them.

* why is this not auto-generated?

  answer: because the auto-generator is written in a bug-ugly language called
perl, and it was easier to do a first revision by cut/paste using the advanced
editing features of vim than it was to mind-bend to yet another perl script [i
did try].  also, the exception handling has been completely ripped out of
CodeGeneratorGObject which makes this file quite different from its origins.

From bugzilla-daemon at webkit.org  Sun Jul 19 13:45:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 13:45:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27426] adding
 GDOMBinding.cpp/h as part of GObject bindings : [Attachment 33053] adds
 GDOMBindings
In-Reply-To: <bug-27426-0@https.bugs.webkit.org/>
References: <bug-27426-0@https.bugs.webkit.org/>
Message-ID: <20090719204549.EB5ED33ADE47@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27426: adding GDOMBinding.cpp/h as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27426

Attachment 33053: adds GDOMBindings
https://bugs.webkit.org/attachment.cgi?id=33053&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
from memory, review comments regarding these files:

* why [were] #ifdef 0s added around some code?

  answer: because they might be needed for debugging purposes, just as they
might be needed in JSDOMBindings.cpp

after a few attempts to keep that code in, just in case, reviewers were so
insistent that i decided it wasn't worth messing around with, and removed them.


* why are the headers not in strict alphabetical order?

 answer: whereas in the JS Bindings, the functions are split across several
files (toJS), it was decided to simply cut/paste the copies of the functions
from which the toGDOM versions are derived into one single file.  the headers
were therefore grouped together from the places from whence they came, and
"s/JS/GDOM/g" was then applied.  it _may_ make sense to re-split
GDOMBinding.cpp back into separate files, which would be made all the easier by
keeping the header files grouped together.  a comment [somewhat] to this effect
has been placed at the top of the file GDOMBinding.cpp

From bugzilla-daemon at webkit.org  Sun Jul 19 13:59:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 13:59:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27427] add event listener
 classes for gobject bindings : [Attachment 33054] adds event handling
 intermediate functions for add and remove window,
 xmlhttprequest and node listeners
In-Reply-To: <bug-27427-0@https.bugs.webkit.org/>
References: <bug-27427-0@https.bugs.webkit.org/>
Message-ID: <20090719205952.F2D4E33AE228@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27427: add event listener classes for gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27427

Attachment 33054: adds event handling intermediate functions for add and remove
window, xmlhttprequest and node listeners
https://bugs.webkit.org/attachment.cgi?id=33054&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
this patch adds the linkage between "browser-event" signal and webkit DOM event
handling.  it's a beginning, and it is functional.  it can be seen that only
"onreadystatechange" is presently allowed in xmlhttprequest because this is all
that's required to get most AJAX working.

From bugzilla-daemon at webkit.org  Sun Jul 19 14:23:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 14:23:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27428] adding "base class"
 GdomDOMObject for GObject bindings : [Attachment 33055] adds GdomDOMObject
In-Reply-To: <bug-27428-0@https.bugs.webkit.org/>
References: <bug-27428-0@https.bugs.webkit.org/>
Message-ID: <20090719212330.0630D33AE9D0@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27428: adding "base class" GdomDOMObject for GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27428

Attachment 33055: adds GdomDOMObject
https://bugs.webkit.org/attachment.cgi?id=33055&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
the three files added include GdomDOMObject (and its private hidden struct. 
this will in the future be used to store pointers to exceptions which occur
when a c++ DOM object function gets called).

review comments ... i do recall discussion about removing this; i do recall
that adam managed to remove it entirely.  personally, knowing that the work's
required in the future, i don't like hacking stuff out that will make life
easier in the future.

also, this was an area where martin soto helped contribute: the first design
involving GdomDOMObject had a private c++ object that had a virtual pointer
function mirroring the JSBinding "type()" function, in order to determine the
type even when the intermediate object was actually a c-based one.

it turns out that glib / gobject already has something that does that sort of
thing, so the redundant intermediate class was removed.  hurrah.  less code -
everyone's happy.

further modifications in this area it would be a wise move to leave them until
after this series is all in, and leave this bugreport open as an indicator that
further work is needed in this specific area.  in the future.

From bugzilla-daemon at webkit.org  Sun Jul 19 14:25:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 14:25:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27428] adding "base class"
 GdomDOMObject for GObject bindings : [Attachment 33055] adds GdomDOMObject
In-Reply-To: <bug-27428-0@https.bugs.webkit.org/>
References: <bug-27428-0@https.bugs.webkit.org/>
Message-ID: <20090719212529.B1DC133AEA46@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has canceled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 27428: adding "base class" GdomDOMObject for GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27428

Attachment 33055: adds GdomDOMObject
https://bugs.webkit.org/attachment.cgi?id=33055&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
nuts.  references wrong bug # in ChangeLog.  corrected.

From bugzilla-daemon at webkit.org  Sun Jul 19 14:42:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 14:42:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27429] add gdom.h
 "convenience" header as part of GObject bindings : [Attachment 33058]
 gdom.h developer convenience header
In-Reply-To: <bug-27429-0@https.bugs.webkit.org/>
References: <bug-27429-0@https.bugs.webkit.org/>
Message-ID: <20090719214227.E1BE533AEFB8@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27429: add gdom.h "convenience" header as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27429

Attachment 33058: gdom.h developer convenience header
https://bugs.webkit.org/attachment.cgi?id=33058&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
should be auto-generated, but isn't.  auto-generation can be considered a
luxury for another time.

From bugzilla-daemon at webkit.org  Sun Jul 19 15:01:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 15:01:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27430] adds glib / gobject
 bindings to webkit gtk port : [Attachment 33059] adds use of glib / gobject
 bindings to webkitwebframe
In-Reply-To: <bug-27430-0@https.bugs.webkit.org/>
References: <bug-27430-0@https.bugs.webkit.org/>
Message-ID: <20090719220125.EAECB33AF4D4@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27430: adds glib / gobject bindings to webkit gtk port
https://bugs.webkit.org/show_bug.cgi?id=27430

Attachment 33059: adds use of glib / gobject bindings to webkitwebframe
https://bugs.webkit.org/attachment.cgi?id=33059&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
this patch should be one of those that is applied almost aaabsolutely at the
end, once its dependent patches are landed.  the modifications to
webkitmarshal.list are also included here: somewhere along the line, in
compiling the glib / gobject bindings (most likely the signals) this extra
jobbie is needed.

the functions add in the essential "hooks" in order to actually get at the glib
/ gobjects available through the bindings.  it would be very nice if there were
less of them - but there are not.

missing from the list of functions here is things like
webkit_web_frame_create_text_document() and other such functions.

also - it's worth noting that now that GdomFrame exists, much of the
functionality provided in webkitwebframe.cpp is duplicated, and can be seen to
have been necessarily hard-coded!  the auto-generated functions of GdomFrame
now make that code redundant, and, with careful thought, it should be possible
to drop most of webkitwebframe.cpp.

one for the future.

From bugzilla-daemon at webkit.org  Sun Jul 19 15:19:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 15:19:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27431] splitting
 CodeGeneratorGObject.pm into library files : [Attachment 33060] code
 generator gobject library #1
In-Reply-To: <bug-27431-0@https.bugs.webkit.org/>
References: <bug-27431-0@https.bugs.webkit.org/>
Message-ID: <20090719221906.4DF6733AF9F5@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27431: splitting CodeGeneratorGObject.pm into library files
https://bugs.webkit.org/show_bug.cgi?id=27431

Attachment 33060: code generator gobject library #1
https://bugs.webkit.org/attachment.cgi?id=33060&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
anyone got any better suggestions that will save everyone time, please make
them known....

From bugzilla-daemon at webkit.org  Sun Jul 19 15:29:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 15:29:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27432] add read-write
 access to HTMLOptionElement text under GObject bindings : [Attachment
 33061] patch to make HTMLOptionElement text property read-write under
 gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090719222920.8FD2233AFCF7@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 15:43:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 15:43:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33062] adds toString to
 gobject bindings
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090719224328.2A52833B00EC@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33062: adds toString to gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33062&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
there are a ton of good technical reasons why these should be added. 
discussion of those technical reasons is welcomed.

From bugzilla-daemon at webkit.org  Sun Jul 19 15:50:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 15:50:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33063] adds 3 essential features to gobject document idl
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090719225029.84F1333B0307@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33063: adds 3 essential features to gobject document idl
https://bugs.webkit.org/attachment.cgi?id=33063&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 16:00:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:00:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27435] adding
 XMLHttpRequest send idl language gobject : [Attachment 33064] allows
 DOMString to be passed to XMLHTTPRequest send, in gobject bindings
In-Reply-To: <bug-27435-0@https.bugs.webkit.org/>
References: <bug-27435-0@https.bugs.webkit.org/>
Message-ID: <20090719230040.23F6033B0640@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27435: adding XMLHttpRequest send idl language gobject
https://bugs.webkit.org/show_bug.cgi?id=27435

Attachment 33064: allows DOMString to be passed to XMLHTTPRequest send, in
gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33064&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 16:10:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:10:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27436] gobject bindings
 need access to keyCode on KeyboardEvents! : [Attachment 33065] enables
 access to keyCode and charCode properties and W3C-compliant
 initKeyboardEvent function under gobject language bindings
In-Reply-To: <bug-27436-0@https.bugs.webkit.org/>
References: <bug-27436-0@https.bugs.webkit.org/>
Message-ID: <20090719231044.7CEED33B08B0@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27436: gobject bindings need access to keyCode on KeyboardEvents!
https://bugs.webkit.org/show_bug.cgi?id=27436

Attachment 33065: enables access to keyCode and charCode properties and
W3C-compliant initKeyboardEvent function under gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33065&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 16:24:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:24:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33062] adds toString to
 gobject bindings
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090719232440.867D433B0C1F@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33062: adds toString to gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33062&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
As outlined before, toString is a JavaScript-specific method.

From bugzilla-daemon at webkit.org  Sun Jul 19 16:27:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:27:03 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27432] add read-write access
 to HTMLOptionElement text under GObject bindings : [Attachment 33061] patch
 to make HTMLOptionElement text property read-write under gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090719232703.1620033B0C96@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Per the HTML 5 specification at
<http://www.whatwg.org/specs/web-apps/current-work/multipage/forms.html#htmlopt
ionelement> the text attribute on HTMLOptionElement should be read-only.

From bugzilla-daemon at webkit.org  Sun Jul 19 16:28:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:28:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27437] make
 HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based
 standards under gobject bindings : [Attachment 33066] patch bringing
 language gobject bindings up on a par with its peers (de-facto standards
 compliant) wrt HTMLAppletElement and HTMLEmbedElement
In-Reply-To: <bug-27437-0@https.bugs.webkit.org/>
References: <bug-27437-0@https.bugs.webkit.org/>
Message-ID: <20090719232844.69B5033B0CFE@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33066: patch bringing language gobject bindings up on a par with its
peers (de-facto standards compliant) wrt HTMLAppletElement and HTMLEmbedElement
https://bugs.webkit.org/attachment.cgi?id=33066&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
the relevant research material begins here:

https://bugs.webkit.org/show_bug.cgi?id=16401#c121

From bugzilla-daemon at webkit.org  Sun Jul 19 16:35:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:35:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33067] adds toString to
 gobject bindings
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090719233506.B55E933B0ED2@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33067: adds toString to gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33067&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
whoops, referenced wrong bug # in ChangeLog.

has the research material been reviewed?

i have not received a satisfactory review response indicating that the research
material has been reviewed.

if a satisfactory answer is given, i will no longer request review of this
patch.

if an unsatisfactory answer is given indicating that the research material has
not been reviewed and has not been taken into consideration, the flag will go
up each and every time is it removed, without fail.

From bugzilla-daemon at webkit.org  Sun Jul 19 16:38:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 16:38:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27432] add read-write
 access to HTMLOptionElement text under GObject bindings : [Attachment
 33061] patch to make HTMLOptionElement text property read-write under
 gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090719233847.CF11D33B0FB3@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 17:47:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 17:47:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27420] Refactor
 WorkerContext to move DedicatedWorker-specific APIs into
 DedicatedWorkerContext : [Attachment 33048] proposed patch
In-Reply-To: <bug-27420-0@https.bugs.webkit.org/>
References: <bug-27420-0@https.bugs.webkit.org/>
Message-ID: <20090720004726.70BE533B1F92@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

Attachment 33048: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33048&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Per our IRC conversation, I'm leaving the changes in this patch that remove the
extraneous CRs from V8Index.cpp/h

From bugzilla-daemon at webkit.org  Sun Jul 19 17:47:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 17:47:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27420] Refactor
 WorkerContext to move DedicatedWorker-specific APIs into
 DedicatedWorkerContext : [Attachment 33068] Patch addressing levin's
 comments
In-Reply-To: <bug-27420-0@https.bugs.webkit.org/>
References: <bug-27420-0@https.bugs.webkit.org/>
Message-ID: <20090720004726.9202D33B1F94@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

Attachment 33068: Patch addressing levin's comments
https://bugs.webkit.org/attachment.cgi?id=33068&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
Per our IRC conversation, I'm leaving the changes in this patch that remove the
extraneous CRs from V8Index.cpp/h

From bugzilla-daemon at webkit.org  Sun Jul 19 18:26:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 18:26:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27438] [Qt] Add an option
 for QtLauncher to build without QtUiTools dependency : [Attachment 33069]
 Proposed patch !
In-Reply-To: <bug-27438-0@https.bugs.webkit.org/>
References: <bug-27438-0@https.bugs.webkit.org/>
Message-ID: <20090720012638.3B61D33B28D4@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27438: [Qt] Add an option for QtLauncher to build without QtUiTools
dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Attachment 33069: Proposed patch !
https://bugs.webkit.org/attachment.cgi?id=33069&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 19:24:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 19:24:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33036] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090720022443.75E9F33B381B@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33036: patch
https://bugs.webkit.org/attachment.cgi?id=33036&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This one was a lot more understandable to me.  In general, it looks great. Just
a few nits and but r- for the one concern to address.



> Index: WebCore/bindings/v8/V8ConsoleMessage.cpp
> +    for (int i = 0; i < size; ++i)
> +	   delayedMessages->at(i).dispatchNow(page);

I'm concerned about the call to dispatchNow because it in turn calls
V8ConsoleMessage::processDelayed.

At first, I thought this was ok because no new messages should get added to the
console but then I saw this note about dispatchNow
   48	      // Add a message to the console. May end up calling JavaScript
code
   49	      // indirectly through the inspector so only call this function
when
   50	      // it is safe to do allocations.
so it looks like it can end up running JavaScript (which may result in added
messages?).

If that is true, then it would seem good if this code called
   console->addMessage(JSMessageSource, LogMessageType, ErrorMessageLevel,
m_string, m_lineNumber, m_source);
more directly in some manner (without calling processDelayed).


> + }  // namespace WebCore

Extra space before the // here.


> Index: WebCore/bindings/v8/V8ConsoleMessage.h
> +	   static void handler(v8::Handle<v8::Message> message,
v8::Handle<v8::Value> data);

"message" param name looks redundant.

> +	   // All delayed messages are stored in this vector. If the vector
> +	   // is NULL, there are no delayed messages.

Since no NULLs are in the code, it would be good just to make this comment say
"0" as well.

> + }

Change to "} // namespace WebCore"

From bugzilla-daemon at webkit.org  Sun Jul 19 19:25:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 19:25:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33067] adds toString to
 gobject bindings
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090720022509.D395C33B3868@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33067: adds toString to gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33067&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Marking as r- for reasons previously noted.

From bugzilla-daemon at webkit.org  Sun Jul 19 19:25:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 19:25:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27432] add read-write access
 to HTMLOptionElement text under GObject bindings : [Attachment 33061] patch
 to make HTMLOptionElement text property read-write under gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090720022538.B493833B3894@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Marking as r- for reasons previously noted.

From bugzilla-daemon at webkit.org  Sun Jul 19 19:31:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 19:31:59 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33038] absolute basic
 beginnings of CodeGeneratorGObject.pm.
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090720023159.517A433B39F5@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33038: absolute basic beginnings of CodeGeneratorGObject.pm. 
https://bugs.webkit.org/attachment.cgi?id=33038&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> +package CodeGeneratorGObject;
> +
> +require "CodeGeneratorGObjectLibrary1.pm";

This file doesn't exist as far as I can see.  What is it?  Why is it named in
this manner?

> +
> +# Params: 'domClass' struct

What is this comment about?  The "Params" suggests it is about the arguments to
the following function, but the function appears to take three arguments that
have no relation to this comment.

> +sub GenerateInterface {
> +    my $object = shift;
> +    my $dataNode = shift;
> +    my $defines = shift;
> +
> +    my $name = $dataNode->name;
> +
> +    print "$name\n";

What's the purpose of this print statement?

> +
> +    $object->Generate($dataNode);
> +
> +    # Write changes
> +    my $fname = "Gdom_" . $name; #decamelize($name);

The comment here doesn't seem to add anything.	Why is there commented-out code
here?

> +    $fname =~ s/_//g;
> +    $object->WriteData($fname);
> +}
> +
> +# Params: 'idlDocument' struct

Same comment as for the previous function applies to this comment.

Marking as r- due to these issues.

From bugzilla-daemon at webkit.org  Sun Jul 19 19:55:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 19:55:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33036] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090720025556.9F0B733B409A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33036: patch
https://bugs.webkit.org/attachment.cgi?id=33036&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 19:56:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 19:56:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33070] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090720025606.31C2C33B40C5@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33070: patch
https://bugs.webkit.org/attachment.cgi?id=33070&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 20:19:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 20:19:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33033] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090720031943.15A2133B47B2@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33033: patch
https://bugs.webkit.org/attachment.cgi?id=33033&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 20:19:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 20:19:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33072] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090720031947.A8D0833B47D6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33072: patch
https://bugs.webkit.org/attachment.cgi?id=33072&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 20:26:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 20:26:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27421] [V8] Factor
 V8ConsoleMessage out of V8Proxy : [Attachment 33070] patch
In-Reply-To: <bug-27421-0@https.bugs.webkit.org/>
References: <bug-27421-0@https.bugs.webkit.org/>
Message-ID: <20090720032623.209FE33B49A5@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27421: [V8] Factor V8ConsoleMessage out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27421

Attachment 33070: patch
https://bugs.webkit.org/attachment.cgi?id=33070&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 22:19:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 22:19:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home and End
 buttons do not do anything in drop down lists : [Attachment 32590] new
 patch
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090720051939.A1B3B33B6775@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 22784: [Chromium] Home and End buttons do not do anything in drop down
lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 32590: new patch
https://bugs.webkit.org/attachment.cgi?id=32590&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It is best not to assign your patch to be reviewed by a particular person. 
You'll get more attention usually if your patch is in the general queue.

There were a few things that Mark suggested which would allow you to get closer
to getting this checked in faster:

1. If you had a patch and a bug just for the define change for
ARROW_KEYS_POP_MENU.  I'd r+ it right now and it would be a small focused patch
that didn't attempt to do more than one thing.	This is a good practice in
general. As it makes reviews go quicker and keeping patches focused also helps
with future maintainence when people look at the history and try to understand
what patches were trying to accomplish, etc. so while it may be ten minutes
more work for you. It is a good thing.

2. WebKit is adopting a new style guide (that isn't yet in the written
guidelines) to avoid bool parameters to functions. This is a really good thing
for several reasons: 
a. It keeps the code more readable (What does "true/false" mean when you see it
at a calling site?)
b. It helps with future changes to avoid breakages.  (Once when we picked up a
new revision of WebKit code in chromium things broke because a new bool
parameter was inserted in the middle of other bool parameters.	Now clearly
this doesn't seem like the best thing to do but if they had been enums the
problem would have been quickly detected and corrected instead of taking hours
to track down.)

While your function seems small and you may feel that it isn't worth it to add
an enum for this function, it isn't hard, and it could help with future
maintenance.



> +static int nextValidIndex(const Vector<Element*>& listItems, int listIndex,
bool forward = true)

Change bool forward to an enum as noted above.

> +	   if (keyIdentifier == "Down" || keyIdentifier == "Right" ||
keyIdentifier == "PageDown") {
> +	       listIndex = nextValidIndex(listItems, listIndex);

Making "PageDown" go down only one item seems incorrect.

> +	   } else if (keyIdentifier == "Up" || keyIdentifier == "Left" ||
keyIdentifier == "PageUp") {
> +	       listIndex = previousValidIndex(listItems, listIndex);
> +	       handled = true;

Making "PageUp" go up only one item seems incorrect.

From bugzilla-daemon at webkit.org  Sun Jul 19 22:40:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 22:40:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home and End
 buttons do not do anything in drop down lists : [Attachment 32594] Proposed
 fix for bug 22784
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090720054006.AEEAC33B6CC8@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Neil Rhodes <nrhodes at google.com>'s
request for review:
Bug 22784: [Chromium] Home and End buttons do not do anything in drop down
lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 32594: Proposed fix for bug 22784
https://bugs.webkit.org/attachment.cgi?id=32594&action=review

------- Additional Comments from David Levin <levin at chromium.org>

1. Please create a separate bug for your patch (or else this is going to get
confusing fast).
2. This needs a changelog.  Run prepare-ChangeLog --bug=YourNewBugNumber.
3. It would be great if you used the functions that are being created in the
other patch on this bug rather than have basically the same code duplicated
here.
4. Please make comments look like sentences.  Start with a capital and end with
a period.
5. It looks like you added several static functions to the class. It doesn't
look like they need to be exposed on the class and could instead be static
functions in the file. 

> Index: WebCore/dom/SelectElement.cpp

> +int SelectElement::selectableListIndexPageFrom(SelectElementData& data,
Element* element, int startIndex, bool pageDown)

Avoid bool parameters. Use an enum instead. See my comment for the other patch
on this bug.

> +{
> +    int pageSize = static_cast<RenderListBox*>(element->renderer())->size()
- 1;  // -1 so we still show context

1 space before end of line comments.

> +    int indexOnePageAway = optionToListIndex(data, element, max(0,
min(listSize -1, startIndex +  (pageDown ? pageSize : -pageSize))));

There is no space after "listSize -"
There are two spaces after "startIndex + "

> +    while (index >= 0 && index < listSize && (!isOptionElement(items[index])
|| items[index]->disabled()))
> +	   pageDown ? ++index : --index;

Ideally this would use the function from the other patch -- perhaps wait until
after that patch is checked in.


> +    if (index < 0 || (unsigned) index == items.size()) {

Use c++ style casts.

> +	   while (index >= 0 && index < listSize &&
(!isOptionElement(items[index]) || items[index]->disabled()))
> +	       pageDown ? --index : ++index;

Ideally this would use the function from the other patch.


> +int SelectElement::firstSelectableListIndex(SelectElementData& data,
Element* element)

Use the function from the other patch.

> +int SelectElement::lastSelectableListIndex(SelectElementData& data, Element*
element)

Use the function from the other patch.

>	       else if (keyIdentifier == "Up")
>		   endIndex = previousSelectableListIndex(data, element,
optionToListIndex(data, element, selectedIndex(data, element)));
...
> +	       else if (keyIdentifier == "PageUp")
> +		   endIndex = selectableListIndexPageFrom(data, element,
selectedIndex(data, element), false);

Why is this using selectedIndex(data, element) instead of what "Up" does:
optionToListIndex(data, element, selectedIndex(data, element)) ?

> +	   if (endIndex >= 0 && 
Boolean expressions at the same nesting level that span multiple lines should
have their operators on the left side of the line instead of the right side.

So please move the && to the next line.

> +			(keyIdentifier == "Down" || keyIdentifier == "Up" ||
keyIdentifier == "Home"
> +		   ||  keyIdentifier == "End" || keyIdentifier == "PageDown" ||
keyIdentifier == "PageUp")) {

You have some TABs here which is why the indentation looks so bad.

From bugzilla-daemon at webkit.org  Sun Jul 19 22:55:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 22:55:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27424] adding GStringBinding.h
 : [Attachment 33050] adds GStringConvert.h
In-Reply-To: <bug-27424-0@https.bugs.webkit.org/>
References: <bug-27424-0@https.bugs.webkit.org/>
Message-ID: <20090720055525.693C733B7168@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27424: adding GStringBinding.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33050: adds GStringConvert.h
https://bugs.webkit.org/attachment.cgi?id=33050&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
This is using WebCore types, so the above header file is internal, this means
you should follow the WebCore coding style guidelines, which you don't. The
first issue i notice is the placement of the '*'.

On the question of content, I wonder if the gdom/ directory is supposed to hold
public API as well? if that is the case you should put the GStringConvert
somewhere else, and calling it GStringConvert is a bit misleading as GString !=
gchar.

please revise.

From bugzilla-daemon at webkit.org  Sun Jul 19 22:58:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 22:58:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27423] Remove some outdated
 S60 platform specific code : [Attachment 33049] Proposed patch !
In-Reply-To: <bug-27423-0@https.bugs.webkit.org/>
References: <bug-27423-0@https.bugs.webkit.org/>
Message-ID: <20090720055849.CDDA033B7267@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27423: Remove some outdated S60 platform specific code
https://bugs.webkit.org/show_bug.cgi?id=27423

Attachment 33049: Proposed patch !
https://bugs.webkit.org/attachment.cgi?id=33049&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 23:02:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 23:02:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27275] [Chromium] popup menus
 can crash when the selected index is -1 : [Attachment 32908] Updated fix
 for an invalid vector index crash
In-Reply-To: <bug-27275-0@https.bugs.webkit.org/>
References: <bug-27275-0@https.bugs.webkit.org/>
Message-ID: <20090720060225.BDC9C33B7354@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Paul Godavari <paul at chromium.org>'s
request for review:
Bug 27275: [Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 32908: Updated fix for an invalid vector index crash
https://bugs.webkit.org/attachment.cgi?id=32908&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This seems wrong:
     if (index < 0 || index >= numItems())
 890	     return;
 891 
888892	   if (index == -1 && m_popupClient) {

You've made some of the code unreachable.

From bugzilla-daemon at webkit.org  Sun Jul 19 23:06:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 23:06:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27438] [Qt] Add an option for
 QtLauncher to build without QtUiTools dependency : [Attachment 33069]
 Proposed patch !
In-Reply-To: <bug-27438-0@https.bugs.webkit.org/>
References: <bug-27438-0@https.bugs.webkit.org/>
Message-ID: <20090720060608.175BA33B7440@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27438: [Qt] Add an option for QtLauncher to build without QtUiTools
dependency
https://bugs.webkit.org/show_bug.cgi?id=27438

Attachment 33069: Proposed patch !
https://bugs.webkit.org/attachment.cgi?id=33069&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Okay, we already handle these QT_NO... things..

From bugzilla-daemon at webkit.org  Sun Jul 19 23:32:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 23:32:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26816] Selection changed by
 indent : [Attachment 33073] 5th submission
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090720063229.0591A33B7C65@gamma.macosforge.org>

Ryosuke Niwa <ryosuke.niwa at gmail.com> has asked  for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 33073: 5th submission
https://bugs.webkit.org/attachment.cgi?id=33073&action=review

------- Additional Comments from Ryosuke Niwa <ryosuke.niwa at gmail.com>
The followup bug is filed as the bug 27441.

From bugzilla-daemon at webkit.org  Sun Jul 19 23:37:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 23:37:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32868] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090720063710.6BD4F33B7DA7@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32868: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=32868&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/platform/haiku/ClipboardHaiku.cpp
b/WebCore/platform/haiku/ClipboardHaiku.cpp

> +#include "HashTable.h"

Should be "#include <wtf/HashTable.h>"

> +
> +
> +namespace WebCore {
> +
> +ClipboardHaiku::ClipboardHaiku(ClipboardAccessPolicy policy, bool
forDragging) 
> +    : Clipboard(policy, forDragging)
> +{
> +}
> +
> +void ClipboardHaiku::clearData(const String& type)
> +{
> +    BMessage *data = (BMessage *) NULL;
1. Star in wrong place.
BMessage* data

2. Use c++ style casts. (BMessage *)  (but I don't think the cast is necessary.


3. Use 0 instead of NULL.

This line is repeated a lot in this patch, but I'm only flagging this first
instace.


> +
> +    if (be_clipboard->Lock()) {
> +	   if ((data = be_clipboard->Data())) {
Since there doesn't seem to be any benefit of putting this in the if other than
saving a line.	Why not write it as two lines (which in my opinion makes it
more readable)?

  data = be_clipboard->Data();
  if (data) {

It isn't necessary to be this but it would be nice imo.



> +// extensions beyond IE's API
Format comments like sentences (begin with a capital and end with a period).

> +IntPoint ClipboardHaiku::dragLocation() const 
> +{ 
> +    notImplemented();
> +    return IntPoint(0,0);
Add a space after the comma.


> +DragImageRef ClipboardHaiku::createDragImage(IntPoint& dragLoc) const
Avoid abbreviations: dragloc -> dragLocation

> diff --git a/WebCore/platform/haiku/ClipboardHaiku.h
b/WebCore/platform/haiku/ClipboardHaiku.h
> +    // State available during IE's events for drag and drop and copy/paste
> +    class ClipboardHaiku : public Clipboard {
> +    public:
> +	   ClipboardHaiku(ClipboardAccessPolicy policy, bool forDragging);

"bool forDragging"
Please use an enum instead of a bool. (See
http://trac.webkit.org/browser/trunk/WebCore/workers/WorkerScriptLoader.h for
an example of where this was done.)



> diff --git a/WebCore/platform/haiku/CursorHaiku.cpp
b/WebCore/platform/haiku/CursorHaiku.cpp

> +namespace WebCore {
> +
> +Cursor::Cursor(PlatformCursor p)
"p" -- Use words instead f abbreviations for variable names.


> +static Cursor global_cursor((PlatformCursor)B_CURSOR_SYSTEM_DEFAULT);

Improper casing global_cursor -> globalCursor
Use C++ style casting (static_cast/reinterpret_cast, etc.) instead of C style
casting.


> +static Cursor ibeam_cursor((PlatformCursor)B_CURSOR_I_BEAM);

Same comments as above.

From bugzilla-daemon at webkit.org  Sun Jul 19 23:59:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 23:59:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32989] patch
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090720065907.F19DF33B8447@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32989: patch
https://bugs.webkit.org/attachment.cgi?id=32989&action=review

From bugzilla-daemon at webkit.org  Sun Jul 19 23:59:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 19 Jul 2009 23:59:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32991] Fix weak handle
 issue
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090720065921.DCBAE33B8478@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32991: Fix weak handle issue
https://bugs.webkit.org/attachment.cgi?id=32991&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 01:16:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 01:16:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27265] [Qt] font cache
 reworking : [Attachment 32941] proposed patch
In-Reply-To: <bug-27265-0@https.bugs.webkit.org/>
References: <bug-27265-0@https.bugs.webkit.org/>
Message-ID: <20090720081612.8A58433B9B72@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied Kelemen Bal?zs
<Kelemen.Balazs.3 at stud.u-szeged.hu>'s request for review:
Bug 27265: [Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Attachment 32941: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32941&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

Most of the patch looks good to me! I have a few small comments below. r-
because of those comments and a missing ChangeLog elaborating the changes.

One thing I've noticed is that the use of std::pair<const FontData*, bool>
doesn't help very much to create readable code. Code like

    if (!item.second)
	return item.first;

is very very hard to read. This isn't your fault of course :-), but one thing
that would be nice is a comment explaining what happens there, to make it
easier to read the code three months later :-)

> -typedef QHash<FontDescription, FontPlatformData*> FontPlatformDataCache;
> +// This type must be consistent with FontPlatformData's ctor - the one which

> +// gets FontDescription as it's parameter.
> +class FontPlatformDataCacheKey {
> +public:
> +    FontPlatformDataCacheKey(const FontDescription& description)
> +	   : m_familyName()
> +	   , m_bold(false)
> +	   , m_size(qRound(description.computedPixelSize()))

Why do you use qRound here? computedPixelSize() appears to return an int.


> +void FontCache::purgeInactiveFontData(int count)
> +{
> +    static bool isPurging;  // Guard against reentry when e.g. a deleted
FontData releases its small caps FontData.
> +    if (isPurging)
> +	   return;
> +
> +    isPurging = true;

>From what I can see a chunk of this patch comes from FontCache.cpp. I believe
your patch should include the addition of the copyright holders of that file to
FontCacheQt.cpp.


> -    const FontData* result = new
SimpleFontData(FontPlatformData(description), _font->wordSpacing(),
_font->letterSpacing());
> -    m_fontList.append(pair<const FontData*, bool>(result,
result->isCustomFont()));
> +    const FontData* result = new
SimpleFontData(FontPlatformData(description, _font->wordSpacing(),
_font->letterSpacing()), true);
> +    m_fontList.append(pair<const FontData*, bool>(result, true));

I may be confusing the code here (sorry if that's the case), but shouldn't this
be "false" instead of "true"?

From bugzilla-daemon at webkit.org  Mon Jul 20 01:48:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 01:48:50 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 17154] [GTK] Widget size
 negotiation : [Attachment 33045] Implement proper size request for the
 widget
In-Reply-To: <bug-17154-0@https.bugs.webkit.org/>
References: <bug-17154-0@https.bugs.webkit.org/>
Message-ID: <20090720084850.1533B33BA610@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has canceled Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 17154: [GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Attachment 33045: Implement proper size request for the widget
https://bugs.webkit.org/attachment.cgi?id=33045&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 01:48:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 01:48:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17154] [GTK] Widget size
 negotiation : [Attachment 33074] Implement proper size request for the
 widget
In-Reply-To: <bug-17154-0@https.bugs.webkit.org/>
References: <bug-17154-0@https.bugs.webkit.org/>
Message-ID: <20090720084856.C626433BA62C@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has asked  for review:
Bug 17154: [GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Attachment 33074: Implement proper size request for the widget
https://bugs.webkit.org/attachment.cgi?id=33074&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Here we go.

From bugzilla-daemon at webkit.org  Mon Jul 20 02:38:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 02:38:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26716] [Gtk] Each
 XMLHttpRequest leaks memory. : [Attachment 33075] fixleak.patch
In-Reply-To: <bug-26716-0@https.bugs.webkit.org/>
References: <bug-26716-0@https.bugs.webkit.org/>
Message-ID: <20090720093859.F2F2933BB4A9@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 26716: [Gtk] Each XMLHttpRequest leaks memory.
https://bugs.webkit.org/show_bug.cgi?id=26716

Attachment 33075: fixleak.patch
https://bugs.webkit.org/attachment.cgi?id=33075&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
I think you are totally right; patch attached.

From bugzilla-daemon at webkit.org  Mon Jul 20 02:54:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 02:54:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26716] [Gtk] Each
 XMLHttpRequest leaks memory. : [Attachment 33075] fixleak.patch
In-Reply-To: <bug-26716-0@https.bugs.webkit.org/>
References: <bug-26716-0@https.bugs.webkit.org/>
Message-ID: <20090720095447.CDDA033BBA04@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 26716: [Gtk] Each XMLHttpRequest leaks memory.
https://bugs.webkit.org/show_bug.cgi?id=26716

Attachment 33075: fixleak.patch
https://bugs.webkit.org/attachment.cgi?id=33075&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 02:56:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 02:56:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 17154] [GTK] Widget size
 negotiation : [Attachment 33074] Implement proper size request for the
 widget
In-Reply-To: <bug-17154-0@https.bugs.webkit.org/>
References: <bug-17154-0@https.bugs.webkit.org/>
Message-ID: <20090720095629.E5B7E33BBA9E@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 17154: [GTK] Widget size negotiation
https://bugs.webkit.org/show_bug.cgi?id=17154

Attachment 33074: Implement proper size request for the widget
https://bugs.webkit.org/attachment.cgi?id=33074&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 03:18:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 03:18:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 24986] ARM JIT port :
 [Attachment 32175] Constant pool for AssemblerBuffer (v3)
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090720101829.92F9933BC1BF@gamma.macosforge.org>

Gabor Loki <loki at inf.u-szeged.hu> has canceled	review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32175: Constant pool for AssemblerBuffer (v3)
https://bugs.webkit.org/attachment.cgi?id=32175&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
Clearing the review+ flag after landing (r46057).

From bugzilla-daemon at webkit.org  Mon Jul 20 03:19:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 03:19:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 24986] ARM JIT port :
 [Attachment 32176] Add YARR support for generic ARM platforms (v3)
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090720101936.B1CF033BC254@gamma.macosforge.org>

Gabor Loki <loki at inf.u-szeged.hu> has canceled	review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32176: Add YARR support for generic ARM platforms (v3)
https://bugs.webkit.org/attachment.cgi?id=32176&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
Clearing the review+ flag after landing (r46059).

From bugzilla-daemon at webkit.org  Mon Jul 20 04:03:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 04:03:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27442] [Gtk] Split
 FontPlatformData into FontPlatformDataGtk and FontPlatformDataPango :
 [Attachment 33078] patch to split FontPlatformData into a Gtk and Pango
 variant
In-Reply-To: <bug-27442-0@https.bugs.webkit.org/>
References: <bug-27442-0@https.bugs.webkit.org/>
Message-ID: <20090720110352.B231D33BCFAE@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27442: [Gtk] Split FontPlatformData into FontPlatformDataGtk and
FontPlatformDataPango
https://bugs.webkit.org/show_bug.cgi?id=27442

Attachment 33078: patch to split FontPlatformData into a Gtk and Pango variant
https://bugs.webkit.org/attachment.cgi?id=33078&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 04:42:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 04:42:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27097] [Gtk] Segfault when
 examining an object of ROLE_TABLE via at-spi : [Attachment 33079]
 fixcrash.patch
In-Reply-To: <bug-27097-0@https.bugs.webkit.org/>
References: <bug-27097-0@https.bugs.webkit.org/>
Message-ID: <20090720114209.6FEE233BDA72@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 27097: [Gtk] Segfault when examining an object of ROLE_TABLE via at-spi
https://bugs.webkit.org/show_bug.cgi?id=27097

Attachment 33079: fixcrash.patch
https://bugs.webkit.org/attachment.cgi?id=33079&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Fix the crash.

From bugzilla-daemon at webkit.org  Mon Jul 20 05:46:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 05:46:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27265] [Qt] font cache
 reworking : [Attachment 33080] proposed patch
In-Reply-To: <bug-27265-0@https.bugs.webkit.org/>
References: <bug-27265-0@https.bugs.webkit.org/>
Message-ID: <20090720124604.5F14933BF043@gamma.macosforge.org>

Kelemen Bal?zs <Kelemen.Balazs.3 at stud.u-szeged.hu> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27265: [Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Attachment 33080: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33080&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 06:34:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 06:34:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27265] [Qt] font cache
 reworking : [Attachment 33080] proposed patch
In-Reply-To: <bug-27265-0@https.bugs.webkit.org/>
References: <bug-27265-0@https.bugs.webkit.org/>
Message-ID: <20090720133445.6650133BFFF6@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Kelemen Bal?zs
<Kelemen.Balazs.3 at stud.u-szeged.hu>'s request for review:
Bug 27265: [Qt] font cache reworking
https://bugs.webkit.org/show_bug.cgi?id=27265

Attachment 33080: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33080&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Noticed a small coding style glitch (missing space after if), but I'll
fix it when landing. Thanks!

From bugzilla-daemon at webkit.org  Mon Jul 20 06:35:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 06:35:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27444] Wrong
 FrameLoader::activeDocumentLoader when loading a invalid URL. : [Attachment
 33081] set the provisional documentLoader as the activeDocument in case of
 load failures (v0.1)
In-Reply-To: <bug-27444-0@https.bugs.webkit.org/>
References: <bug-27444-0@https.bugs.webkit.org/>
Message-ID: <20090720133524.3E8FB33C0031@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27444: Wrong FrameLoader::activeDocumentLoader when loading a invalid URL.
https://bugs.webkit.org/show_bug.cgi?id=27444

Attachment 33081: set the provisional documentLoader as the activeDocument in
case of load failures (v0.1)
https://bugs.webkit.org/attachment.cgi?id=33081&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
Steps to reproduce:

1) load a valid url (e.g. http://google.com). Calling:

FrameLoader::activeDocumentLoader::originalURL() -> http://google.com
FrameLoader::activeDocumentLoader::url() -> http://www.google.com
(resolved/redirected)

--> FROM GDB we see that the proper DocumentLoader is set to the FrameLoader
after the load succeeds (see below):

gdb_$ b FrameLoader.cpp:setDocumentLoader
gdb_$ bt
FrameLoader::finishedLoading:3092
DocumentLoader::finishedLoading:353
main frame - willCloseFrame
FrameLoader::stopLoading:566
FrameLoader::transitionToCommitted:2869
*******FrameLoader::setDocumentLoader:2691 'loader=0x886bdb0'

2) after that, load an invalid url (e.g. http://abcdef.abcdef). 

--> Since it fails to load, FrameLoader::setDocumentLoader is *never* called,
and so calling Frameloader::activeDocumentLoader() returns a reference to
"0x886bdb0" (documentLoader of the previous loaded URL - see above). It results
in wrong originalURL values:

FrameLoader::activeDocumentLoader::originalURL() -> http://google.com	  
<---- WRONG
FrameLoader::activeDocumentLoader::url() -> http://abcdef.abcdef

From bugzilla-daemon at webkit.org  Mon Jul 20 06:44:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 06:44:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27097] [Gtk] Segfault when
 examining an object of ROLE_TABLE via at-spi : [Attachment 33079]
 fixcrash.patch
In-Reply-To: <bug-27097-0@https.bugs.webkit.org/>
References: <bug-27097-0@https.bugs.webkit.org/>
Message-ID: <20090720134419.5884233C032D@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 27097: [Gtk] Segfault when examining an object of ROLE_TABLE via at-spi
https://bugs.webkit.org/show_bug.cgi?id=27097

Attachment 33079: fixcrash.patch
https://bugs.webkit.org/attachment.cgi?id=33079&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 07:17:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 07:17:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27445] Coding style fixes :
 [Attachment 33082] Codign style fixes for the Qt sources
In-Reply-To: <bug-27445-0@https.bugs.webkit.org/>
References: <bug-27445-0@https.bugs.webkit.org/>
Message-ID: <20090720141757.7955333C0E9B@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27445: Coding style fixes
https://bugs.webkit.org/show_bug.cgi?id=27445

Attachment 33082: Codign style fixes for the Qt sources
https://bugs.webkit.org/attachment.cgi?id=33082&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Fix Qt code to follow the WebKit Coding Style.

Compiles and didn't affect the results of the layout tests

From bugzilla-daemon at webkit.org  Mon Jul 20 08:08:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 08:08:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 33085] patch 0.4 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090720150823.91FFD33C2088@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 33085: patch 0.4 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=33085&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 08:38:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 08:38:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27410] [Gtk] adding GObject
 Language bindings auto-generator : [Attachment 33086] answered review
 comments
In-Reply-To: <bug-27410-0@https.bugs.webkit.org/>
References: <bug-27410-0@https.bugs.webkit.org/>
Message-ID: <20090720153800.56B1033C2AEC@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27410: [Gtk] adding GObject Language bindings auto-generator
https://bugs.webkit.org/show_bug.cgi?id=27410

Attachment 33086: answered review comments
https://bugs.webkit.org/attachment.cgi?id=33086&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
answering review comments.  made functions in file more like the original from
which it was copied (CodeGeneratorJS.pm).  added explanation of
CodeGeneratorGObjectLibrary1.pm which is included in another patch.

From bugzilla-daemon at webkit.org  Mon Jul 20 08:55:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 08:55:50 -0700 (PDT)
Subject: [webkit-reviews] =?utf-8?q?review_requested=3A_=5BBug_27447=5D_We?=
 =?utf-8?q?bInspector=3A_Accept_autocomplete_on_=27End=27_key_pressed=2E_?=
 =?utf-8?b?OiBbQXR0YWNobWVudCAzMzA4N10gINC30YTQtdGB0YA=?=
In-Reply-To: <bug-27447-0@https.bugs.webkit.org/>
References: <bug-27447-0@https.bugs.webkit.org/>
Message-ID: <20090720155550.70BDA33C3067@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27447: WebInspector: Accept autocomplete on 'End' key pressed.
https://bugs.webkit.org/show_bug.cgi?id=27447

Attachment 33087: ?????
https://bugs.webkit.org/attachment.cgi?id=33087&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 09:29:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:29:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27424] adding
 GStringBinding.h : [Attachment 33088] rename to ConvertToCGharPrivate.h and
 fix up coding standards
In-Reply-To: <bug-27424-0@https.bugs.webkit.org/>
References: <bug-27424-0@https.bugs.webkit.org/>
Message-ID: <20090720162914.2F4CE33C3C51@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27424: adding GStringBinding.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33088: rename to ConvertToCGharPrivate.h and fix up coding standards
https://bugs.webkit.org/attachment.cgi?id=33088&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 09:30:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:30:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 33089]
 Replacement patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090720163012.E02B033C3C9F@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 33089: Replacement patch
https://bugs.webkit.org/attachment.cgi?id=33089&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 09:39:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:39:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27407] [V8] Revert
 incomplete patch : [Attachment 33090] patch, with missing file added
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090720163942.5695433C3F8B@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked Jeremy Orlow <jorlow at chromium.org> for
review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33090: patch, with missing file added
https://bugs.webkit.org/attachment.cgi?id=33090&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
Added the missing WebCore/bindings/v8/custom/V8DataGridColumnListCustom.cpp;
sorry about that.
This patch is up to date with the current r46125.

From bugzilla-daemon at webkit.org  Mon Jul 20 09:45:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:45:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27407] [V8] Revert
 incomplete patch : [Attachment 33090] patch, with missing file added
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090720164549.B3F9033C41C1@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has reassigned Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33090: patch, with missing file added
https://bugs.webkit.org/attachment.cgi?id=33090&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
I don't have review rights.  I think it's best for everyone if you leave off
the requestee since really any reviewer could r+ this for you.

From bugzilla-daemon at webkit.org  Mon Jul 20 09:55:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:55:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27407] [V8] Revert incomplete
 patch : [Attachment 33090] patch, with missing file added
In-Reply-To: <bug-27407-0@https.bugs.webkit.org/>
References: <bug-27407-0@https.bugs.webkit.org/>
Message-ID: <20090720165525.A38DE33C4521@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 27407: [V8] Revert incomplete patch
https://bugs.webkit.org/show_bug.cgi?id=27407

Attachment 33090: patch, with missing file added
https://bugs.webkit.org/attachment.cgi?id=33090&action=review

------- Additional Comments from David Levin <levin at chromium.org>
The patch is about fixing bug 27383, so it should be added to that bug.  (Plus
you'd want to re-open any bug that has a new patch on it and clear the r+ from
any old patches.)

*Also* in WebCore/bindings/v8/V8DataGridDataSource.cpp, this is missing a "//":
 #endif ENABLE(DATAGRID)

From bugzilla-daemon at webkit.org  Mon Jul 20 09:58:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:58:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32991] Fix weak handle
 issue
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090720165844.7983633C4662@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32991: Fix weak handle issue
https://bugs.webkit.org/attachment.cgi?id=32991&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I believe this is the one we want.

From bugzilla-daemon at webkit.org  Mon Jul 20 09:59:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 09:59:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 33091] coding
 style modifications and latest fixes
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090720165953.0BBC133C4709@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked Adam Roben (aroben)
<aroben at apple.com> for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 33091: coding style modifications and latest fixes
https://bugs.webkit.org/attachment.cgi?id=33091&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
modified to follow WEBKIT coding style rules

From bugzilla-daemon at webkit.org  Mon Jul 20 10:02:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 10:02:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 33091] coding
 style modifications and latest fixes
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090720170212.EF62633C47C1@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 33091: coding style modifications and latest fixes
https://bugs.webkit.org/attachment.cgi?id=33091&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 10:10:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 10:10:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27448] [Chromium] On Mac,
 arrow keys should cause Select to pop up its menu : [Attachment
 33092] patch for ARROW_KEYS_POP_MENU
In-Reply-To: <bug-27448-0@https.bugs.webkit.org/>
References: <bug-27448-0@https.bugs.webkit.org/>
Message-ID: <20090720171037.02D7933C4AA9@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu
https://bugs.webkit.org/show_bug.cgi?id=27448

Attachment 33092: patch for ARROW_KEYS_POP_MENU
https://bugs.webkit.org/attachment.cgi?id=33092&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
It's the feel-good, focused patch of the summer! The critics are raving:
"If you had a patch and a bug just for the define change for
ARROW_KEYS_POP_MENU.  I'd r+ it right now."
--David Levin, from comment in 22784

From bugzilla-daemon at webkit.org  Mon Jul 20 10:13:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 10:13:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27448] [Chromium] On Mac,
 arrow keys should cause Select to pop up its menu : [Attachment
 33092] patch for ARROW_KEYS_POP_MENU
In-Reply-To: <bug-27448-0@https.bugs.webkit.org/>
References: <bug-27448-0@https.bugs.webkit.org/>
Message-ID: <20090720171354.38E6F33C4BAD@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jens Alfke <snej at chromium.org>'s
request for review:
Bug 27448: [Chromium] On Mac, arrow keys should cause Select to pop up its menu
https://bugs.webkit.org/show_bug.cgi?id=27448

Attachment 33092: patch for ARROW_KEYS_POP_MENU
https://bugs.webkit.org/attachment.cgi?id=33092&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 10:28:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 10:28:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33093] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090720172807.158EB33C5046@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33093: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33093&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 10:56:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 10:56:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33093] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090720175604.F419F33C5AF0@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33093: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33093&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few last things to address.

> Other ports designed this class with the constructor as private and have a
static method to create the
> clipboard.
Yep, that is a standard pattern. My mistake in missing it :)


> > "bool forDragging"
> > Please use an enum instead of a bool. (See
> > http://trac.webkit.org/browser/trunk/WebCore/workers/WorkerScriptLoader.h
for
> > an example of where this was done.)

> On this point I don't really agree. I know what you mean but, as I looked in
> other ports, none of them used an enum but a boolean.

This is a new style that WebKit is moving to that likely post dates the other
implementations, so that's why they use an enum.

For example see https://bugs.webkit.org/show_bug.cgi?id=26695, where this was
said when someone was adding a new bool parameter:
  We're trying to avoid adding boolean parameters, because they are not very
  clear (when reading code like "hitTestResultAtPoint(point, true, false,
true)",
  what do the booleans mean?). One strategy to replace a boolean parameter is
to
  use a two-value enum, like this:

  enum HitTestScrollbars { ShouldHitTestScrollbars, DontHitTestScrollbars };
 
Although in this case, it does just pass it along to the base class which takes
bool, so perhaps it really isn't a new bool parameter.

Thus, it seems ok in this instance.  Please keep this in mind when doing other
apis though.


> diff --git a/WebCore/platform/haiku/ClipboardHaiku.cpp
b/WebCore/platform/haiku/ClipboardHaiku.cpp

> +#include "IntPoint.h"
> +#include "FileList.h"
> +#include "PlatformString.h"
> +#include "StringHash.h"
> +
> +#include "NotImplemented.h"

Please sort this with the other "" headers.

> +
> +#include <wtf/HashTable.h>

Please sort this with the other #include <> headers.

> +
> +#include <app/Clipboard.h>
> +#include <Message.h>
> +#include <String.h>



> +void ClipboardHaiku::clearData(const String& type)
> +{
> +    BMessage* data;

It would be better if you declared this where it was used and initialized.

> +    if (be_clipboard->Lock()) {
> +	   data = be_clipboard->Data();

It would look like this:
  BMessage* data = be_clipboard->Data();

This same pattern is throughout this code.

> diff --git a/WebCore/platform/haiku/ClipboardHaiku.h
b/WebCore/platform/haiku/ClipboardHaiku.h

> +
> +#include <support/Locker.h>
> +#include <app/Clipboard.h>

Please sort these two.


> diff --git a/WebCore/platform/haiku/CursorHaiku.cpp
b/WebCore/platform/haiku/CursorHaiku.cpp
> +static Cursor
global_cursor(static_cast<PlatformCursor>(B_CURSOR_SYSTEM_DEFAULT));
> +static Cursor ibeam_cursor(static_cast<PlatformCursor>(B_CURSOR_I_BEAM));

As noted before: Improper casing global_cursor -> globalCursor

From bugzilla-daemon at webkit.org  Mon Jul 20 11:17:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 11:17:32 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 33091] coding
 style modifications and latest fixes
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090720181732.A8FAE33C6372@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 33091: coding style modifications and latest fixes
https://bugs.webkit.org/attachment.cgi?id=33091&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +#include "wtf/OwnPtr.h"

"wtf/OwnPtr.h" should be <wtf/OwnPtr.h> (with angle brackets instead of
quotes).

> +struct RotationTransform
> +{

The opening brace for type declarations (struct, class, enum) should be on the
same line as the type name. (Note that this differs from the rule for
functions.) (applies elsewhere)

> +    IntPoint origin()

This can be a const member function.

> +    IntRect mapRect(const IntRect& rect)
> +    {
> +	   return m_transform.mapRect(rect);
> +    }
> +
> +    FloatRect mapRect(const FloatRect& rect)
> +    {
> +	   return m_transform.mapRect(rect);
> +    }
> +
> +    IntPoint mapPoint(const IntPoint& point)
> +    {
> +	   return m_transform.mapPoint(point);
> +    }
> +
> +    FloatPoint mapPoint(const FloatPoint& point)
> +    {
> +	   return m_transform.mapPoint(point);
> +    }
> +
> +    FloatSize mapSize(const FloatSize& size)
> +    {
> +	   double w, h;
> +	   m_transform.map(size.width(), size.height(), w, h);
> +	   return FloatSize(static_cast<float>(w), static_cast<float>(h));
> +    }

These can be const member functions.

> +    PassRefPtr<SharedBitmap> getTransparentLayerBitmap(IntRect& origRect,
AlphaPaintType alphaPaint, RECT& bmpRect, bool checkClipBox, bool force)
> +    {
> +	   if (m_opacity <= 0)
> +	       return 0;
> +
> +	   if (force || m_opacity < 1.)  {
> +	       if (checkClipBox) {
> +		   RECT clipBox;
> +		   int clipType = GetClipBox(m_dc, &clipBox);
> +		   if (clipType == SIMPLEREGION || clipType == COMPLEXREGION)
> +		       origRect.intersect(clipBox);
> +		   if (origRect.isEmpty())
> +		       return 0;
> +	       }
> +
> +	       RefPtr<SharedBitmap> bmp =
SharedBitmap::createInstance(alphaPaint == AlphaPaintNone, origRect.width(),
origRect.height(), false);
> +	       SetRect(&bmpRect, 0, 0, origRect.width(), origRect.height());
> +	       if (bmp) {
> +		   switch (alphaPaint) {
> +		   case AlphaPaintNone:
> +		   case AlphaPaintImage:
> +		       {
> +			   SharedBitmap::DCHolder dc(bmp.get());
> +			   if (dc.get()) {
> +			       BitBlt(dc.get(), 0, 0, origRect.width(),
origRect.height(), m_dc, origRect.x(), origRect.y(), SRCCOPY);
> +			       if (bmp->is32bit() && (!m_bitmap ||
m_bitmap->is16bit())) {
> +				   // Set alpha channel
> +				   unsigned* pixels = (unsigned*)bmp->bytes();

Please use a C++-style cast here.

> +template <typename PixelType, bool Is16bit> void _rotateBitmap(SharedBitmap*
destBmp, const SharedBitmap* sourceBmp, const RotationTransform& transform)

This can be marked "static" so it gets internal linkage.

> +{
> +    int destW = destBmp->width();
> +    int destH = destBmp->height();
> +    int sourceW = sourceBmp->width();
> +    int sourceH = sourceBmp->height();
> +    PixelType* dest = (PixelType*)destBmp->bytes();
> +    const PixelType* source = (const PixelType*)sourceBmp->bytes();

Please use C++-style casts here.

> +void rotateBitmap(SharedBitmap* destBmp, const SharedBitmap* sourceBmp,
const RotationTransform& transform)

This can be marked "static" so it gets internal linkage.

> +void GraphicsContext::drawRect(const IntRect& rect)
> +{
> +    if (!m_data->m_opacity || paintingDisabled() || rect.width() <= 0 ||
rect.height() <= 0)
> +	   return;

I thought you were going to use rect.isEmpty() instead of the width() and
height() checks?

> +#define EQUAL_ANGLE(a, b) (fabs((a) - (b)) < 1e-5)

An inline function would be nicer.

> +void GraphicsContext::setPlatformShouldAntialias(bool should)
> +{
> +    (void)should;
> +    notImplemented();
> +}
> +
> +void GraphicsContext::setLineDash(const DashArray&, float dashOffset)
> +{
> +    (void)dashOffset;
> +    notImplemented();
> +}

As I said before, you should either use UNUSED_PARAM from wtf/UnusedParam.h, or
omit the parameter names entirely.

This patch still has many instances of names like "transparentDc" instead of
"transparentDC", and still has the single-parameter-per-line style for some
function calls. Please fix those.

From bugzilla-daemon at webkit.org  Mon Jul 20 11:29:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 11:29:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27449] Web Inspector: don't
 lose mousemove events while dragging over iframe : [Attachment 33095] patch
In-Reply-To: <bug-27449-0@https.bugs.webkit.org/>
References: <bug-27449-0@https.bugs.webkit.org/>
Message-ID: <20090720182916.5E7C733C67E8@gamma.macosforge.org>

apavlov at chromium.org has asked	for review:
Bug 27449: Web Inspector: don't lose mousemove events while dragging over
iframe
https://bugs.webkit.org/show_bug.cgi?id=27449

Attachment 33095: patch
https://bugs.webkit.org/attachment.cgi?id=33095&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 12:02:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:02:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27453] Uninitialized
 variable in WebCore::CSSFunctionValue::parserValue : [Attachment 33097]
 Patch which initializes a variable
In-Reply-To: <bug-27453-0@https.bugs.webkit.org/>
References: <bug-27453-0@https.bugs.webkit.org/>
Message-ID: <20090720190240.B958633C73CF@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has asked  for review:
Bug 27453: Uninitialized variable in WebCore::CSSFunctionValue::parserValue
https://bugs.webkit.org/show_bug.cgi?id=27453

Attachment 33097: Patch which initializes a variable
https://bugs.webkit.org/attachment.cgi?id=33097&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 12:10:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:10:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 33098] more
 modifications for coding style
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090720191040.BDB6233C76BA@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 33098: more modifications for coding style
https://bugs.webkit.org/attachment.cgi?id=33098&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
more modifications for coding style

From bugzilla-daemon at webkit.org  Mon Jul 20 12:15:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:15:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 33089]
 Replacement patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090720191526.0E47133C782E@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 33089: Replacement patch
https://bugs.webkit.org/attachment.cgi?id=33089&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>

> +float GraphicsLayer::accumulatedOpacity() const
> +{
> +    if (!preserves3D())
> +	   return 1;
> +	   
> +    return m_opacity * (parent() ? parent()->accumulatedOpacity() : 1);
> +}
> +
> +void GraphicsLayer::distributeOpacity(float accumulatedOpacity)
> +{
> +    // If this is a transform layer we need to distribute our opacity to all
our children
> +    
> +    // Incoming accumulatedOpacity is the contribution from our parent(s).
We mutiply this by our own
> +    // opacity to get the total contribution
> +    accumulatedOpacity *= m_opacity;
> +    
> +    if (preserves3D()) {
> +	   size_t numChildren = children().size();
> +	   for (size_t i = 0; i < numChildren; ++i)
> +	       children()[i]->distributeOpacity(accumulatedOpacity);
> +    }
> +}



> +void GraphicsLayerCA::distributeOpacity(float accumulatedOpacity)
> +{
> +    GraphicsLayer::distributeOpacity(accumulatedOpacity);
> +    
> +    // If this is a transform layer we need set the opacity on our m_layer.
Otherwise 
> +    // we just set our own opacity.
> +    accumulatedOpacity *= m_opacity;
> +    
> +    if (preserves3D()) {
> +	   if (m_layer.get())
> +	       [m_layer.get() setOpacity: accumulatedOpacity];
> +    } else
> +	   [primaryLayer() setOpacity: accumulatedOpacity];
> +}

I don't like this duplication of logic between the base class and the derived
class. Logic should live in just one place.

You still have spaces after colons.

I'm also a little concerned about the fact that you're walking the
GraphicsLayer tree, rather than the RenderLayer tree to distribute opacity.
This only happens to work because we have other logic that makes compositing
layers on ancestors of layers with opacity < 1 (in
computeCompositingRequirements()). That logic may changes, so this code needs
to work when a composited layer has a software-rendered parent with opacity <
1.

From bugzilla-daemon at webkit.org  Mon Jul 20 12:16:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:16:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27453] Uninitialized
 variable in WebCore::CSSFunctionValue::parserValue : [Attachment 33099]
 removed tabs from Changelog
In-Reply-To: <bug-27453-0@https.bugs.webkit.org/>
References: <bug-27453-0@https.bugs.webkit.org/>
Message-ID: <20090720191620.8DEAB33C7892@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has asked  for review:
Bug 27453: Uninitialized variable in WebCore::CSSFunctionValue::parserValue
https://bugs.webkit.org/show_bug.cgi?id=27453

Attachment 33099: removed tabs from Changelog
https://bugs.webkit.org/attachment.cgi?id=33099&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 12:16:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:16:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27453] Uninitialized
 variable in WebCore::CSSFunctionValue::parserValue : [Attachment 33097]
 Patch which initializes a variable
In-Reply-To: <bug-27453-0@https.bugs.webkit.org/>
References: <bug-27453-0@https.bugs.webkit.org/>
Message-ID: <20090720191626.D793C33C78A3@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has canceled James Hawkins
<jhawkins at google.com>'s request for review:
Bug 27453: Uninitialized variable in WebCore::CSSFunctionValue::parserValue
https://bugs.webkit.org/show_bug.cgi?id=27453

Attachment 33097: Patch which initializes a variable
https://bugs.webkit.org/attachment.cgi?id=33097&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 12:40:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:40:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27372] [v8] switch to faster
 methods to obtain and set implementation : [Attachment 32942] Initial
 version
In-Reply-To: <bug-27372-0@https.bugs.webkit.org/>
References: <bug-27372-0@https.bugs.webkit.org/>
Message-ID: <20090720194045.E020C33C81B7@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 27372: [v8] switch to faster methods to obtain and set implementation
https://bugs.webkit.org/show_bug.cgi?id=27372

Attachment 32942: Initial version
https://bugs.webkit.org/attachment.cgi?id=32942&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Awesome.  Thanks for explain this patch to me.	Yes, I see now that the callers
all have branches guarding the caste (and that we've retained the assert that's
keeping us honest).

From bugzilla-daemon at webkit.org  Mon Jul 20 12:41:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:41:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26848] [Qt]
 ResourceHandle::willLoadFromCache needs to be implmeneted QtWebKit. :
 [Attachment 33100] modify the patch to include Zecke's review comments.
In-Reply-To: <bug-26848-0@https.bugs.webkit.org/>
References: <bug-26848-0@https.bugs.webkit.org/>
Message-ID: <20090720194104.1524C33C81F8@gamma.macosforge.org>

Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 26848: [Qt] ResourceHandle::willLoadFromCache needs to be implmeneted
QtWebKit.
https://bugs.webkit.org/show_bug.cgi?id=26848

Attachment 33100: modify the patch to include Zecke's review comments.
https://bugs.webkit.org/attachment.cgi?id=33100&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 12:46:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 12:46:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27349] [WINCE] Add
 GraphicsContextWince implementation for WinCE. : [Attachment 33098] more
 modifications for coding style
In-Reply-To: <bug-27349-0@https.bugs.webkit.org/>
References: <bug-27349-0@https.bugs.webkit.org/>
Message-ID: <20090720194616.75BFB33C835A@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27349: [WINCE] Add GraphicsContextWince implementation for WinCE.
https://bugs.webkit.org/show_bug.cgi?id=27349

Attachment 33098: more modifications for coding style
https://bugs.webkit.org/attachment.cgi?id=33098&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +#include "wtf/OwnPtr.h"

This should be <wtf/OwnPtr.h>, with angle brackets.

r=me. Maybe the committer can fix the above before committing.

From bugzilla-daemon at webkit.org  Mon Jul 20 13:20:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:20:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27460]
 WebCore/platform/FileSystem.h needs to include wtf/Platform.h before using
 the PLATFORM macro : [Attachment 33101] patch
In-Reply-To: <bug-27460-0@https.bugs.webkit.org/>
References: <bug-27460-0@https.bugs.webkit.org/>
Message-ID: <20090720202023.0A4D533C8F1D@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 27460: WebCore/platform/FileSystem.h needs to include wtf/Platform.h before
using the PLATFORM macro
https://bugs.webkit.org/show_bug.cgi?id=27460

Attachment 33101: patch
https://bugs.webkit.org/attachment.cgi?id=33101&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 13:26:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:26:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27275] [Chromium] popup
 menus can crash when the selected index is -1 : [Attachment 33102] Fix for
 crashing with invalid index.
In-Reply-To: <bug-27275-0@https.bugs.webkit.org/>
References: <bug-27275-0@https.bugs.webkit.org/>
Message-ID: <20090720202627.B768E33C913B@gamma.macosforge.org>

Paul Godavari <paul at chromium.org> has asked  for review:
Bug 27275: [Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 33102: Fix for crashing with invalid index.
https://bugs.webkit.org/attachment.cgi?id=33102&action=review

------- Additional Comments from Paul Godavari <paul at chromium.org>
Updated the code per previous review comments. Changed the check from "index ==
-1" to "index < 0" to be consistent with other PopupListBox methods.

From bugzilla-daemon at webkit.org  Mon Jul 20 13:29:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:29:46 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27460]
 WebCore/platform/FileSystem.h needs to include wtf/Platform.h before using
 the PLATFORM macro : [Attachment 33101] patch
In-Reply-To: <bug-27460-0@https.bugs.webkit.org/>
References: <bug-27460-0@https.bugs.webkit.org/>
Message-ID: <20090720202946.6203933C92B3@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27460: WebCore/platform/FileSystem.h needs to include wtf/Platform.h before
using the PLATFORM macro
https://bugs.webkit.org/show_bug.cgi?id=27460

Attachment 33101: patch
https://bugs.webkit.org/attachment.cgi?id=33101&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
This is not correct.  The implication of this change is that some .cpp file is
not including config.h.

From bugzilla-daemon at webkit.org  Mon Jul 20 13:37:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:37:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27444] Wrong
 FrameLoader::activeDocumentLoader when loading an invalid URL. :
 [Attachment 33081] set the provisional documentLoader as the activeDocument
 in case of load failures (v0.1)
In-Reply-To: <bug-27444-0@https.bugs.webkit.org/>
References: <bug-27444-0@https.bugs.webkit.org/>
Message-ID: <20090720203750.0090633C955B@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has denied Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27444: Wrong FrameLoader::activeDocumentLoader when loading an invalid URL.
https://bugs.webkit.org/show_bug.cgi?id=27444

Attachment 33081: set the provisional documentLoader as the activeDocument in
case of load failures (v0.1)
https://bugs.webkit.org/attachment.cgi?id=33081&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Thanks for your interest and thanks for you patch, but I think you're chasing
down a non-issue.

Most importantly, a Frame shouldn't ever consider a failed, non-committed load
as it's current DocumentLoader.  Making this change would be a change in
behavior that many WebKit applications do not expect. Most notably, Safari
would break with this change.

Can you explain an example of an application you're working on where this
change is desirable?  And why?

Also, if a layout test times out with your patch in but runs correctly without
your patch, that *is* indicative of a regression with your patch.  I bet the
test is catching exactly the WebKit API breakage that I alluded to.

From bugzilla-daemon at webkit.org  Mon Jul 20 13:41:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:41:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27371] [WINCE] Add WinCE
 specific platform/text files to WebCore : [Attachment 33103] code clean-up
In-Reply-To: <bug-27371-0@https.bugs.webkit.org/>
References: <bug-27371-0@https.bugs.webkit.org/>
Message-ID: <20090720204132.C445533C96C2@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27371: [WINCE] Add WinCE specific platform/text files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27371

Attachment 33103: code clean-up
https://bugs.webkit.org/attachment.cgi?id=33103&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
modified for obvious coding style conflicts

From bugzilla-daemon at webkit.org  Mon Jul 20 13:51:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:51:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27275] [Chromium] popup menus
 can crash when the selected index is -1 : [Attachment 33102] Fix for
 crashing with invalid index.
In-Reply-To: <bug-27275-0@https.bugs.webkit.org/>
References: <bug-27275-0@https.bugs.webkit.org/>
Message-ID: <20090720205137.EE56B33C9A1C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Paul Godavari <paul at chromium.org>'s
request for review:
Bug 27275: [Chromium] popup menus can crash when the selected index is -1
https://bugs.webkit.org/show_bug.cgi?id=27275

Attachment 33102: Fix for crashing with invalid index.
https://bugs.webkit.org/attachment.cgi?id=33102&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I spoke w/ Paul at his desk.

The real bug here seems to be the API design for pointToRowIndex. 
pointToRowIndex returns the special value "-1" which all other places which use
"int index" are forced to then handle.

+    if (index >= numItems())
+	 return;

is not necessary.  I can be an ASSERT, but doesn't seem otherwise needed.

+    if (index < 0) {

could be index == -1, since -1 is the only special value.  It's OK as is
though.

-    ASSERT(index >= 0 && index < numItems());
+    if (index < 0 || index >= numItems())
+	 return;

This looks like it will crash in the future?  Seems we need to handle at least
the -1 case.
bool PopupListBox::isSelectableItem(int index)
 {
+    ASSERT(index >= 0 && index < numItems());

Since we know the source of the only invalid indices (pointToRowIndex), seems
we should fix the source of these invalid indices.

bool hitTest(IntPoint, int& hitRow);
seems like a better API than pointToRowIndex as it would force all callers to
handle the out-of bounds case.

r+ because this fixes the crash.  Please consider filing a bug about the
re-archtecture, or post-ing a fix using the hitTest approach instead.

From bugzilla-daemon at webkit.org  Mon Jul 20 13:53:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 13:53:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27453] Uninitialized variable
 in WebCore::CSSFunctionValue::parserValue : [Attachment 33099] removed tabs
 from Changelog
In-Reply-To: <bug-27453-0@https.bugs.webkit.org/>
References: <bug-27453-0@https.bugs.webkit.org/>
Message-ID: <20090720205349.5E07C33C9B19@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has denied James Hawkins <jhawkins at google.com>'s
request for review:
Bug 27453: Uninitialized variable in WebCore::CSSFunctionValue::parserValue
https://bugs.webkit.org/show_bug.cgi?id=27453

Attachment 33099: removed tabs from Changelog
https://bugs.webkit.org/attachment.cgi?id=33099&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Test case?

From bugzilla-daemon at webkit.org  Mon Jul 20 14:18:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:18:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33104] fix some coding
 style conflicts
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090720211812.70B6433CA3D2@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33104: fix some coding style conflicts
https://bugs.webkit.org/attachment.cgi?id=33104&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
fix some coding style conflicts

From bugzilla-daemon at webkit.org  Mon Jul 20 14:20:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:20:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33105] oops. forgot to
 add ChangeLog to it
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090720212000.0A33833CA49D@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33105: oops. forgot to add ChangeLog to it
https://bugs.webkit.org/attachment.cgi?id=33105&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
add ChangeLog to it

From bugzilla-daemon at webkit.org  Mon Jul 20 14:19:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:19:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33104] fix some coding
 style conflicts
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090720211959.EBF4633CA49B@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33104: fix some coding style conflicts
https://bugs.webkit.org/attachment.cgi?id=33104&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
add ChangeLog to it

From bugzilla-daemon at webkit.org  Mon Jul 20 14:27:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:27:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33106] Checks for namespace
 indentation to cpplint
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090720212705.7CF1833CA727@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33106: Checks for namespace indentation to cpplint
https://bugs.webkit.org/attachment.cgi?id=33106&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 14:43:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:43:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33106] Checks for namespace
 indentation to cpplint
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090720214320.3E82033CAC3F@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33106: Checks for namespace indentation to cpplint
https://bugs.webkit.org/attachment.cgi?id=33106&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Sorry, I forgot an obsolete comment in there (the checks now actually do cover
namespaces in implementation files).
Also, adding the copyright for Torch Mobile, as Bugzilla and Adam Treat
suggest.

From bugzilla-daemon at webkit.org  Mon Jul 20 14:51:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:51:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27445] Coding style fixes :
 [Attachment 33082] Codign style fixes for the Qt sources
In-Reply-To: <bug-27445-0@https.bugs.webkit.org/>
References: <bug-27445-0@https.bugs.webkit.org/>
Message-ID: <20090720215123.362CF33CAF30@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27445: Coding style fixes
https://bugs.webkit.org/show_bug.cgi?id=27445

Attachment 33082: Codign style fixes for the Qt sources
https://bugs.webkit.org/attachment.cgi?id=33082&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
FANTASTIC!

There are still style errors here.  But I guess the tool doesn't catch those
yet.

From bugzilla-daemon at webkit.org  Mon Jul 20 14:58:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 14:58:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26816] Selection changed by
 indent : [Attachment 33073] 5th submission
In-Reply-To: <bug-26816-0@https.bugs.webkit.org/>
References: <bug-26816-0@https.bugs.webkit.org/>
Message-ID: <20090720215805.AC42E33CB16E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 26816: Selection changed by indent
https://bugs.webkit.org/show_bug.cgi?id=26816

Attachment 33073: 5th submission
https://bugs.webkit.org/attachment.cgi?id=33073&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks OK.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:00:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:00:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27463] fix failures seen on
 the bots : [Attachment 33108] patch
In-Reply-To: <bug-27463-0@https.bugs.webkit.org/>
References: <bug-27463-0@https.bugs.webkit.org/>
Message-ID: <20090720220056.EFF6F33CB28D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27463: fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463

Attachment 33108: patch
https://bugs.webkit.org/attachment.cgi?id=33108&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:01:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:01:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27462] Add cpplint check
 for proper include order : [Attachment 33109] Checks include order and
 tests
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090720220135.B2D0B33CB2EF@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33109: Checks include order and tests
https://bugs.webkit.org/attachment.cgi?id=33109&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:03:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:03:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 32970] Fix for 1px CSS border issue
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090720220324.54E3E33CB3AE@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has asked Eric Seidel
<eric at webkit.org> for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 32970: Fix for 1px CSS border issue
https://bugs.webkit.org/attachment.cgi?id=32970&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:04:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:04:01 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27263] WebInspector: show
 last opened panel when invoking inspector. : [Attachment 32847] patch
In-Reply-To: <bug-27263-0@https.bugs.webkit.org/>
References: <bug-27263-0@https.bugs.webkit.org/>
Message-ID: <20090720220401.8DDBE33CB3E7@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27263: WebInspector: show last opened panel when invoking inspector.
https://bugs.webkit.org/show_bug.cgi?id=27263

Attachment 32847: patch
https://bugs.webkit.org/attachment.cgi?id=32847&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
If this is closed as fixed, nothing should be marked for review.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:04:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:04:34 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26120] [Cairo] Honor Desired
 Weight and Italic State for Fonts in Windows Cairo Build : [Attachment
 30837] Honor weight/italic in HFONT structure
In-Reply-To: <bug-26120-0@https.bugs.webkit.org/>
References: <bug-26120-0@https.bugs.webkit.org/>
Message-ID: <20090720220434.ECDC133CB424@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 26120: [Cairo] Honor Desired Weight and Italic State for Fonts in Windows
Cairo Build
https://bugs.webkit.org/show_bug.cgi?id=26120

Attachment 30837: Honor weight/italic in HFONT structure
https://bugs.webkit.org/attachment.cgi?id=30837&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Since this is marked fix, clearing review flag.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:05:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:05:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33110] Fixes, part 7
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090720220540.4813B33CB4AF@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33110: Fixes, part 7
https://bugs.webkit.org/attachment.cgi?id=33110&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This addresses a problem reported by Darin Adler (which was causing his patches
to contain strings like "../../../../../../Filename.ext") and an inconsistency
reported by Adam Barth.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:06:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:06:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33110] Fixes, part 7
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090720220623.078A333CB506@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33110: Fixes, part 7
https://bugs.webkit.org/attachment.cgi?id=33110&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:08:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:08:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27342] Allow custom memory
 allocation control for OpaqueJSPropertyNameArray struct : [Attachment
 32850] proposed patch
In-Reply-To: <bug-27342-0@https.bugs.webkit.org/>
References: <bug-27342-0@https.bugs.webkit.org/>
Message-ID: <20090720220829.EC5CD33CB5D3@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27342: Allow custom memory allocation control for OpaqueJSPropertyNameArray
struct
https://bugs.webkit.org/show_bug.cgi?id=27342

Attachment 32850: proposed patch
https://bugs.webkit.org/attachment.cgi?id=32850&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:09:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:09:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27463] fix failures seen on
 the bots : [Attachment 33108] patch
In-Reply-To: <bug-27463-0@https.bugs.webkit.org/>
References: <bug-27463-0@https.bugs.webkit.org/>
Message-ID: <20090720220918.2D4D333CB634@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Eric Seidel <eric at webkit.org>'s request
for review:
Bug 27463: fix failures seen on the bots
https://bugs.webkit.org/show_bug.cgi?id=27463

Attachment 33108: patch
https://bugs.webkit.org/attachment.cgi?id=33108&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:12:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:12:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33111] Add checks for
 namespace indentation to cpplint (try 3)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090720221201.81A4733CB717@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33111: Add checks for namespace indentation to cpplint (try 3)
https://bugs.webkit.org/attachment.cgi?id=33111&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
One more try, this time updating the method apidox (had a copy-n-paste error in
it) and being nice to preprocessor instructions.
Other parts like "using namespace Foo;" might also get exceptions, but then
those are standard C++ code and should probably be treated like all other C++
code as well. So not building any special cases for those into the code.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:13:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:13:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 32970] Fix for 1px CSS border issue
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090720221357.B162B33CB7CF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 32970: Fix for 1px CSS border issue
https://bugs.webkit.org/attachment.cgi?id=32970&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Not much for me to say here.  As long as this passes tests, it looks sane.

Sad that we can't share more of this code.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:14:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:14:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 33112]
 Replacement patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090720221423.D506C33CB804@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 33112: Replacement patch
https://bugs.webkit.org/attachment.cgi?id=33112&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:16:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:16:12 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 33112]
 Replacement patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090720221612.20B8633CB892@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has canceled Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 33112: Replacement patch
https://bugs.webkit.org/attachment.cgi?id=33112&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:16:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:16:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 33113]
 Fixes a typo in the previous patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090720221612.3471033CB894@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 33113: Fixes a typo in the previous patch
https://bugs.webkit.org/attachment.cgi?id=33113&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:16:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:16:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33110] Fixes, part 7
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090720221655.645CD33CB8C4@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33110: Fixes, part 7
https://bugs.webkit.org/attachment.cgi?id=33110&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46134, clearing flags

From bugzilla-daemon at webkit.org  Mon Jul 20 15:19:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:19:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33105] oops. forgot to
 add ChangeLog to it
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090720221921.4287233CB99F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33105: oops. forgot to add ChangeLog to it
https://bugs.webkit.org/attachment.cgi?id=33105&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Too large to review.  Please explain the 3rd party code you're adding and why
you know it to be a compatible license to WebKit.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:20:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:20:03 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 32951] Add
 platform/network WinCE specific files
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090720222003.BE68433CB9D6@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Adam Treat <treat at kde.org>'s request
for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 32951: Add platform/network WinCE specific files
https://bugs.webkit.org/attachment.cgi?id=32951&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems this is made obsolete by a later patch.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:20:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:20:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27380] Media Controls: We are
 specifying the text height,
 where it is unneeded and the slider is 2px off. : [Attachment 33005] Adjust
 the margin of the slider and remove useless height specification to fix
 alignement of the media controls.
In-Reply-To: <bug-27380-0@https.bugs.webkit.org/>
References: <bug-27380-0@https.bugs.webkit.org/>
Message-ID: <20090720222047.D3D6133CBA27@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27380: Media Controls: We are specifying the text height, where it is
unneeded and the slider is 2px off.
https://bugs.webkit.org/show_bug.cgi?id=27380

Attachment 33005: Adjust the margin of the slider and remove useless height
specification to fix alignement of the media controls.
https://bugs.webkit.org/attachment.cgi?id=33005&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sounds sane to me.  Rubber Stamp! :)

From bugzilla-daemon at webkit.org  Mon Jul 20 15:22:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:22:34 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27387] Implement ErrorEvent
 API. : [Attachment 32971] Proposed Patch
In-Reply-To: <bug-27387-0@https.bugs.webkit.org/>
References: <bug-27387-0@https.bugs.webkit.org/>
Message-ID: <20090720222234.2DE2333CBAAA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 27387: Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

Attachment 32971: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=32971&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It seems this is not used yet.	Shouldn't this be wrapped in the same
ENABLE(WORKERS) liek the rest of workers?

From bugzilla-daemon at webkit.org  Mon Jul 20 15:23:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:23:28 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32991] Fix weak handle
 issue
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090720222328.B887133CBB0B@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32991: Fix weak handle issue
https://bugs.webkit.org/attachment.cgi?id=32991&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
r- for lack of test, or explanation why no test is possible.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:27:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:27:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27282] [V8] Cleanup
 exception handling in worker evaluation code. : [Attachment 33115] Proposed
 Patch
In-Reply-To: <bug-27282-0@https.bugs.webkit.org/>
References: <bug-27282-0@https.bugs.webkit.org/>
Message-ID: <20090720222737.6163433CBCAF@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27282: [V8] Cleanup exception handling in worker evaluation code.
https://bugs.webkit.org/show_bug.cgi?id=27282

Attachment 33115: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33115&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:30:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:30:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27453] Uninitialized variable
 in WebCore::CSSFunctionValue::parserValue : [Attachment 33099] removed tabs
 from Changelog
In-Reply-To: <bug-27453-0@https.bugs.webkit.org/>
References: <bug-27453-0@https.bugs.webkit.org/>
Message-ID: <20090720223009.B7D9833CBD9A@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted  review:
Bug 27453: Uninitialized variable in WebCore::CSSFunctionValue::parserValue
https://bugs.webkit.org/show_bug.cgi?id=27453

Attachment 33099: removed tabs from Changelog
https://bugs.webkit.org/attachment.cgi?id=33099&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Ok, sounds fine.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:33:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:33:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25509] [GTK] Missing
 accelerator in authentication dialog : [Attachment 33116]
 webkit-bug-25509-add-accelerator
In-Reply-To: <bug-25509-0@https.bugs.webkit.org/>
References: <bug-25509-0@https.bugs.webkit.org/>
Message-ID: <20090720223328.5EF9233CBED1@gamma.macosforge.org>

Priit Laes <amd at store20.com> has asked	for review:
Bug 25509: [GTK] Missing accelerator in authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=25509

Attachment 33116: webkit-bug-25509-add-accelerator
https://bugs.webkit.org/attachment.cgi?id=33116&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 15:33:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:33:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27398] Handle opacity and
 opacity animations on transform layers in Leopard : [Attachment 33113]
 Fixes a typo in the previous patch
In-Reply-To: <bug-27398-0@https.bugs.webkit.org/>
References: <bug-27398-0@https.bugs.webkit.org/>
Message-ID: <20090720223347.52B0C33CBEFA@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 27398: Handle opacity and opacity animations on transform layers in Leopard
https://bugs.webkit.org/show_bug.cgi?id=27398

Attachment 33113: Fixes a typo in the previous patch
https://bugs.webkit.org/attachment.cgi?id=33113&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================

> +	   * platform/graphics/GraphicsLayer.h:
> +	   (WebCore::GraphicsLayer::distributeOpacity):
> +	   (WebCore::GraphicsLayer::accumulatedOpacity):
> +	   * platform/graphics/mac/GraphicsLayerCA.h:
> +	   * platform/graphics/mac/GraphicsLayerCA.mm:
> +	   (WebCore::GraphicsLayerCA::setPreserves3D):
> +	   (WebCore::GraphicsLayerCA::setOpacity):
> +	   (WebCore::GraphicsLayerCA::animateFloat):
> +	   (WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
> +	   (WebCore::GraphicsLayerCA::accumulatedOpacity):
> +	   (WebCore::GraphicsLayerCA::distributeOpacity):
> +	   (WebCore::GraphicsLayerCA::setOpacityOnLayer):

This changelist seems stale.

> Index: WebCore/platform/graphics/GraphicsLayer.h
> ===================================================================

>  protected:
> +    virtual void distributeOpacityHelper(float) { }

Please rename this to internalSetOpacity(), or even setOpacityOnLayer(); the
name should say what it does.

> Index: WebCore/platform/graphics/mac/GraphicsLayerCA.mm
> ===================================================================

> +void GraphicsLayerCA::distributeOpacityHelper(float accumulatedOpacity)
> +{
> +    [ (preserves3D() ? m_layer.get() : primaryLayer())
setOpacity:accumulatedOpacity];
> +}

You've got an extra space after the first [

r=me with those adjustments.

From bugzilla-daemon at webkit.org  Mon Jul 20 15:49:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:49:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24818] [GTK] http auth
 dialog pops up twice after a cancelled atempt : [Attachment 33117]
 drop-workaround.patch
In-Reply-To: <bug-24818-0@https.bugs.webkit.org/>
References: <bug-24818-0@https.bugs.webkit.org/>
Message-ID: <20090720224910.682D733CC3AB@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has asked  for review:
Bug 24818: [GTK] http auth dialog pops up twice after a cancelled atempt
https://bugs.webkit.org/show_bug.cgi?id=24818

Attachment 33117: drop-workaround.patch
https://bugs.webkit.org/attachment.cgi?id=33117&action=review

------- Additional Comments from Priit Laes (IRC: plaes) <amd at store20.com>
We can remove the workaround now, as we depend on libsoup-2.27.4

From bugzilla-daemon at webkit.org  Mon Jul 20 15:58:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 15:58:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27466] Search boxes should
 fallback when the RenderTheme doesn't deal with them : [Attachment 33118]
 patch
In-Reply-To: <bug-27466-0@https.bugs.webkit.org/>
References: <bug-27466-0@https.bugs.webkit.org/>
Message-ID: <20090720225800.CE30033CC665@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked  for review:
Bug 27466: Search boxes should fallback when the RenderTheme doesn't deal with
them
https://bugs.webkit.org/show_bug.cgi?id=27466

Attachment 33118: patch
https://bugs.webkit.org/attachment.cgi?id=33118&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 16:01:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 16:01:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home, End,
 PageUp and PageDown buttons do not do anything in drop down lists :
 [Attachment 33096] Updated, more focused patch
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090720230155.BE73933CC76D@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33096: Updated, more focused patch
https://bugs.webkit.org/attachment.cgi?id=33096&action=review

------- Additional Comments from David Levin <levin at chromium.org>


> Index: WebCore/ChangeLog
> +	   No new tests; affects only user input handling.

(Now that I understand this better) It seems that a layout test could be added
for this functionality.  For example, see this test that simulates user input:
LayoutTests/fast/forms/input-text-enter.html

> Index: WebCore/dom/SelectElement.cpp
> +enum SkipDirection {
> +    kSkipBackwards = -1,
> +    kSkipForwards = 1
> +};
> +

Enum members should user InterCaps with an initial capital letter.  (No leading
"k". Also, just fyi, even for constants WebKit doesn't prefix them with "k". 
They follow the standard naming convention.)

From bugzilla-daemon at webkit.org  Mon Jul 20 16:12:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 16:12:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27467] Use memory reference
 in PlatformContextSkia::currentPathInLocalCoordinates() : [Attachment
 33119] Return an empty path in
 PlatformContextSkia::currentPathInLocalCoordinates if matrix.invert() fails
In-Reply-To: <bug-27467-0@https.bugs.webkit.org/>
References: <bug-27467-0@https.bugs.webkit.org/>
Message-ID: <20090720231249.99E7B33CCB00@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has asked  for review:
Bug 27467: Use memory reference in
PlatformContextSkia::currentPathInLocalCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=27467

Attachment 33119: Return an empty path in
PlatformContextSkia::currentPathInLocalCoordinates if matrix.invert() fails
https://bugs.webkit.org/attachment.cgi?id=33119&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 16:14:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 16:14:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24333]
 execCommand('underline') can modify DOM outside of the contentEditable area
 : [Attachment 33120] fixes the bug
In-Reply-To: <bug-24333-0@https.bugs.webkit.org/>
References: <bug-24333-0@https.bugs.webkit.org/>
Message-ID: <20090720231408.04FF733CCB5F@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 24333: execCommand('underline') can modify DOM outside of the
contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Attachment 33120: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33120&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
This patch may also resolve https://bugs.webkit.org/show_bug.cgi?id=20215.

From bugzilla-daemon at webkit.org  Mon Jul 20 16:29:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 16:29:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27467] Uninitialized memory
 reference in PlatformContextSkia::currentPathInLocalCoordinates() :
 [Attachment 33119] Return an empty path in
 PlatformContextSkia::currentPathInLocalCoordinates if matrix.invert() fails
In-Reply-To: <bug-27467-0@https.bugs.webkit.org/>
References: <bug-27467-0@https.bugs.webkit.org/>
Message-ID: <20090720232910.CC1ED33CD06A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted James Hawkins <jhawkins at google.com>'s
request for review:
Bug 27467: Uninitialized memory reference in
PlatformContextSkia::currentPathInLocalCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=27467

Attachment 33119: Return an empty path in
PlatformContextSkia::currentPathInLocalCoordinates if matrix.invert() fails
https://bugs.webkit.org/attachment.cgi?id=33119&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Mon Jul 20 16:29:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 16:29:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33122] Proposed patch
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090720232914.D1E5E33CD087@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33122: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33122&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 16:55:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 16:55:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25552] Support for HTML5 Forms
 "pattern" attribute : [Attachment 33122] Proposed patch
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090720235524.49A3633CD8FF@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33122: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33122&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       RegularExpression patternRegExp(pattern(), TextCaseSensitive);
> +	       return patternRegExp.match(value()) != 0;

If you are trying to determine if the regular expression matches the entire
string you need to do more work. You need to create a test where there is a
regular expression that matches the beginning of a string but there are extra
characters in the value. I believe that test would fail.

This code also recompiles the regular expression pattern every time you do the
match. I suppose that's intentional. If you remove pattern() as I request
below, then you'll instead do getAttribute(patternAttr) and put it into a local
variable of type const AtomicString& at the top of the function.

> +String HTMLInputElement::pattern() const
> +{
> +    return getAttribute(patternAttr);
> +}

For new code, we try to avoid having this kind of function. Instead we put
[Reflect] in the .idl file and let the function be automatically generated. If
you were going to write it by hand there are some issues about using String vs.
AtomicString.

> +void HTMLInputElement::setPattern(const String& p)
> +{
> +    if (p.isEmpty()) {
> +	   int exccode;
> +	   removeAttribute(patternAttr, exccode);
> +    } else
> +	   setAttribute(patternAttr, p);
> +}

Are you sure this does the right thing for the empty string? I recommend just
using [Reflect] in the .idl file and not writing custom code for this. I think
it's unlikely this has a rule different from all other attributes.

I'd like to see some tests about how this works with all the special characters
for regular expressions, especially ones like "$" and "^".

review- mainly because of the "matches the entire string" issue.

From bugzilla-daemon at webkit.org  Mon Jul 20 17:14:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:14:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27472] REGRESSION (r39185):
 Safari adds ".jpeg" extension to images that already have ".JPG" extension
 : [Attachment 33124] patch
In-Reply-To: <bug-27472-0@https.bugs.webkit.org/>
References: <bug-27472-0@https.bugs.webkit.org/>
Message-ID: <20090721001453.0800233CDE8C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27472: REGRESSION (r39185): Safari adds ".jpeg" extension to images that
already have ".JPG" extension
https://bugs.webkit.org/show_bug.cgi?id=27472

Attachment 33124: patch
https://bugs.webkit.org/attachment.cgi?id=33124&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 17:24:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:24:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27472] REGRESSION (r39185):
 Safari adds ".jpeg" extension to images that already have ".JPG" extension
 : [Attachment 33124] patch
In-Reply-To: <bug-27472-0@https.bugs.webkit.org/>
References: <bug-27472-0@https.bugs.webkit.org/>
Message-ID: <20090721002426.9079733CE228@gamma.macosforge.org>

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 27472: REGRESSION (r39185): Safari adds ".jpeg" extension to images that
already have ".JPG" extension
https://bugs.webkit.org/show_bug.cgi?id=27472

Attachment 33124: patch
https://bugs.webkit.org/attachment.cgi?id=33124&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 17:26:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:26:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27387] Implement ErrorEvent
 API. : [Attachment 33125] Proposed Patch
In-Reply-To: <bug-27387-0@https.bugs.webkit.org/>
References: <bug-27387-0@https.bugs.webkit.org/>
Message-ID: <20090721002630.0EDCF33CE2D6@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27387: Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

Attachment 33125: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33125&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
I've wrapped the code in ENABLE(WORKERS). ErrorEvent will be used in the
incoming patch I am going to submit for review.

From bugzilla-daemon at webkit.org  Mon Jul 20 17:36:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:36:56 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33111] Add checks for
 namespace indentation to cpplint (try 3)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721003656.AC1D233CE636@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33111: Add checks for namespace indentation to cpplint (try 3)
https://bugs.webkit.org/attachment.cgi?id=33111&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Cool.  Thanks for adding this.	There are a few things to address below at this
point.


> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
>  # Copyright (c) 2009 Google Inc. All rights reserved.
> +# Copyright (c) 2009 Torch Mobile Inc.

Not necessary but you would make me happy if you changed the (c) to (C) in both
of these (and in the other file).

> +def check_namespace_indentation(filename, clean_lines, line_number,
file_extension, error):
...
> +    line = clean_lines.elided[line_number]	     # get rid of comments and
strings

Just one space before the #.


> +    if not match(r'\s*namespace\s+\S+\s+{\s*$', line):
I would change this to 
   namespace_match =
match(r'(?P<namespace_indentation>\s*)namespace\s+\S+\s*{\s*$', line):
   if not namespace_match:

I did two changes:
1. I made "namespace WebKit{" match so that this code can catch things even if
there is a bad style.
2. I added a named group which allows the next change:

> +    namespace_indentation = line[0 : line.find('namespace')]

namespace_indentation = namespace_match.group('namespace_indentation')

> +    if file_extension == 'h':
> +	   is_implementation_file = False
> +    elif file_extension == 'cpp' or file_extension == 'c' or file_extension
== 'mm':
> +	   is_implementation_file = True
> +    else:
> +	   return
> +
> +    is_header_file = not is_implementation_file

Note that cpplint only processes files with certain extensions already, so
there is no need to do the filtering again here.

With that in mind, consider this
    is_header_file = file_extension == 'h'
    is_implementation_file = not is_header_file

> +    line_offset = 0
> +
> +    if is_header_file:
> +	   inner_indentation = namespace_indentation + '    '

  inner_indentation = namespace_indentation + ' ' * 4
Makes it clearer that it is 4 spaces.

> +	   for current_line in clean_lines.raw_lines[line_number + 1 :
clean_lines.num_lines()]:

No spaces around ":"
Also, for indexes at the edges, you don't need to list them, so you should do
this

for current_line in clean_lines.raw_lines[line_number + 1:]:

> +	       # Skip not only empty lines but also those with preprocessor
directives.

What about labels? (Not case labels but other labels.)

> +	       if current_line.strip() == '' or current_line.startswith('#'):
> +		   continue
> +
> +	       if current_line.find(inner_indentation) != 0:

if not current_line.startswith(inner_indentation):

> +		   # If something unindented was discovered, make sure it's a
closing brace.
> +		   if current_line.find(namespace_indentation + '}') != 0:

if not current_line.startswith(namespace_indentation + '}'):

> +		       error(filename, line_number + line_offset,
'whitespace/indent', 4,
> +			     'In a header, code inside a namespace should be
indented.')
> +		   break
> +
> +    if is_implementation_file:
> +	   for current_line in clean_lines.raw_lines[line_number + 1 :
clean_lines.num_lines()]:

Use
	for current_line in clean_lines.raw_lines[line_number + 1:]:

> +	       line_offset += 1
> +
> +	       if current_line.strip() == '':
> +		   continue
> +
> +	       remaining_line = current_line[len(namespace_indentation) :
len(current_line)]

Use
	    remaining_line = current_line[len(namespace_indentation):]

> +	       if not match(r'\S+', remaining_line):

Why bother with the +?
 if not match(r'\S', remaining_line):


> diff --git a/WebKitTools/Scripts/modules/cpplint_unittest.py
b/WebKitTools/Scripts/modules/cpplint_unittest.py
> +    def assert_multi_line_lint(self, code, expected_message, file_name =
'foo.h'):

No spaces around = for arguments (weird python style rule).

> +    def assert_multi_line_lint_re(self, code, expected_message_re, file_name
= 'foo.h'):

No spaces around = for arguments (weird python style rule).


> @@ -275,6 +277,64 @@ class CpplintTest(CpplintTestBase):
>	       'Line ends in whitespace.  Consider deleting these extra
spaces.'
>	       '  [whitespace/end_of_line] [4]')
>  
> +    def test_namespace_indentation(self):

These tests should go in class WebKitStyleTests:, def_test_indentation: Look
for "# 3." and "# 4." to see where to add them.

> +	   # Test indentation in header files, which is required.
> +	   self.assert_multi_line_lint(
> +	       'namespace WebCore {\n'

Add an empty line here to test that code as well.

> +	       '    class Document {\n'

Would be nice to add a line there as well to verify that lines indented further
in the namespace are not flagged.

> +	       '    };\n'
> +	       '}',
> +	       '',
> +	       'foo.h')


> +
> +	   # Test indentation in implementation files, which is not allowed.
> +	   self.assert_multi_line_lint(
> +	       'namespace WebCore {\n'

Add an empty line here to test that code as well.

> +	       'Document::Foo() {}\n'

Please make this a function with contents to verify that it doesn't flag the
lines indented inside of the function.


> +	       '}',
> +	       '',
> +	       'foo.cpp')
> +	   self.assert_multi_line_lint(
> +	       'namespace OuterNamespace {\n'
> +	       'namespace InnerNamespace {\n'
> +	       'Document::Foo() {}\n'

Please add a space in side of { } (because I think this is the preferred WebKit
style and the tests might as well reflect that).
(The same thing in other places where {} appears.)

From bugzilla-daemon at webkit.org  Mon Jul 20 17:38:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:38:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27469] Make it harder to
 misuse try* allocation routines : [Attachment 33126] a patch
In-Reply-To: <bug-27469-0@https.bugs.webkit.org/>
References: <bug-27469-0@https.bugs.webkit.org/>
Message-ID: <20090721003856.F0C3733CE714@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27469: Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Attachment 33126: a patch
https://bugs.webkit.org/attachment.cgi?id=33126&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 17:39:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:39:22 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27469] Make it harder to
 misuse try* allocation routines : [Attachment 33126] a patch
In-Reply-To: <bug-27469-0@https.bugs.webkit.org/>
References: <bug-27469-0@https.bugs.webkit.org/>
Message-ID: <20090721003922.DEE9133CE740@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27469: Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Attachment 33126: a patch
https://bugs.webkit.org/attachment.cgi?id=33126&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
whoops, bad patch

From bugzilla-daemon at webkit.org  Mon Jul 20 17:45:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:45:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27469] Make it harder to
 misuse try* allocation routines : [Attachment 33127] a correct patch
In-Reply-To: <bug-27469-0@https.bugs.webkit.org/>
References: <bug-27469-0@https.bugs.webkit.org/>
Message-ID: <20090721004540.48FCB33CE8E2@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27469: Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Attachment 33127: a correct patch
https://bugs.webkit.org/attachment.cgi?id=33127&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 17:49:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:49:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27473] Chromium Linux:
 cache Harfbuzz faces : [Attachment 33128] patch
In-Reply-To: <bug-27473-0@https.bugs.webkit.org/>
References: <bug-27473-0@https.bugs.webkit.org/>
Message-ID: <20090721004947.576EF33CE9E8@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27473: Chromium Linux: cache Harfbuzz faces
https://bugs.webkit.org/show_bug.cgi?id=27473

Attachment 33128: patch
https://bugs.webkit.org/attachment.cgi?id=33128&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 17:53:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:53:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27387] Implement ErrorEvent
 API. : [Attachment 33125] Proposed Patch
In-Reply-To: <bug-27387-0@https.bugs.webkit.org/>
References: <bug-27387-0@https.bugs.webkit.org/>
Message-ID: <20090721005324.4C4B033CEADA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27387: Implement ErrorEvent API.
https://bugs.webkit.org/show_bug.cgi?id=27387

Attachment 33125: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33125&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Mon Jul 20 17:58:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 17:58:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27474] webkit crashes if
 the selection is set in a textarea/text input immediately after setting
 display:none : [Attachment 33129] Fixes crashes
In-Reply-To: <bug-27474-0@https.bugs.webkit.org/>
References: <bug-27474-0@https.bugs.webkit.org/>
Message-ID: <20090721005854.7185E33CEC79@gamma.macosforge.org>

Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 27474: webkit crashes if the selection is set in a textarea/text input
immediately after setting display:none
https://bugs.webkit.org/show_bug.cgi?id=27474

Attachment 33129: Fixes crashes
https://bugs.webkit.org/attachment.cgi?id=33129&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>

---
 8 files changed, 101 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 20 18:06:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 18:06:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27475] REGRESSION (r46142):
 Need to remove showTreeThisForThis : [Attachment 33130] remove
 showTreeForThis
In-Reply-To: <bug-27475-0@https.bugs.webkit.org/>
References: <bug-27475-0@https.bugs.webkit.org/>
Message-ID: <20090721010658.B23CF33CEEB2@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27475: REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475

Attachment 33130: remove showTreeForThis
https://bugs.webkit.org/attachment.cgi?id=33130&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 18:08:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 18:08:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27475] REGRESSION (r46142):
 Need to remove showTreeThisForThis : [Attachment 33130] remove
 showTreeForThis
In-Reply-To: <bug-27475-0@https.bugs.webkit.org/>
References: <bug-27475-0@https.bugs.webkit.org/>
Message-ID: <20090721010855.E7CA333CEF47@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 27475: REGRESSION (r46142): Need to remove showTreeThisForThis
https://bugs.webkit.org/show_bug.cgi?id=27475

Attachment 33130: remove showTreeForThis
https://bugs.webkit.org/attachment.cgi?id=33130&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 18:13:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 18:13:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33131] Fixes, part 8
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090721011314.6878E33CF0C9@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33131: Fixes, part 8
https://bugs.webkit.org/attachment.cgi?id=33131&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This implements abarth's suggestion of creating a centralized
determineSVNRoot() that multiple scripts can call.

The main goal of this is to use it in commit-log-editor, where the old code
resulted in commit logs like "../../../../../../JavaScriptCore:" in my hybrid
checkout.

ddkilzer said that darin has expressed a preference for keeping
svn-create-patch independent, which would imply copy-and-pasting this code
instead of (or in addition to?) putting it in VCSUtils.pm.  I can do either;
I'm biased against copy-and-pasting unless it's important.  Let me know.

From bugzilla-daemon at webkit.org  Mon Jul 20 18:34:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 18:34:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33132] Fixes, part 9
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090721013456.9D8C933CF4AF@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked Steve Falkenburg
<sfalken at apple.com> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33132: Fixes, part 9
https://bugs.webkit.org/attachment.cgi?id=33132&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This is patch 3 plus "cmd /c" after the "if errorlevel 1 set PATH" call.

This shouldn't be committed until it's tested with someone at Apple who was
having problems with patch 3 and found to solve the problem.  (Personally, I'm
somewhat skeptical.)

From bugzilla-daemon at webkit.org  Mon Jul 20 19:04:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:04:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27473] Chromium Linux:
 cache Harfbuzz faces : [Attachment 33133] patch
In-Reply-To: <bug-27473-0@https.bugs.webkit.org/>
References: <bug-27473-0@https.bugs.webkit.org/>
Message-ID: <20090721020407.37FB933CFA10@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27473: Chromium Linux: cache Harfbuzz faces
https://bugs.webkit.org/show_bug.cgi?id=27473

Attachment 33133: patch
https://bugs.webkit.org/attachment.cgi?id=33133&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:05:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:05:22 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27473] Chromium Linux: cache
 Harfbuzz faces : [Attachment 33133] patch
In-Reply-To: <bug-27473-0@https.bugs.webkit.org/>
References: <bug-27473-0@https.bugs.webkit.org/>
Message-ID: <20090721020522.91DCA33CFA45@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has canceled Adam Langley <agl at chromium.org>'s
request for review:
Bug 27473: Chromium Linux: cache Harfbuzz faces
https://bugs.webkit.org/show_bug.cgi?id=27473

Attachment 33133: patch
https://bugs.webkit.org/attachment.cgi?id=33133&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:05:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:05:22 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27473] Chromium Linux: cache
 Harfbuzz faces : [Attachment 33128] patch
In-Reply-To: <bug-27473-0@https.bugs.webkit.org/>
References: <bug-27473-0@https.bugs.webkit.org/>
Message-ID: <20090721020522.6D4E733CFA41@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has canceled Adam Langley <agl at chromium.org>'s
request for review:
Bug 27473: Chromium Linux: cache Harfbuzz faces
https://bugs.webkit.org/show_bug.cgi?id=27473

Attachment 33128: patch
https://bugs.webkit.org/attachment.cgi?id=33128&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:05:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:05:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27473] Chromium Linux:
 cache Harfbuzz faces : [Attachment 33134] patch
In-Reply-To: <bug-27473-0@https.bugs.webkit.org/>
References: <bug-27473-0@https.bugs.webkit.org/>
Message-ID: <20090721020522.C12F233CFA4B@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27473: Chromium Linux: cache Harfbuzz faces
https://bugs.webkit.org/show_bug.cgi?id=27473

Attachment 33134: patch
https://bugs.webkit.org/attachment.cgi?id=33134&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:06:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:06:52 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27473] Chromium Linux: cache
 Harfbuzz faces : [Attachment 33134] patch
In-Reply-To: <bug-27473-0@https.bugs.webkit.org/>
References: <bug-27473-0@https.bugs.webkit.org/>
Message-ID: <20090721020652.F15AB33CFA85@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27473: Chromium Linux: cache Harfbuzz faces
https://bugs.webkit.org/show_bug.cgi?id=27473

Attachment 33134: patch
https://bugs.webkit.org/attachment.cgi?id=33134&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems fine.

From bugzilla-daemon at webkit.org  Mon Jul 20 19:19:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:19:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27478] All
 DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject :
 [Attachment 33135] patch
In-Reply-To: <bug-27478-0@https.bugs.webkit.org/>
References: <bug-27478-0@https.bugs.webkit.org/>
Message-ID: <20090721021909.8C16233CFBB2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27478: All DOMConstructorObjects should hold a pointer to the
JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

Attachment 33135: patch
https://bugs.webkit.org/attachment.cgi?id=33135&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:26:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:26:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27479] Guard access to
 installedMediaEngines()[0] : [Attachment 33136] patch
In-Reply-To: <bug-27479-0@https.bugs.webkit.org/>
References: <bug-27479-0@https.bugs.webkit.org/>
Message-ID: <20090721022638.978B233CFCB1@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked  for review:
Bug 27479: Guard access to installedMediaEngines()[0]
https://bugs.webkit.org/show_bug.cgi?id=27479

Attachment 33136: patch
https://bugs.webkit.org/attachment.cgi?id=33136&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:28:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:28:30 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27466] Search boxes should
 fallback when the RenderTheme doesn't deal with them : [Attachment 33118]
 patch
In-Reply-To: <bug-27466-0@https.bugs.webkit.org/>
References: <bug-27466-0@https.bugs.webkit.org/>
Message-ID: <20090721022830.3C74633CFCE5@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 27466: Search boxes should fallback when the RenderTheme doesn't deal with
them
https://bugs.webkit.org/show_bug.cgi?id=27466

Attachment 33118: patch
https://bugs.webkit.org/attachment.cgi?id=33118&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Change looks fine.  Fix the fallthrough issue and re-post. :)

From bugzilla-daemon at webkit.org  Mon Jul 20 19:36:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:36:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27477] Incorrect assertion
 in Vector::remove : [Attachment 33137] Patch that makes the assertion check
 for <= instead of just <.
In-Reply-To: <bug-27477-0@https.bugs.webkit.org/>
References: <bug-27477-0@https.bugs.webkit.org/>
Message-ID: <20090721023652.86B0F33CFDBB@gamma.macosforge.org>

Jessie Berlin <jberlin at apple.com> has asked  for review:
Bug 27477: Incorrect assertion in Vector::remove
https://bugs.webkit.org/show_bug.cgi?id=27477

Attachment 33137: Patch that makes the assertion check for <= instead of just
<.
https://bugs.webkit.org/attachment.cgi?id=33137&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:42:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:42:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27469] Make it harder to
 misuse try* allocation routines : [Attachment 33127] a correct patch
In-Reply-To: <bug-27469-0@https.bugs.webkit.org/>
References: <bug-27469-0@https.bugs.webkit.org/>
Message-ID: <20090721024204.5884D33CFE2C@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has granted Oliver Hunt
<oliver at apple.com>'s request for review:
Bug 27469: Make it harder to misuse try* allocation routines
https://bugs.webkit.org/show_bug.cgi?id=27469

Attachment 33127: a correct patch
https://bugs.webkit.org/attachment.cgi?id=33127&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Please rename 'Maybe' to 'PossiblyNull', abarth ftw!

From bugzilla-daemon at webkit.org  Mon Jul 20 19:44:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:44:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27477] Incorrect assertion in
 Vector::remove : [Attachment 33137] Patch that makes the assertion check
 for <= instead of just <.
In-Reply-To: <bug-27477-0@https.bugs.webkit.org/>
References: <bug-27477-0@https.bugs.webkit.org/>
Message-ID: <20090721024449.38A0033CFE66@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jessie Berlin
<jberlin at apple.com>'s request for review:
Bug 27477: Incorrect assertion in Vector::remove
https://bugs.webkit.org/show_bug.cgi?id=27477

Attachment 33137: Patch that makes the assertion check for <= instead of just
<.
https://bugs.webkit.org/attachment.cgi?id=33137&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:50:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:50:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27437] make HTMLAppletElement
 and HTMLEmbedElement compliant with de-facto JS-based standards under
 gobject bindings : [Attachment 33066] patch bringing language gobject
 bindings up on a par with its peers (de-facto standards compliant) wrt
 HTMLAppletElement and HTMLEmbedElement
In-Reply-To: <bug-27437-0@https.bugs.webkit.org/>
References: <bug-27437-0@https.bugs.webkit.org/>
Message-ID: <20090721025012.1D28233CFEF0@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33066: patch bringing language gobject bindings up on a par with its
peers (de-facto standards compliant) wrt HTMLAppletElement and HTMLEmbedElement
https://bugs.webkit.org/attachment.cgi?id=33066&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Per comment 3 and comment 4, the current patch is not correct but the idea is
good.  Please revise and resubmit.  Please also include a more useful ChangeLog
entry.

From bugzilla-daemon at webkit.org  Mon Jul 20 19:51:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:51:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27425] adding
 GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 33052] adds
 gdomhtmlelementwrapperfactory.
In-Reply-To: <bug-27425-0@https.bugs.webkit.org/>
References: <bug-27425-0@https.bugs.webkit.org/>
Message-ID: <20090721025139.8F20333CFF12@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27425: adding GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425

Attachment 33052: adds gdomhtmlelementwrapperfactory.
https://bugs.webkit.org/attachment.cgi?id=33052&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +2008-11-30  lkcl  <lkcl at lkcl.net>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27425
> +
> +	   * bindings/gdom/GDOMHTMLElementWrapperFactory.cpp: Added.  Copied
from the auto-generated JSHTMLElementWrapperFactory.cpp 
> +	   * bindings/gdom/GDOMHTMLElementWrapperFactory.h:  Added.  Copied
from the auto-generated JSHTMLElementWrapperFactory.h

You are missing a description of what this patch actually does.  Please fill
out some description for what this patch is meant to provide.

> +/* Note: This file is derived by hand from an automatically generated
> + file.
> + 
> + Keeping it up-to-date could potentially be done by adding a
> + make_names.pl generator, or by writing a separate generater which
> + takes JSHTMLElementWrapperFactory.h as input.
> +*/

Minor nit: s/generater/generator/

Regular nit: why is this generated file to be landed?  If it is to be updated
in the future with a script, then why land it in the tree as static?  A
placeholder until said script is written?

> +
> +
> +#include "config.h"
> +
> +#include "gdom/GdomNode.h"
> +#include "GDOMHTMLElementWrapperFactory.h"

Order of includes is wrong.   See the WebKit coding style guidelines for order
of includes.

There a lot of commented out pieces of code.  We generally don't land patches
with commented out pieces of code.

Beyond that, without a more detailed Changelog it makes it hard to review.

r- for the above reasons.

From bugzilla-daemon at webkit.org  Mon Jul 20 19:53:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:53:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27479] Guard access to
 installedMediaEngines()[0] : [Attachment 33136] patch
In-Reply-To: <bug-27479-0@https.bugs.webkit.org/>
References: <bug-27479-0@https.bugs.webkit.org/>
Message-ID: <20090721025321.DFF4933CFF44@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27479: Guard access to installedMediaEngines()[0]
https://bugs.webkit.org/show_bug.cgi?id=27479

Attachment 33136: patch
https://bugs.webkit.org/attachment.cgi?id=33136&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
r=me

From bugzilla-daemon at webkit.org  Mon Jul 20 19:55:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:55:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27479] Guard access to
 installedMediaEngines()[0] : [Attachment 33138] patch
In-Reply-To: <bug-27479-0@https.bugs.webkit.org/>
References: <bug-27479-0@https.bugs.webkit.org/>
Message-ID: <20090721025505.AE00733CFF7F@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27479: Guard access to installedMediaEngines()[0]
https://bugs.webkit.org/show_bug.cgi?id=27479

Attachment 33138: patch
https://bugs.webkit.org/attachment.cgi?id=33138&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:57:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:57:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27466] Search boxes should
 fallback when the RenderTheme doesn't deal with them : [Attachment 33139]
 patch
In-Reply-To: <bug-27466-0@https.bugs.webkit.org/>
References: <bug-27466-0@https.bugs.webkit.org/>
Message-ID: <20090721025706.1DF8733CFFC8@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27466: Search boxes should fallback when the RenderTheme doesn't deal with
them
https://bugs.webkit.org/show_bug.cgi?id=27466

Attachment 33139: patch
https://bugs.webkit.org/attachment.cgi?id=33139&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 19:57:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:57:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27479] Guard access to
 installedMediaEngines()[0] : [Attachment 33138] patch
In-Reply-To: <bug-27479-0@https.bugs.webkit.org/>
References: <bug-27479-0@https.bugs.webkit.org/>
Message-ID: <20090721025717.7208833CFFDA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27479: Guard access to installedMediaEngines()[0]
https://bugs.webkit.org/show_bug.cgi?id=27479

Attachment 33138: patch
https://bugs.webkit.org/attachment.cgi?id=33138&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Ok.  A coupel things to fix when landing.

The layout test should self-document (i.e. say something like: "PASSED -- crash
using Audio with no installed engines bug 27479")

The test needs a -expected.txt file from a layout tests run.

empty.wav belongs in the resources/ subdirectory.

You can fix those when landing.

Thanks!

From bugzilla-daemon at webkit.org  Mon Jul 20 19:59:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 19:59:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27466] Search boxes should
 fallback when the RenderTheme doesn't deal with them : [Attachment 33139]
 patch
In-Reply-To: <bug-27466-0@https.bugs.webkit.org/>
References: <bug-27466-0@https.bugs.webkit.org/>
Message-ID: <20090721025944.1EBA833D0024@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Langley <agl at chromium.org>'s
request for review:
Bug 27466: Search boxes should fallback when the RenderTheme doesn't deal with
them
https://bugs.webkit.org/show_bug.cgi?id=27466

Attachment 33139: patch
https://bugs.webkit.org/attachment.cgi?id=33139&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Your changelog is unclear.

This is already covered by many layout tests.  It's just that chromium layout
test results are not stored in the webkit tree.

Your comment currently sounds like you're adding new tests, but only to the
chromium tree, which makes no sense. ;)

please adjust the commnet when landing.

From bugzilla-daemon at webkit.org  Mon Jul 20 20:02:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 20:02:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27478] All
 DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject :
 [Attachment 33135] patch
In-Reply-To: <bug-27478-0@https.bugs.webkit.org/>
References: <bug-27478-0@https.bugs.webkit.org/>
Message-ID: <20090721030248.1437D33D0058@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27478: All DOMConstructorObjects should hold a pointer to the
JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

Attachment 33135: patch
https://bugs.webkit.org/attachment.cgi?id=33135&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 20:02:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 20:02:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27478] All
 DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject :
 [Attachment 33140] Update patch
In-Reply-To: <bug-27478-0@https.bugs.webkit.org/>
References: <bug-27478-0@https.bugs.webkit.org/>
Message-ID: <20090721030251.C9A7833D0069@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27478: All DOMConstructorObjects should hold a pointer to the
JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

Attachment 33140: Update patch
https://bugs.webkit.org/attachment.cgi?id=33140&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 20:13:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 20:13:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24818] [GTK] http auth dialog
 pops up twice after a cancelled atempt : [Attachment 33117]
 drop-workaround.patch
In-Reply-To: <bug-24818-0@https.bugs.webkit.org/>
References: <bug-24818-0@https.bugs.webkit.org/>
Message-ID: <20090721031351.535B233D0195@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 24818: [GTK] http auth dialog pops up twice after a cancelled atempt
https://bugs.webkit.org/show_bug.cgi?id=24818

Attachment 33117: drop-workaround.patch
https://bugs.webkit.org/attachment.cgi?id=33117&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 20:20:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 20:20:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25509] [GTK] Missing
 accelerator in authentication dialog : [Attachment 33116]
 webkit-bug-25509-add-accelerator
In-Reply-To: <bug-25509-0@https.bugs.webkit.org/>
References: <bug-25509-0@https.bugs.webkit.org/>
Message-ID: <20090721032016.5C8ED33D022B@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 25509: [GTK] Missing accelerator in authentication dialog
https://bugs.webkit.org/show_bug.cgi?id=25509

Attachment 33116: webkit-bug-25509-add-accelerator
https://bugs.webkit.org/attachment.cgi?id=33116&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
As of
http://library.gnome.org/devel/hig-book/stable/controls-check-boxes.html.en...

From bugzilla-daemon at webkit.org  Mon Jul 20 20:51:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 20:51:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32991] Fix weak handle
 issue
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090721035100.8CD6733D04DA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32991: Fix weak handle issue
https://bugs.webkit.org/attachment.cgi?id=32991&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Re-nominating this patch because I can't seem to reproduce the issue with a DOM
event handler.	I'm not sure this is testable without the rest of the extension
system.

From bugzilla-daemon at webkit.org  Mon Jul 20 21:41:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 21:41:41 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25463] Desktop Notifications
 API : [Attachment 32344] Notifications API, Core & JSC Bindings
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090721044141.B983433D0999@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 32344: Notifications API, Core & JSC Bindings
https://bugs.webkit.org/attachment.cgi?id=32344&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
This is looking much better! I still have some comments that I think need
addressing. The main substantive issue is the dispatch logic still being buggy
in various ways, and I also think there is a lot of unnecessary use of custom
bindings which could be manual. r- to address remaining issues. I suggested
test case ideas that could verify correctness of event dispatch logic. I'd also
be happy to help further by email or IRC, or I could even try to make full test
cases showing the bugs if my descriptions are too vague. r- for remaining
issues.

> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 45576)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,15 @@
> +2009-07-06  John Gregg  <johnnyg at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Desktop Notifications API
> +	   https://bugs.webkit.org/show_bug.cgi?id=25463
> +
> +	   Adds ENABLE_NOTIFICATION flag.
> +
> +	   * Configurations/FeatureDefines.xcconfig:
> +	   * wtf/Platform.h:
> +
>  2009-07-06  Ada Chan  <adachan at apple.com>
>  
>	   Reviewed by Darin Adler and Mark Rowe.
> Index: JavaScriptCore/Configurations/FeatureDefines.xcconfig
> ===================================================================
> --- JavaScriptCore/Configurations/FeatureDefines.xcconfig	(revision
45574)
> +++ JavaScriptCore/Configurations/FeatureDefines.xcconfig	(working copy)
> @@ -37,6 +37,7 @@ ENABLE_FILTERS = ;
>  ENABLE_GEOLOCATION = ;
>  ENABLE_ICONDATABASE = ENABLE_ICONDATABASE;
>  ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER;
> +ENABLE_NOTIFICATIONS = ;
>  ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS;
>  ENABLE_SVG = ENABLE_SVG;
>  ENABLE_SVG_ANIMATION = ENABLE_SVG_ANIMATION;
> @@ -51,4 +52,4 @@ ENABLE_WORKERS = ENABLE_WORKERS;
>  ENABLE_XPATH = ENABLE_XPATH;
>  ENABLE_XSLT = ENABLE_XSLT;
>  
> -FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_DATABASE) $(ENABLE_DOM_STORAGE) $(ENABLE_FILTERS)
$(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER)
$(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION)
$(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS)
$(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WML)
$(ENABLE_WORKERS) $(ENABLE_XPATH) $(ENABLE_XSLT);
> +FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_DATABASE) $(ENABLE_DOM_STORAGE) $(ENABLE_FILTERS)
$(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER)
$(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_SVG)
$(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS)
$(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE)
$(ENABLE_VIDEO) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XPATH) $(ENABLE_XSLT);

> Index: JavaScriptCore/wtf/Platform.h
> ===================================================================
> --- JavaScriptCore/wtf/Platform.h	(revision 45574)
> +++ JavaScriptCore/wtf/Platform.h	(working copy)
> @@ -514,6 +514,10 @@
>  #define ENABLE_GEOLOCATION 0
>  #endif
>  
> +#if !defined(ENABLE_NOTIFICATIONS)
> +#define ENABLE_NOTIFICATIONS 0
> +#endif
> +
>  #if !defined(ENABLE_TEXT_CARET)
>  #define ENABLE_TEXT_CARET 1
>  #endif
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 45576)
> +++ WebCore/ChangeLog (working copy)
> @@ -1,3 +1,105 @@
> +2009-07-06  John Gregg  <johnnyg at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Desktop Notifications API
> +	   https://bugs.webkit.org/show_bug.cgi?id=25463
> +
> +	   Adds an implementation of desktop notifications, behind the
compile-time
> +	   flag ENABLE(NOTIFICATIONS).	This code simply relays calls on the
JavaScript
> +	   API through a NotificationProvider interface, which must provide the
services
> +	   to actually notify the user and manage the desktop.	This provider
is injected
> +	   into WebKit through the ChromeClient for normal page contexts and
through the
> +	   WorkerThread for worker contexts.
> +
> +	   A permissions API is defined on a per-origin basis, which allows a
web page
> +	   to check if its origin is allowed to show desktop notifications, and
to request
> +	   permission for its origin.
> +
> +	   * Configurations/FeatureDefines.xcconfig:
> +	   * DerivedSources.cpp:
> +	   * DerivedSources.make:
> +	   * GNUmakefile.am:
> +	   * WebCore.vcproj/WebCore.vcproj:
> +	   * WebCore.vcproj/WebCoreCommon.vsprops:
> +	   * WebCore.xcodeproj/project.pbxproj:
> +	   * bindings/js/JSDOMWindowCustom.cpp:
> +	   (WebCore::JSDOMWindow::notifications):
> +	   * bindings/js/JSDesktopNotificationsCustom.cpp: Added.
> +	   (WebCore::JSNotificationCenter::createHTMLNotification):
> +	   (WebCore::JSNotificationCenter::createNotification):
> +	   (WebCore::JSNotificationCenter::checkPermission):
> +	   (WebCore::JSNotificationCenter::requestPermission):
> +	   * loader/EmptyClients.h:
> +	   (WebCore::EmptyChromeClient::notificationProvider):
> +	   * notifications: Added.
> +	   * notifications/Notification.cpp: Added.
> +	   (WebCore::Notification::Notification):
> +	   (WebCore::Notification::~Notification):
> +	   (WebCore::Notification::show):
> +	   (WebCore::Notification::cancel):
> +	   (WebCore::Notification::dispatchDisplayEvent):
> +	   (WebCore::Notification::dispatchErrorEvent):
> +	   (WebCore::Notification::dispatchCloseEvent):
> +	   (WebCore::Notification::addEventListener):
> +	   (WebCore::Notification::removeEventListener):
> +	   (WebCore::Notification::dispatchEvent):
> +	   (WebCore::Notification::display):
> +	   (WebCore::Notification::error):
> +	   (WebCore::Notification::close):
> +	   * notifications/Notification.h: Added.
> +	   (WebCore::Notification::create):
> +	   (WebCore::Notification::isHTML):
> +	   (WebCore::Notification::url):
> +	   (WebCore::Notification::contents):
> +	   (WebCore::Notification::ondisplay):
> +	   (WebCore::Notification::setOndisplay):
> +	   (WebCore::Notification::onerror):
> +	   (WebCore::Notification::setOnerror):
> +	   (WebCore::Notification::onclose):
> +	   (WebCore::Notification::setOnclose):
> +	   (WebCore::Notification::scriptExecutionContext):
> +	   (WebCore::Notification::refEventTarget):
> +	   (WebCore::Notification::derefEventTarget):
> +	   * notifications/Notification.idl: Added.
> +	   * notifications/NotificationCenter.cpp: Added.
> +	   (WebCore::NotificationCenter::NotificationCenter):
> +	   (WebCore::NotificationCenter::checkPermission):
> +	   (WebCore::NotificationCenter::requestPermission):
> +	   * notifications/NotificationCenter.h: Added.
> +	   (WebCore::NotificationCenter::create):
> +	   (WebCore::NotificationCenter::createHTMLNotification):
> +	   (WebCore::NotificationCenter::createNotification):
> +	   (WebCore::NotificationCenter::context):
> +	   (WebCore::NotificationCenter::provider):
> +	   * notifications/NotificationCenter.idl: Added.
> +	   * notifications/NotificationContents.h: Added.
> +	   (WebCore::NotificationContents::NotificationContents):
> +	   (WebCore::NotificationContents::icon):
> +	   (WebCore::NotificationContents::title):
> +	   (WebCore::NotificationContents::body):
> +	   * notifications/NotificationProvider.h: Added.
> +	   (WebCore::NotificationProvider::):
> +	   (WebCore::NotificationProvider::~NotificationProvider):
> +	   * page/Chrome.cpp:
> +	   (WebCore::Chrome::notificationProvider):
> +	   * page/Chrome.h:
> +	   * page/ChromeClient.h:
> +	   * page/DOMWindow.cpp:
> +	   (WebCore::DOMWindow::clear):
> +	   (WebCore::DOMWindow::webkitNotifications):
> +	   * page/DOMWindow.h:
> +	   * page/DOMWindow.idl:
> +	   * page/Page.h:
> +	   * workers/WorkerContext.cpp:
> +	   (WebCore::WorkerContext::~WorkerContext):
> +	   (WebCore::WorkerContext::webkitNotifications):
> +	   * workers/WorkerContext.h:
> +	   * workers/WorkerContext.idl:
> +	   * workers/WorkerThread.h:
> +	   (WebCore::WorkerThread::getNotificationProvider):
> +	   (WebCore::WorkerThread::setNotificationProvider):
> +
>  2009-07-06  Eric Carlson  <eric.carlson at apple.com>
>  
>	   Reviewed by Simon Fraser.
> Index: WebCore/DerivedSources.cpp
> ===================================================================
> --- WebCore/DerivedSources.cpp	(revision 45574)
> +++ WebCore/DerivedSources.cpp	(working copy)
> @@ -162,6 +162,8 @@
>  #include "JSNodeIterator.cpp"
>  #include "JSNodeList.cpp"
>  #include "JSNotation.cpp"
> +#include "JSNotificationCenter.cpp"
> +#include "JSNotification.cpp"
>  #include "JSOverflowEvent.cpp"
>  #include "JSPlugin.cpp"
>  #include "JSPluginArray.cpp"
> Index: WebCore/DerivedSources.make
> ===================================================================
> --- WebCore/DerivedSources.make	(revision 45574)
> +++ WebCore/DerivedSources.make	(working copy)
> @@ -34,6 +34,7 @@ VPATH = \
>      $(WebCore)/html \
>      $(WebCore)/inspector \
>      $(WebCore)/loader/appcache \
> +    $(WebCore)/notifications \
>      $(WebCore)/page \
>      $(WebCore)/plugins \
>      $(WebCore)/storage \
> @@ -188,6 +189,8 @@ DOM_CLASSES = \
>      NodeIterator \
>      NodeList \
>      Notation \
> +    Notification \
> +    NotificationCenter \
>      OverflowEvent \
>      Plugin \
>      PluginArray \
> @@ -678,7 +681,7 @@ endif
>  # JavaScript bindings
>  
>  GENERATE_BINDINGS = perl -I $(WebCore)/bindings/scripts
$(WebCore)/bindings/scripts/generate-bindings.pl \
> -    --include dom --include html --include css --include page --include xml
--include svg --outputDir .
> +    --include dom --include html --include css --include page --include
notifications --include xml --include svg --outputDir .
>  
>  GENERATE_BINDINGS_SCRIPTS = \
>      bindings/scripts/CodeGenerator.pm \
> Index: WebCore/GNUmakefile.am
> ===================================================================
> --- WebCore/GNUmakefile.am	(revision 45574)
> +++ WebCore/GNUmakefile.am	(working copy)
> @@ -25,6 +25,7 @@ webcore_cppflags += \
>	-I$(srcdir)/WebCore/loader/appcache \
>	-I$(srcdir)/WebCore/loader/archive \
>	-I$(srcdir)/WebCore/loader/icon \
> +	-I$(srcdir)/WebCore/notifications \
>	-I$(srcdir)/WebCore/page \
>	-I$(srcdir)/WebCore/page/animation \
>	-I$(srcdir)/WebCore/platform \
> @@ -231,6 +232,8 @@ IDL_BINDINGS += \
>	WebCore/html/VoidCallback.idl \
>	WebCore/inspector/JavaScriptCallFrame.idl \
>	WebCore/inspector/InspectorController.idl \
> +	WebCore/notifications/Notification.idl \
> +	WebCore/notifications/NotificationCenter.idl \
>	WebCore/page/BarInfo.idl \
>	WebCore/page/Console.idl \
>	WebCore/page/Coordinates.idl \
> @@ -2428,6 +2431,24 @@ webcoregtk_sources += \
>	WebCore/platform/gtk/GeolocationServiceGtk.h
>  endif # END ENABLE_GEOLOCATION
>  
> +# ----
> +# Notifications support
> +# ----
> +if ENABLE_NOTIFICATIONS
> +FEATURE_DEFINES_JAVASCRIPT += ENABLE_NOTIFICATIONS=1
> +
> +webcore_cppflags += \
> +	-DENABLE_NOTIFICATIONS=1
> +
> +webcore_sources += \
> +	WebCore/notifications/Notification.cpp \
> +	WebCore/notifications/Notification.h \
> +	WebCore/notifications/NotificationCenter.cpp \
> +	WebCore/notifications/NotificationCenter.h \
> +	WebCore/notifications/NotificationProvider.h \
> +	WebCore/notifications/NotificationContents.h
> +
> +endif # END ENABLE_NOTIFICATIONS
>  
>  # ----
>  # SVG Support
> Index: WebCore/Configurations/FeatureDefines.xcconfig
> ===================================================================
> --- WebCore/Configurations/FeatureDefines.xcconfig	(revision 45574)
> +++ WebCore/Configurations/FeatureDefines.xcconfig	(working copy)
> @@ -38,6 +38,7 @@ ENABLE_FILTERS = ;
>  ENABLE_GEOLOCATION = ;
>  ENABLE_ICONDATABASE = ENABLE_ICONDATABASE;
>  ENABLE_JAVASCRIPT_DEBUGGER = ENABLE_JAVASCRIPT_DEBUGGER;
> +ENABLE_NOTIFICATIONS = ;
>  ENABLE_OFFLINE_WEB_APPLICATIONS = ENABLE_OFFLINE_WEB_APPLICATIONS;
>  ENABLE_SVG = ENABLE_SVG;
>  ENABLE_SVG_ANIMATION = ENABLE_SVG_ANIMATION;
> @@ -52,4 +53,5 @@ ENABLE_WORKERS = ENABLE_WORKERS;
>  ENABLE_XPATH = ENABLE_XPATH;
>  ENABLE_XSLT = ENABLE_XSLT;
>  
> -FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DOM_STORAGE) $(ENABLE_FILTERS)
$(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER)
$(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_SVG) $(ENABLE_SVG_ANIMATION)
$(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS) $(ENABLE_SVG_FONTS)
$(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE) $(ENABLE_VIDEO) $(ENABLE_WML)
$(ENABLE_WORKERS) $(ENABLE_XPATH) $(ENABLE_XSLT);
> +FEATURE_DEFINES = $(ENABLE_3D_RENDERING) $(ENABLE_CHANNEL_MESSAGING)
$(ENABLE_DATABASE) $(ENABLE_DATAGRID) $(ENABLE_DOM_STORAGE) $(ENABLE_FILTERS)
$(ENABLE_GEOLOCATION) $(ENABLE_ICONDATABASE) $(ENABLE_JAVASCRIPT_DEBUGGER)
$(ENABLE_NOTIFICATIONS) $(ENABLE_OFFLINE_WEB_APPLICATIONS) $(ENABLE_SVG)
$(ENABLE_SVG_ANIMATION) $(ENABLE_SVG_AS_IMAGE) $(ENABLE_SVG_DOM_OBJC_BINDINGS)
$(ENABLE_SVG_FONTS) $(ENABLE_SVG_FOREIGN_OBJECT) $(ENABLE_SVG_USE)
$(ENABLE_VIDEO) $(ENABLE_WML) $(ENABLE_WORKERS) $(ENABLE_XPATH) $(ENABLE_XSLT);

> +
> Index: WebCore/WebCore.vcproj/WebCore.vcproj
> ===================================================================
> --- WebCore/WebCore.vcproj/WebCore.vcproj	(revision 45574)
> +++ WebCore/WebCore.vcproj/WebCore.vcproj	(working copy)
> @@ -67,7 +67,7 @@
>			/>
>			<Tool
>				Name="VCPostBuildEventTool"
> -				CommandLine="mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders&quot;&#x0D;&#x0A;mkd
ir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\bindings&quot;&#x0D;
&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\parser&quot;&#x0D;&#
x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\runtime&quot;&#x0D;&
#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\masm&quot;&#x0D;&#x0
A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\pcre&quot;&#x0D;&#x0
A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\profiler&quot;&#x0D;
&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wrec&quot;&#x0D;&#x0
A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf&quot;&#x0D;&#x0A
;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode&quot;&#x
0D;&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode\icu&quot
;&#x0D;&#x0A;&#x0D;&#x0A;xcopy /y /d &quot;$(ProjectDir)..\config.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(WebKitOutputDir)\obj\WebCore\DerivedSources\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\accessibility\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\accessibility\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\inspector\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\appcache\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\archive\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\archive\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\icon\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\history\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\history\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\html\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\css\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\animation\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\transforms\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\opentype\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\text\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\network\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\network\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\network\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\sql\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\cairo\cairo\src\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\bindings\js\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\page\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\page\animation\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\page\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\bridge\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\plugins\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\plugins\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\rendering\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\rendering\style\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\editing\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\dom\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\xml\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\svg\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\storage\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\workers\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)\..\ForwardingHeaders\bindings\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\bindings&quot;&#x0D;
&#x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\parser\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\parser&quot;&#x0D;&#
x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\runtime\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\runtime&quot;&#x0D;&
#x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\masm\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\masm&quot;&#x0D;&#x0
A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\pcre\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\pcre&quot;&#x0D;&#x0
A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\profiler\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\profiler&quot;&#x0D;
&#x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\wrec\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wrec&quot;&#x0D;&#x0
A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\wtf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf&quot;&#x0D;&#x0A
;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\wtf\unicode\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode&quot;&#x
0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)\..\ForwardingHeaders\wtf\unicode\icu\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode\icu&quot
;&#x0D;&#x0A;&#x0D;&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\bin\WebKit.resources\inspector&quot;&#x0D;&#x0A;xcopy
/y /d /s /exclude:xcopy.excludes
&quot;$(ProjectDir)\..\inspector\front-end\*&quot;
&quot;$(WebKitOutputDir)\bin\WebKit.resources\inspector&quot;&#x0D;&#x0A;mkdir
2&gt;NUL
&quot;$(WebKitOutputDir)\bin\WebKit.resources\en.lproj&quot;&#x0D;&#x0A;xcopy
/y /d /s /exclude:xcopy.excludes
&quot;$(ProjectDir)\..\English.lproj\localizedStrings.js&quot;
&quot;$(WebKitOutputDir)\bin\WebKit.resources\en.lproj&quot;&#x0D;&#x0A;&#x0D;&
#x0A;if exist &quot;$(WebKitOutputDir)\buildfailed&quot; del
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;"
> +				CommandLine="mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders&quot;&#x0D;&#x0A;mkd
ir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\bindings&quot;&#x0D;
&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\parser&quot;&#x0D;&#
x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\runtime&quot;&#x0D;&
#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\masm&quot;&#x0D;&#x0
A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\pcre&quot;&#x0D;&#x0
A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\profiler&quot;&#x0D;
&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wrec&quot;&#x0D;&#x0
A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf&quot;&#x0D;&#x0A
;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode&quot;&#x
0D;&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode\icu&quot
;&#x0D;&#x0A;&#x0D;&#x0A;xcopy /y /d &quot;$(ProjectDir)..\config.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(WebKitOutputDir)\obj\WebCore\DerivedSources\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\accessibility\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\accessibility\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\inspector\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\appcache\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\archive\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\archive\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\loader\icon\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\history\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\history\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\html\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\notifications\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\css\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\animation\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\transforms\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\graphics\opentype\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\text\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\network\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\network\cf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\network\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\sql\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\platform\cairo\cairo\src\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\bindings\js\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\page\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\page\animation\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\page\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\bridge\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\plugins\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\plugins\win\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\rendering\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\rendering\style\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\editing\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\dom\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\xml\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\svg\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\storage\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)..\workers\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore&quot;&#x0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)\..\ForwardingHeaders\bindings\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\bindings&quot;&#x0D;
&#x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\parser\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\parser&quot;&#x0D;&#
x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\runtime\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\runtime&quot;&#x0D;&
#x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\masm\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\masm&quot;&#x0D;&#x0
A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\pcre\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\pcre&quot;&#x0D;&#x0
A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\profiler\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\profiler&quot;&#x0D;
&#x0A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\wrec\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wrec&quot;&#x0D;&#x0
A;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\wtf\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf&quot;&#x0D;&#x0A
;xcopy /y /d &quot;$(ProjectDir)\..\ForwardingHeaders\wtf\unicode\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode&quot;&#x
0D;&#x0A;xcopy /y /d
&quot;$(ProjectDir)\..\ForwardingHeaders\wtf\unicode\icu\*.h&quot;
&quot;$(WebKitOutputDir)\include\WebCore\ForwardingHeaders\wtf\unicode\icu&quot
;&#x0D;&#x0A;&#x0D;&#x0A;mkdir 2&gt;NUL
&quot;$(WebKitOutputDir)\bin\WebKit.resources\inspector&quot;&#x0D;&#x0A;xcopy
/y /d /s /exclude:xcopy.excludes
&quot;$(ProjectDir)\..\inspector\front-end\*&quot;
&quot;$(WebKitOutputDir)\bin\WebKit.resources\inspector&quot;&#x0D;&#x0A;mkdir
2&gt;NUL
&quot;$(WebKitOutputDir)\bin\WebKit.resources\en.lproj&quot;&#x0D;&#x0A;xcopy
/y /d /s /exclude:xcopy.excludes
&quot;$(ProjectDir)\..\English.lproj\localizedStrings.js&quot;
&quot;$(WebKitOutputDir)\bin\WebKit.resources\en.lproj&quot;&#x0D;&#x0A;&#x0D;&
#x0A;if exist &quot;$(WebKitOutputDir)\buildfailed&quot; del
&quot;$(WebKitOutputDir)\buildfailed&quot;&#x0D;&#x0A;"
>			/>
>		</Configuration>
>		<Configuration
> @@ -7190,6 +7190,102 @@
>				>
>			</File>
>			<File
> +			       
RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSNotificati
on.cpp"
> +				>
> +				<FileConfiguration
> +					Name="Debug|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Release|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_Internal|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_Cairo|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Release_Cairo|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +			</File>
> +			<File
> +			       
RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSNotificati
on.h"
> +				>
> +			</File>
> +			<File
> +			       
RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSNotificati
onCenter.cpp"
> +				>
> +				<FileConfiguration
> +					Name="Debug|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Release|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_Internal|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Debug_Cairo|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +				<FileConfiguration
> +					Name="Release_Cairo|Win32"
> +					ExcludedFromBuild="true"
> +					>
> +					<Tool
> +						Name="VCCLCompilerTool"
> +					/>
> +				</FileConfiguration>
> +			</File>
> +			<File
> +			       
RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSNotificati
onCenter.h"
> +				>
> +			</File>
> +			<File
>			       
RelativePath="$(WebKitOutputDir)\obj\$(ProjectName)\DerivedSources\JSOverflowEv
ent.cpp"
>				>
>				<FileConfiguration
> @@ -23832,6 +23928,34 @@
>			</File>
>		</Filter>
>		<Filter
> +			Name="notifications"
> +			>
> +			<File
> +			       
RelativePath="..\notifications\Notification.cpp"
> +				>
> +			</File>
> +			<File
> +				RelativePath="..\notifications\Notification.h"
> +				>
> +			</File>
> +			<File
> +			       
RelativePath="..\notifications\NotificationCenter.cpp"
> +				>
> +			</File>
> +			<File
> +			       
RelativePath="..\notifications\NotificationCenter.h"
> +				>
> +			</File>
> +			<File
> +			       
RelativePath="..\notifications\NotificationContents.h"
> +				>
> +			</File>
> +			<File
> +			       
RelativePath="..\notifications\NotificationProvider.h"
> +				>
> +			</File>
> +		</Filter>
> +		<Filter
>			Name="editing"
>			>
>			<File
> @@ -28066,6 +28190,10 @@
>					>
>				</File>
>				<File
> +				       
RelativePath="..\bindings\js\JSDesktopNotificationsCustom.cpp"
> +					>
> +				</File>
> +				<File
>				       
RelativePath="..\bindings\js\JSDocumentCustom.cpp"
>					>
>				</File>
> Index: WebCore/WebCore.vcproj/WebCoreCommon.vsprops
> ===================================================================
> --- WebCore/WebCore.vcproj/WebCoreCommon.vsprops	(revision 45574)
> +++ WebCore/WebCore.vcproj/WebCoreCommon.vsprops	(working copy)
> @@ -7,7 +7,7 @@
>	>
>	<Tool
>		Name="VCCLCompilerTool"
> -	       
AdditionalIncludeDirectories="&quot;$(ProjectDir)..\&quot;;&quot;$(ProjectDir).
.&quot;;&quot;$(ProjectDir)..\accessibility&quot;;&quot;$(ProjectDir)..\accessi
bility\win&quot;;&quot;$(ProjectDir)..\bridge&quot;;&quot;$(ProjectDir)..\bridg
e\c&quot;;&quot;$(ProjectDir)..\css&quot;;&quot;$(ProjectDir)..\editing&quot;;&
quot;$(ProjectDir)..\rendering&quot;;&quot;$(ProjectDir)..\rendering\style&quot
;;&quot;$(ProjectDir)..\bindings\js&quot;;&quot;$(ProjectDir)..\dom&quot;;&quot
;$(ProjectDir)..\dom\default&quot;;&quot;$(ProjectDir)..\history&quot;;&quot;$(
ProjectDir)..\html&quot;;&quot;$(ProjectDir)..\inspector&quot;;&quot;$(ProjectD
ir)..\loader&quot;;&quot;$(ProjectDir)..\loader\appcache&quot;;&quot;$(ProjectD
ir)..\loader\archive&quot;;&quot;$(ProjectDir)..\loader\archive\cf&quot;;&quot;
$(ProjectDir)..\loader\icon&quot;;&quot;$(ProjectDir)..\page&quot;;&quot;$(Proj
ectDir)..\page\animation&quot;;&quot;$(ProjectDir)..\page\win&quot;;&quot;$(Pro
jectDir)..\platform&quot;;&quot;$(ProjectDir)..\platform\animation&quot;;&quot;
$(ProjectDir)..\platform\sql&quot;;&quot;$(ProjectDir)..\platform\win&quot;;&qu
ot;$(ProjectDir)..\platform\network&quot;;&quot;$(ProjectDir)..\platform\networ
k\win&quot;;&quot;$(ProjectDir)..\platform\cf&quot;;&quot;$(ProjectDir)..\platf
orm\graphics&quot;;&quot;$(ProjectDir)..\platform\graphics\opentype&quot;;&quot
;$(ProjectDir)..\platform\graphics\transforms&quot;;&quot;$(ProjectDir)..\platf
orm\text&quot;;&quot;$(ProjectDir)..\platform\graphics\win&quot;;&quot;$(Projec
tDir)..\xml&quot;;&quot;$(WebKitOutputDir)\obj\WebCore\DerivedSources&quot;;&qu
ot;$(ProjectDir)..\plugins&quot;;&quot;$(ProjectDir)..\plugins\win&quot;;&quot;
$(ProjectDir)..\svg\graphics&quot;;&quot;$(ProjectDir)..\svg\graphics\filters&q
uot;;&quot;$(ProjectDir)..\svg&quot;;&quot;$(ProjectDir)..\wml&quot;;&quot;$(Pr
ojectDir)..\storage&quot;;&quot;$(ProjectDir)..\workers&quot;;&quot;$(WebKitOut
putDir)\include&quot;;&quot;$(WebKitOutputDir)\include\JavaScriptCore&quot;;&qu
ot;$(ProjectDir)..\ForwardingHeaders&quot;;&quot;$(WebKitLibrariesDir)\include&
quot;;&quot;$(WebKitLibrariesDir)\include\icu&quot;;&quot;$(WebKitLibrariesDir)
\include\iconv&quot;;&quot;$(WebKitLibrariesDir)\include\pthreads&quot;;&quot;$
(WebKitLibrariesDir)\include\sqlite&quot;;&quot;$(WebKitLibrariesDir)\include\J
avaScriptCore&quot;;&quot;$(WebKitLibrariesDir)\Include\CoreFoundation\OSXCompa
tibilityHeaders&quot;;&quot;$(WebKitLibrariesDir)\Include\CoreFoundation\OSXCom
patibilityHeaders\GNUCompatibility&quot;;&quot;$(ProjectDir)..\svg\animation&qu
ot;"
> +	       
AdditionalIncludeDirectories="&quot;$(ProjectDir)..\&quot;;&quot;$(ProjectDir).
.&quot;;&quot;$(ProjectDir)..\accessibility&quot;;&quot;$(ProjectDir)..\accessi
bility\win&quot;;&quot;$(ProjectDir)..\bridge&quot;;&quot;$(ProjectDir)..\bridg
e\c&quot;;&quot;$(ProjectDir)..\css&quot;;&quot;$(ProjectDir)..\editing&quot;;&
quot;$(ProjectDir)..\notifications&quot;;&quot;$(ProjectDir)..\rendering&quot;;
&quot;$(ProjectDir)..\rendering\style&quot;;&quot;$(ProjectDir)..\bindings\js&q
uot;;&quot;$(ProjectDir)..\dom&quot;;&quot;$(ProjectDir)..\dom\default&quot;;&q
uot;$(ProjectDir)..\history&quot;;&quot;$(ProjectDir)..\html&quot;;&quot;$(Proj
ectDir)..\inspector&quot;;&quot;$(ProjectDir)..\loader&quot;;&quot;$(ProjectDir
)..\loader\appcache&quot;;&quot;$(ProjectDir)..\loader\archive&quot;;&quot;$(Pr
ojectDir)..\loader\archive\cf&quot;;&quot;$(ProjectDir)..\loader\icon&quot;;&qu
ot;$(ProjectDir)..\page&quot;;&quot;$(ProjectDir)..\page\animation&quot;;&quot;
$(ProjectDir)..\page\win&quot;;&quot;$(ProjectDir)..\platform&quot;;&quot;$(Pro
jectDir)..\platform\animation&quot;;&quot;$(ProjectDir)..\platform\sql&quot;;&q
uot;$(ProjectDir)..\platform\win&quot;;&quot;$(ProjectDir)..\platform\network&q
uot;;&quot;$(ProjectDir)..\platform\network\win&quot;;&quot;$(ProjectDir)..\pla
tform\cf&quot;;&quot;$(ProjectDir)..\platform\graphics&quot;;&quot;$(ProjectDir
)..\platform\graphics\opentype&quot;;&quot;$(ProjectDir)..\platform\graphics\tr
ansforms&quot;;&quot;$(ProjectDir)..\platform\text&quot;;&quot;$(ProjectDir)..\
platform\graphics\win&quot;;&quot;$(ProjectDir)..\xml&quot;;&quot;$(WebKitOutpu
tDir)\obj\WebCore\DerivedSources&quot;;&quot;$(ProjectDir)..\plugins&quot;;&quo
t;$(ProjectDir)..\plugins\win&quot;;&quot;$(ProjectDir)..\svg\graphics&quot;;&q
uot;$(ProjectDir)..\svg\graphics\filters&quot;;&quot;$(ProjectDir)..\svg&quot;;
&quot;$(ProjectDir)..\wml&quot;;&quot;$(ProjectDir)..\storage&quot;;&quot;$(Pro
jectDir)..\workers&quot;;&quot;$(WebKitOutputDir)\include&quot;;&quot;$(WebKitO
utputDir)\include\JavaScriptCore&quot;;&quot;$(ProjectDir)..\ForwardingHeaders&
quot;;&quot;$(WebKitLibrariesDir)\include&quot;;&quot;$(WebKitLibrariesDir)\inc
lude\icu&quot;;&quot;$(WebKitLibrariesDir)\include\iconv&quot;;&quot;$(WebKitLi
brariesDir)\include\pthreads&quot;;&quot;$(WebKitLibrariesDir)\include\sqlite&q
uot;;&quot;$(WebKitLibrariesDir)\include\JavaScriptCore&quot;;&quot;$(WebKitLib
rariesDir)\Include\CoreFoundation\OSXCompatibilityHeaders&quot;;&quot;$(WebKitL
ibrariesDir)\Include\CoreFoundation\OSXCompatibilityHeaders\GNUCompatibility&qu
ot;;&quot;$(ProjectDir)..\svg\animation&quot;"
>	       
PreprocessorDefinitions="__WIN32__;WEBCORE_CONTEXT_MENUS;ENABLE_DATABASE;ENABLE
_DATAGRID;ENABLE_DOM_STORAGE;ENABLE_ICONDATABASE;ENABLE_OFFLINE_WEB_APPLICATION
S;ENABLE_SVG;ENABLE_SVG_ANIMATION;ENABLE_SVG_AS_IMAGE;ENABLE_SVG_FONTS;ENABLE_S
VG_FOREIGN_OBJECT;ENABLE_SVG_USE;ENABLE_WORKERS;ENABLE_XPATH;ENABLE_XSLT"
>		UsePrecompiledHeader="2"
>		PrecompiledHeaderThrough="WebCorePrefix.h"
> Index: WebCore/WebCore.xcodeproj/project.pbxproj
> ===================================================================
> --- WebCore/WebCore.xcodeproj/project.pbxproj (revision 45574)
> +++ WebCore/WebCore.xcodeproj/project.pbxproj (working copy)
> @@ -614,6 +614,10 @@
>		31C0FF4C0E4CEFDD007D6FE5 /* DOMWebKitTransitionEvent.h in
Headers */ = {isa = PBXBuildFile; fileRef = 31C0FF460E4CEFDD007D6FE5 /*
DOMWebKitTransitionEvent.h */; };
>		31C0FF4D0E4CEFDD007D6FE5 /* DOMWebKitTransitionEvent.mm in
Sources */ = {isa = PBXBuildFile; fileRef = 31C0FF470E4CEFDD007D6FE5 /*
DOMWebKitTransitionEvent.mm */; };
>		31C0FF4E0E4CEFDD007D6FE5 /* DOMWebKitTransitionEventInternal.h
in Headers */ = {isa = PBXBuildFile; fileRef = 31C0FF480E4CEFDD007D6FE5 /*
DOMWebKitTransitionEventInternal.h */; };
> +		3390CA550FFC157B00921962 /* NotificationCenter.cpp in Sources
*/ = {isa = PBXBuildFile; fileRef = 3390CA510FFC157B00921962 /*
NotificationCenter.cpp */; };
> +		3390CA560FFC157B00921962 /* NotificationCenter.h in Headers */
= {isa = PBXBuildFile; fileRef = 3390CA520FFC157B00921962 /*
NotificationCenter.h */; };
> +		3390CA570FFC157B00921962 /* NotificationCenter.idl in Resources
*/ = {isa = PBXBuildFile; fileRef = 3390CA530FFC157B00921962 /*
NotificationCenter.idl */; };
> +		3390CA580FFC157B00921962 /* NotificationContents.h in Headers
*/ = {isa = PBXBuildFile; fileRef = 3390CA540FFC157B00921962 /*
NotificationContents.h */; };
>		371F4F400D25B9AF00ECE0D5 /* FontData.h in Headers */ = {isa =
PBXBuildFile; fileRef = 371F4F3E0D25B9AF00ECE0D5 /* FontData.h */; settings =
{ATTRIBUTES = (Private, ); }; };
>		371F4F410D25B9AF00ECE0D5 /* FontData.cpp in Sources */ = {isa =
PBXBuildFile; fileRef = 371F4F3F0D25B9AF00ECE0D5 /* FontData.cpp */; };
>		371F4FFC0D25E7F300ECE0D5 /* SegmentedFontData.h in Headers */ =
{isa = PBXBuildFile; fileRef = 371F4FFA0D25E7F300ECE0D5 /* SegmentedFontData.h
*/; };
> @@ -5542,6 +5546,14 @@
>		31C0FF460E4CEFDD007D6FE5 /* DOMWebKitTransitionEvent.h */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h;
path = DOMWebKitTransitionEvent.h; sourceTree = "<group>"; };
>		31C0FF470E4CEFDD007D6FE5 /* DOMWebKitTransitionEvent.mm */ =
{isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.cpp.objcpp; path = DOMWebKitTransitionEvent.mm; sourceTree =
"<group>"; };
>		31C0FF480E4CEFDD007D6FE5 /* DOMWebKitTransitionEventInternal.h
*/ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType =
sourcecode.c.h; path = DOMWebKitTransitionEventInternal.h; sourceTree =
"<group>"; };
> +		333F704E0FB49CA2008E12A6 /* Notification.idl */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name =
Notification.idl; path = notifications/Notification.idl; sourceTree =
"<group>"; };
> +		333F704F0FB49CA2008E12A6 /* Notification.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
Notification.h; path = notifications/Notification.h; sourceTree = "<group>"; };

> +		333F70500FB49CA2008E12A6 /* Notification.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = Notification.cpp; path = notifications/Notification.cpp; sourceTree =
"<group>"; };
> +		333F70510FB49CA2008E12A6 /* NotificationProvider.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
NotificationProvider.h; path = notifications/NotificationProvider.h; sourceTree
= "<group>"; };
> +		3390CA510FFC157B00921962 /* NotificationCenter.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
name = NotificationCenter.cpp; path = notifications/NotificationCenter.cpp;
sourceTree = "<group>"; };
> +		3390CA520FFC157B00921962 /* NotificationCenter.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
NotificationCenter.h; path = notifications/NotificationCenter.h; sourceTree =
"<group>"; };
> +		3390CA530FFC157B00921962 /* NotificationCenter.idl */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = text; name =
NotificationCenter.idl; path = notifications/NotificationCenter.idl; sourceTree
= "<group>"; };
> +		3390CA540FFC157B00921962 /* NotificationContents.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; name =
NotificationContents.h; path = notifications/NotificationContents.h; sourceTree
= "<group>"; };
>		371F4F3E0D25B9AF00ECE0D5 /* FontData.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
FontData.h; sourceTree = "<group>"; };
>		371F4F3F0D25B9AF00ECE0D5 /* FontData.cpp */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp;
path = FontData.cpp; sourceTree = "<group>"; };
>		371F4FFA0D25E7F300ECE0D5 /* SegmentedFontData.h */ = {isa =
PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path =
SegmentedFontData.h; sourceTree = "<group>"; };
> @@ -9414,6 +9426,7 @@
>				93EEC1EC09C2877700C515D1 /* html */,
>				1C81B94D0E9732D900266E07 /* inspector */,
>				BCB16BFB0979C38700467741 /* loader */,
> +				333F703D0FB49C16008E12A6 /* notifications */,
>				65BF02180974806300C43196 /* page */,
>				BCF1A5BA097832090061A123 /* platform */,
>				5DCF83690D59157800953BC6 /* plugins */,
> @@ -9884,6 +9897,21 @@
>			name = animation;
>			sourceTree = "<group>";
>		};
> +		333F703D0FB49C16008E12A6 /* notifications */ = {
> +			isa = PBXGroup;
> +			children = (
> +				3390CA510FFC157B00921962 /*
NotificationCenter.cpp */,
> +				3390CA520FFC157B00921962 /*
NotificationCenter.h */,
> +				3390CA530FFC157B00921962 /*
NotificationCenter.idl */,
> +				3390CA540FFC157B00921962 /*
NotificationContents.h */,
> +				333F704E0FB49CA2008E12A6 /* Notification.idl
*/,
> +				333F704F0FB49CA2008E12A6 /* Notification.h */,
> +				333F70500FB49CA2008E12A6 /* Notification.cpp
*/,
> +				333F70510FB49CA2008E12A6 /*
NotificationProvider.h */,
> +			);
> +			name = notifications;
> +			sourceTree = "<group>";
> +		};
>		449195900FBE175B00D9F824 /* Exports */ = {
>			isa = PBXGroup;
>			children = (
> @@ -16917,6 +16945,8 @@
>				BC77D16C0FF19F560070887B /*
JSDataGridColumnList.h in Headers */,
>				BCBCAE370FF19385000762AE /*
DataGridDataSource.h in Headers */,
>				BCBCAE3D0FF19399000762AE /*
JSDataGridDataSource.h in Headers */,
> +				3390CA560FFC157B00921962 /*
NotificationCenter.h in Headers */,
> +				3390CA580FFC157B00921962 /*
NotificationContents.h in Headers */,
>				C50D0E830FF4272900AC2644 /* StorageNamespace.h
in Headers */,
>				BC7DAAEF0FF9615D00CE0138 /*
DOMDataGridDataSource.h in Headers */,
>				B5A684220FFABE9800D24689 /* SQLiteFileSystem.h
in Headers */,
> @@ -17028,6 +17058,7 @@
>				BC77CDA30FEFEB530070887B /*
HTMLDataGridCellElement.idl in Resources */,
>				BC77CF990FF172420070887B /*
DataGridColumnList.idl in Resources */,
>				BC77CF9F0FF172B30070887B /* DataGridColumn.idl
in Resources */,
> +				3390CA570FFC157B00921962 /*
NotificationCenter.idl in Resources */,
>			);
>			runOnlyForDeploymentPostprocessing = 0;
>		};
> @@ -18932,6 +18963,7 @@
>				BCBCAE540FF1A29E000762AE /*
JSHTMLDataGridElementCustom.cpp in Sources */,
>				BC77D1FD0FF28D9B0070887B /*
DataGridColumnList.cpp in Sources */,
>				BC77D2390FF298080070887B /* DataGridColumn.cpp
in Sources */,
> +				3390CA550FFC157B00921962 /*
NotificationCenter.cpp in Sources */,
>				C50D0E820FF4272900AC2644 /*
StorageNamespace.cpp in Sources */,
>				BC7DAAEE0FF9615D00CE0138 /*
DOMDataGridDataSource.cpp in Sources */,
>				B5A684240FFABEAA00D24689 /*
SQLiteFileSystem.cpp in Sources */,
> Index: WebCore/bindings/js/JSDOMWindowCustom.cpp
> ===================================================================
> --- WebCore/bindings/js/JSDOMWindowCustom.cpp (revision 45574)
> +++ WebCore/bindings/js/JSDOMWindowCustom.cpp (working copy)
> @@ -44,6 +44,7 @@
>  #include "JSLocation.h"
>  #include "JSMessageChannelConstructor.h"
>  #include "JSMessagePort.h"
> +#include "JSNotificationCenter.h"
>  #include "JSOptionConstructor.h"
>  #include "JSWebKitCSSMatrixConstructor.h"
>  #include "JSWebKitPointConstructor.h"
> @@ -53,6 +54,7 @@
>  #include "Location.h"
>  #include "MediaPlayer.h"
>  #include "MessagePort.h"
> +#include "NotificationCenter.h"
>  #include "Page.h"
>  #include "PlatformScreen.h"
>  #include "RegisteredEventListener.h"
> @@ -374,6 +376,19 @@ JSValue JSDOMWindow::location(ExecState*
>      return jsLocation;
>  }
>  
> +#if ENABLE(NOTIFICATIONS)
> +JSValue JSDOMWindow::notifications(ExecState* exec) const
> +{
> +    NotificationCenter* notifications = impl()->notifications();
> +    if (DOMObject* wrapper = getCachedDOMObjectWrapper(exec->globalData(),
notifications))
> +	   return wrapper;
> +
> +    JSNotificationCenter* jsNotifications = new (exec)
JSNotificationCenter(getDOMStructure<JSNotificationCenter>(exec,
const_cast<JSDOMWindow*>(this)), notifications);
> +    cacheDOMObjectWrapper(exec->globalData(), notifications,
jsNotifications);
> +    return jsNotifications;
> +}
> +#endif
> +

Why does this need to be a custom binding? Seems like this does basically the
same thing that a manual binding would (except the manual binding would use
toJS() instead of doing the wrapper conversion by hand).

> +
> +JSValue JSNotificationCenter::createHTMLNotification(ExecState* exec, const
ArgList& args)
> +{
> +    ExceptionCode ec = 0;
> +    String url = args.at(0).toString(exec);
> +    JSValue value = toJS(exec, Notification::create(url, impl()->context(),
ec, impl()->provider()));
> +    setDOMException(exec, ec);
> +    return value;
> +}

Why does this need to be a custom binding? Wouldn't it be simpler to give
JSNotificationCenter a createHTMLNotification() method and let the bindings
generator do the work? Also, it looks like this code will use "undefined" for
url if the URL parameter is omitted, instead of an empty string as is the case
with many other DOM APIs. Is that intentional?

> +
> +JSValue JSNotificationCenter::createNotification(ExecState* exec, const
ArgList& args)
> +{
> +    ExceptionCode ec = 0;
> +    NotificationContents contents(args.at(0).toString(exec),
args.at(1).toString(exec), args.at(2).toString(exec));
> +
> +
> +    JSValue value = toJS(exec, Notification::create(contents,
impl()->context(), ec, impl()->provider()));
> +    setDOMException(exec, ec);
> +    return value;
> +}

Ditto the two issues above.

> +
> +JSValue JSNotificationCenter::checkPermission(ExecState* exec, const
ArgList& args)
> +{
> +    return JSValue(exec, impl()->checkPermission());
> +}

Once again, not clear why this needs to be a custom binding.



> +Notification::~Notification() 
> +{
> +}

It's not necessary to explicitly define an empty constructor.

> +
> +void Notification::dispatchDisplayEvent() 
> +{   
> +    RefPtr<Event> event = Event::create("display", false, true);
> +
> +    if (m_onDisplayListener) {
> +	   event->setTarget(this);
> +	   event->setCurrentTarget(this);
> +	   m_onDisplayListener->handleEvent(event.get(), true);
> +    }
> +
> +    ExceptionCode ec = 0;
> +    dispatchEvent(event.release(), ec);
> +    ASSERT(!ec);
> +}

I think all of the event dispatch has some bugs. The event flow should be like
this:

1) All capturing event listeners -- ones registered with addEventListener's
third argument (useCapture) set to true -- get to handle the event, in the
order in which they were added.
2) All non-capturing event listeners, including built-in ones set via the
attributes, get to handle the event in the order in which they were added.

This should happen whether or not the event is dispatched internally or by an
explicit dispatchEvent() call from JS.

I believe you have at least four bugs here, I will describe them plus test
cases that would catch them (which you should add).

A) For events dispatched internally, the built-in listener will be invoked
*before* the capturing listeners (which we don't get to until handleEvent).
This is wrong, capturing listeners need to fire first. You can test this by
setting a capturing listener with addEventListener as well as one via the
builtin (onerror, onclose, etc) DOM attributes. Then cause one of the events to
be dispatched in a built-in way.

B) For events dispatched by calling dispatchEvent() directly, the built-in
listeners will be skipped entirely. That's because they are only called by the
special dispatchErrorEvent / dispatchCloseEvent etc functions, but those are
not invoked when dispatchEvent is called directly.

C) Very minor - if you add a non-capturing listener with addEventListener, and
then afterwards set a DOM property listener (say, by setting onerror) the
addEventListener listener should fire first on a built-in dispatch, but with
your code it will fire second.

D) You are not handling propagationStopped properly between the phases. You can
observe this by setting a capturing and non-capturing listener, and calling
stopPropagation in the capturing listener. 

There may be EventTarget subclasses that get this wrong. Node gets it right,
although it also has logic to go up and down the DOM tree which is not
necessary here. If you code it more like what Node does, starting with the line
event->setEventPhase(Event::AT_TARGET) in Node::dispatchGenericEvent() up to
right before the section of code handling the bubble phase, and if you make the
attribute listeners work more like they would via
Node::setAttributeEventListener(), then all four of the above bugs should go
away.

We can file bugs on any other classes getting this wrong. Maybe we should
eventually have some helper code for EventTarget classes that are standalone
and not DOM nodes, to make it easier to get this right.

> +
> +void Notification::dispatchErrorEvent()
> +{  
> +    RefPtr<Event> event = Event::create(eventNames().errorEvent, false,
true);
> +
> +    if (m_onErrorListener) {
> +	   event->setTarget(this);
> +	   event->setCurrentTarget(this);
> +	   m_onErrorListener->handleEvent(event.get(), true);
> +    }
> +
> +    ExceptionCode ec = 0;
> +    dispatchEvent(event.release(), ec);
> +    ASSERT(!ec);
> +}
> +
> +void Notification::dispatchCloseEvent() 
> +{   
> +    RefPtr<Event> event = Event::create(eventNames().closeEvent, false,
true);
> +
> +    if (m_onCloseListener) {
> +	   event->setTarget(this);
> +	   event->setCurrentTarget(this);
> +	   m_onCloseListener->handleEvent(event.get(), true);
> +    }
> +
> +    ExceptionCode ec = 0;
> +    dispatchEvent(event.release(), ec);
> +    ASSERT(!ec);
> +
> +}

These two methods are buggy too, as cited above.

> +bool Notification::dispatchEvent(PassRefPtr<Event> event, ExceptionCode& ec)

> +{
> +    RegisteredEventListenerVector listenersCopy = m_eventListeners;
> +    size_t size = listenersCopy.size();
> +    for (size_t i = 0; i < size; ++i) {
> +	   RegisteredEventListener& r = *listenersCopy[i];
> +	   if (r.eventType() == event->type() && !r.removed())
> +	       r.listener()->handleEvent(event.get());
> +    }
> +
> +    return true;
> +}

And this too - notice how it ignores whether the listeners have useCapture set.


> +
> +void Notification::display()
> +{
> +    dispatchDisplayEvent();
> +}
> +
> +void Notification::error()
> +{
> +    dispatchErrorEvent();
> +}
> +
> +void Notification::close()
> +{
> +    dispatchCloseEvent();
> +}

These one-line wrappers don't seem to add much. Maybe there should be only one
of display()/dispatchDisplayEvent() and the notification provider can call
that.


I think NotificationDisplay or NotificationUI or something like that would be a
better name than NotificationProvider, as discussed previously. Or maybe
NotificationPresenter (since the job of this class from the point of view of
the rest of the code) is to present notifications to the user.

From bugzilla-daemon at webkit.org  Mon Jul 20 21:43:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 21:43:56 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25463] Desktop Notifications
 API : [Attachment 32341] Notifications API, Tests and DumpRenderTree hooks
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090721044356.6DFA733D0A05@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied John Gregg <johnnyg at google.com>'s
request for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 32341: Notifications API, Tests and DumpRenderTree hooks
https://bugs.webkit.org/attachment.cgi?id=32341&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
First of all, I suggest combining this with the other patch. Yes, it will make
it overall a bit bigger, but it's a significant benefit to be able to land
atomically with test cases. I don't see any problems with the code (well done!)
but marking r- since this depends on the other patch, and since I suggest
combining with it.

From bugzilla-daemon at webkit.org  Mon Jul 20 22:45:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 22:45:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27482] svn-apply cannot
 apply patch generated by Windows SVN : [Attachment 33144] Patch!
In-Reply-To: <bug-27482-0@https.bugs.webkit.org/>
References: <bug-27482-0@https.bugs.webkit.org/>
Message-ID: <20090721054521.4411633D0FCF@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has asked  for review:
Bug 27482: svn-apply cannot apply patch generated by Windows SVN
https://bugs.webkit.org/show_bug.cgi?id=27482

Attachment 33144: Patch!
https://bugs.webkit.org/attachment.cgi?id=33144&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 23:14:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:14:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27483] diff_parser should
 accept lines without trailing \n : [Attachment 33145] Patch v1
In-Reply-To: <bug-27483-0@https.bugs.webkit.org/>
References: <bug-27483-0@https.bugs.webkit.org/>
Message-ID: <20090721061408.6A7EF33D1237@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27483: diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483

Attachment 33145: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33145&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 29 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 20 23:19:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:19:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27484] diff_parser:
 s/add_deleted_line/add_old_line/g : [Attachment 33146] Patch v1
In-Reply-To: <bug-27484-0@https.bugs.webkit.org/>
References: <bug-27484-0@https.bugs.webkit.org/>
Message-ID: <20090721061916.7A1D633D12B2@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27484: diff_parser: s/add_deleted_line/add_old_line/g
https://bugs.webkit.org/show_bug.cgi?id=27484

Attachment 33146: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33146&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 2 files changed, 15 insertions(+), 6 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 20 23:32:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:32:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27324] Add ENABLE_RUBY to
 list of build options : [Attachment 33147] patch: add ENABLE_RUBY build
 option (fixed patch)
In-Reply-To: <bug-27324-0@https.bugs.webkit.org/>
References: <bug-27324-0@https.bugs.webkit.org/>
Message-ID: <20090721063252.B5EAB33D13F5@gamma.macosforge.org>

Roland Steiner <rolandsteiner at google.com> has asked  for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Attachment 33147: patch: add ENABLE_RUBY build option (fixed patch)
https://bugs.webkit.org/attachment.cgi?id=33147&action=review

------- Additional Comments from Roland Steiner <rolandsteiner at google.com>
Uploaded a fixed patch that should address all mentioned issues.

(FWIW, my original ruby patch did include GNUMakefile.am, must have been a
casualty of the patch split :p)

From bugzilla-daemon at webkit.org  Mon Jul 20 23:38:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:38:11 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27291] Support lint for
 patches : [Attachment 32771] Patch v1
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721063811.8A5C933D14E7@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 32771: Patch v1
https://bugs.webkit.org/attachment.cgi?id=32771&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 23:38:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:38:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27291] Support lint for
 patches : [Attachment 33148] Patch v1
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721063814.EB3D333D14EE@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33148: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33148&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 159 insertions(+), 11 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 20 23:38:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:38:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27482] svn-apply cannot apply
 patch generated by Windows SVN : [Attachment 33144] Patch!
In-Reply-To: <bug-27482-0@https.bugs.webkit.org/>
References: <bug-27482-0@https.bugs.webkit.org/>
Message-ID: <20090721063856.0C72133D155C@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 27482: svn-apply cannot apply patch generated by Windows SVN
https://bugs.webkit.org/show_bug.cgi?id=27482

Attachment 33144: Patch!
https://bugs.webkit.org/attachment.cgi?id=33144&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Mon Jul 20 23:42:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:42:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27484] diff_parser:
 s/add_deleted_line/add_old_line/g : [Attachment 33146] Patch v1
In-Reply-To: <bug-27484-0@https.bugs.webkit.org/>
References: <bug-27484-0@https.bugs.webkit.org/>
Message-ID: <20090721064210.22D4033D18EB@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27484: diff_parser: s/add_deleted_line/add_old_line/g
https://bugs.webkit.org/show_bug.cgi?id=27484

Attachment 33146: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33146&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 23:44:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:44:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26375] VC++ 2005 Express
 failed to build WebKit due to raw UTF-8 string in
 WebKit/win/WebCoreLocalizedStrings.cpp : [Attachment 33143] Proposed fix
 for 26375 (rev 4)
In-Reply-To: <bug-26375-0@https.bugs.webkit.org/>
References: <bug-26375-0@https.bugs.webkit.org/>
Message-ID: <20090721064454.1A3E133D1CDF@gamma.macosforge.org>

Takeshi Yoshino <tyoshino at google.com> has asked  for review:
Bug 26375: VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in
WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375

Attachment 33143: Proposed fix for 26375 (rev 4)
https://bugs.webkit.org/attachment.cgi?id=33143&action=review

From bugzilla-daemon at webkit.org  Mon Jul 20 23:50:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:50:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27483] diff_parser should
 accept lines without trailing \n : [Attachment 33145] Patch v1
In-Reply-To: <bug-27483-0@https.bugs.webkit.org/>
References: <bug-27483-0@https.bugs.webkit.org/>
Message-ID: <20090721065007.A7C8C33D1DA5@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27483: diff_parser should accept lines without trailing \n
https://bugs.webkit.org/show_bug.cgi?id=27483

Attachment 33145: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33145&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog

> +
> +	   Normalize the input lines by removing a trailing newline.
> +	   Also, add a case for unittest for newly added files.
I think this reads better: "Also, add a case to the unittest for newly added
files."

fwiw, it is best to keep your patches focused on one thing and this does a bit
more, so the bug doesn't reflect what is being done. However, it is all rather
simple and you do describe it, so no need to break it up this time.

From bugzilla-daemon at webkit.org  Mon Jul 20 23:57:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 20 Jul 2009 23:57:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27291] Support lint for
 patches : [Attachment 33148] Patch v1
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721065714.E2D5933D1E8E@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33148: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33148&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
> Patch v1

Actually, this is v2 :(

Hmm... the usage of current patch is

% run-webkit-lint [options] [commitish]...

with this syntax, we cannot add support of linting files. Maybe the following
syntax would be better?

% run-webkit-lint [--git-commit=<commitish>] [options] [file]...

For now, to keep the patch small, I'll re-upload a patch with removing support
of linting specified commit.

From bugzilla-daemon at webkit.org  Tue Jul 21 00:00:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:00:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27324] Add ENABLE_RUBY to
 list of build options : [Attachment 33147] patch: add ENABLE_RUBY build
 option (fixed patch)
In-Reply-To: <bug-27324-0@https.bugs.webkit.org/>
References: <bug-27324-0@https.bugs.webkit.org/>
Message-ID: <20090721070009.1228C33D1EEE@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 27324: Add ENABLE_RUBY to list of build options
https://bugs.webkit.org/show_bug.cgi?id=27324

Attachment 33147: patch: add ENABLE_RUBY build option (fixed patch)
https://bugs.webkit.org/attachment.cgi?id=33147&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: WebKitTools/Scripts/build-webkit
> @@ -88,6 +88,9 @@ my @features = (
>      { option => "shared-workers", desc => "Toggle SharedWorkers support",
>	 define => "ENABLE_SHARED_WORKERS", default => 0, value =>
\$sharedWorkersSupport },
>  
> +    { option => "ruby", desc => "Toggle HTML5 Ruby support",
> +	 define => "ENABLE_RUBY", default => 1, value => \$rubySupport },
> +

To whoever is landing this one option is just slightly out of sort order so
this should be fixed on landing.

>      { option => "svg", desc => "Toggle SVG support",

From bugzilla-daemon at webkit.org  Tue Jul 21 00:01:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:01:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27077] Workers + garbage
 collector: weird crashes : [Attachment 33149] Cache the structure of the
 prototype
In-Reply-To: <bug-27077-0@https.bugs.webkit.org/>
References: <bug-27077-0@https.bugs.webkit.org/>
Message-ID: <20090721070134.D87AE33D1F2B@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 27077: Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

Attachment 33149: Cache the structure of the prototype
https://bugs.webkit.org/attachment.cgi?id=33149&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 00:16:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:16:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27485] Move
 LinkBuffer/RepatchBuffer out of AbstractMacroAssembler. : [Attachment
 33150] The patch
In-Reply-To: <bug-27485-0@https.bugs.webkit.org/>
References: <bug-27485-0@https.bugs.webkit.org/>
Message-ID: <20090721071628.62ECE33D20B4@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 27485: Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=27485

Attachment 33150: The patch
https://bugs.webkit.org/attachment.cgi?id=33150&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 00:44:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:44:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 9589] WCSS: -wap-accesskey
 not supported : [Attachment 33151] This is for -wap-accesskey support ,
 contains both the code change and the test cases as per request from last
 review
In-Reply-To: <bug-9589-0@https.bugs.webkit.org/>
References: <bug-9589-0@https.bugs.webkit.org/>
Message-ID: <20090721074408.74EA333D22FD@gamma.macosforge.org>

Charles Wei <charles.wei at torchmobile.com.cn> has asked	for review:
Bug 9589: WCSS: -wap-accesskey not supported
https://bugs.webkit.org/show_bug.cgi?id=9589

Attachment 33151: This is for -wap-accesskey support , contains both the code
change and the test cases as per request from last review 
https://bugs.webkit.org/attachment.cgi?id=33151&action=review

------- Additional Comments from Charles Wei <charles.wei at torchmobile.com.cn>
This patch contains both the code change and the test cases /expected test
results.  There's no change to the last code change,  this patch differes from
last patch only in the test cases, test cases for LayoutTests has been designed
and expected test results are also attached.

From bugzilla-daemon at webkit.org  Tue Jul 21 00:47:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:47:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27486] cpplint.py should
 have an interface to get global error count : [Attachment 33152] Patch v1
In-Reply-To: <bug-27486-0@https.bugs.webkit.org/>
References: <bug-27486-0@https.bugs.webkit.org/>
Message-ID: <20090721074720.DFF5D33D23AE@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27486: cpplint.py should have an interface to get global error count
https://bugs.webkit.org/show_bug.cgi?id=27486

Attachment 33152: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33152&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 25 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 00:49:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:49:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27486] cpplint.py should have
 an interface to get global error count : [Attachment 33152] Patch v1
In-Reply-To: <bug-27486-0@https.bugs.webkit.org/>
References: <bug-27486-0@https.bugs.webkit.org/>
Message-ID: <20090721074926.6394433D23E6@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27486: cpplint.py should have an interface to get global error count
https://bugs.webkit.org/show_bug.cgi?id=27486

Attachment 33152: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33152&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 00:49:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 00:49:44 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27366] TextEncodingDetector
 that uses Universal Charset Detector : [Attachment 32926]
 TextEncodingDetectorUniversal
In-Reply-To: <bug-27366-0@https.bugs.webkit.org/>
References: <bug-27366-0@https.bugs.webkit.org/>
Message-ID: <20090721074944.E43D333D23FC@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has denied Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 27366: TextEncodingDetector that uses Universal Charset Detector
https://bugs.webkit.org/show_bug.cgi?id=27366

Attachment 32926: TextEncodingDetectorUniversal
https://bugs.webkit.org/attachment.cgi?id=32926&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
What's our plan for maintaining this code? Will we sync with upstream
periodically or maintain it ourselves? Either way, it seems like a bad idea to
put all the code in one file. It seems like it will make maintenance harder.
Please resubmit with files split properly. I have no comment on the merits as
to whether including this is a good idea, probably international text experts
should chime in. Is there any information available on Universal Charset
Detector, what it does, and how it works?

From bugzilla-daemon at webkit.org  Tue Jul 21 01:09:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:09:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27487] cpplint.py's
 process_file() should accept customized error function : [Attachment 33153]
 Patch v1
In-Reply-To: <bug-27487-0@https.bugs.webkit.org/>
References: <bug-27487-0@https.bugs.webkit.org/>
Message-ID: <20090721080925.8DA0033D26A1@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27487: cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

Attachment 33153: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33153&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 25 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 01:10:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:10:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27487] cpplint.py's
 process_file() should accept customized error function : [Attachment 33153]
 Patch v1
In-Reply-To: <bug-27487-0@https.bugs.webkit.org/>
References: <bug-27487-0@https.bugs.webkit.org/>
Message-ID: <20090721081016.E8A7F33D26D1@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27487: cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

Attachment 33153: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33153&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 01:10:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:10:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27487] cpplint.py's
 process_file() should accept customized error function : [Attachment 33153]
 Patch v1
In-Reply-To: <bug-27487-0@https.bugs.webkit.org/>
References: <bug-27487-0@https.bugs.webkit.org/>
Message-ID: <20090721081027.B49AB33D26E5@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 27487: cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

Attachment 33153: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33153&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 01:10:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:10:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27487] cpplint.py's
 process_file() should accept customized error function : [Attachment 33154]
 Patch v2
In-Reply-To: <bug-27487-0@https.bugs.webkit.org/>
References: <bug-27487-0@https.bugs.webkit.org/>
Message-ID: <20090721081031.CC7F933D26F6@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27487: cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

Attachment 33154: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33154&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 2 files changed, 11 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 01:11:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:11:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27488] SVG and XPath memory
 leaks in V8 bindings : [Attachment 33155] Add 'create' methods to
 SVGPODTypeWrappers and XPathNSResolvers to avoid memory leaks.
In-Reply-To: <bug-27488-0@https.bugs.webkit.org/>
References: <bug-27488-0@https.bugs.webkit.org/>
Message-ID: <20090721081110.83C0933D2723@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33155: Add 'create' methods to SVGPODTypeWrappers and
XPathNSResolvers to avoid memory leaks.
https://bugs.webkit.org/attachment.cgi?id=33155&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 01:16:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:16:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27487] cpplint.py's
 process_file() should accept customized error function : [Attachment 33154]
 Patch v2
In-Reply-To: <bug-27487-0@https.bugs.webkit.org/>
References: <bug-27487-0@https.bugs.webkit.org/>
Message-ID: <20090721081620.14D5F33D27D1@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27487: cpplint.py's process_file() should accept customized error function
https://bugs.webkit.org/show_bug.cgi?id=27487

Attachment 33154: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33154&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I thought I had just reviewed that other patch but then thought maybe I forgot
to click submit. :)

From bugzilla-daemon at webkit.org  Tue Jul 21 01:22:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:22:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27489] cpplint's
 parse_argument should not exit even if no files are specified : [Attachment
 33156] Patch v1
In-Reply-To: <bug-27489-0@https.bugs.webkit.org/>
References: <bug-27489-0@https.bugs.webkit.org/>
Message-ID: <20090721082220.E18F233D2884@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27489: cpplint's parse_argument should not exit even if no files are
specified
https://bugs.webkit.org/show_bug.cgi?id=27489

Attachment 33156: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33156&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 17 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 01:25:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:25:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27489] cpplint's
 parse_argument should not exit even if no files are specified : [Attachment
 33156] Patch v1
In-Reply-To: <bug-27489-0@https.bugs.webkit.org/>
References: <bug-27489-0@https.bugs.webkit.org/>
Message-ID: <20090721082509.A289C33D28DA@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27489: cpplint's parse_argument should not exit even if no files are
specified
https://bugs.webkit.org/show_bug.cgi?id=27489

Attachment 33156: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33156&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 01:35:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:35:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27485] Move
 LinkBuffer/RepatchBuffer out of AbstractMacroAssembler. : [Attachment
 33150] The patch
In-Reply-To: <bug-27485-0@https.bugs.webkit.org/>
References: <bug-27485-0@https.bugs.webkit.org/>
Message-ID: <20090721083536.66DDF33D2A69@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27485: Move LinkBuffer/RepatchBuffer out of AbstractMacroAssembler.
https://bugs.webkit.org/show_bug.cgi?id=27485

Attachment 33150: The patch
https://bugs.webkit.org/attachment.cgi?id=33150&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
r=me

From bugzilla-daemon at webkit.org  Tue Jul 21 01:46:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:46:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27490] Web Sockets Test
 Infrastructure Part 1/3: Server : [Attachment 33157] Web Socket Server for
 LayoutTests.
In-Reply-To: <bug-27490-0@https.bugs.webkit.org/>
References: <bug-27490-0@https.bugs.webkit.org/>
Message-ID: <20090721084656.B948233D2BC6@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 27490: Web Sockets Test Infrastructure Part 1/3: Server
https://bugs.webkit.org/show_bug.cgi?id=27490

Attachment 33157: Web Socket Server for LayoutTests.
https://bugs.webkit.org/attachment.cgi?id=33157&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 01:53:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:53:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27291] Support lint for
 patches : [Attachment 33158] Patch v3
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721085311.20A6933D2CA6@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33158: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33158&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 149 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 01:55:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 01:55:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27491] Web Sockets Test
 Infrastructure Part 2/3: Patch to run-webkit-tests : [Attachment 33159]
 Patch to run-webkit-test to start up / shut down Web Socket Server.
In-Reply-To: <bug-27491-0@https.bugs.webkit.org/>
References: <bug-27491-0@https.bugs.webkit.org/>
Message-ID: <20090721085534.2A90E33D2CC9@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 27491: Web Sockets Test Infrastructure Part 2/3: Patch to run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=27491

Attachment 33159: Patch to run-webkit-test to start up / shut down Web Socket
Server.
https://bugs.webkit.org/attachment.cgi?id=33159&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 02:03:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:03:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27493] Web Inspector:
 special case console panel opening : [Attachment 33161] patch
In-Reply-To: <bug-27493-0@https.bugs.webkit.org/>
References: <bug-27493-0@https.bugs.webkit.org/>
Message-ID: <20090721090346.27C4233D2E0F@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27493: Web Inspector: special case console panel opening
https://bugs.webkit.org/show_bug.cgi?id=27493

Attachment 33161: patch
https://bugs.webkit.org/attachment.cgi?id=33161&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 02:08:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:08:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27492] Web Sockets Test
 Infrastructure Part 3/3: Example test : [Attachment 33162] Patch to add
 example Web Sockets test.
In-Reply-To: <bug-27492-0@https.bugs.webkit.org/>
References: <bug-27492-0@https.bugs.webkit.org/>
Message-ID: <20090721090814.EB1B533D2E9C@gamma.macosforge.org>

Yuzo Fujishima <yuzo at google.com> has asked  for review:
Bug 27492: Web Sockets Test Infrastructure Part 3/3: Example test
https://bugs.webkit.org/show_bug.cgi?id=27492

Attachment 33162: Patch to add example Web Sockets test.
https://bugs.webkit.org/attachment.cgi?id=33162&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 02:13:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:13:41 -0700 (PDT)
Subject: [webkit-reviews] =?utf-8?q?review_canceled=3A_=5BBug_27447=5D_Web?=
 =?utf-8?q?Inspector=3A_Accept_autocomplete_on_=27End=27_key_pressed=2E_?=
 =?utf-8?b?OiBbQXR0YWNobWVudCAzMzA4N10gINC30YTQtdGB0YA=?=
In-Reply-To: <bug-27447-0@https.bugs.webkit.org/>
References: <bug-27447-0@https.bugs.webkit.org/>
Message-ID: <20090721091341.9179933D2F32@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27447: WebInspector: Accept autocomplete on 'End' key pressed.
https://bugs.webkit.org/show_bug.cgi?id=27447

Attachment 33087: ?????
https://bugs.webkit.org/attachment.cgi?id=33087&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 02:13:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:13:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27447] WebInspector: Accept
 autocomplete on 'End' key pressed. : [Attachment 33163] patch
In-Reply-To: <bug-27447-0@https.bugs.webkit.org/>
References: <bug-27447-0@https.bugs.webkit.org/>
Message-ID: <20090721091341.A6E8833D2F35@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27447: WebInspector: Accept autocomplete on 'End' key pressed.
https://bugs.webkit.org/show_bug.cgi?id=27447

Attachment 33163: patch
https://bugs.webkit.org/attachment.cgi?id=33163&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 02:22:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:22:06 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 32991] Fix weak handle
 issue
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090721092206.556C333D3051@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 32991: Fix weak handle issue
https://bugs.webkit.org/attachment.cgi?id=32991&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The weak callback doesn't currently.  I'll spin up a new version that does.

From bugzilla-daemon at webkit.org  Tue Jul 21 02:28:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:28:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 33164] patch
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090721092802.1C68533D310C@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 33164: patch
https://bugs.webkit.org/attachment.cgi?id=33164&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 02:39:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:39:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27291] Support lint for
 patches : [Attachment 33158] Patch v3
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721093910.3C7E633D3212@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33158: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33158&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few things to consider....

> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py

> +# FIXME: Once run-webkit-lint script becomes ready, we don't need to
> +#	    support standalone execution for this module.
> +#	    So, we should remove _USAGE and main() eventually.

I'm not sure this is necessary (maybe).


>      _cpplint_state.reset_error_count()

Add this line here:

   _set_verbose_level(_cpplint_state.verbose_level)

>      for filename in filenames:
> -	   process_file(filename, _cpplint_state.verbose_level)
> +	   process_file(filename)


> diff --git a/WebKitTools/Scripts/run-webkit-lint
b/WebKitTools/Scripts/run-webkit-lint

> +cpplint._USAGE = """
> +Syntax: webkit-run-lint [--verbose=#] [--output=vs7] [--filter=-x,+y,...]
> +
> +  The style guidelines this tries to follow are those in
> +    http://webkit.org/coding/coding-style.html
> +
> +  Every problem is given a confidence score from 1-5, with 5 meaning we are
> +  certain of the problem, and 1 meaning it could be a legitimate construct.
> +  This will miss some errors, and is not a substitute for a code review.
> +
> +  To prevent specific lines from being linted, add a '// NOLINT' comment to
the
> +  end of the line.
> +
> +  Linted extensions are .cc, .cpp, and .h.  Other file types will be
ignored.
> +
> +  Flags:
> +
> +    output=vs7
> +	 By default, the output is formatted to ease emacs parsing.  Visual
Studio
> +	 compatible output (vs7) may also be used.  Other formats are
unsupported.
> +
> +    verbose=#
> +	 Specify a number 0-5 to restrict errors to certain verbosity levels.
> +
> +    filter=-x,+y,...
> +	 Specify a comma-separated list of category-filters to apply: only
> +	 error messages whose category names pass the filters will be printed.
> +	 (Category names are printed with the message and look like
> +	 "[whitespace/indent]".)  Filters are evaluated left to right.
> +	 "-FOO" and "FOO" means "do not print categories that start with FOO".
> +	 "+FOO" means "do print categories that start with FOO".
> +
> +	 Examples: --filter=-whitespace,+whitespace/braces
> +		   --filter=whitespace,runtime/printf,+runtime/printf_format
> +		   --filter=-,+build/include_what_you_use
> +
> +	 To see a list of all the categories used in cpplint, pass no arg:
> +	    --filter=
> +"""

When I said this:  Consider doing this

""" ....""" % {'program_name' sys.argv[0]}
In the description text replace "webkit-run-lint" and "cpplint" with
"%{program_name}s"

I was referring to this comment (not the one in cpplint.py).  It would fix two
things: "webkit-run-lint" is not the program name. "cpplint" is also not the
name of the program being run.
sys.argv[0] is the program name.

>
> +	   if file_extension in ['.cc', '.cpp', '.h']:
> +	       line_numbers = set()
This looks fine.  The problem with my suggestion was the assigment inside of
error_for_patch which made the variable have scope local to that block.


> +    if args:
> +	   sys.stderr.write('ERROR: We don\'t support files as arguments for
now.\n' + cpplint._USAGE)

Consider using "" for the outside quotes and change \' to '.  Like this

	sys.stderr.write("ERROR: We don't support files as arguments for
now.\n" + cpplint._USAGE)

From bugzilla-daemon at webkit.org  Tue Jul 21 02:46:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:46:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33165] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090721094628.6CA1833D32EA@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33165: Patch
https://bugs.webkit.org/attachment.cgi?id=33165&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Created a new base class called ScriptSourceProvider which is inherited by both
StringSourceProvider and CachedScriptSourceProvider.

Blindly edited the WebCore Visual C++ project file.

From bugzilla-daemon at webkit.org  Tue Jul 21 02:47:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 02:47:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33166] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090721094720.5BC4133D3315@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33166: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33166&action=review

------- Additional Comments from Maxime Simon <simon.maxime at gmail.com>
+#include <support/Locker.h>
+#include <app/Clipboard.h>

I have no choice but to put these includes in this order.
Clipboard.h needs Locker.h but it seems that it doesn't include it.

From bugzilla-daemon at webkit.org  Tue Jul 21 03:03:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:03:19 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33166] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090721100319.DACB333D3517@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33166: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33166&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I want to approve this but this change isn't done.

 diff --git a/WebCore/platform/haiku/CursorHaiku.cpp
b/WebCore/platform/haiku/CursorHaiku.cpp
> +static Cursor
global_cursor(static_cast<PlatformCursor>(B_CURSOR_SYSTEM_DEFAULT));
> +static Cursor ibeam_cursor(static_cast<PlatformCursor>(B_CURSOR_I_BEAM));

As noted before: Improper casing 
   s/global_cursor/globalCursor/
   s/ibeam_cursor/ibeamCursor/

From bugzilla-daemon at webkit.org  Tue Jul 21 03:18:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:18:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27291] Support lint for
 patches : [Attachment 33158] Patch v3
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721101858.89ABC33D367C@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled  review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33158: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33158&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 03:19:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:19:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27291] Support lint for
 patches : [Attachment 33167] Patch v4
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721101902.F006133D3683@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33167: Patch v4
https://bugs.webkit.org/attachment.cgi?id=33167&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 146 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 03:26:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:26:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33168] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090721102651.B45E933D374A@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33168: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33168&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 03:28:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:28:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27291] Support lint for
 patches : [Attachment 33167] Patch v4
In-Reply-To: <bug-27291-0@https.bugs.webkit.org/>
References: <bug-27291-0@https.bugs.webkit.org/>
Message-ID: <20090721102847.8719933D378A@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27291: Support lint for patches
https://bugs.webkit.org/show_bug.cgi?id=27291

Attachment 33167: Patch v4
https://bugs.webkit.org/attachment.cgi?id=33167&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Ok I see there is no need to call
_set_verbose_level(_cpplint_state.verbose_level) because that is just
redundant.

From bugzilla-daemon at webkit.org  Tue Jul 21 03:37:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:37:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33168] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090721103734.05BCC33D388E@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33168: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33168&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> +Cursor& Cursor::operator=(const Cursor& other)
> +{
> +    m_impl = other.m_impl;
> +    return* this;
Should be "return *this;"

Fix on landing.

From bugzilla-daemon at webkit.org  Tue Jul 21 03:42:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 03:42:12 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33168] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090721104212.DFC5B33D38ED@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33168: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33168&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r+.
Committed as http://trac.webkit.org/changeset/46167

From bugzilla-daemon at webkit.org  Tue Jul 21 04:35:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 04:35:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27449] Web Inspector: don't
 lose mousemove events while dragging over iframe : [Attachment 33095] patch
In-Reply-To: <bug-27449-0@https.bugs.webkit.org/>
References: <bug-27449-0@https.bugs.webkit.org/>
Message-ID: <20090721113515.CCA9133D3E50@gamma.macosforge.org>

apavlov at chromium.org has canceled apavlov at chromium.org's request for review:
Bug 27449: Web Inspector: don't lose mousemove events while dragging over
iframe
https://bugs.webkit.org/show_bug.cgi?id=27449

Attachment 33095: patch
https://bugs.webkit.org/attachment.cgi?id=33095&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 04:58:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 04:58:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27495] [Qt] Add simple
 proxy support for QtLauncher : [Attachment 33170] Proposed patch.
In-Reply-To: <bug-27495-0@https.bugs.webkit.org/>
References: <bug-27495-0@https.bugs.webkit.org/>
Message-ID: <20090721115839.4E5F833D42CD@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27495: [Qt] Add simple proxy support for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27495

Attachment 33170: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33170&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Picks up proxy settings from the http_proxy env variable.

From bugzilla-daemon at webkit.org  Tue Jul 21 05:08:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 05:08:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24602] [Gtk] Searching in
 thepiratebay.org doesn't work with more than 1 word : [Attachment 33171]
 webkit-bug-24602-drop-workaround.patch
In-Reply-To: <bug-24602-0@https.bugs.webkit.org/>
References: <bug-24602-0@https.bugs.webkit.org/>
Message-ID: <20090721120859.1038033D43F3@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has asked  for review:
Bug 24602: [Gtk] Searching in thepiratebay.org doesn't work with more than 1
word
https://bugs.webkit.org/show_bug.cgi?id=24602

Attachment 33171: webkit-bug-24602-drop-workaround.patch
https://bugs.webkit.org/attachment.cgi?id=33171&action=review

------- Additional Comments from Priit Laes (IRC: plaes) <amd at store20.com>
Drop workaround required for <=libsoup-2.26.2

From bugzilla-daemon at webkit.org  Tue Jul 21 05:11:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 05:11:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 24602] [Gtk] Searching in
 thepiratebay.org doesn't work with more than 1 word : [Attachment 33171]
 webkit-bug-24602-drop-workaround.patch
In-Reply-To: <bug-24602-0@https.bugs.webkit.org/>
References: <bug-24602-0@https.bugs.webkit.org/>
Message-ID: <20090721121108.803E233D444C@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has canceled Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 24602: [Gtk] Searching in thepiratebay.org doesn't work with more than 1
word
https://bugs.webkit.org/show_bug.cgi?id=24602

Attachment 33171: webkit-bug-24602-drop-workaround.patch
https://bugs.webkit.org/attachment.cgi?id=33171&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 05:11:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 05:11:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24602] [Gtk] Searching in
 thepiratebay.org doesn't work with more than 1 word : [Attachment 33172]
 webkit-bug-24602-drop-workaround.patch
In-Reply-To: <bug-24602-0@https.bugs.webkit.org/>
References: <bug-24602-0@https.bugs.webkit.org/>
Message-ID: <20090721121108.A0E5433D4450@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has asked  for review:
Bug 24602: [Gtk] Searching in thepiratebay.org doesn't work with more than 1
word
https://bugs.webkit.org/show_bug.cgi?id=24602

Attachment 33172: webkit-bug-24602-drop-workaround.patch
https://bugs.webkit.org/attachment.cgi?id=33172&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 05:47:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 05:47:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26838] Multithread support
 for JSC on UNIX : [Attachment 33173]
 WebKit-r46156-Collector-multithread-support-for-UNIX.diff
In-Reply-To: <bug-26838-0@https.bugs.webkit.org/>
References: <bug-26838-0@https.bugs.webkit.org/>
Message-ID: <20090721124730.8167933D47C8@gamma.macosforge.org>

Martin Zoubek <martin.zoubek at acision.com> has asked  for review:
Bug 26838: Multithread support for JSC on UNIX
https://bugs.webkit.org/show_bug.cgi?id=26838

Attachment 33173: WebKit-r46156-Collector-multithread-support-for-UNIX.diff
https://bugs.webkit.org/attachment.cgi?id=33173&action=review

------- Additional Comments from Martin Zoubek <martin.zoubek at acision.com>
Hi Maciej,
thanks for your review. Changes since last version of the patch:
- SIG_THREAD_SUSPEND_RESUME becomes static const int
- pth_sig_suspend_resume was renamed
- unrelated check for registers size in Heap::markOtherThreadConservatively()
was removed, it is not needed
- signal handler was modified to use sigsuspend() instead of sigwait(), because
sigwait() is not async signal safe

Sunspider results:
1. Single threaded gtk+ build
before: 525.5ms +/- 0.4%
after: 524.8ms +/- 0.6% (no change)
2. Multi threaded gtk+ build
before: not buildable
after: 544.3ms +/- 0.7%

Tests were performed on Fedora 11 x86_64 in VMware machine.

From bugzilla-daemon at webkit.org  Tue Jul 21 06:43:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 06:43:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27077] Workers + garbage
 collector: weird crashes : [Attachment 33174] layout test for
 op_method_call bug
In-Reply-To: <bug-27077-0@https.bugs.webkit.org/>
References: <bug-27077-0@https.bugs.webkit.org/>
Message-ID: <20090721134328.9C17833D4E3F@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 27077: Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

Attachment 33174: layout test for op_method_call bug
https://bugs.webkit.org/attachment.cgi?id=33174&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 07:00:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 07:00:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27462] Add cpplint check
 for proper include order : [Attachment 33175] New version incorporating
 comments
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721140007.2C26E33D505D@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33175: New version incorporating comments
https://bugs.webkit.org/attachment.cgi?id=33175&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I've greatly simplified _classify_include following discussions on IRC and
incorporated your other comments into this new version.

From bugzilla-daemon at webkit.org  Tue Jul 21 07:00:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 07:00:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27462] Add cpplint check for
 proper include order : [Attachment 33109] Checks include order and tests
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721140007.1A47D33D505B@gamma.macosforge.org>

Adam Treat <treat at kde.org> has canceled Adam Treat <treat at kde.org>'s request
for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33109: Checks include order and tests
https://bugs.webkit.org/attachment.cgi?id=33109&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I've greatly simplified _classify_include following discussions on IRC and
incorporated your other comments into this new version.

From bugzilla-daemon at webkit.org  Tue Jul 21 07:33:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 07:33:30 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27371] [WINCE] Add WinCE
 specific platform/text files to WebCore : [Attachment 32939] Adds
 platform/text/wince files to WebCore
In-Reply-To: <bug-27371-0@https.bugs.webkit.org/>
References: <bug-27371-0@https.bugs.webkit.org/>
Message-ID: <20090721143330.CEF7733D53EB@gamma.macosforge.org>

Adam Treat <treat at kde.org> has canceled Adam Treat <treat at kde.org>'s request
for review:
Bug 27371: [WINCE] Add WinCE specific platform/text files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27371

Attachment 32939: Adds platform/text/wince files to WebCore
https://bugs.webkit.org/attachment.cgi?id=32939&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 08:19:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 08:19:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27502] Web Inspector: Add
 ability to evaluate selection while on break point. : [Attachment 33177]
 patch
In-Reply-To: <bug-27502-0@https.bugs.webkit.org/>
References: <bug-27502-0@https.bugs.webkit.org/>
Message-ID: <20090721151902.675D033D5971@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27502: Web Inspector: Add ability to evaluate selection while on break
point.
https://bugs.webkit.org/show_bug.cgi?id=27502

Attachment 33177: patch
https://bugs.webkit.org/attachment.cgi?id=33177&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 08:28:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 08:28:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33178] Add checks for
 namespace indentation to cpplint (try 4)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721152847.3FEBF33D5AA0@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33178: Add checks for namespace indentation to cpplint (try 4)
https://bugs.webkit.org/attachment.cgi?id=33178&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
See comment above, addresses various issues that were highlighted by David
Levin.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:04:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:04:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27493] Web Inspector: special
 case console panel opening : [Attachment 33161] patch
In-Reply-To: <bug-27493-0@https.bugs.webkit.org/>
References: <bug-27493-0@https.bugs.webkit.org/>
Message-ID: <20090721160433.D560433D5E74@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27493: Web Inspector: special case console panel opening
https://bugs.webkit.org/show_bug.cgi?id=27493

Attachment 33161: patch
https://bugs.webkit.org/attachment.cgi?id=33161&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
I am not sure what "fast view" means. But this seams right.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:05:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:05:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27503] Inspector: Should
 Syntax Highlight JSON : [Attachment 33179] patch
In-Reply-To: <bug-27503-0@https.bugs.webkit.org/>
References: <bug-27503-0@https.bugs.webkit.org/>
Message-ID: <20090721160552.94BE933D5EA1@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27503: Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

Attachment 33179: patch
https://bugs.webkit.org/attachment.cgi?id=33179&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Most JSON is from an XHR and thus its resource.type is
"WebInspector.Resource.Type.XHR".  This patch therefore tries to also highlight
resources that have a mime type of 'application/json' and even further if the
resource ends in the common extension names ".js" or ".json".

From bugzilla-daemon at webkit.org  Tue Jul 21 09:22:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:22:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27502] Web Inspector: Add
 ability to evaluate selection while on break point. : [Attachment 33177]
 patch
In-Reply-To: <bug-27502-0@https.bugs.webkit.org/>
References: <bug-27502-0@https.bugs.webkit.org/>
Message-ID: <20090721162229.4BE7F33D60FD@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27502: Web Inspector: Add ability to evaluate selection while on break
point.
https://bugs.webkit.org/show_bug.cgi?id=27502

Attachment 33177: patch
https://bugs.webkit.org/attachment.cgi?id=33177&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   var shortcut = WebInspector.KeyboardShortcut.makeKey(
> +	       69 /* 'E' */,
> +	       platformSpecificModifier |
WebInspector.KeyboardShortcut.Modifiers.Shift);

I think that would be fine and more readable on one line.

Talk to Sam Weinig, he has a patch (maybe landed) that will let us add
"evaluate on hover".

From bugzilla-daemon at webkit.org  Tue Jul 21 09:25:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:25:12 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33178] Add checks for
 namespace indentation to cpplint (try 4)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721162512.BF63033D6150@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33178: Add checks for namespace indentation to cpplint (try 4)
https://bugs.webkit.org/attachment.cgi?id=33178&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Adapt checks for goto labels as discussed with Dave on IRC: empirical research
shows that such labels are not used in header files, and therefore don't need
to be checked. Also, add a test case for goto labels in implementation files,
just to make sure the check actually works (although it probably won't be
triggered anytime soon, because indented namespaced hardly exist anywhere in
implementation files).

From bugzilla-daemon at webkit.org  Tue Jul 21 09:25:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:25:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33181] Add checks for
 namespace indentation to cpplint (try 5)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721162512.E75BE33D6154@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33181: Add checks for namespace indentation to cpplint (try 5)
https://bugs.webkit.org/attachment.cgi?id=33181&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Adapt checks for goto labels as discussed with Dave on IRC: empirical research
shows that such labels are not used in header files, and therefore don't need
to be checked. Also, add a test case for goto labels in implementation files,
just to make sure the check actually works (although it probably won't be
triggered anytime soon, because indented namespaced hardly exist anywhere in
implementation files).

From bugzilla-daemon at webkit.org  Tue Jul 21 09:28:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:28:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27503] Inspector: Should
 Syntax Highlight JSON : [Attachment 33179] patch
In-Reply-To: <bug-27503-0@https.bugs.webkit.org/>
References: <bug-27503-0@https.bugs.webkit.org/>
Message-ID: <20090721162840.AE8C033D61D1@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27503: Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

Attachment 33179: patch
https://bugs.webkit.org/attachment.cgi?id=33179&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Added 'application/javascript'.
Added to the test page.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:28:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:28:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27503] Inspector: Should
 Syntax Highlight JSON : [Attachment 33182] Added 'application/javascript'
In-Reply-To: <bug-27503-0@https.bugs.webkit.org/>
References: <bug-27503-0@https.bugs.webkit.org/>
Message-ID: <20090721162840.D62B833D61D5@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27503: Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

Attachment 33182: Added 'application/javascript'
https://bugs.webkit.org/attachment.cgi?id=33182&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Added 'application/javascript'.
Added to the test page.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:34:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:34:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27462] Add cpplint check for
 proper include order : [Attachment 33175] New version incorporating
 comments
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721163420.8503433D625B@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Adam Treat <treat at kde.org>'s
request for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33175: New version incorporating comments
https://bugs.webkit.org/attachment.cgi?id=33175&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This looks really good.  Just a few things to address.

> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> +	   if header_type == _CONFIG_HEADER and file_is_header:
> +	       return 'Header file should not contain WebCore config.h.'
> +	   if header_type == _PRIMARY_HEADER and file_is_header:
> +	       return 'Header file should not contain itself.'
> +
> +	   error_message = ''
> +	   if self._section != self._OTHER_SECTION:
> +	       before_error_message = ('Found %s before %s' %
> +				       (self._TYPE_NAMES[header_type],
> +					self._SECTION_NAMES[self._section +
1]))
> +	   after_error_message = ('Found %s after %s' %
> +				   (self._TYPE_NAMES[header_type],
> +				    self._SECTION_NAMES[self._section]))
> +
> +	   if header_type == _CONFIG_HEADER:
> +	       if self._section >= self._CONFIG_SECTION:
> +		   error_message = after_error_message
> +	       self._section = self._CONFIG_SECTION
> +	   elif header_type == _PRIMARY_HEADER:
> +	       if self._section >= self._PRIMARY_SECTION:
> +		   error_message = after_error_message
> +	       elif self._section < self._CONFIG_SECTION:
> +		   error_message = before_error_message

I think this is primarily here to note that the config.h header include may be
missing.  

Maybe it is better just have the message say something about the missing
include.
"It appears that config.h wasn't included (or it wasn't included first)."


> +	       if not file_is_header and self._section < self._PRIMARY_SECTION:


This seems to be ensuring that we got to the primary header.  It is rare but
sometimes there is no primary header.
I think the only thing to check here is that the missing config.h file.  The
check becomes:
   if not file_is_header and self._section < self._CONFIG_SECTION:

Have the same message as before about missing config.h.  This gets rid of
before_error_message by the way.


> +	       # Check to make sure all headers besides config.h and the
primary header are
> +	       # alphabetically sorted.
> +	       if not error_message and header_type == _OTHER_HEADER:
> +		    previous_line_number = line_number - 1;
> +		    previous_line = clean_lines.lines[previous_line_number]
> +		    previous_match = _RE_PATTERN_INCLUDE.search(previous_line)
> +		    while not previous_match and previous_line_number > 0:
> +		       previous_line_number -= 1;
> +		       previous_line = clean_lines.lines[previous_line_number]
> +		       previous_match =
_RE_PATTERN_INCLUDE.search(previous_line)

I would try to match #ifdef/#else here and break out if you get that without a
previous match (just to avoid flagging a sorting issue when there is an
ifdef'ed group after the regular includes.



> diff --git a/WebKitTools/Scripts/modules/cpplint_unittest.py
b/WebKitTools/Scripts/modules/cpplint_unittest.py

> +    def test_check_next_include_order__no_config(self):
> +	   self.assertEqual('Header file should not contain WebCore config.h.',

>			    self.include_state.check_next_include_order(
> -				cpplint._CPP_SYS_HEADER))
> +			       cpplint._CONFIG_HEADER, True))
You seem to be doing a two space indenting here.  Anyway, I just wouldn't wrap
the arguments.


It would be nice to add a test for this case as well:

   #include "test.h"

   #ifdef MY_DEFINE
   #include "a.h"
   #endif
Just to verify that a.h ins't flagged as a sorting error.



There is a test that says this:
3097	    def test_include(self):
3098		# FIXME: Implement this.
3099		pass

Should this test be deleted (or just add a comment there saying where it is
tested) or should the header tests move there? etc.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:43:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:43:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27506] Fixed typo :
 [Attachment 33184] proposed patch
In-Reply-To: <bug-27506-0@https.bugs.webkit.org/>
References: <bug-27506-0@https.bugs.webkit.org/>
Message-ID: <20090721164315.8FB8433D635B@gamma.macosforge.org>

Robert Agoston <Agoston.Robert at stud.u-szeged.hu> has asked  for review:
Bug 27506: Fixed typo
https://bugs.webkit.org/show_bug.cgi?id=27506

Attachment 33184: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33184&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 09:45:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:45:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33181] Add checks for
 namespace indentation to cpplint (try 5)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721164540.BF62E33D63B1@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33181: Add checks for namespace indentation to cpplint (try 5)
https://bugs.webkit.org/attachment.cgi?id=33181&action=review

------- Additional Comments from David Levin <levin at chromium.org>
It could be landed as is.  If the lander would fix these issues, it would be
even better.


> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> +def check_namespace_indentation(filename, clean_lines, line_number,
file_extension, error):
> +    """Looks for indentation errors inside of namespaces.
> +
> +    Args:
> +	 filename: The name of the current file.
> +	 clean_lines: A CleansedLines instance containing the file.
> +	 line_number: The number of the line to check.
> +	 file_extension: The extension (dot not included) of the file.
> +	 error: The function to call with any errors found.
> +    """
> +
> +    line = clean_lines.elided[line_number] # get rid of comments and strings


It is nice to make comment look like sentences.  Start with a capital. End with
a period.  (I know this was copied from elsewhere in the file.)


> +    if is_implementation_file:
> +	   for current_line in clean_lines.raw_lines[line_number + 1:]:
> +	       line_offset += 1
> +
> +	       # Skip not only empty lines but also those with (goto) labels.

You should be able to hit a goto label before you hit other code and break out
of this, but no big deal.  Maybe it is useful to leave this in case we decide
to extend this function to not have the break.


> diff --git a/WebKitTools/Scripts/modules/cpplint_unittest.py
b/WebKitTools/Scripts/modules/cpplint_unittest.py

> +	   self.assert_multi_line_lint(
> +	       'namespace WebCore {\n\n'
> +	       'bool Document::Foo() {}\n'
> +	       '    return true;\n'

It would be nice to have valid code.  Something like this:

	    'bool Document::Foo()\n'
	    '{\n'
	    '	 return true;\n'
	    '}',

> +	       '}',
> +	       '',
> +	       'foo.cpp')
> +	   self.assert_multi_line_lint(
> +	       'namespace OuterNamespace {\n'
> +	       'namespace InnerNamespace {\n'
> +	       'Document::Foo() { }\n'
> +	       '}',
> +	       '',
> +	       'foo.cpp')
> +	   self.assert_multi_line_lint(
> +	       '    namespace WebCore {\n\n'
> +	       '    void Document::Foo() {}\n'
> +	       'start:	// infinite loops are fun!\n'
> +	       '	goto start;\n'
Invalid code.

> +	       '    }',
> +	       '',
> +	       'foo.cpp')

From bugzilla-daemon at webkit.org  Tue Jul 21 09:47:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:47:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27506] Fixed typo :
 [Attachment 33184] proposed patch
In-Reply-To: <bug-27506-0@https.bugs.webkit.org/>
References: <bug-27506-0@https.bugs.webkit.org/>
Message-ID: <20090721164732.589FF33D63E7@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Robert Agoston
<Agoston.Robert at stud.u-szeged.hu>'s request for review:
Bug 27506: Fixed typo
https://bugs.webkit.org/show_bug.cgi?id=27506

Attachment 33184: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33184&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 09:52:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:52:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27397] [V8] V8IsolatedWorld
 keeps a handle to a disposed context : [Attachment 33164] patch
In-Reply-To: <bug-27397-0@https.bugs.webkit.org/>
References: <bug-27397-0@https.bugs.webkit.org/>
Message-ID: <20090721165238.0A0AB33D64B1@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27397: [V8] V8IsolatedWorld keeps a handle to a disposed context
https://bugs.webkit.org/show_bug.cgi?id=27397

Attachment 33164: patch
https://bugs.webkit.org/attachment.cgi?id=33164&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Mads Ager says this looks good and he know this a lot better than I do.

No style issues. So I'll rubber stamp it based on his review.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:57:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:57:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33165] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090721165710.975E133D6556@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33165: Patch
https://bugs.webkit.org/attachment.cgi?id=33165&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
The code looks good, but when you add a file to the project, you should really
add it to all the build systems.  I think you've missed WebCore.gypi for
example.   You should find "ScriptSourceCode.h" and make sure your new file
shows up in all the same places.

From bugzilla-daemon at webkit.org  Tue Jul 21 09:57:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 09:57:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33185] Add checks for
 namespace indentation to cpplint (try 6)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721165759.21D8933D6583@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33185: Add checks for namespace indentation to cpplint (try 6)
https://bugs.webkit.org/attachment.cgi?id=33185&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Above issues fixed, apart from the one more goto label stuff. Newbie question:
is it ok to repost a new patch as r+ if it was already reviewed with r+ before
(and I only made slight changes like these)?

From bugzilla-daemon at webkit.org  Tue Jul 21 10:07:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 10:07:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24602] [Gtk] Searching in
 thepiratebay.org doesn't work with more than 1 word : [Attachment 33172]
 webkit-bug-24602-drop-workaround.patch
In-Reply-To: <bug-24602-0@https.bugs.webkit.org/>
References: <bug-24602-0@https.bugs.webkit.org/>
Message-ID: <20090721170708.1FB1533D66A9@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 24602: [Gtk] Searching in thepiratebay.org doesn't work with more than 1
word
https://bugs.webkit.org/show_bug.cgi?id=24602

Attachment 33172: webkit-bug-24602-drop-workaround.patch
https://bugs.webkit.org/attachment.cgi?id=33172&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
looks good r=me

From bugzilla-daemon at webkit.org  Tue Jul 21 10:11:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 10:11:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27461] Add checks for
 namespace indentation to cpplint : [Attachment 33185] Add checks for
 namespace indentation to cpplint (try 6)
In-Reply-To: <bug-27461-0@https.bugs.webkit.org/>
References: <bug-27461-0@https.bugs.webkit.org/>
Message-ID: <20090721171141.4582333D675F@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27461: Add checks for namespace indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27461

Attachment 33185: Add checks for namespace indentation to cpplint (try 6)
https://bugs.webkit.org/attachment.cgi?id=33185&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Sure posting a new patch like this is fine.  (It would be easier if there was
diff between patches :) but that may come one day in the not too distant
future).

From bugzilla-daemon at webkit.org  Tue Jul 21 10:19:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 10:19:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27478] All
 DOMConstructorObjects should hold a pointer to the JSDOMGlobalObject :
 [Attachment 33140] Update patch
In-Reply-To: <bug-27478-0@https.bugs.webkit.org/>
References: <bug-27478-0@https.bugs.webkit.org/>
Message-ID: <20090721171906.24CA933D6869@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27478: All DOMConstructorObjects should hold a pointer to the
JSDOMGlobalObject
https://bugs.webkit.org/show_bug.cgi?id=27478

Attachment 33140: Update patch
https://bugs.webkit.org/attachment.cgi?id=33140&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is awesome.	Redundant code: BE GONE!

+	 I've added two new classes: DOMObjectWithGlobalPointer and
DOMConstructorObjectInDocument.

The ChangeLog uses the old class names.

+    class DOMConstructorWithDocument : public DOMConstructorObject {
+    public:
+	 Document* document() const
+	 {
+	     return static_cast<Document*>(scriptExecutionContext());
+	 }
+    protected:

Missing a blank line here.

From bugzilla-daemon at webkit.org  Tue Jul 21 10:30:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 10:30:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33132] Only add Cygwin to PATH when
 necessary (attempt #2)
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090721173041.06CEC33D6A2C@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33132: Only add Cygwin to PATH when necessary (attempt #2)
https://bugs.webkit.org/attachment.cgi?id=33132&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Here's the cleaned version.

From bugzilla-daemon at webkit.org  Tue Jul 21 10:30:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 10:30:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33186] Only add Cygwin to PATH when
 necessary (attempt #2)
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090721173041.43AAD33D6A32@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked Steve Falkenburg
<sfalken at apple.com> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33186: Only add Cygwin to PATH when necessary (attempt #2)
https://bugs.webkit.org/attachment.cgi?id=33186&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Here's the cleaned version.

From bugzilla-daemon at webkit.org  Tue Jul 21 10:50:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 10:50:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27462] Add cpplint check
 for proper include order : [Attachment 33187] More changes reflecting
 comments
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721175020.61D6233D6DAC@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33187: More changes reflecting comments
https://bugs.webkit.org/attachment.cgi?id=33187&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
New version reflecting the state of the review conversation.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:01:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:01:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27425] adding
 GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 33188] adds
 gdomhtmlelementwrapperfactory with better ChangeLog
In-Reply-To: <bug-27425-0@https.bugs.webkit.org/>
References: <bug-27425-0@https.bugs.webkit.org/>
Message-ID: <20090721180118.5448833D6F34@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27425: adding GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425

Attachment 33188: adds gdomhtmlelementwrapperfactory with better ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33188&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
revised patch, updated ChangeLog explaining why it's not autogenerated at the
moment etc. corrected spelling.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:09:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:09:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27462] Add cpplint check
 for proper include order : [Attachment 33191] New version that special
 cases 'FooCustom.cpp'
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721180902.A2FD133D6FF6@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33191: New version that special cases 'FooCustom.cpp'
https://bugs.webkit.org/attachment.cgi?id=33191&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
New version that special cases 'FooCustom.cpp' as discussed on IRC.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:09:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:09:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27462] Add cpplint check for
 proper include order : [Attachment 33187] More changes reflecting comments
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721180902.9239933D6FF4@gamma.macosforge.org>

Adam Treat <treat at kde.org> has canceled Adam Treat <treat at kde.org>'s request
for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33187: More changes reflecting comments
https://bugs.webkit.org/attachment.cgi?id=33187&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
New version that special cases 'FooCustom.cpp' as discussed on IRC.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:11:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:11:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27462] Add cpplint check for
 proper include order : [Attachment 33191] New version that special cases
 'FooCustom.cpp'
In-Reply-To: <bug-27462-0@https.bugs.webkit.org/>
References: <bug-27462-0@https.bugs.webkit.org/>
Message-ID: <20090721181154.21DD933D7049@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27462: Add cpplint check for proper include order
https://bugs.webkit.org/show_bug.cgi?id=27462

Attachment 33191: New version that special cases 'FooCustom.cpp'
https://bugs.webkit.org/attachment.cgi?id=33191&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Would be nice to make s small adjustment on landing.

> +		   if filename.endswith('.h'):
> +		       error(filename, line_number, 'build/include_order', 4,
> +			     '%s Should be: alphabetically sorted.' %
> +			     (error_message))
No need for parens on error_message (since it is a single element).

Btw, wierd python-ism: the parens do nothing here :) 
to make it a tuple with one element you'd have to do this: (error_message,)
 


> +		   else:
> +		       error(filename, line_number, 'build/include_order', 4,
> +			     '%s Should be: config.h, primary header, blank
line, and then alphabetically sorted.' %
> +			     (error_message))

Same comment about (error_message)

From bugzilla-daemon at webkit.org  Tue Jul 21 11:23:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:23:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27437] make
 HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based
 standards under gobject bindings : [Attachment 33192] makes
 HTMLAppletElement and HTMLEmbedElement width and height DOMString except
 for Obj-C bindings
In-Reply-To: <bug-27437-0@https.bugs.webkit.org/>
References: <bug-27437-0@https.bugs.webkit.org/>
Message-ID: <20090721182337.6D82733D7202@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33192: makes HTMLAppletElement and HTMLEmbedElement width and height
DOMString except for Obj-C bindings
https://bugs.webkit.org/attachment.cgi?id=33192&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
is this better?

From bugzilla-daemon at webkit.org  Tue Jul 21 11:38:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:38:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 32988] 3rd patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090721183829.E581733D7408@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32988: 3rd patch
https://bugs.webkit.org/attachment.cgi?id=32988&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r+ b/c this broke the build and marking as obsolete.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:38:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:38:57 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 32985] 2nd patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090721183857.76DE733D7418@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 32985: 2nd patch
https://bugs.webkit.org/attachment.cgi?id=32985&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r+ to make this not show up in the commit queue.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:42:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:42:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27436] gobject bindings
 need access to keyCode on KeyboardEvents! : [Attachment 33193] comments out
 only the 2nd initKeyboardEvent function on LANGUAGE_GOBJECT
In-Reply-To: <bug-27436-0@https.bugs.webkit.org/>
References: <bug-27436-0@https.bugs.webkit.org/>
Message-ID: <20090721184225.C27C633D7490@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27436: gobject bindings need access to keyCode on KeyboardEvents!
https://bugs.webkit.org/show_bug.cgi?id=27436

Attachment 33193: comments out only the 2nd initKeyboardEvent function on
LANGUAGE_GOBJECT
https://bugs.webkit.org/attachment.cgi?id=33193&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
probably a good idea to look at #27437 this likely needs discussion, i'm happy
to submit necessary patches to keep Obj-C happy but don't have the expertise to
say what is what, here - just let me know what needs to be done.  i do know
however that you can't have two versions of the same c function which is why
one of the initKeyboardEvent functions _has_ to be #ifdef'd out.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:42:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:42:25 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27436] gobject bindings need
 access to keyCode on KeyboardEvents! : [Attachment 33065] enables access to
 keyCode and charCode properties and W3C-compliant initKeyboardEvent
 function under gobject language bindings
In-Reply-To: <bug-27436-0@https.bugs.webkit.org/>
References: <bug-27436-0@https.bugs.webkit.org/>
Message-ID: <20090721184225.A81A733D748E@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has canceled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 27436: gobject bindings need access to keyCode on KeyboardEvents!
https://bugs.webkit.org/show_bug.cgi?id=27436

Attachment 33065: enables access to keyCode and charCode properties and
W3C-compliant initKeyboardEvent function under gobject language bindings
https://bugs.webkit.org/attachment.cgi?id=33065&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
probably a good idea to look at #27437 this likely needs discussion, i'm happy
to submit necessary patches to keep Obj-C happy but don't have the expertise to
say what is what, here - just let me know what needs to be done.  i do know
however that you can't have two versions of the same c function which is why
one of the initKeyboardEvent functions _has_ to be #ifdef'd out.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:44:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:44:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27383] [Chromium] Hook up
 V8 bindings for DataGrid elements : [Attachment 33194] Patch,
 with missing file added
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090721184440.C7CDE33D74DF@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 33194: Patch, with missing file added
https://bugs.webkit.org/attachment.cgi?id=33194&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
This is the patch that I mistakenly added to 27407 yesterday; sorry about that.

I've also added the '//' after '#endif'.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:47:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:47:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20797] add Settings entries
 for per-script/lang generic family : [Attachment 33195] patch updated
 (macro expanded)
In-Reply-To: <bug-20797-0@https.bugs.webkit.org/>
References: <bug-20797-0@https.bugs.webkit.org/>
Message-ID: <20090721184702.2E0E333D7530@gamma.macosforge.org>

Jungshik Shin <jshin at chromium.org> has asked  for review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 33195: patch updated (macro expanded)
https://bugs.webkit.org/attachment.cgi?id=33195&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Thank you for taking a look and sorry for this terrible delay. I've always had
this issue in mind, but somehow I missed the review comment. 

This patch now has font setters and getters that are expanded out of macros.
UScriptCode.h for ports (not using ICU) has
the latest script code available from ICU 4.2.1 (Unicode 5.1).

From bugzilla-daemon at webkit.org  Tue Jul 21 11:49:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:49:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20797] add Settings entries
 for per-script/lang generic family : [Attachment 33195] patch updated
 (macro expanded)
In-Reply-To: <bug-20797-0@https.bugs.webkit.org/>
References: <bug-20797-0@https.bugs.webkit.org/>
Message-ID: <20090721184957.ADD0433D7572@gamma.macosforge.org>

Jungshik Shin <jshin at chromium.org> has asked Maciej Stachowiak <mjs at apple.com>
for review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 33195: patch updated (macro expanded)
https://bugs.webkit.org/attachment.cgi?id=33195&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Maciej, if you could take another look, that'd be great.  Thanks for taking a
look earlier and in advance and sorry again for the delay.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:54:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:54:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27508] Add checks for
 switch statement indentation to cpplint : [Attachment 33196] Add checks for
 switch statement indentation to cpplint
In-Reply-To: <bug-27508-0@https.bugs.webkit.org/>
References: <bug-27508-0@https.bugs.webkit.org/>
Message-ID: <20090721185423.2FAD533D7613@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33196: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/attachment.cgi?id=33196&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Switch statements have strong similarities to namespaces when it comes to
indentation, so I stole from my previous patch
(https://bugs.webkit.org/show_bug.cgi?id=27461) and adapted some parts to
implement style guideline #5 from http://webkit.org/coding/coding-style.html to
cpplint. Looking for a motivated reviewer, hope you like it!

From bugzilla-daemon at webkit.org  Tue Jul 21 11:59:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:59:31 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27508] Add checks for switch
 statement indentation to cpplint : [Attachment 33196] Add checks for switch
 statement indentation to cpplint
In-Reply-To: <bug-27508-0@https.bugs.webkit.org/>
References: <bug-27508-0@https.bugs.webkit.org/>
Message-ID: <20090721185931.AA6C133D76A6@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33196: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/attachment.cgi?id=33196&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Note to self: Don't post patch files unless bug report is created and URL is
inserted into the ChangeLog.
Apart from that, same patch as the previous one.

From bugzilla-daemon at webkit.org  Tue Jul 21 11:59:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 11:59:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27508] Add checks for
 switch statement indentation to cpplint : [Attachment 33197] Add checks for
 switch statement indentation to cpplint
In-Reply-To: <bug-27508-0@https.bugs.webkit.org/>
References: <bug-27508-0@https.bugs.webkit.org/>
Message-ID: <20090721185931.CFB1133D76AA@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33197: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/attachment.cgi?id=33197&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Note to self: Don't post patch files unless bug report is created and URL is
inserted into the ChangeLog.
Apart from that, same patch as the previous one.

From bugzilla-daemon at webkit.org  Tue Jul 21 12:16:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:16:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27508] Add checks for switch
 statement indentation to cpplint : [Attachment 33197] Add checks for switch
 statement indentation to cpplint
In-Reply-To: <bug-27508-0@https.bugs.webkit.org/>
References: <bug-27508-0@https.bugs.webkit.org/>
Message-ID: <20090721191609.EF59733D78C4@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33197: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/attachment.cgi?id=33197&action=review

------- Additional Comments from David Levin <levin at chromium.org>
In general it looks good but I think it will have problems on nested switch
statements. What can be done about that?

From bugzilla-daemon at webkit.org  Tue Jul 21 12:18:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:18:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33067] adds toString to
 gobject bindings
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090721191819.3858D33D791E@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33067: adds toString to gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33067&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
come on, mark - the burden on developers to "recreate" toString is immense. 
every language-bindings developer will have to create a secondary wrapper,
doing something like this:

def toString(element):
    if ENGINE.type != "webkit":
	return element.toString()

    # ok, xulrunner and MSHTML have toString,
    # but webkit's team are being a pain, forcing
    # us to work out what the element type is
    # and... never mind, let's just get on with it

    # first determine what type of element this is
    if hasattr(element, "nodetype"):
       # ok it's likely to be an HTML element.
       # now we work out if it's a comment
       # etc. etc.
       if element.nodetype == 1:
	   # ok, it's an HTML element.
	   nodename = element.nodename
	   return "<%s>" % nodename +
		  element.innerHTML +
		  "</%s>" % nodename

    # ok, it wasn't an HTML element - is
    # it an exception?	let's guess...
    
    if hasattr(element, "message") and
       hasattr(element, "name"):

	# ok - exceptions have name and
	# message.

	return element.name + element.message

    # ok, what about DOMSelection?

    # etc.

    # etc.



so you can see that to burden even _one_ dynamic
language with this kind of stuff is just absolutely
ridiculous - and that's just one application.

all applications will need to apply this same
awful trick - i don't dare to think what a mess
of spaghetti code there would be if someone
wanted to do this in native c!

all that spaghetti goes away if there are toString
functions which can be assumed to be in each of
the objects.  in the case of the pyjamas API
which uses pywebkitgtk, python takes care of
the mapping, and it's a 2-line function:

def toString(element):
    return element.toString()


if these functions weren't available to all language bindings in XULrunner,
KHTML and MSHTML, i wouldn't be pushing this issue - yes, i'd simply not bother
and would even consider removing toString from the pyjamas API, and let users
get on with it.

but - it's there, and it's in the GWT API so we have to conform with it.

so, very sorry, but i'm re-raising the review flag until this is properly
looked at.

an answer "yes we have looked at the research material which shows yes that the
all of the current web browser competitor technology to webkit can clearly seen
to support the fact that toString is part of de-facto standards... <complete
sentence>" is what i expect.

if there is anything which does not mention "the research material has been
examined" i will instantly re-submit the patch for review.

sorry.

From bugzilla-daemon at webkit.org  Tue Jul 21 12:18:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:18:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27509] Add WinCE specific
 font files to WebCore : [Attachment 33198] font related files
In-Reply-To: <bug-27509-0@https.bugs.webkit.org/>
References: <bug-27509-0@https.bugs.webkit.org/>
Message-ID: <20090721191833.CADF733D7929@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27509: Add WinCE specific font files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27509

Attachment 33198: font related files
https://bugs.webkit.org/attachment.cgi?id=33198&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 12:23:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:23:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27420] Refactor
 WorkerContext to move DedicatedWorker-specific APIs into
 DedicatedWorkerContext : [Attachment 33068] Patch addressing levin's
 comments
In-Reply-To: <bug-27420-0@https.bugs.webkit.org/>
References: <bug-27420-0@https.bugs.webkit.org/>
Message-ID: <20090721192305.F154C33D79C1@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

Attachment 33068: Patch addressing levin's comments
https://bugs.webkit.org/attachment.cgi?id=33068&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'm marking this obsolete to move it out of the review queue because I'm fairly
certain atwilson is doing some fixes to it.  Drew if I got this wrong please
undo this :)

From bugzilla-daemon at webkit.org  Tue Jul 21 12:26:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:26:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27432] add read-write
 access to HTMLOptionElement text under GObject bindings : [Attachment
 33061] patch to make HTMLOptionElement text property read-write under
 gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090721192646.8723633D7A29@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
sorry, mark, but the reality is that existing applications expect to be able to
change text in <option> - that's supported _now_, not "in the future".

when webkit's javascript bindings remove write access to text, _then_ is the
time for the gobject bindings to _also_ have write access to text removed.

so whatever reasons apply to javascript supporting write-access to this
property, the exact same argument applies to the gobject bindings.

review- denied.  re-enabling review.  answer in next review is expected which
takes the above line of reasoning into account.

From bugzilla-daemon at webkit.org  Tue Jul 21 12:31:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:31:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27497] Feature request:
 cpplint should check for braces - rule 2 : [Attachment 33199] Add support
 for making sure { is on the same line as foreach
In-Reply-To: <bug-27497-0@https.bugs.webkit.org/>
References: <bug-27497-0@https.bugs.webkit.org/>
Message-ID: <20090721193122.DD96A33D7ADE@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked Adam
Treat <treat at kde.org> for review:
Bug 27497: Feature request: cpplint should check for braces - rule 2
https://bugs.webkit.org/show_bug.cgi?id=27497

Attachment 33199: Add support for making sure { is on the same line as foreach
https://bugs.webkit.org/attachment.cgi?id=33199&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 12:33:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:33:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27497] Feature request:
 cpplint should check for braces - rule 2 : [Attachment 33199] Add support
 for making sure { is on the same line as foreach
In-Reply-To: <bug-27497-0@https.bugs.webkit.org/>
References: <bug-27497-0@https.bugs.webkit.org/>
Message-ID: <20090721193328.1378333D7B24@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27497: Feature request: cpplint should check for braces - rule 2
https://bugs.webkit.org/show_bug.cgi?id=27497

Attachment 33199: Add support for making sure { is on the same line as foreach
https://bugs.webkit.org/attachment.cgi?id=33199&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 12:39:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:39:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27508] Add checks for
 switch statement indentation to cpplint : [Attachment 33200] Add checks for
 switch statement indentation to cpplint (try 3)
In-Reply-To: <bug-27508-0@https.bugs.webkit.org/>
References: <bug-27508-0@https.bugs.webkit.org/>
Message-ID: <20090721193921.CB54C33D7BEE@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33200: Add checks for switch statement indentation to cpplint (try
3)
https://bugs.webkit.org/attachment.cgi?id=33200&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Good point, I had not thought of that case. Here's a relatively simple solution
that'll work in pretty much all common cases, approach explained in the code
comments. Plus more test cases. Is that good enough, or does it need to be
perfect?

From bugzilla-daemon at webkit.org  Tue Jul 21 12:47:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:47:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27510] [S60 QtWebKit] Don't
 put some intermediate generated files into the final mmp project file for
 linking. : [Attachment 33201] Point variable_out properties of effected
 custom compilers to empty,
 to avoid putting generated files into mmp project file.
In-Reply-To: <bug-27510-0@https.bugs.webkit.org/>
References: <bug-27510-0@https.bugs.webkit.org/>
Message-ID: <20090721194710.C471B33D7D17@gamma.macosforge.org>

Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 27510: [S60 QtWebKit] Don't put some intermediate generated files into the
final mmp project file for linking.
https://bugs.webkit.org/show_bug.cgi?id=27510

Attachment 33201: Point variable_out properties of effected custom compilers to
empty, to avoid putting generated files into mmp project file.
https://bugs.webkit.org/attachment.cgi?id=33201&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 12:56:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 12:56:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27509] Add WinCE specific font
 files to WebCore : [Attachment 33198] font related files
In-Reply-To: <bug-27509-0@https.bugs.webkit.org/>
References: <bug-27509-0@https.bugs.webkit.org/>
Message-ID: <20090721195635.9DCB733D7E4A@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27509: Add WinCE specific font files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27509

Attachment 33198: font related files
https://bugs.webkit.org/attachment.cgi?id=33198&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
The file that has (C) Torch Mobile but an Apple BSD License should actually be
LGPL license, unless it happens to have some code copied from another file
which was Apple BSD licensed in which case it should also have Apple (C)
listed.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:00:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:00:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33202] graphics files for
 WINCE port
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090721200040.EED0C33D7EB9@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33202: graphics files for WINCE port
https://bugs.webkit.org/attachment.cgi?id=33202&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
not including font-related files

From bugzilla-daemon at webkit.org  Tue Jul 21 13:01:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:01:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27508] Add checks for switch
 statement indentation to cpplint : [Attachment 33200] Add checks for switch
 statement indentation to cpplint (try 3)
In-Reply-To: <bug-27508-0@https.bugs.webkit.org/>
References: <bug-27508-0@https.bugs.webkit.org/>
Message-ID: <20090721200136.C8D0533D7EF9@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27508: Add checks for switch statement indentation to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27508

Attachment 33200: Add checks for switch statement indentation to cpplint (try
3)
https://bugs.webkit.org/attachment.cgi?id=33200&action=review

------- Additional Comments from David Levin <levin at chromium.org>
This is an improvement over what we have now and seems to minimize the
possibility of false alarms (with respect to nested switch statements), so it
seems like a positive step forward.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:08:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:08:31 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33202] graphics files for
 WINCE port
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090721200831.82E1F33D8019@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33202: graphics files for WINCE port
https://bugs.webkit.org/attachment.cgi?id=33202&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Same issue here - LGPL license on files that are entirely new by Torch.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:27:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:27:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27371] [WINCE] Add WinCE
 specific platform/text files to WebCore : [Attachment 33203] Latest version
 with latest cpplint cleanup
In-Reply-To: <bug-27371-0@https.bugs.webkit.org/>
References: <bug-27371-0@https.bugs.webkit.org/>
Message-ID: <20090721202735.43F5B33D81FA@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27371: [WINCE] Add WinCE specific platform/text files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27371

Attachment 33203: Latest version with latest cpplint cleanup
https://bugs.webkit.org/attachment.cgi?id=33203&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
This version also has all licensing info included in the patch files.  They are
all compatible.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:27:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:27:35 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27371] [WINCE] Add WinCE
 specific platform/text files to WebCore : [Attachment 33103] code clean-up
In-Reply-To: <bug-27371-0@https.bugs.webkit.org/>
References: <bug-27371-0@https.bugs.webkit.org/>
Message-ID: <20090721202735.2C81833D81F8@gamma.macosforge.org>

Adam Treat <treat at kde.org> has canceled Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27371: [WINCE] Add WinCE specific platform/text files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27371

Attachment 33103: code clean-up
https://bugs.webkit.org/attachment.cgi?id=33103&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
This version also has all licensing info included in the patch files.  They are
all compatible.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:28:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:28:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33204] Broken out
 ResourceHandleWince into own patch
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090721202822.985CA33D8211@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33204: Broken out ResourceHandleWince into own patch
https://bugs.webkit.org/attachment.cgi?id=33204&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Checked with latest cpplint and passes.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:29:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:29:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33205] The rest of
 WebCore/platform/network/wince
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090721202919.9508B33D8232@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33205: The rest of WebCore/platform/network/wince
https://bugs.webkit.org/attachment.cgi?id=33205&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Also checked with latest cpplint and passes.  The licensing info of third-party
code is also clearly marked.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:31:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:31:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33206] The rest of
 WebCore/platform/network/wince (v2)
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090721203123.9978F33D827C@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33206: The rest of WebCore/platform/network/wince (v2)
https://bugs.webkit.org/attachment.cgi?id=33206&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 13:31:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:31:23 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27376] [WINCE] Add WinCE
 specific files for platform/network : [Attachment 33205] The rest of
 WebCore/platform/network/wince
In-Reply-To: <bug-27376-0@https.bugs.webkit.org/>
References: <bug-27376-0@https.bugs.webkit.org/>
Message-ID: <20090721203123.87F1533D827A@gamma.macosforge.org>

Adam Treat <treat at kde.org> has canceled Adam Treat <treat at kde.org>'s request
for review:
Bug 27376: [WINCE] Add WinCE specific files for platform/network
https://bugs.webkit.org/show_bug.cgi?id=27376

Attachment 33205: The rest of WebCore/platform/network/wince
https://bugs.webkit.org/attachment.cgi?id=33205&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 13:38:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:38:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27512] Test for
 QWebFrame::hasSetFocus() is trying to use a not defined resource. :
 [Attachment 33207] Copied resources from qwebpage tests and added the
 references to the qwebframe.qrc.
In-Reply-To: <bug-27512-0@https.bugs.webkit.org/>
References: <bug-27512-0@https.bugs.webkit.org/>
Message-ID: <20090721203814.EA6D033D8382@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has asked	for review:
Bug 27512: Test for QWebFrame::hasSetFocus() is trying to use a not defined
resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

Attachment 33207: Copied resources from qwebpage tests and added the references
to the qwebframe.qrc.
https://bugs.webkit.org/attachment.cgi?id=33207&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 13:39:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:39:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27513] [Chromium] Linux:
 add static functions to FontPlatformData which allow for setting the global
 font rendering preferences. : [Attachment 33208] patch
In-Reply-To: <bug-27513-0@https.bugs.webkit.org/>
References: <bug-27513-0@https.bugs.webkit.org/>
Message-ID: <20090721203938.A6FB433D83AE@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27513: [Chromium] Linux: add static functions to FontPlatformData which
allow for setting the global font rendering preferences.
https://bugs.webkit.org/show_bug.cgi?id=27513

Attachment 33208: patch
https://bugs.webkit.org/attachment.cgi?id=33208&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 13:52:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:52:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27419] Storing a reference
 to WorkerContext.postMessage() and calling it later yields a TypeError :
 [Attachment 33209] proposed patch
In-Reply-To: <bug-27419-0@https.bugs.webkit.org/>
References: <bug-27419-0@https.bugs.webkit.org/>
Message-ID: <20090721205248.C1E5133D8556@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27419: Storing a reference to WorkerContext.postMessage() and calling it
later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

Attachment 33209: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33209&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
This is dependent on 27420 as it relies on the IsWorkerContext attribute added
in that patch.

From bugzilla-daemon at webkit.org  Tue Jul 21 13:58:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 13:58:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27509] Add WinCE specific
 font files to WebCore : [Attachment 33210] coding style fixes by using
 cpplint and license text
In-Reply-To: <bug-27509-0@https.bugs.webkit.org/>
References: <bug-27509-0@https.bugs.webkit.org/>
Message-ID: <20090721205806.7C9E833D864E@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27509: Add WinCE specific font files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27509

Attachment 33210: coding style fixes by using cpplint and license text
https://bugs.webkit.org/attachment.cgi?id=33210&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:00:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:00:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27515] Implement
 AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent. :
 [Attachment 33211] Proposed Patch
In-Reply-To: <bug-27515-0@https.bugs.webkit.org/>
References: <bug-27515-0@https.bugs.webkit.org/>
Message-ID: <20090721210005.12BF033D869E@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27515: Implement AbstractWorker::dispatchScriptErrorEvent by generating an
ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27515

Attachment 33211: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33211&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:05:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:05:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33212] v1
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090721210538.C2CEA33D872A@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33212: v1
https://bugs.webkit.org/attachment.cgi?id=33212&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
The StorageAreaImpl changes are all for Chromium.  Because the DOM Storage
implementation runs in a different process from where the Frame object lives,
Chromium passes in NULL for the sourceFrame.  This affects events and handling
privateBrowsing.  Chromium's incognito mode does not use the private browsing
setting, so that's not a concern.  As for events, I've decided to simply
disable them for now.

The StorageNamespaceImpl changes get rid of a stale comment (path is .copy'ed
for thread-safety) and to add an assert that .copy is only ever called on a
SessionStorage namespace.

From bugzilla-daemon at webkit.org  Tue Jul 21 14:09:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:09:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27496] Feature request:
 cpplint should check for indentation - rule 6 : [Attachment 33213] Add
 checks for multi-line boolean operator placement
In-Reply-To: <bug-27496-0@https.bugs.webkit.org/>
References: <bug-27496-0@https.bugs.webkit.org/>
Message-ID: <20090721210924.C101633D879F@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27496: Feature request: cpplint should check for indentation - rule 6
https://bugs.webkit.org/show_bug.cgi?id=27496

Attachment 33213: Add checks for multi-line boolean operator placement
https://bugs.webkit.org/attachment.cgi?id=33213&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
...like this? Seems the new check caught an issue in cpplint_unittest.py itself
:P

From bugzilla-daemon at webkit.org  Tue Jul 21 14:11:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:11:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27516] Add onerror to
 WorkerContext. : [Attachment 33214] Proposed Patch
In-Reply-To: <bug-27516-0@https.bugs.webkit.org/>
References: <bug-27516-0@https.bugs.webkit.org/>
Message-ID: <20090721211140.4678633D87FC@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27516: Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

Attachment 33214: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33214&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:13:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:13:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27509] Add WinCE specific
 font files to WebCore : [Attachment 33210] coding style fixes by using
 cpplint and license text
In-Reply-To: <bug-27509-0@https.bugs.webkit.org/>
References: <bug-27509-0@https.bugs.webkit.org/>
Message-ID: <20090721211348.7BE8B33D884E@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27509: Add WinCE specific font files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27509

Attachment 33210: coding style fixes by using cpplint and license text
https://bugs.webkit.org/attachment.cgi?id=33210&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:36:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:36:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27518] [V8] Add V8 bindings
 for onerror in WorkerContext. : [Attachment 33215] Proposed Patch
In-Reply-To: <bug-27518-0@https.bugs.webkit.org/>
References: <bug-27518-0@https.bugs.webkit.org/>
Message-ID: <20090721213618.147DC33D8B05@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27518: [V8] Add V8 bindings for onerror in WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27518

Attachment 33215: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33215&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:39:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:39:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27496] Feature request:
 cpplint should check for indentation - rule 6 : [Attachment 33213] Add
 checks for multi-line boolean operator placement
In-Reply-To: <bug-27496-0@https.bugs.webkit.org/>
References: <bug-27496-0@https.bugs.webkit.org/>
Message-ID: <20090721213947.650FB33D8B7E@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27496: Feature request: cpplint should check for indentation - rule 6
https://bugs.webkit.org/show_bug.cgi?id=27496

Attachment 33213: Add checks for multi-line boolean operator placement
https://bugs.webkit.org/attachment.cgi?id=33213&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:53:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:53:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27518] [V8] Add V8 bindings
 for onerror in WorkerContext. : [Attachment 33215] Proposed Patch
In-Reply-To: <bug-27518-0@https.bugs.webkit.org/>
References: <bug-27518-0@https.bugs.webkit.org/>
Message-ID: <20090721215329.7C38333D8D6B@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27518: [V8] Add V8 bindings for onerror in WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27518

Attachment 33215: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33215&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:57:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:57:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27480] REGRESSION (r46142):
 editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in
 Windows build : [Attachment 33216] fixes the bug in Position.h
In-Reply-To: <bug-27480-0@https.bugs.webkit.org/>
References: <bug-27480-0@https.bugs.webkit.org/>
Message-ID: <20090721215734.BAED033D8E22@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27480: REGRESSION (r46142):  editing/execCommand/19087.html &
editing/execCommand/19653-1.html fail in Windows build
https://bugs.webkit.org/show_bug.cgi?id=27480

Attachment 33216: fixes the bug in Position.h
https://bugs.webkit.org/attachment.cgi?id=33216&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 14:59:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 14:59:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27480] REGRESSION (r46142):
 editing/execCommand/19087.html & editing/execCommand/19653-1.html fail in
 Windows build : [Attachment 33216] fixes the bug in Position.h
In-Reply-To: <bug-27480-0@https.bugs.webkit.org/>
References: <bug-27480-0@https.bugs.webkit.org/>
Message-ID: <20090721215911.BC6B433D8E44@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27480: REGRESSION (r46142):  editing/execCommand/19087.html &
editing/execCommand/19653-1.html fail in Windows build
https://bugs.webkit.org/show_bug.cgi?id=27480

Attachment 33216: fixes the bug in Position.h
https://bugs.webkit.org/attachment.cgi?id=33216&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Fix the Tabs in the ChangeLog, and then this is fine.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:09:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:09:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27521] Move m_context out
 of generator into superclass : [Attachment 33217] patch
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090721220959.3F2AE33D8F95@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33217: patch
https://bugs.webkit.org/attachment.cgi?id=33217&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 15:12:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:12:11 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27516] Add onerror to
 WorkerContext. : [Attachment 33214] Proposed Patch
In-Reply-To: <bug-27516-0@https.bugs.webkit.org/>
References: <bug-27516-0@https.bugs.webkit.org/>
Message-ID: <20090721221211.45BF033D9011@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 27516: Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

Attachment 33214: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33214&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to clean up.


> diff --git a/WebCore/workers/WorkerContext.h
b/WebCore/workers/WorkerContext.h

> +	   RefPtr<EventListener> m_onErrorListener;

Should be "m_onerrorListener" because onerror seems to consistently treated as
one word.



> diff --git a/WebCore/workers/WorkerContext.idl
b/WebCore/workers/WorkerContext.idl
>  #if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> -		    attribute [Replaceable] WorkerContext self;
> +	   attribute [Replaceable] WorkerContext self;

Don't unindent these.  The idl formatting leaves room for "readonly " when it
isn't present which is why these are indented to this level.

>  #endif
> -		    attribute [Replaceable] WorkerLocation location;
> +	   attribute [Replaceable] WorkerLocation location;

Same unindenting comment.

>	   void close();
> -	   //	      attribute EventListener onerror;
> +	   attribute EventListener onerror;

Just uncomment but indent correctly.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:27:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:27:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27516] Add onerror to
 WorkerContext. : [Attachment 33218] Proposed Patch
In-Reply-To: <bug-27516-0@https.bugs.webkit.org/>
References: <bug-27516-0@https.bugs.webkit.org/>
Message-ID: <20090721222723.14A1333D9208@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27516: Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

Attachment 33218: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33218&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 15:28:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:28:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33219] Fix
 WebCore/DerivedSources.make "Duplicate value!" problem
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090721222806.696C133D9235@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33219: Fix WebCore/DerivedSources.make "Duplicate value!" problem
https://bugs.webkit.org/attachment.cgi?id=33219&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
This makes DerivedSources.make and make{prop,values}.pl a more permissive in
what kind of line endings they'll expect coming out of
WebCore/css/*CSSPropertyNames.in.

This may incidentally help the Apple developers who were having problems with
the "only add Cygwin to PATH when necessary" patch; I'm not sure.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:29:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:29:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33220] Update auto-version.sh to
 handle different line endings
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090721222922.C5F2F33D92C2@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked  for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33220: Update auto-version.sh to handle different line endings
https://bugs.webkit.org/attachment.cgi?id=33220&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
auto-version.sh had a couple different ways it could fail to deal with
different line endings, so this makes it handle them all correctly.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:31:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:31:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27516] Add onerror to
 WorkerContext. : [Attachment 33218] Proposed Patch
In-Reply-To: <bug-27516-0@https.bugs.webkit.org/>
References: <bug-27516-0@https.bugs.webkit.org/>
Message-ID: <20090721223110.4B80B33D9350@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27516: Add onerror to WorkerContext.
https://bugs.webkit.org/show_bug.cgi?id=27516

Attachment 33218: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33218&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 15:33:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:33:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33221] Implements $0, $1, $n
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090721223329.6280B33D93B3@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33221: Implements $0, $1, $n
https://bugs.webkit.org/attachment.cgi?id=33221&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
I've finally figured this out.

JSInspectorCallbackWrapper wraps the return value with
JSInspectorCallbackWrapper::wrapOutgoingValue. It wraps it as a
JSInspectorCallbackWrapper, which blocks getProperty, setProperty,
deleteProperty, construct, hasInstance, and getPropertyNames.

I think this is overkill for objects from the "inspected window" but a
necessary security measure for objects from the "inspector".

$0 - Variable containing the most recently inspected object .
$1 - Variable containing the next most recently inspected object .
$n(n) - Returns the nth most recently inspected object that has been inspected.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:47:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:47:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27523] Don't convert soft
 hyphens in selections into spaces : [Attachment 33222] patch
In-Reply-To: <bug-27523-0@https.bugs.webkit.org/>
References: <bug-27523-0@https.bugs.webkit.org/>
Message-ID: <20090721224723.66B3933D95EC@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked  for review:
Bug 27523: Don't convert soft hyphens in selections into spaces
https://bugs.webkit.org/show_bug.cgi?id=27523

Attachment 33222: patch
https://bugs.webkit.org/attachment.cgi?id=33222&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 15:48:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:48:42 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33221] Implements $0, $1, $n
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090721224842.1A3A733D9637@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33221: Implements $0, $1, $n
https://bugs.webkit.org/attachment.cgi?id=33221&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
The history limit seems to be 5 in firebug.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:48:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:48:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33223] set history limit to 5
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090721224842.3EECD33D963B@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33223: set history limit to 5
https://bugs.webkit.org/attachment.cgi?id=33223&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
The history limit seems to be 5 in firebug.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:56:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:56:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27521] Move m_context out of
 generator into superclass : [Attachment 33217] patch
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090721225611.3D74833D975D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33217: patch
https://bugs.webkit.org/attachment.cgi?id=33217&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good.  Perl is super ugly.

From bugzilla-daemon at webkit.org  Tue Jul 21 15:59:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 15:59:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24333]
 execCommand('underline') can modify DOM outside of the contentEditable area
 : [Attachment 33120] highestAncestorWithTextDecoration stops at an
 unsplittable element, and improves other text decorations support
In-Reply-To: <bug-24333-0@https.bugs.webkit.org/>
References: <bug-24333-0@https.bugs.webkit.org/>
Message-ID: <20090721225955.B51B733D97E1@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 24333: execCommand('underline') can modify DOM outside of the
contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Attachment 33120: highestAncestorWithTextDecoration stops at an unsplittable
element, and improves other text decorations support
https://bugs.webkit.org/attachment.cgi?id=33120&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This makes unrelated, possibly incorrect changes.  Please break this into
multiple patches with individual test cases.

See the test case on https://bugs.webkit.org/show_bug.cgi?id=20215, I think you
may have broken some of those cases here.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:03:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:03:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22784] [Chromium] Home, End,
 PageUp and PageDown buttons do not do anything in drop down lists :
 [Attachment 33224] Updated patch with test case
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090721230347.1EF4933D986C@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33224: Updated patch with test case
https://bugs.webkit.org/attachment.cgi?id=33224&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
This revised patch adds a layout test. (Note that the test checks the non-Mac
behavior, so it is expected to report failure on Mac; I've added a Mac-specific
expected output file reflecting this.)
Page Up/Down now jump by three, as in Neil Rhodes' related patch.
It also fixes the enum naming.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:07:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:07:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 33194] Patch,
 with missing file added
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090721230724.F0BEC33D98E0@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 33194: Patch, with missing file added
https://bugs.webkit.org/attachment.cgi?id=33194&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
Looks great overall, but there are some stylistic nits that should be fixed
before this is committed.  See below:


> Index: WebCore/bindings/v8/V8DOMWrapper.cpp
...
> +#if ENABLE(DATAGRID)
> +    case V8ClassIndex::DATAGRIDCOLUMNLIST:
> +	  
descriptor->InstanceTemplate()->SetIndexedPropertyHandler(USE_INDEXED_PROPERTY_
GETTER(DataGridColumnList));
> +	  
descriptor->InstanceTemplate()->SetNamedPropertyHandler(USE_NAMED_PROPERTY_GETT
ER(DataGridColumnList));
> +	   break;
> +#endif
> +	 default:
>	   break;

nit: 4 space indent


> +#if ENABLE(DATAGRID)
> +#define FOR_EACH_DATAGRID_TAG(macro) 	      \
> +  macro(datagrid, DATAGRID)			      \
> +  macro(dcell, DATAGRIDCELL) 		      \
> +  macro(dcol, DATAGRIDCOL)			      \
> +  macro(drow, DATAGRIDROW)

nit: 4 space indent


> Index: WebCore/bindings/v8/custom/V8DataGridColumnListCustom.cpp
...
> +#include "config.h"
> +#include "Document.h"
> +#include "DataGridColumnList.h"

^^^ See my comment below about the misplaced Document.h include.


> Index: WebCore/bindings/v8/custom/V8HTMLDataGridElementCustom.cpp
...
>  #include "config.h"
> +#include "Document.h"
>  #include "HTMLDataGridElement.h"

^^^ This doesn't match convention (I believe).	Ordinarily, you should
include config.h and then the header corresponding to the .cpp file.
Then there should be a newline, and the rest of the includes.
V8NodeCustom.cpp is a good example to follow.


>  ACCESSOR_SETTER(HTMLDataGridElementDataSource)
...
> +    PassRefPtr<DataGridDataSource> dataSource;

nit: I think this should be a RefPtr.  PassRefPtr should only be
used in argument lists and as a return value.


>  } // namespace WebCore
> +
> +#endif ENABLE(DATAGRID)

^^^ I think you meant to comment out the ENABLE(DATAGRID) text.  It is quite
common in WebKit to not comment the #endif by the way.


> Index: LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-basic.html
...
> +	   try {
> +
>	   function log(msg)

nit: I think it is good style to indent the body of a try block.


> Index:
LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-dom-attributes.html
...
> +	   try{
> +
>	   function log(msg)

nit: I think it is good style to indent the body of a try block.

nit: Add a space after "try"


> Index: LayoutTests/fast/dom/HTMLDataGridElement/DataGridColumns-dom.html
...
> +	   
> +	   try {
>  
>	   function log(msg)

nit: I think it is good style to indent the body of a try block.


> Index: LayoutTests/fast/dom/HTMLDataGridElement/DataGridDataSource-basic.html

...
> +	   try {
> +	       
>	   function log(msg)

nit: I think it is good style to indent the body of a try block.

I think it would be good to provide a justification for the
"==" -> "===" change in the ChangeLog.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:14:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:14:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27524] Add check for
 correct wtf includes in WebCore to cpplint : [Attachment 33225] Add check
 for correct wtf includes in WebCore to cpplint
In-Reply-To: <bug-27524-0@https.bugs.webkit.org/>
References: <bug-27524-0@https.bugs.webkit.org/>
Message-ID: <20090721231403.EF6C933D999B@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27524: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33225: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/attachment.cgi?id=33225&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
The patch implementing this check.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:27:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:27:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 22784] [Chromium] Home, End,
 PageUp and PageDown buttons do not do anything in drop down lists :
 [Attachment 33224] Updated patch with test case
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090721232739.9D19433D9B10@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jens Alfke <snej at chromium.org>'s
request for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33224: Updated patch with test case
https://bugs.webkit.org/attachment.cgi?id=33224&action=review

------- Additional Comments from David Levin <levin at chromium.org>
A few small changes and this will be done :)

> --- LayoutTests/fast/forms/select-popup-pagekeys-expected.txt (revision 0)

> +This test verifies that the Home/End/PageUp/PageDown keys work correctly for
pop-up <select> elements that have focus but are not currently popped-up.
> +

The tests typically note here what one should see if running it in the browser.
 (Some thing like.  Below you should see some information about the key pressed
and whether a test passed followed by a single "SUCCESS".)


The expected output here doesn't match what I would expect from the html. (It
is missing "NOTE: This test will fail on Mac OS, on which these keys are NOT
supposed to change the selection of a focused pop-up."


> \ No newline at end of file

Please add a newline (I guess fix the html file to ensure that there is one.)


> Property changes on:
LayoutTests/fast/forms/select-popup-pagekeys-expected.txt
> ___________________________________________________________________
> Name: svn:eol-style:native

Please set to LF.


> Index: LayoutTests/fast/forms/select-popup-pagekeys.html
> \ No newline at end of file

Please add a newline.

> Index: LayoutTests/platform/mac/fast/forms/select-popup-pagekeys-expected.txt

> ___________________________________________________________________
> Name: svn:eol-style:native

Please set to LF.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:32:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:32:55 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27523] Don't convert soft
 hyphens in selections into spaces : [Attachment 33222] patch
In-Reply-To: <bug-27523-0@https.bugs.webkit.org/>
References: <bug-27523-0@https.bugs.webkit.org/>
Message-ID: <20090721233255.5C03033D9BFC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Adam Langley <agl at chromium.org>'s
request for review:
Bug 27523: Don't convert soft hyphens in selections into spaces
https://bugs.webkit.org/show_bug.cgi?id=27523

Attachment 33222: patch
https://bugs.webkit.org/attachment.cgi?id=33222&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Need expected results for the layout test.

+	 var e = window.eventSender;
+	 e.mouseMoveTo(3, 5);
+	 e.mouseDown();
+	 for (var x = 4; x < 300; x += 20) {
+	   e.mouseMoveTo(x, 5);
+	 }
+	 e.mouseUp();

can probably be replaced by something like this:

var sel = window.getSelection()
var p = document.getElementsByTagName("p")[0]; // an id lookup would be
cleaner.
sel.selectAllChildren(p);

WebKit only way for selecting part of a node:
sel.setBaseAndExtent(p, 0, p, 10);

You can also create ranges and add them to the selection with sel.addRange(). 
In FF the only way to manipulate the selection is through Ranges:

var range = document.createRange();
range.setStart(p, 0);
range.setEnd(p, 10);
sel.removeAllRanges();
sel.addRange(range);

http://www.w3.org/TR/DOM-Level-2-Traversal-Range/ranges.html
Yes, the Range API is insane.

No need to do all the style stuff if you use Range/Selection APIs to create the
selection.

I'm not really sure about the code change.  I would probably have put it into
some sort of inline:
atRunEndOrSoftHyphen(str, nextRunStart, runEnd)

I'm not actually sure what the change is doing though, so difficult for me to
name said inline. ;)

r- for lack of expected results.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:36:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:36:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33226] Add Attributes
 to Nodes
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090721233658.786EC33D9C99@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33226: Add Attributes to Nodes
https://bugs.webkit.org/attachment.cgi?id=33226&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This allows users to add attributes to nodes from the Elements Panel in the
Tree.

NOTES: 

1. Only nodes that are of type Node.ELEMENT_NODE will exhibit the behavior
mentioned below, and only in the Elements Panel, not in the console when
inspecting a node.
2. When hovering over the Node in the Tree view an ellipsis (?) will appear to
the right of the text on the hovered line
3. Double Clicking the ellipsis (I didn't both with a single click at the
moment) will trigger the usual dblclick
4. This notices it is inside the 'add-attribute' ellipsis and will dynamically
create an attribute to start editing, like normal.

Give it a whirl.  Make suggestions on how to improve the User Interface to a
tool like this.  Sometimes I really wish I had a designer to work with.

From bugzilla-daemon at webkit.org  Tue Jul 21 16:45:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:45:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27513] [Chromium] Linux: add
 static functions to FontPlatformData which allow for setting the global
 font rendering preferences. : [Attachment 33208] patch
In-Reply-To: <bug-27513-0@https.bugs.webkit.org/>
References: <bug-27513-0@https.bugs.webkit.org/>
Message-ID: <20090721234513.3386333D9D90@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has canceled Adam Langley <agl at chromium.org>'s
request for review:
Bug 27513: [Chromium] Linux: add static functions to FontPlatformData which
allow for setting the global font rendering preferences.
https://bugs.webkit.org/show_bug.cgi?id=27513

Attachment 33208: patch
https://bugs.webkit.org/attachment.cgi?id=33208&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 16:47:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:47:30 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27524] Add check for correct
 wtf includes in WebCore to cpplint : [Attachment 33225] Add check for
 correct wtf includes in WebCore to cpplint
In-Reply-To: <bug-27524-0@https.bugs.webkit.org/>
References: <bug-27524-0@https.bugs.webkit.org/>
Message-ID: <20090721234730.ECC7D33D9DC6@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27524: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33225: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/attachment.cgi?id=33225&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/Scripts/modules/cpplint.py
b/WebKitTools/Scripts/modules/cpplint.py
> +	   # Check specific include file rules.
> +	   if filename != "-":

When is the filename "-" ?

> +	       filepath = os.path.abspath(filename)
> +	       filepath_parts = filepath.split(os.sep)
> +	       if 'WebCore' in filepath_parts:

Why only WebCore? I think this is true in all directories. (And if it should
only be WebCore, please add a test for this.)



>

From bugzilla-daemon at webkit.org  Tue Jul 21 16:47:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:47:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27521] Move m_context out of
 generator into superclass : [Attachment 33217] patch
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090721234755.E8B4633D9DDA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33217: patch
https://bugs.webkit.org/attachment.cgi?id=33217&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 16:47:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:47:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27521] Move m_context out
 of generator into superclass : [Attachment 33227] Move out into a file to
 fix WebKit build
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090721234758.BA30933D9DEB@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33227: Move out into a file to fix WebKit build
https://bugs.webkit.org/attachment.cgi?id=33227&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 9 files changed, 113 insertions(+), 43 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 16:49:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:49:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27521] Move m_context out of
 generator into superclass : [Attachment 33227] Move out into a file to fix
 WebKit build
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090721234953.A18EC33D9E53@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33227: Move out into a file to fix WebKit build
https://bugs.webkit.org/attachment.cgi?id=33227&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 16:49:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 16:49:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27521] Move m_context out
 of generator into superclass : [Attachment 33228] Fix WebKit build by
 moving into new file
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090721234956.649E733D9E66@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33228: Fix WebKit build by moving into new file
https://bugs.webkit.org/attachment.cgi?id=33228&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 9 files changed, 121 insertions(+), 43 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 17:02:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 17:02:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27521] Move m_context out of
 generator into superclass : [Attachment 33228] Fix WebKit build by moving
 into new file
In-Reply-To: <bug-27521-0@https.bugs.webkit.org/>
References: <bug-27521-0@https.bugs.webkit.org/>
Message-ID: <20090722000200.5D8C933D9FAB@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27521: Move m_context out of generator into superclass
https://bugs.webkit.org/show_bug.cgi?id=27521

Attachment 33228: Fix WebKit build by moving into new file
https://bugs.webkit.org/attachment.cgi?id=33228&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
okedoke

From bugzilla-daemon at webkit.org  Tue Jul 21 17:17:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 17:17:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27513] [Chromium] Linux:
 add static functions to FontPlatformData which allow for setting the global
 font rendering preferences. : [Attachment 33229] patch
In-Reply-To: <bug-27513-0@https.bugs.webkit.org/>
References: <bug-27513-0@https.bugs.webkit.org/>
Message-ID: <20090722001713.C7FBC33DA172@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27513: [Chromium] Linux: add static functions to FontPlatformData which
allow for setting the global font rendering preferences.
https://bugs.webkit.org/show_bug.cgi?id=27513

Attachment 33229: patch
https://bugs.webkit.org/attachment.cgi?id=33229&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 17:25:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 17:25:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27515] Implement
 AbstractWorker::dispatchScriptErrorEvent by generating an ErrorEvent. :
 [Attachment 33211] Proposed Patch
In-Reply-To: <bug-27515-0@https.bugs.webkit.org/>
References: <bug-27515-0@https.bugs.webkit.org/>
Message-ID: <20090722002504.AD23733DA252@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27515: Implement AbstractWorker::dispatchScriptErrorEvent by generating an
ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27515

Attachment 33211: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33211&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Please do a variable name change below before landing.


> +void AbstractWorker::dispatchScriptErrorEvent(const String& message, const
String& sourceURL, int lineNumber)
>  {
> +    RefPtr<ErrorEvent> evt = ErrorEvent::create(message, sourceURL,
static_cast<unsigned>(lineNumber));

Use full words, except in the rare case where an abbreviation would be more
canonical and easier to understand.
s/evt/event/

> +    if (m_onErrorListener) {
> +	   evt->setTarget(this);
> +	   evt->setCurrentTarget(this);
> +	   m_onErrorListener->handleEvent(evt.get(), true);
> +    }
> +
> +    ExceptionCode ec = 0;
> +    dispatchEvent(evt.release(), ec);
> +    ASSERT(!ec);
>  }
>  
>  } // namespace WebCore

From bugzilla-daemon at webkit.org  Tue Jul 21 17:32:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 17:32:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33230] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722003224.724A133DA30D@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33230: Patch
https://bugs.webkit.org/attachment.cgi?id=33230&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Added ScriptSourceProvider to WebCore.gypi.

From bugzilla-daemon at webkit.org  Tue Jul 21 17:37:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 17:37:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27526] Inspector: Removing
 an Attribute via Edit should Delete the Attribute,
 Not Ignore Your Changes : [Attachment 33231] Removing an Attribute Deletes
 the Attribute - And Fix Possible Exception
In-Reply-To: <bug-27526-0@https.bugs.webkit.org/>
References: <bug-27526-0@https.bugs.webkit.org/>
Message-ID: <20090722003759.5D6B833DA3BC@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27526: Inspector: Removing an Attribute via Edit should Delete the
Attribute, Not Ignore Your Changes
https://bugs.webkit.org/show_bug.cgi?id=27526

Attachment 33231: Removing an Attribute Deletes the Attribute - And Fix
Possible Exception
https://bugs.webkit.org/attachment.cgi?id=33231&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
NOTES:

1. This will delete an attribute _if_ that attribute previously existed.  The
only time an attribute would not previously exist would be if it is a "new"
attribute.  This means this is compatible with the (uncommitted) patch on the
following bug to create new attributes:
https://bugs.webkit.org/show_bug.cgi?id=21108

2. This fixes an error that has been around for a while where an invalid
attribute from user input (such as "-") can cause an error.  An example test
case will be attached in a minute.

From bugzilla-daemon at webkit.org  Tue Jul 21 18:29:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 18:29:00 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33230] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722012900.0D12733DA8B4@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33230: Patch
https://bugs.webkit.org/attachment.cgi?id=33230&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
There are yet more build systems in the tree.  Yes it sucks.  For example:

http://trac.webkit.org/browser/trunk/WebCore/WebCore.pro

Also, can we test for this crash in a LayoutTest?  If it involves a cached
script, we might need to load the same script twice.

From bugzilla-daemon at webkit.org  Tue Jul 21 18:40:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 18:40:08 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33067] adds toString to
 gobject bindings
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090722014008.9F2D733DA98E@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33067: adds toString to gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33067&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
Please do not continue to remark for review patches that have been r-'ed
already.  Continuing to do so will have your account suspended.  As Mark noted,
toString() is a JS concept that does not map to other languages and is
therefore not suited for the C GObject bindings.

From bugzilla-daemon at webkit.org  Tue Jul 21 18:48:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 18:48:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27432] add read-write access
 to HTMLOptionElement text under GObject bindings : [Attachment 33061] patch
 to make HTMLOptionElement text property read-write under gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090722014857.B357133DAA4B@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
As I have noted in another bug, repeatedly remarking a patch for review that
has been r-ed is not acceptable behavior.

From bugzilla-daemon at webkit.org  Tue Jul 21 19:02:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 19:02:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27523] Don't convert soft
 hyphens in selections into spaces : [Attachment 33234] patch
In-Reply-To: <bug-27523-0@https.bugs.webkit.org/>
References: <bug-27523-0@https.bugs.webkit.org/>
Message-ID: <20090722020259.162AA33DAB83@gamma.macosforge.org>

Adam Langley <agl at chromium.org> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 27523: Don't convert soft hyphens in selections into spaces
https://bugs.webkit.org/show_bug.cgi?id=27523

Attachment 33234: patch
https://bugs.webkit.org/attachment.cgi?id=33234&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 19:36:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 19:36:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27242] JSC bindings should
 use an auto-bound RGBColor class instead of hand-rolled JSRGBColor :
 [Attachment 33235] patch
In-Reply-To: <bug-27242-0@https.bugs.webkit.org/>
References: <bug-27242-0@https.bugs.webkit.org/>
Message-ID: <20090722023640.DCC2D33DADBC@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has asked  for review:
Bug 27242: JSC bindings should use an auto-bound RGBColor class instead of
hand-rolled JSRGBColor
https://bugs.webkit.org/show_bug.cgi?id=27242

Attachment 33235: patch
https://bugs.webkit.org/attachment.cgi?id=33235&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 19:50:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 19:50:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27527] Move call linking /
 repatching down from AbstractMacroAssembler into MacroAssemblerARCH
 classes. : [Attachment 33236] The patch
In-Reply-To: <bug-27527-0@https.bugs.webkit.org/>
References: <bug-27527-0@https.bugs.webkit.org/>
Message-ID: <20090722025047.69B4F33DAF04@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 27527: Move call linking / repatching down from AbstractMacroAssembler into
MacroAssemblerARCH classes.
https://bugs.webkit.org/show_bug.cgi?id=27527

Attachment 33236: The patch
https://bugs.webkit.org/attachment.cgi?id=33236&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 20:01:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 20:01:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27527] Move call linking /
 repatching down from AbstractMacroAssembler into MacroAssemblerARCH
 classes. : [Attachment 33236] The patch
In-Reply-To: <bug-27527-0@https.bugs.webkit.org/>
References: <bug-27527-0@https.bugs.webkit.org/>
Message-ID: <20090722030100.6134F33DAFF9@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27527: Move call linking / repatching down from AbstractMacroAssembler into
MacroAssemblerARCH classes.
https://bugs.webkit.org/show_bug.cgi?id=27527

Attachment 33236: The patch
https://bugs.webkit.org/attachment.cgi?id=33236&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 20:09:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 20:09:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27242] JSC bindings should
 use an auto-bound RGBColor class instead of hand-rolled JSRGBColor :
 [Attachment 33235] patch
In-Reply-To: <bug-27242-0@https.bugs.webkit.org/>
References: <bug-27242-0@https.bugs.webkit.org/>
Message-ID: <20090722030955.5B7D533DB099@gamma.macosforge.org>

mitz at webkit.org has granted Sam Weinig <sam at webkit.org>'s request for review:
Bug 27242: JSC bindings should use an auto-bound RGBColor class instead of
hand-rolled JSRGBColor
https://bugs.webkit.org/show_bug.cgi?id=27242

Attachment 33235: patch
https://bugs.webkit.org/attachment.cgi?id=33235&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 20:49:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 20:49:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33237] Syntax fixes
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090722034953.8F11E33DB3CB@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33237: Syntax fixes
https://bugs.webkit.org/attachment.cgi?id=33237&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
$n is pointless. It's only in their old outdated documentation anyway. (The
assert* commands seems to have been deprecated) 

I vote to ditch it.

From bugzilla-daemon at webkit.org  Tue Jul 21 20:49:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 20:49:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33223] set history limit to 5
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090722034953.7897333DB3C8@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33223: set history limit to 5
https://bugs.webkit.org/attachment.cgi?id=33223&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
$n is pointless. It's only in their old outdated documentation anyway. (The
assert* commands seems to have been deprecated) 

I vote to ditch it.

From bugzilla-daemon at webkit.org  Tue Jul 21 21:00:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 21:00:17 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33237] Syntax fixes
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090722040017.313D833DB4F3@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33237: Syntax fixes
https://bugs.webkit.org/attachment.cgi?id=33237&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 21:00:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 21:00:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33238] No more $n
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090722040017.5588E33DB4F7@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33238: No more $n
https://bugs.webkit.org/attachment.cgi?id=33238&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 21:02:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 21:02:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 17907] Inspector should
 support Firebug's magic $0 variable to access inspected node : [Attachment
 33238] No more $n
In-Reply-To: <bug-17907-0@https.bugs.webkit.org/>
References: <bug-17907-0@https.bugs.webkit.org/>
Message-ID: <20090722040221.42F7133DB521@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 17907: Inspector should support Firebug's magic $0 variable to access
inspected node
https://bugs.webkit.org/show_bug.cgi?id=17907

Attachment 33238: No more $n
https://bugs.webkit.org/attachment.cgi?id=33238&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 21:51:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 21:51:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33239] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722045148.0199433DB977@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33239: Patch
https://bugs.webkit.org/attachment.cgi?id=33239&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Added bindings/js/ScriptSourceProvider.h, ScriptSourceCode.h,
StringSourceProvider.h to WebCore.pro.

I hope I've got all the build systems covered.

From bugzilla-daemon at webkit.org  Tue Jul 21 22:07:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:07:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33239] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722050701.65AC133DBB08@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33239: Patch
https://bugs.webkit.org/attachment.cgi?id=33239&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Confirmed with Dan on IRC that this crash only surfaces after he makes another
change he's working on.  It's a crash fix from the future!

From bugzilla-daemon at webkit.org  Tue Jul 21 22:30:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:30:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27528] run-webkit-lint
 should have --git-commit option : [Attachment 33240] Patch v1
In-Reply-To: <bug-27528-0@https.bugs.webkit.org/>
References: <bug-27528-0@https.bugs.webkit.org/>
Message-ID: <20090722053050.485C633DBD6D@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27528: run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

Attachment 33240: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33240&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 3 files changed, 35 insertions(+), 7 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 22:30:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:30:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27077] Workers + garbage
 collector: weird crashes : [Attachment 33149] Cache the structure of the
 prototype
In-Reply-To: <bug-27077-0@https.bugs.webkit.org/>
References: <bug-27077-0@https.bugs.webkit.org/>
Message-ID: <20090722053056.1BDDF33DBD7F@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has canceled Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27077: Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

Attachment 33149: Cache the structure of the prototype
https://bugs.webkit.org/attachment.cgi?id=33149&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 22:31:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:31:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27077] Workers + garbage
 collector: weird crashes : [Attachment 33174] layout test for
 op_method_call bug
In-Reply-To: <bug-27077-0@https.bugs.webkit.org/>
References: <bug-27077-0@https.bugs.webkit.org/>
Message-ID: <20090722053114.7196A33DBD9B@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has canceled Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27077: Workers + garbage collector: weird crashes
https://bugs.webkit.org/show_bug.cgi?id=27077

Attachment 33174: layout test for op_method_call bug
https://bugs.webkit.org/attachment.cgi?id=33174&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 22:34:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:34:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27528] run-webkit-lint
 should have --git-commit option : [Attachment 33240] Patch v1
In-Reply-To: <bug-27528-0@https.bugs.webkit.org/>
References: <bug-27528-0@https.bugs.webkit.org/>
Message-ID: <20090722053448.CEE3333DBDF7@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has canceled Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27528: run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

Attachment 33240: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33240&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>
Oops. This breaks cpplint_unittest due to lack of default argument of
additional_flags. I'll modify a bit.

From bugzilla-daemon at webkit.org  Tue Jul 21 22:45:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:45:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27528] run-webkit-lint
 should have --git-commit option : [Attachment 33241] Patch v2
In-Reply-To: <bug-27528-0@https.bugs.webkit.org/>
References: <bug-27528-0@https.bugs.webkit.org/>
Message-ID: <20090722054521.AB91B33DBED7@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27528: run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

Attachment 33241: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33241&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 4 files changed, 56 insertions(+), 18 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 22:51:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:51:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27529] run-webkit-lint
 checks code which are not changed : [Attachment 33242] Patch v1
In-Reply-To: <bug-27529-0@https.bugs.webkit.org/>
References: <bug-27529-0@https.bugs.webkit.org/>
Message-ID: <20090722055116.9AAF833DBF82@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27529: run-webkit-lint checks code which are not changed
https://bugs.webkit.org/show_bug.cgi?id=27529

Attachment 33242: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33242&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 2 files changed, 15 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 22:55:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:55:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27530] Tiny typo fixes for
 cpplint.py : [Attachment 33244] Patch v1
In-Reply-To: <bug-27530-0@https.bugs.webkit.org/>
References: <bug-27530-0@https.bugs.webkit.org/>
Message-ID: <20090722055540.3B21333DC005@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27530: Tiny typo fixes for cpplint.py
https://bugs.webkit.org/show_bug.cgi?id=27530

Attachment 33244: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33244&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 2 files changed, 11 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 21 22:57:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:57:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33245] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722055720.C5DE233DC046@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33245: Patch
https://bugs.webkit.org/attachment.cgi?id=33245&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
I hope this fixes the Xcode issue.

From bugzilla-daemon at webkit.org  Tue Jul 21 22:57:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 22:57:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33245] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722055752.413EB33DC05E@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has canceled Daniel Bates
<dbates at berkeley.edu>'s request for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33245: Patch
https://bugs.webkit.org/attachment.cgi?id=33245&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 23:01:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 23:01:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33246] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722060106.0C43E33DC0AD@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33246: Patch
https://bugs.webkit.org/attachment.cgi?id=33246&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Oops. Forgot the change log last time.

From bugzilla-daemon at webkit.org  Tue Jul 21 23:17:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 23:17:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27494] Crash/Unexpected
 behavior if call ScriptSourceCode::source on a CachedScript : [Attachment
 33246] Patch
In-Reply-To: <bug-27494-0@https.bugs.webkit.org/>
References: <bug-27494-0@https.bugs.webkit.org/>
Message-ID: <20090722061729.9A17A33DC229@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27494: Crash/Unexpected behavior if call ScriptSourceCode::source on a
CachedScript
https://bugs.webkit.org/show_bug.cgi?id=27494

Attachment 33246: Patch
https://bugs.webkit.org/attachment.cgi?id=33246&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  Let's try it.

From bugzilla-daemon at webkit.org  Tue Jul 21 23:22:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 23:22:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27530] Tiny typo fixes for
 cpplint.py : [Attachment 33244] Patch v1
In-Reply-To: <bug-27530-0@https.bugs.webkit.org/>
References: <bug-27530-0@https.bugs.webkit.org/>
Message-ID: <20090722062231.ADF9C33DC2BB@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27530: Tiny typo fixes for cpplint.py
https://bugs.webkit.org/show_bug.cgi?id=27530

Attachment 33244: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33244&action=review

From bugzilla-daemon at webkit.org  Tue Jul 21 23:24:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 23:24:30 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27529] run-webkit-lint checks
 code which are not changed : [Attachment 33242] Patch v1
In-Reply-To: <bug-27529-0@https.bugs.webkit.org/>
References: <bug-27529-0@https.bugs.webkit.org/>
Message-ID: <20090722062430.B5CF533DC303@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27529: run-webkit-lint checks code which are not changed
https://bugs.webkit.org/show_bug.cgi?id=27529

Attachment 33242: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33242&action=review

------- Additional Comments from David Levin <levin at chromium.org>

>		   if not line_numbers:
>		       for line in diff.lines:
> -			   line_numbers.add(line[1])
> +			   # When deleted line is not set, it means that
> +			   # the line is newly added.

There is no need to wrap this comment.

> +			   if not line[0]:
> +			       line_numbers.add(line[1])
Of course...nice fix.

From bugzilla-daemon at webkit.org  Tue Jul 21 23:36:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 21 Jul 2009 23:36:00 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27528] run-webkit-lint should
 have --git-commit option : [Attachment 33241] Patch v2
In-Reply-To: <bug-27528-0@https.bugs.webkit.org/>
References: <bug-27528-0@https.bugs.webkit.org/>
Message-ID: <20090722063600.1D14C33DC3BB@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27528: run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

Attachment 33241: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33241&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebKitTools/Scripts/run-webkit-lint
b/WebKitTools/Scripts/run-webkit-lint
> @@ -57,6 +57,13 @@ Syntax: %(program_name)s [--verbose=#] [--output=vs7]
[--filter=-x,+y,...]

Shouldn't the "Syntax" line get [--git-commit=<COMMITISH>] added to it?

From bugzilla-daemon at webkit.org  Wed Jul 22 00:14:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 00:14:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27532] [WinCairo] Correct
 Build Errors : [Attachment 33247] Small set of conditionals around
 Apple-specific headers.
In-Reply-To: <bug-27532-0@https.bugs.webkit.org/>
References: <bug-27532-0@https.bugs.webkit.org/>
Message-ID: <20090722071429.9468533DC764@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 27532: [WinCairo] Correct Build Errors
https://bugs.webkit.org/show_bug.cgi?id=27532

Attachment 33247: Small set of conditionals around Apple-specific headers.
https://bugs.webkit.org/attachment.cgi?id=33247&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 01:26:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 01:26:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27533] [V8] Fix isolated
 world wrappers for event handlers : [Attachment 33248] patch
In-Reply-To: <bug-27533-0@https.bugs.webkit.org/>
References: <bug-27533-0@https.bugs.webkit.org/>
Message-ID: <20090722082616.1838A33DCEBA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27533: [V8] Fix isolated world wrappers for event handlers
https://bugs.webkit.org/show_bug.cgi?id=27533

Attachment 33248: patch
https://bugs.webkit.org/attachment.cgi?id=33248&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 01:30:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 01:30:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27533] [V8] Fix isolated
 world wrappers for event handlers : [Attachment 33248] patch
In-Reply-To: <bug-27533-0@https.bugs.webkit.org/>
References: <bug-27533-0@https.bugs.webkit.org/>
Message-ID: <20090722083021.5E39133DCF2E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27533: [V8] Fix isolated world wrappers for event handlers
https://bugs.webkit.org/show_bug.cgi?id=27533

Attachment 33248: patch
https://bugs.webkit.org/attachment.cgi?id=33248&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Actually, there might be some interaction with workers that I need to think
though.  Clearing the review flag for now.

From bugzilla-daemon at webkit.org  Wed Jul 22 02:39:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 02:39:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27535] WebInspector: Print
 console command message upon evaluate selection request : [Attachment
 33249] patch
In-Reply-To: <bug-27535-0@https.bugs.webkit.org/>
References: <bug-27535-0@https.bugs.webkit.org/>
Message-ID: <20090722093908.AA1AB33DD4DC@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27535: WebInspector: Print console command message upon evaluate selection
request
https://bugs.webkit.org/show_bug.cgi?id=27535

Attachment 33249: patch
https://bugs.webkit.org/attachment.cgi?id=33249&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 02:54:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 02:54:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27536] Make possible
 introducing custom panels in Inspector. : [Attachment 33250] proposed
 change
In-Reply-To: <bug-27536-0@https.bugs.webkit.org/>
References: <bug-27536-0@https.bugs.webkit.org/>
Message-ID: <20090722095437.8B66333DD648@gamma.macosforge.org>

Mikhail Naganov <mnaganov at chromium.org> has asked  for review:
Bug 27536: Make possible introducing custom panels in Inspector.
https://bugs.webkit.org/show_bug.cgi?id=27536

Attachment 33250: proposed change
https://bugs.webkit.org/attachment.cgi?id=33250&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 03:24:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 03:24:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27432] add read-write
 access to HTMLOptionElement text under GObject bindings : [Attachment
 33061] patch to make HTMLOptionElement text property read-write under
 gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090722102432.BD30B33DD8C7@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 03:25:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 03:25:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27537] Inform V8 of the
 amount of WebCore string memory it is keeping alive. : [Attachment 33251]
 Inform V8 of the amount of external memory kept alive by external strings.
In-Reply-To: <bug-27537-0@https.bugs.webkit.org/>
References: <bug-27537-0@https.bugs.webkit.org/>
Message-ID: <20090722102530.615C733DD8D4@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27537: Inform V8 of the amount of WebCore string memory it is keeping
alive.
https://bugs.webkit.org/show_bug.cgi?id=27537

Attachment 33251: Inform V8 of the amount of external memory kept alive by
external strings.
https://bugs.webkit.org/attachment.cgi?id=33251&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 03:25:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 03:25:47 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27426] adding
 GDOMBinding.cpp/h as part of GObject bindings : [Attachment 33053] adds
 GDOMBindings
In-Reply-To: <bug-27426-0@https.bugs.webkit.org/>
References: <bug-27426-0@https.bugs.webkit.org/>
Message-ID: <20090722102547.AE74E33DD8E2@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has canceled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 27426: adding GDOMBinding.cpp/h as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27426

Attachment 33053: adds GDOMBindings
https://bugs.webkit.org/attachment.cgi?id=33053&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
this file was accidentally submitted as part of another patch, and got
accidentally reviewed :)

to save reviewer time, review is being removed pending update of the comments
from the other accidental review.

From bugzilla-daemon at webkit.org  Wed Jul 22 03:39:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 03:39:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27432] add read-write
 access to HTMLOptionElement text under GObject bindings : [Attachment
 33061] patch to make HTMLOptionElement text property read-write under
 gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090722103927.444A033DDA07@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked Eric Seidel
<eric at webkit.org> for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
sorry to be requesting a direct reviewee, eric, but you took a look at the
research material and gave it due consideration.  i wonder if therefore i could
ask you if you might be able to do likewise on this one?

i'm very reluctant to keep on re-requesting review like this - that i am taking
a risk by doing so and breaking protocol should indicate to you that it is
actually a rather key and important feature that's critically required, and
would be incredibly inconvenient to have to workaround if it's not there.

From bugzilla-daemon at webkit.org  Wed Jul 22 05:01:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:01:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27538] Qt memory
 consumption on site with many images : [Attachment 33252] Change the Qt
 image decoding to be closer to cairo
In-Reply-To: <bug-27538-0@https.bugs.webkit.org/>
References: <bug-27538-0@https.bugs.webkit.org/>
Message-ID: <20090722120122.DED9633DE36E@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has asked  for review:
Bug 27538: Qt memory consumption on site with many images
https://bugs.webkit.org/show_bug.cgi?id=27538

Attachment 33252: Change the Qt image decoding to be closer to cairo
https://bugs.webkit.org/attachment.cgi?id=33252&action=review

------- Additional Comments from Holger Freyther <zecke at selfish.org>
Introduce an RGBA32Buffer buffer implementation for Qt. The
actualy buffer is a WTF::Vector (to use fastMalloc) but we
have a image on top of this we are using for manipulation,
width/heigt.

Re-Implement ImageDecoderQt on top of the ImageDecoder using
the RGBA32Buffer to hold the final image and attempt to delay
image decoding until the actual image data is requested. This
is failing for gif were we need to decode the images in frameCount()
due QImageReader limitations. Add a side-channel to RGBA32Buffer
because QImageReader can not decode to the QImage we give it.

Change the ImageSourceQt.cpp to be close cairo and change
ImageQt.cpp to free the native image pointer (QPixmap) now that
the ownership of QPixmap's is the same as in other ports.

This change makes the ownership of RGBA32Buffer and native
images/pixmaps follow other ports and allows to easily use
the WebCore image decoders.
---
 8 files changed, 414 insertions(+), 321 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 22 05:21:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:21:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27535] WebInspector: Print
 console command message upon evaluate selection request : [Attachment
 33249] patch
In-Reply-To: <bug-27535-0@https.bugs.webkit.org/>
References: <bug-27535-0@https.bugs.webkit.org/>
Message-ID: <20090722122134.47A6333DE586@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27535: WebInspector: Print console command message upon evaluate selection
request
https://bugs.webkit.org/show_bug.cgi?id=27535

Attachment 33249: patch
https://bugs.webkit.org/attachment.cgi?id=33249&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 05:25:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:25:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27536] Make possible
 introducing custom panels in Inspector. : [Attachment 33250] proposed
 change
In-Reply-To: <bug-27536-0@https.bugs.webkit.org/>
References: <bug-27536-0@https.bugs.webkit.org/>
Message-ID: <20090722122518.6854233DE5E8@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Mikhail Naganov
<mnaganov at chromium.org>'s request for review:
Bug 27536: Make possible introducing custom panels in Inspector.
https://bugs.webkit.org/show_bug.cgi?id=27536

Attachment 33250: proposed change
https://bugs.webkit.org/attachment.cgi?id=33250&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 05:39:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:39:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27499] Coding style -
 Clarify some cases with spacing : [Attachment 33257] Add explicit rule
 about no space before comma or semicolon
In-Reply-To: <bug-27499-0@https.bugs.webkit.org/>
References: <bug-27499-0@https.bugs.webkit.org/>
Message-ID: <20090722123931.A0A2B33DE780@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27499: Coding style - Clarify some cases with spacing
https://bugs.webkit.org/show_bug.cgi?id=27499

Attachment 33257: Add explicit rule about no space before comma or semicolon
https://bugs.webkit.org/attachment.cgi?id=33257&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 05:44:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:44:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33258]
 leninbytes.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090722124407.83B6133DE7DF@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33258: leninbytes.patch
https://bugs.webkit.org/attachment.cgi?id=33258&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Fix a problem in the g_substr function wrt length in characters != length in
bytes for utf8 strings.

From bugzilla-daemon at webkit.org  Wed Jul 22 05:44:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:44:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33259]
 textencoding.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090722124439.1D57B33DE7FA@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33259: textencoding.patch
https://bugs.webkit.org/attachment.cgi?id=33259&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Use TextEncoding facilities for UTF16->UTF8 conversion.

From bugzilla-daemon at webkit.org  Wed Jul 22 05:54:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 05:54:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27499] Coding style - Clarify
 some cases with spacing : [Attachment 33257] Add explicit rule about no
 space before comma or semicolon
In-Reply-To: <bug-27499-0@https.bugs.webkit.org/>
References: <bug-27499-0@https.bugs.webkit.org/>
Message-ID: <20090722125407.77D3E33DE8FF@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27499: Coding style - Clarify some cases with spacing
https://bugs.webkit.org/show_bug.cgi?id=27499

Attachment 33257: Add explicit rule about no space before comma or semicolon
https://bugs.webkit.org/attachment.cgi?id=33257&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Please take out the foreach examples as that's likely to confuse people not
familiar with Qt :)  Otherwise, r+ following discussions on webkit-dev.

From bugzilla-daemon at webkit.org  Wed Jul 22 06:06:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 06:06:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27432] add read-write access
 to HTMLOptionElement text under GObject bindings : [Attachment 33061] patch
 to make HTMLOptionElement text property read-write under gobject bindings
In-Reply-To: <bug-27432-0@https.bugs.webkit.org/>
References: <bug-27432-0@https.bugs.webkit.org/>
Message-ID: <20090722130648.2803233DEA67@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has canceled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 27432: add read-write access to HTMLOptionElement text under GObject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27432

Attachment 33061: patch to make HTMLOptionElement text property read-write
under gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33061&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
tell you what: based on the review requests of #27437 i'll do a better updated
ChangeLog entry.
that will satisfy review criteria, and will make it easier to discuss this
issue.	also i will do some research into webkit's peers, MSHTML, KHTML and
XULrunner, to provide supporting evidence for this request.  perhaps, like
#27437, it may be best to put !LANGUAGE_OBJECTIVE_C

From bugzilla-daemon at webkit.org  Wed Jul 22 06:35:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 06:35:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27512] Test for
 QWebFrame::hasSetFocus() is trying to use a not defined resource. :
 [Attachment 33207] Copied resources from qwebpage tests and added the
 references to the qwebframe.qrc.
In-Reply-To: <bug-27512-0@https.bugs.webkit.org/>
References: <bug-27512-0@https.bugs.webkit.org/>
Message-ID: <20090722133538.E1EE233DED3C@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Andre Pedralho <apedralho at gmail.com>'s
request for review:
Bug 27512: Test for QWebFrame::hasSetFocus() is trying to use a not defined
resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

Attachment 33207: Copied resources from qwebpage tests and added the references
to the qwebframe.qrc.
https://bugs.webkit.org/attachment.cgi?id=33207&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
As tonikitoo pointed out, we shouldn't dupe the resources, but rather share
them.

From bugzilla-daemon at webkit.org  Wed Jul 22 07:24:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 07:24:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27513] [Chromium] Linux: add
 static functions to FontPlatformData which allow for setting the global
 font rendering preferences. : [Attachment 33229] patch
In-Reply-To: <bug-27513-0@https.bugs.webkit.org/>
References: <bug-27513-0@https.bugs.webkit.org/>
Message-ID: <20090722142421.1D50033DF24B@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Adam Langley
<agl at chromium.org>'s request for review:
Bug 27513: [Chromium] Linux: add static functions to FontPlatformData which
allow for setting the global font rendering preferences.
https://bugs.webkit.org/show_bug.cgi?id=27513

Attachment 33229: patch
https://bugs.webkit.org/attachment.cgi?id=33229&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> +    static void setHinting(SkPaint::Hinting);
> +    static void setAntiAlias(bool on);
> +    static void setSubpixelGlyphs(bool on);

nit: i think webkit style is to leave these bool parameters unnamed.

otherwise, r=me

From bugzilla-daemon at webkit.org  Wed Jul 22 07:33:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 07:33:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27524] Add check for
 correct wtf includes in WebCore to cpplint : [Attachment 33261] Add check
 for correct wtf includes to cpplint
In-Reply-To: <bug-27524-0@https.bugs.webkit.org/>
References: <bug-27524-0@https.bugs.webkit.org/>
Message-ID: <20090722143358.CF87233DF340@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27524: Add check for correct wtf includes in WebCore to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33261: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/attachment.cgi?id=33261&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
re #3: Cool, that simplifies stuff a lot. Also looks less out of place this
way. Please re-review... thanks!

From bugzilla-daemon at webkit.org  Wed Jul 22 07:34:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 07:34:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33262] fixed style errors
 reported by cpplint and added correct license text
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090722143415.BB34933DF355@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33262: fixed style errors reported by cpplint and added correct
license text
https://bugs.webkit.org/attachment.cgi?id=33262&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 07:49:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 07:49:48 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27524] Add check for correct
 wtf includes to cpplint : [Attachment 33261] Add check for correct wtf
 includes to cpplint
In-Reply-To: <bug-27524-0@https.bugs.webkit.org/>
References: <bug-27524-0@https.bugs.webkit.org/>
Message-ID: <20090722144948.E306933DF55A@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Jakob Petsovits <jpetso at gmx.at>'s request
for review:
Bug 27524: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33261: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/attachment.cgi?id=33261&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
		 'wtf includes inside WebCore should be <wtf/file.h> instead of
"wtf/file.h".')

This should no longer mention 'WebCore'.  Just say, "wtf includes should be..."


And make sure to change the tests to reflect :)

I'd tell you to make the change on landing, but you can't land yet so please
post another patch with that change and then I'll land.

From bugzilla-daemon at webkit.org  Wed Jul 22 07:54:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 07:54:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27524] Add check for
 correct wtf includes to cpplint : [Attachment 33263] Add check for correct
 wtf includes to cpplint
In-Reply-To: <bug-27524-0@https.bugs.webkit.org/>
References: <bug-27524-0@https.bugs.webkit.org/>
Message-ID: <20090722145428.E320E33DF5CE@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27524: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33263: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/attachment.cgi?id=33263&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Ouch. I adapted the ChangeLog, the commit message and the test function, but
that occurrence I forgot... fixed in this version, no other changes.

From bugzilla-daemon at webkit.org  Wed Jul 22 07:56:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 07:56:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27524] Add check for correct
 wtf includes to cpplint : [Attachment 33263] Add check for correct wtf
 includes to cpplint
In-Reply-To: <bug-27524-0@https.bugs.webkit.org/>
References: <bug-27524-0@https.bugs.webkit.org/>
Message-ID: <20090722145639.D17D733DF608@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27524: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27524

Attachment 33263: Add check for correct wtf includes to cpplint
https://bugs.webkit.org/attachment.cgi?id=33263&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 09:11:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:11:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27528] run-webkit-lint should
 have --git-commit option : [Attachment 33241] Patch v2
In-Reply-To: <bug-27528-0@https.bugs.webkit.org/>
References: <bug-27528-0@https.bugs.webkit.org/>
Message-ID: <20090722161125.5708E33DFE12@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted  review:
Bug 27528: run-webkit-lint should have --git-commit option
https://bugs.webkit.org/show_bug.cgi?id=27528

Attachment 33241: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33241&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'll fix the small issue that I noted above while landing.

From bugzilla-daemon at webkit.org  Wed Jul 22 09:14:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:14:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27537] [V8] Inform V8 of the
 amount of WebCore string memory it is keeping alive. : [Attachment 33251]
 Inform V8 of the amount of external memory kept alive by external strings.
In-Reply-To: <bug-27537-0@https.bugs.webkit.org/>
References: <bug-27537-0@https.bugs.webkit.org/>
Message-ID: <20090722161435.A081933DFEAC@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Mads Ager <ager at chromium.org>'s
request for review:
Bug 27537: [V8] Inform V8 of the amount of WebCore string memory it is keeping
alive.
https://bugs.webkit.org/show_bug.cgi?id=27537

Attachment 33251: Inform V8 of the amount of external memory kept alive by
external strings.
https://bugs.webkit.org/attachment.cgi?id=33251&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 09:17:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:17:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33264] Fix cpplint
 generating false positives for primary includes
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722161721.3525F33DFF4F@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33264: Fix cpplint generating false positives for primary includes
https://bugs.webkit.org/attachment.cgi?id=33264&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 09:25:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:25:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33265] files for WINCE port in
 platform/wince
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090722162515.37B7433E003E@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33265: files for WINCE port in platform/wince
https://bugs.webkit.org/attachment.cgi?id=33265&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>

I have used cpplint to check coding style errors and fixed them.

From bugzilla-daemon at webkit.org  Wed Jul 22 09:30:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:30:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27544] cpplint generates false
 positives for primary includes : [Attachment 33264] Fix cpplint generating
 false positives for primary includes
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722163009.B862533E00A0@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Jakob Petsovits <jpetso at gmx.at>'s request
for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33264: Fix cpplint generating false positives for primary includes
https://bugs.webkit.org/attachment.cgi?id=33264&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> Fix false positives for instances when cpplint would
> normally classify multiple includes as primary: After
> the first primary include, classify all other ones as
> "other" includes even if they look like primary ones.

Almost right I think.  Rather, what we want to do is make the primary header
check even more strict after we've found the first one IMO.

> +	   self._visited_primary_section = False
> +	   self.header_types = dict();
> +
> +    def visited_primary_section(self):
> +	   return self._visited_primary_section

Why did you add 'self.header_types = dic();'

>      if target_base.startswith(include_base):
> -	   return _PRIMARY_HEADER
> +	   # If we already had a primary header before, chances are that this
one
> +	   # is a false positive (e.g. "ScrollbarThemeWince.h" and
"Scrollbar.h"
> +	   # might both be classified as primary header, but only the first one

> +	   # is actually it).
> +	   if not include_state.visited_primary_section():
> +	       return _PRIMARY_HEADER

First, you could have combined the two 'if's'.

Second, I'm not sure this is what we want.  Like I said above, I think we want
to make the header check more strict if we've already found the first one. Make
it check for exact match of target_base and include_base if we've already found
one.  And add a testcase for this.
> +	       include_state.header_types[line_number] = header_type

Purpose?

> -		       previous_include = previous_match.group(2)
> -		       previous_header_type = _classify_include(filename,
previous_include, (previous_match.group(1) == '<'))
> +		       previous_header_type =
include_state.header_types[previous_line_number]

Ahh, now I see.  Perhaps is ok, but not strictly necessary for this patch.

> +					     False, include_state))
> +	   # Tricky example where both includes might be classified as primary.

> +	   self.assert_language_rules_check('ScrollbarThemeWince.cpp',
> +					    '#include "config.h"\n'
> +					    '#include
"ScrollbarThemeWince.h"\n'
> +					    '\n'
> +					    '#include "Scrollbar.h"\n',
> +					    '')

Otherwise looks good I think. r- for now.

From bugzilla-daemon at webkit.org  Wed Jul 22 09:36:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:36:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27523] Don't convert soft
 hyphens in selections into spaces : [Attachment 33234] patch
In-Reply-To: <bug-27523-0@https.bugs.webkit.org/>
References: <bug-27523-0@https.bugs.webkit.org/>
Message-ID: <20090722163618.9542733E013E@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has denied Adam Langley
<agl at chromium.org>'s request for review:
Bug 27523: Don't convert soft hyphens in selections into spaces
https://bugs.webkit.org/show_bug.cgi?id=27523

Attachment 33234: patch
https://bugs.webkit.org/attachment.cgi?id=33234&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
This looks like a duplicate of bug 11154 and/or 26774 to me. Please search for
existing Bugzilla bugs when submitting new ones.

We usually check whether the test is running under DRT to avoid console spew if
it's not. Also, it's slightly better to call dumpAsText as early as possible,
to ease investigation in case something in the test suddenly starts raising
exceptions.

if (window.layoutTestController)
    layoutTestController.dumpAsText();

The ChangeLog doesn't explain changes to charset-xuser-defined-expected.txt.
Why are these safe?

r- for the reasons given by Peter Arrenbrecht above.

From bugzilla-daemon at webkit.org  Wed Jul 22 09:37:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 09:37:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27474] Crash if the selection
 is set in a textarea/text input immediately after setting display:none :
 [Attachment 33129] Fixes crashes
In-Reply-To: <bug-27474-0@https.bugs.webkit.org/>
References: <bug-27474-0@https.bugs.webkit.org/>
Message-ID: <20090722163709.13D4B33E0162@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 27474: Crash if the selection is set in a textarea/text input immediately
after setting display:none
https://bugs.webkit.org/show_bug.cgi?id=27474

Attachment 33129: Fixes crashes
https://bugs.webkit.org/attachment.cgi?id=33129&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is definitely the right basic approach. And what's here is OK if it's OK
for these functions to do nothing when there are pending stylesheets.

But I think it's likely that for website compatibility, these functions need to
work even when called early during loading before all the stylesheets are
loaded. The code needs to call updateLayoutIgnorePendingStylesheets instead of
updateLayout for cases where that needs to work.

I'm going to say review- because of that issue, but I could be convinced to
reconsider if you think I'm wrong.

From bugzilla-daemon at webkit.org  Wed Jul 22 10:03:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 10:03:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26375] VC++ 2005 Express
 failed to build WebKit due to raw UTF-8 string in
 WebKit/win/WebCoreLocalizedStrings.cpp : [Attachment 33143] Proposed fix
 for 26375 (rev 4)
In-Reply-To: <bug-26375-0@https.bugs.webkit.org/>
References: <bug-26375-0@https.bugs.webkit.org/>
Message-ID: <20090722170319.6F57933E04E0@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Takeshi Yoshino
<tyoshino at google.com>'s request for review:
Bug 26375: VC++ 2005 Express failed to build WebKit due to raw UTF-8 string in
WebKit/win/WebCoreLocalizedStrings.cpp
https://bugs.webkit.org/show_bug.cgi?id=26375

Attachment 33143: Proposed fix for 26375 (rev 4)
https://bugs.webkit.org/attachment.cgi?id=33143&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 10:10:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 10:10:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27383] [Chromium] Hook up
 V8 bindings for DataGrid elements : [Attachment 33266] 5th patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090722171041.9295633E05C9@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 33266: 5th patch
https://bugs.webkit.org/attachment.cgi?id=33266&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
Addresses Darin's review comments above.
Note that the diffs of the layout tests are a lot messier because I've now
indented most of the contents (since I wrapped them in 'try' blocks.)

From bugzilla-daemon at webkit.org  Wed Jul 22 10:29:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 10:29:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27525] Fix error handling
 in dedicated worker and worker context. : [Attachment 33268] Proposed Patch
In-Reply-To: <bug-27525-0@https.bugs.webkit.org/>
References: <bug-27525-0@https.bugs.webkit.org/>
Message-ID: <20090722172929.AC44F33E080F@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27525: Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

Attachment 33268: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33268&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 10:53:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 10:53:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 32882] Patch
 and test cases for bug 27289.
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090722175340.C6AFB33E0B00@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has denied Viet-Trung Luu
<viettrungluu at gmail.com>'s request for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 32882: Patch and test cases for bug 27289.
https://bugs.webkit.org/attachment.cgi?id=32882&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
One minor comment.  You repeat the same if statement block twice. Can you make
that into a helper function, e.g., something like
updateLastScrollbarUnderMouse?

From bugzilla-daemon at webkit.org  Wed Jul 22 10:58:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 10:58:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27547] expand
 prototype-inheritance test to cover constructors : [Attachment 33269] patch
In-Reply-To: <bug-27547-0@https.bugs.webkit.org/>
References: <bug-27547-0@https.bugs.webkit.org/>
Message-ID: <20090722175849.5670033E0BB2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27547: expand prototype-inheritance test to cover constructors
https://bugs.webkit.org/show_bug.cgi?id=27547

Attachment 33269: patch
https://bugs.webkit.org/attachment.cgi?id=33269&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:04:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:04:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27548] Chromium has a build
 break after removal of JSRGBColor bindings : [Attachment 33270] Fix
 Chromium V8 build break
In-Reply-To: <bug-27548-0@https.bugs.webkit.org/>
References: <bug-27548-0@https.bugs.webkit.org/>
Message-ID: <20090722180413.B16E133E0C93@gamma.macosforge.org>

Paul Godavari <paul at chromium.org> has asked  for review:
Bug 27548: Chromium has a build break after removal of JSRGBColor bindings
https://bugs.webkit.org/show_bug.cgi?id=27548

Attachment 33270: Fix Chromium V8 build break
https://bugs.webkit.org/attachment.cgi?id=33270&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:08:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:08:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27533] [V8] Fix isolated
 world wrappers for event handlers : [Attachment 33271] Slightly better
 patch
In-Reply-To: <bug-27533-0@https.bugs.webkit.org/>
References: <bug-27533-0@https.bugs.webkit.org/>
Message-ID: <20090722180811.7AF7533E0D34@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27533: [V8] Fix isolated world wrappers for event handlers
https://bugs.webkit.org/show_bug.cgi?id=27533

Attachment 33271: Slightly better patch
https://bugs.webkit.org/attachment.cgi?id=33271&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:10:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:10:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33272] Fix cpplint
 generating false positives for primary includes (try 2)
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722181026.7ED4233E0D99@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33272: Fix cpplint generating false positives for primary includes
(try 2)
https://bugs.webkit.org/attachment.cgi?id=33272&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Combined the two ifs into one condition in this new patch. This also makes it
apparent that there is no need to make the check stricter than startswith()
after encountering the first occurrence, because it won't be triggered anyways.


> (regarding header_types dict)
> Ahh, now I see.  Perhaps is ok, but not strictly necessary for this patch.

It was actually necessary, because the second _classify_include() apparently
caused some state change which in turn caused some test case to fail. So this
change makes the first _classify_include() to be the only one that's being
called, which ensures proper state tracking.

From bugzilla-daemon at webkit.org  Wed Jul 22 11:10:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:10:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27533] [V8] Fix isolated
 world wrappers for event handlers : [Attachment 33271] Slightly better
 patch
In-Reply-To: <bug-27533-0@https.bugs.webkit.org/>
References: <bug-27533-0@https.bugs.webkit.org/>
Message-ID: <20090722181037.61E0033E0D9F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27533: [V8] Fix isolated world wrappers for event handlers
https://bugs.webkit.org/show_bug.cgi?id=27533

Attachment 33271: Slightly better patch
https://bugs.webkit.org/attachment.cgi?id=33271&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:10:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:10:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27533] [V8] Fix isolated
 world wrappers for event handlers : [Attachment 33273] patch with less
 trailing whitespace
In-Reply-To: <bug-27533-0@https.bugs.webkit.org/>
References: <bug-27533-0@https.bugs.webkit.org/>
Message-ID: <20090722181043.BB7F433E0DBC@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27533: [V8] Fix isolated world wrappers for event handlers
https://bugs.webkit.org/show_bug.cgi?id=27533

Attachment 33273: patch with less trailing whitespace
https://bugs.webkit.org/attachment.cgi?id=33273&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:11:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:11:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27548] Chromium has a build
 break after removal of JSRGBColor bindings : [Attachment 33270] Fix
 Chromium V8 build break
In-Reply-To: <bug-27548-0@https.bugs.webkit.org/>
References: <bug-27548-0@https.bugs.webkit.org/>
Message-ID: <20090722181127.1561633E0DE2@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Paul Godavari
<paul at chromium.org>'s request for review:
Bug 27548: Chromium has a build break after removal of JSRGBColor bindings
https://bugs.webkit.org/show_bug.cgi?id=27548

Attachment 33270: Fix Chromium V8 build break
https://bugs.webkit.org/attachment.cgi?id=33270&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:22:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:22:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27549] Make run-webkit-lint
 supports files as arguments : [Attachment 33274] Make run-webkit-lint
 supports files as arguments
In-Reply-To: <bug-27549-0@https.bugs.webkit.org/>
References: <bug-27549-0@https.bugs.webkit.org/>
Message-ID: <20090722182213.7C31A33E0F7D@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked David
Levin <levin at chromium.org> for review:
Bug 27549: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/show_bug.cgi?id=27549

Attachment 33274: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/attachment.cgi?id=33274&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:29:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:29:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27550] Add wince specific
 memory files into wtf/wince : [Attachment 33276] wtf/wince memory manager
 files
In-Reply-To: <bug-27550-0@https.bugs.webkit.org/>
References: <bug-27550-0@https.bugs.webkit.org/>
Message-ID: <20090722182956.2255133E109F@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27550: Add wince specific memory files into wtf/wince
https://bugs.webkit.org/show_bug.cgi?id=27550

Attachment 33276: wtf/wince memory manager files
https://bugs.webkit.org/attachment.cgi?id=33276&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
already "cpplint"ed.

From bugzilla-daemon at webkit.org  Wed Jul 22 11:33:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:33:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27550] Add wince specific
 memory files into wtf/wince : [Attachment 33276] wtf/wince memory manager
 files
In-Reply-To: <bug-27550-0@https.bugs.webkit.org/>
References: <bug-27550-0@https.bugs.webkit.org/>
Message-ID: <20090722183333.41D0633E10E9@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27550: Add wince specific memory files into wtf/wince
https://bugs.webkit.org/show_bug.cgi?id=27550

Attachment 33276: wtf/wince memory manager files
https://bugs.webkit.org/attachment.cgi?id=33276&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:40:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:40:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33277] Patch to make it possible to build JavaScriptCore as shared library
 on Linux without symbol files.
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090722184052.4F5E533E11C3@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33277: Patch to make it possible to build JavaScriptCore as shared
library on Linux without symbol files.
https://bugs.webkit.org/attachment.cgi?id=33277&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Currently JavaScriptCore is built as shared library on the Apple Windows and
Mac OS X builds.

The symbols used by WebCore and WebKit are exported in JavaScriptCore via
separate files, one for MSVC and one for Mac OS X gcc. The files contain the
mangled symbol names.

It is cumbersome to maintain these lists and it becomes worse when taking
additional compilers into account, like for example g++ on Linux or RVCT for
ARM. When a new symbol needs to be exported it is necessary to determine their
mangled name for each supported compiler.

This bug tries to track the patches/work needed to replace the separately
maintained export lists with the commonly used export macros.


The initial patch merely adds the export macros where necessary and tweaks the
Visual studio and Xcode based builds to accept them, while keeping the symbol
files in place.


Pending approval for the first patch, the second step is to change the Visual
Studio and Xcode builds to fully utilize the macros and delete the symbol
files. On Windows this step will require the placement of additional export
macros that are not part of the first patch.

From bugzilla-daemon at webkit.org  Wed Jul 22 11:45:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:45:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27476]
 execCommand('underline' / 'strikeThrough') doesn't work properly with
 multiple styles in text-decoration : [Attachment 33278] fixes the bug
In-Reply-To: <bug-27476-0@https.bugs.webkit.org/>
References: <bug-27476-0@https.bugs.webkit.org/>
Message-ID: <20090722184549.E40B433E124C@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33278: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33278&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 11:54:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:54:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33265] files for WINCE port in
 platform/wince
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090722185438.7891333E1353@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33265: files for WINCE port in platform/wince
https://bugs.webkit.org/attachment.cgi?id=33265&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +#include "CString.h"
> +#include "DocumentFragment.h"
> +#include "KURL.h"
> +#include "PlatformString.h"
> +#include "TextEncoding.h"
> +#include "markup.h"

Alphabetical sorting problem. Is this a bug in cpplint with capitalization?

> +static String extractURL(const String &inURL, String* title)

Decoration of 'const String &inURL' is wrong.  Another cpplint error?

> +    String url = inURL;
> +    int splitLoc = url.find('\n');
> +    if (splitLoc > 0) {

Minor nit: splitLoc should be spelled out fully: splitLocation.

> +	   if (title)
> +	       *title = url.substring(splitLoc+1);

Space between splitLoc and 1. Rule #2 of spacing.

> +//Firefox text/html
> +static FORMATETC* texthtmlFormat()
> +{
> +    static UINT cf = RegisterClipboardFormat(L"text/html");
> +    static FORMATETC texthtmlFormat = {cf, 0, DVASPECT_CONTENT, -1,
TYMED_HGLOBAL};
> +    return &texthtmlFormat;
> +}

Should be 'textHTMLFormat()' I believe.  What is the Firefox comment for?

> +    HGLOBAL cbData = GlobalAlloc(GPTR, size * sizeof(UChar));

Should be clipboardData or so.

> +    // calculate offsets
> +    const unsigned UINT_MAXdigits = 10; // number of digits in UINT_MAX in
base 10
> +    unsigned startHTMLOffset = cf_html.length() + startHTML.length() +
endHTML.length() + startFragment.length() + endFragment.length() +
(shouldFillSourceURL ? sourceURL.length() + srcURL.length() : 0) +
(4*UINT_MAXdigits);

Space around '4*UINT_MAXdigits'.

> +String getURL(IDataObject* dataObject, bool& success, String* title)
> +{
> +    return String();
> +}

Compiler doesn't complain of unused arguments?

> +#endif // ClipboardWin_h

Should be // ClipboardWince_h I think.

> +void ContextMenuItem::setSubMenu(ContextMenu* subMenu)
> +{
> +    if (m_platformDescription) {
> +	   if (m_platformDescription->subMenu !=
subMenu->platformDescription())
> +	       delete m_platformDescription->subMenu;
> +	   m_platformDescription->subMenu =
subMenu->releasePlatformDescription();
> +    }
> +}

Early return please.

> +void ContextMenuItem::setChecked(bool checked)
> +{
> +    if (m_platformDescription) {
> +	   if (checked)
> +	       m_platformDescription->state |=
PlatformMenuItemDescriptionType::CheckedState;
> +	   else
> +	       m_platformDescription->state &=
~PlatformMenuItemDescriptionType::CheckedState;
> +    }
> +}

Early return please.

> +void ContextMenuItem::setEnabled(bool enabled)
> +{
> +    if (m_platformDescription) {
> +	   if (enabled)
> +	       m_platformDescription->state |=
PlatformMenuItemDescriptionType::EnabledState;
> +	   else
> +	       m_platformDescription->state &=
~PlatformMenuItemDescriptionType::EnabledState;
> +    }
> +}

Early return please.

> +PlatformMenuDescriptionType::PlatformMenuDescriptionType()
> +: hMenu(::CreatePopupMenu())
> +, itemCount(0)
> +{
> +}

Needs indentation of member variable initialization.

> +    if (desc->type == SeparatorType) {
> +	   flags |= MF_SEPARATOR;
> +    } else {

One line if clause...

> +#if 0
> +    if (!m_platformDescription)
> +	   return;
> +
> +    // FIXME: the Windows version did this, is it necessary?
> +    MENUINFO menuInfo = {0};
> +    menuInfo.cbSize = sizeof(MENUINFO);
> +    menuInfo.fMask = MIM_STYLE;
> +    ::GetMenuInfo(m_platformDescription, &menuInfo);
> +    menuInfo.fMask = MIM_STYLE;
> +    menuInfo.dwStyle |= MNS_NOTIFYBYPOS;
> +    ::SetMenuInfo(m_platformDescription, &menuInfo);
> +#endif

--commented out code

Going to stop there.  For the next iteration can you break it up in the
following way?

Patch 1:


 * platform/wince/ClipboardUtilitiesWince.cpp: Added.
 * platform/wince/ClipboardWince.cpp: Added.
 * platform/wince/ClipboardWince.h: Added.
 * platform/wince/ContextMenuItemWince.cpp: Added.
 * platform/wince/ContextMenuWince.cpp: Added.
 * platform/wince/CursorWince.cpp: Added.
 * platform/wince/DragDataWince.cpp: Added.
 * platform/wince/DragImageWince.cpp: Added.
 * platform/wince/EditorWince.cpp: Added.
 * platform/wince/FileChooserWince.cpp: Added.
 * platform/wince/FileSystemWince.cpp: Added.
 * platform/wince/KURLWince.cpp: Added.
 * platform/wince/KeygenWince.cpp: Added.
 * platform/wince/MIMETypeRegistryWince.cpp: Added.
 * platform/wince/OptimizedBuffer.cpp: Added.
 * platform/wince/OptimizedBuffer.h: Added.
 * platform/wince/PasteboardWince.cpp: Added. 
 * platform/wince/SearchPopupMenuWince.cpp: Added.
 * platform/wince/SharedBuffer.cpp: Added.
 * platform/wince/SharedTimerWince.cpp: Added.
 * platform/wince/SystemTimeWince.cpp: Added. 

Patch 2:

The rest of the ScrollView/Widget related files?

Thanks,
Adam
I Indent as above. t

From bugzilla-daemon at webkit.org  Wed Jul 22 11:58:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:58:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33272] Fix cpplint
 generating false positives for primary includes (try 2)
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722185837.3C78033E1408@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33272: Fix cpplint generating false positives for primary includes
(try 2)
https://bugs.webkit.org/attachment.cgi?id=33272&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Ok, new try: This one still regards subsequent includes as primary if they
strictly match the implementation's filename. Plus a new testcase to verify
that.

From bugzilla-daemon at webkit.org  Wed Jul 22 11:58:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 11:58:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33279] Fix cpplint
 generating false positives for primary includes (try 3)
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722185837.6A4E833E140C@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33279: Fix cpplint generating false positives for primary includes
(try 3)
https://bugs.webkit.org/attachment.cgi?id=33279&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Ok, new try: This one still regards subsequent includes as primary if they
strictly match the implementation's filename. Plus a new testcase to verify
that.

From bugzilla-daemon at webkit.org  Wed Jul 22 12:10:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:10:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33279] Fix cpplint
 generating false positives for primary includes (try 3)
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722191059.A0A6333E15B5@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33279: Fix cpplint generating false positives for primary includes
(try 3)
https://bugs.webkit.org/attachment.cgi?id=33279&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
One more try, with (hopefully) clearer comments, incorporating suggestions by
Adam Treat on IRC.

From bugzilla-daemon at webkit.org  Wed Jul 22 12:11:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:11:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33280] Fix cpplint
 generating false positives for primary includes (try 4)
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722191140.75ECB33E15CD@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33280: Fix cpplint generating false positives for primary includes
(try 4)
https://bugs.webkit.org/attachment.cgi?id=33280&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 12:14:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:14:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27544] cpplint generates
 false positives for primary includes : [Attachment 33280] Fix cpplint
 generating false positives for primary includes (try 4)
In-Reply-To: <bug-27544-0@https.bugs.webkit.org/>
References: <bug-27544-0@https.bugs.webkit.org/>
Message-ID: <20090722191433.3096B33E162F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27544: cpplint generates false positives for primary includes
https://bugs.webkit.org/show_bug.cgi?id=27544

Attachment 33280: Fix cpplint generating false positives for primary includes
(try 4)
https://bugs.webkit.org/attachment.cgi?id=33280&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Looks good.

From bugzilla-daemon at webkit.org  Wed Jul 22 12:15:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:15:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27547] expand
 prototype-inheritance test to cover constructors : [Attachment 33269] patch
In-Reply-To: <bug-27547-0@https.bugs.webkit.org/>
References: <bug-27547-0@https.bugs.webkit.org/>
Message-ID: <20090722191509.39C3133E164F@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27547: expand prototype-inheritance test to cover constructors
https://bugs.webkit.org/show_bug.cgi?id=27547

Attachment 33269: patch
https://bugs.webkit.org/attachment.cgi?id=33269&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 12:43:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:43:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33281] part 1 (not including ScrollView
 Widget and ScrollBar files)
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090722194338.838BE33E199D@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33281: part 1 (not including ScrollView Widget and ScrollBar files)
https://bugs.webkit.org/attachment.cgi?id=33281&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 12:44:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:44:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33282] part 2 (ScrollView, Widget,
 ScrollBar files)
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090722194416.65ECF33E19C8@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33282: part 2 (ScrollView, Widget, ScrollBar files)
https://bugs.webkit.org/attachment.cgi?id=33282&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 12:44:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:44:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27553] Fix cpplint
 generating false positives for "primary" includes in headers : [Attachment
 33283] Fix cpplint generating false positives for "primary" includes in
 headers
In-Reply-To: <bug-27553-0@https.bugs.webkit.org/>
References: <bug-27553-0@https.bugs.webkit.org/>
Message-ID: <20090722194441.ED4FF33E19DB@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27553: Fix cpplint generating false positives for "primary" includes in
headers
https://bugs.webkit.org/show_bug.cgi?id=27553

Attachment 33283: Fix cpplint generating false positives for "primary" includes
in headers
https://bugs.webkit.org/attachment.cgi?id=33283&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 12:47:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:47:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33131] Use a common
 determineSVNRoot() in multiple scripts
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090722194723.1DC2F33E1A45@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked David Kilzer (ddkilzer)
<ddkilzer at webkit.org> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33131: Use a common determineSVNRoot() in multiple scripts
https://bugs.webkit.org/attachment.cgi?id=33131&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 12:49:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 12:49:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27553] Fix cpplint generating
 false positives for "primary" includes in headers : [Attachment 33283] Fix
 cpplint generating false positives for "primary" includes in headers
In-Reply-To: <bug-27553-0@https.bugs.webkit.org/>
References: <bug-27553-0@https.bugs.webkit.org/>
Message-ID: <20090722194901.7F96B33E1A7D@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27553: Fix cpplint generating false positives for "primary" includes in
headers
https://bugs.webkit.org/show_bug.cgi?id=27553

Attachment 33283: Fix cpplint generating false positives for "primary" includes
in headers
https://bugs.webkit.org/attachment.cgi?id=33283&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 13:01:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:01:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27557] Case-insensitive
 comparison of include file sorting for cpplint : [Attachment 33284]
 Case-insensitive comparison of include file order for cpplint
In-Reply-To: <bug-27557-0@https.bugs.webkit.org/>
References: <bug-27557-0@https.bugs.webkit.org/>
Message-ID: <20090722200106.7FE2733E1C7F@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27557: Case-insensitive comparison of include file sorting for cpplint
https://bugs.webkit.org/show_bug.cgi?id=27557

Attachment 33284: Case-insensitive comparison of include file order for cpplint
https://bugs.webkit.org/attachment.cgi?id=33284&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 13:03:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:03:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27557] Case-insensitive
 comparison of include file sorting for cpplint : [Attachment 33284]
 Case-insensitive comparison of include file order for cpplint
In-Reply-To: <bug-27557-0@https.bugs.webkit.org/>
References: <bug-27557-0@https.bugs.webkit.org/>
Message-ID: <20090722200308.9D76333E1CCD@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27557: Case-insensitive comparison of include file sorting for cpplint
https://bugs.webkit.org/show_bug.cgi?id=27557

Attachment 33284: Case-insensitive comparison of include file order for cpplint
https://bugs.webkit.org/attachment.cgi?id=33284&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 13:04:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:04:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33220] Update auto-version.sh to
 handle different line endings
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090722200444.8E11533E1D11@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked Adam Roben (aroben)
<aroben at apple.com> for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33220: Update auto-version.sh to handle different line endings
https://bugs.webkit.org/attachment.cgi?id=33220&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
ddkilzer suggests aroben to review this.

He also notes that "sed -r" isn't a recognized switch on OS X, but since this
script is in win/tools/ hopefully that doesn't matter.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:05:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:05:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27557] Case-insensitive
 comparison of include file sorting for cpplint : [Attachment 33284]
 Case-insensitive comparison of include file order for cpplint
In-Reply-To: <bug-27557-0@https.bugs.webkit.org/>
References: <bug-27557-0@https.bugs.webkit.org/>
Message-ID: <20090722200501.AF44233E1D37@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied  review:
Bug 27557: Case-insensitive comparison of include file sorting for cpplint
https://bugs.webkit.org/show_bug.cgi?id=27557

Attachment 33284: Case-insensitive comparison of include file order for cpplint
https://bugs.webkit.org/attachment.cgi?id=33284&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Setting to review- for now. I believe the sort is supposed to be case
sensitive, but if there is consensus otherwise, then this is a good change to
make.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:05:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:05:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33131] Use a common
 determineSVNRoot() in multiple scripts
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090722200505.8EB1533E1D43@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33131: Use a common determineSVNRoot() in multiple scripts
https://bugs.webkit.org/attachment.cgi?id=33131&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> Index: WebKitTools/Scripts/svn-create-patch
> ===================================================================
> --- WebKitTools/Scripts/svn-create-patch	(revision 46134)
> +++ WebKitTools/Scripts/svn-create-patch	(working copy)
> @@ -44,19 +44,21 @@ use strict;
>  use warnings;
>  
>  use Config;
> -use Cwd;
> +use Cwd ();	# "use Cwd;" causes warnings if we later (indirectly) "use
POSIX;"

For consistency, please use "qw()" here in case anyone wants to import methods
later and is confused by the bare parenthesis:

use Cwd qw();  # "qw()" prevents warnings with "use POSIX;" below

r=me

From bugzilla-daemon at webkit.org  Wed Jul 22 13:06:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:06:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27556]
 pushDownTextDecorationStyleAroundNode needs clean up : [Attachment 33285]
 cleans up pushDownTextDecorationStyleAroundNode
In-Reply-To: <bug-27556-0@https.bugs.webkit.org/>
References: <bug-27556-0@https.bugs.webkit.org/>
Message-ID: <20090722200623.F29F333E1D94@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27556: pushDownTextDecorationStyleAroundNode needs clean up
https://bugs.webkit.org/show_bug.cgi?id=27556

Attachment 33285: cleans up pushDownTextDecorationStyleAroundNode
https://bugs.webkit.org/attachment.cgi?id=33285&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 13:09:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:09:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27325]
 copyInheritableProperties and removeComputedInheritablePropertiesFrom
 should be deprecated : [Attachment 32826] Deprecates
 copyInheritableProperties and removes
 removeComputedInheritablePropertiesFrom
In-Reply-To: <bug-27325-0@https.bugs.webkit.org/>
References: <bug-27325-0@https.bugs.webkit.org/>
Message-ID: <20090722200906.2853933E1E3A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27325: copyInheritableProperties and
removeComputedInheritablePropertiesFrom should be deprecated
https://bugs.webkit.org/show_bug.cgi?id=27325

Attachment 32826: Deprecates copyInheritableProperties and removes
removeComputedInheritablePropertiesFrom
https://bugs.webkit.org/attachment.cgi?id=32826&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems fine.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:10:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:10:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33219] Fix
 WebCore/DerivedSources.make "Duplicate value!" problem
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090722201029.AACFA33E1E78@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33219: Fix WebCore/DerivedSources.make "Duplicate value!" problem
https://bugs.webkit.org/attachment.cgi?id=33219&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> -	if sort $(WEBCORE_CSS_PROPERTY_NAMES) | uniq -d | grep -E '^[^#]'; then
echo 'Duplicate value!'; exit 1; fi
> +	if sort $(WEBCORE_CSS_PROPERTY_NAMES) | uniq -d | grep -Ev
'(^#)|(^[[:space:]]*$)'; then echo 'Duplicate value!'; exit 1; fi

Nit: I generally like to put spaces between arguments (rather than merging
them):	"-E -v".  This isn't necessary, though.

> -	if sort CSSValueKeywords.in | uniq -d | grep -E '^[^#]'; then echo
'Duplicate value!'; exit 1; fi
> +	if sort CSSValueKeywords.in | uniq -d | grep -Ev
'(^#)|(^[[:space:]]*$)'; then echo 'Duplicate value!'; exit 1; fi
>	perl "$(WebCore)/css/makevalues.pl"

Change this to "-E -v", too, if you change the above command.

> Index: WebCore/css/makeprop.pl
> ===================================================================
> --- WebCore/css/makeprop.pl	(revision 46178)
> +++ WebCore/css/makeprop.pl	(working copy)
> @@ -26,9 +26,9 @@ use warnings;
>  open NAMES, "<CSSPropertyNames.in" || die "Could not find
CSSPropertyNames.in";
>  my @names = ();
>  while (<NAMES>) {
> -  next if (m/#/);
> -  chomp $_;
> -  next if ($_ eq "");
> +  next if (m/(^#)|(^\s*$)/);
> +  # Input may use a different EOL sequence than $/, so avoid chomp.
> +  $_ =~ s/[\r\n]+$//g;
>    push @names, $_;
>  }
>  close(NAMES);

I think it may be safest to put the \r\n replacement before the "next" line
unless you're sure that Perl is going to treat all forms of line endings
equally on all platforms when applying regular expressions.  (I don't know the
answer myself, but it's more common to chomp() before you try to match, so I'd
follow that pattern anyway.)

> Index: WebCore/css/makevalues.pl
> ===================================================================
> --- WebCore/css/makevalues.pl (revision 46178)
> +++ WebCore/css/makevalues.pl (working copy)
> @@ -26,9 +26,9 @@ use warnings;
>  open NAMES, "<CSSValueKeywords.in" || die "Could not open
CSSValueKeywords.in";
>  my @names = ();
>  while (<NAMES>) {
> -  next if (m/#/);
> -  chomp $_;
> -  next if ($_ eq "");
> +  next if (m/(^#)|(^\s*$)/);
> +  # Input may use a different EOL sequence than $/, so avoid chomp.
> +  $_ =~ s/[\r\n]+$//g;
>    push @names, $_;
>  }
>  close(NAMES);

Ditto.

r=me with the changes to makeprop.pl and makevalues.pl.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:29:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:29:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27174] XSSAuditor needs
 cleanup : [Attachment 33286] Patch with tests
In-Reply-To: <bug-27174-0@https.bugs.webkit.org/>
References: <bug-27174-0@https.bugs.webkit.org/>
Message-ID: <20090722202904.8AEC233E214F@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27174: XSSAuditor needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=27174

Attachment 33286: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=33286&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
This patch also addresses bug #26938.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:33:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:33:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33131] Use a common
 determineSVNRoot() in multiple scripts
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090722203307.63FA533E2217@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33131: Use a common determineSVNRoot() in multiple scripts
https://bugs.webkit.org/attachment.cgi?id=33131&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46236, clearing flags

From bugzilla-daemon at webkit.org  Wed Jul 22 13:33:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:33:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27476] execCommand('underline'
 / 'strikeThrough') doesn't work properly with multiple styles in
 text-decoration : [Attachment 33278] fixes the bug
In-Reply-To: <bug-27476-0@https.bugs.webkit.org/>
References: <bug-27476-0@https.bugs.webkit.org/>
Message-ID: <20090722203314.214F933E223B@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33278: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33278&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
/CSSComputedStyleDeclaration.cpp change needs testing.
window.getComputedStyle(foo).getPropertyCSSValue('text-decoration')


   RefPtr<CSSValueList> list = CSSValueList::createCommaSeparated();
 1055		  RefPtr<CSSValueList> list =
CSSValueList::createSpaceSeparated();
needs test too.
foo.style.textDecoration

 73 void CSSValueList::remove(CSSValue* val)
should be called removeFirst or removeAll or should at least be documented as
to its behavior.

 78	    if (m_values.at(index)->cssText() == val->cssText())

is really really sad.

consider adding a bool return to remove and then you don't need hasValue

 93 static bool applyCommandToFrame(Frame* frame, EditorCommandSource source,
EditAction action, CSSMutableStyleDeclaration* style)
is a great change and could even be made in a separate patch.  it's OK to do in
this one though.

YOu can just delete:
110116 static bool executeApplyStyle(Frame* frame, EditorCommandSource source,
EditAction action, int propertyID, const char* propertyValue)

Spacing:
 130	 Node* nodeToRemove=0;

This looks great!  We just need more tests!

From bugzilla-daemon at webkit.org  Wed Jul 22 13:35:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:35:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33219] Fix
 WebCore/DerivedSources.make "Duplicate value!" problem
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090722203515.34A2233E22C0@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33219: Fix WebCore/DerivedSources.make "Duplicate value!" problem
https://bugs.webkit.org/attachment.cgi?id=33219&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46237 (got r+ from ddkilzer on IRC to not modify make*.pl), clearing
flags.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:37:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:37:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27556]
 pushDownTextDecorationStyleAroundNode needs clean up : [Attachment 33285]
 cleans up pushDownTextDecorationStyleAroundNode
In-Reply-To: <bug-27556-0@https.bugs.webkit.org/>
References: <bug-27556-0@https.bugs.webkit.org/>
Message-ID: <20090722203724.D4A0833E2334@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27556: pushDownTextDecorationStyleAroundNode needs clean up
https://bugs.webkit.org/show_bug.cgi?id=27556

Attachment 33285: cleans up pushDownTextDecorationStyleAroundNode
https://bugs.webkit.org/attachment.cgi?id=33285&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

From bugzilla-daemon at webkit.org  Wed Jul 22 13:55:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 13:55:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 33287] Patch
 and test cases for bug 27289
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090722205522.31A8133E256B@gamma.macosforge.org>

Viet-Trung Luu <viettrungluu at gmail.com> has asked Dave Hyatt <hyatt at apple.com>
for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 33287: Patch and test cases for bug 27289
https://bugs.webkit.org/attachment.cgi?id=33287&action=review

------- Additional Comments from Viet-Trung Luu <viettrungluu at gmail.com>
Added a helper method to avoid repeating code.

From bugzilla-daemon at webkit.org  Wed Jul 22 14:11:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:11:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27561] ImageDecoder
 enhancements for WINCE port : [Attachment 33288] this is the patch
In-Reply-To: <bug-27561-0@https.bugs.webkit.org/>
References: <bug-27561-0@https.bugs.webkit.org/>
Message-ID: <20090722211134.435E333E272E@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27561: ImageDecoder enhancements for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27561

Attachment 33288: this is the patch
https://bugs.webkit.org/attachment.cgi?id=33288&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>

1) be able to write output directly to scaled image buffer
2) use ImageFrameSink which supports 16bit, and directly writes to platform
image buffer
3) be able to work with segmented SharedBuffer
4) other changes: assign memory allocator to libpng

The patch depends on bug 27543.

It's currently only for WINCE port, but it can be easily modified to in order
be used for other platforms.

From bugzilla-daemon at webkit.org  Wed Jul 22 14:17:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:17:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27383] [Chromium] Hook up V8
 bindings for DataGrid elements : [Attachment 33266] 5th patch
In-Reply-To: <bug-27383-0@https.bugs.webkit.org/>
References: <bug-27383-0@https.bugs.webkit.org/>
Message-ID: <20090722211755.3A60C33E2814@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27383: [Chromium] Hook up V8 bindings for DataGrid elements
https://bugs.webkit.org/show_bug.cgi?id=27383

Attachment 33266: 5th patch
https://bugs.webkit.org/attachment.cgi?id=33266&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 14:22:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:22:19 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27174] XSSAuditor needs
 cleanup : [Attachment 33286] Patch with tests
In-Reply-To: <bug-27174-0@https.bugs.webkit.org/>
References: <bug-27174-0@https.bugs.webkit.org/>
Message-ID: <20090722212219.51B0733E28B6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27174: XSSAuditor needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=27174

Attachment 33286: Patch with tests
https://bugs.webkit.org/attachment.cgi?id=33286&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Spoke to Dan in person.  We want to remove all the slashes.

From bugzilla-daemon at webkit.org  Wed Jul 22 14:28:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:28:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27563] Remove unneeded
 virtual destructor from ScriptSourceProvider : [Attachment 33289] patch
In-Reply-To: <bug-27563-0@https.bugs.webkit.org/>
References: <bug-27563-0@https.bugs.webkit.org/>
Message-ID: <20090722212850.D724533E2A23@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27563: Remove unneeded virtual destructor from ScriptSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=27563

Attachment 33289: patch
https://bugs.webkit.org/attachment.cgi?id=33289&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 14:31:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:31:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27562] Drop the prefixes
 from background-clip and background-origin : [Attachment 33290] Patch
In-Reply-To: <bug-27562-0@https.bugs.webkit.org/>
References: <bug-27562-0@https.bugs.webkit.org/>
Message-ID: <20090722213106.41D9E33E2A6C@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27562: Drop the prefixes from background-clip and background-origin
https://bugs.webkit.org/show_bug.cgi?id=27562

Attachment 33290: Patch
https://bugs.webkit.org/attachment.cgi?id=33290&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 14:34:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:34:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27562] Drop the prefixes from
 background-clip and background-origin : [Attachment 33290] Patch
In-Reply-To: <bug-27562-0@https.bugs.webkit.org/>
References: <bug-27562-0@https.bugs.webkit.org/>
Message-ID: <20090722213403.1FBB933E2ABA@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has granted Dave Hyatt <hyatt at apple.com>'s
request for review:
Bug 27562: Drop the prefixes from background-clip and background-origin
https://bugs.webkit.org/show_bug.cgi?id=27562

Attachment 33290: Patch
https://bugs.webkit.org/attachment.cgi?id=33290&action=review

------- Additional Comments from Beth Dakin <bdakin at apple.com>
r=me!

From bugzilla-daemon at webkit.org  Wed Jul 22 14:34:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:34:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27289] Click/releases on
 scrollbars misbehave when mouse move is missed : [Attachment 33287] Patch
 and test cases for bug 27289
In-Reply-To: <bug-27289-0@https.bugs.webkit.org/>
References: <bug-27289-0@https.bugs.webkit.org/>
Message-ID: <20090722213423.C399233E2AD4@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Viet-Trung Luu
<viettrungluu at gmail.com>'s request for review:
Bug 27289: Click/releases on scrollbars misbehave when mouse move is missed
https://bugs.webkit.org/show_bug.cgi?id=27289

Attachment 33287: Patch and test cases for bug 27289
https://bugs.webkit.org/attachment.cgi?id=33287&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 22 14:46:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:46:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27564] With
 ENABLE(ASSEMBLER_WX_EXCLUSIVE),
 only change permissions once per repatch event. : [Attachment 33291] The
 Patch.
In-Reply-To: <bug-27564-0@https.bugs.webkit.org/>
References: <bug-27564-0@https.bugs.webkit.org/>
Message-ID: <20090722214625.D7BFC33E2C1C@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 27564: With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once
per repatch event.
https://bugs.webkit.org/show_bug.cgi?id=27564

Attachment 33291: The Patch.
https://bugs.webkit.org/attachment.cgi?id=33291&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 14:57:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 14:57:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27561] ImageDecoder
 enhancements for WINCE port : [Attachment 33288] this is the patch
In-Reply-To: <bug-27561-0@https.bugs.webkit.org/>
References: <bug-27561-0@https.bugs.webkit.org/>
Message-ID: <20090722215746.B672333E2DA5@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27561: ImageDecoder enhancements for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27561

Attachment 33288: this is the patch
https://bugs.webkit.org/attachment.cgi?id=33288&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:01:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:01:58 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27564] With
 ENABLE(ASSEMBLER_WX_EXCLUSIVE),
 only change permissions once per repatch event. : [Attachment 33291] The
 Patch.
In-Reply-To: <bug-27564-0@https.bugs.webkit.org/>
References: <bug-27564-0@https.bugs.webkit.org/>
Message-ID: <20090722220158.F10B433E2E5F@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27564: With ENABLE(ASSEMBLER_WX_EXCLUSIVE), only change permissions once
per repatch event.
https://bugs.webkit.org/show_bug.cgi?id=27564

Attachment 33291: The Patch.
https://bugs.webkit.org/attachment.cgi?id=33291&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:02:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:02:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27565] Null deref in
 JSObject::mark due to null xhr wrapper : [Attachment 33297] Fixeration
In-Reply-To: <bug-27565-0@https.bugs.webkit.org/>
References: <bug-27565-0@https.bugs.webkit.org/>
Message-ID: <20090722220212.512DE33E2E71@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has asked  for review:
Bug 27565: Null deref in JSObject::mark due to null xhr wrapper
https://bugs.webkit.org/show_bug.cgi?id=27565

Attachment 33297: Fixeration
https://bugs.webkit.org/attachment.cgi?id=33297&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:02:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:02:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27567] False positives in
 namespace indentation checks : [Attachment 33298] Fix false positives in
 namespace indentation checks
In-Reply-To: <bug-27567-0@https.bugs.webkit.org/>
References: <bug-27567-0@https.bugs.webkit.org/>
Message-ID: <20090722220212.6A19733E2E73@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27567: False positives in namespace indentation checks
https://bugs.webkit.org/show_bug.cgi?id=27567

Attachment 33298: Fix false positives in namespace indentation checks
https://bugs.webkit.org/attachment.cgi?id=33298&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:03:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:03:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27565] Null deref in
 JSObject::mark due to null xhr wrapper : [Attachment 33297] Fixeration
In-Reply-To: <bug-27565-0@https.bugs.webkit.org/>
References: <bug-27565-0@https.bugs.webkit.org/>
Message-ID: <20090722220354.6074E33E2ED3@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 27565: Null deref in JSObject::mark due to null xhr wrapper
https://bugs.webkit.org/show_bug.cgi?id=27565

Attachment 33297: Fixeration
https://bugs.webkit.org/attachment.cgi?id=33297&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:09:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:09:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27567] False positives in
 namespace indentation checks : [Attachment 33298] Fix false positives in
 namespace indentation checks
In-Reply-To: <bug-27567-0@https.bugs.webkit.org/>
References: <bug-27567-0@https.bugs.webkit.org/>
Message-ID: <20090722220959.0586333E2F65@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Jakob Petsovits <jpetso at gmx.at>'s request
for review:
Bug 27567: False positives in namespace indentation checks
https://bugs.webkit.org/show_bug.cgi?id=27567

Attachment 33298: Fix false positives in namespace indentation checks
https://bugs.webkit.org/attachment.cgi?id=33298&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Next time put more detail in the ChangeLog as you did in the bug report.

Also, I'd like a comment for the added regex.

From bugzilla-daemon at webkit.org  Wed Jul 22 15:16:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:16:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27174] XSSAuditor needs
 cleanup : [Attachment 33299] Patch
In-Reply-To: <bug-27174-0@https.bugs.webkit.org/>
References: <bug-27174-0@https.bugs.webkit.org/>
Message-ID: <20090722221657.38AF533E309A@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27174: XSSAuditor needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=27174

Attachment 33299: Patch
https://bugs.webkit.org/attachment.cgi?id=33299&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Updated patch, removed XSSAuditor::stripSlashes

From bugzilla-daemon at webkit.org  Wed Jul 22 15:20:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:20:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27567] False positives in
 namespace indentation checks : [Attachment 33300] Fix false positives in
 namespace indentation checks (try 2)
In-Reply-To: <bug-27567-0@https.bugs.webkit.org/>
References: <bug-27567-0@https.bugs.webkit.org/>
Message-ID: <20090722222006.3418E33E30EF@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27567: False positives in namespace indentation checks
https://bugs.webkit.org/show_bug.cgi?id=27567

Attachment 33300: Fix false positives in namespace indentation checks (try 2)
https://bugs.webkit.org/attachment.cgi?id=33300&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Better patch, more verbosely describing what is being done. (No changes in
functionality, though.)

From bugzilla-daemon at webkit.org  Wed Jul 22 15:23:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:23:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27174] XSSAuditor needs
 cleanup : [Attachment 33299] Patch
In-Reply-To: <bug-27174-0@https.bugs.webkit.org/>
References: <bug-27174-0@https.bugs.webkit.org/>
Message-ID: <20090722222332.ECB8B33E3157@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has canceled Daniel Bates
<dbates at berkeley.edu>'s request for review:
Bug 27174: XSSAuditor needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=27174

Attachment 33299: Patch
https://bugs.webkit.org/attachment.cgi?id=33299&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:23:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:23:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27174] XSSAuditor needs
 cleanup : [Attachment 33301] patch
In-Reply-To: <bug-27174-0@https.bugs.webkit.org/>
References: <bug-27174-0@https.bugs.webkit.org/>
Message-ID: <20090722222342.DEAD333E3172@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27174: XSSAuditor needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=27174

Attachment 33301: patch
https://bugs.webkit.org/attachment.cgi?id=33301&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:24:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:24:43 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27174] XSSAuditor needs
 cleanup : [Attachment 33301] patch
In-Reply-To: <bug-27174-0@https.bugs.webkit.org/>
References: <bug-27174-0@https.bugs.webkit.org/>
Message-ID: <20090722222443.9A0F233E31AC@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27174: XSSAuditor needs cleanup
https://bugs.webkit.org/show_bug.cgi?id=27174

Attachment 33301: patch
https://bugs.webkit.org/attachment.cgi?id=33301&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks Dan.

From bugzilla-daemon at webkit.org  Wed Jul 22 15:28:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:28:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27567] False positives in
 namespace indentation checks : [Attachment 33300] Fix false positives in
 namespace indentation checks (try 2)
In-Reply-To: <bug-27567-0@https.bugs.webkit.org/>
References: <bug-27567-0@https.bugs.webkit.org/>
Message-ID: <20090722222808.4B6A533E3230@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27567: False positives in namespace indentation checks
https://bugs.webkit.org/show_bug.cgi?id=27567

Attachment 33300: Fix false positives in namespace indentation checks (try 2)
https://bugs.webkit.org/attachment.cgi?id=33300&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:32:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:32:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27568] run-webkit-lint
 should be named check-webkit-style : [Attachment 33302] Proposed fix.
In-Reply-To: <bug-27568-0@https.bugs.webkit.org/>
References: <bug-27568-0@https.bugs.webkit.org/>
Message-ID: <20090722223222.E25A833E3283@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27568: run-webkit-lint should be named check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=27568

Attachment 33302: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33302&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:36:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:36:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27568] run-webkit-lint should
 be named check-webkit-style : [Attachment 33302] Proposed fix.
In-Reply-To: <bug-27568-0@https.bugs.webkit.org/>
References: <bug-27568-0@https.bugs.webkit.org/>
Message-ID: <20090722223645.CFE4133E3301@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27568: run-webkit-lint should be named check-webkit-style
https://bugs.webkit.org/show_bug.cgi?id=27568

Attachment 33302: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33302&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
As discussed with all known folks currently working on it.

From bugzilla-daemon at webkit.org  Wed Jul 22 15:38:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:38:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27474] Crash if the
 selection is set in a textarea/text input immediately after setting
 display:none : [Attachment 33129] Fixes crashes
In-Reply-To: <bug-27474-0@https.bugs.webkit.org/>
References: <bug-27474-0@https.bugs.webkit.org/>
Message-ID: <20090722223840.E311633E334D@gamma.macosforge.org>

Ojan Vafai <ojan at chromium.org> has canceled  review:
Bug 27474: Crash if the selection is set in a textarea/text input immediately
after setting display:none
https://bugs.webkit.org/show_bug.cgi?id=27474

Attachment 33129: Fixes crashes
https://bugs.webkit.org/attachment.cgi?id=33129&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 15:38:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:38:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27474] Crash if the
 selection is set in a textarea/text input immediately after setting
 display:none : [Attachment 33303] Fixes crashes
In-Reply-To: <bug-27474-0@https.bugs.webkit.org/>
References: <bug-27474-0@https.bugs.webkit.org/>
Message-ID: <20090722223843.9C86233E3358@gamma.macosforge.org>

Ojan Vafai <ojan at chromium.org> has asked  for review:
Bug 27474: Crash if the selection is set in a textarea/text input immediately
after setting display:none
https://bugs.webkit.org/show_bug.cgi?id=27474

Attachment 33303: Fixes crashes
https://bugs.webkit.org/attachment.cgi?id=33303&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>

---
 9 files changed, 132 insertions(+), 29 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 22 15:56:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 15:56:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27476]
 execCommand('underline' / 'strikeThrough') doesn't work properly with
 multiple styles in text-decoration : [Attachment 33304] 2nd submission,
 no longer adds hasValue to CSSValueList
In-Reply-To: <bug-27476-0@https.bugs.webkit.org/>
References: <bug-27476-0@https.bugs.webkit.org/>
Message-ID: <20090722225651.AC25E33E35E1@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33304: 2nd submission, no longer adds hasValue to CSSValueList
https://bugs.webkit.org/attachment.cgi?id=33304&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 16:10:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:10:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27099] Elements with
 display none still gets focus and take part in the tab order : [Attachment
 33305] Make isKeyboardFocusable return false when there is no renderer.
In-Reply-To: <bug-27099-0@https.bugs.webkit.org/>
References: <bug-27099-0@https.bugs.webkit.org/>
Message-ID: <20090722231050.91C9F33E3789@gamma.macosforge.org>

Erik Arvidsson <arv at chromium.org> has asked  for review:
Bug 27099: Elements with display none still gets focus and take part in the tab
order
https://bugs.webkit.org/show_bug.cgi?id=27099

Attachment 33305: Make isKeyboardFocusable return false when there is no
renderer.
https://bugs.webkit.org/attachment.cgi?id=33305&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 16:13:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:13:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27563] Remove unneeded
 virtual destructor from ScriptSourceProvider : [Attachment 33289] patch
In-Reply-To: <bug-27563-0@https.bugs.webkit.org/>
References: <bug-27563-0@https.bugs.webkit.org/>
Message-ID: <20090722231334.D900F33E37E1@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27563: Remove unneeded virtual destructor from ScriptSourceProvider
https://bugs.webkit.org/show_bug.cgi?id=27563

Attachment 33289: patch
https://bugs.webkit.org/attachment.cgi?id=33289&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I actually liked making it non-inline more, but this class isn't used all that
much for it to matter. r=me

From bugzilla-daemon at webkit.org  Wed Jul 22 16:26:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:26:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27476] execCommand('underline'
 / 'strikeThrough') doesn't work properly with multiple styles in
 text-decoration : [Attachment 33304] 2nd submission,
 no longer adds hasValue to CSSValueList
In-Reply-To: <bug-27476-0@https.bugs.webkit.org/>
References: <bug-27476-0@https.bugs.webkit.org/>
Message-ID: <20090722232618.D807F33E3933@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33304: 2nd submission, no longer adds hasValue to CSSValueList
https://bugs.webkit.org/attachment.cgi?id=33304&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
getComputedStyle/getComputedStyle-text-decoration.html shoudl be a js test
(like how editing/execCommand/resources/toggle-text-decorations.js is).  Ping
me if you need help converting it.

missing newline at EOF:
29 var successfullyParsed = true;
030 \ No newline at end of file

Would like to see the converted test. Otherwise this looks fine.

From bugzilla-daemon at webkit.org  Wed Jul 22 16:43:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:43:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 22784] [Chromium] Home, End,
 PageUp and PageDown buttons do not do anything in drop down lists :
 [Attachment 33306] Final(?) patch
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090722234352.CD0D733E3BDE@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33306: Final(?) patch
https://bugs.webkit.org/attachment.cgi?id=33306&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
This patches addresses the above review comments. It's also been updated to
WebKit r46229.

From bugzilla-daemon at webkit.org  Wed Jul 22 16:49:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:49:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27586] URL appears in
 back/forward button menu instead of title for items with custom
 representation : [Attachment 33307] patch
In-Reply-To: <bug-27586-0@https.bugs.webkit.org/>
References: <bug-27586-0@https.bugs.webkit.org/>
Message-ID: <20090722234902.A038833E3C67@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27586: URL appears in back/forward button menu instead of title for items
with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586

Attachment 33307: patch
https://bugs.webkit.org/attachment.cgi?id=33307&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 16:50:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:50:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 22784] [Chromium] Home, End,
 PageUp and PageDown buttons do not do anything in drop down lists :
 [Attachment 33306] Final(?) patch
In-Reply-To: <bug-22784-0@https.bugs.webkit.org/>
References: <bug-22784-0@https.bugs.webkit.org/>
Message-ID: <20090722235031.CADD333E3C85@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jens Alfke <snej at chromium.org>'s
request for review:
Bug 22784: [Chromium] Home, End, PageUp and PageDown buttons do not do anything
in drop down lists
https://bugs.webkit.org/show_bug.cgi?id=22784

Attachment 33306: Final(?) patch
https://bugs.webkit.org/attachment.cgi?id=33306&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I think the conversion to LF was over aggressive (when it was done to existing
files -- I didn't mean to suggest that.  Anyway, I'll take care of this all on
landing).

From bugzilla-daemon at webkit.org  Wed Jul 22 16:58:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 16:58:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27474] Crash if the selection
 is set in a textarea/text input immediately after setting display:none :
 [Attachment 33303] Fixes crashes
In-Reply-To: <bug-27474-0@https.bugs.webkit.org/>
References: <bug-27474-0@https.bugs.webkit.org/>
Message-ID: <20090722235825.9D90533E3D60@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Ojan Vafai <ojan at chromium.org>'s
request for review:
Bug 27474: Crash if the selection is set in a textarea/text input immediately
after setting display:none
https://bugs.webkit.org/show_bug.cgi?id=27474

Attachment 33303: Fixes crashes
https://bugs.webkit.org/attachment.cgi?id=33303&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   Unfortunately, this seems to be
> +	   untestable. Loading an external stylesheet and then having an inline

> +	   script hit this code did not result in an pending stylesheets.

You should talk to Hyatt. I'm sure he can give you a way to test this.

If we put too many of these calls in we get "flashes of unstyled content"
(FOUC).

We need to put these into calls that need to function even when called early,
while stylesheets are still loading.

But we should not put it into calls where it's OK if they silently do nothing
when called early, while stylesheets are still loading.

There's a risk that by following my request to do the stronger form of
updateLayout you will introduce FOUC.

> +static bool isTextFieldWithRendererAfterUpdateLayout(HTMLInputElement*
element)

I think the AfterUpdateLayout here is slightly too explicit.

> +    ASSERT(!document()->childNeedsStyleRecalc() ||
document()->inStyleRecalc());

If the assertion is going to take this form, then maybe we should expose this
expression instead of the raw inStyleRecalc value.

r=me

From bugzilla-daemon at webkit.org  Wed Jul 22 17:02:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 17:02:11 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27099] Elements with display
 none still gets focus and take part in the tab order : [Attachment 33305]
 Make isKeyboardFocusable return false when there is no renderer.
In-Reply-To: <bug-27099-0@https.bugs.webkit.org/>
References: <bug-27099-0@https.bugs.webkit.org/>
Message-ID: <20090723000211.372AB33E3DB0@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied Erik Arvidsson <arv at chromium.org>'s
request for review:
Bug 27099: Elements with display none still gets focus and take part in the tab
order
https://bugs.webkit.org/show_bug.cgi?id=27099

Attachment 33305: Make isKeyboardFocusable return false when there is no
renderer.
https://bugs.webkit.org/attachment.cgi?id=33305&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Thanks for tackling this. It looks like you are on the right track.

Unfortunately this is not quite right.

Calling renderer() inside a Node function can give you a false negative. The
object might have a different display type and layout just hasn't run yet. It's
an error to ever call renderer() unless you know that layout is up to date.

Instead, this check needs to be something done by callers that are at a higher
level; they are in a position to know that layout is updated and if renderer()
is 0 it actually means something.

From bugzilla-daemon at webkit.org  Wed Jul 22 18:12:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 18:12:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27476]
 execCommand('underline' / 'strikeThrough') doesn't work properly with
 multiple styles in text-decoration : [Attachment 33308] 3rd submission,
 test for computed style is converted to a js test
In-Reply-To: <bug-27476-0@https.bugs.webkit.org/>
References: <bug-27476-0@https.bugs.webkit.org/>
Message-ID: <20090723011253.47AB233E435D@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33308: 3rd submission, test for computed style is converted to a js
test
https://bugs.webkit.org/attachment.cgi?id=33308&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 18:14:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 18:14:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27586] URL appears in
 back/forward button menu instead of title for items with custom
 representation : [Attachment 33307] patch
In-Reply-To: <bug-27586-0@https.bugs.webkit.org/>
References: <bug-27586-0@https.bugs.webkit.org/>
Message-ID: <20090723011412.A66DF33E437B@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 27586: URL appears in back/forward button menu instead of title for items
with custom representation
https://bugs.webkit.org/show_bug.cgi?id=27586

Attachment 33307: patch
https://bugs.webkit.org/attachment.cgi?id=33307&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
Nice!

From bugzilla-daemon at webkit.org  Wed Jul 22 18:24:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 18:24:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27588] Make most DOMObjects
 hold onto a JSDOMGlobalObject* : [Attachment 33309] patch
In-Reply-To: <bug-27588-0@https.bugs.webkit.org/>
References: <bug-27588-0@https.bugs.webkit.org/>
Message-ID: <20090723012457.D65D833E444A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27588: Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

Attachment 33309: patch
https://bugs.webkit.org/attachment.cgi?id=33309&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 18:29:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 18:29:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27476]
 execCommand('underline' / 'strikeThrough') doesn't work properly with
 multiple styles in text-decoration : [Attachment 33308] 3rd submission,
 test for computed style is converted to a js test
In-Reply-To: <bug-27476-0@https.bugs.webkit.org/>
References: <bug-27476-0@https.bugs.webkit.org/>
Message-ID: <20090723012934.92BCB33E44D2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27476: execCommand('underline' / 'strikeThrough') doesn't work properly
with multiple styles in text-decoration
https://bugs.webkit.org/show_bug.cgi?id=27476

Attachment 33308: 3rd submission, test for computed style is converted to a js
test
https://bugs.webkit.org/attachment.cgi?id=33308&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

From bugzilla-daemon at webkit.org  Wed Jul 22 19:16:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 19:16:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27589] Audio element at
 default width shouldn't have time field. : [Attachment 33310] WebCore:
In-Reply-To: <bug-27589-0@https.bugs.webkit.org/>
References: <bug-27589-0@https.bugs.webkit.org/>
Message-ID: <20090723021623.2E6E533E4913@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27589: Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

Attachment 33310: WebCore:
https://bugs.webkit.org/attachment.cgi?id=33310&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
2009-07-22  Pierre d'Herbemont	<pdherbemont at apple.com>

Reviewed by NOBODY (OOPS!).

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

* rendering/MediaControlElements.cpp:
(WebCore::MediaControlTimeDisplayElement::setVisible): Make sure we don't
forget to remember the visibility if there is no renderer.

LayoutTests:

2009-07-22  Pierre d'Herbemont	<pdherbemont at apple.com>

Reviewed by NOBODY (OOPS!).

Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

* platform/mac-snowleopard/Skipped: Enables back audio-controls-rendering.
* platform/mac/media/audio-controls-rendering-expected.checksum:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/audio-controls-rendering-expected.txt:
---
 7 files changed, 86 insertions(+), 46 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 22 19:21:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 19:21:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27591] REGRESSION (r46240):
 /fast/css/getComputedStyle/computed-style & computed-style-without-renderer
 needs rebaseline for Windows : [Attachment 33311] rebaseline
In-Reply-To: <bug-27591-0@https.bugs.webkit.org/>
References: <bug-27591-0@https.bugs.webkit.org/>
Message-ID: <20090723022122.B7EFD33E49C2@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27591: REGRESSION (r46240): /fast/css/getComputedStyle/computed-style &
computed-style-without-renderer needs rebaseline for Windows
https://bugs.webkit.org/show_bug.cgi?id=27591

Attachment 33311: rebaseline
https://bugs.webkit.org/attachment.cgi?id=33311&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 19:24:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 19:24:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27591] REGRESSION (r46240):
 /fast/css/getComputedStyle/computed-style & computed-style-without-renderer
 needs rebaseline for Windows : [Attachment 33311] rebaseline
In-Reply-To: <bug-27591-0@https.bugs.webkit.org/>
References: <bug-27591-0@https.bugs.webkit.org/>
Message-ID: <20090723022442.B062933E4A26@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27591: REGRESSION (r46240): /fast/css/getComputedStyle/computed-style &
computed-style-without-renderer needs rebaseline for Windows
https://bugs.webkit.org/show_bug.cgi?id=27591

Attachment 33311: rebaseline
https://bugs.webkit.org/attachment.cgi?id=33311&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks for explaining this patch to me on IRC.

From bugzilla-daemon at webkit.org  Wed Jul 22 22:07:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 22:07:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27594] Windows needs a
 better nightly launching mechanism : [Attachment 33313] Checkpoint of a new
 native nightly launcher
In-Reply-To: <bug-27594-0@https.bugs.webkit.org/>
References: <bug-27594-0@https.bugs.webkit.org/>
Message-ID: <20090723050724.57A7E33E5763@gamma.macosforge.org>

Steve Falkenburg <sfalken at apple.com> has asked	for review:
Bug 27594: Windows needs a better nightly launching mechanism
https://bugs.webkit.org/show_bug.cgi?id=27594

Attachment 33313: Checkpoint of a new native nightly launcher
https://bugs.webkit.org/attachment.cgi?id=33313&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 22:18:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 22:18:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27594] Windows needs a better
 nightly launching mechanism : [Attachment 33313] Checkpoint of a new native
 nightly launcher
In-Reply-To: <bug-27594-0@https.bugs.webkit.org/>
References: <bug-27594-0@https.bugs.webkit.org/>
Message-ID: <20090723051819.CF97033E584F@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Steve Falkenburg
<sfalken at apple.com>'s request for review:
Bug 27594: Windows needs a better nightly launching mechanism
https://bugs.webkit.org/show_bug.cgi?id=27594

Attachment 33313: Checkpoint of a new native nightly launcher
https://bugs.webkit.org/attachment.cgi?id=33313&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp
> ===================================================================
> --- WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp	(revision 0)
> +++ WebKitTools/WebKitLauncherWin/WebKitLauncherWin.cpp	(revision 0)
> @@ -0,0 +1,111 @@
> +/*
> + * Copyright (C) 2009 Apple Inc. All rights reserved.
> + *
> + * Redistribution and use in source and binary forms, with or without
> + * modification, are permitted provided that the following conditions
> + * are met:
> + *
> + * 1.  Redistributions of source code must retain the above copyright
> + *	  notice, this list of conditions and the following disclaimer.
> + * 2.  Redistributions in binary form must reproduce the above copyright
> + *	  notice, this list of conditions and the following disclaimer in the
> + *	  documentation and/or other materials provided with the distribution.
> + * 3.  Neither the name of Apple Computer, Inc. ("Apple") nor the names of
> + *	  its contributors may be used to endorse or promote products derived
> + *	  from this software without specific prior written permission.

This isn't the license that we typically use on new code.


The copyEnvironmentVariable function isn't used.  Will it be in the future?


> +int APIENTRY _tWinMain(HINSTANCE instance, HINSTANCE, LPTSTR commandLine,
int)
> +{
> +    STARTUPINFO startupInfo = {0};
> +    startupInfo.cb = sizeof(startupInfo);
> +    PROCESS_INFORMATION processInfo = {0};

These should be moved closer to where they're used.

> +    // Launch Safari as a child process
> +    CreateProcess(browserExe, commandLine, 0, 0, FALSE,
NORMAL_PRIORITY_CLASS | CREATE_UNICODE_ENVIRONMENT, 0, path, &startupInfo,
&processInfo);

Do we need some error handling here in case Safari couldn't be launched for
some reason?


r=me

From bugzilla-daemon at webkit.org  Wed Jul 22 22:22:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 22:22:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27595] WebCore/Kit has a
 few places that don't gracefully handle a null request returned from
 willSendRequest : [Attachment 33314] Proposed fix
In-Reply-To: <bug-27595-0@https.bugs.webkit.org/>
References: <bug-27595-0@https.bugs.webkit.org/>
Message-ID: <20090723052237.1430533E58B6@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27595: WebCore/Kit has a few places that don't gracefully handle a null
request returned from willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=27595

Attachment 33314: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=33314&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 22:24:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 22:24:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27595] WebCore/Kit has a few
 places that don't gracefully handle a null request returned from
 willSendRequest : [Attachment 33314] Proposed fix
In-Reply-To: <bug-27595-0@https.bugs.webkit.org/>
References: <bug-27595-0@https.bugs.webkit.org/>
Message-ID: <20090723052439.9CE1833E58D4@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 27595: WebCore/Kit has a few places that don't gracefully handle a null
request returned from willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=27595

Attachment 33314: Proposed fix
https://bugs.webkit.org/attachment.cgi?id=33314&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
Can you add a test for this? For example, could we configure the DRT resource
load delegate to return null when asked to?

From bugzilla-daemon at webkit.org  Wed Jul 22 23:10:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 23:10:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27597] [V8] Make Node
 wrappers go fast : [Attachment 33315] patch
In-Reply-To: <bug-27597-0@https.bugs.webkit.org/>
References: <bug-27597-0@https.bugs.webkit.org/>
Message-ID: <20090723061031.B841C33E5CAB@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27597: [V8] Make Node wrappers go fast
https://bugs.webkit.org/show_bug.cgi?id=27597

Attachment 33315: patch
https://bugs.webkit.org/attachment.cgi?id=33315&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 23:17:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 23:17:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27597] [V8] Make Node
 wrappers go fast : [Attachment 33315] patch
In-Reply-To: <bug-27597-0@https.bugs.webkit.org/>
References: <bug-27597-0@https.bugs.webkit.org/>
Message-ID: <20090723061723.47C5C33E5D51@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27597: [V8] Make Node wrappers go fast
https://bugs.webkit.org/show_bug.cgi?id=27597

Attachment 33315: patch
https://bugs.webkit.org/attachment.cgi?id=33315&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Without the "// static" comment, please :)

From bugzilla-daemon at webkit.org  Wed Jul 22 23:17:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 23:17:31 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27488] SVG and XPath memory
 leaks in V8 bindings : [Attachment 33155] Add 'create' methods to
 SVGPODTypeWrappers and XPathNSResolvers to avoid memory leaks.
In-Reply-To: <bug-27488-0@https.bugs.webkit.org/>
References: <bug-27488-0@https.bugs.webkit.org/>
Message-ID: <20090723061731.124ED33E5D6F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Mads Ager <ager at chromium.org>'s
request for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33155: Add 'create' methods to SVGPODTypeWrappers and
XPathNSResolvers to avoid memory leaks.
https://bugs.webkit.org/attachment.cgi?id=33155&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
R- based on Eric's comments.  I, for one, welcome our PassRefPtr overloads.

From bugzilla-daemon at webkit.org  Wed Jul 22 23:25:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 23:25:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27598] Clean up the
 AccessibilityObject class : [Attachment 33316] Patch
In-Reply-To: <bug-27598-0@https.bugs.webkit.org/>
References: <bug-27598-0@https.bugs.webkit.org/>
Message-ID: <20090723062512.7821633E5E54@gamma.macosforge.org>

Beth Dakin <bdakin at apple.com> has asked  for review:
Bug 27598: Clean up the AccessibilityObject class
https://bugs.webkit.org/show_bug.cgi?id=27598

Attachment 33316: Patch
https://bugs.webkit.org/attachment.cgi?id=33316&action=review

From bugzilla-daemon at webkit.org  Wed Jul 22 23:53:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 22 Jul 2009 23:53:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27169] typing
 "document.__proto__" in inspector throws exception : [Attachment 33317]
 Javascript Workaround
In-Reply-To: <bug-27169-0@https.bugs.webkit.org/>
References: <bug-27169-0@https.bugs.webkit.org/>
Message-ID: <20090723065317.0CDEC33E619D@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27169: typing "document.__proto__" in inspector throws exception
https://bugs.webkit.org/show_bug.cgi?id=27169

Attachment 33317: Javascript Workaround
https://bugs.webkit.org/attachment.cgi?id=33317&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This would be the javascript workaround.  I looked into what Firefox does and
they don't report document.__proto__ as an instanceof Node!  So maybe that
would be the better route.

WebKit via Web Inspector:
> document.__proto__ instanceof window.Node
true

Firefox via Firebug:
> document.__proto__ instanceof window.Node
false

From bugzilla-daemon at webkit.org  Thu Jul 23 00:01:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 00:01:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20215]
 execCommand('underline') can't remove <U> underlines : [Attachment 33318]
 fixes the bug (non-CSS mode still unsupported)
In-Reply-To: <bug-20215-0@https.bugs.webkit.org/>
References: <bug-20215-0@https.bugs.webkit.org/>
Message-ID: <20090723070143.C401A33E62CC@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 20215: execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

Attachment 33318: fixes the bug (non-CSS mode still unsupported)
https://bugs.webkit.org/attachment.cgi?id=33318&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 00:04:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 00:04:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27437] make HTMLAppletElement
 and HTMLEmbedElement compliant with de-facto JS-based standards under
 gobject bindings : [Attachment 33192] makes HTMLAppletElement and
 HTMLEmbedElement width and height DOMString except for Obj-C bindings
In-Reply-To: <bug-27437-0@https.bugs.webkit.org/>
References: <bug-27437-0@https.bugs.webkit.org/>
Message-ID: <20090723070451.DE38B33E633C@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33192: makes HTMLAppletElement and HTMLEmbedElement width and height
DOMString except for Obj-C bindings
https://bugs.webkit.org/attachment.cgi?id=33192&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 44473)
> +++ WebCore/ChangeLog (working copy)
> @@ -62327,6 +62335,21 @@
>	   (WebCore::PluginPackage::fetchInfo):
>	   (WebCore::PluginPackage::isPluginBlacklisted):
>  
> +2008-11-30  lkcl <lkcl at lkcl.net>

Please put the correct date and your name here.

> +
> +	   Reviewed by NOBODY (OOPS!)
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27437
> +
> +		Make width and height attributes DOMString except for
> +		LANGUAGE_OBJECTIVE_C due to API backwards-compatibility
> +		reasons.  HTML5 specification has HTMLAppletElement
> +		and HTMLEmbedElement width and height now marked as a
> +		DOMString.

You have a number of tabs here that our pre-commit hook will be unhappy with.

> +
> +	   * html/HTMLAppletElement.idl: width and height attributes DOMString
except for LANGUAGE_OBJECTIVE_C
> +	   * html/HTMLEmbedElement.idl: width and height attributes DOMString
except for LANGUAGE_OBJECTIVE_C

It'd be great if these sentences had correct grammar.

Please resubmit with an updated ChangeLog so that this can be landed.

From bugzilla-daemon at webkit.org  Thu Jul 23 00:19:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 00:19:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27424] adding
 ConvertToGCharPrivate.h : [Attachment 33088] rename to
 ConvertToCGharPrivate.h and fix up coding standards
In-Reply-To: <bug-27424-0@https.bugs.webkit.org/>
References: <bug-27424-0@https.bugs.webkit.org/>
Message-ID: <20090723071924.CBD3733E6545@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27424: adding ConvertToGCharPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33088: rename to ConvertToCGharPrivate.h and fix up coding standards
https://bugs.webkit.org/attachment.cgi?id=33088&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebKit/gtk/gdom/ConvertToGCharPrivate.h

Based on your previous comments and the fact that this deals with WebCore
types, this sounds like a file that's not intended to be used outside of
building WebKit.  Is there a reason that it needs the "Private" suffix?

> +/*
> + * added under bug #27424 - 19jul2009
> + */
> +
> +/* convenience c++ functions for converting various different webkit
> + * string types into a utf8 glib string.
> + */

These comments don't add anything.

ConvertToGchar doesn't fit our naming conventions, which states that functions
should not start with an initial capital letter.  The "Gchar" strikes me as a
little odd too, but I guess that's what falls out of the lowercase "gchar"
being camel-cased.  Returning a raw pointer that expect the caller to free
seems to be asking for memory leaks.  Is there some way we can make this
interface safer?

> +inline gchar* ConvertToGchar(WebCore::String const& s)
> +{
> +    return g_strdup(s.utf8().data());
> +}

There should be a blank line between each function.

> +inline gchar* ConvertToGchar(WebCore::KURL const& s)
> +{
> +    return g_strdup(s.string().utf8().data());
> +}

This could be expressed more concisely as: return ConvertToGchar(s.string());

> +inline gchar* ConvertToGchar(const JSC::UString& s)
> +{
> +    return g_strdup(s.UTF8String().c_str());
> +}

> +inline gchar* ConvertToGchar(WebCore::AtomicString const&s)
> +{
> +    return g_strdup(s.string().utf8().data());
> +}

Missing a space after the &.  This could be expressed more concisely as: return
ConvertToGchar(s.string());

> +2008-11-30  lkcl  <lkcl at lkcl.net>

Please update this with the current date and your name.

> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   WARNING: NO TEST CASES ADDED OR CHANGED

This line is an intended only as an informative note for the patch author.

> +	   (GStringConvert): bug #27424 - added ConvertToGCharPrivate.h to help
GObject bindings convert various types to gobject gchar* 

Please take a look at the format of our other ChangeLog entries for how your
entry should be structured.  The prepare-ChangeLog script can be used to assist
in the creation of a ChangeLog entry for your change.

From bugzilla-daemon at webkit.org  Thu Jul 23 00:25:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 00:25:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27599] 'const unsigned' in
 return value : [Attachment 33319] linenoconst.patch
In-Reply-To: <bug-27599-0@https.bugs.webkit.org/>
References: <bug-27599-0@https.bugs.webkit.org/>
Message-ID: <20090723072515.D356E33E65F2@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 27599: 'const unsigned' in return value
https://bugs.webkit.org/show_bug.cgi?id=27599

Attachment 33319: linenoconst.patch
https://bugs.webkit.org/attachment.cgi?id=33319&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Remove 'const' modifier.

From bugzilla-daemon at webkit.org  Thu Jul 23 00:56:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 00:56:27 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33063] adds 3 essential features to gobject document idl
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090723075627.65D6933E6927@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33063: adds 3 essential features to gobject document idl
https://bugs.webkit.org/attachment.cgi?id=33063&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/dom/Document.idl
> ===================================================================
> --- WebCore/dom/Document.idl	(revision 44473)
> +++ WebCore/dom/Document.idl	(working copy)
> @@ -154,7 +154,8 @@
>  
>		    attribute [ConvertNullToNullString] DOMString title;
>	   readonly attribute DOMString referrer;
> -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> +	(defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
>		    attribute [ConvertNullToNullString] DOMString domain;
>  #else
>	   readonly attribute DOMString domain;

I wonder why the non-JavaScript case is marked as readonly. The HTML 5 spec
suggests it should not be.  It may be that we should consider removing the
#if's here.

> @@ -180,7 +181,8 @@
>  
>	   NodeList getElementsByName(in DOMString elementName);
>  
> -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> +	(defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
>		    attribute [Custom] Location location;
>  #endif

This is flagged as being [Custom] but I don't see a gobject method implementing
this property anywhere in the patch.  Did you forget to include it?

> @@ -193,7 +195,8 @@
>	   Element	      elementFromPoint(in long x, in long y);
>  
>	   // Mozilla extensions
> -#if defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT
> +#if (defined(LANGUAGE_JAVASCRIPT) && LANGUAGE_JAVASCRIPT) || \
> +	(defined(LANGUAGE_GOBJECT) && LANGUAGE_GOBJECT)
>	   DOMSelection       getSelection();
>  #endif

The #if's should probably be removed from this one.  The method was added in
<http://trac.webkit.org/changeset/30515>, where the ChangeLog notes that it was
restricted to JS as it was only added for web compatibility.  Since then, the
getSelection attribute on Document has made its way in to the HTML 5
specification:
<http://www.whatwg.org/specs/web-apps/current-work/multipage/dom.html#documents
>.

From bugzilla-daemon at webkit.org  Thu Jul 23 00:58:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 00:58:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27599] 'const unsigned' in
 return value : [Attachment 33319] linenoconst.patch
In-Reply-To: <bug-27599-0@https.bugs.webkit.org/>
References: <bug-27599-0@https.bugs.webkit.org/>
Message-ID: <20090723075835.2EB3E33E6947@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 27599: 'const unsigned' in return value
https://bugs.webkit.org/show_bug.cgi?id=27599

Attachment 33319: linenoconst.patch
https://bugs.webkit.org/attachment.cgi?id=33319&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 23 01:25:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 01:25:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27435] adding XMLHttpRequest
 send idl language gobject : [Attachment 33064] allows DOMString to be
 passed to XMLHTTPRequest send, in gobject bindings
In-Reply-To: <bug-27435-0@https.bugs.webkit.org/>
References: <bug-27435-0@https.bugs.webkit.org/>
Message-ID: <20090723082525.0979633E6BB7@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27435: adding XMLHttpRequest send idl language gobject
https://bugs.webkit.org/show_bug.cgi?id=27435

Attachment 33064: allows DOMString to be passed to XMLHTTPRequest send, in
gobject bindings
https://bugs.webkit.org/attachment.cgi?id=33064&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 02:51:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 02:51:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27602] Build fix for x86
 platforms : [Attachment 33321] proposed patch
In-Reply-To: <bug-27602-0@https.bugs.webkit.org/>
References: <bug-27602-0@https.bugs.webkit.org/>
Message-ID: <20090723095145.563CE33E72F1@gamma.macosforge.org>

Csaba Osztrogon?c <oszi at inf.u-szeged.hu> has asked  for review:
Bug 27602: Build fix for x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=27602

Attachment 33321: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33321&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 02:53:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 02:53:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27601] Fixing minor isses
 in QtLauncher : [Attachment 33322] Fixes for QtLauncher
In-Reply-To: <bug-27601-0@https.bugs.webkit.org/>
References: <bug-27601-0@https.bugs.webkit.org/>
Message-ID: <20090723095343.0E4C333E733F@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 27601: Fixing minor isses in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27601

Attachment 33322: Fixes for QtLauncher
https://bugs.webkit.org/attachment.cgi?id=33322&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 03:17:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 03:17:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27603] updating
 Document.idl to match HTML5 spec: domain read-write and access to
 getSelection : [Attachment 33323] makes Document.domain read-write and adds
 Document.getSelection to all bindings, as per HTML5 spec
In-Reply-To: <bug-27603-0@https.bugs.webkit.org/>
References: <bug-27603-0@https.bugs.webkit.org/>
Message-ID: <20090723101743.CD2BF33E75D5@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27603: updating Document.idl to match HTML5 spec: domain read-write and
access to getSelection
https://bugs.webkit.org/show_bug.cgi?id=27603

Attachment 33323: makes Document.domain read-write and adds
Document.getSelection to all bindings, as per HTML5 spec
https://bugs.webkit.org/attachment.cgi?id=33323&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 03:23:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 03:23:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27601] Fixing minor isses in
 QtLauncher : [Attachment 33322] Fixes for QtLauncher
In-Reply-To: <bug-27601-0@https.bugs.webkit.org/>
References: <bug-27601-0@https.bugs.webkit.org/>
Message-ID: <20090723102310.A604D33E7643@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27601: Fixing minor isses in QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27601

Attachment 33322: Fixes for QtLauncher
https://bugs.webkit.org/attachment.cgi?id=33322&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 23 03:31:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 03:31:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33324] adds read-only access to Document.location pending writing of custom
 code to set location properties (at some indeterminate future point)
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090723103152.5F53433E7728@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33324: adds read-only access to Document.location pending writing of
custom code to set location properties (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33324&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 04:26:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 04:26:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27435] adding
 XMLHttpRequest send idl language gobject : [Attachment 33325] corrections
 to #ifdefs as per r2 comment
In-Reply-To: <bug-27435-0@https.bugs.webkit.org/>
References: <bug-27435-0@https.bugs.webkit.org/>
Message-ID: <20090723112647.4C97A33E7C33@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27435: adding XMLHttpRequest send idl language gobject
https://bugs.webkit.org/show_bug.cgi?id=27435

Attachment 33325: corrections to #ifdefs as per r2 comment
https://bugs.webkit.org/attachment.cgi?id=33325&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 06:20:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 06:20:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27488] SVG and XPath memory
 leaks in V8 bindings : [Attachment 33327] Avoid memory leaks and cleanup
 use of get() and release() on RefPtrs.
In-Reply-To: <bug-27488-0@https.bugs.webkit.org/>
References: <bug-27488-0@https.bugs.webkit.org/>
Message-ID: <20090723132032.0176F33E890D@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33327: Avoid memory leaks and cleanup use of get() and release() on
RefPtrs.
https://bugs.webkit.org/attachment.cgi?id=33327&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 06:33:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 06:33:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27437] make
 HTMLAppletElement and HTMLEmbedElement compliant with de-facto JS-based
 standards under gobject bindings : [Attachment 33328] corrects grammar,
 complies with precommit hook, adds correct date and name
In-Reply-To: <bug-27437-0@https.bugs.webkit.org/>
References: <bug-27437-0@https.bugs.webkit.org/>
Message-ID: <20090723133307.7673933E8A7E@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33328: corrects grammar, complies with precommit hook, adds correct
date and name
https://bugs.webkit.org/attachment.cgi?id=33328&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 07:25:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 07:25:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24540] Fix for missing mmap
 features in Symbian : [Attachment 32409] Update 2 of patch file for bug
 24540
In-Reply-To: <bug-24540-0@https.bugs.webkit.org/>
References: <bug-24540-0@https.bugs.webkit.org/>
Message-ID: <20090723142501.6022D33E9124@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 24540: Fix for missing mmap features in Symbian
https://bugs.webkit.org/show_bug.cgi?id=24540

Attachment 32409: Update 2 of patch file for bug 24540
https://bugs.webkit.org/attachment.cgi?id=32409&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>

> +#if PLATFORM(SYMBIAN)
> +    const size_t MAX_NUM_BLOCKS = 256; // Max size of collector heap set to
16 MB
> +    static RHeap* userChunk = NULL;
> +#endif
> +    

This should not be indented and 0 instead of NULL should be used, as Mark
points out.

That's a really simple and minor issue that I can fix while landing. The rest
looks good to me.

From bugzilla-daemon at webkit.org  Thu Jul 23 07:30:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 07:30:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27495] [Qt] Add simple proxy
 support for QtLauncher : [Attachment 33170] Proposed patch.
In-Reply-To: <bug-27495-0@https.bugs.webkit.org/>
References: <bug-27495-0@https.bugs.webkit.org/>
Message-ID: <20090723143002.D900E33E9210@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27495: [Qt] Add simple proxy support for QtLauncher
https://bugs.webkit.org/show_bug.cgi?id=27495

Attachment 33170: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33170&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 23 08:03:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:03:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27604] Enable cpplint for
 .c files : [Attachment 33329] Enable cpplint for .c files
In-Reply-To: <bug-27604-0@https.bugs.webkit.org/>
References: <bug-27604-0@https.bugs.webkit.org/>
Message-ID: <20090723150324.9598933E9625@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27604: Enable cpplint for .c files
https://bugs.webkit.org/show_bug.cgi?id=27604

Attachment 33329: Enable cpplint for .c files
https://bugs.webkit.org/attachment.cgi?id=33329&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:18:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:18:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27602] Build fix for x86
 platforms : [Attachment 33321] proposed patch
In-Reply-To: <bug-27602-0@https.bugs.webkit.org/>
References: <bug-27602-0@https.bugs.webkit.org/>
Message-ID: <20090723151836.9045433E97B9@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Csaba Osztrogon?c
<oszi at inf.u-szeged.hu>'s request for review:
Bug 27602: Build fix for x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=27602

Attachment 33321: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33321&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:27:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:27:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27598] Clean up the
 AccessibilityObject class : [Attachment 33316] Patch
In-Reply-To: <bug-27598-0@https.bugs.webkit.org/>
References: <bug-27598-0@https.bugs.webkit.org/>
Message-ID: <20090723152702.8272833E98E3@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 27598: Clean up the AccessibilityObject class
https://bugs.webkit.org/show_bug.cgi?id=27598

Attachment 33316: Patch
https://bugs.webkit.org/attachment.cgi?id=33316&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Making the functions pure virtual seems great to me!

It also seems OK to move these "stubs" to the header. I know Hyatt likes this
style.

But personally I normally avoid putting bodies of virtual functions into the
class definition in the header, even small stubs. For one thing, it means
changing any of these requires recompilation of any files that include the
header. And generally there are few opportunities for virtual functions to be
inlined, which is the usual reason for putting things in a header or in the
class definition.

> -    virtual VisiblePosition visiblePositionForIndex(unsigned indexValue,
bool lastIndexOK) const;
> +    virtual VisiblePosition visiblePositionForIndex(unsigned, bool) const {
return VisiblePosition(); }

Here I think it's not so great to lose the names of the arguments, since the
meaning of the bool is not clear without a name. Maybe keep lastIndexOK around,
but commented out, like this:

    virtual VisiblePosition visiblePositionForIndex(unsigned, bool /*
lastIndexOK */) const { return VisiblePosition(); }

Or leave this one in the implementation file.

r=me as-is, but please consider the lastIndexOK thing

From bugzilla-daemon at webkit.org  Thu Jul 23 08:27:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:27:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33330]
 patch to add --[no-]write option to prepare-ChangeLog to put new entries on
 stdout instead of modifiying ChangeLog files
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723152727.24D9833E98F0@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has asked	for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33330: patch to add --[no-]write option to prepare-ChangeLog to put
new entries on stdout instead of modifiying ChangeLog files
https://bugs.webkit.org/attachment.cgi?id=33330&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:27:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:27:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33262] fixed style errors
 reported by cpplint and added correct license text
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090723152758.A611433E990D@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33262: fixed style errors reported by cpplint and added correct
license text
https://bugs.webkit.org/attachment.cgi?id=33262&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
removed unnecessary files

From bugzilla-daemon at webkit.org  Thu Jul 23 08:27:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:27:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33331] removed unnecessary
 files
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090723152758.B8D9633E990F@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33331: removed unnecessary files
https://bugs.webkit.org/attachment.cgi?id=33331&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
removed unnecessary files

From bugzilla-daemon at webkit.org  Thu Jul 23 08:41:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:41:57 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27538] Qt memory consumption
 on site with many images : [Attachment 33252] Change the Qt image decoding
 to be closer to cairo
In-Reply-To: <bug-27538-0@https.bugs.webkit.org/>
References: <bug-27538-0@https.bugs.webkit.org/>
Message-ID: <20090723154157.EA60433E9A7E@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has canceled Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 27538: Qt memory consumption on site with many images
https://bugs.webkit.org/show_bug.cgi?id=27538

Attachment 33252: Change the Qt image decoding to be closer to cairo
https://bugs.webkit.org/attachment.cgi?id=33252&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:50:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:50:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27606]
 WebCore/page/Console.cpp does not conform to style standards : [Attachment
 33332] Style patch for Console.cpp
In-Reply-To: <bug-27606-0@https.bugs.webkit.org/>
References: <bug-27606-0@https.bugs.webkit.org/>
Message-ID: <20090723155018.1DEEF33E9B8B@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27606: WebCore/page/Console.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27606

Attachment 33332: Style patch for Console.cpp
https://bugs.webkit.org/attachment.cgi?id=33332&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:52:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:52:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33333] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090723155203.1F25A33E9BBE@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33333: Step 1
https://bugs.webkit.org/attachment.cgi?id=33333&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Step 1: 
- split classes, 
- move whatever is trivial to the InspectorBackend class
- hide private stuff in InspectorController
- delegate non-trivial calls such as highlighting-related.

From bugzilla-daemon at webkit.org  Thu Jul 23 08:52:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:52:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33330]
 patch to add --[no-]write option to prepare-ChangeLog to put new entries on
 stdout instead of modifiying ChangeLog files
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723155229.BC2C533E9BEE@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has canceled Eli Fidler <eli at staikos.net>'s
request for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33330: patch to add --[no-]write option to prepare-ChangeLog to put
new entries on stdout instead of modifiying ChangeLog files
https://bugs.webkit.org/attachment.cgi?id=33330&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:52:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:52:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33334]
 revised patch to handle top-level changes properly
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723155258.1F33633E9C05@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has asked	for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33334: revised patch to handle top-level changes properly
https://bugs.webkit.org/attachment.cgi?id=33334&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:55:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:55:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27604] Enable cpplint for .c
 files : [Attachment 33329] Enable cpplint for .c files
In-Reply-To: <bug-27604-0@https.bugs.webkit.org/>
References: <bug-27604-0@https.bugs.webkit.org/>
Message-ID: <20090723155522.8EF2933E9C70@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27604: Enable cpplint for .c files
https://bugs.webkit.org/show_bug.cgi?id=27604

Attachment 33329: Enable cpplint for .c files
https://bugs.webkit.org/attachment.cgi?id=33329&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Good stuff, although I think we should remove the .cc file ending as that is
not used in WebKit to my knowledge.  Anyways, another patch.

From bugzilla-daemon at webkit.org  Thu Jul 23 08:59:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:59:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27606]
 WebCore/page/Console.cpp does not conform to style standards : [Attachment
 33335] Replacement patch for Console.cpp
In-Reply-To: <bug-27606-0@https.bugs.webkit.org/>
References: <bug-27606-0@https.bugs.webkit.org/>
Message-ID: <20090723155914.D9F4F33E9CD7@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27606: WebCore/page/Console.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27606

Attachment 33335: Replacement patch for Console.cpp
https://bugs.webkit.org/attachment.cgi?id=33335&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 08:59:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 08:59:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27606]
 WebCore/page/Console.cpp does not conform to style standards : [Attachment
 33332] Style patch for Console.cpp
In-Reply-To: <bug-27606-0@https.bugs.webkit.org/>
References: <bug-27606-0@https.bugs.webkit.org/>
Message-ID: <20090723155914.B99A433E9CD4@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has canceled Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27606: WebCore/page/Console.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27606

Attachment 33332: Style patch for Console.cpp
https://bugs.webkit.org/attachment.cgi?id=33332&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:03:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:03:37 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27549] Make run-webkit-lint
 supports files as arguments : [Attachment 33274] Make run-webkit-lint
 supports files as arguments
In-Reply-To: <bug-27549-0@https.bugs.webkit.org/>
References: <bug-27549-0@https.bugs.webkit.org/>
Message-ID: <20090723160337.405B333E9D70@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27549: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/show_bug.cgi?id=27549

Attachment 33274: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/attachment.cgi?id=33274&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Thanks for the patch.  This is a nice addition.

Just a few things to address at the moment.

Well, first off, sorry, I changed the name of the tool on you. So if you would
switch the patch over to check-webkit-style, that would be excellent.

fwiw, you don't need to request me as the reviewer - Adam has been also
reviewing these and doing a great job (The funny thing is that it delayed your
review because I typically scan the general queue -- not used to being asked
for by name). cc'ing me did get my attention though :)


> diff --git a/WebKitTools/Scripts/run-webkit-lint
b/WebKitTools/Scripts/run-webkit-lint

Please fix up "cpplint._USAGE" to reflect the fact that you may optionally pass
in files.

What should happen if the user passes in --git-commit and files?  (Personally I
recommend something simple like an error message that you need to choose one or
the other.)

> +    if not filenames:
> +	   cwd = os.path.abspath('.')
> +	   scm = detect_scm_system(cwd)
> +
> +	   process_patch(scm.create_patch())
> +    else:
> +	   # Change stderr to write with replacement characters so we don't die

> +	   # if we try to print something containing non-ASCII characters.
> +	   sys.stderr = codecs.StreamReaderWriter(sys.stderr,
> +						  codecs.getreader('utf8'),
> +						  codecs.getwriter('utf8'),
> +						  'replace')

If this is useful (and I think it is), it seems like it would be needed for
both code paths, so I'd move this outside of the "if".

> +
> +	   for filename in filenames:
> +	       cpplint.process_file(filename)

From bugzilla-daemon at webkit.org  Thu Jul 23 09:04:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:04:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27607]
 WebCore/page/BarInfo.cpp does not conform to style standards : [Attachment
 33336] Style patch for BarInfo.cpp
In-Reply-To: <bug-27607-0@https.bugs.webkit.org/>
References: <bug-27607-0@https.bugs.webkit.org/>
Message-ID: <20090723160414.B4C0733E9DBB@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27607: WebCore/page/BarInfo.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27607

Attachment 33336: Style patch for BarInfo.cpp
https://bugs.webkit.org/attachment.cgi?id=33336&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:06:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:06:52 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27605] Improve git workflow by
 populating commit messages with ChangeLog entries. : [Attachment 33334]
 revised patch to handle top-level changes properly
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723160652.0A91433E9E17@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Eli Fidler <eli at staikos.net>'s request
for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33334: revised patch to handle top-level changes properly
https://bugs.webkit.org/attachment.cgi?id=33334&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> index 26eae74..654f679 100644
> --- a/WebKitTools/ChangeLog
> +++ b/WebKitTools/ChangeLog
> @@ -1,3 +1,17 @@
> +2009-07-23  Eli Fidler  <eli.fidler at torchmobile.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Improve git workflow by populating commit messages with ChangeLog
entries.
> +	   https://bugs.webkit.org/show_bug.cgi?id=27605
> +
> +		add --[no-]write option to optionally output new ChangeLog
entries to
> +		stdout instead of modifying ChangeLog files
> +
> +		fix Torch Mobile copyright

Please fix the indentation.

> -#   Add command line option to put the ChangeLog into a separate
> -#	 file or just spew it out stdout.
> +#   Add command line option to put the ChangeLog into a separate file.

Hmm, so this functionality supposedly existed at one point...

> +    if ($prefixDir eq "top level") {
> +	   $sortKey = "";
> +    } elsif ($prefixDir eq "Tools") {
> +	   $sortKey = "-, just after top level";
> +    } elsif ($prefixDir eq "WebBrowser") {
> +	   $sortKey = lc "WebKit, WebBrowser after";
> +    } elsif ($prefixDir eq "WebCore") {
> +	   $sortKey = lc "WebFoundation, WebCore after";

I understand that this logic was taken from commit-log-editor.	It'd be nice
for an explanation of where 'WebBrowser' and 'WebFoundation' come from, but I
suspect only the Apple folks would be able to provide that.  Still, it is good
to match commit-log-editor.

The patch looks good minus the minor nits above.  One semi-ugly thing is that
prepare-ChangeLog also writes to stderr by default a bunch of verbosity.  It is
not important for our use case, but perhaps a header or a line break should be
written to stderr right before we write to stdout to separate the two.

r- for the ChangeLog above.

Cheers,
Adam

From bugzilla-daemon at webkit.org  Thu Jul 23 09:09:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:09:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27607]
 WebCore/page/BarInfo.cpp does not conform to style standards : [Attachment
 33336] Style patch for BarInfo.cpp
In-Reply-To: <bug-27607-0@https.bugs.webkit.org/>
References: <bug-27607-0@https.bugs.webkit.org/>
Message-ID: <20090723160946.D63EF33E9E9B@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27607: WebCore/page/BarInfo.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27607

Attachment 33336: Style patch for BarInfo.cpp
https://bugs.webkit.org/attachment.cgi?id=33336&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:13:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:13:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27488] SVG and XPath memory
 leaks in V8 bindings : [Attachment 33327] Avoid memory leaks and cleanup
 use of get() and release() on RefPtrs.
In-Reply-To: <bug-27488-0@https.bugs.webkit.org/>
References: <bug-27488-0@https.bugs.webkit.org/>
Message-ID: <20090723161304.E345E33E9F03@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Mads Ager <ager at chromium.org>'s
request for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33327: Avoid memory leaks and cleanup use of get() and release() on
RefPtrs.
https://bugs.webkit.org/attachment.cgi?id=33327&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is looking good.  A couple questions:

	 if ($attrIsPodType) {
-	     $resultObject = "wrapper";
+	     $resultObject = "wrapper.get()";
+	 }

You should just just WTF::getPtr unconditionally.  It should be free in the
non-RefPtr case.

-    return V8DOMWrapper::convertNodeToV8Object(object.get());
+    return V8DOMWrapper::convertNodeToV8Object(object);
[...]
-    return V8DOMWrapper::convertNodeToV8Object(object.get());
+    return V8DOMWrapper::convertNodeToV8Object(object);

Why no release here?

From bugzilla-daemon at webkit.org  Thu Jul 23 09:15:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:15:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27606]
 WebCore/page/Console.cpp does not conform to style standards : [Attachment
 33335] Replacement patch for Console.cpp
In-Reply-To: <bug-27606-0@https.bugs.webkit.org/>
References: <bug-27606-0@https.bugs.webkit.org/>
Message-ID: <20090723161521.6330633E9F97@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27606: WebCore/page/Console.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27606

Attachment 33335: Replacement patch for Console.cpp
https://bugs.webkit.org/attachment.cgi?id=33335&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:22:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:22:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33338]
 updated patch to fix ChangeLog indentation
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723162203.B684333EA0AA@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has asked	for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33338: updated patch to fix ChangeLog indentation
https://bugs.webkit.org/attachment.cgi?id=33338&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:30:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:30:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33338]
 updated patch to fix ChangeLog indentation
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723163006.2176D33EA154@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Eli Fidler <eli at staikos.net>'s request
for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33338: updated patch to fix ChangeLog indentation
https://bugs.webkit.org/attachment.cgi?id=33338&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:33:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:33:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33226] Add Attributes
 to Nodes
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723163349.366E133EA1D3@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33226: Add Attributes to Nodes
https://bugs.webkit.org/attachment.cgi?id=33226&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This has slightly better margins.  When you add a new attribute the textfield
is no longer overlapping text from the attribute/text before it.  This was
because the .editing class was giving it a negative margin.  I overrule that
with a direct style property for the new attribute.

From bugzilla-daemon at webkit.org  Thu Jul 23 09:33:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:33:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33339] Add Attributes
 to Nodes
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723163349.6221F33EA1D7@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33339: Add Attributes to Nodes
https://bugs.webkit.org/attachment.cgi?id=33339&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
This has slightly better margins.  When you add a new attribute the textfield
is no longer overlapping text from the attribute/text before it.  This was
because the .editing class was giving it a negative margin.  I overrule that
with a direct style property for the new attribute.

From bugzilla-daemon at webkit.org  Thu Jul 23 09:36:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:36:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27435] adding XMLHttpRequest
 send idl language gobject : [Attachment 33325] corrections to #ifdefs as
 per r2 comment
In-Reply-To: <bug-27435-0@https.bugs.webkit.org/>
References: <bug-27435-0@https.bugs.webkit.org/>
Message-ID: <20090723163647.6F5F533EA227@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27435: adding XMLHttpRequest send idl language gobject
https://bugs.webkit.org/show_bug.cgi?id=27435

Attachment 33325: corrections to #ifdefs as per r2 comment
https://bugs.webkit.org/attachment.cgi?id=33325&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Marking as r- for reasons previously noted.

From bugzilla-daemon at webkit.org  Thu Jul 23 09:44:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:44:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27608]
 WebCore/page/Chrome.cpp does not conform to style standards : [Attachment
 33340] Style patch for Chrome.cpp
In-Reply-To: <bug-27608-0@https.bugs.webkit.org/>
References: <bug-27608-0@https.bugs.webkit.org/>
Message-ID: <20090723164449.1DA8C33EA339@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27608: WebCore/page/Chrome.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27608

Attachment 33340: Style patch for Chrome.cpp
https://bugs.webkit.org/attachment.cgi?id=33340&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 09:48:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:48:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27561] ImageDecoder
 enhancements for WINCE port : [Attachment 33341] make image decoders use
 ImageFrameSink
In-Reply-To: <bug-27561-0@https.bugs.webkit.org/>
References: <bug-27561-0@https.bugs.webkit.org/>
Message-ID: <20090723164809.A09B333EA3AA@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27561: ImageDecoder enhancements for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27561

Attachment 33341: make image decoders use ImageFrameSink
https://bugs.webkit.org/attachment.cgi?id=33341&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
1) use ImageFrameSink
2) use secondary GIF reader for size & frame count only
3) able to decode big image down to smaller destination buffer on the fly.

From bugzilla-daemon at webkit.org  Thu Jul 23 09:54:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:54:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27561] ImageDecoder
 enhancements for WINCE port : [Attachment 33342] decode from stream source
 data
In-Reply-To: <bug-27561-0@https.bugs.webkit.org/>
References: <bug-27561-0@https.bugs.webkit.org/>
Message-ID: <20090723165427.30E1833EA468@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27561: ImageDecoder enhancements for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27561

Attachment 33342: decode from stream source data
https://bugs.webkit.org/attachment.cgi?id=33342&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
Make decoders able to decode from stream or segmented source .

Decoders can grab segment by segment from the source.

From bugzilla-daemon at webkit.org  Thu Jul 23 09:56:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:56:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33324] adds read-only access to Document.location pending writing of custom
 code to set location properties (at some indeterminate future point)
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090723165614.2A06433EA4AA@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33324: adds read-only access to Document.location pending writing of
custom code to set location properties (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33324&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
As far as I can see this doesn't really address the issue, which relates to a
member of type Location being exposed.	Document::location being read-only does
not prevent you from mutating Location::href, which will fail unless your
bindings explicitly handle setters for Location's members in a custom fashion
(WebCore::Location has no setHref method).  Given that the URL of a document is
trivially retrievable from the ports WebView object, I don't see any reason to
#if this particular member until the problem here can be addressed in a more
robust manner.

From bugzilla-daemon at webkit.org  Thu Jul 23 09:58:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 09:58:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27437] make HTMLAppletElement
 and HTMLEmbedElement compliant with de-facto JS-based standards under
 gobject bindings : [Attachment 33328] corrects grammar,
 complies with precommit hook, adds correct date and name
In-Reply-To: <bug-27437-0@https.bugs.webkit.org/>
References: <bug-27437-0@https.bugs.webkit.org/>
Message-ID: <20090723165857.6A4A433EA508@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27437: make HTMLAppletElement and HTMLEmbedElement compliant with de-facto
JS-based standards under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27437

Attachment 33328: corrects grammar, complies with precommit hook, adds correct
date and name
https://bugs.webkit.org/attachment.cgi?id=33328&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/ChangeLog
> ===================================================================
> --- WebCore/ChangeLog (revision 44473)
> +++ WebCore/ChangeLog (working copy)
> @@ -62327,6 +62347,17 @@
>	   (WebCore::PluginPackage::fetchInfo):
>	   (WebCore::PluginPackage::isPluginBlacklisted):
>  
> +2008-11-30  Luke Kenneth Casson Leighton <lkcl at lkcl.net>
> +
> +	   Reviewed by NOBODY (OOPS!)
> +
> +	   https://bugs.webkit.org/show_bug.cgi?id=27437
> +
> +		Make width and height attributes DOMString except for
LANGUAGE_OBJECTIVE_C due to API backwards-compatibility reasons.  HTML5
specification has HTMLAppletElement and HTMLEmbedElement width and height now
marked as a DOMString.
> +
> +	   * html/HTMLAppletElement.idl: width and height attributes made to be
DOMString except for LANGUAGE_OBJECTIVE_C where they are kept as long
> +	   * html/HTMLEmbedElement.idl: width and height attributes made to be
DOMString except for LANGUAGE_OBJECTIVE_C where they are kept as long
> +

It's no longer November 2008 and there are still tabs in your ChangeLog entry? 
Can you please fix this minor issue so that this can be landed?

From bugzilla-daemon at webkit.org  Thu Jul 23 10:15:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:15:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27581] [CSS3 Backgrounds
 and Borders] Drop the prefix from box-shadow : [Attachment 33343] Patch
In-Reply-To: <bug-27581-0@https.bugs.webkit.org/>
References: <bug-27581-0@https.bugs.webkit.org/>
Message-ID: <20090723171524.511D533EA6D5@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27581: [CSS3 Backgrounds and Borders] Drop the prefix from box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27581

Attachment 33343: Patch
https://bugs.webkit.org/attachment.cgi?id=33343&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 10:19:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:19:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27581] [CSS3 Backgrounds and
 Borders] Drop the prefix from box-shadow : [Attachment 33343] Patch
In-Reply-To: <bug-27581-0@https.bugs.webkit.org/>
References: <bug-27581-0@https.bugs.webkit.org/>
Message-ID: <20090723171908.7DE1933EA757@gamma.macosforge.org>

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 27581: [CSS3 Backgrounds and Borders] Drop the prefix from box-shadow
https://bugs.webkit.org/show_bug.cgi?id=27581

Attachment 33343: Patch
https://bugs.webkit.org/attachment.cgi?id=33343&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 10:22:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:22:48 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33333] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090723172248.2B57133EA80F@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33333: Step 1
https://bugs.webkit.org/attachment.cgi?id=33333&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
What cleans up the plain pointer reference the InspectorBackend has to the
InspectorController? It looks like you want to make InspectorController not be
RefCounted anymore, but I don't see a change in the class inheritence.

Basically what guarentees the InspectorBackend has a valid InspectorController
reference still when InspectorBackend is RefCounted and can be wrapped to
JavaScript objects that have a GC lifetime?

Maybe InspectorController needs to stay RefCounted and still have RefPtr on
Page or when InspectorController goes away it disconnects from
InspectorBackend.

Otherwise patch looks great!

From bugzilla-daemon at webkit.org  Thu Jul 23 10:33:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:33:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33339] Add Attributes
 to Nodes
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723173335.812CC33EA939@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33339: Add Attributes to Nodes
https://bugs.webkit.org/attachment.cgi?id=33339&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Thanks for the video! It helped a lot.

I wonder if a icon (button looking) would be better than the text ellipsis. Or
move the ellipsis to the inside of the tag so it is where the new attribute
will be insterted? What do you think?

> +	       var span = document.createElement('span');
> +	       span.className = 'add-attribute';
> +	       span.innerText = '???';
> +	       this.listItemElement.appendChild(span);
> +	       this._addAttributeElement = span;

Better to use a escaped character (\uXXXX) instead of UTF8 here. Also we use
double quotes for string almost esclusivly in our JS.

The textContent property is better to use than innerText. It has no IE
weirdness and is standard.

> +		   this._addAttributeElement.parentNode.removeChild(
this._addAttributeElement );

No spaces needed here.

> +	   if ( tag.getElementsByClassName('webkit-html-attribute').length > 0
) {

No spaces needed here.

> +	   return this._startEditingAttribute(attr, { target: attr });

No spaces needed here.

From bugzilla-daemon at webkit.org  Thu Jul 23 10:35:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:35:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33344] makes Document.location and all Location properties read-only,
 pending writing of custom code (at some indeterminate future point)
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090723173508.D9AC233EA994@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33344: makes Document.location and all Location properties
read-only, pending writing of custom code (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33344&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
like this?  what do you think?	it's an intermediate "safety" step.

i can't cut access to Location out entirely, because of the "get" code in the
pyjamas API:

http://pyjamas.svn.sourceforge.net/viewvc/pyjamas/trunk/library/pyjamas/Locatio
n.py?content-type=text%2Fplain

From bugzilla-daemon at webkit.org  Thu Jul 23 10:44:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:44:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27589] Audio element at
 default width shouldn't have time field. : [Attachment 33310] WebCore:
In-Reply-To: <bug-27589-0@https.bugs.webkit.org/>
References: <bug-27589-0@https.bugs.webkit.org/>
Message-ID: <20090723174449.D4F3C33EAAB2@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27589: Audio element at default width shouldn't have time field.
https://bugs.webkit.org/show_bug.cgi?id=27589

Attachment 33310: WebCore:
https://bugs.webkit.org/attachment.cgi?id=33310&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 10:54:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:54:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25463] Desktop
 Notifications API : [Attachment 33345] Notifications API,
 combined Core and Tests
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090723175425.CD58733EABD4@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has asked  for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 33345: Notifications API, combined Core and Tests
https://bugs.webkit.org/attachment.cgi?id=33345&action=review

------- Additional Comments from John Gregg <johnnyg at google.com>
New patch which addresses the feedback and combines the two pieces together. 
V8 Bindings still pending in a separate patch.	One small addition to this
patch allows the notification to inform its presenter when it's being
destroyed, in order to detach it from future events.

From bugzilla-daemon at webkit.org  Thu Jul 23 10:58:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:58:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25463] Desktop Notifications
 API : [Attachment 33345] Notifications API, combined Core and Tests
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090723175827.9644833EAC43@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has canceled John Gregg <johnnyg at google.com>'s
request for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 33345: Notifications API, combined Core and Tests
https://bugs.webkit.org/attachment.cgi?id=33345&action=review

------- Additional Comments from John Gregg <johnnyg at google.com>
same patch as above without bogus svn:executable properties.

From bugzilla-daemon at webkit.org  Thu Jul 23 10:58:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 10:58:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25463] Desktop
 Notifications API : [Attachment 33346] Notifications API,
 combined Core and Tests
In-Reply-To: <bug-25463-0@https.bugs.webkit.org/>
References: <bug-25463-0@https.bugs.webkit.org/>
Message-ID: <20090723175827.A9C1933EAC45@gamma.macosforge.org>

John Gregg <johnnyg at google.com> has asked  for review:
Bug 25463: Desktop Notifications API
https://bugs.webkit.org/show_bug.cgi?id=25463

Attachment 33346: Notifications API, combined Core and Tests
https://bugs.webkit.org/attachment.cgi?id=33346&action=review

------- Additional Comments from John Gregg <johnnyg at google.com>
same patch as above without bogus svn:executable properties.

From bugzilla-daemon at webkit.org  Thu Jul 23 11:01:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:01:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33212] v1
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090723180124.D95A133EACBB@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33212: v1
https://bugs.webkit.org/attachment.cgi?id=33212&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/storage/StorageAreaImpl.cpp
...
> +    // The frame pointer can be NULL in Chromium since this call is made in
a
> +    // different process from where the Frame object exists.  Luckily
private
> +    // browsing is implemented differently in Chromium, so it'd never return

> +    // true anyway.

This is a good comment for the ChangeLog since it is the kind of thing that
could get stale, and it refers to things like Chrome's multi-process
architecture
that are not visible to someone just looking at the WebKit code base.

We have made a concerted effort to avoid putting comments into WebKit that
refer
to Chrome and Chrome's architecture as much as we can.	If we can instead have
WebKit "make sense" standalone then it is a good thing.  It means WebKit will
be
easier to understand.

Ultimately, I think we should probably revise StorageAreaImpl to not depend
directly on having a Page with Settings.  Or, in Chromium we should have a
dummy Page so that we can provide Settings.  Or, finally... the simplest thing
is to just have a comment that says StorageAreaImpl should be usable when there

is no associated Frame.  We could have a single comment in the header say that
documents that.  We could add that Chromium uses it that way without needing to

give much more detail.	A blanket comment like that would help someone else who

is tempted to add additional code to touch the Frame, Page, or Settings.

Otherwise, looks good.

From bugzilla-daemon at webkit.org  Thu Jul 23 11:26:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:26:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27503] Inspector: Should
 Syntax Highlight JSON : [Attachment 33182] Added 'application/javascript'
In-Reply-To: <bug-27503-0@https.bugs.webkit.org/>
References: <bug-27503-0@https.bugs.webkit.org/>
Message-ID: <20090723182641.7862333EAFC6@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27503: Inspector: Should Syntax Highlight JSON
https://bugs.webkit.org/show_bug.cgi?id=27503

Attachment 33182: Added 'application/javascript'
https://bugs.webkit.org/attachment.cgi?id=33182&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:27:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:27:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27169] typing
 "document.__proto__" in inspector throws exception : [Attachment 33317]
 Javascript Workaround
In-Reply-To: <bug-27169-0@https.bugs.webkit.org/>
References: <bug-27169-0@https.bugs.webkit.org/>
Message-ID: <20090723182724.30D4533EAFDE@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27169: typing "document.__proto__" in inspector throws exception
https://bugs.webkit.org/show_bug.cgi?id=27169

Attachment 33317: Javascript Workaround
https://bugs.webkit.org/attachment.cgi?id=33317&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:33:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:33:31 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14410] Dragging a resource in
 the sidebar should drag it's URL : [Attachment 33008] Make Resource Have a
 Draggable URL
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090723183331.75E8A33EB0C2@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33008: Make Resource Have a Draggable URL
https://bugs.webkit.org/attachment.cgi?id=33008&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   var link = document.createElement('a');
> +	   link.href = this.resource.url;
> +	   link.className = 'invisible';
> +	   for (var i = 0, len = this._listItemNode.children.length; i < len;
++i)
> +	       link.appendChild(this._listItemNode.firstChild);
> +	   this._listItemNode.appendChild(link);

This should use childNodes and not children. You could do this another way
using DOMRange's surroundContents() function.

https://developer.mozilla.org/en/DOM:range.surroundContents

Also use double quotes for strings.

From bugzilla-daemon at webkit.org  Thu Jul 23 11:38:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:38:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27610] Add check for
 line-breaking rule #3 to cpplint : [Attachment 33347] Add check for
 line-breaking rule #3 to cpplint
In-Reply-To: <bug-27610-0@https.bugs.webkit.org/>
References: <bug-27610-0@https.bugs.webkit.org/>
Message-ID: <20090723183826.2145533EB18F@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33347: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/attachment.cgi?id=33347&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:40:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:40:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27286] Inspector: Keyboard
 Shortcuts to Switch Panels : [Attachment 32758] Keyboard Shortcuts for
 Switching Panels
In-Reply-To: <bug-27286-0@https.bugs.webkit.org/>
References: <bug-27286-0@https.bugs.webkit.org/>
Message-ID: <20090723184021.E298C33EB1CA@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27286: Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286

Attachment 32758: Keyboard Shortcuts for Switching Panels
https://bugs.webkit.org/attachment.cgi?id=32758&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +		       index = (index === 0) ? this.panelOrder.length-1 :
index-1;

Should have spaces around the "-"s.

From bugzilla-daemon at webkit.org  Thu Jul 23 11:41:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:41:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27288] Inspector: Missing
 UIString and other localizedString.js fixes : [Attachment 32763] Localized
 String Fixes
In-Reply-To: <bug-27288-0@https.bugs.webkit.org/>
References: <bug-27288-0@https.bugs.webkit.org/>
Message-ID: <20090723184106.B593D33EB206@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27288: Inspector: Missing UIString and other localizedString.js fixes
https://bugs.webkit.org/show_bug.cgi?id=27288

Attachment 32763: Localized String Fixes
https://bugs.webkit.org/attachment.cgi?id=32763&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:46:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:46:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27329] Inspector: Properties
 Should be Sorted more Naturally : [Attachment 32879] Sort is Applied
 Correctly, only When Displaying
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090723184601.0B20E33EB2BE@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 32879: Sort is Applied Correctly, only When Displaying
https://bugs.webkit.org/attachment.cgi?id=32879&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +		       if ( !+chunka && !+chunkb ) // chunks are strings of all
0s (special case)

No need for spaces on the inside of the parenthesis.

> +	       }
> +	       else if (chunka !== chunkb)

The else should be on on the same lien as the curly brace.

Maybe move the sort function to Utilities.js so it could be used by other
callers?

I think sorting the completions this way would be good too.

From bugzilla-daemon at webkit.org  Thu Jul 23 11:46:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:46:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27526] Inspector: Removing an
 Attribute via Edit should Delete the Attribute,
 Not Ignore Your Changes : [Attachment 33231] Removing an Attribute Deletes
 the Attribute - And Fix Possible Exception
In-Reply-To: <bug-27526-0@https.bugs.webkit.org/>
References: <bug-27526-0@https.bugs.webkit.org/>
Message-ID: <20090723184648.94FBC33EB2EC@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27526: Inspector: Removing an Attribute via Edit should Delete the
Attribute, Not Ignore Your Changes
https://bugs.webkit.org/show_bug.cgi?id=27526

Attachment 33231: Removing an Attribute Deletes the Attribute - And Fix
Possible Exception
https://bugs.webkit.org/attachment.cgi?id=33231&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:48:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:48:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14409] Double click on a
 resource in the sidebar should open that resource in Safari : [Attachment
 33006] Double Click opens the Resource in a New Window
In-Reply-To: <bug-14409-0@https.bugs.webkit.org/>
References: <bug-14409-0@https.bugs.webkit.org/>
Message-ID: <20090723184853.2E68C33EB31A@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 14409: Double click on a resource in the sidebar should open that resource
in Safari
https://bugs.webkit.org/show_bug.cgi?id=14409

Attachment 33006: Double Click opens the Resource in a New Window
https://bugs.webkit.org/attachment.cgi?id=33006&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:52:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:52:34 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27400] Inspector:
 Automatically Refresh DOM Storage Grids on "storage" event : [Attachment
 32993] Live Update both DOM Storage Grids
In-Reply-To: <bug-27400-0@https.bugs.webkit.org/>
References: <bug-27400-0@https.bugs.webkit.org/>
Message-ID: <20090723185234.2CB7933EB39E@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27400: Inspector: Automatically Refresh DOM Storage Grids on "storage"
event
https://bugs.webkit.org/show_bug.cgi?id=27400

Attachment 32993: Live Update both DOM Storage Grids
https://bugs.webkit.org/attachment.cgi?id=32993&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> - * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
> + * Copyright (C) 2007, 2008, 2009 Apple Inc.  All rights reserved.

You should add your name and copyright on a new line instead.

> +	   inspectedWindow.addEventListener('storage',
this._storageEventListener, true);

You should use double quotes for strings.

> +	   var flag = (event.storageArea ==
InspectorController.inspectedWindow().localStorage);
> +	   if (this._domStorage) {

An early return would be better here.

> +	       var domStorageLength = this._domStorage.length;
> +	       for (var i = 0; i < domStorageLength; ++i) {
> +		   var domStorage = this._domStorage[i];
> +		   if (flag == domStorage.isLocalStorage) {

Triple equals.

> +		       var view = domStorage._domStorageView;
> +		       if (this.visibleView && view == this.visibleView)

Ditto.

From bugzilla-daemon at webkit.org  Thu Jul 23 11:53:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:53:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27572] [CSS3 Backgrounds
 and Borders] Add support for the "local" value for background-attachment :
 [Attachment 33348] Patch
In-Reply-To: <bug-27572-0@https.bugs.webkit.org/>
References: <bug-27572-0@https.bugs.webkit.org/>
Message-ID: <20090723185342.4184133EB3FC@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has asked	for review:
Bug 27572: [CSS3 Backgrounds and Borders] Add support for the "local" value for
background-attachment
https://bugs.webkit.org/show_bug.cgi?id=27572

Attachment 33348: Patch
https://bugs.webkit.org/attachment.cgi?id=33348&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 11:56:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:56:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27612] handling scripts can
 block UI : [Attachment 33349] the patch
In-Reply-To: <bug-27612-0@https.bugs.webkit.org/>
References: <bug-27612-0@https.bugs.webkit.org/>
Message-ID: <20090723185625.6E74933EB463@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27612: handling scripts can block UI
https://bugs.webkit.org/show_bug.cgi?id=27612

Attachment 33349: the patch
https://bugs.webkit.org/attachment.cgi?id=33349&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>

CachedScript calls client->notifyFinished() immediately if the script is
already in cache, and it also does that when all resource data comes.

In the case that the user goes back/forward to a page that contains many JS
files, HMTLTokenizer will decode and execute those JS files at one time. This
can affect UI responsiveness.

The attached patch contains code to delay sending notifications to cliensts of
CachedScript by timer.

It helps improving responsiveness on WinMob

(Probably this is not a problem at all for desktop browsers?)

From bugzilla-daemon at webkit.org  Thu Jul 23 11:59:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 11:59:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27572] [CSS3 Backgrounds and
 Borders] Add support for the "local" value for background-attachment :
 [Attachment 33348] Patch
In-Reply-To: <bug-27572-0@https.bugs.webkit.org/>
References: <bug-27572-0@https.bugs.webkit.org/>
Message-ID: <20090723185906.60FCA33EB4B1@gamma.macosforge.org>

mitz at webkit.org has granted Dave Hyatt <hyatt at apple.com>'s request for review:
Bug 27572: [CSS3 Backgrounds and Borders] Add support for the "local" value for
background-attachment
https://bugs.webkit.org/show_bug.cgi?id=27572

Attachment 33348: Patch
https://bugs.webkit.org/attachment.cgi?id=33348&action=review

------- Additional Comments from mitz at webkit.org
> +</html>
> \ No newline at end of file

Please add a newline.

From bugzilla-daemon at webkit.org  Thu Jul 23 12:07:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:07:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27613]
 WebCore/page/ContextMenuController.cpp does not conform to style standards
 : [Attachment 33350] Style patch for ContextMenuController.cpp
In-Reply-To: <bug-27613-0@https.bugs.webkit.org/>
References: <bug-27613-0@https.bugs.webkit.org/>
Message-ID: <20090723190759.4B21F33EB5F6@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27613: WebCore/page/ContextMenuController.cpp does not conform to style
standards
https://bugs.webkit.org/show_bug.cgi?id=27613

Attachment 33350: Style patch for ContextMenuController.cpp
https://bugs.webkit.org/attachment.cgi?id=33350&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 12:13:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:13:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27614]
 WebCore/page/Coordinates.cpp does not conform to style standards :
 [Attachment 33351] Style patch for Coordinates.cpp
In-Reply-To: <bug-27614-0@https.bugs.webkit.org/>
References: <bug-27614-0@https.bugs.webkit.org/>
Message-ID: <20090723191348.781ED33EB6A9@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27614: WebCore/page/Coordinates.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27614

Attachment 33351: Style patch for Coordinates.cpp
https://bugs.webkit.org/attachment.cgi?id=33351&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 12:14:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:14:09 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27610] Add check for
 line-breaking rule #3 to cpplint : [Attachment 33347] Add check for
 line-breaking rule #3 to cpplint
In-Reply-To: <bug-27610-0@https.bugs.webkit.org/>
References: <bug-27610-0@https.bugs.webkit.org/>
Message-ID: <20090723191409.A5A3B33EB6B9@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Jakob Petsovits <jpetso at gmx.at>'s request
for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33347: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/attachment.cgi?id=33347&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
First, I want to say that this is awesome.  I wasn't sure we'd be able to
easily check this style rule.

> +    readability/else_if

So you are adding an entirely new category.  Far enough.  At this point I want
to say I think this test should check for the following situation too:

if (true) {
    foo();
    return;
} else {
    bar();
}

The style guide doesn't explicitly say it, but I think it is implied.  Why on
earth would we allow the above, but deny for 'else if' ?

As such, I think the name of the category as well as the rest of the code
should be changed to reflect this case as well and test cases added.

The style guide should probably be updated to make it explicit as well.

> +def check_else_if_with_prior_return(filename, clean_lines, line_number,
error):

See above re: naming of method.

> +    elseif_match =
match(r'(?P<elseif_indentation>\s*)(?P<brace>\}\s*)?else\s+if\s*\(', line)
> +    if not elseif_match:
> +	   return
> +
> +    elseif_indentation = elseif_match.group('elseif_indentation')
> +    inner_indentation = elseif_indentation + ' ' * 4
> +    expect_closing_brace = elseif_match.start('brace') == -1

Ok, I follow.  You are going to rely upon indentation to tell the story.  This
is going to produce false positives for places where the code is improperly
indented and it is going to miss
a lot of cases too potentially.  That is ok, though as we understand cpplint
has false positives and is only meant as a guide in addition to review.

> +	   # Skip not only empty lines but also those with preprocessor
directives
> +	   # and goto labels.
> +	   if current_line.strip() == '' or current_line.startswith('#') or
match(r'\w+\s*:\s*$', current_line):
> +	       continue

Perhaps it'd be good to break these regex's out where they are used in multiple
places by cpplint.  RE_PATTERN_INCLUDE does this with good success.

Maybe RE_PATTERN_GOTO and RE_PATTERN_PREPROCESSOR too?	Good refactoring
possibility to think about.

> +	   # Skip lines with closing braces on the original indentation level.
> +	   # Even though the styleguide says they should be on the same line as

> +	   # the "else if" statement, we also want to check for instances where

> +	   # the current code does not comply with the coding style. Thus,
ignore
> +	   # these lines and proceed to the line before that.
> +	   if expect_closing_brace and current_line == elseif_indentation +
'}':
> +	       expect_closing_brace = False
> +	       continue

After this you don't expect a closing brace, right?  Where is
'expect_closing_brace' used again?  I don't see it...  Is this variable
necessary?  What happens when you expect a closing brace and it never comes
because the prior if doesn't have braces?

> +	   # As we're going up the lines, the first real statement to encounter

> +	   # has to be a return statement - otherwise, this check doesn't
apply.
> +	   if not encountered_return:
> +	       if current_line.startswith(inner_indentation + 'return ') or
current_line.startswith(inner_indentation + 'return;'):
> +		   encountered_return = True
> +		   continue
> +	       else:
> +		   break

Why not just, "if current_line.startswith(inner_indentation + 'return')" ?

> +	   # When code execution reaches this point, we have found a "return"
line
> +	   # as last statement of the previous block. Now we only need to make
> +	   # sure that the block belongs to an "if", and we can throw an error.


What else is it going to belong to? an 'else if'? if it is an 'else if' 
shouldn't we complain for that too?

    if (condition1) {
	foo1();
    } else if (condition2) {
	foo2();
	return;
    } else if (condition3 {
	foo3();
    } else {
	foo4();
    }

That should be rewritten too, no?

    if (!condition1 && condition2) {
	foo2();
	return;
    }

    if (condition1) {
	foo1();
    } else if (condition3 {
	foo3();
    } else {
	foo4();
    }

What do others think?

> +	   # Skip lines with opening braces on the original indentation level,
> +	   # similar to the closing braces check above.
> +	   if current_line == elseif_indentation + '{':
> +	       continue

I don't follow this...

> +	   current_indentation_match =
match(r'(?P<indentation>\s*)(?P<remaining_line>.*)$', current_line);
> +	   current_indentation = current_indentation_match.group('indentation')

> +	   remaining_line = current_indentation_match.group('remaining_line')

Guess you are looking for original 'if'...

> +	   # Skip everything that's further indented than our "else if".
> +	   if current_indentation.startswith(elseif_indentation) and
current_indentation != elseif_indentation:
> +	       continue
> +
> +	   # So we've got a line with same (or less) indentation. Is it an
"if"?
> +	   # If yes: throw an error. If no: don't throw an error.
> +	   # Whatever the outcome, this is the end of our loop.
> +	   if match(r'if\s*\(', remaining_line):
> +	       error(filename, line_number + line_offset,
'readability/else_if', 4,
> +		     'An else if statement should be written as an if statement
when the prior if concludes with a return statement.')
> +	   break

Can be greatly simplified if we also consider above I think.  Then you won't
have to go searching for original if.

I'd like to get some others feedback if possible.

From bugzilla-daemon at webkit.org  Thu Jul 23 12:30:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:30:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27617]
 WebCore/page/DOMSelection.cpp/h does not conform to style standards :
 [Attachment 33352] Style patch for DomSelectionPatch.cpp/h
In-Reply-To: <bug-27617-0@https.bugs.webkit.org/>
References: <bug-27617-0@https.bugs.webkit.org/>
Message-ID: <20090723193044.E75DA33EB8A6@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27617: WebCore/page/DOMSelection.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27617

Attachment 33352: Style patch for DomSelectionPatch.cpp/h
https://bugs.webkit.org/attachment.cgi?id=33352&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 12:33:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:33:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27554] getComputedStyle
 does not contain a value for text-overflow : [Attachment 33353] Patch to
 expose the value of text-overflow on the computedStyle object.
In-Reply-To: <bug-27554-0@https.bugs.webkit.org/>
References: <bug-27554-0@https.bugs.webkit.org/>
Message-ID: <20090723193349.CD36133EB8ED@gamma.macosforge.org>

Jessie Berlin <jberlin at apple.com> has asked  for review:
Bug 27554: getComputedStyle does not contain a value for text-overflow
https://bugs.webkit.org/show_bug.cgi?id=27554

Attachment 33353: Patch to expose the value of text-overflow on the
computedStyle object.
https://bugs.webkit.org/attachment.cgi?id=33353&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 12:35:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:35:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27615] Fix false positives
 for switch statement indentation check in cpplint : [Attachment 33354] Fix
 false positives for switch statement indentation check in cpplint
In-Reply-To: <bug-27615-0@https.bugs.webkit.org/>
References: <bug-27615-0@https.bugs.webkit.org/>
Message-ID: <20090723193537.08BEE33EB922@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27615: Fix false positives for switch statement indentation check in
cpplint
https://bugs.webkit.org/show_bug.cgi?id=27615

Attachment 33354: Fix false positives for switch statement indentation check in
cpplint
https://bugs.webkit.org/attachment.cgi?id=33354&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 12:37:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:37:29 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33344] makes Document.location and all Location properties read-only,
 pending writing of custom code (at some indeterminate future point)
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090723193729.7CA6233EB96C@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33344: makes Document.location and all Location properties
read-only, pending writing of custom code (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33344&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I would prefer that we skip generation of Location and Document::location until
they can be supported properly.  As I noted in a previous comment, the WebKit
APIs already provide mechanisms for retrieving the URL of a frame so I don't
buy the argument that this property *needs* to be exposed *now*.

From bugzilla-daemon at webkit.org  Thu Jul 23 12:45:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:45:34 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27158] Add WebKit version API
 to Qt. : [Attachment 32804] Updated patch for generating WebKitVersion.h
 manually
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090723194534.44E1933EBA29@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied robert
<robert at roberthogan.net>'s request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 32804: Updated patch for generating WebKitVersion.h manually
https://bugs.webkit.org/attachment.cgi?id=32804&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This header file should be generated at build time.  Checking in a generated
source file doesn't make a lot of sense.

From bugzilla-daemon at webkit.org  Thu Jul 23 12:48:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:48:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33355] Add Attributes
 to Nodes Improved
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723194844.ED8EC33EBAFD@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33355: Add Attributes to Nodes Improved
https://bugs.webkit.org/attachment.cgi?id=33355&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 12:55:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 12:55:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33355] Add Attributes
 to Nodes Improved
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723195514.DC2D933EBBDE@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33355: Add Attributes to Nodes Improved
https://bugs.webkit.org/attachment.cgi?id=33355&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +	       var nodeName = tag.textContent.match(/^<(.*?)>$/)[1];
> +	       tag.textContent = '';
> +	       tag.appendChild(document.createTextNode('<'+nodeName));
> +	       tag.appendChild(node);
> +	       tag.appendChild(document.createTextNode('>'));

Double quote strings and spaces around "+".

From bugzilla-daemon at webkit.org  Thu Jul 23 13:00:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:00:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27618]
 WebCore/page/DOMTimer.cpp/h does not conform to style standards :
 [Attachment 33356] Style patch for DOMTimer.cpp/h
In-Reply-To: <bug-27618-0@https.bugs.webkit.org/>
References: <bug-27618-0@https.bugs.webkit.org/>
Message-ID: <20090723200009.3CCAD33EBC61@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27618: WebCore/page/DOMTimer.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27618

Attachment 33356: Style patch for DOMTimer.cpp/h
https://bugs.webkit.org/attachment.cgi?id=33356&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:02:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:02:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 20215]
 execCommand('underline') can't remove <U> underlines : [Attachment 33318]
 fixes the bug (non-CSS mode still unsupported)
In-Reply-To: <bug-20215-0@https.bugs.webkit.org/>
References: <bug-20215-0@https.bugs.webkit.org/>
Message-ID: <20090723200220.EB63D33EBC9F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 20215: execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

Attachment 33318: fixes the bug (non-CSS mode still unsupported)
https://bugs.webkit.org/attachment.cgi?id=33318&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Just use a raw pointer:
 967			 RefPtr<CSSValueList> valueList =
static_cast<CSSValueList*>(property.value());

These should be static:
		     RefPtr<CSSPrimitiveValue> underline =
CSSPrimitiveValue::createIdentifier(CSSValueUnderline);
 969			 RefPtr<CSSPrimitiveValue> lineThrough =
CSSPrimitiveValue::createIdentifier(CSSValueLineThrough);
 97
Watch out for the LOCAL_STATIC macro.  You can't just use "static" here due to
a GCC bug.

Otherwise this looks great.  I'd like to see the patch one more time though.

From bugzilla-daemon at webkit.org  Thu Jul 23 13:03:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:03:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33357] Make it possible to build JSC as a shared library without symbol
 lists
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090723200313.4C26833EBCD4@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33357: Make it possible to build JSC as a shared library without
symbol lists
https://bugs.webkit.org/attachment.cgi?id=33357&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:05:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:05:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33358] Build JSC as a shared library for QtWebKit
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090723200530.C7DE033EBD29@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33358: Build JSC as a shared library for QtWebKit
https://bugs.webkit.org/attachment.cgi?id=33358&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:07:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:07:58 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27554] getComputedStyle does
 not contain a value for text-overflow : [Attachment 33353] Patch to expose
 the value of text-overflow on the computedStyle object.
In-Reply-To: <bug-27554-0@https.bugs.webkit.org/>
References: <bug-27554-0@https.bugs.webkit.org/>
Message-ID: <20090723200758.EE89233EBD7D@gamma.macosforge.org>

mitz at webkit.org has granted Jessie Berlin <jberlin at apple.com>'s request for
review:
Bug 27554: getComputedStyle does not contain a value for text-overflow
https://bugs.webkit.org/show_bug.cgi?id=27554

Attachment 33353: Patch to expose the value of text-overflow on the
computedStyle object.
https://bugs.webkit.org/attachment.cgi?id=33353&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:13:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:13:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33277] Patch to make it possible to build JavaScriptCore as shared library
 on Linux without symbol files.
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090723201359.399FD33EBE7B@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33277: Patch to make it possible to build JavaScriptCore as shared
library on Linux without symbol files.
https://bugs.webkit.org/attachment.cgi?id=33277&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing review after splitting up the patch

From bugzilla-daemon at webkit.org  Thu Jul 23 13:16:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:16:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27510] [S60 QtWebKit] Don't
 put some intermediate generated files into the final mmp project file for
 linking. : [Attachment 33359] update the patch discription to mention it is
 a workaround for qmake bug in Symbian port.
In-Reply-To: <bug-27510-0@https.bugs.webkit.org/>
References: <bug-27510-0@https.bugs.webkit.org/>
Message-ID: <20090723201652.1E09333EBEEE@gamma.macosforge.org>

Yongjun Zhang <yongjun.zhang at nokia.com> has asked  for review:
Bug 27510: [S60 QtWebKit] Don't put some intermediate generated files into the
final mmp project file for linking.
https://bugs.webkit.org/show_bug.cgi?id=27510

Attachment 33359: update the patch discription to mention it is a workaround
for qmake bug in Symbian port.
https://bugs.webkit.org/attachment.cgi?id=33359&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:16:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:16:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27510] [S60 QtWebKit] Don't
 put some intermediate generated files into the final mmp project file for
 linking. : [Attachment 33201] Point variable_out properties of effected
 custom compilers to empty,
 to avoid putting generated files into mmp project file.
In-Reply-To: <bug-27510-0@https.bugs.webkit.org/>
References: <bug-27510-0@https.bugs.webkit.org/>
Message-ID: <20090723201651.E58AD33EBEEA@gamma.macosforge.org>

Yongjun Zhang <yongjun.zhang at nokia.com> has canceled Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 27510: [S60 QtWebKit] Don't put some intermediate generated files into the
final mmp project file for linking.
https://bugs.webkit.org/show_bug.cgi?id=27510

Attachment 33201: Point variable_out properties of effected custom compilers to
empty, to avoid putting generated files into mmp project file.
https://bugs.webkit.org/attachment.cgi?id=33201&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:22:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:22:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33360] Add Attributes
 to Nodes More Improved
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723202239.B594B33EBFD5@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33360: Add Attributes to Nodes More Improved
https://bugs.webkit.org/attachment.cgi?id=33360&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Fixes those styles issues and the ChangeLog.

From bugzilla-daemon at webkit.org  Thu Jul 23 13:23:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:23:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 33085] patch 0.4 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090723202354.9C10B33EC01C@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 33085: patch 0.4 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=33085&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
ready for review.

From bugzilla-daemon at webkit.org  Thu Jul 23 13:23:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:23:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 33361] patch 0.5 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090723202354.C603933EC020@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 33361: patch 0.5 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=33361&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
ready for review.

From bugzilla-daemon at webkit.org  Thu Jul 23 13:24:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:24:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27620] [V8] Fix an assert
 in running workers in Chrome. : [Attachment 33362] Proposed Patch
In-Reply-To: <bug-27620-0@https.bugs.webkit.org/>
References: <bug-27620-0@https.bugs.webkit.org/>
Message-ID: <20090723202409.8978833EC037@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27620: [V8] Fix an assert in running workers in Chrome.
https://bugs.webkit.org/show_bug.cgi?id=27620

Attachment 33362: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33362&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:29:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:29:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27620] [V8] Fix an assert in
 running workers in Chrome. : [Attachment 33362] Proposed Patch
In-Reply-To: <bug-27620-0@https.bugs.webkit.org/>
References: <bug-27620-0@https.bugs.webkit.org/>
Message-ID: <20090723202957.3B40B33EC129@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27620: [V8] Fix an assert in running workers in Chrome.
https://bugs.webkit.org/show_bug.cgi?id=27620

Attachment 33362: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33362&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:30:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:30:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27622] Add new test to
 cover more prototype/constructor inheritance cases : [Attachment 33364]
 patch
In-Reply-To: <bug-27622-0@https.bugs.webkit.org/>
References: <bug-27622-0@https.bugs.webkit.org/>
Message-ID: <20090723203031.8D6B033EC154@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27622: Add new test to cover more prototype/constructor inheritance cases
https://bugs.webkit.org/show_bug.cgi?id=27622

Attachment 33364: patch
https://bugs.webkit.org/attachment.cgi?id=33364&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:42:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:42:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14410] Dragging a resource
 in the sidebar should drag it's URL : [Attachment 33365] Fixed Based on
 Review
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090723204211.3565F33EC30A@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33365: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33365&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:43:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:43:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27588] Make most DOMObjects
 hold onto a JSDOMGlobalObject* : [Attachment 33309] patch
In-Reply-To: <bug-27588-0@https.bugs.webkit.org/>
References: <bug-27588-0@https.bugs.webkit.org/>
Message-ID: <20090723204337.5BDE333EC33E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27588: Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

Attachment 33309: patch
https://bugs.webkit.org/attachment.cgi?id=33309&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:43:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:43:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27588] Make most DOMObjects
 hold onto a JSDOMGlobalObject* : [Attachment 33366] Just the code changes
In-Reply-To: <bug-27588-0@https.bugs.webkit.org/>
References: <bug-27588-0@https.bugs.webkit.org/>
Message-ID: <20090723204340.0E8F233EC34F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27588: Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

Attachment 33366: Just the code changes
https://bugs.webkit.org/attachment.cgi?id=33366&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 17 files changed, 147 insertions(+), 43 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 23 13:46:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:46:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27510] [S60 QtWebKit] Don't
 put some intermediate generated files into the final mmp project file for
 linking. : [Attachment 33359] update the patch discription to mention it is
 a workaround for qmake bug in Symbian port.
In-Reply-To: <bug-27510-0@https.bugs.webkit.org/>
References: <bug-27510-0@https.bugs.webkit.org/>
Message-ID: <20090723204600.78E1633EC3B3@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 27510: [S60 QtWebKit] Don't put some intermediate generated files into the
final mmp project file for linking.
https://bugs.webkit.org/show_bug.cgi?id=27510

Attachment 33359: update the patch discription to mention it is a workaround
for qmake bug in Symbian port.
https://bugs.webkit.org/attachment.cgi?id=33359&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 23 13:53:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:53:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27624]
 WebCore/page/DragController.cpp does not conform to style standards :
 [Attachment 33367] Style patch for DragController.cpp
In-Reply-To: <bug-27624-0@https.bugs.webkit.org/>
References: <bug-27624-0@https.bugs.webkit.org/>
Message-ID: <20090723205357.CDBCE33EC4A7@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27624: WebCore/page/DragController.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27624

Attachment 33367: Style patch for DragController.cpp
https://bugs.webkit.org/attachment.cgi?id=33367&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 13:54:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:54:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27286] Inspector: Keyboard
 Shortcuts to Switch Panels : [Attachment 33368] Keyboard Shortcuts for
 Switching Panels
In-Reply-To: <bug-27286-0@https.bugs.webkit.org/>
References: <bug-27286-0@https.bugs.webkit.org/>
Message-ID: <20090723205443.1C09D33EC4D0@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27286: Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286

Attachment 33368: Keyboard Shortcuts for Switching Panels
https://bugs.webkit.org/attachment.cgi?id=33368&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Fix based on review.

From bugzilla-daemon at webkit.org  Thu Jul 23 13:56:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 13:56:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20215]
 execCommand('underline') can't remove <U> underlines : [Attachment 33369]
 fixed per comment
In-Reply-To: <bug-20215-0@https.bugs.webkit.org/>
References: <bug-20215-0@https.bugs.webkit.org/>
Message-ID: <20090723205608.F3CCF33EC4FF@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 20215: execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

Attachment 33369: fixed per comment
https://bugs.webkit.org/attachment.cgi?id=33369&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:01:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:01:50 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 20215]
 execCommand('underline') can't remove <U> underlines : [Attachment 33369]
 fixed per comment
In-Reply-To: <bug-20215-0@https.bugs.webkit.org/>
References: <bug-20215-0@https.bugs.webkit.org/>
Message-ID: <20090723210150.D4B9033EC5FF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 20215: execCommand('underline') can't remove <U> underlines
https://bugs.webkit.org/show_bug.cgi?id=20215

Attachment 33369: fixed per comment
https://bugs.webkit.org/attachment.cgi?id=33369&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Should add a comment before:
 104	 ASSERT(!mutableStyle->getPropertyCSSValue(CSSPropertyTextDecoration)
||
!mutableStyle->getPropertyCSSValue(CSSPropertyWebkitTextDecorationsInEffect));

This comment is confusing:
 132		 // Always use text-decoration NOT to expose
-webkit-text-decoration-in-effect.

Otherwise looks great!

From bugzilla-daemon at webkit.org  Thu Jul 23 14:06:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:06:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27435] adding
 XMLHttpRequest send idl language gobject : [Attachment 33325] corrections
 to #ifdefs as per r2 comment
In-Reply-To: <bug-27435-0@https.bugs.webkit.org/>
References: <bug-27435-0@https.bugs.webkit.org/>
Message-ID: <20090723210650.609AD33EC6B5@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27435: adding XMLHttpRequest send idl language gobject
https://bugs.webkit.org/show_bug.cgi?id=27435

Attachment 33325: corrections to #ifdefs as per r2 comment
https://bugs.webkit.org/attachment.cgi?id=33325&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
ehh?  sorry, what reasons?  if you look closely at the comments, mark, it's
been discussed (by xan) and i concur with xan's assessment; eric's review
comment is satisfied - what reasons are you referring to?

From bugzilla-daemon at webkit.org  Thu Jul 23 14:11:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:11:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27621] 3d-transforms media
 query needs to look at the accelerated compositing pref : [Attachment
 33370] Patch, changelog
In-Reply-To: <bug-27621-0@https.bugs.webkit.org/>
References: <bug-27621-0@https.bugs.webkit.org/>
Message-ID: <20090723211146.6BD8133EC7B2@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27621: 3d-transforms media query needs to look at the accelerated
compositing pref
https://bugs.webkit.org/show_bug.cgi?id=27621

Attachment 33370: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=33370&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:12:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:12:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 33361] patch 0.5 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090723211239.3DB7033EC7E4@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 33361: patch 0.5 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=33361&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
clearing review again. got comments from itc

From bugzilla-daemon at webkit.org  Thu Jul 23 14:16:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:16:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27329] Inspector:
 Properties Should be Sorted more Naturally : [Attachment 33371] Fixed Based
 on Review
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090723211616.71CEF33EC88F@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 33371: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33371&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:17:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:17:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27329] Inspector: Properties
 Should be Sorted more Naturally : [Attachment 33371] Fixed Based on Review
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090723211758.ED99833EC8C0@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 33371: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33371&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:17:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:17:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27329] Inspector:
 Properties Should be Sorted more Naturally : [Attachment 33372] Fixed Based
 on Review
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090723211759.3426F33EC8C4@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 33372: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33372&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:18:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:18:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27621] 3d-transforms media
 query needs to look at the accelerated compositing pref : [Attachment
 33370] Patch, changelog
In-Reply-To: <bug-27621-0@https.bugs.webkit.org/>
References: <bug-27621-0@https.bugs.webkit.org/>
Message-ID: <20090723211854.AB4DE33EC8EA@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 27621: 3d-transforms media query needs to look at the accelerated
compositing pref
https://bugs.webkit.org/show_bug.cgi?id=27621

Attachment 33370: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=33370&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:21:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:21:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27622] Add new test to cover
 more prototype/constructor inheritance cases : [Attachment 33364] patch
In-Reply-To: <bug-27622-0@https.bugs.webkit.org/>
References: <bug-27622-0@https.bugs.webkit.org/>
Message-ID: <20090723212137.5E3DE33EC98E@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27622: Add new test to cover more prototype/constructor inheritance cases
https://bugs.webkit.org/show_bug.cgi?id=27622

Attachment 33364: patch
https://bugs.webkit.org/attachment.cgi?id=33364&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:26:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:26:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33373]
 add new prepare-ChangeLog options to bash completion script
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723212605.6027033ECA1D@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has asked	for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33373: add new prepare-ChangeLog options to bash completion script
https://bugs.webkit.org/attachment.cgi?id=33373&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:26:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:26:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33344] makes Document.location and all Location properties read-only,
 pending writing of custom code (at some indeterminate future point)
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090723212606.B00DA33ECA2F@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33344: makes Document.location and all Location properties
read-only, pending writing of custom code (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33344&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:27:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:27:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27619] Switch wx to using
 waf for builds : [Attachment 33374] Changes to build-webkit needed for wx
 to use the waf build process
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090723212706.5A84633ECA50@gamma.macosforge.org>

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33374: Changes to build-webkit needed for wx to use the waf build
process
https://bugs.webkit.org/attachment.cgi?id=33374&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:31:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:31:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27619] Switch wx to using
 waf for builds : [Attachment 33375] Fix for when running
 DerivedSources.make from a subdir of JSCore
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090723213136.4F06F33ECAC9@gamma.macosforge.org>

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33375: Fix for when running DerivedSources.make from a subdir of
JSCore
https://bugs.webkit.org/attachment.cgi?id=33375&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:32:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:32:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33376]
 If the user doesn't modify the ChangeLog files in the git commit,
 use prepare-ChangeLog to populate the git commit message.
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723213226.53BA233ECAF2@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has asked	for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33376: If the user doesn't modify the ChangeLog files in the git
commit, use prepare-ChangeLog to populate the git commit message.
https://bugs.webkit.org/attachment.cgi?id=33376&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:36:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:36:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27400] Inspector:
 Automatically Refresh DOM Storage Grids on "storage" event : [Attachment
 33378] Fixed Based on Review
In-Reply-To: <bug-27400-0@https.bugs.webkit.org/>
References: <bug-27400-0@https.bugs.webkit.org/>
Message-ID: <20090723213604.AB5C333ECB6C@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27400: Inspector: Automatically Refresh DOM Storage Grids on "storage"
event
https://bugs.webkit.org/show_bug.cgi?id=27400

Attachment 33378: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33378&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:38:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:38:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33373]
 add new prepare-ChangeLog options to bash completion script
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723213832.5ECF533ECBB8@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Eli Fidler <eli at staikos.net>'s
request for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33373: add new prepare-ChangeLog options to bash completion script
https://bugs.webkit.org/attachment.cgi?id=33373&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> +complete -W "--bug --diff --git-commit --git-index --git-reviewer --help
--no-update --open --update -d -h -o --write --no-write" prepare-ChangeLog

Believe it or not, these are actually all sorted, but this can be fixed on
landing. :)

From bugzilla-daemon at webkit.org  Thu Jul 23 14:40:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:40:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33338]
 updated patch to fix ChangeLog indentation
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090723214004.47FC733ECBFF@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33338: updated patch to fix ChangeLog indentation
https://bugs.webkit.org/attachment.cgi?id=33338&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r+ since it was landed.

From bugzilla-daemon at webkit.org  Thu Jul 23 14:42:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:42:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27610] Add check for
 line-breaking rule #3 to cpplint : [Attachment 33379] Add check for
 line-breaking rule #3 to cpplint (try 2)
In-Reply-To: <bug-27610-0@https.bugs.webkit.org/>
References: <bug-27610-0@https.bugs.webkit.org/>
Message-ID: <20090723214212.7675C33ECC32@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33379: Add check for line-breaking rule #3 to cpplint (try 2)
https://bugs.webkit.org/attachment.cgi?id=33379&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
New version, incorporating most feedback from Adam Treat and Dave Levin, both
from the comments in here and from comments in IRC.
Now checks for both "else" and "else if" statements, as well as "break" and
"continue" in addition to "return".

This version does not trigger on exit statements in else-if blocks (only in if
blocks) and also does not (yet?) unify regular expressions for goto labels
(which was suggested by Adam). Apart from that, it's pretty neat though. Please
have another look.

From bugzilla-daemon at webkit.org  Thu Jul 23 14:43:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:43:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27615] Fix false positives
 for switch statement indentation check in cpplint : [Attachment 33354] Fix
 false positives for switch statement indentation check in cpplint
In-Reply-To: <bug-27615-0@https.bugs.webkit.org/>
References: <bug-27615-0@https.bugs.webkit.org/>
Message-ID: <20090723214331.6860B33ECC64@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27615: Fix false positives for switch statement indentation check in
cpplint
https://bugs.webkit.org/show_bug.cgi?id=27615

Attachment 33354: Fix false positives for switch statement indentation check in
cpplint
https://bugs.webkit.org/attachment.cgi?id=33354&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:43:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:43:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 21108] Impossible to add an
 attribute to a node without attributes : [Attachment 33360] Add Attributes
 to Nodes More Improved
In-Reply-To: <bug-21108-0@https.bugs.webkit.org/>
References: <bug-21108-0@https.bugs.webkit.org/>
Message-ID: <20090723214339.BE9B233ECC88@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 21108: Impossible to add an attribute to a node without attributes
https://bugs.webkit.org/show_bug.cgi?id=21108

Attachment 33360: Add Attributes to Nodes More Improved
https://bugs.webkit.org/attachment.cgi?id=33360&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 14:46:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 14:46:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14410] Dragging a resource in
 the sidebar should drag it's URL : [Attachment 33365] Fixed Based on Review
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090723214618.E041333ECCDC@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33365: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33365&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Sorry to keep nitpicking, but this for loop could be a while loop like:

while (this._listItemNode.hasChildNodes())
   link.appendChild(this._listItemNode.firstChild);

From bugzilla-daemon at webkit.org  Thu Jul 23 15:03:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:03:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33380] for convenience of the
 reviewers,
 this patch includes the research material which is not being read and
 answered as part of the prior review comments,
 which has been requested seventeen times so far
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090723220302.2466433ECEA0@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33380: for convenience of the reviewers, this patch includes the
research material which is not being read and answered as part of the prior
review comments, which has been requested seventeen times so far
https://bugs.webkit.org/attachment.cgi?id=33380&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
for your convenience, i'm including the research material in the ChangeLog,
showing evidence of the existence and support of toString in all competitor
browser engines, in their language bindings.  MSHTML's DCOM interface. 
XULrunner's native c++ and XPCOM bindings.  KHTML with its toHTML (because
QObject already has a function called toString, with which the name toHTML
obviously clashes).

perhaps you could see your way to reviewing the attached patch, along with the
supporting evidence, which is different from the one previously submitted.

From bugzilla-daemon at webkit.org  Thu Jul 23 15:09:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:09:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27626] To allow disabling
 DataGrid,
 conditionalize its files in DerivedSourcesAllInOne : [Attachment 33381]
 patch to fix it
In-Reply-To: <bug-27626-0@https.bugs.webkit.org/>
References: <bug-27626-0@https.bugs.webkit.org/>
Message-ID: <20090723220915.F21AC33ECF39@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 27626: To allow disabling DataGrid, conditionalize its files in
DerivedSourcesAllInOne
https://bugs.webkit.org/show_bug.cgi?id=27626

Attachment 33381: patch to fix it
https://bugs.webkit.org/attachment.cgi?id=33381&action=review

------- Additional Comments from Jens Alfke <snej at chromium.org>
(Note that this patch only affects platforms that build V8 not JSC.)

From bugzilla-daemon at webkit.org  Thu Jul 23 15:13:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:13:35 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27626] To allow disabling
 DataGrid,
 conditionalize its files in DerivedSourcesAllInOne : [Attachment 33381]
 patch to fix it
In-Reply-To: <bug-27626-0@https.bugs.webkit.org/>
References: <bug-27626-0@https.bugs.webkit.org/>
Message-ID: <20090723221335.4345133ECFDB@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Jens Alfke
<snej at chromium.org>'s request for review:
Bug 27626: To allow disabling DataGrid, conditionalize its files in
DerivedSourcesAllInOne
https://bugs.webkit.org/show_bug.cgi?id=27626

Attachment 33381: patch to fix it
https://bugs.webkit.org/attachment.cgi?id=33381&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
This looks good, but it needs ChangeLog entry.

From bugzilla-daemon at webkit.org  Thu Jul 23 15:16:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:16:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14410] Dragging a resource
 in the sidebar should drag it's URL : [Attachment 33382] Added ChangeLog
 and Improved Loop
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090723221637.BEA1333ED076@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33382: Added ChangeLog and Improved Loop
https://bugs.webkit.org/attachment.cgi?id=33382&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Added a ChangeLog and better loop.

From bugzilla-daemon at webkit.org  Thu Jul 23 15:16:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:16:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27626] To allow disabling
 DataGrid,
 conditionalize its files in DerivedSourcesAllInOne : [Attachment 33383] Now
 with changelog entry, duh
In-Reply-To: <bug-27626-0@https.bugs.webkit.org/>
References: <bug-27626-0@https.bugs.webkit.org/>
Message-ID: <20090723221653.3753F33ED089@gamma.macosforge.org>

Jens Alfke <snej at chromium.org> has asked  for review:
Bug 27626: To allow disabling DataGrid, conditionalize its files in
DerivedSourcesAllInOne
https://bugs.webkit.org/show_bug.cgi?id=27626

Attachment 33383: Now with changelog entry, duh
https://bugs.webkit.org/attachment.cgi?id=33383&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 15:17:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:17:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27603] updating Document.idl
 to match HTML5 spec: domain read-write and access to getSelection :
 [Attachment 33323] makes Document.domain read-write and adds
 Document.getSelection to all bindings, as per HTML5 spec
In-Reply-To: <bug-27603-0@https.bugs.webkit.org/>
References: <bug-27603-0@https.bugs.webkit.org/>
Message-ID: <20090723221755.9E54133ED0A4@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has canceled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 27603: updating Document.idl to match HTML5 spec: domain read-write and
access to getSelection
https://bugs.webkit.org/show_bug.cgi?id=27603

Attachment 33323: makes Document.domain read-write and adds
Document.getSelection to all bindings, as per HTML5 spec
https://bugs.webkit.org/attachment.cgi?id=33323&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 15:17:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:17:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27603] updating
 Document.idl to match HTML5 spec: domain read-write and access to
 getSelection : [Attachment 33384] removes JS-specificism around
 Document.domain;
 keeps comment on getSelection to avoid it being confused with IE block of
 properties, above, but makes comment same as is shown further down in file
In-Reply-To: <bug-27603-0@https.bugs.webkit.org/>
References: <bug-27603-0@https.bugs.webkit.org/>
Message-ID: <20090723221755.B144233ED0A6@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27603: updating Document.idl to match HTML5 spec: domain read-write and
access to getSelection
https://bugs.webkit.org/show_bug.cgi?id=27603

Attachment 33384: removes JS-specificism around Document.domain; keeps comment
on getSelection to avoid it being confused with IE block of properties, above,
but makes comment same as is shown further down in file
https://bugs.webkit.org/attachment.cgi?id=33384&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 15:18:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:18:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14410] Dragging a resource in
 the sidebar should drag it's URL : [Attachment 33382] Added ChangeLog and
 Improved Loop
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090723221816.AAEAA33ED0B6@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33382: Added ChangeLog and Improved Loop
https://bugs.webkit.org/attachment.cgi?id=33382&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 15:22:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:22:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27627] DRT
 animation/transition pause API does not pause accelerated animations :
 [Attachment 33385] Patch, changelogs
In-Reply-To: <bug-27627-0@https.bugs.webkit.org/>
References: <bug-27627-0@https.bugs.webkit.org/>
Message-ID: <20090723222220.8FFFC33ED14D@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27627: DRT animation/transition pause API does not pause accelerated
animations
https://bugs.webkit.org/show_bug.cgi?id=27627

Attachment 33385: Patch, changelogs
https://bugs.webkit.org/attachment.cgi?id=33385&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 15:35:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:35:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27610] Add check for
 line-breaking rule #3 to cpplint : [Attachment 33379] Add check for
 line-breaking rule #3 to cpplint (try 2)
In-Reply-To: <bug-27610-0@https.bugs.webkit.org/>
References: <bug-27610-0@https.bugs.webkit.org/>
Message-ID: <20090723223559.DBEA833ED2B2@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33379: Add check for line-breaking rule #3 to cpplint (try 2)
https://bugs.webkit.org/attachment.cgi?id=33379&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Third try. Changes this time:
- Adding goto as fourth exit statement that triggers this check.
- Updating not only the code but also comments to reflect the new situation
with multiple exit statements.
- Make the (otherwise unrelated) label indentation check more permissive,
because currently it doesn't allow for goto labels at the very start of a line.

- Even more unit tests. If I didn't know these are all necessary, I'd say it's
too many of them. But no, these are all necessary.

From bugzilla-daemon at webkit.org  Thu Jul 23 15:36:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:36:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27610] Add check for
 line-breaking rule #3 to cpplint : [Attachment 33386] Add check for
 line-breaking rule #3 to cpplint
In-Reply-To: <bug-27610-0@https.bugs.webkit.org/>
References: <bug-27610-0@https.bugs.webkit.org/>
Message-ID: <20090723223600.0EE3433ED2B6@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33386: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/attachment.cgi?id=33386&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Third try. Changes this time:
- Adding goto as fourth exit statement that triggers this check.
- Updating not only the code but also comments to reflect the new situation
with multiple exit statements.
- Make the (otherwise unrelated) label indentation check more permissive,
because currently it doesn't allow for goto labels at the very start of a line.

- Even more unit tests. If I didn't know these are all necessary, I'd say it's
too many of them. But no, these are all necessary.

From bugzilla-daemon at webkit.org  Thu Jul 23 15:41:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:41:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27582] [CSS3 Backgrounds
 and Borders] Add support for inset box shadows : [Attachment 33387] Add
 support for inset box shadows
In-Reply-To: <bug-27582-0@https.bugs.webkit.org/>
References: <bug-27582-0@https.bugs.webkit.org/>
Message-ID: <20090723224147.C585E33ED326@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27582: [CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

Attachment 33387: Add support for inset box shadows
https://bugs.webkit.org/attachment.cgi?id=33387&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 15:45:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:45:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27610] Add check for
 line-breaking rule #3 to cpplint : [Attachment 33386] Add check for
 line-breaking rule #3 to cpplint
In-Reply-To: <bug-27610-0@https.bugs.webkit.org/>
References: <bug-27610-0@https.bugs.webkit.org/>
Message-ID: <20090723224506.9098033ED36A@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27610: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/show_bug.cgi?id=27610

Attachment 33386: Add check for line-breaking rule #3 to cpplint
https://bugs.webkit.org/attachment.cgi?id=33386&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Ok, I think you've suffered enough given the test cases we're now seeing.  It
looks pretty damn robust and well thoughtout.  Cheers!

From bugzilla-daemon at webkit.org  Thu Jul 23 15:49:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:49:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27431] splitting
 CodeGeneratorGObject.pm into library files : [Attachment 33060] code
 generator gobject library #1
In-Reply-To: <bug-27431-0@https.bugs.webkit.org/>
References: <bug-27431-0@https.bugs.webkit.org/>
Message-ID: <20090723224941.E359533ED3C0@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has canceled Luke Kenneth Casson
Leighton <lkcl at lkcl.net>'s request for review:
Bug 27431: splitting CodeGeneratorGObject.pm into library files
https://bugs.webkit.org/show_bug.cgi?id=27431

Attachment 33060: code generator gobject library #1
https://bugs.webkit.org/attachment.cgi?id=33060&action=review

------- Additional Comments from Luke Kenneth Casson Leighton <lkcl at lkcl.net>
cancelling review request after changes made under 
https://bugs.webkit.org/show_bug.cgi?id=27424 which affect this patch.

will re-submit (and take the opportunity to correct the ChangeLog entry layout)

From bugzilla-daemon at webkit.org  Thu Jul 23 15:51:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:51:24 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27582] [CSS3 Backgrounds and
 Borders] Add support for inset box shadows : [Attachment 33387] Add support
 for inset box shadows
In-Reply-To: <bug-27582-0@https.bugs.webkit.org/>
References: <bug-27582-0@https.bugs.webkit.org/>
Message-ID: <20090723225124.8831733ED3F2@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted mitz at webkit.org's request for review:
Bug 27582: [CSS3 Backgrounds and Borders] Add support for inset box shadows
https://bugs.webkit.org/show_bug.cgi?id=27582

Attachment 33387: Add support for inset box shadows
https://bugs.webkit.org/attachment.cgi?id=33387&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Looks good!  Can you put "inset" first in a couple of the test just to make
sure the parsing is covered?

It might not hurt to have a test of inset in between the length and color (and
color and length) also, just to show that the entire property gets discarded.

r=me

From bugzilla-daemon at webkit.org  Thu Jul 23 15:55:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 15:55:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27424] adding
 ConvertToGCharPrivate.h : [Attachment 33388] addressing review comments,
 decision on "Private" in name still outstanding decision?
In-Reply-To: <bug-27424-0@https.bugs.webkit.org/>
References: <bug-27424-0@https.bugs.webkit.org/>
Message-ID: <20090723225545.A0CB533ED490@gamma.macosforge.org>

Luke Kenneth Casson Leighton <lkcl at lkcl.net> has asked	for review:
Bug 27424: adding ConvertToGCharPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33388: addressing review comments, decision on "Private" in name
still outstanding decision?
https://bugs.webkit.org/attachment.cgi?id=33388&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 16:11:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 16:11:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33389] Proposed patch, rev. 2
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090723231106.95BF233ED683@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33389: Proposed patch, rev. 2
https://bugs.webkit.org/attachment.cgi?id=33389&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 16:22:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 16:22:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33389] Proposed patch, rev. 2
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090723232208.ABF4A33ED7A6@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33389: Proposed patch, rev. 2
https://bugs.webkit.org/attachment.cgi?id=33389&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    const AtomicString& l_pattern = getAttribute(patternAttr);

What's the "l_" prefix here? We don't use underscores in variable names. You
can just name this local variable pattern, I believe. It will shadow the
pattern() function, but that should be fine; you can always use this->pattern()
if you need to get at the pattern function.

> +    if (l_pattern.isEmpty() || value().isEmpty())

This function calls value(), a virtual function, three times. I would suggest
doing this at the start of the function:

    String value = this->value();

And then use the local value throughout.

I'm going to say r=me, but we probably do want to fix the l_pattern variable
name.

From bugzilla-daemon at webkit.org  Thu Jul 23 16:49:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 16:49:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33393] Proposed patch, rev. 2b
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090723234949.DF90633EDA63@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33393: Proposed patch, rev. 2b
https://bugs.webkit.org/attachment.cgi?id=33393&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 17:01:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:01:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33393] Proposed patch, rev. 2b
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090724000135.E2C9533EDB86@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33393: Proposed patch, rev. 2b
https://bugs.webkit.org/attachment.cgi?id=33393&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

I did have a few more thoughts, but probably not ones that have to be resolved
during review.

The code to get the pattern and value could moved inside the switch so we
wouldn't waste any time getting the pattern or value for input types that don't
support pattern. You might also be able to remove one or both special cases,
since I think compiling an empty regular expression will fail and return false.


Is it really true that an empty value can never mismatch?

From bugzilla-daemon at webkit.org  Thu Jul 23 17:02:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:02:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27630] [V8] More V8
 bindings changes to use ErrorEvent. : [Attachment 33394] Proposed Patch
In-Reply-To: <bug-27630-0@https.bugs.webkit.org/>
References: <bug-27630-0@https.bugs.webkit.org/>
Message-ID: <20090724000210.CC7DC33EDBAF@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27630: [V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630

Attachment 33394: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33394&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 17:28:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:28:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33395] Proposed Patch, rev. 2c
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090724002833.E7B9233EDE44@gamma.macosforge.org>

Michelangelo De Simone <micdesim at gmail.com> has asked  for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33395: Proposed Patch, rev. 2c
https://bugs.webkit.org/attachment.cgi?id=33395&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 17:32:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:32:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27633] AXLoadComplete can
 be fired off to frequently : [Attachment 33396] patch
In-Reply-To: <bug-27633-0@https.bugs.webkit.org/>
References: <bug-27633-0@https.bugs.webkit.org/>
Message-ID: <20090724003206.13BA633EDEC7@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 27633: AXLoadComplete can be fired off to frequently
https://bugs.webkit.org/show_bug.cgi?id=27633

Attachment 33396: patch
https://bugs.webkit.org/attachment.cgi?id=33396&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 17:33:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:33:50 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27633] AXLoadComplete can be
 fired off to frequently : [Attachment 33396] patch
In-Reply-To: <bug-27633-0@https.bugs.webkit.org/>
References: <bug-27633-0@https.bugs.webkit.org/>
Message-ID: <20090724003350.A697333EDEFD@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27633: AXLoadComplete can be fired off to frequently
https://bugs.webkit.org/show_bug.cgi?id=27633

Attachment 33396: patch
https://bugs.webkit.org/attachment.cgi?id=33396&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 17:56:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:56:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 20534] DumpRenderTree needs
 a way to override settings on a per-test basis : [Attachment 32572] Fixed
 and cleaned patch.
In-Reply-To: <bug-20534-0@https.bugs.webkit.org/>
References: <bug-20534-0@https.bugs.webkit.org/>
Message-ID: <20090724005639.8DDEC33EE145@gamma.macosforge.org>

Dmitry Titov <dimich at chromium.org> has canceled Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 32572: Fixed and cleaned patch.
https://bugs.webkit.org/attachment.cgi?id=32572&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 17:57:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 17:57:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27420] Refactor
 WorkerContext to move DedicatedWorker-specific APIs into
 DedicatedWorkerContext : [Attachment 33397] Patch addressing dimich's
 comments
In-Reply-To: <bug-27420-0@https.bugs.webkit.org/>
References: <bug-27420-0@https.bugs.webkit.org/>
Message-ID: <20090724005754.DE53333EE17E@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

Attachment 33397: Patch addressing dimich's comments
https://bugs.webkit.org/attachment.cgi?id=33397&action=review

------- Additional Comments from Andrew Wilson <atwilson at google.com>
I fixed up a number of places where we were doing the wrong thing in the V8
bindings.

Note that V8ClassIndex::WORKERCONTEXT can't go away entirely, as it's still
used by the generated code in V8WorkerContext.cpp, and also used for generating
the template chain for derived classes like V8DedicatedWorkerContext.

Also, it is OK to do lookupDOMWrapper(V8ClassIndex::WORKERCONTEXT, global) in
WorkerContextExecutionProxy::retrieve(), because lookupDOMWrapper walks up the
prototype chain to determine the class. Likewise for calling
convertToNativeObject(WORKERCONTEXT, global) - it still works no matter what
type you pass in, derived or base. In fact, convertToNativeObject() mostly just
uses the passed-in type for error checking, as it always ends up pulling a
pointer to the impl object out of the same place in the wrapper regardless of
type anyway.

From bugzilla-daemon at webkit.org  Thu Jul 23 18:28:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 18:28:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27619] Switch wx to using
 waf for builds : [Attachment 33399] Helper scripts for the waf build.
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090724012821.9392E33EE4A8@gamma.macosforge.org>

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33399: Helper scripts for the waf build.
https://bugs.webkit.org/attachment.cgi?id=33399&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 18:32:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 18:32:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27619] Switch wx to using
 waf for builds : [Attachment 33400] JSCore waf build script
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090724013247.A7FD733EE533@gamma.macosforge.org>

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33400: JSCore waf build script
https://bugs.webkit.org/attachment.cgi?id=33400&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 18:52:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 18:52:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27619] Switch wx to using
 waf for builds : [Attachment 33401] WebKit waf build script for wx
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090724015237.56C9A33EE6CD@gamma.macosforge.org>

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33401: WebKit waf build script for wx
https://bugs.webkit.org/attachment.cgi?id=33401&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 18:57:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 18:57:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27619] Switch wx to using
 waf for builds : [Attachment 33402] wxBrowser waf build script
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090724015707.1821633EE749@gamma.macosforge.org>

Kevin Ollivier <kevino at theolliviers.com> has asked  for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33402: wxBrowser waf build script
https://bugs.webkit.org/attachment.cgi?id=33402&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 19:12:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 19:12:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27595] WebCore/Kit has a
 few places that don't gracefully handle a null request returned from
 willSendRequest : [Attachment 33403] DRT enhancements and layout test
In-Reply-To: <bug-27595-0@https.bugs.webkit.org/>
References: <bug-27595-0@https.bugs.webkit.org/>
Message-ID: <20090724021230.76E9133EE8A2@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27595: WebCore/Kit has a few places that don't gracefully handle a null
request returned from willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=27595

Attachment 33403: DRT enhancements and layout test
https://bugs.webkit.org/attachment.cgi?id=33403&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 19:30:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 19:30:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27595] WebCore/Kit has a few
 places that don't gracefully handle a null request returned from
 willSendRequest : [Attachment 33403] DRT enhancements and layout test
In-Reply-To: <bug-27595-0@https.bugs.webkit.org/>
References: <bug-27595-0@https.bugs.webkit.org/>
Message-ID: <20090724023048.AEE2633EEA53@gamma.macosforge.org>

Geoffrey Garen <ggaren at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 27595: WebCore/Kit has a few places that don't gracefully handle a null
request returned from willSendRequest
https://bugs.webkit.org/show_bug.cgi?id=27595

Attachment 33403: DRT enhancements and layout test
https://bugs.webkit.org/attachment.cgi?id=33403&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
A patch is temporary. A layout test is forever! :)

From bugzilla-daemon at webkit.org  Thu Jul 23 19:34:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 19:34:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33390] Initial version
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090724023454.1FF6833EEAC8@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33390: Initial version
https://bugs.webkit.org/attachment.cgi?id=33390&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Sorry, forgot to mark as a patch

From bugzilla-daemon at webkit.org  Thu Jul 23 19:51:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 19:51:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26749] Canvas: rotation of
 'no-repeat' pattern still has small error : [Attachment 32859] Patch v2
In-Reply-To: <bug-26749-0@https.bugs.webkit.org/>
References: <bug-26749-0@https.bugs.webkit.org/>
Message-ID: <20090724025133.6448133EECAF@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 26749: Canvas: rotation of 'no-repeat' pattern still has small error
https://bugs.webkit.org/show_bug.cgi?id=26749

Attachment 32859: Patch v2
https://bugs.webkit.org/attachment.cgi?id=32859&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
ChangeLog needs to be updated to say 1<<22 not (1<<23)/2 but this is otherwise
okay -- can the person who lands fix up the changelog?

From bugzilla-daemon at webkit.org  Thu Jul 23 20:01:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 20:01:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 21794] Middle-click panning
 should be springloaded while dragging : [Attachment 33404] Pan Scrolling
In-Reply-To: <bug-21794-0@https.bugs.webkit.org/>
References: <bug-21794-0@https.bugs.webkit.org/>
Message-ID: <20090724030119.5783A33EEDA9@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has asked  for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 33404: Pan Scrolling
https://bugs.webkit.org/attachment.cgi?id=33404&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 21:47:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 21:47:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27636] [Gtk] Add
 implementation of GCController for DRT : [Attachment 33405] patch
In-Reply-To: <bug-27636-0@https.bugs.webkit.org/>
References: <bug-27636-0@https.bugs.webkit.org/>
Message-ID: <20090724044758.3D83C33EF70D@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27636: [Gtk] Add implementation of GCController for DRT
https://bugs.webkit.org/show_bug.cgi?id=27636

Attachment 33405: patch
https://bugs.webkit.org/attachment.cgi?id=33405&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 22:05:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 22:05:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27635] Make
 get_by_id/put_by_id/method_check/call defer optimization using a data flag
 rather than a code modification. : [Attachment 33406] The Patch.
In-Reply-To: <bug-27635-0@https.bugs.webkit.org/>
References: <bug-27635-0@https.bugs.webkit.org/>
Message-ID: <20090724050522.3C16F33EF83F@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has asked  for review:
Bug 27635: Make get_by_id/put_by_id/method_check/call defer optimization using
a data flag rather than a code modification.
https://bugs.webkit.org/show_bug.cgi?id=27635

Attachment 33406: The Patch.
https://bugs.webkit.org/attachment.cgi?id=33406&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 22:36:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 22:36:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27635] Make
 get_by_id/put_by_id/method_check/call defer optimization using a data flag
 rather than a code modification. : [Attachment 33406] The Patch.
In-Reply-To: <bug-27635-0@https.bugs.webkit.org/>
References: <bug-27635-0@https.bugs.webkit.org/>
Message-ID: <20090724053610.F0ACF33EFA9F@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 27635: Make get_by_id/put_by_id/method_check/call defer optimization using
a data flag rather than a code modification.
https://bugs.webkit.org/show_bug.cgi?id=27635

Attachment 33406: The Patch.
https://bugs.webkit.org/attachment.cgi?id=33406&action=review

From bugzilla-daemon at webkit.org  Thu Jul 23 22:40:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 22:40:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 3749] XHTML 1.1 Ruby
 Annotation : [Attachment 32823] patch: HTML5 ruby functionality only -
 requires patch in bug #32822 for build option
In-Reply-To: <bug-3749-0@https.bugs.webkit.org/>
References: <bug-3749-0@https.bugs.webkit.org/>
Message-ID: <20090724054010.B0F6133EFB1D@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has denied Roland Steiner
<rolandsteiner at google.com>'s request for review:
Bug 3749: XHTML 1.1 Ruby  Annotation
https://bugs.webkit.org/show_bug.cgi?id=3749

Attachment 32823: patch: HTML5 ruby functionality only - requires patch in bug
#32822 for build option
https://bugs.webkit.org/attachment.cgi?id=32823&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Why an extra ruby stylesheet?  I think the rules can just go in html.css. 
There are only 4!

ruby { display: inline } is unnecessary.  The default display type is inline,
so you don't need that rule.

Can rp just always be display:none?

When does rt occur outside a ruby?

There is funny indentation in InlineFlowBox.h... it looks like you 3-space
indented instead of 4.

I do not like the addition of an extra virtual function call in
InlineFlowBox.cpp's placeBoxesVertically method.  Possible to avoid it?

In RenderBlock.cpp I worked hard to devirtualize the container walk, so having
it be re-virtualized is bothersome.  I'm curious why that is needed.  It looks
like you're using some CSS style constant to scramble order.  Is that actually
part of HTML5?

From bugzilla-daemon at webkit.org  Thu Jul 23 23:07:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:07:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27636] [Gtk] Add
 implementation of GCController for DRT : [Attachment 33405] patch
In-Reply-To: <bug-27636-0@https.bugs.webkit.org/>
References: <bug-27636-0@https.bugs.webkit.org/>
Message-ID: <20090724060725.7902C33EFE36@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 27636: [Gtk] Add implementation of GCController for DRT
https://bugs.webkit.org/show_bug.cgi?id=27636

Attachment 33405: patch
https://bugs.webkit.org/attachment.cgi?id=33405&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

I'm surprised you all don't have a macro for DELETE_AND_ZERO:
delete gcController;
 689	 gcController = 0;

The Mac DRT has one for RELEASE_AND_ZERO iirc.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:08:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:08:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27630] [V8] More V8 bindings
 changes to use ErrorEvent. : [Attachment 33394] Proposed Patch
In-Reply-To: <bug-27630-0@https.bugs.webkit.org/>
References: <bug-27630-0@https.bugs.webkit.org/>
Message-ID: <20090724060802.8850233EFE4E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27630: [V8] More V8 bindings changes to use ErrorEvent.
https://bugs.webkit.org/show_bug.cgi?id=27630

Attachment 33394: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33394&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:09:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:09:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27282] [V8] Cleanup exception
 handling in worker evaluation code. : [Attachment 33115] Proposed Patch
In-Reply-To: <bug-27282-0@https.bugs.webkit.org/>
References: <bug-27282-0@https.bugs.webkit.org/>
Message-ID: <20090724060903.3556F33EFE76@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27282: [V8] Cleanup exception handling in worker evaluation code.
https://bugs.webkit.org/show_bug.cgi?id=27282

Attachment 33115: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33115&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good.  Is there any behavior change we can test?

From bugzilla-daemon at webkit.org  Thu Jul 23 23:11:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:11:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27624]
 WebCore/page/DragController.cpp does not conform to style standards :
 [Attachment 33367] Style patch for DragController.cpp
In-Reply-To: <bug-27624-0@https.bugs.webkit.org/>
References: <bug-27624-0@https.bugs.webkit.org/>
Message-ID: <20090724061103.AA50633EFEC0@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27624: WebCore/page/DragController.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27624

Attachment 33367: Style patch for DragController.cpp
https://bugs.webkit.org/attachment.cgi?id=33367&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:11:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:11:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27419] Storing a reference to
 WorkerContext.postMessage() and calling it later yields a TypeError :
 [Attachment 33209] proposed patch
In-Reply-To: <bug-27419-0@https.bugs.webkit.org/>
References: <bug-27419-0@https.bugs.webkit.org/>
Message-ID: <20090724061140.97DDE33EFED8@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27419: Storing a reference to WorkerContext.postMessage() and calling it
later yields a TypeError
https://bugs.webkit.org/show_bug.cgi?id=27419

Attachment 33209: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33209&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Awesome.  Thanks for the patch.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:12:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:12:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27618]
 WebCore/page/DOMTimer.cpp/h does not conform to style standards :
 [Attachment 33356] Style patch for DOMTimer.cpp/h
In-Reply-To: <bug-27618-0@https.bugs.webkit.org/>
References: <bug-27618-0@https.bugs.webkit.org/>
Message-ID: <20090724061232.5C75133EFEF2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27618: WebCore/page/DOMTimer.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27618

Attachment 33356: Style patch for DOMTimer.cpp/h
https://bugs.webkit.org/attachment.cgi?id=33356&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I wish XCode would strip whitespace for me. ;)

The changes look fine.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:12:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:12:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27617]
 WebCore/page/DOMSelection.cpp/h does not conform to style standards :
 [Attachment 33352] Style patch for DomSelectionPatch.cpp/h
In-Reply-To: <bug-27617-0@https.bugs.webkit.org/>
References: <bug-27617-0@https.bugs.webkit.org/>
Message-ID: <20090724061255.8BF5533EFF10@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27617: WebCore/page/DOMSelection.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27617

Attachment 33352: Style patch for DomSelectionPatch.cpp/h
https://bugs.webkit.org/attachment.cgi?id=33352&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:13:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:13:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27614]
 WebCore/page/Coordinates.cpp does not conform to style standards :
 [Attachment 33351] Style patch for Coordinates.cpp
In-Reply-To: <bug-27614-0@https.bugs.webkit.org/>
References: <bug-27614-0@https.bugs.webkit.org/>
Message-ID: <20090724061313.2EB9E33EFF20@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27614: WebCore/page/Coordinates.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27614

Attachment 33351: Style patch for Coordinates.cpp
https://bugs.webkit.org/attachment.cgi?id=33351&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:14:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:14:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33408] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090724061402.8279A33EFF3B@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33408: Step 1
https://bugs.webkit.org/attachment.cgi?id=33408&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Now disconnecting backend from the controller upon controller destruction.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:15:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:15:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27608]
 WebCore/page/Chrome.cpp does not conform to style standards : [Attachment
 33340] Style patch for Chrome.cpp
In-Reply-To: <bug-27608-0@https.bugs.webkit.org/>
References: <bug-27608-0@https.bugs.webkit.org/>
Message-ID: <20090724061536.8607C33EFF63@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27608: WebCore/page/Chrome.cpp does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27608

Attachment 33340: Style patch for Chrome.cpp
https://bugs.webkit.org/attachment.cgi?id=33340&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:21:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:21:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27532] [WinCairo] Correct
 Build Dependencies : [Attachment 33247] Small set of conditionals around
 Apple-specific headers.
In-Reply-To: <bug-27532-0@https.bugs.webkit.org/>
References: <bug-27532-0@https.bugs.webkit.org/>
Message-ID: <20090724062100.CC9E933F002F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 27532: [WinCairo] Correct Build Dependencies
https://bugs.webkit.org/show_bug.cgi?id=27532

Attachment 33247: Small set of conditionals around Apple-specific headers.
https://bugs.webkit.org/attachment.cgi?id=33247&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:26:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:26:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27208] Add open as event
 name,
 which is used in WebSocket : [Attachment 32650] add open in event names
In-Reply-To: <bug-27208-0@https.bugs.webkit.org/>
References: <bug-27208-0@https.bugs.webkit.org/>
Message-ID: <20090724062656.6D32E33F00DD@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Fumitoshi Ukai <ukai at chromium.org>'s
request for review:
Bug 27208: Add open as event name, which is used in WebSocket
https://bugs.webkit.org/show_bug.cgi?id=27208

Attachment 32650: add open in event names
https://bugs.webkit.org/attachment.cgi?id=32650&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Marking r- and obsolete per above comments.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:26:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:26:57 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26915] HTML5: DOM binding of
 <datalist> element : [Attachment 32835] Proposed patch (rev.4)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090724062657.0AA8333F00E8@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has canceled TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 32835: Proposed patch (rev.4)
https://bugs.webkit.org/attachment.cgi?id=32835&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Just updated the patch for project.pbxproj because the previous patch made a
conflict with the current source.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:26:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:26:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26915] HTML5: DOM binding
 of <datalist> element : [Attachment 33409] Proposed patch (rev.5)
In-Reply-To: <bug-26915-0@https.bugs.webkit.org/>
References: <bug-26915-0@https.bugs.webkit.org/>
Message-ID: <20090724062657.2680433F00EC@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 26915: HTML5: DOM binding of <datalist> element
https://bugs.webkit.org/show_bug.cgi?id=26915

Attachment 33409: Proposed patch (rev.5)
https://bugs.webkit.org/attachment.cgi?id=33409&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Just updated the patch for project.pbxproj because the previous patch made a
conflict with the current source.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:29:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:29:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 22249] CSS Multicolumn text
 is split awkwardly : [Attachment 32700] Patch v5
In-Reply-To: <bug-22249-0@https.bugs.webkit.org/>
References: <bug-22249-0@https.bugs.webkit.org/>
Message-ID: <20090724062940.5419F33F0156@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Yuta Kitamura <yutak at chromium.org>'s
request for review:
Bug 22249: CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249

Attachment 32700: Patch v5
https://bugs.webkit.org/attachment.cgi?id=32700&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Clearing review flags, since above comments suggest this patch has been
withdrawn.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:32:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:32:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27588] Make most DOMObjects
 hold onto a JSDOMGlobalObject* : [Attachment 33366] Just the code changes
In-Reply-To: <bug-27588-0@https.bugs.webkit.org/>
References: <bug-27588-0@https.bugs.webkit.org/>
Message-ID: <20090724063229.7DC7F33F019A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27588: Make most DOMObjects hold onto a JSDOMGlobalObject*
https://bugs.webkit.org/show_bug.cgi?id=27588

Attachment 33366: Just the code changes
https://bugs.webkit.org/attachment.cgi?id=33366&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
After some clarifying questions via chat, I believe this patch is correct.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:33:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:33:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27634] Give toJS a
 JSDOMGlobalObject parameter : [Attachment 33407] Fully working patch
In-Reply-To: <bug-27634-0@https.bugs.webkit.org/>
References: <bug-27634-0@https.bugs.webkit.org/>
Message-ID: <20090724063331.BA8FA33F01B2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27634: Give toJS a JSDOMGlobalObject parameter
https://bugs.webkit.org/show_bug.cgi?id=27634

Attachment 33407: Fully working patch
https://bugs.webkit.org/attachment.cgi?id=33407&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
This patch is ready for review.  I just figure it's large enough no one will
dare.  Feel welcome to make comments or r+/r- however :)  I will attempt to
split it up tomorrow.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:34:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:34:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27634] Give toJS a
 JSDOMGlobalObject parameter : [Attachment 33407] Fully working patch
In-Reply-To: <bug-27634-0@https.bugs.webkit.org/>
References: <bug-27634-0@https.bugs.webkit.org/>
Message-ID: <20090724063405.6A5F133F01CA@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27634: Give toJS a JSDOMGlobalObject parameter
https://bugs.webkit.org/show_bug.cgi?id=27634

Attachment 33407: Fully working patch
https://bugs.webkit.org/attachment.cgi?id=33407&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Hum.. Nevermind.  I havne' tadded ChangeLogs, so it's not really ready. :(

From bugzilla-daemon at webkit.org  Thu Jul 23 23:42:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:42:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27420] Refactor WorkerContext
 to move DedicatedWorker-specific APIs into DedicatedWorkerContext :
 [Attachment 33397] Patch addressing dimich's comments
In-Reply-To: <bug-27420-0@https.bugs.webkit.org/>
References: <bug-27420-0@https.bugs.webkit.org/>
Message-ID: <20090724064234.B2EC033F028F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27420: Refactor WorkerContext to move DedicatedWorker-specific APIs into
DedicatedWorkerContext
https://bugs.webkit.org/show_bug.cgi?id=27420

Attachment 33397: Patch addressing dimich's comments
https://bugs.webkit.org/attachment.cgi?id=33397&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  One infinitesimal nit:

> -    private:
> +    protected:
>	   WorkerContext(const KURL&, const String&, WorkerThread*);
> +	   bool isClosing() { return m_closing; }
> +    private:
>  
>	   virtual void refScriptExecutionContext() { ref(); }
>	   virtual void derefScriptExecutionContext() { deref(); }

Please move the private to below the blank line.

From bugzilla-daemon at webkit.org  Thu Jul 23 23:47:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 23 Jul 2009 23:47:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33390] Initial version
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090724064726.6F94233F02FD@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33390: Initial version
https://bugs.webkit.org/attachment.cgi?id=33390&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+    DOMDataStore* store = DOMDataStore::allStores()[0];

Why is it sufficient only to look in the zeroth DOMDataStore?  What about the
DOMDataStore for isolated worlds?

From bugzilla-daemon at webkit.org  Fri Jul 24 00:08:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:08:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27641] Classes call
 DOMObject::mark() explicitly,
 should call DOMObjectWithGlobal::mark() instead : [Attachment 33410] patch
In-Reply-To: <bug-27641-0@https.bugs.webkit.org/>
References: <bug-27641-0@https.bugs.webkit.org/>
Message-ID: <20090724070827.564A533F055E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27641: Classes call DOMObject::mark() explicitly, should call
DOMObjectWithGlobal::mark() instead
https://bugs.webkit.org/show_bug.cgi?id=27641

Attachment 33410: patch
https://bugs.webkit.org/attachment.cgi?id=33410&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 00:10:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:10:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27641] Classes call
 DOMObject::mark() explicitly,
 should call DOMObjectWithGlobal::mark() instead : [Attachment 33410] patch
In-Reply-To: <bug-27641-0@https.bugs.webkit.org/>
References: <bug-27641-0@https.bugs.webkit.org/>
Message-ID: <20090724071006.720F033F05A6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27641: Classes call DOMObject::mark() explicitly, should call
DOMObjectWithGlobal::mark() instead
https://bugs.webkit.org/show_bug.cgi?id=27641

Attachment 33410: patch
https://bugs.webkit.org/attachment.cgi?id=33410&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yep.  C++ is the suck.

From bugzilla-daemon at webkit.org  Fri Jul 24 00:24:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:24:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24758] [Gtk] Implement a
 WebDataSource for the gtk port : [Attachment 33014] updated patch
In-Reply-To: <bug-24758-0@https.bugs.webkit.org/>
References: <bug-24758-0@https.bugs.webkit.org/>
Message-ID: <20090724072426.5858033F06E2@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 33014: updated patch
https://bugs.webkit.org/attachment.cgi?id=33014&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> +static void test_webkit_web_resource_get_url(WebResourceFixture* fixture,
gconstpointer data)
> +{
> +    gchar* url;
> +    g_object_get(G_OBJECT(fixture->webResource), "url", &url, NULL);
> +    g_assert_cmpstr(url, ==, "http://example.com/");
> +    g_assert_cmpstr(webkit_web_resource_get_url(fixture->webResource)
,==,"http://example.com/");
> +}

You are leaking 'url' here, g_object_get will dup the string.

> +static void test_webkit_web_resource_get_mime_type(WebResourceFixture*
fixture, gconstpointer data)
> +{
> +    gchar* mime_type;
> +    g_object_get(G_OBJECT(fixture->webResource), "mime-type", &mime_type,
NULL);
> +    g_assert_cmpstr(mime_type, ==, "text/html");
> +   
g_assert_cmpstr(webkit_web_resource_get_mime_type(fixture->webResource),==,"tex
t/html");
> +}

Leaking 'mime_type'; same issue for all remaining tests.

> +static void webkit_web_resource_dispose(GObject* object)
> +{
> +    WebKitWebResource* webResource = WEBKIT_WEB_RESOURCE(object);
> +    WebKitWebResourcePrivate* priv = webResource->priv;
> +
> +    if (priv->resource)
> +	   priv->resource->deref();

Don't you need a priv->resource = 0; here?

> +
> +    G_OBJECT_CLASS(webkit_web_resource_parent_class)->dispose(object);
> +}
> +
> +static void webkit_web_resource_finalize(GObject* object)
> +{
> +    WebKitWebResource* webResource = WEBKIT_WEB_RESOURCE(object);
> +    WebKitWebResourcePrivate* priv = webResource->priv;
> +
> +    priv->url = CString();
> +    priv->mimeType = CString();
> +    priv->textEncoding = CString();
> +    priv->frameName = CString();

IIRC we had a discussion about this and we decided it was not a good method to
free memory? Is the mac port doing something like this? I'd say you'll be still
leaking a full CString object this way...

> +
> +    if (priv->data)
> +	   g_string_free(priv->data, FALSE);

I think you want to pass TRUE, not FALSE.

> +
> +/**
> + * webkit_web_resource_new:
> + * @data: the data to initialize the #WebKitWebResource
> + * @url: the url of the #WebKitWebResource
> + * @mime_type: the MIME type of the #WebKitWebResource
> + * @text_encoding_name: the text encoding name of the #WebKitWebResource
> + * @frame_name: the frame name of the #WebKitWebResource
> + *
> + * Returns a new #WebKitWebResource. The @text_encoding_name can be %NULL.
The
> + * @frame_name argument can be used if the resource represents contents of
an
> + * entire HTML frame, otherwise pass %NULL.
> + *
> + * Return value: a new #WebKitWebResource
> + *
> + * Since: 1.1.12
> + */
> +WebKitWebResource* webkit_web_resource_new(const gchar* data,
> +					      const gchar* url,
> +					      const gchar* mimeType,
> +					      const gchar* textEncodingName,
> +					      const gchar* frameName)
> +{
> +    ASSERT(data);
> +    ASSERT(url);
> +    ASSERT(mime_type);
> +
> +    RefPtr<SharedBuffer> buffer = SharedBuffer::create(data, strlen(data));

Mmm, data can't have explicit '0'? If it can strlen is wrong here (and I guess
you'd need an extra 'length' parameter).

> +    WebKitWebResource* webResource =
webkit_web_resource_new_with_core_resource(ArchiveResource::create(buffer,
KURL(KURL(),String::fromUTF8(url)), String::fromUTF8(mimeType),
String::fromUTF8(textEncodingName), String::fromUTF8(frameName)));
> +
> +    return webResource;
> +}
> +
> +/**
> + * webkit_web_resource_get_data:
> + * @web_resource: a #WebKitWebResource
> + *
> + * Returns the data of the @webResource.
> + *
> + * Return value: a #GString containing the character data of the
@webResource.
> + * The string is owned by WebKit and should not be freed or destroyed.
> + *
> + * Since: 1.1.12
> + */
> +G_CONST_RETURN GString* webkit_web_resource_get_data(WebKitWebResource*
webResource)

I believe in general 'const pointer object' makes little sense in C APIs, so
I'd just return GString* with the note.

> +/**
> + * webkit_web_resource_get_url:
> + * @web_resource: a #WebKitWebResource
> + *
> + * Returns the URL of the resource
> + *
> + * Return value: the URL of the resource
> + *
> + * Since: 1.1.12
> + */
> +G_CONST_RETURN gchar* webkit_web_resource_get_url(WebKitWebResource*
webResource)
> +{
> +    g_return_val_if_fail(WEBKIT_IS_WEB_RESOURCE(webResource), NULL);
> +
> +    WebKitWebResourcePrivate* priv = webResource->priv;
> +    if (!priv->resource)
> +	   return NULL;
> +
> +    priv->url = priv->resource->url().string().utf8();
> +
> +    return priv->url.data();

Shouldn't you put the URL in priv->url once and then return always that? You
are doing the same for the other properties.


> + * webkit_web_resource_get_text_encoding_name:
> + * @web_resource: a #WebKitWebResource
> + *
> + * Returns the text encoding name of the resource
> + *
> + * Return value: the text encoding name of the resource
> + *
> + * Since: 1.1.12
> + */
> +G_CONST_RETURN gchar*
webkit_web_resource_get_text_encoding_name(WebKitWebResource* webResource)

We have other APIs to get the encoding name and we call them simply
"get_encoding", so I think we should be consistent here probably.

Going to r- while we work on the issues.

From bugzilla-daemon at webkit.org  Fri Jul 24 00:33:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:33:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27566] x-frame constructor
 calls are instantiated with the wrong prototype chain : [Attachment 33411]
 patch
In-Reply-To: <bug-27566-0@https.bugs.webkit.org/>
References: <bug-27566-0@https.bugs.webkit.org/>
Message-ID: <20090724073312.E13C533F0827@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27566: x-frame constructor calls are instantiated with the wrong prototype
chain
https://bugs.webkit.org/show_bug.cgi?id=27566

Attachment 33411: patch
https://bugs.webkit.org/attachment.cgi?id=33411&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 00:33:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:33:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27532] [WinCairo] Correct
 Build Dependencies : [Attachment 33247] Small set of conditionals around
 Apple-specific headers.
In-Reply-To: <bug-27532-0@https.bugs.webkit.org/>
References: <bug-27532-0@https.bugs.webkit.org/>
Message-ID: <20090724073347.DDD4233F083F@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied	review:
Bug 27532: [WinCairo] Correct Build Dependencies
https://bugs.webkit.org/show_bug.cgi?id=27532

Attachment 33247: Small set of conditionals around Apple-specific headers.
https://bugs.webkit.org/attachment.cgi?id=33247&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/platform/graphics/win/SimpleFontDataWin.cpp
> ===================================================================
> --- WebCore/platform/graphics/win/SimpleFontDataWin.cpp	(revision
46148)
> +++ WebCore/platform/graphics/win/SimpleFontDataWin.cpp	(working copy)
> @@ -37,10 +37,14 @@
>  #include <wtf/MathExtras.h>
>  #include <unicode/uchar.h>
>  #include <unicode/unorm.h>
> +#if PLATFORM(CG)
>  #include <ApplicationServices/ApplicationServices.h>
> +#endif
>  #include <mlang.h>
>  #include <tchar.h>
> +#if PLATFORM(CG)
>  #include <WebKitSystemInterface/WebKitSystemInterface.h>
> +#endif

Please don't add #if's in the middle of a block of #include's like this.  The
#include's should be sorted, and any #if'd #include's should be in separate
paragraphs at the end.

> Index: WebKit/win/DefaultDownloadDelegate.h
> ===================================================================
> --- WebKit/win/DefaultDownloadDelegate.h	(revision 46148)
> +++ WebKit/win/DefaultDownloadDelegate.h	(working copy)
> @@ -28,7 +28,9 @@
>  #include "COMPtr.h"
>  #include "WebKit.h"
>  
> +#if PLATFORM(CFNETWORK)
>  #include <CFNetwork/CFURLDownloadPriv.h>
> +#endif
>  #include <wtf/HashSet.h>

Same comment applies here.

> Index: WebKit/win/WebDownload.h
> ===================================================================
> --- WebKit/win/WebDownload.h	(revision 46148)
> +++ WebKit/win/WebDownload.h	(working copy)
> @@ -29,7 +29,9 @@
>  #include "COMPtr.h"
>  #include "WebKit.h"
>  
> +#if PLATFORM(CFNETWORK)
>  #include <CFNetwork/CFURLDownloadPriv.h>
> +#endif
>  #include <WebCore/PlatformString.h>
>  #include <wtf/RetainPtr.h>

And here.

>  
> Index: WebKit/win/WebMutableURLRequest.cpp
> ===================================================================
> --- WebKit/win/WebMutableURLRequest.cpp	(revision 46148)
> +++ WebKit/win/WebMutableURLRequest.cpp	(working copy)
> @@ -30,7 +30,9 @@
>  #include "WebKit.h"
>  #include "MarshallingHelpers.h"
>  #include "WebKit.h"
> +#if PLATFORM(CFNETWORK)
>  #include <CFNetwork/CFURLRequestPriv.h>
> +#endif
>  #pragma warning(push, 0)
>  #include <WebCore/BString.h>
>  #include <WebCore/COMPtr.h>


And here.

Marking as r- as this broke the build.

From bugzilla-daemon at webkit.org  Fri Jul 24 00:38:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:38:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27566] x-frame constructor
 calls are instantiated with the wrong prototype chain : [Attachment 33411]
 patch
In-Reply-To: <bug-27566-0@https.bugs.webkit.org/>
References: <bug-27566-0@https.bugs.webkit.org/>
Message-ID: <20090724073826.D80A133F089D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27566: x-frame constructor calls are instantiated with the wrong prototype
chain
https://bugs.webkit.org/show_bug.cgi?id=27566

Attachment 33411: patch
https://bugs.webkit.org/attachment.cgi?id=33411&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yay for more failing tests.

From bugzilla-daemon at webkit.org  Fri Jul 24 00:43:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:43:23 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26742] Support fullscreen in
 MediaPlayer. : [Attachment 31894] patch v1.
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090724074323.E92A833F099A@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled  review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 31894: patch v1.
https://bugs.webkit.org/attachment.cgi?id=31894&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 00:43:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:43:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26742] Support fullscreen
 in MediaPlayer. : [Attachment 33412] Implement video Fullscreen on Mac OS
 X.
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090724074326.611F633F099F@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33412: Implement video Fullscreen on Mac OS X.
https://bugs.webkit.org/attachment.cgi?id=33412&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
ChromeClient gets a new interface enter/exit/supportsFullscreenForNode().
---
 28 files changed, 1110 insertions(+), 13 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 24 00:49:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:49:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33259]
 textencoding.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090724074953.3BA9433F0A81@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33259: textencoding.patch
https://bugs.webkit.org/attachment.cgi?id=33259&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +static gchar* utf8_substr(const gchar* string, gint start, gint end)

Style - utf8Substr or similar.

>  {
>      gchar* startPtr = g_utf8_offset_to_pointer(string, start);
>      gsize lenInBytes = g_utf8_offset_to_pointer(string, end) -  startPtr +
1;
> @@ -581,27 +530,23 @@ static gchar* g_substr(const gchar* string, gint start,
gint end)
>  // internals of WebCore's text presentation.
>  static gchar* convertUniCharToUTF8(const UChar* characters, gint length, int
from, int to)
>  {
> -    gchar* utf8 = 0;
> -    gint newLength = 0;
> -    UTF16ToUTF8(characters, length, utf8, newLength);
> -    if (!utf8)
> -	   return NULL;
> -
> -    gchar *pos = g_substr(utf8, from, to);
> -    g_free(utf8);
> -    gint len = strlen(pos);
> +    CString stringUTF8 = UTF8Encoding().encode(characters, length,
QuestionMarksForUnencodables);
> +    gchar* utf8 = utf8_substr(stringUTF8.data(), from, to);
> +    if (!g_utf8_validate(utf8, -1, NULL))
> +	   return 0;

Please change utf8 to something like utf8String. Also maybe free utf8 as well?
It may not validate but that doesn't mean utf8 is NULL either.

> +    gint len = strlen(utf8);

Use gsize here too.

r=me.

From bugzilla-daemon at webkit.org  Fri Jul 24 00:55:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 00:55:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27526] Inspector: Removing an
 Attribute via Edit should Delete the Attribute,
 Not Ignore Your Changes : [Attachment 33231] Removing an Attribute Deletes
 the Attribute - And Fix Possible Exception
In-Reply-To: <bug-27526-0@https.bugs.webkit.org/>
References: <bug-27526-0@https.bugs.webkit.org/>
Message-ID: <20090724075543.8525C33F0B88@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27526: Inspector: Removing an Attribute via Edit should Delete the
Attribute, Not Ignore Your Changes
https://bugs.webkit.org/show_bug.cgi?id=27526

Attachment 33231: Removing an Attribute Deletes the Attribute - And Fix
Possible Exception
https://bugs.webkit.org/attachment.cgi?id=33231&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch does not apply cleanly to TOT.  I haven't looked whether the merge
is trivial.

From bugzilla-daemon at webkit.org  Fri Jul 24 01:06:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 01:06:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27602] Build fix for x86
 platforms : [Attachment 33321] proposed patch
In-Reply-To: <bug-27602-0@https.bugs.webkit.org/>
References: <bug-27602-0@https.bugs.webkit.org/>
Message-ID: <20090724080604.8B91B33F0CB6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 27602: Build fix for x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=27602

Attachment 33321: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33321&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This breaks the build.

From bugzilla-daemon at webkit.org  Fri Jul 24 01:07:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 01:07:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33258]
 leninbytes.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090724080709.CF7F933F0CE8@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33258: leninbytes.patch
https://bugs.webkit.org/attachment.cgi?id=33258&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>  static gchar* g_substr(const gchar* string, gint start, gint end)
>  {
> -    gsize len = end - start + 1;
> -    gchar* output = static_cast<gchar*>(g_malloc0(len + 1));
> -    return g_utf8_strncpy(output, string +start, len);
> +    gchar* startPtr = g_utf8_offset_to_pointer(string, start);

According to the doc, g_utf8_offset_to_pointer doesn't check if offset is
within the boundaries of string. Can we add a check here?

> +    gsize lenInBytes = g_utf8_offset_to_pointer(string, end) -  startPtr +
1;

Ditto for 'end' and check if startPtr is 0 first. Looks fine otherwise. r=me.

From bugzilla-daemon at webkit.org  Fri Jul 24 01:28:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 01:28:44 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 14997] Support for server-sent
 DOM events : [Attachment 31160] updated patch
In-Reply-To: <bug-14997-0@https.bugs.webkit.org/>
References: <bug-14997-0@https.bugs.webkit.org/>
Message-ID: <20090724082844.D1C2233F10D6@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied  review:
Bug 14997: Support for server-sent DOM events
https://bugs.webkit.org/show_bug.cgi?id=14997

Attachment 31160: updated patch
https://bugs.webkit.org/attachment.cgi?id=31160&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I tried to land this, but the patch did not apply cleanly to a top-of-tree
checkout:

1 out of 3 hunks FAILED -- saving rejects to file configure.ac.rej

I haven't looked whether the merge is trivial.	Can you post an updated patch
that applies cleanly?  Thanks.

From bugzilla-daemon at webkit.org  Fri Jul 24 01:44:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 01:44:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33258]
 leninbytes.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090724084414.A438433F12CB@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has canceled  review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33258: leninbytes.patch
https://bugs.webkit.org/attachment.cgi?id=33258&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Landed as r46342, clearing flags.

From bugzilla-daemon at webkit.org  Fri Jul 24 01:44:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 01:44:35 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33259]
 textencoding.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090724084435.8381133F12E5@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has canceled  review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33259: textencoding.patch
https://bugs.webkit.org/attachment.cgi?id=33259&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Landed as r46343, clearing flags.

From bugzilla-daemon at webkit.org  Fri Jul 24 01:45:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 01:45:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27643] Update
 CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls :
 [Attachment 33413] patch
In-Reply-To: <bug-27643-0@https.bugs.webkit.org/>
References: <bug-27643-0@https.bugs.webkit.org/>
Message-ID: <20090724084507.44AA033F130E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27643: Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to
toJS calls
https://bugs.webkit.org/show_bug.cgi?id=27643

Attachment 33413: patch
https://bugs.webkit.org/attachment.cgi?id=33413&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 02:08:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:08:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27643] Update
 CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to toJS calls :
 [Attachment 33413] patch
In-Reply-To: <bug-27643-0@https.bugs.webkit.org/>
References: <bug-27643-0@https.bugs.webkit.org/>
Message-ID: <20090724090844.6517933F15E9@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27643: Update CodeGeneratorJS.pm to support passing JSDOMGlobalObject* to
toJS calls
https://bugs.webkit.org/show_bug.cgi?id=27643

Attachment 33413: patch
https://bugs.webkit.org/attachment.cgi?id=33413&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yes.  You could have put the code generator clean up in a separate patch, but
it's not needed now that I've reviewed it.

From bugzilla-daemon at webkit.org  Fri Jul 24 02:10:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:10:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27602] Build fix for x86
 platforms : [Attachment 33414] proposed patch
In-Reply-To: <bug-27602-0@https.bugs.webkit.org/>
References: <bug-27602-0@https.bugs.webkit.org/>
Message-ID: <20090724091023.AF70733F1624@gamma.macosforge.org>

Csaba Osztrogon?c <oszi at inf.u-szeged.hu> has asked  for review:
Bug 27602: Build fix for x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=27602

Attachment 33414: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33414&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 02:21:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:21:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27602] Build fix for x86
 platforms : [Attachment 33414] proposed patch
In-Reply-To: <bug-27602-0@https.bugs.webkit.org/>
References: <bug-27602-0@https.bugs.webkit.org/>
Message-ID: <20090724092125.9FB3D33F17B0@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Csaba Osztrogon?c
<oszi at inf.u-szeged.hu>'s request for review:
Bug 27602: Build fix for x86 platforms
https://bugs.webkit.org/show_bug.cgi?id=27602

Attachment 33414: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33414&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks like a reasonable modification to the first patch.  Thanks.

From bugzilla-daemon at webkit.org  Fri Jul 24 02:22:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:22:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33415] Addressing Adam's comments
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090724092232.EB76233F17E3@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33415: Addressing Adam's comments
https://bugs.webkit.org/attachment.cgi?id=33415&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Thanks a lot, Adam.  May you have another look?

From bugzilla-daemon at webkit.org  Fri Jul 24 02:45:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:45:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33415] Addressing Adam's comments
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090724094559.09AD233F1A6A@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33415: Addressing Adam's comments
https://bugs.webkit.org/attachment.cgi?id=33415&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This patch is still incorrect.

-    v8::HandleScope scope;

Don't we need a handle scope before talking to handles?

-    ASSERT(v8Object->IsObject());

Why drop this assert?

+	 ASSERT(store->domData()->owningThread() == WTF::currentThread());

This assert is bogus.  Some of DOMDataStores belong to worker threads.

Here's what you should do:

1) Acquire the mutex before iterating through the list because items might be
inserted or removed on another thread.

2) Move the ASSERT to after

+	 if (it == domMapImpl.end() || it->second != *v8Object)

At that point, you've found a DOMDataStore that holds a Node and it must be on
the main thread.

From bugzilla-daemon at webkit.org  Fri Jul 24 02:52:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:52:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27644] Update all
 CREATE_DOM_*_WRAPPER callers to pass globalObject : [Attachment 33416]
 patch
In-Reply-To: <bug-27644-0@https.bugs.webkit.org/>
References: <bug-27644-0@https.bugs.webkit.org/>
Message-ID: <20090724095249.58A9533F1B2B@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27644: Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

Attachment 33416: patch
https://bugs.webkit.org/attachment.cgi?id=33416&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 02:59:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 02:59:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33408] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090724095946.3E6FB33F1C07@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33408: Step 1
https://bugs.webkit.org/attachment.cgi?id=33408&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
Validated Chromium part (v8 bindings).

From bugzilla-daemon at webkit.org  Fri Jul 24 03:00:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:00:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33418] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090724100012.89D8C33F1C1C@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33418: Step 1
https://bugs.webkit.org/attachment.cgi?id=33418&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 03:00:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:00:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27644] Update all
 CREATE_DOM_*_WRAPPER callers to pass globalObject : [Attachment 33416]
 patch
In-Reply-To: <bug-27644-0@https.bugs.webkit.org/>
References: <bug-27644-0@https.bugs.webkit.org/>
Message-ID: <20090724100023.2633933F1C2C@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27644: Update all CREATE_DOM_*_WRAPPER callers to pass globalObject
https://bugs.webkit.org/show_bug.cgi?id=27644

Attachment 33416: patch
https://bugs.webkit.org/attachment.cgi?id=33416&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is correct.  So glad there's no Perl in this one.	:)

From bugzilla-daemon at webkit.org  Fri Jul 24 03:04:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:04:16 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27525] Fix error handling in
 dedicated worker and worker context. : [Attachment 33268] Proposed Patch
In-Reply-To: <bug-27525-0@https.bugs.webkit.org/>
References: <bug-27525-0@https.bugs.webkit.org/>
Message-ID: <20090724100416.D647933F1CBE@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Jian Li <jianli at chromium.org>'s
request for review:
Bug 27525: Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

Attachment 33268: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33268&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Thanks for taking this on.  It is a pretty complicated area as such I have
quite a few comments some of which may just require educating me :)


> diff --git
a/LayoutTests/fast/workers/resources/worker-script-error-not-handled1.js
b/LayoutTests/fast/workers/resources/worker-script-error-not-handled1.js

What do you think about
   /LayoutTests/fast/workers/resources/worker-script-error-unhandled.js
?

(Just an idea)


> diff --git
a/LayoutTests/fast/workers/resources/worker-script-error-not-handled2.js
b/LayoutTests/fast/workers/resources/worker-script-error-not-handled2.js
> @@ -0,0 +1,7 @@
> +onerror = function(message, url, lineno)
> +{
> +    postMessage("onerror invoked for a script that has script error '" +
message + "' at line " + lineno);
> +    return true;
> +}
> +
> +foo.bar = 0;

This is handled in some sense but allowed to bubble.  What do you think about 
  LayoutTests/fast/workers/resources/worker-script-error-bubbled.js
?


> diff --git a/LayoutTests/fast/workers/worker-constructor.html
b/LayoutTests/fast/workers/worker-constructor.html
...
> +
> +function test10()
> +{
> +    try {
> +	   var worker = new
Worker("resources/worker-script-error-not-handled2.js");
> +	   worker.onerror = function(evt) {
> +	       log("PASS: onerror invoked for a script that has script error '"
+ evt.message + "' at line " + evt.lineno + ".");
> +	       runNextTest();
> +	   }

Why doesn't this test capture and log the message from
"worker-script-error-not-handled2.js"?

> +function test11()

Need to add a test that cancels the event received on the worker object.

I see some advantages of this format (test#), but now that there are 11 tests
with this format, I find it a bit less readable.  Here's why:

1. The tests end up with non descript names, and it is hard for me to quickly
tell what unique thing each is trying to test. Instead I'd recommend getting
rid of runNextTest and just calling each test from the previous tests.	It is
not much more fragile (one must check that each test calls the next and that
the last test logs DONE and calls layoutTestController.notifyDone();).

2. It feels like it led to more tests to this same file. It would be good if
the new tests were in a new file based on what they are testing.  The new tests
are about script errors and on error handling.	They should be in a test with a
name that represents that as opposed to "worker-constructor.html"



> diff --git a/WebCore/bindings/js/JSEventListener.cpp
b/WebCore/bindings/js/JSEventListener.cpp
> +bool JSEventListener::reportError(const String& message, const String& url,
int lineNumber)
...
> +
> +    globalObject->globalData()->timeoutChecker.start();
> +    JSValue retval = call(exec, jsFunction, callType, callData, thisValue,
args);

retvalue -> returnValue?

> +    globalObject->globalData()->timeoutChecker.stop();
> +
> +    if (exec->hadException()) {
> +	   reportCurrentException(exec);

Does this do the following: 
 "if the error occurred while handling a previous script error, the user agent
must queue a task to fire a worker error event at the Worker object associated
with the worker."
?

If not, why not?

> +	   return true;
> +    }
> +    
> +    bool retvalbool;

How about bubbleEvent (instead of retvalbool)?

> +    return retval.getBoolean(retvalbool) && !retvalbool;


> diff --git a/WebCore/bindings/js/JSEventListener.h
b/WebCore/bindings/js/JSEventListener.h
> +	   virtual bool reportError(const String& message, const String& url,
int);

It would be helpful to fill in the param name for the int.

> diff --git a/WebCore/dom/EventListener.h b/WebCore/dom/EventListener.h
> +	   // Return true to indicate that the error is handled.
> +	   virtual bool reportError(const String& /*message*/, const String&
/*url*/, int) { return false; }

It would be helpful to fill in the param name for the int.


> diff --git a/WebCore/workers/WorkerContext.cpp
b/WebCore/workers/WorkerContext.cpp
>  void WorkerContext::reportException(const String& errorMessage, int
lineNumber, const String& sourceURL)
>  {
> -    m_thread->workerObjectProxy().postExceptionToWorkerObject(errorMessage,
lineNumber, sourceURL);
> +    bool errorHandled = false;
> +    if (m_onerrorListener)
> +	   errorHandled = m_onerrorListener->reportError(errorMessage,
sourceURL, lineNumber);
> +
> +    if (!errorHandled)
> +	  
m_thread->workerObjectProxy().postExceptionToWorkerObject(errorMessage,
lineNumber, sourceURL);

For Document::reportException, only logs the message to the console
    if (DOMWindow* window = domWindow())
	window->console()->addMessage(JSMessageSource, LogMessageType,
ErrorMessageLevel, errorMessage, lineNumber, sourceURL);

So when done in a Document callers of ScriptExecutionContext::reportException
are simply doing this.	So far in workers, the
message was simply proxies to the Document which did its normal thing. 

Now this calls the on error listener first.  Who calls this api in workers and
is this the correct thing to do for all of them? (Seems likely but it would be
good to track this down and be sure.  Then can we add tests for the error
handling for them to verify that the error is being reported so your fix does
get regressed?)


Does every place that called this want to do the dispatch script error event?


> diff --git a/WebCore/workers/WorkerMessagingProxy.cpp
b/WebCore/workers/WorkerMessagingProxy.cpp
>      virtual void performTask(ScriptExecutionContext* context)
>      {
> -	   if (!m_messagingProxy->askedToTerminate())
> +	   Worker* workerObject = m_messagingProxy->workerObject();
> +	   if (!workerObject || m_messagingProxy->askedToTerminate())
> +	       return;
> +
> +	   if (workerObject->onerror())
> +	       workerObject->dispatchScriptErrorEvent(m_errorMessage,
m_sourceURL, m_lineNumber);
> +	   else
>	       context->reportException(m_errorMessage, m_lineNumber,
m_sourceURL);
According to the web workers spec:

"When the user agent is to fire a worker error event at a Worker object, it
must dispatch an event that uses the ErrorEvent interface, with the name error,
that doesn't bubble and is cancelable, with its message, filename, and lineno
attributes set appropriately. The default action of this event depends on
whether the Worker object is itself in a worker. If it is, and that worker is
also a dedicated worker, then the user agent must again queue a task to fire a
worker error event at the Worker object associated with that worker. Otherwise,
then the error should be reported to the user."

It sounds like this event should go to ScriptExecutionContext::reportException
("reported to the user") unless it was cancelled.

Thanks again for this and for dealing with my volume of comments here :)

From bugzilla-daemon at webkit.org  Fri Jul 24 03:12:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:12:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27625] cpplint crash when
 there is a duplicate header followed by another header. : [Attachment
 33421] Proposed fix.
In-Reply-To: <bug-27625-0@https.bugs.webkit.org/>
References: <bug-27625-0@https.bugs.webkit.org/>
Message-ID: <20090724101223.D06E133F1DD5@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27625: cpplint crash when there is a duplicate header followed by another
header.
https://bugs.webkit.org/show_bug.cgi?id=27625

Attachment 33421: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33421&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 03:31:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:31:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27560] [Gtk] Password is
 saved into gnome-keyring even if auth. fails : [Attachment 33422]
 webkit-bug-27560-fix-authentication.patch
In-Reply-To: <bug-27560-0@https.bugs.webkit.org/>
References: <bug-27560-0@https.bugs.webkit.org/>
Message-ID: <20090724103104.2D1D333F1FE9@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has asked  for review:
Bug 27560: [Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Attachment 33422: webkit-bug-27560-fix-authentication.patch
https://bugs.webkit.org/attachment.cgi?id=33422&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 03:36:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:36:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27645] Fix the last of the
 x-frame constructor calls to have the right prototype chains : [Attachment
 33423] patch
In-Reply-To: <bug-27645-0@https.bugs.webkit.org/>
References: <bug-27645-0@https.bugs.webkit.org/>
Message-ID: <20090724103651.8D3E533F20A5@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27645: Fix the last of the x-frame constructor calls to have the right
prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

Attachment 33423: patch
https://bugs.webkit.org/attachment.cgi?id=33423&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 03:45:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:45:41 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27560] [Gtk] Password is saved
 into gnome-keyring even if auth. fails : [Attachment 33422]
 webkit-bug-27560-fix-authentication.patch
In-Reply-To: <bug-27560-0@https.bugs.webkit.org/>
References: <bug-27560-0@https.bugs.webkit.org/>
Message-ID: <20090724104541.B946933F214C@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has denied Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 27560: [Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Attachment 33422: webkit-bug-27560-fix-authentication.patch
https://bugs.webkit.org/attachment.cgi?id=33422&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
>  2009-07-23  Jan Michael Alonzo  <jmalonzo at webkit.org>
>  
>	   Reviewed by Eric Seidel.
> diff --git a/WebKit/gtk/webkit/webkitsoupauthdialog.c
b/WebKit/gtk/webkit/webkitsoupauthdialog.c
> index d5ca79c..eeaaa63 100644
> --- a/WebKit/gtk/webkit/webkitsoupauthdialog.c
> +++ b/WebKit/gtk/webkit/webkitsoupauthdialog.c
> @@ -90,12 +90,16 @@ typedef struct _WebKitAuthData {
>      GtkWidget* passwordEntry;
>  #if USE(GNOMEKEYRING)
>      GtkWidget* checkButton;
> +    char *username;
> +    char *password;
>  #endif
>  } WebKitAuthData;
>  
>  static void free_authData(WebKitAuthData* authData)
>  {
>      g_object_unref(authData->msg);
> +    g_free(authData->username);
> +    g_free(authData->password);

Should be protected by #if USE(GNOMEKEYRING)

>      g_slice_free(WebKitAuthData, authData);
>  }
>  
> @@ -104,47 +108,52 @@ static void set_password_callback(GnomeKeyringResult
result, guint32 val, gpoint
>  {
>      /* Dummy callback, gnome_keyring_set_network_password does not accept a
NULL one */
>  }
> -#endif
>  
> -static void response_callback(GtkDialog* dialog, gint response_id,
WebKitAuthData* authData)
> +static void save_password_callback(SoupMessage* msg, WebKitAuthData*
authData)
>  {
> -    const char* login;
> -    const char* password;
> -#if USE(GNOMEKEYRING)
>      SoupURI* uri;
> -    gboolean storePassword;
> +
> +    if (msg->status_code >= 400)
> +	   return;
> +

Mmm, are you sure anything < 400 means we should save the password?

>  
> @@ -278,7 +287,7 @@ static void show_auth_dialog(WebKitAuthData* authData,
const char* login, const
>      gtk_box_pack_start (GTK_BOX (vbox), rememberBox,
>			   FALSE, FALSE, 0);
>  
> -    checkButton = gtk_check_button_new_with_label(_("_Remember password"));
> +    checkButton = gtk_check_button_new_with_mnemonic(_("_Remember
password"));
>      if (login && password)
>	   gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(checkButton), TRUE);
>     
gtk_label_set_line_wrap(GTK_LABEL(gtk_bin_get_child(GTK_BIN(checkButton))),
TRUE);

This seems unrelated to this bug (although it looks OK, please open a new bug
with it).

Marking r- for now, waiting for the updated patch :)

From bugzilla-daemon at webkit.org  Fri Jul 24 03:52:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 03:52:11 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33373]
 add new prepare-ChangeLog options to bash completion script
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090724105211.8064233F21F6@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33373: add new prepare-ChangeLog options to bash completion script
https://bugs.webkit.org/attachment.cgi?id=33373&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r+.

Landed as http://trac.webkit.org/changeset/46349

From bugzilla-daemon at webkit.org  Fri Jul 24 04:03:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:03:22 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32587] Now as a
 patch
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090724110322.8898133F246F@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied  review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32587: Now as a patch
https://bugs.webkit.org/attachment.cgi?id=32587&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: xml/XMLHttpRequest.cpp
> +#include "Cache.h"

Rather than flagging each instance below, I just do it once here:
Don't use cache() in XMLHttpRequest because XMLHttpRequest may be used on a
thread (in a worker) and cache() isn't threadsafe.

>From workers and in Documents, XHR eventually gets to DocumentThreadableLoader
(on the main thread), so maybe you can do what you want in there.  (Note that
DocumentThreadableLoader may be used by things other than XHR like
importScripts in workers).

From bugzilla-daemon at webkit.org  Fri Jul 24 04:10:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:10:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26496] iframe isn't loaded
 until xmlhttprequest in parent completes : [Attachment 32587] Now as a
 patch
In-Reply-To: <bug-26496-0@https.bugs.webkit.org/>
References: <bug-26496-0@https.bugs.webkit.org/>
Message-ID: <20090724111059.E770D33F2537@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 26496: iframe isn't loaded until xmlhttprequest in parent completes
https://bugs.webkit.org/show_bug.cgi?id=26496

Attachment 32587: Now as a patch
https://bugs.webkit.org/attachment.cgi?id=32587&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Sorry about that. Clearing my r-. Since I didn't see any commit messages in
here, I thought this had not been landed (when I saw it in the commit queue)
but it has been.

Committed as http://trac.webkit.org/changeset/45732

Then there was a follow up to address workers here:
http://trac.webkit.org/changeset/45755

From bugzilla-daemon at webkit.org  Fri Jul 24 04:14:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:14:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33424] Second round
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090724111414.F349B33F2592@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33424: Second round
https://bugs.webkit.org/attachment.cgi?id=33424&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
Thanks a lot for another round, Adam.  Answering in comments.

From bugzilla-daemon at webkit.org  Fri Jul 24 04:22:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:22:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27647] Gtk/x86_64 build
 failure after r46344 -
 "error:=?UTF-8?Q?=20invalid=20initialization=20of=20reference=20of=20type=20=E2=80=98long=20long=20int=26=E2=80=99=20from=20expression=20of=20type=20=E2=80=98int64=5Ft=E2=80=99?="
 : [Attachment 33425] patch
In-Reply-To: <bug-27647-0@https.bugs.webkit.org/>
References: <bug-27647-0@https.bugs.webkit.org/>
Message-ID: <20090724112208.6C0BB33F2663@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27647: Gtk/x86_64 build failure after r46344 - "error: invalid
initialization of reference of type ?long long int&? from expression of type
?int64_t?"
https://bugs.webkit.org/show_bug.cgi?id=27647

Attachment 33425: patch
https://bugs.webkit.org/attachment.cgi?id=33425&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 04:35:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:35:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27560] [Gtk] Password is
 saved into gnome-keyring even if auth. fails : [Attachment 33426]
 webkit-bug-27560-fix-authentication-v2.patch
In-Reply-To: <bug-27560-0@https.bugs.webkit.org/>
References: <bug-27560-0@https.bugs.webkit.org/>
Message-ID: <20090724113521.9B9F033F2778@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has asked  for review:
Bug 27560: [Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Attachment 33426: webkit-bug-27560-fix-authentication-v2.patch
https://bugs.webkit.org/attachment.cgi?id=33426&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 04:38:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:38:52 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27560] [Gtk] Password is
 saved into gnome-keyring even if auth. fails : [Attachment 33426]
 webkit-bug-27560-fix-authentication-v2.patch
In-Reply-To: <bug-27560-0@https.bugs.webkit.org/>
References: <bug-27560-0@https.bugs.webkit.org/>
Message-ID: <20090724113852.B00A533F27C4@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has granted Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 27560: [Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Attachment 33426: webkit-bug-27560-fix-authentication-v2.patch
https://bugs.webkit.org/attachment.cgi?id=33426&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
authData is leaked when the authentication fails, but other than that looks
good to me.

From bugzilla-daemon at webkit.org  Fri Jul 24 04:49:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:49:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27648] ApplicationCache
 Layout test failing on GTK : [Attachment 33427] patch
In-Reply-To: <bug-27648-0@https.bugs.webkit.org/>
References: <bug-27648-0@https.bugs.webkit.org/>
Message-ID: <20090724114951.DFFF133F28C4@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27648: ApplicationCache Layout test failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=27648

Attachment 33427: patch
https://bugs.webkit.org/attachment.cgi?id=33427&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 04:59:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 04:59:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27648] ApplicationCache
 Layout test failing on GTK : [Attachment 33427] patch
In-Reply-To: <bug-27648-0@https.bugs.webkit.org/>
References: <bug-27648-0@https.bugs.webkit.org/>
Message-ID: <20090724115945.2C8A133F2C2B@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 27648: ApplicationCache Layout test failing on GTK
https://bugs.webkit.org/show_bug.cgi?id=27648

Attachment 33427: patch
https://bugs.webkit.org/attachment.cgi?id=33427&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK.

From bugzilla-daemon at webkit.org  Fri Jul 24 05:15:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:15:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27560] [Gtk] Password is
 saved into gnome-keyring even if auth. fails : [Attachment 33428]
 webkit-bug-27560-fix-authentication-v3.patch
In-Reply-To: <bug-27560-0@https.bugs.webkit.org/>
References: <bug-27560-0@https.bugs.webkit.org/>
Message-ID: <20090724121536.73B4F33F2DB8@gamma.macosforge.org>

Priit Laes (IRC: plaes) <amd at store20.com> has asked  for review:
Bug 27560: [Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Attachment 33428: webkit-bug-27560-fix-authentication-v3.patch
https://bugs.webkit.org/attachment.cgi?id=33428&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 05:19:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:19:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27650]
 ChromeClient::maxAppCacheSize() method was left accidentally in
 WebKit/qt/ChromeClientQt.h : [Attachment 33429] Remove the
 ChromeClient::maxAppCacheSize() method in
 WebKit/mac/WebCoreSupport/ChromeClientQt.h
In-Reply-To: <bug-27650-0@https.bugs.webkit.org/>
References: <bug-27650-0@https.bugs.webkit.org/>
Message-ID: <20090724121947.E84B133F2E34@gamma.macosforge.org>

Andrei Popescu <andreip at google.com> has asked  for review:
Bug 27650: ChromeClient::maxAppCacheSize() method was left accidentally in
WebKit/qt/ChromeClientQt.h
https://bugs.webkit.org/show_bug.cgi?id=27650

Attachment 33429: Remove the  ChromeClient::maxAppCacheSize() method in
WebKit/mac/WebCoreSupport/ChromeClientQt.h
https://bugs.webkit.org/attachment.cgi?id=33429&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 05:26:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:26:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27560] [Gtk] Password is
 saved into gnome-keyring even if auth. fails : [Attachment 33428]
 webkit-bug-27560-fix-authentication-v3.patch
In-Reply-To: <bug-27560-0@https.bugs.webkit.org/>
References: <bug-27560-0@https.bugs.webkit.org/>
Message-ID: <20090724122656.7066E33F2EFE@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has granted Priit Laes (IRC: plaes)
<amd at store20.com>'s request for review:
Bug 27560: [Gtk] Password is saved into gnome-keyring even if auth. fails
https://bugs.webkit.org/show_bug.cgi?id=27560

Attachment 33428: webkit-bug-27560-fix-authentication-v3.patch
https://bugs.webkit.org/attachment.cgi?id=33428&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
OK.

From bugzilla-daemon at webkit.org  Fri Jul 24 05:34:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:34:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27488] SVG and XPath memory
 leaks in V8 bindings : [Attachment 33430] Avoid memory leaks and cleanup
 use of get() and release() on RefPtrs.
In-Reply-To: <bug-27488-0@https.bugs.webkit.org/>
References: <bug-27488-0@https.bugs.webkit.org/>
Message-ID: <20090724123453.574D933F2FE1@gamma.macosforge.org>

Mads Ager <ager at chromium.org> has asked  for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33430: Avoid memory leaks and cleanup use of get() and release() on
RefPtrs.
https://bugs.webkit.org/attachment.cgi?id=33430&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 05:43:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:43:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26352] Remove void
 QWebFrame::renderContents(...) : [Attachment 33431] Added tests and qdoc
 headers.
In-Reply-To: <bug-26352-0@https.bugs.webkit.org/>
References: <bug-26352-0@https.bugs.webkit.org/>
Message-ID: <20090724124341.76AED33F30D4@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has asked	for review:
Bug 26352: Remove void QWebFrame::renderContents(...)
https://bugs.webkit.org/show_bug.cgi?id=26352

Attachment 33431: Added tests and qdoc headers.
https://bugs.webkit.org/attachment.cgi?id=33431&action=review

------- Additional Comments from Andre Pedralho <apedralho at gmail.com>
Patch updated according to the suggestions.

From bugzilla-daemon at webkit.org  Fri Jul 24 05:44:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:44:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27625] cpplint crash when
 there is a duplicate header followed by another header. : [Attachment
 33421] Proposed fix.
In-Reply-To: <bug-27625-0@https.bugs.webkit.org/>
References: <bug-27625-0@https.bugs.webkit.org/>
Message-ID: <20090724124435.92A2F33F30F0@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27625: cpplint crash when there is a duplicate header followed by another
header.
https://bugs.webkit.org/show_bug.cgi?id=27625

Attachment 33421: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33421&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 05:52:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 05:52:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 33432] patch 0.6 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090724125238.A65DF33F31C1@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 33432: patch 0.6 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=33432&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
1) ran style code script
2) left name as originalURL to match w/ QWebHistory::originalURL (as w/ gtk API
)
3) updated to ToT
4) adde class doc overview

From bugzilla-daemon at webkit.org  Fri Jul 24 06:16:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 06:16:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33418] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090724131628.9535333F343B@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33418: Step 1
https://bugs.webkit.org/attachment.cgi?id=33418&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +    if (m_inspectorController)
> +	   return m_inspectorController->resourceTrackingEnabled();
> +    else
> +	   return false;

This (and a few othe places) should be written like:

> +    if (m_inspectorController)
> +	   return m_inspectorController->resourceTrackingEnabled();
> +    return false;

From bugzilla-daemon at webkit.org  Fri Jul 24 06:43:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 06:43:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27250] Geolocation callback
 function IDL files are superfluous : [Attachment 33433] Patch for bug 27250
In-Reply-To: <bug-27250-0@https.bugs.webkit.org/>
References: <bug-27250-0@https.bugs.webkit.org/>
Message-ID: <20090724134317.186B133F38A3@gamma.macosforge.org>

steveblock at google.com has asked  for review:
Bug 27250: Geolocation callback function IDL files are superfluous
https://bugs.webkit.org/show_bug.cgi?id=27250

Attachment 33433: Patch for bug 27250
https://bugs.webkit.org/attachment.cgi?id=33433&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 06:47:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 06:47:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27646] REGRESSION:
 inspector seems broken in ToT WebKit : [Attachment 33434] Fixed
In-Reply-To: <bug-27646-0@https.bugs.webkit.org/>
References: <bug-27646-0@https.bugs.webkit.org/>
Message-ID: <20090724134700.2373933F391C@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27646: REGRESSION: inspector seems broken in ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=27646

Attachment 33434: Fixed
https://bugs.webkit.org/attachment.cgi?id=33434&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 06:54:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 06:54:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27646] REGRESSION: inspector
 seems broken in ToT WebKit : [Attachment 33434] Fixed
In-Reply-To: <bug-27646-0@https.bugs.webkit.org/>
References: <bug-27646-0@https.bugs.webkit.org/>
Message-ID: <20090724135425.3A4AA33F3A57@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27646: REGRESSION: inspector seems broken in ToT WebKit
https://bugs.webkit.org/show_bug.cgi?id=27646

Attachment 33434: Fixed
https://bugs.webkit.org/attachment.cgi?id=33434&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 06:56:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 06:56:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33435] When clearing the plugin
 database, clear also the timestamp map.
Message-ID: <20090724135625.9B48C33F3A98@gamma.macosforge.org>

X-Bugzilla-Type: request
In-Reply-To: <bug-27651-0 at https.bugs.webkit.org/>
References: <bug-27651-0 at https.bugs.webkit.org/>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33435: When clearing the plugin database, clear also the timestamp
map.

https://bugs.webkit.org/attachment.cgi?id=33435&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:02:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:02:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33436] Allow to enable/disable
 particular plugin packages.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090724140231.A6A3433F3B33@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33436: Allow to enable/disable particular plugin packages.
https://bugs.webkit.org/attachment.cgi?id=33436&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:02:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:02:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26352] Remove void
 QWebFrame::renderContents(...) : [Attachment 33431] Added tests and qdoc
 headers.
In-Reply-To: <bug-26352-0@https.bugs.webkit.org/>
References: <bug-26352-0@https.bugs.webkit.org/>
Message-ID: <20090724140253.41C5933F3B3E@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has canceled Andre Pedralho
<apedralho at gmail.com>'s request for review:
Bug 26352: Remove void QWebFrame::renderContents(...)
https://bugs.webkit.org/show_bug.cgi?id=26352

Attachment 33431: Added tests and qdoc headers.
https://bugs.webkit.org/attachment.cgi?id=33431&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:02:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:02:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26352] Remove void
 QWebFrame::renderContents(...) : [Attachment 33437] Fixed variable name and
 update ToT.
In-Reply-To: <bug-26352-0@https.bugs.webkit.org/>
References: <bug-26352-0@https.bugs.webkit.org/>
Message-ID: <20090724140253.6F5FA33F3B42@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has asked	for review:
Bug 26352: Remove void QWebFrame::renderContents(...)
https://bugs.webkit.org/show_bug.cgi?id=26352

Attachment 33437: Fixed variable name and update ToT.
https://bugs.webkit.org/attachment.cgi?id=33437&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:09:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:09:59 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27650]
 ChromeClient::maxAppCacheSize() method was left accidentally in
 WebKit/qt/ChromeClientQt.h : [Attachment 33429] Remove the
 ChromeClient::maxAppCacheSize() method in
 WebKit/mac/WebCoreSupport/ChromeClientQt.h
In-Reply-To: <bug-27650-0@https.bugs.webkit.org/>
References: <bug-27650-0@https.bugs.webkit.org/>
Message-ID: <20090724140959.01AFB33F3C3C@gamma.macosforge.org>

Andrei Popescu <andreip at google.com> has canceled Andrei Popescu
<andreip at google.com>'s request for review:
Bug 27650: ChromeClient::maxAppCacheSize() method was left accidentally in
WebKit/qt/ChromeClientQt.h
https://bugs.webkit.org/show_bug.cgi?id=27650

Attachment 33429: Remove the  ChromeClient::maxAppCacheSize() method in
WebKit/mac/WebCoreSupport/ChromeClientQt.h
https://bugs.webkit.org/attachment.cgi?id=33429&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:10:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:10:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33438] Allow to explicitly choose a
 preferred plugin for a mimetype.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090724141051.3F30E33F3C6B@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33438: Allow to explicitly choose a preferred plugin for a mimetype.
https://bugs.webkit.org/attachment.cgi?id=33438&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:12:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:12:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27526] Inspector: Removing
 an Attribute via Edit should Delete the Attribute,
 Not Ignore Your Changes : [Attachment 33439] Applies to ToT
In-Reply-To: <bug-27526-0@https.bugs.webkit.org/>
References: <bug-27526-0@https.bugs.webkit.org/>
Message-ID: <20090724141255.D7F6A33F3CB4@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27526: Inspector: Removing an Attribute via Edit should Delete the
Attribute, Not Ignore Your Changes
https://bugs.webkit.org/show_bug.cgi?id=27526

Attachment 33439: Applies to ToT
https://bugs.webkit.org/attachment.cgi?id=33439&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
- Fixed a Style Issue as well

From bugzilla-daemon at webkit.org  Fri Jul 24 07:15:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:15:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33440] Expose the
 PluginDatabase::pluginForMIMEType() function as public API.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090724141522.473E533F3CF5@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33440: Expose the PluginDatabase::pluginForMIMEType() function as
public API.
https://bugs.webkit.org/attachment.cgi?id=33440&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:17:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:17:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26352] Remove void
 QWebFrame::renderContents(...) : [Attachment 33437] Fixed variable name and
 update ToT.
In-Reply-To: <bug-26352-0@https.bugs.webkit.org/>
References: <bug-26352-0@https.bugs.webkit.org/>
Message-ID: <20090724141745.0E3A433F3D31@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Andre Pedralho <apedralho at gmail.com>'s
request for review:
Bug 26352: Remove void QWebFrame::renderContents(...)
https://bugs.webkit.org/show_bug.cgi?id=26352

Attachment 33437: Fixed variable name and update ToT.
https://bugs.webkit.org/attachment.cgi?id=33437&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Looks good.

From bugzilla-daemon at webkit.org  Fri Jul 24 07:19:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:19:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33441] Expose the default plugin
 directories and the current directory set of the plugin database as public
 API.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090724141906.0619133F3D78@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33441: Expose the default plugin directories and the current
directory set of the plugin database as public API.
https://bugs.webkit.org/attachment.cgi?id=33441&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:26:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:26:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33442] Fix style in PluginPackage and
 PluginDatabase.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090724142606.3CF9F33F3E0B@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33442: Fix style in PluginPackage and PluginDatabase.
https://bugs.webkit.org/attachment.cgi?id=33442&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:45:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:45:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27653] Filetype support
 changes for cpplint and check_webkit_style : [Attachment 33444] Filetype
 support changes for cpplint and check_webkit_style
In-Reply-To: <bug-27653-0@https.bugs.webkit.org/>
References: <bug-27653-0@https.bugs.webkit.org/>
Message-ID: <20090724144533.72D3C33F4046@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27653: Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/show_bug.cgi?id=27653

Attachment 33444: Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/attachment.cgi?id=33444&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:48:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:48:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27512] Test for
 QWebFrame::hasSetFocus() is trying to use a not defined resource. :
 [Attachment 33445] Using setHtml methods to define the test web page
 instead of external resources.
In-Reply-To: <bug-27512-0@https.bugs.webkit.org/>
References: <bug-27512-0@https.bugs.webkit.org/>
Message-ID: <20090724144824.CE1AD33F4089@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has asked	for review:
Bug 27512: Test for QWebFrame::hasSetFocus() is trying to use a not defined
resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

Attachment 33445: Using setHtml methods to define the test web page instead of
external resources.
https://bugs.webkit.org/attachment.cgi?id=33445&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 07:49:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:49:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33357] Make it possible to build JSC as a shared library without symbol
 lists
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090724144902.06DF533F40A7@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33357: Make it possible to build JSC as a shared library without
symbol lists
https://bugs.webkit.org/attachment.cgi?id=33357&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
I have to clear review on this patch as it needs to be rebased against current
ToT (some parts fall away) and I've noticed a new build issue on Windows. I'll
rework it next week.

From bugzilla-daemon at webkit.org  Fri Jul 24 07:49:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:49:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33358] Build JSC as a shared library for QtWebKit
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090724144926.6AE6B33F40C5@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33358: Build JSC as a shared library for QtWebKit
https://bugs.webkit.org/attachment.cgi?id=33358&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing review on this one, too, as it's not useful without the other patch

From bugzilla-daemon at webkit.org  Fri Jul 24 07:52:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 07:52:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27653] Filetype support
 changes for cpplint and check_webkit_style : [Attachment 33444] Filetype
 support changes for cpplint and check_webkit_style
In-Reply-To: <bug-27653-0@https.bugs.webkit.org/>
References: <bug-27653-0@https.bugs.webkit.org/>
Message-ID: <20090724145216.1EB9E33F4121@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27653: Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/show_bug.cgi?id=27653

Attachment 33444: Filetype support changes for cpplint and check_webkit_style
https://bugs.webkit.org/attachment.cgi?id=33444&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 08:09:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 08:09:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 33448] Revert of previous patch.
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090724150923.5F42233F4364@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has asked  for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 33448: Revert of previous patch.
https://bugs.webkit.org/attachment.cgi?id=33448&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 08:13:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 08:13:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27654]
 WebCore/page/Frame.cpp/h does not conform to style standards : [Attachment
 33449] Style patch for Frame.cpp/h
In-Reply-To: <bug-27654-0@https.bugs.webkit.org/>
References: <bug-27654-0@https.bugs.webkit.org/>
Message-ID: <20090724151347.D85E733F4407@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27654: WebCore/page/Frame.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27654

Attachment 33449: Style patch for Frame.cpp/h
https://bugs.webkit.org/attachment.cgi?id=33449&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 08:14:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 08:14:58 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25867] [QT] Implement
 original_url getter method to the API : [Attachment 33432] patch 0.6 -
 implement originalUrl support
In-Reply-To: <bug-25867-0@https.bugs.webkit.org/>
References: <bug-25867-0@https.bugs.webkit.org/>
Message-ID: <20090724151458.28B8C33F444D@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 25867: [QT] Implement original_url getter method to the API
https://bugs.webkit.org/show_bug.cgi?id=25867

Attachment 33432: patch 0.6 - implement originalUrl support
https://bugs.webkit.org/attachment.cgi?id=33432&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

Please submit a separate patch for the function renaming, as discussed on IRC
:)

From bugzilla-daemon at webkit.org  Fri Jul 24 08:17:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 08:17:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27654]
 WebCore/page/Frame.cpp/h does not conform to style standards : [Attachment
 33449] Style patch for Frame.cpp/h
In-Reply-To: <bug-27654-0@https.bugs.webkit.org/>
References: <bug-27654-0@https.bugs.webkit.org/>
Message-ID: <20090724151728.58B3833F44AE@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has canceled Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27654: WebCore/page/Frame.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27654

Attachment 33449: Style patch for Frame.cpp/h
https://bugs.webkit.org/attachment.cgi?id=33449&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 08:17:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 08:17:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27654]
 WebCore/page/Frame.cpp/h does not conform to style standards : [Attachment
 33450] Fixed bug # typo
In-Reply-To: <bug-27654-0@https.bugs.webkit.org/>
References: <bug-27654-0@https.bugs.webkit.org/>
Message-ID: <20090724151728.B879033F44B2@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27654: WebCore/page/Frame.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27654

Attachment 33450: Fixed bug # typo
https://bugs.webkit.org/attachment.cgi?id=33450&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 08:51:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 08:51:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27655] [v8] cache v8
 strings when converting from webcore string to v8 string : [Attachment
 33453] Initial version
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090724155142.E85D033F4AD0@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33453: Initial version
https://bugs.webkit.org/attachment.cgi?id=33453&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 09:05:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:05:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27654]
 WebCore/page/Frame.cpp/h does not conform to style standards : [Attachment
 33450] Fixed bug # typo
In-Reply-To: <bug-27654-0@https.bugs.webkit.org/>
References: <bug-27654-0@https.bugs.webkit.org/>
Message-ID: <20090724160505.AF72833F4CC5@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27654: WebCore/page/Frame.cpp/h does not conform to style standards
https://bugs.webkit.org/show_bug.cgi?id=27654

Attachment 33450: Fixed bug # typo
https://bugs.webkit.org/attachment.cgi?id=33450&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
While I fundamentally disagree with this class of changes altogether, I have no
reason not to r+ this.

From bugzilla-daemon at webkit.org  Fri Jul 24 09:05:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:05:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 33448] Revert of previous patch.
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090724160532.20CEF33F4CD7@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 33448: Revert of previous patch.
https://bugs.webkit.org/attachment.cgi?id=33448&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Verified that it is simply a revert and (essentially) rubberstamping.

From bugzilla-daemon at webkit.org  Fri Jul 24 09:09:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:09:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27657] Add more wince port
 files : [Attachment 33454] the patch
In-Reply-To: <bug-27657-0@https.bugs.webkit.org/>
References: <bug-27657-0@https.bugs.webkit.org/>
Message-ID: <20090724160939.C76F133F4D6C@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27657: Add more wince port files
https://bugs.webkit.org/show_bug.cgi?id=27657

Attachment 33454: the patch
https://bugs.webkit.org/attachment.cgi?id=33454&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
	* loader/icon/wince/IconDatabaseWince.cpp: Added.
	* rendering/RenderThemeWince.cpp: Added.
	* rendering/RenderThemeWince.h: Added.
	* storage/wince/DatabaseThreadWince.cpp: Added.
	* storage/wince/DatabaseThreadWince.h: Added.
	* storage/wince/LocalStorageThreadWince.cpp: Added.
	* storage/wince/LocalStorageThreadWince.h: Added.
	* svg/graphics/wince/SVGResourceFilterWince.cpp: Added.

From bugzilla-daemon at webkit.org  Fri Jul 24 09:17:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:17:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27347]
 HitTestResult::boundingBox can ASSERT in SVGRenderBase::mapLocalToContainer
 : [Attachment 32862] Make using HitTestResult on SVG not run into
 assertions
In-Reply-To: <bug-27347-0@https.bugs.webkit.org/>
References: <bug-27347-0@https.bugs.webkit.org/>
Message-ID: <20090724161719.6B26D33F4EE1@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Holger Freyther
<zecke at selfish.org>'s request for review:
Bug 27347: HitTestResult::boundingBox can ASSERT in
SVGRenderBase::mapLocalToContainer
https://bugs.webkit.org/show_bug.cgi?id=27347

Attachment 32862: Make using HitTestResult on SVG not run into assertions
https://bugs.webkit.org/attachment.cgi?id=32862&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
Could you also add a LayoutTest for this?

From bugzilla-daemon at webkit.org  Fri Jul 24 09:31:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:31:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27657] Add more wince port
 files : [Attachment 33454] the patch
In-Reply-To: <bug-27657-0@https.bugs.webkit.org/>
References: <bug-27657-0@https.bugs.webkit.org/>
Message-ID: <20090724163100.5F75C33F5085@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27657: Add more wince port files
https://bugs.webkit.org/show_bug.cgi?id=27657

Attachment 33454: the patch
https://bugs.webkit.org/attachment.cgi?id=33454&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

Subject to the following minor corrections:

> +++ b/WebCore/loader/icon/wince/IconDatabaseWince.cpp
> @@ -0,0 +1,82 @@
> +/*
> + *  Copyright (C) 2007 Staikos Computing Services Inc.

  Copyright should be Torch Mobile Inc.  Is the year correct?

> +#ifndef RenderThemeWincece_h
> +#define RenderThemeWincece_h

  Might want to fix that

  
Rest looks okay to me.

From bugzilla-daemon at webkit.org  Fri Jul 24 09:43:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:43:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27532] [WinCairo] Correct
 Build Dependencies : [Attachment 33455] Revised per bdash's comments
In-Reply-To: <bug-27532-0@https.bugs.webkit.org/>
References: <bug-27532-0@https.bugs.webkit.org/>
Message-ID: <20090724164302.644A033F51ED@gamma.macosforge.org>

Brent Fulgham <bfulgham at webkit.org> has asked  for review:
Bug 27532: [WinCairo] Correct Build Dependencies
https://bugs.webkit.org/show_bug.cgi?id=27532

Attachment 33455: Revised per bdash's comments
https://bugs.webkit.org/attachment.cgi?id=33455&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 09:46:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:46:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27532] [WinCairo] Correct
 Build Dependencies : [Attachment 33455] Revised per bdash's comments
In-Reply-To: <bug-27532-0@https.bugs.webkit.org/>
References: <bug-27532-0@https.bugs.webkit.org/>
Message-ID: <20090724164613.74E9233F5231@gamma.macosforge.org>

Dave Hyatt <hyatt at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 27532: [WinCairo] Correct Build Dependencies
https://bugs.webkit.org/show_bug.cgi?id=27532

Attachment 33455: Revised per bdash's comments
https://bugs.webkit.org/attachment.cgi?id=33455&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 24 09:49:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 09:49:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27655] [v8] cache v8 strings
 when converting from webcore string to v8 string : [Attachment 33453]
 Initial version
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090724164951.1BE8B33F52AD@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33453: Initial version
https://bugs.webkit.org/attachment.cgi?id=33453&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to clean up.

> Index: third_party/WebKit/WebCore/bindings/v8/V8Binding.cpp

> +HashMap<StringImpl*, v8::String*> stringCache;

Better to use DEFINE_STATE_LOCAL.  (Then it is allocated on demand instead of
at start up and it won't have to get deleted on shutdown. You could make some
statically linked function to expose this.)

> +
> +static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void*
parameter)
> +{

Assert that this is only called on the main thread (since HashMap isn't
threadsafe).

> +    StringImpl* stringImpl = static_cast<StringImpl*>(parameter);
> +    ASSERT(stringCache.contains(stringImpl));
> +    stringCache.remove(stringImpl);
> +    wrapper.Dispose();
>  }
>  
>  v8::Local<v8::String> v8ExternalString(const String& string)

A "to" prefix is usually used on conversion functions like this.  (Or perhaps
you want findCachedV8String?)

>  {

Assert that this is only called on the main thread (since HashMap isn't
threadsafe). (As long as, that's true.)

> +
> +    StringImpl* stringImpl = string.impl();
> +    v8::String* s = stringCache.get(stringImpl);
> +    if (s) return v8::Local<v8::String>(s);

Avoid abbreviations:
s/s/cachedV8String/

From bugzilla-daemon at webkit.org  Fri Jul 24 10:11:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 10:11:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27416] Windows build break
 due to warning C4819 : [Attachment 33029] Disable C4819 to fix build for
 non-English Windows
In-Reply-To: <bug-27416-0@https.bugs.webkit.org/>
References: <bug-27416-0@https.bugs.webkit.org/>
Message-ID: <20090724171109.F38BD33F5516@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Kwang Yul Seo
<kwangyul.seo at gmail.com>'s request for review:
Bug 27416: Windows build break due to warning C4819
https://bugs.webkit.org/show_bug.cgi?id=27416

Attachment 33029: Disable C4819 to fix build for non-English Windows
https://bugs.webkit.org/attachment.cgi?id=33029&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Is there some way to put this disabling in fewer places and still affect all
the configurations?

From bugzilla-daemon at webkit.org  Fri Jul 24 10:41:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 10:41:21 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33424] Second round
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090724174121.2F04033F58AB@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33424: Second round
https://bugs.webkit.org/attachment.cgi?id=33424&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I think you mistakenly uploaded the old version of the patch.

From bugzilla-daemon at webkit.org  Fri Jul 24 10:45:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 10:45:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27488] SVG and XPath memory
 leaks in V8 bindings : [Attachment 33430] Avoid memory leaks and cleanup
 use of get() and release() on RefPtrs.
In-Reply-To: <bug-27488-0@https.bugs.webkit.org/>
References: <bug-27488-0@https.bugs.webkit.org/>
Message-ID: <20090724174553.C8F9A33F5985@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Mads Ager <ager at chromium.org>'s
request for review:
Bug 27488: SVG and XPath memory leaks in V8 bindings
https://bugs.webkit.org/show_bug.cgi?id=27488

Attachment 33430: Avoid memory leaks and cleanup use of get() and release() on
RefPtrs.
https://bugs.webkit.org/attachment.cgi?id=33430&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yay!  Looks great.  Thanks for incorporating our comments.

From bugzilla-daemon at webkit.org  Fri Jul 24 11:33:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 11:33:43 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27645] Fix the last of the
 x-frame constructor calls to have the right prototype chains : [Attachment
 33423] patch
In-Reply-To: <bug-27645-0@https.bugs.webkit.org/>
References: <bug-27645-0@https.bugs.webkit.org/>
Message-ID: <20090724183343.C660B33F677E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27645: Fix the last of the x-frame constructor calls to have the right
prototype chains
https://bugs.webkit.org/show_bug.cgi?id=27645

Attachment 33423: patch
https://bugs.webkit.org/attachment.cgi?id=33423&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+    // FIXME: Why do we use the lexical global object here?

I believe this is correct.  See step 14 of:

http://www.whatwg.org/specs/web-workers/current-work/#creating-workers

14. Let docs be the list of relevant Document objects to add given the global
scope of the script that invoked the constructor.

The lexical global object is "the global scope of the script that invoked the
constructor".

From bugzilla-daemon at webkit.org  Fri Jul 24 11:33:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 11:33:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27627] DRT
 animation/transition pause API does not pause accelerated animations :
 [Attachment 33385] Patch, changelogs
In-Reply-To: <bug-27627-0@https.bugs.webkit.org/>
References: <bug-27627-0@https.bugs.webkit.org/>
Message-ID: <20090724183345.62AA133F6794@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 27627: DRT animation/transition pause API does not pause accelerated
animations
https://bugs.webkit.org/show_bug.cgi?id=27627

Attachment 33385: Patch, changelogs
https://bugs.webkit.org/attachment.cgi?id=33385&action=review

------- Additional Comments from mitz at webkit.org
Minor style issues:

> -void AnimationBase::pauseAtTime(double t)
> +void AnimationBase::freezeAtTime(double t)

While you?re at it, please rename 't' to 'time'.

> +    ASSERT(m_startTime);	   // if m_startTime is zero, we haven't
started yet, so we'll get a bad pause time.

Since it ends with a period, it must begin with a capital ?If? instead of ?if?.


> +    void freezeAtTime(double t);

No need to name the parameter here.

> +    virtual void suspendAnimations(double time = 0);    // zero value for
time means "use currentTime()".

?Zero? instead of ?zero?.

From bugzilla-daemon at webkit.org  Fri Jul 24 12:18:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:18:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27661] Move more callers to
 using 3 argument toJS : [Attachment 33460] patch
In-Reply-To: <bug-27661-0@https.bugs.webkit.org/>
References: <bug-27661-0@https.bugs.webkit.org/>
Message-ID: <20090724191813.398F433F6E48@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27661: Move more callers to using 3 argument toJS
https://bugs.webkit.org/show_bug.cgi?id=27661

Attachment 33460: patch
https://bugs.webkit.org/attachment.cgi?id=33460&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 12:24:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:24:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27661] Move more callers to
 using 3 argument toJS : [Attachment 33460] patch
In-Reply-To: <bug-27661-0@https.bugs.webkit.org/>
References: <bug-27661-0@https.bugs.webkit.org/>
Message-ID: <20090724192442.1CFEB33F6F24@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27661: Move more callers to using 3 argument toJS
https://bugs.webkit.org/show_bug.cgi?id=27661

Attachment 33460: patch
https://bugs.webkit.org/attachment.cgi?id=33460&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I, for one, welcome our new deprecatedGlobalObjectForPrototype overlords.

From bugzilla-daemon at webkit.org  Fri Jul 24 12:32:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:32:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27663] FontPlatformData for
 Qt requires mapping from FontWeight to QFont::Weight : [Attachment 33461]
 Path to add toQFontWeight functionality.
In-Reply-To: <bug-27663-0@https.bugs.webkit.org/>
References: <bug-27663-0@https.bugs.webkit.org/>
Message-ID: <20090724193245.0170A33F7039@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27663: FontPlatformData for Qt requires mapping from FontWeight to
QFont::Weight
https://bugs.webkit.org/show_bug.cgi?id=27663

Attachment 33461: Path to add toQFontWeight functionality.
https://bugs.webkit.org/attachment.cgi?id=33461&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 12:51:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:51:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24333]
 execCommand('underline') can modify DOM outside of the contentEditable area
 : [Attachment 33463] smaller patch with extra test case for unsplittable
 element
In-Reply-To: <bug-24333-0@https.bugs.webkit.org/>
References: <bug-24333-0@https.bugs.webkit.org/>
Message-ID: <20090724195157.096C833F728C@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 24333: execCommand('underline') can modify DOM outside of the
contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Attachment 33463: smaller patch with extra test case for unsplittable element
https://bugs.webkit.org/attachment.cgi?id=33463&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 12:52:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:52:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27639] XSS Auditor
 interferes with -[WebView stringByEvaluatingJavaScriptFromString:] :
 [Attachment 33464] Patch with test
In-Reply-To: <bug-27639-0@https.bugs.webkit.org/>
References: <bug-27639-0@https.bugs.webkit.org/>
Message-ID: <20090724195221.8AEB133F72A9@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27639: XSS Auditor interferes with -[WebView
stringByEvaluatingJavaScriptFromString:]
https://bugs.webkit.org/show_bug.cgi?id=27639

Attachment 33464: Patch with test
https://bugs.webkit.org/attachment.cgi?id=33464&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Added test.

From bugzilla-daemon at webkit.org  Fri Jul 24 12:53:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:53:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27664] commit-log-editor
 should allow git commit --amend to regenerate the commit log based on the
 modifed ChangeLog : [Attachment 33465] 2009-07-24 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27664-0@https.bugs.webkit.org/>
References: <bug-27664-0@https.bugs.webkit.org/>
Message-ID: <20090724195332.AF0A833F72F5@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27664: commit-log-editor should allow git commit --amend to regenerate the
commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

Attachment 33465: 2009-07-24  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33465&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
Reviewed by NOBODY (OOPS!).

commit-log-editor should allow git commit --amend to regenerate the commit log
based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

* Scripts/commit-log-editor: Add --allow-commit-log-suppression option.
The user is asked if he wants to suppress previous ChangeLog and regenerate it,
if this option is enabled.
---
 2 files changed, 32 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 24 12:59:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 12:59:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27663] FontPlatformData for Qt
 requires mapping from FontWeight to QFont::Weight : [Attachment 33461] Path
 to add toQFontWeight functionality.
In-Reply-To: <bug-27663-0@https.bugs.webkit.org/>
References: <bug-27663-0@https.bugs.webkit.org/>
Message-ID: <20090724195949.9009733F73C1@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27663: FontPlatformData for Qt requires mapping from FontWeight to
QFont::Weight
https://bugs.webkit.org/show_bug.cgi?id=27663

Attachment 33461: Path to add toQFontWeight functionality.
https://bugs.webkit.org/attachment.cgi?id=33461&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> +    static inline QFont::Weight toQFontWeight(FontWeight fontWeight)
> +    {
> +	   QFont::Weight weight;

Unnecessary.

> +	   switch (fontWeight) {
> +	   case FontWeight100:
> +	   case FontWeight200:
> +	       weight = QFont::Light;
> +	       break;

return QFont::Light;

> +	   case FontWeight600:
> +	       weight = QFont::DemiBold;

return QFont::DemiBold;

And so on...

> -    if (description.weight() >= FontWeight600) {
> -	   m_font.setWeight(QFont::Bold);
> -	   m_bold = true;
> -    } else
> -	   m_font.setWeight(QFont::Normal);
> +
> +    m_font.setWeight(toQFontWeight(description.weight()));
> +    m_bold = m_font.bold();

Seems unnecessary to keep 'm_bold' with what you are doing.  m_font.bold()
stores the state.

However, this appears to be a behavior change.	Are you sure it is correct?

How did you go about determining the proper mapping?

Did you run the layout tests before and after to see if anything changed?

Cheers,
Adam

From bugzilla-daemon at webkit.org  Fri Jul 24 13:02:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 13:02:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27639] XSS Auditor interferes
 with -[WebView stringByEvaluatingJavaScriptFromString:] : [Attachment
 33464] Patch with test
In-Reply-To: <bug-27639-0@https.bugs.webkit.org/>
References: <bug-27639-0@https.bugs.webkit.org/>
Message-ID: <20090724200254.8AA1933F7433@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27639: XSS Auditor interferes with -[WebView
stringByEvaluatingJavaScriptFromString:]
https://bugs.webkit.org/show_bug.cgi?id=27639

Attachment 33464: Patch with test
https://bugs.webkit.org/attachment.cgi?id=33464&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
A patch of beauty.

From bugzilla-daemon at webkit.org  Fri Jul 24 13:40:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 13:40:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26460] Cross-platform ICO
 decoder should return all icons in file as separate frames,
 sorted by decreasing quality : [Attachment 33468] part four
In-Reply-To: <bug-26460-0@https.bugs.webkit.org/>
References: <bug-26460-0@https.bugs.webkit.org/>
Message-ID: <20090724204022.EEB0933F7955@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has asked Eric Seidel <eric at webkit.org> for
review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460

Attachment 33468: part four
https://bugs.webkit.org/attachment.cgi?id=33468&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Some cleanup and plumbing I split out of the next patch (which, finally,
implements the desired behavior), in order to make it more readable.

Mainly, this adds a new function ImageDecoder::frameSizeAtIndex(), and hooks
the ImageSource::frameSizeAtIndex() implementations to it; no decoder actually
implements it yet (the ICO decoder will after the next patch).

From bugzilla-daemon at webkit.org  Fri Jul 24 13:42:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 13:42:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33376]
 If the user doesn't modify the ChangeLog files in the git commit,
 use prepare-ChangeLog to populate the git commit message.
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090724204214.DBA9833F797C@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has canceled Eli Fidler <eli at staikos.net>'s
request for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33376: If the user doesn't modify the ChangeLog files in the git
commit, use prepare-ChangeLog to populate the git commit message.
https://bugs.webkit.org/attachment.cgi?id=33376&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 13:42:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 13:42:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33469]
 add git configuration option to disable populating commit message
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090724204215.00D6A33F797E@gamma.macosforge.org>

Eli Fidler <eli at staikos.net> has asked	for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33469: add git configuration option to disable populating commit
message
https://bugs.webkit.org/attachment.cgi?id=33469&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 13:49:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 13:49:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24333]
 execCommand('underline') can modify DOM outside of the contentEditable area
 : [Attachment 33463] smaller patch with extra test case for unsplittable
 element
In-Reply-To: <bug-24333-0@https.bugs.webkit.org/>
References: <bug-24333-0@https.bugs.webkit.org/>
Message-ID: <20090724204923.2C38A33F7A70@gamma.macosforge.org>

Justin Garcia <justin.garcia at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 24333: execCommand('underline') can modify DOM outside of the
contentEditable area
https://bugs.webkit.org/show_bug.cgi?id=24333

Attachment 33463: smaller patch with extra test case for unsplittable element
https://bugs.webkit.org/attachment.cgi?id=33463&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 24 13:49:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 13:49:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27605] Improve git workflow
 by populating commit messages with ChangeLog entries. : [Attachment 33469]
 add git configuration option to disable populating commit message
In-Reply-To: <bug-27605-0@https.bugs.webkit.org/>
References: <bug-27605-0@https.bugs.webkit.org/>
Message-ID: <20090724204929.3BAB733F7A86@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Eli Fidler <eli at staikos.net>'s request
for review:
Bug 27605: Improve git workflow by populating commit messages with ChangeLog
entries.
https://bugs.webkit.org/show_bug.cgi?id=27605

Attachment 33469: add git configuration option to disable populating commit
message
https://bugs.webkit.org/attachment.cgi?id=33469&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
I think we should prepend 'webKit' to the git config name otherwise this is
perfect.  The change can be made when landing...

From bugzilla-daemon at webkit.org  Fri Jul 24 14:10:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:10:06 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26742] Support fullscreen in
 MediaPlayer. : [Attachment 33412] Implement video Fullscreen on Mac OS X.
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090724211006.AB8F833F7D1D@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33412: Implement video Fullscreen on Mac OS X.
https://bugs.webkit.org/attachment.cgi?id=33412&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 14:10:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:10:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26742] Support fullscreen
 in MediaPlayer. : [Attachment 33470] Implement video Fullscreen on Mac OS
 X.
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090724211009.148C733F7D26@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33470: Implement video Fullscreen on Mac OS X.
https://bugs.webkit.org/attachment.cgi?id=33470&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
ChromeClient gets a new interface enter/exit/supportsFullscreenForNode().
---
 30 files changed, 1588 insertions(+), 13 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 24 14:14:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:14:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27666] The patch submitted
 for bug 26054 has some no-op instructions that need to be removed :
 [Attachment 33471] patch
In-Reply-To: <bug-27666-0@https.bugs.webkit.org/>
References: <bug-27666-0@https.bugs.webkit.org/>
Message-ID: <20090724211417.876EB33F7DD3@gamma.macosforge.org>

Dumitru Daniliuc <dumi at chromium.org> has asked	for review:
Bug 27666: The patch submitted for bug 26054 has some no-op instructions that
need to be removed
https://bugs.webkit.org/show_bug.cgi?id=27666

Attachment 33471: patch
https://bugs.webkit.org/attachment.cgi?id=33471&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 14:17:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:17:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 21794] Middle-click panning
 should be springloaded while dragging : [Attachment 33404] Pan Scrolling
In-Reply-To: <bug-21794-0@https.bugs.webkit.org/>
References: <bug-21794-0@https.bugs.webkit.org/>
Message-ID: <20090724211700.5B7A133F7E4B@gamma.macosforge.org>

Jon Honeycutt <jhoneycutt at apple.com> has granted Brian Weinstein
<bweinstein at apple.com>'s request for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 33404: Pan Scrolling
https://bugs.webkit.org/attachment.cgi?id=33404&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
> --- a/WebCore/page/EventHandler.cpp
> +++ b/WebCore/page/EventHandler.cpp
> @@ -141,6 +141,8 @@ EventHandler::EventHandler(Frame* frame)
>      , m_mouseDownWasSingleClickInSelection(false)
>      , m_beganSelectingText(false)
>      , m_panScrollInProgress(false)
> +    , m_panScrollButtonPressed(false)
> +    , m_pressedPanScrollInProgress(false)

I think we should stick with the term "spring-loaded pan scroll" rather than
"pressed pan scroll".

> @@ -676,6 +678,9 @@ void EventHandler::setPanScrollCursor()
>      bool north = m_panScrollStartPos.y() > (m_currentMousePosition.y() +
ScrollView::noPanScrollRadius);
>      bool south = m_panScrollStartPos.y() < (m_currentMousePosition.y() -
ScrollView::noPanScrollRadius);
>	    
> +    if ((east || west || north || south) && m_panScrollButtonPressed)
> +	   m_pressedPanScrollInProgress = true;
> +

It's strange to add this logic to setPanScrollCursor(). We should either move
this logic out or rename the function.

r=me, but please fix the above issues.

From bugzilla-daemon at webkit.org  Fri Jul 24 14:22:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:22:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27665] Failed assertion in
 WorkerContext::~WorkerContext() : [Attachment 33472] Fix for flaky tests
In-Reply-To: <bug-27665-0@https.bugs.webkit.org/>
References: <bug-27665-0@https.bugs.webkit.org/>
Message-ID: <20090724212207.B42FA33F7F00@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27665: Failed assertion in WorkerContext::~WorkerContext()
https://bugs.webkit.org/show_bug.cgi?id=27665

Attachment 33472: Fix for flaky tests
https://bugs.webkit.org/attachment.cgi?id=33472&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 14:25:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:25:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27665] Failed assertion in
 WorkerContext::~WorkerContext() : [Attachment 33472] Fix for flaky tests
In-Reply-To: <bug-27665-0@https.bugs.webkit.org/>
References: <bug-27665-0@https.bugs.webkit.org/>
Message-ID: <20090724212537.3F42433F7F8C@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27665: Failed assertion in WorkerContext::~WorkerContext()
https://bugs.webkit.org/show_bug.cgi?id=27665

Attachment 33472: Fix for flaky tests
https://bugs.webkit.org/attachment.cgi?id=33472&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 14:36:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:36:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27329] Inspector: Properties
 Should be Sorted more Naturally : [Attachment 33372] Fixed Based on Review
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090724213627.A5ABB33F80D8@gamma.macosforge.org>

Kevin McCullough <kmccullough at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 33372: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33372&action=review

------- Additional Comments from Kevin McCullough <kmccullough at apple.com>

> +	   //  - check if a == b

You should add your comment here that you don't need to check 'a == b' because
no two object properties are going to be the same thing.

From bugzilla-daemon at webkit.org  Fri Jul 24 14:41:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 14:41:31 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27639] XSS Auditor
 interferes with -[WebView stringByEvaluatingJavaScriptFromString:] :
 [Attachment 33464] Patch with test
In-Reply-To: <bug-27639-0@https.bugs.webkit.org/>
References: <bug-27639-0@https.bugs.webkit.org/>
Message-ID: <20090724214131.9F52E33F8195@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27639: XSS Auditor interferes with -[WebView
stringByEvaluatingJavaScriptFromString:]
https://bugs.webkit.org/show_bug.cgi?id=27639

Attachment 33464: Patch with test
https://bugs.webkit.org/attachment.cgi?id=33464&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Removing from commit queue.

From bugzilla-daemon at webkit.org  Fri Jul 24 15:07:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 15:07:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27286] Inspector: Keyboard
 Shortcuts to Switch Panels : [Attachment 33368] Keyboard Shortcuts for
 Switching Panels
In-Reply-To: <bug-27286-0@https.bugs.webkit.org/>
References: <bug-27286-0@https.bugs.webkit.org/>
Message-ID: <20090724220710.889AC33F84F0@gamma.macosforge.org>

Kevin McCullough <kmccullough at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27286: Inspector: Keyboard Shortcuts to Switch Panels
https://bugs.webkit.org/show_bug.cgi?id=27286

Attachment 33368: Keyboard Shortcuts for Switching Panels
https://bugs.webkit.org/attachment.cgi?id=33368&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 15:16:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 15:16:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 21794] Middle-click panning
 should be springloaded while dragging : [Attachment 33404] Pan Scrolling
In-Reply-To: <bug-21794-0@https.bugs.webkit.org/>
References: <bug-21794-0@https.bugs.webkit.org/>
Message-ID: <20090724221636.945C633F85E3@gamma.macosforge.org>

Brian Weinstein <bweinstein at apple.com> has canceled  review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 33404: Pan Scrolling
https://bugs.webkit.org/attachment.cgi?id=33404&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 15:22:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 15:22:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27525] Fix error handling
 in dedicated worker and worker context. : [Attachment 33474] Proposed Patch
In-Reply-To: <bug-27525-0@https.bugs.webkit.org/>
References: <bug-27525-0@https.bugs.webkit.org/>
Message-ID: <20090724222200.E0EF733F8662@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27525: Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

Attachment 33474: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33474&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 15:40:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 15:40:34 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27525] Fix error handling in
 dedicated worker and worker context. : [Attachment 33474] Proposed Patch
In-Reply-To: <bug-27525-0@https.bugs.webkit.org/>
References: <bug-27525-0@https.bugs.webkit.org/>
Message-ID: <20090724224034.6382733F884C@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled Jian Li <jianli at chromium.org>'s
request for review:
Bug 27525: Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

Attachment 33474: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33474&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just found out that Jian is doing a few more changes to this , so canceling the
review request for him.

From bugzilla-daemon at webkit.org  Fri Jul 24 16:19:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 16:19:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27525] Fix error handling
 in dedicated worker and worker context. : [Attachment 33475] Proposed Patch
In-Reply-To: <bug-27525-0@https.bugs.webkit.org/>
References: <bug-27525-0@https.bugs.webkit.org/>
Message-ID: <20090724231911.9E64133F8C28@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27525: Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

Attachment 33475: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33475&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 16:36:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 16:36:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27525] Fix error handling in
 dedicated worker and worker context. : [Attachment 33475] Proposed Patch
In-Reply-To: <bug-27525-0@https.bugs.webkit.org/>
References: <bug-27525-0@https.bugs.webkit.org/>
Message-ID: <20090724233631.799D433F8E09@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27525: Fix error handling in dedicated worker and worker context.
https://bugs.webkit.org/show_bug.cgi?id=27525

Attachment 33475: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33475&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Thanks Jian!

From bugzilla-daemon at webkit.org  Fri Jul 24 17:23:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 17:23:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27671] Add functions to
 print the glyph page trees for debugging : [Attachment 33478] Add functions
 to print the glyph page trees for debugging
In-Reply-To: <bug-27671-0@https.bugs.webkit.org/>
References: <bug-27671-0@https.bugs.webkit.org/>
Message-ID: <20090725002350.A9F3033F923E@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27671: Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/show_bug.cgi?id=27671

Attachment 33478: Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/attachment.cgi?id=33478&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 17:36:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 17:36:06 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27647] Gtk/x86_64 build
 failure after r46344 -
 "error:=?UTF-8?Q?=20invalid=20initialization=20of=20reference=20of=20type=20=E2=80=98long=20long=20int=26=E2=80=99=20from=20expression=20of=20type=20=E2=80=98int64=5Ft=E2=80=99?="
 : [Attachment 33425] patch
In-Reply-To: <bug-27647-0@https.bugs.webkit.org/>
References: <bug-27647-0@https.bugs.webkit.org/>
Message-ID: <20090725003606.7938B33F9354@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 27647: Gtk/x86_64 build failure after r46344 - "error: invalid
initialization of reference of type ?long long int&? from expression of type
?int64_t?"
https://bugs.webkit.org/show_bug.cgi?id=27647

Attachment 33425: patch
https://bugs.webkit.org/attachment.cgi?id=33425&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Kenneth fixed this already in r46353. Clearing review flag.

From bugzilla-daemon at webkit.org  Fri Jul 24 17:51:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 17:51:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27669] [chromium] Default
 UI controls for <video> has rendering problems : [Attachment 33480] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090725005137.95B7B33F94EF@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33480: patch
https://bugs.webkit.org/attachment.cgi?id=33480&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 18:08:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 18:08:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27671] Add functions to print
 the glyph page trees for debugging : [Attachment 33478] Add functions to
 print the glyph page trees for debugging
In-Reply-To: <bug-27671-0@https.bugs.webkit.org/>
References: <bug-27671-0@https.bugs.webkit.org/>
Message-ID: <20090725010808.79AB133F9689@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted mitz at webkit.org's request for review:
Bug 27671: Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/show_bug.cgi?id=27671

Attachment 33478: Add functions to print the glyph page trees for debugging
https://bugs.webkit.org/attachment.cgi?id=33478&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +#ifndef NDEBUG
> +#include "PlatformString.h"
> +#endif

I'm conflicted about how useful it is to have the #include be #ifndef'd. Maybe
it's better to not do that.

But also, declaring a function that returns a String requires only a forward
declaration, not the definition, so the include isn't needed.

> +#ifndef NDEBUG
> +#include "PlatformString.h"
> +#endif
> +
>  namespace WebCore {
>  
>  class FontPlatformData {
> @@ -107,6 +111,10 @@ public:
>  #endif
>      };
>  
> +#ifndef NDEBUG
> +    String description() const { return String(); }
> +#endif

In this case, and others like it, "PlatformString.h" is needed, but only
because the implementation is in the header. Can we put the implementation in a
.cpp file instead?

r=me, but consider a version with less PlatformString.h

From bugzilla-daemon at webkit.org  Fri Jul 24 18:34:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 18:34:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27236] Memory is not
 released back to the system from TCMalloc on Windows : [Attachment 33482]
 Patch to remove TCMALLOC_TRACK_DECOMMITED_SPANS
In-Reply-To: <bug-27236-0@https.bugs.webkit.org/>
References: <bug-27236-0@https.bugs.webkit.org/>
Message-ID: <20090725013440.DB36433F987E@gamma.macosforge.org>

Ada Chan <adachan at apple.com> has asked	for review:
Bug 27236: Memory is not released back to the system from TCMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=27236

Attachment 33482: Patch to remove TCMALLOC_TRACK_DECOMMITED_SPANS
https://bugs.webkit.org/attachment.cgi?id=33482&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 18:39:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 18:39:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27236] Memory is not released
 back to the system from TCMalloc on Windows : [Attachment 33482] Patch to
 remove TCMALLOC_TRACK_DECOMMITED_SPANS
In-Reply-To: <bug-27236-0@https.bugs.webkit.org/>
References: <bug-27236-0@https.bugs.webkit.org/>
Message-ID: <20090725013932.9DE3733F98F5@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 27236: Memory is not released back to the system from TCMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=27236

Attachment 33482: Patch to remove TCMALLOC_TRACK_DECOMMITED_SPANS
https://bugs.webkit.org/attachment.cgi?id=33482&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: JavaScriptCore/ChangeLog
> ===================================================================
> --- JavaScriptCore/ChangeLog	(revision 46386)
> +++ JavaScriptCore/ChangeLog	(working copy)
> @@ -1,3 +1,18 @@
> +2009-07-24  Ada Chan  <adachan at apple.com>
> +
> +	   In preparation for https://bugs.webkit.org/show_bug.cgi?id=27236:
> +	   Remove TCMALLOC_TRACK_DECOMMITED_SPANS.  We'll always track
decommitted spans.

It's probably worth mentioning that this was performance tested and had little
impact.

r=me

From bugzilla-daemon at webkit.org  Fri Jul 24 21:05:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 21:05:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27660] createMarkup does
 not handle CSS properly : [Attachment 33483] fixes the bug but may worsen
 the bug 26483
In-Reply-To: <bug-27660-0@https.bugs.webkit.org/>
References: <bug-27660-0@https.bugs.webkit.org/>
Message-ID: <20090725040534.564B433FA288@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27660: createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660

Attachment 33483: fixes the bug but may worsen the bug 26483
https://bugs.webkit.org/attachment.cgi?id=33483&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 21:10:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 21:10:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27329] Inspector:
 Properties Should be Sorted more Naturally : [Attachment 33484] Improved
 Comment Based on Review
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090725041034.87CB733FA2F3@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 33484: Improved Comment Based on Review
https://bugs.webkit.org/attachment.cgi?id=33484&action=review

From bugzilla-daemon at webkit.org  Fri Jul 24 21:29:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 21:29:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 14410] Dragging a resource
 in the sidebar should drag it's URL : [Attachment 33485] More Consistent
 Style
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090725042915.ADCAF33FA418@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33485: More Consistent Style
https://bugs.webkit.org/attachment.cgi?id=33485&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Changed the element to have "cursor:default" which was the behavior it had
before, but the <a> turned it into a pointer.  I think it looks nicer and more
consistent to have a the default cursor.  What do you think?

From bugzilla-daemon at webkit.org  Fri Jul 24 21:39:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 21:39:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 14410] Dragging a resource in
 the sidebar should drag it's URL : [Attachment 33485] More Consistent Style
In-Reply-To: <bug-14410-0@https.bugs.webkit.org/>
References: <bug-14410-0@https.bugs.webkit.org/>
Message-ID: <20090725043912.EA0B233FA4A2@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 14410: Dragging a resource in the sidebar should drag it's URL
https://bugs.webkit.org/show_bug.cgi?id=14410

Attachment 33485: More Consistent Style
https://bugs.webkit.org/attachment.cgi?id=33485&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Agreed.

From bugzilla-daemon at webkit.org  Fri Jul 24 23:29:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 23:29:33 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27526] Inspector: Removing an
 Attribute via Edit should Delete the Attribute,
 Not Ignore Your Changes : [Attachment 33439] Applies to ToT
In-Reply-To: <bug-27526-0@https.bugs.webkit.org/>
References: <bug-27526-0@https.bugs.webkit.org/>
Message-ID: <20090725062933.8941633FAC7D@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27526: Inspector: Removing an Attribute via Edit should Delete the
Attribute, Not Ignore Your Changes
https://bugs.webkit.org/show_bug.cgi?id=27526

Attachment 33439: Applies to ToT
https://bugs.webkit.org/attachment.cgi?id=33439&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
I added this functionality into bug 27673, which does more and includes this
feature.

From bugzilla-daemon at webkit.org  Fri Jul 24 23:49:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 24 Jul 2009 23:49:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33486] Tab Through Attributes
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090725064903.0DA1B33FAE15@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33486: Tab Through Attributes
https://bugs.webkit.org/attachment.cgi?id=33486&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Also fixes (and improves the fix) for:
https://bugs.webkit.org/show_bug.cgi?id=27526

From bugzilla-daemon at webkit.org  Sat Jul 25 00:05:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 00:05:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33487] Tab Through Attributes
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090725070539.E6D2533FAF6D@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33487: Tab Through Attributes
https://bugs.webkit.org/attachment.cgi?id=33487&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
I had forgotten the try/catch block from the earlier bug =).  All better now.

From bugzilla-daemon at webkit.org  Sat Jul 25 00:05:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 00:05:39 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33486] Tab Through Attributes
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090725070539.BD25033FAF69@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33486: Tab Through Attributes
https://bugs.webkit.org/attachment.cgi?id=33486&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
I had forgotten the try/catch block from the earlier bug =).  All better now.

From bugzilla-daemon at webkit.org  Sat Jul 25 01:34:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 01:34:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27329] Inspector: Properties
 Should be Sorted more Naturally : [Attachment 33484] Improved Comment Based
 on Review
In-Reply-To: <bug-27329-0@https.bugs.webkit.org/>
References: <bug-27329-0@https.bugs.webkit.org/>
Message-ID: <20090725083406.8946533FB504@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27329: Inspector: Properties Should be Sorted more Naturally
https://bugs.webkit.org/show_bug.cgi?id=27329

Attachment 33484: Improved Comment Based on Review
https://bugs.webkit.org/attachment.cgi?id=33484&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 01:53:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 01:53:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27674] [Gtk] Enable
 http/tests/appcache tests : [Attachment 33488] patch
In-Reply-To: <bug-27674-0@https.bugs.webkit.org/>
References: <bug-27674-0@https.bugs.webkit.org/>
Message-ID: <20090725085358.4A1A033FB6EF@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27674: [Gtk] Enable http/tests/appcache tests
https://bugs.webkit.org/show_bug.cgi?id=27674

Attachment 33488: patch
https://bugs.webkit.org/attachment.cgi?id=33488&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 02:40:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 02:40:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33489] patch
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090725094053.7E12533FBA7F@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33489: patch
https://bugs.webkit.org/attachment.cgi?id=33489&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 03:00:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 03:00:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33489] patch
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090725100029.BB74033FBC03@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33489: patch
https://bugs.webkit.org/attachment.cgi?id=33489&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 04:50:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 04:50:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27675] [WML] Make
 http/tests/wml/post-data-to-server.* more understable : [Attachment 33491]
 Initial patch
In-Reply-To: <bug-27675-0@https.bugs.webkit.org/>
References: <bug-27675-0@https.bugs.webkit.org/>
Message-ID: <20090725115024.CB1A433FC505@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27675: [WML] Make http/tests/wml/post-data-to-server.* more understable
https://bugs.webkit.org/show_bug.cgi?id=27675

Attachment 33491: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33491&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 05:38:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 05:38:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27676] [WML] WMLDoElement
 doesn't update its RenderButton object upon attach() : [Attachment 33492]
 Initial patch
In-Reply-To: <bug-27676-0@https.bugs.webkit.org/>
References: <bug-27676-0@https.bugs.webkit.org/>
Message-ID: <20090725123800.A2ABC33FCC49@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27676: [WML] WMLDoElement doesn't update its RenderButton object upon
attach()
https://bugs.webkit.org/show_bug.cgi?id=27676

Attachment 33492: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33492&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 05:52:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 05:52:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27675] [WML] Make
 http/tests/wml/post-data-to-server.* more understable : [Attachment 33491]
 Initial patch
In-Reply-To: <bug-27675-0@https.bugs.webkit.org/>
References: <bug-27675-0@https.bugs.webkit.org/>
Message-ID: <20090725125203.3E2BF33FCD4E@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27675: [WML] Make http/tests/wml/post-data-to-server.* more understable
https://bugs.webkit.org/show_bug.cgi?id=27675

Attachment 33491: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33491&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 05:55:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 05:55:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27676] [WML] WMLDoElement
 doesn't update its RenderButton object upon attach() : [Attachment 33492]
 Initial patch
In-Reply-To: <bug-27676-0@https.bugs.webkit.org/>
References: <bug-27676-0@https.bugs.webkit.org/>
Message-ID: <20090725125553.C8BB333FCDBB@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27676: [WML] WMLDoElement doesn't update its RenderButton object upon
attach()
https://bugs.webkit.org/show_bug.cgi?id=27676

Attachment 33492: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33492&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 05:58:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 05:58:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27677] [WML] Variable
 substitution is buggy : [Attachment 33493] Initial patch
In-Reply-To: <bug-27677-0@https.bugs.webkit.org/>
References: <bug-27677-0@https.bugs.webkit.org/>
Message-ID: <20090725125827.E3E4633FCDE8@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27677: [WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677

Attachment 33493: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33493&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Initial patch

From bugzilla-daemon at webkit.org  Sat Jul 25 07:12:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 07:12:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27677] [WML] Variable
 substitution is buggy : [Attachment 33493] Initial patch
In-Reply-To: <bug-27677-0@https.bugs.webkit.org/>
References: <bug-27677-0@https.bugs.webkit.org/>
Message-ID: <20090725141217.6D26833FD3C0@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27677: [WML] Variable substitution is buggy
https://bugs.webkit.org/show_bug.cgi?id=27677

Attachment 33493: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33493&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 09:33:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 09:33:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27680] [Qt] Fix build break
 after r46369 : [Attachment 33494] Proposed fix.
In-Reply-To: <bug-27680-0@https.bugs.webkit.org/>
References: <bug-27680-0@https.bugs.webkit.org/>
Message-ID: <20090725163301.8FCEF33FDF6B@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27680: [Qt] Fix build break after r46369
https://bugs.webkit.org/show_bug.cgi?id=27680

Attachment 33494: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33494&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 11:20:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 11:20:50 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27680] [Qt] Fix build break
 after r46369 : [Attachment 33494] Proposed fix.
In-Reply-To: <bug-27680-0@https.bugs.webkit.org/>
References: <bug-27680-0@https.bugs.webkit.org/>
Message-ID: <20090725182050.187D433FE896@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27680: [Qt] Fix build break after r46369
https://bugs.webkit.org/show_bug.cgi?id=27680

Attachment 33494: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33494&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 13:34:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 13:34:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs
 a way to override settings on a per-test basis : [Attachment 33495]
 Hopefully the final cut.
In-Reply-To: <bug-20534-0@https.bugs.webkit.org/>
References: <bug-20534-0@https.bugs.webkit.org/>
Message-ID: <20090725203408.8EBB833FF393@gamma.macosforge.org>

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 33495: Hopefully the final cut.
https://bugs.webkit.org/attachment.cgi?id=33495&action=review

------- Additional Comments from Dmitry Titov <dimich at chromium.org>
I think this can be the final version. I've fixed windows DRT to not break the
tests following the one with changed preferences.
Now both mac and windows versions of DRT have
'resetDefaultsToConsistentValues()' functin which is called before each test
and initializes preferences to the regular DRT 'defaults'. I also moved all the
initialization of such 'defaults' into this single function.

Run tests on both mac and windows. On windows (Vista) not all tests pass for me
even before this patch but at least the set of failed tests is the same before
and after.

From bugzilla-daemon at webkit.org  Sat Jul 25 14:31:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 14:31:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27541] Web Inspector: Split
 InspectorController into InspectorController and InspectorBackend :
 [Attachment 33418] Step 1
In-Reply-To: <bug-27541-0@https.bugs.webkit.org/>
References: <bug-27541-0@https.bugs.webkit.org/>
Message-ID: <20090725213154.C010233FF87D@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27541: Web Inspector: Split InspectorController into InspectorController
and InspectorBackend
https://bugs.webkit.org/show_bug.cgi?id=27541

Attachment 33418: Step 1
https://bugs.webkit.org/attachment.cgi?id=33418&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Clearing review flag to remove from commit queue.

From bugzilla-daemon at webkit.org  Sat Jul 25 16:42:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 16:42:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20565] Drag and drop issues
 after DOM modifications : [Attachment 33498] Patch to use
 m_documentUnderMouse instead of element->ownerDocument() when element is
 NULL.
In-Reply-To: <bug-20565-0@https.bugs.webkit.org/>
References: <bug-20565-0@https.bugs.webkit.org/>
Message-ID: <20090725234216.AFFA1340036D@gamma.macosforge.org>

Aaron Golden <aegolden at gmail.com> has asked  for review:
Bug 20565: Drag and drop issues after DOM modifications
https://bugs.webkit.org/show_bug.cgi?id=20565

Attachment 33498: Patch to use m_documentUnderMouse instead of
element->ownerDocument() when element is NULL.
https://bugs.webkit.org/attachment.cgi?id=33498&action=review

------- Additional Comments from Aaron Golden <aegolden at gmail.com>
This patch prevents the crash by avoiding using a NULL result from
elementFromPoint.  I'm not sure if this is what we want or if we should,
instead, prevent elementFromPoint from ever returning NULL in the first place.

From bugzilla-daemon at webkit.org  Sat Jul 25 16:59:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 16:59:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27685] [V8] Split up
 V8DOMMap.cpp by class : [Attachment 33499] Patch (just copy/paste)
In-Reply-To: <bug-27685-0@https.bugs.webkit.org/>
References: <bug-27685-0@https.bugs.webkit.org/>
Message-ID: <20090725235922.F30B134004BB@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27685: [V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

Attachment 33499: Patch (just copy/paste)
https://bugs.webkit.org/attachment.cgi?id=33499&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 17:02:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 17:02:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27685] [V8] Split up
 V8DOMMap.cpp by class : [Attachment 33499] Patch (just copy/paste)
In-Reply-To: <bug-27685-0@https.bugs.webkit.org/>
References: <bug-27685-0@https.bugs.webkit.org/>
Message-ID: <20090726000256.3E2E73400503@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27685: [V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

Attachment 33499: Patch (just copy/paste)
https://bugs.webkit.org/attachment.cgi?id=33499&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 17:03:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 17:03:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27685] [V8] Split up
 V8DOMMap.cpp by class : [Attachment 33500] Patch (just copy/paste)
In-Reply-To: <bug-27685-0@https.bugs.webkit.org/>
References: <bug-27685-0@https.bugs.webkit.org/>
Message-ID: <20090726000305.524CF3400514@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27685: [V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

Attachment 33500: Patch (just copy/paste)
https://bugs.webkit.org/attachment.cgi?id=33500&action=review

From bugzilla-daemon at webkit.org  Sat Jul 25 19:56:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 19:56:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25552] Support for HTML5
 Forms "pattern" attribute : [Attachment 33395] Proposed Patch, rev. 2c
In-Reply-To: <bug-25552-0@https.bugs.webkit.org/>
References: <bug-25552-0@https.bugs.webkit.org/>
Message-ID: <20090726025642.4190D3400ED5@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Michelangelo De Simone
<micdesim at gmail.com>'s request for review:
Bug 25552: Support for HTML5 Forms "pattern" attribute
https://bugs.webkit.org/show_bug.cgi?id=25552

Attachment 33395: Proposed Patch, rev. 2c
https://bugs.webkit.org/attachment.cgi?id=33395&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

From bugzilla-daemon at webkit.org  Sat Jul 25 20:12:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 20:12:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33501] v2
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090726031259.05C443400FDC@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33501: v2
https://bugs.webkit.org/attachment.cgi?id=33501&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
I haven't decided what approach I'm going to take with events yet.  I'll have
to think carefully about how it can be tied in with Chromium in a way that's
still very clean from the WebKit side of things.  Until then, I've placed
FIXME's where we're dong the frame checks.  I'll come up with a better long
term solution soon, but since we're the only implementation that would supply
NULLS, I think this is an acceptable short-term solution.

So...changed the comments in StorageAreaImpl.cpp.  Also cleaned up a bunch of
trailing whitespace because once I started I couldn't stop.

From bugzilla-daemon at webkit.org  Sat Jul 25 21:19:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sat, 25 Jul 2009 21:19:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27687] [Gtk] Refactor
 ResourceHandleSoup - make start* functions static : [Attachment 33502]
 patch
In-Reply-To: <bug-27687-0@https.bugs.webkit.org/>
References: <bug-27687-0@https.bugs.webkit.org/>
Message-ID: <20090726041933.773D334013B9@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27687: [Gtk] Refactor ResourceHandleSoup - make start* functions static
https://bugs.webkit.org/show_bug.cgi?id=27687

Attachment 33502: patch
https://bugs.webkit.org/attachment.cgi?id=33502&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 00:26:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 00:26:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33503] Tab Through CSS
 Properties (Needs First Patch)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726072626.D65323401E82@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33503: Tab Through CSS Properties (Needs First Patch)
https://bugs.webkit.org/attachment.cgi?id=33503&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
See Previous Comment for a video.

From bugzilla-daemon at webkit.org  Sun Jul 26 00:38:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 00:38:30 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33503] Tab Through CSS
 Properties (Needs First Patch)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726073830.AD3EE3401F3B@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33503: Tab Through CSS Properties (Needs First Patch)
https://bugs.webkit.org/attachment.cgi?id=33503&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Removed Excess Whitespace.

From bugzilla-daemon at webkit.org  Sun Jul 26 00:38:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 00:38:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33504] Tab Through CSS
 Properties (Needs First Patch)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726073830.D8C4D3401F3F@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33504: Tab Through CSS Properties (Needs First Patch)
https://bugs.webkit.org/attachment.cgi?id=33504&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Removed Excess Whitespace.

From bugzilla-daemon at webkit.org  Sun Jul 26 03:52:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 03:52:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 11175] Implement the
 breakpoints sidebar pane : [Attachment 33505] patch
In-Reply-To: <bug-11175-0@https.bugs.webkit.org/>
References: <bug-11175-0@https.bugs.webkit.org/>
Message-ID: <20090726105252.D0AB73402D1A@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 11175: Implement the breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=11175

Attachment 33505: patch
https://bugs.webkit.org/attachment.cgi?id=33505&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 04:45:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 04:45:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 11175] Implement the
 breakpoints sidebar pane : [Attachment 33505] patch
In-Reply-To: <bug-11175-0@https.bugs.webkit.org/>
References: <bug-11175-0@https.bugs.webkit.org/>
Message-ID: <20090726114519.278103403BD4@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has canceled Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 11175: Implement the breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=11175

Attachment 33505: patch
https://bugs.webkit.org/attachment.cgi?id=33505&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 04:45:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 04:45:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 11175] Implement the
 breakpoints sidebar pane : [Attachment 33507] same with sorting
In-Reply-To: <bug-11175-0@https.bugs.webkit.org/>
References: <bug-11175-0@https.bugs.webkit.org/>
Message-ID: <20090726114519.935C63403BD8@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 11175: Implement the breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=11175

Attachment 33507: same with sorting
https://bugs.webkit.org/attachment.cgi?id=33507&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 06:25:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 06:25:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27690] Don't override
 m_allowGeolocation set by
 ChromeClient::requestGeolocationPermissionForFrame : [Attachment 33509]
 Geolocation patch
In-Reply-To: <bug-27690-0@https.bugs.webkit.org/>
References: <bug-27690-0@https.bugs.webkit.org/>
Message-ID: <20090726132538.3DD6D3404630@gamma.macosforge.org>

Kwang Yul Seo <kwangyul.seo at gmail.com> has asked  for review:
Bug 27690: Don't override m_allowGeolocation set by
ChromeClient::requestGeolocationPermissionForFrame
https://bugs.webkit.org/show_bug.cgi?id=27690

Attachment 33509: Geolocation patch
https://bugs.webkit.org/attachment.cgi?id=33509&action=review

------- Additional Comments from Kwang Yul Seo <kwangyul.seo at gmail.com>
Don't override m_allowGeolocation.

From bugzilla-daemon at webkit.org  Sun Jul 26 07:05:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 07:05:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33504] Tab Through CSS
 Properties (Needs First Patch)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726140552.14E0934049AB@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33504: Tab Through CSS Properties (Needs First Patch)
https://bugs.webkit.org/attachment.cgi?id=33504&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
I found a way to eliminate firing the "dblclick" event in one case and just
directly start editing (thanks to bug 18224's patch from way back when).  This
case is for the new property and there is no text to select. I might even
eventually do the same for the condition (tabbing to a non-new attribute), but
for right now its fine, because it gets to specifically pick something to have
selected when starting to edit.

From bugzilla-daemon at webkit.org  Sun Jul 26 07:05:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 07:05:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33510] Tab Through CSS
 Properties (Needs First Patch)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726140552.3D8A034049AF@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33510: Tab Through CSS Properties (Needs First Patch)
https://bugs.webkit.org/attachment.cgi?id=33510&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
I found a way to eliminate firing the "dblclick" event in one case and just
directly start editing (thanks to bug 18224's patch from way back when).  This
case is for the new property and there is no text to select. I might even
eventually do the same for the condition (tabbing to a non-new attribute), but
for right now its fine, because it gets to specifically pick something to have
selected when starting to edit.

From bugzilla-daemon at webkit.org  Sun Jul 26 07:31:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 07:31:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 11175] Implement the
 breakpoints sidebar pane : [Attachment 33507] same with sorting
In-Reply-To: <bug-11175-0@https.bugs.webkit.org/>
References: <bug-11175-0@https.bugs.webkit.org/>
Message-ID: <20090726143120.836E03404B89@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 11175: Implement the breakpoints sidebar pane
https://bugs.webkit.org/show_bug.cgi?id=11175

Attachment 33507: same with sorting
https://bugs.webkit.org/attachment.cgi?id=33507&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Awesome!

From bugzilla-daemon at webkit.org  Sun Jul 26 07:36:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 07:36:50 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27673] Inspector: Tab Through
 Attributes When Editing : [Attachment 33487] Tab Through Attributes
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726143650.7F09F3404C01@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33487: Tab Through Attributes
https://bugs.webkit.org/attachment.cgi?id=33487&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>

> +		  
attributeElements[i].nextSibling.nextSibling.dispatchEvent(event); // "="
textNode, then the "webkit-html-attribute-value" node

All looks fine except this. I fear this is too fragile. It would be better to
loop through the next siblings until you found "webkit-html-attribute-value".

From bugzilla-daemon at webkit.org  Sun Jul 26 07:46:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 07:46:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27673] Inspector: Tab Through
 Attributes When Editing : [Attachment 33510] Tab Through CSS Properties
 (Needs First Patch)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726144610.3D4F73404CD9@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33510: Tab Through CSS Properties (Needs First Patch)
https://bugs.webkit.org/attachment.cgi?id=33510&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +		   if (elem.className === "name") {

This would be safer as "elem.hasStyleClass("name")" so if we add more to the
className later it still works.

> +	       // Find the attribute we were supposed to start editing in this
section
> +	       var list =
section.propertiesTreeOutline._childrenListNode.childNodes;
> +	       for (var i = 0, len = list.length; i < len; ++i) {
> +		   var listItem = list[i];
> +		   var spans = listItem.getElementsByTagName("span");
> +		   if (spans[0].textContent === nameOfPropretyToEdit) {
> +		       var event = document.createEvent("MouseEvents");
> +		       event.initMouseEvent("dblclick", true, true);
> +		       spans[1].dispatchEvent(event); // the value
> +		       return;
> +		   }
> +	       }
> +	   }

Over all these patches look good, but I think they are too low level and
fragile at this point. They are working with the DOM too much when they should
just be working with the high-level TreeElements and TreeOutlines. This would
require additions to StylePropertyTreeElement like "editName" or "editValue"
that would start editing on one of the parts without the need for a fake event
and getElementsByTagName or using private properties like _childrenListNode.

From bugzilla-daemon at webkit.org  Sun Jul 26 10:15:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 10:15:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33511] Tab Through
 Attributes/Properties (BOTH)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726171510.02E43340596D@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33511: Tab Through Attributes/Properties (BOTH)
https://bugs.webkit.org/attachment.cgi?id=33511&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Both patches together.

From bugzilla-daemon at webkit.org  Sun Jul 26 10:27:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 10:27:24 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33511] Tab Through
 Attributes/Properties (BOTH)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726172724.B8E613405A94@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33511: Tab Through Attributes/Properties (BOTH)
https://bugs.webkit.org/attachment.cgi?id=33511&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Sorry about the spam, I had forgotten a Changelog.

From bugzilla-daemon at webkit.org  Sun Jul 26 10:27:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 10:27:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27673] Inspector: Tab
 Through Attributes When Editing : [Attachment 33512] Tab Through
 Attributes/Properties (BOTH)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726172725.0853E3405A98@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33512: Tab Through Attributes/Properties (BOTH)
https://bugs.webkit.org/attachment.cgi?id=33512&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
Sorry about the spam, I had forgotten a Changelog.

From bugzilla-daemon at webkit.org  Sun Jul 26 10:38:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 10:38:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27673] Inspector: Tab Through
 Attributes When Editing : [Attachment 33512] Tab Through
 Attributes/Properties (BOTH)
In-Reply-To: <bug-27673-0@https.bugs.webkit.org/>
References: <bug-27673-0@https.bugs.webkit.org/>
Message-ID: <20090726173818.0ACF13405B84@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27673: Inspector: Tab Through Attributes When Editing
https://bugs.webkit.org/show_bug.cgi?id=27673

Attachment 33512: Tab Through Attributes/Properties (BOTH)
https://bugs.webkit.org/attachment.cgi?id=33512&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 11:15:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 11:15:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27691] WebCore bindings:
 Implement ScriptArray bindings. : [Attachment 33513] patch
In-Reply-To: <bug-27691-0@https.bugs.webkit.org/>
References: <bug-27691-0@https.bugs.webkit.org/>
Message-ID: <20090726181536.921033405EC7@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27691: WebCore bindings: Implement ScriptArray bindings.
https://bugs.webkit.org/show_bug.cgi?id=27691

Attachment 33513: patch
https://bugs.webkit.org/attachment.cgi?id=33513&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 11:41:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 11:41:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27691] WebCore bindings:
 Implement ScriptArray bindings. : [Attachment 33513] patch
In-Reply-To: <bug-27691-0@https.bugs.webkit.org/>
References: <bug-27691-0@https.bugs.webkit.org/>
Message-ID: <20090726184155.D24E93406135@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27691: WebCore bindings: Implement ScriptArray bindings.
https://bugs.webkit.org/show_bug.cgi?id=27691

Attachment 33513: patch
https://bugs.webkit.org/attachment.cgi?id=33513&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 12:26:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 12:26:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop
 support : [Attachment 33515] Third patch
In-Reply-To: <bug-23642-0@https.bugs.webkit.org/>
References: <bug-23642-0@https.bugs.webkit.org/>
Message-ID: <20090726192647.40F943406602@gamma.macosforge.org>

Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 33515: Third patch
https://bugs.webkit.org/attachment.cgi?id=33515&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
Improved!
Removed some debugging leftovers, some ref counting love added.

From bugzilla-daemon at webkit.org  Sun Jul 26 12:28:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 12:28:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop
 support : [Attachment 33516] DragClipboard patch
In-Reply-To: <bug-23642-0@https.bugs.webkit.org/>
References: <bug-23642-0@https.bugs.webkit.org/>
Message-ID: <20090726192835.59BD03406641@gamma.macosforge.org>

Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 33516: DragClipboard patch
https://bugs.webkit.org/attachment.cgi?id=33516&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
Fixed indent in the header file.

From bugzilla-daemon at webkit.org  Sun Jul 26 21:44:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 21:44:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27695] There are many DOM
 Storage corner cases the layout tests don't currently cover. : [Attachment
 33517] v1
In-Reply-To: <bug-27695-0@https.bugs.webkit.org/>
References: <bug-27695-0@https.bugs.webkit.org/>
Message-ID: <20090727044423.5570934090ED@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27695: There are many DOM Storage corner cases the layout tests don't
currently cover.
https://bugs.webkit.org/show_bug.cgi?id=27695

Attachment 33517: v1
https://bugs.webkit.org/attachment.cgi?id=33517&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Add some checks to existing layout tests.

From bugzilla-daemon at webkit.org  Sun Jul 26 21:59:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 21:59:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33518] The right one
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090727045928.E8CAA340925B@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33518: The right one
https://bugs.webkit.org/attachment.cgi?id=33518&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 22:08:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 22:08:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33518] The right one
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090727050837.7ADB9340930D@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has canceled anton muhin
<antonm at chromium.org>'s request for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33518: The right one
https://bugs.webkit.org/attachment.cgi?id=33518&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 22:08:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 22:08:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33519] Fixing a minor type (should have
 used plural)
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090727050837.9AECA340930F@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33519: Fixing a minor type (should have used plural)
https://bugs.webkit.org/attachment.cgi?id=33519&action=review

From bugzilla-daemon at webkit.org  Sun Jul 26 22:19:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 22:19:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27628] [v8] Simplify weak
 handlers callback : [Attachment 33519] Fixing a minor type (should have
 used plural)
In-Reply-To: <bug-27628-0@https.bugs.webkit.org/>
References: <bug-27628-0@https.bugs.webkit.org/>
Message-ID: <20090727051921.087EC34093DF@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 27628: [v8] Simplify weak handlers callback
https://bugs.webkit.org/show_bug.cgi?id=27628

Attachment 33519: Fixing a minor type (should have used plural)
https://bugs.webkit.org/attachment.cgi?id=33519&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This is great.	Thanks for iterating on this.

From bugzilla-daemon at webkit.org  Sun Jul 26 22:58:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Sun, 26 Jul 2009 22:58:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33520]
 Patch
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090727055805.00C70340970C@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33520: Patch
https://bugs.webkit.org/attachment.cgi?id=33520&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 00:11:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 00:11:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18027] CSS3 Selector Test:
 combination of hover and multiple chained sibling selector fails in Webkit
 : [Attachment 33521] hover-adjacent-v1
In-Reply-To: <bug-18027-0@https.bugs.webkit.org/>
References: <bug-18027-0@https.bugs.webkit.org/>
Message-ID: <20090727071139.674913409CB6@gamma.macosforge.org>

Yusuke Sato <yusukes at chromium.org> has asked  for review:
Bug 18027: CSS3 Selector Test: combination of hover and multiple chained
sibling selector fails in Webkit
https://bugs.webkit.org/show_bug.cgi?id=18027

Attachment 33521: hover-adjacent-v1
https://bugs.webkit.org/attachment.cgi?id=33521&action=review

------- Additional Comments from Yusuke Sato <yusukes at chromium.org>

---
 15 files changed, 299 insertions(+), 5 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 00:41:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 00:41:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27697] WorkerThread needs
 to be refactored to separate out dedicated-worker functionality :
 [Attachment 33522] proposed patch
In-Reply-To: <bug-27697-0@https.bugs.webkit.org/>
References: <bug-27697-0@https.bugs.webkit.org/>
Message-ID: <20090727074126.6C8723409F0A@gamma.macosforge.org>

Andrew Wilson <atwilson at google.com> has asked  for review:
Bug 27697: WorkerThread needs to be refactored to separate out dedicated-worker
functionality
https://bugs.webkit.org/show_bug.cgi?id=27697

Attachment 33522: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33522&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 01:09:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 01:09:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27626] To allow disabling
 DataGrid,
 conditionalize its files in DerivedSourcesAllInOne : [Attachment 33383] Now
 with changelog entry, duh
In-Reply-To: <bug-27626-0@https.bugs.webkit.org/>
References: <bug-27626-0@https.bugs.webkit.org/>
Message-ID: <20090727080915.722FC340A1D1@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled Jens Alfke <snej at chromium.org>'s
request for review:
Bug 27626: To allow disabling DataGrid, conditionalize its files in
DerivedSourcesAllInOne
https://bugs.webkit.org/show_bug.cgi?id=27626

Attachment 33383: Now with changelog entry, duh
https://bugs.webkit.org/attachment.cgi?id=33383&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r? per snej's comment in bug.

From bugzilla-daemon at webkit.org  Mon Jul 27 01:41:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 01:41:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27699] Would be nice if
 build-webkit on Mac respected WEBKITOUTPUTDIR and set SYMROOT/OBJROOT
 accordingly : [Attachment
 33523]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27699-0@https.bugs.webkit.org/>
References: <bug-27699-0@https.bugs.webkit.org/>
Message-ID: <20090727084140.43CFC340A4F9@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27699: Would be nice if build-webkit on Mac respected WEBKITOUTPUTDIR and
set SYMROOT/OBJROOT accordingly
https://bugs.webkit.org/show_bug.cgi?id=27699

Attachment 33523: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33523&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

build-webkit: Reorder logic for determining the baseProductDir

https://bugs.webkit.org/show_bug.cgi?id=27699

We now do port-spesific probing for the product dir first, and then
fall back to either the generic WEBKITOUTPUTDIR (which now also works
on Mac), or WebKitBuild.

Then we add the git branch if the git branch build option is enabled.

Finally we massage the product dir based on the port. For example the
Mac port will now always set the SYMROOT and OBJROOT configuration for
XCode.

* Scripts/webkitdirs.pm:
---
 2 files changed, 40 insertions(+), 25 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 01:53:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 01:53:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27700] Visual Studio
 project files should support building WebKit out-of-tree (shadow build) :
 [Attachment 33524] WebCore:
In-Reply-To: <bug-27700-0@https.bugs.webkit.org/>
References: <bug-27700-0@https.bugs.webkit.org/>
Message-ID: <20090727085322.3CF16340A5FF@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27700: Visual Studio project files should support building WebKit
out-of-tree (shadow build)
https://bugs.webkit.org/show_bug.cgi?id=27700

Attachment 33524: WebCore:
https://bugs.webkit.org/attachment.cgi?id=33524&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>

Reviewed by NOBODY (OOPS!).

Add output directory for VS pre-build steps to enable out-of-tree builds

https://bugs.webkit.org/show_bug.cgi?id=27700

The tmp.obj file is now placed in the intermediate build directory.

* WebCore.vcproj/WebCoreCommon.vsprops:

WebKit/win:

2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>

Reviewed by NOBODY (OOPS!).

Add output directory for VS pre-build steps to enable out-of-tree builds

https://bugs.webkit.org/show_bug.cgi?id=27700

The tmp.obj file is now placed in the intermediate build directory.

* WebKit.vcproj/WebKit.vcproj:
---
 4 files changed, 30 insertions(+), 6 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 02:06:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 02:06:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33525] oops
 tabs
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090727090627.8BC89340A742@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33525: oops tabs
https://bugs.webkit.org/attachment.cgi?id=33525&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 02:06:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 02:06:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33520]
 Patch
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090727090627.60B00340A73E@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33520: Patch
https://bugs.webkit.org/attachment.cgi?id=33520&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 02:14:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 02:14:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27702] [Qt] Buildfix on
 Windows : [Attachment 33526] proposed patch
In-Reply-To: <bug-27702-0@https.bugs.webkit.org/>
References: <bug-27702-0@https.bugs.webkit.org/>
Message-ID: <20090727091439.D9C6A340A827@gamma.macosforge.org>

Csaba Osztrogon?c <oszi at inf.u-szeged.hu> has asked  for review:
Bug 27702: [Qt] Buildfix on Windows
https://bugs.webkit.org/show_bug.cgi?id=27702

Attachment 33526: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33526&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 02:34:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 02:34:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27701] [V8] Teach
 V8Proxy::context about isolated worlds : [Attachment 33527] patch
In-Reply-To: <bug-27701-0@https.bugs.webkit.org/>
References: <bug-27701-0@https.bugs.webkit.org/>
Message-ID: <20090727093426.159EC340A9FC@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27701: [V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701

Attachment 33527: patch
https://bugs.webkit.org/attachment.cgi?id=33527&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 02:42:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 02:42:24 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27701] [V8] Teach
 V8Proxy::context about isolated worlds : [Attachment 33527] patch
In-Reply-To: <bug-27701-0@https.bugs.webkit.org/>
References: <bug-27701-0@https.bugs.webkit.org/>
Message-ID: <20090727094224.20C91340AB0B@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27701: [V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701

Attachment 33527: patch
https://bugs.webkit.org/attachment.cgi?id=33527&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 02:42:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 02:42:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27701] [V8] Teach
 V8Proxy::context about isolated worlds : [Attachment 33528] patch
In-Reply-To: <bug-27701-0@https.bugs.webkit.org/>
References: <bug-27701-0@https.bugs.webkit.org/>
Message-ID: <20090727094231.87266340AB2E@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27701: [V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701

Attachment 33528: patch
https://bugs.webkit.org/attachment.cgi?id=33528&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 03:18:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 03:18:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27704] Refactor the first
 step of layout in RenderFlexibleBox.cpp : [Attachment 33529] Patch v1
In-Reply-To: <bug-27704-0@https.bugs.webkit.org/>
References: <bug-27704-0@https.bugs.webkit.org/>
Message-ID: <20090727101824.A9870340AFF1@gamma.macosforge.org>

Shinichiro Hamaji <hamaji at chromium.org> has asked  for review:
Bug 27704: Refactor the first step of layout in RenderFlexibleBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=27704

Attachment 33529: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33529&action=review

------- Additional Comments from Shinichiro Hamaji <hamaji at chromium.org>

---
 2 files changed, 44 insertions(+), 41 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 03:36:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 03:36:38 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27702] [Qt] Buildfix on
 Windows : [Attachment 33526] proposed patch
In-Reply-To: <bug-27702-0@https.bugs.webkit.org/>
References: <bug-27702-0@https.bugs.webkit.org/>
Message-ID: <20090727103638.AC5C3340B521@gamma.macosforge.org>

Csaba Osztrogon?c <oszi at inf.u-szeged.hu> has canceled Csaba Osztrogon?c
<oszi at inf.u-szeged.hu>'s request for review:
Bug 27702: [Qt] Buildfix on Windows
https://bugs.webkit.org/show_bug.cgi?id=27702

Attachment 33526: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33526&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 03:36:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 03:36:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27702] [Qt] Buildfix on
 Windows : [Attachment 33530] proposed patch
In-Reply-To: <bug-27702-0@https.bugs.webkit.org/>
References: <bug-27702-0@https.bugs.webkit.org/>
Message-ID: <20090727103638.C7FE9340B525@gamma.macosforge.org>

Csaba Osztrogon?c <oszi at inf.u-szeged.hu> has asked  for review:
Bug 27702: [Qt] Buildfix on Windows
https://bugs.webkit.org/show_bug.cgi?id=27702

Attachment 33530: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33530&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 03:38:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 03:38:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27702] [Qt] Buildfix on
 Windows : [Attachment 33530] proposed patch
In-Reply-To: <bug-27702-0@https.bugs.webkit.org/>
References: <bug-27702-0@https.bugs.webkit.org/>
Message-ID: <20090727103845.B2FC9340B5B5@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Csaba Osztrogon?c
<oszi at inf.u-szeged.hu>'s request for review:
Bug 27702: [Qt] Buildfix on Windows
https://bugs.webkit.org/show_bug.cgi?id=27702

Attachment 33530: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33530&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Thanks!

From bugzilla-daemon at webkit.org  Mon Jul 27 03:56:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 03:56:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27255] Geolocation
 incorrectly calls error callback in case of exception in success callback :
 [Attachment 33531] Patch
In-Reply-To: <bug-27255-0@https.bugs.webkit.org/>
References: <bug-27255-0@https.bugs.webkit.org/>
Message-ID: <20090727105651.0E31A340BA50@gamma.macosforge.org>

steveblock at google.com has asked  for review:
Bug 27255: Geolocation incorrectly calls error callback in case of exception in
success callback
https://bugs.webkit.org/show_bug.cgi?id=27255

Attachment 33531: Patch
https://bugs.webkit.org/attachment.cgi?id=33531&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 04:15:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 04:15:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27255] Geolocation
 incorrectly calls error callback in case of exception in success callback :
 [Attachment 33532] Patch for bug 27255
In-Reply-To: <bug-27255-0@https.bugs.webkit.org/>
References: <bug-27255-0@https.bugs.webkit.org/>
Message-ID: <20090727111542.36D55340BD10@gamma.macosforge.org>

steveblock at google.com has asked  for review:
Bug 27255: Geolocation incorrectly calls error callback in case of exception in
success callback
https://bugs.webkit.org/show_bug.cgi?id=27255

Attachment 33532: Patch for bug 27255
https://bugs.webkit.org/attachment.cgi?id=33532&action=review

------- Additional Comments from steveblock at google.com
Fixed ChangeLog to add bug URL and brief explanation of changes.

From bugzilla-daemon at webkit.org  Mon Jul 27 04:15:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 04:15:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27255] Geolocation
 incorrectly calls error callback in case of exception in success callback :
 [Attachment 33531] Patch
In-Reply-To: <bug-27255-0@https.bugs.webkit.org/>
References: <bug-27255-0@https.bugs.webkit.org/>
Message-ID: <20090727111541.F0808340BD0C@gamma.macosforge.org>

steveblock at google.com has canceled steveblock at google.com's request for review:
Bug 27255: Geolocation incorrectly calls error callback in case of exception in
success callback
https://bugs.webkit.org/show_bug.cgi?id=27255

Attachment 33531: Patch
https://bugs.webkit.org/attachment.cgi?id=33531&action=review

------- Additional Comments from steveblock at google.com
Fixed ChangeLog to add bug URL and brief explanation of changes.

From bugzilla-daemon at webkit.org  Mon Jul 27 04:37:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 04:37:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27705] Fix Chromium build
 breakage introduced in 46388 : [Attachment 33533] build fix
In-Reply-To: <bug-27705-0@https.bugs.webkit.org/>
References: <bug-27705-0@https.bugs.webkit.org/>
Message-ID: <20090727113701.C35E4340BF18@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27705: Fix Chromium build breakage introduced in 46388
https://bugs.webkit.org/show_bug.cgi?id=27705

Attachment 33533: build fix
https://bugs.webkit.org/attachment.cgi?id=33533&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 06:10:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:10:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27708] class/struct mixup
 in forward declarations : [Attachment 33534] Proposed patch.
In-Reply-To: <bug-27708-0@https.bugs.webkit.org/>
References: <bug-27708-0@https.bugs.webkit.org/>
Message-ID: <20090727131050.09268340C910@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27708: class/struct mixup in forward declarations
https://bugs.webkit.org/show_bug.cgi?id=27708

Attachment 33534: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33534&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 06:13:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:13:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27708] class/struct mixup in
 forward declarations : [Attachment 33534] Proposed patch.
In-Reply-To: <bug-27708-0@https.bugs.webkit.org/>
References: <bug-27708-0@https.bugs.webkit.org/>
Message-ID: <20090727131308.98A35340C996@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27708: class/struct mixup in forward declarations
https://bugs.webkit.org/show_bug.cgi?id=27708

Attachment 33534: Proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33534&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 06:16:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:16:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment
 33535]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090727131607.CB1A5340C9FD@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33535: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33535&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Refactor the common parts out of PluginView::init() and add platformInit()

https://bugs.webkit.org/show_bug.cgi?id=27706

PluginViewMac used to call stop() in some cases, but this error handling
should be unified across the different implementations, so removing for now.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

* plugins/PluginView.cpp:
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::init):
(WebCore::PluginView::bindingInstance):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformInit):
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 8 files changed, 71 insertions(+), 100 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 06:16:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:16:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment
 33536]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090727131633.105DF340CA0A@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33536: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33536&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Join the various versions of PluginView::stop() into one shared implementation

https://bugs.webkit.org/show_bug.cgi?id=27706

The platform-dependent bits are now ifdef'ed in the shared implementation,
using the XP_ defines (XP_WIN, XP_MACOSX, XP_UNIX) from npapi.h

Differences to the original implementation are as follows:

- The Qt port unregistered the plugin before calling NP_SetWindow
with a 0 window handle. Now it's done after (similar to Win)

- The GTK and Qt ports unregistered the plugin before clearing
the m_npWindow.ws_info struct. Now it's done after.

- The Win port constructed the DropAllLocks after unsubclassing
the window. Now it's done before.

- The Mac, Qt, and GTK ports did not pass a NPSavedData struct
to NP_Destroy (like the Win port). Now all ports do.

- The Win port did not call PluginView::setCurrentPluginView()
before calling to NP-functions. Now it does.

* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::~PluginView):
(WebCore::PluginView::stop):
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::getValueStatic):
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::handlePostReadFile):
---
 7 files changed, 110 insertions(+), 181 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 06:16:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:16:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment
 33537]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090727131649.1636D340CA27@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33537: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33537&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Unregister plugin from PluginMainThreadScheduler if NPP_New fails

https://bugs.webkit.org/show_bug.cgi?id=27706

Since the plugin has not been started yet (m_isStarted is not set),
calling stop() will not have any affect, so we manually unregister
in start() before returning.

* plugins/PluginView.cpp:
(WebCore::PluginView::start):
---
 2 files changed, 18 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 06:17:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:17:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment
 33538]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090727131708.F3F30340CA34@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33538: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33538&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Join the various PluginView destructors into one shared implementation

https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

- The Mac port does not set m_window to 0 anymore.

- The Qt port used to delete the platform plugin widget as
the last step. Now this is done before cleaning up the
script objects and unloading the plugin package (like
the Win port).

* plugins/PluginView.cpp:
(WebCore::PluginView::~PluginView):
* plugins/PluginViewNone.cpp:
(WebCore::PluginView::updatePluginWidget):
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::platformInit):
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::platformInit):
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::init):
---
 7 files changed, 59 insertions(+), 74 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 06:17:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:17:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment
 33539]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090727131728.E2B2B340CA47@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33539: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33539&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Share implementation of PluginView::userAgent() and userAgentStatic()

https://bugs.webkit.org/show_bug.cgi?id=27706

Differences to the original implementation are as follows:

- The Win port used to return 0 for userAgentStatic, but now
returns the quirk mode MozillaUserAgent as the other ports.

* plugins/PluginView.cpp:
(WebCore::PluginView::userAgent):
(WebCore::PluginView::userAgentStatic):
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 7 files changed, 49 insertions(+), 87 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 06:19:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:19:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33435] When clearing the plugin
 database, clear also the timestamp map.
Message-ID: <20090727131902.86F47340CA83@gamma.macosforge.org>

X-Bugzilla-Type: request
In-Reply-To: <bug-27651-0 at https.bugs.webkit.org/>
References: <bug-27651-0 at https.bugs.webkit.org/>

Adam Treat <treat at kde.org> has granted Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33435: When clearing the plugin database, clear also the timestamp
map.

https://bugs.webkit.org/attachment.cgi?id=33435&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 06:27:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:27:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment
 33540]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090727132720.34CF2340CB74@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has asked  for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33540: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33540&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Reviewed by NOBODY (OOPS!).

Refactor the common parts out of PluginView::init() and add platformInit()

https://bugs.webkit.org/show_bug.cgi?id=27706

PluginViewMac used to call stop() in some cases, but this error handling
should be unified across the different implementations, so removing for now.

m_hasPendingGeometryChange is now initialized in the initializer list
instead of in PluginViewQt's init()

* plugins/PluginView.cpp:
(WebCore::PluginView::handleEvent):
(WebCore::PluginView::init):
(WebCore::PluginView::bindingInstance):
* plugins/PluginView.h:
* plugins/PluginViewNone.cpp:
* plugins/gtk/PluginViewGtk.cpp:
* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::platformInit):
* plugins/qt/PluginViewQt.cpp:
* plugins/win/PluginViewWin.cpp:
---
 8 files changed, 71 insertions(+), 100 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 06:27:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:27:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment 33535] Refactor the
 common parts out of PluginView::init() and add platformInit()
Message-ID: <20090727132756.3498E340CBA2@gamma.macosforge.org>

X-Bugzilla-Type: request
In-Reply-To: <bug-27706-0 at https.bugs.webkit.org/>
References: <bug-27706-0 at https.bugs.webkit.org/>

Tor Arne Vestb? <vestbo at webkit.org> has canceled Tor Arne Vestb?
<vestbo at webkit.org>'s request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33535: Refactor the common parts out of PluginView::init() and add
platformInit()

https://bugs.webkit.org/attachment.cgi?id=33535&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 06:35:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 06:35:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27709] [Qt] Disable some
 compiler warnings for the win build : [Attachment 33541] proposed patch.
In-Reply-To: <bug-27709-0@https.bugs.webkit.org/>
References: <bug-27709-0@https.bugs.webkit.org/>
Message-ID: <20090727133509.BB6C9340CC63@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27709: [Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709

Attachment 33541: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33541&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 07:05:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 07:05:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27711] SVG Filter need
 feColorMatrix implementation : [Attachment 33543] SVG
 feColorMatrix-implementation
In-Reply-To: <bug-27711-0@https.bugs.webkit.org/>
References: <bug-27711-0@https.bugs.webkit.org/>
Message-ID: <20090727140523.4DCA3340D038@gamma.macosforge.org>

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 27711: SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Attachment 33543: SVG feColorMatrix-implementation
https://bugs.webkit.org/attachment.cgi?id=33543&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This is the implementation  of feColorMatrix.

From bugzilla-daemon at webkit.org  Mon Jul 27 07:09:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 07:09:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 33544] Re-apply (unrevert) the patch.
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090727140950.B22C1340D0C5@gamma.macosforge.org>

Stephen White <senorblanco at chromium.org> has asked David Levin
<levin at chromium.org> for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 33544: Re-apply (unrevert) the patch.
https://bugs.webkit.org/attachment.cgi?id=33544&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 07:36:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 07:36:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33545] the patch
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727143649.0F741340D404@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33545: the patch
https://bugs.webkit.org/attachment.cgi?id=33545&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 07:48:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 07:48:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27713] WINCE port: make plugin
 work for wince : [Attachment 33545] the patch
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727144804.B341B340D547@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33545: the patch
https://bugs.webkit.org/attachment.cgi?id=33545&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +DWORD SHGetValue(HKEY hkey, LPCWSTR pszSubKey, LPCWSTR pszValue, LPDWORD
pdwType, LPVOID pvData, LPDWORD pcbData)
> +{
> +    HKEY key;
> +	if (RegOpenKeyEx(hkey, pszSubKey, 0, 0, &key) == ERROR_SUCCESS) {
> +	   DWORD result = RegQueryValueEx(key, pszValue, 0, pdwType,
(LPBYTE)pvData, pcbData);
> +	   RegCloseKey(key);
> +	   return result;
> +	}
> +    return ERROR_INVALID_NAME;
> +}

  Tabs should be removed.


>      HKEY key;
> +#if PLATFORM(WINCE)
> +    HRESULT result = RegOpenKeyExW(rootKey, L"Software\\MozillaPlugins", 0,
0, &key);
> +#else
>      HRESULT result = RegOpenKeyExW(rootKey, L"Software\\MozillaPlugins", 0,
KEY_ENUMERATE_SUB_KEYS, &key);
> +#endif

   Does it make more sense to #define KEY_ENUMERATE_SUB_KEYS if it's not
available?

>  static inline void addWindowsMediaPlayerPluginDirectory(Vector<String>&
directories)
>  {
> +#if PLATFORM(WINCE)
> +#else
   Change to #if !PLATFORM(WINCE)

>  static inline void addMacromediaPluginDirectories(Vector<String>&
directories)
>  {
> +#if PLATFORM(WINCE)
> +    directories.append("\\Windows\\System\\macromed\\Flash");
> +#else

   Is this valid?

> -    NP_Initialize = (NP_InitializeFuncPtr)GetProcAddress(m_module,
"NP_Initialize");
> -    NP_GetEntryPoints = (NP_GetEntryPointsFuncPtr)GetProcAddress(m_module,
"NP_GetEntryPoints");
> -    m_NPP_Shutdown = (NPP_ShutdownProcPtr)GetProcAddress(m_module,
"NP_Shutdown");
> +    NP_Initialize = (NP_InitializeFuncPtr)GetProcAddress(m_module,
_T("NP_Initialize"));
> +    NP_GetEntryPoints = (NP_GetEntryPointsFuncPtr)GetProcAddress(m_module,
_T("NP_GetEntryPoints"));
> +    m_NPP_Shutdown = (NPP_ShutdownProcPtr)GetProcAddress(m_module,
_T("NP_Shutdown"));

   Will this not affect the Win32 build?
 
> @@ -264,6 +284,10 @@ static bool isWindowsMessageUserGesture(UINT message)
>  LRESULT
>  PluginView::wndProc(HWND hWnd, UINT message, WPARAM wParam, LPARAM lParam)
>  {
> +#if PLATFORM(WINCE)
> +    if (!m_pluginWndProc)
> +	   return 1;
> +#endif

   Can this be unconditional on WINCE?

> +#if PLATFORM(WINCE)
> +    m_windowRect = frameView->contentsToWindow(frameRect());
> +#else
>      m_windowRect =
IntRect(frameView->contentsToWindow(frameRect().location()),
frameRect().size());
> +#endif

   The difference here concerns me.

> @@ -491,15 +525,24 @@ void PluginView::paint(GraphicsContext* context, const
IntRect& rect)
>      m_npWindow.type = NPWindowTypeDrawable;
>      m_npWindow.window = hdc;
>  
> -    IntPoint p =
static_cast<FrameView*>(parent())->contentsToWindow(frameRect().location());
> -    
>      WINDOWPOS windowpos;
>      memset(&windowpos, 0, sizeof(windowpos));
>  
> +#if PLATFORM(WINCE)
> +    IntRect r =
static_cast<FrameView*>(parent())->contentsToWindow(frameRect());
> +    
> +    windowpos.x = r.x();
> +    windowpos.y = r.y();
> +    windowpos.cx = r.width();
> +    windowpos.cy = r.height();
> +#else
> +    IntPoint p =
static_cast<FrameView*>(parent())->contentsToWindow(frameRect().location());
> +    
>      windowpos.x = p.x();
>      windowpos.y = p.y();
>      windowpos.cx = frameRect().width();
>      windowpos.cy = frameRect().height();
> +#endif

  Likewise.  Why are the coordinates behaving so differently?
> @@ -697,14 +770,24 @@ void PluginView::stop()
>  
>      ASSERT(m_streams.isEmpty());
>  
> +    if (m_manualStream)
> +	   m_manualStream->stop();
> +
>      m_isStarted = false;

   This looks like it will affect the Win32 case.  Should probably be checked
in separately if it's valid there too.

>  #if PLATFORM(WIN_OS) && PLATFORM(QT)
>	   m_window = window;
>  #else
>	   setPlatformWidget(window);
> +	   m_isWindowed = true;
>  #endif

   Same here.

From bugzilla-daemon at webkit.org  Mon Jul 27 08:06:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:06:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27705] Fix Chromium build
 breakage introduced in 46388 : [Attachment 33533] build fix
In-Reply-To: <bug-27705-0@https.bugs.webkit.org/>
References: <bug-27705-0@https.bugs.webkit.org/>
Message-ID: <20090727150631.13833340D716@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27705: Fix Chromium build breakage introduced in 46388
https://bugs.webkit.org/show_bug.cgi?id=27705

Attachment 33533: build fix
https://bugs.webkit.org/attachment.cgi?id=33533&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
r=me

From bugzilla-daemon at webkit.org  Mon Jul 27 08:13:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:13:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 33448] Revert of previous patch.
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090727151353.085F3340D7F8@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 33448: Revert of previous patch.
https://bugs.webkit.org/attachment.cgi?id=33448&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing the r+ since this patch was applied (and the bug has ben re-opened).

From bugzilla-daemon at webkit.org  Mon Jul 27 08:16:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:16:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27388] [Chromium] CSS
 dotted/dashed borders in Chromium/skia are generally hosed : [Attachment
 33544] Re-apply (unrevert) the patch.
In-Reply-To: <bug-27388-0@https.bugs.webkit.org/>
References: <bug-27388-0@https.bugs.webkit.org/>
Message-ID: <20090727151613.C731B340D846@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 27388: [Chromium] CSS dotted/dashed borders in Chromium/skia are generally
hosed
https://bugs.webkit.org/show_bug.cgi?id=27388

Attachment 33544: Re-apply (unrevert) the patch.
https://bugs.webkit.org/attachment.cgi?id=33544&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Really reviewed by Eric really. I verified that this is the same patch that
Eric r+ before.

From bugzilla-daemon at webkit.org  Mon Jul 27 08:17:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:17:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33331] removed unnecessary
 files
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090727151721.401F6340D88F@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33331: removed unnecessary files
https://bugs.webkit.org/attachment.cgi?id=33331&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 08:17:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:17:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33546] move encoder files
 to platform/image_encoders/wince
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090727151721.5B147340D891@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33546: move encoder files to platform/image_encoders/wince
https://bugs.webkit.org/attachment.cgi?id=33546&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 08:36:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:36:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33547] updated
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727153656.07C11340DA44@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33547: updated
https://bugs.webkit.org/attachment.cgi?id=33547&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 08:44:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:44:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33547] updated
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727154421.A08C6340DB18@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33547: updated
https://bugs.webkit.org/attachment.cgi?id=33547&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 08:44:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:44:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33548] more cleanup
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727154421.BD3FE340DB1A@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33548: more cleanup
https://bugs.webkit.org/attachment.cgi?id=33548&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 08:47:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:47:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33549]
 Fixed sortedProperties
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090727154702.6C5F2340DB6B@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33549: Fixed sortedProperties
https://bugs.webkit.org/attachment.cgi?id=33549&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
(In reply to comment #3)
> Sort function for Object.sortedProperties is used in
ObjectPropertiesSections. 
> You should that parameter (sortFunc) back.  If sortFunc is not provided then
> the normal sort() is applied so it works out fine.

Sorry my mistake.

> Also what about global functions/classes?  For example:
> String, Date, toString, Number, ...

Great idea. My understanding is that those are specified are {DontEnum} so you
need to keep a list of them. I think I'll file separate bug.

From bugzilla-daemon at webkit.org  Mon Jul 27 08:47:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:47:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33525] oops
 tabs
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090727154702.3545F340DB65@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33525: oops tabs
https://bugs.webkit.org/attachment.cgi?id=33525&action=review

------- Additional Comments from Keishi Hattori <casey.hattori at gmail.com>
(In reply to comment #3)
> Sort function for Object.sortedProperties is used in
ObjectPropertiesSections. 
> You should that parameter (sortFunc) back.  If sortFunc is not provided then
> the normal sort() is applied so it works out fine.

Sorry my mistake.

> Also what about global functions/classes?  For example:
> String, Date, toString, Number, ...

Great idea. My understanding is that those are specified are {DontEnum} so you
need to keep a list of them. I think I'll file separate bug.

From bugzilla-daemon at webkit.org  Mon Jul 27 08:57:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:57:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33548] more cleanup
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727155756.75E94340DCD1@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33548: more cleanup
https://bugs.webkit.org/attachment.cgi?id=33548&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 08:57:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 08:57:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33550] fix a bug
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727155756.9939A340DCD3@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33550: fix a bug
https://bugs.webkit.org/attachment.cgi?id=33550&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 09:16:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:16:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27685] [V8] Split up
 V8DOMMap.cpp by class : [Attachment 33500] Patch (just copy/paste)
In-Reply-To: <bug-27685-0@https.bugs.webkit.org/>
References: <bug-27685-0@https.bugs.webkit.org/>
Message-ID: <20090727161613.82152340DECC@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27685: [V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

Attachment 33500: Patch (just copy/paste)
https://bugs.webkit.org/attachment.cgi?id=33500&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things that can be fixed up on landing.  

If the changes are substantial or you'd like me to review the "thread safe"
comments or fixes, feel free to put up for review again.


> Index: WebCore/ChangeLog
> +	   * bindings/v8/DOMDataStore.cpp: Added.
> +	   (WebCore::DOMDataStore::DOMDataStore):
> +	   (WebCore::DOMDataStore::~DOMDataStore):
> +	   (WebCore::DOMDataStore::allStores):
> +	   (WebCore::DOMDataStore::allStoresMutex):
> +	   (WebCore::DOMDataStore::getDOMWrapperMap):
> +	   (WebCore::::forget):

Would be nice to fix this function definition: "WebCore::::forget"


> Index: WebCore/WebCore.gypi
>	       'bindings/js/StringSourceProvider.h',
>	       'bindings/js/WorkerScriptController.cpp',
>	       'bindings/js/WorkerScriptController.h',
> +	       'bindings/v8/ChildThreadDOMData.h',
> +	       'bindings/v8/ChildThreadDOMData.cpp',

For all changes in gypi, put foo.h after foo.cpp (sorting).

> Index: WebCore/bindings/v8/DOMData.cpp

> +
> +DOMData* DOMData::getCurrent()
> +{
> +    if (WTF::isMainThread())
> +	   return getCurrentMainThread();
> +
> +    DEFINE_STATIC_LOCAL(WTF::ThreadSpecific<ChildThreadDOMData>,
childThreadDOMData, ());

This looks like it has race conditions.  Please add a comment about why it
isn't or consider switching to using AtomicallyInitializedStatic (from
wtf/Threading.h).

>
> +void DOMData::ensureDeref(V8ClassIndex::V8WrapperType type, void* domObject)

> +{
> +    if (m_owningThread == WTF::currentThread()) {
> +	   // No need to delay the work.  We can deref right now.

Nice to change to single space after .


> Index: WebCore/bindings/v8/DOMData.h
> ===================================================================
>
> +    class DOMData: public Noncopyable {
Add space before ":"

> +    public:
> +	   DOMData();
> +
> +	   static DOMData* getCurrent();
> +	   static DOMData* getCurrentMainThread(); // Caller must be on the
main thread.
> +	   virtual DOMDataStore& getStore() = 0;
> +
> +	   template<typename T>
> +	   static void handleWeakObject(DOMDataStore::DOMWrapperMapType
mapType, v8::Handle<v8::Object> v8Object, T* domObject);
Remove redundant parameter names "mapType" and possibly "v8Object".


> +
> +	   void forgetDelayedObject(void* object) {
m_delayedObjectMap.take(object); }
> +
> +	   // This is to ensure that we will deref DOM objects from the owning
thread,
> +	   // not the GC thread.  The helper function will be scheduled by the
GC

Nice to change to single space after .

> Index: WebCore/bindings/v8/DOMDataStore.cpp


> +WTF::Mutex& DOMDataStore::allStoresMutex()
> +{
> +    DEFINE_STATIC_LOCAL(WTF::Mutex, staticDOMDataListMutex, ());

This looks like it has race conditions.  Please add a comment about why it
isn't or consider switching to using AtomicallyInitializedStatic (from
wtf/Threading.h).



> Index: WebCore/bindings/v8/DOMDataStore.h
> ===================================================================

> +
> +#include <wtf/HashMap.h>
> +#include <wtf/MainThread.h>
> +#include <wtf/Noncopyable.h>
> +#include <wtf/OwnPtr.h>
> +#include <wtf/StdLibExtras.h>
> +#include <wtf/Threading.h>
> +#include <wtf/ThreadSpecific.h>
> +#include <wtf/Vector.h>
> +#include <v8.h>

I would put v8.h before the wtf based on sorting.


> +
> +	   template <class KeyType>
> +	   class InternalDOMWrapperMap : public DOMWrapperMap<KeyType> {
> +	   public:
> +	       InternalDOMWrapperMap(DOMData* domData,
v8::WeakReferenceCallback callback)
> +		   : DOMWrapperMap<KeyType>(callback) , m_domData(domData) { }

Bad spacing before the ,

Actually, I would just format the code like this:
	    InternalDOMWrapperMap(DOMData* domData, v8::WeakReferenceCallback
callback)
		: DOMWrapperMap<KeyType>(callback)
		, m_domData(domData)
	    {
	    }


> +	   DOMDataStore(DOMData* domData);

Remove parameter name.



> Index: WebCore/bindings/v8/ScopedDOMDataStore.cpp
> +ScopedDOMDataStore::ScopedDOMDataStore(DOMData* domData) :
DOMDataStore(domData)

Put ": DOMDataStore(domData)" on the next line.


> Index: WebCore/bindings/v8/ScopedDOMDataStore.h
> +    class ScopedDOMDataStore : public DOMDataStore {
> +    public:
> +	   ScopedDOMDataStore(DOMData* domData);

Remove parameter name.

From bugzilla-daemon at webkit.org  Mon Jul 27 09:17:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:17:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27713] WINCE port: make
 plugin work for wince : [Attachment 33550] fix a bug
In-Reply-To: <bug-27713-0@https.bugs.webkit.org/>
References: <bug-27713-0@https.bugs.webkit.org/>
Message-ID: <20090727161711.A9547340DEFB@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27713: WINCE port: make plugin work for wince
https://bugs.webkit.org/show_bug.cgi?id=27713

Attachment 33550: fix a bug
https://bugs.webkit.org/attachment.cgi?id=33550&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 09:23:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:23:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27714] update qt expefic
 expected files for fast/css/getComputedStyle/ tests after r46274 :
 [Attachment 33551] fix
In-Reply-To: <bug-27714-0@https.bugs.webkit.org/>
References: <bug-27714-0@https.bugs.webkit.org/>
Message-ID: <20090727162329.09D5C340DF98@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27714: update qt expefic expected files for fast/css/getComputedStyle/
tests after r46274
https://bugs.webkit.org/show_bug.cgi?id=27714

Attachment 33551: fix
https://bugs.webkit.org/attachment.cgi?id=33551&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
r46274 has removed "-webkit" prefix from "box-shadow" property.

patch updates qt expected results, accordingly.

From bugzilla-daemon at webkit.org  Mon Jul 27 09:39:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:39:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27714] update qt expefic
 expected files for fast/css/getComputedStyle/ tests after r46274 :
 [Attachment 33551] fix
In-Reply-To: <bug-27714-0@https.bugs.webkit.org/>
References: <bug-27714-0@https.bugs.webkit.org/>
Message-ID: <20090727163938.A2166340E16F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27714: update qt expefic expected files for fast/css/getComputedStyle/
tests after r46274
https://bugs.webkit.org/show_bug.cgi?id=27714

Attachment 33551: fix
https://bugs.webkit.org/attachment.cgi?id=33551&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 09:41:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:41:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27715] WINCE PORT: changes
 made to platform/text existing files : [Attachment 33552] the patch
In-Reply-To: <bug-27715-0@https.bugs.webkit.org/>
References: <bug-27715-0@https.bugs.webkit.org/>
Message-ID: <20090727164148.7D070340E19A@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27715: WINCE PORT: changes made to platform/text existing files
https://bugs.webkit.org/show_bug.cgi?id=27715

Attachment 33552: the patch
https://bugs.webkit.org/attachment.cgi?id=33552&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 09:46:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:46:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27707] [WML] History
 handling / page cache / loading is buggy and depends on several hacks :
 [Attachment 33553] Initial patch
In-Reply-To: <bug-27707-0@https.bugs.webkit.org/>
References: <bug-27707-0@https.bugs.webkit.org/>
Message-ID: <20090727164627.4C87B340E227@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27707: [WML] History handling / page cache / loading is buggy and depends
on several hacks
https://bugs.webkit.org/show_bug.cgi?id=27707

Attachment 33553: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33553&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 09:57:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 09:57:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27707] [WML] History handling
 / page cache / loading is buggy and depends on several hacks : [Attachment
 33553] Initial patch
In-Reply-To: <bug-27707-0@https.bugs.webkit.org/>
References: <bug-27707-0@https.bugs.webkit.org/>
Message-ID: <20090727165712.DDAD5340E32E@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27707: [WML] History handling / page cache / loading is buggy and depends
on several hacks
https://bugs.webkit.org/show_bug.cgi?id=27707

Attachment 33553: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33553&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 10:25:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 10:25:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27700] Visual Studio project
 files should support building WebKit out-of-tree (shadow build) :
 [Attachment 33524] WebCore:
In-Reply-To: <bug-27700-0@https.bugs.webkit.org/>
References: <bug-27700-0@https.bugs.webkit.org/>
Message-ID: <20090727172531.E838C340E67C@gamma.macosforge.org>

Steve Falkenburg <sfalken at apple.com> has granted Tor Arne Vestb?
<vestbo at webkit.org>'s request for review:
Bug 27700: Visual Studio project files should support building WebKit
out-of-tree (shadow build)
https://bugs.webkit.org/show_bug.cgi?id=27700

Attachment 33524: WebCore:
https://bugs.webkit.org/attachment.cgi?id=33524&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 10:36:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 10:36:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27715] WINCE PORT: changes
 made to platform/text existing files : [Attachment 33552] the patch
In-Reply-To: <bug-27715-0@https.bugs.webkit.org/>
References: <bug-27715-0@https.bugs.webkit.org/>
Message-ID: <20090727173652.8CDE3340E7BF@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27715: WINCE PORT: changes made to platform/text existing files
https://bugs.webkit.org/show_bug.cgi?id=27715

Attachment 33552: the patch
https://bugs.webkit.org/attachment.cgi?id=33552&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 10:36:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 10:36:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27715] WINCE PORT: changes
 made to platform/text existing files : [Attachment 33554] remove
 unnecessary change
In-Reply-To: <bug-27715-0@https.bugs.webkit.org/>
References: <bug-27715-0@https.bugs.webkit.org/>
Message-ID: <20090727173652.ACA2E340E7C1@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27715: WINCE PORT: changes made to platform/text existing files
https://bugs.webkit.org/show_bug.cgi?id=27715

Attachment 33554: remove unnecessary change
https://bugs.webkit.org/attachment.cgi?id=33554&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 10:42:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 10:42:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27666] The patch submitted
 for bug 26054 has some no-op instructions that need to be removed :
 [Attachment 33471] patch
In-Reply-To: <bug-27666-0@https.bugs.webkit.org/>
References: <bug-27666-0@https.bugs.webkit.org/>
Message-ID: <20090727174206.5A559340E88A@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dumitru Daniliuc
<dumi at chromium.org>'s request for review:
Bug 27666: The patch submitted for bug 26054 has some no-op instructions that
need to be removed
https://bugs.webkit.org/show_bug.cgi?id=27666

Attachment 33471: patch
https://bugs.webkit.org/attachment.cgi?id=33471&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Mon Jul 27 10:59:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 10:59:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27718] [WML] Manual WML
 tests aren't properly working : [Attachment 33555] Initial patch
In-Reply-To: <bug-27718-0@https.bugs.webkit.org/>
References: <bug-27718-0@https.bugs.webkit.org/>
Message-ID: <20090727175958.B654B340EB56@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27718: [WML] Manual WML tests aren't properly working
https://bugs.webkit.org/show_bug.cgi?id=27718

Attachment 33555: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33555&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 11:07:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:07:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27663] FontPlatformData for
 Qt requires mapping from FontWeight to QFont::Weight : [Attachment 33556]
 Revised Patch
In-Reply-To: <bug-27663-0@https.bugs.webkit.org/>
References: <bug-27663-0@https.bugs.webkit.org/>
Message-ID: <20090727180704.C19BD340EC61@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27663: FontPlatformData for Qt requires mapping from FontWeight to
QFont::Weight
https://bugs.webkit.org/show_bug.cgi?id=27663

Attachment 33556: Revised Patch
https://bugs.webkit.org/attachment.cgi?id=33556&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Patch has been updated.

Based on feedback, toQFontWeight now returns values directly within
intermediary variable.

Switch bold calculation to >Normal from >=Bold to ensure logic matches
calculation provided by QFont.bold().

This does not break any tests.

m_bold variable is required by FontPlatformData and can not be removed without
affecting other platforms.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:08:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:08:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27718] [WML] Manual WML tests
 aren't properly working : [Attachment 33555] Initial patch
In-Reply-To: <bug-27718-0@https.bugs.webkit.org/>
References: <bug-27718-0@https.bugs.webkit.org/>
Message-ID: <20090727180800.C08CB340ECB5@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27718: [WML] Manual WML tests aren't properly working
https://bugs.webkit.org/show_bug.cgi?id=27718

Attachment 33555: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33555&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 11:09:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:09:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27715] WINCE PORT: changes
 made to platform/text existing files : [Attachment 33554] remove
 unnecessary change
In-Reply-To: <bug-27715-0@https.bugs.webkit.org/>
References: <bug-27715-0@https.bugs.webkit.org/>
Message-ID: <20090727180901.A03FC340ECED@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27715: WINCE PORT: changes made to platform/text existing files
https://bugs.webkit.org/show_bug.cgi?id=27715

Attachment 33554: remove unnecessary change
https://bugs.webkit.org/attachment.cgi?id=33554&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 11:09:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:09:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27719] [Chromium]
 Regression in r42671 - js event object being hidden. : [Attachment 33557]
 patch
In-Reply-To: <bug-27719-0@https.bugs.webkit.org/>
References: <bug-27719-0@https.bugs.webkit.org/>
Message-ID: <20090727180912.DA26B340ED0C@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27719: [Chromium] Regression in r42671 - js event object being hidden.
https://bugs.webkit.org/show_bug.cgi?id=27719

Attachment 33557: patch
https://bugs.webkit.org/attachment.cgi?id=33557&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 11:12:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:12:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27719] [Chromium] Regression
 in r42671 - js event object being hidden. : [Attachment 33557] patch
In-Reply-To: <bug-27719-0@https.bugs.webkit.org/>
References: <bug-27719-0@https.bugs.webkit.org/>
Message-ID: <20090727181210.434E7340ED58@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27719: [Chromium] Regression in r42671 - js event object being hidden.
https://bugs.webkit.org/show_bug.cgi?id=27719

Attachment 33557: patch
https://bugs.webkit.org/attachment.cgi?id=33557&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:24:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:24:16 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27685] [V8] Split up
 V8DOMMap.cpp by class : [Attachment 33500] Patch (just copy/paste)
In-Reply-To: <bug-27685-0@https.bugs.webkit.org/>
References: <bug-27685-0@https.bugs.webkit.org/>
Message-ID: <20090727182416.EFE0C340EF28@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27685: [V8] Split up V8DOMMap.cpp by class
https://bugs.webkit.org/show_bug.cgi?id=27685

Attachment 33500: Patch (just copy/paste)
https://bugs.webkit.org/attachment.cgi?id=33500&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 11:24:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:24:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 33559] Updated patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090727182455.C73AA340EF74@gamma.macosforge.org>

robert <robert at roberthogan.net> has asked Simon Hausmann <hausmann at webkit.org>
for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 33559: Updated patch
https://bugs.webkit.org/attachment.cgi?id=33559&action=review

------- Additional Comments from robert <robert at roberthogan.net>
Sorry for the delay in responding - was away for a week. Patch updated per
Simon and Kenny's comments.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:29:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:29:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27663] FontPlatformData for
 Qt requires mapping from FontWeight to QFont::Weight : [Attachment 33556]
 Revised Patch
In-Reply-To: <bug-27663-0@https.bugs.webkit.org/>
References: <bug-27663-0@https.bugs.webkit.org/>
Message-ID: <20090727182946.2EC6E340F0C0@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27663: FontPlatformData for Qt requires mapping from FontWeight to
QFont::Weight
https://bugs.webkit.org/show_bug.cgi?id=27663

Attachment 33556: Revised Patch
https://bugs.webkit.org/attachment.cgi?id=33556&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Looks good to me.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:39:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:39:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27512] Test for
 QWebFrame::hasSetFocus() is trying to use a not defined resource. :
 [Attachment 33445] Using setHtml methods to define the test web page
 instead of external resources.
In-Reply-To: <bug-27512-0@https.bugs.webkit.org/>
References: <bug-27512-0@https.bugs.webkit.org/>
Message-ID: <20090727183918.E8282340F25F@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has canceled Andre Pedralho
<apedralho at gmail.com>'s request for review:
Bug 27512: Test for QWebFrame::hasSetFocus() is trying to use a not defined
resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

Attachment 33445: Using setHtml methods to define the test web page instead of
external resources.
https://bugs.webkit.org/attachment.cgi?id=33445&action=review

------- Additional Comments from Andre Pedralho <apedralho at gmail.com>
Marking old patch obsolete as per suggestions in IRC.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:39:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:39:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27512] Test for
 QWebFrame::hasSetFocus() is trying to use a not defined resource. :
 [Attachment 33560] Using QSignalSpy to control whether a load finished
 signal has been emited instead of just wait for some miliseconds.
In-Reply-To: <bug-27512-0@https.bugs.webkit.org/>
References: <bug-27512-0@https.bugs.webkit.org/>
Message-ID: <20090727183919.23CD3340F263@gamma.macosforge.org>

Andre Pedralho <apedralho at gmail.com> has asked	for review:
Bug 27512: Test for QWebFrame::hasSetFocus() is trying to use a not defined
resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

Attachment 33560: Using QSignalSpy to control whether a load finished signal
has been emited instead of just wait for some miliseconds.
https://bugs.webkit.org/attachment.cgi?id=33560&action=review

------- Additional Comments from Andre Pedralho <apedralho at gmail.com>
Marking old patch obsolete as per suggestions in IRC.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:39:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:39:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33220] Update auto-version.sh to
 handle different line endings
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090727183951.DAC46340F287@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Peter Kasting
<pkasting at google.com>'s request for review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33220: Update auto-version.sh to handle different line endings
https://bugs.webkit.org/attachment.cgi?id=33220&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> -    PROPOSEDVERSION=$(cat "$SRCPATH/VERSION")
> +    PROPOSEDVERSION=`cat $SRCPATH/VERSION | sed -r 's/(.*\S+)\s*/\1/'`

Seems like the \s* part of the regex isn't needed, since regex matching is
greedy (ditto for the other sed command).

r=me

From bugzilla-daemon at webkit.org  Mon Jul 27 11:54:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:54:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27323] Better support for
 non-Cygwin SVN on Windows : [Attachment 33220] Update auto-version.sh to
 handle different line endings
In-Reply-To: <bug-27323-0@https.bugs.webkit.org/>
References: <bug-27323-0@https.bugs.webkit.org/>
Message-ID: <20090727185453.29305340F4AA@gamma.macosforge.org>

Peter Kasting <pkasting at google.com> has canceled  review:
Bug 27323: Better support for non-Cygwin SVN on Windows
https://bugs.webkit.org/show_bug.cgi?id=27323

Attachment 33220: Update auto-version.sh to handle different line endings
https://bugs.webkit.org/attachment.cgi?id=33220&action=review

------- Additional Comments from Peter Kasting <pkasting at google.com>
Landed in r46424, clearing flags.

From bugzilla-daemon at webkit.org  Mon Jul 27 11:56:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 11:56:54 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27669] [chromium] Default UI
 controls for <video> has rendering problems : [Attachment 33480] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090727185654.B1FD6340F500@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33480: patch
https://bugs.webkit.org/attachment.cgi?id=33480&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> @@ -1,3 +1,23 @@
> +'

Please get rid of this.

> +2009-07-24  Alpha Lam  <hclam at google.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [chromium] Default UI controls for <video> has rendering problems
> +	   https://bugs.webkit.org/show_bug.cgi?id=27669
> +
> +	   Fixes the bug that <video> in MediaDocument is 1 pixel tall if
> +	   it is playing an audio file by changing the style to be 16px

It looks like you made it 32px.

> +
> +	   There is no layout test provided because this only affects the
> +	   chromium port.

Couldn't there still could be a layout test (with different results for each
platform: OSX, Chromium, etc.).

From bugzilla-daemon at webkit.org  Mon Jul 27 12:19:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 12:19:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27687] [Gtk] Refactor
 ResourceHandleSoup - make start* functions static : [Attachment 33502]
 patch
In-Reply-To: <bug-27687-0@https.bugs.webkit.org/>
References: <bug-27687-0@https.bugs.webkit.org/>
Message-ID: <20090727191908.2CC2C340F77B@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 27687: [Gtk] Refactor ResourceHandleSoup - make start* functions static
https://bugs.webkit.org/show_bug.cgi?id=27687

Attachment 33502: patch
https://bugs.webkit.org/attachment.cgi?id=33502&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
Makes sense to me.

From bugzilla-daemon at webkit.org  Mon Jul 27 12:39:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 12:39:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27723] [WML] 'onpick'
 intrinsic event handling missing : [Attachment 33562] Initial patch
In-Reply-To: <bug-27723-0@https.bugs.webkit.org/>
References: <bug-27723-0@https.bugs.webkit.org/>
Message-ID: <20090727193916.4074D340FA09@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27723: [WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Attachment 33562: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33562&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 12:43:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 12:43:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27723] [WML] 'onpick'
 intrinsic event handling missing : [Attachment 33562] Initial patch
In-Reply-To: <bug-27723-0@https.bugs.webkit.org/>
References: <bug-27723-0@https.bugs.webkit.org/>
Message-ID: <20090727194329.39962340FA82@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27723: [WML] 'onpick' intrinsic event handling missing
https://bugs.webkit.org/show_bug.cgi?id=27723

Attachment 33562: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33562&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 13:10:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 13:10:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27669] [chromium] Default
 UI controls for <video> has rendering problems : [Attachment 33564] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090727201007.887FD340FDAD@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33564: patch
https://bugs.webkit.org/attachment.cgi?id=33564&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 13:17:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 13:17:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27669] [chromium] Default UI
 controls for <video> has rendering problems : [Attachment 33564] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090727201701.9F011340FE67@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33564: patch
https://bugs.webkit.org/attachment.cgi?id=33564&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog
> +	   There is no new tests provided because this is already covered
> +	   by existing tests.

Minor nit: There are

From bugzilla-daemon at webkit.org  Mon Jul 27 13:26:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 13:26:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33565]
 dontcachelayout.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090727202605.CC58A341009E@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33565: dontcachelayout.patch
https://bugs.webkit.org/attachment.cgi?id=33565&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
I believe this should fix the issue with the function not reacting to layout
changes. About the crasher, if you can provide a trace with full debug symbols
that would help (you need to compile WebKit with --enable-debug), otherwise
I'll get to it tomorrow. Thanks!

From bugzilla-daemon at webkit.org  Mon Jul 27 13:29:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 13:29:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27729] Add WINCE port file:
 WebCore/page/wince/FrameWince.cpp : [Attachment 33566] the patch
In-Reply-To: <bug-27729-0@https.bugs.webkit.org/>
References: <bug-27729-0@https.bugs.webkit.org/>
Message-ID: <20090727202925.4D3073410113@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27729: Add WINCE port file: WebCore/page/wince/FrameWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27729

Attachment 33566: the patch
https://bugs.webkit.org/attachment.cgi?id=33566&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 13:35:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 13:35:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27731] [V8] Implement
 EventListener::reportError for V8 event listeners in worker context. :
 [Attachment 33567] Proposed Patch
In-Reply-To: <bug-27731-0@https.bugs.webkit.org/>
References: <bug-27731-0@https.bugs.webkit.org/>
Message-ID: <20090727203519.8862D34101C6@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27731: [V8] Implement EventListener::reportError for V8 event listeners in
worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731

Attachment 33567: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33567&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 13:40:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 13:40:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27660] createMarkup does not
 handle CSS properly : [Attachment 33483] fixes the bug but may worsen the
 bug 26483
In-Reply-To: <bug-27660-0@https.bugs.webkit.org/>
References: <bug-27660-0@https.bugs.webkit.org/>
Message-ID: <20090727204038.B80CC3410275@gamma.macosforge.org>

Justin Garcia <justin.garcia at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 27660: createMarkup does not handle CSS properly
https://bugs.webkit.org/show_bug.cgi?id=27660

Attachment 33483: fixes the bug but may worsen the bug 26483
https://bugs.webkit.org/attachment.cgi?id=33483&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
No need to separate the patch, it's rather small.

+    // All text-decoration-related elements should have been treated as
special ancestor

Small typo.  Should read "as special ancestors".

+    DEFINE_STATIC_LOCAL(const String, divCloseTag, ("</div>"));
+    DEFINE_STATIC_LOCAL(const String, styleSpanOpen, ("<span class=\""
AppleStyleSpanClass "\" style=\""));
+    DEFINE_STATIC_LOCAL(const String, styleSpanClose, ("</span>"));

I'd name it "divClose" for consistency.

r=me

From bugzilla-daemon at webkit.org  Mon Jul 27 14:05:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 14:05:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27732] Fix chromium linux
 build by adding missing function implementation. : [Attachment 33568]
 Trivial implemenation of FontPlatformData::description()
In-Reply-To: <bug-27732-0@https.bugs.webkit.org/>
References: <bug-27732-0@https.bugs.webkit.org/>
Message-ID: <20090727210536.BC30A3410527@gamma.macosforge.org>

Albert J. Wong <ajwong at chromium.org> has asked	for review:
Bug 27732: Fix chromium linux build by adding missing function implementation.
https://bugs.webkit.org/show_bug.cgi?id=27732

Attachment 33568: Trivial implemenation of FontPlatformData::description()
https://bugs.webkit.org/attachment.cgi?id=33568&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 14:06:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 14:06:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27732] Fix chromium linux
 build by adding missing function implementation. : [Attachment 33568]
 Trivial implemenation of FontPlatformData::description()
In-Reply-To: <bug-27732-0@https.bugs.webkit.org/>
References: <bug-27732-0@https.bugs.webkit.org/>
Message-ID: <20090727210654.A04FA3410563@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Albert J. Wong
<ajwong at chromium.org>'s request for review:
Bug 27732: Fix chromium linux build by adding missing function implementation.
https://bugs.webkit.org/show_bug.cgi?id=27732

Attachment 33568: Trivial implemenation of FontPlatformData::description()
https://bugs.webkit.org/attachment.cgi?id=33568&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 14:18:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 14:18:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27734] WINCE PORT: font
 related changes : [Attachment 33569] the patch
In-Reply-To: <bug-27734-0@https.bugs.webkit.org/>
References: <bug-27734-0@https.bugs.webkit.org/>
Message-ID: <20090727211859.AFFA03410708@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27734: WINCE PORT: font related changes
https://bugs.webkit.org/show_bug.cgi?id=27734

Attachment 33569: the patch
https://bugs.webkit.org/attachment.cgi?id=33569&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 14:32:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 14:32:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27735] Give a helpful name
 to JSLock argument : [Attachment 33570] proposed patch
In-Reply-To: <bug-27735-0@https.bugs.webkit.org/>
References: <bug-27735-0@https.bugs.webkit.org/>
Message-ID: <20090727213200.16C7A34108D3@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has asked  for review:
Bug 27735: Give a helpful name to JSLock argument
https://bugs.webkit.org/show_bug.cgi?id=27735

Attachment 33570: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33570&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 14:51:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 14:51:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27735] Give a helpful name to
 JSLock argument : [Attachment 33570] proposed patch
In-Reply-To: <bug-27735-0@https.bugs.webkit.org/>
References: <bug-27735-0@https.bugs.webkit.org/>
Message-ID: <20090727215132.B8EF53410ACE@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Alexey Proskuryakov <ap at webkit.org>'s
request for review:
Bug 27735: Give a helpful name to JSLock argument
https://bugs.webkit.org/show_bug.cgi?id=27735

Attachment 33570: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33570&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 14:59:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 14:59:58 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27400] Inspector:
 Automatically Refresh DOM Storage Grids on "storage" event : [Attachment
 33378] Fixed Based on Review
In-Reply-To: <bug-27400-0@https.bugs.webkit.org/>
References: <bug-27400-0@https.bugs.webkit.org/>
Message-ID: <20090727215958.BCB6E3410BB0@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27400: Inspector: Automatically Refresh DOM Storage Grids on "storage"
event
https://bugs.webkit.org/show_bug.cgi?id=27400

Attachment 33378: Fixed Based on Review
https://bugs.webkit.org/attachment.cgi?id=33378&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 15:02:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 15:02:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27322] Inspector: Create New
 DOM Storage Items via DataGrid : [Attachment 32821] Make DOM Storage
 DataGrid More Interactive
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090727220257.584353410C04@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 32821: Make DOM Storage DataGrid More Interactive
https://bugs.webkit.org/attachment.cgi?id=32821&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   if (this._editingNode.isCreationNode) {
> +	       element = this._editingNode._element.children[0]; // Leftmost
Column
> +	   }

No need for the braces here.

What does the creation row look like?

From bugzilla-daemon at webkit.org  Mon Jul 27 15:13:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 15:13:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27737] [V8] Remove
 parameterless frame/window retrieval methods from V8Proxy : [Attachment
 33572] Remove parameterless frame/window retrieval methods, v1.
In-Reply-To: <bug-27737-0@https.bugs.webkit.org/>
References: <bug-27737-0@https.bugs.webkit.org/>
Message-ID: <20090727221346.EC2A73410DA7@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has asked  for review:
Bug 27737: [V8] Remove parameterless frame/window retrieval methods from
V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27737

Attachment 33572: Remove parameterless frame/window retrieval methods, v1.
https://bugs.webkit.org/attachment.cgi?id=33572&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
 WebCore/ChangeLog				    |	34 ++++++++++++++++++++
 WebCore/bindings/v8/ScriptCallStack.cpp	    |	 2 +-
 WebCore/bindings/v8/V8NPUtils.cpp		    |	 2 +-
 WebCore/bindings/v8/V8Proxy.cpp		    |	18 +---------
 WebCore/bindings/v8/V8Proxy.h			    |	 5 ---
 WebCore/bindings/v8/custom/V8DatabaseCustom.cpp    |	30 +++++++----------
 .../v8/custom/V8HTMLAudioElementConstructor.cpp    |	 8 +++-
 .../v8/custom/V8HTMLImageElementConstructor.cpp    |	 8 +++-
 .../v8/custom/V8HTMLOptionElementConstructor.cpp   |	 8 +++-
 .../v8/custom/V8MessageChannelConstructor.cpp	    |	 2 +-
 .../bindings/v8/custom/V8SQLTransactionCustom.cpp  |	 2 +-
 WebCore/bindings/v8/custom/V8WorkerCustom.cpp	    |	 2 +-
 .../v8/custom/V8XMLHttpRequestConstructor.cpp	    |	10 +++++-
 13 files changed, 80 insertions(+), 51 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 15:28:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 15:28:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27737] [V8] Remove
 parameterless frame/window retrieval methods from V8Proxy : [Attachment
 33572] Remove parameterless frame/window retrieval methods, v1.
In-Reply-To: <bug-27737-0@https.bugs.webkit.org/>
References: <bug-27737-0@https.bugs.webkit.org/>
Message-ID: <20090727222828.2C42F3410F99@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Dimitri Glazkov (Google)
<dglazkov at chromium.org>'s request for review:
Bug 27737: [V8] Remove parameterless frame/window retrieval methods from
V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27737

Attachment 33572: Remove parameterless frame/window retrieval methods, v1.
https://bugs.webkit.org/attachment.cgi?id=33572&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Some minor things to fix on check-in.


> diff --git a/WebCore/bindings/v8/custom/V8DatabaseCustom.cpp
b/WebCore/bindings/v8/custom/V8DatabaseCustom.cpp
> +    if (args.Length() == 0)

Since you're changing this line, may I suggest

 if (!args.Length())

> +	   return throwError("Transaction callback is required.",
V8Proxy::SyntaxError);
>  
> +	   if (!args[1]->IsObject())
> +	       throwError("Transaction success callback must be of valid
type.");
Missing "return" before "throwError"




> diff --git a/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp
b/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp
> index 8c447c6..a3e523c 100644
> --- a/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp
> +++ b/WebCore/bindings/v8/custom/V8XMLHttpRequestConstructor.cpp
> @@ -55,9 +55,15 @@ CALLBACK_FUNC_DECL(XMLHttpRequestConstructor)
>      WorkerContextExecutionProxy* proxy =
WorkerContextExecutionProxy::retrieve();
>      if (proxy)
>	   context = proxy->workerContext();
> -    else
> +    else {
> +#endif
> +	   Frame* frame = V8Proxy::retrieveFrameForCurrentContext();
> +	   if (!frame)
> +	       return throwError("Frame associated with XMLHttpRequest
constructor is not available.", V8Proxy::ReferenceError);

Why did you go with a different style of error message here?

This would match the format of the others:

 "XMLHttpRequest constructor associated frame is not available"

But actually I like the format in this one better.


Also, I think they would read better with a 's
 "XMLHttpRequest constructor's associated frame is not available"

From bugzilla-daemon at webkit.org  Mon Jul 27 15:34:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 15:34:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27741]
 prototypes-inheritance-2.html should crawl more types : [Attachment 33575]
 patch
In-Reply-To: <bug-27741-0@https.bugs.webkit.org/>
References: <bug-27741-0@https.bugs.webkit.org/>
Message-ID: <20090727223446.349853411070@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27741: prototypes-inheritance-2.html should crawl more types
https://bugs.webkit.org/show_bug.cgi?id=27741

Attachment 33575: patch
https://bugs.webkit.org/attachment.cgi?id=33575&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 15:38:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 15:38:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27741]
 prototypes-inheritance-2.html should crawl more types : [Attachment 33575]
 patch
In-Reply-To: <bug-27741-0@https.bugs.webkit.org/>
References: <bug-27741-0@https.bugs.webkit.org/>
Message-ID: <20090727223826.C1CAB34110CA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27741: prototypes-inheritance-2.html should crawl more types
https://bugs.webkit.org/show_bug.cgi?id=27741

Attachment 33575: patch
https://bugs.webkit.org/attachment.cgi?id=33575&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Great.	I like - lines on the "never saw" list.

From bugzilla-daemon at webkit.org  Mon Jul 27 15:40:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 15:40:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27322] Inspector: Create
 New DOM Storage Items via DataGrid : [Attachment 33577] Make DOM Storage
 DataGrid More Interactive
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090727224056.21BEF3411143@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 33577: Make DOM Storage DataGrid More Interactive
https://bugs.webkit.org/attachment.cgi?id=33577&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
NOTES:

- Style fixes
- Added the select() call to prevent unwanted deletions

From bugzilla-daemon at webkit.org  Mon Jul 27 16:13:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 16:13:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27664] commit-log-editor
 should allow git commit --amend to regenerate the commit log based on the
 modifed ChangeLog : [Attachment 33465] 2009-07-24 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27664-0@https.bugs.webkit.org/>
References: <bug-27664-0@https.bugs.webkit.org/>
Message-ID: <20090727231304.DE7B63411457@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27664: commit-log-editor should allow git commit --amend to regenerate the
commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

Attachment 33465: 2009-07-24  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33465&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +	   * Scripts/commit-log-editor: Add --allow-commit-log-suppression
option.
> +	   The user is asked if he wants to suppress previous ChangeLog and
regenerate it,
> +	   if this option is enabled.

I think "--allow-commit-log-suppression" should have a better name.  Maybe
--regenerate-log?

> +my $previousLogMessage = "";
[...]
> -    $logContents .= $_;
> +    if(!isGit() || (/^#/)) {
> +	   $logContents .= $_;
> +    } else {
> +	   $previousLogMessage .= $_;
> +    }
>      $existingLog = isGit() && !(/^#/ || /^\s*$/) unless $existingLog;

The $previousLogMessage contents don't seem to be used anywhere else.  What
happens if you want to use the previousLogMessage?  Should $previousLogMessage
be assigned (or appended) to $logContents?

> +my $keepExistingLog = 1;
> +if ($allowPreviousCommitLogSuppression && $existingLog) {
> +    print "Existing log message detected, enter 'd' to delete, and
regenerate log message from ChangeLogs. Press Return to continue.\n";
> +    my $key = getc(STDIN);
> +    $keepExistingLog = 0 if ($key eq "d");
> +}

My reading of the code indicates that *any* key besides 'd' will cause the
existing log to be kept.  I'd change the message to something like:

print "Existing log message detected.  Use 'r' to regenerate from ChangeLogs,
or any other key to keep the existing message.\n";

r- to address the above issues.

From bugzilla-daemon at webkit.org  Mon Jul 27 16:56:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 16:56:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27720] [WML] 'title'
 attribute handling not correct for <a> / <anchor> elements : [Attachment
 33580] Initial patch
In-Reply-To: <bug-27720-0@https.bugs.webkit.org/>
References: <bug-27720-0@https.bugs.webkit.org/>
Message-ID: <20090727235634.9A0103411871@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27720: [WML] 'title' attribute handling not correct for <a> / <anchor>
elements
https://bugs.webkit.org/show_bug.cgi?id=27720

Attachment 33580: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33580&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 16:56:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 16:56:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27236] Memory is not
 released back to the system from TCMalloc on Windows : [Attachment 33581]
 Revised patch to use a background thread to release memory back to the
 system.
In-Reply-To: <bug-27236-0@https.bugs.webkit.org/>
References: <bug-27236-0@https.bugs.webkit.org/>
Message-ID: <20090727235647.B67BB341187C@gamma.macosforge.org>

Ada Chan <adachan at apple.com> has asked	for review:
Bug 27236: Memory is not released back to the system from TCMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=27236

Attachment 33581: Revised patch to use a background thread to release memory
back to the system.
https://bugs.webkit.org/attachment.cgi?id=33581&action=review

------- Additional Comments from Ada Chan <adachan at apple.com>
This patch has been revised from the previous version.	The condition of
whether we should hold off on the scavenge has changed.  We'll check whether we
need to commit any memory in the last 5 seconds.  If so, it's a sign that there
are not enough free committed pages around for the amount of allocations that
we have done recently, so we should hold off on releasing memory.

From bugzilla-daemon at webkit.org  Mon Jul 27 16:59:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 16:59:52 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27720] [WML] 'title'
 attribute handling not correct for <a> / <anchor> elements : [Attachment
 33580] Initial patch
In-Reply-To: <bug-27720-0@https.bugs.webkit.org/>
References: <bug-27720-0@https.bugs.webkit.org/>
Message-ID: <20090727235952.96DF634118B2@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27720: [WML] 'title' attribute handling not correct for <a> / <anchor>
elements
https://bugs.webkit.org/show_bug.cgi?id=27720

Attachment 33580: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33580&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
ps: spelled unify wrong

From bugzilla-daemon at webkit.org  Mon Jul 27 17:01:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:01:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27745] fix more obvious
 global object lookups : [Attachment 33582] patch
In-Reply-To: <bug-27745-0@https.bugs.webkit.org/>
References: <bug-27745-0@https.bugs.webkit.org/>
Message-ID: <20090728000107.95D2434118D9@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27745: fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745

Attachment 33582: patch
https://bugs.webkit.org/attachment.cgi?id=33582&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 17:14:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:14:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27745] fix more obvious
 global object lookups : [Attachment 33582] patch
In-Reply-To: <bug-27745-0@https.bugs.webkit.org/>
References: <bug-27745-0@https.bugs.webkit.org/>
Message-ID: <20090728001449.2B81B34119FF@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27745: fix more obvious global object lookups
https://bugs.webkit.org/show_bug.cgi?id=27745

Attachment 33582: patch
https://bugs.webkit.org/attachment.cgi?id=33582&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Ok.  The ones that use global execs probably don't have any observable change. 
The ones about wrapping the events, you might be able to test with page-created
events and synchronous dispatching, but I'm not sure.

From bugzilla-daemon at webkit.org  Mon Jul 27 17:16:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:16:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27746] Inspector: Tab
 Through the DOM Storage DataGrid when Editing : [Attachment 33583] Tab
 Through DOM Storage DataGrid When Editing
In-Reply-To: <bug-27746-0@https.bugs.webkit.org/>
References: <bug-27746-0@https.bugs.webkit.org/>
Message-ID: <20090728001654.7EC7B3411A48@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27746: Inspector: Tab Through the DOM Storage DataGrid when Editing
https://bugs.webkit.org/show_bug.cgi?id=27746

Attachment 33583: Tab Through DOM Storage DataGrid When Editing
https://bugs.webkit.org/attachment.cgi?id=33583&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
NOTES:

- Relies on the (previously r+) patch in bug 27322

From bugzilla-daemon at webkit.org  Mon Jul 27 17:21:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:21:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27729] Add WINCE port file:
 WebCore/page/wince/FrameWince.cpp : [Attachment 33566] the patch
In-Reply-To: <bug-27729-0@https.bugs.webkit.org/>
References: <bug-27729-0@https.bugs.webkit.org/>
Message-ID: <20090728002149.AAD833411AAA@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27729: Add WINCE port file: WebCore/page/wince/FrameWince.cpp
https://bugs.webkit.org/show_bug.cgi?id=27729

Attachment 33566: the patch
https://bugs.webkit.org/attachment.cgi?id=33566&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 17:52:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:52:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27724] [WML] <do> elements
 with a <noop> task shouldn't be exposed to the user : [Attachment 33584]
 Initial patch
In-Reply-To: <bug-27724-0@https.bugs.webkit.org/>
References: <bug-27724-0@https.bugs.webkit.org/>
Message-ID: <20090728005224.EEF073411DA6@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27724: [WML] <do> elements with a <noop> task shouldn't be exposed to the
user
https://bugs.webkit.org/show_bug.cgi?id=27724

Attachment 33584: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33584&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 17:59:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:59:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27664] commit-log-editor
 should allow git commit --amend to regenerate the commit log based on the
 modifed ChangeLog : [Attachment 33465] 2009-07-24 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27664-0@https.bugs.webkit.org/>
References: <bug-27664-0@https.bugs.webkit.org/>
Message-ID: <20090728005910.ED7663411E7D@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled  review:
Bug 27664: commit-log-editor should allow git commit --amend to regenerate the
commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

Attachment 33465: 2009-07-24  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33465&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 17:59:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 17:59:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27664] commit-log-editor
 should allow git commit --amend to regenerate the commit log based on the
 modifed ChangeLog : [Attachment 33585] 2009-07-24 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27664-0@https.bugs.webkit.org/>
References: <bug-27664-0@https.bugs.webkit.org/>
Message-ID: <20090728005912.E896C3411E82@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27664: commit-log-editor should allow git commit --amend to regenerate the
commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

Attachment 33585: 2009-07-24  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33585&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
Reviewed by NOBODY (OOPS!).

commit-log-editor should allow git commit --amend to regenerate the commit log
based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

* Scripts/commit-log-editor: Add --regenerate-log option.
The user is asked if he wants to suppress previous ChangeLog and regenerate it,
if this option is enabled.
---
 2 files changed, 43 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 18:04:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:04:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27731] [V8] Implement
 EventListener::reportError for V8 event listeners in worker context. :
 [Attachment 33567] Proposed Patch
In-Reply-To: <bug-27731-0@https.bugs.webkit.org/>
References: <bug-27731-0@https.bugs.webkit.org/>
Message-ID: <20090728010418.E60753411EEC@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27731: [V8] Implement EventListener::reportError for V8 event listeners in
worker context.
https://bugs.webkit.org/show_bug.cgi?id=27731

Attachment 33567: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33567&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/bindings/v8/V8WorkerContextEventListener.cpp
b/WebCore/bindings/v8/V8WorkerContextEventListener.cpp
> +    // The callback function on XMLHttpRequest can clear the event listener
and destroys 'this' object. Keep a local reference to it.

I'd get rid of "on XMLHttpRequest" and change "destroys" to "destroy".


> +    // See issue 889829.

I'd remove this issue number here.

From bugzilla-daemon at webkit.org  Mon Jul 27 18:07:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:07:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27747] "bugzilla-tool
 post-commit head" doesn't work because it can't find the bug id from the
 commit load. : [Attachment 33586] 2009-07-27 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27747-0@https.bugs.webkit.org/>
References: <bug-27747-0@https.bugs.webkit.org/>
Message-ID: <20090728010744.6ECC33411F67@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27747: "bugzilla-tool post-commit head" doesn't work because it can't find
the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

Attachment 33586: 2009-07-27  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33586&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
Reviewed by NOBODY (OOPS!).

"bugzilla-tool post-commit head" doesn't work because it can't find the bug id
from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

modules.bugzilla is not found because not included.

* Scripts/modules/scm.py: Properly import modules.bugzilla.
---
 2 files changed, 12 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 18:11:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:11:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27664] commit-log-editor
 should allow git commit --amend to regenerate the commit log based on the
 modifed ChangeLog : [Attachment 33585] 2009-07-24 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27664-0@https.bugs.webkit.org/>
References: <bug-27664-0@https.bugs.webkit.org/>
Message-ID: <20090728011107.CC3943411FAB@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27664: commit-log-editor should allow git commit --amend to regenerate the
commit log based on the modifed ChangeLog
https://bugs.webkit.org/show_bug.cgi?id=27664

Attachment 33585: 2009-07-24  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33585&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
> +sub usage
> +{
> +    print "Usage: [--help] [--regenerate-log] <log file>\n";
> +    exit 0;
> +}

The usage() method should always exit with a non-zero status.  I suggest "exit
1;".

r=me with the above change.  Thanks!

From bugzilla-daemon at webkit.org  Mon Jul 27 18:11:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:11:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27747] "bugzilla-tool
 post-commit head" doesn't work because it can't find the bug id from the
 commit load. : [Attachment 33586] 2009-07-27 Pierre d'Herbemont
 <pdherbemont@apple.com>
In-Reply-To: <bug-27747-0@https.bugs.webkit.org/>
References: <bug-27747-0@https.bugs.webkit.org/>
Message-ID: <20090728011138.B65973411FBB@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27747: "bugzilla-tool post-commit head" doesn't work because it can't find
the bug id from the commit load.
https://bugs.webkit.org/show_bug.cgi?id=27747

Attachment 33586: 2009-07-27  Pierre d'Herbemont  <pdherbemont at apple.com>
https://bugs.webkit.org/attachment.cgi?id=33586&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:22:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:22:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27669] [chromium] Default
 UI controls for <video> has rendering problems : [Attachment 33588] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090728012221.7750A34120B3@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33588: patch
https://bugs.webkit.org/attachment.cgi?id=33588&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:33:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:33:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27669] [chromium] Default UI
 controls for <video> has rendering problems : [Attachment 33588] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090728013314.17EDC34121AE@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has canceled Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33588: patch
https://bugs.webkit.org/attachment.cgi?id=33588&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:34:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:34:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27669] [chromium] Default
 UI controls for <video> has rendering problems : [Attachment 33589] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090728013417.4187834121DE@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33589: patch
https://bugs.webkit.org/attachment.cgi?id=33589&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:38:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:38:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27749] StyleChange::init
 needs clean up before fixing the bug 23892 : [Attachment 33590] fixes the
 bug
In-Reply-To: <bug-27749-0@https.bugs.webkit.org/>
References: <bug-27749-0@https.bugs.webkit.org/>
Message-ID: <20090728013828.743933412263@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27749: StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749

Attachment 33590: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33590&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:39:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:39:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27669] [chromium] Default UI
 controls for <video> has rendering problems : [Attachment 33589] patch
In-Reply-To: <bug-27669-0@https.bugs.webkit.org/>
References: <bug-27669-0@https.bugs.webkit.org/>
Message-ID: <20090728013921.32C833412283@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27669: [chromium] Default UI controls for <video> has rendering problems
https://bugs.webkit.org/show_bug.cgi?id=27669

Attachment 33589: patch
https://bugs.webkit.org/attachment.cgi?id=33589&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:44:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:44:45 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27749] StyleChange::init
 needs clean up before fixing the bug 23892 : [Attachment 33590] fixes the
 bug
In-Reply-To: <bug-27749-0@https.bugs.webkit.org/>
References: <bug-27749-0@https.bugs.webkit.org/>
Message-ID: <20090728014445.5C0E834122DC@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27749: StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749

Attachment 33590: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33590&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 18:53:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 18:53:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27749] StyleChange::init
 needs clean up before fixing the bug 23892 : [Attachment 33591] minor
 correction
In-Reply-To: <bug-27749-0@https.bugs.webkit.org/>
References: <bug-27749-0@https.bugs.webkit.org/>
Message-ID: <20090728015321.BB42E341238A@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27749: StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749

Attachment 33591: minor correction
https://bugs.webkit.org/attachment.cgi?id=33591&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 19:20:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 19:20:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27752] cpplint* should be
 named cpp_style* : [Attachment 33595] Proposed fix.
In-Reply-To: <bug-27752-0@https.bugs.webkit.org/>
References: <bug-27752-0@https.bugs.webkit.org/>
Message-ID: <20090728022009.553C03412600@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27752: cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752

Attachment 33595: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33595&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 19:30:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 19:30:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27752] cpplint* should be
 named cpp_style* : [Attachment 33596] Proposed fix.
In-Reply-To: <bug-27752-0@https.bugs.webkit.org/>
References: <bug-27752-0@https.bugs.webkit.org/>
Message-ID: <20090728023041.5AD6434126DF@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27752: cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752

Attachment 33596: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33596&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 19:30:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 19:30:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27752] cpplint* should be
 named cpp_style* : [Attachment 33595] Proposed fix.
In-Reply-To: <bug-27752-0@https.bugs.webkit.org/>
References: <bug-27752-0@https.bugs.webkit.org/>
Message-ID: <20090728023051.AC82234126F1@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled David Levin
<levin at chromium.org>'s request for review:
Bug 27752: cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752

Attachment 33595: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33595&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 20:16:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 20:16:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27748] crash w/ stack
 overflow when same CSS file loaded repeatedly : [Attachment 33597] patch
 for crash
In-Reply-To: <bug-27748-0@https.bugs.webkit.org/>
References: <bug-27748-0@https.bugs.webkit.org/>
Message-ID: <20090728031623.E217B3412AB9@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 27748: crash w/ stack overflow when same CSS file loaded repeatedly
https://bugs.webkit.org/show_bug.cgi?id=27748

Attachment 33597: patch for crash
https://bugs.webkit.org/attachment.cgi?id=33597&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 20:49:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 20:49:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27754] commit-log-editor
 does not produce a git commit log that is git friendly. : [Attachment
 33598] commit-log-editor does not produce a git commit log that is git
 friendly.
In-Reply-To: <bug-27754-0@https.bugs.webkit.org/>
References: <bug-27754-0@https.bugs.webkit.org/>
Message-ID: <20090728034925.84B8A3412CF5@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27754: commit-log-editor does not produce a git commit log that is git
friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

Attachment 33598: commit-log-editor does not produce a git commit log that is
git friendly.
https://bugs.webkit.org/attachment.cgi?id=33598&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=27754

Reviewed by NOBODY (OOPS!).

We make sure we end up with:
- A first paragraph describing the bug.
- The Reviewed By line
- The rest of the commit

We get rid of the date given that this is part of the commit info
in a more precise maneer, and also the author of the patch,
as this is also part of the commit information. Given that subversion
doesn't support different committer and author info, the line
would have to be added manually.

* Scripts/commit-log-editor:
---
 2 files changed, 51 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 20:52:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 20:52:03 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27748] crash w/ stack overflow
 when same CSS file loaded repeatedly : [Attachment 33597] patch for crash
In-Reply-To: <bug-27748-0@https.bugs.webkit.org/>
References: <bug-27748-0@https.bugs.webkit.org/>
Message-ID: <20090728035203.B9D9B3412D2B@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has denied Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 27748: crash w/ stack overflow when same CSS file loaded repeatedly
https://bugs.webkit.org/show_bug.cgi?id=27748

Attachment 33597: patch for crash
https://bugs.webkit.org/attachment.cgi?id=33597&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
> -	   ~CSSRuleDataList() { delete m_first; }
> +	   ~CSSRuleDataList() { 

{ should be on the next line.

> +	     CSSRuleData* ptr;
> +	     CSSRuleData* next;
> +	     ptr = m_first;
> +	     while (ptr) {
> +	       next = ptr->next();
> +	       delete ptr;
> +	       ptr = next;
> +	     }
> +	   }

This should use 4 spaces for indentation.

You have also marked the tests as executable which is not correct.  Is there no
programatic way to test this using JS?

r-.

From bugzilla-daemon at webkit.org  Mon Jul 27 20:59:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 20:59:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27724] [WML] <do> elements
 with a <noop> task shouldn't be exposed to the user : [Attachment 33584]
 Initial patch
In-Reply-To: <bug-27724-0@https.bugs.webkit.org/>
References: <bug-27724-0@https.bugs.webkit.org/>
Message-ID: <20090728035928.1C3753412DBE@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27724: [WML] <do> elements with a <noop> task shouldn't be exposed to the
user
https://bugs.webkit.org/show_bug.cgi?id=27724

Attachment 33584: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33584&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 21:11:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 21:11:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27755] Layout tests that
 dump resource load delegate calls should dump the request method and the
 response status code. : [Attachment 33599] DRT changes and updated layout
 tests
In-Reply-To: <bug-27755-0@https.bugs.webkit.org/>
References: <bug-27755-0@https.bugs.webkit.org/>
Message-ID: <20090728041109.2231A3412ECD@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27755: Layout tests that dump resource load delegate calls should dump the
request method and the response status code.
https://bugs.webkit.org/show_bug.cgi?id=27755

Attachment 33599: DRT changes and updated layout tests
https://bugs.webkit.org/attachment.cgi?id=33599&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 21:12:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 21:12:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27755] Layout tests that dump
 resource load delegate calls should dump the request method and the
 response status code. : [Attachment 33599] DRT changes and updated layout
 tests
In-Reply-To: <bug-27755-0@https.bugs.webkit.org/>
References: <bug-27755-0@https.bugs.webkit.org/>
Message-ID: <20090728041255.617AE3412F01@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 27755: Layout tests that dump resource load delegate calls should dump the
request method and the response status code.
https://bugs.webkit.org/show_bug.cgi?id=27755

Attachment 33599: DRT changes and updated layout tests
https://bugs.webkit.org/attachment.cgi?id=33599&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 21:25:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 21:25:17 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27754] commit-log-editor
 does not produce a git commit log that is git friendly. : [Attachment
 33598] commit-log-editor does not produce a git commit log that is git
 friendly.
In-Reply-To: <bug-27754-0@https.bugs.webkit.org/>
References: <bug-27754-0@https.bugs.webkit.org/>
Message-ID: <20090728042517.D19F53413012@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27754: commit-log-editor does not produce a git commit log that is git
friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

Attachment 33598: commit-log-editor does not produce a git commit log that is
git friendly.
https://bugs.webkit.org/attachment.cgi?id=33598&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 21:25:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 21:25:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27754] commit-log-editor
 does not produce a git commit log that is git friendly. : [Attachment
 33601] commit-log-editor does not produce a git commit log that is git
 friendly.
In-Reply-To: <bug-27754-0@https.bugs.webkit.org/>
References: <bug-27754-0@https.bugs.webkit.org/>
Message-ID: <20090728042519.E16B23413019@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27754: commit-log-editor does not produce a git commit log that is git
friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

Attachment 33601: commit-log-editor does not produce a git commit log that is
git friendly.
https://bugs.webkit.org/attachment.cgi?id=33601&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=27754

Reviewed by NOBODY (OOPS!).

We make sure we end up with:
- A first paragraph describing the bug.
- The Reviewed By line.
- An eventual Patch By line if author and committer doesn't match.
- The rest of the commit.

* Scripts/commit-log-editor:
---
 2 files changed, 66 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 21:35:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 21:35:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27754] commit-log-editor
 does not produce a git commit log that is git friendly. : [Attachment
 33601] commit-log-editor does not produce a git commit log that is git
 friendly.
In-Reply-To: <bug-27754-0@https.bugs.webkit.org/>
References: <bug-27754-0@https.bugs.webkit.org/>
Message-ID: <20090728043556.A2A9C34130EF@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 27754: commit-log-editor does not produce a git commit log that is git
friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

Attachment 33601: commit-log-editor does not produce a git commit log that is
git friendly.
https://bugs.webkit.org/attachment.cgi?id=33601&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 21:35:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 21:35:58 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27754] commit-log-editor
 does not produce a git commit log that is git friendly. : [Attachment
 33602] commit-log-editor does not produce a git commit log that is git
 friendly.
In-Reply-To: <bug-27754-0@https.bugs.webkit.org/>
References: <bug-27754-0@https.bugs.webkit.org/>
Message-ID: <20090728043558.EC2F434130F6@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 27754: commit-log-editor does not produce a git commit log that is git
friendly.
https://bugs.webkit.org/show_bug.cgi?id=27754

Attachment 33602: commit-log-editor does not produce a git commit log that is
git friendly.
https://bugs.webkit.org/attachment.cgi?id=33602&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=27754

Reviewed by NOBODY (OOPS!).

We make sure we end up with:
- A first paragraph describing the bug. It is eventually prefixed by
"WebKit: <line>" or "WebCore: <line>". This used to be
"WebCore:\n\n<line>".
- The Reviewed By line.
- An eventual Patch By line if author and committer doesn't match.
- The rest of the commit.

* Scripts/commit-log-editor:
---
 2 files changed, 69 insertions(+), 3 deletions(-)

From bugzilla-daemon at webkit.org  Mon Jul 27 23:31:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 23:31:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27757]
 update-webkit-auxiliary-libs,
 update-webkit-support-libs cause Perl warnings about functions tmpnam and
 tmpfile : [Attachment 33603] Patch
In-Reply-To: <bug-27757-0@https.bugs.webkit.org/>
References: <bug-27757-0@https.bugs.webkit.org/>
Message-ID: <20090728063141.010593413A57@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27757: update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl
warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33603: Patch
https://bugs.webkit.org/attachment.cgi?id=33603&action=review

From bugzilla-daemon at webkit.org  Mon Jul 27 23:35:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Mon, 27 Jul 2009 23:35:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27756] [HTML5][Forms]
 Support for HTMLInputElement::list and HTMLInputElement::selectedOption :
 [Attachment 33604] Support for HTMLInputElement::list and
 HTMLInputElement::selectedOption.
In-Reply-To: <bug-27756-0@https.bugs.webkit.org/>
References: <bug-27756-0@https.bugs.webkit.org/>
Message-ID: <20090728063510.9D8F83413A92@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27756: [HTML5][Forms] Support for HTMLInputElement::list and
HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33604: Support for HTMLInputElement::list and
HTMLInputElement::selectedOption.
https://bugs.webkit.org/attachment.cgi?id=33604&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>

---
 10 files changed, 274 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 28 00:45:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 00:45:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26750] Allow custom memory
 allocation control for JavaScriptCore/runtime directory's classes :
 [Attachment 33606] updated proposed patch
In-Reply-To: <bug-26750-0@https.bugs.webkit.org/>
References: <bug-26750-0@https.bugs.webkit.org/>
Message-ID: <20090728074536.EF9BA34140D3@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 26750: Allow custom memory allocation control for JavaScriptCore/runtime
directory's classes
https://bugs.webkit.org/show_bug.cgi?id=26750

Attachment 33606: updated proposed patch
https://bugs.webkit.org/attachment.cgi?id=33606&action=review

------- Additional Comments from Zoltan Horvath <hzoltan at inf.u-szeged.hu>
I need to send one patch for one class, so we will see which causes the
assertion.

From bugzilla-daemon at webkit.org  Tue Jul 28 01:36:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 01:36:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27695] There are many DOM
 Storage corner cases the layout tests don't currently cover. : [Attachment
 33517] v1
In-Reply-To: <bug-27695-0@https.bugs.webkit.org/>
References: <bug-27695-0@https.bugs.webkit.org/>
Message-ID: <20090728083626.BC1223414523@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27695: There are many DOM Storage corner cases the layout tests don't
currently cover.
https://bugs.webkit.org/show_bug.cgi?id=27695

Attachment 33517: v1
https://bugs.webkit.org/attachment.cgi?id=33517&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yay tests.  One comment:

+ log("window.sessionStorage == window.sessionStorage: " +
(window.sessionStorage == window.sessionStorage));

You should test === too (in both places).

From bugzilla-daemon at webkit.org  Tue Jul 28 02:21:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 02:21:17 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27697] WorkerThread needs to
 be refactored to separate out dedicated-worker functionality : [Attachment
 33522] proposed patch
In-Reply-To: <bug-27697-0@https.bugs.webkit.org/>
References: <bug-27697-0@https.bugs.webkit.org/>
Message-ID: <20090728092117.8CAFC341496B@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Andrew Wilson
<atwilson at google.com>'s request for review:
Bug 27697: WorkerThread needs to be refactored to separate out dedicated-worker
functionality
https://bugs.webkit.org/show_bug.cgi?id=27697

Attachment 33522: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33522&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebCore/workers/WorkerThread.h b/WebCore/workers/WorkerThread.h
> +	   WorkerContext* workerContext() { return m_workerContext.get(); }

Can this ever return 0?

If not, consider making it return WorkerContext&.

From bugzilla-daemon at webkit.org  Tue Jul 28 02:30:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 02:30:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33435] When clearing the plugin
 database, clear also the timestamp map.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090728093040.470F23414A57@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled  review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33435: When clearing the plugin database, clear also the timestamp
map.
https://bugs.webkit.org/attachment.cgi?id=33435&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing review on this one as it has been landed

From bugzilla-daemon at webkit.org  Tue Jul 28 02:44:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 02:44:59 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26952] WebCore Support for the
 Haiku WebKit port : [Attachment 32860] Patch to add FrameLoaderClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090728094459.A71273414B6E@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 32860: Patch to add FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=32860&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few issues to address.


> diff --git a/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp
b/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.cpp
> +/*
> + * Copyright (C) 2006 Don Gibson <dgibson77 at gmail.com>
> + * Copyright (C) 2006 Zack Rusin <zack at kde.org>
> + * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2007 Trolltech ASA
> + * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
> + *
> + * All rights reserved.

This is an odd location for "All rights reserved."  It typically follows the
copyright lines.

> +#include "config.h"
> +#include "FrameLoaderClientHaiku.h"
> +
> +#include "DocumentLoader.h"
> +#include "FrameLoader.h"
> +#include "FrameTree.h"
> +#include "Frame.h"
> +#include "FrameView.h"
> +#include "HTMLFrameOwnerElement.h"
> +#include "Page.h"
> +#include "PlatformString.h"
> +#include "ResourceRequest.h"
> +
> +#include "NotImplemented.h"
This appears out of sort order.

> +void FrameLoaderClientHaiku::setWebView(WebView* webview)
webView

> +bool FrameLoaderClientHaiku::hasWebView() const
> +{
> +    return m_webView != NULL;
Avoid NULL (use 0), but also avoid comparisons to 0/NULL.

    return m_webView;

> +void FrameLoaderClientHaiku::dispatchWillPerformClientRedirect(const KURL&,
> +								  double
interval,
> +								  double
fireDate)
Feel free to unwrap these parameters into one line.


> +void FrameLoaderClientHaiku::didChangeTitle(DocumentLoader *docLoader)

"*" in wrong location. (DocumentLoader* docLoader)



> +    if (m_firstData) {
> +	   FrameLoader *frameLoader = loader->frameLoader();

"*" in wrong location.

> +{
> +	// FIXME:

Indentation is off.


> diff --git a/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h
b/WebKit/haiku/WebCoreSupport/FrameLoaderClientHaiku.h
> @@ -0,0 +1,248 @@
> +/*
> + * Copyright (C) 2006 Zack Rusin <zack at kde.org>
> + * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
> + *
> + * All rights reserved.

Same comment as before.

> +#ifndef FrameLoaderClientHaiku_H

Use lowercase h like this:
FrameLoaderClientHaiku_h

> +#include "FrameLoaderClient.h"
> +#include "FrameLoader.h"

Out of sort order.

> +    class NavigationAction;
> +    class String;
> +    class ResourceLoader;

Out of sort order.

> +	   void setFrame(Frame *frame);

Remove parameter names if they don't add any information.
This should be 
  "void setFrame(Frame*);"

> +	   void setWebView(WebView *webview);

Remove parameter names if they don't add any information.


> +	   virtual void dispatchDecidePolicyForMIMEType(FramePolicyFunction
function,

Remove parameter names if they don't add any information.

> +	   virtual void
dispatchDecidePolicyForNewWindowAction(FramePolicyFunction function,

Remove parameter names if they don't add any information.

> +	   virtual void
dispatchDecidePolicyForNavigationAction(FramePolicyFunction function,

Remove parameter names if they don't add any information.


> +	   // FIXME: This should probably not be here, but it's needed for the
tests currently
Add "."


> +	   virtual PassRefPtr<Frame> createFrame(const KURL& url, const String&
name,
> +						 HTMLFrameOwnerElement*
ownerElement,

Remove parameter names if they don't add any information: ownerElement.


> +	   virtual PassRefPtr<Widget> createPlugin(const IntSize&,
HTMLPlugInElement*, const KURL&,
> +					const Vector<String>&, const
Vector<String>&, const String&,

indentation is off.

> +					bool loadManually) ;

> +
> +	   virtual PassRefPtr<Widget> createJavaAppletWidget(const IntSize&,
HTMLAppletElement*,
> +						  const KURL& baseURL, const
Vector<String>& paramNames,

indentation is off.

> +						  const Vector<String>&
paramValues);

> +	   Frame *m_frame;

"*" in wrong location.

> +	   WebView *m_webView;

"*" in wrong location.

From bugzilla-daemon at webkit.org  Tue Jul 28 02:50:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 02:50:01 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26952] WebCore Support for the
 Haiku WebKit port : [Attachment 33037] Patch to add ChromeClient for Haiku
 WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090728095001.AB5D13414BCA@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33037: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33037&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few comments to address and this will be ready to land.

> diff --git a/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp
b/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.cpp
> @@ -0,0 +1,360 @@
> +/*
> + * Copyright (C) 2006 Zack Rusin <zack at kde.org>
> + * Copyright (C) 2006 Apple Computer, Inc.  All rights reserved.
> + * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
> + *
> + * All rights reserved.

Looks odd as before.
> +
> +#include "Frame.h"
> +#include "FrameView.h"
> +#include "FrameLoadRequest.h"
> +#include "PlatformString.h"
> +#include "HitTestResult.h"
> +
> +#include "NotImplemented.h"

Sort all of these.


> diff --git a/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h
b/WebKit/haiku/WebCoreSupport/ChromeClientHaiku.h
> + * Copyright (C) 2006 Zack Rusin <zack at kde.org>
> + * Copyright (C) 2007 Ryan Leavengood <leavengood at gmail.com>
> + *
> + * All rights reserved.

Ditto :)

> +#ifndef ChromeClientHaiku_H

Use "_h" instead of "_H"

From bugzilla-daemon at webkit.org  Tue Jul 28 03:03:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:03:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 33607] Patch to add ChromeClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090728100306.620643414D2A@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33607: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33607&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 03:22:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:22:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 33608] Patch to add FrameLoaderClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090728102233.3F7693414F12@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33608: Patch to add FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33608&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 03:22:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:22:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 24986] ARM JIT port :
 [Attachment 32181] Add generic ARM-JIT support using ARMAssembler
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090728102236.37CC63414F27@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has canceled Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32181: Add generic ARM-JIT support using ARMAssembler
https://bugs.webkit.org/attachment.cgi?id=32181&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 03:22:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:22:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
 [Attachment 33609] Add generic ARM-JIT support using ARMAssembler v2
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090728102236.642063414F2B@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 33609: Add generic ARM-JIT support using ARMAssembler v2
https://bugs.webkit.org/attachment.cgi?id=33609&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 03:23:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:23:25 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 24986] ARM JIT port :
 [Attachment 32182] Floating point support for ARM. Looks like we double the
 number of patches each day :)
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090728102325.E73C93414F62@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has canceled Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 32182: Floating point support for ARM. Looks like we double the
number of patches each day :)
https://bugs.webkit.org/attachment.cgi?id=32182&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 03:23:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:23:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
 [Attachment 33610] Floating point support for ARM v2
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090728102326.2011C3414F66@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 33610: Floating point support for ARM v2
https://bugs.webkit.org/attachment.cgi?id=33610&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 03:26:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:26:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
 [Attachment 33611] Add optimize call support for ARM JIT
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090728102607.81FE13414FC9@gamma.macosforge.org>

Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 33611: Add optimize call support for ARM JIT
https://bugs.webkit.org/attachment.cgi?id=33611&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
This patch adds support for ENABLE_JIT_OPTIMIZE_CALL and
ENABLE_JIT_OPTIMIZE_NATIVE_CALL optimizations.

From bugzilla-daemon at webkit.org  Tue Jul 28 03:27:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:27:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 24986] ARM JIT port :
 [Attachment 33612] Add property access support for ARM JIT
In-Reply-To: <bug-24986-0@https.bugs.webkit.org/>
References: <bug-24986-0@https.bugs.webkit.org/>
Message-ID: <20090728102747.A4B933415014@gamma.macosforge.org>

Gabor Loki <loki at inf.u-szeged.hu> has asked  for review:
Bug 24986: ARM JIT port
https://bugs.webkit.org/show_bug.cgi?id=24986

Attachment 33612: Add property access support for ARM JIT
https://bugs.webkit.org/attachment.cgi?id=33612&action=review

------- Additional Comments from Gabor Loki <loki at inf.u-szeged.hu>
This patch adds support for ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS and
ENABLE_JIT_OPTIMIZE_METHOD_CALLS optimizations.

From bugzilla-daemon at webkit.org  Tue Jul 28 03:28:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:28:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33565]
 dontcachelayout.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090728102823.2BD8E341504E@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33565: dontcachelayout.patch
https://bugs.webkit.org/attachment.cgi?id=33565&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
There is also an updateLayout callback that currently updates the patch. rs=me
on removing the callback and the signal connections, too.

From bugzilla-daemon at webkit.org  Tue Jul 28 03:48:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 03:48:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27760]
 HTMLOptionElement::value() returns incorrect value : [Attachment 33613]
 patch
In-Reply-To: <bug-27760-0@https.bugs.webkit.org/>
References: <bug-27760-0@https.bugs.webkit.org/>
Message-ID: <20090728104848.39FC3341524B@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27760: HTMLOptionElement::value() returns incorrect value
https://bugs.webkit.org/show_bug.cgi?id=27760

Attachment 33613: patch
https://bugs.webkit.org/attachment.cgi?id=33613&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 04:30:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 04:30:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27758] Web Inspector: Add
 inspected node using public console API. : [Attachment 33614] Patch
In-Reply-To: <bug-27758-0@https.bugs.webkit.org/>
References: <bug-27758-0@https.bugs.webkit.org/>
Message-ID: <20090728113028.35EB43415621@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27758: Web Inspector: Add inspected node using public console API.
https://bugs.webkit.org/show_bug.cgi?id=27758

Attachment 33614: Patch
https://bugs.webkit.org/attachment.cgi?id=33614&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 05:06:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 05:06:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27758] Web Inspector: Add
 inspected node using public console API. : [Attachment 33614] Patch
In-Reply-To: <bug-27758-0@https.bugs.webkit.org/>
References: <bug-27758-0@https.bugs.webkit.org/>
Message-ID: <20090728120629.3560A3415BBB@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27758: Web Inspector: Add inspected node using public console API.
https://bugs.webkit.org/show_bug.cgi?id=27758

Attachment 33614: Patch
https://bugs.webkit.org/attachment.cgi?id=33614&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 05:25:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 05:25:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27709] [Qt] Disable some
 compiler warnings for the win build : [Attachment 33541] proposed patch.
In-Reply-To: <bug-27709-0@https.bugs.webkit.org/>
References: <bug-27709-0@https.bugs.webkit.org/>
Message-ID: <20090728122554.20C2B3415DD2@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27709: [Qt] Disable some compiler warnings for the win build
https://bugs.webkit.org/show_bug.cgi?id=27709

Attachment 33541: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33541&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Thanks :)

From bugzilla-daemon at webkit.org  Tue Jul 28 06:01:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:01:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27512] Test for
 QWebFrame::hasSetFocus() is trying to use a not defined resource. :
 [Attachment 33560] Using QSignalSpy to control whether a load finished
 signal has been emited instead of just wait for some miliseconds.
In-Reply-To: <bug-27512-0@https.bugs.webkit.org/>
References: <bug-27512-0@https.bugs.webkit.org/>
Message-ID: <20090728130154.14C1F341612B@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Andre Pedralho
<apedralho at gmail.com>'s request for review:
Bug 27512: Test for QWebFrame::hasSetFocus() is trying to use a not defined
resource.
https://bugs.webkit.org/show_bug.cgi?id=27512

Attachment 33560: Using QSignalSpy to control whether a load finished signal
has been emited instead of just wait for some miliseconds.
https://bugs.webkit.org/attachment.cgi?id=33560&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Thanks

From bugzilla-daemon at webkit.org  Tue Jul 28 06:11:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:11:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33618] Initial version
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090728131108.7C9D83416261@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has asked  for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33618: Initial version
https://bugs.webkit.org/attachment.cgi?id=33618&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 06:15:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:15:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27655] [v8] cache v8
 strings when converting from webcore string to v8 string : [Attachment
 33619] Next iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090728131508.A1DBA34162D0@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33619: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33619&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 06:34:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:34:35 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33618] Initial version
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090728133435.212AD3416515@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has canceled
Christian Plesner Hansen <christian.plesner.hansen at gmail.com>'s request for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33618: Initial version
https://bugs.webkit.org/attachment.cgi?id=33618&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 06:34:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:34:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33620] Updated ChangeLog
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090728133435.379D63416517@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has asked  for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33620: Updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33620&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 06:41:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:41:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27765] Added project
 properties as needed by symbian platform : [Attachment 33621] Patch for
 WebCore.pro
In-Reply-To: <bug-27765-0@https.bugs.webkit.org/>
References: <bug-27765-0@https.bugs.webkit.org/>
Message-ID: <20090728134112.7E0E53416579@gamma.macosforge.org>

Norbert Leser <norbert.leser at nokia.com> has asked  for review:
Bug 27765: Added project properties as needed by symbian platform
https://bugs.webkit.org/show_bug.cgi?id=27765

Attachment 33621: Patch for WebCore.pro
https://bugs.webkit.org/attachment.cgi?id=33621&action=review

------- Additional Comments from Norbert Leser <norbert.leser at nokia.com>
Attached patch contains project properties, such as memory allocation size,
that are needed for Symbian platform.
These properties are defined within a conditional symbian block.

From bugzilla-daemon at webkit.org  Tue Jul 28 06:50:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:50:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27763] PopupMenuQt lacks
 proper separator : [Attachment 33622] Patch to replace separator and fix
 include order.
In-Reply-To: <bug-27763-0@https.bugs.webkit.org/>
References: <bug-27763-0@https.bugs.webkit.org/>
Message-ID: <20090728135036.05A65341668C@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33622: Patch to replace separator and fix include order.
https://bugs.webkit.org/attachment.cgi?id=33622&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 06:52:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 06:52:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27766] Web Inspector:
 encapsulate ScriptState into the ScriptObject,
 get rid of InspectorJSONObject : [Attachment 33623] patch
In-Reply-To: <bug-27766-0@https.bugs.webkit.org/>
References: <bug-27766-0@https.bugs.webkit.org/>
Message-ID: <20090728135256.949AA34166D7@gamma.macosforge.org>

Pavel Feldman <pfeldman at chromium.org> has asked  for review:
Bug 27766: Web Inspector: encapsulate ScriptState into the ScriptObject, get
rid of InspectorJSONObject
https://bugs.webkit.org/show_bug.cgi?id=27766

Attachment 33623: patch
https://bugs.webkit.org/attachment.cgi?id=33623&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:04:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:04:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27716] Add Geolocation
 layout tests. : [Attachment 33625] Patch for bug 27716
In-Reply-To: <bug-27716-0@https.bugs.webkit.org/>
References: <bug-27716-0@https.bugs.webkit.org/>
Message-ID: <20090728140453.E0739341684A@gamma.macosforge.org>

steveblock at google.com has asked  for review:
Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Attachment 33625: Patch for bug 27716
https://bugs.webkit.org/attachment.cgi?id=33625&action=review

------- Additional Comments from steveblock at google.com
A patch to add the first couple of unit tests, which simply test that
navigator.geolocation is present only when is is supposed to be.

From bugzilla-daemon at webkit.org  Tue Jul 28 07:09:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:09:34 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27763] PopupMenuQt lacks
 proper separator : [Attachment 33622] Patch to replace separator and fix
 include order.
In-Reply-To: <bug-27763-0@https.bugs.webkit.org/>
References: <bug-27763-0@https.bugs.webkit.org/>
Message-ID: <20090728140934.EEF7C34168A4@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33622: Patch to replace separator and fix include order.
https://bugs.webkit.org/attachment.cgi?id=33622&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
>	   if (client()->itemIsSeparator(i)) {
> -	       //FIXME: better seperator item
> -	       m_popup->insertItem(i, QString::fromLatin1("---"));
> +	       m_popup->insertSeparator(i);
>	   } else {

Looks like you can remove the braces now from the if clause.  cpplint didn't
catch it?  Also, you can go ahead and remove the #if 0 code.  If it is
important somehow, that's what we have revision control systems for :)

From bugzilla-daemon at webkit.org  Tue Jul 28 07:10:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:10:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33626] Updated patch, rebased against ToT and fixed windows and mac builds.
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090728141040.E354E34168DA@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33626: Updated patch, rebased against ToT and fixed windows and mac
builds.
https://bugs.webkit.org/attachment.cgi?id=33626&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:11:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:11:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33627] Rebased patch to build JavaScriptCore as shared library with Qt
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090728141132.D851B3416917@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33627: Rebased patch to build JavaScriptCore as shared library with
Qt
https://bugs.webkit.org/attachment.cgi?id=33627&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:20:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:20:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33620] Updated ChangeLog
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090728142014.A1B053416A20@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has canceled
Christian Plesner Hansen <christian.plesner.hansen at gmail.com>'s request for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33620: Updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33620&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:20:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:20:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33628] Check that cached
 atomic string stay on the main thread
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090728142026.9BCCC3416A36@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has asked  for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33628: Check that cached atomic string stay on the main thread
https://bugs.webkit.org/attachment.cgi?id=33628&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:22:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:22:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27763] PopupMenuQt lacks
 proper separator : [Attachment 33629] Improved Style patch
In-Reply-To: <bug-27763-0@https.bugs.webkit.org/>
References: <bug-27763-0@https.bugs.webkit.org/>
Message-ID: <20090728142211.38ADA3416A7D@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33629: Improved Style patch
https://bugs.webkit.org/attachment.cgi?id=33629&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Thanks for the quick review.

This patch removes the braces for both the if and the else as well as removes
the unimplemented code block.

From bugzilla-daemon at webkit.org  Tue Jul 28 07:37:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:37:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27763] PopupMenuQt lacks
 proper separator : [Attachment 33629] Improved Style patch
In-Reply-To: <bug-27763-0@https.bugs.webkit.org/>
References: <bug-27763-0@https.bugs.webkit.org/>
Message-ID: <20090728143713.8D2953416C2C@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has canceled Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33629: Improved Style patch
https://bugs.webkit.org/attachment.cgi?id=33629&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:37:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:37:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27763] PopupMenuQt lacks
 proper separator : [Attachment 33630] Remove extra brace from patch.
In-Reply-To: <bug-27763-0@https.bugs.webkit.org/>
References: <bug-27763-0@https.bugs.webkit.org/>
Message-ID: <20090728143713.BB9223416C30@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33630: Remove extra brace from patch.
https://bugs.webkit.org/attachment.cgi?id=33630&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:38:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:38:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27763] PopupMenuQt lacks
 proper separator : [Attachment 33630] Remove extra brace from patch.
In-Reply-To: <bug-27763-0@https.bugs.webkit.org/>
References: <bug-27763-0@https.bugs.webkit.org/>
Message-ID: <20090728143854.67E053416C64@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27763: PopupMenuQt lacks proper separator
https://bugs.webkit.org/show_bug.cgi?id=27763

Attachment 33630: Remove extra brace from patch.
https://bugs.webkit.org/attachment.cgi?id=33630&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:46:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:46:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27725] [WML] Page title
 doesn't update after variable substitution,
 if it contained variables : [Attachment 33631] Initial patch
In-Reply-To: <bug-27725-0@https.bugs.webkit.org/>
References: <bug-27725-0@https.bugs.webkit.org/>
Message-ID: <20090728144611.8505C3416D34@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27725: [WML] Page title doesn't update after variable substitution, if it
contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725

Attachment 33631: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33631&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:50:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:50:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27725] [WML] Page title
 doesn't update after variable substitution,
 if it contained variables : [Attachment 33631] Initial patch
In-Reply-To: <bug-27725-0@https.bugs.webkit.org/>
References: <bug-27725-0@https.bugs.webkit.org/>
Message-ID: <20090728145003.BD9FE3416DAD@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27725: [WML] Page title doesn't update after variable substitution, if it
contained variables
https://bugs.webkit.org/show_bug.cgi?id=27725

Attachment 33631: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33631&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 07:57:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 07:57:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27158] Add WebKit version API
 to Qt. : [Attachment 33559] Updated patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090728145740.866073416ED5@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted robert
<robert at roberthogan.net>'s request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 33559: Updated patch
https://bugs.webkit.org/attachment.cgi?id=33559&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Thanks!

I'll move the script to WebKit/scripts when landing, as that's a slightly more
appropriate place I realize for a script that parses stuff from WebKit/ instead
of WebCore/ :)

From bugzilla-daemon at webkit.org  Tue Jul 28 08:27:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 08:27:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27726] [WML] Variable
 substitution recursion seems to have bugs : [Attachment 33642] Initial
 patch
In-Reply-To: <bug-27726-0@https.bugs.webkit.org/>
References: <bug-27726-0@https.bugs.webkit.org/>
Message-ID: <20090728152722.06CE53417304@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27726: [WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726

Attachment 33642: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33642&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 08:29:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 08:29:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27752] cpplint* should be
 named cpp_style* : [Attachment 33596] Proposed fix.
In-Reply-To: <bug-27752-0@https.bugs.webkit.org/>
References: <bug-27752-0@https.bugs.webkit.org/>
Message-ID: <20090728152945.C3BF3341736F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27752: cpplint* should be named cpp_style*
https://bugs.webkit.org/show_bug.cgi?id=27752

Attachment 33596: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33596&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 08:31:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 08:31:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27726] [WML] Variable
 substitution recursion seems to have bugs : [Attachment 33642] Initial
 patch
In-Reply-To: <bug-27726-0@https.bugs.webkit.org/>
References: <bug-27726-0@https.bugs.webkit.org/>
Message-ID: <20090728153135.B249C34173DC@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27726: [WML] Variable substitution recursion seems to have bugs
https://bugs.webkit.org/show_bug.cgi?id=27726

Attachment 33642: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33642&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 08:38:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 08:38:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 24932] WebKit compilation
 support in Solaris 10 with Sun Studio 12 (CC 5.9) : [Attachment 33636]
 [PATCH 05/17] Fix crash misaligned reads on Sparc processors.
In-Reply-To: <bug-24932-0@https.bugs.webkit.org/>
References: <bug-24932-0@https.bugs.webkit.org/>
Message-ID: <20090728153826.BFC81341754B@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted  review:
Bug 24932: WebKit compilation support in Solaris 10 with Sun Studio 12 (CC 5.9)
https://bugs.webkit.org/show_bug.cgi?id=24932

Attachment 33636: [PATCH 05/17] Fix crash misaligned reads on Sparc processors.
https://bugs.webkit.org/attachment.cgi?id=33636&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 08:43:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 08:43:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27766] Web Inspector:
 encapsulate ScriptState into the ScriptObject,
 get rid of InspectorJSONObject : [Attachment 33623] patch
In-Reply-To: <bug-27766-0@https.bugs.webkit.org/>
References: <bug-27766-0@https.bugs.webkit.org/>
Message-ID: <20090728154356.5A6DA34175DC@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27766: Web Inspector: encapsulate ScriptState into the ScriptObject, get
rid of InspectorJSONObject
https://bugs.webkit.org/show_bug.cgi?id=27766

Attachment 33623: patch
https://bugs.webkit.org/attachment.cgi?id=33623&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me.

This limits usefulness of the ScriptObject, but sure makes the code more
legible/pretty. In any case, we could always add
ScriptObject::setState(ScriptState*) later if we need it.

From bugzilla-daemon at webkit.org  Tue Jul 28 08:48:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 08:48:17 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27655] [v8] cache v8 strings
 when converting from webcore string to v8 string : [Attachment 33619] Next
 iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090728154817.D605F341765C@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33619: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33619&action=review

------- Additional Comments from David Levin <levin at chromium.org>
"
> +#include "StringHash.h"
> +#include "Threading.h"
> +#include "ThreadSpecific.h"

Case sensitive sorting, so it should be:

#include "ThreadSpecific.h"
#include "Threading.h"


> +// Returns thread-specific version of string cache
> +static StringCache& getStringCache()
> +{
> +    if (WTF::isMainThread())
> +    {
> +	   DEFINE_STATIC_LOCAL(StringCache, mainThreadStringCache, ());
> +	   return mainThreadStringCache;
> +    }
> +
> +    DEFINE_STATIC_LOCAL(WTF::ThreadSpecific<StringCache>, threadStringCache,
());


This looks like it has a race condition. (specifically the allocation of
ThreadSpecific<StringCache>.)
Please add a comment about why it isn't or consider switching to using
AtomicallyInitializedStatic (from
wtf/Threading.h).

> +static void cachedStringCallback(v8::Persistent<v8::Value> wrapper, void*
parameter)
> +{
> +    StringImpl* stringImpl = static_cast<StringImpl*>(parameter);
> +    ASSERT(getStringCache().contains(stringImpl));
> +    getStringCache().remove(stringImpl);
> +    wrapper.Dispose();
> +    stringImpl->deref();

It is my understanding that v8 garbage collection may be done on any thread. 
If that is the case, then the code would be broken because getStringCache()
returns a thread specific value.

(Even if you got the right string cache, you'd run into problems with
StringCache and StringImpl::Deref not being threadsafe.)

From bugzilla-daemon at webkit.org  Tue Jul 28 09:41:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 09:41:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 33651] proposed patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090728164110.7244A3417CD9@gamma.macosforge.org>

Robert Agoston <Agoston.Robert at stud.u-szeged.hu> has asked  for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 33651: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33651&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 09:50:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 09:50:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27158] Add WebKit version API
 to Qt. : [Attachment 33651] proposed patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090728165010.0D98C3417E3D@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Robert Agoston
<Agoston.Robert at stud.u-szeged.hu>'s request for review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 33651: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33651&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Mea culpa, I was sure I had that fixed when landing, but looks like it
slipped ;(

From bugzilla-daemon at webkit.org  Tue Jul 28 10:11:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:11:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 33559] Updated patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090728171106.03FC934180A4@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled  review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 33559: Updated patch
https://bugs.webkit.org/attachment.cgi?id=33559&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing review, as it needs more work. Will look at the dll linkage warning
and remove the macros from the enums.

From bugzilla-daemon at webkit.org  Tue Jul 28 10:12:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:12:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27158] Add WebKit version
 API to Qt. : [Attachment 33651] proposed patch
In-Reply-To: <bug-27158-0@https.bugs.webkit.org/>
References: <bug-27158-0@https.bugs.webkit.org/>
Message-ID: <20090728171228.DEFFB34180EE@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled  review:
Bug 27158: Add WebKit version API to Qt.
https://bugs.webkit.org/show_bug.cgi?id=27158

Attachment 33651: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33651&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing for this one, too.

From bugzilla-daemon at webkit.org  Tue Jul 28 10:16:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:16:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27765] Added project
 properties as needed by symbian platform : [Attachment 33621] Patch for
 WebCore.pro
In-Reply-To: <bug-27765-0@https.bugs.webkit.org/>
References: <bug-27765-0@https.bugs.webkit.org/>
Message-ID: <20090728171632.70FDC34181C0@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Norbert Leser
<norbert.leser at nokia.com>'s request for review:
Bug 27765: Added project properties as needed by symbian platform
https://bugs.webkit.org/show_bug.cgi?id=27765

Attachment 33621: Patch for WebCore.pro
https://bugs.webkit.org/attachment.cgi?id=33621&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems sane.

From bugzilla-daemon at webkit.org  Tue Jul 28 10:27:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:27:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33628] Check that cached
 atomic string stay on the main thread
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090728172712.3151A34182A8@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Christian Plesner Hansen
<christian.plesner.hansen at gmail.com>'s request for review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33628: Check that cached atomic string stay on the main thread
https://bugs.webkit.org/attachment.cgi?id=33628&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
There are tabs in your ChangeLog.

m_atomic_impl is not WebKit style.  m_atomicString would be, or m_atomicImpl
(although we've historically tried to kill Impl, excepting a few places)

+	 if (m_atomic_impl.isNull()) {
+	     m_atomic_impl = AtomicString(m_impl);
+	 }

is not WK style.

WK uses 4 space indent:
+    if (!v8String->MakeExternal(resource)) {
+      // In case of a failure delete the external resource as it was not used.

+      delete resource;
+    }

I think you should consider running WebKit's copy of cpplint, it's found in
WebKitTools/Scripts/


JSC does this by passing UStrings directly to an AtomicString constructor
(they're implicitly constructed when getElementById is called).

PassRefPtr<StringImpl> AtomicString::add(const JSC::UString& ustring)

is where the real magic is.  (Just hashes the string and makes a StringImpl
wrapper if necessary.)

Does V8 not want to just do the same thing?  Add a new constructor for
AtomicString for a Handle<String> (or whatever the appropriate v8 string base
type is).

From bugzilla-daemon at webkit.org  Tue Jul 28 10:30:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:30:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27749] StyleChange::init
 needs clean up before fixing the bug 23892 : [Attachment 33591] minor
 correction
In-Reply-To: <bug-27749-0@https.bugs.webkit.org/>
References: <bug-27749-0@https.bugs.webkit.org/>
Message-ID: <20090728173052.C0F2D341833B@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27749: StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749

Attachment 33591: minor correction
https://bugs.webkit.org/attachment.cgi?id=33591&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 10:30:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:30:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27749] StyleChange::init
 needs clean up before fixing the bug 23892 : [Attachment 33652] fixed per
 comment
In-Reply-To: <bug-27749-0@https.bugs.webkit.org/>
References: <bug-27749-0@https.bugs.webkit.org/>
Message-ID: <20090728173052.D81B9341833D@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27749: StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749

Attachment 33652: fixed per comment
https://bugs.webkit.org/attachment.cgi?id=33652&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 10:37:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:37:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27757]
 update-webkit-auxiliary-libs,
 update-webkit-support-libs cause Perl warnings about functions tmpnam and
 tmpfile : [Attachment 33603] Patch
In-Reply-To: <bug-27757-0@https.bugs.webkit.org/>
References: <bug-27757-0@https.bugs.webkit.org/>
Message-ID: <20090728173725.679B034183F1@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27757: update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl
warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33603: Patch
https://bugs.webkit.org/attachment.cgi?id=33603&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
perldoc -f use
says:

	       If you do not want to call the package's "import" method (for
	       instance, to stop your namespace from being altered), explic-
	       itly supply the empty list:

		   use Module ();

	       That is exactly equivalent to

		   BEGIN { require Module }


Looks fine.

You might want to add more information to the ChangeLog about why this stops
the warning.

From bugzilla-daemon at webkit.org  Tue Jul 28 10:46:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:46:28 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27756] [HTML5][Forms] Support
 for HTMLInputElement::list and HTMLInputElement::selectedOption :
 [Attachment 33604] Support for HTMLInputElement::list and
 HTMLInputElement::selectedOption.
In-Reply-To: <bug-27756-0@https.bugs.webkit.org/>
References: <bug-27756-0@https.bugs.webkit.org/>
Message-ID: <20090728174628.9C1AF34184E6@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 27756: [HTML5][Forms] Support for HTMLInputElement::list and
HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33604: Support for HTMLInputElement::list and
HTMLInputElement::selectedOption.
https://bugs.webkit.org/attachment.cgi?id=33604&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Normally we don't commit commented-out code:
 1738	  //case DATETIME:
 1739	  //case DATE:
 1740	  //case MONTH:
 1741	  //case WEEK:
 1742	  //case TIME:
 1743	  //case DATETIMELOCAL:

Why does this need to be PassRefPtr?
 1727 PassRefPtr<HTMLElement> HTMLInputElement::list()
your'e not returning a newly allocated list.

This is very very bad:
 1751		  return static_cast<HTMLElement*>(element.get());
That would normally crash.  Grabbing a pointer out of a RefPtr and returning it
is not ok. :(  .release() is what you wanted there.  But again, I don't think
we need this to be a PassRefPtr, or?

Also probably doesn't need to be PassRefPtr:
 1770 PassRefPtr<HTMLOptionElement> HTMLInputElement::selectedOption()

WK style violation:
	 if (element && element->isHTMLElement() &&
element->hasTagName(datalistTag)) {
 1751		  return static_cast<HTMLElement*>(element.get());
 1752	      }

From bugzilla-daemon at webkit.org  Tue Jul 28 10:54:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:54:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27704] Refactor the first
 step of layout in RenderFlexibleBox.cpp : [Attachment 33529] Patch v1
In-Reply-To: <bug-27704-0@https.bugs.webkit.org/>
References: <bug-27704-0@https.bugs.webkit.org/>
Message-ID: <20090728175429.5442A3418643@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Shinichiro Hamaji
<hamaji at chromium.org>'s request for review:
Bug 27704: Refactor the first step of layout in RenderFlexibleBox.cpp
https://bugs.webkit.org/show_bug.cgi?id=27704

Attachment 33529: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33529&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
It's difficult to read the diff, but this looks right.	Looks like you're just
sharing code between two functions which should have been shared long ago!

From bugzilla-daemon at webkit.org  Tue Jul 28 10:56:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:56:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27757]
 update-webkit-auxiliary-libs,
 update-webkit-support-libs cause Perl warnings about functions tmpnam and
 tmpfile : [Attachment 33653] Patch with updated ChangeLog
In-Reply-To: <bug-27757-0@https.bugs.webkit.org/>
References: <bug-27757-0@https.bugs.webkit.org/>
Message-ID: <20090728175601.BD7C33418676@gamma.macosforge.org>

Daniel Bates <dbates at berkeley.edu> has asked  for review:
Bug 27757: update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl
warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33653: Patch with updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33653&action=review

------- Additional Comments from Daniel Bates <dbates at berkeley.edu>
Added additional information as per Eric's suggestion.

From bugzilla-daemon at webkit.org  Tue Jul 28 10:58:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 10:58:55 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27699] Would be nice if
 build-webkit on Mac respected WEBKITOUTPUTDIR and set SYMROOT/OBJROOT
 accordingly : [Attachment
 33523]=?UTF-8?Q?=202009=2D07=2D27=20=20Tor=20Arne=20Vestb=C3=B8=20=20?=<tor.arne.vestbo@nokia.com>
In-Reply-To: <bug-27699-0@https.bugs.webkit.org/>
References: <bug-27699-0@https.bugs.webkit.org/>
Message-ID: <20090728175855.4B5E234186F4@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Tor Arne Vestb? <vestbo at webkit.org>'s
request for review:
Bug 27699: Would be nice if build-webkit on Mac respected WEBKITOUTPUTDIR and
set SYMROOT/OBJROOT accordingly
https://bugs.webkit.org/show_bug.cgi?id=27699

Attachment 33523: 2009-07-27  Tor Arne Vestb?  <tor.arne.vestbo at nokia.com>
https://bugs.webkit.org/attachment.cgi?id=33523&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:03:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:03:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27674] [Gtk] Enable
 http/tests/appcache tests : [Attachment 33488] patch
In-Reply-To: <bug-27674-0@https.bugs.webkit.org/>
References: <bug-27674-0@https.bugs.webkit.org/>
Message-ID: <20090728180329.43DEF34187E8@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 27674: [Gtk] Enable http/tests/appcache tests
https://bugs.webkit.org/show_bug.cgi?id=27674

Attachment 33488: patch
https://bugs.webkit.org/attachment.cgi?id=33488&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks sane enough.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:04:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:04:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33442] Fix style in PluginPackage and
 PluginDatabase.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090728180441.EA2723418808@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Jakub Wieczorek <faw217 at gmail.com>'s
request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33442: Fix style in PluginPackage and PluginDatabase.
https://bugs.webkit.org/attachment.cgi?id=33442&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Looks fine.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:09:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:09:24 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33501] v2
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090728180924.5D4373418892@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33501: v2
https://bugs.webkit.org/attachment.cgi?id=33501&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I would rather you abstract this into a function, something like this:

static bool privateBrowsingEnabled(frame)
{
#ifdef CHROMIUM
    // comment explaing why it's OK for frame to be null
    return false;
#else
    return frame->....
#endif
}

Otherwis this looks fine.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:21:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:21:59 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27613]
 WebCore/page/ContextMenuController.cpp does not conform to style standards
 : [Attachment 33350] Style patch for ContextMenuController.cpp
In-Reply-To: <bug-27613-0@https.bugs.webkit.org/>
References: <bug-27613-0@https.bugs.webkit.org/>
Message-ID: <20090728182159.6AF0D34189F5@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27613: WebCore/page/ContextMenuController.cpp does not conform to style
standards
https://bugs.webkit.org/show_bug.cgi?id=27613

Attachment 33350: Style patch for ContextMenuController.cpp
https://bugs.webkit.org/attachment.cgi?id=33350&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +2009-07-23  Mike Fenton  <mike.fenton at torchmobile.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Update WebCore/page/ContextMenuController.cpp to conform to WebKit
> +	   Style Guidelines as identified by cpplint.py.

Now it is cpp_style.py :)


> diff --git a/WebCore/page/ContextMenuController.cpp
b/WebCore/page/ContextMenuController.cpp


Since this is about fixing styling in ContextMenuController.cpp,


Why not fix the indentation in this block of code?  Personally, I would unwrap
this line but you could just indent to the createWindow(.


107	static void openNewWindow(const KURL& urlToLoad, Frame* frame)
108	{
109	    if (Page* oldPage = frame->page()) {
110		WindowFeatures features;
111		if (Page* newPage = oldPage->chrome()->createWindow(frame,
112			FrameLoadRequest(ResourceRequest(urlToLoad,
frame->loader()->outgoingReferrer())), features))
113		    newPage->chrome()->show();
114	    }
115	}


> +    case ContextMenuItemTagOpenFrameInNewWindow: {
> +	   DocumentLoader* loader = frame->loader()->documentLoader();
> +	   if (!loader->unreachableURL().isEmpty())
> +	       openNewWindow(loader->unreachableURL(), frame);
> +	   else
> +	       openNewWindow(loader->url(), frame);
> +	   break;
>	   }
The indentation for the "}" needs fixing.

> +    case ContextMenuItemTagSpellingGuess:
> +	   ASSERT(frame->selectedText().length());
> +	   if (frame->editor()->shouldInsertText(item->title(),
frame->selection()->toNormalizedRange().get(),
> +	       EditorInsertActionPasted)) {
Either indent to the level of the nested paren or unwrap.

> +	       Document* document = frame->document();
> +	       RefPtr<ReplaceSelectionCommand> command =
> +		   ReplaceSelectionCommand::create(document,
createFragmentFromMarkup(document, item->title(), ""),
> +									       
  true, false, true);

Either indent to the level of the nested paren or unwrap.


> +    case ContextMenuItemTagOpenLink:
> +	   if (Frame* targetFrame = result.targetFrame()) {
> +	      
targetFrame->loader()->loadFrameRequest(FrameLoadRequest(ResourceRequest(result
.absoluteLinkURL(),
> +		   frame->loader()->outgoingReferrer())), false, false, 0, 0);

Either indent to the level of the nested paren or unwrap.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:29:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:29:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 33607] Patch to add ChromeClient for
 Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090728182945.24A453418B19@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33607: Patch to add ChromeClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33607&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> +
> +	   #if ENABLE(OFFLINE_WEB_APPLICATIONS)
> +	   virtual void reachedMaxAppCacheSize(int64_t spaceNeeded);
> +	   #endif

The #if (and #endif) shouldn't be indented.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:32:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:32:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26952] WebCore Support for
 the Haiku WebKit port : [Attachment 33608] Patch to add FrameLoaderClient
 for Haiku WebCore support.
In-Reply-To: <bug-26952-0@https.bugs.webkit.org/>
References: <bug-26952-0@https.bugs.webkit.org/>
Message-ID: <20090728183222.C32883418B89@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26952: WebCore Support for the Haiku WebKit port
https://bugs.webkit.org/show_bug.cgi?id=26952

Attachment 33608: Patch to add FrameLoaderClient for Haiku WebCore support.
https://bugs.webkit.org/attachment.cgi?id=33608&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 11:32:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:32:37 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27760]
 HTMLOptionElement::value() returns incorrect value : [Attachment 33613]
 patch
In-Reply-To: <bug-27760-0@https.bugs.webkit.org/>
References: <bug-27760-0@https.bugs.webkit.org/>
Message-ID: <20090728183237.142B83418BA3@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has denied TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 27760: HTMLOptionElement::value() returns incorrect value
https://bugs.webkit.org/show_bug.cgi?id=27760

Attachment 33613: patch
https://bugs.webkit.org/attachment.cgi?id=33613&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
> diff --git a/LayoutTests/ChangeLog b/LayoutTests/ChangeLog
> index d934c7d..6a83b21 100644
> --- a/LayoutTests/ChangeLog
> +++ b/LayoutTests/ChangeLog
> @@ -1,3 +1,13 @@
> +2009-07-28  Kent Tamura  <tkent at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fix a bug that HTMLOptionElement::value() returns an incorrect
value.
> +	   https://bugs.webkit.org/show_bug.cgi?id=27760
> +
> +	   * fast/forms/option-value-and-label-expected.txt: Added.
> +	   * fast/forms/option-value-and-label.html: Added.
> +
>  2009-07-27  Antonio Gomes   <antonio.gomes at openbossa.org>
>  
>	   Reviewed by Adam Treat.
> diff --git a/LayoutTests/fast/forms/option-value-and-label-expected.txt
b/LayoutTests/fast/forms/option-value-and-label-expected.txt
> new file mode 100644
> index 0000000..99dffe3
> --- /dev/null
> +++ b/LayoutTests/fast/forms/option-value-and-label-expected.txt
> @@ -0,0 +1,17 @@
> +Test for .value and .label of OPTION element
> +
> +On success, you will see a series of "PASS" messages, followed by "TEST
COMPLETE".
> +
> +
> +PASS o1.value is "text"
> +PASS o1.label is ""
> +PASS o2.value is "value"
> +PASS o2.label is ""
> +PASS o3.value is "text"
> +PASS o3.label is "label"
> +PASS o4.value is "value"
> +PASS o4.label is "label"
> +PASS successfullyParsed is true
> +
> +TEST COMPLETE
> +
> diff --git a/LayoutTests/fast/forms/option-value-and-label.html
b/LayoutTests/fast/forms/option-value-and-label.html
> new file mode 100644
> index 0000000..afe3e30
> --- /dev/null
> +++ b/LayoutTests/fast/forms/option-value-and-label.html
> @@ -0,0 +1,41 @@
> +<!DOCTYPE HTML>
> +<html>
> +<head>
> +<link rel="stylesheet" href="../../fast/js/resources/js-test-style.css">
> +<script src="../../fast/js/resources/js-test-pre.js"></script>
> +</head>
> +<body>
> +<p id="description"></p>
> +<div id="console"></div>
> +
> +<select>
> +<option id="o1">text</option>
> +<option id="o2" value="value">text</option>
> +<option id="o3" label="label">text</option>
> +<option id="o4" value="value" label="label">text</option>
> +</select>
> +
> +<script>
> +description('Test for .value and .label of OPTION element');
> +
> +var o1 = document.getElementById('o1');
> +shouldBe('o1.value', '"text"');
> +shouldBe('o1.label', '""');
> +
> +var o2 = document.getElementById('o2');
> +shouldBe('o2.value', '"value"');
> +shouldBe('o2.label', '""');
> +
> +var o3 = document.getElementById('o3');
> +shouldBe('o3.value', '"text"');
> +shouldBe('o3.label', '"label"');
> +
> +var o4 = document.getElementById('o4');
> +shouldBe('o4.value', '"value"');
> +shouldBe('o4.label', '"label"');
> +
> +var successfullyParsed = true;
> +</script>
> +<script src="../../fast/js/resources/js-test-post.js"></script>
> +</body>
> +</html>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index 467345a..b75fe69 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,23 @@
> +2009-07-28  Kent Tamura  <tkent at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Fix a bug that HTMLOptionElement::value() returns an incorrect
value.
> +	   https://bugs.webkit.org/show_bug.cgi?id=27760
> +
> +	   Test: fast/forms/option-value-and-label.html
> +
> +	   * dom/OptionElement.cpp:
> +	   (WebCore::OptionElement::collectOptionLabel):
> +	   (WebCore::OptionElement::collectOptionText):
> +	   (WebCore::OptionElement::collectOptionTextRespectingGroupLabel):
> +	   (WebCore::OptionElement::collectOptionValue):
> +	   * dom/OptionElement.h:
> +	   * html/HTMLOptionElement.cpp:
> +	   (WebCore::HTMLOptionElement::text):
> +	   * wml/WMLOptionElement.cpp:
> +	   (WebCore::WMLOptionElement::text):

Can you please come up with a more detailed ChangeLog, it helps in tricky cases
like this..
;
> +    static String collectOptionText(const Element*, String);
Use "const String&" here.
  
>  String HTMLOptionElement::text() const
>  {
> -    return OptionElement::collectOptionText(m_data, this);
> +    return OptionElement::collectOptionLabel(m_data, this);
>  }

>  String WMLOptionElement::text() const
>  {
> -    return OptionElement::collectOptionText(m_data, this);
> +    return OptionElement::collectOptionLabel(m_data, this);
>  }

Hmm, very unfortunate that the naming is misleading nowadays, maybe this
indicates we need better function names here.
I like the patch, though we clearly need a better naming scheme here, it's
confusing. Or a detailed ChangeLog describing why it is as it is :-)

r-, for the ChangeLog & "const String&" issue.

From bugzilla-daemon at webkit.org  Tue Jul 28 11:41:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:41:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27711] SVG Filter need
 feColorMatrix implementation : [Attachment 33543] SVG
 feColorMatrix-implementation
In-Reply-To: <bug-27711-0@https.bugs.webkit.org/>
References: <bug-27711-0@https.bugs.webkit.org/>
Message-ID: <20090728184149.AC2833418CFA@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 27711: SVG Filter need feColorMatrix implementation
https://bugs.webkit.org/show_bug.cgi?id=27711

Attachment 33543: SVG feColorMatrix-implementation
https://bugs.webkit.org/attachment.cgi?id=33543&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
Woo!  alas, the double casts here:
double red = (double)r, green = (double)g, blue = (double)b, alpha = (double)a;


are unnecessary

And I don't like having that switch in the middle of the main processing loop
-- i'm not entirely sure what can be done to improve it short of something
involving templates ;)

From bugzilla-daemon at webkit.org  Tue Jul 28 11:45:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:45:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27773] [V8] Update bindings
 to use new API for pixel data : [Attachment 33655] proposed patch
In-Reply-To: <bug-27773-0@https.bugs.webkit.org/>
References: <bug-27773-0@https.bugs.webkit.org/>
Message-ID: <20090728184519.5C1803418D7A@gamma.macosforge.org>

Ivan Posva <iposva at chromium.org> has asked  for review:
Bug 27773: [V8] Update bindings to use new API for pixel data
https://bugs.webkit.org/show_bug.cgi?id=27773

Attachment 33655: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33655&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 11:46:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:46:33 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27773] [V8] Update bindings
 to use new API for pixel data : [Attachment 33655] proposed patch
In-Reply-To: <bug-27773-0@https.bugs.webkit.org/>
References: <bug-27773-0@https.bugs.webkit.org/>
Message-ID: <20090728184633.728F93418D98@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Ivan Posva
<iposva at chromium.org>'s request for review:
Bug 27773: [V8] Update bindings to use new API for pixel data
https://bugs.webkit.org/show_bug.cgi?id=27773

Attachment 33655: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33655&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me

From bugzilla-daemon at webkit.org  Tue Jul 28 11:49:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 11:49:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27774] [Gtk] Code cleanup
 in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33656] v0.1 - code style fixes + removal of unneeded includes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090728184956.25A073418E11@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33656: v0.1 - code style fixes + removal of unneeded includes 
https://bugs.webkit.org/attachment.cgi?id=33656&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
these files have coding style issues (accordingly to
WebCore/Scripts/modules/cpplint.py). patch fixes them, and remove some unneeded
includes (e.g. gdk.h or gtk.h).

ps: this patch make gtk video backend work for EFL out of the box too.

From bugzilla-daemon at webkit.org  Tue Jul 28 12:00:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:00:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27769] Chromium crashes in
 the V8 bindings code when the page is being torn down : [Attachment 33657]
 Patch containing the proposed fix in V8Proxy.cpp
In-Reply-To: <bug-27769-0@https.bugs.webkit.org/>
References: <bug-27769-0@https.bugs.webkit.org/>
Message-ID: <20090728190025.A22ED3418FD3@gamma.macosforge.org>

Ananta Iyengar <ananta at chromium.org> has asked	for review:
Bug 27769: Chromium crashes in the V8 bindings code when the page is being torn
down
https://bugs.webkit.org/show_bug.cgi?id=27769

Attachment 33657: Patch containing the proposed fix in V8Proxy.cpp
https://bugs.webkit.org/attachment.cgi?id=33657&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:01:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:01:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33168] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090728190155.5884F341901D@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has asked  for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33168: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33168&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:03:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:03:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33656] v0.1 - code style fixes + removal of unneeded includes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090728190337.2E62D341909F@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33656: v0.1 - code style fixes + removal of unneeded includes 
https://bugs.webkit.org/attachment.cgi?id=33656&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
clearing review flag, since xan asked to break it down in smaller patches:

1) for coding style
2) for removing unneeded includes.

From bugzilla-daemon at webkit.org  Tue Jul 28 12:05:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:05:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27772] PopupMenuQt lacks
 disabled and selected support : [Attachment 33658] Patch that enables
 selected and disabled support for PopupMenuQt.
In-Reply-To: <bug-27772-0@https.bugs.webkit.org/>
References: <bug-27772-0@https.bugs.webkit.org/>
Message-ID: <20090728190530.8DE3434190F0@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27772: PopupMenuQt lacks disabled and selected support
https://bugs.webkit.org/show_bug.cgi?id=27772

Attachment 33658: Patch that enables selected and disabled support for
PopupMenuQt.
https://bugs.webkit.org/attachment.cgi?id=33658&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:10:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:10:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26993]
 Geolocation::requestPermission() : [Attachment 33659] the patch
In-Reply-To: <bug-26993-0@https.bugs.webkit.org/>
References: <bug-26993-0@https.bugs.webkit.org/>
Message-ID: <20090728191039.16D0B3419173@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 26993: Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993

Attachment 33659: the patch
https://bugs.webkit.org/attachment.cgi?id=33659&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:13:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:13:31 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 32943] Patch to add ScrollBar and ScrollView code
 specific to Haiku.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090728191331.02D7234191D5@gamma.macosforge.org>

Maxime Simon <simon.maxime at gmail.com> has canceled Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 32943: Patch to add ScrollBar and ScrollView code specific to Haiku.
https://bugs.webkit.org/attachment.cgi?id=32943&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:17:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:17:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26988] Haiku-specific files
 for WebCore : [Attachment 33168] Patch to add a first bunch of
 Haiku-specific files for WebCore.
In-Reply-To: <bug-26988-0@https.bugs.webkit.org/>
References: <bug-26988-0@https.bugs.webkit.org/>
Message-ID: <20090728191739.635B13419291@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Maxime Simon
<simon.maxime at gmail.com>'s request for review:
Bug 26988: Haiku-specific files for WebCore
https://bugs.webkit.org/show_bug.cgi?id=26988

Attachment 33168: Patch to add a first bunch of Haiku-specific files for
WebCore.
https://bugs.webkit.org/attachment.cgi?id=33168&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I believe I already landed this: http://trac.webkit.org/changeset/46167

Let me know if I am mistaken.

From bugzilla-daemon at webkit.org  Tue Jul 28 12:30:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:30:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27769] Chromium crashes in
 the V8 bindings code when the page is being torn down : [Attachment 33660]
 Updated V8 bindings patch
In-Reply-To: <bug-27769-0@https.bugs.webkit.org/>
References: <bug-27769-0@https.bugs.webkit.org/>
Message-ID: <20090728193053.2BD5D341941C@gamma.macosforge.org>

Ananta Iyengar <ananta at chromium.org> has asked	for review:
Bug 27769: Chromium crashes in the V8 bindings code when the page is being torn
down
https://bugs.webkit.org/show_bug.cgi?id=27769

Attachment 33660: Updated V8 bindings patch
https://bugs.webkit.org/attachment.cgi?id=33660&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:30:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:30:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27769] Chromium crashes in
 the V8 bindings code when the page is being torn down : [Attachment 33657]
 Patch containing the proposed fix in V8Proxy.cpp
In-Reply-To: <bug-27769-0@https.bugs.webkit.org/>
References: <bug-27769-0@https.bugs.webkit.org/>
Message-ID: <20090728193053.028AD341941A@gamma.macosforge.org>

Ananta Iyengar <ananta at chromium.org> has canceled Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 27769: Chromium crashes in the V8 bindings code when the page is being torn
down
https://bugs.webkit.org/show_bug.cgi?id=27769

Attachment 33657: Patch containing the proposed fix in V8Proxy.cpp
https://bugs.webkit.org/attachment.cgi?id=33657&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 12:32:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:32:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27769] Chromium crashes in
 the V8 bindings code when the page is being torn down : [Attachment 33660]
 Updated V8 bindings patch
In-Reply-To: <bug-27769-0@https.bugs.webkit.org/>
References: <bug-27769-0@https.bugs.webkit.org/>
Message-ID: <20090728193203.99A833419464@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Ananta Iyengar
<ananta at chromium.org>'s request for review:
Bug 27769: Chromium crashes in the V8 bindings code when the page is being torn
down
https://bugs.webkit.org/show_bug.cgi?id=27769

Attachment 33660: Updated V8 bindings patch
https://bugs.webkit.org/attachment.cgi?id=33660&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok.

From bugzilla-daemon at webkit.org  Tue Jul 28 12:33:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 12:33:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27749] StyleChange::init
 needs clean up before fixing the bug 23892 : [Attachment 33652] fixed per
 comment
In-Reply-To: <bug-27749-0@https.bugs.webkit.org/>
References: <bug-27749-0@https.bugs.webkit.org/>
Message-ID: <20090728193318.8E03134194A6@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27749: StyleChange::init needs clean up before fixing the bug 23892
https://bugs.webkit.org/show_bug.cgi?id=27749

Attachment 33652: fixed per comment
https://bugs.webkit.org/attachment.cgi?id=33652&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 13:02:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:02:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27768] SVG
 feComponentTransfer needs to be implemented : [Attachment 33662] SVG Filter
 feComponentTransfer
In-Reply-To: <bug-27768-0@https.bugs.webkit.org/>
References: <bug-27768-0@https.bugs.webkit.org/>
Message-ID: <20090728200250.A17D33419894@gamma.macosforge.org>

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 27768: SVG feComponentTransfer needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=27768

Attachment 33662: SVG Filter feComponentTransfer
https://bugs.webkit.org/attachment.cgi?id=33662&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
Implementation with look-up-table. This is a dramaticly speed up of
feComponentTransfer.

From bugzilla-daemon at webkit.org  Tue Jul 28 13:20:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:20:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27776] Add sesssion storage
 layout tests : [Attachment 33664] v1
In-Reply-To: <bug-27776-0@https.bugs.webkit.org/>
References: <bug-27776-0@https.bugs.webkit.org/>
Message-ID: <20090728202059.C09B53419B48@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27776: Add sesssion storage layout tests
https://bugs.webkit.org/show_bug.cgi?id=27776

Attachment 33664: v1
https://bugs.webkit.org/attachment.cgi?id=33664&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
This is a mixed bag of tweaks to existing tests.  This is the sessionStorage
side of https://bugs.webkit.org/show_bug.cgi?id=27695

From bugzilla-daemon at webkit.org  Tue Jul 28 13:23:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:23:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27776] Add sesssion storage
 layout tests : [Attachment 33664] v1
In-Reply-To: <bug-27776-0@https.bugs.webkit.org/>
References: <bug-27776-0@https.bugs.webkit.org/>
Message-ID: <20090728202345.0E7A83419BDF@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27776: Add sesssion storage layout tests
https://bugs.webkit.org/show_bug.cgi?id=27776

Attachment 33664: v1
https://bugs.webkit.org/attachment.cgi?id=33664&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Tests!

From bugzilla-daemon at webkit.org  Tue Jul 28 13:23:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:23:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33665]
 Patch to fix
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728202324.376DE3419BC3@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked Darin Fisher (:fishd, Google)
<fishd at chromium.org> for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33665: Patch to fix
https://bugs.webkit.org/attachment.cgi?id=33665&action=review

------- Additional Comments from Avi Drissman <avi at drissman.com>
When you create a CGImageRef, it takes the CFDataRef that holds its backing
data, and retains it for its entire lifetime.

The problem here is that ImageSourceCG uses CFDataCreateWithBytesNoCopy to
create the CFDataRef containing the image data. When you use
CFDataCreateWithBytesNoCopy, it's up to you to ensure that the backing store
that you pass to it stays valid through the lifetime of the created CFDataRef.

Since the lifetime of the CFDataRef is the lifetime of the CGImageRef,
ImageSourceCG makes a promise that it can't keep. The SharedBuffer is passed in
as a parameter to setData--who knows if it will live longer than the created
CGImageRef?

From bugzilla-daemon at webkit.org  Tue Jul 28 13:29:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:29:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33665]
 Patch to fix
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728202921.0936A3419CCB@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33665: Patch to fix
https://bugs.webkit.org/attachment.cgi?id=33665&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 13:35:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:35:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27778] Add more DOM Storage
 tests : [Attachment 33667] v1
In-Reply-To: <bug-27778-0@https.bugs.webkit.org/>
References: <bug-27778-0@https.bugs.webkit.org/>
Message-ID: <20090728203537.AA9EA3419DDF@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27778: Add more DOM Storage tests
https://bugs.webkit.org/show_bug.cgi?id=27778

Attachment 33667: v1
https://bugs.webkit.org/attachment.cgi?id=33667&action=review

------- Additional Comments from Jeremy Orlow <jorlow at chromium.org>
Add more localStorage tests.  As with before, once I know everything's OK with
them, I'll port them over to SessionStorage tests as well.

       These test behavior that I don't think was very well verified earlier.

	* storage/domstorage/localstorage/complex-keys-expected.txt: Added.
	* storage/domstorage/localstorage/complex-keys.html: Added.
	      A bunch of corner cases related to keys.
	* storage/domstorage/localstorage/complex-values-expected.txt: Added.
	* storage/domstorage/localstorage/complex-values.html: Added.
	      A bunch of corner cases related to values.
	* storage/domstorage/localstorage/remove-item-expected.txt: Added.
	* storage/domstorage/localstorage/remove-item.html: Added.
	      Test basic removeItem functionality.

From bugzilla-daemon at webkit.org  Tue Jul 28 13:45:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:45:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33668] the patch
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090728204550.D421D3419F9F@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33668: the patch
https://bugs.webkit.org/attachment.cgi?id=33668&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 13:51:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:51:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33668] the patch
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090728205154.46A66341A067@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33668: the patch
https://bugs.webkit.org/attachment.cgi?id=33668&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 13:51:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 13:51:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33669] remove an unnecessary line
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090728205154.61D8E341A069@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33669: remove an unnecessary line
https://bugs.webkit.org/attachment.cgi?id=33669&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:07:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:07:55 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33501] v2
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090728210755.2D4FA341A264@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has canceled  review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33501: v2
https://bugs.webkit.org/attachment.cgi?id=33501&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:08:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:08:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33670] patch
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090728210813.28236341A271@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33670: patch
https://bugs.webkit.org/attachment.cgi?id=33670&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:30:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:30:12 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33670] patch
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090728213012.21185341A49B@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has canceled Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33670: patch
https://bugs.webkit.org/attachment.cgi?id=33670&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:31:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:31:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33672] patch
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090728213145.E794F341A4CF@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33672: patch
https://bugs.webkit.org/attachment.cgi?id=33672&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:40:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:40:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27782] [Chromium]
 getStringIdentifier() in V8NPUtils doesn't handle UTF8 identifiers :
 [Attachment 33673] patch
In-Reply-To: <bug-27782-0@https.bugs.webkit.org/>
References: <bug-27782-0@https.bugs.webkit.org/>
Message-ID: <20090728214014.4B7C6341A60E@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27782: [Chromium] getStringIdentifier() in V8NPUtils doesn't handle UTF8
identifiers
https://bugs.webkit.org/show_bug.cgi?id=27782

Attachment 33673: patch
https://bugs.webkit.org/attachment.cgi?id=33673&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:45:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:45:40 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33665]
 Patch to fix
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728214540.58652341A694@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has canceled Avi Drissman <avi at drissman.com>'s
request for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33665: Patch to fix
https://bugs.webkit.org/attachment.cgi?id=33665&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:45:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:45:40 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33674]
 Patch to fix (ref/deref backing data)
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728214540.73EA0341A696@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked  for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33674: Patch to fix (ref/deref backing data)
https://bugs.webkit.org/attachment.cgi?id=33674&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 14:57:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 14:57:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27517] Misc cleanup in DOM
 Storage. : [Attachment 33672] patch
In-Reply-To: <bug-27517-0@https.bugs.webkit.org/>
References: <bug-27517-0@https.bugs.webkit.org/>
Message-ID: <20090728215709.9614E341A7B0@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27517: Misc cleanup in DOM Storage.
https://bugs.webkit.org/show_bug.cgi?id=27517

Attachment 33672: patch
https://bugs.webkit.org/attachment.cgi?id=33672&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why remove:
// FIXME: When can this occur?

Also, instead of removing // FIXME: Is the .copy necessary?
it seems replacing it with // copy for safe muti-threaded access
or some similar comment which explains the "why" since clearly the author of
that FIXME didn't understand "why" :)

Otherwise looks fine.

From bugzilla-daemon at webkit.org  Tue Jul 28 15:01:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:01:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27619] Switch wx to using waf
 for builds : [Attachment 33402] wxBrowser waf build script
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090728220125.1FA5F341A842@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33402: wxBrowser waf build script
https://bugs.webkit.org/attachment.cgi?id=33402&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 15:06:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:06:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27236] Memory is not released
 back to the system from TCMalloc on Windows : [Attachment 33581] Revised
 patch to use a background thread to release memory back to the system.
In-Reply-To: <bug-27236-0@https.bugs.webkit.org/>
References: <bug-27236-0@https.bugs.webkit.org/>
Message-ID: <20090728220622.E61A6341A8DC@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Ada Chan <adachan at apple.com>'s
request for review:
Bug 27236: Memory is not released back to the system from TCMalloc on Windows
https://bugs.webkit.org/show_bug.cgi?id=27236

Attachment 33581: Revised patch to use a background thread to release memory
back to the system.
https://bugs.webkit.org/attachment.cgi?id=33581&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	       if (!s->decommitted)
> +		   pagesDecommitted += s->length;
> +	       s->decommitted = true;

Since you already have the if statement, you could move the assignment into it.


> +#if PLATFORM(WIN)
> +static void sleep(unsigned seconds)
> +{
> +    ::Sleep(seconds * 1000);
> +}
> +#endif

I usually prefer to put these platform-specific hacks into WTF headers. This is
OK for now but I'd like to consider later having this be in some header with
other <unistd.h> implementations for non-Unix platforms. Or a thread helper
function header.

> +	   BOOL success = VirtualFree(ptr, length < info.RegionSize ? length :
info.RegionSize, MEM_DECOMMIT);
> +	   ASSERT_UNUSED(success, success);
> +	   length -= info.RegionSize;
> +	   ptr = static_cast<char*>(ptr) + info.RegionSize;

I think the way the code modifies length here is a little confusing and
unnecessary. Instead I would write something like this:

    size_t decommitSize = min(info.RegionSize, end - ptr);

And use that instead of the ?: and not change length each time through the
loop.

> +    return;
> +}

You don't need a return here.

> +	   void *newAddress = VirtualAlloc(ptr, length < info.RegionSize ?
length : info.RegionSize, MEM_COMMIT, PAGE_READWRITE);
> +	   ASSERT_UNUSED(newAddress, newAddress == ptr);
> +	   length -= info.RegionSize;
> +	   ptr = static_cast<char*>(ptr) + info.RegionSize;
> +    }
> +    return;
>  }

Same comments as above.

r=me, but please consider the tweaks I mentioned.

From bugzilla-daemon at webkit.org  Tue Jul 28 15:12:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:12:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33674]
 Patch to fix (ref/deref backing data)
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728221221.B9F43341A9C8@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Avi Drissman <avi at drissman.com>'s
request for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33674: Patch to fix (ref/deref backing data)
https://bugs.webkit.org/attachment.cgi?id=33674&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +void SharedBufferDerefCallback(void*, void* info)

Function names should start with a lowercase letter. Since this is private to
this source file it should use "static" to get internal linkage.

> +    SharedBuffer* sharedBuffer = reinterpret_cast<SharedBuffer*>(info);

This should be static_cast, which can convert a void* to a specific pointer
type.

> +    data->ref();
> +    CFAllocatorContext context = {0, data, 0, 0, 0, 0, 0,
SharedBufferDerefCallback, 0};
> +    CFAllocatorRef derefAllocator = CFAllocatorCreate(kCFAllocatorDefault,
&context);
> +    CFDataRef cfData = CFDataCreateWithBytesNoCopy(0, reinterpret_cast<const
UInt8*>(data->data()), data->size(), derefAllocator);
> +    CFRelease(derefAllocator);

Creating a unique allocator each time is unfortunate, but I can't think of any
better idea.

r=me but the style issues I mention above should be fixed

From bugzilla-daemon at webkit.org  Tue Jul 28 15:31:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:31:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33677]
 Patch with Darin's cleanup applied
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728223142.C7874341ACCC@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked Darin Adler <darin at apple.com> for
review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33677: Patch with Darin's cleanup applied
https://bugs.webkit.org/attachment.cgi?id=33677&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 15:35:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:35:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27785] [V8] Add a way to
 register V8 extensions for Isolated Worlds only : [Attachment 33678] first
 attempt
In-Reply-To: <bug-27785-0@https.bugs.webkit.org/>
References: <bug-27785-0@https.bugs.webkit.org/>
Message-ID: <20090728223527.2E8C9341AD46@gamma.macosforge.org>

Matt Perry <mpcomplete at chromium.org> has asked Adam Barth <abarth at webkit.org>
for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33678: first attempt
https://bugs.webkit.org/attachment.cgi?id=33678&action=review

------- Additional Comments from Matt Perry <mpcomplete at chromium.org>
There is a corresponding Chromium change here:
http://codereview.chromium.org/159542

From bugzilla-daemon at webkit.org  Tue Jul 28 15:48:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:48:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27785] [V8] Add a way to
 register V8 extensions for Isolated Worlds only : [Attachment 33678] first
 attempt
In-Reply-To: <bug-27785-0@https.bugs.webkit.org/>
References: <bug-27785-0@https.bugs.webkit.org/>
Message-ID: <20090728224810.4B17D341AE30@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Matt Perry
<mpcomplete at chromium.org>'s request for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33678: first attempt
https://bugs.webkit.org/attachment.cgi?id=33678&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
+	 } else if (it->scheme.length() > 0 && (it->scheme !=
m_frame->loader()->activeDocumentLoader()->url().protocol() || it->scheme !=
m_frame->page()->mainFrame()->loader()->activeDocumentLoader()->url().protocol(
))) {

You don't need the "else" here because the "if" clause ends in continue.

+	 v8::Persistent<v8::Context> createNewContext(v8::Handle<v8::Object>
global, bool isolatedContext);

Adding bools to this function doesn't really scale.  Can we pass in the set of
extensions somehow?  You might want a helper function that grabs the proper set
of extensions for normal and for isolated worlds.

Also, there's is no such thing as an "isolated context".  There are isolated
worlds, which eventually will hold more than one context each.

From bugzilla-daemon at webkit.org  Tue Jul 28 15:51:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:51:45 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33677]
 Patch with Darin's cleanup applied
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728225145.A3475341AE81@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has canceled Avi Drissman <avi at drissman.com>'s
request for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33677: Patch with Darin's cleanup applied
https://bugs.webkit.org/attachment.cgi?id=33677&action=review

------- Additional Comments from Avi Drissman <avi at drissman.com>
That should do it. Compiles with both PLATFORM(MAC) and not.

From bugzilla-daemon at webkit.org  Tue Jul 28 15:51:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 15:51:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33679]
 Patch with platform fix and "static"
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090728225145.C1CD8341AE83@gamma.macosforge.org>

Avi Drissman <avi at drissman.com> has asked Darin Adler <darin at apple.com> for
review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33679: Patch with platform fix and "static"
https://bugs.webkit.org/attachment.cgi?id=33679&action=review

------- Additional Comments from Avi Drissman <avi at drissman.com>
That should do it. Compiles with both PLATFORM(MAC) and not.

From bugzilla-daemon at webkit.org  Tue Jul 28 16:05:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 16:05:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27782] [Chromium]
 getStringIdentifier() in V8NPUtils doesn't handle UTF8 identifiers :
 [Attachment 33673] patch
In-Reply-To: <bug-27782-0@https.bugs.webkit.org/>
References: <bug-27782-0@https.bugs.webkit.org/>
Message-ID: <20090728230520.81AE3341B000@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Nate Chapin
<japhet at chromium.org>'s request for review:
Bug 27782: [Chromium] getStringIdentifier() in V8NPUtils doesn't handle UTF8
identifiers
https://bugs.webkit.org/show_bug.cgi?id=27782

Attachment 33673: patch
https://bugs.webkit.org/attachment.cgi?id=33673&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 17:02:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:02:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27584] [CSS3 Backgrounds
 and Borders] Handle the / and 4 values in border-radius : [Attachment
 33680] Support the new border-radius syntax and maintain legacy
 -webkit-border-radius syntax
In-Reply-To: <bug-27584-0@https.bugs.webkit.org/>
References: <bug-27584-0@https.bugs.webkit.org/>
Message-ID: <20090729000236.8EC69341B524@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27584: [CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584

Attachment 33680: Support the new border-radius syntax and maintain legacy
-webkit-border-radius syntax
https://bugs.webkit.org/attachment.cgi?id=33680&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 17:13:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:13:43 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27584] [CSS3 Backgrounds and
 Borders] Handle the / and 4 values in border-radius : [Attachment 33680]
 Support the new border-radius syntax and maintain legacy
 -webkit-border-radius syntax
In-Reply-To: <bug-27584-0@https.bugs.webkit.org/>
References: <bug-27584-0@https.bugs.webkit.org/>
Message-ID: <20090729001343.62144341B65C@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 27584: [CSS3 Backgrounds and Borders] Handle the / and 4 values in
border-radius
https://bugs.webkit.org/show_bug.cgi?id=27584

Attachment 33680: Support the new border-radius syntax and maintain legacy
-webkit-border-radius syntax
https://bugs.webkit.org/attachment.cgi?id=33680&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
> Index: WebCore/css/CSSParser.cpp
> ===================================================================


> +    case CSSPropertyBorderRadius:
> +    case CSSPropertyWebkitBorderRadius:
> +	   return parseBorderRadius(propId, important);
> +	   break;

No need for the break after return.

r=me

From bugzilla-daemon at webkit.org  Tue Jul 28 17:17:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:17:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27786] [WML] WML*Element
 classes mostly implement insertedIntoDocument(),
 not removedFromDocument() : [Attachment 33681] Initial patch
In-Reply-To: <bug-27786-0@https.bugs.webkit.org/>
References: <bug-27786-0@https.bugs.webkit.org/>
Message-ID: <20090729001720.6CC48341B69F@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27786: [WML] WML*Element classes mostly implement insertedIntoDocument(),
not removedFromDocument()
https://bugs.webkit.org/show_bug.cgi?id=27786

Attachment 33681: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33681&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 17:33:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:33:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27786] [WML] WML*Element
 classes mostly implement insertedIntoDocument(),
 not removedFromDocument() : [Attachment 33681] Initial patch
In-Reply-To: <bug-27786-0@https.bugs.webkit.org/>
References: <bug-27786-0@https.bugs.webkit.org/>
Message-ID: <20090729003325.20AFD341BB2F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Nikolas Zimmermann
<zimmermann at kde.org>'s request for review:
Bug 27786: [WML] WML*Element classes mostly implement insertedIntoDocument(),
not removedFromDocument()
https://bugs.webkit.org/show_bug.cgi?id=27786

Attachment 33681: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33681&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
After Niko walked me through it over chat I can't find anything wrong.	Drats
:)

From bugzilla-daemon at webkit.org  Tue Jul 28 17:41:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:41:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 32609] Patch v3
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090729004127.5834B341BC33@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 32609: Patch v3
https://bugs.webkit.org/attachment.cgi?id=32609&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 17:41:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:41:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 33683] Patch v1
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090729004131.129A0341BC52@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 33683: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33683&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 17:52:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:52:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27788] Export
 WebPluginContainerCheck.h as private header : [Attachment 33684] Patch v1
In-Reply-To: <bug-27788-0@https.bugs.webkit.org/>
References: <bug-27788-0@https.bugs.webkit.org/>
Message-ID: <20090729005220.8B708341BD69@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27788: Export WebPluginContainerCheck.h as private header
https://bugs.webkit.org/show_bug.cgi?id=27788

Attachment 33684: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33684&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

WebPluginContainerCheck.h must be a private header because it is
included from WebPluginController.h, which is a private header.

WebKit:

* WebKit.xcodeproj/project.pbxproj: Export
WebPluginContainerCheck.h as a private header.

WebKit/mac:

* Plugins/WebPluginController.h: Changed #import of
WebPluginContainerCheck.h to use a framework-style path.
---
 4 files changed, 26 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 28 17:59:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 17:59:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27777] ImageSourceCG makes
 bad data refs (race condition causes blank images) : [Attachment 33679]
 Patch with platform fix and "static"
In-Reply-To: <bug-27777-0@https.bugs.webkit.org/>
References: <bug-27777-0@https.bugs.webkit.org/>
Message-ID: <20090729005956.DBCC4341BE27@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Avi Drissman <avi at drissman.com>'s
request for review:
Bug 27777: ImageSourceCG makes bad data refs (race condition causes blank
images)
https://bugs.webkit.org/show_bug.cgi?id=27777

Attachment 33679: Patch with platform fix and "static"
https://bugs.webkit.org/attachment.cgi?id=33679&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 18:21:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 18:21:15 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27760]
 HTMLOptionElement::value() returns incorrect value : [Attachment 33613]
 patch
In-Reply-To: <bug-27760-0@https.bugs.webkit.org/>
References: <bug-27760-0@https.bugs.webkit.org/>
Message-ID: <20090729012115.77FE2341C25F@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has canceled	review:
Bug 27760: HTMLOptionElement::value() returns incorrect value
https://bugs.webkit.org/show_bug.cgi?id=27760

Attachment 33613: patch
https://bugs.webkit.org/attachment.cgi?id=33613&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 18:21:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 18:21:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27760]
 HTMLOptionElement::value() returns incorrect value : [Attachment 33685]
 patch
In-Reply-To: <bug-27760-0@https.bugs.webkit.org/>
References: <bug-27760-0@https.bugs.webkit.org/>
Message-ID: <20090729012121.10585341C26C@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27760: HTMLOptionElement::value() returns incorrect value
https://bugs.webkit.org/show_bug.cgi?id=27760

Attachment 33685: patch
https://bugs.webkit.org/attachment.cgi?id=33685&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 18:36:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 18:36:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27789] [Qt] Build fix after
 r46502 : [Attachment 33686] proposed patch
In-Reply-To: <bug-27789-0@https.bugs.webkit.org/>
References: <bug-27789-0@https.bugs.webkit.org/>
Message-ID: <20090729013606.23C6B341C3BB@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27789: [Qt] Build fix after r46502
https://bugs.webkit.org/show_bug.cgi?id=27789

Attachment 33686: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33686&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 18:47:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 18:47:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27789] [Qt] Build fix after
 r46502 : [Attachment 33686] proposed patch
In-Reply-To: <bug-27789-0@https.bugs.webkit.org/>
References: <bug-27789-0@https.bugs.webkit.org/>
Message-ID: <20090729014744.1A27D341C496@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27789: [Qt] Build fix after r46502
https://bugs.webkit.org/show_bug.cgi?id=27789

Attachment 33686: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33686&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Note that you don't need code review for simple build fixes like this.

From bugzilla-daemon at webkit.org  Tue Jul 28 19:03:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 19:03:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27791] 307 redirects of
 POSTs should use POST, not GET : [Attachment 33687] Mac and Windows fix,
 plus layout test
In-Reply-To: <bug-27791-0@https.bugs.webkit.org/>
References: <bug-27791-0@https.bugs.webkit.org/>
Message-ID: <20090729020325.D4F63341C866@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27791: 307 redirects of POSTs should use POST, not GET
https://bugs.webkit.org/show_bug.cgi?id=27791

Attachment 33687: Mac and Windows fix, plus layout test
https://bugs.webkit.org/attachment.cgi?id=33687&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 19:13:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 19:13:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27748] crash w/ stack
 overflow when same CSS file loaded repeatedly : [Attachment 33688] revied
 patch w/ sam's comments - data file reduced from 50k lines to 30k
In-Reply-To: <bug-27748-0@https.bugs.webkit.org/>
References: <bug-27748-0@https.bugs.webkit.org/>
Message-ID: <20090729021355.1802A341C975@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 27748: crash w/ stack overflow when same CSS file loaded repeatedly
https://bugs.webkit.org/show_bug.cgi?id=27748

Attachment 33688: revied patch w/ sam's comments - data file reduced from 50k
lines to 30k
https://bugs.webkit.org/attachment.cgi?id=33688&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 19:22:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 19:22:15 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 33683] Patch v4
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090729022215.C351E341CCD9@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 33683: Patch v4
https://bugs.webkit.org/attachment.cgi?id=33683&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Biggest concern:

I don't understand the bootstrapping aspect to this. In order to create a well
formed patch, I need a changelog with a bug link/title.  This tool creates a
bug for a patch, but by definition, the patch must not be well formed because
the bug doesn't exist yet.

It could modify the ChangeLog right after creating the bug (but that sounds
complicated especially considering that you can given it a COMMITISH....)

On to the details.


> diff --git a/WebKitTools/Scripts/bugzilla-tool
b/WebKitTools/Scripts/bugzilla-tool
> +class CreateBug(Command):
> +    def __init__(self):
> +	   Command.__init__(self, 'Create a bug from local changes or local
commits', '[COMMITISH]', options=options)

Nice to add period to this sentence.

> +
> +    def create_bug_from_commit(self, options, args, tool):
> +	   commit_ids = tool.scm().commit_ids_from_range_arguments(args,
cherry_pick=True)

This won't be very friendly to svn users if they happen to given an extra
argument.  Maybe it should check that it is git and if not, error out with a
friendly message.


> diff --git a/WebKitTools/Scripts/modules/bugzilla.py
b/WebKitTools/Scripts/modules/bugzilla.py
> +    def check_create_bug_response_returning_bug_id_on_success(self,
response_html):

If you don't expect external callers, then prefix it with a _

It is quite long. What about _get_create_bug_id(self, create_bug_response):
or something else (even) shorter?

> +    def create_bug_with_patch(self, bug_title, bug_description, component,
patch_file_object, patch_description, cc, mark_for_review=False):
...
> +	   if not component or component not in [item.name for item in
component_items]:
> +	       component = self.prompt_for_component([item.name for item in
component_items])

This is fine.  I like this better:

	component_names = map(lambda item: item.name, component_items)
	if not component or component not in component_names:
	    component = self.prompt_for_component(component_names)

You choose.

From bugzilla-daemon at webkit.org  Tue Jul 28 19:29:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 19:29:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27760]
 HTMLOptionElement::value() returns incorrect value : [Attachment 33685]
 patch
In-Reply-To: <bug-27760-0@https.bugs.webkit.org/>
References: <bug-27760-0@https.bugs.webkit.org/>
Message-ID: <20090729022932.910B6341CD9D@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has granted TAMURA, Kent
<tkent at chromium.org>'s request for review:
Bug 27760: HTMLOptionElement::value() returns incorrect value
https://bugs.webkit.org/show_bug.cgi?id=27760

Attachment 33685: patch
https://bugs.webkit.org/attachment.cgi?id=33685&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks perfect, r=me.

From bugzilla-daemon at webkit.org  Tue Jul 28 20:35:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 20:35:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27447] WebInspector: Accept
 autocomplete on 'End' key pressed. : [Attachment 33163] patch
In-Reply-To: <bug-27447-0@https.bugs.webkit.org/>
References: <bug-27447-0@https.bugs.webkit.org/>
Message-ID: <20090729033540.5C76C341D481@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 27447: WebInspector: Accept autocomplete on 'End' key pressed.
https://bugs.webkit.org/show_bug.cgi?id=27447

Attachment 33163: patch
https://bugs.webkit.org/attachment.cgi?id=33163&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
Sometimes space accepts completions too, but I think that isn't as comon. (I
never used End before.)

From bugzilla-daemon at webkit.org  Tue Jul 28 20:45:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 20:45:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 19874] Inspector should
 support inspect() in the command line : [Attachment 33047] used workaround
 for DOMStorage
In-Reply-To: <bug-19874-0@https.bugs.webkit.org/>
References: <bug-19874-0@https.bugs.webkit.org/>
Message-ID: <20090729034508.883C5341D561@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 19874: Inspector should support inspect() in the command line
https://bugs.webkit.org/show_bug.cgi?id=19874

Attachment 33047: used workaround for DOMStorage
https://bugs.webkit.org/attachment.cgi?id=33047&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 20:50:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 20:50:02 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27701] [V8] Teach
 V8Proxy::context about isolated worlds : [Attachment 33528] patch
In-Reply-To: <bug-27701-0@https.bugs.webkit.org/>
References: <bug-27701-0@https.bugs.webkit.org/>
Message-ID: <20090729035002.BCD97341D5C9@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27701: [V8] Teach V8Proxy::context about isolated worlds
https://bugs.webkit.org/show_bug.cgi?id=27701

Attachment 33528: patch
https://bugs.webkit.org/attachment.cgi?id=33528&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok. Will this affect performance in any measurable way?

From bugzilla-daemon at webkit.org  Tue Jul 28 20:55:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 20:55:52 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27533] [V8] Fix isolated
 world wrappers for event handlers : [Attachment 33273] patch with less
 trailing whitespace
In-Reply-To: <bug-27533-0@https.bugs.webkit.org/>
References: <bug-27533-0@https.bugs.webkit.org/>
Message-ID: <20090729035552.72FD9341D64C@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 27533: [V8] Fix isolated world wrappers for event handlers
https://bugs.webkit.org/show_bug.cgi?id=27533

Attachment 33273: patch with less trailing whitespace
https://bugs.webkit.org/attachment.cgi?id=33273&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
ok. I wonder if OwnHandler would rather live in v8 namespace? It seems like a
useful primitive and not very WebCore-specific.

From bugzilla-daemon at webkit.org  Tue Jul 28 21:03:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:03:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27746] Inspector: Tab Through
 the DOM Storage DataGrid when Editing : [Attachment 33583] Tab Through DOM
 Storage DataGrid When Editing
In-Reply-To: <bug-27746-0@https.bugs.webkit.org/>
References: <bug-27746-0@https.bugs.webkit.org/>
Message-ID: <20090729040319.6F8F4341D6FC@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27746: Inspector: Tab Through the DOM Storage DataGrid when Editing
https://bugs.webkit.org/show_bug.cgi?id=27746

Attachment 33583: Tab Through DOM Storage DataGrid When Editing
https://bugs.webkit.org/attachment.cgi?id=33583&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 21:30:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:30:16 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27322] Inspector: Create New
 DOM Storage Items via DataGrid : [Attachment 32821] Make DOM Storage
 DataGrid More Interactive
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090729043016.9E1CC341DC28@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 32821: Make DOM Storage DataGrid More Interactive
https://bugs.webkit.org/attachment.cgi?id=32821&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Clearing r+ on obsolete patch to move out of commit queue.

From bugzilla-daemon at webkit.org  Tue Jul 28 21:38:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:38:46 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27322] Inspector: Create New
 DOM Storage Items via DataGrid : [Attachment 33577] Make DOM Storage
 DataGrid More Interactive
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090729043846.EB719341DCBA@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has canceled Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 33577: Make DOM Storage DataGrid More Interactive
https://bugs.webkit.org/attachment.cgi?id=33577&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 21:38:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:38:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27322] Inspector: Create
 New DOM Storage Items via DataGrid : [Attachment 33689] Fixed the Loop
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090729043847.08F96341DCBD@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 33689: Fixed the Loop
https://bugs.webkit.org/attachment.cgi?id=33689&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 21:41:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:41:44 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33549]
 Fixed sortedProperties
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090729044144.B1E2C341DD0B@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has canceled Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33549: Fixed sortedProperties
https://bugs.webkit.org/attachment.cgi?id=33549&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 21:47:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:47:32 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27322] Inspector: Create New
 DOM Storage Items via DataGrid : [Attachment 33689] Fixed the Loop
In-Reply-To: <bug-27322-0@https.bugs.webkit.org/>
References: <bug-27322-0@https.bugs.webkit.org/>
Message-ID: <20090729044732.C6CE5341DD89@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27322: Inspector: Create New DOM Storage Items via DataGrid
https://bugs.webkit.org/show_bug.cgi?id=27322

Attachment 33689: Fixed the Loop
https://bugs.webkit.org/attachment.cgi?id=33689&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 21:47:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:47:45 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 33683] Patch v4
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090729044745.04B7D341DD95@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 33683: Patch v4
https://bugs.webkit.org/attachment.cgi?id=33683&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 21:47:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 21:47:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 33691] Patch v5
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090729044748.CF938341DDB6@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 33691: Patch v5
https://bugs.webkit.org/attachment.cgi?id=33691&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 22:31:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 22:31:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33693]
 Eliminated reduce
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090729053110.A431F341E41B@gamma.macosforge.org>

Keishi Hattori <casey.hattori at gmail.com> has asked  for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33693: Eliminated reduce
https://bugs.webkit.org/attachment.cgi?id=33693&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 22:40:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 22:40:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27119] bugzilla-tool: Add
 create-bug command : [Attachment 33691] Patch v5
In-Reply-To: <bug-27119-0@https.bugs.webkit.org/>
References: <bug-27119-0@https.bugs.webkit.org/>
Message-ID: <20090729054028.71B60341E4CB@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27119: bugzilla-tool: Add create-bug command
https://bugs.webkit.org/show_bug.cgi?id=27119

Attachment 33691: Patch v5
https://bugs.webkit.org/attachment.cgi?id=33691&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> diff --git a/WebKitTools/ChangeLog b/WebKitTools/ChangeLog
> +2009-07-28  David Kilzer  <ddkilzer at apple.com>
> +
> +	   <http://webkit.org/b/27119> bugzilla-tool: Add create-bug command
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Implement "create-bug" command for bugzilla-tool.

oooo new format :)


> diff --git a/WebKitTools/Scripts/modules/bugzilla.py
b/WebKitTools/Scripts/modules/bugzilla.py

> +	   if match:
> +	       text_lines =
BeautifulSoup(match.group('error_message')).findAll(text=True)
> +	       error_message = "\n" + '\n'.join(["  " + line.strip() for line
in text_lines if line.strip()])

fwiw, this statment is at the edge of the complexity boundary.	It is hard to
define but when you start seeing "for in if" + other stuff, you're close.

I'd leave it as is though.  Just something to keep in mind in your future
python writing sessions :)

From bugzilla-daemon at webkit.org  Tue Jul 28 22:52:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 22:52:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27756] [HTML5][Forms]
 Support for HTMLInputElement::list and HTMLInputElement::selectedOption :
 [Attachment 33604] Support for HTMLInputElement::list and
 HTMLInputElement::selectedOption.
In-Reply-To: <bug-27756-0@https.bugs.webkit.org/>
References: <bug-27756-0@https.bugs.webkit.org/>
Message-ID: <20090729055214.0B2E0341E5B6@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has canceled	review:
Bug 27756: [HTML5][Forms] Support for HTMLInputElement::list and
HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33604: Support for HTMLInputElement::list and
HTMLInputElement::selectedOption.
https://bugs.webkit.org/attachment.cgi?id=33604&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 22:52:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 22:52:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27756] [HTML5][Forms]
 Support for HTMLInputElement::list and HTMLInputElement::selectedOption :
 [Attachment 33694] Support for HTMLInputElement::list and
 HTMLInputElement::selectedOption.
In-Reply-To: <bug-27756-0@https.bugs.webkit.org/>
References: <bug-27756-0@https.bugs.webkit.org/>
Message-ID: <20090729055218.A9C5A341E5C5@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27756: [HTML5][Forms] Support for HTMLInputElement::list and
HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33694: Support for HTMLInputElement::list and
HTMLInputElement::selectedOption.
https://bugs.webkit.org/attachment.cgi?id=33694&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>

---
 10 files changed, 265 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Tue Jul 28 23:13:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 23:13:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27696] Inspector: Console
 should show completions for the command line APIs : [Attachment 33693]
 Eliminated reduce
In-Reply-To: <bug-27696-0@https.bugs.webkit.org/>
References: <bug-27696-0@https.bugs.webkit.org/>
Message-ID: <20090729061318.F17A5341E757@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Keishi Hattori
<casey.hattori at gmail.com>'s request for review:
Bug 27696: Inspector: Console should show completions for the command line APIs
https://bugs.webkit.org/show_bug.cgi?id=27696

Attachment 33693: Eliminated reduce
https://bugs.webkit.org/attachment.cgi?id=33693&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 23:23:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 23:23:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33695] Fixed style issues;
 added main thread assert
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090729062348.3E563341EAAE@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has asked  for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33695: Fixed style issues; added main thread assert
https://bugs.webkit.org/attachment.cgi?id=33695&action=review

From bugzilla-daemon at webkit.org  Tue Jul 28 23:39:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Tue, 28 Jul 2009 23:39:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27767] Kill the annoying
 (and misunderstandable) LEAK messages in debug mode : [Attachment 33696]
 propsed patch v2
In-Reply-To: <bug-27767-0@https.bugs.webkit.org/>
References: <bug-27767-0@https.bugs.webkit.org/>
Message-ID: <20090729063951.B3AAA341EC13@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 27767: Kill the annoying (and misunderstandable) LEAK messages in debug
mode
https://bugs.webkit.org/show_bug.cgi?id=27767

Attachment 33696: propsed patch v2
https://bugs.webkit.org/attachment.cgi?id=33696&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 00:20:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 00:20:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27794] [HTML5][Forms]
 Introduce new pseudo selector, new appearance,
 and new control part for the list attribute support : [Attachment 33697]
 Proposed patch
In-Reply-To: <bug-27794-0@https.bugs.webkit.org/>
References: <bug-27794-0@https.bugs.webkit.org/>
Message-ID: <20090729072035.593FC341F240@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27794: [HTML5][Forms] Introduce new pseudo selector, new appearance, and
new control part for the list attribute support
https://bugs.webkit.org/show_bug.cgi?id=27794

Attachment 33697: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33697&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
* See https://bugs.webkit.org/attachment.cgi?id=33600 for the actual
appearance.
* I'll add tests with another patch.

From bugzilla-daemon at webkit.org  Wed Jul 29 00:39:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 00:39:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27757]
 update-webkit-auxiliary-libs,
 update-webkit-support-libs cause Perl warnings about functions tmpnam and
 tmpfile : [Attachment 33603] Patch
In-Reply-To: <bug-27757-0@https.bugs.webkit.org/>
References: <bug-27757-0@https.bugs.webkit.org/>
Message-ID: <20090729073902.493D3341F466@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled  review:
Bug 27757: update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl
warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33603: Patch
https://bugs.webkit.org/attachment.cgi?id=33603&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Cleared r+ on obsolete patch to move this out of the commit queue.

From bugzilla-daemon at webkit.org  Wed Jul 29 00:57:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 00:57:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27209] Add WebSocket.idl :
 [Attachment 32916] add WebSocket.idl
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090729075714.45912341F5B0@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has canceled Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 32916: add WebSocket.idl
https://bugs.webkit.org/attachment.cgi?id=32916&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 00:57:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 00:57:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27209] Add WebSocket.idl :
 [Attachment 33698] add WebSocket.idl and js binding classes.
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090729075719.296E6341F5C5@gamma.macosforge.org>

Fumitoshi Ukai <ukai at chromium.org> has asked  for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 33698: add WebSocket.idl and js binding classes.
https://bugs.webkit.org/attachment.cgi?id=33698&action=review

------- Additional Comments from Fumitoshi Ukai <ukai at chromium.org>

---
 7 files changed, 619 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 29 01:30:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 01:30:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27767] Kill the annoying
 (and misunderstandable) LEAK messages in debug mode : [Attachment 33696]
 propsed patch v2
In-Reply-To: <bug-27767-0@https.bugs.webkit.org/>
References: <bug-27767-0@https.bugs.webkit.org/>
Message-ID: <20090729083004.5DB14341FBD1@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has canceled Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27767: Kill the annoying (and misunderstandable) LEAK messages in debug
mode
https://bugs.webkit.org/show_bug.cgi?id=27767

Attachment 33696: propsed patch v2
https://bugs.webkit.org/attachment.cgi?id=33696&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 01:30:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 01:30:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27767] Kill the annoying
 (and misunderstandable) LEAK messages in debug mode : [Attachment 33700]
 propsed patch v3
In-Reply-To: <bug-27767-0@https.bugs.webkit.org/>
References: <bug-27767-0@https.bugs.webkit.org/>
Message-ID: <20090729083004.97F6C341FBD5@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has asked  for review:
Bug 27767: Kill the annoying (and misunderstandable) LEAK messages in debug
mode
https://bugs.webkit.org/show_bug.cgi?id=27767

Attachment 33700: propsed patch v3
https://bugs.webkit.org/attachment.cgi?id=33700&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 01:34:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 01:34:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27767] Kill the annoying (and
 misunderstandable) LEAK messages in debug mode : [Attachment 33700] propsed
 patch v3
In-Reply-To: <bug-27767-0@https.bugs.webkit.org/>
References: <bug-27767-0@https.bugs.webkit.org/>
Message-ID: <20090729083404.4A230341FC49@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Zoltan Herczeg
<zherczeg at inf.u-szeged.hu>'s request for review:
Bug 27767: Kill the annoying (and misunderstandable) LEAK messages in debug
mode
https://bugs.webkit.org/show_bug.cgi?id=27767

Attachment 33700: propsed patch v3
https://bugs.webkit.org/attachment.cgi?id=33700&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 29 02:19:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 02:19:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24758] [Gtk] Implement a
 WebDataSource for the gtk port : [Attachment 33015] updated datasource
 patch
In-Reply-To: <bug-24758-0@https.bugs.webkit.org/>
References: <bug-24758-0@https.bugs.webkit.org/>
Message-ID: <20090729091918.CF3A93420308@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 33015: updated datasource patch
https://bugs.webkit.org/attachment.cgi?id=33015&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> +void DocumentLoader::detachDataSource()
> +{
> +    ASSERT(!m_isDataSourceReffed);
> +    unrefDataSource();
> +}

Mmm, I don't think this ASSERT can be right, since unrefDataSource won't do
anything if !m_isDataSourceReffed.

> +
> +void DocumentLoader::detachFromFrame()
> +{
> +    WebCore::DocumentLoader::detachFromFrame();
> +
> +    if (m_loadingResources.isEmpty())
> +	   unrefDataSource();
> +
> +}

So this will silently not do stuff if there are resources still being loaded. I
suppose that's OK?

> +
> +void DocumentLoader::decreaseLoadCount(unsigned long identifier)
> +{
> +    HashSet<unsigned long>::iterator it =
m_loadingResources.find(identifier);
> +
> +    // It is valid for a load to be cancelled before it's started.
> +    if (it == m_loadingResources.end())
> +	   return;
> +
> +    m_loadingResources.remove(it);
> +
> +    if (m_loadingResources.isEmpty() && !frame())
> +	   unrefDataSource();
> +
> +}

Mmm, this seems to not do one unref per call, as opposed to the
increaseLoadCount function which does that (for different resources). Is this
done elsewhere?


>  WTF::PassRefPtr<WebCore::DocumentLoader>
FrameLoaderClient::createDocumentLoader(const WebCore::ResourceRequest&
request, const SubstituteData& substituteData)
>  {
> -    return DocumentLoader::create(request, substituteData);
> +    RefPtr<WebKit::DocumentLoader> loader =
WebKit::DocumentLoader::create(request, substituteData);
> +
> +    WebKitWebDataSource* webDataSource =
webkit_web_data_source_new_with_loader(loader.get());
> +    loader->setDataSource(webDataSource);
> +    g_object_unref(webDataSource);

Mmm, this seems a bit pointless:

- Create a loader.
- Create a datasource from the loader (and nothing else).
- Set the datasource in the loader.

Couldn't this happen automatically with a 'create' of our own or something like
that?

> +#define WEBKIT_WEB_DATA_SOURCE_GET_PRIVATE(obj)	 
(G_TYPE_INSTANCE_GET_PRIVATE((obj), WEBKIT_TYPE_WEB_DATA_SOURCE,
WebKitWebDataSourcePrivate))
> +
> +G_DEFINE_TYPE(WebKitWebDataSource, webkit_web_data_source, G_TYPE_OBJECT);
> +
> +static void webkit_web_data_source_dispose(GObject* object)
> +{
> +    WebKitWebDataSource* webDataSource = WEBKIT_WEB_DATA_SOURCE(object);
> +    WebKitWebDataSourcePrivate* priv = webDataSource->priv;
> +
> +    ASSERT(priv->loader);
> +    ASSERT(!priv->loader->isLoading());
> +    priv->loader->detachDataSource();
> +    priv->loader->deref();
> +
> +    if (priv->initialRequest)
> +	   g_object_unref(priv->initialRequest);
> +
> +    if (priv->networkRequest)
> +	   g_object_unref(priv->networkRequest);
> +
> +    if (priv->mainResource)
> +	   g_object_unref(priv->mainResource);
> +
> +    if (priv->data)
> +	   g_string_free(priv->data, FALSE);

You need to set all those to NULL, dispose can be called multiple times.

> +
> +    if (priv->subresources) {
> +	   for (unsigned i=0; i < priv->subresources->len; i++) {
> +	       WebKitWebResource* res = &g_array_index(priv->subresources,
WebKitWebResource, i);
> +	       if (res)
> +		   g_object_unref(res);
> +	   }
> +
> +	   g_array_free(priv->subresources, TRUE);
> +    }

What's the point of using an array here? A list seems much more natural (seems
Gustavo suggests a hash to be able to get easily a resource by its identifier,
that might make sense too).

> +
> +    G_OBJECT_CLASS(webkit_web_data_source_parent_class)->dispose(object);
> +}
> +
> +static void webkit_web_data_source_finalize(GObject* object)
> +{
> +    WebKitWebDataSource* dataSource = WEBKIT_WEB_DATA_SOURCE(object);
> +    WebKitWebDataSourcePrivate* priv = dataSource->priv;
> +
> +    priv->unreachableURL = CString();

Same comment about this than in previous patch.

> +/**
> + * webkit_web_data_source_new:
> + * @request: the #WebKitNetworkRequest to use to create this data source
> + *
> + * Creates a new #WebKitWebDataSource from a #WebKitNetworkRequest.
Normally,
> + * #WebKitWebFrame objects create their data sources so you will almost
never
> + * want to invoke this method directly.
> + *
> + * Returns: a new #WebKitWebDataSource
> + *
> + * Since: 1.1.12
> + */
> +WebKitWebDataSource* webkit_web_data_source_new(WebKitNetworkRequest*
request)
> +{
> +    ASSERT(request);
> +
> +    const gchar* uri = webkit_network_request_get_uri(request);
> +
> +    WebKitWebDataSource* datasource;
> +    datasource = webkit_web_data_source_new_with_loader(
> +	   WebKit::DocumentLoader::create(ResourceRequest(KURL(KURL(),
String::fromUTF8(uri))),
> +					  SubstituteData()));
> +
> +    WebKitWebDataSourcePrivate* priv = datasource->priv;
> +    priv->initialRequest = request;
> +
> +    return datasource;
> +}

_new functions should, when possible, only be a call to g_object_new (otherwise
bindings have to override them). This could probably be fixed by making the
request/uri a property of the object and doing the needed setup there?

> +
> +/**
> + * webkit_web_data_source_get_text_encoding_name:

Same than in the other patch, we might want to just call thes
"get_text_encoding" to be consistent with existing APIs.

> +
> +/**
> + * webkit_web_data_source_get_data:
> + * @data_source: a #WebKitWebDataSource
> + *
> + * Returns the raw data that represents the the frame's content.The data
will
> + * be incomplete until the data has finished loading. Returns %NULL if the
web
> + * frame hasn't loaded any data. Use webkit_web_data_source_is_loading to
test
> + * if data source is in the process of loading.
> + *
> + * Return value: a #GString which contains the raw data that represents the
@data_source or %NULL if the
> + * @data_source hasn't loaded any data.
> + *
> + * Since: 1.1.12
> + */
> +G_CONST_RETURN GString* webkit_web_data_source_get_data(WebKitWebDataSource*
webDataSource)
> +{
> +    g_return_val_if_fail(WEBKIT_IS_WEB_DATA_SOURCE(webDataSource), NULL);
> +
> +    WebKitWebDataSourcePrivate* priv = webDataSource->priv;
> +
> +    RefPtr<SharedBuffer> mainResourceData =
priv->loader->mainResourceData();
> +
> +    if (!mainResourceData)
> +	   return NULL;
> +
> +    if (!priv->data)
> +	   priv->data = g_string_new(mainResourceData->data());

Can the data have '0'? If yes, then you need the length and do
g_string_new_with_len.

> +
> +/**
> + * webkit_web_data_source_get_subresources:
> + * @data_source: a #WebKitWebDataSource
> + *
> + * Returns the @data_source subresources that have finished downloading
> + *
> + * Return value: a #GArray of #WebKitWebResource. The array if owned by
WebKit
> + * and should not be freed or destroyed.
> + *
> + * Since: 1.1.12
> + */
> +GArray* webkit_web_data_source_get_subresources(WebKitWebDataSource*
webDataSource)

See previous comment about using a list or a hash table here.

> +
> +/**
> + * webkit_web_data_source_get_resource_for_url:
> + * @data_source: a #WebKitWebDataSource
> + * @url: the url of a resource
> + *
> + * Returns the #WebKitWebResource for the given URL
> + *
> + * Return value: the #WebKitWebResource for @url
> + *
> + * Since: 1.1.12
> + */
> +WebKitWebResource*
webkit_web_data_source_get_resource_for_url(WebKitWebDataSource* webDataSource,
const gchar* url)

Mmm, shouldn't this return one of the elements in the array we have?

Marking r- while we address some of the issues.

From bugzilla-daemon at webkit.org  Wed Jul 29 02:30:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 02:30:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33704] Add QWebPluginDatabase class to
 the Qt API (with API docs).
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729093016.74A2A3420400@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33704: Add QWebPluginDatabase class to the Qt API (with API docs).
https://bugs.webkit.org/attachment.cgi?id=33704&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 02:32:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 02:32:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27798] [chromium] Media
 control panel for <video> in MediaDocument is mis-placed : [Attachment
 33706] patch
In-Reply-To: <bug-27798-0@https.bugs.webkit.org/>
References: <bug-27798-0@https.bugs.webkit.org/>
Message-ID: <20090729093230.66FBC342045A@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27798: [chromium] Media control panel for <video> in MediaDocument is
mis-placed
https://bugs.webkit.org/show_bug.cgi?id=27798

Attachment 33706: patch
https://bugs.webkit.org/attachment.cgi?id=33706&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 02:50:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 02:50:05 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27798] [chromium] Media
 control panel for <video> in MediaDocument is mis-placed : [Attachment
 33706] patch
In-Reply-To: <bug-27798-0@https.bugs.webkit.org/>
References: <bug-27798-0@https.bugs.webkit.org/>
Message-ID: <20090729095005.1651E34205F2@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27798: [chromium] Media control panel for <video> in MediaDocument is
mis-placed
https://bugs.webkit.org/show_bug.cgi?id=27798

Attachment 33706: patch
https://bugs.webkit.org/attachment.cgi?id=33706&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/ChangeLog

> +2009-07-29  Alpha Lam  <hclam at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).

This should be added to the changelog:

  Media control panel for <video> in MediaDocument is mis-placed
  https://bugs.webkit.org/show_bug.cgi?id=27798

If you can use prepare-ChangeLog --bug #, this will be set-up for you.

From bugzilla-daemon at webkit.org  Wed Jul 29 02:59:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 02:59:45 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27799] [chromium] Font size
 for current time display in media controls panel is affected by body font
 size : [Attachment 33709] patch
In-Reply-To: <bug-27799-0@https.bugs.webkit.org/>
References: <bug-27799-0@https.bugs.webkit.org/>
Message-ID: <20090729095945.3312834206D4@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27799: [chromium] Font size for current time display in media controls
panel is affected by body font size
https://bugs.webkit.org/show_bug.cgi?id=27799

Attachment 33709: patch
https://bugs.webkit.org/attachment.cgi?id=33709&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 03:32:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 03:32:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26848] [Qt]
 ResourceHandle::willLoadFromCache needs to be implmeneted QtWebKit. :
 [Attachment 33100] modify the patch to include Zecke's review comments.
In-Reply-To: <bug-26848-0@https.bugs.webkit.org/>
References: <bug-26848-0@https.bugs.webkit.org/>
Message-ID: <20090729103247.1B00D3420BD4@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Yongjun Zhang
<yongjun.zhang at nokia.com>'s request for review:
Bug 26848: [Qt] ResourceHandle::willLoadFromCache needs to be implmeneted
QtWebKit.
https://bugs.webkit.org/show_bug.cgi?id=26848

Attachment 33100: modify the patch to include Zecke's review comments.
https://bugs.webkit.org/attachment.cgi?id=33100&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. There's a typo in the ChangeLog and the "No new tests" line shouldn't be
there, but I'll remove that when landing.

From bugzilla-daemon at webkit.org  Wed Jul 29 04:00:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 04:00:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27800] Move controlClip
 from RenderTextControlSingleLine to TextControlElements.cpp : [Attachment
 33710] Proposed patch
In-Reply-To: <bug-27800-0@https.bugs.webkit.org/>
References: <bug-27800-0@https.bugs.webkit.org/>
Message-ID: <20090729110024.7F8563420E21@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27800: Move controlClip from RenderTextControlSingleLine to
TextControlElements.cpp
https://bugs.webkit.org/show_bug.cgi?id=27800

Attachment 33710: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33710&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 04:39:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 04:39:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27801] [WML] Running WML
 tests in random order multiple times exposes subtle bugs : [Attachment
 33711] Initial patch
In-Reply-To: <bug-27801-0@https.bugs.webkit.org/>
References: <bug-27801-0@https.bugs.webkit.org/>
Message-ID: <20090729113924.76FAE342144F@gamma.macosforge.org>

Nikolas Zimmermann <zimmermann at kde.org> has asked  for review:
Bug 27801: [WML] Running WML tests in random order multiple times exposes
subtle bugs
https://bugs.webkit.org/show_bug.cgi?id=27801

Attachment 33711: Initial patch
https://bugs.webkit.org/attachment.cgi?id=33711&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 05:10:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 05:10:20 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24758] [Gtk] Implement a
 WebDataSource for the gtk port : [Attachment 33016] Updated frame data
 source API patch
In-Reply-To: <bug-24758-0@https.bugs.webkit.org/>
References: <bug-24758-0@https.bugs.webkit.org/>
Message-ID: <20090729121020.CC4DF3421717@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has denied Jan Alonzo <jmalonzo at gmail.com>'s
request for review:
Bug 24758: [Gtk] Implement a WebDataSource for the gtk port
https://bugs.webkit.org/show_bug.cgi?id=24758

Attachment 33016: Updated frame data source API patch
https://bugs.webkit.org/attachment.cgi?id=33016&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
> +static void web_data_source_fixture_teardown(WebDataSourceFixture* fixture,
> +						gconstpointer data)
> +{
> +    g_assert(fixture->mainFrame != NULL);
> +    g_assert(fixture->webView != NULL);

Just g_assert (fixture->mainFrame);, etc?


>  /**
> + * webkit_web_frame_get_data_source:
> + * @frame: a #WebKitWebFrame
> + *
> + * Returns the committed data source.
> + *
> + * Return value: the committed #WebKitWebDataSource or %NULL if the
> + * provisional data source is not done loading.
> + *
> + * Since: 1.1.5

1.1.5? :)

> + */
> +WebKitWebDataSource* webkit_web_frame_get_data_source(WebKitWebFrame* frame)

> +{
> +    g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), NULL);
> +
> +    Frame* coreFrame = core(frame);
> +    WebKitWebDataSource* dataSource;

You need to initialize this to NULL here, otherwise you could crash below.

> +
> +    if (coreFrame && coreFrame->loader()->frameHasLoaded())
> +	   dataSource =
webkit_web_frame_get_data_source_from_core_loader(coreFrame->loader()->document
Loader());
> +
> +    if (!dataSource)
> +	   return NULL;
> +
> +    return dataSource;
> +}
> +
> +/**
> + * webkit_web_frame_get_provisional_data_source:
> + * @frame: a #WebKitWebFrame
> + *
> + * You use the webkit_web_frame_load_request method to initiate a request
that
> + * creates a provisional data source. The provisional data source will
> + * transition to a committed data source once any data has been received.
Use
> + * webkit_web_frame_get_data_source to get the committed data source.
> + *
> + * Return value: the provisional #WebKitWebDataSource or %NULL if a load
> + * request is not in progress or has been completed.
> + *
> + * Since: 1.1.5

Version again.

> + */
> +WebKitWebDataSource*
webkit_web_frame_get_provisional_data_source(WebKitWebFrame* frame)
> +{
> +    g_return_val_if_fail(WEBKIT_IS_WEB_FRAME(frame), NULL);
> +
> +    Frame* coreFrame = core(frame);
> +    WebKitWebDataSource* dataSource =
webkit_web_frame_get_data_source_from_core_loader(coreFrame->loader()->provisio
nalDocumentLoader());
> +
> +    if (!dataSource)
> +	   return NULL;
> +
> +    return dataSource;

You can jsut return the dataSource, this does not really add anything.

Marking as r- for now.

From bugzilla-daemon at webkit.org  Wed Jul 29 05:39:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 05:39:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33442] Fix style in PluginPackage and
 PluginDatabase.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729123948.8A5573421BDD@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has canceled  review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33442: Fix style in PluginPackage and PluginDatabase.
https://bugs.webkit.org/attachment.cgi?id=33442&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
Clearing review.

From bugzilla-daemon at webkit.org  Wed Jul 29 07:46:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 07:46:48 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27613]
 WebCore/page/ContextMenuController.cpp does not conform to style standards
 : [Attachment 33714] Replacement patch for ContextMenuController.cpp style
 fixes.
In-Reply-To: <bug-27613-0@https.bugs.webkit.org/>
References: <bug-27613-0@https.bugs.webkit.org/>
Message-ID: <20090729144648.8A0663422E06@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27613: WebCore/page/ContextMenuController.cpp does not conform to style
standards
https://bugs.webkit.org/show_bug.cgi?id=27613

Attachment 33714: Replacement patch for ContextMenuController.cpp style fixes.
https://bugs.webkit.org/attachment.cgi?id=33714&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 07:49:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 07:49:49 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27651] [Qt] QWebPluginDatabase
 API : [Attachment 33438] Allow to explicitly choose a preferred plugin for
 a mimetype.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729144949.597723422E62@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has denied Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33438: Allow to explicitly choose a preferred plugin for a mimetype.
https://bugs.webkit.org/attachment.cgi?id=33438&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
The patch looks good, but I think there's one bug left: The m_preferredPlugins
hash keeps PluginPackage instances alife, through the use of RefPtr. When
calling clear() as well as refresh() we may have to free the references to
these plugins, to allow the pluginpackage objects to be freed.

From bugzilla-daemon at webkit.org  Wed Jul 29 08:04:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 08:04:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27549] Make run-webkit-lint
 supports files as arguments : [Attachment 33712] Updates and improved patch
In-Reply-To: <bug-27549-0@https.bugs.webkit.org/>
References: <bug-27549-0@https.bugs.webkit.org/>
Message-ID: <20090729150414.2ACE63422FED@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27549: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/show_bug.cgi?id=27549

Attachment 33712: Updates and improved patch
https://bugs.webkit.org/attachment.cgi?id=33712&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I'm willing to do these changes, but I'd like to know how you feel about the
"consider" comments.


> diff --git a/WebKitTools/Scripts/check-webkit-style
b/WebKitTools/Scripts/check-webkit-style
> +  The file parameter is optional and multiple file scan be passed in.
Leaving

Consider:
  The file parameter is optional and multiple files to scan may be passed in

> +  out the file parameter will apply the check to the files currently not

Consider:
  out the file parameter will apply the check to the files changed 
  according to the scm system.


> +    if files and "--git-commit" in flags:
> +	   sys.stderr.write("ERROR: It is not possible to check files "
> +			     "and a specific commit at the same time.\n" +
cpp_style._USAGE)
>	   sys.exit(1)
> +    elif files:

Make this an "if" since the pre if "exits".

From bugzilla-daemon at webkit.org  Wed Jul 29 08:09:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 08:09:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33626] Updated patch, rebased against ToT and fixed windows and mac builds.
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090729150953.48BBC3423099@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33626: Updated patch, rebased against ToT and fixed windows and mac
builds.
https://bugs.webkit.org/attachment.cgi?id=33626&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
Clearing review after discussion with Adam Roben on IRC. Will upload a new
patch tomorrow with better explanation for the DLL warnings and the removal of
4273.

From bugzilla-daemon at webkit.org  Wed Jul 29 08:10:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 08:10:08 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33627] Rebased patch to build JavaScriptCore as shared library with Qt
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090729151008.41B5D34230B5@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has canceled Simon Hausmann
<hausmann at webkit.org>'s request for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33627: Rebased patch to build JavaScriptCore as shared library with
Qt
https://bugs.webkit.org/attachment.cgi?id=33627&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 08:13:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 08:13:58 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27549] Make run-webkit-lint
 supports files as arguments : [Attachment 33712] Updates and improved patch
In-Reply-To: <bug-27549-0@https.bugs.webkit.org/>
References: <bug-27549-0@https.bugs.webkit.org/>
Message-ID: <20090729151358.CDE9A342314F@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has canceled 
review:
Bug 27549: Make run-webkit-lint supports files as arguments
https://bugs.webkit.org/show_bug.cgi?id=27549

Attachment 33712: Updates and improved patch
https://bugs.webkit.org/attachment.cgi?id=33712&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Landed (with the above changes) in 46542.

From bugzilla-daemon at webkit.org  Wed Jul 29 08:16:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 08:16:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27799] [chromium] Font size
 for current time display in media controls panel is affected by body font
 size : [Attachment 33709] patch
In-Reply-To: <bug-27799-0@https.bugs.webkit.org/>
References: <bug-27799-0@https.bugs.webkit.org/>
Message-ID: <20090729151653.74A2934231C9@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Hin-Chung Lam <hclam at google.com>'s
request for review:
Bug 27799: [chromium] Font size for current time display in media controls
panel is affected by body font size
https://bugs.webkit.org/show_bug.cgi?id=27799

Attachment 33709: patch
https://bugs.webkit.org/attachment.cgi?id=33709&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 08:58:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 08:58:41 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27716] Add Geolocation
 layout tests. : [Attachment 33625] Patch for bug 27716
In-Reply-To: <bug-27716-0@https.bugs.webkit.org/>
References: <bug-27716-0@https.bugs.webkit.org/>
Message-ID: <20090729155841.2C3DF3423645@gamma.macosforge.org>

steveblock at google.com has canceled steveblock at google.com's request for review:
Bug 27716: Add Geolocation layout tests.
https://bugs.webkit.org/show_bug.cgi?id=27716

Attachment 33625: Patch for bug 27716
https://bugs.webkit.org/attachment.cgi?id=33625&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 09:13:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:13:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27805] Old dead pointer
 wrapping code in the v8 bindings. : [Attachment 33717] Patch.
In-Reply-To: <bug-27805-0@https.bugs.webkit.org/>
References: <bug-27805-0@https.bugs.webkit.org/>
Message-ID: <20090729161318.1FC80342378F@gamma.macosforge.org>

Dean McNamee <deanm at chromium.org> has asked  for review:
Bug 27805: Old dead pointer wrapping code in the v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27805

Attachment 33717: Patch.
https://bugs.webkit.org/attachment.cgi?id=33717&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 09:14:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:14:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27805] Old dead pointer
 wrapping code in the v8 bindings. : [Attachment 33717] Patch.
In-Reply-To: <bug-27805-0@https.bugs.webkit.org/>
References: <bug-27805-0@https.bugs.webkit.org/>
Message-ID: <20090729161439.3BB5F34237C5@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dean McNamee
<deanm at chromium.org>'s request for review:
Bug 27805: Old dead pointer wrapping code in the v8 bindings.
https://bugs.webkit.org/show_bug.cgi?id=27805

Attachment 33717: Patch.
https://bugs.webkit.org/attachment.cgi?id=33717&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
super-duper!

From bugzilla-daemon at webkit.org  Wed Jul 29 09:24:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:24:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27757]
 update-webkit-auxiliary-libs,
 update-webkit-support-libs cause Perl warnings about functions tmpnam and
 tmpfile : [Attachment 33653] Patch with updated ChangeLog
In-Reply-To: <bug-27757-0@https.bugs.webkit.org/>
References: <bug-27757-0@https.bugs.webkit.org/>
Message-ID: <20090729162423.B221734238E9@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Daniel Bates <dbates at berkeley.edu>'s
request for review:
Bug 27757: update-webkit-auxiliary-libs, update-webkit-support-libs cause Perl
warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33653: Patch with updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33653&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 09:29:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:29:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27655] [v8] cache v8
 strings when converting from webcore string to v8 string : [Attachment
 33718] Next iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090729162937.BF9D03423960@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33718: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33718&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
As was discussed by IM with David, for now I just put caching under a flag. 
This flag would be turned on for renderer process in Chromium (but it default
to false).

From bugzilla-daemon at webkit.org  Wed Jul 29 09:33:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:33:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27756] [HTML5][Forms] Support
 for HTMLInputElement::list and HTMLInputElement::selectedOption :
 [Attachment 33694] Support for HTMLInputElement::list and
 HTMLInputElement::selectedOption.
In-Reply-To: <bug-27756-0@https.bugs.webkit.org/>
References: <bug-27756-0@https.bugs.webkit.org/>
Message-ID: <20090729163347.5061C3423A00@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied TAMURA, Kent <tkent at chromium.org>'s
request for review:
Bug 27756: [HTML5][Forms] Support for HTMLInputElement::list and
HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33694: Support for HTMLInputElement::list and
HTMLInputElement::selectedOption.
https://bugs.webkit.org/attachment.cgi?id=33694&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You can just check here for dataListTag and cast directly to an
HTMLDataListElement:
742	    if (element && element->isHTMLElement() &&
element->hasTagName(datalistTag))
 1743		  return static_cast<HTMLElement*>(element)

Not required but slightly cleaner.

isEmpty() checks null:
 697	     m_hasNonEmptyList = !attr->isNull() && !attr->isEmpty();

This sseems like the long way around:
      bool hadNonEmptyList = m_hasNonEmptyList;
 697	     m_hasNonEmptyList = !attr->isNull() && !attr->isEmpty();
 698	     if (hadNonEmptyList != m_hasNonEmptyList && attached()) {
 699		 // Re-create a renderer because m_hasNonEmptyList affects UI.
 700		 detach();
 701		 attach();
 702	     }

Do you really need to attach/detach every time?  Can't you do a layout or a
style recalc?  What does the list do to the renderer?

list() clearly should return a HTMLDataListElement*, or?  Otherwise you
certainly shouldn't be blindly casting to one in callers of list()

From bugzilla-daemon at webkit.org  Wed Jul 29 09:42:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:42:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27767] Kill the annoying
 (and misunderstandable) LEAK messages in debug mode : [Attachment 33700]
 propsed patch v3
In-Reply-To: <bug-27767-0@https.bugs.webkit.org/>
References: <bug-27767-0@https.bugs.webkit.org/>
Message-ID: <20090729164226.7DB4F3423AF9@gamma.macosforge.org>

Zoltan Herczeg <zherczeg at inf.u-szeged.hu> has canceled	review:
Bug 27767: Kill the annoying (and misunderstandable) LEAK messages in debug
mode
https://bugs.webkit.org/show_bug.cgi?id=27767

Attachment 33700: propsed patch v3
https://bugs.webkit.org/attachment.cgi?id=33700&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 09:56:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:56:17 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33436] Allow to enable/disable
 particular plugin packages.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729165617.F09853423C7E@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has canceled  review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33436: Allow to enable/disable particular plugin packages.
https://bugs.webkit.org/attachment.cgi?id=33436&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 09:57:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 09:57:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33440] Expose the
 PluginDatabase::pluginForMIMEType() function as public API.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729165733.18EB23423CAC@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has canceled  review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33440: Expose the PluginDatabase::pluginForMIMEType() function as
public API.
https://bugs.webkit.org/attachment.cgi?id=33440&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:03:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:03:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33441] Expose the default plugin
 directories and the current directory set of the plugin database as public
 API.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729170319.B59D43423D64@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has canceled  review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33441: Expose the default plugin directories and the current
directory set of the plugin database as public API.
https://bugs.webkit.org/attachment.cgi?id=33441&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:06:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:06:00 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33669] remove an unnecessary line
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090729170600.7FD293423DCB@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33669: remove an unnecessary line
https://bugs.webkit.org/attachment.cgi?id=33669&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:06:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:06:00 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33719] remove unnecessary changes
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090729170600.9DE433423DCD@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33719: remove unnecessary changes
https://bugs.webkit.org/attachment.cgi?id=33719&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:11:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:11:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26867] Animation play-state
 property does not work correctly : [Attachment 33720] Patch with test
In-Reply-To: <bug-26867-0@https.bugs.webkit.org/>
References: <bug-26867-0@https.bugs.webkit.org/>
Message-ID: <20090729171126.7EE383423E64@gamma.macosforge.org>

Chris Marrin <cmarrin at apple.com> has asked  for review:
Bug 26867: Animation play-state property does not work correctly
https://bugs.webkit.org/show_bug.cgi?id=26867

Attachment 33720: Patch with test
https://bugs.webkit.org/attachment.cgi?id=33720&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:14:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:14:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26867] Animation play-state
 property does not work correctly : [Attachment 33720] Patch with test
In-Reply-To: <bug-26867-0@https.bugs.webkit.org/>
References: <bug-26867-0@https.bugs.webkit.org/>
Message-ID: <20090729171437.158313423ECA@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Chris Marrin
<cmarrin at apple.com>'s request for review:
Bug 26867: Animation play-state property does not work correctly
https://bugs.webkit.org/show_bug.cgi?id=26867

Attachment 33720: Patch with test
https://bugs.webkit.org/attachment.cgi?id=33720&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:23:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:23:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33695] Fixed style issues;
 added main thread assert
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090729172302.80EEA3423FA7@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has canceled
Christian Plesner Hansen <christian.plesner.hansen at gmail.com>'s request for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33695: Fixed style issues; added main thread assert
https://bugs.webkit.org/attachment.cgi?id=33695&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:23:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:23:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33721] Fixed whitespace
 issue
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090729172302.9E1793423FA9@gamma.macosforge.org>

Christian Plesner Hansen <christian.plesner.hansen at gmail.com> has asked  for
review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33721: Fixed whitespace issue
https://bugs.webkit.org/attachment.cgi?id=33721&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:25:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:25:56 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27655] [v8] cache v8 strings
 when converting from webcore string to v8 string : [Attachment 33718] Next
 iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090729172556.DFA563423FDD@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33718: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33718&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: third_party/WebKit/WebCore/ChangeLog
> +2009-07-24  Anton Muhin  <antonm at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Cache v8 strings when converting from WebCore::String to v8 string.
> +	   https://bugs.webkit.org/show_bug.cgi?id=27655
> +
> +	   * bindings/v8/V8Binding.cpp:
> +	   (WebCore::v8String):
> +	   (WebCore::cachedStringCallback):
> +	   (WebCore::v8ExternalString):

This needs to be updated.  Also per function comments are encourage for
non-trivial changes to explain what changes you did to the functions.


> Index: third_party/WebKit/WebCore/bindings/v8/V8Binding.cpp

> +static bool stringImplCacheEnabled = false;
> +
> +void enableStringImplCache()
> +{
> +    stringImplCacheEnabled = true;
> +}

We discussed a compile time flag or runtime.  After seeing this, I much prefer
the compile time define because 
1. I think there are several places in the v8 bindings that will need this.
2. I don't think this is a runtime decision, and making it compile time will
have the benefits of making the separate code pieces easier to see, reduce
complexity of thinking about what happens if the flag is set after some class
are done, get rid of an unnecessary branch in your code.

Perhaps:
  V8_SINGLE_THREADED
and only chrome builds define this.


> +    v8::Persistent<v8::String> wrapper =
v8::Persistent<v8::String>::New(newString);
> +    if (wrapper.IsEmpty())
> +	   return newString;

Does "wrapper.Dispose();" need to be called before the return? (I'm not totally
familiar with persistent handles in v8.)


> Index: third_party/WebKit/WebCore/bindings/v8/V8Binding.h
> +    // Enables caching v8 wrappers created for WebCore::StringImpl. 
Currently this cache requires
> +    // all the calls (both to convert WebCore::String to v8::String and to
GC the handle)
> +    // to be peformed on the main thread.

typo: peformed
(just in case this comment is kept)

From bugzilla-daemon at webkit.org  Wed Jul 29 10:30:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:30:32 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27791] 307 redirects of
 POSTs should use POST, not GET : [Attachment 33722] Now as a patch...
In-Reply-To: <bug-27791-0@https.bugs.webkit.org/>
References: <bug-27791-0@https.bugs.webkit.org/>
Message-ID: <20090729173032.DD85F3424071@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27791: 307 redirects of POSTs should use POST, not GET
https://bugs.webkit.org/show_bug.cgi?id=27791

Attachment 33722: Now as a patch...
https://bugs.webkit.org/attachment.cgi?id=33722&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:30:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:30:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27791] 307 redirects of
 POSTs should use POST, not GET : [Attachment 33687] Mac and Windows fix,
 plus layout test
In-Reply-To: <bug-27791-0@https.bugs.webkit.org/>
References: <bug-27791-0@https.bugs.webkit.org/>
Message-ID: <20090729173032.AC7A0342406D@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has canceled Brady Eidson
<beidson at apple.com>'s request for review:
Bug 27791: 307 redirects of POSTs should use POST, not GET
https://bugs.webkit.org/show_bug.cgi?id=27791

Attachment 33687: Mac and Windows fix, plus layout test
https://bugs.webkit.org/attachment.cgi?id=33687&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:33:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:33:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27791] 307 redirects of POSTs
 should use POST, not GET : [Attachment 33722] Now as a patch...
In-Reply-To: <bug-27791-0@https.bugs.webkit.org/>
References: <bug-27791-0@https.bugs.webkit.org/>
Message-ID: <20090729173314.7264434240D7@gamma.macosforge.org>

Sam Weinig <sam at webkit.org> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 27791: 307 redirects of POSTs should use POST, not GET
https://bugs.webkit.org/show_bug.cgi?id=27791

Attachment 33722: Now as a patch...
https://bugs.webkit.org/attachment.cgi?id=33722&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 10:47:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 10:47:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27807] AX: move re-usable
 code into more common areas for other platforms : [Attachment 33723] patch
In-Reply-To: <bug-27807-0@https.bugs.webkit.org/>
References: <bug-27807-0@https.bugs.webkit.org/>
Message-ID: <20090729174717.79D39342422D@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 27807: AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807

Attachment 33723: patch
https://bugs.webkit.org/attachment.cgi?id=33723&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 11:08:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 11:08:12 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27807] AX: move re-usable
 code into more common areas for other platforms : [Attachment 33723] patch
In-Reply-To: <bug-27807-0@https.bugs.webkit.org/>
References: <bug-27807-0@https.bugs.webkit.org/>
Message-ID: <20090729180812.B67C53424475@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has canceled chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27807: AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807

Attachment 33723: patch
https://bugs.webkit.org/attachment.cgi?id=33723&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 11:08:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 11:08:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27807] AX: move re-usable
 code into more common areas for other platforms : [Attachment 33726] patch
 (minor update to make sure TextMarkerData is bzerod right away in the
 method)
In-Reply-To: <bug-27807-0@https.bugs.webkit.org/>
References: <bug-27807-0@https.bugs.webkit.org/>
Message-ID: <20090729180812.EDB953424479@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 27807: AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807

Attachment 33726: patch (minor update to make sure TextMarkerData is bzerod
right away in the method)
https://bugs.webkit.org/attachment.cgi?id=33726&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 11:39:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 11:39:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27792] [GTK]
 new-window-policy-decision-requested provides no information about the
 target frame : [Attachment 33715] Updated patch
In-Reply-To: <bug-27792-0@https.bugs.webkit.org/>
References: <bug-27792-0@https.bugs.webkit.org/>
Message-ID: <20090729183948.3425034247AA@gamma.macosforge.org>

Martin Robinson <martin.james.robinson at gmail.com> has asked  for review:
Bug 27792: [GTK] new-window-policy-decision-requested provides no information
about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Attachment 33715: Updated patch
https://bugs.webkit.org/attachment.cgi?id=33715&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 11:51:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 11:51:41 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27796] CSS
 -webkit-transition and (overflow: (and/or) display:) properties crash the
 browser : [Attachment 33727] Patch, testcase, changelog
In-Reply-To: <bug-27796-0@https.bugs.webkit.org/>
References: <bug-27796-0@https.bugs.webkit.org/>
Message-ID: <20090729185141.DC77734248C9@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27796: CSS -webkit-transition and (overflow: (and/or) display:) properties
crash the browser
https://bugs.webkit.org/show_bug.cgi?id=27796

Attachment 33727: Patch, testcase, changelog
https://bugs.webkit.org/attachment.cgi?id=33727&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 12:02:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:02:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 33728] Patch v3
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090729190218.B2FD434249E1@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 33728: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33728&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* Scripts/bugzilla-tool:
(LandPatchesFromBugs.__init__): Added --no-close switch.
(LandPatchesFromBugs.land_patches): Don't close the bug if the
--no-close switch was used, but call
Bugzilla.clear_attachment_review_flag() on the attachment so it
no longer shows up in the commit queue.  Also changed the
behavior when landing multiple patches from obsoleting patches
to clearing each patch's review flag.
* Scripts/modules/bugzilla.py:
(Bugzilla.clear_attachment_review_flag): Added.
---
 3 files changed, 38 insertions(+), 6 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 29 12:06:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:06:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23522] Use checked casts
 for render tree : [Attachment 33729] Next step: Includes toRenderWidget
In-Reply-To: <bug-23522-0@https.bugs.webkit.org/>
References: <bug-23522-0@https.bugs.webkit.org/>
Message-ID: <20090729190656.4F9FE3424A92@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 23522: Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Attachment 33729: Next step: Includes toRenderWidget
https://bugs.webkit.org/attachment.cgi?id=33729&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 12:16:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:16:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33730] Allow to explicitly choose a
 preferred plugin for a mimetype - r2.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090729191621.55ADA3424B57@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33730: Allow to explicitly choose a preferred plugin for a mimetype
- r2.
https://bugs.webkit.org/attachment.cgi?id=33730&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
(In reply to comment #19)
> (From update of attachment 33438 [details])
> The patch looks good, but I think there's one bug left: The
m_preferredPlugins
> hash keeps PluginPackage instances alife, through the use of RefPtr. When
> calling clear() as well as refresh() we may have to free the references to
> these plugins, to allow the pluginpackage objects to be freed.

Fixed, thanks. :)

From bugzilla-daemon at webkit.org  Wed Jul 29 12:18:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:18:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27796] CSS -webkit-transition
 and (overflow: (and/or) display:) properties crash the browser :
 [Attachment 33727] Patch, testcase, changelog
In-Reply-To: <bug-27796-0@https.bugs.webkit.org/>
References: <bug-27796-0@https.bugs.webkit.org/>
Message-ID: <20090729191856.896163424B7F@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 27796: CSS -webkit-transition and (overflow: (and/or) display:) properties
crash the browser
https://bugs.webkit.org/show_bug.cgi?id=27796

Attachment 33727: Patch, testcase, changelog
https://bugs.webkit.org/attachment.cgi?id=33727&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 12:30:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:30:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33719] remove unnecessary changes
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090729193052.4689C3424CA6@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33719: remove unnecessary changes
https://bugs.webkit.org/attachment.cgi?id=33719&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 12:30:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:30:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33731] add some comments for removed ASSERT
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090729193052.616233424CA8@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33731: add some comments for removed ASSERT
https://bugs.webkit.org/attachment.cgi?id=33731&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 12:37:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:37:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33731] add some comments for removed ASSERT
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090729193710.6B63D3424D56@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33731: add some comments for removed ASSERT
https://bugs.webkit.org/attachment.cgi?id=33731&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Still more ifdef than I'd like to see but I think it's ok for now. 
Unfortunately WinCE doesn't make this easy.

From bugzilla-daemon at webkit.org  Wed Jul 29 12:44:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:44:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27785] [V8] Add a way to
 register V8 extensions for Isolated Worlds only : [Attachment 33733] rework
 of above using an extensionGroup tag
In-Reply-To: <bug-27785-0@https.bugs.webkit.org/>
References: <bug-27785-0@https.bugs.webkit.org/>
Message-ID: <20090729194434.41FBB3424E37@gamma.macosforge.org>

Matt Perry <mpcomplete at chromium.org> has asked Adam Barth <abarth at webkit.org>
for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33733: rework of above using an extensionGroup tag
https://bugs.webkit.org/attachment.cgi?id=33733&action=review

------- Additional Comments from Matt Perry <mpcomplete at chromium.org>
Here's the rework using a tag for contexts. You can see how it's used in the
chromium code review I linked earlier.

From bugzilla-daemon at webkit.org  Wed Jul 29 12:53:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 12:53:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27785] [V8] Add a way to
 register V8 extensions for Isolated Worlds only : [Attachment 33733] rework
 of above using an extensionGroup tag
In-Reply-To: <bug-27785-0@https.bugs.webkit.org/>
References: <bug-27785-0@https.bugs.webkit.org/>
Message-ID: <20090729195325.E11A23424F66@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Matt Perry
<mpcomplete at chromium.org>'s request for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33733: rework of above using an extensionGroup tag
https://bugs.webkit.org/attachment.cgi?id=33733&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
This looks good.  The below are only minor style issues:

1) Sometimes we call the value extensionGroup and sometimes extensionFlags.  We
should probably make this consistent.

2) We should put the parameter name in the headers.  Having a bare "int" is
very ambiguous.

Thanks!

From bugzilla-daemon at webkit.org  Wed Jul 29 13:02:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:02:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27785] [V8] Add a way to
 register V8 extensions for Isolated Worlds only : [Attachment 33734] fixed
 up the naming
In-Reply-To: <bug-27785-0@https.bugs.webkit.org/>
References: <bug-27785-0@https.bugs.webkit.org/>
Message-ID: <20090729200230.A3FB634250AD@gamma.macosforge.org>

Matt Perry <mpcomplete at chromium.org> has asked Adam Barth <abarth at webkit.org>
for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33734: fixed up the naming
https://bugs.webkit.org/attachment.cgi?id=33734&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:12:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:12:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27785] [V8] Add a way to
 register V8 extensions for Isolated Worlds only : [Attachment 33734] fixed
 up the naming
In-Reply-To: <bug-27785-0@https.bugs.webkit.org/>
References: <bug-27785-0@https.bugs.webkit.org/>
Message-ID: <20090729201222.7278834251E7@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Matt Perry
<mpcomplete at chromium.org>'s request for review:
Bug 27785: [V8] Add a way to register V8 extensions for Isolated Worlds only
https://bugs.webkit.org/show_bug.cgi?id=27785

Attachment 33734: fixed up the naming
https://bugs.webkit.org/attachment.cgi?id=33734&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Great.	Thanks.

From bugzilla-daemon at webkit.org  Wed Jul 29 13:23:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:23:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27815] bugzilla-tool: add
 -m/--description to post-commits command : [Attachment 33736] Patch v1
In-Reply-To: <bug-27815-0@https.bugs.webkit.org/>
References: <bug-27815-0@https.bugs.webkit.org/>
Message-ID: <20090729202328.5E1CA3425371@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27815: bugzilla-tool: add -m/--description to post-commits command
https://bugs.webkit.org/show_bug.cgi?id=27815

Attachment 33736: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33736&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* Scripts/bugzilla-tool:
(PostDiffAsPatchToBug.execute): Changed default patch name from
"patch" to "Patch v1".
(PostCommitsAsPatchesToBug.__init__): Added -m/--description
switch.
(PostCommitsAsPatchesToBug.execute): Use description provided by
-m/--description switch first, else fall back to the commit
message.
---
 2 files changed, 18 insertions(+), 2 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 29 13:23:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:23:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33737] Implement ImageDiff
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090729202340.7F1543425392@gamma.macosforge.org>

Ariya Hidayat <ariya.hidayat at trolltech.com> has granted  review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33737: Implement ImageDiff
https://bugs.webkit.org/attachment.cgi?id=33737&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:24:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:24:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33737] Implement ImageDiff
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090729202406.8683C342539C@gamma.macosforge.org>

Ariya Hidayat <ariya.hidayat at trolltech.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33737: Implement ImageDiff
https://bugs.webkit.org/attachment.cgi?id=33737&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:27:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:27:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33738] Add pixel tests to
 DumpRenderTree
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090729202726.EEB3834253E7@gamma.macosforge.org>

Ariya Hidayat <ariya.hidayat at trolltech.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33738: Add pixel tests to DumpRenderTree
https://bugs.webkit.org/attachment.cgi?id=33738&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:27:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:27:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27815] bugzilla-tool: add
 -m/--description to post-commits command : [Attachment 33736] Patch v1
In-Reply-To: <bug-27815-0@https.bugs.webkit.org/>
References: <bug-27815-0@https.bugs.webkit.org/>
Message-ID: <20090729202751.9FF4034253F3@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27815: bugzilla-tool: add -m/--description to post-commits command
https://bugs.webkit.org/show_bug.cgi?id=27815

Attachment 33736: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33736&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Seems a little strange when dealing with more than one patch.

From bugzilla-daemon at webkit.org  Wed Jul 29 13:28:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:28:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27807] AX: move re-usable
 code into more common areas for other platforms : [Attachment 33726] patch
 (minor update to make sure TextMarkerData is bzerod right away in the
 method)
In-Reply-To: <bug-27807-0@https.bugs.webkit.org/>
References: <bug-27807-0@https.bugs.webkit.org/>
Message-ID: <20090729202814.5036D3425424@gamma.macosforge.org>

Justin Garcia <justin.garcia at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27807: AX: move re-usable code into more common areas for other platforms
https://bugs.webkit.org/show_bug.cgi?id=27807

Attachment 33726: patch (minor update to make sure TextMarkerData is bzerod
right away in the method)
https://bugs.webkit.org/attachment.cgi?id=33726&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 29 13:28:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:28:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27811] Inset box shadows
 are incorrectly accounted for in visual overflow computations : [Attachment
 33739] Refactor some of box-shadow extent computations,
 make all such computations exclude inset shadows
In-Reply-To: <bug-27811-0@https.bugs.webkit.org/>
References: <bug-27811-0@https.bugs.webkit.org/>
Message-ID: <20090729202814.41D523425422@gamma.macosforge.org>

mitz at webkit.org has asked  for review:
Bug 27811: Inset box shadows are incorrectly accounted for in visual overflow
computations
https://bugs.webkit.org/show_bug.cgi?id=27811

Attachment 33739: Refactor some of box-shadow extent computations, make all
such computations exclude inset shadows
https://bugs.webkit.org/attachment.cgi?id=33739&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:30:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:30:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27811] Inset box shadows are
 incorrectly accounted for in visual overflow computations : [Attachment
 33739] Refactor some of box-shadow extent computations,
 make all such computations exclude inset shadows
In-Reply-To: <bug-27811-0@https.bugs.webkit.org/>
References: <bug-27811-0@https.bugs.webkit.org/>
Message-ID: <20090729203059.2A789342548C@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted mitz at webkit.org's
request for review:
Bug 27811: Inset box shadows are incorrectly accounted for in visual overflow
computations
https://bugs.webkit.org/show_bug.cgi?id=27811

Attachment 33739: Refactor some of box-shadow extent computations, make all
such computations exclude inset shadows
https://bugs.webkit.org/attachment.cgi?id=33739&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:38:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:38:31 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 33728] Patch v3
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090729203831.813E2342558E@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 33728: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33728&action=review

------- Additional Comments from David Levin <levin at chromium.org>



> diff --git a/WebKitTools/Scripts/bugzilla-tool
b/WebKitTools/Scripts/bugzilla-tool


> @@ -314,20 +315,21 @@ class LandPatchesFromBugs(Command):
>      @classmethod
>      def land_patches(cls, bug_id, patches, options, tool):
>	   try:
> +	       # Clear the review flag on each bug if we're not closing the bug
or if there is more than one patch.

Consider:
 # Clear the review flag on patches when needed for adding the commit revision
number and/or moving out of the commit queue.

> +	       should_clear_review_flag = not options.close_bug or len(patches)
> 1
...
> +		   if should_clear_review_flag:
> +		       tool.bugs.clear_attachment_review_flag(patch['id'])

Why isn't comment_text passed in?

I really like the practice of putting the revision # corresponding to the patch
commitment in the bug.



> diff --git a/WebKitTools/Scripts/modules/bugzilla.py
b/WebKitTools/Scripts/modules/bugzilla.py
> +    def clear_attachment_review_flag(self, attachment_id):
...
> +	   self.browser['comment'] = "Clearing review+ flag."

From bugzilla-daemon at webkit.org  Wed Jul 29 13:55:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:55:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27788] Don't export
 WebPluginController.h as a private header : [Attachment 33684] Patch v1
In-Reply-To: <bug-27788-0@https.bugs.webkit.org/>
References: <bug-27788-0@https.bugs.webkit.org/>
Message-ID: <20090729205553.108E234257AA@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled David Kilzer
(ddkilzer) <ddkilzer at webkit.org>'s request for review:
Bug 27788: Don't export WebPluginController.h as a private header
https://bugs.webkit.org/show_bug.cgi?id=27788

Attachment 33684: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33684&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 13:55:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 13:55:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27788] Don't export
 WebPluginController.h as a private header : [Attachment 33740] Patch v2
In-Reply-To: <bug-27788-0@https.bugs.webkit.org/>
References: <bug-27788-0@https.bugs.webkit.org/>
Message-ID: <20090729205555.6208734257B3@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27788: Don't export WebPluginController.h as a private header
https://bugs.webkit.org/show_bug.cgi?id=27788

Attachment 33740: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33740&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 14:14:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:14:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27816] WINCE PORT: some
 files modified for WINCE build : [Attachment 33741] the patch
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090729211448.1537634259B4@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33741: the patch
https://bugs.webkit.org/attachment.cgi?id=33741&action=review

------- Additional Comments from Yong Li <yong.li at torchmobile.com>
About BitmapInfo: We started using class BitmapInfo in WINCE port at least 1
year ago. Later, we found that webkit upstream added BitmapInfo.h for win32
port. However, the usage is different. Probably we should restructure it to
make WINCE and WIN32 share a same BitmapInfo class? I'm not sure if it's good
for win32 port.

From bugzilla-daemon at webkit.org  Wed Jul 29 14:17:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:17:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27810] Illegal values for
 <ol start> cause list numbering start at 0 (should start at 1) :
 [Attachment 33742] patch
In-Reply-To: <bug-27810-0@https.bugs.webkit.org/>
References: <bug-27810-0@https.bugs.webkit.org/>
Message-ID: <20090729211748.A52CD3425C2F@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 27810: Illegal values for <ol start> cause list numbering start at 0
(should start at 1)
https://bugs.webkit.org/show_bug.cgi?id=27810

Attachment 33742: patch
https://bugs.webkit.org/attachment.cgi?id=33742&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 14:25:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:25:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27816] WINCE PORT: some
 files modified for WINCE build : [Attachment 33743] updated patch
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090729212517.43FDE3425D12@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33743: updated patch
https://bugs.webkit.org/attachment.cgi?id=33743&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 14:25:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:25:17 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27816] WINCE PORT: some
 files modified for WINCE build : [Attachment 33741] the patch
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090729212517.2915B3425D10@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33741: the patch
https://bugs.webkit.org/attachment.cgi?id=33741&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 14:28:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:28:58 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27816] WINCE PORT: some files
 modified for WINCE build : [Attachment 33741] the patch
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090729212858.CF2683425D4E@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied  review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33741: the patch
https://bugs.webkit.org/attachment.cgi?id=33741&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Let's remove the bitmapinfo stuff, and also Torch Mobile is spelled wrong in at
least one place.


>  class BitmapInfo: public BITMAPINFO

   Space missing


The changes in ~PopupMenu should probably be submitted separately.  They look
generic.

From bugzilla-daemon at webkit.org  Wed Jul 29 14:29:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:29:39 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27816] WINCE PORT: some files
 modified for WINCE build : [Attachment 33743] updated patch
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090729212939.92B4D3425D62@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33743: updated patch
https://bugs.webkit.org/attachment.cgi?id=33743&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
See previous comments

From bugzilla-daemon at webkit.org  Wed Jul 29 14:44:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:44:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 33728] Patch v3
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090729214443.E80DB3425EBC@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 33728: Patch v3
https://bugs.webkit.org/attachment.cgi?id=33728&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 14:44:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:44:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 33744] Patch v4
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090729214447.847D33425ED9@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 33744: Patch v4
https://bugs.webkit.org/attachment.cgi?id=33744&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 14:50:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 14:50:45 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27082] bugzilla-tool: Add
 --no-close switch to land-patches : [Attachment 33744] Patch v4
In-Reply-To: <bug-27082-0@https.bugs.webkit.org/>
References: <bug-27082-0@https.bugs.webkit.org/>
Message-ID: <20090729215045.4E6913425F69@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27082: bugzilla-tool: Add --no-close switch to land-patches
https://bugs.webkit.org/show_bug.cgi?id=27082

Attachment 33744: Patch v4
https://bugs.webkit.org/attachment.cgi?id=33744&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 15:03:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 15:03:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27817] HDC leaks in
 PopupMenuWin.cpp : [Attachment 33745] the patch
In-Reply-To: <bug-27817-0@https.bugs.webkit.org/>
References: <bug-27817-0@https.bugs.webkit.org/>
Message-ID: <20090729220351.51952342610D@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27817: HDC leaks in PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=27817

Attachment 33745: the patch
https://bugs.webkit.org/attachment.cgi?id=33745&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 15:34:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 15:34:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27788] Don't export
 WebPluginController.h as a private header : [Attachment 33740] Patch v2
In-Reply-To: <bug-27788-0@https.bugs.webkit.org/>
References: <bug-27788-0@https.bugs.webkit.org/>
Message-ID: <20090729223407.330B43426697@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27788: Don't export WebPluginController.h as a private header
https://bugs.webkit.org/show_bug.cgi?id=27788

Attachment 33740: Patch v2
https://bugs.webkit.org/attachment.cgi?id=33740&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 15:55:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 15:55:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27817] HDC leaks in
 PopupMenuWin.cpp : [Attachment 33745] the patch
In-Reply-To: <bug-27817-0@https.bugs.webkit.org/>
References: <bug-27817-0@https.bugs.webkit.org/>
Message-ID: <20090729225507.94D4134268E2@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27817: HDC leaks in PopupMenuWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=27817

Attachment 33745: the patch
https://bugs.webkit.org/attachment.cgi?id=33745&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
r=me

From bugzilla-daemon at webkit.org  Wed Jul 29 15:55:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 15:55:26 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27810] Illegal values for <ol
 start> cause list numbering start at 0 (should start at 1) : [Attachment
 33742] patch
In-Reply-To: <bug-27810-0@https.bugs.webkit.org/>
References: <bug-27810-0@https.bugs.webkit.org/>
Message-ID: <20090729225526.740F13426904@gamma.macosforge.org>

mitz at webkit.org has granted Darin Adler <darin at apple.com>'s request for review:
Bug 27810: Illegal values for <ol start> cause list numbering start at 0
(should start at 1)
https://bugs.webkit.org/show_bug.cgi?id=27810

Attachment 33742: patch
https://bugs.webkit.org/attachment.cgi?id=33742&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:06:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:06:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27809]
 REGRESSION(r46370-46426):
 /editing/style/remove-underline-from-stylesheet.html fails : [Attachment
 33747] fixes the bug
In-Reply-To: <bug-27809-0@https.bugs.webkit.org/>
References: <bug-27809-0@https.bugs.webkit.org/>
Message-ID: <20090729230617.0A94734269ED@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27809: REGRESSION(r46370-46426):
/editing/style/remove-underline-from-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=27809

Attachment 33747: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33747&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:14:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:14:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27819] Need to update
 layout test for different timings of multi process message ports :
 [Attachment 33748] Proposed patch
In-Reply-To: <bug-27819-0@https.bugs.webkit.org/>
References: <bug-27819-0@https.bugs.webkit.org/>
Message-ID: <20090729231443.A9B823426AD1@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27819: Need to update layout test for different timings of multi process
message ports
https://bugs.webkit.org/show_bug.cgi?id=27819

Attachment 33748: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33748&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:18:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:18:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27819] Need to update
 layout test for different timings of multi process message ports :
 [Attachment 33749] fixed bad merge
In-Reply-To: <bug-27819-0@https.bugs.webkit.org/>
References: <bug-27819-0@https.bugs.webkit.org/>
Message-ID: <20090729231829.B80213426DBE@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27819: Need to update layout test for different timings of multi process
message ports
https://bugs.webkit.org/show_bug.cgi?id=27819

Attachment 33749: fixed bad merge
https://bugs.webkit.org/attachment.cgi?id=33749&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:18:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:18:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27819] Need to update layout
 test for different timings of multi process message ports : [Attachment
 33748] Proposed patch
In-Reply-To: <bug-27819-0@https.bugs.webkit.org/>
References: <bug-27819-0@https.bugs.webkit.org/>
Message-ID: <20090729231829.9812C3426DBC@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has canceled John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27819: Need to update layout test for different timings of multi process
message ports
https://bugs.webkit.org/show_bug.cgi?id=27819

Attachment 33748: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33748&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:22:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:22:00 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27435] adding XMLHttpRequest
 send idl language gobject : [Attachment 33325] corrections to #ifdefs as
 per r2 comment
In-Reply-To: <bug-27435-0@https.bugs.webkit.org/>
References: <bug-27435-0@https.bugs.webkit.org/>
Message-ID: <20090729232200.82AFD3426E2B@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27435: adding XMLHttpRequest send idl language gobject
https://bugs.webkit.org/show_bug.cgi?id=27435

Attachment 33325: corrections to #ifdefs as per r2 comment
https://bugs.webkit.org/attachment.cgi?id=33325&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
Marking as r- based on the comments from several reviewers and contributors.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:30:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:30:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27820] Unicode in <script>
 tag attributes causes DCHECK in Chrome : [Attachment 33750] wip
In-Reply-To: <bug-27820-0@https.bugs.webkit.org/>
References: <bug-27820-0@https.bugs.webkit.org/>
Message-ID: <20090729233012.DF7673426E94@gamma.macosforge.org>

Evan Martin <evan at chromium.org> has asked  for review:
Bug 27820: Unicode in <script> tag attributes causes DCHECK in Chrome
https://bugs.webkit.org/show_bug.cgi?id=27820

Attachment 33750: wip
https://bugs.webkit.org/attachment.cgi?id=33750&action=review

------- Additional Comments from Evan Martin <evan at chromium.org>

---
 2 files changed, 10 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Wed Jul 29 16:31:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:31:45 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27434] adding necessary
 functions and properties to Document IDL gobject bindings : [Attachment
 33344] makes Document.location and all Location properties read-only,
 pending writing of custom code (at some indeterminate future point)
In-Reply-To: <bug-27434-0@https.bugs.webkit.org/>
References: <bug-27434-0@https.bugs.webkit.org/>
Message-ID: <20090729233145.885903426ECB@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27434: adding necessary functions and properties to Document IDL gobject
bindings
https://bugs.webkit.org/show_bug.cgi?id=27434

Attachment 33344: makes Document.location and all Location properties
read-only, pending writing of custom code (at some indeterminate future point)
https://bugs.webkit.org/attachment.cgi?id=33344&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:33:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:33:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27819] Need to update layout
 test for different timings of multi process message ports : [Attachment
 33749] fixed bad merge
In-Reply-To: <bug-27819-0@https.bugs.webkit.org/>
References: <bug-27819-0@https.bugs.webkit.org/>
Message-ID: <20090729233318.E75C33426EEB@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27819: Need to update layout test for different timings of multi process
message ports
https://bugs.webkit.org/show_bug.cgi?id=27819

Attachment 33749: fixed bad merge
https://bugs.webkit.org/attachment.cgi?id=33749&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Why the set-timeout for the "done"?

Looks fine otherwise.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:33:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:33:35 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27809]
 REGRESSION(r46370-46426):
 /editing/style/remove-underline-from-stylesheet.html fails : [Attachment
 33747] fixes the bug
In-Reply-To: <bug-27809-0@https.bugs.webkit.org/>
References: <bug-27809-0@https.bugs.webkit.org/>
Message-ID: <20090729233336.002863426F09@gamma.macosforge.org>

Justin Garcia <justin.garcia at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 27809: REGRESSION(r46370-46426):
/editing/style/remove-underline-from-stylesheet.html fails
https://bugs.webkit.org/show_bug.cgi?id=27809

Attachment 33747: fixes the bug
https://bugs.webkit.org/attachment.cgi?id=33747&action=review

------- Additional Comments from Justin Garcia <justin.garcia at apple.com>
"set by u, s, & stirke"

Small typo.  And I'd use "and" instead of &, but it's up to you.

r=me

From bugzilla-daemon at webkit.org  Wed Jul 29 16:34:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:34:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27770] Workers need to
 throw an exception when presented with invalid URLs : [Attachment 33751]
 Proposed Patch
In-Reply-To: <bug-27770-0@https.bugs.webkit.org/>
References: <bug-27770-0@https.bugs.webkit.org/>
Message-ID: <20090729233409.ED51D3426F24@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27770: Workers need to throw an exception when presented with invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=27770

Attachment 33751: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33751&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:38:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:38:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27433] enable toString
 function under gobject bindings : [Attachment 33380] for convenience of the
 reviewers,
 this patch includes the research material which is not being read and
 answered as part of the prior review comments,
 which has been requested seventeen times so far
In-Reply-To: <bug-27433-0@https.bugs.webkit.org/>
References: <bug-27433-0@https.bugs.webkit.org/>
Message-ID: <20090729233814.57B903426FAA@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27433: enable toString function under gobject bindings
https://bugs.webkit.org/show_bug.cgi?id=27433

Attachment 33380: for convenience of the reviewers, this patch includes the
research material which is not being read and answered as part of the prior
review comments, which has been requested seventeen times so far
https://bugs.webkit.org/attachment.cgi?id=33380&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
As we've mentioned repeatedly: we do not feel that it is appropriate to expose
toString methods outside of JavaScript.  The toString function is a JavaScript
concept that does not map directly to other languages.	They are not part of
the DOM itself.  The information they expose is available via existing means.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:40:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:40:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27819] Need to update
 layout test for different timings of multi process message ports :
 [Attachment 33752] removed setTimeout
In-Reply-To: <bug-27819-0@https.bugs.webkit.org/>
References: <bug-27819-0@https.bugs.webkit.org/>
Message-ID: <20090729234042.9AF8D3427012@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27819: Need to update layout test for different timings of multi process
message ports
https://bugs.webkit.org/show_bug.cgi?id=27819

Attachment 33752: removed setTimeout
https://bugs.webkit.org/attachment.cgi?id=33752&action=review

------- Additional Comments from John Abd-El-Malek <jam at chromium.org>
Thanks for the quick review.  You're right, no need.  Updated patch.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:41:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:41:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27819] Need to update layout
 test for different timings of multi process message ports : [Attachment
 33752] removed setTimeout
In-Reply-To: <bug-27819-0@https.bugs.webkit.org/>
References: <bug-27819-0@https.bugs.webkit.org/>
Message-ID: <20090729234122.C15B2342703C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27819: Need to update layout test for different timings of multi process
message ports
https://bugs.webkit.org/show_bug.cgi?id=27819

Attachment 33752: removed setTimeout
https://bugs.webkit.org/attachment.cgi?id=33752&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:42:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:42:26 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27748] crash w/ stack
 overflow when same CSS file loaded repeatedly : [Attachment 33688] revied
 patch w/ sam's comments - data file reduced from 50k lines to 30k
In-Reply-To: <bug-27748-0@https.bugs.webkit.org/>
References: <bug-27748-0@https.bugs.webkit.org/>
Message-ID: <20090729234226.63C083427081@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has canceled Dirk Pranke
<dpranke at chromium.org>'s request for review:
Bug 27748: crash w/ stack overflow when same CSS file loaded repeatedly
https://bugs.webkit.org/show_bug.cgi?id=27748

Attachment 33688: revied patch w/ sam's comments - data file reduced from 50k
lines to 30k
https://bugs.webkit.org/attachment.cgi?id=33688&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:42:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:42:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27748] crash w/ stack
 overflow when same CSS file loaded repeatedly : [Attachment 33753] third
 time's the charm - generate the list of rules dynamically
In-Reply-To: <bug-27748-0@https.bugs.webkit.org/>
References: <bug-27748-0@https.bugs.webkit.org/>
Message-ID: <20090729234226.A21453427085@gamma.macosforge.org>

Dirk Pranke <dpranke at chromium.org> has asked  for review:
Bug 27748: crash w/ stack overflow when same CSS file loaded repeatedly
https://bugs.webkit.org/show_bug.cgi?id=27748

Attachment 33753: third time's the charm - generate the list of rules
dynamically
https://bugs.webkit.org/attachment.cgi?id=33753&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 16:47:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:47:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27770] Workers need to
 throw an exception when presented with invalid URLs : [Attachment 33754]
 Proposed Patch
In-Reply-To: <bug-27770-0@https.bugs.webkit.org/>
References: <bug-27770-0@https.bugs.webkit.org/>
Message-ID: <20090729234702.12FD734270EC@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has asked  for review:
Bug 27770: Workers need to throw an exception when presented with invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=27770

Attachment 33754: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33754&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Fixed the problem pointed out by Darin.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:47:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:47:01 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27770] Workers need to throw
 an exception when presented with invalid URLs : [Attachment 33751] Proposed
 Patch
In-Reply-To: <bug-27770-0@https.bugs.webkit.org/>
References: <bug-27770-0@https.bugs.webkit.org/>
Message-ID: <20090729234701.D438B34270E8@gamma.macosforge.org>

Jian Li <jianli at chromium.org> has canceled Jian Li <jianli at chromium.org>'s
request for review:
Bug 27770: Workers need to throw an exception when presented with invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=27770

Attachment 33751: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33751&action=review

------- Additional Comments from Jian Li <jianli at chromium.org>
Fixed the problem pointed out by Darin.

From bugzilla-daemon at webkit.org  Wed Jul 29 16:52:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 16:52:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33755] class ApplicationCacheHost
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090729235246.9B54A34271A9@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33755: class ApplicationCacheHost
https://bugs.webkit.org/attachment.cgi?id=33755&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
This patch started out in rietveld...
http://codereview.chromium.org/160115

There is some history there (several patch sets) that may be useful for
reviewers.

From bugzilla-daemon at webkit.org  Wed Jul 29 17:12:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 17:12:42 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27770] Workers need to throw
 an exception when presented with invalid URLs : [Attachment 33754] Proposed
 Patch
In-Reply-To: <bug-27770-0@https.bugs.webkit.org/>
References: <bug-27770-0@https.bugs.webkit.org/>
Message-ID: <20090730001242.7244A3427361@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Jian Li <jianli at chromium.org>'s
request for review:
Bug 27770: Workers need to throw an exception when presented with invalid URLs
https://bugs.webkit.org/show_bug.cgi?id=27770

Attachment 33754: Proposed Patch
https://bugs.webkit.org/attachment.cgi?id=33754&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +    KURL scriptURL = context->completeURL(url);
> +    if (url.isEmpty() || !scriptURL.isValid()) {
> +	   ec = SYNTAX_ERR;
> +	   return;
> +    }

Seems like the url.isEmpty() check could go before the call to completeURL.

> -	   void loadSynchronously(ScriptExecutionContext*, const String& url,
URLCompletionPolicy, CrossOriginLoadPolicy);
> -	   void loadAsynchronously(ScriptExecutionContext*, const String& url,
URLCompletionPolicy, CrossOriginLoadPolicy, WorkerScriptLoaderClient*);
> +	   void loadSynchronously(ScriptExecutionContext*, const KURL& url,
CrossOriginRedirectPolicy);
> +	   void loadAsynchronously(ScriptExecutionContext*, const KURL& url,
CrossOriginRedirectPolicy, WorkerScriptLoaderClient*);

Normally we would omit a name like "url" when the type makes it clear what it
is. So in addition to changing it from String to KURL, you could remove the
argument name here.

r=me

From bugzilla-daemon at webkit.org  Wed Jul 29 17:22:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 17:22:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27822] (REGRESSION: r46039)
 Should restore previous connections-per-host limit for non-http(s) hosts :
 [Attachment 33756] A fix
In-Reply-To: <bug-27822-0@https.bugs.webkit.org/>
References: <bug-27822-0@https.bugs.webkit.org/>
Message-ID: <20090730002206.E11953427442@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27822: (REGRESSION: r46039) Should restore previous connections-per-host
limit for non-http(s) hosts
https://bugs.webkit.org/show_bug.cgi?id=27822

Attachment 33756: A fix
https://bugs.webkit.org/attachment.cgi?id=33756&action=review

------- Additional Comments from Brady Eidson <beidson at apple.com>
No layout test, as we haven't yet figured out how reproducibly stress the
loader in a reliable and predictable manner to test this class of bug.

From bugzilla-daemon at webkit.org  Wed Jul 29 17:27:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 17:27:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27822] REGRESSION (r46039):
 Should restore previous connections-per-host limit for non-http(s) hosts :
 [Attachment 33756] A fix
In-Reply-To: <bug-27822-0@https.bugs.webkit.org/>
References: <bug-27822-0@https.bugs.webkit.org/>
Message-ID: <20090730002704.626E43427478@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Brady Eidson <beidson at apple.com>'s
request for review:
Bug 27822: REGRESSION (r46039): Should restore previous connections-per-host
limit for non-http(s) hosts
https://bugs.webkit.org/show_bug.cgi?id=27822

Attachment 33756: A fix
https://bugs.webkit.org/attachment.cgi?id=33756&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
r=me

Does the non-named host limit ever do any good at all? Maybe we should remove
the limit entirely for non-named hosts.

From bugzilla-daemon at webkit.org  Wed Jul 29 18:04:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 18:04:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 20565] Drag and drop issues
 after DOM modifications : [Attachment 33498] Patch to use
 m_documentUnderMouse instead of element->ownerDocument() when element is
 NULL.
In-Reply-To: <bug-20565-0@https.bugs.webkit.org/>
References: <bug-20565-0@https.bugs.webkit.org/>
Message-ID: <20090730010440.39D563427798@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has denied Aaron Golden <aegolden at gmail.com>'s
request for review:
Bug 20565: Drag and drop issues after DOM modifications
https://bugs.webkit.org/show_bug.cgi?id=20565

Attachment 33498: Patch to use m_documentUnderMouse instead of
element->ownerDocument() when element is NULL.
https://bugs.webkit.org/attachment.cgi?id=33498&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
This is basically a good patch but it needs a testcase, and i think there
should be an assertion:
> +    if (element) {
	   ASSERT(element->ownerDocument() == m_documentUnderMouse);
> +	   innerFrame = element->ownerDocument()->frame();
> +    } else
> +	   innerFrame = m_documentUnderMouse->frame();
> +    
>      ASSERT(innerFrame);
>  
>      if (dragData->containsColor()) {

From bugzilla-daemon at webkit.org  Wed Jul 29 18:08:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 18:08:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27824] v8 binding and gyp
 changes for the chromium port's multi process message port implementation :
 [Attachment 33757] Proposed patch
In-Reply-To: <bug-27824-0@https.bugs.webkit.org/>
References: <bug-27824-0@https.bugs.webkit.org/>
Message-ID: <20090730010810.5B8B4342780B@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27824: v8 binding and gyp changes for the chromium port's multi process
message port implementation
https://bugs.webkit.org/show_bug.cgi?id=27824

Attachment 33757: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33757&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 18:15:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 18:15:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27825] All DOM Storage
 layout tests need to call layoutTestController.notifyDone() so they can be
 run as UI tests in Chromium : [Attachment 33758] patch
In-Reply-To: <bug-27825-0@https.bugs.webkit.org/>
References: <bug-27825-0@https.bugs.webkit.org/>
Message-ID: <20090730011542.75C7434278FC@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27825: All DOM Storage layout tests need to call
layoutTestController.notifyDone() so they can be run as UI tests in Chromium
https://bugs.webkit.org/show_bug.cgi?id=27825

Attachment 33758: patch
https://bugs.webkit.org/attachment.cgi?id=33758&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 18:34:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 18:34:54 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33755] class ApplicationCacheHost
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730013454.AB74F3427A9E@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has canceled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33755: class ApplicationCacheHost
https://bugs.webkit.org/attachment.cgi?id=33755&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
* fixed a changelog typo
* put the Apple copyright on the new .cpp file
* massaged the #includes in the new .h file
* updated and merged the .xcodeproj file

From bugzilla-daemon at webkit.org  Wed Jul 29 18:34:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 18:34:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33759] class ApplicationCacheHost rev2
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730013454.C9BE13427AA0@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33759: class ApplicationCacheHost rev2
https://bugs.webkit.org/attachment.cgi?id=33759&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
* fixed a changelog typo
* put the Apple copyright on the new .cpp file
* massaged the #includes in the new .h file
* updated and merged the .xcodeproj file

From bugzilla-daemon at webkit.org  Wed Jul 29 19:19:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 19:19:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27825] All DOM Storage layout
 tests need to call layoutTestController.notifyDone() so they can be run as
 UI tests in Chromium : [Attachment 33758] patch
In-Reply-To: <bug-27825-0@https.bugs.webkit.org/>
References: <bug-27825-0@https.bugs.webkit.org/>
Message-ID: <20090730021914.BCD383427DE2@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has denied Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27825: All DOM Storage layout tests need to call
layoutTestController.notifyDone() so they can be run as UI tests in Chromium
https://bugs.webkit.org/show_bug.cgi?id=27825

Attachment 33758: patch
https://bugs.webkit.org/attachment.cgi?id=33758&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
This change doesn't make any sense.  layoutTestController.notifyDone() is not
necessary unless a test first calls waitUntilDone().  You should fix your test
harness to match the expectations of the tests, not the other way around.

From bugzilla-daemon at webkit.org  Wed Jul 29 20:49:45 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 20:49:45 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33731] add some comments for removed ASSERT
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090730034945.4EFAD34283A8@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied  review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33731: add some comments for removed ASSERT
https://bugs.webkit.org/attachment.cgi?id=33731&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
	
> +#if !PLATFORM(WINCE) || PLATFORM(QT)
>	   PlatformGraphicsContext* platformContext() const;
> +#endif
> +
> +	   const Font& font() const;
> +	   void setFont(const Font&);

  I think we have a problem here.  Why are these unconditionally added?

  In retrospect I think we need more cleanup.

From bugzilla-daemon at webkit.org  Wed Jul 29 23:40:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 23:40:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27826] [V8] Remove bug-bait
 V8Proxy::context() : [Attachment 33760] Patch v1
In-Reply-To: <bug-27826-0@https.bugs.webkit.org/>
References: <bug-27826-0@https.bugs.webkit.org/>
Message-ID: <20090730064048.545A13428E2F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27826: [V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826

Attachment 33760: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33760&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 23:50:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 23:50:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27826] [V8] Remove bug-bait
 V8Proxy::context() : [Attachment 33760] Patch v1
In-Reply-To: <bug-27826-0@https.bugs.webkit.org/>
References: <bug-27826-0@https.bugs.webkit.org/>
Message-ID: <20090730065008.91A333428ECB@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27826: [V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826

Attachment 33760: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33760&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: WebCore/bindings/v8/V8Proxy.cpp
> +    v8::Context::Scope contextScope(m_context);

This is more than just a transform on this line.

This line would be equivalent to what was there before: 
   v8::Context::Scope contextScope(v8::Local<v8::Context>::New(m_context));


So r+ if you make this change to make it equivalent to before.

From bugzilla-daemon at webkit.org  Wed Jul 29 23:52:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 23:52:34 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27826] [V8] Remove bug-bait
 V8Proxy::context() : [Attachment 33760] Patch v1
In-Reply-To: <bug-27826-0@https.bugs.webkit.org/>
References: <bug-27826-0@https.bugs.webkit.org/>
Message-ID: <20090730065234.190713428F4F@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27826: [V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826

Attachment 33760: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33760&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 23:52:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 23:52:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27826] [V8] Remove bug-bait
 V8Proxy::context() : [Attachment 33761] Patch v1
In-Reply-To: <bug-27826-0@https.bugs.webkit.org/>
References: <bug-27826-0@https.bugs.webkit.org/>
Message-ID: <20090730065247.3ED7F3428F70@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has asked  for review:
Bug 27826: [V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826

Attachment 33761: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33761&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 23:55:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 23:55:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27787] The type information
 about the resource loading is not forwarded to the network layer :
 [Attachment 33682] patch which resource type information to the
 ResourceRequestBase class
In-Reply-To: <bug-27787-0@https.bugs.webkit.org/>
References: <bug-27787-0@https.bugs.webkit.org/>
Message-ID: <20090730065504.BAF583428FC9@gamma.macosforge.org>

Zsombor <gzsombor at gmail.com> has asked	for review:
Bug 27787: The type information about the resource loading is not forwarded to
the network layer
https://bugs.webkit.org/show_bug.cgi?id=27787

Attachment 33682: patch which resource type information to the
ResourceRequestBase class
https://bugs.webkit.org/attachment.cgi?id=33682&action=review

From bugzilla-daemon at webkit.org  Wed Jul 29 23:56:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Wed, 29 Jul 2009 23:56:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 23522] Use checked casts for
 render tree : [Attachment 33729] Next step: Includes toRenderWidget
In-Reply-To: <bug-23522-0@https.bugs.webkit.org/>
References: <bug-23522-0@https.bugs.webkit.org/>
Message-ID: <20090730065601.6F49F3428FD7@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 23522: Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Attachment 33729: Next step: Includes toRenderWidget
https://bugs.webkit.org/attachment.cgi?id=33729&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Verified that it is equivalent (with the added bonus of error checking).

I wish there was a way to give compile errors for instances of
"static_cast<RenderWidget*>()" to prevent it from being added again
(automatically), but I couldn't think of any way to do this.

From bugzilla-daemon at webkit.org  Thu Jul 30 00:13:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 00:13:51 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27826] [V8] Remove bug-bait
 V8Proxy::context() : [Attachment 33761] Patch v1
In-Reply-To: <bug-27826-0@https.bugs.webkit.org/>
References: <bug-27826-0@https.bugs.webkit.org/>
Message-ID: <20090730071352.0471A3429188@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27826: [V8] Remove bug-bait V8Proxy::context()
https://bugs.webkit.org/show_bug.cgi?id=27826

Attachment 33761: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33761&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 00:42:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 00:42:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 25535] [GTK]
 object:state-changed:checked events missing for radio buttons and
 checkboxes : [Attachment 31410] statechangedchecked.patch
In-Reply-To: <bug-25535-0@https.bugs.webkit.org/>
References: <bug-25535-0@https.bugs.webkit.org/>
Message-ID: <20090730074220.692CB34293A3@gamma.macosforge.org>

Maciej Stachowiak <mjs at apple.com> has granted Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 25535: [GTK] object:state-changed:checked events missing for radio buttons
and checkboxes
https://bugs.webkit.org/show_bug.cgi?id=25535

Attachment 31410: statechangedchecked.patch
https://bugs.webkit.org/attachment.cgi?id=31410&action=review

------- Additional Comments from Maciej Stachowiak <mjs at apple.com>
Accessibility notifications right now are posted from all over the code. It
might be good to rationalize them (maybe they should all come from the render
tree), but for now this seems like a sensible approach. I wonder if other AX
back ends need to react to this notification too.

From bugzilla-daemon at webkit.org  Thu Jul 30 03:04:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 03:04:19 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27247] [HTML5][Forms] Support
 for `list' attribute of <input> : [Attachment 33765] Reference patch
In-Reply-To: <bug-27247-0@https.bugs.webkit.org/>
References: <bug-27247-0@https.bugs.webkit.org/>
Message-ID: <20090730100420.039603429D9D@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has denied  review:
Bug 27247: [HTML5][Forms] Support for `list' attribute of <input>
https://bugs.webkit.org/show_bug.cgi?id=27247

Attachment 33765: Reference patch
https://bugs.webkit.org/attachment.cgi?id=33765&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
This is a patch without ChangeLog and tests, for reference.
I'll submit a complete one after all dependent patches are landed.

From bugzilla-daemon at webkit.org  Thu Jul 30 03:43:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 03:43:16 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33730] Allow to explicitly choose a
 preferred plugin for a mimetype - r2.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090730104316.54837342A084@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has canceled Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33730: Allow to explicitly choose a preferred plugin for a mimetype
- r2.
https://bugs.webkit.org/attachment.cgi?id=33730&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
ChangeLog.

From bugzilla-daemon at webkit.org  Thu Jul 30 03:43:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 03:43:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33766] Allow to explicitly choose a
 preferred plugin for a mimetype - r3.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090730104316.88AAF342A088@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked Simon Hausmann
<hausmann at webkit.org> for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33766: Allow to explicitly choose a preferred plugin for a mimetype
- r3.
https://bugs.webkit.org/attachment.cgi?id=33766&action=review

------- Additional Comments from Jakub Wieczorek <faw217 at gmail.com>
ChangeLog.

From bugzilla-daemon at webkit.org  Thu Jul 30 04:58:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 04:58:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27830] Allow custom memory
 allocation control for JavaScriptCore's HashEntry class : [Attachment
 33768] proposed patch
In-Reply-To: <bug-27830-0@https.bugs.webkit.org/>
References: <bug-27830-0@https.bugs.webkit.org/>
Message-ID: <20090730115813.94422342A8BF@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27830: Allow custom memory allocation control for JavaScriptCore's
HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830

Attachment 33768: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33768&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 05:04:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:04:25 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27792] [GTK]
 new-window-policy-decision-requested provides no information about the
 target frame : [Attachment 33715] Updated patch
In-Reply-To: <bug-27792-0@https.bugs.webkit.org/>
References: <bug-27792-0@https.bugs.webkit.org/>
Message-ID: <20090730120425.8D29C342A9A5@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has denied Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 27792: [GTK] new-window-policy-decision-requested provides no information
about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Attachment 33715: Updated patch
https://bugs.webkit.org/attachment.cgi?id=33715&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> + * Since: 1.1.12

Should be 1.1.13, now =).

> +void
webkit_web_navigation_action_set_target_frame(WebKitWebNavigationAction*
navigationAction, const gchar* targetFrame)
> +{
> +    g_return_if_fail(WEBKIT_IS_WEB_NAVIGATION_ACTION(navigationAction));

No need for this check, after making it static.

> --- a/WebKitTools/ChangeLog
> +++ b/WebKitTools/ChangeLog
> @@ -1,3 +1,14 @@
> +2009-07-29  Martin Robinson	<martin.james.robinson at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [GTK] new-window-policy-decision-requested provides no information
about the target frame
> +	   https://bugs.webkit.org/show_bug.cgi?id=27792
> +
> +	   * GtkLauncher/main.c:
> +	   (policy_callback):
> +	   (create_browser):
> +

The ChangeLog entry should be in WebKit/gtk/ChangeLog, and list the correct
funtions =).

I'm OK with the approach and with the API additions. I'll say r-, though,
because I see too many nits to be addressed, and because of the ChangeLog
issue, but feel free to r+ the next patch, Jan, or Xan.

From bugzilla-daemon at webkit.org  Thu Jul 30 05:11:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:11:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27655] [v8] cache v8
 strings when converting from webcore string to v8 string : [Attachment
 33769] Next iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090730121129.3068C342AA1A@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33769: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33769&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 05:16:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:16:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33737] Implement ImageDiff
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090730121611.89DF3342AAC2@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Ariya Hidayat
<ariya.hidayat at trolltech.com>'s request for review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33737: Implement ImageDiff
https://bugs.webkit.org/attachment.cgi?id=33737&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. Cool stuff :)

From bugzilla-daemon at webkit.org  Thu Jul 30 05:18:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:18:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33738] Add pixel tests to
 DumpRenderTree
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090730121814.DDF55342AAFA@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Ariya Hidayat
<ariya.hidayat at trolltech.com>'s request for review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33738: Add pixel tests to DumpRenderTree
https://bugs.webkit.org/attachment.cgi?id=33738&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me. One sidenote: Due to the WTF assertion macros not be consistenly exported
in Mac framework builds in dbg vs. release it may be better to use Q_ASSERT
instead of ASSERT() for now.

From bugzilla-daemon at webkit.org  Thu Jul 30 05:21:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:21:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27831] Allow custom memory
 allocation control for JavaScriptCore's UString class : [Attachment 33770]
 proposed patch
In-Reply-To: <bug-27831-0@https.bugs.webkit.org/>
References: <bug-27831-0@https.bugs.webkit.org/>
Message-ID: <20090730122154.61078342AB91@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27831: Allow custom memory allocation control for JavaScriptCore's UString
class
https://bugs.webkit.org/show_bug.cgi?id=27831

Attachment 33770: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33770&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 05:31:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:31:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27833] Allow custom memory
 allocation control for JavaScriptCore's RegExpConstructorPrivate struct :
 [Attachment 33772] proposed patch
In-Reply-To: <bug-27833-0@https.bugs.webkit.org/>
References: <bug-27833-0@https.bugs.webkit.org/>
Message-ID: <20090730123121.DA8C2342AC71@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27833: Allow custom memory allocation control for JavaScriptCore's
RegExpConstructorPrivate struct
https://bugs.webkit.org/show_bug.cgi?id=27833

Attachment 33772: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33772&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 05:46:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:46:38 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27551] Make it possible to
 build JavaScriptCore as shared library without symbol lists : [Attachment
 33773] Updated patch with one MSVC warning fixed and explanation for the
 other ignored warning
In-Reply-To: <bug-27551-0@https.bugs.webkit.org/>
References: <bug-27551-0@https.bugs.webkit.org/>
Message-ID: <20090730124638.5EAC8342ADA3@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has asked	for review:
Bug 27551: Make it possible to build JavaScriptCore as shared library without
symbol lists
https://bugs.webkit.org/show_bug.cgi?id=27551

Attachment 33773: Updated patch with one MSVC warning fixed and explanation for
the other ignored warning
https://bugs.webkit.org/attachment.cgi?id=33773&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 05:51:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:51:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33766] Allow to explicitly choose a
 preferred plugin for a mimetype - r3.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090730125107.2A21D342AE17@gamma.macosforge.org>

Simon Hausmann <hausmann at webkit.org> has granted Jakub Wieczorek
<faw217 at gmail.com>'s request for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33766: Allow to explicitly choose a preferred plugin for a mimetype
- r3.
https://bugs.webkit.org/attachment.cgi?id=33766&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
r=me

+    if (plugin && !plugin->mimeToExtensions().contains(mimeType))

I would formulate this one the other way around:

if (!plugin || plugin->mimeToExtension().contains(mimeType))
    return;

What do you think?

The rest looks good to me :-)

From bugzilla-daemon at webkit.org  Thu Jul 30 05:51:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 05:51:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27834] Allow custom memory
 allocation control for JavaScriptCore's ScopeChain class : [Attachment
 33774] proposed patch
In-Reply-To: <bug-27834-0@https.bugs.webkit.org/>
References: <bug-27834-0@https.bugs.webkit.org/>
Message-ID: <20090730125150.9EF9D342AE3E@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27834: Allow custom memory allocation control for JavaScriptCore's
ScopeChain class
https://bugs.webkit.org/show_bug.cgi?id=27834

Attachment 33774: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33774&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 06:02:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 06:02:08 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27802] Encoding override is
 not applied to all the contents in the page. : [Attachment 33775] patch v2
 for loader
In-Reply-To: <bug-27802-0@https.bugs.webkit.org/>
References: <bug-27802-0@https.bugs.webkit.org/>
Message-ID: <20090730130208.ED6AF342AF46@gamma.macosforge.org>

johnnyding <johnnyding.webkit at gmail.com> has asked Alexey Proskuryakov
<ap at webkit.org> for review:
Bug 27802: Encoding override is not applied to all the contents in the page.
https://bugs.webkit.org/show_bug.cgi?id=27802

Attachment 33775: patch v2 for loader
https://bugs.webkit.org/attachment.cgi?id=33775&action=review

------- Additional Comments from johnnyding <johnnyding.webkit at gmail.com>
Alex, the patch v2 used the way I mentioned in comments #3. Please take a look.

Thanks!

From bugzilla-daemon at webkit.org  Thu Jul 30 06:13:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 06:13:52 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33737] Implement ImageDiff
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090730131352.50369342B072@gamma.macosforge.org>

Ariya Hidayat <ariya.hidayat at trolltech.com> has canceled  review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33737: Implement ImageDiff
https://bugs.webkit.org/attachment.cgi?id=33737&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 06:14:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 06:14:24 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27813] [Qt] DumpRenderTree
 lacks pixel tests support : [Attachment 33738] Add pixel tests to
 DumpRenderTree
In-Reply-To: <bug-27813-0@https.bugs.webkit.org/>
References: <bug-27813-0@https.bugs.webkit.org/>
Message-ID: <20090730131424.247FA342B07E@gamma.macosforge.org>

Ariya Hidayat <ariya.hidayat at trolltech.com> has canceled  review:
Bug 27813: [Qt] DumpRenderTree lacks pixel tests support
https://bugs.webkit.org/show_bug.cgi?id=27813

Attachment 33738: Add pixel tests to DumpRenderTree
https://bugs.webkit.org/attachment.cgi?id=33738&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 06:24:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 06:24:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27655] [v8] cache v8 strings
 when converting from webcore string to v8 string : [Attachment 33769] Next
 iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090730132440.D875C342B19A@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33769: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33769&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Last thing to fix....(the paths for the files).

> Index: third_party/WebKit/WebCore/ChangeLog
You seem to be creating these patches from outside of your WebKit enlistment.

These lines should start with WebCore (or else committing them is going to be
annoying).

If you create the patch when you are in the third_party/WebKit directory this
should all work. Alternately, you could just carefully edit the patch by hand.

> ===================================================================
> --- third_party/WebKit/WebCore/ChangeLog	(revision 46575)
> +++ third_party/WebKit/WebCore/ChangeLog	(working copy)
> @@ -1,3 +1,24 @@
> +2009-07-30  Anton Muhin  <antonm at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   Cache v8 strings when converting from WebCore::String to v8 string.
> +	   https://bugs.webkit.org/show_bug.cgi?id=27655
> +
> +	   * bindings/v8/V8Binding.cpp:
> +	   (WebCore::v8String): now just immediately calls v8ExternalString
> +	   (WebCore::enableStringImplCache): enables caching of conversions
from WebCore::StringImpl to
> +	   v8::String
> +	   (WebCore::makeExternalString): utilty function to create external
v8::String out of
> +	   WebCore::Strin
typo: Strin

I can fix this on landing, but if you upload a new patch, it would be nice to
fix it.


> I'm lacking knowledge of our build process, but are you sure we have to
> separate binaries for worker and render?  I was under impression that the
> binary is the same and it flags which turn it into a worker or renderer
> process.

Yes. Note: Workers in chromium only run one thread, but we can leave this as a
runtime flag as it all appears to work.

The api feels a bit narrow in scope "enableStringImplCache" vs
"setSingleThreadedMode", but this is fine. It can be broadened if there is ever
any other code that needs this info.

From bugzilla-daemon at webkit.org  Thu Jul 30 06:59:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 06:59:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27655] [v8] cache v8
 strings when converting from webcore string to v8 string : [Attachment
 33776] Next iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090730135936.697C5342B47B@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33776: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33776&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 07:02:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 07:02:50 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27655] [v8] cache v8 strings
 when converting from webcore string to v8 string : [Attachment 33776] Next
 iteration
In-Reply-To: <bug-27655-0@https.bugs.webkit.org/>
References: <bug-27655-0@https.bugs.webkit.org/>
Message-ID: <20090730140250.52225342B4FD@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted anton muhin
<antonm at chromium.org>'s request for review:
Bug 27655: [v8] cache v8 strings when converting from webcore string to v8
string
https://bugs.webkit.org/show_bug.cgi?id=27655

Attachment 33776: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33776&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 07:27:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 07:27:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33777] more clean up
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090730142711.B2A56342B6F2@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33777: more clean up
https://bugs.webkit.org/attachment.cgi?id=33777&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 07:56:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 07:56:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27792] [GTK]
 new-window-policy-decision-requested provides no information about the
 target frame : [Attachment 33779] Updated patch 2
In-Reply-To: <bug-27792-0@https.bugs.webkit.org/>
References: <bug-27792-0@https.bugs.webkit.org/>
Message-ID: <20090730145635.595D4342B9F6@gamma.macosforge.org>

Martin Robinson <martin.james.robinson at gmail.com> has asked  for review:
Bug 27792: [GTK] new-window-policy-decision-requested provides no information
about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Attachment 33779: Updated patch 2
https://bugs.webkit.org/attachment.cgi?id=33779&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 07:56:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 07:56:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27816] WINCE PORT: some
 files modified for WINCE build : [Attachment 33780] updatd (changes in
 BitmapInfo.h removed)
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090730145653.320A8342BA19@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33780: updatd (changes in BitmapInfo.h removed)
https://bugs.webkit.org/attachment.cgi?id=33780&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 08:01:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:01:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27774] [Gtk] Code cleanup
 in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33781] v0.2.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730150109.6146C342BA8D@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33781: v0.2.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33781&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
code style fixed pointed out by cpplint.py tool

From bugzilla-daemon at webkit.org  Thu Jul 30 08:02:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:02:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27774] [Gtk] Code cleanup
 in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33782] v0.2.2 - removal of unneeded includes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730150255.D2226342BAC0@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33782: v0.2.2 - removal of unneeded includes
https://bugs.webkit.org/attachment.cgi?id=33782&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
unneeded includes removal.

From bugzilla-daemon at webkit.org  Thu Jul 30 08:24:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:24:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27124] let me *edit* css
 styles in the web inspector. : [Attachment 33783] Edit CSS Selectors
In-Reply-To: <bug-27124-0@https.bugs.webkit.org/>
References: <bug-27124-0@https.bugs.webkit.org/>
Message-ID: <20090730152407.F2D2F342BCC9@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27124: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

Attachment 33783: Edit CSS Selectors
https://bugs.webkit.org/attachment.cgi?id=33783&action=review

------- Additional Comments from Joseph Pecoraro <joepeck02 at gmail.com>
NOTES:

- Double-Click to Add CSS Selectors section, provides a useful initial value
- Double-Click a Selector to edit (if allowed)
- Double-Click White-Space to add a Property (enlarged whitespace)
- GUI Displays as Gray if an edit is Not Applicable to the current selected
node
- Tabbing may go between the Selector and its Properties
- Strikethroughs and Ordering are accurate
- Selected Element's style attributes always show, expands automatically,
otherwise collapsed
- Editing Element's style attributes is synced with Element's Tree Outline
- Fix for Adding a New Property and pushing Esc to Cancel

From bugzilla-daemon at webkit.org  Thu Jul 30 08:30:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:30:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27623] Video elements fires
 another "load" event when attached to DOM : [Attachment 33784] proposed
 patch
In-Reply-To: <bug-27623-0@https.bugs.webkit.org/>
References: <bug-27623-0@https.bugs.webkit.org/>
Message-ID: <20090730153005.B5B5C342BD56@gamma.macosforge.org>

Eric Carlson <eric.carlson at apple.com> has asked  for review:
Bug 27623: Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623

Attachment 33784: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33784&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 08:32:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:32:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27124] let me *edit* css
 styles in the web inspector. : [Attachment 33783] Edit CSS Selectors
In-Reply-To: <bug-27124-0@https.bugs.webkit.org/>
References: <bug-27124-0@https.bugs.webkit.org/>
Message-ID: <20090730153243.AC154342BD98@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has denied Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27124: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

Attachment 33783: Edit CSS Selectors
https://bugs.webkit.org/attachment.cgi?id=33783&action=review

------- Additional Comments from Timothy Hatcher <timothy at hatcher.name>
> +	   for (var i = 0, len = parentRules.length; i < len; ++i) {
> +	   for (var i = 0, len = nodes.length; i < len; ++i) {

We prefer to spell out variables like length.

You need to add all the new UIStrings to localizedString.js

Awesome work!

From bugzilla-daemon at webkit.org  Thu Jul 30 08:49:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:49:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27623] Video elements fires
 another "load" event when attached to DOM : [Attachment 33784] proposed
 patch
In-Reply-To: <bug-27623-0@https.bugs.webkit.org/>
References: <bug-27623-0@https.bugs.webkit.org/>
Message-ID: <20090730154916.B1301342BF1B@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 27623: Video elements fires another "load" event when attached to DOM
https://bugs.webkit.org/show_bug.cgi?id=27623

Attachment 33784: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33784&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 08:57:15 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:57:15 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27124] let me *edit* css
 styles in the web inspector. : [Attachment 33785] Edit CSS Selectors (diff
 --binary)
In-Reply-To: <bug-27124-0@https.bugs.webkit.org/>
References: <bug-27124-0@https.bugs.webkit.org/>
Message-ID: <20090730155715.1D3C2342C00F@gamma.macosforge.org>

Joseph Pecoraro <joepeck02 at gmail.com> has asked  for review:
Bug 27124: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

Attachment 33785: Edit CSS Selectors (diff --binary)
https://bugs.webkit.org/attachment.cgi?id=33785&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 08:58:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 08:58:04 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27124] let me *edit* css
 styles in the web inspector. : [Attachment 33785] Edit CSS Selectors (diff
 --binary)
In-Reply-To: <bug-27124-0@https.bugs.webkit.org/>
References: <bug-27124-0@https.bugs.webkit.org/>
Message-ID: <20090730155804.A0B28342C029@gamma.macosforge.org>

Timothy Hatcher <timothy at hatcher.name> has granted Joseph Pecoraro
<joepeck02 at gmail.com>'s request for review:
Bug 27124: let me *edit* css styles in the web inspector.
https://bugs.webkit.org/show_bug.cgi?id=27124

Attachment 33785: Edit CSS Selectors (diff --binary)
https://bugs.webkit.org/attachment.cgi?id=33785&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:04:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:04:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27830] Allow custom memory
 allocation control for JavaScriptCore's HashEntry class : [Attachment
 33768] proposed patch
In-Reply-To: <bug-27830-0@https.bugs.webkit.org/>
References: <bug-27830-0@https.bugs.webkit.org/>
Message-ID: <20090730160437.04DA9342C0DA@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27830: Allow custom memory allocation control for JavaScriptCore's
HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830

Attachment 33768: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33768&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:05:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:05:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27831] Allow custom memory
 allocation control for JavaScriptCore's UString class : [Attachment 33770]
 proposed patch
In-Reply-To: <bug-27831-0@https.bugs.webkit.org/>
References: <bug-27831-0@https.bugs.webkit.org/>
Message-ID: <20090730160501.66720342C0EA@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27831: Allow custom memory allocation control for JavaScriptCore's UString
class
https://bugs.webkit.org/show_bug.cgi?id=27831

Attachment 33770: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33770&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:05:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:05:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27833] Allow custom memory
 allocation control for JavaScriptCore's RegExpConstructorPrivate struct :
 [Attachment 33772] proposed patch
In-Reply-To: <bug-27833-0@https.bugs.webkit.org/>
References: <bug-27833-0@https.bugs.webkit.org/>
Message-ID: <20090730160529.4D0FA342C0FA@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27833: Allow custom memory allocation control for JavaScriptCore's
RegExpConstructorPrivate struct
https://bugs.webkit.org/show_bug.cgi?id=27833

Attachment 33772: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33772&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:08:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:08:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27834] Allow custom memory
 allocation control for JavaScriptCore's ScopeChain class : [Attachment
 33774] proposed patch
In-Reply-To: <bug-27834-0@https.bugs.webkit.org/>
References: <bug-27834-0@https.bugs.webkit.org/>
Message-ID: <20090730160818.66A7B342C13C@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27834: Allow custom memory allocation control for JavaScriptCore's
ScopeChain class
https://bugs.webkit.org/show_bug.cgi?id=27834

Attachment 33774: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33774&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:28:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:28:48 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27824] [chromium] v8 binding
 and gyp changes for the chromium port's multi process message port
 implementation : [Attachment 33757] Proposed patch
In-Reply-To: <bug-27824-0@https.bugs.webkit.org/>
References: <bug-27824-0@https.bugs.webkit.org/>
Message-ID: <20090730162848.6E6E5342C336@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27824: [chromium] v8 binding and gyp changes for the chromium port's multi
process message port implementation
https://bugs.webkit.org/show_bug.cgi?id=27824

Attachment 33757: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33757&action=review

------- Additional Comments from David Levin <levin at chromium.org>

The general consensus in WebKit land seems to be that pure style/formatting
changes should be separated from other changes, so while I think the
indentation change in WebCore/bindings/v8/V8GCController.cpp is good, it should
be a separate patch.

From bugzilla-daemon at webkit.org  Thu Jul 30 09:41:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:41:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27772] PopupMenuQt lacks
 disabled and selected support : [Attachment 33658] Patch that enables
 selected and disabled support for PopupMenuQt.
In-Reply-To: <bug-27772-0@https.bugs.webkit.org/>
References: <bug-27772-0@https.bugs.webkit.org/>
Message-ID: <20090730164106.4CAC8342C47D@gamma.macosforge.org>

Adam Treat <treat at kde.org> has denied Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27772: PopupMenuQt lacks disabled and selected support
https://bugs.webkit.org/show_bug.cgi?id=27772

Attachment 33658: Patch that enables selected and disabled support for
PopupMenuQt.
https://bugs.webkit.org/attachment.cgi?id=33658&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +    QStandardItemModel *model =
qobject_cast<QStandardItemModel*>(m_popup->model());
> +    Q_ASSERT(model);

Style decoration problem.  See coding guidelines.

> +	       if (client()->itemIsSelected(i))
> +		   m_popup->setCurrentIndex(i);

The big fear I have is that QComboBox uses QStandardItemModel internally... if
they change that to using something else we'll be asserting.

How about this... Still ASSERT on the model, but further down replace with:

    if (model && !client()->itemIsEnabled())

That way we won't worry in release builds.

Sound ok?

From bugzilla-daemon at webkit.org  Thu Jul 30 09:44:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:44:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33781] v0.2.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730164429.7E94A342C4D8@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33781: v0.2.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33781&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
kept NULL whereas compiler warning show up, suggested by kov

From bugzilla-daemon at webkit.org  Thu Jul 30 09:44:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:44:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27774] [Gtk] Code cleanup
 in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33788] v0.3.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730164429.D4E82342C4DC@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33788: v0.3.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33788&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
kept NULL whereas compiler warning show up, suggested by kov

From bugzilla-daemon at webkit.org  Thu Jul 30 09:48:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:48:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33766] Allow to explicitly choose a
 preferred plugin for a mimetype - r3.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090730164833.8F762342C53A@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has canceled  review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33766: Allow to explicitly choose a preferred plugin for a mimetype
- r3.
https://bugs.webkit.org/attachment.cgi?id=33766&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:52:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:52:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33788] v0.3.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730165233.48A63342C589@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has canceled Antonio Gomes
(tonikitoo) <tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33788: v0.3.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33788&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
fixed, changelog message.

again please apply v0.4.1 before, then 0.2.2

From bugzilla-daemon at webkit.org  Thu Jul 30 09:52:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:52:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27774] [Gtk] Code cleanup
 in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33789] v0.4.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730165249.9432A342C59F@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33789: v0.4.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33789&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 09:55:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 09:55:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33789] v0.4.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730165549.99596342C606@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33789: v0.4.1 - code style fixes
https://bugs.webkit.org/attachment.cgi?id=33789&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
> -    } else {
> +    } else
>	   g_object_set(G_OBJECT(m_playBin), "volume", m_volume, NULL);
> -    }
> +
>  }

I'd remove this line.

> -	       LOG_VERBOSE(Media, "m_source is NULL");
> +	       LOG_VERBOSE(Media, "m_source is 0");

I think you want to keep this as NULL here.

Other than that looks good.

From bugzilla-daemon at webkit.org  Thu Jul 30 10:03:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:03:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27774] [Gtk] Code cleanup
 in MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33792] v0.5.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730170344.5BBE9342C6F1@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33792: v0.5.1 - code style fixes 
https://bugs.webkit.org/attachment.cgi?id=33792&action=review

------- Additional Comments from Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>
fixed.

carrying kov's r+ for the previous patch

From bugzilla-daemon at webkit.org  Thu Jul 30 10:13:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:13:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33792] v0.5.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730171357.E84DB342C7CF@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33792: v0.5.1 - code style fixes 
https://bugs.webkit.org/attachment.cgi?id=33792&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
right, thanks!

From bugzilla-daemon at webkit.org  Thu Jul 30 10:37:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:37:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27841] Fix box shadow
 painting: should pass shadow's color : [Attachment 33791] patch to fix box
 shadow painting
In-Reply-To: <bug-27841-0@https.bugs.webkit.org/>
References: <bug-27841-0@https.bugs.webkit.org/>
Message-ID: <20090730173707.AC2F3342CAAD@gamma.macosforge.org>

George Staikos <staikos at kde.org> has asked  for review:
Bug 27841: Fix box shadow painting: should pass shadow's color
https://bugs.webkit.org/show_bug.cgi?id=27841

Attachment 33791: patch to fix box shadow painting
https://bugs.webkit.org/attachment.cgi?id=33791&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 10:39:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:39:20 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33792] v0.5.1 - code style fixes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730173920.CA7D5342CAE3@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has canceled  review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33792: v0.5.1 - code style fixes 
https://bugs.webkit.org/attachment.cgi?id=33792&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Landed as r46587. Clearing review flag.

From bugzilla-daemon at webkit.org  Thu Jul 30 10:40:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:40:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27779] WINCE PORT: modified
 graphics files : [Attachment 33777] more clean up
In-Reply-To: <bug-27779-0@https.bugs.webkit.org/>
References: <bug-27779-0@https.bugs.webkit.org/>
Message-ID: <20090730174053.CBFCE342CB24@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27779: WINCE PORT: modified graphics files
https://bugs.webkit.org/show_bug.cgi?id=27779

Attachment 33777: more clean up
https://bugs.webkit.org/attachment.cgi?id=33777&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 10:47:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:47:10 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33782] v0.2.2 - removal of unneeded includes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730174710.79BB7342CBE6@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has granted Antonio Gomes (tonikitoo)
<tonikitoo at gmail.com>'s request for review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33782: v0.2.2 - removal of unneeded includes
https://bugs.webkit.org/attachment.cgi?id=33782&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Looks good.

From bugzilla-daemon at webkit.org  Thu Jul 30 10:51:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:51:24 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27774] [Gtk] Code cleanup in
 MediaPlayerPrivateGStreamer.cpp|h and VideoSinkGStreamer.cpp|h :
 [Attachment 33782] v0.2.2 - removal of unneeded includes
In-Reply-To: <bug-27774-0@https.bugs.webkit.org/>
References: <bug-27774-0@https.bugs.webkit.org/>
Message-ID: <20090730175124.CED9C342CC6C@gamma.macosforge.org>

Gustavo Noronha (kov) <gns at gnome.org> has canceled  review:
Bug 27774: [Gtk] Code cleanup in MediaPlayerPrivateGStreamer.cpp|h and
VideoSinkGStreamer.cpp|h
https://bugs.webkit.org/show_bug.cgi?id=27774

Attachment 33782: v0.2.2 - removal of unneeded includes
https://bugs.webkit.org/attachment.cgi?id=33782&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
Landed as r46588.

From bugzilla-daemon at webkit.org  Thu Jul 30 10:58:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 10:58:57 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27841] Fix box shadow
 painting: should pass shadow's color : [Attachment 33791] patch to fix box
 shadow painting
In-Reply-To: <bug-27841-0@https.bugs.webkit.org/>
References: <bug-27841-0@https.bugs.webkit.org/>
Message-ID: <20090730175857.560BC342CD49@gamma.macosforge.org>

mitz at webkit.org has denied George Staikos <staikos at kde.org>'s request for
review:
Bug 27841: Fix box shadow painting: should pass shadow's color
https://bugs.webkit.org/show_bug.cgi?id=27841

Attachment 33791: patch to fix box shadow painting
https://bugs.webkit.org/attachment.cgi?id=33791&action=review

------- Additional Comments from mitz at webkit.org
I think this is wrong. What is the issue this is supposed to address?

From bugzilla-daemon at webkit.org  Thu Jul 30 11:13:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:13:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27816] WINCE PORT: some files
 modified for WINCE build : [Attachment 33780] updatd (PopupMenuWin.cpp)
In-Reply-To: <bug-27816-0@https.bugs.webkit.org/>
References: <bug-27816-0@https.bugs.webkit.org/>
Message-ID: <20090730181340.3485D342CF28@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27816: WINCE PORT: some files modified for WINCE build
https://bugs.webkit.org/show_bug.cgi?id=27816

Attachment 33780: updatd (PopupMenuWin.cpp)
https://bugs.webkit.org/attachment.cgi?id=33780&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 11:30:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:30:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33282] part 2 (ScrollView, Widget,
 ScrollBar files)
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730183006.CC1ED342D0C3@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33282: part 2 (ScrollView, Widget, ScrollBar files)
https://bugs.webkit.org/attachment.cgi?id=33282&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
No changelog.  Also is this style checked?  I didn't notice any issues so far
but it's a big patch.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:31:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:31:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27843] Invalid member
 function pointer hashing in SVG bindings. : [Attachment 33794] Patch
In-Reply-To: <bug-27843-0@https.bugs.webkit.org/>
References: <bug-27843-0@https.bugs.webkit.org/>
Message-ID: <20090730183134.03EC2342D0F2@gamma.macosforge.org>

Dean McNamee <deanm at chromium.org> has asked  for review:
Bug 27843: Invalid member function pointer hashing in SVG bindings.
https://bugs.webkit.org/show_bug.cgi?id=27843

Attachment 33794: Patch
https://bugs.webkit.org/attachment.cgi?id=33794&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 11:35:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:35:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27842] Implement
 GraphicsContext::fillRoundRect() for WINCE port : [Attachment 33793] patch
 to implement fillRoundRect
In-Reply-To: <bug-27842-0@https.bugs.webkit.org/>
References: <bug-27842-0@https.bugs.webkit.org/>
Message-ID: <20090730183551.62647342D17E@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied  review:
Bug 27842: Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

Attachment 33793: patch to implement fillRoundRect
https://bugs.webkit.org/attachment.cgi?id=33793&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
No need to include "Written by" in this patch and please use the
proper/consistent email address

You should use 0 instead of NULL.

You have braces around IntersectClipRect twice where the coding guidelines say
there should not be (not that I agree...)

The rest seems fine.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:37:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:37:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27772] PopupMenuQt lacks
 disabled and selected support : [Attachment 33795] Patch with updated style
 / model check.
In-Reply-To: <bug-27772-0@https.bugs.webkit.org/>
References: <bug-27772-0@https.bugs.webkit.org/>
Message-ID: <20090730183753.9A841342D1BF@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27772: PopupMenuQt lacks disabled and selected support
https://bugs.webkit.org/show_bug.cgi?id=27772

Attachment 33795: Patch with updated style / model check.
https://bugs.webkit.org/attachment.cgi?id=33795&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Thanks for the review.	 Patch is updated as suggested.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:39:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:39:36 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27802] Encoding override is
 not applied to all the contents in the page. : [Attachment 33775] patch v2
 for loader
In-Reply-To: <bug-27802-0@https.bugs.webkit.org/>
References: <bug-27802-0@https.bugs.webkit.org/>
Message-ID: <20090730183936.80039342D1FA@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has canceled johnnyding
<johnnyding.webkit at gmail.com>'s request for review:
Bug 27802: Encoding override is not applied to all the contents in the page.
https://bugs.webkit.org/show_bug.cgi?id=27802

Attachment 33775: patch v2 for loader
https://bugs.webkit.org/attachment.cgi?id=33775&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
Clearing review flag per the above comment.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:45:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:45:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27844] SVG Filter and
 linearRGB, sRGB platform support : [Attachment 33796] linearRGB,
 sRGB support for platforms
In-Reply-To: <bug-27844-0@https.bugs.webkit.org/>
References: <bug-27844-0@https.bugs.webkit.org/>
Message-ID: <20090730184552.DDF4C342D2B3@gamma.macosforge.org>

Dirk Schulze <krit at webkit.org> has asked  for review:
Bug 27844: SVG Filter and linearRGB, sRGB platform support
https://bugs.webkit.org/show_bug.cgi?id=27844

Attachment 33796: linearRGB, sRGB support for platforms
https://bugs.webkit.org/attachment.cgi?id=33796&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This is an inital patch to add support of linearRGB as well as sRGB. It uses
the native version of color space transformations from platforms if available.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:55:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:55:34 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27842] Implement
 GraphicsContext::fillRoundRect() for WINCE port : [Attachment 33798]
 Updated patch to implement fillRoundRect
In-Reply-To: <bug-27842-0@https.bugs.webkit.org/>
References: <bug-27842-0@https.bugs.webkit.org/>
Message-ID: <20090730185534.76A1C342D3D2@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted  review:
Bug 27842: Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

Attachment 33798: Updated patch to implement fillRoundRect
https://bugs.webkit.org/attachment.cgi?id=33798&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +	   Written by Crystal Zhang <crystal.zhang at torchmobile.com>

   That should be removed on checkin.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:58:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:58:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27842] Implement
 GraphicsContext::fillRoundRect() for WINCE port : [Attachment 33798]
 Updated patch to implement fillRoundRect
In-Reply-To: <bug-27842-0@https.bugs.webkit.org/>
References: <bug-27842-0@https.bugs.webkit.org/>
Message-ID: <20090730185818.5AA04342D424@gamma.macosforge.org>

George Staikos <staikos at kde.org> has denied  review:
Bug 27842: Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

Attachment 33798: Updated patch to implement fillRoundRect
https://bugs.webkit.org/attachment.cgi?id=33798&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Round() was renamed as pointed out by Yong.  Need to revisit this patch.

From bugzilla-daemon at webkit.org  Thu Jul 30 11:58:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 11:58:27 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27772] PopupMenuQt lacks
 disabled and selected support : [Attachment 33795] Patch with updated style
 / model check.
In-Reply-To: <bug-27772-0@https.bugs.webkit.org/>
References: <bug-27772-0@https.bugs.webkit.org/>
Message-ID: <20090730185827.7FDDE342D42E@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27772: PopupMenuQt lacks disabled and selected support
https://bugs.webkit.org/show_bug.cgi?id=27772

Attachment 33795: Patch with updated style / model check.
https://bugs.webkit.org/attachment.cgi?id=33795&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> +
> +	       if (model && !client()->itemIsEnabled(i))
> +		 model->item(i)->setEnabled(false);
> +
> +	       if (client()->itemIsSelected(i))
> +		   m_popup->setCurrentIndex(i);
> +	   }

Indentation is not quite right, but I'll fix it when I land.  Otherwise r=me!

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:17 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 29924] Add PositionConstructors.h
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190717.6F3A1342D546@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 29924: Add PositionConstructors.h
https://bugs.webkit.org/attachment.cgi?id=29924&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 29926] Rename positionBeforeNode to
 positionInParentBeforeNode
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190721.67AF2342D55A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 29926: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=29926&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:25 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 29927] Add more position constructors
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190725.3D772342D56E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 29927: Add more position constructors
https://bugs.webkit.org/attachment.cgi?id=29927&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:29 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 30846] Add PositionCreationFunctions.h
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190729.42FEE342D58A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 30846: Add PositionCreationFunctions.h
https://bugs.webkit.org/attachment.cgi?id=30846&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:32 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:32 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 30847] Rename positionBeforeNode to
 positionInParentBeforeNode
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190732.A1C65342D59E@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 30847: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=30847&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:35 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 30848] Add more position constructors
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190735.CFCB3342D5B2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 30848: Add more position constructors
https://bugs.webkit.org/attachment.cgi?id=30848&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33799] Add more position constructors
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190739.0F2BB342D5C9@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33799: Add more position constructors
https://bugs.webkit.org/attachment.cgi?id=33799&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 6 files changed, 62 insertions(+), 8 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:43 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33799] Add more position constructors
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190743.E879F342D5DF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33799: Add more position constructors
https://bugs.webkit.org/attachment.cgi?id=33799&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33800] Rename positionBeforeNode to
 positionInParentBeforeNode
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190747.41BA1342D5F4@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33800: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=33800&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 16 files changed, 96 insertions(+), 46 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:51 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33800] Rename positionBeforeNode to
 positionInParentBeforeNode
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190751.B7E63342D60A@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Eric Seidel <eric at webkit.org>'s
request for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33800: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=33800&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:07:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:07:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33801] Move them back to Position.h per
 mjs's request
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190754.D09EB342D61F@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33801: Move them back to Position.h per mjs's request
https://bugs.webkit.org/attachment.cgi?id=33801&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 7 files changed, 68 insertions(+), 45 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 30 12:09:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:09:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33799] Add more position constructors
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190939.02185342D669@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33799: Add more position constructors
https://bugs.webkit.org/attachment.cgi?id=33799&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
A victim of bug 27849.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:09:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:09:44 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 25494] add
 PositionCreationFunctions.h in preparation for adding more position
 constructor functions : [Attachment 33800] Rename positionBeforeNode to
 positionInParentBeforeNode
In-Reply-To: <bug-25494-0@https.bugs.webkit.org/>
References: <bug-25494-0@https.bugs.webkit.org/>
Message-ID: <20090730190944.6EDF8342D685@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 25494: add PositionCreationFunctions.h in preparation for adding more
position constructor functions
https://bugs.webkit.org/show_bug.cgi?id=25494

Attachment 33800: Rename positionBeforeNode to positionInParentBeforeNode
https://bugs.webkit.org/attachment.cgi?id=33800&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
A victim of bug 27849.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:10:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:10:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27848] [WINCE] allow using
 old GetTickCount implementation of currentTime : [Attachment 33802] patch
 to CurrentTime.cpp
In-Reply-To: <bug-27848-0@https.bugs.webkit.org/>
References: <bug-27848-0@https.bugs.webkit.org/>
Message-ID: <20090730191006.2EA14342D6A4@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27848: [WINCE] allow using old GetTickCount implementation of currentTime
https://bugs.webkit.org/show_bug.cgi?id=27848

Attachment 33802: patch to CurrentTime.cpp
https://bugs.webkit.org/attachment.cgi?id=33802&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:18:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:18:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27843] (V8) Invalid member
 function pointer hashing in SVG bindings. : [Attachment 33794] Patch
In-Reply-To: <bug-27843-0@https.bugs.webkit.org/>
References: <bug-27843-0@https.bugs.webkit.org/>
Message-ID: <20090730191828.93EFF342D7D6@gamma.macosforge.org>

Dimitri Glazkov (Google) <dglazkov at chromium.org> has granted Dean McNamee
<deanm at chromium.org>'s request for review:
Bug 27843: (V8) Invalid member function pointer hashing in SVG bindings.
https://bugs.webkit.org/show_bug.cgi?id=27843

Attachment 33794: Patch
https://bugs.webkit.org/attachment.cgi?id=33794&action=review

------- Additional Comments from Dimitri Glazkov (Google)
<dglazkov at chromium.org>
r=me.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:22:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:22:12 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27848] [WINCE] allow using
 old GetTickCount implementation of currentTime : [Attachment 33802] patch
 to CurrentTime.cpp
In-Reply-To: <bug-27848-0@https.bugs.webkit.org/>
References: <bug-27848-0@https.bugs.webkit.org/>
Message-ID: <20090730192212.D8C78342D83A@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27848: [WINCE] allow using old GetTickCount implementation of currentTime
https://bugs.webkit.org/show_bug.cgi?id=27848

Attachment 33802: patch to CurrentTime.cpp
https://bugs.webkit.org/attachment.cgi?id=33802&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Looks good to me.  Needed for WinCE, could also be useful elsewhere.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:33:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:33:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27851] Fix compiler warning
 : [Attachment 33803] bmpwarning.patch
In-Reply-To: <bug-27851-0@https.bugs.webkit.org/>
References: <bug-27851-0@https.bugs.webkit.org/>
Message-ID: <20090730193317.2413C342D981@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 27851: Fix compiler warning
https://bugs.webkit.org/show_bug.cgi?id=27851

Attachment 33803: bmpwarning.patch
https://bugs.webkit.org/attachment.cgi?id=33803&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
GCC does not like multi-character character constants, so it produces the
following warning for BMPImageDecoder.cpp:

  CXX	 WebCore/platform/image-decoders/bmp/libWebCore_la-BMPImageDecoder.lo
../../WebCore/platform/image-decoders/bmp/BMPImageDecoder.cpp:128:16: warning:
multi-character character constant

The attached patch fixes the warning, but since this might be a bit
controversial *and* I can't run the tests to verify that this does not break
anything (they all fail with 'timed out' now, something must be broken
somewhere...), I'm opening a bug for this.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:42:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:42:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27848] [WINCE] allow using
 old GetTickCount implementation of currentTime : [Attachment 33805] same
 patch, updated changelog
In-Reply-To: <bug-27848-0@https.bugs.webkit.org/>
References: <bug-27848-0@https.bugs.webkit.org/>
Message-ID: <20090730194259.33F5C342DA89@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27848: [WINCE] allow using old GetTickCount implementation of currentTime
https://bugs.webkit.org/show_bug.cgi?id=27848

Attachment 33805: same patch, updated changelog
https://bugs.webkit.org/attachment.cgi?id=33805&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:46:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:46:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27820] Adding layout test for
 Unicode in <script> tag attributes : [Attachment 33750] wip
In-Reply-To: <bug-27820-0@https.bugs.webkit.org/>
References: <bug-27820-0@https.bugs.webkit.org/>
Message-ID: <20090730194626.68834342DADB@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has denied Evan Martin <evan at chromium.org>'s
request for review:
Bug 27820: Adding layout test for Unicode in <script> tag attributes
https://bugs.webkit.org/show_bug.cgi?id=27820

Attachment 33750: wip
https://bugs.webkit.org/attachment.cgi?id=33750&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Yeah, this looks good.	We just need a ChangeLog. 
WebKitTools/Scripts/prepare-ChangeLog can help you with that.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:47:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:47:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26558] WINCE needs
 important date related symbols : [Attachment 33806] patch to DateMath.cpp
In-Reply-To: <bug-26558-0@https.bugs.webkit.org/>
References: <bug-26558-0@https.bugs.webkit.org/>
Message-ID: <20090730194759.CC117342DB0A@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 26558: WINCE needs important date related symbols
https://bugs.webkit.org/show_bug.cgi?id=26558

Attachment 33806: patch to DateMath.cpp 
https://bugs.webkit.org/attachment.cgi?id=33806&action=review

------- Additional Comments from Joe Mason <joe.mason at torchmobile.com>
DateMath.cpp also uses time symbols that have no header file on WinCE

From bugzilla-daemon at webkit.org  Thu Jul 30 12:48:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:48:13 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27848] [WINCE] allow using
 old GetTickCount implementation of currentTime : [Attachment 33805] same
 patch, updated changelog
In-Reply-To: <bug-27848-0@https.bugs.webkit.org/>
References: <bug-27848-0@https.bugs.webkit.org/>
Message-ID: <20090730194813.DBA53342DB14@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 27848: [WINCE] allow using old GetTickCount implementation of currentTime
https://bugs.webkit.org/show_bug.cgi?id=27848

Attachment 33805: same patch, updated changelog
https://bugs.webkit.org/attachment.cgi?id=33805&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:49:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:49:08 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment 33536] Join the
 various versions of PluginView::stop() into one shared implementation
Message-ID: <20090730194908.5D40A342DB3A@gamma.macosforge.org>

X-Bugzilla-Type: request
In-Reply-To: <bug-27706-0 at https.bugs.webkit.org/>
References: <bug-27706-0 at https.bugs.webkit.org/>

Anders Carlsson <andersca at apple.com> has denied Tor Arne Vestb?
<vestbo at webkit.org>'s request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33536: Join the various versions of PluginView::stop() into one
shared implementation

https://bugs.webkit.org/attachment.cgi?id=33536&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
This looks very good, although it should use our PLATFORM defines instead of
those from npapi.h Marking r- for this reason.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:49:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:49:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27852] Add --minimal option
 to webkit-build : [Attachment 33807] Add --minimal option to webkit-build
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730194912.52D2D342DB4B@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33807: Add --minimal option to webkit-build
https://bugs.webkit.org/attachment.cgi?id=33807&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 12:49:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:49:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26558] WINCE needs important
 date related symbols : [Attachment 33806] patch to DateMath.cpp
In-Reply-To: <bug-26558-0@https.bugs.webkit.org/>
References: <bug-26558-0@https.bugs.webkit.org/>
Message-ID: <20090730194946.3F635342DB65@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Joe Mason
<joe.mason at torchmobile.com>'s request for review:
Bug 26558: WINCE needs important date related symbols
https://bugs.webkit.org/show_bug.cgi?id=26558

Attachment 33806: patch to DateMath.cpp 
https://bugs.webkit.org/attachment.cgi?id=33806&action=review

------- Additional Comments from George Staikos <staikos at kde.org>

> +#if PLATFORM(WINCE) && ! PLATFORM(QT)

  Maybe remove that extra space on checkin

From bugzilla-daemon at webkit.org  Thu Jul 30 12:50:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:50:43 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27209] Add WebSocket.idl :
 [Attachment 33698] add WebSocket.idl and js binding classes.
In-Reply-To: <bug-27209-0@https.bugs.webkit.org/>
References: <bug-27209-0@https.bugs.webkit.org/>
Message-ID: <20090730195043.34A6C342DB85@gamma.macosforge.org>

Alexey Proskuryakov <ap at webkit.org> has denied Fumitoshi Ukai
<ukai at chromium.org>'s request for review:
Bug 27209: Add WebSocket.idl
https://bugs.webkit.org/show_bug.cgi?id=27209

Attachment 33698: add WebSocket.idl and js binding classes.
https://bugs.webkit.org/attachment.cgi?id=33698&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
I think that the patch should also update project files for all build systems
(or at the very least, Mac). If the code is not functional as is, it should be
guarded with ENABLE() ifdefs.

> +JSWebSocketConstructor::JSWebSocketConstructor(ExecState* exec,
JSDOMGlobalObject* globalObject)
> +	   :
DOMConstructorObject(JSWebSocketConstructor::createStructure(globalObject->obje
ctPrototype()), globalObject)

Please use 4 spaces to indent.

> +{
> +    putDirect(exec->propertyNames().prototype,
JSWebSocketPrototype::self(exec, globalObject), None);
> +}

Looking at existing constructors, I believe you may also need to add a length
property.

> +    RefPtr<WebSocket> websocket = WebSocket::create(context);

"Websocket" is not a word, please capitalize the variable name accordingly
(webSocket).

> +	   const String protocol = args.at(1).toString(exec);

I think you intended to assign to a reference here.

Please add a test for what happens when toString() raises an exception for
either argument. Also, I'm not sure exactly what behavior is intended here, but
you may need to consider null arguments, not just undefined ones.

> +	   websocket->connect(url, protocol, ec);

Why is ec ignored?

> +    // TODO(ukai): garbage collection policy?

We use FIXME comments which say what exactly is wrong with the code. It is not
clear how others could use this comment.

> +    if (m_impl->readyState() != WebSocket::CLOSED)
> +	   markIfNotNull(m_impl->onmessage());
> +    // EventListeners?

Ditto.

> +    JSValue ret = jsBoolean(impl()->send(args.at(0).toString(exec), ec));

What happens if toString raises an exception? Please add a test (if the code is
not functional as is, please try to add it locally for later submission, let's
just not forget about it).

> +// TODO(ukai): addEventListener/removeEventListener?

Should be a FIXME, explaining what needs to be done (is it just unfinished code
that can be pretty much copied from elsewhere, or something that needs to be
carefully considered first?)
> +WebSocket::WebSocket(ScriptExecutionContext* context)
> +	   : ActiveDOMObject(context, this)
> +	   , m_state(CONNECTING)
> +	   , m_protocol("")

Please use 4-space indentation.

> +    m_url = url.copy();

Why copy the URL? As a comment in KURL.h explains, this is only needed if you
intend to use the KURL object on another thread.

> +    notImplemented();

No need to use notImplemented in cross-platform code that's just unfinished -
it's helpful for port maintainers to learn what unimplemented code paths they
hit, but not in this case.

Multiple TODOs in this file that need to be FIXMEs.

> +class WebSocket : public RefCounted<WebSocket>, public EventTarget, public
ActiveDOMObject {

Inheriting from ActiveDOMObject is needed when you want to use its GC
protection features. Is this the plan?

> +    // avoid error: request for member 'deref' is ambiguous.
> +    using RefCounted<WebSocket>::ref;
> +    using RefCounted<WebSocket>::deref;

This is something we routinely do in other code, probably no need to
specifically comment here. If you prefer to keep this comment, please turn it
into a full sentence starting with a capital letter.

This looks pretty good to me, but r- for now, since there are quite a few
comments.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:53:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:53:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27852] Add --minimal option
 to webkit-build : [Attachment 33807] Add --minimal option to webkit-build
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730195305.23E6A342DBDF@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33807: Add --minimal option to webkit-build
https://bugs.webkit.org/attachment.cgi?id=33807&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
New version, this one gets the --minimal option out of @ARGV and thus makes it
work with subsequent code that makes use of @ARGV still, like Qt's qmake stuff.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:53:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:53:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27852] Add --minimal option
 to webkit-build : [Attachment 33808] Add --minimal option to webkit-build
 (try 2)
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730195305.7F1A2342DBE4@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33808: Add --minimal option to webkit-build (try 2)
https://bugs.webkit.org/attachment.cgi?id=33808&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
New version, this one gets the --minimal option out of @ARGV and thus makes it
work with subsequent code that makes use of @ARGV still, like Qt's qmake stuff.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:54:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:54:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27842] Implement
 GraphicsContext::fillRoundRect() for WINCE port : [Attachment 33809]
 Updated patch again
In-Reply-To: <bug-27842-0@https.bugs.webkit.org/>
References: <bug-27842-0@https.bugs.webkit.org/>
Message-ID: <20090730195404.938BB342DC10@gamma.macosforge.org>

Crystal Zhang <crystal.zhang at torchmobile.com> has asked  for review:
Bug 27842: Implement GraphicsContext::fillRoundRect() for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27842

Attachment 33809: Updated patch again
https://bugs.webkit.org/attachment.cgi?id=33809&action=review

------- Additional Comments from Crystal Zhang <crystal.zhang at torchmobile.com>
Update patch according to review.

From bugzilla-daemon at webkit.org  Thu Jul 30 12:58:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:58:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33759] class ApplicationCacheHost rev2
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730195849.2A55B342DCC5@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has canceled Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33759: class ApplicationCacheHost rev2
https://bugs.webkit.org/attachment.cgi?id=33759&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
For whatever reason...

private:
    friend class RefCounted<DOMApplicationCache>;
    ~DOMApplicationCache() {}

... doesn't compile with msvc (the RefCounted base class does not have access
to the dtor).  Removing the 'class' keyword does compile with msvc, but then
gcc is unhappy about that. So... bailing on hiding the dtor, moved it to the
public section (which is generally how webcore refcounted classes are).

no other changes

From bugzilla-daemon at webkit.org  Thu Jul 30 12:58:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 12:58:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33810] class ApplicationCacheHost rev3
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730195849.45D75342DCC7@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33810: class ApplicationCacheHost rev3
https://bugs.webkit.org/attachment.cgi?id=33810&action=review

------- Additional Comments from Michael Nordman <michaeln at google.com>
For whatever reason...

private:
    friend class RefCounted<DOMApplicationCache>;
    ~DOMApplicationCache() {}

... doesn't compile with msvc (the RefCounted base class does not have access
to the dtor).  Removing the 'class' keyword does compile with msvc, but then
gcc is unhappy about that. So... bailing on hiding the dtor, moved it to the
public section (which is generally how webcore refcounted classes are).

no other changes

From bugzilla-daemon at webkit.org  Thu Jul 30 13:01:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:01:26 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 20534] DumpRenderTree needs a
 way to override settings on a per-test basis : [Attachment 33495] Hopefully
 the final cut.
In-Reply-To: <bug-20534-0@https.bugs.webkit.org/>
References: <bug-20534-0@https.bugs.webkit.org/>
Message-ID: <20090730200126.E55B1342DD13@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Dmitry Titov
<dimich at chromium.org>'s request for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 33495: Hopefully the final cut.
https://bugs.webkit.org/attachment.cgi?id=33495&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +	   * security/override-preferences-2-expected.txt:
> +	   * security/override-preferences-2.html: Verifies
overridePreverence("WebKitDefaultFontSize", "24")
> +	   * security/override-preferences-expected.txt:
> +	   * security/override-preferences.html: Verifies
overridePreference("WebKitJavaScriptEnabled", false).
> +	   * security/override-zzz-reset-expected.txt:
> +	   * security/override-zzz-reset.html: Because of 'zzz' this test will
run after the tests above and
> +	   verify that override of preferences does not 'spill' to the
subsequent tests in a batch.

The added tests are missing from this patch.

security/ seems like a strange place to put them. Maybe we need a new directory
for tests of the test harness?

> +- (void)_setPreference:(NSString *)key stringValue:(NSString *)value
> +{
> +    NSString *_key = KEY(key);
> +    [self _setStringValue:value forKey:_key];	
> +}

This is wrong. _setStringValue:forKey: also passes the key through KEY(), so
you'll end up with the preferences identifier prepended twice.

_setPreference:stringValue: is not a very Cocoa-y name. The obvious name would
be _setStringValue:forKey:. Maybe we should just expose that method through
WebPreferencesPrivate.h? Or maybe we can come up with a name that indicates
this is for testing purposes only. I don't think it's super-important to have
similar names on Mac and Windows for this.

> @@ -70,6 +70,10 @@ interface IWebPreferencesPrivate : IUnknown
>      HRESULT setFontSmoothingContrast([in] float contrast);
>      HRESULT fontSmoothingContrast([out, retval] float* contrast);
>  
> +    // This method is meant for overriding preferences for tests run
> +    // with DumpRenderTree only.
> +    HRESULT setPreference([in] BSTR key, [in] BSTR value);
> +
>      HRESULT isWebSecurityEnabled([out, retval] BOOL* enabled);
>      HRESULT setWebSecurityEnabled([in] BOOL enabled);

Please add the new function at the end of the interface, to avoid the risk of
breaking nightly builds.

> +HRESULT STDMETHODCALLTYPE WebPreferences::setPreference(BSTR key, BSTR
value)
> +{

There's no need to have STDMETHODCALLTYPE on the implementation. It's only
needed on the declaration.

> +    LayoutTestController* controller =
reinterpret_cast<LayoutTestController*>(JSObjectGetPrivate(thisObject));

static_cast is preferable here.

> +void LayoutTestController::overridePreference(JSStringRef key, JSStringRef
flag)
> +{
> +    RetainPtr<CFStringRef> keyCF(AdoptCF,
JSStringCopyCFString(kCFAllocatorDefault, key));
> +    NSString *keyNS = (NSString *)keyCF.get();
> +
> +    RetainPtr<CFStringRef> flagCF(AdoptCF,
JSStringCopyCFString(kCFAllocatorDefault, flag));
> +    NSString *flagNS = (NSString *)flagCF.get();

I think we tend to use 0 instead of kCFAllocatorDefault, though either is fine.


> +static void resetDefaultsToConsistentValues(IWebPreferences* preferences)
> +{
> +#ifdef USE_MAC_FONTS
> +    BSTR standardFamily = SysAllocString(TEXT("Times"));
> +    BSTR fixedFamily = SysAllocString(TEXT("Courier"));
> +    BSTR sansSerifFamily = SysAllocString(TEXT("Helvetica"));
> +    BSTR cursiveFamily = SysAllocString(TEXT("Apple Chancery"));
> +    BSTR fantasyFamily = SysAllocString(TEXT("Papyrus"));
> +#else
> +    BSTR standardFamily = SysAllocString(TEXT("Times New Roman"));
> +    BSTR fixedFamily = SysAllocString(TEXT("Courier New"));
> +    BSTR sansSerifFamily = SysAllocString(TEXT("Arial"));
> +    BSTR cursiveFamily = SysAllocString(TEXT("Comic Sans MS")); // Not
actually cursive, but it's what IE and Firefox use.
> +    BSTR fantasyFamily = SysAllocString(TEXT("Times New Roman"));
> +#endif
> +
> +    preferences->setStandardFontFamily(standardFamily);
> +    preferences->setFixedFontFamily(fixedFamily);
> +    preferences->setSerifFontFamily(standardFamily);
> +    preferences->setSansSerifFontFamily(sansSerifFamily);
> +    preferences->setCursiveFontFamily(cursiveFamily);
> +    preferences->setFantasyFontFamily(fantasyFamily);
> +
> +    SysFreeString(standardFamily);
> +    SysFreeString(fixedFamily);
> +    SysFreeString(sansSerifFamily);
> +    SysFreeString(cursiveFamily);
> +    SysFreeString(fantasyFamily);

You could make the font names be leaked static BSTRs.

> +	   preferences->resetDefaultsToConsistentValues();

This won't compile. resetDefaultsToConsistentValues() isn't a member of
IWebPreferences.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:05:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:05:34 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27824] [chromium] fix v8
 binding problem when locallyEntangledPort returns NULL : [Attachment 33811]
 new patch
In-Reply-To: <bug-27824-0@https.bugs.webkit.org/>
References: <bug-27824-0@https.bugs.webkit.org/>
Message-ID: <20090730200534.8DC0B342DDB8@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked	for review:
Bug 27824: [chromium] fix v8 binding problem when locallyEntangledPort returns
NULL
https://bugs.webkit.org/show_bug.cgi?id=27824

Attachment 33811: new patch
https://bugs.webkit.org/attachment.cgi?id=33811&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:08:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:08:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27852] Add --minimal option
 to webkit-build : [Attachment 33808] Add --minimal option to webkit-build
 (try 2)
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730200819.50138342DE65@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33808: Add --minimal option to webkit-build (try 2)
https://bugs.webkit.org/attachment.cgi?id=33808&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Fix for a spelling issue, pointed out by Adam Treat: explicitely -> explicitly.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:08:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:08:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27852] Add --minimal option
 to webkit-build : [Attachment 33812] Add --minimal option to webkit-build
 (try 3)
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730200819.82F1D342DE69@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33812: Add --minimal option to webkit-build (try 3)
https://bugs.webkit.org/attachment.cgi?id=33812&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Fix for a spelling issue, pointed out by Adam Treat: explicitely -> explicitly.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:11:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:11:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33546] move encoder files
 to platform/image_encoders/wince
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201113.4F441342DF78@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33546: move encoder files to platform/image_encoders/wince
https://bugs.webkit.org/attachment.cgi?id=33546&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:11:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:11:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33813] 1) image encoders
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201113.797BF342DF7A@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33813: 1) image encoders
https://bugs.webkit.org/attachment.cgi?id=33813&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:12:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:12:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33814] 2) SharedBitmap
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201220.1C8A3342DF97@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33814: 2) SharedBitmap
https://bugs.webkit.org/attachment.cgi?id=33814&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:13:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:13:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33815] 3) ImageBuffer
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201313.6A77A342DFCE@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33815: 3) ImageBuffer
https://bugs.webkit.org/attachment.cgi?id=33815&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:13:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:13:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33816] 4) ImageFrameSink
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201346.A2874342DFFB@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33816: 4) ImageFrameSink
https://bugs.webkit.org/attachment.cgi?id=33816&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:14:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:14:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33817] 5) MediaPlayer
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201416.31211342E024@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33817: 5) MediaPlayer
https://bugs.webkit.org/attachment.cgi?id=33817&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:14:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:14:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33818] 6) Path
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201446.8FC87342E041@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33818: 6) Path
https://bugs.webkit.org/attachment.cgi?id=33818&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:15:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:15:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33819] Color, Gradient,
 Image
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201513.70DA1342E05C@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33819: Color, Gradient, Image
https://bugs.webkit.org/attachment.cgi?id=33819&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:15:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:15:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27824] [chromium] fix v8
 binding problem when locallyEntangledPort returns NULL : [Attachment 33811]
 new patch
In-Reply-To: <bug-27824-0@https.bugs.webkit.org/>
References: <bug-27824-0@https.bugs.webkit.org/>
Message-ID: <20090730201557.06B46342E082@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27824: [chromium] fix v8 binding problem when locallyEntangledPort returns
NULL
https://bugs.webkit.org/show_bug.cgi?id=27824

Attachment 33811: new patch
https://bugs.webkit.org/attachment.cgi?id=33811&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks John.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:16:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:16:07 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33819] 7) Color, Gradient,
 Image
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201607.C399E342E0AE@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33819: 7) Color, Gradient, Image
https://bugs.webkit.org/attachment.cgi?id=33819&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:17:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:17:13 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27852] Add --minimal option to
 webkit-build : [Attachment 33812] Add --minimal option to webkit-build (try
 3)
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730201713.89A1C342E3CA@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has denied Jakob Petsovits
<jpetso at gmx.at>'s request for review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33812: Add --minimal option to webkit-build (try 3)
https://bugs.webkit.org/attachment.cgi?id=33812&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
I think it would be better and clearer for --minimal to be parsed like all the
other options. After the GetOptions call, if $minimal is true you can just loop
over @features and set all the values that don't match the default to 0.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:17:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:17:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27511] Add WinCE specific
 platform/graphics files to WebCore : [Attachment 33820] 7) Color, Gradient,
 Image
In-Reply-To: <bug-27511-0@https.bugs.webkit.org/>
References: <bug-27511-0@https.bugs.webkit.org/>
Message-ID: <20090730201720.C3B32342E425@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27511: Add WinCE specific platform/graphics files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=27511

Attachment 33820: 7) Color, Gradient, Image
https://bugs.webkit.org/attachment.cgi?id=33820&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:19:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:19:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 23522] Use checked casts for
 render tree : [Attachment 33729] Next step: Includes toRenderWidget
In-Reply-To: <bug-23522-0@https.bugs.webkit.org/>
References: <bug-23522-0@https.bugs.webkit.org/>
Message-ID: <20090730201918.07DB0342EB8B@gamma.macosforge.org>

Darin Adler <darin at apple.com> has canceled  review:
Bug 23522: Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Attachment 33729: Next step: Includes toRenderWidget
https://bugs.webkit.org/attachment.cgi?id=33729&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Landed, clearing review flag.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:20:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:20:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 23522] Use checked casts
 for render tree : [Attachment 33821] Next step: Includes toRenderTable*
In-Reply-To: <bug-23522-0@https.bugs.webkit.org/>
References: <bug-23522-0@https.bugs.webkit.org/>
Message-ID: <20090730202026.1BE1B342EC90@gamma.macosforge.org>

Darin Adler <darin at apple.com> has asked  for review:
Bug 23522: Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Attachment 33821: Next step: Includes toRenderTable*
https://bugs.webkit.org/attachment.cgi?id=33821&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:23:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:23:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27814] Qt Port does not
 obey color style in button tag with default background : [Attachment 33822]
 Code patch as described in bug report.
In-Reply-To: <bug-27814-0@https.bugs.webkit.org/>
References: <bug-27814-0@https.bugs.webkit.org/>
Message-ID: <20090730202314.C11FA342EFAD@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27814: Qt Port does not obey color style in button tag with default
background
https://bugs.webkit.org/show_bug.cgi?id=27814

Attachment 33822: Code patch as described in bug report.
https://bugs.webkit.org/attachment.cgi?id=33822&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
This patch is strictly the code change as described in the initial bug report. 
Test updates to follow.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:29:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:29:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33823] 1) Clipboard
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730202925.0E30C3430060@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33823: 1) Clipboard
https://bugs.webkit.org/attachment.cgi?id=33823&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:29:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:29:24 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33281] part 1 (not including ScrollView
 Widget and ScrollBar files)
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730202924.D86D8343005E@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has canceled Yong Li
<yong.li at torchmobile.com>'s request for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33281: part 1 (not including ScrollView Widget and ScrollBar files)
https://bugs.webkit.org/attachment.cgi?id=33281&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:30:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:30:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33824] 2) ScrollView
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203013.EFCB43430329@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33824: 2) ScrollView
https://bugs.webkit.org/attachment.cgi?id=33824&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:30:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:30:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33825] Widget, Scrollbar
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203042.140A23430398@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33825: Widget, Scrollbar
https://bugs.webkit.org/attachment.cgi?id=33825&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:31:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:31:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33826] 4) SharedBuffer
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203124.9B4BB3430499@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33826: 4) SharedBuffer
https://bugs.webkit.org/attachment.cgi?id=33826&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:31:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:31:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33827] ContextMenu
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203151.266A33430650@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33827: ContextMenu
https://bugs.webkit.org/attachment.cgi?id=33827&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:32:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:32:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33828] 6) SharedTimer and SystemTime
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203243.D21A23430979@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33828: 6) SharedTimer and SystemTime
https://bugs.webkit.org/attachment.cgi?id=33828&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:33:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:33:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33829] 7) KeygenWince
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203311.6B08B3430B22@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33829: 7) KeygenWince
https://bugs.webkit.org/attachment.cgi?id=33829&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:33:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:33:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27543] Add platform/wince/
 files for WINCE port : [Attachment 33830] 8) Other
In-Reply-To: <bug-27543-0@https.bugs.webkit.org/>
References: <bug-27543-0@https.bugs.webkit.org/>
Message-ID: <20090730203339.E20C33430D2B@gamma.macosforge.org>

Yong Li <yong.li at torchmobile.com> has asked  for review:
Bug 27543: Add platform/wince/ files for WINCE port
https://bugs.webkit.org/show_bug.cgi?id=27543

Attachment 33830: 8) Other
https://bugs.webkit.org/attachment.cgi?id=33830&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:40:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:40:56 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27820] Adding layout test
 for Unicode in <script> tag attributes : [Attachment 33750] wip
In-Reply-To: <bug-27820-0@https.bugs.webkit.org/>
References: <bug-27820-0@https.bugs.webkit.org/>
Message-ID: <20090730204056.A03D03431F62@gamma.macosforge.org>

Evan Martin <evan at chromium.org> has canceled  review:
Bug 27820: Adding layout test for Unicode in <script> tag attributes
https://bugs.webkit.org/show_bug.cgi?id=27820

Attachment 33750: wip
https://bugs.webkit.org/attachment.cgi?id=33750&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 13:40:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:40:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27820] Adding layout test
 for Unicode in <script> tag attributes : [Attachment 33831] patch with
 changelog
In-Reply-To: <bug-27820-0@https.bugs.webkit.org/>
References: <bug-27820-0@https.bugs.webkit.org/>
Message-ID: <20090730204059.575BA3431F77@gamma.macosforge.org>

Evan Martin <evan at chromium.org> has asked  for review:
Bug 27820: Adding layout test for Unicode in <script> tag attributes
https://bugs.webkit.org/show_bug.cgi?id=27820

Attachment 33831: patch with changelog
https://bugs.webkit.org/attachment.cgi?id=33831&action=review

------- Additional Comments from Evan Martin <evan at chromium.org>

---
 3 files changed, 20 insertions(+), 0 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 30 13:41:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:41:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27852] Add --minimal option
 to webkit-build : [Attachment 33812] Add --minimal option to webkit-build
 (try 3)
In-Reply-To: <bug-27852-0@https.bugs.webkit.org/>
References: <bug-27852-0@https.bugs.webkit.org/>
Message-ID: <20090730204136.22BFF3431F9D@gamma.macosforge.org>

Adam Roben (aroben) <aroben at apple.com> has granted  review:
Bug 27852: Add --minimal option to webkit-build
https://bugs.webkit.org/show_bug.cgi?id=27852

Attachment 33812: Add --minimal option to webkit-build (try 3)
https://bugs.webkit.org/attachment.cgi?id=33812&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
Jakob convinced me that my suggested approach is not better.

r=me

From bugzilla-daemon at webkit.org  Thu Jul 30 13:43:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:43:28 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27820] Adding layout test for
 Unicode in <script> tag attributes : [Attachment 33831] patch with
 changelog
In-Reply-To: <bug-27820-0@https.bugs.webkit.org/>
References: <bug-27820-0@https.bugs.webkit.org/>
Message-ID: <20090730204328.106653431FB7@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Evan Martin <evan at chromium.org>'s
request for review:
Bug 27820: Adding layout test for Unicode in <script> tag attributes
https://bugs.webkit.org/show_bug.cgi?id=27820

Attachment 33831: patch with changelog
https://bugs.webkit.org/attachment.cgi?id=33831&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Awesome!  Thanks for the patch.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:56:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:56:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27847] bugzilla-tool
 post-commits trunk..head errors out : [Attachment 33832] First attempt
In-Reply-To: <bug-27847-0@https.bugs.webkit.org/>
References: <bug-27847-0@https.bugs.webkit.org/>
Message-ID: <20090730205647.1B8B63432141@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27847: bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Attachment 33832: First attempt
https://bugs.webkit.org/attachment.cgi?id=33832&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 3 files changed, 36 insertions(+), 23 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 30 13:56:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:56:59 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment 33539] Share
 implementation of PluginView::userAgent() and userAgentStatic()
Message-ID: <20090730205659.3D9CE3432157@gamma.macosforge.org>

X-Bugzilla-Type: request
In-Reply-To: <bug-27706-0 at https.bugs.webkit.org/>
References: <bug-27706-0 at https.bugs.webkit.org/>

Anders Carlsson <andersca at apple.com> has granted Tor Arne Vestb?
<vestbo at webkit.org>'s request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33539: Share implementation of PluginView::userAgent() and
userAgentStatic()

https://bugs.webkit.org/attachment.cgi?id=33539&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
Looks great, r=me.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:57:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:57:07 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27814] Qt Port does not
 obey color style in button tag with default background : [Attachment 33833]
 Test patch associated with bug.
In-Reply-To: <bug-27814-0@https.bugs.webkit.org/>
References: <bug-27814-0@https.bugs.webkit.org/>
Message-ID: <20090730205707.44EB13432164@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27814: Qt Port does not obey color style in button tag with default
background
https://bugs.webkit.org/show_bug.cgi?id=27814

Attachment 33833: Test patch associated with bug.
https://bugs.webkit.org/attachment.cgi?id=33833&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
This patch is for the tests associated with the bug and include the following
changes to tests.

Add new test fast/forms/button-style-color.html and results in
platform/qt/fast/forms/button-style-color-expected.txt
Enable previously skipped test tables/mozilla/bugs/bug92647-2.html
Update expected result for qt in test
fast/dom/HTMLTableColElement/resize-table-using-col-width-expected

All tests denoted above pass correctly.

From bugzilla-daemon at webkit.org  Thu Jul 30 13:57:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 13:57:21 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment 33536] Join the
 various versions of PluginView::stop() into one shared implementation
In-Reply-To: <bug-27706-0@https.bugs.webkit.org/>
References: <bug-27706-0@https.bugs.webkit.org/>
Message-ID: <20090730205721.62BB13432174@gamma.macosforge.org>

Anders Carlsson <andersca at apple.com> has granted  review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33536: Join the various versions of PluginView::stop() into one
shared implementation
https://bugs.webkit.org/attachment.cgi?id=33536&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
Actually, this is OK and it's certainly better than what we have now :)

From bugzilla-daemon at webkit.org  Thu Jul 30 14:02:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:02:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27854] crash at
 WebCore::AXObjectCache::notificationPostTimerFired : [Attachment 33834]
 patch
In-Reply-To: <bug-27854-0@https.bugs.webkit.org/>
References: <bug-27854-0@https.bugs.webkit.org/>
Message-ID: <20090730210212.EB4F734321FD@gamma.macosforge.org>

chris fleizach <cfleizach at apple.com> has asked	for review:
Bug 27854: crash at WebCore::AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=27854

Attachment 33834: patch
https://bugs.webkit.org/attachment.cgi?id=33834&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:02:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:02:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33810] class ApplicationCacheHost rev3
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730210240.5777C343220F@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has denied Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33810: class ApplicationCacheHost rev3
https://bugs.webkit.org/attachment.cgi?id=33810&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/ChangeLog
...
> +	   * loader/appcache/ApplicationCacheHost.cpp: Added.
> +	   (WebCore::ApplicationCacheHost::ApplicationCacheHost):
> +	   (WebCore::ApplicationCacheHost::~ApplicationCacheHost):
> +	   (WebCore::ApplicationCacheHost::selectCacheWithoutManifest):

nit: It is encouraged to delete these lines that list functions in new
files being added.  The point, I gather, is that the function list is
most interesting when existing files are being modified.


> Index: WebCore/html/HTMLHtmlElement.cpp
...
> +    if (manifest.isNull() || manifest.isEmpty())

nit: isEmpty() is all you need since it returns true if the string is
either null or zero-length.


> Index: WebCore/loader/DocumentLoader.h
...
> +#if ENABLE(OFFLINE_WEB_APPLICATIONS)
> +	   friend class ApplicationCacheHost;  // for substitute resource
delivery
> +	   OwnPtr<ApplicationCacheHost> m_applicationCacheHost;
>  #endif

nit: Can this just be a non-pointer member variable?  It isn't lazily
allocated.


> Index: WebCore/loader/MainResourceLoader.cpp
...
> @@ -495,27 +478,15 @@ bool MainResourceLoader::load(const Reso
>  
>      m_substituteData = substituteData;
>  
> +    ResourceRequest request(r);
> +
>  #if ENABLE(OFFLINE_WEB_APPLICATIONS)
> -    // Check if this request should be loaded from the application cache
> -    if (!m_substituteData.isValid() && frameLoader()->frame()->settings() &&
frameLoader()->frame()->settings()->offlineWebApplicationCacheEnabled()) {
> -	   ASSERT(!m_applicationCache);
> -
> -	   m_applicationCache = ApplicationCacheGroup::cacheForMainRequest(r,
m_documentLoader.get());
> -
> -	   if (m_applicationCache) {
> -	       // Get the resource from the application cache. By definition,
cacheForMainRequest() returns a cache that contains the resource.
> -	       ApplicationCacheResource* resource =
m_applicationCache->resourceForRequest(r);
> -	       m_substituteData = SubstituteData(resource->data(), 
> -						
resource->response().mimeType(),
> -						
resource->response().textEncodingName(), KURL());
> -	   }
> -    }
> +    documentLoader()->applicationCacheHost()->maybeLoadMainResource(request,
m_substituteData);
>  #endif
>  
> -    ResourceRequest request(r);
>      bool defer = defersLoading();
>      if (defer) {
> -	   bool shouldLoadEmpty = shouldLoadAsEmptyDocument(r.url());
> +	   bool shouldLoadEmpty = shouldLoadAsEmptyDocument(request.url());
>	   if (shouldLoadEmpty)
>	       defer = false;
>      }


> Index: WebCore/loader/appcache/ApplicationCacheHost.h
...
> +#include "DOMApplicationCache.h"
> +#include "KURL.h"

nit: you can probably get away with just forward declaring KURL, right?


> Index: WebCore/loader/appcache/DOMApplicationCache.cpp

> +    switch (eventType) {
> +	   case CHECKING_EVENT:
> +	       return eventNames().checkingEvent;
> +	   case ERROR_EVENT:
> +	       return eventNames().errorEvent;
> +	   case NOUPDATE_EVENT:
> +	       return eventNames().noupdateEvent;
> +	   case DOWNLOADING_EVENT:
> +	       return eventNames().downloadingEvent;
> +	   case PROGRESS_EVENT:
> +	       return eventNames().progressEvent;
> +	   case UPDATEREADY_EVENT:
> +	       return eventNames().updatereadyEvent;
> +	   case CACHED_EVENT:
> +	       return eventNames().cachedEvent;
> +	   case OBSOLETE_EVENT: 	   
> +	       return eventNames().obsoleteEvent;
> +    }
> +    ASSERT_NOT_REACHED();
> +    return eventNames().errorEvent;
>  }
>  
> +// static
> +DOMApplicationCache::EventType DOMApplicationCache::toEventType(const
AtomicString& eventName)
>  {
> +    if (eventName == eventNames().checkingEvent)
> +	   return CHECKING_EVENT;
> +    if (eventName == eventNames().errorEvent)
> +	   return ERROR_EVENT;
> +    if (eventName == eventNames().noupdateEvent)
> +	   return NOUPDATE_EVENT;
> +    if (eventName == eventNames().downloadingEvent)
> +	   return DOWNLOADING_EVENT;
> +    if (eventName == eventNames().progressEvent)
> +	   return PROGRESS_EVENT;
> +    if (eventName == eventNames().updatereadyEvent)
> +	   return UPDATEREADY_EVENT;
> +    if (eventName == eventNames().cachedEvent)
> +	   return CACHED_EVENT;
> +    if (eventName == eventNames().obsoleteEvent)
> +	   return OBSOLETE_EVENT;
> +  
> +    ASSERT_NOT_REACHED();
> +    return ERROR_EVENT;
>  }

nit: Instead of creating a new enum type, perhaps it would have been better
to just pass an AtomicString for the event name?  What does the enum buy us
over just using the event name directly?


> Index: WebCore/page/chromium/ChromeClientChromium.h

> +#if ENABLE(OFFLINE_WEB_APPLICATIONS)
> +	   // Callback invoked when the application cache fails to save a cache
object
> +	   // because storing it would grow the database file past its defined
maximum
> +	   // size or past the amount of free space on the device. 
> +	   // The chrome client would need to take some action such as evicting
some
> +	   // old caches.
> +	   virtual void reachedMaxAppCacheSize(int64_t spaceNeeded) { }
> +#endif

I don't think this change is correct or necessary.  See page/ChromeClient.h.

From bugzilla-daemon at webkit.org  Thu Jul 30 14:03:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:03:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27814] Qt Port does not obey
 color style in button tag with default background : [Attachment 33822] Code
 patch as described in bug report.
In-Reply-To: <bug-27814-0@https.bugs.webkit.org/>
References: <bug-27814-0@https.bugs.webkit.org/>
Message-ID: <20090730210319.AE8A23432237@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27814: Qt Port does not obey color style in button tag with default
background
https://bugs.webkit.org/show_bug.cgi?id=27814

Attachment 33822: Code patch as described in bug report.
https://bugs.webkit.org/attachment.cgi?id=33822&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:04:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:04:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27814] Qt Port does not obey
 color style in button tag with default background : [Attachment 33833] Test
 patch associated with bug.
In-Reply-To: <bug-27814-0@https.bugs.webkit.org/>
References: <bug-27814-0@https.bugs.webkit.org/>
Message-ID: <20090730210441.9481B343225F@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27814: Qt Port does not obey color style in button tag with default
background
https://bugs.webkit.org/show_bug.cgi?id=27814

Attachment 33833: Test patch associated with bug.
https://bugs.webkit.org/attachment.cgi?id=33833&action=review

------- Additional Comments from Adam Treat <treat at kde.org>
Next time you can combine these two.  A bug fix and the associated tests should
land together.	I'll do so when landing.

From bugzilla-daemon at webkit.org  Thu Jul 30 14:06:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:06:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27849] bugzilla-tool
 post-commits obsoletes its own work :( : [Attachment 33837] Simple fix
In-Reply-To: <bug-27849-0@https.bugs.webkit.org/>
References: <bug-27849-0@https.bugs.webkit.org/>
Message-ID: <20090730210609.2E68034322BE@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27849: bugzilla-tool post-commits obsoletes its own work :(
https://bugs.webkit.org/show_bug.cgi?id=27849

Attachment 33837: Simple fix
https://bugs.webkit.org/attachment.cgi?id=33837&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>

---
 2 files changed, 12 insertions(+), 1 deletions(-)

From bugzilla-daemon at webkit.org  Thu Jul 30 14:14:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:14:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27855] Delay starting
 plug-ins : [Attachment 33838] Patch to add this
In-Reply-To: <bug-27855-0@https.bugs.webkit.org/>
References: <bug-27855-0@https.bugs.webkit.org/>
Message-ID: <20090730211413.E61E6343238A@gamma.macosforge.org>

Jon Honeycutt <jhoneycutt at apple.com> has asked	for review:
Bug 27855: Delay starting plug-ins
https://bugs.webkit.org/show_bug.cgi?id=27855

Attachment 33838: Patch to add this
https://bugs.webkit.org/attachment.cgi?id=33838&action=review

------- Additional Comments from Jon Honeycutt <jhoneycutt at apple.com>
Would like a way to delay starting plug-ins. This could be used to leave
plug-ins unstarted until they are brought onto the screen.

From bugzilla-daemon at webkit.org  Thu Jul 30 14:41:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:41:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27856] Animation with a
 timing function property in a keyframe eats CPU : [Attachment 33840] Patch,
 changelog
In-Reply-To: <bug-27856-0@https.bugs.webkit.org/>
References: <bug-27856-0@https.bugs.webkit.org/>
Message-ID: <20090730214111.E4B8F3432620@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27856: Animation with a timing function property in a keyframe eats CPU
https://bugs.webkit.org/show_bug.cgi?id=27856

Attachment 33840: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=33840&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:41:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:41:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27853] Make
 Chrome::requestGeolocationPermissionForFrame() into a synchronous call :
 [Attachment 33841] patch to implement bug fix
In-Reply-To: <bug-27853-0@https.bugs.webkit.org/>
References: <bug-27853-0@https.bugs.webkit.org/>
Message-ID: <20090730214142.2E03D343263B@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27853: Make Chrome::requestGeolocationPermissionForFrame() into a
synchronous call
https://bugs.webkit.org/show_bug.cgi?id=27853

Attachment 33841: patch to implement bug fix
https://bugs.webkit.org/attachment.cgi?id=33841&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:43:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:43:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27857] clean up
 build-webkit to use less copy/paste code and remove unneeded SVG warning :
 [Attachment 33842] Patch v1
In-Reply-To: <bug-27857-0@https.bugs.webkit.org/>
References: <bug-27857-0@https.bugs.webkit.org/>
Message-ID: <20090730214302.3FC933432662@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has asked  for review:
Bug 27857: clean up build-webkit to use less copy/paste code and remove
unneeded SVG warning
https://bugs.webkit.org/show_bug.cgi?id=27857

Attachment 33842: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33842&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:46:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:46:56 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27856] Animation with a
 timing function property in a keyframe eats CPU : [Attachment 33840] Patch,
 changelog
In-Reply-To: <bug-27856-0@https.bugs.webkit.org/>
References: <bug-27856-0@https.bugs.webkit.org/>
Message-ID: <20090730214656.ECD6234326DE@gamma.macosforge.org>

mitz at webkit.org has granted Simon Fraser (smfr) <simon.fraser at apple.com>'s
request for review:
Bug 27856: Animation with a timing function property in a keyframe eats CPU
https://bugs.webkit.org/show_bug.cgi?id=27856

Attachment 33840: Patch, changelog
https://bugs.webkit.org/attachment.cgi?id=33840&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:47:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:47:11 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27854] crash at
 WebCore::AXObjectCache::notificationPostTimerFired : [Attachment 33834]
 patch
In-Reply-To: <bug-27854-0@https.bugs.webkit.org/>
References: <bug-27854-0@https.bugs.webkit.org/>
Message-ID: <20090730214711.A0A4D34326FA@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 27854: crash at WebCore::AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=27854

Attachment 33834: patch
https://bugs.webkit.org/attachment.cgi?id=33834&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 14:53:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 14:53:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27849] bugzilla-tool
 post-commits obsoletes its own work :( : [Attachment 33837] Simple fix
In-Reply-To: <bug-27849-0@https.bugs.webkit.org/>
References: <bug-27849-0@https.bugs.webkit.org/>
Message-ID: <20090730215303.37B3F34327FD@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 27849: bugzilla-tool post-commits obsoletes its own work :(
https://bugs.webkit.org/show_bug.cgi?id=27849

Attachment 33837: Simple fix
https://bugs.webkit.org/attachment.cgi?id=33837&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me if this fixes the bug.

Why does add() work better than update() here (from a Python language
perspective)?

From bugzilla-daemon at webkit.org  Thu Jul 30 15:03:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 15:03:03 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27847] bugzilla-tool
 post-commits trunk..head errors out : [Attachment 33832] First attempt
In-Reply-To: <bug-27847-0@https.bugs.webkit.org/>
References: <bug-27847-0@https.bugs.webkit.org/>
Message-ID: <20090730220303.6EDC53432A2E@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted Eric Seidel
<eric at webkit.org>'s request for review:
Bug 27847: bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Attachment 33832: First attempt
https://bugs.webkit.org/attachment.cgi?id=33832&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>

> +    # This function supports the following argument formats:
> +    # no args : rev-list trunk..HEAD
> +    # A..B	 : rev-list A..B
> +    # A...B	 : error!
> +    # A B	 : [A, B]  (different from git diff, which would use "rev-list
A..B")
> +    def commit_ids_from_commitish_arguments(self, args):
> +	   if not len(args):
> +	       args.append('trunk..HEAD')
> +
> +	   commit_ids = []
> +	   for commitish in args:
> +	       if '...' in commitish:
> +		   error("'...' is not supported (found in %s). Did you mean
'..'?" % commitish)
> +	       elif '..' in commitish:
> +		   commit_ids += self.run_command(['git', 'rev-list',
commitish]).splitlines()
> +	       else:
> +		   commit_ids.append(commitish)
> +	   return commit_ids

I think individual commits should still be passed through git rev-parse:

> +	       else:
> +		   commit_ids += self.run_command(['git', 'rev-parse',
'--revs-only', commitish]).splitlines()

This allows you to specify a branch name or a tag name that turns into a single
commit.

r=me with this change. Everything else looks good.

From bugzilla-daemon at webkit.org  Thu Jul 30 15:16:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 15:16:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27706] WebCore NPAPI
 implementations should share more code : [Attachment 33537] Unregister
 plugin from PluginMainThreadScheduler if NPP_New fails
Message-ID: <20090730221608.B74913432C19@gamma.macosforge.org>

X-Bugzilla-Type: request
In-Reply-To: <bug-27706-0 at https.bugs.webkit.org/>
References: <bug-27706-0 at https.bugs.webkit.org/>

Anders Carlsson <andersca at apple.com> has granted Tor Arne Vestb?
<vestbo at webkit.org>'s request for review:
Bug 27706: WebCore NPAPI implementations should share more code
https://bugs.webkit.org/show_bug.cgi?id=27706

Attachment 33537: Unregister plugin from PluginMainThreadScheduler if NPP_New
fails

https://bugs.webkit.org/attachment.cgi?id=33537&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
r=me

From bugzilla-daemon at webkit.org  Thu Jul 30 15:17:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 15:17:48 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33843] class ApplicationCacheHost rev3
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730221748.029C93432C53@gamma.macosforge.org>

Michael Nordman <michaeln at google.com> has asked  for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33843: class ApplicationCacheHost rev3
https://bugs.webkit.org/attachment.cgi?id=33843&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 15:40:55 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 15:40:55 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27860] Release anchor
 scroll lock when a scroll is handled by a Node : [Attachment 33845] patch
In-Reply-To: <bug-27860-0@https.bugs.webkit.org/>
References: <bug-27860-0@https.bugs.webkit.org/>
Message-ID: <20090730224055.336E43432F1F@gamma.macosforge.org>

Nate Chapin <japhet at chromium.org> has asked  for review:
Bug 27860: Release anchor scroll lock when a scroll is handled by a Node
https://bugs.webkit.org/show_bug.cgi?id=27860

Attachment 33845: patch
https://bugs.webkit.org/attachment.cgi?id=33845&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 15:44:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 15:44:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27859] [chromium] Implement
 media slider for chromium : [Attachment 33846] patch
In-Reply-To: <bug-27859-0@https.bugs.webkit.org/>
References: <bug-27859-0@https.bugs.webkit.org/>
Message-ID: <20090730224403.0409D3432F70@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27859: [chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859

Attachment 33846: patch
https://bugs.webkit.org/attachment.cgi?id=33846&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 15:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 15:46:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27821] ApplicationCacheHost
 refactoring : [Attachment 33843] class ApplicationCacheHost rev4
In-Reply-To: <bug-27821-0@https.bugs.webkit.org/>
References: <bug-27821-0@https.bugs.webkit.org/>
Message-ID: <20090730224607.3BEFE3432FA8@gamma.macosforge.org>

Darin Fisher (:fishd, Google) <fishd at chromium.org> has granted Michael Nordman
<michaeln at google.com>'s request for review:
Bug 27821: ApplicationCacheHost refactoring
https://bugs.webkit.org/show_bug.cgi?id=27821

Attachment 33843: class ApplicationCacheHost rev4
https://bugs.webkit.org/attachment.cgi?id=33843&action=review

------- Additional Comments from Darin Fisher (:fishd, Google)
<fishd at chromium.org>
> Index: WebCore/loader/appcache/DOMApplicationCache.cpp
...
> +    switch (eventType) {
> +	   case CHECKING_EVENT:
> +	       return eventNames().checkingEvent;
> +	   case ERROR_EVENT:

nit: I forgot to mention that the style guide says to not indent
the cases.  I'll take care of this before committing the patch.

R=me

From bugzilla-daemon at webkit.org  Thu Jul 30 16:00:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 16:00:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27861] [Chromium] remove
 ChromeClientChromium::setToolTip() : [Attachment 33847] patch
In-Reply-To: <bug-27861-0@https.bugs.webkit.org/>
References: <bug-27861-0@https.bugs.webkit.org/>
Message-ID: <20090730230013.6839E34330D0@gamma.macosforge.org>

Xiaomei Ji <xji at chromium.org> has asked  for review:
Bug 27861: [Chromium] remove ChromeClientChromium::setToolTip()
https://bugs.webkit.org/show_bug.cgi?id=27861

Attachment 33847: patch
https://bugs.webkit.org/attachment.cgi?id=33847&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 16:04:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 16:04:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27861] [Chromium] remove
 ChromeClientChromium::setToolTip() : [Attachment 33847] patch
In-Reply-To: <bug-27861-0@https.bugs.webkit.org/>
References: <bug-27861-0@https.bugs.webkit.org/>
Message-ID: <20090730230444.49E223433138@gamma.macosforge.org>

mitz at webkit.org has granted Xiaomei Ji <xji at chromium.org>'s request for review:
Bug 27861: [Chromium] remove ChromeClientChromium::setToolTip()
https://bugs.webkit.org/show_bug.cgi?id=27861

Attachment 33847: patch
https://bugs.webkit.org/attachment.cgi?id=33847&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 16:14:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 16:14:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27862] [V8] DataGrid
 guard's #endif needs to have // before ENABLE(DATAGRID) : [Attachment
 33848] patch
In-Reply-To: <bug-27862-0@https.bugs.webkit.org/>
References: <bug-27862-0@https.bugs.webkit.org/>
Message-ID: <20090730231419.866513433221@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27862: [V8] DataGrid guard's #endif needs to have // before
ENABLE(DATAGRID)
https://bugs.webkit.org/show_bug.cgi?id=27862

Attachment 33848: patch
https://bugs.webkit.org/attachment.cgi?id=33848&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 16:15:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 16:15:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27862] [V8] DataGrid guard's
 #endif needs to have // before ENABLE(DATAGRID) : [Attachment 33848] patch
In-Reply-To: <bug-27862-0@https.bugs.webkit.org/>
References: <bug-27862-0@https.bugs.webkit.org/>
Message-ID: <20090730231516.F10903433241@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27862: [V8] DataGrid guard's #endif needs to have // before
ENABLE(DATAGRID)
https://bugs.webkit.org/show_bug.cgi?id=27862

Attachment 33848: patch
https://bugs.webkit.org/attachment.cgi?id=33848&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 16:57:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 16:57:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27857] clean up build-webkit
 to use less copy/paste code and remove unneeded SVG warning : [Attachment
 33842] Patch v1
In-Reply-To: <bug-27857-0@https.bugs.webkit.org/>
References: <bug-27857-0@https.bugs.webkit.org/>
Message-ID: <20090730235739.5D913343358A@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 27857: clean up build-webkit to use less copy/paste code and remove
unneeded SVG warning
https://bugs.webkit.org/show_bug.cgi?id=27857

Attachment 33842: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33842&action=review

------- Additional Comments from David Levin <levin at chromium.org>
I don't normally r+ perl, but this one is simple enough for me to verify.

From bugzilla-daemon at webkit.org  Thu Jul 30 17:08:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 17:08:54 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27792] [GTK]
 new-window-policy-decision-requested provides no information about the
 target frame : [Attachment 33779] Updated patch 2
In-Reply-To: <bug-27792-0@https.bugs.webkit.org/>
References: <bug-27792-0@https.bugs.webkit.org/>
Message-ID: <20090731000854.7EFEE34336AE@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Martin Robinson
<martin.james.robinson at gmail.com>'s request for review:
Bug 27792: [GTK] new-window-policy-decision-requested provides no information
about the target frame
https://bugs.webkit.org/show_bug.cgi?id=27792

Attachment 33779: Updated patch 2
https://bugs.webkit.org/attachment.cgi?id=33779&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
> +    g_object_class_install_property(objectClass, PROP_TARGET_FRAME,
> +				       g_param_spec_string("target-frame",
> +							   _("Target frame"),
> +							   _("The target frame
for the navigation"),
> +							   "",
> +							  
(GParamFlags)(WEBKIT_PARAM_READWRITE | G_PARAM_CONSTRUCT_ONLY)));

This should be initialized to NULL.

r=me. I'll fixed the nit prior to landing.

From bugzilla-daemon at webkit.org  Thu Jul 30 17:41:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 17:41:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 23522] Use checked casts for
 render tree : [Attachment 33821] Next step: Includes toRenderTable*
In-Reply-To: <bug-23522-0@https.bugs.webkit.org/>
References: <bug-23522-0@https.bugs.webkit.org/>
Message-ID: <20090731004141.0D4DF343395D@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 23522: Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Attachment 33821: Next step: Includes toRenderTable*
https://bugs.webkit.org/attachment.cgi?id=33821&action=review

------- Additional Comments from David Levin <levin at chromium.org>

> Index: WebCore/page/Frame.cpp
> ===================================================================
>      if (cellRenderer && cellRenderer->isTableCell()) {
> -	   RenderTableCell* cellAboveRenderer =
cellRenderer->table()->cellAbove(cellRenderer);
> +	   RenderTableCell* cellAboveRenderer =
toRenderTableCell(cellRenderer)->table()->cellAbove(toRenderTableCell(cellRende
rer));

Although it is no runtime expense, it is harder to read with two
"toRenderTableCell(cellRenderer)" in the same line.

Consider a local variable to avoid this.  For example,
	RenderTableCell* tableCell = toRenderTableCell(cellRenderer);
	RenderTableCell* cellAboveRenderer =
tableCell->table()->cellAbove(tableCell);


> Index: WebCore/page/mac/FrameMac.mm
> ===================================================================
>      if (cellRenderer && cellRenderer->isTableCell()) {
> -	   RenderTableCell* cellAboveRenderer =
cellRenderer->table()->cellAbove(cellRenderer);
> +	   RenderTableCell* cellAboveRenderer =
toRenderTableCell(cellRenderer)->table()->cellAbove(toRenderTableCell(cellRende
rer));

Same comment as before "It is harder to read with two
"toRenderTableCell(cellRenderer)" in the same line...."


> Index: WebCore/rendering/RenderTable.cpp
> ===================================================================

47	RenderTable::RenderTable(Node* node)
...
53	    , m_tableLayout(0)

This initialization may be deleted now.


> Index: WebCore/rendering/RenderTable.h
> ===================================================================
> +    virtual void paintMask(PaintInfo& paintInfo, int tx, int ty);

"paintInfo" param name is redundant.  (It existed before due to the move it
looks like a new line so it is a good time to remove this.)

> +inline RenderTable* toRenderTable(RenderObject* o)
> +inline const RenderTable* toRenderTable(const RenderObject* o)

Consider using renderObject instead of o (so that we have full words for the
variable names).


> Index: WebCore/rendering/RenderTableCell.h
> ===================================================================
> +inline RenderTableCell* toRenderTableCell(RenderObject* o)
> +inline const RenderTableCell* toRenderTableCell(const RenderObject* o)

Consider using renderObject instead of o.


> Index: WebCore/rendering/RenderTableCol.h
> ===================================================================
> +    void setSpan(int s) { m_span = s; }

Consider using span instead of s.


> +inline RenderTableCol* toRenderTableCol(RenderObject* o)
> +inline const RenderTableCol* toRenderTableCol(const RenderObject* o)

Consider using renderObject instead of o.



> Index: WebCore/rendering/RenderTableRow.h
> ===================================================================

> +inline RenderTableRow* toRenderTableRow(RenderObject* o)
> +inline const RenderTableRow* toRenderTableRow(const RenderObject* o)

Consider using renderObject instead of o.



> Index: WebCore/rendering/RenderTableSection.h
> ===================================================================
> +inline RenderTableSection* toRenderTableSection(RenderObject* o)
> +inline const RenderTableSection* toRenderTableSection(const RenderObject* o)


Consider using renderObject instead of o.

From bugzilla-daemon at webkit.org  Thu Jul 30 17:41:59 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 17:41:59 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27858] selectionHasStyle
 doesn't handle text-specific properties properly : [Attachment 33849] fixes
 the bug, large because converts a pixel test to a dumpastext.
In-Reply-To: <bug-27858-0@https.bugs.webkit.org/>
References: <bug-27858-0@https.bugs.webkit.org/>
Message-ID: <20090731004159.C07873433992@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27858: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Attachment 33849: fixes the bug, large because converts a pixel test to a
dumpastext.
https://bugs.webkit.org/attachment.cgi?id=33849&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 17:48:43 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 17:48:43 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27863] Consolidate
 GeoLocation code to send positions and errors : [Attachment 33850] Patch
 implementing the change
In-Reply-To: <bug-27863-0@https.bugs.webkit.org/>
References: <bug-27863-0@https.bugs.webkit.org/>
Message-ID: <20090731004843.97C373433A0B@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27863: Consolidate GeoLocation code to send positions and errors
https://bugs.webkit.org/show_bug.cgi?id=27863

Attachment 33850: Patch implementing the change
https://bugs.webkit.org/attachment.cgi?id=33850&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 18:23:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:23:13 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27418] [V8] Factor
 V8ContextFactory out of V8Proxy : [Attachment 33072] patch
In-Reply-To: <bug-27418-0@https.bugs.webkit.org/>
References: <bug-27418-0@https.bugs.webkit.org/>
Message-ID: <20090731012313.74D033433D13@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled Adam Barth <abarth at webkit.org>'s
request for review:
Bug 27418: [V8] Factor V8ContextFactory out of V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=27418

Attachment 33072: patch
https://bugs.webkit.org/attachment.cgi?id=33072&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Clearing the review flag because this patch no longer applies cleanly to TOT.

From bugzilla-daemon at webkit.org  Thu Jul 30 18:24:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:24:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27828] Title attribute is
 not respected on option elements : [Attachment 33851] Patch for the Mac
 part of this
In-Reply-To: <bug-27828-0@https.bugs.webkit.org/>
References: <bug-27828-0@https.bugs.webkit.org/>
Message-ID: <20090731012430.CAD503433D5C@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has asked  for review:
Bug 27828: Title attribute is not respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=27828

Attachment 33851: Patch for the Mac part of this
https://bugs.webkit.org/attachment.cgi?id=33851&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
I'll clone this bug to track fixing this for other platforms after this is
landed.

From bugzilla-daemon at webkit.org  Thu Jul 30 18:26:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:26:38 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27828] Title attribute is not
 respected on option elements : [Attachment 33851] Patch for the Mac part of
 this
In-Reply-To: <bug-27828-0@https.bugs.webkit.org/>
References: <bug-27828-0@https.bugs.webkit.org/>
Message-ID: <20090731012638.8B60A3433DAC@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Mark Rowe (bdash)
<mrowe at apple.com>'s request for review:
Bug 27828: Title attribute is not respected on option elements
https://bugs.webkit.org/show_bug.cgi?id=27828

Attachment 33851: Patch for the Mac part of this
https://bugs.webkit.org/attachment.cgi?id=33851&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 18:29:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:29:29 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26993]
 Geolocation::requestPermission() : [Attachment 33659] the patch
In-Reply-To: <bug-26993-0@https.bugs.webkit.org/>
References: <bug-26993-0@https.bugs.webkit.org/>
Message-ID: <20090731012929.EC26B3433E03@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Yong Li <yong.li at torchmobile.com>'s
request for review:
Bug 26993: Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993

Attachment 33659: the patch
https://bugs.webkit.org/attachment.cgi?id=33659&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Let me know if you figure out a way to test this.

From bugzilla-daemon at webkit.org  Thu Jul 30 18:38:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:38:21 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27858] selectionHasStyle
 doesn't handle text-specific properties properly : [Attachment 33852] fixed
 per comment on IRC
In-Reply-To: <bug-27858-0@https.bugs.webkit.org/>
References: <bug-27858-0@https.bugs.webkit.org/>
Message-ID: <20090731013821.D15853433F52@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27858: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Attachment 33852: fixed per comment on IRC
https://bugs.webkit.org/attachment.cgi?id=33852&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 18:38:21 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:38:21 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27858] selectionHasStyle
 doesn't handle text-specific properties properly : [Attachment 33849] fixes
 the bug, large because converts a pixel test to a dumpastext.
In-Reply-To: <bug-27858-0@https.bugs.webkit.org/>
References: <bug-27858-0@https.bugs.webkit.org/>
Message-ID: <20090731013821.AAA493433F50@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27858: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Attachment 33849: fixes the bug, large because converts a pixel test to a
dumpastext.
https://bugs.webkit.org/attachment.cgi?id=33849&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 18:39:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:39:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27859] [chromium] Implement
 media slider for chromium : [Attachment 33846] patch
In-Reply-To: <bug-27859-0@https.bugs.webkit.org/>
References: <bug-27859-0@https.bugs.webkit.org/>
Message-ID: <20090731013949.28F973433F7F@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has canceled Hin-Chung Lam
<hclam at google.com>'s request for review:
Bug 27859: [chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859

Attachment 33846: patch
https://bugs.webkit.org/attachment.cgi?id=33846&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 18:42:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 18:42:11 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27858] selectionHasStyle
 doesn't handle text-specific properties properly : [Attachment 33852] fixed
 per comment on IRC
In-Reply-To: <bug-27858-0@https.bugs.webkit.org/>
References: <bug-27858-0@https.bugs.webkit.org/>
Message-ID: <20090731014211.8FADD3433FC3@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27858: selectionHasStyle doesn't handle text-specific properties properly
https://bugs.webkit.org/show_bug.cgi?id=27858

Attachment 33852: fixed per comment on IRC
https://bugs.webkit.org/attachment.cgi?id=33852&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
will split into two patches.

From bugzilla-daemon at webkit.org  Thu Jul 30 19:03:26 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 19:03:26 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33853] cleans up
 selectionHasStyle and selectionStartHasStyle
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090731020326.13B3D34341A7@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33853: cleans up selectionHasStyle and selectionStartHasStyle
https://bugs.webkit.org/attachment.cgi?id=33853&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 19:04:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 19:04:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33854] deleted irrelevant
 tests.
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090731020453.3DFF534341D4@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33854: deleted irrelevant tests.
https://bugs.webkit.org/attachment.cgi?id=33854&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 19:04:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 19:04:53 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33853] cleans up
 selectionHasStyle and selectionStartHasStyle
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090731020453.1F00434341D2@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33853: cleans up selectionHasStyle and selectionStartHasStyle
https://bugs.webkit.org/attachment.cgi?id=33853&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 19:10:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 19:10:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33854] deleted irrelevant
 tests.
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090731021014.BFB773434235@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33854: deleted irrelevant tests.
https://bugs.webkit.org/attachment.cgi?id=33854&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 19:10:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 19:10:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33855] fixed typo
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090731021014.E833B3434237@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33855: fixed typo
https://bugs.webkit.org/attachment.cgi?id=33855&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 20:58:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 20:58:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33721] Fixed whitespace
 issue
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090731035812.80B0534349FF@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied Christian Plesner Hansen
<christian.plesner.hansen at gmail.com>'s request for review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33721: Fixed whitespace issue
https://bugs.webkit.org/attachment.cgi?id=33721&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things to address and this can be done.

Please get the patch to be based from WebKit or else it will be harder to
commit this for you (i.e. in this case, all path for files below should be
prefixed with WebCore/).

> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 46477)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,21 @@
> +2009-07-28  Christian Plesner Hansen  <christian.plesner.hansen at gmail.com>
> +
> +    Reviewed by NOBODY (OOPS!).
> +
Add title and bug link like this:

[v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762


> +    Cache atomic strings in externalized strings the first time
> +    the string is converted.  Added V8Custom IDL annotation for
> +    hinting that converting a string directly to an atomic string is a
> +    good idea.

Get rid of TABs in the changelog.



> Index: bindings/v8/V8Binding.cpp
> +    explicit WebCoreStringResource(const AtomicString& string)
> +	   : m_impl(string.impl()), m_atomicImpl(string.impl())
Please format like this:
    explicit WebCoreStringResource(const AtomicString& string)
	: m_impl(string.impl())
	, m_atomicImpl(string.impl())




> +    AtomicString atomicString()
> +    {
> +	   ASSERT(WTF::isMainThread());
> +	   if (m_atomicImpl.isNull())
> +	       m_atomicImpl = AtomicString(m_impl);

It seems that you should adjust the external memory here:
	if (m_atomicImpl.isNull()) {
	    m_atomicImpl = AtomicString(m_impl);
	    if (!m_impl.inTable())
		v8::V8::AdjustAmountOfExternalAllocatedMemory(2 * length());
	}

And change the destructor like this:

    virtual ~WebCoreStringResource()
    {
	ASSERT(WTF::isMainThread());
	int reducedExternalMemory = -2 * length();
	if (!m_impl.inTable())
	    reducedExternalMemory *= 2;
	v8::V8::AdjustAmountOfExternalAllocatedMemory(reducedExternalMemory);
    }

>  private:
>      // A shallow copy of the string. Keeps the string buffer alive until the
V8 engine garbage collects it.
>      String m_impl;
> +    // If this string is atomic or has been made atomic earlier the
> +    // atomic string is held here.  In the case where the string starts

Please only put one space after periods.

> +    // off non-atomic and becomes atomic later it is necessary to keep
> +    // the original string alive because v8 may keep derived pointers
> +    // into that string.
> +    AtomicString m_atomicImpl;

Why is it m_atomicImpl instead of just m_atomicString?


> @@ -130,13 +151,34 @@ String v8ValueToWebCoreString(v8::Handle
>  
>  AtomicString v8StringToAtomicWebCoreString(v8::Handle<v8::String> v8String)
>  {
> +    WebCoreStringResource* stringResource =
static_cast<WebCoreStringResource*>(v8String->GetExternalStringResource());
> +    if (stringResource)
> +	   return stringResource->atomicString();
> +
> +    int length = v8String->Length();
> +    if (!length) {
> +	   // Avoid trying to morph empty strings, as they do not have enough
room to contain the external reference.
> +	   return StringImpl::empty();
> +    }
> +
> +    UChar* buffer;
> +    String plainResult = String::createUninitialized(length, buffer);
> +    v8String->Write(reinterpret_cast<uint16_t*>(buffer), 0, length);
> +    AtomicString result(plainResult);
> +
> +    WebCoreStringResource* resource = new WebCoreStringResource(result);
> +    if (!v8String->MakeExternal(resource)) {
> +	   // In case of a failure delete the external resource as it was not
used.
> +	   delete resource;
> +    }
> +    return result;

This duplicates a fair amount of code from v8StringToWebCoreString. Can you
factor the code to avoid this?

btw, if you create a new function (or add to an existing function) and want a
"bool" parameter, please make it an enum instead.

From bugzilla-daemon at webkit.org  Thu Jul 30 21:59:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 21:59:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27866] [Qt] Initialize
 HTML5 Application Cache for QtWebKit to a sensible default : [Attachment
 33856] proposed patch
In-Reply-To: <bug-27866-0@https.bugs.webkit.org/>
References: <bug-27866-0@https.bugs.webkit.org/>
Message-ID: <20090731045956.E88323434DEC@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27866: [Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible
default
https://bugs.webkit.org/show_bug.cgi?id=27866

Attachment 33856: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33856&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 22:25:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 22:25:57 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 22910] Rewrite the
 ctiTrampoline for x86-64,
 so that we don't need to pass all those zeros! : [Attachment 33857] Patch
 from John McCall.
In-Reply-To: <bug-22910-0@https.bugs.webkit.org/>
References: <bug-22910-0@https.bugs.webkit.org/>
Message-ID: <20090731052557.68A6E3434FEA@gamma.macosforge.org>

Gavin Barraclough <barraclough at apple.com> has granted  review:
Bug 22910: Rewrite the ctiTrampoline for x86-64, so that we don't need to pass
all those zeros!
https://bugs.webkit.org/show_bug.cgi?id=22910

Attachment 33857: Patch from John McCall.
https://bugs.webkit.org/attachment.cgi?id=33857&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 23:28:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 23:28:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20534] DumpRenderTree needs
 a way to override settings on a per-test basis : [Attachment 33859] Patch
 with changes after review
In-Reply-To: <bug-20534-0@https.bugs.webkit.org/>
References: <bug-20534-0@https.bugs.webkit.org/>
Message-ID: <20090731062801.63AFB34355B6@gamma.macosforge.org>

Dmitry Titov <dimich at chromium.org> has asked  for review:
Bug 20534: DumpRenderTree needs a way to override settings on a per-test basis
https://bugs.webkit.org/show_bug.cgi?id=20534

Attachment 33859: Patch with changes after review
https://bugs.webkit.org/attachment.cgi?id=33859&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 23:44:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 23:44:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27868]
 http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit,
 works in others : [Attachment 33860] Fix + Layout Test
In-Reply-To: <bug-27868-0@https.bugs.webkit.org/>
References: <bug-27868-0@https.bugs.webkit.org/>
Message-ID: <20090731064429.CAB1334356F8@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27868: http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit,
works in others
https://bugs.webkit.org/show_bug.cgi?id=27868

Attachment 33860: Fix + Layout Test
https://bugs.webkit.org/attachment.cgi?id=33860&action=review

From bugzilla-daemon at webkit.org  Thu Jul 30 23:48:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 23:48:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27868]
 http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit,
 works in others : [Attachment 33860] Fix + Layout Test
In-Reply-To: <bug-27868-0@https.bugs.webkit.org/>
References: <bug-27868-0@https.bugs.webkit.org/>
Message-ID: <20090731064847.07D313435758@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 27868: http://www.ruthhuntcandy.com/ goes into infinite refresh in WebKit,
works in others
https://bugs.webkit.org/show_bug.cgi?id=27868

Attachment 33860: Fix + Layout Test
https://bugs.webkit.org/attachment.cgi?id=33860&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
> Index: WebCore/platform/network/HTTPParsers.cpp
> ===================================================================
> --- WebCore/platform/network/HTTPParsers.cpp	(revision 46514)
> +++ WebCore/platform/network/HTTPParsers.cpp	(working copy)
> @@ -100,6 +100,12 @@ bool parseHTTPRefresh(const String& refr
>		   if (refresh[urlEndPos] == quotationMark)
>		       break;
>	       }
> +	       
> +	       // https://bugs.webkit.org/show_bug.cgi?id=27868
> +	       // Sometimes there is no closing quote for the end of the URL
even though there was an opening quote.
> +	       // All of the other browsers handle this case.
> +	       if (urlEndPos == urlStartPos)
> +		   urlEndPos = len;
>	   }

The comment could be a little clearer about what it is we do to handle the
stray quote (eg, skip over it).  I had to read back up in the code to work out
how this code related to the quote at all.

r=me

From bugzilla-daemon at webkit.org  Thu Jul 30 23:58:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Thu, 30 Jul 2009 23:58:02 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 25415] [GTK][ATK] Please
 implement support for get_text_at_offset : [Attachment 33565]
 dontcachelayout.patch
In-Reply-To: <bug-25415-0@https.bugs.webkit.org/>
References: <bug-25415-0@https.bugs.webkit.org/>
Message-ID: <20090731065802.5FE15343585D@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has canceled  review:
Bug 25415: [GTK][ATK] Please implement support for get_text_at_offset
https://bugs.webkit.org/show_bug.cgi?id=25415

Attachment 33565: dontcachelayout.patch
https://bugs.webkit.org/attachment.cgi?id=33565&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Clearing review flag as this patch was already committed.

From bugzilla-daemon at webkit.org  Fri Jul 31 00:32:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 00:32:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27869] strict-aliasing
 warnings in JSFunction.h : [Attachment 33861] aliasing.patch
In-Reply-To: <bug-27869-0@https.bugs.webkit.org/>
References: <bug-27869-0@https.bugs.webkit.org/>
Message-ID: <20090731073227.5B54F3435B5A@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has asked  for review:
Bug 27869: strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869

Attachment 33861: aliasing.patch
https://bugs.webkit.org/attachment.cgi?id=33861&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
GCC gives me the following warnings when compiling with JSFunction.h:

In file included from ../../JavaScriptCore/runtime/JSFunction.cpp:27,
		 from ../../JavaScriptCore/AllInOneFile.cpp:36:
../../JavaScriptCore/runtime/JSFunction.h: In member function ?JSC::JSValue (*
JSC::JSFunction::nativeFunction())(JSC::ExecState*, JSC::JSObject*,
JSC::JSValue, const JSC::ArgList&)?:
../../JavaScriptCore/runtime/JSFunction.h:87: warning: dereferencing
type-punned pointer will break strict-aliasing rules
../../JavaScriptCore/runtime/JSFunction.h: In member function ?JSC::ScopeChain&
JSC::JSFunction::scopeChain()?:
../../JavaScriptCore/runtime/JSFunction.h:104: warning: dereferencing
type-punned pointer will break strict-aliasing rules
../../JavaScriptCore/runtime/JSFunction.h: In member function ?void
JSC::JSFunction::setScopeChain(const JSC::ScopeChain&)?:
../../JavaScriptCore/runtime/JSFunction.h:119: warning: dereferencing
type-punned pointer will break strict-aliasing rules
../../JavaScriptCore/runtime/JSFunction.h: In member function ?void
JSC::JSFunction::setNativeFunction(JSC::JSValue (*)(JSC::ExecState*,
JSC::JSObject*, JSC::JSValue, const JSC::ArgList&))?:
../../JavaScriptCore/runtime/JSFunction.h:123: warning: dereferencing
type-punned pointer will break strict-aliasing rules

The problem is that we are accessing a char array as NativeFunction* and
ScopeChain*, which GCC deems to be incompatible pointers. Attached is the usual
trick-solution for this, which is to use a union type and do all memory access
through there. This was done with the help of Maciej on IRC, and he also
suggested that we could do further cleanups here, so I'm attaching my current
patch for discussion.

From bugzilla-daemon at webkit.org  Fri Jul 31 01:19:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 01:19:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27851] Fix compiler warning :
 [Attachment 33803] bmpwarning.patch
In-Reply-To: <bug-27851-0@https.bugs.webkit.org/>
References: <bug-27851-0@https.bugs.webkit.org/>
Message-ID: <20090731081949.A8B753435F70@gamma.macosforge.org>

Mark Rowe (bdash) <mrowe at apple.com> has granted Xan Lopez
<xan.lopez at gmail.com>'s request for review:
Bug 27851: Fix compiler warning
https://bugs.webkit.org/show_bug.cgi?id=27851

Attachment 33803: bmpwarning.patch
https://bugs.webkit.org/attachment.cgi?id=33803&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 02:21:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 02:21:27 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27756] [HTML5][Forms] Part
 2 of datalist&list: Support for HTMLInputElement::list and
 HTMLInputElement::selectedOption : [Attachment 33863] Proposed patch
 (rev.3)
In-Reply-To: <bug-27756-0@https.bugs.webkit.org/>
References: <bug-27756-0@https.bugs.webkit.org/>
Message-ID: <20090731092127.C26853436496@gamma.macosforge.org>

TAMURA, Kent <tkent at chromium.org> has asked  for review:
Bug 27756: [HTML5][Forms] Part 2 of datalist&list: Support for
HTMLInputElement::list and HTMLInputElement::selectedOption
https://bugs.webkit.org/show_bug.cgi?id=27756

Attachment 33863: Proposed patch (rev.3)
https://bugs.webkit.org/attachment.cgi?id=33863&action=review

------- Additional Comments from TAMURA, Kent <tkent at chromium.org>
Note: this patch depends on the patch of
https://bugs.webkit.org/show_bug.cgi?id=26915

From bugzilla-daemon at webkit.org  Fri Jul 31 02:24:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 02:24:35 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27871] Allow custom memory
 allocation control for JavaScriptCore's HashMap class : [Attachment 33864]
 proposed patch
In-Reply-To: <bug-27871-0@https.bugs.webkit.org/>
References: <bug-27871-0@https.bugs.webkit.org/>
Message-ID: <20090731092436.030EE34364E1@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27871: Allow custom memory allocation control for JavaScriptCore's HashMap
class
https://bugs.webkit.org/show_bug.cgi?id=27871

Attachment 33864: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33864&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 02:47:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 02:47:49 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27869] strict-aliasing
 warnings in JSFunction.h : [Attachment 33861] aliasing.patch
In-Reply-To: <bug-27869-0@https.bugs.webkit.org/>
References: <bug-27869-0@https.bugs.webkit.org/>
Message-ID: <20090731094749.A65EC34366A4@gamma.macosforge.org>

Xan Lopez <xan.lopez at gmail.com> has canceled Xan Lopez <xan.lopez at gmail.com>'s
request for review:
Bug 27869: strict-aliasing warnings in JSFunction.h
https://bugs.webkit.org/show_bug.cgi?id=27869

Attachment 33861: aliasing.patch
https://bugs.webkit.org/attachment.cgi?id=33861&action=review

------- Additional Comments from Xan Lopez <xan.lopez at gmail.com>
This seems to introduce a crash in the JSFunction destructor (which calls the
ScopeChain destructor). Maciej suggested something like this could happen, so
this needs further investigation. Removing from the queue.

From bugzilla-daemon at webkit.org  Fri Jul 31 03:54:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 03:54:33 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27873] [Patch] Fix compile
 error for ambigous call to abs() : [Attachment 33869] compile fix for
 ambigous call to abs()
In-Reply-To: <bug-27873-0@https.bugs.webkit.org/>
References: <bug-27873-0@https.bugs.webkit.org/>
Message-ID: <20090731105433.9A3CF3436CD7@gamma.macosforge.org>

Harald Fernengel <harry at kdevelop.org> has asked  for review:
Bug 27873: [Patch] Fix compile error for ambigous call to abs()
https://bugs.webkit.org/show_bug.cgi?id=27873

Attachment 33869: compile fix for ambigous call to abs()
https://bugs.webkit.org/attachment.cgi?id=33869&action=review

------- Additional Comments from Harald Fernengel <harry at kdevelop.org>
DateMath.cpp calls abs(long int) - which is ambiguous in some tool chains, for
example on QNX:

/home/harald/qt/qt/src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.cpp: In
function 'double WTF::parseDateFromNullTerminatedCharacters(const char*)':
/home/harald/qt/qt/src/3rdparty/webkit/JavaScriptCore/wtf/DateMath.cpp:844:
error: call of overloaded 'abs(long int&)' is ambiguous
/opt/qnx640/target/qnx6///usr/include/stdlib.h:122: note: candidates are: int
std::abs(int)
/opt/qnx640/target/qnx6///usr/include/math.h:1042: note:		 long
double std::abs(long double)
/opt/qnx640/target/qnx6///usr/include/math.h:692: note: 		float
std::abs(float)
/opt/qnx640/target/qnx6///usr/include/math.h:624: note: 		double
std::abs(double)
make[1]: *** [obj/debug/DateMath.o] Error 1

Patch replaces the abs() call to labs(), which takes a long int and returns a
long int. This also removes two implicit casts.

From bugzilla-daemon at webkit.org  Fri Jul 31 04:24:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 04:24:22 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27874] Change malloc to
 fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp :
 [Attachment 33870] proposed patch
In-Reply-To: <bug-27874-0@https.bugs.webkit.org/>
References: <bug-27874-0@https.bugs.webkit.org/>
Message-ID: <20090731112422.E03EC343716A@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27874: Change malloc to fastMalloc and free to fastFree in Yarr's
RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874

Attachment 33870: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33870&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 04:27:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 04:27:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27827] [Chromium] Functions
 Keys don't work in google spreadsheet. : [Attachment 33871] A quick fix
In-Reply-To: <bug-27827-0@https.bugs.webkit.org/>
References: <bug-27827-0@https.bugs.webkit.org/>
Message-ID: <20090731112716.197723437193@gamma.macosforge.org>

Hironori Bono <hbono at chromium.org> has asked  for review:
Bug 27827: [Chromium] Functions Keys don't work in google spreadsheet.
https://bugs.webkit.org/show_bug.cgi?id=27827

Attachment 33871: A quick fix
https://bugs.webkit.org/attachment.cgi?id=33871&action=review

------- Additional Comments from Hironori Bono <hbono at chromium.org>
The attached layout test fails on platforms whose eventSender.keyDown() cannot
send function-key events.
I'm wondering which is the better option: moving this layout test to
"LayoutTest/platform" or changing "Skipped" files?

From bugzilla-daemon at webkit.org  Fri Jul 31 05:04:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 05:04:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27875] Allow custom memory
 allocation control for JavaScriptCore's ScopeNodeData struct : [Attachment
 33872] proposed patch
In-Reply-To: <bug-27875-0@https.bugs.webkit.org/>
References: <bug-27875-0@https.bugs.webkit.org/>
Message-ID: <20090731120450.D695034374EE@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27875: Allow custom memory allocation control for JavaScriptCore's
ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875

Attachment 33872: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33872&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 05:44:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 05:44:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27876] Expose the Offline
 Web Application Cache API in the Qt API : [Attachment 33873] Add API to Qt
 for exposing the webcache
In-Reply-To: <bug-27876-0@https.bugs.webkit.org/>
References: <bug-27876-0@https.bugs.webkit.org/>
Message-ID: <20090731124442.81B83343783B@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has asked  for
review:
Bug 27876: Expose the Offline Web Application Cache API in the Qt API
https://bugs.webkit.org/show_bug.cgi?id=27876

Attachment 33873: Add API to Qt for exposing the webcache
https://bugs.webkit.org/attachment.cgi?id=33873&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
We need to expose the offline web app cache in the Qt API, so that users can at
least set some sane defaults for their applications.

From bugzilla-daemon at webkit.org  Fri Jul 31 05:50:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 05:50:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27877] Allow custom memory
 allocation control for JavaScriptCore's PolymorphicAccessStructureList
 struct : [Attachment 33874] proposed patch
In-Reply-To: <bug-27877-0@https.bugs.webkit.org/>
References: <bug-27877-0@https.bugs.webkit.org/>
Message-ID: <20090731125030.89F5334378CE@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27877: Allow custom memory allocation control for JavaScriptCore's
PolymorphicAccessStructureList struct
https://bugs.webkit.org/show_bug.cgi?id=27877

Attachment 33874: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33874&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 06:22:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 06:22:36 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27876] Expose the Offline Web
 Application Cache API in the Qt API : [Attachment 33873] Add API to Qt for
 exposing the webcache
In-Reply-To: <bug-27876-0@https.bugs.webkit.org/>
References: <bug-27876-0@https.bugs.webkit.org/>
Message-ID: <20090731132236.F05253437BAF@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has granted Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>'s request for review:
Bug 27876: Expose the Offline Web Application Cache API in the Qt API
https://bugs.webkit.org/show_bug.cgi?id=27876

Attachment 33873: Add API to Qt for exposing the webcache
https://bugs.webkit.org/attachment.cgi?id=33873&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
looks good, but we have to do an api review of all of this offline/cache stuff
before the release. a few nitpicks:

> @@ -358,7 +358,6 @@ QWebSettings::QWebSettings()
>      d->attributes.insert(QWebSettings::LocalStorageDatabaseEnabled, true);
>      d->attributes.insert(QWebSettings::LocalContentCanAccessRemoteUrls,
true);
>      d->offlineStorageDefaultQuota = 5 * 1024 * 1024;
> -
>  }

Whitespace change, please remove.

> @@ -785,10 +784,17 @@ qint64 QWebSettings::offlineStorageDefaultQuota()
>  }
>  
>  /*
> -    \internal
> +    \since 4.6
>      \relates QWebSettings
>  
>      Sets the path for HTML5 offline web application cache storage to \a
path.

Please add linebreak here.

> +    An application cache acts like an HTTP cache in some sense. For
documents
> +    that use the application cache via JavaScript, the loader mechinery will

> +    first ask the application cache for the contents, before hitting the
> +    network.

From bugzilla-daemon at webkit.org  Fri Jul 31 06:30:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 06:30:37 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27876] Expose the Offline
 Web Application Cache API in the Qt API : [Attachment 33873] Add API to Qt
 for exposing the webcache
In-Reply-To: <bug-27876-0@https.bugs.webkit.org/>
References: <bug-27876-0@https.bugs.webkit.org/>
Message-ID: <20090731133037.CB1003437C79@gamma.macosforge.org>

Kenneth Rohde Christiansen <kenneth.christiansen at openbossa.org> has canceled 
review:
Bug 27876: Expose the Offline Web Application Cache API in the Qt API
https://bugs.webkit.org/show_bug.cgi?id=27876

Attachment 33873: Add API to Qt for exposing the webcache
https://bugs.webkit.org/attachment.cgi?id=33873&action=review

------- Additional Comments from Kenneth Rohde Christiansen
<kenneth.christiansen at openbossa.org>
Landed in 46628

From bugzilla-daemon at webkit.org  Fri Jul 31 06:34:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 06:34:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27866] [Qt] Initialize HTML5
 Application Cache for QtWebKit to a sensible default : [Attachment 33856]
 proposed patch
In-Reply-To: <bug-27866-0@https.bugs.webkit.org/>
References: <bug-27866-0@https.bugs.webkit.org/>
Message-ID: <20090731133447.9B5C33437CD3@gamma.macosforge.org>

Tor Arne Vestb? <vestbo at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27866: [Qt] Initialize HTML5 Application Cache for QtWebKit to a sensible
default
https://bugs.webkit.org/show_bug.cgi?id=27866

Attachment 33856: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33856&action=review

------- Additional Comments from Tor Arne Vestb? <vestbo at webkit.org>
Looks good! A minor nitpick, just fix before landing:

> +static void WebKitInitializeApplicationCachePathIfNecessary()

Should be named initializeApplicationCachePathIfNecessary(), ie no WebKit
prefix, and start with lower-case.

Actually this is not in the coding style guidelines, but I think the lower case
variant is more prevalent.

From bugzilla-daemon at webkit.org  Fri Jul 31 07:16:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 07:16:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27879] Allow custom memory
 allocation control for JavaScriptCore's Noncopyable class : [Attachment
 33875] proposed patch
In-Reply-To: <bug-27879-0@https.bugs.webkit.org/>
References: <bug-27879-0@https.bugs.webkit.org/>
Message-ID: <20090731141639.AC4B93438088@gamma.macosforge.org>

Zoltan Horvath <hzoltan at inf.u-szeged.hu> has asked  for review:
Bug 27879: Allow custom memory allocation control for JavaScriptCore's
Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879

Attachment 33875: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33875&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 07:31:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 07:31:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27863] Consolidate
 GeoLocation code to send positions and errors : [Attachment 33850] Patch
 implementing the change
In-Reply-To: <bug-27863-0@https.bugs.webkit.org/>
References: <bug-27863-0@https.bugs.webkit.org/>
Message-ID: <20090731143122.5E86E34381DC@gamma.macosforge.org>

George Staikos <staikos at kde.org> has granted Greg Bolsinga
<bolsinga at apple.com>'s request for review:
Bug 27863: Consolidate GeoLocation code to send positions and errors
https://bugs.webkit.org/show_bug.cgi?id=27863

Attachment 33850: Patch implementing the change
https://bugs.webkit.org/attachment.cgi?id=33850&action=review

------- Additional Comments from George Staikos <staikos at kde.org>
Nice cleanup!

From bugzilla-daemon at webkit.org  Fri Jul 31 08:13:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 08:13:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33865] Next iteration
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090731151317.4EBC034385E9@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33865: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33865&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 08:45:11 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 08:45:11 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27882] Test results missing
 for a number of LayoutTests under Qt. : [Attachment 33877] Patch including
 all missing test results.
In-Reply-To: <bug-27882-0@https.bugs.webkit.org/>
References: <bug-27882-0@https.bugs.webkit.org/>
Message-ID: <20090731154511.43BC3343898A@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27882: Test results missing for a number of LayoutTests under Qt.
https://bugs.webkit.org/show_bug.cgi?id=27882

Attachment 33877: Patch including all missing test results.
https://bugs.webkit.org/attachment.cgi?id=33877&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 08:53:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 08:53:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27804] [Qt]
 QWebFrame::requestedUrl method can mis-behave in case of unhandled
 sslErrors. : [Attachment 33724] fix
In-Reply-To: <bug-27804-0@https.bugs.webkit.org/>
References: <bug-27804-0@https.bugs.webkit.org/>
Message-ID: <20090731155330.D0AFA3438A71@gamma.macosforge.org>

Antonio Gomes (tonikitoo) <tonikitoo at gmail.com> has asked  for review:
Bug 27804: [Qt] QWebFrame::requestedUrl method can mis-behave in case of
unhandled sslErrors.
https://bugs.webkit.org/show_bug.cgi?id=27804

Attachment 33724: fix
https://bugs.webkit.org/attachment.cgi?id=33724&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:01:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:01:29 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33865] Next iteration
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090731160129.DF18A3438B4E@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied David Levin <levin at chromium.org>'s
request for review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33865: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33865&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few more thigns.

> Index: WebCore/ChangeLog
> +2009-07-31  Christian Plesner Hansen  <christian.plesner.hansen at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [V8] Cache atomic strings in externalized v8 strings
> +	   https://bugs.webkit.org/show_bug.cgi?id=27762
> +
> +	   * bindings/scripts/CodeGeneratorV8.pm:
> +	   * bindings/v8/V8Binding.cpp:
> +	   (WebCore::WebCoreStringResource::WebCoreStringResource):
> +	   (WebCore::WebCoreStringResource::~WebCoreStringResource):
> +	   (WebCore::WebCoreStringResource::data):
> +	   (WebCore::WebCoreStringResource::length):
> +	   (WebCore::WebCoreStringResource::webcoreString):
> +	   (WebCore::WebCoreStringResource::atomicString):
> +	   (WebCore::WebCoreStringResource::forString):
> +	   (WebCore::v8StringToWebCoreString):
> +	   (WebCore::v8StringToAtomicWebCoreString):
> +	   (WebCore::v8ValueToWebCoreString):
> +	   (WebCore::v8ValueToAtomicWebCoreString):

I think this is ok for this change, but in general (brief) per function
comments are encouraged to explain what happened in the function.  See other
entries in the change log.

> Index: WebCore/bindings/v8/V8Binding.cpp

> @@ -49,33 +49,66 @@ namespace WebCore {
>  class WebCoreStringResource : public v8::String::ExternalStringResource {
>  public:
>      explicit WebCoreStringResource(const String& string)
> -	   : m_impl(string.impl())
> +	   : m_plainString(string)
>      {
Nice to add assert here:
	ASSERT(WTF::isMainThread());

>	   v8::V8::AdjustAmountOfExternalAllocatedMemory(2 * length());
>      }
>  
> +    explicit WebCoreStringResource(const AtomicString& string)
> +	   : m_plainString(string)
> +	   , m_atomicString(string)
> +    {
> +	   ASSERT(WTF::isMainThread());
> +	   v8::V8::AdjustAmountOfExternalAllocatedMemory(2 * length());
> +    }
> +
>      virtual ~WebCoreStringResource()
>      {
> -	   v8::V8::AdjustAmountOfExternalAllocatedMemory(-2 * length());

Nice to add assert here:
	ASSERT(WTF::isMainThread());

(Really all we care about is that everything is on the same thread and for now
this will do.)


> +	   int reducedExternalMemory = -2 * length();
> +	   if (!m_plainString.impl()->inTable())
> +	       reducedExternalMemory *= 2;
> +	  
v8::V8::AdjustAmountOfExternalAllocatedMemory(reducedExternalMemory);
>      }



> +    AtomicString atomicString()
> +    {
> +	   ASSERT(WTF::isMainThread());
> +	   if (m_atomicString.isNull()) {
> +	       m_atomicString = AtomicString(m_plainString);
> +	       if (m_plainString.impl()->inTable())

This should be
   if (!m_plainString.impl()->inTable())

> +		   v8::V8::AdjustAmountOfExternalAllocatedMemory(2 * length());

> +	   }
> +	   return m_atomicString;
> +    }
> +
> +    static WebCoreStringResource *forString(v8::Handle<v8::String> v8String)


Move the "*"
   static WebCoreStringResource*

Also the name "forString" doesn't read that well to me. How about
toStringResource?  (toString may have worked but there are so many *String* in
here, that I thought it would be nice to distinguish.)


> +AtomicString v8StringToAtomicWebCoreString(v8::Handle<v8::String> v8String)
> +{
> +    WebCoreStringResource* stringResource =
WebCoreStringResource::forString(v8String);
> +    if (!stringResource) {
> +	   // If this string hasn't been externalized we force it now.

Nice to add a comma after the if clause.
   If this string hasn't been externalized, we force it now.



And as discussed, this solution removed the duplicate code but increased memory
usage unnecessarily.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:10:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:10:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27883] [v8] check if proxy
 is present before invoking a handler : [Attachment 33878] Initial version
In-Reply-To: <bug-27883-0@https.bugs.webkit.org/>
References: <bug-27883-0@https.bugs.webkit.org/>
Message-ID: <20090731161057.6E8693438C57@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27883: [v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Attachment 33878: Initial version
https://bugs.webkit.org/attachment.cgi?id=33878&action=review

------- Additional Comments from anton muhin <antonm at chromium.org>
To be honest, I would guess the code expects always not NULL proxy here as
listeners are enabled. (but I think in that case it should be documented with
ASSERT).  So I am by no means insisting on this patch.

One thing that stroke me is presence of GoogleUpdateClient in the call stack
(see
http://crash/reportdetail?reportid=19d99906cbceb8a7&product=Chrome&version=3.0.
196.0&date=&signature=WebCore::V8Proxy::callFunction%28v8::Handle).  My
immediate reaction is something wasn't initialized properly.

And I'll be on vacation two next weeks.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:19:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:19:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27883] [v8] check if proxy is
 present before invoking a handler : [Attachment 33878] Initial version
In-Reply-To: <bug-27883-0@https.bugs.webkit.org/>
References: <bug-27883-0@https.bugs.webkit.org/>
Message-ID: <20090731161904.393223438D24@gamma.macosforge.org>

David Levin <levin at chromium.org> has denied anton muhin <antonm at chromium.org>'s
request for review:
Bug 27883: [v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Attachment 33878: Initial version
https://bugs.webkit.org/attachment.cgi?id=33878&action=review

------- Additional Comments from David Levin <levin at chromium.org>
> Index: third_party/WebKit/WebCore/ChangeLog
> +2009-07-31  Anton Muhin  <antonm at chromium.org>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +

Please add:

Bug Title
Bug Link

"prepare-ChangeLog --bug #" will do this for you.

> +	   Do not invoke handler functio if proxy is NULL (that would lead to
NPE anyway).

typo: functio

Change NULL to 0 (since WebKit doesn't use NULL).

NPE is not an abbreviation that I'm familiar with but I guess you mean
crash/access violation.  It would be good to write it in a longer form without
using an abbreviation.

Also, this ChangeLog explains what but not why.  Please add why.


Can there be a layout test for whatever problem was encountered?
  If so, please add one.
  If not, why not?

From bugzilla-daemon at webkit.org  Fri Jul 31 09:20:13 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:20:13 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33879] Fixed memory waste
 etc.
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090731162013.CEF7B3438D44@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33879: Fixed memory waste etc.
https://bugs.webkit.org/attachment.cgi?id=33879&action=review

------- Additional Comments from David Levin <levin at chromium.org>
If you want a review, it is good to set the r? (or no one will see this).  I'm
adding it for you.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:22:29 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:22:29 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27885] Add QNX as supported
 platform : [Attachment 33880] Patch making WebKitCore and JavaScriptCore
 compile on QNX
In-Reply-To: <bug-27885-0@https.bugs.webkit.org/>
References: <bug-27885-0@https.bugs.webkit.org/>
Message-ID: <20090731162229.2FE0E3438DA4@gamma.macosforge.org>

Harald Fernengel <harry at kdevelop.org> has asked  for review:
Bug 27885: Add QNX as supported platform
https://bugs.webkit.org/show_bug.cgi?id=27885

Attachment 33880: Patch making WebKitCore and JavaScriptCore compile on QNX
https://bugs.webkit.org/attachment.cgi?id=33880&action=review

------- Additional Comments from Harald Fernengel <harry at kdevelop.org>
Attached patch adds WTF_PLATFORM_QNX and a few minor fixes to make WebKitCore
and JavaScriptCore compile on QNX 6.4.

Tested only with Qt, see http://www.youtube.com/watch?v=U05iuHL2b9M&fmt=22 for
proof :)

From bugzilla-daemon at webkit.org  Fri Jul 31 09:25:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:25:57 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27882] Test results missing
 for a number of LayoutTests under Qt. : [Attachment 33877] Patch including
 all missing test results.
In-Reply-To: <bug-27882-0@https.bugs.webkit.org/>
References: <bug-27882-0@https.bugs.webkit.org/>
Message-ID: <20090731162557.1E1553438DEB@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has canceled Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27882: Test results missing for a number of LayoutTests under Qt.
https://bugs.webkit.org/show_bug.cgi?id=27882

Attachment 33877: Patch including all missing test results.
https://bugs.webkit.org/attachment.cgi?id=33877&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Two of the tests had questionable results that may or may not be accurate and
should be investigated in greater depth.  These have been removed from the
patch.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:25:57 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:25:57 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27882] Test results missing
 for a number of LayoutTests under Qt. : [Attachment 33881] Updated patch
 with 2 tests removed.
In-Reply-To: <bug-27882-0@https.bugs.webkit.org/>
References: <bug-27882-0@https.bugs.webkit.org/>
Message-ID: <20090731162557.5DDD13438DEF@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27882: Test results missing for a number of LayoutTests under Qt.
https://bugs.webkit.org/show_bug.cgi?id=27882

Attachment 33881: Updated patch with 2 tests removed.
https://bugs.webkit.org/attachment.cgi?id=33881&action=review

------- Additional Comments from Mike Fenton <mike.fenton at torchmobile.com>
Two of the tests had questionable results that may or may not be accurate and
should be investigated in greater depth.  These have been removed from the
patch.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:29:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:29:40 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27871] Allow custom memory
 allocation control for JavaScriptCore's HashMap class : [Attachment 33864]
 proposed patch
In-Reply-To: <bug-27871-0@https.bugs.webkit.org/>
References: <bug-27871-0@https.bugs.webkit.org/>
Message-ID: <20090731162941.003F93438E7B@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27871: Allow custom memory allocation control for JavaScriptCore's HashMap
class
https://bugs.webkit.org/show_bug.cgi?id=27871

Attachment 33864: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33864&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
> +	   * wtf/RefPtrHashMap.h:
> +	   (WTF::):

Please don't leave broken lines like this in the change log just because the
prepare-ChangeLog script put them there.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:32:54 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:32:54 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27884] Animations stutter
 on pages with lots of animations and 3d transforms : [Attachment 33882]
 Patch
In-Reply-To: <bug-27884-0@https.bugs.webkit.org/>
References: <bug-27884-0@https.bugs.webkit.org/>
Message-ID: <20090731163254.895863438EDA@gamma.macosforge.org>

Simon Fraser (smfr) <simon.fraser at apple.com> has asked	for review:
Bug 27884: Animations stutter on pages with lots of animations and 3d
transforms
https://bugs.webkit.org/show_bug.cgi?id=27884

Attachment 33882: Patch
https://bugs.webkit.org/attachment.cgi?id=33882&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:33:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:33:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27873] [Patch] Fix compile
 error for ambigous call to abs() : [Attachment 33869] compile fix for
 ambigous call to abs()
In-Reply-To: <bug-27873-0@https.bugs.webkit.org/>
References: <bug-27873-0@https.bugs.webkit.org/>
Message-ID: <20090731163349.CEC5B3438F06@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Harald Fernengel
<harry at kdevelop.org>'s request for review:
Bug 27873: [Patch] Fix compile error for ambigous call to abs()
https://bugs.webkit.org/show_bug.cgi?id=27873

Attachment 33869: compile fix for ambigous call to abs()
https://bugs.webkit.org/attachment.cgi?id=33869&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Another approach we use for issues like this is to put code in MathExtras.h to
work around platform differences. Take a look at MathExtras.h to see what I
mean.

But this change seems OK.

I think the change log is not so good. It says "fix compilation" which is far
too vague. The bug mentions the QNX platform and the change log should too.

I'm going to say r=me, though, because this seems like a good fix.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:34:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:34:49 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27874] Change malloc to
 fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp :
 [Attachment 33870] proposed patch
In-Reply-To: <bug-27874-0@https.bugs.webkit.org/>
References: <bug-27874-0@https.bugs.webkit.org/>
Message-ID: <20090731163449.4BE7C3438F1A@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27874: Change malloc to fastMalloc and free to fastFree in Yarr's
RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874

Attachment 33870: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33870&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:36:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:36:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27877] Allow custom memory
 allocation control for JavaScriptCore's PolymorphicAccessStructureList
 struct : [Attachment 33874] proposed patch
In-Reply-To: <bug-27877-0@https.bugs.webkit.org/>
References: <bug-27877-0@https.bugs.webkit.org/>
Message-ID: <20090731163609.E8B913438F58@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27877: Allow custom memory allocation control for JavaScriptCore's
PolymorphicAccessStructureList struct
https://bugs.webkit.org/show_bug.cgi?id=27877

Attachment 33874: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33874&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:40:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:40:06 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33879] Fixed memory waste
 etc.
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090731164006.D93313438FF5@gamma.macosforge.org>

David Levin <levin at chromium.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33879: Fixed memory waste etc.
https://bugs.webkit.org/attachment.cgi?id=33879&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Just a few things that can be fixed on landing..


> Index: WebCore/ChangeLog
> ===================================================================
> +2009-07-31  Christian Plesner Hansen  <christian.plesner.hansen at gmail.com>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   [V8] Cache atomic strings in externalized v8 strings
> +	   https://bugs.webkit.org/show_bug.cgi?id=27762
> +

I should have said this before, but typically there is a comment here about why
no layout tests were added if none were.

In this case, there is no change in functionality, so you could say:

	No change in behavior, so no tests.


> Index: WebCore/bindings/v8/V8Binding.cpp
> ===================================================================

> +String v8StringToWebCoreString(v8::Handle<v8::String> v8String, ExternalMode
external,
> +	   StringType type)

This is typically indented to align with the (.



> Index: WebCore/bindings/v8/V8Binding.h

Enum members should user InterCaps with an initial capital letter.

> +    enum ExternalMode { EXTERNALIZE, DONT_EXTERNALIZE };

Externalize, DoNotExternalize

> +    enum StringType { PLAIN, ATOMIC };

Since these enum are in the WebCore namespace (and cased like classes), it
feels like the names for StringType should be a little more verbose.

Here's some simple alternatives:
PlainStringType
AtomicStringType

From bugzilla-daemon at webkit.org  Fri Jul 31 09:40:24 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:40:24 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27886] Build QtWebKit
 without benchmark tests for Qt < 4.5 : [Attachment 33883] Build QtWebKit
 without benchmark tests for Qt < 4.5
In-Reply-To: <bug-27886-0@https.bugs.webkit.org/>
References: <bug-27886-0@https.bugs.webkit.org/>
Message-ID: <20090731164024.6A94C3439026@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27886: Build QtWebKit without benchmark tests for Qt < 4.5
https://bugs.webkit.org/show_bug.cgi?id=27886

Attachment 33883: Build QtWebKit without benchmark tests for Qt < 4.5
https://bugs.webkit.org/attachment.cgi?id=33883&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:43:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:43:10 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27886] Build QtWebKit
 without benchmark tests for Qt < 4.5 : [Attachment 33883] Build QtWebKit
 without benchmark tests for Qt < 4.5
In-Reply-To: <bug-27886-0@https.bugs.webkit.org/>
References: <bug-27886-0@https.bugs.webkit.org/>
Message-ID: <20090731164310.B6D113439063@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has canceled Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27886: Build QtWebKit without benchmark tests for Qt < 4.5
https://bugs.webkit.org/show_bug.cgi?id=27886

Attachment 33883: Build QtWebKit without benchmark tests for Qt < 4.5
https://bugs.webkit.org/attachment.cgi?id=33883&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Don't end a sentence with two periods, only one.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:43:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:43:10 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27886] Build QtWebKit
 without benchmark tests for Qt < 4.5 : [Attachment 33884] Build QtWebKit
 without benchmark tests for Qt < 4.5 (try 2)
In-Reply-To: <bug-27886-0@https.bugs.webkit.org/>
References: <bug-27886-0@https.bugs.webkit.org/>
Message-ID: <20090731164310.EACF33439067@gamma.macosforge.org>

Jakob Petsovits <jpetso at gmx.at> has asked  for review:
Bug 27886: Build QtWebKit without benchmark tests for Qt < 4.5
https://bugs.webkit.org/show_bug.cgi?id=27886

Attachment 33884: Build QtWebKit without benchmark tests for Qt < 4.5 (try 2)
https://bugs.webkit.org/attachment.cgi?id=33884&action=review

------- Additional Comments from Jakob Petsovits <jpetso at gmx.at>
Don't end a sentence with two periods, only one.

From bugzilla-daemon at webkit.org  Fri Jul 31 09:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:46:07 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27886] Build QtWebKit without
 benchmark tests for Qt < 4.5 : [Attachment 33884] Build QtWebKit without
 benchmark tests for Qt < 4.5 (try 2)
In-Reply-To: <bug-27886-0@https.bugs.webkit.org/>
References: <bug-27886-0@https.bugs.webkit.org/>
Message-ID: <20090731164607.BBC4434390C5@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Jakob Petsovits <jpetso at gmx.at>'s
request for review:
Bug 27886: Build QtWebKit without benchmark tests for Qt < 4.5
https://bugs.webkit.org/show_bug.cgi?id=27886

Attachment 33884: Build QtWebKit without benchmark tests for Qt < 4.5 (try 2)
https://bugs.webkit.org/attachment.cgi?id=33884&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:48:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:48:47 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27882] Test results missing
 for a number of LayoutTests under Qt. : [Attachment 33881] Updated patch
 with 2 tests removed.
In-Reply-To: <bug-27882-0@https.bugs.webkit.org/>
References: <bug-27882-0@https.bugs.webkit.org/>
Message-ID: <20090731164847.56DCF3439130@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has canceled Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27882: Test results missing for a number of LayoutTests under Qt.
https://bugs.webkit.org/show_bug.cgi?id=27882

Attachment 33881: Updated patch with 2 tests removed.
https://bugs.webkit.org/attachment.cgi?id=33881&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:48:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:48:47 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27882] Test results missing
 for a number of LayoutTests under Qt. : [Attachment 33885] Remove printing
 test that is not supported by DRT.
In-Reply-To: <bug-27882-0@https.bugs.webkit.org/>
References: <bug-27882-0@https.bugs.webkit.org/>
Message-ID: <20090731164847.8DCAC3439134@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27882: Test results missing for a number of LayoutTests under Qt.
https://bugs.webkit.org/show_bug.cgi?id=27882

Attachment 33885: Remove printing test that is not supported by DRT.
https://bugs.webkit.org/attachment.cgi?id=33885&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 09:50:00 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 09:50:00 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27882] Test results missing
 for a number of LayoutTests under Qt. : [Attachment 33885] Remove printing
 test that is not supported by DRT.
In-Reply-To: <bug-27882-0@https.bugs.webkit.org/>
References: <bug-27882-0@https.bugs.webkit.org/>
Message-ID: <20090731165000.88A96343915C@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27882: Test results missing for a number of LayoutTests under Qt.
https://bugs.webkit.org/show_bug.cgi?id=27882

Attachment 33885: Remove printing test that is not supported by DRT.
https://bugs.webkit.org/attachment.cgi?id=33885&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 10:08:10 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 10:08:10 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27762] [v8] Cache atomic
 strings in externalized v8 strings : [Attachment 33879] Fixed memory waste
 etc.
In-Reply-To: <bug-27762-0@https.bugs.webkit.org/>
References: <bug-27762-0@https.bugs.webkit.org/>
Message-ID: <20090731170810.40E68343935D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 27762: [v8] Cache atomic strings in externalized v8 strings
https://bugs.webkit.org/show_bug.cgi?id=27762

Attachment 33879: Fixed memory waste etc.
https://bugs.webkit.org/attachment.cgi?id=33879&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
You still haven't convinced me that this need to be fixed in V8 and not in
WebCore.

From bugzilla-daemon at webkit.org  Fri Jul 31 10:25:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 10:25:14 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27888] Geolocation clean up
 when no longer updating : [Attachment 33886] patch to implement bug fix
In-Reply-To: <bug-27888-0@https.bugs.webkit.org/>
References: <bug-27888-0@https.bugs.webkit.org/>
Message-ID: <20090731172514.7821B3439542@gamma.macosforge.org>

Greg Bolsinga <bolsinga at apple.com> has asked  for review:
Bug 27888: Geolocation clean up when no longer updating
https://bugs.webkit.org/show_bug.cgi?id=27888

Attachment 33886: patch to implement bug fix
https://bugs.webkit.org/attachment.cgi?id=33886&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 11:13:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 11:13:39 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27890] Some tests skipped
 in platform/qt/Skipped pass successfully. : [Attachment 33888] Re-Enable
 currently working tests being skipped in platform/qt.
In-Reply-To: <bug-27890-0@https.bugs.webkit.org/>
References: <bug-27890-0@https.bugs.webkit.org/>
Message-ID: <20090731181340.047FF3439A6C@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27890: Some tests skipped in platform/qt/Skipped pass successfully.
https://bugs.webkit.org/show_bug.cgi?id=27890

Attachment 33888: Re-Enable currently working tests being skipped in
platform/qt.
https://bugs.webkit.org/attachment.cgi?id=33888&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 11:14:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 11:14:46 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27890] Some tests skipped in
 platform/qt/Skipped pass successfully. : [Attachment 33888] Re-Enable
 currently working tests being skipped in platform/qt.
In-Reply-To: <bug-27890-0@https.bugs.webkit.org/>
References: <bug-27890-0@https.bugs.webkit.org/>
Message-ID: <20090731181446.647C93439A8C@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted Mike Fenton
<mike.fenton at torchmobile.com>'s request for review:
Bug 27890: Some tests skipped in platform/qt/Skipped pass successfully.
https://bugs.webkit.org/show_bug.cgi?id=27890

Attachment 33888: Re-Enable currently working tests being skipped in
platform/qt.
https://bugs.webkit.org/attachment.cgi?id=33888&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 11:24:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 11:24:51 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27870] isContentEditable
 function in htmlediting.* must be removed : [Attachment 33889] removes the
 function
In-Reply-To: <bug-27870-0@https.bugs.webkit.org/>
References: <bug-27870-0@https.bugs.webkit.org/>
Message-ID: <20090731182451.A3A403439BBF@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27870: isContentEditable function in htmlediting.* must be removed
https://bugs.webkit.org/show_bug.cgi?id=27870

Attachment 33889: removes the function
https://bugs.webkit.org/attachment.cgi?id=33889&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 11:32:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 11:32:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27870] isContentEditable
 function in htmlediting.* must be removed : [Attachment 33889] removes the
 function
In-Reply-To: <bug-27870-0@https.bugs.webkit.org/>
References: <bug-27870-0@https.bugs.webkit.org/>
Message-ID: <20090731183209.D0F453439C73@gamma.macosforge.org>

Adele Peterson <adele at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27870: isContentEditable function in htmlediting.* must be removed
https://bugs.webkit.org/show_bug.cgi?id=27870

Attachment 33889: removes the function
https://bugs.webkit.org/attachment.cgi?id=33889&action=review

------- Additional Comments from Adele Peterson <adele at apple.com>
My only comment is that the title of this bug could be "isContentEditable
function in htmlediting.* can be removed" instead of "must", but that doesn't
really matter.

From bugzilla-daemon at webkit.org  Fri Jul 31 11:39:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 11:39:31 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 20797] add Settings entries
 for per-script/lang generic family : [Attachment 33195] patch updated
 (macros expanded)
In-Reply-To: <bug-20797-0@https.bugs.webkit.org/>
References: <bug-20797-0@https.bugs.webkit.org/>
Message-ID: <20090731183931.740083439EAD@gamma.macosforge.org>

Jungshik Shin <jshin at chromium.org> has asked mitz at webkit.org for review:
Bug 20797: add Settings entries for per-script/lang generic family
https://bugs.webkit.org/show_bug.cgi?id=20797

Attachment 33195: patch updated (macros expanded)
https://bugs.webkit.org/attachment.cgi?id=33195&action=review

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Because Maciej didn't have any issue other than macros for the previous patch
and this patch removed them, I'm asking mitz to take a look.

From bugzilla-daemon at webkit.org  Fri Jul 31 11:40:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 11:40:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27875] Allow custom memory
 allocation control for JavaScriptCore's ScopeNodeData struct : [Attachment
 33872] proposed patch
In-Reply-To: <bug-27875-0@https.bugs.webkit.org/>
References: <bug-27875-0@https.bugs.webkit.org/>
Message-ID: <20090731184008.9F7E33439ECE@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27875: Allow custom memory allocation control for JavaScriptCore's
ScopeNodeData struct
https://bugs.webkit.org/show_bug.cgi?id=27875

Attachment 33872: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33872&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 12:01:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 12:01:06 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27883] [v8] check if proxy
 is present before invoking a handler : [Attachment 33893] Next iteration
In-Reply-To: <bug-27883-0@https.bugs.webkit.org/>
References: <bug-27883-0@https.bugs.webkit.org/>
Message-ID: <20090731190106.C58E7343A2C7@gamma.macosforge.org>

anton muhin <antonm at chromium.org> has asked  for review:
Bug 27883: [v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Attachment 33893: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33893&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 12:22:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 12:22:23 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27883] [v8] check if proxy is
 present before invoking a handler : [Attachment 33893] Next iteration
In-Reply-To: <bug-27883-0@https.bugs.webkit.org/>
References: <bug-27883-0@https.bugs.webkit.org/>
Message-ID: <20090731192223.65775343A803@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted anton muhin <antonm at chromium.org>'s
request for review:
Bug 27883: [v8] check if proxy is present before invoking a handler
https://bugs.webkit.org/show_bug.cgi?id=27883

Attachment 33893: Next iteration
https://bugs.webkit.org/attachment.cgi?id=33893&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
Thanks for the patch.  Can you file a bug to investigate whether we're making a
mistake at a higher level?

As for modifying contributing.html, it's in SVN under WebKitSite.  Feel free to
file a bug and propose a patch.  :)

From bugzilla-daemon at webkit.org  Fri Jul 31 12:36:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 12:36:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27778] Add more DOM Storage
 tests : [Attachment 33667] v1
In-Reply-To: <bug-27778-0@https.bugs.webkit.org/>
References: <bug-27778-0@https.bugs.webkit.org/>
Message-ID: <20090731193639.D64E6343AA09@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has granted Jeremy Orlow <jorlow at chromium.org>'s
request for review:
Bug 27778: Add more DOM Storage tests
https://bugs.webkit.org/show_bug.cgi?id=27778

Attachment 33667: v1
https://bugs.webkit.org/attachment.cgi?id=33667&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I support all non-flaky tests.	:)

From bugzilla-daemon at webkit.org  Fri Jul 31 13:01:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:01:25 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33894] Add normalizePath() function to
 the FileSystem files.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090731200125.1E5F9343ACD0@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33894: Add normalizePath() function to the FileSystem files.
https://bugs.webkit.org/attachment.cgi?id=33894&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:01:52 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:01:52 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27651] [Qt]
 QWebPluginDatabase API : [Attachment 33895] Don't clear the plugin database
 when changing search paths.
In-Reply-To: <bug-27651-0@https.bugs.webkit.org/>
References: <bug-27651-0@https.bugs.webkit.org/>
Message-ID: <20090731200152.65BA1343ACFB@gamma.macosforge.org>

Jakub Wieczorek <faw217 at gmail.com> has asked  for review:
Bug 27651: [Qt] QWebPluginDatabase API
https://bugs.webkit.org/show_bug.cgi?id=27651

Attachment 33895: Don't clear the plugin database when changing search paths.
https://bugs.webkit.org/attachment.cgi?id=33895&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:22:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:22:14 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26742] Support fullscreen in
 MediaPlayer. : [Attachment 33470] Implement video Fullscreen on Mac OS X.
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090731202214.CEDA4343AF1B@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33470: Implement video Fullscreen on Mac OS X.
https://bugs.webkit.org/attachment.cgi?id=33470&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:22:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:22:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26742] Support fullscreen
 in MediaPlayer. : [Attachment 33898] Support Fullscreen for video element
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090731202217.09B0A343AF22@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33898: Support Fullscreen for video element
https://bugs.webkit.org/attachment.cgi?id=33898&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=26742
---
 27 files changed, 1464 insertions(+), 13 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 13:24:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:24:18 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27859] [chromium] Implement
 media slider for chromium : [Attachment 33897] patch
In-Reply-To: <bug-27859-0@https.bugs.webkit.org/>
References: <bug-27859-0@https.bugs.webkit.org/>
Message-ID: <20090731202418.A4BA0343AF50@gamma.macosforge.org>

Hin-Chung Lam <hclam at google.com> has asked  for review:
Bug 27859: [chromium] Implement media slider for chromium
https://bugs.webkit.org/show_bug.cgi?id=27859

Attachment 33897: patch
https://bugs.webkit.org/attachment.cgi?id=33897&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:32:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:32:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27893] run-webkit-tests
 Skipped Only mode includes tests that are skipped by other flags. :
 [Attachment 33899] Patch to improve the behavior of --skipped=only and add
 --skipped=only-all mode to run-webkit-tests
In-Reply-To: <bug-27893-0@https.bugs.webkit.org/>
References: <bug-27893-0@https.bugs.webkit.org/>
Message-ID: <20090731203202.551F7343B02F@gamma.macosforge.org>

Mike Fenton <mike.fenton at torchmobile.com> has asked  for review:
Bug 27893: run-webkit-tests Skipped Only mode includes tests that are skipped
by other flags.
https://bugs.webkit.org/show_bug.cgi?id=27893

Attachment 33899: Patch to improve the behavior of --skipped=only and add
--skipped=only-all mode to run-webkit-tests
https://bugs.webkit.org/attachment.cgi?id=33899&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:36:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:36:05 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27849] bugzilla-tool
 post-commits obsoletes its own work :( : [Attachment 33837] Simple fix
In-Reply-To: <bug-27849-0@https.bugs.webkit.org/>
References: <bug-27849-0@https.bugs.webkit.org/>
Message-ID: <20090731203605.DCD3D343B09B@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has canceled  review:
Bug 27849: bugzilla-tool post-commits obsoletes its own work :(
https://bugs.webkit.org/show_bug.cgi?id=27849

Attachment 33837: Simple fix
https://bugs.webkit.org/attachment.cgi?id=33837&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:40:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:40:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27855] Delay starting
 plug-ins : [Attachment 33838] Patch to add this
In-Reply-To: <bug-27855-0@https.bugs.webkit.org/>
References: <bug-27855-0@https.bugs.webkit.org/>
Message-ID: <20090731204020.EE68E343B10F@gamma.macosforge.org>

Anders Carlsson <andersca at apple.com> has granted Jon Honeycutt
<jhoneycutt at apple.com>'s request for review:
Bug 27855: Delay starting plug-ins
https://bugs.webkit.org/show_bug.cgi?id=27855

Attachment 33838: Patch to add this
https://bugs.webkit.org/attachment.cgi?id=33838&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 31 13:45:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:45:09 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27894] bugzilla-tool:
 Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and
 python-2.5 : [Attachment 33901] Patch v1
In-Reply-To: <bug-27894-0@https.bugs.webkit.org/>
References: <bug-27894-0@https.bugs.webkit.org/>
Message-ID: <20090731204509.8C9DB343B1C2@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 27894: bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with
ClientForm-0.2.10 and python-2.5
https://bugs.webkit.org/show_bug.cgi?id=27894

Attachment 33901: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33901&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 13:48:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:48:16 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27879] Allow custom memory
 allocation control for JavaScriptCore's Noncopyable class : [Attachment
 33875] proposed patch
In-Reply-To: <bug-27879-0@https.bugs.webkit.org/>
References: <bug-27879-0@https.bugs.webkit.org/>
Message-ID: <20090731204816.CB482343B216@gamma.macosforge.org>

Darin Adler <darin at apple.com> has granted Zoltan Horvath
<hzoltan at inf.u-szeged.hu>'s request for review:
Bug 27879: Allow custom memory allocation control for JavaScriptCore's
Noncopyable class
https://bugs.webkit.org/show_bug.cgi?id=27879

Attachment 33875: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33875&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This is a big one, that will affect tons of classes. Lets make sure this gets
tested well.

r=me

From bugzilla-daemon at webkit.org  Fri Jul 31 13:50:09 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 13:50:09 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27894] bugzilla-tool:
 Bugzilla.clear_attachment_review_flag() fails with ClientForm-0.2.10 and
 python-2.5 : [Attachment 33901] Patch v1
In-Reply-To: <bug-27894-0@https.bugs.webkit.org/>
References: <bug-27894-0@https.bugs.webkit.org/>
Message-ID: <20090731205009.6BE84343B266@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 27894: bugzilla-tool: Bugzilla.clear_attachment_review_flag() fails with
ClientForm-0.2.10 and python-2.5
https://bugs.webkit.org/show_bug.cgi?id=27894

Attachment 33901: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33901&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.  Are there other places we need to worry about?  We have several places
we set the comment...  r=me to change the rest too.

From bugzilla-daemon at webkit.org  Fri Jul 31 14:34:58 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 14:34:58 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27884] Animations stutter on
 pages with lots of animations and 3d transforms : [Attachment 33882] Patch
In-Reply-To: <bug-27884-0@https.bugs.webkit.org/>
References: <bug-27884-0@https.bugs.webkit.org/>
Message-ID: <20090731213458.CF32D343B7EE@gamma.macosforge.org>

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 27884: Animations stutter on pages with lots of animations and 3d
transforms
https://bugs.webkit.org/show_bug.cgi?id=27884

Attachment 33882: Patch
https://bugs.webkit.org/attachment.cgi?id=33882&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 31 14:35:08 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 14:35:08 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27888] Geolocation clean up
 when no longer updating : [Attachment 33886] patch to implement bug fix
In-Reply-To: <bug-27888-0@https.bugs.webkit.org/>
References: <bug-27888-0@https.bugs.webkit.org/>
Message-ID: <20090731213508.EB732343B802@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 27888: Geolocation clean up when no longer updating
https://bugs.webkit.org/show_bug.cgi?id=27888

Attachment 33886: patch to implement bug fix
https://bugs.webkit.org/attachment.cgi?id=33886&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Any way to test this?  We really need some sort of geolocationController for
DumpRenderTree it seems.

From bugzilla-daemon at webkit.org  Fri Jul 31 15:02:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:02:27 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26742] Support fullscreen in
 MediaPlayer. : [Attachment 33898] Support Fullscreen for video element
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090731220227.8BD10343BA74@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33898: Support Fullscreen for video element
https://bugs.webkit.org/attachment.cgi?id=33898&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 15:02:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:02:30 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26742] Support fullscreen
 in MediaPlayer. : [Attachment 33903] Support Fullscreen for video element
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090731220230.257D9343BA7F@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33903: Support Fullscreen for video element
https://bugs.webkit.org/attachment.cgi?id=33903&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=26742
---
 27 files changed, 1464 insertions(+), 13 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 15:09:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:09:34 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27831] Allow custom memory
 allocation control for JavaScriptCore's UString class : [Attachment 33770]
 proposed patch
In-Reply-To: <bug-27831-0@https.bugs.webkit.org/>
References: <bug-27831-0@https.bugs.webkit.org/>
Message-ID: <20090731220934.18FEB343BB59@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 27831: Allow custom memory allocation control for JavaScriptCore's UString
class
https://bugs.webkit.org/show_bug.cgi?id=27831

Attachment 33770: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33770&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Did you run the layout tests?
11027 test cases (99%) succeeded
1 test case (<1%) timed out
5 test cases (<1%) crashed
14 test cases (<1%) had stderr output

From bugzilla-daemon at webkit.org  Fri Jul 31 15:10:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:10:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27830] Allow custom memory
 allocation control for JavaScriptCore's HashEntry class : [Attachment
 33768] proposed patch
In-Reply-To: <bug-27830-0@https.bugs.webkit.org/>
References: <bug-27830-0@https.bugs.webkit.org/>
Message-ID: <20090731221006.86D31343BB6D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 27830: Allow custom memory allocation control for JavaScriptCore's
HashEntry class
https://bugs.webkit.org/show_bug.cgi?id=27830

Attachment 33768: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33768&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
A layout test timed out, and then I stopped running them.  Did you run the
layout tests?

From bugzilla-daemon at webkit.org  Fri Jul 31 15:13:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:13:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27853] Make
 Chrome::requestGeolocationPermissionForFrame() into a synchronous call :
 [Attachment 33841] patch to implement bug fix
In-Reply-To: <bug-27853-0@https.bugs.webkit.org/>
References: <bug-27853-0@https.bugs.webkit.org/>
Message-ID: <20090731221304.68E8B343BBAF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled Greg Bolsinga <bolsinga at apple.com>'s
request for review:
Bug 27853: Make Chrome::requestGeolocationPermissionForFrame() into a
synchronous call
https://bugs.webkit.org/show_bug.cgi?id=27853

Attachment 33841: patch to implement bug fix
https://bugs.webkit.org/attachment.cgi?id=33841&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Clearing review flag.

From bugzilla-daemon at webkit.org  Fri Jul 31 15:16:40 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:16:40 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27827] [Chromium] Functions
 Keys don't work in google spreadsheet. : [Attachment 33871] A quick fix
In-Reply-To: <bug-27827-0@https.bugs.webkit.org/>
References: <bug-27827-0@https.bugs.webkit.org/>
Message-ID: <20090731221640.1BD54343BC23@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Hironori Bono <hbono at chromium.org>'s
request for review:
Bug 27827: [Chromium] Functions Keys don't work in google spreadsheet.
https://bugs.webkit.org/show_bug.cgi?id=27827

Attachment 33871: A quick fix
https://bugs.webkit.org/attachment.cgi?id=33871&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Woh woh.  Please end the copy-pasted insanity in DumpRenderTree.

From bugzilla-daemon at webkit.org  Fri Jul 31 15:29:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:29:17 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27874] Change malloc to
 fastMalloc and free to fastFree in Yarr's RegexInterpreter.cpp :
 [Attachment 33870] proposed patch
In-Reply-To: <bug-27874-0@https.bugs.webkit.org/>
References: <bug-27874-0@https.bugs.webkit.org/>
Message-ID: <20090731222917.96F7C343BDAF@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 27874: Change malloc to fastMalloc and free to fastFree in Yarr's
RegexInterpreter.cpp
https://bugs.webkit.org/show_bug.cgi?id=27874

Attachment 33870: proposed patch
https://bugs.webkit.org/attachment.cgi?id=33870&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 15:42:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:42:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27847] bugzilla-tool
 post-commits trunk..head errors out : [Attachment 33832] First attempt
In-Reply-To: <bug-27847-0@https.bugs.webkit.org/>
References: <bug-27847-0@https.bugs.webkit.org/>
Message-ID: <20090731224219.48E4E343BEEE@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 27847: bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Attachment 33832: First attempt
https://bugs.webkit.org/attachment.cgi?id=33832&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 15:48:31 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:48:31 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27847] bugzilla-tool
 post-commits trunk..head errors out : [Attachment 33904] Revised per review
 comments
In-Reply-To: <bug-27847-0@https.bugs.webkit.org/>
References: <bug-27847-0@https.bugs.webkit.org/>
Message-ID: <20090731224831.CECCF343BFDB@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has granted  review:
Bug 27847: bugzilla-tool post-commits trunk..head errors out
https://bugs.webkit.org/show_bug.cgi?id=27847

Attachment 33904: Revised per review comments
https://bugs.webkit.org/attachment.cgi?id=33904&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
r=me

From bugzilla-daemon at webkit.org  Fri Jul 31 15:59:17 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 15:59:17 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27896] Favicons are still
 loaded when automatic image loading is disabled. : [Attachment 33905] Fix,
 DRT enhancements, and layout test.
In-Reply-To: <bug-27896-0@https.bugs.webkit.org/>
References: <bug-27896-0@https.bugs.webkit.org/>
Message-ID: <20090731225917.99C7E343C1C3@gamma.macosforge.org>

Brady Eidson <beidson at apple.com> has asked  for review:
Bug 27896: Favicons are still loaded when automatic image loading is disabled.
https://bugs.webkit.org/show_bug.cgi?id=27896

Attachment 33905: Fix, DRT enhancements, and layout test.
https://bugs.webkit.org/attachment.cgi?id=33905&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 16:13:44 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 16:13:44 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27896] Favicons are still
 loaded when automatic image loading is disabled. : [Attachment 33905] Fix,
 DRT enhancements, and layout test.
In-Reply-To: <bug-27896-0@https.bugs.webkit.org/>
References: <bug-27896-0@https.bugs.webkit.org/>
Message-ID: <20090731231344.1E63A343C357@gamma.macosforge.org>

John Sullivan <sullivan at apple.com> has granted Brady Eidson
<beidson at apple.com>'s request for review:
Bug 27896: Favicons are still loaded when automatic image loading is disabled.
https://bugs.webkit.org/show_bug.cgi?id=27896

Attachment 33905: Fix, DRT enhancements, and layout test.
https://bugs.webkit.org/attachment.cgi?id=33905&action=review

------- Additional Comments from John Sullivan <sullivan at apple.com>
Maybe add a line that explains why site icons are tied together with images on
the page in this way, such as "People who want to avoid loading images
generally want to avoid loading all images."

From bugzilla-daemon at webkit.org  Fri Jul 31 16:14:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 16:14:25 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27844] SVG Filter and
 linearRGB, sRGB platform support : [Attachment 33796] linearRGB,
 sRGB support for platforms
In-Reply-To: <bug-27844-0@https.bugs.webkit.org/>
References: <bug-27844-0@https.bugs.webkit.org/>
Message-ID: <20090731231425.59CE0343C36D@gamma.macosforge.org>

Oliver Hunt <oliver at apple.com> has granted Dirk Schulze <krit at webkit.org>'s
request for review:
Bug 27844: SVG Filter and linearRGB, sRGB platform support
https://bugs.webkit.org/show_bug.cgi?id=27844

Attachment 33796: linearRGB, sRGB support for platforms
https://bugs.webkit.org/attachment.cgi?id=33796&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
> +void ImageBuffer::transformColorSpace(ImageColorSpace srcColorSpace,
ImageColorSpace dstColorSpace)
> +{
...
> +    if (dstColorSpace == LinearRGB) {
> +	   if (m_linearRgbLUT.isEmpty()) {
...
> +	   lookUpTable = m_linearRgbLUT;
> +    }
> +    if (dstColorSpace == DeviceRGB) {
...
> +    }
should be 'else if' here

> +	   case LinearRGB:
> +			colorSpace =
CGColorSpaceCreateWithName(kCGColorSpaceGenericRGBLinear);
indenting :D

I share eric's concern about the placement of the colour matching logic --
logically it should be in GraphicsContext, but i don't think it's feasible to
do the required logic to ensure that behaviour is correct outside of the
underlying graphics library so this placement seems the only place it can
really go for now.

From bugzilla-daemon at webkit.org  Fri Jul 31 16:25:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 16:25:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27898] Migrate new
 localStorage layout tests over to sessionStorage : [Attachment 33906] Patch
 v1
In-Reply-To: <bug-27898-0@https.bugs.webkit.org/>
References: <bug-27898-0@https.bugs.webkit.org/>
Message-ID: <20090731232557.00AD0343C460@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27898: Migrate new localStorage layout tests over to sessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27898

Attachment 33906: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33906&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 16:55:33 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 16:55:33 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27898] Migrate new
 localStorage layout tests over to sessionStorage : [Attachment 33906] Patch
 v1
In-Reply-To: <bug-27898-0@https.bugs.webkit.org/>
References: <bug-27898-0@https.bugs.webkit.org/>
Message-ID: <20090731235533.B8C76343C74B@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has canceled Jeremy Orlow
<jorlow at chromium.org>'s request for review:
Bug 27898: Migrate new localStorage layout tests over to sessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27898

Attachment 33906: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33906&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 16:55:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 16:55:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27898] Migrate new
 localStorage layout tests over to sessionStorage : [Attachment 33907] Patch
 v1
In-Reply-To: <bug-27898-0@https.bugs.webkit.org/>
References: <bug-27898-0@https.bugs.webkit.org/>
Message-ID: <20090731235553.4FB41343C762@gamma.macosforge.org>

Jeremy Orlow <jorlow at chromium.org> has asked  for review:
Bug 27898: Migrate new localStorage layout tests over to sessionStorage
https://bugs.webkit.org/show_bug.cgi?id=27898

Attachment 33907: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33907&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 16:58:27 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 16:58:27 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 26742] Support fullscreen in
 MediaPlayer. : [Attachment 33903] Support Fullscreen for video element
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090731235827.20CE1343C7AC@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Pierre d'Herbemont
<pdherbemont at apple.com>'s request for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33903: Support Fullscreen for video element
https://bugs.webkit.org/attachment.cgi?id=33903&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
 1622	  IntRect elementRect(0,0,0,0);

There are style problems with that line, but the default constructor would do
better anyway.

Except even better would be to early return like this:

if (!renderer())
    return IntRect();
return
renderer()->view()->frameView()->contentsToScreen(renderer()->absoluteBoundingB
oxRect());

Seems I could make this crash by getting "enterFullScreen or exitFullscreen()"
called on a detached document.	page() goes through frame() if I remember
correctly, and the document looses its frame when detached...

We could use a typedef for PlatformMovie instead of just void*:
 77	void* platformMovie() const;

const?
 146	 IntRect screenRect();

Same problem with page():
virtual bool supportsFullscreen() const { return document() &&
document()->page()->chrome()->client()->supportsFullscreenForNode(this); }

If I had a click handler and detach the document during my handler but dont'
prevent default, it should crash from the enterFullScreen() call:
525525 void MediaControlFullscreenButtonElement::defaultEventHandler(Event*
event)

Extra spacE?
     BOOL _forceDisableAnimation;
 49 
 50 }

Should any of these be @private?  and what's // (retain) supposed to mean?  (I
thought Obj-C 2.0 ... which maybe we don't use in WebCore... did auto-retaining
or something for you? ;)

Seems we should pick one style or the other for .mm files:
55 - (void)setMediaElement:(WebCore::HTMLMediaElement*)mediaElement;
 56 - (WebCore::HTMLMediaElement*)mediaElement;
 57 
 58 - (void)enterFullscreen:(NSScreen *)screen;

What makes this weak pointer safe?
 - (void)setMediaElement:(WebCore::HTMLMediaElement*)mediaElement;
 104 {
 105	 _mediaElement = mediaElement;

Why autorelease here?  Seems unnecessary to add it to the containing
autorelease pool (or if it is, isn't that a bug?)  seems -release is what you
want.

 - (void)clearFadeAnimation
 123 {
 124	 [_fadeAnimation stopAnimation];
 125	 [_fadeAnimation setWindow:nil];
 126	 [_fadeAnimation autorelease];

Sad that this has to be 2-steps:
     [_backgroundFullscreenWindow release];
 141	 _backgroundFullscreenWindow = nil;

Why do we need to self-retain?
 143	 [self autorelease];  // From in exitFullscreen

Style:
 181	 if (newRatio > originalRatio)
 182	 {
 183	     double newWidth = originalRatio * endFrame.size.height;

I would have used static inline functions to split up large functions like:
 170 - (void)enterFullscreen:(NSScreen *)screen;

 249	 [self retain]; // Balanced in windowDidExitFullscreen
the comment ideally should explain "why"  :)

Most parts of WebKit prefer an early-return style:
 282	 if ((self = [super initWithContentRect:contentRect
styleMask:NSBorderlessWindowMask backing:bufferingType defer:flag])) {

I don't remember if AppKit has strong style to the contrary, but it seems
checking !self would make more sense here.

Why not just use normal syntaxt?
 323	     objc_msgSend([self windowController],
_controllerActionOnAnimationEnd);

Style again:
44     if ((self = [super initWithContentRect:contentRect
styleMask:NSBorderlessWindowMask backing:bufferingType defer:flag]))
 45	{

Style:
7     if (![[self window] isVisible]) {
 118	     [[self window] setAlphaValue:0];
 119	 }

I'm surprised we don't do more of the  184 - (void)windowDidLoad
 wiring in a nib?  Or maybe i'm over-remembering the power of nibs here.

Wouldn't Marc Piccerelli yell at you for this? ;)
0 - (void)updateVolume
 281 {
 282	 [self willChangeValueForKey:@"volume"];
 283	 [self didChangeValueForKey:@"volume"];
 284 }

Aren't there NSDateFormatters for this sort of thing?
 359 static NSString *timeToString(double time)

Ideally this patch would be smaller for easier review.	 I can't promise that
I've actually read it as closely as I really should have, but the above is
enough for at least one more round.

From bugzilla-daemon at webkit.org  Fri Jul 31 17:01:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:01:12 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27901] Add an option to
 specify the make binary name and path from the build-webkit script :
 [Attachment 33908] proposed patch.
In-Reply-To: <bug-27901-0@https.bugs.webkit.org/>
References: <bug-27901-0@https.bugs.webkit.org/>
Message-ID: <20090801000112.17AA1343C7D3@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27901: Add an option to specify the make binary name and path from the
build-webkit script
https://bugs.webkit.org/show_bug.cgi?id=27901

Attachment 33908: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33908&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 17:03:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:03:04 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27902] Missing default
 switch for baselineShift case statement : [Attachment 33909] Assert on
 unhandled values for baselineShift
In-Reply-To: <bug-27902-0@https.bugs.webkit.org/>
References: <bug-27902-0@https.bugs.webkit.org/>
Message-ID: <20090801000304.20AE9343C80C@gamma.macosforge.org>

James Hawkins <jhawkins at google.com> has asked  for review:
Bug 27902: Missing default switch for baselineShift case statement
https://bugs.webkit.org/show_bug.cgi?id=27902

Attachment 33909: Assert on unhandled values for baselineShift
https://bugs.webkit.org/attachment.cgi?id=33909&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 17:36:46 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:36:46 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs
 doesn't work with relative paths : [Attachment 33910] Add error checking to
 git ls-files command on close()
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801003646.8CC9C343CA49@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33910: Add error checking to git ls-files command on close()
https://bugs.webkit.org/attachment.cgi?id=33910&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Item 2 of <https://bugs.webkit.org/show_bug.cgi?id=18599#c0>.

* Scripts/resolve-ChangeLogs: Added error checking to close()
after running git ls-files.  Added error checking to all
system() calls by checking for a non-zero WEXITSTATUS($?).
Changed "|| die;" expressions to "or die $!;".
---
 2 files changed, 34 insertions(+), 15 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 17:36:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:36:50 -0700 (PDT)
Subject: =?iso-8859-1?q?_=5Bwebkit-reviews=5D_review_requested=3A_=5BBug_?=
 =?iso-8859-1?q?18599=5D_resolve-ChangeLogs_doesn=27t_work_with_relative_p?=
 =?iso-8859-1?q?aths_=3A_=5BAttachment_33911=5D_=01resolve-ChangeLogs_does?=
 =?iso-8859-1?q?n=27t_work_with_relative_paths?=
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801003650.23941343CA60@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33911: 
resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/attachment.cgi?id=33911&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

* Scripts/resolve-ChangeLogs: Used chdirReturningRelativePath()
and determineVCSRoot() to change directories to the root of the
project before running the command and to provide a path for
removeChangeLogArguments() to make sure any ChangeLog arguments
on the command line are still found.
(canonicalRelativePath): Added.  Returns a canonical path (e.g.,
stripping 'dir/../' from the path) relative to the current
directory.
(removeChangeLogArguments): Added argument which contains a
relative path that must be prepended to any ChangeLog arguments.
Used canonicalRelativePath() and File::Spec->catfile() to
construct a normalized, relative path to each file.
---
 2 files changed, 34 insertions(+), 4 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 17:36:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:36:53 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs
 doesn't work with relative paths : [Attachment 33912] Implement
 VCSUtils::chdirReturningRelativePath()
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801003653.6AC85343CA77@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33912: Implement VCSUtils::chdirReturningRelativePath()
https://bugs.webkit.org/attachment.cgi?id=33912&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Step 2 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

* Scripts/VCSUtils.pm:
(VCSUtils::chdirReturningRelativePath): Moved here from
chdirAndGetDifference() in svn-create-patch.
* Scripts/svn-create-patch: Switched to use
chdirReturningRelativePath() instead of chdirAndGetDifference().
(chdirAndGetDifference): Removed.
---
 3 files changed, 29 insertions(+), 13 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 17:36:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:36:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 18599] resolve-ChangeLogs
 doesn't work with relative paths : [Attachment 33913] Implement
 VCSUtils::determineVCSRoot()
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801003656.94DE3343CA8E@gamma.macosforge.org>

David Kilzer (ddkilzer) <ddkilzer at webkit.org> has asked  for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33913: Implement VCSUtils::determineVCSRoot()
https://bugs.webkit.org/attachment.cgi?id=33913&action=review

------- Additional Comments from David Kilzer (ddkilzer) <ddkilzer at webkit.org>
Reviewed by NOBODY (OOPS!).

Step 1 to fix:
<http://webkit.org/b/18599> resolve-ChangeLogs doesn't work with relative paths

* Scripts/VCSUtils.pm: Removed reference to webkitdirs module.
(VCSUtils::EXPORT): Added &determineVCSRoot.  Realphabetized.
(VCSUtils::determineGitRoot): Added.  Based on code in
commit-log-editor.
(VCSUtils::determineVCSRoot): Implemented using
determineGitRoot() and determineSVNRoot().
* Scripts/commit-log-editor: Replaced use of
topLevelSourceDirectory() with determineVCSRoot().  Resorted
use statements.
(topLevelSourceDirectory): Removed.
---
 3 files changed, 44 insertions(+), 16 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 17:47:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:47:04 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27902] Missing default switch
 for baselineShift case statement : [Attachment 33909] Assert on unhandled
 values for baselineShift
In-Reply-To: <bug-27902-0@https.bugs.webkit.org/>
References: <bug-27902-0@https.bugs.webkit.org/>
Message-ID: <20090801004705.09411343CB75@gamma.macosforge.org>

Darin Adler <darin at apple.com> has denied James Hawkins <jhawkins at google.com>'s
request for review:
Bug 27902: Missing default switch for baselineShift case statement
https://bugs.webkit.org/show_bug.cgi?id=27902

Attachment 33909: Assert on unhandled values for baselineShift
https://bugs.webkit.org/attachment.cgi?id=33909&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
By adding the default case, you are turning off the gcc feature that complains
if an enum value is not handled in a switch statement.

So you are turning off compile-time detection (under gcc) of the very thing you
are trying to catch at runtime.

And compile-time detection is even better, so we don't want it turned off!

Please put the assertion outside the switch statement instead of adding a
default case. Or just drop this while thing, since we'll catch missing enum
values immediately due to gcc's warning as soon as this file is compiled with
gcc.

From bugzilla-daemon at webkit.org  Fri Jul 31 17:52:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:52:18 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26742] Support fullscreen in
 MediaPlayer. : [Attachment 33903] Support Fullscreen for video element
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090801005218.2B66F343CBE3@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has canceled  review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33903: Support Fullscreen for video element
https://bugs.webkit.org/attachment.cgi?id=33903&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 17:52:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:52:20 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 26742] Support fullscreen
 in MediaPlayer. : [Attachment 33914] Support Fullscreen for video element
In-Reply-To: <bug-26742-0@https.bugs.webkit.org/>
References: <bug-26742-0@https.bugs.webkit.org/>
Message-ID: <20090801005220.F229B343CBEA@gamma.macosforge.org>

Pierre d'Herbemont <pdherbemont at apple.com> has asked  for review:
Bug 26742: Support fullscreen in MediaPlayer.
https://bugs.webkit.org/show_bug.cgi?id=26742

Attachment 33914: Support Fullscreen for video element
https://bugs.webkit.org/attachment.cgi?id=33914&action=review

------- Additional Comments from Pierre d'Herbemont <pdherbemont at apple.com>
https://bugs.webkit.org/show_bug.cgi?id=26742
---
 28 files changed, 1484 insertions(+), 14 deletions(-)

From bugzilla-daemon at webkit.org  Fri Jul 31 17:52:35 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 17:52:35 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 23522] Use checked casts for
 render tree : [Attachment 33821] Next step: Includes toRenderTable*
In-Reply-To: <bug-23522-0@https.bugs.webkit.org/>
References: <bug-23522-0@https.bugs.webkit.org/>
Message-ID: <20090801005235.E4E89343CBF2@gamma.macosforge.org>

Darin Adler <darin at apple.com> has canceled  review:
Bug 23522: Use checked casts for render tree
https://bugs.webkit.org/show_bug.cgi?id=23522

Attachment 33821: Next step: Includes toRenderTable*
https://bugs.webkit.org/attachment.cgi?id=33821&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
Clearing review flag since this was landed in
http://trac.webkit.org/changeset/46647

From bugzilla-daemon at webkit.org  Fri Jul 31 18:13:36 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:13:36 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27906] [chromium]
 MessagePort construction fails in worker process : [Attachment 33915]
 Proposed patch
In-Reply-To: <bug-27906-0@https.bugs.webkit.org/>
References: <bug-27906-0@https.bugs.webkit.org/>
Message-ID: <20090801011336.CDBFB343CD82@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27906: [chromium] MessagePort construction fails in worker process
https://bugs.webkit.org/show_bug.cgi?id=27906

Attachment 33915: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33915&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 18:25:39 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:25:39 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 18599] resolve-ChangeLogs
 doesn't work with relative paths : [Attachment 33910] Add error checking to
 git ls-files command on close()
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801012539.ECA1E343CE91@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33910: Add error checking to git ls-files command on close()
https://bugs.webkit.org/attachment.cgi?id=33910&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Perl is so disgusting.

From bugzilla-daemon at webkit.org  Fri Jul 31 18:26:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:26:48 -0700 (PDT)
Subject: =?iso-8859-1?q?_=5Bwebkit-reviews=5D_review_granted=3A_=5BBug_18?=
 =?iso-8859-1?q?599=5D_resolve-ChangeLogs_doesn=27t_work_with_relative_pat?=
 =?iso-8859-1?q?hs_=3A_=5BAttachment_33911=5D_=01resolve-ChangeLogs_doesn?=
 =?iso-8859-1?q?=27t_work_with_relative_paths?=
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801012648.70DE8343CEBB@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33911: 
resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/attachment.cgi?id=33911&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
I don't fully understand, but so long as it works, rs=me. :)

From bugzilla-daemon at webkit.org  Fri Jul 31 18:29:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:29:19 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 18599] resolve-ChangeLogs
 doesn't work with relative paths : [Attachment 33912] Implement
 VCSUtils::chdirReturningRelativePath()
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801012919.DEF19343CEF9@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33912: Implement VCSUtils::chdirReturningRelativePath()
https://bugs.webkit.org/attachment.cgi?id=33912&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
you don't need qw() just (), iirc qw() == (), or?

I've never seen this line actually do anything:
    @EXPORT	 = qw(&chdirReturningRelativePath &determineSVNRoot
&determineVCSRoot &isGit &isGitDirectory &isSVN &isSVNDirectory
&makeFilePathRelative
I think we just have it to comply with perl hear-say. ;)

LGTM.

From bugzilla-daemon at webkit.org  Fri Jul 31 18:30:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:30:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 18599] resolve-ChangeLogs
 doesn't work with relative paths : [Attachment 33913] Implement
 VCSUtils::determineVCSRoot()
In-Reply-To: <bug-18599-0@https.bugs.webkit.org/>
References: <bug-18599-0@https.bugs.webkit.org/>
Message-ID: <20090801013020.D8742343CF31@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted David Kilzer (ddkilzer)
<ddkilzer at webkit.org>'s request for review:
Bug 18599: resolve-ChangeLogs doesn't work with relative paths
https://bugs.webkit.org/show_bug.cgi?id=18599

Attachment 33913: Implement VCSUtils::determineVCSRoot()
https://bugs.webkit.org/attachment.cgi?id=33913&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.  Shame we have the same logic in both our python libraries and our perl
libraries (yes, I know the perl ones came first). :)

From bugzilla-daemon at webkit.org  Fri Jul 31 18:35:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:35:50 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33855] fixed typo
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090801013550.D03C0343CFDA@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has canceled Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33855: fixed typo
https://bugs.webkit.org/attachment.cgi?id=33855&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 18:35:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:35:50 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27865] selectionHasStyle
 needs clean up to fix Bug 27858 : [Attachment 33917] Added the reason this
 patch does not need tests
In-Reply-To: <bug-27865-0@https.bugs.webkit.org/>
References: <bug-27865-0@https.bugs.webkit.org/>
Message-ID: <20090801013550.EE26C343CFDC@gamma.macosforge.org>

Ryosuke Niwa <rniwa at webkit.org> has asked  for review:
Bug 27865: selectionHasStyle needs clean up to fix Bug 27858
https://bugs.webkit.org/show_bug.cgi?id=27865

Attachment 33917: Added the reason this patch does not need tests
https://bugs.webkit.org/attachment.cgi?id=33917&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 18:52:04 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:52:04 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27906] [chromium]
 MessagePort construction fails in worker process : [Attachment 33915]
 Proposed patch
In-Reply-To: <bug-27906-0@https.bugs.webkit.org/>
References: <bug-27906-0@https.bugs.webkit.org/>
Message-ID: <20090801015204.92AFD343D143@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has canceled John Abd-El-Malek
<jam at chromium.org>'s request for review:
Bug 27906: [chromium] MessagePort construction fails in worker process
https://bugs.webkit.org/show_bug.cgi?id=27906

Attachment 33915: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=33915&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 18:52:05 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:52:05 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27906] [chromium]
 MessagePort construction fails in worker process : [Attachment 33918] fix
 style problems
In-Reply-To: <bug-27906-0@https.bugs.webkit.org/>
References: <bug-27906-0@https.bugs.webkit.org/>
Message-ID: <20090801015205.1F75F343D147@gamma.macosforge.org>

John Abd-El-Malek <jam at chromium.org> has asked Dimitri Glazkov (Google)
<dglazkov at chromium.org> for review:
Bug 27906: [chromium] MessagePort construction fails in worker process
https://bugs.webkit.org/show_bug.cgi?id=27906

Attachment 33918: fix style problems
https://bugs.webkit.org/attachment.cgi?id=33918&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 18:56:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 18:56:56 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27908] check-webkit-style
 --git-commit has bugs if you select a commit in the past : [Attachment
 33919] Proposed fix.
In-Reply-To: <bug-27908-0@https.bugs.webkit.org/>
References: <bug-27908-0@https.bugs.webkit.org/>
Message-ID: <20090801015656.AB3D0343D1A7@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27908: check-webkit-style --git-commit has bugs if you select a commit in
the past
https://bugs.webkit.org/show_bug.cgi?id=27908

Attachment 33919: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33919&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 19:22:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 19:22:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27908] check-webkit-style
 --git-commit has bugs if you select a commit in the past : [Attachment
 33919] Proposed fix.
In-Reply-To: <bug-27908-0@https.bugs.webkit.org/>
References: <bug-27908-0@https.bugs.webkit.org/>
Message-ID: <20090801022228.7813D343D3A7@gamma.macosforge.org>

David Levin <levin at chromium.org> has canceled David Levin
<levin at chromium.org>'s request for review:
Bug 27908: check-webkit-style --git-commit has bugs if you select a commit in
the past
https://bugs.webkit.org/show_bug.cgi?id=27908

Attachment 33919: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33919&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Addressed some coding issues mention by Eric.
Fixed the spelling issue and tried to clarify the issue mentioned by Adam.

From bugzilla-daemon at webkit.org  Fri Jul 31 19:22:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 19:22:28 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27908] check-webkit-style
 --git-commit has bugs if you select a commit in the past : [Attachment
 33921] Proposed fix.
In-Reply-To: <bug-27908-0@https.bugs.webkit.org/>
References: <bug-27908-0@https.bugs.webkit.org/>
Message-ID: <20090801022228.92E55343D3A9@gamma.macosforge.org>

David Levin <levin at chromium.org> has asked  for review:
Bug 27908: check-webkit-style --git-commit has bugs if you select a commit in
the past
https://bugs.webkit.org/show_bug.cgi?id=27908

Attachment 33921: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33921&action=review

------- Additional Comments from David Levin <levin at chromium.org>
Addressed some coding issues mention by Eric.
Fixed the spelling issue and tried to clarify the issue mentioned by Adam.

From bugzilla-daemon at webkit.org  Fri Jul 31 19:26:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 19:26:47 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27908] check-webkit-style
 --git-commit has bugs if you select a commit in the past : [Attachment
 33921] Proposed fix.
In-Reply-To: <bug-27908-0@https.bugs.webkit.org/>
References: <bug-27908-0@https.bugs.webkit.org/>
Message-ID: <20090801022647.52F34343D405@gamma.macosforge.org>

Adam Treat <treat at kde.org> has granted David Levin <levin at chromium.org>'s
request for review:
Bug 27908: check-webkit-style --git-commit has bugs if you select a commit in
the past
https://bugs.webkit.org/show_bug.cgi?id=27908

Attachment 33921: Proposed fix.
https://bugs.webkit.org/attachment.cgi?id=33921&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 19:29:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 19:29:37 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27909] WebKit cannot decode
 jpegs that are in CMYK or YCCK format : [Attachment 33922] Fix.
In-Reply-To: <bug-27909-0@https.bugs.webkit.org/>
References: <bug-27909-0@https.bugs.webkit.org/>
Message-ID: <20090801022937.4CCC3343D43E@gamma.macosforge.org>

Nico Weber <thakis at chromium.org> has asked  for review:
Bug 27909: WebKit cannot decode jpegs that are in CMYK or YCCK format
https://bugs.webkit.org/show_bug.cgi?id=27909

Attachment 33922: Fix.
https://bugs.webkit.org/attachment.cgi?id=33922&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 19:37:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 19:37:14 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 26460] Cross-platform ICO
 decoder should return all icons in file as separate frames,
 sorted by decreasing quality : [Attachment 33468] part four
In-Reply-To: <bug-26460-0@https.bugs.webkit.org/>
References: <bug-26460-0@https.bugs.webkit.org/>
Message-ID: <20090801023714.E81DC343D4F2@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Peter Kasting <pkasting at google.com>'s
request for review:
Bug 26460: Cross-platform ICO decoder should return all icons in file as
separate frames, sorted by decreasing quality
https://bugs.webkit.org/show_bug.cgi?id=26460

Attachment 33468: part four
https://bugs.webkit.org/attachment.cgi?id=33468&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Sorry, forgot about this one.  Looks good!

From bugzilla-daemon at webkit.org  Fri Jul 31 19:46:07 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 19:46:07 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27425] adding
 GDOMHTMLElementWrapperFactory[.cpp/.h] : [Attachment 33188] adds
 gdomhtmlelementwrapperfactory with better ChangeLog
In-Reply-To: <bug-27425-0@https.bugs.webkit.org/>
References: <bug-27425-0@https.bugs.webkit.org/>
Message-ID: <20090801024607.8FFD8343D5C1@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27425: adding GDOMHTMLElementWrapperFactory[.cpp/.h]
https://bugs.webkit.org/show_bug.cgi?id=27425

Attachment 33188: adds gdomhtmlelementwrapperfactory with better ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33188&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
We don't generally check-in autogenerated files.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:01:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:01:18 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27424] adding
 ConvertToGCharPrivate.h : [Attachment 33388] addressing review comments,
 decision on "Private" in name still outstanding decision?
In-Reply-To: <bug-27424-0@https.bugs.webkit.org/>
References: <bug-27424-0@https.bugs.webkit.org/>
Message-ID: <20090801030118.C37BD343D73C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27424: adding ConvertToGCharPrivate.h
https://bugs.webkit.org/show_bug.cgi?id=27424

Attachment 33388: addressing review comments, decision on "Private" in name
still outstanding decision?
https://bugs.webkit.org/attachment.cgi?id=33388&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Most of the rest of WebCore follows the "copy rule", which would name these
with "copy" in their name since you're copying the data, or create.

copyAsGchar()
or
createGcharFromString()

I've never seen this:
23 /*
 24  * added under bug #27424 - 19jul2009
 25  */

Seems superfluous, given that we have a version control system.

I'm also not sure what Private_h is for, but that was discussed in the long
comments above (which I admit to not reading, given their length).

So overall these look fine.  I'm not a huge fan of the convert name, but it's
also not a dealbreaker.

Since you're not a committer yet, r- for the unneeded comment.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:02:34 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:02:34 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27429] add gdom.h
 "convenience" header as part of GObject bindings : [Attachment 33058]
 gdom.h developer convenience header
In-Reply-To: <bug-27429-0@https.bugs.webkit.org/>
References: <bug-27429-0@https.bugs.webkit.org/>
Message-ID: <20090801030234.627D9343D754@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27429: add gdom.h "convenience" header as part of GObject bindings
https://bugs.webkit.org/show_bug.cgi?id=27429

Attachment 33058: gdom.h developer convenience header
https://bugs.webkit.org/attachment.cgi?id=33058&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Since I assume this is API for you all, you're welcome to name it however you
like.  It does need a license header though.  r- for the lack of license,
otherwise it looks fine.

You should also fix your name from "lkcl" to your full name.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:05:47 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:05:47 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27430] adds glib / gobject
 bindings to webkit gtk port : [Attachment 33059] adds use of glib / gobject
 bindings to webkitwebframe
In-Reply-To: <bug-27430-0@https.bugs.webkit.org/>
References: <bug-27430-0@https.bugs.webkit.org/>
Message-ID: <20090801030547.70581343D7A4@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27430: adds glib / gobject bindings to webkit gtk port
https://bugs.webkit.org/show_bug.cgi?id=27430

Attachment 33059: adds use of glib / gobject bindings to webkitwebframe
https://bugs.webkit.org/attachment.cgi?id=33059&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
WebCore avoids using superfluous argument names in headers:
 91	gpointer toGDOM(DOMWindow* doc);
 92	gpointer toGDOM(Document* doc);
 93	gpointer toGDOM(XMLHttpRequest* obj);

We don't commit commented out code:
 407	 //WebKitWebFramePrivate* priv = frame->priv;

Name:
 2536 2008-11-30  lkcl	<lkcl at lkcl.net>

Otherwise looks fine.  I mean, I'm not really a gtk expert.  There are style
violations, but I assume this stuff is more supposed to be more gtk style than
webkit style, not sure.

r- for the above nits.	If you were a committer I could just r+ it and let you
fix it as you landed.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:08:12 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:08:12 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27436] gobject bindings need
 access to keyCode on KeyboardEvents! : [Attachment 33193] comments out only
 the 2nd initKeyboardEvent function on LANGUAGE_GOBJECT
In-Reply-To: <bug-27436-0@https.bugs.webkit.org/>
References: <bug-27436-0@https.bugs.webkit.org/>
Message-ID: <20090801030812.779D0343D7DE@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied Luke Kenneth Casson Leighton
<lkcl at lkcl.net>'s request for review:
Bug 27436: gobject bindings need access to keyCode on KeyboardEvents!
https://bugs.webkit.org/show_bug.cgi?id=27436

Attachment 33193: comments out only the 2nd initKeyboardEvent function on
LANGUAGE_GOBJECT
https://bugs.webkit.org/attachment.cgi?id=33193&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
ChangeLog name:
+2008-11-30  lkcl <lkcl at lkcl.net>

Tabs in ChangeLog.

I think Mark wanted a different solution for c bindings in general, but in this
change looks fine overall to me.

r- for the ChangeLog issues.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:16:49 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:16:49 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27910] [Qt] Audio related
 layout tests are failing on the buildbot : [Attachment 33924] Place in
 Skipped list
In-Reply-To: <bug-27910-0@https.bugs.webkit.org/>
References: <bug-27910-0@https.bugs.webkit.org/>
Message-ID: <20090801031649.A15AA343D87B@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27910: [Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910

Attachment 33924: Place in Skipped list
https://bugs.webkit.org/attachment.cgi?id=33924&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 20:19:23 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:19:23 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27912] [Qt] intermittent
 failure of two animation related layout tests on buildbot : [Attachment
 33925] For Skipped
In-Reply-To: <bug-27912-0@https.bugs.webkit.org/>
References: <bug-27912-0@https.bugs.webkit.org/>
Message-ID: <20090801031923.682D9343D8B2@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27912: [Qt] intermittent failure of two animation related layout tests on
buildbot
https://bugs.webkit.org/show_bug.cgi?id=27912

Attachment 33925: For Skipped
https://bugs.webkit.org/attachment.cgi?id=33925&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 20:24:37 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:24:37 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27910] [Qt] Audio related
 layout tests are failing on the buildbot : [Attachment 33924] Place in
 Skipped list
In-Reply-To: <bug-27910-0@https.bugs.webkit.org/>
References: <bug-27910-0@https.bugs.webkit.org/>
Message-ID: <20090801032437.3FB34343D916@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 27910: [Qt] Audio related layout tests are failing on the buildbot
https://bugs.webkit.org/show_bug.cgi?id=27910

Attachment 33924: Place in Skipped list
https://bugs.webkit.org/attachment.cgi?id=33924&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:25:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:25:01 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27912] [Qt] intermittent
 failure of two animation related layout tests on buildbot : [Attachment
 33925] For Skipped
In-Reply-To: <bug-27912-0@https.bugs.webkit.org/>
References: <bug-27912-0@https.bugs.webkit.org/>
Message-ID: <20090801032501.C8524343D92C@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 27912: [Qt] intermittent failure of two animation related layout tests on
buildbot
https://bugs.webkit.org/show_bug.cgi?id=27912

Attachment 33925: For Skipped
https://bugs.webkit.org/attachment.cgi?id=33925&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:25:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:25:02 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27913] [Qt] Printing
 related layout test failure for Skipped list : [Attachment 33926] For
 Skipped
In-Reply-To: <bug-27913-0@https.bugs.webkit.org/>
References: <bug-27913-0@https.bugs.webkit.org/>
Message-ID: <20090801032502.B0BC1343D937@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27913: [Qt] Printing related layout test failure for Skipped list
https://bugs.webkit.org/show_bug.cgi?id=27913

Attachment 33926: For Skipped
https://bugs.webkit.org/attachment.cgi?id=33926&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 20:25:41 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:25:41 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27913] [Qt] Printing related
 layout test failure for Skipped list : [Attachment 33926] For Skipped
In-Reply-To: <bug-27913-0@https.bugs.webkit.org/>
References: <bug-27913-0@https.bugs.webkit.org/>
Message-ID: <20090801032541.998CF343D947@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Adam Treat <treat at kde.org>'s request
for review:
Bug 27913: [Qt] Printing related layout test failure for Skipped list
https://bugs.webkit.org/show_bug.cgi?id=27913

Attachment 33926: For Skipped
https://bugs.webkit.org/attachment.cgi?id=33926&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
LGTM.

From bugzilla-daemon at webkit.org  Fri Jul 31 20:34:16 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:34:16 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27914] [Qt] Final four
 layout tests to add to Skipped with no obvious solutions : [Attachment
 33927] Skipped
In-Reply-To: <bug-27914-0@https.bugs.webkit.org/>
References: <bug-27914-0@https.bugs.webkit.org/>
Message-ID: <20090801033416.DB60F343D9D0@gamma.macosforge.org>

Adam Treat <treat at kde.org> has asked  for review:
Bug 27914: [Qt] Final four layout tests to add to Skipped with no obvious
solutions
https://bugs.webkit.org/show_bug.cgi?id=27914

Attachment 33927: Skipped
https://bugs.webkit.org/attachment.cgi?id=33927&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 20:54:02 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 20:54:02 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27873] [Patch] Fix compile
 error for ambigous call to abs() : [Attachment 33869] compile fix for
 ambigous call to abs()
In-Reply-To: <bug-27873-0@https.bugs.webkit.org/>
References: <bug-27873-0@https.bugs.webkit.org/>
Message-ID: <20090801035402.C9B51343DB46@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 27873: [Patch] Fix compile error for ambigous call to abs()
https://bugs.webkit.org/show_bug.cgi?id=27873

Attachment 33869: compile fix for ambigous call to abs()
https://bugs.webkit.org/attachment.cgi?id=33869&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
Please fix the ChangeLog per Darin's comments.

From bugzilla-daemon at webkit.org  Fri Jul 31 21:03:01 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:03:01 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27915] Add a top level
 build option to control datagrid support : [Attachment 33928] proposed
 patch.
In-Reply-To: <bug-27915-0@https.bugs.webkit.org/>
References: <bug-27915-0@https.bugs.webkit.org/>
Message-ID: <20090801040301.D90EC343DC23@gamma.macosforge.org>

Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 27915: Add a top level build option to control datagrid support
https://bugs.webkit.org/show_bug.cgi?id=27915

Attachment 33928: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33928&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 21:03:53 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:03:53 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27914] [Qt] Final four layout
 tests to add to Skipped with no obvious solutions : [Attachment 33927]
 Skipped
In-Reply-To: <bug-27914-0@https.bugs.webkit.org/>
References: <bug-27914-0@https.bugs.webkit.org/>
Message-ID: <20090801040353.C771B343DC37@gamma.macosforge.org>

Holger Freyther <zecke at selfish.org> has granted Adam Treat <treat at kde.org>'s
request for review:
Bug 27914: [Qt] Final four layout tests to add to Skipped with no obvious
solutions
https://bugs.webkit.org/show_bug.cgi?id=27914

Attachment 33927: Skipped
https://bugs.webkit.org/attachment.cgi?id=33927&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 21:04:51 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:04:51 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 17972] [Curl] Rewrite of curl
 backend to run in event loop : [Attachment 20710] Update patch after
 testing acid2
In-Reply-To: <bug-17972-0@https.bugs.webkit.org/>
References: <bug-17972-0@https.bugs.webkit.org/>
Message-ID: <20090801040451.34D30343DC67@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Eric Seidel <eric at webkit.org>'s
request for review:
Bug 17972: [Curl] Rewrite of curl backend to run in event loop
https://bugs.webkit.org/show_bug.cgi?id=17972

Attachment 20710: Update patch after testing acid2
https://bugs.webkit.org/attachment.cgi?id=20710&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
Thanks for the patch. This patch needs to be updated and made standalone
regardless of port by removing the Gtk related changes, as the Gtk port is now
using libsoup as the sole backend. Other ports may benefit from these
enhancements and would be nice if a port maintainer interested can follow it
through.

Thanks again for the patch!

From bugzilla-daemon at webkit.org  Fri Jul 31 21:08:06 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:08:06 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25889] [GTK] scrollbar policy
 for main frame is not implementable : [Attachment 32028] report scrollbar
 policy
In-Reply-To: <bug-25889-0@https.bugs.webkit.org/>
References: <bug-25889-0@https.bugs.webkit.org/>
Message-ID: <20090801040806.423F3343DCBF@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Gustavo Noronha (kov)
<gns at gnome.org>'s request for review:
Bug 25889: [GTK] scrollbar policy for main frame is not implementable
https://bugs.webkit.org/show_bug.cgi?id=25889

Attachment 32028: report scrollbar policy
https://bugs.webkit.org/attachment.cgi?id=32028&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r- for now as this needs to be updated per Holger's comment.

From bugzilla-daemon at webkit.org  Fri Jul 31 21:21:20 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:21:20 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27915] Add a top level build
 option to control datagrid support : [Attachment 33928] proposed patch.
In-Reply-To: <bug-27915-0@https.bugs.webkit.org/>
References: <bug-27915-0@https.bugs.webkit.org/>
Message-ID: <20090801042120.81CFB343DD91@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has granted Laszlo Gombos
<laszlo.1.gombos at nokia.com>'s request for review:
Bug 27915: Add a top level build option to control datagrid support
https://bugs.webkit.org/show_bug.cgi?id=27915

Attachment 33928: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33928&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
OK.

From bugzilla-daemon at webkit.org  Fri Jul 31 21:27:14 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:27:14 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27851] Fix compiler warning :
 [Attachment 33803] bmpwarning.patch
In-Reply-To: <bug-27851-0@https.bugs.webkit.org/>
References: <bug-27851-0@https.bugs.webkit.org/>
Message-ID: <20090801042714.90CF4343DE1D@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 27851: Fix compiler warning
https://bugs.webkit.org/show_bug.cgi?id=27851

Attachment 33803: bmpwarning.patch
https://bugs.webkit.org/attachment.cgi?id=33803&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
rolled out, marking r-

From bugzilla-daemon at webkit.org  Fri Jul 31 21:28:56 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:28:56 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 24932] WebKit compilation
 support in Solaris 10 with Sun Studio 12 (CC 5.9) : [Attachment 33636]
 [PATCH 05/17] Fix crash misaligned reads on Sparc processors.
In-Reply-To: <bug-24932-0@https.bugs.webkit.org/>
References: <bug-24932-0@https.bugs.webkit.org/>
Message-ID: <20090801042856.AC0EF343DE61@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has denied  review:
Bug 24932: WebKit compilation support in Solaris 10 with Sun Studio 12 (CC 5.9)
https://bugs.webkit.org/show_bug.cgi?id=24932

Attachment 33636: [PATCH 05/17] Fix crash misaligned reads on Sparc processors.
https://bugs.webkit.org/attachment.cgi?id=33636&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
None of these have ChangeLogs, so they're not ready for review.  r-

From bugzilla-daemon at webkit.org  Fri Jul 31 21:30:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 21:30:38 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 25998] [GTK] Build failure:
 conflicting declaration 'typedef XID Cursor' : [Attachment 32719] Revised
 patch with ChangeLog
In-Reply-To: <bug-25998-0@https.bugs.webkit.org/>
References: <bug-25998-0@https.bugs.webkit.org/>
Message-ID: <20090801043038.B6B4E343DEBF@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied David Evans <devans at macports.org>'s
request for review:
Bug 25998: [GTK] Build failure: conflicting declaration 'typedef XID Cursor'
https://bugs.webkit.org/show_bug.cgi?id=25998

Attachment 32719: Revised patch with ChangeLog
https://bugs.webkit.org/attachment.cgi?id=32719&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r- for now per Holger's feedback on the ideal approach on this.

From bugzilla-daemon at webkit.org  Fri Jul 31 22:08:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:08:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27619] [multi-patch] Switch
 wx to using waf for builds : [Attachment 33399] Helper scripts for the waf
 build.
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090801050818.95C0D343E2ED@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: [multi-patch] Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33399: Helper scripts for the waf build.
https://bugs.webkit.org/attachment.cgi?id=33399&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
This patch uses mixed style in variables e.g., wx_foo and wxFoo. Patch looks
sane enough otherwise. rs=me.

From bugzilla-daemon at webkit.org  Fri Jul 31 22:15:18 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:15:18 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27619] [multi-patch] Switch
 wx to using waf for builds : [Attachment 33401] WebKit waf build script for
 wx
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090801051518.B76B1343E3A4@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: [multi-patch] Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33401: WebKit waf build script for wx
https://bugs.webkit.org/attachment.cgi?id=33401&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me.

From bugzilla-daemon at webkit.org  Fri Jul 31 22:17:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:17:42 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27909] WebKit cannot decode
 jpegs that are in CMYK or YCCK format : [Attachment 33922] Fix.
In-Reply-To: <bug-27909-0@https.bugs.webkit.org/>
References: <bug-27909-0@https.bugs.webkit.org/>
Message-ID: <20090801051742.8F729343E3DA@gamma.macosforge.org>

Nico Weber <thakis at chromium.org> has canceled Nico Weber
<thakis at chromium.org>'s request for review:
Bug 27909: WebKit cannot decode jpegs that are in CMYK or YCCK format
https://bugs.webkit.org/show_bug.cgi?id=27909

Attachment 33922: Fix.
https://bugs.webkit.org/attachment.cgi?id=33922&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
Sorry about the email address.

check-webkit-style doesn't find anything, though:

Done processing WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
Total errors found: 0

From bugzilla-daemon at webkit.org  Fri Jul 31 22:17:42 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:17:42 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27909] WebKit cannot decode
 jpegs that are in CMYK or YCCK format : [Attachment 33929] with email
 address
In-Reply-To: <bug-27909-0@https.bugs.webkit.org/>
References: <bug-27909-0@https.bugs.webkit.org/>
Message-ID: <20090801051742.C5E8E343E3DE@gamma.macosforge.org>

Nico Weber <thakis at chromium.org> has asked  for review:
Bug 27909: WebKit cannot decode jpegs that are in CMYK or YCCK format
https://bugs.webkit.org/show_bug.cgi?id=27909

Attachment 33929: with email address
https://bugs.webkit.org/attachment.cgi?id=33929&action=review

------- Additional Comments from Nico Weber <thakis at chromium.org>
Sorry about the email address.

check-webkit-style doesn't find anything, though:

Done processing WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
Total errors found: 0

From bugzilla-daemon at webkit.org  Fri Jul 31 22:26:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:26:19 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27848] [WINCE] allow using
 old GetTickCount implementation of currentTime : [Attachment 33805] same
 patch, updated changelog
In-Reply-To: <bug-27848-0@https.bugs.webkit.org/>
References: <bug-27848-0@https.bugs.webkit.org/>
Message-ID: <20090801052619.66621343E496@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27848: [WINCE] allow using old GetTickCount implementation of currentTime
https://bugs.webkit.org/show_bug.cgi?id=27848

Attachment 33805: same patch, updated changelog
https://bugs.webkit.org/attachment.cgi?id=33805&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 22:26:30 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:26:30 -0700 (PDT)
Subject: [webkit-reviews] review denied: [Bug 27619] [multi-patch] Switch wx
 to using waf for builds : [Attachment 33375] Fix for when running
 DerivedSources.make from a subdir of JSCore
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090801052630.03D10343E4D4@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has denied Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: [multi-patch] Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33375: Fix for when running DerivedSources.make from a subdir of
JSCore
https://bugs.webkit.org/attachment.cgi?id=33375&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
>  docs/bytecode.html: make-bytecode-docs.pl Interpreter.cpp 
> -	perl $^ $@
> +	perl $^ $(JavaScriptCore)/$@

VPATH is already set to the appropriate directories so I don't see why you need
this, and why it needs to apply to Interpreter.cpp only. Can you please attach
the build log or the error you're getting here as well? 

r- for now because of this.

From bugzilla-daemon at webkit.org  Fri Jul 31 22:32:38 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:32:38 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26715] bugzilla-tool should
 automate rollouts : [Attachment 32976] Begone ye tabs!
In-Reply-To: <bug-26715-0@https.bugs.webkit.org/>
References: <bug-26715-0@https.bugs.webkit.org/>
Message-ID: <20090801053238.D8B87343E538@gamma.macosforge.org>

Eric Seidel <eric at webkit.org> has canceled  review:
Bug 26715: bugzilla-tool should automate rollouts
https://bugs.webkit.org/show_bug.cgi?id=26715

Attachment 32976: Begone ye tabs!
https://bugs.webkit.org/attachment.cgi?id=32976&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 22:37:22 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:37:22 -0700 (PDT)
Subject: [webkit-reviews] review granted: [Bug 27619] [multi-patch] Switch
 wx to using waf for builds : [Attachment 33400] JSCore waf build script
In-Reply-To: <bug-27619-0@https.bugs.webkit.org/>
References: <bug-27619-0@https.bugs.webkit.org/>
Message-ID: <20090801053722.1FECA343E5B7@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has granted Kevin Ollivier
<kevino at theolliviers.com>'s request for review:
Bug 27619: [multi-patch] Switch wx to using waf for builds
https://bugs.webkit.org/show_bug.cgi?id=27619

Attachment 33400: JSCore waf build script
https://bugs.webkit.org/attachment.cgi?id=33400&action=review

------- Additional Comments from Jan Alonzo <jmalonzo at gmail.com>
r=me.

From bugzilla-daemon at webkit.org  Fri Jul 31 22:50:19 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 22:50:19 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27917] [WINCE]
 LOAD_WITH_ALTERED_SEARCH_PATH not supported on WINCE : [Attachment 33931]
 Go back to LoadLibrary on WINCE
In-Reply-To: <bug-27917-0@https.bugs.webkit.org/>
References: <bug-27917-0@https.bugs.webkit.org/>
Message-ID: <20090801055020.08514343E69B@gamma.macosforge.org>

Joe Mason <joe.mason at torchmobile.com> has asked  for review:
Bug 27917: [WINCE] LOAD_WITH_ALTERED_SEARCH_PATH not supported on WINCE
https://bugs.webkit.org/show_bug.cgi?id=27917

Attachment 33931: Go back to LoadLibrary on WINCE
https://bugs.webkit.org/attachment.cgi?id=33931&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 23:09:25 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 23:09:25 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27765] [commit+] Added
 project properties as needed by symbian platform : [Attachment 33621] Patch
 for WebCore.pro
In-Reply-To: <bug-27765-0@https.bugs.webkit.org/>
References: <bug-27765-0@https.bugs.webkit.org/>
Message-ID: <20090801060925.CAA95343E813@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27765: [commit+] Added project properties as needed by symbian platform
https://bugs.webkit.org/show_bug.cgi?id=27765

Attachment 33621: Patch for WebCore.pro
https://bugs.webkit.org/attachment.cgi?id=33621&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 23:18:03 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 23:18:03 -0700 (PDT)
Subject: [webkit-reviews] review requested: [Bug 27439] [Gtk] crash when
 closing page from javascript : [Attachment 33933] Patch v1
In-Reply-To: <bug-27439-0@https.bugs.webkit.org/>
References: <bug-27439-0@https.bugs.webkit.org/>
Message-ID: <20090801061803.344A2343E8E6@gamma.macosforge.org>

Jan Alonzo <jmalonzo at gmail.com> has asked  for review:
Bug 27439: [Gtk] crash when closing page from javascript
https://bugs.webkit.org/show_bug.cgi?id=27439

Attachment 33933: Patch v1
https://bugs.webkit.org/attachment.cgi?id=33933&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 23:29:48 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 23:29:48 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27915] [commit+] Add a top
 level build option to control datagrid support : [Attachment 33928]
 proposed patch.
In-Reply-To: <bug-27915-0@https.bugs.webkit.org/>
References: <bug-27915-0@https.bugs.webkit.org/>
Message-ID: <20090801062948.0A3E0343E9AA@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27915: [commit+] Add a top level build option to control datagrid support
https://bugs.webkit.org/show_bug.cgi?id=27915

Attachment 33928: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=33928&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 23:43:28 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 23:43:28 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 26993] [commit+]
 Geolocation::requestPermission() : [Attachment 33659] the patch
In-Reply-To: <bug-26993-0@https.bugs.webkit.org/>
References: <bug-26993-0@https.bugs.webkit.org/>
Message-ID: <20090801064328.38A21343EA99@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 26993: [commit+] Geolocation::requestPermission()
https://bugs.webkit.org/show_bug.cgi?id=26993

Attachment 33659: the patch
https://bugs.webkit.org/attachment.cgi?id=33659&action=review

From bugzilla-daemon at webkit.org  Fri Jul 31 23:56:50 2009
From: bugzilla-daemon at webkit.org (bugzilla-daemon at webkit.org)
Date: Fri, 31 Jul 2009 23:56:50 -0700 (PDT)
Subject: [webkit-reviews] review canceled: [Bug 27757] [commit+]
 update-webkit-auxiliary-libs,
 update-webkit-support-libs cause Perl warnings about functions tmpnam and
 tmpfile : [Attachment 33653] Patch with updated ChangeLog
In-Reply-To: <bug-27757-0@https.bugs.webkit.org/>
References: <bug-27757-0@https.bugs.webkit.org/>
Message-ID: <20090801065650.3D321343EBE2@gamma.macosforge.org>

Adam Barth <abarth at webkit.org> has canceled  review:
Bug 27757: [commit+] update-webkit-auxiliary-libs, update-webkit-support-libs
cause Perl warnings about functions tmpnam and tmpfile
https://bugs.webkit.org/show_bug.cgi?id=27757

Attachment 33653: Patch with updated ChangeLog
https://bugs.webkit.org/attachment.cgi?id=33653&action=review