[webkit-reviews] review requested: [Bug 23607] REGRESSION: Clicking near an contentEditable div will focus the div, even though it shouldn't! : [Attachment 27210] Fix bugs 23605 and 23607
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 30 22:12:58 PST 2009
Eric Seidel <eric at webkit.org> has asked for review:
Bug 23607: REGRESSION: Clicking near an contentEditable div will focus the div,
even though it shouldn't!
https://bugs.webkit.org/show_bug.cgi?id=23607
Attachment 27210: Fix bugs 23605 and 23607
https://bugs.webkit.org/attachment.cgi?id=27210&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
LayoutTests/ChangeLog | 33 +++++
...ick-in-margins-inside-editable-div-expected.txt | 23 ++++
.../click-in-margins-inside-editable-div.html | 13 ++
.../click-outside-editable-div-expected.txt | 17 +++
.../selection/click-outside-editable-div.html | 13 ++
.../selection/contenteditable-click-outside.html | 13 --
.../editing/selection/resources/TEMPLATE.html | 13 ++
.../click-in-margins-inside-editable-div.js | 138 ++++++++++++++++++++
.../resources/click-outside-editable-div.js | 50 +++++++
...contenteditable-click-outside-expected.checksum | 1 -
.../contenteditable-click-outside-expected.png | Bin 21262 -> 0 bytes
.../contenteditable-click-outside-expected.txt | 16 ---
.../selection/select-all-iframe-expected.txt | 4 +-
.../select-from-textfield-outwards-expected.txt | 2 +-
.../contenteditable-click-outside-expected.txt | 12 --
.../selection/select-all-iframe-expected.txt | 56 --------
WebCore/ChangeLog | 28 ++++
WebCore/editing/VisiblePosition.cpp | 4 +-
WebCore/rendering/RenderBlock.cpp | 113 +++++++---------
WebCore/rendering/RenderContainer.cpp | 3 +-
WebCore/rendering/RenderInline.cpp | 1 +
21 files changed, 383 insertions(+), 170 deletions(-)
More information about the webkit-reviews
mailing list