[webkit-reviews] review granted: [Bug 23622] create CFString and NSString objects from WebCore::String without copying the characters : [Attachment 27205] patch -- this time I think it handles threading acceptably
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Jan 30 18:12:36 PST 2009
Mark Rowe (bdash) <mrowe at apple.com> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 23622: create CFString and NSString objects from WebCore::String without
copying the characters
https://bugs.webkit.org/show_bug.cgi?id=23622
Attachment 27205: patch -- this time I think it handles threading acceptably
https://bugs.webkit.org/attachment.cgi?id=27205&action=review
------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
The calls to the system memory allocator should probably use FastMalloc
instead, and the code may be slightly easier to follow if create() and
allocator() were closer in the code.
r=me
More information about the webkit-reviews
mailing list