[webkit-reviews] review requested: [Bug 18343] [GTK] Soup backend must handle upload of multiple files : [Attachment 27182] fixed proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 30 09:07:10 PST 2009


Gustavo Noronha Silva <gns at gnome.org> has asked  for review:
Bug 18343: [GTK] Soup backend must handle upload of multiple files
https://bugs.webkit.org/show_bug.cgi?id=18343

Attachment 27182: fixed proposed patch
https://bugs.webkit.org/attachment.cgi?id=27182&action=review

------- Additional Comments from Gustavo Noronha Silva <gns at gnome.org>
Fxed style issues reported by bdash, and also added error checking for open()
and mmap(). As I said on IRC, I believe we have soup covered since Dan worked
with me to figure out why _set_accumulate(msg, FALSE) wasn't working, and
verified the code in the process.


More information about the webkit-reviews mailing list