[webkit-reviews] review requested: [Bug 23642] [GTK] Drag and drop support : [Attachment 27180] The 'drag' implementation

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 30 06:50:37 PST 2009


Zan Dobersek <zandobersek at gmail.com> has asked	for review:
Bug 23642: [GTK] Drag and drop support
https://bugs.webkit.org/show_bug.cgi?id=23642

Attachment 27180: The 'drag' implementation
https://bugs.webkit.org/attachment.cgi?id=27180&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
This only implements the 'drag' of the 'drag and drop'.

With this, user can now click and drag images, links and text to other
applications. As far as I've tested, the following (properly) works in the
GNOME environment (Ubuntu 8.10):
- dragging a link to desktop (Nautilus) => creates a link,
- dragging an image to desktop => downloads the image,
- dragging links, text or HTML to Pidgin,
- dragging links or text to Firefox's search engine input and navigation input,

- dragging links to Epiphany's navigation input,
- dragging image to OpenOffice's Drawing => copies the image.

Supported targets are text targets, HTML, image targets, uri list targets and
the _NETSCAPE_URL target.

Because of the lack of a proper (drag) data container in the Gtk toolkit, a
small 'drag clipboard' was implemented. It is easily accessible to both WebCore
and WebKit components. The GtkClipboard with GTK_SELECTION_SECONDARY could be
used, but such clipboards seem to be storing only one type of data at time.
Targets, however, can be very different - dragging an image can result in
giving the destination either text, link or image itself.


More information about the webkit-reviews mailing list