[webkit-reviews] review requested: [Bug 23580] Add support for GNU mode RVCT compilation : [Attachment 27179] Revised patch to make it more future proof and readable

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 30 05:23:52 PST 2009


Laszlo Gombos <laszlo.1.gombos at nokia.com> has asked  for review:
Bug 23580: Add support for GNU mode RVCT compilation
https://bugs.webkit.org/show_bug.cgi?id=23580

Attachment 27179: Revised patch to make it more future proof and readable
https://bugs.webkit.org/attachment.cgi?id=27179&action=review

------- Additional Comments from Laszlo Gombos <laszlo.1.gombos at nokia.com>
Moved the COMPILER(RVCT) rules in from of the COMPILER(GCC) definition, so that
when COMPILER(GCC) is defined, we can just check for !COMPILER(RVCT).

Extra comment added to make the code more readable !


More information about the webkit-reviews mailing list