[webkit-reviews] review granted: [Bug 23472] SVG pattern transformation/BoundingBox can cause ugly stroke thickness or text positions : [Attachment 27163] transform the pattern instead of the context

[bugzilla-daemon at webkit.org]

Nikolas Zimmermann <zimmermann at kde.org> has granted Dirk Schulze
<krit at webkit.org>'s request for review:
Bug 23472: SVG pattern transformation/BoundingBox can cause ugly stroke
thickness or text positions
https://bugs.webkit.org/show_bug.cgi?id=23472

Attachment 27163: transform the pattern instead of the context
https://bugs.webkit.org/attachment.cgi?id=27163&action=review

------- Additional Comments from Nikolas Zimmermann <zimmermann at kde.org>
Looks nice, some comments:
> +	   // Pattern space is an abstract space that maps to the default user
space by the transformation matrix 
> +	   // you specify with the userSpaceTransformation parameter.
> +	   PlatformPatternPtr createPlatformPattern(const TransformationMatrix&
userSpaceTransformation) const;

I'd shorten the comment:
> +	   // Pattern space is an abstract space that maps to the default user
space by the transformation 'userSpaceTransformation' 

Just leave out the comment for setPatternSpaceTransform, and make the argument
'const TransformationMatrix&'.
> +	   void setPatternSpaceTransform(TransformationMatrix
patternSpaceTransformation) { m_patternSpaceTransformation =
patternSpaceTransformation; }

r=me with thse fixups.