[webkit-reviews] review granted: [Bug 21794] Middle-click panning should be springloaded while dragging : [Attachment 27160] Middle click panning

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 14:21:14 PST 2009


Adam Roben (aroben) <aroben at apple.com> has granted Loren Segal
<lsegal at soen.ca>'s request for review:
Bug 21794: Middle-click panning should be springloaded while dragging
https://bugs.webkit.org/show_bug.cgi?id=21794

Attachment 27160: Middle click panning
https://bugs.webkit.org/attachment.cgi?id=27160&action=review

------- Additional Comments from Adam Roben (aroben) <aroben at apple.com>
> +#if ENABLE(PAN_SCROLLING)
> +    if (m_panScrollInProgress && !m_panScrollHasScrolled &&
panScrollDirection() != PanScrollNone) {
> +	   m_panScrollHasScrolled = true;
> +    }
> +#endif

We normally leave off braces around single-line ifs. I can fix this up before
landing the patch.

> +    PanScrollDirection panScrollDirection();

I think this can be a const member function. I'll fix that, too.

Looks great!


More information about the webkit-reviews mailing list