[webkit-reviews] review granted: [Bug 23625] Skia platform doesn't render text to a canvas or support clipping to an image buffer : [Attachment 27155] Fix for 23625
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 29 13:08:49 PST 2009
Eric Seidel <eric at webkit.org> has granted Scott Violet <sky at google.com>'s
request for review:
Bug 23625: Skia platform doesn't render text to a canvas or support clipping to
an image buffer
https://bugs.webkit.org/show_bug.cgi?id=23625
Attachment 27155: Fix for 23625
https://bugs.webkit.org/attachment.cgi?id=27155&action=review
------- Additional Comments from Eric Seidel <eric at webkit.org>
WebKit style omits names for arguments in headers when the names do not provide
additional clarity:
Like this:
+ void applyClipFromImage(const WebCore::FloatRect& rect, const SkBitmap&
imageBuffer);
neither rect or imageBuffer should be in the definition.
Otherwise this looks fine. One of us can fix those nits when landing.
More information about the webkit-reviews
mailing list