[webkit-reviews] review denied: [Bug 23477] Support for WCSS extensions : [Attachment 26997] new patch: removed unwanted changes

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 10:11:50 PST 2009

Dave Hyatt <hyatt at apple.com> has denied maheshK <mahesh.kulkarni at nokia.com>'s
request for review:
Bug 23477: Support for WCSS extensions

Attachment 26997: new patch: removed unwanted changes

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
Looks pretty good.  Here are some comments:

Your handling of the display property is not correct.  You can't mutate
overflowX at that time or you won't pick up all cases.	Consider the example of
"display:inherit", where someone inherits a display type of -wap-marquee.  Your
code won't set overflowX in that case.	A better place for that code would be
in adjustRenderStyle in CSSStyleSelector.  That code runs after the style has
been fully determined, so at that time you can ask if the display type is
-wap-marquee and then set overflowX to OMARQUEE.

I know you probably plan to implement them, but for this patch please remove
the CSS properties from CSSPropertyNames.in that aren't being handled yet.

You need to patch CSSComputedStyleDeclaration to handle all of these new
properties, so check that out.

More information about the webkit-reviews mailing list