[webkit-reviews] review granted: [Bug 23618] Templated worker tasks should be more error proof to use : [Attachment 27144] Part 1: Add useful templates to TypeTraits.h

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 23618: Templated worker tasks should be more error proof to use
https://bugs.webkit.org/show_bug.cgi?id=23618

Attachment 27144: Part 1: Add useful templates to TypeTraits.h
https://bugs.webkit.org/attachment.cgi?id=27144&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
+	 * wtf/TypeTraits.h:
+	 (WTF::):

Mistakes made by prepare-ChangeLog such as this one should be corrected
manually. In this case, is is probably best to just remove this line - but
generally, we prefer comments to be per-function or at least per-file.

+    // The following are providing in this file:

This doesn't look like correct English grammar to me.

+    template<typename T> struct IsConvertibleToInteger {
+    private:
+	 typedef char YesType;

If it were a class, you wouldn't need private: at the start.

This is good to land as is, maybe with a small correction to grammar. r=me