[webkit-reviews] review granted: [Bug 23616] Various "template helpers" should be consolidated from isolated files in JavaScriptCore. : [Attachment 27142] Patch.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 29 03:04:27 PST 2009


Alexey Proskuryakov <ap at webkit.org> has granted David Levin
<levin at chromium.org>'s request for review:
Bug 23616: Various "template helpers" should be consolidated from isolated
files in JavaScriptCore.
https://bugs.webkit.org/show_bug.cgi?id=23616

Attachment 27142: Patch.
https://bugs.webkit.org/attachment.cgi?id=27142&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
r=me

IsPod needs a comment explaining that it is far from being accurate - for
example, it doesn't accepts structs and enums.

Also, it may be hard to find out what the APIs implemented by this file are -
e.g. RemovePointer comes late after huge piles of implementation cruft and
debug assertions. Maybe there should be a synopsis at the top.


More information about the webkit-reviews mailing list