[webkit-reviews] review requested: [Bug 23602] add another piece (left out earlier) in platform/graphics/chromium : [Attachment 27125] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jan 28 14:45:07 PST 2009

Jungshik Shin <jshin at chromium.org> has asked Eric Seidel <eric at webkit.org> for
Bug 23602: add another piece (left out earlier) in platform/graphics/chromium

Attachment 27125: patch

------- Additional Comments from Jungshik Shin <jshin at chromium.org>
Recap from ChangeLog (FYI):
	This comes from Chromium patch (http://codereview.chromium.org/17624).

	Add m_disableFontFallback to UniscriberHelper class and set it
	to true when filling up glyph pages for non-BMP code points.
	When it's set true, UniscriberHelper does not do its own font
	fallback. Neither does it do glyph placement. Font fallback
	will be taken care of in the simple script font path and glyph
	placement is not necessary for simple scripts.

	Layout test is missing at the moment due to the lack of freely
	distributable font covering a non-BMP code page. A test page
	is available at http://i18nl10n.com/webkit/nonbmp2.html

As for the layout test, I plan to make a simple TTF with 'ugly' glyphs covering
a small number of non-BMP characters.

More information about the webkit-reviews mailing list